From: Stefan Agner
When using DMA framing error get cleared properly. However, due
to the additional read from the data register, an underflow in
the receive FIFO buffer occurs (the FIFO pointer gets out of
sync).
Clear the FIFO in case an underflow has occurred. Also disable the
receiver
Although I haven't observed this bug in practice, it seems that the
code for handling x_char of LPUART is pretty much identical to that of
i.MX. So the fix found in commit 7e2fb5aa8d81 ("serial: imx: Fix issue
in software flow control"):
serial: imx: Fix issue in software flow control
Drop unnecessary extra parenthesis in the driver.
Signed-off-by: Andrey Smirnov
Cc: Stefan Agner
Cc: Chris Healy
Cc: Cory Tusar
Cc: Lucas Stach
Cc: Greg Kroah-Hartman
Cc: Jiri Slaby
Cc: linux-...@nxp.com
Cc: linux-ser...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
By the time lpuart_shutdown() calls lpuart_stop_tx() UARTCR2_TE and
UARTCR2_TIE (which the latter will clear) are already cleared, so that
function call should effectively be a no-op. Moreso, lpuart_stop_tx()
is expected to be executed with port spinlock held, which the caller
doesn't. Given all
Busy polling on a bit in a register is used in multiple places in the
driver. Move it into a shared function.
Signed-off-by: Andrey Smirnov
Cc: Stefan Agner
Cc: Chris Healy
Cc: Cory Tusar
Cc: Lucas Stach
Cc: Greg Kroah-Hartman
Cc: Jiri Slaby
Cc: linux-...@nxp.com
Cc:
The check for termios->c_cflag & CRTSCTS ensure that if we reach else
branch, CRTSCTS in termios->c_cflag is already going to be
cleard. Doing so explicitly there is not necessary. Drop it.
Signed-off-by: Andrey Smirnov
Cc: Stefan Agner
Cc: Chris Healy
Cc: Cory Tusar
Cc: Lucas Stach
Cc: Greg
While sharing code for Tx interrupt handler between 8 and 32 bit
variant of the peripheral saves a bit of code duplication it also adds
quite a number of lpuart_is_32() checks which makes it harder to
understand. Move shared bits back into corresponding
lpuart*_transmit_buffer functions, split
The check for
uart_circ_empty(xmit) || uart_tx_stopped(>port)
appears in multiple places in the driver. Move it into a helper
function.
Signed-off-by: Andrey Smirnov
Cc: Stefan Agner
Cc: Chris Healy
Cc: Cory Tusar
Cc: Lucas Stach
Cc: Greg Kroah-Hartman
Cc: Jiri Slaby
Cc:
When dealing with 32-bit variant of LPUART IP block appropriate I/O
helpers have to be used to properly deal with endianness
differences. Change all of the offending code to do that.
Fixes: a5fa2660d787 ("tty/serial/fsl_lpuart: Add CONSOLE_POLL support
for lpuart32.")
Signed-off-by: Andrey
Code configure DMA TX path in lpuart_startup(), lpuart32_startup() and
lpuart_resume() is doing exactly the same thing, so move it into a
standalone subroutine.
Signed-off-by: Andrey Smirnov
Cc: Stefan Agner
Cc: Chris Healy
Cc: Cory Tusar
Cc: Lucas Stach
Cc: Greg Kroah-Hartman
Cc: Jiri
Code doing initial DMA RX configuration in lpuart_startup() and
lpuart32_startup() is exactly the same, so move it into a standalone
subroutine.
Signed-off-by: Andrey Smirnov
Cc: Stefan Agner
Cc: Chris Healy
Cc: Cory Tusar
Cc: Lucas Stach
Cc: Greg Kroah-Hartman
Cc: Jiri Slaby
Cc:
Use cpu_relax() instead of barrier() in a tight polling loops to make
them a bit more idiomatic. Should also improve things on ARM64 a bit
since cpu_relax() will expand into "yield" instruction there.
Signed-off-by: Andrey Smirnov
Cc: Stefan Agner
Cc: Chris Healy
Cc: Cory Tusar
Cc: Lucas
Code doing final steps of TX/RX configuration in lpuart32_startup()
and lpuart_resume() is identical, so move it into a standalone
subroutine.
Signed-off-by: Andrey Smirnov
Cc: Stefan Agner
Cc: Chris Healy
Cc: Cory Tusar
Cc: Lucas Stach
Cc: Greg Kroah-Hartman
Cc: Jiri Slaby
Cc:
Last steps of .shutdown() code are identical for lpuart and lpuart32
cases, so move it all into a standalone subroutine.
Signed-off-by: Andrey Smirnov
Cc: Stefan Agner
Cc: Chris Healy
Cc: Cory Tusar
Cc: Lucas Stach
Cc: Greg Kroah-Hartman
Cc: Jiri Slaby
Cc: linux-...@nxp.com
Cc:
Clearing CSTOPB bit if it is set is functionally equivalent to jsut
clearing it unconditionally. Drop unnecessary check.
Signed-off-by: Andrey Smirnov
Cc: Stefan Agner
Cc: Chris Healy
Cc: Cory Tusar
Cc: Lucas Stach
Cc: Greg Kroah-Hartman
Cc: Jiri Slaby
Cc: linux-...@nxp.com
Cc:
It appears that lpuart_rxint, lpuart_txint and lpuart32_rxint were
modelled after identical function found in UART driver for
i.MX. However, while said functions are used as individual IRQ
handlers in i.MX driver (in case of i.MX1), it is not the case for
LPUART. Given that, there's no need for us
Hi!
> >> Abstract
> >>
> >>
> >> The modern servers allows multiple cores to run at range of frequencies
> >> higher than rated range of frequencies. But the power budget of the system
> >> inhibits sustaining these higher frequencies for longer durations.
> >
> > Thermal budget?
>
>
Uart_write_wakeup() will already be called as a part of
lpuart*_transmit_buffer() call, so there doesn't seem to be a reason
to call it again right after.
It also appears that second uart_write_wakeup() might potentially
cause unwanted write wakeup when transmitting an x_char. See commit
Most users of lpuart*_setup_watermark() enable identical set of flags
right after the call, so combine those two action into a subroutine
and make use of it.
Signed-off-by: Andrey Smirnov
Cc: Stefan Agner
Cc: Chris Healy
Cc: Cory Tusar
Cc: Lucas Stach
Cc: Greg Kroah-Hartman
Cc: Jiri Slaby
On 7/30/19 9:21 AM, Peter Zijlstra wrote:
> On Tue, Jul 30, 2019 at 08:41:15AM +0200, Juri Lelli wrote:
>> On 29/07/19 18:49, Peter Zijlstra wrote:
>>> On Fri, Jul 26, 2019 at 09:27:55AM +0100, Dietmar Eggemann wrote:
Remove BUG_ON() in __enqueue_dl_entity() since there is already one in
In a mixed DMA/IRQ use-case (e.g.: DMA for TX, IRQ for RX), interrupt
handler might try to handle Rx/Tx condition it shouldn't. Change the
code to only handle TX/RX event if corresponding path isn't being
handled by DMA.
Signed-off-by: Andrey Smirnov
Cc: Stefan Agner
Cc: Chris Healy
Cc: Cory
On Wed, Jul 31, 2019 at 02:05:23AM -0400, Alex Ghiti wrote:
> On 7/30/19 1:51 AM, Alexandre Ghiti wrote:
> >In order to avoid wasting user address space by using bottom-up mmap
> >allocation scheme, prefer top-down scheme when possible.
> >
> >Before:
> >root@qemuriscv64:~# cat /proc/self/maps
>
Enabling TIE in .startup() callback causes the driver to start (or at
least try) to transmit data before .start_tx() is called. Which, while
harmless (since TIE handler will immediately disable it), is a no-op
and shouldn't really happen. Drop UARTCR2_TIE from list of bits set in
lpuart_startup().
Implement .device_synchronize callback in order to be able to use
dmaengine_terminate_sync() and other primitives relying on said
callback.
Signed-off-by: Andrey Smirnov
Cc: Stefan Agner
Cc: Chris Healy
Cc: Vinod Koul
Cc: linux-...@nxp.com
Cc: dmaeng...@vger.kernel.org
Cc:
On 07/31, Adrian Reber wrote:
>
> Extending clone3() to support CLONE_SET_TID makes it possible restore a
> process using CRIU without accessing /proc/sys/kernel/ns_last_pid and
> race free (as long as the desired PID/TID is available).
I personally like this... but please see the question below.
Everyone,
This series contains various fixes/improvements for ziirave_wdt
driver. Hopefully each commit is self-explanatory.
Feedback is welcome!
Thanks,
Andrey Smirnov
Andrey Smirnov (5):
watchdog: ziirave_wdt: Add missing newline
watchdog: ziirave_wdt: Be verbose about errors in probe()
Add missing newline.
Signed-off-by: Andrey Smirnov
Cc: Chris Healy
Cc: Guenter Roeck
Cc: Rick Ramstetter
Cc: linux-watch...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
drivers/watchdog/ziirave_wdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Reprogramming bootloader on watchdog MCU will result in reported
default timeout value of "0". That in turn will be unnecesarily
rejected by the driver as invalid device (-ENODEV). Simplify probe to
just read stored timeout value, clamp it to an acceptable range and
program the value
Log bootloader/firmware info during probe. This information is
available via sysfs already, but it's really helpful to have this in
kernel log during startup as well.
Signed-off-by: Andrey Smirnov
Cc: Chris Healy
Cc: Guenter Roeck
Cc: Rick Ramstetter
Cc: linux-watch...@vger.kernel.org
Cc:
The driver is quite silent in case of probe failure, which makes it
more difficult to diagnose problem from the kernel log. Add logging to
all of the silent error paths ziirave_wdt_probe() to improve that.
Signed-off-by: Andrey Smirnov
Cc: Chris Healy
Cc: Guenter Roeck
Cc: Rick Ramstetter
Cc:
Add more error logging to ziirave_firm_upload() for diagnostics.
Signed-off-by: Andrey Smirnov
Cc: Chris Healy
Cc: Guenter Roeck
Cc: Rick Ramstetter
Cc: linux-watch...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
drivers/watchdog/ziirave_wdt.c | 8 ++--
1 file changed, 6
On 7/31/19 10:15 AM, Mike Rapoport wrote:
> On Wed, Jul 31, 2019 at 04:41:14PM +0200, Michal Hocko wrote:
>> On Wed 31-07-19 17:21:29, Mike Rapoport wrote:
>>> On Wed, Jul 31, 2019 at 03:00:37PM +0200, Michal Hocko wrote:
I am sorry, but I still do not follow. Who is consuming that node
Hello folks,
do we already have some guide (or at least a list of) useful helpers
that can/should be used for more compact/maintainable code ?
I sometimes learn about those by accident (eg. watching at patches
floating around, comments on patches by other folks, reading existing
driver code,
This patch rewrites the pc87413_wdt driver to use the watchdog subsystem. In
doing so, it also addresses a potential race condition owing from the
swc_base_addr variable being used before being set.
Signed-off-by: Mark Balantzyan
---
drivers/watchdog/Kconfig | 1 +
On Wed, Jul 31, 2019 at 9:06 AM Willem de Bruijn
wrote:
>
> On Wed, Jul 31, 2019 at 8:22 AM Chuhong Yuan wrote:
> >
> > refcount_t is better for reference counters since its
> > implementation can prevent overflows.
> > So convert atomic_t ref counters to refcount_t.
> >
> > Signed-off-by:
Hi Thomas,
Here's a small bunch of fixes from the irqchip department. Nothing
major, just a number of fixes for error paths, a GPCv2 irq_set_type()
fix, and a bunch of /* fall-though */ annotation to keep the build
quiet.
Please pull.
M.
The following changes since commit
On Wed, 2019-07-31 at 19:14 +0200, Pavel Machek wrote:
> On Tue 2019-07-30 22:35:18, Joe Perches wrote:
> > Reserve the pseudo keyword 'fallthrough' for the ability to convert the
> > various case block /* fallthrough */ style comments to appear to be an
> > actual reserved word with the same gcc
The high-level VSC drivers will implement device-specific callbacks.
Signed-off-by: Dexuan Cui
Reviewed-by: Michael Kelley
---
drivers/hv/vmbus_drv.c | 42 ++
include/linux/hyperv.h | 3 +++
2 files changed, 45 insertions(+)
diff --git
This is needed for hibernation, e.g. when we resume the old kernel, we need
to disable the "current" kernel's hypercall page and then resume the old
kernel's.
Signed-off-by: Dexuan Cui
Reviewed-by: Michael Kelley
---
arch/x86/hyperv/hv_init.c | 34 ++
1 file
Hi,
This is the first patchset to enable hibernation when Linux runs on Hyper-V.
A second patchset to enhance the high-level VSC drivers (hv_netvsc,
hv_storvsc, etc.) for hibernation will be posted later. The second patchset
depends on this first patchset, so I hope this pathset can be accepted
Before Linux enters hibernation, it sends the CHANNELMSG_UNLOAD message to
the host so all the offers are gone. After hibernation, Linux needs to
re-negotiate with the host using the same vmbus protocol version (which
was in use before hibernation), and ask the host to re-offer the vmbus
devices.
This is needed for hibernation, e.g. when we resume the old kernel, we need
to disable the "current" kernel's TSC page and then resume the old kernel's.
Signed-off-by: Dexuan Cui
Reviewed-by: Michael Kelley
---
drivers/clocksource/hyperv_timer.c | 25 +
1 file changed,
This is needed when we resume the old kernel from the "current" kernel.
Note: when hv_synic_suspend() and hv_synic_resume() run, all the
non-boot CPUs have been offlined, and interrupts are disabled on CPU0.
Signed-off-by: Dexuan Cui
---
drivers/hv/vmbus_drv.c | 46
When the VM resumes, the host re-sends the offers. We should not add the
offers to the global vmbus_connection.chn_list again.
Added some debug code, in case the host screws up the exact info related to
the offers.
Signed-off-by: Dexuan Cui
---
drivers/hv/channel_mgmt.c | 29
Break out synic enable and disable operations into separate
hv_synic_disable_regs() and hv_synic_enable_regs() functions for use by a
later patch to support hibernation.
There is no functional change except the unnecessary check
"if (sctrl.enable != 1) return -EFAULT;" which is removed, because
On 7/31/19 9:52 AM, Doug Ledford wrote:
>
> I'm not sure this is the best fix for this. However, here is where I
> get to admit that I largely ignored the whole Spectre V1 thing, so I'm
> not sure I completely understand the vulnerability and the limits to
> that. But, looking at the
This patch series introduce changes to huawei-wmi driver that includes:
* Move to platform driver
* Implement WMI management interface
* Add micmute LED support through WMI
* Add battery charging protection support through WMI
* Add fn-lock support through WMI
* Implement driver quirks and
Move from WMI driver to platform driver. This move is necessary since
the driver is no longer a hotkeys driver only. Platform driver makes it
easier for users to access sysfs attributes under (i.e.
/sys/devices/platform/huawei-wmi) compared to wmi driver.
Signed-off-by: Ayman Bagabas
---
Do you
Now that huawei WMI management interface is implemented, micmute LED can
be controlled easily through this interface. Exception is the Matebook X
(2017) which continue to uses ACPI EC method to control the LED. This
model can control the LED through the legacy WMI interface which is not
This patch rewrites the pc87413_wdt driver to use the watchdog subsystem. In
doing so, it also addresses a potential race condition owing from the
swc_base_addr variable being used before being set.
Signed-off-by: Mark Balantzyan
---
drivers/watchdog/Kconfig | 1 +
Add a debugfs interface that can be used to call the WMI management
interface function.
The WMI interface takes a 64 bit integer and returns 256-260 bytes
buffer. This debugfs interface creates two files, one stores a 64 bit
int and the other calls the WMI interface and dumps out the returned
Add sysfs interface to enable the use of battery charging thresholds and
fn-lock support introduced in this series.
Signed-off-by: Ayman Bagabas
---
drivers/platform/x86/huawei-wmi.c | 82 +++
1 file changed, 82 insertions(+)
diff --git
Huawei Matebook laptops come with a WMI management interface that can
control various aspects of the device. This interface is also found on
the old Matebook X released in 2017.
Implement basic functionality of this interface along with supported
command IDs that are implemented in this series.
Introduce quirks and module parameters. 3 quirks are added:
1. Fixes reporting brightness keys twice since it's already handled by
acpi-video.
2. Some models need a short delay when setting battery thresholds to
prevent a race condition when two processes read/write.
3. Matebook X (2017)
Huawei Matebook laptops uses Fn key and toggle to access F1-F12 keys.
Along with that, there is this feature called fn-lock that inverts the
behavior of this Fn key.
Implement the basic functionality of this feature to be used later by
sysfs interface support introduced in this series.
Implement battery charging thresholds functionality to be used with
sysfs interface support that is implemented in this series.
Setting battery charging thresholds can introduce a race condition where
two are trying to read/write values from/to EC memory. Even though a
mutex is used, this doesn't
sl is controlled by user-space, hence leading to a potential
exploitation of the Spectre variant 1 vulnerability.
Fix this by sanitizing sl before using it to index ibp->sl_to_sc.
Notice that given that speculation windows are large, the policy is
to kill the speculation on the first load and
Commit-ID: c1a280b68d4e6b6db4a65aa7865c22d8789ddf09
Gitweb: https://git.kernel.org/tip/c1a280b68d4e6b6db4a65aa7865c22d8789ddf09
Author: Thomas Gleixner
AuthorDate: Fri, 26 Jul 2019 23:19:37 +0200
Committer: Ingo Molnar
CommitDate: Wed, 31 Jul 2019 19:03:34 +0200
sched/preempt: Use
Commit-ID: 01b1d88b09824bea1a75b0bac04dcf50d9893875
Gitweb: https://git.kernel.org/tip/01b1d88b09824bea1a75b0bac04dcf50d9893875
Author: Thomas Gleixner
AuthorDate: Fri, 26 Jul 2019 23:19:38 +0200
Committer: Ingo Molnar
CommitDate: Wed, 31 Jul 2019 19:03:35 +0200
rcu: Use
Commit-ID: 27972765bd0410fc2ef5e86a41de17c71440a2dd
Gitweb: https://git.kernel.org/tip/27972765bd0410fc2ef5e86a41de17c71440a2dd
Author: Thomas Gleixner
AuthorDate: Fri, 26 Jul 2019 23:19:39 +0200
Committer: Ingo Molnar
CommitDate: Wed, 31 Jul 2019 19:03:35 +0200
locking/spinlocks: Use
Commit-ID: 30c937043b2db09ae3408f5534824f9ececdb581
Gitweb: https://git.kernel.org/tip/30c937043b2db09ae3408f5534824f9ececdb581
Author: Thomas Gleixner
AuthorDate: Fri, 26 Jul 2019 23:19:40 +0200
Committer: Ingo Molnar
CommitDate: Wed, 31 Jul 2019 19:03:35 +0200
tracing: Use
Commit-ID: 92616606368ee01f1163fcfc986116c810cd48ba
Gitweb: https://git.kernel.org/tip/92616606368ee01f1163fcfc986116c810cd48ba
Author: Thomas Gleixner
AuthorDate: Fri, 26 Jul 2019 23:19:41 +0200
Committer: Ingo Molnar
CommitDate: Wed, 31 Jul 2019 19:03:35 +0200
kprobes: Use
On Wed, Jul 31, 2019 at 5:22 AM Chuhong Yuan wrote:
> static void cnic_ctx_wr(struct cnic_dev *dev, u32 cid_addr, u32 off, u32 val)
> @@ -494,7 +494,7 @@ int cnic_register_driver(int ulp_type, struct
> cnic_ulp_ops *ulp_ops)
> }
> read_unlock(_dev_lock);
>
> -
On Wed, Jul 31, 2019 at 9:36 AM Guillaume La Roque
wrote:
>
> Adding the devicetree binding documentation for the Amlogic temperature
> sensor found in the Amlogic Meson G12 SoCs.
> the G12A and G12B SoCs are supported.
>
> Signed-off-by: Guillaume La Roque
> ---
>
Commit-ID: 48593975aeee548f25e256c515fd1d1e3fb2cc20
Gitweb: https://git.kernel.org/tip/48593975aeee548f25e256c515fd1d1e3fb2cc20
Author: Thomas Gleixner
AuthorDate: Fri, 26 Jul 2019 23:19:42 +0200
Committer: Ingo Molnar
CommitDate: Wed, 31 Jul 2019 19:03:35 +0200
x86: Use
Hi Andrey,
On Wed, Jul 31, 2019 at 2:53 PM Andrey Smirnov wrote:
>
> Everyone:
>
> This series contains fixes/improvements to LPUART dirver I came up
> with recently as well as fixes picked up from Toradex and NXP Vybrid
> repos.
>
> Feedback is welcome!
>
> Changes since [v1]:
Greg has already
Commit-ID: cb376c26971ff54f25980ec1f0ae2f06d6a69df0
Gitweb: https://git.kernel.org/tip/cb376c26971ff54f25980ec1f0ae2f06d6a69df0
Author: Thomas Gleixner
AuthorDate: Fri, 26 Jul 2019 23:19:43 +0200
Committer: Ingo Molnar
CommitDate: Wed, 31 Jul 2019 19:03:36 +0200
x86/dumpstack:
Hello,
This series fixes unreachable code bug and removes dead code in
is_pure_ops_struct().
Thanks.
Joonwon Kang (2):
randstruct: fix a bug in is_pure_ops_struct()
randstruct: remove dead code in is_pure_ops_struct()
scripts/gcc-plugins/randomize_layout_plugin.c | 11 ---
1 file
Before this, there were false negatives in the case where a struct
contains other structs which contain only function pointers because
of unreachable code in is_pure_ops_struct().
Signed-off-by: Joonwon Kang
---
scripts/gcc-plugins/randomize_layout_plugin.c | 10 +-
1 file changed, 5
On Tue, Jul 30, 2019 at 11:39 PM Andrew Jeffery wrote:
>
> The AST2600 splits out the MDIO bus controller from the MAC into its own
> IP block and rearranges the register layout. Add a new binding to
> describe the new hardware.
>
> Signed-off-by: Andrew Jeffery
>
> ---
> v2:
> * aspeed: Utilise
With commit b5bbe2235361 ("usb: phy: mxs: Disable external charger
detect in mxs_phy_hw_init()") in tree all of the necessary charger
setup is done by the USB PHY driver which covers all of the affected
i.MX6 SoCs.
NOTE: Imx_anatop_init() was also called for i.MX7D, but looking at its
datasheet
Recursive declaration for struct which has member of the same struct
type, for example,
struct foo {
struct foo f;
...
};
is not allowed. So, it is unnecessary to check if a struct has this
kind of member.
Signed-off-by: Joonwon Kang
---
scripts/gcc-plugins/randomize_layout_plugin.c |
Commit-ID: 09c7e8b21d67c3c78ab9701dbc0fb1e9f14a0ba5
Gitweb: https://git.kernel.org/tip/09c7e8b21d67c3c78ab9701dbc0fb1e9f14a0ba5
Author: Thomas Gleixner
AuthorDate: Fri, 26 Jul 2019 23:19:44 +0200
Committer: Ingo Molnar
CommitDate: Wed, 31 Jul 2019 19:03:36 +0200
x86/kvm: Use
Use WMI device UID, AMW0 has a UID of HWMI. WMI0 is the device name
and doesn't have a UID so keep it as it is.
Change module description to reflect the upcoming changes.
Signed-off-by: Ayman Bagabas
---
drivers/platform/x86/huawei-wmi.c | 14 --
1 file changed, 8 insertions(+), 6
On Wed, Jul 31, 2019 at 10:42:51AM -0700, Andrey Smirnov wrote:
> Reprogramming bootloader on watchdog MCU will result in reported
> default timeout value of "0". That in turn will be unnecesarily
unnecessarily
> rejected by the driver as invalid device (-ENODEV). Simplify probe to
> just read
On Wed, Jul 31, 2019 at 10:42:47AM -0700, Andrey Smirnov wrote:
> Everyone,
>
> This series contains various fixes/improvements for ziirave_wdt
> driver. Hopefully each commit is self-explanatory.
>
> Feedback is welcome!
>
> Thanks,
> Andrey Smirnov
>
> Andrey Smirnov (5):
> watchdog:
This function simply returns _regdom_rd . So replace this function
with actual code
Signed-off-by: Hariprasad Kelam
---
v2 - Add patch number
drivers/staging/rtl8723bs/os_dep/wifi_regd.c | 9 +
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git
Inthis file all functions has below common functionality
1.Check flag padapter->bSurpriseRemoved
2.Get sdio_func structure from intf_hdl.
This patch introduces two new APIs
rtw_isadapter_removed,rtw_sdio_get_func which helps to do above common
functionality.
Signed-off-by: Hariprasad Kelam
---
Remove passing pdid as function argument to rtw_sdio_if1_init as it is
not being used
Signed-off-by: Hariprasad Kelam
---
v3 - Add patch number
drivers/staging/rtl8723bs/os_dep/sdio_intf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
On Mon 2019-07-29 21:23:19, Greg Kroah-Hartman wrote:
> From: Dan Williams
>
> commit b70d31d054ee3a6fc1034b9d7fc0ae1e481aa018 upstream.
>
> In preparation for fixing a deadlock between wait_for_bus_probe_idle()
> and the nvdimm_bus_list_mutex arrange for __nd_ioctl() without
>
Hi Stephen,
Thanks for your comments.
On 7/16/2019 4:07 AM, Stephen Boyd wrote:
Quoting Taniya Das (2019-05-14 21:20:39)
@@ -128,6 +144,82 @@ enum {
},
};
+static const struct freq_tbl ftbl_disp_cc_mdss_dp_aux_clk_src[] = {
+ F(1920, P_BI_TCXO, 1, 0, 0),
+ { }
+};
Hello Stephen,
Thanks for your review.
On 7/16/2019 4:13 AM, Stephen Boyd wrote:
Quoting Taniya Das (2019-05-14 21:20:38)
diff --git a/drivers/clk/qcom/Kconfig b/drivers/clk/qcom/Kconfig
index 18bdf34..0de080f 100644
--- a/drivers/clk/qcom/Kconfig
+++ b/drivers/clk/qcom/Kconfig
@@ -15,6 +15,7
Remove function argument "padapter" in rtl8723bs_init_recv_priv function
as its not being used
Signed-off-by: Hariprasad Kelam
---
v4 - Add patch number
drivers/staging/rtl8723bs/hal/rtl8723bs_recv.c | 4 ++--
drivers/staging/rtl8723bs/include/recv_osdep.h | 2 +-
Remove below unused defines RTW_CH_MAX_2G_CHANNEL rtw_a_rates
RTW_A_RATES_NUM RTW_5G_CHANNELS_NUM
Signed-off-by: Hariprasad Kelam
---
v2 - Add patch number
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 5 -
1 file changed, 5 deletions(-)
diff --git
On Wed, 2019-07-31 at 12:09 -0400, Qian Cai wrote:
> On Wed, 2019-07-31 at 14:34 +0900, Minchan Kim wrote:
> > On Tue, Jul 30, 2019 at 12:25:28PM -0400, Qian Cai wrote:
> > > OOM workloads with swapping is unable to recover with linux-next since
> > > next-
> > > 20190729 due to the commit "mm:
Remove below defines WEXT_CSCAN_AMOUNT WEXT_CSCAN_BUF_LEN
WEXT_CSCAN_NPROBE_SECTION
Signed-off-by: Hariprasad Kelam
---
v2 - Add patch number
drivers/staging/rtl8723bs/os_dep/ioctl_linux.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_linux.c
Hi!
> This patch implements the fix suggested by Mika in his statement above.
> @@ -12,6 +12,7 @@
> #include
> #include
> #include
> +#include
>
> #include "serial_mctrl_gpio.h"
>
> @@ -115,6 +116,19 @@ struct mctrl_gpios *mctrl_gpio_init_noauto(struct device
> *dev, unsigned int
init_addba_retry_timer does not use padapter, so only keep psta
Signed-off-by: Hariprasad Kelam
---
v2 - Add patch number
drivers/staging/rtl8723bs/core/rtw_sta_mgt.c | 2 +-
drivers/staging/rtl8723bs/include/rtw_mlme_ext.h | 2 +-
drivers/staging/rtl8723bs/os_dep/mlme_linux.c| 2 +-
3
Remove unneeded extern variable "extern unsigned char WFD_OUI"
Signed-off-by: Hariprasad Kelam
---
v2 - Add patch number
drivers/staging/rtl8723bs/core/rtw_ap.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_ap.c
b/drivers/staging/rtl8723bs/core/rtw_ap.c
Hi Guenter, all,
It's alright if you still don't wish to review my patch on alim1535_wdt,
but my employer and I, using our race condition analysis tool, detected it
to contain a race condition warning. I believe any possible issues could
be resolved if it were rewritten to use the watchdog
htpriv.sgi_* variables are of type u8 ,instead of storing them in local
variables ,its better to read value directly from structure.
Signed-off-by: Hariprasad Kelam
---
v2 - Add patch number
drivers/staging/rtl8723bs/core/rtw_xmit.c | 11 ---
1 file changed, 4 insertions(+), 7
recordmcount presents unnecessary challenges to reviewers:
It pretends to wrap access to the ELF file in
uread/uwrite/ulseek functions which aren't related
the way you might think (i.e. not the way read, write,
and lseek are releated to each other).
It
uread() is only used to initialize the ELF file's pseudo
private-memory mapping while uwrite() and ulseek() work within
the pseudo-mapping and extend it as necessary. Thus it is not
a complementary function to uwrite() and ulseek(). It also makes
no sense to do cleanups inside uread() when its
The strcmp is unnecessary since .text is already accepted as a
prefix in the strncmp().
Signed-off-by: Matt Helsley
---
scripts/recordmcount.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/scripts/recordmcount.c b/scripts/recordmcount.c
index 8387a9bc064a..ebe98c39f3cd
Recordmcount uses setjmp/longjmp to manage control flow as
it reads and then writes the ELF file. This unusual control
flow is hard to follow and check in addition to being unlike
kernel coding style.
So we rewrite these paths to use regular return values to
indicate error/success. When an error
Fix up the whitespace irregularity in the ELF switch
blocks.
Swapping the initial value of gpfx allows us to
simplify all but one of the one-line switch cases even
further.
Signed-off-by: Matt Helsley
---
scripts/recordmcount.c | 47 ++
1 file changed,
uwrite() works within the pseudo-mapping and extends it as necessary
without needing the file descriptor (fd) parameter passed to it.
Similarly, ulseek() doesn't need its fd parameter. These parameters
were only added because the functions bear a conceptual resemblance
to write() and lseek().
Redundant cleanup calls were introduced when transitioning from
the old error/success handling via setjmp/longjmp -- the longjmp
ensured the cleanup() call only happened once but replacing
the success_file()/fail_file() calls with cleanup() meant that
multiple cleanup() calls can happen as we
cleanup() mostly frees/unmaps the malloc'd/privately-mapped
copy of the ELF file recordmcount is working on, which is
set up in mmap_file(). It also deals with positioning within
the pseduo prive-mapping of the file and appending to the ELF
file.
Split into two steps:
mmap_cleanup() for
The uwrite() and ulseek() functions are formatted inconsistently
with the rest of the file and the kernel overall. While we're
making other changes here let's fix this.
Signed-off-by: Matt Helsley
---
scripts/recordmcount.c | 21 +++--
scripts/recordmcount.h | 13 ++---
801 - 900 of 1297 matches
Mail list logo
