Re: [PATCH v2] coresight: tmc-etr: Fix perf_data check.

2019-08-14 Thread Yabin Cui
> Did you actually see the check fail or is this a theoretical thing? > I'm really perplex here has I have tested this scenario many times > without issues. > I have seen this warning in dmesg output, that's how I find the problem. > In CPU wide scenarios each perf event (one per CPU) is

Re: [RFC PATCH 2/2] mm/gup: introduce vaddr_pin_pages_remote()

2019-08-14 Thread Ira Weiny
On Tue, Aug 13, 2019 at 05:56:31PM -0700, John Hubbard wrote: > On 8/13/19 5:51 PM, John Hubbard wrote: > > On 8/13/19 2:08 PM, Ira Weiny wrote: > >> On Mon, Aug 12, 2019 at 05:07:32PM -0700, John Hubbard wrote: > >>> On 8/12/19 4:49 PM, Ira Weiny wrote: > On Sun, Aug 11, 2019 at 06:50:44PM

Re: [PATCH 2/2] of/platform: Disable generic device linking code for PowerPC

2019-08-14 Thread Rob Herring
On Tue, Aug 6, 2019 at 4:04 PM Saravana Kannan wrote: > > On Tue, Aug 6, 2019 at 2:27 PM Rob Herring wrote: > > > > On Tue, Aug 6, 2019 at 1:27 PM Saravana Kannan wrote: > > > > > > PowerPC platforms don't use the generic of/platform code to populate the > > > devices from DT. > > > > Yes, they

[PATCH] MAINTAINERS, x86/CPU: Tony Luck will maintain asm/intel-family.h

2019-08-14 Thread Tony Luck
There are a few different subsystems in the kernel that depend on model specific behaviour (perf, EDAC, power, ...). Easier for just one person to have the task to get new model numbers included instead of having these groups trip over each other to do it. Signed-off-by: Tony Luck ---

RE: [PATCH] selftests: net: tcp_fastopen_backup_key.sh: fix shellcheck issue

2019-08-14 Thread Tim.Bird
> -Original Message- > From: Anders Roxell > > When running tcp_fastopen_backup_key.sh the following issue was seen in > a busybox environment. > ./tcp_fastopen_backup_key.sh: line 33: [: -ne: unary operator expected > > Shellcheck showed the following issue. > $ shellcheck

Re: [PATCH net-next v2 6/9] net: macsec: hardware offloading infrastructure

2019-08-14 Thread Florian Fainelli
On 8/13/19 9:28 AM, Andrew Lunn wrote: >> 1) With current implementation it's impossible to install SW macsec engine >> onto >> the device which supports HW offload. That could be a strong limitation in >> cases when user sees HW macsec offload is broken or work differently, and >> he/she >>

Re: [PATCH 0/2] tools/memory-model: Update comment of jugdelitmus.sh

2019-08-14 Thread Paul E. McKenney
On Thu, Aug 15, 2019 at 12:11:36AM +0900, Akira Yokosawa wrote: > Hi Paul, > > I see some inconsistency between the header comment of judgelitmus.sh > and the updated script. > > This patch set updates the header. It is relative to current lkmm-dev > of -rcu. > > Patch 1/2 corresponds to

Re: [PATCH 5.2 000/144] 5.2.9-stable review

2019-08-14 Thread kernelci.org bot
stable-rc/linux-5.2.y boot: 134 boots: 1 failed, 119 passed with 12 offline, 2 untried/unknown (v5.2.8-145-g2440e485aeda) Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-5.2.y/kernel/v5.2.8-145-g2440e485aeda/ Full Build Summary:

Re: [PATCH 04/22] media: Move v4l2_fwnode_parse_link from v4l2 to driver base

2019-08-14 Thread Russell King - ARM Linux admin
On Wed, Aug 14, 2019 at 04:00:30PM -0700, Steve Longerbeam wrote: > > > On 8/14/19 3:04 PM, Russell King - ARM Linux admin wrote: > > On Wed, Aug 14, 2019 at 12:04:41PM -0700, Steve Longerbeam wrote: > > > > > > On 8/14/19 3:30 AM, Russell King - ARM Linux admin wrote: > > > > On Tue, Aug 06,

Re: [PATCH net-next v2 5/9] net: phy: add MACsec ops in phy_device

2019-08-14 Thread Florian Fainelli
On 8/8/19 7:05 AM, Antoine Tenart wrote: > This patch adds a reference to MACsec ops in the phy_device, to allow > PHYs to support offloading MACsec operations. The phydev lock will be > held while calling those helpers. > > Signed-off-by: Antoine Tenart > --- > include/linux/phy.h | 10

Re: [Linux-kernel-mentees] [PATCH v2 1/3] PCI: sysfs: Define device attributes with DEVICE_ATTR*()

2019-08-14 Thread Kelsey Skunberg
On Wed, Aug 14, 2019 at 09:52:20AM +0200, Greg KH wrote: > On Tue, Aug 13, 2019 at 02:45:11PM -0600, Kelsey Skunberg wrote: > > Defining device attributes should be done through the helper > > DEVICE_ATTR*(_name, _mode, _show, _store). Change all instances using > > __ATTR*() to now use

Re: [PATCHv2] mm/migrate: clean up useless code in migrate_vma_collect_pmd()

2019-08-14 Thread Ralph Campbell
On 8/7/19 1:41 AM, Pingfan Liu wrote: Clean up useless 'pfn' variable. Signed-off-by: Pingfan Liu Cc: "Jérôme Glisse" Cc: Andrew Morton Cc: Mel Gorman Cc: Jan Kara Cc: "Kirill A. Shutemov" Cc: Michal Hocko Cc: Mike Kravetz Cc: Andrea Arcangeli Cc: Matthew Wilcox To:

Re: [PATCH] thermal: armada: Fix -Wshift-negative-value

2019-08-14 Thread Daniel Lezcano
On 15/08/2019 00:12, Nick Desaulniers wrote: > On Tue, Aug 13, 2019 at 10:28 AM 'Nathan Huckleberry' via Clang Built > Linux wrote: >> >> Following up to see if this patch is going to be accepted. > > Miquel is listed as the maintainer of this file in MAINTAINERS. > Miquel, can you please pick

Re: [RFC 4/5] media: i2c: ov5670: Report the camera location

2019-08-14 Thread Laurent Pinchart
Hi Jacopo, Thank you for the patch. On Wed, Aug 14, 2019 at 10:28:14PM +0200, Jacopo Mondi wrote: > The camera location is retrieved from the firmware interface parsing > the "location" device property and reported through the read-only > V4L2_CID_LOCATION control. > > Signed-off-by: Jacopo

Re: [PATCH v2] coresight: tmc-etr: Fix perf_data check.

2019-08-14 Thread Mathieu Poirier
Hi Yabin, On Mon, 12 Aug 2019 at 13:03, Yabin Cui wrote: > > When tracing etm data of multiple threads on multiple cpus through > perf interface, each cpu has a unique etr_perf_buffer while sharing > the same etr device. There is no guarantee that the last cpu starts > etm tracing also stops

Re: [PATCH 04/22] media: Move v4l2_fwnode_parse_link from v4l2 to driver base

2019-08-14 Thread Steve Longerbeam
On 8/14/19 3:04 PM, Russell King - ARM Linux admin wrote: On Wed, Aug 14, 2019 at 12:04:41PM -0700, Steve Longerbeam wrote: On 8/14/19 3:30 AM, Russell King - ARM Linux admin wrote: On Tue, Aug 06, 2019 at 09:53:41AM -0700, Steve Longerbeam wrote: The full patchset doesn't seem to be up

Re: [PATCH v4 2/2] rcuperf: Add kfree_rcu() performance Tests

2019-08-14 Thread Paul E. McKenney
On Wed, Aug 14, 2019 at 12:04:11PM -0400, Joel Fernandes (Google) wrote: > This test runs kfree_rcu in a loop to measure performance of the new > kfree_rcu batching functionality. kfree_rcu(). > The following table shows results when booting with arguments: > rcuperf.kfree_loops=20

Re: [PATCH 4.14 00/69] 4.14.139-stable review

2019-08-14 Thread kernelci.org bot
stable-rc/linux-4.14.y boot: 132 boots: 2 failed, 117 passed with 12 offline, 1 untried/unknown (v4.14.138-70-g736c2f07319a) Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-4.14.y/kernel/v4.14.138-70-g736c2f07319a/ Full Build Summary:

Re: [RFC 3/5] media: v4l2-ctrls: Add support for V4L2_CID_LOCATION

2019-08-14 Thread Laurent Pinchart
Hi Jacopo, Thank you for the patch. On Wed, Aug 14, 2019 at 10:28:13PM +0200, Jacopo Mondi wrote: > Add support for the newly defined V4L2_CID_LOCATION read-only control > used to report the camera device mounting position. > > Signed-off-by: Jacopo Mondi > --- >

Re: [patch] mm, page_alloc: move_freepages should not examine struct page of reserved memory

2019-08-14 Thread Andrew Morton
On Tue, 13 Aug 2019 16:31:35 -0700 (PDT) David Rientjes wrote: > > > Move the debug checks to after verifying PageBuddy is true. This isolates > > > the scope of the checks to only be for buddy pages which are on the zone's > > > freelist which move_freepages_block() is operating on. In this

Re: [RFC 2/5] media: v4l2-ctrl: Document V4L2_CID_LOCATION

2019-08-14 Thread Laurent Pinchart
Hi Jacopo, Thank you for the patch. On Wed, Aug 14, 2019 at 10:28:12PM +0200, Jacopo Mondi wrote: > Add documentation for the V4L2_CID_LOCATION camera control. The newly > added read-only control reports the camera device mounting position. > > Signed-off-by: Jacopo Mondi > --- >

Re: [PATCH 1/2] KEYS: Replace uid/gid/perm permissions checking with an ACL

2019-08-14 Thread Eric Biggers
On Tue, Aug 06, 2019 at 07:58:14PM -0700, Eric Biggers wrote: > On Tue, Jul 30, 2019 at 06:16:14PM -0700, Eric Biggers wrote: > > On Mon, Jul 29, 2019 at 08:49:56PM -0700, Eric Biggers wrote: > > > Hi David, > > > > > > On Tue, Jul 09, 2019 at 06:16:01PM -0700, Eric Biggers wrote: > > > > On Thu,

Re: [RFC 1/5] media: dt-bindings: Document 'location' property

2019-08-14 Thread Laurent Pinchart
Hi Jacopo, Thank you for the patch. On Wed, Aug 14, 2019 at 10:28:11PM +0200, Jacopo Mondi wrote: > Add the 'location' device property, used to specify the camera device > mounting position. The property is particularly meaningful for mobile > devices with a well defined usage orientation. > >

Re: [GIT PULL] afs: Fixes

2019-08-14 Thread pr-tracker-bot
The pull request you sent on Wed, 14 Aug 2019 15:18:40 +0100: > git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git > tags/afs-fixes-20190814 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/e22a97a2a85d2a0bdfb134cbbc7ff856ae67edba Thank you! --

Re: [GIT PULL] Wimplicit-fallthrough patches for 5.3-rc5

2019-08-14 Thread pr-tracker-bot
The pull request you sent on Wed, 14 Aug 2019 13:49:01 -0500: > git://git.kernel.org/pub/scm/linux/kernel/git/gustavoars/linux.git > tags/Wimplicit-fallthrough-5.3-rc5 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/41de59634046b19cd53a1983594a95135c656997 Thank you!

Re: [PATCH 1/4] mailbox: arm_mhuv2: add device tree binding documentation

2019-08-14 Thread tushar.khandel...@arm.com
On 14/08/2019 17:51, Sudeep Holla wrote: On Wed, Aug 14, 2019 at 09:52:25AM -0500, Jassi Brar wrote: On Wed, Aug 14, 2019 at 5:05 AM Sudeep Holla wrote: On Tue, Aug 13, 2019 at 11:36:56AM -0500, Jassi Brar wrote: [...] As mentioned in the response to your initial comment, the driver

Re: [PATCH v4 2/2] RISC-V: Implement sparsemem

2019-08-14 Thread Logan Gunthorpe
Hey, On 2019-08-14 7:35 a.m., Greentime Hu wrote: > How about this fix? Not sure if it is good for everyone. I applied your fix to the patch and it seems ok. But it doesn't seem to work on a recent version of the kernel. Have you got it working on v5.3? It seems the following patch breaks

Re: [PATCH 1/4] mailbox: arm_mhuv2: add device tree binding documentation

2019-08-14 Thread tushar.khandel...@arm.com
On 13/08/2019 17:36, Jassi Brar wrote: On Fri, Aug 2, 2019 at 5:41 AM Morten Borup Petersen wrote: On 7/31/19 9:31 AM, Jassi Brar wrote: On Sun, Jul 28, 2019 at 4:28 PM Morten Borup Petersen wrote: On 7/25/19 7:49 AM, Jassi Brar wrote: On Sun, Jul 21, 2019 at 4:58 PM Jassi Brar

Re: [PATCH 12/16] arm64: prefer __section from compiler_attributes.h

2019-08-14 Thread Nick Desaulniers
On Tue, Aug 13, 2019 at 10:08 AM Will Deacon wrote: > > On Tue, Aug 13, 2019 at 02:36:06PM +0200, Miguel Ojeda wrote: > > On Tue, Aug 13, 2019 at 10:27 AM Will Deacon wrote: > > > On Mon, Aug 12, 2019 at 02:50:45PM -0700, Nick Desaulniers wrote: > > > > GCC unescapes escaped string section names

Re: [PATCH v2 bpf-next] mm: mmap: increase sockets maximum memory size pgoff for 32bits

2019-08-14 Thread Andrew Morton
On Wed, 14 Aug 2019 18:09:36 +0300 Ivan Khoronzhuk wrote: > On Mon, Aug 12, 2019 at 02:19:24PM -0700, Andrew Morton wrote: > > Hi, Andrew > > >On Mon, 12 Aug 2019 15:43:26 +0300 Ivan Khoronzhuk > > wrote: > > > >> The AF_XDP sockets umem mapping interface uses XDP_UMEM_PGOFF_FILL_RING > >>

Re: [PATCH v2 2/2] riscv: Make __fstate_clean() work correctly.

2019-08-14 Thread Andreas Schwab
On Aug 14 2019, Palmer Dabbelt wrote: > On Wed, 14 Aug 2019 13:32:50 PDT (-0700), Paul Walmsley wrote: >> On Wed, 14 Aug 2019, Vincent Chen wrote: >> >>> Make the __fstate_clean() function correctly set the >>> state of sstatus.FS in pt_regs to SR_FS_CLEAN. >>> >>> Fixes: 7db91e5 ("RISC-V: Task

Re: [PATCH] ARM: vf610-zii-cfu1: Add node for switch watchdog

2019-08-14 Thread Chris Healy
Tested-by: Chris Healy On Wed, Aug 14, 2019 at 12:35 PM Andrey Smirnov wrote: > > Add I2C child node for switch watchdog present on CFU1. > > Signed-off-by: Andrey Smirnov > Signed-off-by: Cory Tusar > Cc: Shawn Guo > Cc: Chris Healy > Cc: Fabio Estevam > Cc:

Re: [PATCH] thermal: armada: Fix -Wshift-negative-value

2019-08-14 Thread Nick Desaulniers
On Tue, Aug 13, 2019 at 10:28 AM 'Nathan Huckleberry' via Clang Built Linux wrote: > > Following up to see if this patch is going to be accepted. Miquel is listed as the maintainer of this file in MAINTAINERS. Miquel, can you please pick this up? Otherwise Zhang, Eduardo, and Daniel are listed

Re: [PATCH v2 4/5] mm/memory_hotplug: Make sure the pfn is aligned to the order when onlining

2019-08-14 Thread Andrew Morton
On Wed, 14 Aug 2019 23:47:24 +0200 David Hildenbrand wrote: > >> --- a/mm/memory_hotplug.c > >> +++ b/mm/memory_hotplug.c > >> @@ -646,6 +646,9 @@ static int online_pages_range(unsigned long start_pfn, > >> unsigned long nr_pages, > >> */ > >>for (pfn = start_pfn; pfn < end_pfn; pfn +=

Re: [PATCH RFC tip/core/rcu 14/14] rcu/nohz: Make multi_cpu_stop() enable tick on all online CPUs

2019-08-14 Thread Paul E. McKenney
On Wed, Aug 14, 2019 at 01:55:46PM -0400, Joel Fernandes wrote: > On Tue, Aug 13, 2019 at 07:48:09AM -0700, Paul E. McKenney wrote: > > On Tue, Aug 13, 2019 at 02:30:19PM +0200, Frederic Weisbecker wrote: > > > On Mon, Aug 12, 2019 at 04:23:16PM -0700, Paul E. McKenney wrote: > > > > On Mon, Aug

Re: [PATCH] Input: cros_ec_keyb: Add back missing mask for event_type

2019-08-14 Thread Dmitry Torokhov
On Tue, Aug 13, 2019 at 05:47:22PM +0800, Nicolas Boichat wrote: > On Tue, Aug 13, 2019 at 5:38 PM Fei Shao wrote: > > > > In the previous patch we didn't mask out event_type in case statement, > > so switches are always picked instead of buttons, which results in > > ChromeOS devices misbehaving

Re: [PATCH 04/22] media: Move v4l2_fwnode_parse_link from v4l2 to driver base

2019-08-14 Thread Russell King - ARM Linux admin
On Wed, Aug 14, 2019 at 12:04:41PM -0700, Steve Longerbeam wrote: > > > On 8/14/19 3:30 AM, Russell King - ARM Linux admin wrote: > > On Tue, Aug 06, 2019 at 09:53:41AM -0700, Steve Longerbeam wrote: > > > The full patchset doesn't seem to be up yet, but see [1] for the cover > > > letter. > >

Re: [PATCH 2/2] mm: memcontrol: flush percpu slab vmstats on kmem offlining

2019-08-14 Thread Roman Gushchin
On Wed, Aug 14, 2019 at 01:32:42PM +0200, Michal Hocko wrote: > On Mon 12-08-19 15:29:11, Roman Gushchin wrote: > > I've noticed that the "slab" value in memory.stat is sometimes 0, > > even if some children memory cgroups have a non-zero "slab" value. > > The following investigation showed that

Re: [RFC PATCH v2 02/19] fs/locks: Add Exclusive flag to user Layout lease

2019-08-14 Thread Dave Chinner
On Wed, Aug 14, 2019 at 10:15:06AM -0400, Jeff Layton wrote: > On Fri, 2019-08-09 at 15:58 -0700, ira.we...@intel.com wrote: > > From: Ira Weiny > > > > Add an exclusive lease flag which indicates that the layout mechanism > > can not be broken. > > > > Exclusive layout leases allow the file

[PATCH] selftests: net: tcp_fastopen_backup_key.sh: fix shellcheck issue

2019-08-14 Thread Anders Roxell
When running tcp_fastopen_backup_key.sh the following issue was seen in a busybox environment. ./tcp_fastopen_backup_key.sh: line 33: [: -ne: unary operator expected Shellcheck showed the following issue. $ shellcheck tools/testing/selftests/net/tcp_fastopen_backup_key.sh In

Re: [PATCH v2 4/5] mm/memory_hotplug: Make sure the pfn is aligned to the order when onlining

2019-08-14 Thread David Hildenbrand
On 14.08.19 22:56, Andrew Morton wrote: > On Wed, 14 Aug 2019 17:41:08 +0200 David Hildenbrand wrote: > >> Commit a9cd410a3d29 ("mm/page_alloc.c: memory hotplug: free pages as higher >> order") assumed that any PFN we get via memory resources is aligned to >> to MAX_ORDER - 1, I am not convinced

RE: Parsing PXM from ACPI (DSDT)

2019-08-14 Thread Schmauss, Erik
> -Original Message- > From: linux-acpi-ow...@vger.kernel.org [mailto:linux-acpi- > ow...@vger.kernel.org] On Behalf Of Duran, Leo > Sent: Wednesday, August 14, 2019 2:30 PM > To: linux-a...@vger.kernel.org; linux-kernel@vger.kernel.org > Cc: Rafael J. Wysocki ; Len Brown > Subject:

[PATCH v2] regulator: twl: voltage lists for vdd1/2 on twl4030

2019-08-14 Thread Andreas Kemnade
_opp_supported_by_regulators() wrongly ignored errors from regulator_is_supported_voltage(), so it considered errors as success. Since commit 498209445124 ("regulator: core: simplify return value on suported_voltage") regulator_is_supported_voltage() returns a real boolean, so errors make

Re: [PATCH v5 01/18] xfs: compat_ioctl: use compat_ptr()

2019-08-14 Thread Dave Chinner
On Wed, Aug 14, 2019 at 10:42:28PM +0200, Arnd Bergmann wrote: > For 31-bit s390 user space, we have to pass pointer arguments through > compat_ptr() in the compat_ioctl handler. Seems fair enough, but... > > Signed-off-by: Arnd Bergmann > --- > fs/xfs/xfs_ioctl32.c | 8 > 1 file

Re: [PATCH] netfilter: nft_bitwise: Adjust parentheses to fix memcmp size argument

2019-08-14 Thread Pablo Neira Ayuso
On Wed, Aug 14, 2019 at 09:58:09AM -0700, Nathan Chancellor wrote: > clang warns: > > net/netfilter/nft_bitwise.c:138:50: error: size argument in 'memcmp' > call is a comparison [-Werror,-Wmemsize-comparison] > if (memcmp(>xor, , sizeof(priv->xor) || >

Re: [PATCH 4.19 00/91] 4.19.67-stable review

2019-08-14 Thread kernelci.org bot
stable-rc/linux-4.19.y boot: 138 boots: 0 failed, 126 passed with 12 offline (v4.19.66-92-gf777613d3df0) Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-4.19.y/kernel/v4.19.66-92-gf777613d3df0/ Full Build Summary:

Parsing PXM from ACPI (DSDT)

2019-08-14 Thread Duran, Leo
Hello, Is not clear or evident to me if the kernel parses _PXM values below (or under) the root-complex. For example, in my experience: This ASL sample for PXM at the root-complex level produces the expected NUMA assignment from “lstopo”: Scope (\_SB) { // ... Device (PCI0) { // Root PCI

Re: [PATCH v2 2/2] riscv: Make __fstate_clean() work correctly.

2019-08-14 Thread Palmer Dabbelt
On Wed, 14 Aug 2019 13:32:50 PDT (-0700), Paul Walmsley wrote: On Wed, 14 Aug 2019, Vincent Chen wrote: Make the __fstate_clean() function correctly set the state of sstatus.FS in pt_regs to SR_FS_CLEAN. Fixes: 7db91e5 ("RISC-V: Task implementation") Cc: linux-stable Signed-off-by: Vincent

Re: [PATCH 21/22] ARM: omap1: use common clk framework

2019-08-14 Thread Aaro Koskinen
Hi, On Thu, Aug 08, 2019 at 11:43:39PM +0200, Arnd Bergmann wrote: > The omap1 clock driver now uses types and calling conventions > that are compatible with the common clk core. > > Turn on CONFIG_COMMON_CLK and remove all the code that is > now duplicated. > > Note: if this previous steps

Re: [PATCH 2/2] of/platform: Disable generic device linking code for PowerPC

2019-08-14 Thread Saravana Kannan
On Tue, Aug 6, 2019 at 3:04 PM Saravana Kannan wrote: > > On Tue, Aug 6, 2019 at 2:27 PM Rob Herring wrote: > > > > On Tue, Aug 6, 2019 at 1:27 PM Saravana Kannan wrote: > > > > > > PowerPC platforms don't use the generic of/platform code to populate the > > > devices from DT. > > > > Yes, they

[PATCH v5 16/18] compat_ioctl: move SG_GET_REQUEST_TABLE handling

2019-08-14 Thread Arnd Bergmann
SG_GET_REQUEST_TABLE is now the last ioctl command that needs a conversion handler. This is only used in a single file, so the implementation should be there. I'm trying to simplify it in the process, to get rid of the compat_alloc_user_space() and extra copy, by adding a

[PATCH v5 18/18] scsi: sd: enable compat ioctls for sed-opal

2019-08-14 Thread Arnd Bergmann
The sed_ioctl() function is written to be compatible between 32-bit and 64-bit processes, however compat mode is only wired up for nvme, not for sd. Add the missing call to sed_ioctl() in sd_compat_ioctl(). Fixes: d80210f25ff0 ("sd: add support for TCG OPAL self encrypting disks") Signed-off-by:

[PATCH v5 17/18] pktcdvd: add compat_ioctl handler

2019-08-14 Thread Arnd Bergmann
pkt_ioctl() implements the generic SCSI_IOCTL_SEND_COMMAND and some cdrom ioctls by forwarding to the underlying block device. For compat_ioctl handling, this always takes a roundtrip through fs/compat_ioctl.c that we should try to avoid, at least for the compatible commands. CDROM_SEND_PACKET is

[PATCH v5 15/18] compat_ioctl: ppp: move simple commands into ppp_generic.c

2019-08-14 Thread Arnd Bergmann
All ppp commands that are not already handled in ppp_compat_ioctl() are compatible, so they can now handled by calling the native ppp_ioctl() directly. Signed-off-by: Arnd Bergmann --- drivers/net/ppp/ppp_generic.c | 4 fs/compat_ioctl.c | 32

[PATCH v5 14/18] compat_ioctl: handle PPPIOCGIDLE for 64-bit time_t

2019-08-14 Thread Arnd Bergmann
The ppp_idle structure is defined in terms of __kernel_time_t, which is defined as 'long' on all architectures, and this usage is not affected by the y2038 problem since it transports a time interval rather than an absolute time. However, the ppp user space defines the same structure as time_t,

[PATCH v5 13/18] compat_ioctl: move PPPIOCSCOMPRESS to ppp_generic

2019-08-14 Thread Arnd Bergmann
From: Al Viro Rather than using a compat_alloc_user_space() buffer, moving this next to the native handler allows sharing most of the code, leaving only the user copy portion distinct. Signed-off-by: Al Viro Signed-off-by: Arnd Bergmann --- drivers/net/ppp/ppp_generic.c | 53

[PATCH v5 11/18] tty: handle compat PPP ioctls

2019-08-14 Thread Arnd Bergmann
Multiple tty devices are have tty devices that handle the PPPIOCGUNIT and PPPIOCGCHAN ioctls. To avoid adding a compat_ioctl handler to each of those, add it directly in tty_compat_ioctl so we can remove the calls from fs/compat_ioctl.c. Signed-off-by: Arnd Bergmann --- drivers/tty/tty_io.c | 4

Re: [PATCH v2 4/5] mm/memory_hotplug: Make sure the pfn is aligned to the order when onlining

2019-08-14 Thread Andrew Morton
On Wed, 14 Aug 2019 17:41:08 +0200 David Hildenbrand wrote: > Commit a9cd410a3d29 ("mm/page_alloc.c: memory hotplug: free pages as higher > order") assumed that any PFN we get via memory resources is aligned to > to MAX_ORDER - 1, I am not convinced that is always true. Let's play safe, > check

[PATCH] efi/libstub/arm64: Report meaningful relocation errors

2019-08-14 Thread Kees Cook
When UEFI booting, if allocate_pages() fails (either via KASLR or regular boot), efi_low_alloc() is used for fall back. If it, too, fails, it reports "Failed to relocate kernel". Then handle_kernel_image() reports the failure to its caller, which unhelpfully reports exactly the same string again:

[PATCH v5 12/18] compat_ioctl: unify copy-in of ppp filters

2019-08-14 Thread Arnd Bergmann
From: Al Viro Now that isdn4linux is gone, the is only one implementation of PPPIOCSPASS and PPPIOCSACTIVE in ppp_generic.c, so this is where the compat_ioctl support should be implemented. The two commands are implemented in very similar ways, so introduce new helpers to allow sharing between

[PATCH v5 10/18] compat_ioctl: move SIOCOUTQ out of compat_ioctl.c

2019-08-14 Thread Arnd Bergmann
All users of this call are in socket or tty code, so handling it there means we can avoid the table entry in fs/compat_ioctl.c. Signed-off-by: Arnd Bergmann --- drivers/tty/tty_io.c | 1 + fs/compat_ioctl.c| 2 -- net/socket.c | 2 ++ 3 files changed, 3 insertions(+), 2 deletions(-)

[PATCH v5 09/18] compat_ioctl: handle SIOCOUTQNSD

2019-08-14 Thread Arnd Bergmann
Unlike the normal SIOCOUTQ, SIOCOUTQNSD was never handled in compat mode. Add it to the common socket compat handler along with similar ones. Fixes: 2f4e1b397097 ("tcp: ioctl type SIOCOUTQNSD returns amount of data not sent") Signed-off-by: Arnd Bergmann --- net/socket.c | 1 + 1 file changed,

[PATCH v5 07/18] compat_ioctl: reimplement SG_IO handling

2019-08-14 Thread Arnd Bergmann
There are two code locations that implement the SG_IO ioctl: the old sg.c driver, and the generic scsi_ioctl helper that is in turn used by multiple drivers. To eradicate the old compat_ioctl conversion handler for the SG_IO command, I implement a readable pair of put_sg_io_hdr() /get_sg_io_hdr()

[PATCH v5 08/18] af_unix: add compat_ioctl support

2019-08-14 Thread Arnd Bergmann
The af_unix protocol family has a custom ioctl command (inexplicibly based on SIOCPROTOPRIVATE), but never had a compat_ioctl handler for 32-bit applications. Since all commands are compatible here, add a trivial wrapper that performs the compat_ptr() conversion for SIOCOUTQ/SIOCINQ.

Re: [PATCH v3 1/1] waitid: Add support for waiting for the current process group

2019-08-14 Thread Christian Brauner
On Wed, Aug 14, 2019 at 06:09:17PM +0200, Oleg Nesterov wrote: > On 08/14, Christian Brauner wrote: > > > > and a signal could come in between the system call that > > retrieved the process gorup and the call to waitid that changes the > ^ > > current process group. >

[PATCH] lsilogic mpt fusion: mptctl: Fixed race condition around mptctl_id variable using mutexes

2019-08-14 Thread Mark Balantzyan
Certain functions in the driver, such as mptctl_do_fw_download() and mptctl_do_mpt_command(), rely on the instance of mptctl_id, which does the id-ing. There is race condition possible when these functions operate in concurrency. Via, mutexes, the functions are mutually signalled to cooperate.

Re: [PATCH] tools build: Fix clang detection with clang >= 8.0

2019-08-14 Thread Nick Desaulniers
On Mon, Aug 12, 2019 at 10:07 PM Matthew Dawson wrote: > > The 8.0 release of clang/llvm moved the VirtualFileSystem.h header > to from clang to llvm. This change causes a compile error, causing > perf to not detect clang/llvm. > > Fix by including the right header for the different versions of

[PATCH v5 05/18] watchdog: cpwd: use generic compat_ptr_ioctl

2019-08-14 Thread Arnd Bergmann
The cpwd_compat_ioctl() contains a bogus mutex that dates back to a leftover BKL instance. Simplify the implementation by using the new compat_ptr_ioctl() helper function that will do the right thing for all calls here. Note that WIOCSTART/WIOCSTOP don't take any arguments, so the compat_ptr()

[PATCH v5 02/18] xfs: compat_ioctl: add missing conversions

2019-08-14 Thread Arnd Bergmann
FS_IOC_GETFSLABEL/FS_IOC_SETFSLABEL were added in linux-4.18 in xfs, but not in the compat_ioctl case, so add them here. FITRIM was added earlier and also lacks a line the same function, but this is ok because there is an entry in fs/compat_ioctl.c for it. Adding all three here to keep the

[PATCH v5 01/18] xfs: compat_ioctl: use compat_ptr()

2019-08-14 Thread Arnd Bergmann
For 31-bit s390 user space, we have to pass pointer arguments through compat_ptr() in the compat_ioctl handler. Signed-off-by: Arnd Bergmann --- fs/xfs/xfs_ioctl32.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/fs/xfs/xfs_ioctl32.c b/fs/xfs/xfs_ioctl32.c index

Re: [PATCH net-next, 5/6] net/mlx5: Add HV VHCA control agent

2019-08-14 Thread Mark Bloch
On 8/14/19 12:09 PM, Haiyang Zhang wrote: > From: Eran Ben Elisha > > Control agent is responsible over of the control block (ID 0). It should > update the PF via this block about every capability change. In addition, > upon block 0 invalidate, it should activate all other supported agents >

Re: [PATCH net-next, 4/6] net/mlx5: Add HV VHCA infrastructure

2019-08-14 Thread Mark Bloch
On 8/14/19 12:08 PM, Haiyang Zhang wrote: > From: Eran Ben Elisha > > HV VHCA is a layer which provides PF to VF communication channel based on > HyperV PCI config channel. It implements Mellanox's Inter VHCA control > communication protocol. The protocol contains control block in order to >

Re: [PATCH net-next, 3/6] net/mlx5: Add wrappers for HyperV PCIe operations

2019-08-14 Thread Mark Bloch
On 8/14/19 12:08 PM, Haiyang Zhang wrote: > From: Eran Ben Elisha > > Add wrapper functions for HyperV PCIe read / write / > block_invalidate_register operations. This will be used as an > infrastructure in the downstream patch for software communication. > > This will be enabled by default

[PATCH v2 2/6] perf/util/svghelper: Replace MAX_NR_CPUS with env->nr_cpus_online

2019-08-14 Thread Kyle Meyer
env->nr_cpus_online, the number of CPUs online during a record session, can be used as a dynamic alternative for MAX_NR_CPUS in svg_build_topology_map. The value of env->nr_cpus_online can be passed into str_to_bitmap, scan_core_topology, and svg_build_topology_map to replace MAX_NR_CPUS as well.

[PATCH v2 6/6] perf/util/header: Replace MAX_NR_CPUS with cpu__max_cpu

2019-08-14 Thread Kyle Meyer
The function cpu__max_cpu returns the possible number of CPUs as defined in the sysfs and can be used as an alternative for MAX_NR_CPUS in write_cache. MAX_CACHES is replaced by cpu__max_cpu() * MAX_CACHE_LVL. Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Arnaldo Carvalho de Melo Cc: Alexander

[PATCH v2 0/6] perf: Replace MAX_NR_CPUS with dynamic alternatives

2019-08-14 Thread Kyle Meyer
The purpose of this patch series is to replace MAX_NR_CPUS with a dynamic value throughout perf wherever possible using nr_cpus_online, the number of CPUs online during a record session, and cpu__max_cpu, the possible number of CPUs as defined in the sysfs. MAX_NR_CPUS is still used by

[PATCH v2 5/6] perf/util/machine: Replace MAX_NR_CPUS with nr_cpus_online

2019-08-14 Thread Kyle Meyer
nr_cpus_online, the number of CPUs online during a record session, can be used as a dynamic alternative for MAX_NR_CPUS in __machine__synthesize_threads and machine__set_current_tid. Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Arnaldo Carvalho de Melo Cc: Alexander Shishkin Cc: Jiri Olsa Cc:

[PATCH v2 3/6] perf/util/stat: Replace MAX_NR_CPUS with cpu__max_cpu

2019-08-14 Thread Kyle Meyer
The function cpu__max_cpu returns the possible number of CPUs as defined in the sysfs and can be used as an alternative for MAX_NR_CPUS in zero_per_pkg and check_per_pkg. Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Arnaldo Carvalho de Melo Cc: Alexander Shishkin Cc: Jiri Olsa Cc: Namhyung Kim

[PATCH v2 4/6] perf/util/session: Replace MAX_NR_CPUS with nr_cpus_online

2019-08-14 Thread Kyle Meyer
nr_cpus_online, the number of CPUs online during a record session, can be used as a dynamic alternative for MAX_NR_CPUS in perf_session__cpu_bitmap. Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Arnaldo Carvalho de Melo Cc: Alexander Shishkin Cc: Jiri Olsa Cc: Namhyung Kim Cc:

[PATCH v2 1/6] perf: Refactor svg_build_topology_map

2019-08-14 Thread Kyle Meyer
Exchange the parameters of svg_build_topology_map with struct perf_env *env and adjust the function accordingly. This patch should not change any behavior, it is merely refactoring for the following patch. Cc: Peter Zijlstra Cc: Ingo Molnar Cc: Arnaldo Carvalho de Melo Cc: Alexander Shishkin

Re: [PATCH v2] coresight: tmc-etr: Fix updating buffer in not-snapshot mode.

2019-08-14 Thread Mathieu Poirier
On Mon, 12 Aug 2019 at 16:11, Yabin Cui wrote: > > TMC etr always copies all available data to perf aux buffer, which > may exceed the available space in perf aux buffer. It isn't suitable > for not-snapshot mode, because: > 1) It may overwrite previously written data. > 2) It may make the

Re: [PATCH] hv_netvsc: Fix a memory leak bug

2019-08-14 Thread Stephen Hemminger
On Wed, 14 Aug 2019 15:16:11 -0500 Wenwen Wang wrote: > In rndis_filter_device_add(), 'rndis_device' is allocated through kzalloc() > by invoking get_rndis_device(). In the following execution, if an error > occurs, the execution will go to the 'err_dev_remv' label. However, the > allocated

3% L OANS.

2019-08-14 Thread I.D
Hi, Contact us for a 3% L oan today. Let me know how much you need and duration to pay back for more details. Thanks.

RE: [PATCH] hv_netvsc: Fix a memory leak bug

2019-08-14 Thread Haiyang Zhang
> -Original Message- > From: Wenwen Wang > Sent: Wednesday, August 14, 2019 4:16 PM > To: Wenwen Wang > Cc: KY Srinivasan ; Haiyang Zhang > ; Stephen Hemminger > ; Sasha Levin ; David S. > Miller ; open list:Hyper-V CORE AND DRIVERS > ; open list:NETWORKING DRIVERS > ; open list >

Re: [PATCH v2 2/2] riscv: Make __fstate_clean() work correctly.

2019-08-14 Thread Paul Walmsley
On Wed, 14 Aug 2019, Vincent Chen wrote: > Make the __fstate_clean() function correctly set the > state of sstatus.FS in pt_regs to SR_FS_CLEAN. > > Fixes: 7db91e5 ("RISC-V: Task implementation") > Cc: linux-stable > Signed-off-by: Vincent Chen > Reviewed-by: Anup Patel > Reviewed-by:

[RFC 2/5] media: v4l2-ctrl: Document V4L2_CID_LOCATION

2019-08-14 Thread Jacopo Mondi
Add documentation for the V4L2_CID_LOCATION camera control. The newly added read-only control reports the camera device mounting position. Signed-off-by: Jacopo Mondi --- .../media/uapi/v4l/ext-ctrls-camera.rst | 23 +++ 1 file changed, 23 insertions(+) diff --git

[RFC 1/5] media: dt-bindings: Document 'location' property

2019-08-14 Thread Jacopo Mondi
Add the 'location' device property, used to specify the camera device mounting position. The property is particularly meaningful for mobile devices with a well defined usage orientation. Signed-off-by: Jacopo Mondi --- Documentation/devicetree/bindings/media/video-interfaces.txt | 4 1

[RFC 4/5] media: i2c: ov5670: Report the camera location

2019-08-14 Thread Jacopo Mondi
The camera location is retrieved from the firmware interface parsing the "location" device property and reported through the read-only V4L2_CID_LOCATION control. Signed-off-by: Jacopo Mondi --- drivers/media/i2c/ov5670.c | 11 +++ 1 file changed, 11 insertions(+) diff --git

[RFC 3/5] media: v4l2-ctrls: Add support for V4L2_CID_LOCATION

2019-08-14 Thread Jacopo Mondi
Add support for the newly defined V4L2_CID_LOCATION read-only control used to report the camera device mounting position. Signed-off-by: Jacopo Mondi --- drivers/media/v4l2-core/v4l2-ctrls.c | 7 +++ include/uapi/linux/v4l2-controls.h | 4 2 files changed, 11 insertions(+) diff

[RFC 5/5] media: i2c: ov13858: Report the camera location

2019-08-14 Thread Jacopo Mondi
The camera location is retrieved from the firmware interface parsing the "location" device property and reported through the read-only V4L2_CID_LOCATION control. Signed-off-by: Jacopo Mondi --- drivers/media/i2c/ov13858.c | 11 +++ 1 file changed, 11 insertions(+) diff --git

[RFC 0/5] media: v4l2-ctrls: Add camera 'location' support

2019-08-14 Thread Jacopo Mondi
Hello, as anticipared on #v4l, this is a proposal to add a way for camera devices to report their mounting location to user-space. The information on the camera location is particularly meaningful for mobile devices, and in the process of integrating libcamera with the Android camera stack, we

Re: [PATCH v2 1/2] riscv: Correct the initialized flow of FP register

2019-08-14 Thread Paul Walmsley
On Wed, 14 Aug 2019, Vincent Chen wrote: > The following two reasons cause FP registers are sometimes not > initialized before starting the user program. > 1. Currently, the FP context is initialized in flush_thread() function >and we expect these initial values to be restored to FP

Re: [PATCH v2] nvme: Add quirk for LiteON CL1 devices running FW 22301111

2019-08-14 Thread Keith Busch
On Wed, Aug 14, 2019 at 01:14:50PM -0700, Sagi Grimberg wrote: > Mario, > > Can you please respin a patch that applies cleanly on nvme-5.4? This fixes a regression we introduced in 5.3, so it should go in 5.3-rc. For this to apply cleanly, though, we'll need to resync to Linus' tree to get

RE: [PATCH v2] nvme: Add quirk for LiteON CL1 devices running FW 22301111

2019-08-14 Thread Mario.Limonciello
> -Original Message- > From: Sagi Grimberg > Sent: Wednesday, August 14, 2019 3:15 PM > To: Limonciello, Mario; Keith Busch > Cc: Jens Axboe; Christoph Hellwig; linux-n...@lists.infradead.org; LKML; Hong, > Ryan; Wang, Crag; s...@google.com; Hyde, Charles - Dell Team; Dominguez, Jared >

[PATCH] hv_netvsc: Fix a memory leak bug

2019-08-14 Thread Wenwen Wang
In rndis_filter_device_add(), 'rndis_device' is allocated through kzalloc() by invoking get_rndis_device(). In the following execution, if an error occurs, the execution will go to the 'err_dev_remv' label. However, the allocated 'rndis_device' is not deallocated, leading to a memory leak bug.

Re: [PATCH v2] nvme: Add quirk for LiteON CL1 devices running FW 22301111

2019-08-14 Thread Sagi Grimberg
Mario, Can you please respin a patch that applies cleanly on nvme-5.4?

Re: [PATCH v2] nvme: Add quirk for LiteON CL1 devices running FW 22301111

2019-08-14 Thread Keith Busch
On Wed, Aug 14, 2019 at 01:08:24PM -0700, Mario Limonciello wrote: > One of the components in LiteON CL1 device has limitations that > can be encountered based upon boundary race conditions using the > nvme bus specific suspend to idle flow. > > When this situation occurs the drive doesn't resume

Re: [PATCH 1/2] powerpc: rewrite LOAD_REG_IMMEDIATE() as an intelligent macro

2019-08-14 Thread Segher Boessenkool
Hi Christophe, On Tue, Aug 13, 2019 at 09:59:35AM +, Christophe Leroy wrote: > + rldicr \r, \r, 32, 31 Could you please write this as sldi\r, \r, 32 ? It's much easier to read, imo (it's the exact same instruction). You can do a lot cheaper sequences if you

Re: [PATCH v4 2/2] RISC-V: Implement sparsemem

2019-08-14 Thread Paul Walmsley
On Wed, 14 Aug 2019, Logan Gunthorpe wrote: > On 2019-08-14 11:40 a.m., Paul Walmsley wrote: > > On Wed, 14 Aug 2019, Logan Gunthorpe wrote: > > > >> On 2019-08-14 7:35 a.m., Greentime Hu wrote: > >> > >>> Maybe this commit explains why it used HAVE_ARCH_PFN_VALID instead of > >>> SPARSEMEM. >

[PATCH v2] nvme: Add quirk for LiteON CL1 devices running FW 22301111

2019-08-14 Thread Mario Limonciello
One of the components in LiteON CL1 device has limitations that can be encountered based upon boundary race conditions using the nvme bus specific suspend to idle flow. When this situation occurs the drive doesn't resume properly from suspend-to-idle. LiteON has confirmed this problem and fixed

<    1   2   3   4   5   6   7   8   9   10   >