RE: [PATCH v6 3/3] soc: fsl: add RCPM driver

2019-08-20 Thread Ran Wang
Hi Pavel, On Wednesday, August 21, 2019 11:16, Ran Wang wrote: > > The NXP's QorIQ Processors based on ARM Core have RCPM module (Run > Control and Power Management), which performs system level tasks associated > with power management such as wakeup source control. > > This driver depends on PM

Re: [PATCH] mm/oom: Add oom_score_adj value to oom Killed process message

2019-08-20 Thread David Rientjes
On Tue, 20 Aug 2019, Edward Chron wrote: > For an OOM event: print oom_score_adj value for the OOM Killed process to > document what the oom score adjust value was at the time the process was > OOM Killed. The adjustment value can be set by user code and it affects > the resulting oom_score so it

[PATCH v3] psi: get poll_work to run when calling poll syscall next time

2019-08-20 Thread Joseph Qi
From: Jason Xing Only when calling the poll syscall the first time can user receive POLLPRI correctly. After that, user always fails to acquire the event signal. Reproduce case: 1. Get the monitor code in Documentation/accounting/psi.txt 2. Run it, and wait for the event triggered. 3. Kill and r

linux-next: manual merge of the integrity tree with the security tree

2019-08-20 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the integrity tree got a conflict in: arch/s390/kernel/machine_kexec_file.c between commit: 99d5cadfde2b ("kexec_file: split KEXEC_VERIFY_SIG into KEXEC_SIG and KEXEC_SIG_FORCE") from the security tree and commit: c8424e776b09 ("MODSIGN: Export modul

Re: [PATCH] ACPI / PCI: fix a memory leak bug

2019-08-20 Thread Wenwen Wang
On Mon, Aug 19, 2019 at 5:23 PM Bjorn Helgaas wrote: > > The subject line should give a clue about where the leak is, e.g., > > ACPI / PCI: fix acpi_pci_irq_enable() memory leak > > On Thu, Aug 15, 2019 at 11:33:22PM -0500, Wenwen Wang wrote: > > In acpi_pci_irq_enable(), 'entry' is allocated by

RE: [PATCH v2 0/2] Simplify mtty driver and mdev core

2019-08-20 Thread Parav Pandit
> -Original Message- > From: Alex Williamson > Sent: Tuesday, August 20, 2019 10:49 PM > To: Parav Pandit > Cc: Jiri Pirko ; David S . Miller ; > Kirti Wankhede ; Cornelia Huck > ; k...@vger.kernel.org; linux-kernel@vger.kernel.org; > cjia ; net...@vger.kernel.org > Subject: Re: [PATCH

Re: [PATCH 3/3] csky: Support kernel non-aligned access

2019-08-20 Thread Guo Ren
Thx Christoph On Wed, Aug 21, 2019 at 10:17 AM Christoph Hellwig wrote: > > On Tue, Aug 20, 2019 at 08:34:29PM +0800, guo...@kernel.org wrote: > > From: Guo Ren > > > > We prohibit non-aligned access in kernel mode, but some special NIC > > driver needs to support kernel-state unaligned access.

[PATCH v2] ACPI / PCI: fix acpi_pci_irq_enable() memory leak

2019-08-20 Thread Wenwen Wang
In acpi_pci_irq_enable(), 'entry' is allocated by kzalloc() in acpi_pci_irq_check_entry() (invoked from acpi_pci_irq_lookup()). However, it is not deallocated if acpi_pci_irq_valid() returns false, leading to a memory leak. To fix this issue, free 'entry' before returning 0. Fixes: e237a5518425 ("

Re: [PATCH 1/3] csky: Fixup arch_get_unmapped_area() implementation

2019-08-20 Thread Guo Ren
Thx Christoph, On Wed, Aug 21, 2019 at 10:16 AM Christoph Hellwig wrote: > > > +/* > > + * We need to ensure that shared mappings are correctly aligned to > > + * avoid aliasing issues with VIPT caches. We need to ensure that > > + * a specific page of an object is always mapped at a multiple of

[PATCH] VMCI: Release resource if the work is already queued

2019-08-20 Thread Nadav Amit
Francois reported that VMware balloon gets stuck after a balloon reset, when the VMCI doorbell is removed. A similar error can occur when the balloon driver is removed with the following splat: [ 1088.622000] INFO: task modprobe:3565 blocked for more than 120 seconds. [ 1088.622035] Tainted:

Re: kernel panic in 5.3-rc5, nfsd_reply_cache_stats_show+0x11

2019-08-20 Thread Dan Williams
On Tue, Aug 20, 2019 at 6:39 PM wrote: > > Hi, > > Apology if there is a better channel reporting the issue, if so, please > let me know. > > I just saw below regression in 5.3-rc5 kernel, but not in 5.2-rc7 or > earlier kernels. Is the error stable enough to bisect?

Re: [v2 PATCH] RISC-V: Optimize tlb flush path.

2019-08-20 Thread Anup Patel
On Wed, Aug 21, 2019 at 7:10 AM h...@infradead.org wrote: > > On Wed, Aug 21, 2019 at 09:29:22AM +0800, Alan Kao wrote: > > IMHO, this approach should be avoided because CLINT is compatible to but > > not mandatory in the privileged spec. In other words, it is possible that > > a Linux-capable R

[PATCH] aio: Fix io_pgetevents() struct __compat_aio_sigset layout

2019-08-20 Thread Guillem Jover
This type is used to pass the sigset_t from userland to the kernel, but it was using the kernel native pointer type for the member representing the compat userland pointer to the userland sigset_t. This messes up the layout, and makes the kernel eat up both the userland pointer and the size member

[PATCH 4/4] video/logo: move pnmtologo tool to drivers/video/logo/ from scripts/

2019-08-20 Thread Masahiro Yamada
This tool is only used by drivers/video/logo/Makefile. No reason to keep it in scripts/. Signed-off-by: Masahiro Yamada --- drivers/video/logo/.gitignore | 1 + drivers/video/logo/Makefile | 10 +- {scripts => drivers/video/logo}/pnmtologo.c | 0 scripts/

RE: [PATCH v2 0/2] Simplify mtty driver and mdev core

2019-08-20 Thread Parav Pandit
> -Original Message- > From: Cornelia Huck > Sent: Tuesday, August 20, 2019 11:25 PM > To: Alex Williamson > Cc: Parav Pandit ; Jiri Pirko ; > David S . Miller ; Kirti Wankhede > ; k...@vger.kernel.org; linux- > ker...@vger.kernel.org; cjia ; net...@vger.kernel.org > Subject: Re: [PATC

Re: rfc: treewide scripted patch mechanism? (was: Re: [PATCH] Makefile: Convert -Wimplicit-fallthrough=3 to just -Wimplicit-fallthrough for clang)QUILT

2019-08-20 Thread Willy Tarreau
On Tue, Aug 20, 2019 at 05:43:27PM -0700, Linus Torvalds wrote: > I would seriously suggest doing something like > >copy_string( dst, dstsize, src, srcsize, FLAGS ); > > where FLAGS migth be "pad" or whatever. Make it return the size of the > resulting string, because while it can be convenie

[PATCH 3/4] mm/gup: introduce FOLL_PIN flag for get_user_pages()

2019-08-20 Thread John Hubbard
FOLL_PIN is set by callers of vaddr_pin_pages(). This is different than FOLL_LONGTERM, because even short term page pins need a new kind of tracking, if those pinned pages' data is going to potentially be modified. This situation is described in more detail in commit fc1d8e7cca2d ("mm: introduce p

[PATCH 1/4] checkpatch: revert broken NOTIFIER_HEAD check

2019-08-20 Thread John Hubbard
commit 1a47005dd5aa ("checkpatch: add *_NOTIFIER_HEAD as var definition") causes the following warning when run on some patches: Unescaped left brace in regex is passed through in regex; marked by < --HERE in m/(?: ... [238 lines of appalling perl output, mercifully not included] ... )/ at ./sc

[PATCH 4/4] mm/gup: introduce vaddr_pin_pages_remote(), and invoke it

2019-08-20 Thread John Hubbard
vaddr_pin_user_pages_remote() is the "vaddr_pin_pages" corresponding variant to get_user_pages_remote(): it adds the ability to handle FOLL_PIN, FOLL_LONGTERM, or both. Note that the put_user_page*() requirement won't be truly required until all of the call sites have been converted, and the track

[PATCH 2/4] For Ira: tiny formatting tweak to kerneldoc

2019-08-20 Thread John Hubbard
For your vaddr_pin_pages() and vaddr_unpin_pages(). Just merge it into wherever it goes please. Didn't want to cause merge problems so it's a separate patch-let. Signed-off-by: John Hubbard --- mm/gup.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/gup.c b/mm/gup.c i

[PATCH v2 0/3] mm/gup: introduce vaddr_pin_pages_remote(), FOLL_PIN

2019-08-20 Thread John Hubbard
Hi Ira, This is for your tree. I'm dropping the RFC because this aspect is starting to firm up pretty well. I've moved FOLL_PIN inside the vaddr_pin_*() routines, and moved FOLL_LONGTERM outside, based on our recent discussions. This is documented pretty well within the patches. Note that there

[PATCH v2 1/3] For Ira: tiny formatting tweak to kerneldoc

2019-08-20 Thread John Hubbard
For your vaddr_pin_pages() and vaddr_unpin_pages(). Just merge it into wherever it goes please. Didn't want to cause merge problems so it's a separate patch-let. Signed-off-by: John Hubbard --- mm/gup.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mm/gup.c b/mm/gup.c i

disregard: [PATCH 1/4] checkpatch: revert broken NOTIFIER_HEAD check

2019-08-20 Thread John Hubbard
On 8/20/19 9:03 PM, John Hubbard wrote: commit 1a47005dd5aa ("checkpatch: add *_NOTIFIER_HEAD as var definition") causes the following warning when run on some patches: Please disregard this series. It's stale. thanks, -- John Hubbard NVIDIA

[PATCH v2 3/3] mm/gup: introduce vaddr_pin_pages_remote(), and invoke it

2019-08-20 Thread John Hubbard
vaddr_pin_user_pages_remote() is the "vaddr_pin_pages" corresponding variant to get_user_pages_remote(), except that: a) it sets FOLL_PIN, and b) it can handle FOLL_LONGTERM (and the associated vaddr_pin arg). Change process_vm_rw_single_vec() to invoke the new function. Signed-off-by: John

[PATCH v2 2/3] mm/gup: introduce FOLL_PIN flag for get_user_pages()

2019-08-20 Thread John Hubbard
As explained in the newly added documentation for FOLL_PIN and FOLL_LONGTERM, in every case where vaddr_pin_pages() is required, FOLL_PIN must be set. That reason, plus a desire to keep FOLL_PIN an internal (to get_user_pages() and follow_page()) detail, is why vaddr_pin_pages() sets FOLL_PIN. FOL

Re: [linux-sunxi] [PATCH v5 09/15] clk: sunxi-ng: h6: Allow I2S to change parent rate

2019-08-20 Thread Chen-Yu Tsai
On Wed, Aug 14, 2019 at 2:09 PM wrote: > > From: Jernej Skrabec > > I2S doesn't work if parent rate couldn't be change. Difference between > wanted and actual rate is too big. > > Fix this by adding CLK_SET_RATE_PARENT flag to I2S clocks. > > Signed-off-by: Jernej Skrabec This lacks your SoB. P

Re: [PATCH] net: pch_gbe: Fix memory leaks

2019-08-20 Thread Wenwen Wang
On Thu, Aug 15, 2019 at 4:51 PM David Miller wrote: > > From: Wenwen Wang > Date: Thu, 15 Aug 2019 16:46:05 -0400 > > > On Thu, Aug 15, 2019 at 4:42 PM David Miller wrote: > >> > >> From: Wenwen Wang > >> Date: Thu, 15 Aug 2019 16:03:39 -0400 > >> > >> > On Thu, Aug 15, 2019 at 3:34 PM David Mi

Re: [PATCH 15/15] riscv: disable the EFI PECOFF header for M-mode

2019-08-20 Thread Troy Benjegerdes
> On Aug 13, 2019, at 8:47 AM, Christoph Hellwig wrote: > > No point in bloating the kernel image with a bootloader header if > we run bare metal. I would say the same for S-mode. EFI booting should be an option, not a requirement. I have M-mode U-boot working with bootelf to start BBL, and a

Re: [PATCH v7 0/2] KVM: LAPIC: Implement Exitless Timer

2019-08-20 Thread Wanpeng Li
On Sat, 6 Jul 2019 at 09:26, Wanpeng Li wrote: > > Dedicated instances are currently disturbed by unnecessary jitter due > to the emulated lapic timers fire on the same pCPUs which vCPUs resident. > There is no hardware virtual timer on Intel for guest like ARM. Both > programming timer in guest a

[PATCH v2] net: pch_gbe: Fix memory leaks

2019-08-20 Thread Wenwen Wang
In pch_gbe_set_ringparam(), if netif_running() returns false, 'tx_old' and 'rx_old' are not deallocated, leading to memory leaks. To fix this issue, move the free statements to the outside of the if() statement. Signed-off-by: Wenwen Wang --- drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_ethtool

Re: [PATCH v2 0/2] Simplify mtty driver and mdev core

2019-08-20 Thread Alex Williamson
On Wed, 21 Aug 2019 03:42:25 + Parav Pandit wrote: > > -Original Message- > > From: Alex Williamson > > Sent: Tuesday, August 20, 2019 10:49 PM > > To: Parav Pandit > > Cc: Jiri Pirko ; David S . Miller ; > > Kirti Wankhede ; Cornelia Huck > > ; k...@vger.kernel.org; linux-kernel@vg

Re: [PATCH v7 1/7] driver core: Add support for linking devices during device addition

2019-08-20 Thread Frank Rowand
On 8/20/19 7:01 PM, Saravana Kannan wrote: > > > On Tue, Aug 20, 2019, 6:56 PM Greg Kroah-Hartman > wrote: > > On Tue, Aug 20, 2019 at 06:06:55PM -0700, Frank Rowand wrote: > > On 8/20/19 3:10 PM, Saravana Kannan wrote: > > > On Mon, Aug 19, 2019 a

Re: [EXT] [PATCH] qed: Add cleanup in qed_slowpath_start()

2019-08-20 Thread Wenwen Wang
On Tue, Aug 13, 2019 at 6:46 AM Sudarsana Reddy Kalluru wrote: > > > -Original Message- > > From: Wenwen Wang > > Sent: Tuesday, August 13, 2019 3:35 PM > > To: Wenwen Wang > > Cc: Ariel Elior ; GR-everest-linux-l2 > l...@marvell.com>; David S. Miller ; open > > list:QLOGIC QL4xxx ETHER

Re: [PATCH] fsi: scom: Don't abort operations for minor errors

2019-08-20 Thread Benjamin Herrenschmidt
On Thu, 2019-08-15 at 14:08 -0500, Eddie James wrote: > The scom driver currently fails out of operations if certain system > errors are flagged in the status register; system checkstop, special > attention, or recoverable error. These errors won't impact the ability > of the scom engine to perform

Re: [PATCH] powerpc/vdso32: inline __get_datapage()

2019-08-20 Thread Benjamin Herrenschmidt
On Fri, 2019-08-16 at 14:48 +, Christophe Leroy wrote: > __get_datapage() is only a few instructions to retrieve the > address of the page where the kernel stores data to the VDSO. > > By inlining this function into its users, a bl/blr pair and > a mflr/mtlr pair is avoided, plus a few reg mov

RE: [PATCH v2 0/2] Simplify mtty driver and mdev core

2019-08-20 Thread Parav Pandit
> -Original Message- > From: Alex Williamson > Sent: Wednesday, August 21, 2019 9:51 AM > To: Parav Pandit > Cc: Jiri Pirko ; David S . Miller ; > Kirti Wankhede ; Cornelia Huck > ; k...@vger.kernel.org; linux-kernel@vger.kernel.org; > cjia ; net...@vger.kernel.org > Subject: Re: [PATC

linux-next: manual merge of the irqchip tree with the pci tree

2019-08-20 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the irqchip tree got a conflict in: drivers/pci/controller/pci-hyperv.c between commit: 44b1ece783ff ("PCI: hv: Detect and fix Hyper-V PCI domain number collision") from the pci tree and commit: 467a3bb97432 ("PCI: hv: Allocate a named fwnode instead

[PATCH v2] qed: Add cleanup in qed_slowpath_start()

2019-08-20 Thread Wenwen Wang
If qed_mcp_send_drv_version() fails, no cleanup is executed, leading to memory leaks. To fix this issue, introduce the label 'err4' to perform the cleanup work before returning the error. Signed-off-by: Wenwen Wang --- drivers/net/ethernet/qlogic/qed/qed_main.c | 4 +++- 1 file changed, 3 insert

Re: [PATCH v2 0/2] Simplify mtty driver and mdev core

2019-08-20 Thread Alex Williamson
On Wed, 21 Aug 2019 04:40:15 + Parav Pandit wrote: > > -Original Message- > > From: Alex Williamson > > Sent: Wednesday, August 21, 2019 9:51 AM > > To: Parav Pandit > > Cc: Jiri Pirko ; David S . Miller ; > > Kirti Wankhede ; Cornelia Huck > > ; k...@vger.kernel.org; linux-kernel@v

RE: [PATCH v2 0/2] Simplify mtty driver and mdev core

2019-08-20 Thread Parav Pandit
> -Original Message- > From: Alex Williamson > Sent: Wednesday, August 21, 2019 10:27 AM > To: Parav Pandit > Cc: Jiri Pirko ; David S . Miller ; > Kirti Wankhede ; Cornelia Huck > ; k...@vger.kernel.org; linux-kernel@vger.kernel.org; > cjia ; net...@vger.kernel.org > Subject: Re: [PAT

RE: [PATCH v2] qed: Add cleanup in qed_slowpath_start()

2019-08-20 Thread Sudarsana Reddy Kalluru
> -Original Message- > From: Wenwen Wang > Sent: Wednesday, August 21, 2019 10:17 AM > To: Wenwen Wang > Cc: Sudarsana Reddy Kalluru ; Ariel Elior > ; GR-everest-linux-l2 l...@marvell.com>; David S. Miller ; open > list:QLOGIC QL4xxx ETHERNET DRIVER ; open list > > Subject: [PATCH v2]

Re: PROBLEM: 5.3.0-rc* causes iwlwifi failure

2019-08-20 Thread Luciano Coelho
On Tue, 2019-08-20 at 19:37 -0400, Stuart Little wrote: > On Tue, Aug 20, 2019 at 01:45:37PM +0300, Luciano Coelho wrote: > > I'll have to look into all NIC/FW-version combinations that we have > > and > > update the iwl_mvm_sar_geo_support() function accordingly, which > > is, > > BTW, the easier

[rcu:dev.2019.08.17a 8/36] ERROR: "tick_nohz_full_running" [kernel/rcu/rcutorture.ko] undefined!

2019-08-20 Thread kbuild test robot
Hi Paul, FYI, the error/warning still remains. tree: https://kernel.googlesource.com/pub/scm/linux/kernel/git/paulmck/linux-rcu.git dev.2019.08.17a head: 9120323ada960bc9f1427e546772a983ad036b9a commit: 14569aa16daa1cd7610624a500ed2750fe341351 [8/36] rcutorture: Force on tick for readers a

Re: [PATCH v5 2/3] OPP: Add support for bandwidth OPP tables

2019-08-20 Thread Viresh Kumar
On 20-08-19, 15:27, Saravana Kannan wrote: > On Mon, Aug 19, 2019 at 11:13 PM Viresh Kumar wrote: > > > > On 07-08-19, 15:31, Saravana Kannan wrote: > > > Not all devices quantify their performance points in terms of frequency. > > > Devices like interconnects quantify their performance points in

Re: [PATCH v5 2/3] OPP: Add support for bandwidth OPP tables

2019-08-20 Thread Viresh Kumar
On 20-08-19, 15:36, Saravana Kannan wrote: > On Tue, Aug 20, 2019 at 3:27 PM Saravana Kannan wrote: > > > > On Mon, Aug 19, 2019 at 11:13 PM Viresh Kumar > > wrote: > > > > > > On 07-08-19, 15:31, Saravana Kannan wrote: > > > > > + ret = of_property_read_u32(np, "opp-peak-kBps", &bw); > > >

Re: [PATCH v2 1/2] dt-bindings: phy: intel-emmc-phy: Add YAML schema for LGM eMMC PHY

2019-08-20 Thread Ramuthevar, Vadivel MuruganX
On 20/8/2019 11:54 PM, Rob Herring wrote: On Tue, Aug 20, 2019 at 5:31 AM Ramuthevar,Vadivel MuruganX wrote: From: Ramuthevar Vadivel Murugan Add a YAML schema to use the host controller driver with the eMMC PHY on Intel's Lightning Mountain SoC. Signed-off-by: Ramuthevar Vadivel Murugan

Re: [PATCH v2 0/2] Simplify mtty driver and mdev core

2019-08-20 Thread Alex Williamson
On Wed, 21 Aug 2019 05:01:52 + Parav Pandit wrote: > > -Original Message- > > From: Alex Williamson > > Sent: Wednesday, August 21, 2019 10:27 AM > > To: Parav Pandit > > Cc: Jiri Pirko ; David S . Miller ; > > Kirti Wankhede ; Cornelia Huck > > ; k...@vger.kernel.org; linux-kernel@

Re: [PATCH v5 2/3] OPP: Add support for bandwidth OPP tables

2019-08-20 Thread Viresh Kumar
On 20-08-19, 15:36, Saravana Kannan wrote: > On Tue, Aug 20, 2019 at 3:27 PM Saravana Kannan wrote: > > > > On Mon, Aug 19, 2019 at 11:13 PM Viresh Kumar > > wrote: > > > > > > On 07-08-19, 15:31, Saravana Kannan wrote: > > > > > + ret = of_property_read_u32(np, "opp-peak-kBps", &bw); > > >

Re: [PATCH v2 2/2] phy: intel-lgm-emmc: Add support for eMMC PHY

2019-08-20 Thread Ramuthevar, Vadivel MuruganX
On 20/8/2019 9:56 PM, Andy Shevchenko wrote: On Tue, Aug 20, 2019 at 06:31:33PM +0800, Ramuthevar,Vadivel MuruganX wrote: From: Ramuthevar Vadivel Murugan Add support for eMMC PHY on Intel's Lightning Mountain SoC. Thanks for an update. Looks better though several minor comments below. Than

Re: [PATCH v2 2/2] phy: intel-lgm-emmc: Add support for eMMC PHY

2019-08-20 Thread Ramuthevar, Vadivel MuruganX
On 20/8/2019 9:59 PM, Andy Shevchenko wrote: On Tue, Aug 20, 2019 at 04:56:02PM +0300, Andy Shevchenko wrote: On Tue, Aug 20, 2019 at 06:31:33PM +0800, Ramuthevar,Vadivel MuruganX wrote: +#define DR_TY_50OHM(x) ((~(x) << 28) & DR_TY_MASK) For consistency it should be #define DR_TY_SHI

Re: numlist_pop(): Re: [RFC PATCH v4 1/9] printk-rb: add a new printk ringbuffer implementation

2019-08-20 Thread John Ogness
On 2019-08-20, Petr Mladek wrote: >> --- /dev/null >> +++ b/kernel/printk/numlist.c >> +/** >> + * numlist_pop() - Remove the oldest node from the list. >> + * >> + * @nl: The numbered list from which to remove the tail node. >> + * >> + * The tail node can only be removed if two conditions are sa

Re: comments style: Re: [RFC PATCH v4 1/9] printk-rb: add a new printk ringbuffer implementation

2019-08-20 Thread John Ogness
On 2019-08-20, Petr Mladek wrote: >> --- /dev/null >> +++ b/kernel/printk/dataring.c >> +/** >> + * _datablock_valid() - Check if given positions yield a valid data block. >> + * >> + * @dr: The associated data ringbuffer. >> + * >> + * @head_lpos: The newest data logical position. >> + *

Re: ##freemail## Re: [PATCH v2] mm: hwpoison: disable memory error handling on 1GB hugepage

2019-08-20 Thread Naoya Horiguchi
On Tue, Aug 20, 2019 at 03:03:55PM +0800, Wanpeng Li wrote: > Cc Mel Gorman, Kirill, Dave Hansen, > On Tue, 11 Jun 2019 at 07:51, Naoya Horiguchi > wrote: > > > > On Wed, May 29, 2019 at 04:31:01PM -0700, Mike Kravetz wrote: > > > On 5/28/19 2:49 AM, Wanpeng Li wrote: > > > > Cc Paolo, > > > > Hi

Re: comments style: Re: [RFC PATCH v4 1/9] printk-rb: add a new printk ringbuffer implementation

2019-08-20 Thread John Ogness
On 2019-08-20, Sergey Senozhatsky wrote: > [..] >> > + * >> > + * Memory barrier involvement: >> > + * >> > + * If dB reads from gA, then dC reads from fG. >> > + * If dB reads from gA, then dD reads from fH. >> > + * If dB reads from gA, then dE reads from fE. >> > + * >> > + * No

Re: [RFC PATCH v4 8/9] printk-rb: new functionality to support printk

2019-08-20 Thread John Ogness
On 2019-08-20, Sergey Senozhatsky wrote: > [..] >> +void prb_init(struct printk_ringbuffer *rb, char *data, int data_size_bits, >> + struct prb_desc *descs, int desc_count_bits, >> + struct wait_queue_head *waitq) >> +{ >> +struct dataring *dr = &rb->dr; >> +struct numlis

Re: assign_desc() barriers: Re: [RFC PATCH v4 1/9] printk-rb: add a new printk ringbuffer implementation

2019-08-20 Thread John Ogness
On 2019-08-20, Petr Mladek wrote: >> > --- /dev/null >> > +++ b/kernel/printk/ringbuffer.c >> > +/** >> > + * assign_desc() - Assign a descriptor to the caller. >> > + * >> > + * @e: The entry structure to store the assigned descriptor to. >> > + * >> > + * Find an available descriptor to assign t

Re: [linux-sunxi] [PATCH v5 09/15] clk: sunxi-ng: h6: Allow I2S to change parent rate

2019-08-20 Thread Code Kipper
ThanksI've added to my next patch series but if you could add it when applying that would be great. BR, CK On Wed, 21 Aug 2019 at 06:07, Chen-Yu Tsai wrote: > > On Wed, Aug 14, 2019 at 2:09 PM wrote: > > > > From: Jernej Skrabec > > > > I2S doesn't work if parent rate couldn't be change. Di

[PATCH] kprobes/x86: use instruction_pointer and instruction_pointer_set

2019-08-20 Thread Jisheng Zhang
Use an arch-independent way to get/set the instruction pointer, we can make the x86 kprobe_ftrace_handler() more common. Signed-off-by: Jisheng Zhang Acked-by: Masami Hiramatsu --- arch/x86/kernel/kprobes/ftrace.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/arch

RE: [EXT] Re: [PATCH net-next 0/1] net: fec: add C45 MDIO read/write support

2019-08-20 Thread Andy Duan
From: Andrew Lunn Sent: Tuesday, August 20, 2019 9:04 PM > On Tue, Aug 20, 2019 at 02:32:26AM +, Andy Duan wrote: > > From: Andrew Lunn > > > On Mon, Aug 19, 2019 at 05:11:14PM +, Marco Hartmann wrote: > > > > As of yet, the Fast Ethernet Controller (FEC) driver only supports > > > > Clau

Re: [RFC PATCH v4 4/9] printk-rb: initialize new descriptors as invalid

2019-08-20 Thread John Ogness
On 2019-08-20, Petr Mladek wrote: >> Initialize never-used descriptors as permanently invalid so there > > The word "permanently" is confusing. It suggests that it will > never ever be valid again. I would just remove the word. Agreed. >> is no risk of the descriptor unexpectedly being determine

Re: [PATCH v8 2/3] fdt: add support for rng-seed

2019-08-20 Thread Hsin-Yi Wang
Then we'd still use add_device_randomness() in case that bootloader provides weak entropy. On Tue, Aug 20, 2019 at 7:14 PM Ard Biesheuvel wrote: > > On Tue, 20 Aug 2019 at 10:43, Hsin-Yi Wang wrote: > > > > Hi Ted, > > > > Thanks for raising this question. > > > > For UEFI based system, they hav

Re: [linux-sunxi] [PATCH v5 09/15] clk: sunxi-ng: h6: Allow I2S to change parent rate

2019-08-20 Thread Chen-Yu Tsai
On Wed, Aug 21, 2019 at 1:52 PM Code Kipper wrote: > > ThanksI've added to my next patch series but if you could add it > when applying that would be great. Please reply with an explicit SoB to put it on the record. ChenYu > BR, > CK > > On Wed, 21 Aug 2019 at 06:07, Chen-Yu Tsai wrote: >

linux-next: manual merge of the gpio tree with the irqchip tree

2019-08-20 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the gpio tree got a conflict in: drivers/gpio/gpio-ixp4xx.c between commit: daa19fe5b082 ("gpio/ixp4xx: Register the base PA instead of its VA in fwnode") from the irqchip tree and commit: aa7d618ac65f ("gpio: ixp4xx: Convert to hierarchical GPIOLIB_I

Re: [PATCH] fsi: scom: Don't abort operations for minor errors

2019-08-20 Thread Joel Stanley
On Wed, 21 Aug 2019 at 05:26, Benjamin Herrenschmidt wrote: > > On Thu, 2019-08-15 at 14:08 -0500, Eddie James wrote: > > The scom driver currently fails out of operations if certain system > > errors are flagged in the status register; system checkstop, special > > attention, or recoverable error

pull-request: wireless-drivers 2019-08-21

2019-08-20 Thread Kalle Valo
Hi Dave, here's a pull request to net for 5.3, more info below. I will be offline the next week, but Johannes should be able to help if there are any issues. Kalle The following changes since commit d1abaeb3be7b5fa6d7a1fbbd2e14e3310005c4c1: Linux 5.3-rc5 (2019-08-18 14:31:08 -0700) are avai

linux-next: build failure after merge of the pinctrl tree

2019-08-20 Thread Stephen Rothwell
ader") I have used the pinctrl tree from next-20190820 for today. -- Cheers, Stephen Rothwell pgpkDxkHvyjeO.pgp Description: OpenPGP digital signature

Re: [v2] rtc: pcf85363/pcf85263: fix error that failed to run hwclock -w

2019-08-20 Thread Nandor Han
On 8/16/19 10:40 PM, Li Yang wrote: On Fri, Aug 16, 2019 at 11:30 AM Alexandre Belloni wrote: On 16/08/2019 10:50:49-0500, Li Yang wrote: On Fri, Aug 16, 2019 at 3:05 AM Alexandre Belloni wrote: On 16/08/2019 10:46:36+0800, Biwen Li wrote: Issue: - # hwclock -w hwclock: RTC_SE

RE: [PATCH v2 0/2] Simplify mtty driver and mdev core

2019-08-20 Thread Parav Pandit
> -Original Message- > From: Alex Williamson > Sent: Wednesday, August 21, 2019 10:56 AM > To: Parav Pandit > Cc: Jiri Pirko ; David S . Miller ; > Kirti Wankhede ; Cornelia Huck > ; k...@vger.kernel.org; linux-kernel@vger.kernel.org; > cjia ; net...@vger.kernel.org > Subject: Re: [PAT

[PATCH v1] Bluetooth: hci_qca: Set HCI_QUIRK_SIMULTANEOUS_DISCOVERY for QCA UART Radio

2019-08-20 Thread Rocky Liao
QCA UART Bluetooth controllers can do both LE scan and BR/EDR inquiry at once, need to set HCI_QUIRK_SIMULTANEOUS_DISCOVERY quirk. Signed-off-by: Rocky Liao --- drivers/bluetooth/hci_qca.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hc

linux-next: build warning after merge of the rtc tree

2019-08-20 Thread Stephen Rothwell
Hi all, After merging the rtc tree, today's linux-next build (x86_64 allmodconfig) produced this warning: drivers/rtc/rtc-aspeed.c: In function 'aspeed_rtc_probe': drivers/rtc/rtc-aspeed.c:89:6: warning: unused variable 'ret' [-Wunused-variable] int ret; ^~~ drivers/rtc/rtc-armada38x.c:

Re: [PATCH v8 2/3] fdt: add support for rng-seed

2019-08-20 Thread Ard Biesheuvel
On Wed, 21 Aug 2019 at 08:57, Hsin-Yi Wang wrote: > > Then we'd still use add_device_randomness() in case that bootloader > provides weak entropy. > (please don't top post) Whether to trust the firmware provided entropy is a policy decision, and typically, we try to avoid dictating policy in the

Re: [RT PATCH v2] net/xfrm/xfrm_ipcomp: Protect scratch buffer with local_lock

2019-08-20 Thread Juri Lelli
On 21/08/19 01:43, Li, Philip wrote: > > Subject: Re: [RT PATCH v2] net/xfrm/xfrm_ipcomp: Protect scratch buffer with > > local_lock > > > > Hi, > > > > On 20/08/19 13:35, kbuild test robot wrote: > > > Hi Juri, > > > > > > Thank you for the patch! Yet something to improve: > > > > > > [auto buil

Re: [PATCH] mm/oom: Add oom_score_adj value to oom Killed process message

2019-08-20 Thread Michal Hocko
On Tue 20-08-19 20:25:32, David Rientjes wrote: > On Tue, 20 Aug 2019, Edward Chron wrote: > > > For an OOM event: print oom_score_adj value for the OOM Killed process to > > document what the oom score adjust value was at the time the process was > > OOM Killed. The adjustment value can be set by

Re: PROBLEM: 5.3.0-rc* causes iwlwifi failure

2019-08-20 Thread Sedat Dilek
On Tue, Aug 20, 2019 at 12:45 PM Luciano Coelho wrote: > > On Sat, 2019-08-17 at 17:44 -0400, Stuart Little wrote: > > After some private coaching from Serge Belyshev on git-revert I can > > confirm that reverting that commit atop the current tree resolves the > > issue (the wifi card scans for an

Re: [PATCH v6] perf diff: Report noisy for cycles diff

2019-08-20 Thread Jiri Olsa
On Tue, Aug 20, 2019 at 08:22:07PM +0800, Jin Yao wrote: > This patch prints the stddev and hist for the cycles diff of > program block. It can help us to understand if the cycles > is noisy or not. > > This patch is inspired by Andi Kleen's patch > https://lwn.net/Articles/600471/ > > We create

Re: [PATCH v2] mm: hwpoison: disable memory error handling on 1GB hugepage

2019-08-20 Thread Wanpeng Li
Cc Mel Gorman, Kirill, Dave Hansen, On Tue, 11 Jun 2019 at 07:51, Naoya Horiguchi wrote: > > On Wed, May 29, 2019 at 04:31:01PM -0700, Mike Kravetz wrote: > > On 5/28/19 2:49 AM, Wanpeng Li wrote: > > > Cc Paolo, > > > Hi all, > > > On Wed, 14 Feb 2018 at 06:34, Mike Kravetz > > > wrote: > > >>

Re: [PATCH v2] ALSA: hda/ca0132 - Add new SBZ quirk

2019-08-20 Thread Takashi Iwai
On Mon, 19 Aug 2019 22:40:07 +0200, Paweł Rekowski wrote: > > This patch adds a new PCI subsys ID for the SBZ, as found and tested by > me and some reddit users. > > Signed-off-by: Paweł Rekowski Thanks, applied with Cc to stable. Takashi

Re: [PATCH] ecryptfs: fix a memory leak bug

2019-08-20 Thread Tyler Hicks
On 2019-08-20 00:16:40, Wenwen Wang wrote: > In parse_tag_1_packet(), if tag 1 packet contains a key larger than > ECRYPTFS_MAX_ENCRYPTED_KEY_BYTES, no cleanup is executed, leading to a > memory leak on the allocated 'auth_tok_list_item'. To fix this issue, go to > the label 'out_free' to perform t

linux-next: Tree for Aug 20

2019-08-20 Thread Stephen Rothwell
Hi all, Changes since 20190819: The drm-misc tree gained a conflict against the drm-intel tree. The security tree lost its build failure. Non-merge commits (relative to Linus' tree): 6824 7412 files changed, 368368 insertions(+), 221059 deletions(-) ---

Re: [PATCH] ecryptfs: fix a memory leak bug

2019-08-20 Thread Tyler Hicks
On 2019-08-20 00:33:54, Wenwen Wang wrote: > In ecryptfs_init_messaging(), if the allocation for 'ecryptfs_msg_ctx_arr' > fails, the previously allocated 'ecryptfs_daemon_hash' is not deallocated, > leading to a memory leak bug. To fix this issue, free > 'ecryptfs_daemon_hash' before returning the

Re: [PATCH v3] gpio: pl061: Fix the issue failed to register the ACPI interrtupion

2019-08-20 Thread Linus Walleij
On Mon, Aug 19, 2019 at 5:07 PM Andy Shevchenko wrote: > The proper fix is to revert the culprit since we call > acpi_gpiochip_request_interrupts() for all controllers. > Linus, please re-do the approach with IRQ handling, Exactly what do you refer to when you want me to "re-do the approach for

Re: [PATCH v4 02/10] clk: sunxi-ng: Mark AR100 clocks as critical

2019-08-20 Thread Maxime Ripard
Hi, On Mon, Aug 19, 2019 at 10:23:03PM -0500, Samuel Holland wrote: > On sun8i, sun9i, and sun50i SoCs, system suspend/resume support requires > firmware running on the AR100 coprocessor (the "SCP"). Such firmware can > provide additional features, such as thermal monitoring and poweron/off > supp

Re: [PATCH v4 03/10] dt-bindings: mailbox: Add a sunxi message box binding

2019-08-20 Thread Maxime Ripard
Hi, On Mon, Aug 19, 2019 at 10:23:04PM -0500, Samuel Holland wrote: > This mailbox hardware is present in Allwinner sun8i, sun9i, and sun50i > SoCs. Add a device tree binding for it. > > Reviewed-by: Rob Herring > Signed-off-by: Samuel Holland > --- > .../mailbox/allwinner,sunxi-msgbox.yaml

Re: [v2 PATCH] RISC-V: Optimize tlb flush path.

2019-08-20 Thread Andreas Schwab
On Aug 19 2019, "h...@infradead.org" wrote: > This looks a little odd to m and assumes we never pass a size smaller > than PAGE_SIZE. Whule that is probably true, why not something like: > > if (size < PAGE_SIZE && size != -1) ITYM size <= PAGE_SIZE. And since size is unsigned it cannot

Re: [PATCH RESEND] i386/kvm: support guest access CORE cstate

2019-08-20 Thread Wanpeng Li
Kindly reminder, :) On Mon, 15 Jul 2019 at 17:16, Paolo Bonzini wrote: > > On 15/07/19 03:28, Wanpeng Li wrote: > > From: Wanpeng Li > > > > Allow guest reads CORE cstate when exposing host CPU power management > > capabilities > > to the guest. PKG cstate is restricted to avoid a guest to get t

Re: [v2 PATCH] RISC-V: Optimize tlb flush path.

2019-08-20 Thread h...@infradead.org
On Tue, Aug 20, 2019 at 09:14:58AM +0200, Andreas Schwab wrote: > On Aug 19 2019, "h...@infradead.org" wrote: > > > This looks a little odd to m and assumes we never pass a size smaller > > than PAGE_SIZE. Whule that is probably true, why not something like: > > > > if (size < PAGE_SIZE && s

Re: [PATCH v5 2/6] vfio: Introduce vGPU display irq type

2019-08-20 Thread kra...@redhat.com
> > > +#define VFIO_IRQ_TYPE_GFX(1) > > > +/* > > > + * vGPU vendor sub-type > > > + * vGPU device display related interrupts e.g. vblank/pageflip */ > > > +#define VFIO_IRQ_SUBTYPE_GFX_DISPLAY_IRQ (1) > > > > If this is a GFX/DISPLAY IRQ, why are we talkin

Re: [PATCH v8 19/20] pstore: fs superblock limits

2019-08-20 Thread Kees Cook
On Sun, Aug 18, 2019 at 09:58:16AM -0700, Deepa Dinamani wrote: > Leaving granularity at 1ns because it is dependent on the specific > attached backing pstore module. ramoops has microsecond resolution. > > Fix the readback of ramoops fractional timestamp microseconds, > which has incorrectly been

[PATCH] powerpc/Makefile: Always pass --synthetic to nm if supported

2019-08-20 Thread Michael Ellerman
Back in 2004 we added logic to arch/ppc64/Makefile to pass the --synthetic option to nm, if it was supported by nm. Then in 2005 when arch/ppc64 and arch/ppc were merged, the logic to add --synthetic was moved inside an #ifdef CONFIG_PPC64 block within arch/powerpc/Makefile, and has remained there

Re: linux-next: build failure after merge of the arm64 tree

2019-08-20 Thread Michael Ellerman
Will Deacon writes: > Hi Michael, > > On Fri, Aug 16, 2019 at 02:52:40PM +1000, Michael Ellerman wrote: >> Will Deacon writes: >> > Although Alpha, Itanic and PowerPC all override NM, only PowerPC does it >> > conditionally so I agree with you that passing '--synthetic' >> > unconditionally >> >

[PATCHv2 0/4] Layerscape: Remove num-lanes property from PCIe nodes

2019-08-20 Thread Z.q. Hou
From: Hou Zhiqiang On FSL Layerscape SoCs, the number of lanes assigned to PCIe controller is not fixed, it is determined by the selected SerDes protocol. The current num-lanes indicates the max lanes PCIe controller can support up to, instead of the lanes assigned to the PCIe controller. This ca

Re: Enabling UBSAN breaks KCOV in clang (8.0.*) on arm64

2019-08-20 Thread Nathan Chancellor
On Mon, Aug 19, 2019 at 05:59:48PM +0100, Mark Rutland wrote: > Hi, > > I found that when I enable both KCOV and UBSAN on arm64, clang fails to > emit any __sanitizer_cov_trace_*() calls in the resulting binary, > rendering KCOV useless. > > For example, when building v5.3-rc3's arch/arm64/kernel

[PATCHv2 3/4] ARM: dts: ls1021a: Remove num-lanes property from PCIe nodes

2019-08-20 Thread Z.q. Hou
From: Hou Zhiqiang Remove the num-lanes to avoid the driver setting the link width. On FSL Layerscape SoCs, the number of lanes assigned to PCIe controller is not fixed, it is determined by the selected SerDes protocol in the RCW (Reset Configuration Word), and the PCIe link training is complete

[PATCHv2 2/4] PCI: dwc: Return directly when num-lanes is not found

2019-08-20 Thread Z.q. Hou
From: Hou Zhiqiang The num-lanes is optional, so probably it isn't added on some platforms. The subsequent programming is base on the num-lanes, hence return when it is not found. Signed-off-by: Hou Zhiqiang Reviewed-by: Andrew Murray --- V2: - No change. drivers/pci/controller/dwc/pcie-des

[PATCHv2 1/4] dt-bindings: PCI: designware: Remove the num-lanes from Required properties

2019-08-20 Thread Z.q. Hou
From: Hou Zhiqiang The num-lanes is not a mandatory property, e.g. on FSL Layerscape SoCs, the PCIe link training is completed automatically base on the selected SerDes protocol, it doesn't need the num-lanes to set-up the link width. It is previously in both Required and Optional properties, le

[PATCHv2 4/4] arm64: dts: fsl: Remove num-lanes property from PCIe nodes

2019-08-20 Thread Z.q. Hou
From: Hou Zhiqiang Remove the num-lanes to avoid the driver setting the link width. On FSL Layerscape SoCs, the number of lanes assigned to PCIe controller is not fixed, it is determined by the selected SerDes protocol in the RCW (Reset Configuration Word), and the PCIe link training is complete

Re: [LINUX PATCH v19] mtd: rawnand: pl353: Add basic driver for arm pl353 smc nand interface

2019-08-20 Thread Helmut Grohne
Hi, On Tue, Jul 30, 2019 at 05:43:37AM -0600, Naga Sureshkumar Relli wrote: > Add driver for arm pl353 static memory controller nand interface. > This controller is used in Xilinx Zynq SoC for interfacing the > NAND flash memory. Is there a reason that you dropped me from the Cc list? If you Cc m

Re: Lay common foundation to make PVR/SGX work without hacks on OMAP34xx, OMAP36xx, AM335x and potentially OMAP4, OMAP5

2019-08-20 Thread Merlijn Wajer
Hi, On 20/08/2019 08:48, H. Nikolaus Schaller wrote: > >> Am 19.08.2019 um 21:43 schrieb Adam Ford : >> >>> Thanks to the help from the Pyra community, I was able to get a (binary) >>> reference >>> implementation using DRM that works on Pyra/OMAP5. At least the gles1test1. >> >> just a question

Re: [PATCH v8 2/3] fdt: add support for rng-seed

2019-08-20 Thread Hsin-Yi Wang
Hi Ted, Thanks for raising this question. For UEFI based system, they have a config table that carries rng seed and can be passed to device randomness. However, they also use add_device_randomness (not sure if it's the same reason that they can't guarantee _all_ bootloader can be trusted) This pa

Re: [v2 PATCH] RISC-V: Optimize tlb flush path.

2019-08-20 Thread Andreas Schwab
On Aug 19 2019, Atish Patra wrote: > @@ -42,20 +43,44 @@ static inline void flush_tlb_range(struct vm_area_struct > *vma, > > #include > > -static inline void remote_sfence_vma(struct cpumask *cmask, unsigned long > start, > - unsigned long size) > +static

<    1   2   3   4   5   6   7   8   9   10   >