Re: [PATCH 5/5] ARM: dts: qcom: msm8974: add interconnect nodes

2019-10-23 Thread Georgi Djakov
On 23.10.19 г. 16:39 ч., Georgi Djakov wrote: > On 23.10.19 г. 15:47 ч., Brian Masney wrote: >> On Wed, Oct 23, 2019 at 02:50:19PM +0300, Georgi Djakov wrote: >>> On 13.10.19 г. 11:08 ч., Brian Masney wrote: Add interconnect nodes that's needed to support bus scaling. Signed-off-by:

[PATCH -next] memory: emif: remove set but not used variables 'cs1_used' and 'custom_configs'

2019-10-23 Thread YueHaibing
drivers/memory/emif.c:1616:9: warning: variable cs1_used set but not used [-Wunused-but-set-variable] drivers/memory/emif.c:1624:36: warning: variable custom_configs set but not used [-Wunused-but-set-variable] They are never used since introduction. Signed-off-by: YueHaibing --- drivers/memo

Re: [BUG -tip] kmemleak and stacktrace cause page faul

2019-10-23 Thread Cyrill Gorcunov
On Wed, Oct 23, 2019 at 03:47:57PM +0200, Thomas Gleixner wrote: > > And you are right this happens because cea_exception_stacks is not yet > initialized which makes begin = 0 and therefore point into nirvana. > > So the fix is trivial. Great! Thanks a lot for sych detailed analysis! I'll test t

Re: [patch V2 03/17] x86/traps: Remove pointless irq enable from do_spurious_interrupt_bug()

2019-10-23 Thread Sean Christopherson
On Wed, Oct 23, 2019 at 02:27:08PM +0200, Thomas Gleixner wrote: > That function returns immediately after conditionally reenabling interrupts > which > is more than pointless and requires the ASM code to disable interrupts again. > > Signed-off-by: Thomas Gleixner > --- Reviewed-by: Sean Chris

Re: [PATCH V2] usb: typec: Add sysfs node to show connector orientation

2019-10-23 Thread Puma Hsu
Hi Guenter, I think "unknown" here means that the USB port is disconnected in real usage. Thanks in advance. Puma Hsu On Wed, Oct 23, 2019 at 9:44 PM Guenter Roeck wrote: > > On 10/23/19 1:32 AM, Heikki Krogerus wrote: > > +Guenter > > > > On Tue, Oct 22, 2019 at 04:59:24PM +0800, Puma Hs

[PATCH -next] afs: remove unused variable 'afs_zero_fid'

2019-10-23 Thread YueHaibing
fs/afs/fsclient.c:18:29: warning: afs_zero_fid defined but not used [-Wunused-const-variable=] It is never used since commit 025db80c9e42 ("afs: Trace the initiation and completion of client calls") Reported-by: Hulk Robot Signed-off-by: YueHaibing --- fs/afs/yfsclient.c | 2 -- 1 file change

[PATCH -next] afs: remove set but not used variables 'before' and 'after'

2019-10-23 Thread YueHaibing
fs/afs/dir_edit.c:71:12: warning: variable before set but not used [-Wunused-but-set-variable] fs/afs/dir_edit.c:71:20: warning: variable after set but not used [-Wunused-but-set-variable] fs/afs/dir_edit.c:96:12: warning: variable before set but not used [-Wunused-but-set-variable] fs/afs/dir_e

[PATCH] mm: gup: fix comment of __get_user_pages()

2019-10-23 Thread Liu Xiang
Because nr_pages is unsigned long, it can not be negative. Signed-off-by: Liu Xiang --- mm/gup.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/mm/gup.c b/mm/gup.c index 8f236a3..0236954 100644 --- a/mm/gup.c +++ b/mm/gup.c @@ -735,10 +735,10 @@ static int check_vma_

Re: [PATCH 33/36] ARM: s3c: move low-level clk reg access into platform code

2019-10-23 Thread Arnd Bergmann
On Wed, Oct 23, 2019 at 3:50 PM Krzysztof Kozlowski wrote: > > # common code > > > > -obj-$(CONFIG_S3C2410_CPUFREQ_UTILS) += cpufreq-utils.o > > +obj-$(CONFIG_ARM_S3C24XX_CPUFREQ) += cpufreq-utils.o > > Drop also here S3C2410_CPUFREQ_UTILS entirely. > Ok, done. Arnd

[PATCH -next] cifs: remove unused variable 'sid_user'

2019-10-23 Thread YueHaibing
fs/cifs/cifsacl.c:43:30: warning: sid_user defined but not used [-Wunused-const-variable=] It is never used, so remove it. Signed-off-by: YueHaibing --- fs/cifs/cifsacl.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/fs/cifs/cifsacl.c b/fs/cifs/cifsacl.c index f842944a..06ffe52 100644 -

[PATCH -next] mtd: rawnand: cadence: Remove dev_err() on platform_get_irq() failure

2019-10-23 Thread YueHaibing
platform_get_irq() will call dev_err() itself on failure, so there is no need for the driver to also do this. This is detected by coccinelle. Signed-off-by: YueHaibing --- drivers/mtd/nand/raw/cadence-nand-controller.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/driver

Re: [PATCH 31/36] ARM: s3c: cpufreq: use global s3c2412_cpufreq_setrefresh

2019-10-23 Thread Arnd Bergmann
On Wed, Oct 23, 2019 at 3:44 PM Krzysztof Kozlowski wrote: > On Thu, Oct 10, 2019 at 10:30:15PM +0200, Arnd Bergmann wrote: > > @@ -246,6 +246,7 @@ extern int s3c2412_iotiming_calc(struct > > s3c_cpufreq_config *cfg, > > > > extern void s3c2412_iotiming_set(struct s3c_cpufreq_config *cfg, > >

Re: [BUG -tip] kmemleak and stacktrace cause page faul

2019-10-23 Thread Cyrill Gorcunov
On Wed, Oct 23, 2019 at 03:47:57PM +0200, Thomas Gleixner wrote: > > So the fix is trivial. Works like a charm. Tested-by: Cyrill Gorcunov

Re: [PATCH 2/8] mm: clean up and clarify lruvec lookup procedure

2019-10-23 Thread Michal Hocko
On Tue 22-10-19 10:47:57, Johannes Weiner wrote: > There is a per-memcg lruvec and a NUMA node lruvec. Which one is being > used is somewhat confusing right now, and it's easy to make mistakes - > especially when it comes to global reclaim. > > How it works: when memory cgroups are enabled, we alw

Re: [PATCH v8 1/6] PCI: Consider alignment of hot-added bridges when distributing available resources

2019-10-23 Thread Bjorn Helgaas
On Wed, Oct 23, 2019 at 09:08:42AM +, Nicholas Johnson wrote: > On Tue, Oct 08, 2019 at 02:38:12PM +0300, mika.westerb...@linux.intel.com > wrote: > > On Fri, Jul 26, 2019 at 12:53:19PM +, Nicholas Johnson wrote: > > > /* > > > - * Calculate the total amount of extra resource space we

Re: [PATCH 3/8] mm: vmscan: move inactive_list_is_low() swap check to the caller

2019-10-23 Thread Michal Hocko
On Tue 22-10-19 10:47:58, Johannes Weiner wrote: > inactive_list_is_low() should be about one thing: checking the ratio > between inactive and active list. Kitchensink checks like the one for > swap space makes the function hard to use and modify its > callsites. Luckly, most callers already have a

Re: [PATCH 1/3] perf: Optimize perf_install_in_event()

2019-10-23 Thread Peter Zijlstra
On Wed, Oct 23, 2019 at 03:44:44PM +0200, Peter Zijlstra wrote: > On Wed, Oct 23, 2019 at 03:30:27PM +0300, Alexander Shishkin wrote: > > Peter Zijlstra writes: > > > > > + /* > > > + * perf_event_attr::disabled events will not run and can be initialized > > > + * without IPI. Except when this

Re: [PATCH v2 00/11] gpio: pca953x: Convert to bitmap (extended) API

2019-10-23 Thread Linus Walleij
On Tue, Oct 22, 2019 at 7:29 PM Andy Shevchenko wrote: > While converting gpio-pca953x driver to bitmap API, I noticed that we have > no function to replace bits. > > So, that's how patch 7 appears. Acked-by: Linus Walleij Nice, I see that Andrew picked up the patches so no action required fro

Re: [PATCH 11/36] ARM: s5pv210: split from plat-samsung

2019-10-23 Thread Krzysztof Kozlowski
On Wed, Oct 23, 2019 at 03:17:35PM +0200, Arnd Bergmann wrote: > On Wed, Oct 23, 2019 at 2:15 PM Krzysztof Kozlowski wrote: > > On Thu, Oct 10, 2019 at 10:29:55PM +0200, Arnd Bergmann wrote: > > > These can be build completely independently, so split > > > the two Kconfig symbols. > > > conf

Re: [PATCH v3 1/2] sched/topology: Don't try to build empty sched domains

2019-10-23 Thread Valentin Schneider
On 23/10/2019 12:46, Dietmar Eggemann wrote: > Can you not just prevent that a cpuset pointer (cp) is added to the > cpuset array (csa[]) in case cpumask_empty(cp->effective_cpus)? > > @@ -798,9 +800,14 @@ static int generate_sched_domains(cpumask_var_t > **domains, cpumask_subset(cp->cpus_allowed

Re: [PATCH 4/8] mm: vmscan: naming fixes: global_reclaim() and sane_reclaim()

2019-10-23 Thread Michal Hocko
On Tue 22-10-19 10:47:59, Johannes Weiner wrote: > Seven years after introducing the global_reclaim() function, I still > have to double take when reading a callsite. I don't know how others > do it, this is a terrible name. I somehow never had problem with that but ... > > Invert the meaning and

Re: [patch V2 04/17] x86/entry: Make DEBUG_ENTRY_ASSERT_IRQS_OFF available for 32bit

2019-10-23 Thread Sean Christopherson
On Wed, Oct 23, 2019 at 02:27:09PM +0200, Thomas Gleixner wrote: > Move the interrupt state verification debug macro to common code and fixup > the irqflags and paravirt components so it can be used in 32bit code later. > > Signed-off-by: Thomas Gleixner > --- Reviewed-by: Sean Christopherson

Re: [patch V2 05/17] x86/traps: Make interrupt enable/disable symmetric in C code

2019-10-23 Thread Sean Christopherson
On Wed, Oct 23, 2019 at 02:27:10PM +0200, Thomas Gleixner wrote: > Traps enable interrupts conditionally but rely on the ASM return code to > disable them again. That results in redundant interrupt disable and trace > calls. > > Make the trap handlers disable interrupts before returning to avoid t

RE: [PATCHv2] arm64: defconfig: add JFFS FS support in defconfig

2019-10-23 Thread Ooi, Joyce
> -Original Message- > From: Dinh Nguyen > Sent: Monday, October 21, 2019 11:57 PM > To: Ooi, Joyce ; Vladimir Murzin > ; Catalin Marinas ; Will > Deacon > Cc: Shawn Guo ; Olof Johansson ; > Maxime Ripard ; Bjorn Andersson > ; Arnd Bergmann ; Jagan Teki > ; Anson Huang ; > Leonard Crest

Re: [patch V2 06/17] x86/entry/32: Remove redundant interrupt disable

2019-10-23 Thread Sean Christopherson
On Wed, Oct 23, 2019 at 02:27:11PM +0200, Thomas Gleixner wrote: > Now that the trap handlers return with interrupts disabled, the > unconditional disabling of interrupts in the low level entry code can be > removed along with the trace calls and the misnomed preempt_stop macro. > As a consequence

Re: [PATCH 5/8] mm: vmscan: replace shrink_node() loop with a retry jump

2019-10-23 Thread Michal Hocko
On Tue 22-10-19 10:48:00, Johannes Weiner wrote: > Most of the function body is inside a loop, which imposes an > additional indentation and scoping level that makes the code a bit > hard to follow and modify. I do agree! > The looping only happens in case of reclaim-compaction, which isn't > the

Re: [patch V2 07/17] x86/entry/64: Remove redundant interrupt disable

2019-10-23 Thread Sean Christopherson
On Wed, Oct 23, 2019 at 02:27:12PM +0200, Thomas Gleixner wrote: > Now that the trap handlers return with interrupts disabled, the > unconditional disabling of interrupts in the low level entry code can be > removed along with the trace calls. > > Add debug checks where appropriate. > > Signed-of

Re: [PATCH 6/8] mm: vmscan: turn shrink_node_memcg() into shrink_lruvec()

2019-10-23 Thread Michal Hocko
On Tue 22-10-19 10:48:01, Johannes Weiner wrote: > A lruvec holds LRU pages owned by a certain NUMA node and cgroup. > Instead of awkwardly passing around a combination of a pgdat and a > memcg pointer, pass down the lruvec as soon as we can look it up. > > Nested callers that need to access node

Re: [PATCH 7/8] mm: vmscan: split shrink_node() into node part and memcgs part

2019-10-23 Thread Michal Hocko
On Tue 22-10-19 10:48:02, Johannes Weiner wrote: > This function is getting long and unwieldy, split out the memcg bits. > > The updated shrink_node() handles the generic (node) reclaim aspects: > - global vmpressure notifications > - writeback and congestion throttling > - reclaim/compactio

[PATCH] Input: hp_sdc_rtc - remove dead chardev code

2019-10-23 Thread Arnd Bergmann
The driver contains half of the implementation of /dev/rtc, but this was never completed, and it is now incompatible with the drivers/rtc framework. Remove the chardev completely. If anyone wants to add the functionality later, that shoudl be done through rtc_register_device(). The remaining port

Re: [PATCH] mm: gup: fix comment of __get_user_pages()

2019-10-23 Thread David Hildenbrand
On 23.10.19 15:51, Liu Xiang wrote: > Because nr_pages is unsigned long, it can not be negative. > > Signed-off-by: Liu Xiang > --- > mm/gup.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/mm/gup.c b/mm/gup.c > index 8f236a3..0236954 100644 > --- a/mm/gup.c >

Re: [PATCH v2 1/1] PCI: Add hp_mmio_size and hp_mmio_pref_size parameters

2019-10-23 Thread Bjorn Helgaas
On Wed, Oct 23, 2019 at 12:12:29PM +, Nicholas Johnson wrote: > Add kernel parameter pci=hpmmiosize=nn[KMG] to set MMIO bridge window > size for hotplug bridges. > > Add kernel parameter pci=hpmmioprefsize=nn[KMG] to set MMIO_PREF bridge > window size for hotplug bridges. > > Leave pci=hpmems

Re: [PATCH v3 3/5] perf report: Sort by sampled cycles percent per block for stdio

2019-10-23 Thread Jiri Olsa
On Wed, Oct 23, 2019 at 09:09:34PM +0800, Jin, Yao wrote: > > > On 10/23/2019 7:36 PM, Jiri Olsa wrote: > > On Tue, Oct 22, 2019 at 04:07:08PM +0800, Jin Yao wrote: > > > > SNIP > > > > > diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c > > > index cdb436d6e11f..44aed40e90

Re: [PATCH V2] usb: typec: Add sysfs node to show connector orientation

2019-10-23 Thread Heikki Krogerus
On Wed, Oct 23, 2019 at 06:44:39AM -0700, Guenter Roeck wrote: > On 10/23/19 1:32 AM, Heikki Krogerus wrote: > > +Guenter > > > > On Tue, Oct 22, 2019 at 04:59:24PM +0800, Puma Hsu wrote: > > > Export the Type-C connector orientation so that user space > > > can get this information. > > > > > >

Re: [Y2038] [PATCH v6 10/43] compat_ioctl: move rtc handling into rtc-dev.c

2019-10-23 Thread Arnd Bergmann
On Wed, Oct 23, 2019 at 12:29 PM Alexandre Belloni wrote: > On 22/10/2019 14:14:21+0200, Arnd Bergmann wrote: > > On Tue, Oct 22, 2019 at 6:30 AM Al Viro wrote: > > > > I don't see any chance that this code is revived. If anyone wanted to > > make it work, the right approach would be to use the r

Re: [PATCH] mm/vmstat: Reduce zone lock hold time when reading /proc/pagetypeinfo

2019-10-23 Thread Waiman Long
On 10/22/19 5:59 PM, Andrew Morton wrote: > On Tue, 22 Oct 2019 12:21:56 -0400 Waiman Long wrote: > >> The pagetypeinfo_showfree_print() function prints out the number of >> free blocks for each of the page orders and migrate types. The current >> code just iterates the each of the free lists to g

Re: [PATCH v2 4/9] perf affinity: Add infrastructure to save/restore affinity

2019-10-23 Thread Jiri Olsa
On Wed, Oct 23, 2019 at 06:02:35AM -0700, Andi Kleen wrote: > On Wed, Oct 23, 2019 at 11:59:11AM +0200, Jiri Olsa wrote: > > On Sun, Oct 20, 2019 at 10:51:57AM -0700, Andi Kleen wrote: > > > > SNIP > > > > > +} > > > diff --git a/tools/perf/util/affinity.h b/tools/perf/util/affinity.h > > > new f

Re: [PATCH -next] virtiofs: remove unused variable 'fc'

2019-10-23 Thread Stefan Hajnoczi
On Wed, Oct 23, 2019 at 02:21:30PM +0800, YueHaibing wrote: > fs/fuse/virtio_fs.c:983:20: warning: > variable fc set but not used [-Wunused-but-set-variable] > > It is not used since commit 7ee1e2e631db ("virtiofs: > No need to check fpq->connected state") > > Signed-off-by: YueHaibing > --- >

Re: [RFC PATCH 2/2] mm, vmstat: reduce zone->lock holding time by /proc/pagetypeinfo

2019-10-23 Thread Michal Hocko
On Wed 23-10-19 15:48:36, Vlastimil Babka wrote: > On 10/23/19 3:37 PM, Michal Hocko wrote: > > On Wed 23-10-19 15:32:05, Vlastimil Babka wrote: > >> On 10/23/19 12:27 PM, Michal Hocko wrote: > >>> From: Michal Hocko > >>> > >>> pagetypeinfo_showfree_print is called by zone->lock held in irq mode.

Re: [PATCH] mm/page_alloc: fix gcc compile warning

2019-10-23 Thread Michal Hocko
On Wed 23-10-19 21:48:28, Chen Wandun wrote: > From: Chenwandun > > mm/page_alloc.o: In function `page_alloc_init_late': > mm/page_alloc.c:1956: undefined reference to `zone_pcp_update' > mm/page_alloc.o:(.debug_addr+0x8350): undefined reference to `zone_pcp_update' > make: *** [vmlinux] Error 1

Re: [PATCH 1/2] configs: ARM: omap2plus: Enable OMAP3_THERMAL

2019-10-23 Thread Tony Lindgren
* H. Nikolaus Schaller [191023 04:42]: > > > Am 23.10.2019 um 00:19 schrieb Tony Lindgren : > > > > * Adam Ford [191022 19:01]: > >> On Tue, Oct 22, 2019 at 11:22 AM Tony Lindgren wrote: > >>> > >>> Hi, > >>> > >>> * Adam Ford [191007 15:06]: > The some in the OMAP3 family have a bandg

Re: [Y2038] [PATCH v6 10/43] compat_ioctl: move rtc handling into rtc-dev.c

2019-10-23 Thread Alexandre Belloni
On 23/10/2019 16:28:40+0200, Arnd Bergmann wrote: > On Wed, Oct 23, 2019 at 12:29 PM Alexandre Belloni > wrote: > > On 22/10/2019 14:14:21+0200, Arnd Bergmann wrote: > > > On Tue, Oct 22, 2019 at 6:30 AM Al Viro wrote: > > > > > > I don't see any chance that this code is revived. If anyone wanted

Re: linux-next: Signed-off-by missing for commit in the omap tree

2019-10-23 Thread Tony Lindgren
* Stephen Rothwell [191022 20:11]: > Hi all, > > Commit > > 40f3ee0ea7f1 ("ARM: OMAP2+: Drop legacy platform data for dra7 rng") > > is missing a Signed-off-by from its author and committer. Oops sorry about that, will fix it. Regards, Tony

[PATCH] phy: ti: gmii-sel: fix mac tx internal delay for rgmii-rxid

2019-10-23 Thread Grygorii Strashko
Now phy-gmii-sel will disable MAC TX internal delay for PHY interface mode "rgmii-rxid" which is incorrect. Hence, fix it by enabling MAC TX internal delay in the case of "rgmii-rxid" mode. Signed-off-by: Grygorii Strashko --- drivers/phy/ti/phy-gmii-sel.c | 2 +- 1 file changed, 1 insertion(+),

Re: [patch V2 17/17] x86/kvm: Use generic exit to guest work function

2019-10-23 Thread Sean Christopherson
On Wed, Oct 23, 2019 at 02:27:22PM +0200, Thomas Gleixner wrote: > Use the generic infrastructure to check for and handle pending work before > entering into guest mode. > > Signed-off-by: Thomas Gleixner > --- > arch/x86/kvm/Kconfig |1 + > arch/x86/kvm/x86.c | 17 + > 2

Re: [PATCH] mm/vmstat: Reduce zone lock hold time when reading /proc/pagetypeinfo

2019-10-23 Thread Qian Cai
On Wed, 2019-10-23 at 10:30 -0400, Waiman Long wrote: > On 10/22/19 5:59 PM, Andrew Morton wrote: > > On Tue, 22 Oct 2019 12:21:56 -0400 Waiman Long wrote: > > > > > The pagetypeinfo_showfree_print() function prints out the number of > > > free blocks for each of the page orders and migrate types

Re: [patch V2 00/17] entry: Provide generic implementation for host and guest entry/exit work

2019-10-23 Thread Peter Zijlstra
On Wed, Oct 23, 2019 at 02:27:05PM +0200, Thomas Gleixner wrote: > /Makefile |3 > arch/Kconfig |3 > arch/x86/Kconfig |1 > arch/x86/entry/calling.h | 12 + > arch/x86/entry/common.c

Re: [PATCH] gpio: bd70528: Add MODULE ALIAS to autoload module

2019-10-23 Thread Bartosz Golaszewski
śr., 23 paź 2019 o 14:22 Matti Vaittinen napisał(a): > > The bd70528 GPIO driver is probed by MFD driver. Add MODULE_ALIAS > in order to allow udev to load the module when MFD sub-device cell > for GPIO is added. > > Fixes: 18bc64b3aebfa ("gpio: Initial support for ROHM bd70528 GPIO block") > Sign

[PATCH 0/2] net: phy: dp83867: enable robust auto-mdix

2019-10-23 Thread Grygorii Strashko
Hi Patch 1 - improves link detection when dp83867 PHY is configured in manual mode by enabling CFG3[9] Robust Auto-MDIX option. Patch 2 - is minor optimization. Grygorii Strashko (2): net: phy: dp83867: enable robust auto-mdix net: phy: dp83867: move dt parsing to probe drivers/net/phy/dp8

[PATCH 2/2] net: phy: dp83867: move dt parsing to probe

2019-10-23 Thread Grygorii Strashko
Move DT parsing code to probe dp83867_probe() as it's one time operation. Signed-off-by: Grygorii Strashko --- drivers/net/phy/dp83867.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/net/phy/dp83867.c b/drivers/net/phy/dp83867.c index cf4455bbf888..5816a06a9439

Re: [RESEND PATCHv1] arm64: defconfig: enable rsu driver

2019-10-23 Thread Dinh Nguyen
On 10/17/19 3:15 PM, richard.g...@linux.intel.com wrote: > From: Richard Gong > > Enable Intel Stratix10 Remote System Update (RSU) driver > > The Intel Remote System Update (RSU) driver provides a way for customers > to update the boot configuration of a Intel Stratix 10 SoC device with > si

Re: [PATCH v3 3/5] perf report: Sort by sampled cycles percent per block for stdio

2019-10-23 Thread Jin, Yao
On 10/23/2019 10:27 PM, Jiri Olsa wrote: On Wed, Oct 23, 2019 at 09:09:34PM +0800, Jin, Yao wrote: On 10/23/2019 7:36 PM, Jiri Olsa wrote: On Tue, Oct 22, 2019 at 04:07:08PM +0800, Jin Yao wrote: SNIP diff --git a/tools/perf/builtin-report.c b/tools/perf/builtin-report.c index cdb436d6e

Re: [PATCH v2 4/9] perf affinity: Add infrastructure to save/restore affinity

2019-10-23 Thread Andi Kleen
On Wed, Oct 23, 2019 at 04:30:49PM +0200, Jiri Olsa wrote: > On Wed, Oct 23, 2019 at 06:02:35AM -0700, Andi Kleen wrote: > > On Wed, Oct 23, 2019 at 11:59:11AM +0200, Jiri Olsa wrote: > > > On Sun, Oct 20, 2019 at 10:51:57AM -0700, Andi Kleen wrote: > > > > > > SNIP > > > > > > > +} > > > > diff

Re: [RFC PATCH 1/2] mm, vmstat: hide /proc/pagetypeinfo from normal users

2019-10-23 Thread Waiman Long
On 10/23/19 6:27 AM, Michal Hocko wrote: > From: Michal Hocko > > /proc/pagetypeinfo is a debugging tool to examine internal page > allocator state wrt to fragmentation. It is not very useful for > any other use so normal users really do not need to read this file. > > Waiman Long has noticed that

[PATCH 1/2] net: phy: dp83867: enable robust auto-mdix

2019-10-23 Thread Grygorii Strashko
The link detection timeouts can be observed (or link might not be detected at all) when dp83867 PHY is configured in manual mode (speed/duplexity). CFG3[9] Robust Auto-MDIX option allows significantly improve link detection in case dp83867 is configured in manual mode and reduce link detection tim

Re: [PATCH v1 3/6] KEYS: ima hook to measure builtin_trusted_keys

2019-10-23 Thread Lakshmi Ramasubramanian
On 10/23/19 6:22 AM, Mimi Zohar wrote: Thanks for reviewing the changes Mimi. I'll address your comments and post an updated patch set shortly. Add a new ima hook to measure keys added to builtin_trusted_keys keyring. There is no IMA hook in this patch. + else if (st

Re: [PATCH v6 2/2] soc: amazon: al-pos-edac: Introduce Amazon's Annapurna Labs POS EDAC driver

2019-10-23 Thread Shenhar, Talel
On 10/21/2019 7:42 PM, James Morse wrote: Hi Talel, On 10/10/2019 12:41, Talel Shenhar wrote: The Amazon's Annapurna Labs SoCs includes Point Of Serialization error logging unit that reports an error in case write error (e.g . Attempt to (This is tricky to parse. "error in case write error"

Re: [patch V2 16/17] kvm/workpending: Provide infrastructure for work before entering a guest

2019-10-23 Thread Sean Christopherson
On Wed, Oct 23, 2019 at 02:27:21PM +0200, Thomas Gleixner wrote: > Entering a guest is similar to exiting to user space. Pending work like > handling signals, rescheduling, task work etc. needs to be handled before > that. > > Provide generic infrastructure to avoid duplication of the same handlin

Re: [RFC PATCH 2/2] mm, vmstat: reduce zone->lock holding time by /proc/pagetypeinfo

2019-10-23 Thread Waiman Long
On 10/23/19 6:27 AM, Michal Hocko wrote: > From: Michal Hocko > > pagetypeinfo_showfree_print is called by zone->lock held in irq mode. > This is not really nice because it blocks both any interrupts on that > cpu and the page allocator. On large machines this might even trigger > the hard lockup

Re: [PATCH 3/3] vhost, kcov: collect coverage from vhost_worker

2019-10-23 Thread Andrey Konovalov
On Wed, Oct 23, 2019 at 3:50 PM Dmitry Vyukov wrote: > > On Wed, Oct 23, 2019 at 3:35 PM Andrey Konovalov > wrote: > > > > On Wed, Oct 23, 2019 at 10:36 AM Dmitry Vyukov wrote: > > > > > > On Tue, Oct 22, 2019 at 6:46 PM Andrey Konovalov > > > wrote: > > > > > > > > This patch adds kcov_remot

Re: [PATCH] mm/vmstat: Reduce zone lock hold time when reading /proc/pagetypeinfo

2019-10-23 Thread Waiman Long
On 10/23/19 10:48 AM, Qian Cai wrote: >>> this still isn't a bulletproof fix. Maybe just terminate the list >>> walk if freecount reaches 1024. Would anyone really care? >>> >>> Sigh. I wonder if anyone really uses this thing for anything >>> important. Can we just remove it all? >>> >> Removin

Re: [PATCH V2] usb: typec: Add sysfs node to show connector orientation

2019-10-23 Thread Guenter Roeck
On Wed, Oct 23, 2019 at 05:29:00PM +0300, Heikki Krogerus wrote: > On Wed, Oct 23, 2019 at 06:44:39AM -0700, Guenter Roeck wrote: > > On 10/23/19 1:32 AM, Heikki Krogerus wrote: > > > +Guenter > > > > > > On Tue, Oct 22, 2019 at 04:59:24PM +0800, Puma Hsu wrote: > > > > Export the Type-C connector

Re: [PATCH] watchdog: bd70528: Add MODULE_ALIAS to allow module auto loading

2019-10-23 Thread Guenter Roeck
On Wed, Oct 23, 2019 at 03:41:59PM +0300, Matti Vaittinen wrote: > The bd70528 watchdog driver is probed by MFD driver. Add MODULE_ALIAS > in order to allow udev to load the module when MFD sub-device cell for > watchdog is added. > > Fixes: bbc88a0ec9f37 ("watchdog: bd70528: Initial support for R

Re: [Y2038] [PATCH v6 10/43] compat_ioctl: move rtc handling into rtc-dev.c

2019-10-23 Thread Arnd Bergmann
On Wed, Oct 23, 2019 at 4:34 PM Alexandre Belloni wrote: > On 23/10/2019 16:28:40+0200, Arnd Bergmann wrote: > > Ok, done. Speaking of removing rtc drivers, should we just kill off > > drivers/char/rtc.c and drivers/char/efirtc.c as well? I don't remember > > why we left them in the tree, but I'm

[PATCH 1/2] rtc/ia64: remove legacy efirtc driver

2019-10-23 Thread Arnd Bergmann
There are two EFI RTC drivers, the original drivers/char/efirtc.c driver and the more modern drivers/rtc/rtc-efi.c. Both implement the same interface, but the new one does so in a more portable way. Move everything over to that one and remove the old one. Cc: linux-i...@vger.kernel.org Cc: Fengh

Re: [PATCH] mm/vmstat: Reduce zone lock hold time when reading /proc/pagetypeinfo

2019-10-23 Thread Qian Cai
On Wed, 2019-10-23 at 11:01 -0400, Waiman Long wrote: > On 10/23/19 10:48 AM, Qian Cai wrote: > > > > this still isn't a bulletproof fix. Maybe just terminate the list > > > > walk if freecount reaches 1024. Would anyone really care? > > > > > > > > Sigh. I wonder if anyone really uses this thi

Re: [PATCH net-next 11/14] vsock: add multi-transports support

2019-10-23 Thread Stefano Garzarella
On Wed, Oct 23, 2019 at 11:59 AM Stefano Garzarella wrote: > > This patch adds the support of multiple transports in the > VSOCK core. > > With the multi-transports support, we can use vsock with nested VMs > (using also different hypervisors) loading both guest->host and > host->guest transports

Re: [PATCH v2 4/4] perf/x86/intel/pt: Opportunistically use single range output mode

2019-10-23 Thread Alexander Shishkin
Alexander Shishkin writes: > diff --git a/arch/x86/events/intel/pt.c b/arch/x86/events/intel/pt.c > index 2f20d5a333c1..6edd7b785861 100644 > --- a/arch/x86/events/intel/pt.c > +++ b/arch/x86/events/intel/pt.c > @@ -491,7 +491,9 @@ static void pt_config(struct perf_event *event) > } > >

Re: [PATCH] drm/radeon: remove assignment for return value

2019-10-23 Thread Harry Wentland
On 2019-10-19 3:32 a.m., Wambui Karuga wrote: > Remove unnecessary assignment for return value and have the > function return the required value directly. > Issue found by coccinelle: > @@ > local idexpression ret; > expression e; > @@ > > -ret = > +return > e; > -return ret; > > Signed-off-

Re: [RFC PATCH 1/2] mm, vmstat: hide /proc/pagetypeinfo from normal users

2019-10-23 Thread Rafael Aquini
On Wed, Oct 23, 2019 at 12:27:36PM +0200, Michal Hocko wrote: > From: Michal Hocko > > /proc/pagetypeinfo is a debugging tool to examine internal page > allocator state wrt to fragmentation. It is not very useful for > any other use so normal users really do not need to read this file. > > Waima

[PATCH 1/2] perf/x86/amd/ibs: Fix reading of the IBS OpData register and thus precise RIP validity

2019-10-23 Thread Kim Phillips
The loop that reads all the IBS MSRs into *buf stopped one MSR short of reading the IbsOpData register, which contains the RipInvalid status bit. Fix the offset_max assignment so the MSR gets read, so the RIP invalid evaluation is based on what the IBS h/w output, instead of what was left in memor

[PATCH 2/2] perf/x86/amd/ibs: handle erratum #420 only on the affected CPU family (10h)

2019-10-23 Thread Kim Phillips
This saves us writing the IBS control MSR twice when disabling the event. I searched revision guides for all families since 10h, and did not find occurrence of erratum #420, nor anything remotely similar: so we isolate the secondary MSR write to family 10h only. Also unconditionally update the co

Re: [PATCH 1/1] spi: mediatek: add power control when set_cs

2019-10-23 Thread Mark Brown
On Wed, Oct 23, 2019 at 08:38:42AM -0400, Luhua Xu wrote: > From: "luhua.xu" > Use runtime PM to power spi when set_cs > As set_cs may be called from interrupt context, > set runtime PM IRQ safe for spi. Why might we be trying to set the chip select state while the device is runtime idle? It se

Re: [PATCH 0/1] Add spi power control when set cs

2019-10-23 Thread Mark Brown
On Wed, Oct 23, 2019 at 08:38:41AM -0400, Luhua Xu wrote: > This patch add power control when set spi cs to fix register > access violation. Please don't send cover letters for single patches, if there is anything that needs saying put it in the changelog of the patch or after the --- if it's admi

Re: Kernel panic while doing vfio-pci hot-plug/unplug test

2019-10-23 Thread Bjorn Helgaas
On Wed, Oct 23, 2019 at 05:40:20PM +0800, Xiang Zheng wrote: > Hi Bjorn, > > Thanks for your reply! > > On 2019/10/18 21:58, Bjorn Helgaas wrote: > > [+cc Matthew] > > > > On Wed, Oct 16, 2019 at 09:36:23PM +0800, Xiang Zheng wrote: > >> Hi all, > >> > >> Recently I encountered a kernel panic wh

Re: [PATCH v12 2/6] mm: Use zone and order instead of free area in free_list manipulators

2019-10-23 Thread Alexander Duyck
On Wed, 2019-10-23 at 10:26 +0200, David Hildenbrand wrote: > On 23.10.19 00:28, Alexander Duyck wrote: > > From: Alexander Duyck > > > > In order to enable the use of the zone from the list manipulator functions > > I will need access to the zone pointer. As it turns out most of the > > accessor

Re: [PATCH v4 15/16] module: Move where we mark modules RO,X

2019-10-23 Thread Peter Zijlstra
On Wed, Oct 23, 2019 at 01:48:35PM +0200, Peter Zijlstra wrote: > On Mon, Oct 21, 2019 at 04:14:02PM +0200, Peter Zijlstra wrote: > > On Mon, Oct 21, 2019 at 08:53:12AM -0500, Josh Poimboeuf wrote: > > > > Doesn't livepatch code also need to be modified? We have: > > > > Urgh bah.. I was too foc

[PATCH] ASoC: Intel: eve: Enable mclk and ssp sclk early for rt5514

2019-10-23 Thread Brent Lu
The first DMIC capture always fail (zero sequence data from PCM port) after using DSP hotwording function (i.e. Google assistant). The DMIC is attached to rt5514 which also require eaily mclk/sclk like rt5663. Therefore we add a dapm route to provide ssp mclk/sclk early to rt5514. The rt5514 is att

DEAR I NEED YOUR URGENT RESPONSE

2019-10-23 Thread MR.Abderazack Zebdani
Greetings My Dear Friend, Before I introduce myself, I wish to inform you that this letter is not a hoax mail and I urge you to treat it serious.This letter must come to you as a big surprise, but I believe it is only a day that people meet and become great friends and business partners. Ple

Re: [RFC PATCH 2/2] mm, vmstat: reduce zone->lock holding time by /proc/pagetypeinfo

2019-10-23 Thread Waiman Long
On 10/23/19 10:56 AM, Waiman Long wrote: > On 10/23/19 6:27 AM, Michal Hocko wrote: >> From: Michal Hocko >> >> pagetypeinfo_showfree_print is called by zone->lock held in irq mode. >> This is not really nice because it blocks both any interrupts on that >> cpu and the page allocator. On large mac

Re: [PATCH] Input: hp_sdc_rtc - remove dead chardev code

2019-10-23 Thread Alexandre Belloni
On 23/10/2019 16:25:02+0200, Arnd Bergmann wrote: > The driver contains half of the implementation of /dev/rtc, but this > was never completed, and it is now incompatible with the drivers/rtc > framework. > > Remove the chardev completely. If anyone wants to add the functionality > later, that sho

Re: [PATCH v6 1/2] dt-bindings: edac: arm-dmc520.txt

2019-10-23 Thread Rob Herring
On Wed, Oct 23, 2019 at 8:22 AM James Morse wrote: > > Hi Lei, > > On 21/10/2019 18:36, Lei Wang wrote: > >> It looks like your patches didn't make it to the mailing list: > >> https://lore.kernel.org/r/by5pr04mb6599eaa659a53b2331cb812586...@by5pr04mb6599.namprd04.prod.outlook.com > >> > >> You ca

Re: [PATCH 1/2] rtc/ia64: remove legacy efirtc driver

2019-10-23 Thread Alexandre Belloni
On 23/10/2019 17:01:58+0200, Arnd Bergmann wrote: > There are two EFI RTC drivers, the original drivers/char/efirtc.c > driver and the more modern drivers/rtc/rtc-efi.c. > > Both implement the same interface, but the new one does so > in a more portable way. > > Move everything over to that one a

Re: [PATCH] mm/vmstat: Reduce zone lock hold time when reading /proc/pagetypeinfo

2019-10-23 Thread Rafael Aquini
On Wed, Oct 23, 2019 at 10:48:13AM -0400, Qian Cai wrote: > On Wed, 2019-10-23 at 10:30 -0400, Waiman Long wrote: > > On 10/22/19 5:59 PM, Andrew Morton wrote: > > > On Tue, 22 Oct 2019 12:21:56 -0400 Waiman Long wrote: > > > > > > > The pagetypeinfo_showfree_print() function prints out the numbe

[PATCH v2 0/3] kcov: collect coverage from usb and vhost

2019-10-23 Thread Andrey Konovalov
This patchset extends kcov to allow collecting coverage from the USB subsystem and vhost workers. See the first patch description for details about the kcov extension. The other two patches apply this kcov extension to USB and vhost. These patches have been used to enable coverage-guided USB fuzzi

[PATCH v2 1/3] kcov: remote coverage support

2019-10-23 Thread Andrey Konovalov
This patch adds background thread coverage collection ability to kcov. With KCOV_ENABLE coverage is collected only for syscalls that are issued from the current process. With KCOV_REMOTE_ENABLE it's possible to collect coverage for arbitrary parts of the kernel code, provided that those parts are

[PATCH v2 2/3] usb, kcov: collect coverage from hub_event

2019-10-23 Thread Andrey Konovalov
This patch adds kcov_remote_start()/kcov_remote_stop() annotations to the hub_event() function, which is responsible for processing events on USB buses, in particular events that happen during USB device enumeration. Since hub_event() is run in a global background kernel thread (see Documentation/d

[PATCH v2 3/3] vhost, kcov: collect coverage from vhost_worker

2019-10-23 Thread Andrey Konovalov
This patch adds kcov_remote_start()/kcov_remote_stop() annotations to the vhost_worker() function, which is responsible for processing vhost works. Since vhost_worker() threads are spawned per vhost device instance the common kcov handle is used for kcov_remote_start()/stop() annotations (see Docum

[PATCH] net: ethernet: Use the correct style for SPDX License Identifier

2019-10-23 Thread Nishad Kamdar
This patch corrects the SPDX License Identifier style in header file related to ethernet driver for Cortina Gemini devices. For C header files Documentation/process/license-rules.rst mandates C-like comments (opposed to C source files where C++ style should be used) Changes made by using a script

Re: [PATCH v6 11/43] compat_ioctl: move drivers to compat_ptr_ioctl

2019-10-23 Thread Arnd Bergmann
On Wed, Oct 23, 2019 at 5:17 AM Al Viro wrote: > > On Tue, Oct 22, 2019 at 12:26:09PM +0200, Arnd Bergmann wrote: > > On Tue, Oct 22, 2019 at 6:34 AM Al Viro wrote: > > > > > > On Wed, Oct 09, 2019 at 09:10:11PM +0200, Arnd Bergmann wrote: > > > > Each of these drivers has a copy of the same triv

Re: [PATCH] perf/core: fix multiplexing event scheduling issue

2019-10-23 Thread Peter Zijlstra
On Wed, Oct 23, 2019 at 11:37:57AM +0200, Peter Zijlstra wrote: > Further, since we set it on reschedule, I propose you change the above > like: > > if (ctx->rotate_necessary) { > int type = get_event_type(event); > /* >* comment.. >

[PATCH v1] gpio: pca953x: Reduce stack usage in couple of functions

2019-10-23 Thread Andy Shevchenko
Simple bitmap operations are safe against in-place modifications. Due to above we may get rid of temporary variables in some cases. Signed-off-by: Andy Shevchenko --- Andrew, it can be folded into "gpio: pca953x: Convert to use bitmap API" drivers/gpio/gpio-pca953x.c | 10 -- 1 file ch

Re: [PATCH] mmc: renesas_sdhi: add checks for pinctrl_lookup_state

2019-10-23 Thread Wolfram Sang
On Mon, Oct 21, 2019 at 04:32:49PM +0200, Ulf Hansson wrote: > On Fri, 18 Oct 2019 at 15:13, Chuhong Yuan wrote: > > > > renesas_sdhi_probe misses checks for pinctrl_lookup_state and may miss > > failures. > > Add checks for them to fix the problem. > > > > Signed-off-by: Chuhong Yuan > > --- > >

Re: [PATCH] MAINTAINERS: Update the Spreadtrum SoC maintainer

2019-10-23 Thread Olof Johansson
On Wed, Oct 23, 2019 at 5:17 AM Arnd Bergmann wrote: > > On Wed, Oct 23, 2019 at 1:06 PM Baolin Wang wrote: > > +F: drivers/power/reset/sc27xx-poweroff.c > > +F: drivers/leds/leds-sc27xx-bltc.c > > +F: drivers/input/misc/sc27xx-vibra.c > > +F: drivers/power/supply/sc27xx_fuel_gaug

Re: [PATCH v6 1/2] dt-bindings: edac: arm-dmc520.txt

2019-10-23 Thread Rob Herring
On Thu, Sep 19, 2019 at 1:37 PM Lei Wang wrote: > > This is the device tree bindings for new EDAC driver dmc520_edac.c. > > Signed-off-by: Lei Wang > Reviewed-by: James Morse > > --- > No change in v6. > --- > .../devicetree/bindings/edac/arm-dmc520.txt | 26 +++ > 1 file

Re: [PATCH 2/2] net: phy: dp83867: move dt parsing to probe

2019-10-23 Thread Andrew Lunn
On Wed, Oct 23, 2019 at 05:48:46PM +0300, Grygorii Strashko wrote: > Move DT parsing code to probe dp83867_probe() as it's one time operation. > > Signed-off-by: Grygorii Strashko Reviewed-by: Andrew Lunn Andrew

Re: [PATCH v8 2/5] x86/kvm: Change print code to use pr_*() format

2019-10-23 Thread Sean Christopherson
On Wed, Oct 23, 2019 at 07:16:21PM +0800, Zhenzhong Duan wrote: > pr_*() is preferred than printk(KERN_* ...), after change all the print > in arch/x86/kernel/kvm.c will have "kvm-guest: xxx" style. > > No functional change. > > Signed-off-by: Zhenzhong Duan > Reviewed-by: Vitaly Kuznetsov > Cc

[PATCH 2/2] ARM: s3c: Rename s5p_usb_phy functions

2019-10-23 Thread Krzysztof Kozlowski
The name s5p_usb_phy_init() suggests it is shared with S5Pv210 platform, but it is not. It is specific to S3C64xx, so make it clear in the name. Signed-off-by: Krzysztof Kozlowski --- arch/arm/mach-s3c64xx/setup-usb-phy.c| 4 ++-- arch/arm/plat-samsung/devs.c | 4 ++-- a

[PATCH v4 1/2] sched/topology: Don't try to build empty sched domains

2019-10-23 Thread Valentin Schneider
Turns out hotplugging CPUs that are in exclusive cpusets can lead to the cpuset code feeding empty cpumasks to the sched domain rebuild machinery. This leads to the following splat: [ 30.618174] Internal error: Oops: 9604 [#1] PREEMPT SMP [ 30.623697] Modules linked in: [ 30.626731] CPU:

[PATCH v4 0/2] sched/topology: Asymmetric topologies fixes

2019-10-23 Thread Valentin Schneider
Hi, I got a nice splat while testing out the toggling of sched_asym_cpucapacity, so this is a cpuset fix plus a topology patch. Details are in the logs. v2 changes: - Use static_branch_{inc,dec} rather than enable/disable v3 changes: - New patch: add fix for empty cpumap in sched domain reb

<    1   2   3   4   5   6   7   8   >