Re: [PATCH] iio: sca3000: Remove an erroneous get_device() call in sca3000_read_data()

2020-05-10 Thread Jonathan Cameron
On Wed, 6 May 2020 17:30:06 +0200 Markus Elfring wrote: > > This looks really unusual to have a 'get_device()' hidden in a 'dev_err()' > > call. > > Is there a need to prevent similar function calls by the means of > advanced source code analysis? It's a seriously stupid bug so I'd have

Re: [PATCH RFC tip/core/rcu 09/16] rcu-tasks: Add an RCU-tasks rude variant

2020-05-10 Thread Lai Jiangshan
On Tue, Mar 17, 2020 at 6:03 AM Steven Rostedt wrote: > > On Mon, 16 Mar 2020 17:45:40 -0400 > Joel Fernandes wrote: > > > > > > > Same for the function side (if not even more so). This would require > > > adding > > > a srcu_read_lock() to all functions that can be traced! That would be a > >

Re: [PATCH net] net: broadcom: Imply BROADCOM_PHY for BCMGENET

2020-05-10 Thread Geert Uytterhoeven
Hi Florian, On Sat, May 9, 2020 at 7:12 PM Florian Fainelli wrote: > On 5/9/2020 12:38 AM, Geert Uytterhoeven wrote: > > On Sat, May 9, 2020 at 12:32 AM Florian Fainelli > > wrote: > >> The GENET controller on the Raspberry Pi 4 (2711) is typically > >> interfaced with an external Broadcom PHY

Re: [PATCH v4 01/11] iio: light: cm32181: Switch to new style i2c-driver probe function

2020-05-10 Thread Hans de Goede
Hi, On 5/10/20 11:48 AM, Jonathan Cameron wrote: On Mon, 4 May 2020 14:55:41 +0200 Hans de Goede wrote: Switch to the new style i2c-driver probe_new probe function and drop the unnecessary i2c_device_id table (we do not have any old style board files using this). This is a preparation

Re: [PATCH] ALSA: hda/realtek: Add quirk for Samsung Notebook

2020-05-10 Thread Takashi Iwai
On Sun, 10 May 2020 05:28:37 +0200, Mike Pozulp wrote: > > Some models of the Samsung Notebook 9 have very quiet and distorted > headphone output. This quirk changes the VREF value of the ALC298 > codec NID 0x1a from default HIZ to new 100. > > Signed-off-by: Mike Pozulp Applied after rebasing

Re: [PATCH] clk / soc: mediatek: fix ptr_ret.cocci warnings

2020-05-10 Thread Enric Balletbo i Serra
On 10/5/20 4:53, kbuild test robot wrote: > From: kbuild test robot > > drivers/soc/mediatek/mtk-mmsys.c:28:1-3: WARNING: PTR_ERR_OR_ZERO can be used > > > Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR > > Generated by: scripts/coccinelle/api/ptr_ret.cocci > > Fixes:

Re: [RFC PATCH 00/14] iio: buffer: add support for multiple buffers

2020-05-10 Thread Jonathan Cameron
On Sat, 9 May 2020 10:52:14 +0200 Lars-Peter Clausen wrote: > On 5/8/20 3:53 PM, Alexandru Ardelean wrote: > > [...] > > What I don't like, is that iio:device3 has iio:buffer3:0 (to 3). > > This is because the 'buffer->dev.parent = _dev->dev'. > > But I do feel this is correct. > > So, now I

[PATCH v2 1/2] staging: vt6656: vt6655: clean Makefiles

2020-05-10 Thread Matej Dujava
This patch is removing CFLAGS that are defining flags that are not used. Signed-off-by: Matej Dujava --- drivers/staging/vt6655/Makefile | 3 --- drivers/staging/vt6655/device_main.c | 1 - drivers/staging/vt6656/Makefile | 3 --- 3 files changed, 7 deletions(-) diff --git

[PATCH v2 2/2] staging: vt6655: vt6656: change order of makefile variable definitions

2020-05-10 Thread Matej Dujava
This patch will add indentation to multiline variable and put obj-$(CONFIG_X) at the begining of the file. Signed-off-by: Matej Dujava --- drivers/staging/vt6655/Makefile | 24 drivers/staging/vt6656/Makefile | 4 ++-- 2 files changed, 14 insertions(+), 14 deletions(-)

[PATCH v2 0/2] staging: vt6656: vt6655: cleaning Makefile

2020-05-10 Thread Matej Dujava
This patchset will remove unused definitions of C Macros, reorder variable definition and increase indentation to match visual block. --- v2: spliting original patch to 2 separate patches Matej Dujava (2): staging: vt6656: vt6655: clean Makefiles staging: vt6655: vt6656: change order of

[PATCH V3] staging: vc04_services: vchiq_connected.c: Block comment alignment

2020-05-10 Thread John Oldman
Coding style issue This patch clears the checkpatch.pl "Block comments should align the * on each line" warning. Signed-off-by: John Oldman --- v1: Initial attempt. v2: Resubmitted with shorter comment line, as suggested by Greg KH. v3: Resubmitted with descriptiuon text moved into the comment

[PATCH] staging: greybus: Fix uninitialized scalar variable

2020-05-10 Thread Oscar Carter
In the "gb_tty_set_termios" function the "newline" variable is declared but not initialized. So the "flow_control" member is not initialized and the OR / AND operations with itself results in an undefined value in this member. The purpose of the code is to set the flow control type, so remove the

Re: [PATCH v10 00/18] Enable FSGSBASE instructions

2020-05-10 Thread Thomas Gleixner
Vegard Nossum writes: > On 5/10/20 10:09 AM, Vegard Nossum wrote: > > I spoke a few minutes too soon. Just hit this, if anybody wants to have > a look: > > [ 6402.786418] [ cut here ] > [ 6402.787769] WARNING: CPU: 0 PID: 13802 at arch/x86/kernel/traps.c:811 >

Re: [PATCH 02/15] arm64: kvm: Formalize host-hyp hypcall ABI

2020-05-10 Thread Marc Zyngier
Hi Quentin, On Thu, 07 May 2020 14:33:20 +0100, Quentin Perret wrote: > > Hey Marc, > > On Thursday 07 May 2020 at 14:10:30 (+0100), Marc Zyngier wrote: > > Hi David, Quentin, [...] > > > +#define __KVM_HOST_HCALL_TABLE_IDX___vgic_v3_save_aprs 13 > > >

Re: [PATCH 1/2] staging: iio: ad5933: attach life-cycle of kfifo buffer to parent device

2020-05-10 Thread Jonathan Cameron
On Fri, 8 May 2020 17:39:35 +0300 Alexandru Ardelean wrote: > This change makes the use of devm_iio_kfifo_allocate() to attach the > life-cycle of the kfifo buffer to the parent (client->dev) object. > > This removes the need to explicitly free 'indio_dev->buffer' via > iio_kfifo_free(), which

Re: [PATCH] iio: light: gp2ap002: Take runtime PM reference on light read

2020-05-10 Thread Jonathan Cameron
On Fri, 8 May 2020 18:42:21 -0700 Jonathan Bakker wrote: > The light sensor needs the regulators to be enabled which means > the runtime PM needs to be on. This only happened when the > proximity part of the chip was enabled. > > As fallout from this change, only report changes to the prox >

Re: [PATCH] iio: adc: Add scaling support to exynos adc driver

2020-05-10 Thread Jonathan Cameron
On Fri, 8 May 2020 14:14:00 -0700 Jonathan Bakker wrote: > Currently the driver only exposes the raw counts. As we > have the regulator voltage and the maximum value (stored in > the data mask), we can trivially produce a scaling fraction > of voltage / max value. > > This assumes that the

[PATCH v10 3/3] i2c: npcm7xx: Add support for slave mode for Nuvoton

2020-05-10 Thread Tali Perry
Add support for slave mode for Nuvoton NPCM BMC I2C controller driver. Signed-off-by: Tali Perry --- drivers/i2c/busses/i2c-npcm7xx.c | 614 +++ 1 file changed, 614 insertions(+) diff --git a/drivers/i2c/busses/i2c-npcm7xx.c b/drivers/i2c/busses/i2c-npcm7xx.c index

[PATCH v10 2/3] i2c: npcm7xx: Add Nuvoton NPCM I2C controller driver

2020-05-10 Thread Tali Perry
Add Nuvoton NPCM BMC I2C controller driver. Signed-off-by: Tali Perry --- drivers/i2c/busses/Kconfig |9 + drivers/i2c/busses/Makefile |1 + drivers/i2c/busses/i2c-npcm7xx.c | 1853 ++ 3 files changed, 1863 insertions(+) create mode 100644

Re: [PATCH] iio: light: ltr501: Constify structs

2020-05-10 Thread Jonathan Cameron
On Sat, 2 May 2020 17:40:10 +0100 Jonathan Cameron wrote: > On Sat, 2 May 2020 11:52:37 +0200 > Rikard Falkeborn wrote: > > > Constify some data structs that are never changed. In order to do so, > > also update a couple of functions that now need to accept pointers to > > const struct

[PATCH v10 1/3] dt-bindings: i2c: npcm7xx: add NPCM I2C controller

2020-05-10 Thread Tali Perry
Added device tree binding documentation for Nuvoton BMC NPCM I2C controller. Signed-off-by: Tali Perry --- .../bindings/i2c/nuvoton,npcm7xx-i2c.yaml | 62 +++ 1 file changed, 62 insertions(+) create mode 100644 Documentation/devicetree/bindings/i2c/nuvoton,npcm7xx-i2c.yaml

[PATCH v10 0/3] i2c: npcm7xx: add NPCM i2c controller driver

2020-05-10 Thread Tali Perry
This patch set adds i2c controller support for the Nuvoton NPCM Baseboard Management Controller (BMC). NPCM7xx includes 16 I2C controllers. This driver operates the controller. This module also includes a slave mode. --- v10 -> v9: - Fix according to maintainer comments. -

[PATCH v2 1/2] dt-bindings: hwmon: Add Baikal-T1 PVT sensor binding

2020-05-10 Thread Serge Semin
Baikal-T1 SoC is equipped with an embedded process, voltage and temperature sensor to monitor the chip internal environment like temperature, supply voltage and transistors performance. This bindings describes the external Baikal-T1 PVT control interfaces like MMIO registers space, interrupt

[PATCH v2 0/2] hwmon: Add Baikal-T1 SoC Process, Voltage and Temp sensor support

2020-05-10 Thread Serge Semin
In order to keep track of Baikal-T1 SoC power consumption and make sure the chip heating is within the normal temperature limits, there is a dedicated hardware monitor sensor embedded into the SoC. It is based on the Analog Bits PVT sensor but equipped with a vendor-specific control wrapper, which

[PATCH v2 2/2] hwmon: Add Baikal-T1 PVT sensor driver

2020-05-10 Thread Serge Semin
Baikal-T1 SoC provides an embedded process, voltage and temperature sensor to monitor an internal SoC environment (chip temperature, supply voltage and process monitor) and on time detect critical situations, which may cause the system instability and even damages. The IP-block is based on the

Re: [PATCH] workqueue: Fix an use after free in init_rescuer()

2020-05-10 Thread Lai Jiangshan
Reviewed-by: Lai Jiangshan On Fri, May 8, 2020 at 11:07 PM Dan Carpenter wrote: > > We need to preserve error code before freeing "rescuer". > > Fixes: f187b6974f6df ("workqueue: Use IS_ERR and PTR_ERR instead of > PTR_ERR_OR_ZERO.") > Signed-off-by: Dan Carpenter > --- > Another option would

Re: [RFC-PATCH] mtd: spi-nor: add conditional 4B opcodes

2020-05-10 Thread Tudor.Ambarus
Hi, Daniel, On Thursday, May 7, 2020 7:20:47 PM EEST Daniel Walker wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > Some chips have 4B opcodes, but there is no way to know if they have > them. This device tree option allows platform owners

[PATCH v2 4/7] watchdog: dw_wdt: Support devices with non-fixed TOP values

2020-05-10 Thread Serge Semin
In case if the DW Watchdog IP core is synthesised with WDT_USE_FIX_TOP == false, the TOP interval indexes make the device to load a custom periods to the counter. These periods are hardwired at the IP synthesis stage and can be within [2^8, 2^(WDT_CNT_WIDTH - 1)]. Alas their values can't be

[PATCH v2 6/7] watchdog: dw_wdt: Add pre-timeouts support

2020-05-10 Thread Serge Semin
DW Watchdog can rise an interrupt in case if IRQ request mode is enabled and timer reaches the zero value. In this case the IRQ lane is left pending until either the next watchdog kick event (watchdog restart) or until the WDT_EOI register is read or the device/system reset. This interface can be

[PATCH v2 5/7] watchdog: dw_wdt: Support devices with asynch clocks

2020-05-10 Thread Serge Semin
DW Watchdog IP core can be synthesised with asynchronous timer/APB clocks support (WDT_ASYNC_CLK_MODE_ENABLE == 1). In this case separate clock signals are supposed to be used to feed watchdog timer and APB interface of the device. Currently the driver supports the synchronous mode only. Since

[PATCH v2 7/7] watchdog: dw_wdt: Add DebugFS files

2020-05-10 Thread Serge Semin
For the sake of the easier device-driver debug procedure, we added a DebugFS file with the controller registers state. It's available only if kernel is configured with DebugFS support. Signed-off-by: Serge Semin Cc: Alexey Malahov Cc: Thomas Bogendoerfer Cc: Paul Burton Cc: Ralf Baechle Cc:

[PATCH v2 1/7] dt-bindings: watchdog: Convert DW WDT binding to DT schema

2020-05-10 Thread Serge Semin
Modern device tree bindings are supposed to be created as YAML-files in accordance with dt-schema. This commit replaces the DW Watchdog legacy bare text bindings with YAML file. As before the binding states that the corresponding dts node is supposed to have a registers range, a watchdog timer

[PATCH v2 0/7] watchdog: dw_wdt: Take Baikal-T1 DW WDT peculiarities into account

2020-05-10 Thread Serge Semin
There were a few features enabled at the time of the Baikal-T1 SoC DW WDT IP synthesis, which weren't taken into account in the DW WDT driver available in the kernel. First of all the SoC engineers synthesized the watchdog core with WDT_USE_FIX_TOP set to false (don't really know why, but they

[PATCH v2 2/7] dt-bindings: watchdog: dw-wdt: Support devices with asynch clocks

2020-05-10 Thread Serge Semin
DW Watchdog IP core can be synthesised with asynchronous timer/APB clocks support (WDT_ASYNC_CLK_MODE_ENABLE == 1). In this case a separate clock signal is supposed to be used to feed watchdog timer and APB interface of the device. Lets along with the watchdog timer reference clock expect to have

[PATCH v2 3/7] dt-bindings: watchdog: dw-wdt: Add watchdog TOPs array property

2020-05-10 Thread Serge Semin
In case if DW Watchdog IP core is built with WDT_USE_FIX_TOP == false, a custom timeout periods are used to preset the timer counter. In this case that periods should be specified in a new "snps,watchdog-tops" property of the DW watchdog dts node. Signed-off-by: Serge Semin Cc: Alexey Malahov

Re: [PATCH v4 01/11] iio: light: cm32181: Switch to new style i2c-driver probe function

2020-05-10 Thread Jonathan Cameron
On Sun, 10 May 2020 12:03:08 +0200 Hans de Goede wrote: > Hi, > > On 5/10/20 11:48 AM, Jonathan Cameron wrote: > > On Mon, 4 May 2020 14:55:41 +0200 > > Hans de Goede wrote: > > > >> Switch to the new style i2c-driver probe_new probe function and drop the > >> unnecessary i2c_device_id

Re: [PATCH v1 00/15] Add support for Nitro Enclaves

2020-05-10 Thread Herrenschmidt, Benjamin
On Sat, 2020-05-09 at 21:21 +0200, Pavel Machek wrote: > > On Fri 2020-05-08 10:00:27, Paraschiv, Andra-Irina wrote: > > > > > > On 07/05/2020 20:44, Pavel Machek wrote: > > > > > > Hi! > > > > > > > > it uses its own memory and CPUs + its virtio-vsock emulated device for > > > > >

[PATCH] habanalabs: check if CoreSight is supported

2020-05-10 Thread Omer Shpigelman
Coresight is not supported on simulator, therefore add a boolean for checking that (currently used by un-upstreamed code). Signed-off-by: Omer Shpigelman --- drivers/misc/habanalabs/goya/goya.c | 1 + drivers/misc/habanalabs/habanalabs.h | 2 ++ 2 files changed, 3 insertions(+) diff --git

Re: [PATCH 03/15] arm64: kvm: Fix symbol dependency in __hyp_call_panic_nvhe

2020-05-10 Thread Marc Zyngier
Hi David, On Thu, 07 May 2020 15:36:17 +0100, David Brazdil wrote: > > Hi Marc, > > > > > What breaks without this constraint? Is it a fix that should go in > > early? Otherwise looks good. > > This only becomes an issue when __hyp_call_panic_nvhe() and > __hyp_call_panic_vhe() are moved to

Re: [PATCH v4 12/16] mtd: spi-nor: perform a Soft Reset on shutdown

2020-05-10 Thread Tudor.Ambarus
Hi, Pratyush, On Friday, April 24, 2020 9:44:06 PM EEST Pratyush Yadav wrote: > A Software Reset sequence will return the flash to Power-on-Reset (POR) > state. It consists of two commands: Soft Reset Enable and Soft Reset. > > Perform a Soft Reset on shutdown on flashes that support it so that

Re: [PATCH] mmc: sdhci-acpi: Add SDHCI_QUIRK2_BROKEN_64_BIT_DMA for AMDI0040

2020-05-10 Thread Adrian Hunter
On 9/05/20 1:54 am, Raul E Rangel wrote: > The AMD eMMC 5.0 controller does not support 64 bit DMA. > > See the discussion here: https://marc.info/?l=linux-mmc=158879884514552=2 > > Fixes: 34597a3f60b1 ("mmc: sdhci-acpi: Add support for ACPI HID of AMD > Controller with HS400") > Signed-off-by:

RE: [PATCH] x86: bitops: fix build regression

2020-05-10 Thread David Laight
From: Peter Anvin > Sent: 08 May 2020 18:32 > On 2020-05-08 10:21, Nick Desaulniers wrote: > >> > >> One last suggestion. Add the "b" modifier to the mask operand: "orb > >> %b1, %0". That forces the compiler to use the 8-bit register name > >> instead of trying to deduce the width from the

Re: [PATCH v11 54/56] input: atmel_mxt_ts: added sysfs interface to update atmel T38 data

2020-05-10 Thread kbuild test robot
Hi Jiada, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on input/next] [also build test WARNING on xen-tip/linux-next robh/for-next linus/master v5.7-rc4 next-20200508] [if your patch is applied to the wrong git tree, please drop us a note to help improve the

Re: [PATCH v2] KVM: SVM: Disable AVIC before setting V_IRQ

2020-05-10 Thread Maxim Levitsky
On Thu, 2020-05-07 at 10:27 +0200, Paolo Bonzini wrote: > On 07/05/20 04:35, Suravee Suthikulpanit wrote: > > The commit 64b5bd270426 ("KVM: nSVM: ignore L1 interrupt window > > while running L2 with V_INTR_MASKING=1") introduced a WARN_ON, > > which checks if AVIC is enabled when trying to set

[PATCH 2/2] platform/x86: intel-vbtn: Detect switch position before registering the input-device

2020-05-10 Thread Hans de Goede
Setting the initial state of input-device switches must be done before registering the input-device. Otherwise the initial state will get send out as an event as soon as input_sync() gets called. E.g. when undocking a tablet using intel-vbtn to report SW_TABLET_MODE and SW_DOCK before this

[PATCH 1/2] platform/x86: intel-vbtn: Move detect_tablet_mode() to higher in the file

2020-05-10 Thread Hans de Goede
This is a preparation patch for calling detect_tablet_mode() from intel_vbtn_input_setup() without needing a forward declaration. Note this commit makes no functional changes, the moved block of code is completely unchanged. Signed-off-by: Hans de Goede --- drivers/platform/x86/intel-vbtn.c |

[PATCH 2/3] platform/x86: asus-wmi: Add support for SW_TABLET_MODE

2020-05-10 Thread Hans de Goede
On Asus 2-in-1s with a detachable keyboard the Asus WMI interface reports if the tablet is attached to the keyboard or not. Report if the 2-in-1 is in tablet or clamshell mode to userspace by reporting SW_TABLET_MODE events to userspace. This has been tested on a T100TA, T100CHI, T100HA and

[PATCH 3/3] platform/x86: asus-wmi: Ignore WMI events with code 0x79

2020-05-10 Thread Hans de Goede
On some Asus devices, e.g. the T100TA, when the charger is connected we not only get a WMI event with code 0x58, but immediately after that event we also get an even with code 0x79. This is likely related to these devices having an Asus WMI device with a device-id of 0x00120066, which seems to

[PATCH 2/2] MAINTAINERS: Remove Xiaolei Li and mark MTK NFC as orphaned

2020-05-10 Thread Miquel Raynal
Xiaolei's address is bouncing, remove him from MAINTAINERS and mark the driver he was maintaining, Mediatek's, as orphaned. Signed-off-by: Miquel Raynal --- MAINTAINERS | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index

[PATCH 1/2] MAINTAINERS: Remove Piotr Sroka and mark Cadence NFC as orphaned

2020-05-10 Thread Miquel Raynal
Piotr's address is bouncing, remove him from MAINTAINERS and mark the driver he was maintaining, Cadence's, as orphaned. Signed-off-by: Miquel Raynal --- MAINTAINERS | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 1f2c83ead00b..fdd6e96a689b

[PATCH 1/3] platform/x86: asus-wmi: Move asus_wmi_input_init and _exit lower in the file

2020-05-10 Thread Hans de Goede
Move the asus_wmi_input_init() and asus_wmi_input_exit() functions to below the WMI helpers, so that further patches in this patch-set can use the WMI helpers inside asus_wmi_input_init() without needing a forward declaration. Note this commit makes no functional changes, the moved block of code

[PATCH] dsa: sja1105: fix semicolon.cocci warnings

2020-05-10 Thread kbuild test robot
From: kbuild test robot drivers/net/dsa/sja1105/sja1105_ethtool.c:481:11-12: Unneeded semicolon Remove unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci Fixes: ae1804de93f6 ("dsa: sja1105: dynamically allocate stats structure") CC: Arnd Bergmann Signed-off-by:

[git pull] IOMMU Fixes for Linux v5.7-rc4

2020-05-10 Thread Joerg Roedel
Hi Linus, The following changes since commit 0e698dfa282211e414076f9dc7e83c1c288314fd: Linux 5.7-rc4 (2020-05-03 14:56:04 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git tags/iommu-fixes-v5.7-rc4 for you to fetch changes up to

Re: [PATCH] vmbus: Replace zero-length array with flexible-array

2020-05-10 Thread Wei Liu
On Thu, May 07, 2020 at 01:53:23PM -0500, Gustavo A. R. Silva wrote: > The current codebase makes use of the zero-length array language > extension to the C90 standard, but the preferred mechanism to declare > variable-length types such as these ones is a flexible array member[1][2], > introduced

Re: [PATCH 1/2] MAINTAINERS: Remove Piotr Sroka and mark Cadence NFC as orphaned

2020-05-10 Thread Joe Perches
On Sun, 2020-05-10 at 14:24 +0200, Miquel Raynal wrote: > Piotr's address is bouncing, remove him from MAINTAINERS and mark the > driver he was maintaining, Cadence's, as orphaned. > > Signed-off-by: Miquel Raynal > --- > MAINTAINERS | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) >

Re: [PATCH 1/2] MAINTAINERS: Remove Piotr Sroka and mark Cadence NFC as orphaned

2020-05-10 Thread Miquel Raynal
Joe Perches wrote on Sun, 10 May 2020 05:30:02 -0700: > On Sun, 2020-05-10 at 14:24 +0200, Miquel Raynal wrote: > > Piotr's address is bouncing, remove him from MAINTAINERS and mark the > > driver he was maintaining, Cadence's, as orphaned. > > > > Signed-off-by: Miquel Raynal > > --- > >

RE: [PATCH] x86: bitops: fix build regression

2020-05-10 Thread hpa
On May 10, 2020 4:59:17 AM PDT, David Laight wrote: >From: Peter Anvin >> Sent: 08 May 2020 18:32 >> On 2020-05-08 10:21, Nick Desaulniers wrote: >> >> >> >> One last suggestion. Add the "b" modifier to the mask operand: >"orb >> >> %b1, %0". That forces the compiler to use the 8-bit register

[PATCH v8 2/3] dt-bindings: arm: amlogic: add support for the Smartlabs SML-5442TW

2020-05-10 Thread Christian Hewitt
The SML-5442TW is an STB for O2 Czech IPTV/VOD and DVB-T/T2 based on the Amlogic P231 reference design using the S905D chipset. Specs: 2GB DDR3 RAM 8GB eMMC storage 10/100 Base-T Ethernet 802.11 a/b/g/n/ac + BT 4.1 HS sdio wireless module (QCA9377) 2x single colour and 1x dual colour LEDs on the

[PATCH v8 0/3] arm64: dts: meson: add dts/bindings for SmartLabs SML-5442TW

2020-05-10 Thread Christian Hewitt
This series adds new bindings and a device-tree file for the Smartlabs SML-5442TW set-top box which is based on the P231 reference design. As requested, I have reworked the device-tree on the p23x-q20x dtsi. I have also re-added the BT device with new bindings that have now been merged in

[PATCH v8 1/3] dt-bindings: add vendor prefix for Smartlabs LLC

2020-05-10 Thread Christian Hewitt
Smartlabs LLC are a professional integrator of Interactive TV solutions and IPTV/VOD devices [1]. [1] https://www.smartlabs.tv/en/about/ Acked-by: Rob Herring Signed-off-by: Christian Hewitt --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+)

[PATCH v8 3/3] arm64: dts: meson: add support for the Smartlabs SML-5442TW

2020-05-10 Thread Christian Hewitt
The Smartlabs SML-5442TW is based on the Amlogic P231 reference design but with the following differences: - The Yellow and Blue LEDs are available but disabled - The Red and Green LEDs are used to signal off/on status - uart_AO can be accessed after opening the case; soldered pins exist -

RE: [PATCH] Kconfig: default to CC_OPTIMIZE_FOR_PERFORMANCE_O3 for gcc >= 10

2020-05-10 Thread David Laight
From: Joe Perches > Sent: 08 May 2020 16:06 > On Fri, 2020-05-08 at 13:49 +0200, Arnd Bergmann wrote: > > Personally, I'm more interested in improving compile speed of the kernel > > Any opinion on precompiled header support? When ever I've been anywhere near it it is always a disaster. It may

Re: [PATCH 0/3] tools/memory-model, Documentation/litmus-test: Sort out location of litmus test and README

2020-05-10 Thread Andrea Parri
> Akira Yokosawa (3): > tools/memory-model: Fix reference to litmus test in recipes.txt > Revert "Documentation: LKMM: Move MP+onceassign+derefonce to new > litmus-tests/rcu/" > Documentation/litmus-tests: Merge atomic's README into top-level one For the series: Acked-by: Andrea Parri

Re: [PATCH v7 2/5] seq_buf: Export seq_buf_printf() to external modules

2020-05-10 Thread Vaibhav Jain
Hi Joe, Joe Perches writes: > On Fri, 2020-05-08 at 17:30 +0530, Vaibhav Jain wrote: >> Hi Boris, >> >> Borislav Petkov writes: >> >> > On Fri, May 08, 2020 at 04:19:19PM +0530, Vaibhav Jain wrote: >> > > 'seq_buf' provides a very useful abstraction for writing to a string >> > > buffer

[PATCH] sched/debug: Fix requested task uclamp values shown in procfs

2020-05-10 Thread Pavankumar Kondeti
The intention of commit 96e74ebf8d59 ("sched/debug: Add task uclamp values to SCHED_DEBUG procfs") was to print requested and effective task uclamp values. The requested values printed are read from p->uclamp, which holds the last effective values. Fix this by printing the values from

[PATCH] firmware: xilinx: Fix an error handling path in 'zynqmp_firmware_probe()'

2020-05-10 Thread Christophe JAILLET
If 'mfd_add_devices()' fails, we must undo 'zynqmp_pm_api_debugfs_init()' otherwise some debugfs directory and files will be left. Just move the call to 'zynqmp_pm_api_debugfs_init()' a few lines below to fix the issue. Fixes: e23d9c6d0d49 ("drivers: soc: xilinx: Add ZynqMP power domain driver")

Re: [PATCH v7 2/5] seq_buf: Export seq_buf_printf() to external modules

2020-05-10 Thread Vaibhav Jain
Hi Boris, Borislav Petkov writes: > On Fri, May 08, 2020 at 05:30:31PM +0530, Vaibhav Jain wrote: >> I am referring to Kernel Loadable Modules with MODULE_LICENSE("GPL") >> here. > > And what does "external" refer to? Because if it is out-of-tree, we > don't export symbols for out-of-tree

Re: [PATCH v7 2/5] seq_buf: Export seq_buf_printf() to external modules

2020-05-10 Thread Vaibhav Jain
Michael Ellerman writes: > Borislav Petkov writes: >> On Fri, May 08, 2020 at 04:19:19PM +0530, Vaibhav Jain wrote: >>> 'seq_buf' provides a very useful abstraction for writing to a string >>> buffer without needing to worry about it over-flowing. However even >>> though the API has been stable

do_raw_spin_lock, BUG: kernel NULL pointer dereference, address: 0000000000000084

2020-05-10 Thread Alan J. Wylie
I keep up-to-date with Greg's stable releases. I've seen three of these BUGs this year, none earlier than 5.6.7. They occur randomly and infrequently, so impossible to bisect. Afterwards, processes end up hung in "D" state, and can't be killed. The tainting is due to loading this module: May

Re: USB Attached SCSI breakage due no udev involvement

2020-05-10 Thread Dio Putra
On 5/10/20 4:48 PM, Dio Putra wrote: On 5/10/20 3:48 PM, Greg KH wrote: On Sun, May 10, 2020 at 03:35:34PM +0700, Dio Putra wrote: On 5/10/20 2:32 PM, Greg KH wrote: On Sun, May 10, 2020 at 02:10:04PM +0700, Dio Putra wrote: On 5/10/20 1:54 PM, Greg KH wrote: On Sun, May 10, 2020 at

Using a custom LDFLAG for all objects and binaries

2020-05-10 Thread Mahmood Naderan
Hi I would like to modify the kernel makefile in a way to include --emit-relocs for every file that is linked during the process of kernel make. I see KBUILD_HOSTLDFLAGS := $(HOST_LFS_LDFLAGS) $(HOSTLDFLAGS) LDFLAGS_MODULE = LDFLAGS_vmlinux = ... But I don't know which one is the main. Should

Re: [PATCH 0/5] cachefiles, nfs: Fixes

2020-05-10 Thread Trond Myklebust
Hi David, On Fri, 2020-05-08 at 23:16 +0100, David Howells wrote: > Hi Linus, Trond, Anna, > > Can you pull these fixes for cachefiles and NFS's use of > fscache? Should > they go through the NFS tree or directly upstream? The things fixed > are: > > (1) The reorganisation of bmap() use

Re: [patch V4 part 2 01/18] x86/entry/64: Move non entry code into .text section

2020-05-10 Thread Thomas Gleixner
Andy Lutomirski writes: > On Tue, May 5, 2020 at 7:14 AM Thomas Gleixner wrote: >> >> All ASM code which is not part of the entry functionality can move out into >> the .text section. No reason to keep it in the non-instrumentable entry >> section. > > Ick. How about just moving that code into

RE: [PATCH v5] x86: bitops: fix build regression

2020-05-10 Thread David Laight
From: Nick Desaulniers > Sent: 08 May 2020 19:32 .. > It turns out that if your config tickles __builtin_constant_p via > differences in choices to inline or not, these statements produce > invalid assembly: ... > diff --git a/arch/x86/include/asm/bitops.h b/arch/x86/include/asm/bitops.h > index

arch/x86/kernel/apm_32.c:428:43: sparse: sparse: cast truncates bits from constant value (c0000400 becomes 400)

2020-05-10 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: e99332e7b4cda6e60f5b5916cf9943a79dbef902 commit: 1651e700664b4597ddf4f8adfe435252a0d11277 x86: Fix bitops.h warning with a moved cast date: 8 weeks ago reproduce: # apt-get install sparse

[PATCH v6 1/9] w1_therm: adding code comments and code reordering

2020-05-10 Thread Akira Shimahara
Adding code comments to split code in dedicated parts. After the global declarations (defines, macros and function declarations), code is organized as follow : - Device and family dependent structures and functions - Interfaces functions - Helpers functions - Hardware functions - Sysfs

[PATCH v6 2/9] w1_therm: fix reset_select_slave during discovery

2020-05-10 Thread Akira Shimahara
Fix reset_select_slave issue during devices discovery by the master on bus. The w1_reset_select_slave() from w1_io.c, which was previously used, assume that if the slave count is 1 there is only one slave attached on the bus. This is not always true. For example when discovering devices, when the

Re: [PATCH v11 00/18] Enable FSGSBASE instructions

2020-05-10 Thread Sasha Levin
On Sat, May 09, 2020 at 06:40:02PM -0700, Dave Hansen wrote: On 5/9/20 10:36 AM, Sasha Levin wrote: Changes from v10: - Rewrite the commit message for patch #1. - Document communication/acks from userspace projects that are potentially affected by this. I'm glad someone's pushing this

[PATCH v6 3/9] w1_therm: adding sysfs-driver-w1_therm doc

2020-05-10 Thread Akira Shimahara
Adding a sysfs-driver-w1_therm documentation file in Documentation/ABI/testing. It describe the onlys sysfs entry of w1_therm module, based on Documentation/w1/slaves/w1_therm.rst Signed-off-by: Akira Shimahara --- Changes in v5: - All patch serie in one .c file - Correcting some comments -

[PATCH v6 4/9] w1_therm: adding ext_power sysfs entry

2020-05-10 Thread Akira Shimahara
Adding ext_power sysfs entry (RO). Return the power status of the device: - 0: device parasite powered - 1: device externally powered - xx: xx is kernel error The power status of each device is check when the device is discover by the bus master, in 'w1_therm_add_slave(struct w1_slave *)'. The

[PATCH v6 6/9] w1_therm: adding eeprom sysfs entry

2020-05-10 Thread Akira Shimahara
Adding eeprom sysfs entry (WO) to trigger either device EEPROM save (by writing 'save' in the sysfs), either device EEPROM restore (by writing 'restore' in the sysfs). All the RAM of the device will be save/restore, whatever its size (actually 2 or 3 bytes): resolution config register and alarms

[PATCH v6 7/9] w1_therm: optimizing temperature read timings

2020-05-10 Thread Akira Shimahara
Optimizing temperature reading by reducing waiting conversion time according to device resolution settings, as per device specification. This is device dependent as not all the devices supports resolution setting, so it has been added in device family structures. The process to read the

Re: [PATCH v10 00/18] Enable FSGSBASE instructions

2020-05-10 Thread Sasha Levin
On Sun, May 10, 2020 at 12:15:34PM +0200, Thomas Gleixner wrote: Vegard Nossum writes: On 5/10/20 10:09 AM, Vegard Nossum wrote: I spoke a few minutes too soon. Just hit this, if anybody wants to have a look: [ 6402.786418] [ cut here ] [ 6402.787769] WARNING: CPU: 0

[PATCH v6 5/9] w1_therm: adding resolution sysfs entry

2020-05-10 Thread Akira Shimahara
Adding resolution sysfs entry (RW) to get or set the device resolution Write values are managed as follow: * '9..12': resolution to set in bit * Anything else: do nothing Read values are : * '9..12': device resolution in bit * '-xx': xx is kernel error when reading

[PATCH v6 8/9] w1_therm: adding alarm sysfs entry

2020-05-10 Thread Akira Shimahara
Adding device alarms settings by a dedicated sysfs entry alarms (RW): read or write TH and TL in the device RAM. Checking devices in alarm state could be performed using the master search command. As alarms temperature level are store in a 8 bit register on the device and are signed values, a

[PATCH v6 9/9] w1_therm: adding bulk read support to trigger multiple conversion on bus

2020-05-10 Thread Akira Shimahara
Adding bulk read support: Sending a 'trigger' command in the dedicated sysfs entry of bus master device send a conversion command for all the slaves on the bus. The sysfs entry is added as soon as at least one device supporting this feature is detected on the bus. The behavior of the sysfs

Re: [PATCH net-next] net: phy: at803x: add cable diagnostics support

2020-05-10 Thread Andrew Lunn
On Sun, May 10, 2020 at 12:17:19AM +0200, Michael Walle wrote: > The AR8031/AR8033 and the AR8035 support cable diagnostics. Adding > driver support is straightforward, so lets add it. > > The PHY just do one pair at a time, so we have to start the test four > times. The cable_test_get_status()

Re: [PATCH net-next 1/4] net: phy: broadcom: add exp register access methods without buslock

2020-05-10 Thread Andrew Lunn
On Sun, May 10, 2020 at 12:37:11AM +0200, Michael Walle wrote: > Add helper to read and write expansion registers without taking the mdio > lock. > > Please note, that this changes the semantics of the read and write. > Before there was no lock between selecting the expansion register and > the

Re: [PATCH net-next 2/4] net: phy: broadcom: add bcm_phy_modify_exp()

2020-05-10 Thread Andrew Lunn
On Sun, May 10, 2020 at 12:37:12AM +0200, Michael Walle wrote: > Add the convenience function to do a read-modify-write. This has the > additional benefit of saving one write to the selection register. > > Signed-off-by: Michael Walle Reviewed-by: Andrew Lunn Andrew

RE: [PATCHES] uaccess simple access_ok() removals

2020-05-10 Thread David Laight
From: Al Viro > Sent: 10 May 2020 00:41 > > One of the uaccess-related branches; this one is just the > cases when access_ok() calls are trivially pointless - the address > in question gets fed only to primitives that do access_ok() checks > themselves. There is also the check in

Re: [PATCH net-next 3/4] net: phy: broadcom: add cable test support

2020-05-10 Thread Andrew Lunn
On Sun, May 10, 2020 at 12:37:13AM +0200, Michael Walle wrote: > Most modern broadcom PHYs support ECD (enhanced cable diagnostics). Add > support for it in the bcm-phy-lib so they can easily be used in the PHY > driver. > > There are two access methods for ECD: legacy by expansion registers and

Re: [PATCH net-next 4/4] net: phy: bcm54140: add cable diagnostics support

2020-05-10 Thread Andrew Lunn
On Sun, May 10, 2020 at 12:37:14AM +0200, Michael Walle wrote: > Use the generic cable tester functions from bcm-phy-lib to add cable > tester support. > > 100m cable, A/B/C/D open: > Cable test started for device eth0. > Cable test completed for device eth0. > Pair: Pair A, result: Open

Re: [PATCH net-next 3/4] net: phy: broadcom: add cable test support

2020-05-10 Thread Michael Walle
Am 2020-05-10 16:44, schrieb Andrew Lunn: On Sun, May 10, 2020 at 12:37:13AM +0200, Michael Walle wrote: Most modern broadcom PHYs support ECD (enhanced cable diagnostics). Add support for it in the bcm-phy-lib so they can easily be used in the PHY driver. There are two access methods for

Re: [PATCH net-next] net: phy: at803x: add cable diagnostics support

2020-05-10 Thread Andrew Lunn
More of a note to self: Now we have three implementations, we start to see bits of common code which could be pulled out and shared. > +static bool at803x_cdt_fault_length_valid(u16 status) > +{ > + switch (FIELD_GET(AT803X_CDT_STATUS_STAT_MASK, status)) { > + case

Re: [PATCH net-next] net: phy: at803x: add cable diagnostics support

2020-05-10 Thread Michael Walle
Am 2020-05-10 16:52, schrieb Andrew Lunn: More of a note to self: Now we have three implementations, we start to see bits of common code which could be pulled out and shared. +static bool at803x_cdt_fault_length_valid(u16 status) +{ + switch (FIELD_GET(AT803X_CDT_STATUS_STAT_MASK,

[PATCH 00/19] perf: ftrace enhancement

2020-05-10 Thread Changbin Du
The perf has basic kernel ftrace support but lack support of most tracing options. This serias is target to enhance the perf ftrace functionality so that we can make full use of kernel ftrace with only perf. In general, this serias be cataloged into two main changes: 1) Improve usability of

[PATCH 01/19] perf ftrace: trace system wide if no target is given

2020-05-10 Thread Changbin Du
This align ftrace to other perf sub-commands that if no target specified then we trace all functions. Signed-off-by: Changbin Du --- tools/perf/builtin-ftrace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/builtin-ftrace.c b/tools/perf/builtin-ftrace.c index

[PATCH 02/19] perf ftrace: detect workload failure

2020-05-10 Thread Changbin Du
Currently there's no error message prompted if we failed to start workload. And we still get some trace which is confusing. Let's tell users what happened. Signed-off-by: Changbin Du --- tools/perf/builtin-ftrace.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git

[PATCH 04/19] perf ftrace: add support for tracing option 'func_stack_trace'

2020-05-10 Thread Changbin Du
This adds support to display call trace for function tracer. To do this, just specify a '-s' option. $ sudo perf ftrace -T vfs_read -s iio-sensor-prox-855 [003] 6168.369657: vfs_read <-ksys_read iio-sensor-prox-855 [003] 6168.369677: => vfs_read => ksys_read => __x64_sys_read =>

[PATCH 03/19] perf ftrace: select function/function_graph tracer automatically

2020-05-10 Thread Changbin Du
The '-g/-G' options have already implied function_graph tracer should be used instead of function tracer. So the extra option '--tracer' can be killed. This patch changes the behavior as below: - By default, function tracer is used. - If '-g' or '-G' option is on, then function_graph tracer

<    1   2   3   4   5   6   >