Re: [PATCH 2/3] sdhci: sparx5: Add Sparx5 SoC eMMC driver

2020-05-20 Thread Lars Povlsen
Lars Povlsen writes: > Adrian Hunter writes: > >> On 13/05/20 4:31 pm, Lars Povlsen wrote: >>> This adds the eMMC driver for the Sparx5 SoC. It is based upon the >>> designware IP, but requires some extra initialization and quirks. >>> >>> Reviewed-by: Alexandre Belloni >>> Signed-off-by: Lars

Re: [PATCH v4 2/4] kasan: record and print the free track

2020-05-20 Thread Dmitry Vyukov
On Wed, May 20, 2020 at 12:15 PM Walter Wu wrote: > > On Wed, 2020-05-20 at 11:44 +0200, 'Dmitry Vyukov' via kasan-dev wrote: > > On Wed, May 20, 2020 at 11:17 AM Walter Wu > > wrote: > > > > > On Wed, 2020-05-20 at 13:14 +0800, Walter Wu wrote: > > > > > > > On Wed, May 20, 2020 at 6:03 AM

Re: [PATCH] drm/etnaviv: fix memory leak when mapping prime imported buffers

2020-05-20 Thread Fuzzey, Martin
Hi Lucas, > Am Mittwoch, den 20.05.2020, 12:10 +0200 schrieb Martin Fuzzey: > What's the use-case where you did hit this issue? mmap'ing of imported > buffers through the etnaviv DRM device is currently not well defined > and I was pondering the idea of forbidding it completely by not > returning

Re: [PATCH V1 2/3] mmc: sdhci-msm: Use internal voltage control

2020-05-20 Thread Veerabhadrarao Badiganti
Thanks Bjorn for the review. For major comments I'm responding. Other comments, i will take care of them in my next patch-set. On 5/19/2020 1:27 AM, Bjorn Andersson wrote: On Fri 15 May 04:18 PDT 2020, Veerabhadrarao Badiganti wrote: From: Vijay Viswanath On qcom SD host controllers

Re: [EXT] Re: [PATCH net-next 3/5] net: mvpp2: cls: Use RSS contexts to handle RSS tables

2020-05-20 Thread Matteo Croce
On Wed, May 20, 2020 at 1:11 PM Russell King - ARM Linux admin wrote: > > On Tue, May 19, 2020 at 07:05:34PM +0200, Matteo Croce wrote: > > On Tue, 19 May 2020 12:05:20 +0200 > > Matteo Croce wrote: > > > > Hi, > > > > The patch seems to work. I'm generating traffic with random MAC and IP > >

Re: [PATCH] PCI: dwc: Warn only for non-prefetchable memory resource size >4GB

2020-05-20 Thread Thierry Reding
On Tue, May 19, 2020 at 10:08:54PM +, Gustavo Pimentel wrote: > On Tue, May 19, 2020 at 15:58:16, Lorenzo Pieralisi > wrote: > > > On Tue, May 19, 2020 at 07:25:02PM +0530, Vidya Sagar wrote: > > > > > > > > > On 18-May-20 9:24 PM, Lorenzo Pieralisi wrote: > > > > External email: Use

Re: [PATCH v2] printk/kdb: Redirect printk messages into kdb in any context

2020-05-20 Thread Sergey Senozhatsky
On (20/05/20 12:22), Petr Mladek wrote: > kdb has to get messages on consoles even when the system is stopped. > It uses kdb_printf() internally and calls console drivers on its own. > > It uses a hack to reuse an existing code. It sets "kdb_trap_printk" > global variable to redirect even the

Re: [EXT] Re: [PATCH net-next 3/5] net: mvpp2: cls: Use RSS contexts to handle RSS tables

2020-05-20 Thread Russell King - ARM Linux admin
On Wed, May 20, 2020 at 01:16:25PM +0200, Matteo Croce wrote: > On Wed, May 20, 2020 at 1:11 PM Russell King - ARM Linux admin > wrote: > > > > On Tue, May 19, 2020 at 07:05:34PM +0200, Matteo Croce wrote: > > > On Tue, 19 May 2020 12:05:20 +0200 > > > Matteo Croce wrote: > > > > > > Hi, > > > >

Re: [PATCH V1 3/3] mmc: sdhci: Allow platform controlled voltage switching

2020-05-20 Thread Veerabhadrarao Badiganti
On 5/19/2020 11:36 AM, Adrian Hunter wrote: On 15/05/20 2:18 pm, Veerabhadrarao Badiganti wrote: From: Vijay Viswanath If vendor platform drivers are controlling whole logic of voltage switching, then sdhci driver no need control vqmmc regulator. So skip enabling/disable vqmmc from SDHC

Re: kernel BUG at mm/hugetlb.c:LINE!

2020-05-20 Thread Miklos Szeredi
On Tue, May 19, 2020 at 2:35 AM Mike Kravetz wrote: > > On 5/18/20 4:41 PM, Colin Walters wrote: > > > > On Tue, May 12, 2020, at 11:04 AM, Miklos Szeredi wrote: > > > >>> However, in this syzbot test case the 'file' is in an overlayfs filesystem > >>> created as follows: > >>> > >>>

Re: [PATCH] ASoC: fsl: imx-pcm-dma: Don't request dma channel in probe

2020-05-20 Thread Shengjiu Wang
Hi On Wed, May 20, 2020 at 5:42 PM Lucas Stach wrote: > > Am Mittwoch, den 20.05.2020, 16:20 +0800 schrieb Shengjiu Wang: > > Hi > > > > On Tue, May 19, 2020 at 6:04 PM Lucas Stach wrote: > > > Am Dienstag, den 19.05.2020, 17:41 +0800 schrieb Shengjiu Wang: > > > > There are two requirements

Re: [PATCH V2] arm64: tegra: Fix flag for 64-bit resources in 'ranges' property

2020-05-20 Thread Thierry Reding
On Mon, May 18, 2020 at 07:52:24PM +0530, Vidya Sagar wrote: > Thanks Lorenzo. > I've moved linux-pci to BCC and included > devicetree and linux-tegra mailing lists to CC. > > Rob, Could you please review this patch? I don't think there's any need for Rob to review this. It's a simple bugfix and

[PATCH v4 09/11] ARM64: dts: mediatek: add an alias for ethernet0 for pumpkin boards

2020-05-20 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Add the ethernet0 alias for ethernet so that u-boot can find this node and fill in the MAC address. Signed-off-by: Bartosz Golaszewski --- arch/arm64/boot/dts/mediatek/pumpkin-common.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v4 04/11] net: ethernet: mediatek: rename Kconfig prompt

2020-05-20 Thread Bartosz Golaszewski
From: Bartosz Golaszewski We'll soon by adding a second MediaTek Ethernet driver so modify the Kconfig prompt. Signed-off-by: Bartosz Golaszewski --- drivers/net/ethernet/mediatek/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/mediatek/Kconfig

[PATCH v4 10/11] ARM64: dts: mediatek: add ethernet pins for pumpkin boards

2020-05-20 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Setup the pin control for the Ethernet MAC. Signed-off-by: Bartosz Golaszewski --- arch/arm64/boot/dts/mediatek/pumpkin-common.dtsi | 15 +++ 1 file changed, 15 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/pumpkin-common.dtsi

[PATCH v4 02/11] dt-bindings: add new compatible to mediatek,pericfg

2020-05-20 Thread Bartosz Golaszewski
From: Bartosz Golaszewski The PERICFG controller is present on the MT8516 SoC. Add an appropriate compatible variant. Signed-off-by: Bartosz Golaszewski --- .../devicetree/bindings/arm/mediatek/mediatek,pericfg.yaml | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v4 00/11] mediatek: add support for MediaTek Ethernet MAC

2020-05-20 Thread Bartosz Golaszewski
From: Bartosz Golaszewski This adds support for the Ethernet Controller present on MediaTeK SoCs from the MT8* family. First we convert the existing DT bindings for the PERICFG controller to YAML and add a new compatible string for mt8516 variant of it. Then we add the DT bindings for the MAC.

[PATCH v4 08/11] ARM64: dts: mediatek: add the ethernet node to mt8516.dtsi

2020-05-20 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Add the Ethernet MAC node to mt8516.dtsi. This defines parameters common to all the boards based on this SoC. Signed-off-by: Bartosz Golaszewski --- arch/arm64/boot/dts/mediatek/mt8516.dtsi | 12 1 file changed, 12 insertions(+) diff --git

[PATCH v4 11/11] ARM64: dts: mediatek: enable ethernet on pumpkin boards

2020-05-20 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Add remaining properties to the ethernet node and enable it. Signed-off-by: Bartosz Golaszewski --- .../boot/dts/mediatek/pumpkin-common.dtsi | 18 ++ 1 file changed, 18 insertions(+) diff --git a/arch/arm64/boot/dts/mediatek/pumpkin-common.dtsi

[PATCH v4 07/11] ARM64: dts: mediatek: add pericfg syscon to mt8516.dtsi

2020-05-20 Thread Bartosz Golaszewski
From: Bartosz Golaszewski This adds support for the PERICFG register range as a syscon. This will soon be used by the MediaTek Ethernet MAC driver for NIC configuration. Signed-off-by: Bartosz Golaszewski --- arch/arm64/boot/dts/mediatek/mt8516.dtsi | 5 + 1 file changed, 5 insertions(+)

[PATCH v4 03/11] dt-bindings: net: add a binding document for MediaTek Ethernet MAC

2020-05-20 Thread Bartosz Golaszewski
From: Bartosz Golaszewski This adds yaml DT bindings for the MediaTek Ethernet MAC present on the mt8* family of SoCs. Signed-off-by: Bartosz Golaszewski --- .../bindings/net/mediatek,eth-mac.yaml| 89 +++ 1 file changed, 89 insertions(+) create mode 100644

[PATCH v4 06/11] net: ethernet: mtk-eth-mac: new driver

2020-05-20 Thread Bartosz Golaszewski
From: Bartosz Golaszewski This adds the driver for the MediaTek Ethernet MAC used on the MT8* SoC family. For now we only support full-duplex. Signed-off-by: Bartosz Golaszewski --- drivers/net/ethernet/mediatek/Kconfig |6 + drivers/net/ethernet/mediatek/Makefile |1 +

[PATCH v4 05/11] net: ethernet: mediatek: remove unnecessary spaces from Makefile

2020-05-20 Thread Bartosz Golaszewski
From: Bartosz Golaszewski The Makefile formatting in the kernel tree usually doesn't use tabs, so remove them before we add a second driver. Signed-off-by: Bartosz Golaszewski --- drivers/net/ethernet/mediatek/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

XHCI vs PCM2903B/PCM2904 part 2

2020-05-20 Thread Rik van Riel
After a few more weeks of digging, I have come to the tentative conclusion that either the XHCI driver, or the USB sound driver, or both, fail to handle USB errors correctly. I have some questions at the bottom, after a (brief-ish) explanation of exactly what seems to go wrong. TL;DR: arecord

[PATCH v4 01/11] dt-bindings: convert the binding document for mediatek PERICFG to yaml

2020-05-20 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Convert the DT binding .txt file for MediaTek's peripheral configuration controller to YAML. There's one special case where the compatible has three positions. Otherwise, it's a pretty normal syscon. Signed-off-by: Bartosz Golaszewski ---

Re: [PATCH v1] sdhci: tegra: Remove warnings about missing device-tree properties

2020-05-20 Thread Ulf Hansson
On Wed, 20 May 2020 at 04:00, Dmitry Osipenko wrote: > > 19.05.2020 23:44, Sowjanya Komatineni пишет: > > > > On 5/19/20 12:07 PM, Sowjanya Komatineni wrote: > >> > >> On 5/19/20 11:41 AM, Sowjanya Komatineni wrote: > >>> > >>> On 5/19/20 11:34 AM, Sowjanya Komatineni wrote: > > On

Re: [PATCH 09/15] device core: Add ability to handle multiple dma offsets

2020-05-20 Thread Nicolas Saenz Julienne
Hi Jim, thanks for having a go at this! My two cents. On Tue, 2020-05-19 at 16:34 -0400, Jim Quinlan wrote: > The device variable 'dma_pfn_offset' is used to do a single > linear map between cpu addrs and dma addrs. The variable > 'dma_map' is added to struct device to point to an array > of

Re: BUG: sleeping function called from atomic due to "Balance initial LPI affinity across CPUs"

2020-05-20 Thread John Garry
On 20/05/2020 10:51, Marc Zyngier wrote: Hi John, On 2020-05-20 09:43, John Garry wrote: On 19/05/2020 23:09, Qian Cai wrote: Reverted the linux-next commit f068a62c548c ("irqchip/gic-v3-its: Balance initial LPI affinity across CPUs") fixed these warnings during boot, Thanks for the notice.

[PATCH] powercap: remove unused local MSR define

2020-05-20 Thread Sumeet Pawnikar
From: "Pawnikar, Sumeet" Remove unused PLATFORM_POWER_LIMIT MSR local definition from file intel_rapl_common.c. This was missed while splitting old RAPL code intel_rapl.c file into two new files intel_rapl_msr.c and intel_rapl_common.c as per the commit 3382388d7148 ("intel_rapl: abstract RAPL

Re: [PATCH v2 12/20] mips: MAAR: Add XPA mode support

2020-05-20 Thread Serge Semin
On Tue, May 19, 2020 at 05:42:13PM +0200, Thomas Bogendoerfer wrote: > On Wed, May 06, 2020 at 08:42:30PM +0300, sergey.se...@baikalelectronics.ru > wrote: > > From: Serge Semin > > > > When XPA mode is enabled the normally 32-bits MAAR pair registers > > are extended to be of 64-bits width as

Re: [PATCH v3 02/19] mm: memcg: prepare for byte-sized vmstat items

2020-05-20 Thread Vlastimil Babka
On 4/22/20 10:46 PM, Roman Gushchin wrote: > To implement per-object slab memory accounting, we need to > convert slab vmstat counters to bytes. Actually, out of > 4 levels of counters: global, per-node, per-memcg and per-lruvec > only two last levels will require byte-sized counters. > It's

[PATCH] USB: serial: qcserial: Add DW5816e QDL support

2020-05-20 Thread Matt Jolly
Add support for Dell Wireless 5816e Download Mode (AKA boot & hold mode / QDL download mode) to drivers/usb/serial/qcserial.c This is required to update device firmware. Signed-off-by: Matt Jolly --- drivers/usb/serial/qcserial.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [PATCH v8 1/6] MIPS: JZ4780: Introduce SMP support.

2020-05-20 Thread Paul Cercueil
Hi Zhou, Le mer. 20 mai 2020 à 15:23, Zhou Yanjie a écrit : Hi Paul, On 2020年05月20日 03:41, Paul Cercueil wrote: Hi Zhou, Le mar. 19 mai 2020 à 22:35, 周琰杰 (Zhou Yanjie)  a écrit : Forward port smp support from kernel 3.18.3 of CI20_linux to upstream kernel 5.6. Tested-by: H. Nikolaus

Re: [PATCH V1 1/7] dt-bindings: mmc: Add information for DLL register properties

2020-05-20 Thread Ulf Hansson
On Thu, 7 May 2020 at 10:03, Sarthak Garg wrote: > > Add information regarding DLL register properties for getting target > specific configurations. These DLL register settings may vary from > target to target. > > Also new compatible string value for sm8250 target. As Rob indicated, it's a bit

Re: [PATCH v3 02/19] mm: memcg: prepare for byte-sized vmstat items

2020-05-20 Thread Vlastimil Babka
On 5/20/20 1:31 PM, Vlastimil Babka wrote: > On 4/22/20 10:46 PM, Roman Gushchin wrote: >> To implement per-object slab memory accounting, we need to >> convert slab vmstat counters to bytes. Actually, out of >> 4 levels of counters: global, per-node, per-memcg and per-lruvec >> only two last

Re: next-0519 on thinkpad x60: sound related? window manager crash

2020-05-20 Thread Takashi Iwai
On Wed, 20 May 2020 13:11:37 +0200, Pavel Machek wrote: > > Hi! > > My window manager stopped responding. I was able to recover machine > using sysrq-k. > > I started writing nice report, when session failed second time. And > then third time on next attempt. > > Any ideas? Do you know when

Re: [PATCH v11 2/3] i2c: npcm7xx: Add Nuvoton NPCM I2C controller driver

2020-05-20 Thread Avi Fishman
Thanks Andy, Question below: On Wed, May 20, 2020 at 1:24 PM Andy Shevchenko wrote: > > On Wed, May 20, 2020 at 12:51:12PM +0300, Tali Perry wrote: > > Add Nuvoton NPCM BMC I2C controller driver. > > ... > > > +#ifdef CONFIG_DEBUG_FS > > Why?! It is made to save code size if CONFIG_DEBUG_FS is

Re: [patch V6 10/37] x86/entry: Switch XEN/PV hypercall entry to IDTENTRY

2020-05-20 Thread Andrew Cooper
On 20/05/2020 09:06, Jürgen Groß wrote: > On 19.05.20 21:44, Andy Lutomirski wrote: >> On Tue, May 19, 2020 at 11:58 AM Thomas Gleixner >> wrote: >>> >>> Andy Lutomirski writes: B: Turn this thing around.  Specifically, in the one and only case we care about, we know pretty much

Re: next-0519 on thinkpad x60: sound related? window manager crash

2020-05-20 Thread Pavel Machek
On Wed 2020-05-20 13:37:02, Takashi Iwai wrote: > On Wed, 20 May 2020 13:11:37 +0200, > Pavel Machek wrote: > > > > Hi! > > > > My window manager stopped responding. I was able to recover machine > > using sysrq-k. > > > > I started writing nice report, when session failed second time. And > >

Re: [PATCH glibc 1/3] glibc: Perform rseq registration at C startup and thread creation (v19)

2020-05-20 Thread Florian Weimer
* Mathieu Desnoyers via Libc-alpha: > diff --git a/NEWS b/NEWS > index 141078c319..c4e0370fc4 100644 > --- a/NEWS > +++ b/NEWS > @@ -23,6 +23,16 @@ Major new features: >toolchains. It is recommended to use GCC 8 or newer when testing >this option. > > +* Support for automatically

Re: XHCI vs PCM2903B/PCM2904 part 2

2020-05-20 Thread Takashi Iwai
On Wed, 20 May 2020 13:26:57 +0200, Rik van Riel wrote: > > After a few more weeks of digging, I have come to the tentative > conclusion that either the XHCI driver, or the USB sound driver, > or both, fail to handle USB errors correctly. > > I have some questions at the bottom, after a

[PATCH] drm: Replace deprecated function in drm_crtc_helper

2020-05-20 Thread Sidong Yang
Replace deprecated function drm_modeset_lock/unlock_all with helper function DRM_MODESET_LOCK_ALL_BEGIN/END. Signed-off-by: Sidong Yang --- drivers/gpu/drm/drm_crtc_helper.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git

Re: [PATCH v4 2/4] kasan: record and print the free track

2020-05-20 Thread Walter Wu
On Wed, 2020-05-20 at 13:15 +0200, 'Dmitry Vyukov' via kasan-dev wrote: > On Wed, May 20, 2020 at 12:15 PM Walter Wu wrote: > > > > On Wed, 2020-05-20 at 11:44 +0200, 'Dmitry Vyukov' via kasan-dev wrote: > > > On Wed, May 20, 2020 at 11:17 AM Walter Wu > > > wrote: > > > > > > On Wed,

Re: next-0519 on thinkpad x60: sound related? window manager crash

2020-05-20 Thread Takashi Iwai
On Wed, 20 May 2020 13:39:06 +0200, Pavel Machek wrote: > > On Wed 2020-05-20 13:37:02, Takashi Iwai wrote: > > On Wed, 20 May 2020 13:11:37 +0200, > > Pavel Machek wrote: > > > > > > Hi! > > > > > > My window manager stopped responding. I was able to recover machine > > > using sysrq-k. > > >

Re: [PATCH v3 0/3] lib/vsprintf: Introduce %ptT for time64_t

2020-05-20 Thread Sergey Senozhatsky
On (20/05/15 18:02), Petr Mladek wrote: > On Wed 2020-04-15 20:00:43, Andy Shevchenko wrote: > > It is a logical continuation of previously applied %ptR for struct rtc_time. > > We have few users of time64_t that would like to print it. > > It seems that everything was explained and the patches

Re: [PATCH v2 1/2] drivers: thermal: tsens: Add zeroc interrupt support

2020-05-20 Thread Amit Kucheria
On Sun, May 17, 2020 at 4:17 PM Manaf Meethalavalappu Pallikunhi wrote: > > TSENS IP v2.6+ adds zeroc interrupt support. It triggers set As I re-read through these patches, shouldn't we just call it the "cold" interrupt? > interrupt when aggregated minimum temperature of all TSENS falls > below

[PATCH 5/5] net: ethernet: mtk_eth_mac: use devm_register_netdev()

2020-05-20 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Use the new devres variant of register_netdev() in the mtk-eth-mac driver and shrink the code by a couple lines. Signed-off-by: Bartosz Golaszewski --- drivers/net/ethernet/mediatek/mtk_eth_mac.c | 17 + 1 file changed, 1 insertion(+), 16 deletions(-)

[PATCH 0/5] net: provide a devres variant of register_netdev()

2020-05-20 Thread Bartosz Golaszewski
From: Bartosz Golaszewski This series applies on top of my mtk-eth-mac series[1]. Using devres helpers allows to shrink the probing code, avoid memory leaks in error paths make sure the order in which resources are freed is the exact opposite of their allocation. This series proposes to add a

[PATCH 1/5] Documentation: devres: add a missing section for networking helpers

2020-05-20 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Add a new section for networking devres helpers to devres.rst and list the two existing devm functions. Signed-off-by: Bartosz Golaszewski --- Documentation/driver-api/driver-model/devres.rst | 4 1 file changed, 4 insertions(+) diff --git

[PATCH 4/5] net: devres: provide devm_register_netdev()

2020-05-20 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Provide devm_register_netdev() - a device resource managed variant of register_netdev(). This new helper will only work for net_device structs that are also already managed by devres. Signed-off-by: Bartosz Golaszewski --- .../driver-api/driver-model/devres.rst

[PATCH 3/5] net: devres: define a separate devres structure for devm_alloc_etherdev()

2020-05-20 Thread Bartosz Golaszewski
From: Bartosz Golaszewski Not using a proxy structure to store struct net_device doesn't save anything in terms of compiled code size or memory usage but significantly decreases the readability of the code with all the pointer casting. Define struct net_device_devres and use it in

[PATCH 2/5] net: move devres helpers into a separate source file

2020-05-20 Thread Bartosz Golaszewski
From: Bartosz Golaszewski There's currently only a single devres helper in net/ - devm variant of alloc_etherdev. Let's move it to net/devres.c with the intention of assing a second one: devm_register_netdev(). This new routine will need to know the address of the release function of

Re: [PATCH] sh: include linux/time_types.h for sockios

2020-05-20 Thread Geert Uytterhoeven
Hi Arnd, Andrew, On Wed, May 20, 2020 at 10:32 AM Arnd Bergmann wrote: > On Wed, May 20, 2020 at 3:10 AM Andrew Morton > wrote: > > On Tue, 19 May 2020 15:13:13 +0200 Arnd Bergmann wrote: > > > Using the socket ioctls on arch/sh (and only there) causes build > > > time problems when

Re: [PATCH v11 2/3] i2c: npcm7xx: Add Nuvoton NPCM I2C controller driver

2020-05-20 Thread Andy Shevchenko
On Wed, May 20, 2020 at 02:37:13PM +0300, Avi Fishman wrote: > On Wed, May 20, 2020 at 1:24 PM Andy Shevchenko > wrote: > > > > On Wed, May 20, 2020 at 12:51:12PM +0300, Tali Perry wrote: > > > Add Nuvoton NPCM BMC I2C controller driver. > > > > ... > > > > > +#ifdef CONFIG_DEBUG_FS > > > > Why?!

Re: [PATCH 04/15] PCI: brcmstb: Add compatibily of other chips

2020-05-20 Thread Nicolas Saenz Julienne
Hi Jim, On Tue, 2020-05-19 at 16:34 -0400, Jim Quinlan wrote: > From: Jim Quinlan > > Add in compatibility strings and code for three Broadcom STB chips. > Some of the register locations, shifts, and masks are different > for certain chips, requiring the use of different constants based > on

linux-next: Fixes tag needs some work in the v4l-dvb tree

2020-05-20 Thread Stephen Rothwell
Hi all, In commit de99280b2640 ("media: atomisp: add a notice about possible leak resources") Fixes tag Fixes: 88b03de5d705 ("media: atomisp: Add some ACPI detection info") has these problem(s): - Target SHA1 does not exist Maybe you meant Fixes: ea073ef04fb3 ("media: atomisp: Add

Re: [PATCH] i2c: cadence: Add error handling for a platform_get_irq() call in cdns_i2c_probe()

2020-05-20 Thread Markus Elfring
> The driver initialization should be end immediately after found > the platform_get_irq() function return an error. I suggest to improve also this change description. How do you think about a wording variant like the following? Return an error code after a call of the function

Re: [PATCH v2 5/6] irqchip: Add Loongson PCH MSI controller

2020-05-20 Thread Jiaxun Yang
于 2020年5月13日 GMT+08:00 下午8:15:40, Thomas Gleixner 写到: >Thomas Gleixner writes: >> Jiaxun Yang writes: >>> + >>> +struct pch_msi_data { >>> + spinlock_t msi_map_lock; >>> + phys_addr_t doorbell; >>> + u32 irq_first; /* The vector number

Re: [PATCH v2 1/2] hwrng: iproc-rng200 - Set the quality value

2020-05-20 Thread Stephan Mueller
Am Mittwoch, 20. Mai 2020, 12:44:33 CEST schrieb Lukasz Stelmach: Hi Lukasz, > It was <2020-05-20 śro 11:18>, when Stephan Mueller wrote: > > Am Mittwoch, 20. Mai 2020, 11:10:32 CEST schrieb Lukasz Stelmach: > >> It was <2020-05-20 śro 08:23>, when Stephan Mueller wrote: > >>> Am Dienstag, 19.

Re: [PATCH] powercap: remove unused local MSR define

2020-05-20 Thread Andy Shevchenko
On Wed, May 20, 2020 at 05:06:18PM +0530, Sumeet Pawnikar wrote: > From: "Pawnikar, Sumeet" > > Remove unused PLATFORM_POWER_LIMIT MSR local definition from file > intel_rapl_common.c. This was missed while splitting old RAPL code > intel_rapl.c file into two new files intel_rapl_msr.c and >

Re: [PATCH v4 2/4] kasan: record and print the free track

2020-05-20 Thread Dmitry Vyukov
On Wed, May 20, 2020 at 1:42 PM Walter Wu wrote: > > > > > > > > > > > On Tue, May 19, 2020 at 4:25 AM Walter Wu > > > > > > > > > > > wrote: > > > > > > > > > > > > > > > > > > > > > > > > Move free track from slub alloc meta-data to slub free > > > > > > > > > > > > meta-data in > > > > > >

Re: [PATCH] arm64/cpufeature: Move BUG_ON() inside get_arm64_ftr_reg()

2020-05-20 Thread Catalin Marinas
On Wed, May 20, 2020 at 06:52:54AM +0530, Anshuman Khandual wrote: > There is no way to proceed when requested register could not be searched in > arm64_ftr_reg[]. Requesting for a non present register would be an error as > well. Hence lets just BUG_ON() when the search fails in

Re: [PATCH v2 2/3] bindings: sound: Add documentation for TI j721e EVM (CPB and IVI)

2020-05-20 Thread Peter Ujfalusi
Hi Rob, On 20/05/2020 1.21, Rob Herring wrote: > On Tue, May 12, 2020 at 04:16:32PM +0300, Peter Ujfalusi wrote: >> The audio support on the Common Processor Board board is using >> pcm3168a codec connected to McASP10 serializers in parallel setup. >> >> The Infotainment board plugs into the

linux-next: Signed-off-by missing for commit in the v4l-dvb tree

2020-05-20 Thread Stephen Rothwell
Hi all, Commit 21abaf06e4b8 ("media: atomisp: improve device detection code") is missing a Signed-off-by from its author and committer. -- Cheers, Stephen Rothwell pgpnzhVkAq1Cm.pgp Description: OpenPGP digital signature

Re: [PATCH] selftests/timens: handle a case when alarm clocks are not supported

2020-05-20 Thread Vincenzo Frascino
Hi Andrei, thanks for this. On 4/15/20 7:18 AM, Andrei Vagin wrote: > This can happen if a testing node doesn't have RTC (real time clock) > hardware or it doesn't support alarms. > Could you please add the "Reported-by:" tag and the "Fixes:" one? With this: Acked-by: Vincenzo Frascino >

[PATCH] kthread: Use TASK_IDLE state for newly created kernel threads

2020-05-20 Thread Pavankumar Kondeti
When kernel threads are created for later use, they will be in TASK_UNINTERRUPTIBLE state until they are woken up. This results in increased loadavg and false hung task reports. To fix this, use TASK_IDLE state instead of TASK_UNINTERRUPTIBLE when a kernel thread schedules out for the first time.

Re: [PATCH 3/3] soundwire: add Slave sysfs support

2020-05-20 Thread Vinod Koul
On 19-05-20, 04:35, Bard Liao wrote: > +int sdw_slave_sysfs_init(struct sdw_slave *slave) > +{ > + int ret; > + > + ret = devm_device_add_groups(>dev, slave_groups); > + if (ret < 0) > + return ret; > + > + ret = devm_device_add_group(>dev, _slave_dev_attr_group); > +

Re: mm: mkfs.ext4 invoked oom-killer on i386 - pagecache_get_page

2020-05-20 Thread Naresh Kamboju
FYI, This issue is specific on 32-bit architectures i386 and arm on linux-next tree. As per the test results history this problem started happening from Bad : next-20200430 Good : next-20200429 steps to reproduce: dd if=/dev/disk/by-id/ata-SanDisk_SSD_PLUS_120GB_190504A00573 of=/dev/null bs=1M

Re: [PATCH v10 2/5] PCI: Add Loongson PCI Controller support

2020-05-20 Thread Jiaxun Yang
于 2020年5月14日 GMT+08:00 下午9:16:38, Jiaxun Yang 写到: >This controller can be found on Loongson-2K SoC, Loongson-3 >systems with RS780E/LS7A PCH. > >The RS780E part of code was previously located at >arch/mips/pci/ops-loongson3.c and now it can use generic PCI >driver implementation. >

Re: [PATCH 8/8] mm/zswap: Use local lock to protect per-CPU data

2020-05-20 Thread Sebastian Andrzej Siewior
On 2020-05-20 11:13:31 [+], Song Bao Hua wrote: > For example, on cpu1, once you begin to compress, you hold the percpu > acomp-ctx and percpu destination buffer of CPU1, the below code makes sure > you get the acomp and dstmem from the same core by disabling preemption with > get_cpu_var

Re: [PATCH v2 18/20] mips: csrc-r4k: Decrease r4k-clocksource rating if CPU_FREQ enabled

2020-05-20 Thread Serge Semin
On Tue, May 19, 2020 at 05:50:53PM +0200, Thomas Bogendoerfer wrote: > On Mon, May 18, 2020 at 11:57:52PM +0300, Serge Semin wrote: > > On Mon, May 18, 2020 at 06:32:06PM +0200, Thomas Bogendoerfer wrote: > > > On Mon, May 18, 2020 at 04:48:20PM +0300, Serge Semin wrote: > > > > On Fri, May 15,

Re: [PATCH v2 1/2] hwrng: iproc-rng200 - Set the quality value

2020-05-20 Thread Krzysztof Kozlowski
On Wed, 20 May 2020 at 13:53, Stephan Mueller wrote: > > > That said, the illustrated example is typical for hardware RNGs. Yet > > > it is never guaranteed to work that way. Thus, if you can point to > > > architecture documentation of your specific hardware RNGs showing that > > > the data read

Re: [PATCH] printk: handle blank console arguments passed in.

2020-05-20 Thread Sergey Senozhatsky
On (20/05/15 17:24), Petr Mladek wrote: [..] > > diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c > > index ad4606234545..e9ad730991e0 100644 > > --- a/kernel/printk/printk.c > > +++ b/kernel/printk/printk.c > > @@ -2165,7 +2165,10 @@ static int __init console_setup(char *str) > >

[PATCH] w1_therm: Free the correct variable

2020-05-20 Thread Dan Carpenter
The problem is that we change "p_args" to point to the middle of the string so when we free it at the end of the function it's not freeing the same pointer that we originally allocated. Fixes: e2c94d6f5720 ("w1_therm: adding alarm sysfs entry") Signed-off-by: Dan Carpenter --- >From static

Re: [PATCH 0/3] soundwire: add sysfs support

2020-05-20 Thread Vinod Koul
On 19-05-20, 04:35, Bard Liao wrote: > Add soundwire sysfs support. Thanks for this, I have applied these and two patches for issues I found, one was trailing line in drivers/soundwire/sysfs_slave.c and other was a typo (3rd patch) -- ~Vinod

Re: [PATCH v3 0/6] arm64: add the time namespace support

2020-05-20 Thread Vincenzo Frascino
Hi Andrei, On 4/16/20 6:26 AM, Andrei Vagin wrote: > Allocate the time namespace page among VVAR pages and add the logic > to handle faults on VVAR properly. > > If a task belongs to a time namespace then the VVAR page which contains > the system wide VDSO data is replaced with a namespace

[PATCH] drm/amdgpu: off by on in amdgpu_device_attr_create_groups() error handling

2020-05-20 Thread Dan Carpenter
This loop in the error handling code should start a "i - 1" and end at "i == 0". Currently it starts a "i" and ends at "i == 1". The result is that it removes one attribute that wasn't created yet, and leaks the zeroeth attribute. Fixes: 4e01847c38f7 ("drm/amdgpu: optimize amdgpu device

RE: [PATCH 8/8] mm/zswap: Use local lock to protect per-CPU data

2020-05-20 Thread Song Bao Hua
> Subject: Re: [PATCH 8/8] mm/zswap: Use local lock to protect per-CPU data > > On 2020-05-20 11:13:31 [+], Song Bao Hua wrote: > > For example, on cpu1, once you begin to compress, you hold the percpu > acomp-ctx and percpu destination buffer of CPU1, the below code makes sure > you get the

[PATCH v1] mux: adgs1408: Add mod_devicetable.h and remove of_match_ptr

2020-05-20 Thread Andy Shevchenko
Enables probing via the ACPI PRP0001 route but more is mostly about removing examples of this that might get copied into new drivers. Also fixes drivers/mux/adgs1408.c:112:34: warning: unused variable 'adgs1408_of_match as has been reported recently. Fixes: e9e40543ad5b ("spi: Add generic SPI

[PATCH v2] iio: dac: ad5592r-base: Replace indio_dev->mlock with own device lock

2020-05-20 Thread Sergiu Cuciurean
As part of the general cleanup of indio_dev->mlock, this change replaces it with a local lock on the device's state structure. This also removes unused iio_dev pointers. Signed-off-by: Sergiu Cuciurean --- drivers/iio/dac/ad5592r-base.c | 30 +++---

Re: drivers/mux/adgs1408.c:112:34: warning: unused variable 'adgs1408_of_match'

2020-05-20 Thread Andy Shevchenko
On Wed, May 20, 2020 at 5:23 AM kbuild test robot wrote: > > Hi Chris, > > First bad commit (maybe != root cause): > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: 115a54162a6c0d0ef2aef25ebd0b61fc5e179ebe > commit:

[PATCH v2] of: Fix a refcounting bug in __of_attach_node_sysfs()

2020-05-20 Thread Dan Carpenter
The problem in this code is that if kobject_add() fails, then it should call of_node_put(np) to drop the reference count. I've actually moved the of_node_get(np) later in the function to avoid needing to do clean up. Fixes: 5b2c2f5a0ea3 ("of: overlay: add missing of_node_get() in

Re: linux-next boot error: BUG: Invalid wait context ]

2020-05-20 Thread Thomas Gleixner
syzbot writes: > Hello, > > syzbot found the following crash on: > > HEAD commit:fb57b1fa Add linux-next specific files for 20200519 > git tree: linux-next > console output: https://syzkaller.appspot.com/x/log.txt?x=17c9196e10 > kernel config:

Re: [PATCH] drm/amdgpu: off by on in amdgpu_device_attr_create_groups() error handling

2020-05-20 Thread Christian König
Am 20.05.20 um 14:00 schrieb Dan Carpenter: This loop in the error handling code should start a "i - 1" and end at "i == 0". Currently it starts a "i" and ends at "i == 1". The result is that it removes one attribute that wasn't created yet, and leaks the zeroeth attribute. Fixes:

Re: [PATCH 1/8] locking: Introduce local_lock()

2020-05-20 Thread Peter Zijlstra
On Tue, May 19, 2020 at 10:19:05PM +0200, Sebastian Andrzej Siewior wrote: > +/** > + * DEFINE_LOCAL_LOCK - Define and initialize a per CPU local lock > + * @lock:Name of the lock instance > + */ > +#define DEFINE_LOCAL_LOCK(lvar) \ > +

Re: [PATCH 3/8] srcu: Use local_lock() for per-CPU struct srcu_data access

2020-05-20 Thread Sebastian Andrzej Siewior
On 2020-05-20 12:24:07 [+0200], Peter Zijlstra wrote: > On Tue, May 19, 2020 at 10:19:07PM +0200, Sebastian Andrzej Siewior wrote: > > > diff --git a/kernel/rcu/srcutree.c b/kernel/rcu/srcutree.c > > index 0c71505f0e19c..8d2b5f75145d7 100644 > > --- a/kernel/rcu/srcutree.c > > +++

[PATCH] bus: arm-integrator-lm: Fix an IS_ERR() vs NULL check

2020-05-20 Thread Dan Carpenter
The of_find_matching_node() function returns NULL on error, it never returns error pointers. This doesn't really impact runtime very much because if "syscon" is NULL then syscon_node_to_regmap() will return -EINVAL. The only runtime difference is that now it returns -ENODEV. Fixes: ccea5e8a5918

[PATCH] drm/v3d: fix runtime pm imbalance on error

2020-05-20 Thread Dinghao Liu
pm_runtime_get_sync() increments the runtime PM usage counter even the call returns an error code. Thus a pairing decrement is needed on the error handling path to keep the counter balanced. Signed-off-by: Dinghao Liu --- drivers/gpu/drm/v3d/v3d_gem.c | 4 +++- 1 file changed, 3 insertions(+),

Re: [RFC PATCH 2/2] init: Allow multi-line output of kernel command line

2020-05-20 Thread Sergey Senozhatsky
On (20/05/19 21:58), Joe Perches wrote: [..] > > Maybe we can > > use here something rather random and much shorter instead. E.g. > > 256 chars. Hmm. How > > min(some_max like 132/256, PRINTK_LOG_LINE_MAX) > > would work. An alternative approach would be to do what we do in the

Re: [PATCH v2 1/2] hwrng: iproc-rng200 - Set the quality value

2020-05-20 Thread Stephan Mueller
Am Mittwoch, 20. Mai 2020, 14:00:01 CEST schrieb Krzysztof Kozlowski: Hi Krzysztof, > On Wed, 20 May 2020 at 13:53, Stephan Mueller wrote: > > > > That said, the illustrated example is typical for hardware RNGs. Yet > > > > it is never guaranteed to work that way. Thus, if you can point to > >

Re: [PATCH v2 18/20] mips: csrc-r4k: Decrease r4k-clocksource rating if CPU_FREQ enabled

2020-05-20 Thread Serge Semin
On Tue, May 19, 2020 at 05:50:53PM +0200, Thomas Bogendoerfer wrote: > On Mon, May 18, 2020 at 11:57:52PM +0300, Serge Semin wrote: > > On Mon, May 18, 2020 at 06:32:06PM +0200, Thomas Bogendoerfer wrote: > > > On Mon, May 18, 2020 at 04:48:20PM +0300, Serge Semin wrote: > > > > On Fri, May 15,

[PATCH] can: xilinx_can: fix runtime pm imbalance on error

2020-05-20 Thread Dinghao Liu
pm_runtime_get_sync() increments the runtime PM usage counter even the call returns an error code. Thus a pairing decrement is needed on the error handling path to keep the counter balanced. Signed-off-by: Dinghao Liu --- drivers/net/can/xilinx_can.c | 2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH v7 0/6] gpio: Add GPIO Aggregator

2020-05-20 Thread Andy Shevchenko
On Mon, May 11, 2020 at 04:52:51PM +0200, Geert Uytterhoeven wrote: > Hi all, > > GPIO controllers are exported to userspace using /dev/gpiochip* > character devices. Access control to these devices is provided by > standard UNIX file system permissions, on an all-or-nothing basis: >

Re: [PATCH v2 06/12] i2c: designware: slave: Set DW I2C core module dependency

2020-05-20 Thread Jarkko Nikula
On 5/10/20 12:50 PM, Serge Semin wrote: DW APB I2C slave code in fact depends on the DW I2C driver core, but not on the platform code. Yes, the I2C slave interface is currently supported by the platform version of the IP core, but it doesn't make it dependent on it. So make sure the DW APB I2C

Re: [PATCH v2 05/12] i2c: designware: Use `-y` to build multi-object modules

2020-05-20 Thread Jarkko Nikula
On 5/10/20 12:50 PM, Serge Semin wrote: Since commit 4f8272802739 ("Documentation: update kbuild loadable modules goals & examples") `-objs` is fitted for building host programs, lets change DW I2C core, platform and PCI driver kbuild directives to using `-y`, which more straightforward for

Re: [PATCH v2 07/12] i2c: designware: Move Baytrail sem config to the platform if-clause

2020-05-20 Thread Jarkko Nikula
On 5/10/20 12:50 PM, Serge Semin wrote: Currently Intel Baytrail I2C semaphore is a feature of the DW APB I2C platform driver. It's a bit confusing to see it's config in the menu at some separated place with no reference to the platform code. Lets move the config definition under the

Re: [PATCH v2 04/12] i2c: designware: Convert driver to using regmap API

2020-05-20 Thread Jarkko Nikula
On 5/10/20 12:50 PM, Serge Semin wrote: Seeing the DW I2C driver is using flags-based accessors with two conditional clauses it would be better to replace them with the regmap API IO methods and to initialize the regmap object with read/write callbacks specific to the controller registers map

Re: [PATCH v30 01/20] x86/cpufeatures: x86/msr: Add Intel SGX hardware bits

2020-05-20 Thread Borislav Petkov
On Fri, May 15, 2020 at 03:43:51AM +0300, Jarkko Sakkinen wrote: > From: Sean Christopherson > > Add X86_FEATURE_SGX from CPUID.(EAX=7, ECX=1), which informs whether the > CPU has SGX. > > Add X86_FEATURE_SGX1 and X86_FEATURE_SGX2 from CPUID.(EAX=12H, ECX=0), > which describe the level of SGX

Re: [PATCH v2 10/12] i2c: designware: Discard Cherry Trail model flag

2020-05-20 Thread Jarkko Nikula
On 5/10/20 12:50 PM, Serge Semin wrote: A PM workaround activated by the flag MODEL_CHERRYTRAIL has been removed since commit 9cbeeca05049 ("i2c: designware: Remove Cherry Trail PMIC I2C bus pm_disabled workaround"), but the flag most likely by mistake has been left in the Dw I2C drivers. Lets

[PATCH net-next v2 1/4] net: phy: dp83869: Update port-mirroring to read straps

2020-05-20 Thread Dan Murphy
The device tree may not have the property set for port mirroring because the hardware may have it strapped. If the property is not in the DT then check the straps and set the port mirroring bit appropriately. Reviewed-by: Florian Fainelli Signed-off-by: Dan Murphy --- drivers/net/phy/dp83869.c

<    1   2   3   4   5   6   7   8   9   10   >