Re: [PATCH v5 1/2] remoteproc: qcom: Add per subsystem SSR notification

2020-06-23 Thread rishabhb
On 2020-06-23 14:45, Alex Elder wrote: On 6/22/20 8:04 PM, Rishabh Bhatnagar wrote: Currently there is a single notification chain which is called whenever any remoteproc shuts down. This leads to all the listeners being notified, and is not an optimal design as kernel drivers might only be

Re: [PATCH] VMCI: Avoid extra check for access_ok()

2020-06-23 Thread Souptick Joarder
Hi Greg, On Wed, May 6, 2020 at 1:40 AM Souptick Joarder wrote: > > get_user_pages_fast() is already having a check for the same. This > double check can be removed. > > Signed-off-by: Souptick Joarder Does this need to be marked as stable ? > --- > drivers/misc/vmw_vmci/vmci_host.c | 2 -- >

Re: [PATCH v2] erofs: fix partially uninitialized misuse in z_erofs_onlinepage_fixup

2020-06-23 Thread Chao Yu
On 2020/6/19 7:43, Gao Xiang wrote: > From: Gao Xiang > > Hongyu reported "id != index" in z_erofs_onlinepage_fixup() with > specific aarch64 environment easily, which wasn't shown before. > > After digging into that, I found that high 32 bits of page->private > was set to 0x rather

Re: [PATCH v7 10/19] mm: memcg/slab: deprecate memory.kmem.slabinfo

2020-06-23 Thread Shakeel Butt
On Tue, Jun 23, 2020 at 10:40 AM Roman Gushchin wrote: > > Deprecate memory.kmem.slabinfo. > > An empty file will be presented if corresponding config options are > enabled. > > The interface is implementation dependent, isn't present in cgroup v2, and > is generally useful only for core mm

Re: [PATCH 1/7] irqchip: Fix potential resource leaks

2020-06-23 Thread Tiezhu Yang
On 06/23/2020 11:55 PM, Markus Elfring wrote: There exists some potential resource leaks in the error path, fix them. Will the tag “Fixes” become relevant for the commit message? Hi Markus, Thanks for your reply and suggestion. This patch contains many files in drivers/irqchip, maybe I

Re: [PATCH 05/15] mm: allow read-ahead with IOCB_NOWAIT set

2020-06-23 Thread Matthew Wilcox
On Wed, Jun 24, 2020 at 11:02:53AM +1000, Dave Chinner wrote: > On Thu, Jun 18, 2020 at 08:43:45AM -0600, Jens Axboe wrote: > > The read-ahead shouldn't block, so allow it to be done even if > > IOCB_NOWAIT is set in the kiocb. > > Doesn't think break preadv2(RWF_NOWAIT) semantics for on buffered

Re: [PATCH] mm/spase: never partially remove memmap for early section

2020-06-23 Thread Baoquan He
On 06/23/20 at 05:21pm, Dan Williams wrote: > On Tue, Jun 23, 2020 at 2:43 AM Wei Yang > wrote: > > > > For early sections, we assumes its memmap will never be partially > > removed. But current behavior breaks this. > > Where do we assume that? > > The primary use case for this was mapping

[PATCH v3 2/9] vmlinux.lds.h: Add .symtab, .strtab, and .shstrtab to STABS_DEBUG

2020-06-23 Thread Kees Cook
When linking vmlinux with LLD, the synthetic sections .symtab, .strtab, and .shstrtab are listed as orphaned. Add them to the STABS_DEBUG section so there will be no warnings when --orphan-handling=warn is used more widely. (They are added above comment as it is the more common order[1].) ld.lld:

Re: [PATCH v3 4/5] mm: memcg: charge memcg percpu memory to the parent cgroup

2020-06-23 Thread Roman Gushchin
On Tue, Jun 23, 2020 at 06:40:41PM -0700, Shakeel Butt wrote: > On Tue, Jun 23, 2020 at 11:47 AM Roman Gushchin wrote: > > > > Memory cgroups are using large chunks of percpu memory to store vmstat > > data. Yet this memory is not accounted at all, so in the case when there > > are many (dying)

[PATCH v3 3/9] efi/libstub: Remove .note.gnu.property

2020-06-23 Thread Kees Cook
In preparation for adding --orphan-handling=warn to more architectures, make sure unwanted sections don't end up appearing under the .init section prefix that libstub adds to itself during objcopy. Signed-off-by: Kees Cook --- drivers/firmware/efi/libstub/Makefile | 3 +++ 1 file changed, 3

[PATCH v3 7/9] arm/boot: Warn on orphan section placement

2020-06-23 Thread Kees Cook
We don't want to depend on the linker's orphan section placement heuristics as these can vary between linkers, and may change between versions. All sections need to be explicitly named in the linker script. Use common macros for debug sections, discards, and text stubs. Add discards for unwanted

[PATCH v3 1/9] vmlinux.lds.h: Add .gnu.version* to DISCARDS

2020-06-23 Thread Kees Cook
For vmlinux linking, no architecture uses the .gnu.version* sections, so remove it via the common DISCARDS macro in preparation for adding --orphan-handling=warn more widely. This is a work-around for what appears to be a bug[1] in ld.bfd which warns for this synthetic section even when none is

[PATCH v3 5/9] x86/boot: Warn on orphan section placement

2020-06-23 Thread Kees Cook
We don't want to depend on the linker's orphan section placement heuristics as these can vary between linkers, and may change between versions. All sections need to be explicitly named in the linker script. Add the common debugging sections. Discard the unused note, rel, plt, dyn, and hash

[PATCH v3 8/9] arm64/build: Use common DISCARDS in linker script

2020-06-23 Thread Kees Cook
Use the common DISCARDS rule for the linker script in an effort to regularize the linker script to prepare for warning on orphaned sections. Additionally clean up left-over no-op macros. Signed-off-by: Kees Cook Acked-by: Will Deacon --- arch/arm64/kernel/vmlinux.lds.S | 5 ++--- 1 file

[PATCH v3 9/9] arm64/build: Warn on orphan section placement

2020-06-23 Thread Kees Cook
We don't want to depend on the linker's orphan section placement heuristics as these can vary between linkers, and may change between versions. All sections need to be explicitly named in the linker script. Avoid .eh_frame* by making sure both -fno-asychronous-unwind-tables and -fno-unwind-tables

[PATCH v3 6/9] arm/build: Warn on orphan section placement

2020-06-23 Thread Kees Cook
We don't want to depend on the linker's orphan section placement heuristics as these can vary between linkers, and may change between versions. All sections need to be explicitly named in the linker script. Specifically, this would have made a recently fixed bug very obvious: ld: warning: orphan

[PATCH v3 0/9] Warn on orphan section placement

2020-06-23 Thread Kees Cook
v3: - merge series back together (I tried to make it separable, but no luck) - remove unwanted sections in libstub - remove unwanted .eh_frame sections for both .c and .S - handle sections seen during allnoconfig builds - handle synthetic and double-quoted sections reported by Clang - add

[PATCH v3 4/9] x86/build: Warn on orphan section placement

2020-06-23 Thread Kees Cook
We don't want to depend on the linker's orphan section placement heuristics as these can vary between linkers, and may change between versions. All sections need to be explicitly named in the linker script. Discards the unused rela, plt, and got sections that are not needed in the final vmlinux,

Re: [PATCH v7 10/19] mm: memcg/slab: deprecate memory.kmem.slabinfo

2020-06-23 Thread Roman Gushchin
On Tue, Jun 23, 2020 at 06:43:38PM -0700, Shakeel Butt wrote: > On Tue, Jun 23, 2020 at 10:40 AM Roman Gushchin wrote: > > > > Deprecate memory.kmem.slabinfo. > > > > An empty file will be presented if corresponding config options are > > enabled. > > > > The interface is implementation

Re: [PATCH v1 1/3] scsi: ufs: add write booster feature support

2020-06-23 Thread Stanley Chu
Hi Steev, On Tue, 2020-06-23 at 20:10 -0500, Steev Klimaszewski wrote: > On 6/23/20 1:51 AM, Kyuho Choi wrote: > > Hi Avri, > > > > On 6/23/20, Avri Altman wrote: > >>> AFAIK, this device are ufs 2.1. It's not support writebooster. > >>> > >>> I'd check latest linux scsi branch and

Re: [PATCH v1 1/3] scsi: ufs: add write booster feature support

2020-06-23 Thread Kyuho Choi
Hi Steev, Thanks for share log!. On 6/24/20, Steev Klimaszewski wrote: > > On 6/23/20 1:51 AM, Kyuho Choi wrote: >> Hi Avri, >> >> On 6/23/20, Avri Altman wrote: AFAIK, this device are ufs 2.1. It's not support writebooster. I'd check latest linux scsi branch and

Re: [PATCH RESEND] net/cisco: Fix a sleep-in-atomic-context bug in enic_init_affinity_hint()

2020-06-23 Thread Kaige Li
On 06/24/2020 06:26 AM, David Miller wrote: From: David Miller Date: Tue, 23 Jun 2020 14:33:11 -0700 (PDT) Calling a NIC driver open function from a context holding a spinlock is very much the real problem, so many operations have to sleep and in face that ->ndo_open() method is defined as

[PATCH] kvm: x86: limit the maximum number of vPMU fixed counters to 3

2020-06-23 Thread Like Xu
Some new Intel platforms (such as TGL) already have the fourth fixed counter TOPDOWN.SLOTS, but it has not been fully enabled on KVM and the host. Therefore, we limit edx.split.num_counters_fixed to 3, so that it does not break the kvm-unit-tests PMU test case and bad-handled userspace.

Re: [PATCH v1 1/3] scsi: ufs: add write booster feature support

2020-06-23 Thread Kyuho Choi
Hi Stanley, On 6/24/20, Stanley Chu wrote: > Hi Steev, > > On Tue, 2020-06-23 at 20:10 -0500, Steev Klimaszewski wrote: >> On 6/23/20 1:51 AM, Kyuho Choi wrote: >> > Hi Avri, >> > >> > On 6/23/20, Avri Altman wrote: >> >>> AFAIK, this device are ufs 2.1. It's not support writebooster. >> >>> >>

Re: [PATCH 2/3] nvme-pci: Add controller memory buffer supported macro

2020-06-23 Thread Baolin Wang
On Tue, Jun 23, 2020 at 06:27:51PM +0200, Christoph Hellwig wrote: > On Tue, Jun 23, 2020 at 09:24:33PM +0800, Baolin Wang wrote: > > Introduce a new capability macro to indicate if the controller > > supports the memory buffer or not, instead of reading the > > NVME_REG_CMBSZ register. > > This

Re: [PATCH RESEND] net/cisco: Fix a sleep-in-atomic-context bug in enic_init_affinity_hint()

2020-06-23 Thread Kaige Li
On 06/24/2020 04:50 AM, Jakub Kicinski wrote: On Tue, 23 Jun 2020 16:13:09 +0800 Kaige Li wrote: The kernel module may sleep with holding a spinlock. The function call paths (from bottom to top) are: [FUNC] zalloc_cpumask_var(GFP_KERNEL) drivers/net/ethernet/cisco/enic/enic_main.c, 125:

Re: [PATCH 16/22] gpiolib: cdev: add V2 uAPI implementation to parity with V1 (fwd)

2020-06-23 Thread Kent Gibson
On Tue, Jun 23, 2020 at 07:11:49PM +0200, Julia Lawall wrote: > It looks like the put_device (line 891) should be one line earlier. > Yikes - thanks for that. I'll be sure to coccinelle my code before submitting from now on. Cheers, Kent.

Re: [PATCH] mm/spase: never partially remove memmap for early section

2020-06-23 Thread Baoquan He
On 06/24/20 at 09:47am, Baoquan He wrote: > On 06/23/20 at 05:21pm, Dan Williams wrote: > > On Tue, Jun 23, 2020 at 2:43 AM Wei Yang > > wrote: > > > > > > For early sections, we assumes its memmap will never be partially > > > removed. But current behavior breaks this. > > > > Where do we

[PATCH v4] IB/sa: Resolving use-after-free in ib_nl_send_msg

2020-06-23 Thread Divya Indi
Commit 3ebd2fd0d011 ("IB/sa: Put netlink request into the request list before sending")' - 1. Adds the query to the request list before ib_nl_snd_msg. 2. Moves ib_nl_send_msg out of spinlock, hence safe to use gfp_mask as is. However, if there is a delay in sending out the request (For eg: Delay

RE: [PATCH V2 3/9] clk: imx: Support building SCU clock driver as module

2020-06-23 Thread Aisheng Dong
> From: Stephen Boyd > Sent: Wednesday, June 24, 2020 8:58 AM > Subject: RE: [PATCH V2 3/9] clk: imx: Support building SCU clock driver as > module > > Quoting Aisheng Dong (2020-06-23 02:00:47) > > > From: Stephen Boyd > > > Sent: Tuesday, June 23, 2020 4:34 PM > > > Subject: RE: [PATCH V2

[PATCH v6 1/2] remoteproc: qcom: Add per subsystem SSR notification

2020-06-23 Thread Rishabh Bhatnagar
Currently there is a single notification chain which is called whenever any remoteproc shuts down. This leads to all the listeners being notified, and is not an optimal design as kernel drivers might only be interested in listening to notifications from a particular remoteproc. Create a global

[PATCH v6 0/2] Extend SSR notifications framework

2020-06-23 Thread Rishabh Bhatnagar
This set of patches gives kernel client drivers the ability to register for a particular remoteproc's SSR notifications. Also the notifications are extended to before/after-powerup/shutdown stages. It also fixes the bug where clients need to register for notifications again if the platform driver

[PATCH v6 2/2] remoteproc: qcom: Add notification types to SSR

2020-06-23 Thread Rishabh Bhatnagar
The SSR subdevice only adds callback for the unprepare event. Add callbacks for prepare, start and prepare events. The client driver for a particular remoteproc might be interested in knowing the status of the remoteproc while undergoing SSR, not just when the remoteproc has finished shutting

RE: [v2 3/4] arm64: dts: ls1012a/ls1043a/ls1046a/ls1088a/ls208xa: add ftm_alarm0 node

2020-06-23 Thread Biwen Li (OSS)
> > Signed-off-by: Biwen Li > > --- > > Change in v2: > > - use generic name > > - use definition > > > > arch/arm64/boot/dts/freescale/fsl-ls1012a.dtsi | 15 +++ > > arch/arm64/boot/dts/freescale/fsl-ls1043a.dtsi | 14 ++ > >

Re: linux-next: build failures after merge of the hid tree

2020-06-23 Thread Nathan Chancellor
Hi Jiri and Cristian, On Wed, Jun 24, 2020 at 12:13:57AM +0200, Jiri Kosina wrote: > On Tue, 23 Jun 2020, Stephen Rothwell wrote: > > > > I don't know what caused it, but commit > > > > > > 470376737e88 ("HID: allow building hid.ko as an external module") > > > > > > did not fix it. BTW, I

[RFC v4 1/3] usb: dwc3: Resize TX FIFOs to meet EP bursting requirements

2020-06-23 Thread Wesley Cheng
Some devices have USB compositions which may require multiple endpoints that support EP bursting. HW defined TX FIFO sizes may not always be sufficient for these compositions. By utilizing flexible TX FIFO allocation, this allows for endpoints to request the required FIFO depth to achieve higher

[RFC v4 3/3] dt-bindings: usb: dwc3: Add entry for tx-fifo-resize

2020-06-23 Thread Wesley Cheng
Re-introduce the comment for the tx-fifo-resize setting for the DWC3 controller. This allows for vendors to control if they require the TX FIFO resizing logic on their HW, as the default FIFO size configurations may already be sufficient. Signed-off-by: Wesley Cheng Acked-by: Rob Herring ---

[RFC v4 0/3] Re-introduce TX FIFO resize for larger EP bursting

2020-06-23 Thread Wesley Cheng
Changes in V4: - Removed struct dwc3* as an argument for dwc3_gadget_resize_tx_fifos() - Removed WARN_ON(1) in case we run out of fifo space Changes in V3: - Removed "Reviewed-by" tags - Renamed series back to RFC - Modified logic to ensure that fifo_size is reset if we pass the minimum

[RFC v4 2/3] arm64: boot: dts: qcom: sm8150: Enable dynamic TX FIFO resize logic

2020-06-23 Thread Wesley Cheng
Enable the flexible TX FIFO resize logic on SM8150. Using a larger TX FIFO SZ can help account for situations when system latency is greater than the USB bus transmission latency. Signed-off-by: Wesley Cheng --- arch/arm64/boot/dts/qcom/sm8150.dtsi | 1 + 1 file changed, 1 insertion(+) diff

RE: [RESEND PATCH] arm64: dts: ls1028a: Add DSPI nodes

2020-06-23 Thread Qiang Zhao
On 2020/6/24, Leo Li wrote: > -Original Message- > From: Leo Li > Sent: 2020年6月24日 7:12 > To: Qiang Zhao ; shawn...@kernel.org > Cc: devicet...@vger.kernel.org; linux-kernel@vger.kernel.org; Qiang Zhao > ; Xiaowei Bao > Subject: RE: [RESEND PATCH] arm64: dts: ls1028a: Add DSPI nodes >

[PATCH v2] exfat: optimize exfat_zeroed_cluster()

2020-06-23 Thread Tetsuhiro Kohada
Replace part of exfat_zeroed_cluster() with exfat_update_bhs(). And remove exfat_sync_bhs(). Signed-off-by: Tetsuhiro Kohada --- Changes in v2 - Rebase to latest exfat-dev fs/exfat/fatent.c | 53 +-- 1 file changed, 10 insertions(+), 43 deletions(-)

RE: [PATCH V2 3/9] clk: imx: Support building SCU clock driver as module

2020-06-23 Thread Anson Huang
> Subject: RE: [PATCH V2 3/9] clk: imx: Support building SCU clock driver as > module > > > From: Stephen Boyd > > Sent: Wednesday, June 24, 2020 8:58 AM > > Subject: RE: [PATCH V2 3/9] clk: imx: Support building SCU clock > > driver as module > > > > Quoting Aisheng Dong (2020-06-23 02:00:47)

Re: [PATCH v6 1/5] KVM: s390: clean up redundant 'kvm_run' parameters

2020-06-23 Thread Tianjia Zhang
On 2020/6/23 23:31, Christian Borntraeger wrote: On 23.06.20 15:14, Tianjia Zhang wrote: In the current kvm version, 'kvm_run' has been included in the 'kvm_vcpu' structure. For historical reasons, many kvm-related function parameters retain the 'kvm_run' and 'kvm_vcpu' parameters at the

Re: [PATCH v1 1/3] scsi: ufs: add write booster feature support

2020-06-23 Thread Stanley Chu
Hi Kyuho, On Wed, 2020-06-24 at 11:06 +0900, Kyuho Choi wrote: > Hi Stanley, > > On 6/24/20, Stanley Chu wrote: > > Hi Steev, > > > > On Tue, 2020-06-23 at 20:10 -0500, Steev Klimaszewski wrote: > >> On 6/23/20 1:51 AM, Kyuho Choi wrote: > >> > Hi Avri, > >> > > >> > On 6/23/20, Avri Altman

[v3 1/4] arm64: dts: lx2160a: add ftm_alarm0 DT node

2020-06-23 Thread Biwen Li
From: Biwen Li The patch adds ftm_alarm0 DT node for Soc LX2160A FlexTimer1 module is used to wakeup the system in deep sleep Signed-off-by: Biwen Li --- Change in v3: - none Change in v2: - use generic name - use definition

[PATCH v1] scsi: ufs: Disable WriteBooster capability in non-supported UFS device

2020-06-23 Thread Stanley Chu
If UFS device is not qualified to enter the detection of WriteBooster probing by disallowed UFS version or device quirks, then WriteBooster capability in host shall be disabled to prevent any WriteBooster operations in the future. Signed-off-by: Stanley Chu --- drivers/scsi/ufs/ufshcd.c | 35

[v3 4/4] arm: dts: ls1021a: add ftm_alarm0 DT node

2020-06-23 Thread Biwen Li
From: Biwen Li The patch add ftm_alarm0 DT node - add rcpm node - add ftm_alarm0 node - aliases ftm_alarm0 as rtc1 Signed-off-by: Biwen Li --- Change in v3: - sort alphabetically Change in v2: - use generic name arch/arm/boot/dts/ls1021a.dtsi | 15

[v3 2/4] arm64: dts: ls1028a: Add ftm_alarm0 DT node

2020-06-23 Thread Biwen Li
From: Biwen Li The patch adds ftm_alarm0 DT node for LS1028ARDB board FlexTimer1 module is used to wakeup the system Signed-off-by: Biwen Li --- Change in v3: - none Change in v2: - use generic name - use definition arch/arm64/boot/dts/freescale/fsl-ls1028a.dtsi | 17

[v3 3/4] arm64: dts: ls1012a/ls1043a/ls1046a/ls1088a/ls208xa: add ftm_alarm0 node

2020-06-23 Thread Biwen Li
From: Biwen Li The patch adds ftm_alarm0 DT node - add new rcpm node - add ftm_alarm0 node - aliases ftm_alarm0 as rtc1 Signed-off-by: Biwen Li --- Change in v3: - sort alphabetically Change in v2: - use generic name - use definition

Re: [PATCH 1/3] nvme: Add Arbitration Burst support

2020-06-23 Thread Keith Busch
On Wed, Jun 24, 2020 at 09:34:08AM +0800, Baolin Wang wrote: > OK, I understaood your concern. Now we will select the RR arbitration as > default > in nvme_enable_ctrl(), but for some cases, we will not set the arbitration > burst > values from userspace, and we still want to use the defaut

Re: [PATCH 1/3] nvme: Add Arbitration Burst support

2020-06-23 Thread Baolin Wang
On Tue, Jun 23, 2020 at 07:51:35PM -0700, Keith Busch wrote: > On Wed, Jun 24, 2020 at 09:34:08AM +0800, Baolin Wang wrote: > > OK, I understaood your concern. Now we will select the RR arbitration as > > default > > in nvme_enable_ctrl(), but for some cases, we will not set the arbitration > >

Re: [PATCH 1/3] nvme: Add Arbitration Burst support

2020-06-23 Thread Keith Busch
On Tue, Jun 23, 2020 at 09:24:32PM +0800, Baolin Wang wrote: > +void nvme_set_arbitration_burst(struct nvme_ctrl *ctrl) > +{ > + u32 result; > + int status; > + > + if (!ctrl->rab) > + return; > + > + /* > + * The Arbitration Burst setting indicates the maximum

Re: [EXT] Re: [PATCH v1] ARM: imx6plus: enable internal routing of clk_enet_ref where possible

2020-06-23 Thread Sven Van Asbroeck
Hi Andy, On Tue, Jun 23, 2020 at 9:40 PM Andy Duan wrote: > > The patch looks good. > Reviewed-by: Fugang Duan Thank you ! To check we're on a plus, the patch uses: cpu_is_imx6q() && imx_get_soc_revision() >= IMX_CHIP_REVISION_2_0 Fabio Estevam suggested that perhaps checking

Re: [PATCH 2/3] nvme-pci: Add controller memory buffer supported macro

2020-06-23 Thread Keith Busch
On Tue, Jun 23, 2020 at 06:27:51PM +0200, Christoph Hellwig wrote: > On Tue, Jun 23, 2020 at 09:24:33PM +0800, Baolin Wang wrote: > > Introduce a new capability macro to indicate if the controller > > supports the memory buffer or not, instead of reading the > > NVME_REG_CMBSZ register. > > This

RE: [PATCH V2 3/9] clk: imx: Support building SCU clock driver as module

2020-06-23 Thread Aisheng Dong
> From: Anson Huang > Sent: Wednesday, June 24, 2020 10:36 AM > > > Subject: RE: [PATCH V2 3/9] clk: imx: Support building SCU clock > > driver as module > > > > > From: Stephen Boyd > > > Sent: Wednesday, June 24, 2020 8:58 AM > > > Subject: RE: [PATCH V2 3/9] clk: imx: Support building SCU

linux-next: manual merge of the rcu tree with the tip tree

2020-06-23 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the rcu tree got a conflict in: kernel/sched/core.c between commit: 964ed98b0752 ("sched/core: Fix ttwu() race") from the tip tree and commit: 3c88d09bfb1b ("EXP sched: Alleged fix for v5.8 merge-window scheduler issue") from the rcu tree. I fixed

Re: [PATCH 1/3] nvme: Add Arbitration Burst support

2020-06-23 Thread Baolin Wang
On Tue, Jun 23, 2020 at 07:57:15PM -0700, Keith Busch wrote: > On Tue, Jun 23, 2020 at 09:24:32PM +0800, Baolin Wang wrote: > > +void nvme_set_arbitration_burst(struct nvme_ctrl *ctrl) > > +{ > > + u32 result; > > + int status; > > + > > + if (!ctrl->rab) > > + return; > > + > > +

[PATCH] fs/read_write.c: Fix memory leak in read_write.c

2020-06-23 Thread Peng Fan
kmemleak report: unreferenced object 0x9802bb591d00 (size 256): comm "ftest03", pid 24778, jiffies 4301603810 (age 490.665s) hex dump (first 32 bytes): 00 01 04 20 01 00 00 00 80 00 00 00 00 00 00 00 ... f0 02 04 20 01 00 00 00 80 00 00 00 00 00 00 00 ...

Re: [PATCH v3 01/10] objtool: Do not assume order of parent/child functions

2020-06-23 Thread Josh Poimboeuf
On Tue, Jun 23, 2020 at 10:23:18AM -0700, Kristen Carlson Accardi wrote: > If a .cold function is examined prior to it's parent, the link > to the parent/child function can be overwritten when the parent > is examined. Only update pfunc and cfunc if they were previously > nil to prevent this from

Re: [PATCH V3 0/4] mm/debug_vm_pgtable: Add some more tests

2020-06-23 Thread Anshuman Khandual
On 06/15/2020 09:07 AM, Anshuman Khandual wrote: > This series adds some more arch page table helper validation tests which > are related to core and advanced memory functions. This also creates a > documentation, enlisting expected semantics for all page table helpers as > suggested by Mike

Re: [PATCH] [net/ethernet] do_reset: remove dev null check

2020-06-23 Thread David Miller
From: Gaurav Singh Date: Tue, 23 Jun 2020 20:55:45 -0400 > dev cannot be NULL here since its already being accessed > before. Remove the redundant null check. > > Signed-off-by: Gaurav Singh I changed your Subject to be: [PATCH net-next] xirc2ps_cs: remove dev null check from do_reset().

Re: [PATCH] [net/wan] cosa_init: check bounds before access

2020-06-23 Thread David Miller
From: Gaurav Singh Date: Tue, 23 Jun 2020 21:04:49 -0400 > Check i < io bounds before accessing io[i]. > > Signed-off-by: Gaurav Singh The io[] array is intentionally zero terminated, there is no problem.

Are there still some methods that could be used by the Linux kernel to reduce memory fragmentation while both CONFIG-MIGRATION and CONFIG-COMPACTION are disabled?

2020-06-23 Thread 孙世龙 sunshilong
Hi, Are there still some methods that could be used by the Linux kernel to reduce memory fragmentation while both CONFIG-MIGRATION and CONFIG-COMPACTION are disabled? Are there some system settings that could make for this goal? Thank you for your attention to this matter. Best regards.

Re: [PATCH RESEND] net/cisco: Fix a sleep-in-atomic-context bug in enic_init_affinity_hint()

2020-06-23 Thread David Miller
From: Kaige Li Date: Wed, 24 Jun 2020 09:56:47 +0800 > > On 06/24/2020 06:26 AM, David Miller wrote: >> From: David Miller >> Date: Tue, 23 Jun 2020 14:33:11 -0700 (PDT) >> >>> Calling a NIC driver open function from a context holding a spinlock >>> is very much the real problem, so many

Re: [PATCH RESEND] net/cisco: Fix a sleep-in-atomic-context bug in enic_init_affinity_hint()

2020-06-23 Thread David Miller
From: Kaige Li Date: Wed, 24 Jun 2020 10:07:16 +0800 > You are right. Should I do spin_unlock before the enic_open, or remove > spin_lock in enic_reset? You need to learn how this driver's locking works and design a correct adjustment.

Re: [PATCH] fs/read_write.c: Fix memory leak in read_write.c

2020-06-23 Thread Matthew Wilcox
On Wed, Jun 24, 2020 at 11:07:03AM +0800, Peng Fan wrote: > kmemleak report: > unreferenced object 0x9802bb591d00 (size 256): > comm "ftest03", pid 24778, jiffies 4301603810 (age 490.665s) > hex dump (first 32 bytes): > 00 01 04 20 01 00 00 00 80 00 00 00 00 00 00 00 ...

Re: [PATCH] net: qrtr: free flow in __qrtr_node_release

2020-06-23 Thread David Miller
From: Carl Huang Date: Tue, 23 Jun 2020 11:22:03 +0800 > @@ -168,6 +168,7 @@ static void __qrtr_node_release(struct kref *kref) > struct radix_tree_iter iter; > unsigned long flags; > void __rcu **slot; > + struct qrtr_tx_flow *flow; Please retain the reverse christmas

[PATCH v3 2/2] net: phy: call phy_disable_interrupts() in phy_init_hw()

2020-06-23 Thread Jisheng Zhang
Call phy_disable_interrupts() in phy_init_hw() to "have a defined init state as we don't know in which state the PHY is if the PHY driver is loaded. We shouldn't assume that it's the chip power-on defaults, BIOS or boot loader could have changed this. Or in case of dual-boot systems the other OS

[PATCH v3 0/2] net: phy: call phy_disable_interrupts() in phy_init_hw()

2020-06-23 Thread Jisheng Zhang
We face an issue with rtl8211f, a pin is shared between INTB and PMEB, and the PHY Register Accessible Interrupt is enabled by default, so the INTB/PMEB pin is always active in polling mode case. As Heiner pointed out "I was thinking about calling phy_disable_interrupts() in phy_init_hw(), to

[PATCH] mm/page_alloc: fix documentation error and remove magic numbers

2020-06-23 Thread Joel Savitz
When I increased the upper bound of the min_free_kbytes value in ee8eb9a5fe863, I forgot to tweak the above comment to reflect the new value. This patch fixes that mistake. In addition, this patch replaces the magic number bounds with symbolic constants to clarify the logic. Suggested-by: John

[PATCH v3 1/2] net: phy: make phy_disable_interrupts() non-static

2020-06-23 Thread Jisheng Zhang
We face an issue with rtl8211f, a pin is shared between INTB and PMEB, and the PHY Register Accessible Interrupt is enabled by default, so the INTB/PMEB pin is always active in polling mode case. As Heiner pointed out "I was thinking about calling phy_disable_interrupts() in phy_init_hw(), to

Re: [PATCH][next] net: ipv6: Use struct_size() helper and kcalloc()

2020-06-23 Thread David Miller
From: "Gustavo A. R. Silva" Date: Mon, 22 Jun 2020 18:07:41 -0500 > Make use of the struct_size() helper instead of an open-coded version > in order to avoid any potential type mistakes. Also, remove unnecessary > function ipv6_rpl_srh_alloc_size() and replace kzalloc() with kcalloc(), > which

Re: [PATCH] [net/decnet] dn_route_rcv: remove redundant dev null check

2020-06-23 Thread David Miller
From: Gaurav Singh Date: Mon, 22 Jun 2020 23:41:19 -0400 > dev cannot be NULL here since its already being accessed > before. Remove the redundant null check. > > Signed-off-by: Gaurav Singh Applied.

Re: [PATCH] [net] dcb_doit: remove redundant skb check

2020-06-23 Thread David Miller
From: Gaurav Singh Date: Mon, 22 Jun 2020 22:50:39 -0400 > skb cannot be NULL here since its already being accessed > before: sock_net(skb->sk). Remove the redundant null check. > > Signed-off-by: Gaurav Singh Applied.

[PATCH] [drivers/x86] fix bound check in pmc_core_mphy_pg_show

2020-06-23 Thread Gaurav Singh
Check bounds before accessing map[]. Signed-off-by: Gaurav Singh --- drivers/platform/x86/intel_pmc_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/intel_pmc_core.c b/drivers/platform/x86/intel_pmc_core.c index 7c8bdab078cf..f571f9cf7217 100644

Re: [PATCH v3 3/9] efi/libstub: Remove .note.gnu.property

2020-06-23 Thread Fangrui Song
On 2020-06-23, Kees Cook wrote: In preparation for adding --orphan-handling=warn to more architectures, make sure unwanted sections don't end up appearing under the .init section prefix that libstub adds to itself during objcopy. Signed-off-by: Kees Cook ---

Re: [PATCH v2 0/3] ethernet: amd: Convert to generic power management

2020-06-23 Thread David Miller
From: Vaibhav Gupta Date: Mon, 22 Jun 2020 16:43:57 +0530 > Linux Kernel Mentee: Remove Legacy Power Management. > > The purpose of this patch series is to remove legacy power management > callbacks > from amd ethernet drivers. > > The callbacks performing suspend() and resume() operations

Re: [PATCH -V2] swap: Reduce lock contention on swap cache from swap slots allocation

2020-06-23 Thread Huang, Ying
"Huang, Ying" writes: > Andrew Morton writes: > >> On Wed, 20 May 2020 11:15:02 +0800 Huang Ying wrote: >> >>> In some swap scalability test, it is found that there are heavy lock >>> contention on swap cache even if we have split one swap cache radix >>> tree per swap device to one swap cache

Re: [PATCH v1 0/5] ethernet: dec: tulip: use generic power management

2020-06-23 Thread David Miller
From: Vaibhav Gupta Date: Mon, 22 Jun 2020 17:12:23 +0530 > Linux Kernel Mentee: Remove Legacy Power Management. > > The purpose of this patch series is to remove legacy power management > callbacks and invocation of PCI helper functions, from tulip ethernet drivers. > > With legacy PM,

Re: [PATCH v3 2/2] net: phy: call phy_disable_interrupts() in phy_init_hw()

2020-06-23 Thread Florian Fainelli
Le 2020-06-23 à 20:26, Jisheng Zhang a écrit : > Call phy_disable_interrupts() in phy_init_hw() to "have a defined init > state as we don't know in which state the PHY is if the PHY driver is > loaded. We shouldn't assume that it's the chip power-on defaults, BIOS > or boot loader could have

[for-linus][PATCH 1/4] ring-buffer: Zero out time extend if it is nested and not absolute

2020-06-23 Thread Steven Rostedt
From: "Steven Rostedt (VMware)" Currently the ring buffer makes events that happen in interrupts that preempt another event have a delta of zero. (Hopefully we can change this soon). But this is to deal with the races of updating a global counter with lockless and nesting functions updating

[for-linus][PATCH 2/4] tracing/boot: Fix config dependency for synthedic event

2020-06-23 Thread Steven Rostedt
From: Masami Hiramatsu Since commit 726721a51838 ("tracing: Move synthetic events to a separate file") decoupled synthetic event from histogram, boot-time tracing also has to check CONFIG_SYNTH_EVENT instead of CONFIG_HIST_TRIGGERS. Link:

[for-linus][PATCH 3/4] tracing: Fix event trigger to accept redundant spaces

2020-06-23 Thread Steven Rostedt
From: Masami Hiramatsu Fix the event trigger to accept redundant spaces in the trigger input. For example, these return -EINVAL echo " traceon" > events/ftrace/print/trigger echo "traceon if common_pid == 0" > events/ftrace/print/trigger echo "disable_event:kmem:kmalloc " >

[for-linus][PATCH 4/4] tracing/boottime: Fix kprobe multiple events

2020-06-23 Thread Steven Rostedt
From: Sascha Ortmann Fix boottime kprobe events to report and abort after each failure when adding probes. As an example, when we try to set multiprobe kprobe events in bootconfig like this: ftrace.event.kprobes.vfsevents { probes = "vfs_read $arg1 $arg2,, !error! not

[for-linus][PATCH 0/4] tracing: Fixes for 5.8-rc

2020-06-23 Thread Steven Rostedt
Masami Hiramatsu (2): tracing/boot: Fix config dependency for synthedic event tracing: Fix event trigger to accept redundant spaces Sascha Ortmann (1): tracing/boottime: Fix kprobe multiple events Steven Rostedt (VMware) (1): ring-buffer: Zero out time extend if it is

Re: [PATCH RESEND] net/cisco: Fix a sleep-in-atomic-context bug in enic_init_affinity_hint()

2020-06-23 Thread Kaige Li
On 06/24/2020 11:23 AM, David Miller wrote: From: Kaige Li Date: Wed, 24 Jun 2020 09:56:47 +0800 On 06/24/2020 06:26 AM, David Miller wrote: From: David Miller Date: Tue, 23 Jun 2020 14:33:11 -0700 (PDT) Calling a NIC driver open function from a context holding a spinlock is very much

ERROR: "min_low_pfn" undefined!

2020-06-23 Thread kernel test robot
months ago config: microblaze-randconfig-c021-20200623 (attached as .config) compiler: microblaze-linux-gcc (GCC) 9.3.0 If you fix the issue, kindly add following tag as appropriate Reported-by: kernel test robot All errors (new ones prefixed by >>): ERROR: "min_low_pfn" [net/m

RE: [EXT] Re: [PATCH v1] ARM: imx6plus: enable internal routing of clk_enet_ref where possible

2020-06-23 Thread Andy Duan
From: Sven Van Asbroeck Sent: Wednesday, June 24, 2020 10:56 AM > Hi Andy, > > On Tue, Jun 23, 2020 at 9:40 PM Andy Duan wrote: > > > > The patch looks good. > > Reviewed-by: Fugang Duan > > Thank you ! > > To check we're on a plus, the patch uses: > cpu_is_imx6q() && imx_get_soc_revision()

Re: [PATCH] mm/spase: never partially remove memmap for early section

2020-06-23 Thread Wei Yang
On Wed, Jun 24, 2020 at 09:47:37AM +0800, Baoquan He wrote: >On 06/23/20 at 05:21pm, Dan Williams wrote: >> On Tue, Jun 23, 2020 at 2:43 AM Wei Yang >> wrote: >> > >> > For early sections, we assumes its memmap will never be partially >> > removed. But current behavior breaks this. >> >> Where

Re: [PATCH 1/2] selftests/lkdtm: Don't clear dmesg when running tests

2020-06-23 Thread Joe Lawrence
On 6/22/20 4:51 AM, Naresh Kamboju wrote: On Fri, 8 May 2020 at 12:23, Michael Ellerman wrote: It is Very Rude to clear dmesg in test scripts. That's because the script may be part of a larger test run, and clearing dmesg potentially destroys the output of other tests. We can avoid using

RE: [PATCH 1/1] power_supply: wilco_ec: Add permanent long life charging mode

2020-06-23 Thread Crag.Wang
> > > Since this is normally only done in the factory context, can you > > > please confirm does something need to be artificially done to block > > > userland from trying to set the battery charging to this mode? Or > > > will the EC already > > handle > > > blocking it directly? > > > > This is

Re: Add MediaTek MT6873 devapc driver

2020-06-23 Thread Neal Liu
On Tue, 2020-06-09 at 11:32 -0600, Rob Herring wrote: > On Tue, Jun 09, 2020 at 06:24:19PM +0800, Neal Liu wrote: > > These patch series introduce a MediaTek MT6873 devapc driver. > > > > MT6873 bus frabric provides TrustZone security support and data > > protection to prevent slaves from being

Re: [PATCH] mm/spase: never partially remove memmap for early section

2020-06-23 Thread Baoquan He
On 06/24/20 at 11:46am, Wei Yang wrote: > On Wed, Jun 24, 2020 at 09:47:37AM +0800, Baoquan He wrote: > >On 06/23/20 at 05:21pm, Dan Williams wrote: > >> On Tue, Jun 23, 2020 at 2:43 AM Wei Yang > >> wrote: > >> > > >> > For early sections, we assumes its memmap will never be partially > >> >

Re: [PATCH] mm/spase: never partially remove memmap for early section

2020-06-23 Thread Wei Yang
On Wed, Jun 24, 2020 at 11:52:36AM +0800, Baoquan He wrote: >On 06/24/20 at 11:46am, Wei Yang wrote: >> On Wed, Jun 24, 2020 at 09:47:37AM +0800, Baoquan He wrote: >> >On 06/23/20 at 05:21pm, Dan Williams wrote: >> >> On Tue, Jun 23, 2020 at 2:43 AM Wei Yang >> >> wrote: >> >> > >> >> > For early

[PATCH] powerpc/boot: Use address-of operator on section symbols

2020-06-23 Thread Nathan Chancellor
Clang warns: arch/powerpc/boot/main.c:107:18: warning: array comparison always evaluates to a constant [-Wtautological-compare] if (_initrd_end > _initrd_start) { ^ arch/powerpc/boot/main.c:155:20: warning: array comparison always evaluates to a constant

Re: reset-brcmstb-rescal.c:undefined reference to `devm_ioremap_resource'

2020-06-23 Thread Florian Fainelli
On 6/23/2020 6:26 PM, kernel test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: 3e08a95294a4fb3702bb3d35ed08028433c37fe6 > commit: 4cf176e52397853e4a4dd37e917c5eafb47ba8d1 reset: Add Broadcom STB > RESCAL reset controller > date:

Re: [PATCH 2/2] Documentation/litmus-tests: Add note on herd7 7.56 in atomic litmus test

2020-06-23 Thread Paul E. McKenney
On Wed, Jun 24, 2020 at 01:24:25AM +0200, Andrea Parri wrote: > On Wed, Jun 24, 2020 at 07:09:01AM +0900, Akira Yokosawa wrote: > > From f808c371075d2f92b955da1a83ecb3828db1972e Mon Sep 17 00:00:00 2001 > > From: Akira Yokosawa > > Date: Wed, 24 Jun 2020 06:59:26 +0900 > > Subject: [PATCH 2/2]

Re: linux-next: manual merge of the rcu tree with the tip tree

2020-06-23 Thread Paul E. McKenney
On Wed, Jun 24, 2020 at 01:04:50PM +1000, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the rcu tree got a conflict in: > > kernel/sched/core.c > > between commit: > > 964ed98b0752 ("sched/core: Fix ttwu() race") > > from the tip tree and commit: > > 3c88d09bfb1b

Subject: [PATCH v3 1/2] USB: serial: cp210x: Enable usb generic throttle/unthrottle

2020-06-23 Thread Phu Luu
Assign the .throttle and .unthrottle functions to be generic function in the driver structure to prevent data loss that can otherwise occur if the host does not enable USB throttling. Signed-off-by: Phu Luu An Signed-off-by: Brant Merryman --- 06/09/2020: Patch v3 1/2 Modified based on feedback

Re: [PATCH 5.4 000/314] 5.4.49-rc1 review

2020-06-23 Thread Nathan Chancellor
On Tue, Jun 23, 2020 at 09:53:15PM +0200, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 5.4.49 release. > There are 314 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me

<    1   2   3   4   5   6   7   8   9   10   >