drivers/interconnect/qcom/icc-rpmh.c:132:28: sparse: sparse: incorrect type in assignment (different base types)

2020-07-06 Thread kernel test robot
-20200706 (attached as .config) compiler: aarch64-linux-gcc (GCC) 9.3.0 reproduce: wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # apt-get install sparse # sparse version: v0.6.2-14-g8fce3d7a

[PATCH v3 08/13] bus/fsl-mc: Export a cleanup function for DPRC

2020-07-06 Thread Diana Craciun
From: Diana Craciun Create and export a cleanup function for DPRC. The function is used by the DPRC driver, but it will be used by the VFIO driver as well. Signed-off-by: Diana Craciun --- drivers/bus/fsl-mc/dprc-driver.c | 52 include/linux/fsl/mc.h

Re: [PATCH v2 16/18] media: mtk-vcodec: venc: make S_PARM return -ENOTTY for CAPTURE queue

2020-07-06 Thread Hans Verkuil
On 04/07/2020 14:36, Alexandre Courbot wrote: > On Fri, Jul 3, 2020 at 5:30 PM Hans Verkuil wrote: >> >> On 26/06/2020 10:04, Alexandre Courbot wrote: >>> v4l2-compliance expects ENOTTY to be returned when a given queue does >>> not support S_PARM. >>> >>> Signed-off-by: Alexandre Courbot >>>

[PATCH v3 13/13] bus/fsl-mc: Add a new version for dprc_get_obj_region command

2020-07-06 Thread Diana Craciun
From: Diana Craciun The region size reported by the firmware for mc and software portals was less than allocated by the hardware. This may be problematic when mmapping the region in user space because the region size is less than page size. However the size as reserved by the hardware is 64K.

[PATCH v3 01/13] bus/fsl-mc: Do no longer export the total number of irqs outside dprc_scan_objects

2020-07-06 Thread Diana Craciun
From: Diana Craciun The total number of interrupts is only used for some checks outside the dprc_scan_objects function. Furthermore, in some situations the check is made twice. Move the bounds check inside the function for all situations. Signed-off-by: Diana Craciun ---

[PATCH net-next] selftests: mptcp: capture pcap on both sides

2020-07-06 Thread Matthieu Baerts
When investigating performance issues that involve latency / loss / reordering it is useful to have the pcap from the sender-side as it allows to easier infer the state of the sender's congestion-control, loss-recovery, etc. Allow the selftests to capture a pcap on both sender and receiver so

[PATCH v3] hung_task:add detecting task in D state milliseconds timeout

2020-07-06 Thread yang che
current hung_task_check_interval_secs and hung_task_timeout_secs only supports seconds. In some cases,the TASK_UNINTERRUPTIBLE state takes less than 1 second,may need to hung task trigger panic get ramdump or print all cpu task. modify hung_task_check_interval_secs to

Re: [PATCH] CodingStyle: Inclusive Terminology

2020-07-06 Thread Chris Mason
On 5 Jul 2020, at 0:55, Willy Tarreau wrote: > On Sat, Jul 04, 2020 at 01:02:51PM -0700, Dan Williams wrote: >> +Non-inclusive terminology has that same distracting effect which is >> why >> +it is a style issue for Linux, it injures developer efficiency. > > I'm personally thinking that for a

RE: [PATCH v4 03/15] iommu/smmu: Report empty domain nesting info

2020-07-06 Thread Liu, Yi L
Hi Eric, > From: Auger Eric > > Hi Yi, > > Please add a commit message: instead of returning a boolean for > DOMAIN_ATTR_NESTING, arm_smmu_domain_get_attr() returns a > iommu_nesting_info handle. will do. thanks for the suggestion. > > On 7/4/20 1:26 PM, Liu Yi L wrote: > > Cc: Will Deacon

RE: [PATCH 1/3] arm64/numa: set numa_off to false when numa node is fake

2020-07-06 Thread Justin He
Hi Jonathan, thanks for the comments. > -Original Message- > From: Jonathan Cameron > Sent: Monday, July 6, 2020 6:46 PM > To: Justin He > Cc: Catalin Marinas ; Will Deacon > ; Andrew Morton ; Mike > Rapoport ; Baoquan He ; Chuhong Yuan > ; linux-arm-ker...@lists.infradead.org; linux- >

Re: mainline/master bisection: baseline.dmesg.crit on qemu_arm-vexpress-a15

2020-07-06 Thread Sudeep Holla
Hi, On Sun, Jul 05, 2020 at 07:12:58PM -0700, kernelci.org bot wrote: > * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * > * This automated bisection report was sent to you on the basis * > * that you may be involved with the breaking commit it has * > * found. No manual

Re: [Ksummit-discuss] [PATCH] CodingStyle: Inclusive Terminology

2020-07-06 Thread Matthew Wilcox
On Mon, Jul 6, 2020 at 3:54 AM Geert Uytterhoeven wrote: > On Mon, Jul 6, 2020 at 9:22 AM Greg Kroah-Hartman > wrote: > > On Mon, Jul 06, 2020 at 05:10:37PM +1000, NeilBrown wrote: > > > On Sat, Jul 04 2020, Matthew Wilcox wrote: > > > > Another suggestion for "slave" replacement should be

Re: [Intel-gfx] [PATCH v9 5/5] drm/i915: Enable support for integrated privacy screen

2020-07-06 Thread Hans de Goede
Hi, On 3/12/20 7:56 PM, Rajat Jain wrote: Add support for an ACPI based integrated privacy screen that is available on some systems. Signed-off-by: Rajat Jain So as discussed a while ago I'm working on adding support for the privacy-screen on Lenovo Thinkpads, introducing a small new

[PATCH] pidfd: fix memory leak in pidfd_getfd()

2020-07-06 Thread Vamshi K Sthambamkadi
kmemleak backtrace: comm "pidfd_getfd_tes", pid 1406, jiffies 4294936898 (age 8.644s) hex dump (first 32 bytes): 00 00 00 00 00 00 00 00 90 da d8 f6 80 d5 6f f2 ..o. b8 fb 9b ea c0 91 99 d1 00 00 00 00 00 00 00 00 backtrace: [<8da987ad>]

Re: [qemu] boot failed: Unable to handle kernel NULL pointer dereference at virtual address 0000000000000000

2020-07-06 Thread Arnd Bergmann
On Mon, Jul 6, 2020 at 1:03 PM Naresh Kamboju wrote: > > While booting qemu_arm64 and qemu_arm with Linux version > 5.8.0-rc3-next-20200706 > the kernel panic noticed due to kernel NULL pointer dereference. > > metadata: > git branch: master > git repo: > htt

Re: [PATCH 1/3] thermal/cpu-cooling, sched/core: Cleanup thermal pressure definition

2020-07-06 Thread Vincent Guittot
On Sun, 5 Jul 2020 at 16:19, Valentin Schneider wrote: > > > Sorry for getting back to this only now; > > On 22/06/20 09:37, Vincent Guittot wrote: > > On Sun, 21 Jun 2020 at 00:28, Valentin Schneider > > wrote: > >> On 20/06/20 18:49, Ionela Voinescu wrote: > >> > On Thursday 18 Jun 2020 at

Re: [PATCH v4 01/15] vfio/type1: Refactor vfio_iommu_type1_ioctl()

2020-07-06 Thread Auger Eric
Hi Yi, On 7/6/20 2:27 PM, Liu, Yi L wrote: > Hi Eric, > >> From: Auger Eric >> Sent: Monday, July 6, 2020 5:34 PM >> >> Hi Yi, >> >> On 7/4/20 1:26 PM, Liu Yi L wrote: >>> This patch refactors the vfio_iommu_type1_ioctl() to use switch >>> instead of if-else, and each cmd got a helper function.

Re: [PATCH 02/17] Documentation/driver-api: firmware/built-in-fw: drop doubled word

2020-07-06 Thread Luis Chamberlain
On Fri, Jul 03, 2020 at 08:44:47PM -0700, Randy Dunlap wrote: > Drop the doubled word "for". > > Signed-off-by: Randy Dunlap > Cc: Jonathan Corbet > Cc: linux-...@vger.kernel.org > Cc: Luis Chamberlain > Cc: Greg Kroah-Hartman For all the firmware patches you sent: Acked-by: Luis

Re: [RFC 1/3] perf jevents: Add support for parsing perchip/percore events

2020-07-06 Thread Jiri Olsa
On Fri, Jul 03, 2020 at 11:50:28AM +0530, kajoljain wrote: SNIP > ] > diff --git a/tools/perf/pmu-events/jevents.c b/tools/perf/pmu-events/jevents.c > index fa86c5f997cc..dd2b14cc147c 100644 > --- a/tools/perf/pmu-events/jevents.c > +++ b/tools/perf/pmu-events/jevents.c > @@ -53,6 +53,23 @@ >

Re: [PATCH] pidfd: fix memory leak in pidfd_getfd()

2020-07-06 Thread Christian Brauner
On Mon, Jul 06, 2020 at 06:22:55PM +0530, Vamshi K Sthambamkadi wrote: > kmemleak backtrace: > > comm "pidfd_getfd_tes", pid 1406, jiffies 4294936898 (age 8.644s) > hex dump (first 32 bytes): > 00 00 00 00 00 00 00 00 90 da d8 f6 80 d5 6f f2 ..o. > b8 fb 9b ea c0 91 99 d1

Re: [PATCH] usb: core: fix quirks_param_set() writing to a const pointer

2020-07-06 Thread Kars Mulder
On Monday, July 06, 2020 12:34 CEST, Greg Kroah-Hartman wrote: > That's a lot of stack space, is it really needed? Can we just use a > static variable instead, or dynamically allocate this? It is very possible to statically or dynamically allocate this. Statically reserving an additional 128

Re: [Ksummit-discuss] [PATCH] CodingStyle: Inclusive Terminology

2020-07-06 Thread Joe Perches
On Mon, 2020-07-06 at 08:51 -0400, Matthew Wilcox wrote: [] > In terms of number of lines of code using the word, it's only seventh > in drivers/: > > $ for i in drivers/*; do c=$(find $i -type f |xargs grep slave |wc > -l); echo "$c $i"; done |sort -rn |head > 5218 drivers/net > 1341 drivers/dma

RE: [PATCH v4 01/15] vfio/type1: Refactor vfio_iommu_type1_ioctl()

2020-07-06 Thread Liu, Yi L
Hi Eric, > From: Auger Eric > Sent: Monday, July 6, 2020 8:56 PM > > Hi Yi, > > On 7/6/20 2:27 PM, Liu, Yi L wrote: > > Hi Eric, > > > >> From: Auger Eric > >> Sent: Monday, July 6, 2020 5:34 PM > >> > >> Hi Yi, > >> > >> On 7/4/20 1:26 PM, Liu Yi L wrote: > >>> This patch refactors the

Re: [PATCH v4 02/15] iommu: Report domain nesting info

2020-07-06 Thread Auger Eric
On 7/6/20 2:20 PM, Liu, Yi L wrote: > Hi Eric, > >> From: Auger Eric >> Sent: Monday, July 6, 2020 5:34 PM >> >> On 7/4/20 1:26 PM, Liu Yi L wrote: >>> IOMMUs that support nesting translation needs report the capability info >> need to report >>> to userspace, e.g. the format of first

Re: [PATCH] HID: logitech-hidpp: avoid repeated "multiplier = " log messages

2020-07-06 Thread Filipe Laíns
On Mon, 2020-07-06 at 14:41 +0200, Maciej S. Szmigiero wrote: > On 06.07.2020 14:38, Filipe Laíns wrote: > > On Sun, 2020-07-05 at 19:34 +0200, Maciej S. Szmigiero wrote: > > > These messages appear each time the mouse wakes from sleep, in my > > > case > > > (Logitech M705), every minute or so. >

Re: [PATCH 1/3] arm64/numa: set numa_off to false when numa node is fake

2020-07-06 Thread Jonathan Cameron
On Mon, 6 Jul 2020 12:47:51 + Justin He wrote: > Hi Jonathan, thanks for the comments. > > > -Original Message- > > From: Jonathan Cameron > > Sent: Monday, July 6, 2020 6:46 PM > > To: Justin He > > Cc: Catalin Marinas ; Will Deacon > > ; Andrew Morton ; Mike > > Rapoport ;

Re: [Ksummit-discuss] [PATCH] CodingStyle: Inclusive Terminology

2020-07-06 Thread Matthew Wilcox
On Mon, Jul 6, 2020 at 8:59 AM Joe Perches wrote: > On Mon, 2020-07-06 at 08:51 -0400, Matthew Wilcox wrote: > > In terms of number of lines of code using the word, it's only seventh > > in drivers/: > > > > $ for i in drivers/*; do c=$(find $i -type f |xargs grep slave |wc > > -l); echo "$c $i";

Re: file.c:undefined reference to `.dump_emit'

2020-07-06 Thread Arnd Bergmann
spufs core dumping > date: 9 weeks ago > config: powerpc64-randconfig-c003-20200706 (attached as .config) > compiler: powerpc64-linux-gcc (GCC) 9.3.0 > > If you fix the issue, kindly add following tag as appropriate > Reported-by: kernel test robot > > All errors (new ones

Re: [PATCH v9 02/15] tools/libperf: add properties to struct pollfd *entries objects

2020-07-06 Thread Alexey Budankov
On 06.07.2020 15:24, Jiri Olsa wrote: > On Fri, Jul 03, 2020 at 10:41:45AM +0300, Alexey Budankov wrote: >> >> Store boolean properties per struct pollfd *entries object in a >> bitmap of int size. Implement fdarray_prop__nonfilterable property >> to skip object from counting by

Re: [PATCH] usb: core: fix quirks_param_set() writing to a const pointer

2020-07-06 Thread Greg Kroah-Hartman
On Mon, Jul 06, 2020 at 02:57:59PM +0200, Kars Mulder wrote: > On Monday, July 06, 2020 12:34 CEST, Greg Kroah-Hartman wrote: > > That's a lot of stack space, is it really needed? Can we just use a > > static variable instead, or dynamically allocate this? > > It is very possible to statically

Re: [PATCH v5 4/7] pidfd: Replace open-coded partial fd_install_received()

2020-07-06 Thread Christian Brauner
On Wed, Jun 17, 2020 at 03:03:24PM -0700, Kees Cook wrote: > The sock counting (sock_update_netprioidx() and sock_update_classid()) was > missing from pidfd's implementation of received fd installation. Replace > the open-coded version with a call to the new fd_install_received() > helper. > >

Re: [PATCH v9 09/15] perf stat: factor out event handling loop into dispatch_events()

2020-07-06 Thread Alexey Budankov
On 06.07.2020 15:27, Jiri Olsa wrote: > On Fri, Jul 03, 2020 at 10:46:15AM +0300, Alexey Budankov wrote: >> >> Consolidate event dispatching loops for fork, attach and system >> wide monitoring use cases into common dispatch_events() function. >> >> Signed-off-by: Alexey Budankov >> --- >>

[PATCH][next] scsi: lpfc: fix less than zero comparison on unsigned int computation

2020-07-06 Thread Colin King
From: Colin Ian King The expressions start_idx - dbg_cnt is evaluated using unsigned int arthithmetic (since these variables are unsigned ints) and hence can never be less than zero, so the less than comparison is never true. Re-write the expression to check for start_idx being less than

Re: [PATCH v4 07/18] nitro_enclaves: Init misc device providing the ioctl interface

2020-07-06 Thread Paraschiv, Andra-Irina
On 06/07/2020 11:01, Alexander Graf wrote: On 06.07.20 09:49, Paraschiv, Andra-Irina wrote: On 06/07/2020 10:13, Alexander Graf wrote: On 22.06.20 22:03, Andra Paraschiv wrote: The Nitro Enclaves driver provides an ioctl interface to the user space for enclave lifetime management

Re: [PATCH v9 11/15] perf stat: implement control commands handling

2020-07-06 Thread Alexey Budankov
On 06.07.2020 15:37, Jiri Olsa wrote: > On Fri, Jul 03, 2020 at 10:47:22AM +0300, Alexey Budankov wrote: > > SNIP > >> >> while (1) { >> if (forks) >> @@ -574,11 +610,22 @@ static int dispatch_events(bool forks, int timeout, >> int interval, int *times, st >>

RE: [PATCH v4 04/15] vfio/type1: Report iommu nesting info to userspace

2020-07-06 Thread Liu, Yi L
Hi Eric, > From: Auger Eric > Sent: Monday, July 6, 2020 6:37 PM > > Yi, > > On 7/4/20 1:26 PM, Liu Yi L wrote: > > This patch exports iommu nesting capability info to user space through > > VFIO. User space is expected to check this info for supported uAPIs (e.g. > > PASID alloc/free, bind

Re: [PATCH v4 08/18] nitro_enclaves: Add logic for enclave vm creation

2020-07-06 Thread Paraschiv, Andra-Irina
On 06/07/2020 10:53, Alexander Graf wrote: On 22.06.20 22:03, Andra Paraschiv wrote: Add ioctl command logic for enclave VM creation. It triggers a slot allocation. The enclave resources will be associated with this slot and it will be used as an identifier for triggering enclave run.

Re: [PATCH v3 13/13] bus/fsl-mc: Add a new version for dprc_get_obj_region command

2020-07-06 Thread Laurentiu Tudor
On 7/6/2020 3:42 PM, Diana Craciun wrote: > From: Diana Craciun > > The region size reported by the firmware for mc and software > portals was less than allocated by the hardware. This may be > problematic when mmapping the region in user space because the > region size is less than page

RE: [PATCH v4 02/15] iommu: Report domain nesting info

2020-07-06 Thread Liu, Yi L
> From: Auger Eric > Sent: Monday, July 6, 2020 9:01 PM > > On 7/6/20 2:20 PM, Liu, Yi L wrote: > > Hi Eric, > > > >> From: Auger Eric > >> Sent: Monday, July 6, 2020 5:34 PM > >> > >> On 7/4/20 1:26 PM, Liu Yi L wrote: > >>> IOMMUs that support nesting translation needs report the capability >

Re: [PATCH v4 4/4] thermal: core: Add notifications call in the framework

2020-07-06 Thread Marek Szyprowski
gt; Reviewed-by: Amit Kucheria > Signed-off-by: Daniel Lezcano This patch landed in today's linux-next 20200706 as commit 5df786e46560 ("thermal: core: Add notifications call in the framework"). Sadly it breaks booting various Samsung Exynos based boards. Here is an example log from

RE: [PATCH] PCI: endpoint: Fix NULL pointer dereference for ->get_features()

2020-07-06 Thread Sriram Dash
> From: Lorenzo Pieralisi > Sent: 06 July 2020 16:47 > Subject: Re: [PATCH] PCI: endpoint: Fix NULL pointer dereference for - > >get_features() > > On Thu, Apr 02, 2020 at 08:01:59PM +0530, Sriram Dash wrote: > > [...] > > > > So the patch itself is correct though the commit log has to be > >

Re: [PATCH v2 09/11] ima: Move validation of the keyrings conditional into ima_validate_rule()

2020-07-06 Thread Tyler Hicks
On 2020-07-03 10:15:32, Mimi Zohar wrote: > On Thu, 2020-07-02 at 17:16 -0500, Tyler Hicks wrote: > > On 2020-06-30 19:07:29, Mimi Zohar wrote: > > > On Fri, 2020-06-26 at 17:38 -0500, Tyler Hicks wrote: > > > > Use ima_validate_rule() to ensure that the combination of a hook > > > > function and

Re: file.c:undefined reference to `.dump_emit'

2020-07-06 Thread Arnd Bergmann
On Mon, Jul 6, 2020 at 3:04 PM Arnd Bergmann wrote: > > On Mon, Jul 6, 2020 at 12:17 PM kernel test robot wrote: > > > In the interest of keeping things simple, I'd suggest doing this one instead: > > --- a/arch/powerpc/platforms/cell/Kconfig > +++ b/arch/powerpc/platforms/cell/Kconfig > @@

[PATCH][next] staging: wfx: fix uninitialized variable bytes_done

2020-07-06 Thread Colin King
From: Colin Ian King The variable bytes_done is not initialized and hence the first FIFO size check on bytes_done may be breaking prematurely from the loop if bytes_done contains a large bogus uninitialized value. Fix this by initializing bytes_done to zero. Addresses-Coverity: ("Uninitialized

Re: [PATCH] firmware: arm_scmi: fix notifications macros argument reuse

2020-07-06 Thread Cristian Marussi
Hi On Sat, Jul 04, 2020 at 07:01:21AM +0800, kernel test robot wrote: > Hi Cristian, > > Thank you for the patch! Perhaps something to improve: > > [auto build test WARNING on next-20200630] > [cannot apply to linux/master soc/for-next linus/master v5.8-rc3 v5.8-rc2 > v5.8-rc1 v5.8-rc3] > [If

[PATCH v3] scsi: ufs: Cleanup completed request without interrupt notification

2020-07-06 Thread Stanley Chu
If somehow no interrupt notification is raised for a completed request and its doorbell bit is cleared by host, UFS driver needs to cleanup its outstanding bit in ufshcd_abort(). Otherwise, system may crash by below abnormal flow: After this request is requeued by SCSI layer with its outstanding

Re: [PATCH v4 03/15] iommu/smmu: Report empty domain nesting info

2020-07-06 Thread Auger Eric
Hi Yi, On 7/6/20 2:46 PM, Liu, Yi L wrote: > Hi Eric, > >> From: Auger Eric >> >> Hi Yi, >> >> Please add a commit message: instead of returning a boolean for >> DOMAIN_ATTR_NESTING, arm_smmu_domain_get_attr() returns a >> iommu_nesting_info handle. > > will do. thanks for the suggestion. >

[RFC PATCH v3] scsi: ufs: Quiesce all scsi devices before shutdown

2020-07-06 Thread Stanley Chu
Currently I/O request could be still submitted to UFS device while UFS is working on shutdown flow. This may lead to racing as below scenarios and finally system may crash due to unclocked register accesses. To fix this kind of issues, specifically quiesce all SCSI devices before UFS shutdown to

Re: [PATCH] CodingStyle: Inclusive Terminology

2020-07-06 Thread Tibor Raschko
Sending the wrong message === I'm pretty sure everybody agrees that being inclusive is more than just using the right words. Being truly inclusive means not caring about the origin, birth, age, sex, skin color (amongst other things) at all. This means not judging people

[PATCH] powerpc/spufs: add CONFIG_COREDUMP dependency

2020-07-06 Thread Arnd Bergmann
The kernel test robot pointed out a slightly different error message after recent commit 5456ffdee666 ("powerpc/spufs: simplify spufs core dumping") to spufs for a configuration that never worked: powerpc64-linux-ld: arch/powerpc/platforms/cell/spufs/file.o: in function

Re: [mm] 4e2c82a409: ltp.overcommit_memory01.fail

2020-07-06 Thread Feng Tang
Hi All, Please help to review this fix patch, thanks! It is against today's linux-mm tree. For easy review, I put the fix into one patch, and I could split it to 2 parts for percpu-counter and mm/util.c if it's preferred. >From 593f9dc139181a7c3bb1705aacd1f625f400e458 Mon Sep 17 00:00:00 2001

Re: [PATCH v2 00/14] Add regulator devfreq support to Panfrost

2020-07-06 Thread Alyssa Rosenzweig
Patches 1-12 are Reviewed-by: Alyssa Rosenzweig Thank you! On Sat, Jul 04, 2020 at 12:25:21PM +0200, Clément Péron wrote: > Hi, > > This serie cleans and adds regulator support to Panfrost devfreq. > This is mostly based on comment for the freshly introduced lima > devfreq. > > We

RE: [PATCH v4 03/15] iommu/smmu: Report empty domain nesting info

2020-07-06 Thread Liu, Yi L
Hi Eric, > From: Auger Eric > Sent: Monday, July 6, 2020 9:22 PM > > Hi Yi, > > On 7/6/20 2:46 PM, Liu, Yi L wrote: > > Hi Eric, > > > >> From: Auger Eric > >> > >> Hi Yi, > >> > >> Please add a commit message: instead of returning a boolean for > >> DOMAIN_ATTR_NESTING,

RE: [PATCH][v2] Drivers: hv: Change flag to write log level in panic msg to false

2020-07-06 Thread Michael Kelley
From: Wei Liu Sent: Monday, July 6, 2020 3:56 AM > > On Wed, Jul 01, 2020 at 07:33:25PM +, Sasha Levin wrote: > > Hi > > > > [This is an automated email] > > > > This commit has been processed because it contains a -stable tag. > > The stable tag indicates that it's relevant for the

Re: [PATCH][next] staging: wfx: fix uninitialized variable bytes_done

2020-07-06 Thread Jérôme Pouiller
On Monday 6 July 2020 15:20:17 CEST Colin King wrote: > > From: Colin Ian King > > The variable bytes_done is not initialized and hence the first > FIFO size check on bytes_done may be breaking prematurely from > the loop if bytes_done contains a large bogus uninitialized value. > Fix this by

Re: [Ksummit-discuss] [PATCH] CodingStyle: Inclusive Terminology

2020-07-06 Thread Joe Perches
On Mon, 2020-07-06 at 09:04 -0400, Matthew Wilcox wrote: > On Mon, Jul 6, 2020 at 8:59 AM Joe Perches wrote: > > On Mon, 2020-07-06 at 08:51 -0400, Matthew Wilcox wrote: > > > In terms of number of lines of code using the word, it's only seventh > > > in drivers/: > > > > > > $ for i in

Re: [PATCH V3 13/23] perf/x86/intel/lbr: Factor out intel_pmu_store_lbr

2020-07-06 Thread Liang, Kan
On 7/6/2020 6:25 AM, Peter Zijlstra wrote: On Fri, Jul 03, 2020 at 04:59:49PM -0400, Liang, Kan wrote: On 7/3/2020 3:50 PM, Peter Zijlstra wrote: If I'm not mistaken, this correctly deals with LBR_FORMAT_INFO, so can't we also use the intel_pmu_arch_lbr_read() function for that case?

Re: [PATCH] riscv: use 16KB kernel stack on 64-bit

2020-07-06 Thread Anup Patel
On Mon, Jul 6, 2020 at 6:02 PM Andreas Schwab wrote: > > With the current 8KB stack size there are frequent overflows in a 64-bit > configuration. > > Signed-off-by: Andreas Schwab > --- > arch/riscv/include/asm/thread_info.h | 4 > 1 file changed, 4 insertions(+) > > diff --git

[PATCH 00/32] Fix the final bunch of W=1 issues in USB

2020-07-06 Thread Lee Jones
This set is part of a larger effort attempting to clean-up W=1 kernel builds, which are currently overwhelmingly riddled with niggly little warnings. After these patches are applied, the build system no longer complains about any W=0 nor W=1 level warnings in drivers/usb. Hurrah! Lee Jones

[PATCH 01/32] usb: misc: legousbtower: Demote obvious misuse of kerneldoc to standard comment blocks

2020-07-06 Thread Lee Jones
No attempt has been made to document any of the demoted functions here. Fixes the following W=1 kernel build warning(s): drivers/usb/misc/legousbtower.c:280: warning: Function parameter or member 'dev' not described in 'lego_usb_tower_debug_data' drivers/usb/misc/legousbtower.c:280: warning:

[PATCH 05/32] usb: gadget: function: u_ether: Downgrade kerneldoc headers which to not make the mark

2020-07-06 Thread Lee Jones
Kerneldoc expects all function arguments to be documented. If any are missed it will complain. Downgrade one header with 3 missing argument descriptions and one which makes no attempt. Fixes the following W=1 kernel build warning(s): drivers/usb/gadget/function/u_ether.c:750: warning:

[PATCH 03/32] usb: gadget: legacy: printer: Remove unused variable 'driver_desc'

2020-07-06 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/usb/gadget/legacy/printer.c:24:19: warning: ‘driver_desc’ defined but not used [-Wunused-const-variable=] Cc: Felipe Balbi Signed-off-by: Lee Jones --- drivers/usb/gadget/legacy/printer.c | 1 - 1 file changed, 1 deletion(-) diff

[PATCH 09/32] usb: gadget: udc: atmel_usba_udc: Remove set but unused variable 'pp'

2020-07-06 Thread Lee Jones
Commit e78355b577c4b ("usb: gadget: udc: atmel: Don't use DT to configure end point") pulled out all functionality dealing with 'pp'. Fixes the following W=1 kernel build warning(s): drivers/usb/gadget/udc/atmel_usba_udc.c: In function ‘atmel_udc_of_init’:

[PATCH 31/32] usb: host: fhci-sched: Remove unused variable 'td'

2020-07-06 Thread Lee Jones
'td' has been completely unused since the driver's inception in 2009. Fixes the following W=1 kernel build warning(s): drivers/usb/host/fhci-sched.c: In function ‘fhci_queue_urb’: drivers/usb/host/fhci-sched.c:704:13: warning: variable ‘td’ set but not used [-Wunused-but-set-variable] 704 |

[PATCH 10/32] usb: gadget: legacy: nokia: Remove unused static variable 'product_nokia'

2020-07-06 Thread Lee Jones
Looks as though it's never been used. Driver was introduced in 2010. Fixes the following W=1 kernel build warning(s): drivers/usb/gadget/legacy/nokia.c:65:19: warning: ‘product_nokia’ defined but not used [-Wunused-const-variable=] 65 | static const char product_nokia[] = NOKIA_LONG_NAME; |

[PATCH 23/32] usb: gadget: udc: max3420_udc: Remove set, but never checked variable 'addr'

2020-07-06 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/usb/gadget/udc/max3420_udc.c: In function ‘max3420_handle_setup’: drivers/usb/gadget/udc/max3420_udc.c:626:5: warning: variable ‘addr’ set but not used [-Wunused-but-set-variable] 626 | u8 addr; | ^~~~ Cc: Felipe Balbi Cc: Jassi Brar

[PATCH 19/32] usb: gadget: function: u_uac1_legacy: Demote obvious misuse of kerneldoc to standard comment blocks

2020-07-06 Thread Lee Jones
No attempt has been made to document any of the demoted functions here. Fixes the following W=1 kernel build warning(s): drivers/usb/gadget/function/u_uac1_legacy.c:30: warning: Function parameter or member 'i' not described in 'snd_interval_refine_set'

Re: [RFC PATCH] vfio: type1: fix kthread use case

2020-07-06 Thread Markus Elfring
>> Can it be helpful to convert initialisations for these variables >> into later assignments? > > Perhaps. Then it looks like the below. … > +++ b/drivers/vfio/vfio_iommu_type1.c > @@ -2798,9 +2798,12 @@ static int vfio_iommu_type1_dma_rw_chunk … > - bool kthread = current->mm == NULL; > +

[PATCH 26/32] usb: early: xhci-dbc: Supply missing 'xhci-dbgp.h' headerfile

2020-07-06 Thread Lee Jones
If the header file containing a function's prototype isn't included by the sourcefile containing the associated function, the build system complains of missing prototypes. Fixes the following W=1 kernel build warning(s): drivers/usb/early/ehci-dbgp.c: In function ‘early_dbgp_write’:

[PATCH 22/32] usb: gadget: udc: mv_u3d_core: Remove unused static const 'driver_desc'

2020-07-06 Thread Lee Jones
Looks like it's never been used. Driver was mainlined in 2014. Fixes the following W=1 kernel build warning(s): drivers/usb/gadget/udc/mv_u3d_core.c:35:19: warning: ‘driver_desc’ defined but not used [-Wunused-const-variable=] 35 | static const char driver_desc[] = DRIVER_DESC; |

[PATCH 28/32] usb: host: ehci-platform: Do not define 'struct acpi_device_id' when !CONFIG_ACPI

2020-07-06 Thread Lee Jones
Since ACPI_PTR() is used to NULLify the value when !CONFIG_ACPI, struct ehci_acpi_match becomes defined by unused. Fixes the following W=1 kernel build warning(s): drivers/usb/host/ehci-platform.c:478:36: warning: ‘ehci_acpi_match’ defined but not used [-Wunused-const-variable=] 478 | static

[PATCH 08/32] usb: typec: tcpm: tcpm: Remove dangling unused 'struct tcpm_altmode_ops'

2020-07-06 Thread Lee Jones
Looks as though a079973f462a3 ("usb: typec: tcpm: Remove tcpc_config configuration mechanism") pulled out the only use of 'tcpm_altmode_ops' last year. No need to keep it around. Fixes the following W=1 kernel build warning(s): drivers/usb/typec/tcpm/tcpm.c:1551:39: warning: ‘tcpm_altmode_ops’

[PATCH 32/32] usb: host: xhci-plat: Do not define 'struct acpi_device_id' when !CONFIG_ACPI

2020-07-06 Thread Lee Jones
Since ACPI_PTR() is used to NULLify the value when !CONFIG_ACPI, struct usb_xhci_acpi_match becomes defined by unused. Fixes the following W=1 kernel build warning(s): drivers/usb/host/xhci-plat.c:457:36: warning: ‘usb_xhci_acpi_match’ defined but not used [-Wunused-const-variable=] 457 |

[PATCH 27/32] usb: early: xhci-dbc: File headers are not good candidates for kerneldoc

2020-07-06 Thread Lee Jones
Demote xhci-dbc's file header to a standard comment block. Fixes the following W=1 kernel build warning(s): drivers/usb/early/xhci-dbc.c:10: warning: Function parameter or member 'fmt' not described in 'pr_fmt' Cc: Lu Baolu Signed-off-by: Lee Jones --- drivers/usb/early/xhci-dbc.c | 2 +-

[PATCH 30/32] usb: host: fhci-tds: Remove unused variables 'buf' and 'extra_data'

2020-07-06 Thread Lee Jones
Neither have been used since the driver's inception in 2009. Fixes the following W=1 kernel build warning(s): drivers/usb/host/fhci-tds.c: In function ‘fhci_flush_bds’: drivers/usb/host/fhci-tds.c:472:6: warning: variable ‘buf’ set but not used [-Wunused-but-set-variable] 472 | u32 buf; |

[PATCH 29/32] usb: dwc3: dwc3-qcom: Do not define 'struct acpi_device_id' when !CONFIG_ACPI

2020-07-06 Thread Lee Jones
Since ACPI_PTR() is used to NULLify the value when !CONFIG_ACPI, struct dwc3_qcom_acpi_match becomes defined by unused. Also need to place the platform data obtained via the matching process inside the #ifdef, else that becomes unused too. Fixes the following W=1 kernel build warning(s):

Re: [mm] 4e2c82a409: ltp.overcommit_memory01.fail

2020-07-06 Thread Andi Kleen
> ret = proc_dointvec_minmax(table, write, buffer, lenp, ppos); > - if (ret == 0 && write) > + if (ret == 0 && write) { > + if (sysctl_overcommit_memory == OVERCOMMIT_NEVER) > + schedule_on_each_cpu(sync_overcommit_as); The schedule_on_each_cpu is not

[PATCH 21/32] usb: host: fotg210-hcd: Demote obvious misuse of kerneldoc to standard comment blocks

2020-07-06 Thread Lee Jones
Only 2 functions attempted to use kerneldoc in this massive file. Fixes the following W=1 kernel build warning(s): drivers/usb/host/fotg210-hcd.c: In function ‘fotg210_run’: drivers/usb/host/fotg210-hcd.c:5013:6: warning: variable ‘hcc_params’ set but not used [-Wunused-but-set-variable]

[PATCH 25/32] usb: early: ehci-dbgp: Remove set but never checked variable 'ret'

2020-07-06 Thread Lee Jones
'ret' hasn't been checked since the driver's inception in 2009. Fixes the following W=1 kernel build warning(s): drivers/usb/early/ehci-dbgp.c: In function ‘early_dbgp_write’: drivers/usb/early/ehci-dbgp.c:915:13: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] 915 |

[PATCH 20/32] usb: host: bcma-hcd: Demote obvious misuse of kerneldoc to standard comment blocks

2020-07-06 Thread Lee Jones
No attempt has been made to document either of the demoted functions here. Fixes the following W=1 kernel build warning(s): drivers/usb/host/bcma-hcd.c:180: warning: Function parameter or member 'usb_dev' not described in 'bcma_hcd_usb20_old_arm_init' drivers/usb/host/bcma-hcd.c:268: warning:

[PATCH 12/32] usb: gadget: udc: lpc32xx_udc: Staticify 2 local functions

2020-07-06 Thread Lee Jones
These are not used outside of this sourcefile, so make them static. Fixes the following W=1 kernel build warning(s): drivers/usb/gadget/udc/lpc32xx_udc.c:1929:6: warning: no previous prototype for ‘udc_send_in_zlp’ [-Wmissing-prototypes] 1929 | void udc_send_in_zlp(struct lpc32xx_udc *udc,

[PATCH 14/32] usb: gadget: udc: mv_udc_core: Remove unused static const variable 'driver_desc'

2020-07-06 Thread Lee Jones
Looks as though it's never been used. Driver was introduced in 2014. Fixes the following W=1 kernel build warning(s): drivers/usb/gadget/udc/mv_udc_core.c:56:19: warning: ‘driver_desc’ defined but not used [-Wunused-const-variable=] 56 | static const char driver_desc[] = DRIVER_DESC; |

[PATCH 16/32] usb: host: imx21-hcd: Demote function header which is clearly not kerneldoc

2020-07-06 Thread Lee Jones
No attempt has been made to document the demoted function here. Fixes the following W=1 kernel build warning(s): drivers/usb/host/imx21-hcd.c:233: warning: Function parameter or member 'imx21' not described in 'copy_to_dmem' drivers/usb/host/imx21-hcd.c:233: warning: Function parameter or

[PATCH 17/32] usb: host: ehci-fsl: Fix incorrectly named function argument

2020-07-06 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/usb/host/ehci-fsl.c:694: warning: Function parameter or member 'pdev' not described in 'fsl_ehci_drv_remove' drivers/usb/host/ehci-fsl.c:694: warning: Excess function parameter 'dev' description in 'fsl_ehci_drv_remove' Cc: Alan Stern

[PATCH 24/32] usb: typec: ucsi: ucsi: Staticify and stop export of ucsi_init()

2020-07-06 Thread Lee Jones
It isn't called from anywhere outside of ucsi.c. Fixes the following W=1 kernel build warning(s): drivers/usb/typec/ucsi/ucsi.c:1005:5: warning: no previous prototype for ‘ucsi_init’ [-Wmissing-prototypes] 1005 | int ucsi_init(struct ucsi *ucsi) | ^ Cc: Heikki Krogerus

[PATCH 11/32] usb: gadget: function: f_fs: Demote function header which is clearly not kerneldoc

2020-07-06 Thread Lee Jones
No attempt has been made to document the demoted function here. Fixes the following W=1 kernel build warning(s): drivers/usb/gadget/function/f_fs.c:2361: warning: Function parameter or member 'type' not described in '__ffs_data_do_os_desc' drivers/usb/gadget/function/f_fs.c:2361: warning:

[PATCH 13/32] usb: host: r8a66597-hcd: Remove set, then over-written, but never used variable 'tmp'

2020-07-06 Thread Lee Jones
Looks like it's been this way since the driver's inception in 2007. Fixes the following W=1 kernel build warning(s): drivers/usb/host/r8a66597-hcd.c: In function ‘clear_all_buffer’: drivers/usb/host/r8a66597-hcd.c:478:6: warning: variable ‘tmp’ set but not used [-Wunused-but-set-variable]

[PATCH 18/32] usb: host: fotg210-hcd: Remove unused variable 'hcc_params'

2020-07-06 Thread Lee Jones
The result is actually read into fotg210->caps->hcc_params. No need to popuate an unused varible with the unchecked return value from fotg210_readl(). Fixes the following W=1 kernel build warning(s): drivers/usb/host/fotg210-hcd.c: In function ‘fotg210_run’:

[PATCH 15/32] usb: gadget: udc: pch_udc: Fix a plethora of function documentation related issues

2020-07-06 Thread Lee Jones
Ranging from missing descriptions and formatting mishaps to over-documenting of missing arguments, likely due to bitrot. Fixes the following W=1 kernel build warning(s): drivers/usb/gadget/udc/pch_udc.c:239: warning: Function parameter or member 'request' not described in

[PATCH 04/32] usb: gadget: udc: amd5536udc_pci: Remove unused variable 'mod_desc'

2020-07-06 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/usb/gadget/udc/amd5536udc_pci.c:52:19: warning: ‘mod_desc’ defined but not used [-Wunused-const-variable=] Cc: Felipe Balbi Signed-off-by: Lee Jones --- drivers/usb/gadget/udc/amd5536udc_pci.c | 1 - 1 file changed, 1 deletion(-)

[PATCH 06/32] usb: gadget: udc: pxa27x_udc: Fix a bunch of kerneldoc issues

2020-07-06 Thread Lee Jones
Mostly bitrotted argument descriptions/names. Also the removal of a blank line in the middle of a kerneldoc header, which is not allowed. Fixes the following W=1 kernel build warning(s): drivers/usb/gadget/udc/pxa27x_udc.c:398: warning: Function parameter or member 'ep' not described in

Re: [PATCH v4 10/18] nitro_enclaves: Add logic for enclave image load info

2020-07-06 Thread Paraschiv, Andra-Irina
On 06/07/2020 13:16, Alexander Graf wrote: On 22.06.20 22:03, Andra Paraschiv wrote: Before setting the memory regions for the enclave, the enclave image needs to be placed in memory. After the memory regions are set, this memory cannot be used anymore by the VM, being carved out. Add

[PATCH 02/32] usb: chipidea: ci_hdrc_pci: Fix improper use of kerneldoc format

2020-07-06 Thread Lee Jones
No attempt has been made to document any of the structure's properties here. Fixes the following W=1 kernel build warning(s): drivers/usb/chipidea/ci_hdrc_pci.c:132: warning: cannot understand function prototype: 'const struct pci_device_id ci_hdrc_pci_id_table[] = ' Cc: Peter Chen Cc: David

[PATCH 07/32] usb: misc: legousbtower: Demote function header which is clearly not kerneldoc

2020-07-06 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/usb/misc/legousbtower.c:280: warning: Function parameter or member 'dev' not described in 'lego_usb_tower_debug_data' drivers/usb/misc/legousbtower.c:280: warning: Function parameter or member 'function' not described in

Re: [PATCH v3 1/1] s390: virtio: let arch accept devices without IOMMU feature

2020-07-06 Thread Pierre Morel
On 2020-07-02 15:03, Pierre Morel wrote: On 2020-06-29 18:05, Cornelia Huck wrote: On Mon, 29 Jun 2020 11:57:14 -0400 "Michael S. Tsirkin" wrote: On Wed, Jun 17, 2020 at 12:43:57PM +0200, Pierre Morel wrote: An architecture protecting the guest memory against unauthorized host access

[PATCH -next] smp: Make symbol 'csd_bug_count' static

2020-07-06 Thread Wei Yongjun
The sparse tool complains as follows kernel/smp.c:107:10: warning: symbol 'csd_bug_count' was not declared. Should it be static? This variable is not used outside of smp.c, s this commit marks it static. Reported-by: Hulk Robot Signed-off-by: Wei Yongjun --- kernel/smp.c | 2 +- 1 file

[PATCH -next] smp: Fix unused-but-set-variable warning

2020-07-06 Thread Wei Yongjun
Gcc report build warning as follows: kernel/smp.c:126:15: warning: variable 'csd_type' set but not used [-Wunused-but-set-variable] 126 | unsigned int csd_type; | ^~~~ 'csd_type' is only used when CONFIG_64BIT defined, so move them under '#ifdef'. Reported-by: Hulk

RE: [PATCH 2/3] mm/memory_hotplug: harden try_offline_node against bogus nid

2020-07-06 Thread Justin He
Hi David > -Original Message- > From: David Hildenbrand > Sent: Monday, July 6, 2020 3:58 PM > To: Justin He ; Catalin Marinas > ; Will Deacon > Cc: Andrew Morton ; Mike Rapoport > ; Baoquan He ; Chuhong Yuan > ; linux-arm-ker...@lists.infradead.org; linux- > ker...@vger.kernel.org;

Re: [PATCH v4 04/15] vfio/type1: Report iommu nesting info to userspace

2020-07-06 Thread Auger Eric
Hi Yi, On 7/6/20 3:10 PM, Liu, Yi L wrote: > Hi Eric, > >> From: Auger Eric >> Sent: Monday, July 6, 2020 6:37 PM >> >> Yi, >> >> On 7/4/20 1:26 PM, Liu Yi L wrote: >>> This patch exports iommu nesting capability info to user space through >>> VFIO. User space is expected to check this info for

回复: [kthread] a90477f0c9: WARNING:at_kernel/kthread.c:#kthread_queue_work

2020-07-06 Thread Zhang, Qiang
发件人: Zhang, Qiang 发送时间: 2020年7月6日 18:17 收件人: Petr Mladek 抄送: Andrew Morton; linux-kernel@vger.kernel.org 主题: 回复: [kthread] a90477f0c9: WARNING:at_kernel/kthread.c:#kthread_queue_work Hi , Petr Mladek There some question for "Work could not be queued

<    1   2   3   4   5   6   7   8   9   10   >