[PATCH v17 05/21] mm/thp: move lru_add_page_tail func to huge_memory.c

2020-07-25 Thread Alex Shi
The func is only used in huge_memory.c, defining it in other file with a CONFIG_TRANSPARENT_HUGEPAGE macro restrict just looks weird. Let's move it THP. And make it static as Hugh Dickin suggested. Signed-off-by: Alex Shi Reviewed-by: Kirill A. Shutemov Cc: Andrew Morton Cc: Johannes Weiner

[PATCH v17 17/21] mm/lru: replace pgdat lru_lock with lruvec lock

2020-07-25 Thread Alex Shi
This patch moves per node lru_lock into lruvec, thus bring a lru_lock for each of memcg per node. So on a large machine, each of memcg don't have to suffer from per node pgdat->lru_lock competition. They could go fast with their self lru_lock. After move memcg charge before lru inserting, page

[PATCH v17 12/21] mm/lru: move lock into lru_note_cost

2020-07-25 Thread Alex Shi
This patch move lru_lock into lru_note_cost. It's a bit ugly and may cost more locking, but it's necessary for later per pgdat lru_lock to per memcg lru_lock change. Signed-off-by: Alex Shi Cc: Johannes Weiner Cc: Andrew Morton Cc: linux...@kvack.org Cc: linux-kernel@vger.kernel.org ---

[PATCH v17 02/21] mm/page_idle: no unlikely double check for idle page counting

2020-07-25 Thread Alex Shi
As func comments mentioned, few isolated page missing be tolerated. So why not do further to drop the unlikely double check. That won't cause more idle pages, but reduce a lock contention. This is also a preparation for later new page isolation feature. Signed-off-by: Alex Shi Cc: Andrew Morton

Re: checkpatch: support deprecated terms checking

2020-07-25 Thread Michał Mirosław
Hello, I see that this patch went into next and is already inciting people to do wrong things [1]. Can you please fix it to require '--subjective' switch or otherwise mark it clearly as suggestion-only? The coding-style as in Linus' master says about *NEW* uses of the words listed (those

Re: [PATCH V2 1/1] irqchip: imx-intmux: implement intmux PM

2020-07-25 Thread Marc Zyngier
On Mon, 20 Jul 2020 11:42:37 +0100, Joakim Zhang wrote: > > When system suspended, we could explicitly disable clock to save power. > And we need save registers' state since it could be lost after power > off. > > Implement PM which will: > 1) Without CONFIG_PM, clock is always on after probe

Re: [PATCH v2] media: cedrus: Add support for VP8 decoding

2020-07-25 Thread Ezequiel Garcia
Hi Jernej, As you know, I'm not familiar with this hardware, but I've tried to take a detailed look anyway. The driver looks mostly good to me, I just have some minor comments. More importantly, seems the current uAPI control is supporting this platform nicely, which gives us some confidence to

[PATCH V2] Subject: [PATCH] staging: rtl8723bs: core: Using comparison to true is error prone

2020-07-25 Thread John Oldman
clear below issues reported by checkpatch.pl: CHECK: Using comparison to true is error prone Signed-off-by: John Oldman --- v1: Initial attempt. v2: Removed unneccessary parentheses around 'pregistrypriv->ht_enable' Also considered clearing 'CHECK: Logical continuations should be on the

Re: [PATCH v2 1/4] fpga: dfl: change data type of feature id to u16

2020-07-25 Thread Tom Rix
It would be good if the variable or element for the feature id had a consistent name. > @@ -197,7 +197,7 @@ int dfl_fpga_check_port_id(struct platform_device *pdev, > void *pport_id); > * @id: unique dfl private feature id. > */ > struct dfl_feature_id { > - u64 id; > + u16 id; >

[PATCH] net: ipv6: fix slab-out-of-bounds Read in __xfrm6_tunnel_spi_check

2020-07-25 Thread B K Karthik
use spi_byaddr instead of spi_byspi == BUG: KASAN: slab-out-of-bounds in __xfrm6_tunnel_spi_check+0x316/0x330 net/ipv6/xfrm6_tunnel.c:108 Read of size 8 at addr 8880a93a5e08 by task syz-executor.1/8482 CPU: 0 PID: 8482 Comm:

Re: [PATCH 03/10] media: uapi: h264: Split prediction weight parameters

2020-07-25 Thread Alexandre Courbot
On Thu, Jul 16, 2020 at 5:23 AM Ezequiel Garcia wrote: > > The prediction weight parameters are only required under > certain conditions, which depend on slice header parameters. > > The slice header syntax specifies that the prediction > weight table is present if: > > ((weighted_pred_flag &&

Re: [PATCH V2] Subject: [PATCH] staging: rtl8723bs: core: Using comparison to true is error prone

2020-07-25 Thread Greg KH
On Sat, Jul 25, 2020 at 02:28:06PM +0100, John Oldman wrote: > clear below issues reported by checkpatch.pl: > > CHECK: Using comparison to true is error prone Your subject line is very odd :( > Signed-off-by: John Oldman > --- > v1: Initial attempt. > v2: Removed unneccessary parentheses

Re: [PATCH net-next] fib: use indirect call wrappers in the most common fib_rules_ops

2020-07-25 Thread kernel test robot
Hi Brian, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Brian-Vazquez/fib-use-indirect-call-wrappers-in-the-most-common-fib_rules_ops/20200725-095008 base: https://git.kernel.org/pub/scm/linux

[PATCH] net: xfrm: xfrm_policy.c: remove some unnecessary cases in decode_session6

2020-07-25 Thread B K Karthik
remove some unnecessary cases in decode_session6 Signed-off-by: B K Karthik --- net/xfrm/xfrm_policy.c | 4 1 file changed, 4 deletions(-) diff --git a/net/xfrm/xfrm_policy.c b/net/xfrm/xfrm_policy.c index 19c5e0fa3f44..e1c988a89382 100644 --- a/net/xfrm/xfrm_policy.c +++

Re: [PATCH v2 0/5] drm: rockchip: various ports for older VOPs

2020-07-25 Thread Alex Bee
Am 22.07.20 um 23:43 schrieb Daniel Vetter: On Wed, Jul 22, 2020 at 8:13 PM Alex Bee wrote: Hi, this series mainly ports existining functionality to older SoCs - most importantly enables alpha blending for RK3036, RK3066, RK3126 and RK3188. Besides that, it also changes the window type from

[tip: x86/timers] x86/xen/time: Set the X86_FEATURE_TSC_KNOWN_FREQ flag in xen_tsc_khz()

2020-07-25 Thread tip-bot2 for Hayato Ohhashi
The following commit has been merged into the x86/timers branch of tip: Commit-ID: 898ec52d2ba05915aaedcdb21bff2e944c883cb8 Gitweb: https://git.kernel.org/tip/898ec52d2ba05915aaedcdb21bff2e944c883cb8 Author:Hayato Ohhashi AuthorDate:Tue, 21 Jul 2020 16:12:31 Committer:

Re: [PATCH V2] Subject: [PATCH] staging: rtl8723bs: core: Using comparison to true is error prone

2020-07-25 Thread
On Sat, Jul 25, 2020 at 03:34:34PM +0200, Greg KH wrote: > On Sat, Jul 25, 2020 at 02:28:06PM +0100, John Oldman wrote: > > clear below issues reported by checkpatch.pl: > > > > CHECK: Using comparison to true is error prone > > Your subject line is very odd :( Thanks, I should read all before

Re: [RFC 0/7] Add support to process rx packets in thread

2020-07-25 Thread Sebastian Gottschall
Am 25.07.2020 um 14:25 schrieb Hillf Danton: On Sat, 25 Jul 2020 12:38:00 +0200 Sebastian Gottschall wrote: you may consider this https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg1142611.html Thanks

Re: [PATCH] irqchip: irq-bcm2836.h: drop a duplicated word

2020-07-25 Thread Marc Zyngier
On Sat, 18 Jul 2020 17:28:53 -0700, Randy Dunlap wrote: > Drop the repeated word "the" in a comment. Applied to irq/irqchip-5.9, thanks! [1/1] irqchip: irq-bcm2836.h: drop a duplicated word commit: b48489d82fcf61f229a892c7e1b559be15c95916 Cheers, M. -- Without deviation from the

Re: [PATCH v3 0/4] irqchip: Add IRQCHIP_PLATFORM_DRIVER helper macros

2020-07-25 Thread Marc Zyngier
On Fri, 17 Jul 2020 17:06:33 -0700, Saravana Kannan wrote: > Made a series out of the previous v2 patch + some example uses of the > macros. > > Not sure if the MTK changes work (just compile tested), but saw that > Hanks was trying to make those drivers into tristate. So I assume > they'll work

Re: [PATCH v2] irqchip/stm32-exti: map direct event to irq parent

2020-07-25 Thread Marc Zyngier
On Fri, 17 Jul 2020 16:07:17 +0200, Alexandre Torgue wrote: > EXTI lines are mainly used to wake-up system from CStop low power mode. > Currently, if a device wants to use a EXTI (direct) line as wakeup line, > it has to declare 2 interrupts: > - one for EXTI used to wake-up system (with

Re: [PATCH v2] irqchip/gic-v4.1: Ensure accessing the correct RD when writing INVALLR

2020-07-25 Thread Marc Zyngier
On Mon, 20 Jul 2020 17:23:28 +0800, Zenghui Yu wrote: > The GICv4.1 spec tells us that it's CONSTRAINED UNPREDICTABLE to issue a > register-based invalidation operation for a vPEID not mapped to that RD, > or another RD within the same CommonLPIAff group. > > To follow this rule, commit

Re: [PATCH] irqchip/irq-bcm7038-l1: Guard uses of cpu_logical_map

2020-07-25 Thread Marc Zyngier
On Fri, 24 Jul 2020 11:41:56 -0700, Florian Fainelli wrote: > cpu_logical_map is only defined for CONFIG_SMP builds, when we are in an > UP configuration, the boot CPU is 0. Applied to irq/irqchip-5.9, thanks! [1/1] irqchip/irq-bcm7038-l1: Guard uses of cpu_logical_map commit:

[rcu:dev.2020.07.20a] BUILD SUCCESS 80f707206fe3d3ab5b83f8180538f8a70e095ead

2020-07-25 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git dev.2020.07.20a branch HEAD: 80f707206fe3d3ab5b83f8180538f8a70e095ead fixup! kernel/smp: Provide CSD lock timeout diagnostics elapsed time: 1112m configs tested: 74 configs skipped: 1 The following configs

Re: [PATCH] mips: Do not include hi and lo in clobber list for R6

2020-07-25 Thread Alexander Lobakin
Hi Romain, From: Romain Naour Date: Sat, 25 Jul 2020 15:25:33 +0200 > From [1] > "GCC 10 (PR 91233) won't silently allow registers that are not architecturally > available to be present in the clobber list anymore, resulting in build > failure > for mips*r6 targets in form of: > ... >

Re: [PATCH 08/10] media: uapi: h264: Clean slice invariants syntax elements

2020-07-25 Thread Alexandre Courbot
On Thu, Jul 16, 2020 at 5:23 AM Ezequiel Garcia wrote: > > The H.264 specification requires in its "Slice header semantics" > section that the following values shall be the same in all slice headers: > > pic_parameter_set_id > frame_num > field_pic_flag > bottom_field_flag > idr_pic_id

[PATCH V3] staging: rtl8723bs: core: Using comparison to true is error prone

2020-07-25 Thread John Oldman
clear below issues reported by checkpatch.pl: CHECK: Using comparison to true is error prone Signed-off-by: John Oldman --- v1- First attempt: removed comparison to true. v2- Removed unneccessary parentheses around 'pregistrypriv->ht_enable, missed in v1. v3- Corrected the 'odd' subject line;

Re: [PULL REQUEST] i2c for v5.8

2020-07-25 Thread Wolfram Sang
Linus, > Do you have a lot of pending fixes? Because things _seem_ fairly quiet > for this release, and right now it doesn't seem to make much sense to > delay 5.8. No, it is not about fixes. I have one fix pending and I am quite sure we make it for 5.8. It would simply give me one more week to

Re: [PATCH 09/10] media: hantro: Don't require unneeded H264_SLICE_PARAMS

2020-07-25 Thread Alexandre Courbot
On Thu, Jul 16, 2020 at 5:23 AM Ezequiel Garcia wrote: > > Now that slice invariant parameters have been moved, > the driver no longer needs this control, so drop it. > > Signed-off-by: Ezequiel Garcia > --- > drivers/staging/media/hantro/hantro_drv.c | 5 - >

Re: [PATCH] mips: Do not include hi and lo in clobber list for R6

2020-07-25 Thread Romain Naour
Hi Alexander, Le 25/07/2020 à 16:32, Alexander Lobakin a écrit : > Hi Romain, > > From: Romain Naour > Date: Sat, 25 Jul 2020 15:25:33 +0200 > >> From [1] >> "GCC 10 (PR 91233) won't silently allow registers that are not >> architecturally >> available to be present in the clobber list

Re: [PATCH v2 4/4] fpga: dfl: add support for N3000 nios private feature

2020-07-25 Thread Tom Rix
Mostly little stuff. The polling on the int in ns_bus_poll_stat_timeout should be refactored. Tom On 7/23/20 7:09 PM, Xu Yilun wrote: > This patch adds support for the nios handshake private feature on Intel > N3000 FPGA Card. This private feature provides a handshake interface to > FPGA NIOS

Re: [PATCH RFC 2/6] pwm: core: Add option to config PWM duty/period with u64 data length

2020-07-25 Thread Martin Botka
Hello, As can be seen this divides llu by llu in few warnings and error. At the time of sending i didn't realize it but this fails on 32 bit architectures. So i would like to ask how would you like this fixed ? Using macro or some other way ? Thank you. Best regards, Martin

Re: [PATCH] kcsan: Add option to allow watcher interruptions

2020-07-25 Thread Paul E. McKenney
On Thu, Feb 20, 2020 at 10:33:17PM +0100, Marco Elver wrote: > On Thu, 20 Feb 2020, Paul E. McKenney wrote: I am clearly not keeping up... :-/ > > On Thu, Feb 20, 2020 at 03:15:51PM +0100, Marco Elver wrote: > > > Add option to allow interrupts while a watchpoint is set up. This can be > > >

Re: [PATCH RFC leds + net-next v3 2/2] net: phy: marvell: add support for PHY LEDs via LED class

2020-07-25 Thread Andrew Lunn
On Sat, Jul 25, 2020 at 11:34:50AM +0200, Marek Behun wrote: > On Sat, 25 Jul 2020 11:23:39 +0200 > Pavel Machek wrote: > > > Hi! > > > > > +static const struct marvell_led_mode_info marvell_led_mode_info[] = { > > > + { "link", { 0x0, -1, 0x0, -1, -1, -1, }, 0 }, > >

[net-next v3 0/6] net: marvell: prestera: Add Switchdev driver for Prestera family ASIC device 98DX326x (AC3x)

2020-07-25 Thread Vadym Kochan
Marvell Prestera 98DX326x integrates up to 24 ports of 1GbE with 8 ports of 10GbE uplinks or 2 ports of 40Gbps stacking for a largely wireless SMB deployment. Prestera Switchdev is a firmware based driver that operates via PCI bus. The current implementation supports only boards designed for the

[net-next v3 2/6] net: marvell: prestera: Add PCI interface support

2020-07-25 Thread Vadym Kochan
Add PCI interface driver for Prestera Switch ASICs family devices, which provides: - Firmware loading mechanism - Requests & events handling to/from the firmware - Access to the firmware on the bus level The firmware has to be loaded each time device is reset. The driver is loading

[net-next v3 1/6] net: marvell: prestera: Add driver for Prestera family ASIC devices

2020-07-25 Thread Vadym Kochan
Marvell Prestera 98DX326x integrates up to 24 ports of 1GbE with 8 ports of 10GbE uplinks or 2 ports of 40Gbps stacking for a largely wireless SMB deployment. The current implementation supports only boards designed for the Marvell Switchdev solution and requires special firmware. The core

[net-next v3 5/6] net: marvell: prestera: Add Switchdev driver implementation

2020-07-25 Thread Vadym Kochan
The following features are supported: - VLAN-aware bridge offloading - VLAN-unaware bridge offloading - FDB offloading (learning, ageing) - Switchport configuration Currently there are some limitations like: - Only 1 VLAN-aware bridge instance supported - FDB ageing

[net-next v3 4/6] net: marvell: prestera: Add ethtool interface support

2020-07-25 Thread Vadym Kochan
The ethtool API provides support for the configuration of the following features: speed and duplex, auto-negotiation, MDI-x, forward error correction, port media type. The API also provides information about the port status, hardware and software statistic. The following limitation exists: -

[net-next v3 3/6] net: marvell: prestera: Add basic devlink support

2020-07-25 Thread Vadym Kochan
Add very basic support for devlink interface: - driver name - fw version - devlink ports Signed-off-by: Vadym Kochan --- drivers/net/ethernet/marvell/prestera/Kconfig | 1 + .../net/ethernet/marvell/prestera/Makefile| 2 +- .../net/ethernet/marvell/prestera/prestera.h |

[net-next v3 6/6] dt-bindings: marvell,prestera: Add description for device-tree bindings

2020-07-25 Thread Vadym Kochan
Add brief description how to configure base mac address binding in device-tree. Describe requirement for the PCI port which is connected to the ASIC, to allow access to the firmware related registers. Signed-off-by: Vadym Kochan --- .../bindings/net/marvell,prestera.txt | 34

Re: [PATCH v2 2/2] kernel/trace: Remove function callback casts

2020-07-25 Thread Oscar Carter
Hi Steven, On Fri, Jul 24, 2020 at 02:34:57PM -0400, Steven Rostedt wrote: > On Fri, 24 Jul 2020 19:55:00 +0200 > Oscar Carter wrote: > > > > Which one of the above is this patch set for? > > > > This patch is the result of a warning obtained with the following: > > > > make allmodconfig

Re: [PATCH net-next] fib: use indirect call wrappers in the most common fib_rules_ops

2020-07-25 Thread kernel test robot
Hi Brian, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Brian-Vazquez/fib-use-indirect-call-wrappers-in-the-most-common-fib_rules_ops/20200725-095008 base: https://git.kernel.org/pub/scm

Re: [PATCH] kcsan: Add option to allow watcher interruptions

2020-07-25 Thread Marco Elver
[+Peter] On Sat, 25 Jul 2020 at 16:56, Paul E. McKenney wrote: > > On Thu, Feb 20, 2020 at 10:33:17PM +0100, Marco Elver wrote: > > On Thu, 20 Feb 2020, Paul E. McKenney wrote: > > I am clearly not keeping up... :-/ Not to worry, I think the local_t idea was discarded based on Peter's feedback

Re: [PATCH v2 2/2] kernel/trace: Remove function callback casts

2020-07-25 Thread Oscar Carter
Sorry, typo correction for the last paragraph: On Sat, Jul 25, 2020 at 05:09:14PM +0200, Oscar Carter wrote: > > I would be will to add that linker trick to remove the warning. Or we > > just use that warning as incentive to get architecture developers to > > implement this feature ;-) > > In my

Re: [PATCH RFC 2/6] pwm: core: Add option to config PWM duty/period with u64 data length

2020-07-25 Thread Pavel Machek
Hi! > As can be seen this divides llu by llu in few warnings and error. > At the time of sending i didn't realize it but this fails on 32 bit > architectures. > > So i would like to ask how would you like this fixed ? > Using macro or some other way ? +#include - gain_q23 =

Re: [PATCH RFC 2/6] pwm: core: Add option to config PWM duty/period with u64 data length

2020-07-25 Thread Martin Botka
> +#include > - gain_q23 = (gain_q23 * dmic->boost_gain) / 100; > + gain_q23 = div_u64(gain_q23 * dmic->boost_gain, 100); Ok so using a macro. Thank you.

Re: [RFC 0/7] Add support to process rx packets in thread

2020-07-25 Thread Sebastian Gottschall
i agree. i just can say that i tested this patch recently due this discussion here. and it can be changed by sysfs. but it doesnt work for wifi drivers which are mainly using dummy netdev devices. for this i made a small patch to get them working using napi_set_threaded manually hardcoded in

Re: [PATCH v2] cpuidle: change enter_s2idle() prototype

2020-07-25 Thread Rafael J. Wysocki
On Fri, Jul 24, 2020 at 1:50 PM Neal Liu wrote: > > On Fri, 2020-07-24 at 13:20 +0200, Rafael J. Wysocki wrote: > > On Fri, Jul 24, 2020 at 12:24 PM Neal Liu wrote: > > > > > > On Fri, 2020-07-24 at 11:57 +0200, Rafael J. Wysocki wrote: > > > > On Thu, Jul 23, 2020 at 9:07 PM Sami Tolvanen > >

Re: [PATCH v3 00/19] Introduce partial kernel_read_file() support

2020-07-25 Thread Kees Cook
On Sat, Jul 25, 2020 at 12:05:55PM +0200, Greg Kroah-Hartman wrote: > On Fri, Jul 24, 2020 at 02:36:21PM -0700, Kees Cook wrote: > > v3: > > - add reviews/acks > > - add "IMA: Add support for file reads without contents" patch > > - trim CC list, in case that's why vger ignored v2 > > v2: [missing

Re: [PATCH v3 03/19] firmware_loader: EFI firmware loader must handle pre-allocated buffer

2020-07-25 Thread Kees Cook
On Sat, Jul 25, 2020 at 12:07:00PM +0200, Greg Kroah-Hartman wrote: > On Fri, Jul 24, 2020 at 02:36:24PM -0700, Kees Cook wrote: > > The EFI platform firmware fallback would clobber any pre-allocated > > buffers. Instead, correctly refuse to reallocate when too small (as > > already done in the

Re: [PATCH v2 0/5] drm: rockchip: various ports for older VOPs

2020-07-25 Thread Daniel Vetter
On Sat, Jul 25, 2020 at 3:52 PM Alex Bee wrote: > > > Am 22.07.20 um 23:43 schrieb Daniel Vetter: > > On Wed, Jul 22, 2020 at 8:13 PM Alex Bee wrote: > >> Hi, > >> > >> this series mainly ports existining functionality to older SoCs - most > >> importantly enables alpha blending for RK3036,

Re: [PATCHv3 3/6] irqchip/irq-pruss-intc: Add support for shared and invalid interrupts

2020-07-25 Thread Suman Anna
Hi Marc, On 7/17/20 6:02 AM, Marc Zyngier wrote: On Fri, 10 Jul 2020 21:59:17 +0100, Suman Anna wrote: Hi Suman, [...] Hi Marc, On 7/2/20 12:44 PM, Marc Zyngier wrote: On 2020-07-02 15:17, Grzegorz Jaszczyk wrote: From: Suman Anna The PRUSS INTC has a fixed number of output interrupt

Re: [PATCH] drm/vkms: add missing drm_crtc_vblank_put to the get/put pair on flush

2020-07-25 Thread Daniel Vetter
On Sat, Jul 25, 2020 at 5:12 AM Sidong Yang wrote: > > On Wed, Jul 22, 2020 at 05:17:05PM +0200, Daniel Vetter wrote: > > On Wed, Jul 22, 2020 at 4:06 PM Melissa Wen wrote: > > > > > > On 07/22, dan...@ffwll.ch wrote: > > > > On Wed, Jul 22, 2020 at 08:04:11AM -0300, Melissa Wen wrote: > > > > >

[PATCH] efi/libstub: Stop parsing arguments at "--"

2020-07-25 Thread Arvind Sankar
Arguments after "--" are arguments for init, not for the kernel. Signed-off-by: Arvind Sankar --- drivers/firmware/efi/libstub/efi-stub-helper.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/firmware/efi/libstub/efi-stub-helper.c b/drivers/firmware/efi/libstub/efi-stub-helper.c

Re: [PATCH RFC leds + net-next v3 1/2] net: phy: add API for LEDs controlled by PHY HW

2020-07-25 Thread Andrew Lunn
On Fri, Jul 24, 2020 at 06:46:02PM +0200, Marek Behún wrote: > Many PHYs support various HW control modes for LEDs connected directly > to them. > > This code adds a new private LED trigger called phydev-hw-mode. When > this trigger is enabled for a LED, the various HW control modes which > the

Re: [PATCHv3 3/6] irqchip/irq-pruss-intc: Add support for shared and invalid interrupts

2020-07-25 Thread Marc Zyngier
On 2020-07-25 16:57, Suman Anna wrote: Suman, Hi Marc, [...] @@ -244,8 +295,14 @@ static int pruss_intc_probe(struct platform_device *pdev) return -ENOMEM; for (i = 0; i < MAX_NUM_HOST_IRQS; i++) { +    if (intc->invalid_intr & BIT(i)) +    continue; +

Re: checkpatch: support deprecated terms checking

2020-07-25 Thread Joe Perches
On Sat, 2020-07-25 at 15:02 +0200, Michał Mirosław wrote: > Hello, > > I see that this patch went into next and is already inciting people to > do wrong things [1]. Can you please fix it to require '--subjective' > switch or otherwise mark it clearly as suggestion-only? > > The coding-style as

Re: [PATCHv3 3/6] irqchip/irq-pruss-intc: Add support for shared and invalid interrupts

2020-07-25 Thread Suman Anna
Hi Marc, On 7/25/20 11:27 AM, Marc Zyngier wrote: On 2020-07-25 16:57, Suman Anna wrote: Suman, Hi Marc, [...] @@ -244,8 +295,14 @@ static int pruss_intc_probe(struct platform_device *pdev)   return -ENOMEM;   for (i = 0; i < MAX_NUM_HOST_IRQS; i++) { +    if

Re: [PATCH 1/2] perf tools: Allow r0x event syntax

2020-07-25 Thread Ian Rogers
On Sat, Jul 25, 2020 at 5:20 AM Jiri Olsa wrote: > > Adding support to specify raw event with 'r0' syntax within > pmu term syntax like: > > -e cpu/r0xdead/ > > It will be used to specify raw events in cases where they conflict > with real pmu terms, like 'read', which is valid raw event

Re: [PATCH v3 4/4] bus: mhi: clients: Add user space client interface driver

2020-07-25 Thread Manivannan Sadhasivam
On Fri, Jul 24, 2020 at 04:47:44PM -0700, Hemant Kumar wrote: > Hi Mani, > > On 7/22/20 1:45 AM, Manivannan Sadhasivam wrote: > > On Mon, Jul 20, 2020 at 08:40:24PM -0700, Hemant Kumar wrote: > > > Hi Mani, > > > > > > On 6/19/20 3:40 AM, Manivannan Sadhasivam wrote: > > > > On Thu, Jun 11, 2020

Re: [PATCH v2] sched,tracing: Convert to sched_set_fifo()

2020-07-25 Thread Peter Zijlstra
On Fri, Jul 24, 2020 at 06:18:46PM -0400, Steven Rostedt wrote: > On Fri, 24 Jul 2020 23:50:03 +0200 > pet...@infradead.org wrote: > > > - if (producer_fifo < 0) > > + if (producer_fifo) > > + trace_printk("Running Producer at SCHED_FIFO %s\n", > > +

Re: [PATCH 2/2] perf tools: Fix term parsing for raw syntax

2020-07-25 Thread Ian Rogers
On Sat, Jul 25, 2020 at 5:20 AM Jiri Olsa wrote: > > Jin Yao reported issue with possible conflict between raw > events and term values in pmu event syntax. > > Currently following syntax is resolved as raw event with > 0xead value: > uncore_imc_free_running/read/ > > instead of using 'read'

Re: [ANNOUNCE] util-linux v2.36

2020-07-25 Thread Pavel Machek
Hi! > The commands fdisk(8), sfdisk(8), cfdisk(8), mkswap(8) and wipefs(8) now > support block devices locking by flock(2) to better behave with udevd or other > tools. Ffor more details see https://systemd.io/BLOCK_DEVICE_LOCKING/. This There's typo "ffor", but I guess it is too late to fix

[PATCH v2] netfilter: Replace HTTP links with HTTPS ones

2020-07-25 Thread Alexander A. Klimov
Rationale: Reduces attack surface on kernel devs opening the links for MITM as HTTPS traffic is much harder to manipulate. Deterministic algorithm: For each file: If not .svg: For each line: If doesn't contain `\bxmlns\b`: For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:

WARNING in delete_node (2)

2020-07-25 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:de2e69cf Add linux-next specific files for 20200721 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=13645cef10 kernel config: https://syzkaller.appspot.com/x/.config?x=a18f913b3827a63a dashboard

Re: [PATCH v3 03/19] firmware_loader: EFI firmware loader must handle pre-allocated buffer

2020-07-25 Thread Greg Kroah-Hartman
On Sat, Jul 25, 2020 at 08:50:33AM -0700, Kees Cook wrote: > On Sat, Jul 25, 2020 at 12:07:00PM +0200, Greg Kroah-Hartman wrote: > > On Fri, Jul 24, 2020 at 02:36:24PM -0700, Kees Cook wrote: > > > The EFI platform firmware fallback would clobber any pre-allocated > > > buffers. Instead, correctly

Re: [PATCH V3] staging: rtl8723bs: core: Using comparison to true is error prone

2020-07-25 Thread Greg KH
On Sat, Jul 25, 2020 at 03:37:12PM +0100, John Oldman wrote: > clear below issues reported by checkpatch.pl: > > CHECK: Using comparison to true is error prone Again, you did more than just this in the patch :(

[PATCH] net/ipv4: add comment about connect() to INADDR_ANY

2020-07-25 Thread Konstantin Khlebnikov
Copy comment from net/ipv6/tcp_ipv6.c to help future readers. Signed-off-by: Konstantin Khlebnikov --- net/ipv4/route.c |1 + 1 file changed, 1 insertion(+) diff --git a/net/ipv4/route.c b/net/ipv4/route.c index a01efa062f6b..303fe706cbd2 100644 --- a/net/ipv4/route.c +++

Re: [PATCH RFC leds + net-next v3 2/2] net: phy: marvell: add support for PHY LEDs via LED class

2020-07-25 Thread Andrew Lunn
On Fri, Jul 24, 2020 at 06:46:03PM +0200, Marek Behún wrote: > This patch adds support for controlling the LEDs connected to several > families of Marvell PHYs via the PHY HW LED trigger API. These families > are: 88E1112, 88E1121R, 88E1240, 88E1340S, 88E1510 and 88E1545. More can > be added. > >

Re: [PATCH v3 5/6] powerpc/pseries: implement paravirt qspinlocks for SPLPAR

2020-07-25 Thread Peter Zijlstra
On Fri, Jul 24, 2020 at 03:10:59PM -0400, Waiman Long wrote: > On 7/24/20 4:16 AM, Will Deacon wrote: > > On Thu, Jul 23, 2020 at 08:47:59PM +0200, pet...@infradead.org wrote: > > > On Thu, Jul 23, 2020 at 02:32:36PM -0400, Waiman Long wrote: > > > > BTW, do you have any comment on my v2 lock

Re: checkpatch: support deprecated terms checking

2020-07-25 Thread Joe Perches
On Sat, 2020-07-25 at 15:02 +0200, Michał Mirosław wrote: > Hello, > > I see that this patch went into next and is already inciting people to > do wrong things [1]. Can you please fix it to require '--subjective' > switch or otherwise mark it clearly as suggestion-only? > > The coding-style as

Re: [RFC][PATCH 1/9] irq_work: Cleanup

2020-07-25 Thread Peter Zijlstra
On Sat, Jul 25, 2020 at 01:58:28PM +0200, Ingo Molnar wrote: > > * Peter Zijlstra wrote: > > > Get rid of the __call_single_node union and clean up the API a little > > to avoid external code relying on the structure layout as much. > > > > Signed-off-by: Peter Zijlstra (Intel) > > --- > >

Re: [RFC PATCH] net: dsa: qca8k: Add 802.1q VLAN support

2020-07-25 Thread Jonathan McDowell
On Thu, Jul 23, 2020 at 01:58:47AM +0300, Vladimir Oltean wrote: > On Wed, Jul 22, 2020 at 03:36:38PM -0700, Florian Fainelli wrote: > > On 7/22/20 12:38 PM, Jonathan McDowell wrote: > > > On Tue, Jul 21, 2020 at 10:26:07AM -0700, Florian Fainelli wrote: > > >> On 7/21/20 10:16 AM, Jonathan

Re: [PATCH V3] staging: rtl8723bs: core: Using comparison to true is error prone

2020-07-25 Thread
On Sat, Jul 25, 2020 at 07:21:24PM +0200, Greg KH wrote: > On Sat, Jul 25, 2020 at 03:37:12PM +0100, John Oldman wrote: > > clear below issues reported by checkpatch.pl: > > > > CHECK: Using comparison to true is error prone > > Again, you did more than just this in the patch :( do you mean by

Re: [PATCH v3 5/6] powerpc/pseries: implement paravirt qspinlocks for SPLPAR

2020-07-25 Thread Waiman Long
On 7/25/20 1:26 PM, Peter Zijlstra wrote: On Fri, Jul 24, 2020 at 03:10:59PM -0400, Waiman Long wrote: On 7/24/20 4:16 AM, Will Deacon wrote: On Thu, Jul 23, 2020 at 08:47:59PM +0200, pet...@infradead.org wrote: On Thu, Jul 23, 2020 at 02:32:36PM -0400, Waiman Long wrote: BTW, do you have

Re: [RESEND RFC PATCH v1] arm64: kvm: flush tlbs by range in unmap_stage2_range function

2020-07-25 Thread Marc Zyngier
On 2020-07-24 14:43, Zhenyu Ye wrote: Now in unmap_stage2_range(), we flush tlbs one by one just after the corresponding pages cleared. However, this may cause some performance problems when the unmap range is very large (such as when the vm migration rollback, this may cause vm downtime too

Re: [PATCH RFC leds + net-next v3 2/2] net: phy: marvell: add support for PHY LEDs via LED class

2020-07-25 Thread Marek Behun
On Sat, 25 Jul 2020 17:03:42 +0200 Andrew Lunn wrote: > Does hi-z mean off? In the implementation i did, i did not list off > and on as triggers. I instead used them for untriggered > brightness. That allowed the software triggers to work, so i had the > PHY blinking the heartbeat etc. But i had

[PATCH] MIPS: ingenic: JZ4725B: Add IPU node

2020-07-25 Thread Paul Cercueil
Add a devicetree node for the Image Processing Unit (IPU) found in the JZ4725B. Connect it with graph nodes to the LCD node. The LCD driver will expect the IPU node to be accessed through graph port #8, as stated in the bindings documentation. Signed-off-by: Paul Cercueil --- Notes: Binding

Re: [PATCH] kcsan: Add option to allow watcher interruptions

2020-07-25 Thread Peter Zijlstra
On Sat, Jul 25, 2020 at 05:17:43PM +0200, Marco Elver wrote: > On Sat, 25 Jul 2020 at 16:56, Paul E. McKenney wrote: > > On Thu, Feb 20, 2020 at 10:33:17PM +0100, Marco Elver wrote: > > > On Thu, 20 Feb 2020, Paul E. McKenney wrote: > > > > On Thu, Feb 20, 2020 at 03:15:51PM +0100, Marco Elver

Re: [PATCH 1/1] STAGING - REALTEK RTL8188EU DRIVERS: Fix Coding Style Error

2020-07-25 Thread Larry Finger
On 7/25/20 7:20 AM, Anant Thazhemadam wrote: Running the checkpatch.pl script on the file for which patch was created, the following error was found to exist. ERROR: space required after that ',' (ctx:VxV) Fixed the above error which was found on line #721 by inserting a blank space at the

Re: [PATCH] drm/vkms: add missing drm_crtc_vblank_put to the get/put pair on flush

2020-07-25 Thread Melissa Wen
On 07/25, Daniel Vetter wrote: > On Sat, Jul 25, 2020 at 5:12 AM Sidong Yang wrote: > > > > On Wed, Jul 22, 2020 at 05:17:05PM +0200, Daniel Vetter wrote: > > > On Wed, Jul 22, 2020 at 4:06 PM Melissa Wen wrote: > > > > > > > > On 07/22, dan...@ffwll.ch wrote: > > > > > On Wed, Jul 22, 2020 at

Re: [PATCH RFC leds + net-next v3 2/2] net: phy: marvell: add support for PHY LEDs via LED class

2020-07-25 Thread Andrew Lunn
On Sat, Jul 25, 2020 at 07:39:50PM +0200, Marek Behun wrote: > On Sat, 25 Jul 2020 17:03:42 +0200 > Andrew Lunn wrote: > > > Does hi-z mean off? In the implementation i did, i did not list off > > and on as triggers. I instead used them for untriggered > > brightness. That allowed the software

Re: [RESEND PATCH] usb: common: usb-conn-gpio: Register optional charger

2020-07-25 Thread Paul Cercueil
Hi Greg, Le mar. 21 juil. 2020 à 13:41, Greg Kroah-Hartman a écrit : On Mon, Jun 22, 2020 at 12:48:07AM +0200, Paul Cercueil wrote: Register a power supply charger, if the Kconfig option USB_CONN_GPIO_CHARGER is set, whose online state depends on whether the USB role is set to device or

Re: [PATCH 04/18] csum_and_copy_..._user(): pass 0xffffffff instead of 0 as initial sum

2020-07-25 Thread Al Viro
On Tue, Jul 21, 2020 at 10:11:18PM +0100, Al Viro wrote: > Theoretically - sure. I can post the full analysis of that stuff (starting > with the proof that all instances of csum_partial() are OK in that respect, > which takes care of the default instances, then instance-by-instance > analysis of

Re: [RFC 0/7] Add support to process rx packets in thread

2020-07-25 Thread Felix Fietkau
On 2020-07-25 10:16, Hillf Danton wrote: > Hi folks > > Below is a minimunm poc implementation I can imagine on top of workqueue > to make napi threaded. Thoughts are appreciated. Hi Hillf, For some reason I don't see your mails on linux-wireless/netdev. I've cleaned up your implementation a bit

Re: [PATCH RFC leds + net-next v3 2/2] net: phy: marvell: add support for PHY LEDs via LED class

2020-07-25 Thread Marek Behun
On Sat, 25 Jul 2020 19:23:18 +0200 Andrew Lunn wrote: > On Fri, Jul 24, 2020 at 06:46:03PM +0200, Marek Behún wrote: > > This patch adds support for controlling the LEDs connected to several > > families of Marvell PHYs via the PHY HW LED trigger API. These families > > are: 88E1112, 88E1121R,

Re: [PATCH] drm/vkms: add missing drm_crtc_vblank_put to the get/put pair on flush

2020-07-25 Thread Daniel Vetter
On Sat, Jul 25, 2020 at 7:45 PM Melissa Wen wrote: > > On 07/25, Daniel Vetter wrote: > > On Sat, Jul 25, 2020 at 5:12 AM Sidong Yang wrote: > > > > > > On Wed, Jul 22, 2020 at 05:17:05PM +0200, Daniel Vetter wrote: > > > > On Wed, Jul 22, 2020 at 4:06 PM Melissa Wen > > > > wrote: > > > > > >

KMSAN: uninit-value in strstr

2020-07-25 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:93f54a72 instrumented.h: fix KMSAN support git tree: https://github.com/google/kmsan.git master console output: https://syzkaller.appspot.com/x/log.txt?x=118c345490 kernel config:

[RFC PATCH v5 6/7] drivers: thermal: tsens: Add support for ipq8064-tsens

2020-07-25 Thread Ansuel Smith
Add support for tsens present in ipq806x SoCs based on generic msm8960 tsens driver. Signed-off-by: Ansuel Smith --- drivers/thermal/qcom/tsens.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/thermal/qcom/tsens.c b/drivers/thermal/qcom/tsens.c index 78840c1bc5d2..5eb036767e8d

[RFC PATCH v5 5/7] drivers: thermal: tsens: Change calib_backup name for msm8960

2020-07-25 Thread Ansuel Smith
Follow standard naming for calib secondary rom and change calib_backup to tsens_calsel. Signed-off-by: Ansuel Smith --- drivers/thermal/qcom/tsens-8960.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thermal/qcom/tsens-8960.c b/drivers/thermal/qcom/tsens-8960.c

[RFC PATCH v5 0/7] Add support for ipq8064 tsens

2020-07-25 Thread Ansuel Smith
This patchset convert msm8960 to reg_filed, use int_common instead of a custom function and fix wrong tsens get_temp function for msm8960. Ipq8064 SoCs tsens driver is based on 8960 tsens driver. Ipq8064 needs to be registered as a gcc child as the tsens regs on this platform are shared with the

[RFC PATCH v5 7/7] dt-bindings: thermal: tsens: Document ipq8064 bindings

2020-07-25 Thread Ansuel Smith
Document the use of bindings used for msm8960 tsens based devices. msm8960 use the same gcc regs and is set as a child of the qcom gcc. Signed-off-by: Ansuel Smith --- .../bindings/thermal/qcom-tsens.yaml | 50 --- 1 file changed, 43 insertions(+), 7 deletions(-) diff

[RFC PATCH v5 4/7] drivers: thermal: tsens: Fix wrong get_temp for msm8960

2020-07-25 Thread Ansuel Smith
msm8960 based tsens have an hardcoded slope. Fix the calibrate function with the new added slope, change code_to_mdegC to use slope and conver get_temp to use reg_field. Signed-off-by: Ansuel Smith --- drivers/thermal/qcom/tsens-8960.c | 43 +++ 1 file changed, 32

[RFC PATCH v5 3/7] drivers: thermal: tsens: Use init_common for msm8960

2020-07-25 Thread Ansuel Smith
Use init_common and drop custom init for msm8960. Signed-off-by: Ansuel Smith --- drivers/thermal/qcom/tsens-8960.c | 53 +-- 1 file changed, 1 insertion(+), 52 deletions(-) diff --git a/drivers/thermal/qcom/tsens-8960.c b/drivers/thermal/qcom/tsens-8960.c index

[RFC PATCH v5 1/7] drivers: thermal: tsens: Add VER_0 tsens version

2020-07-25 Thread Ansuel Smith
VER_0 is used to describe device based on tsens version before v0.1. These device are devices based on msm8960 for example apq8064 or ipq806x. Signed-off-by: Ansuel Smith --- drivers/thermal/qcom/tsens.c | 160 +++ drivers/thermal/qcom/tsens.h | 7 +- 2 files

[RFC PATCH v5 2/7] drivers: thermal: tsens: Convert msm8960 to reg_field

2020-07-25 Thread Ansuel Smith
Covert msm9860 driver to reg_filed to use the init_common function. Signed-off-by: Ansuel Smith --- drivers/thermal/qcom/tsens-8960.c | 74 +++ 1 file changed, 74 insertions(+) diff --git a/drivers/thermal/qcom/tsens-8960.c b/drivers/thermal/qcom/tsens-8960.c index

[PATCH] [cgroup/testing] cg_read_strcmp: Fix null pointer dereference

2020-07-25 Thread Gaurav Singh
Passing NULL in strcmp will cause a segmentation fault. Fix this by returning -1 if expected is NULL pointer. Signed-off-by: Gaurav Singh --- tools/testing/selftests/cgroup/cgroup_util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH RFC leds + net-next v3 2/2] net: phy: marvell: add support for PHY LEDs via LED class

2020-07-25 Thread Andrew Lunn
On Sat, Jul 25, 2020 at 08:02:24PM +0200, Marek Behun wrote: > On Sat, 25 Jul 2020 19:23:18 +0200 > Andrew Lunn wrote: > > > On Fri, Jul 24, 2020 at 06:46:03PM +0200, Marek Behún wrote: > > > This patch adds support for controlling the LEDs connected to several > > > families of Marvell PHYs via

Re: [PATCH 0/2] Fix some build warnings when W=1

2020-07-25 Thread Palmer Dabbelt
On Wed, 15 Jul 2020 23:15:25 PDT (-0700), zong...@sifive.com wrote: These patches fix some build warnings when W=1, the most of warnings are missing prototype as follows: arch/riscv/mm/init.c:520:13: warning: no previous prototype for 'resource_init' [-Wmissing-prototypes]

  1   2   3   4   5   >