Re: [PATCH -next v2] virtio_net: Avoid loop in virtnet_poll

On Sun, Aug 02, 2020 at 01:56:33PM +0800, Mao Wenan wrote: > The loop may exist if vq->broken is true, > virtqueue_get_buf_ctx_packed or virtqueue_get_buf_ctx_split > will return NULL, so virtnet_poll will reschedule napi to > receive packet, it will lead cpu usage(si) to 100%. > > call trace as

Re: [PATCH -next v2] virtio_net: Avoid loop in virtnet_poll

Just noticed the subject is wrong: this is no longer a virtio_net patch. On Sun, Aug 02, 2020 at 01:56:33PM +0800, Mao Wenan wrote: > The loop may exist if vq->broken is true, > virtqueue_get_buf_ctx_packed or virtqueue_get_buf_ctx_split > will return NULL, so virtnet_poll will reschedule napi

Re: WARNING in hci_conn_timeout

On Sat, Aug 01, 2020 at 03:56:09PM -0700, syzbot wrote: > syzbot has bisected this issue to: > > commit 3d30311c0e4d834c94e6a27d6242a942d6a76b85 > Author: Varsha Rao > Date: Sun Oct 9 11:13:56 2016 + > > staging: vt6655: Removes unnecessary blank lines. I doubt this is the real issue

Re: [PATCH v2] ASoC: fsl-asoc-card: Remove fsl_asoc_card_set_bias_level function

On Sun, Aug 02, 2020 at 10:22:35AM +0800, Shengjiu Wang wrote: > > > + /* Specific configuration for PLL */ > > > + if (codec_priv->pll_id && codec_priv->fll_id) { > > > + if (priv->sample_format == SNDRV_PCM_FORMAT_S24_LE) > > > + pll_out =

[PATCH] MAINTAINERS: update QUALCOMM IOMMU after Arm SSMU drivers move

Commit e86d1aa8b60f ("iommu/arm-smmu: Move Arm SMMU drivers into their own subdirectory") moved drivers/iommu/qcom_iommu.c to drivers/iommu/arm/arm-smmu/qcom_iommu.c amongst other moves, adjusted some sections in MAINTAINERS, but missed adjusting the QUALCOMM IOMMU section. Hence,

[PATCH] dt-bindings: mmc: sdhci-am654: Document bindings for the host controllers on TI's J7200 devices

Add binding documentation for mmc host controllers present on TI's J7200 SOC Signed-off-by: Faiz Abbas --- Documentation/devicetree/bindings/mmc/sdhci-am654.txt | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/mmc/sdhci-am654.txt

Re: [PATCH] drm/panel: remove return value of function drm_panel_add

Hi Bernard. On Sat, Aug 01, 2020 at 08:02:13PM +0800, Bernard Zhao wrote: > The function "int drm_panel_add(struct drm_panel *panel)" > always returns 0, this return value is meaningless. > Also, there is no need to check return value which calls > "drm_panel_add and", error branch code will

Re: [PATCH v6] coccinelle: api: add kvfree script

On Sun, 2 Aug 2020, Markus Elfring wrote: > … > > +++ b/scripts/coccinelle/api/kvfree.cocci > … > > +@choice@ > > +expression E, E1; > > +position kok, vok; > > +@@ > > + > > +( > … > > +| > > + E = \(kmalloc\|kzalloc\|krealloc\|kcalloc\|kmalloc_node\|kzalloc_node\| > > +

Re: [PATCH] Modify the parameters that are not used

' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/leesagacious/Modify-the-parameters-that-are-not-used/20200802-115945 base: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 6ba1b005ffc388c2aeaddae20da29e4810dea298

Re: [PATCH -next v2] virtio_net: Avoid loop in virtnet_poll

On 8/2/20 2:26 PM, Michael S. Tsirkin wrote: Just noticed the subject is wrong: this is no longer a virtio_net patch. thanks, I will change the subject and send v3.

Re: possible deadlock in __dev_queue_xmit (3)

syzbot has bisected this issue to: commit 1a33e10e4a95cb109ff1145098175df3113313ef Author: Cong Wang Date: Sun May 3 05:22:19 2020 + net: partially revert dynamic lockdep key changes bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=1043497090 start commit: d8b9faec

[PATCH -next v3] virtio_ring: Avoid loop when vq is broken in virtqueue_poll

The loop may exist if vq->broken is true, virtqueue_get_buf_ctx_packed or virtqueue_get_buf_ctx_split will return NULL, so virtnet_poll will reschedule napi to receive packet, it will lead cpu usage(si) to 100%. call trace as below: virtnet_poll virtnet_receive

[net-next PATCH] net: phy: mdio-mvusb: select MDIO_DEVRES in Kconfig

From: Bartosz Golaszewski PHYLIB is not selected by the mvusb driver but it uses mdio devres helpers. Explicitly select MDIO_DEVRES in this driver's Kconfig entry. Reported-by: kernel test robot Fixes: 1814cff26739 ("net: phy: add a Kconfig option for mdio_devres") Signed-off-by: Bartosz

Re: [PATCH v2 1/2] MAINTAINERS: Remove JZ4780 DMA driver entry

Hi Maciej, Le sam. 1 août 2020 à 23:30, Maciej W. Rozycki a écrit : On Sun, 26 Jul 2020, Krzysztof Kozlowski wrote: diff --git a/MAINTAINERS b/MAINTAINERS index cba0ed5b..362863cae239 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -8541,11 +8541,6 @@ F: include/uapi/rdma/ F:

[PATCH] drm: Remove unnecessary drm_panel_attach and drm_panel_detach

These functions are now empty and no longer useful so remove the functions and their uses. Signed-off-by: Joe Perches --- It's too tedious to break apart into multiple patches. Done with coccinelle and typing. Compiled allyesconfig x86-64 only.

Aw: Re: [PATCH v2 1/5] drm/mediatek: config component output by device node port

> Gesendet: Sonntag, 02. August 2020 um 02:03 Uhr > Von: "Chun-Kuang Hu" > An: "Frank Wunderlich" > Cc: "Chun-Kuang Hu" , "Philipp Zabel" > , "David Airlie" , "linux-kernel" > , "DRI Development" > , "moderated list:ARM/Mediatek SoC support" > , "Daniel Vetter" , > "Matthias Brugger" ,

Re: [PATCH v2 4/5] drm/mediatek: dpi/dsi: change the getting possible_crtc way

Am 2. August 2020 05:07:41 MESZ schrieb Chun-Kuang Hu : >I would like more information of why do this patch. For example: > >For current mediatek dsi encoder, its possible crtc is fixed in crtc >0, and mediatek dpi encoder's possible crtc is fixed in crtc 1. In >some SoC the possible crtc is

Re: [PATCH] fs: optimise kiocb_set_rw_flags()

On 01/08/2020 20:02, Jens Axboe wrote: > On 8/1/20 4:36 AM, Pavel Begunkov wrote: >> Use a local var to collect flags in kiocb_set_rw_flags(). That spares >> some memory writes and allows to replace most of the jumps with MOVEcc. > > I've picked this one up. Thanks -- Pavel Begunkov

[PATCH v6 1/3] devres: provide devm_krealloc()

From: Bartosz Golaszewski Implement the managed variant of krealloc(). This function works with all memory allocated by devm_kmalloc() (or devres functions using it implicitly like devm_kmemdup(), devm_kstrdup() etc.). Managed realloc'ed chunks can be manually released with devm_kfree().

[PATCH v6 3/3] iio: adc: xilinx-xadc: use devm_krealloc()

From: Bartosz Golaszewski Use the managed variant of krealloc() and shrink the code a bit. Signed-off-by: Bartosz Golaszewski Acked-by: Jonathan Cameron --- drivers/iio/adc/xilinx-xadc-core.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git

[PATCH v6 2/3] hwmon: pmbus: use more devres helpers

From: Bartosz Golaszewski Shrink pmbus code by using devm_hwmon_device_register_with_groups() and devm_krealloc() instead of their non-managed variants. Signed-off-by: Bartosz Golaszewski Acked-by: Guenter Roeck --- drivers/hwmon/pmbus/pmbus_core.c | 28 +--- 1 file

[PATCH v6 0/3] devres: provide and use devm_krealloc()

From: Bartosz Golaszewski Hi Greg, Andy, this is a reworked version of devm_krealloc(). This time without the risk of sleeping with spinlock taken. I noticed that devres_lock is only there to protect the integrity of the devres list - we can assume users are sane enough to not devm_kfree()

Re: [PATCH] fs: optimise kiocb_set_rw_flags()

On 01/08/2020 20:01, Jens Axboe wrote: > On 8/1/20 9:37 AM, Matthew Wilcox wrote: >> On Sat, Aug 01, 2020 at 01:36:33PM +0300, Pavel Begunkov wrote: >>> Use a local var to collect flags in kiocb_set_rw_flags(). That spares >>> some memory writes and allows to replace most of the jumps with MOVEcc.

Re: [PATCH] fs: optimise kiocb_set_rw_flags()

On 01/08/2020 18:37, Matthew Wilcox wrote: > On Sat, Aug 01, 2020 at 01:36:33PM +0300, Pavel Begunkov wrote: >> Use a local var to collect flags in kiocb_set_rw_flags(). That spares >> some memory writes and allows to replace most of the jumps with MOVEcc. >> >> Signed-off-by: Pavel Begunkov > >

Re: [PATCH] drm: Remove unnecessary drm_panel_attach and drm_panel_detach

Hi Joe. On Sun, Aug 02, 2020 at 01:00:11AM -0700, Joe Perches wrote: > These functions are now empty and no longer > useful so remove the functions and their uses. > > Signed-off-by: Joe Perches > --- > > It's too tedious to break apart into multiple patches. > Done with coccinelle and typing.

Re: [PATCH] splice: direct call for default_file_splice*()

On 01/08/2020 20:41, Christoph Hellwig wrote: > On Sat, Aug 01, 2020 at 01:12:22PM +0300, Pavel Begunkov wrote: >> On 30/01/2020 19:54, Christoph Hellwig wrote: >>> On Mon, Jan 20, 2020 at 11:49:46PM +0300, Pavel Begunkov wrote: Indirect calls could be very expensive nowadays, so try to use

[PATCH] regulator: lp8755: Get rid of lp8755_read/lp8755_write/lp8755_update_bits

Just use regmap_read/regmap_write/regmap_update_bits instead. Signed-off-by: Axel Lin --- drivers/regulator/lp8755.c | 82 ++ 1 file changed, 21 insertions(+), 61 deletions(-) diff --git a/drivers/regulator/lp8755.c b/drivers/regulator/lp8755.c index

staging: most: Build error since commit "drivers: most: add USB adapter driver"

Hi, with commit 97a6f772f36b7f52bcfa56a581bbd2470cffe23d ("drivers: most: add USB adapter driver") I get build errors. $ LANG=C make clean drivers/staging/rtl8188eu/ scripts/Makefile.clean:15: drivers/staging/most/usb/Makefile: No such file or directory make[5]: *** No rule to make target

[PATCH] atm: eni: avoid accessing the data mapped to streaming DMA

In do_tx(), skb->data is mapped to streaming DMA on line : paddr = dma_map_single(...,skb->data,DMA_TO_DEVICE); Then skb->data is accessed on line 1153: (skb->data[3] & 0xf) This access may cause data inconsistency between CPU cache and hardware. To fix this problem, skb->data[3] is

Re: staging: most: Build error since commit "drivers: most: add USB adapter driver"

On Sun, Aug 02, 2020 at 11:08:12AM +0200, Michael Straube wrote: > Hi, > > with commit 97a6f772f36b7f52bcfa56a581bbd2470cffe23d ("drivers: most: add USB > adapter driver") > I get build errors. > > $ LANG=C make clean drivers/staging/rtl8188eu/ > scripts/Makefile.clean:15:

[PATCH] staging: most: fix up movement of USB driver

When moving the most usb driver out of staging, we forgot to remove the subdirectory out of the staging Makefile as well. Fixes: 97a6f772f36b ("drivers: most: add USB adapter driver") Cc: Christian Gromm Reported-by: Michael Straube Signed-off-by: Greg Kroah-Hartman ---

[tip:master] BUILD SUCCESS 587bb771546ebb8e3b18c5201af430573df41a9d

allmodconfig powerpc defconfig powerpc allyesconfig powerpc allmodconfig powerpc allnoconfig x86_64 randconfig-a006-20200802 x86_64 randconfig-a001-20200802

[tip:locking/core] BUILD REGRESSION a68415c27ff366970be132c266aa859ad706af33

allyesconfig mips allmodconfig powerpc defconfig powerpc allyesconfig powerpc allmodconfig powerpc allnoconfig x86_64 randconfig-a006-20200802 x86_64

Re: [PATCH v2 05/18] gpiolib: cdev: support GPIO_GET_LINE_IOCTL and GPIOLINE_GET_VALUES_IOCTL

On Sun, Aug 02, 2020 at 11:31:58AM +0800, Kent Gibson wrote: > On Fri, Jul 31, 2020 at 06:05:10PM +0200, Bartosz Golaszewski wrote: > > On Sun, Jul 26, 2020 at 3:12 AM Kent Gibson wrote: > > > > > > > > > > > > > > + dev_dbg(>dev, "registered chardev handle for > > > > > line

[PATCH] atm: idt77252: avoid accessing the data mapped to streaming DMA

In queue_skb(), skb->data is mapped to streaming DMA on line 850: dma_map_single(..., skb->data, ...); Then skb->data is accessed on lines 862 and 863: tbd->word_4 = (skb->data[0] << 24) | (skb->data[1] << 16) | (skb->data[2] << 8) | (skb->data[3] << 0); and on lines 893 and 894:

Re: [PATCH 1/3] dt-bindings: pinctrl: Add bindings for Actions S500 SoC

On Sat, Aug 01, 2020 at 08:16:06PM +0530, Manivannan Sadhasivam wrote: > Hi, > > On Fri, Jun 26, 2020 at 04:06:41PM +0300, Cristian Ciocaltea wrote: > > On Fri, Jun 26, 2020 at 12:50:46PM +0530, Manivannan Sadhasivam wrote: > > > > > > > > > On 26 June 2020 1:46:18 AM IST, Cristian Ciocaltea >

[PATCH] iommu/vt-d:Add support for ACPI device in RMRR

Some ACPI devices require access to the specified reserved memory region.BIOS report the specified reserved memory region through RMRR structures.Add analysis of ACPI device in RMRR and establish identity mapping for ACPI device. Reported-by: kernel test robot Signed-off-by: FelixCuioc ---

Proposal

Dear Sir, Madam, Proposal I am Mr.John Woods, a Consultant with the Department of Power and Steel here in Spain . I have been contracted by a wealthy individual and serving government official from somewhere in Africa who is interested in engaging your services for investment of a large

[GIT PULL] Final KVM changes for Linux 5.8

Linus, The following changes since commit 3d9fdc252b52023260de1d12399cb3157ed28c07: KVM: MIPS: Fix build errors for 32bit kernel (2020-07-10 06:15:38 -0400) are available in the Git repository at: https://git.kernel.org/pub/scm/virt/kvm/kvm.git tags/for-linus for you to fetch changes up

[PATCH] scsi: qla4xxx: Fix an error handling path in 'qla4xxx_get_host_stats()'

Update the size used in 'dma_free_coherent()' in order to match the one used in the corresponding 'dma_alloc_coherent()'. Fixes: 4161cee52df8 ("[SCSI] qla4xxx: Add host statistics support") Signed-off-by: Christophe JAILLET --- drivers/scsi/qla4xxx/ql4_os.c | 2 +- 1 file changed, 1

RE: [RESEND PATCH v5] mm/zswap: move to use crypto_acomp API for hardware acceleration

> > Subject: [RESEND PATCH v5] mm/zswap: move to use crypto_acomp API for > > hardware acceleration > > > > Right now, all new ZIP drivers are adapted to crypto_acomp APIs rather than > > legacy crypto_comp APIs. Tradiontal ZIP drivers like lz4,lzo etc have been > > also > > wrapped into acomp

Re: [PATCH v6 1/3] devres: provide devm_krealloc()

On Sun, Aug 2, 2020 at 11:37 AM Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski > > Implement the managed variant of krealloc(). This function works with > all memory allocated by devm_kmalloc() (or devres functions using it > implicitly like devm_kmemdup(), devm_kstrdup() etc.). > >

Re: sparse warnings in vop

On Sun, Aug 2, 2020 at 9:25 AM Andy Shevchenko wrote: > On Sunday, August 2, 2020, Michael S. Tsirkin wrote: >> >> Hi! >> Building vop with make C=1 produces the following: >> >> CHECK drivers/misc/mic/vop/vop_main.c >> drivers/misc/mic/vop/vop_main.c:551:58: warning: incorrect type in

powerpc: build failures in Linus' tree

Hi all, We are getting build failures in some PowerPC configs for Linus' tree. See e.g. http://kisskb.ellerman.id.au/kisskb/buildresult/14306515/ In file included from /kisskb/src/arch/powerpc/include/asm/paca.h:18, from /kisskb/src/arch/powerpc/include/asm/percpu.h:13,

Re: [serial] 679193b7ba: BUG:spinlock_bad_magic_on_CPU

On Sun, Aug 2, 2020 at 8:54 AM kernel test robot wrote: > > Greeting, > > FYI, we noticed the following commit (built with gcc-9): > > commit: 679193b7baf8d88e41cbeb397ca17f797654947d ("serial: 8250: Let serial > core initialise spin lock") >

Re: [serial] 679193b7ba: BUG:spinlock_bad_magic_on_CPU

On Sun, Aug 02, 2020 at 01:50:29PM +0300, Andy Shevchenko wrote: > On Sun, Aug 2, 2020 at 8:54 AM kernel test robot wrote: > > > > Greeting, > > > > FYI, we noticed the following commit (built with gcc-9): > > > > commit: 679193b7baf8d88e41cbeb397ca17f797654947d ("serial: 8250: Let serial > >

[PATCH] include: Modify parameters that are not used in __local_bh_disable_ip()

Signed-off-by: leesagacious --- include/linux/bottom_half.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/linux/bottom_half.h b/include/linux/bottom_half.h index ab54f34..edcdf3fa 100644 --- a/include/linux/bottom_half.h +++ b/include/linux/bottom_half.h @@ -7,7

Re: [PATCH 2/2] mm, util: account_locked_vm() does not hold mmap_lock

On Wed, 29 Jul 2020 12:21:11 -0700 (PDT) Hugh Dickins wrote: Sorry for the late reply. > On Sun, 26 Jul 2020, Pengfei Li wrote: > > > Since mm->locked_vm is already an atomic counter, > > account_locked_vm() does not need to hold mmap_lock. > > I am worried that this patch, already added to

[PATCH] scsi: qla2xxx: Fix the size used in a 'dma_free_coherent()' call

Update the size used in 'dma_free_coherent()' in order to match the one used in the corresponding 'dma_alloc_coherent()'. While at it, remove a memset after a call to 'dma_alloc_coherent()'. This is useless since commit 518a2f1925c3 ("dma-mapping: zero memory returned from dma_alloc_*") Fixes:

Re: [PATCH 4/4] mm/thp: narrow lru locking

You're playing games with separating interrupt disabling from spinlocks. Have you got any feedback from -rt people on this? On Sat, Aug 01, 2020 at 12:09:17PM +0800, Alex Shi wrote: > lru_lock and page cache xa_lock have no reason with current sequence, > put them together isn't necessary.

linux-next: Fixes tags need some work in the kvm-fixes tree

Hi all, In commit 830f01b089b1 ("KVM: SVM: Fix disable pause loop exit/pause filtering capability on SVM") Fixes tag Fixes: 8566ac8b ("KVM: SVM: Implement pause loop exit logic in SVM") has these problem(s): - SHA1 should be at least 12 digits long Can be fixed by setting

[PATCH] drm/i915: Fix wrong return value in intel_atomic_check()

In the case of calling check_digital_port_conflicts() failed, a negative error code -EINVAL should be returned. Fixes: bf5da83e4bd80 ("drm/i915: Move check_digital_port_conflicts() earier") Cc: Ville Syrjälä Signed-off-by: Tianjia Zhang --- drivers/gpu/drm/i915/display/intel_display.c | 2 +-

[PATCH] scsi: csiostor: Fix wrong return value in csio_hw_prep_fw()

On an error exit path, a negative error code should be returned instead of a positive return value. Fixes: f40e74ffa3de4 ("csiostor:firmware upgrade fix") Cc: Praveen Madhavan Signed-off-by: Tianjia Zhang --- drivers/scsi/csiostor/csio_hw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH] nvme-fc: Fix wrong return value in __nvme_fc_init_request()

On an error exit path, a negative error code should be returned instead of a positive return value. Fixes: e399441de9115 ("nvme-fabrics: Add host support for FC transport") Cc: James Smart Signed-off-by: Tianjia Zhang --- drivers/nvme/host/fc.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH] s390/pkey: Remove redundant variable initialization

In the first place, the initialization value of `rc` is wrong. It is unnecessary to initialize `rc` variables, so remove their initialization operation. Fixes: f2bbc96e7cfad ("s390/pkey: add CCA AES cipher key support") Cc: Harald Freudenberger Signed-off-by: Tianjia Zhang ---

[PATCH] scsi: qla2xxx: Fix wrong return value in qla_nvme_register_hba()

On an error exit path, a negative error code should be returned instead of a positive return value. Fixes: 8777e4314d397 ("scsi: qla2xxx: Migrate NVME N2N handling into state machine") Cc: Quinn Tran Signed-off-by: Tianjia Zhang --- drivers/scsi/qla2xxx/qla_nvme.c | 2 +- 1 file changed, 1

[PATCH] scsi: qla2xxx: Remove redundant variable initialization

The initialization value of `rc` is wrong. It is unnecessary to initialize `rc` variables, so remove its initialization operation. Fixes: 84905dfe78d28 ("scsi: qla2xxx: Fix TMF and Multi-Queue config") Cc: Quinn Tran Signed-off-by: Tianjia Zhang --- drivers/scsi/qla2xxx/qla_target.c | 2 +- 1

[PATCH] scsi: qla2xxx: Fix wrong return value in qlt_chk_unresolv_exchg()

In the case of a failed retry, a positive value EIO is returned here. I think this is a typo error. It is necessary to return an error value. Fixes: 0691094ff3f2c ("scsi: qla2xxx: Add logic to detect ABTS hang and response completion") Cc: Quinn Tran Signed-off-by: Tianjia Zhang ---

[PATCH] tools/bpf/bpftool: Fix wrong return value in do_dump()

In case of btf_id does not exist, a negative error code -ENOENT should be returned. Fixes: c93cc69004df3 ("bpftool: add ability to dump BTF types") Cc: Andrii Nakryiko Signed-off-by: Tianjia Zhang --- tools/bpf/bpftool/btf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] liquidio: Fix wrong return value in cn23xx_get_pf_num()

On an error exit path, a negative error code should be returned instead of a positive return value. Fixes: 0c45d7fe12c7e ("liquidio: fix use of pf in pass-through mode in a virtual machine") Cc: Rick Farrington Signed-off-by: Tianjia Zhang ---

[PATCH] clocksource/h8300_timer8: Fix wrong return value in h8300_8timer_init()

In the case of calling of_iomap() failed, a positive value ENXIO is returned here. I think this is a typo error. It is necessary to return a negative error value. Fixes: 691f8f878290f ("clocksource/drivers/h8300_timer8: Convert init function to return error") Cc: Daniel Lezcano Signed-off-by:

[PATCH] crypto: mediatek - Fix wrong return value in mtk_desc_ring_alloc()

In case of memory allocation failure, a negative error code should be returned. Fixes: 785e5c616c849 ("crypto: mediatek - Add crypto driver support for some MediaTek chips") Cc: Ryder Lee Signed-off-by: Tianjia Zhang --- drivers/crypto/mediatek/mtk-platform.c | 4 ++-- 1 file changed, 2

[PATCH] drm/i915: Fix wrong return value

In function i915_active_acquire_preallocate_barrier(), not all paths have the return value set correctly, and in case of memory allocation failure, a negative error code should be returned. Cc: Chris Wilson Signed-off-by: Tianjia Zhang --- drivers/gpu/drm/i915/i915_active.c| 4 ++--

[PATCH] IB/core: Fix wrong return value in _ib_modify_qp()

On an error exit path, a negative error code should be returned instead of a positive return value. Fixes: 7a5c938b9ed09 ("IB/core: Check for rdma_protocol_ib only after validating port_num") Cc: Jason Gunthorpe Signed-off-by: Tianjia Zhang --- drivers/infiniband/core/verbs.c | 2 +- 1 file

[PATCH] phy: qcom-ufs: Fix wrong return value in ufs_qcom_phy_calibrate()

On an error exit path, a negative error code should be returned instead of a positive return value. Fixes: adaafaa393ef1 ("phy: qcom-ufs: add support for QUALCOMM Technologies UFS PHY drivers") Cc: Yaniv Gardi Signed-off-by: Tianjia Zhang --- drivers/phy/qualcomm/phy-qcom-ufs.c | 4 ++-- 1

[PATCH] drm/amd/display: Fix wrong return value in dm_update_plane_state()

On an error exit path, a negative error code should be returned instead of a positive return value. Fixes: 9e869063b0021 ("drm/amd/display: Move iteration out of dm_update_planes") Cc: Leo Li Signed-off-by: Tianjia Zhang --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +-- 1 file

[PATCH] net: ethernet: aquantia: Fix wrong return value

In function hw_atl_a0_hw_multicast_list_set(), when an invalid request is encountered, a negative error code should be returned. Fixes: bab6de8fd180b ("net: ethernet: aquantia: Atlantic A0 and B0 specific functions") Cc: David VomLehn Signed-off-by: Tianjia Zhang ---

[PATCH] net/enetc: Fix wrong return value in enetc_psfp_parse_clsflower()

In the case of invalid rule, a positive value EINVAL is returned here. I think this is a typo error. It is necessary to return an error value. Cc: Po Liu Signed-off-by: Tianjia Zhang --- drivers/net/ethernet/freescale/enetc/enetc_qos.c | 8 1 file changed, 4 insertions(+), 4

Re: [serial] 679193b7ba: BUG:spinlock_bad_magic_on_CPU

On Sun, Aug 2, 2020 at 1:58 PM Greg Kroah-Hartman wrote: > On Sun, Aug 02, 2020 at 01:50:29PM +0300, Andy Shevchenko wrote: > > On Sun, Aug 2, 2020 at 8:54 AM kernel test robot wrote: ... > > > If you fix the issue, kindly add following tag > > > Reported-by: kernel test robot > > > > Thanks

Re: [PATCH 2/2] mm, util: account_locked_vm() does not hold mmap_lock

On Thu, 30 Jul 2020 16:57:05 -0400 Daniel Jordan wrote: > On Wed, Jul 29, 2020 at 12:21:11PM -0700, Hugh Dickins wrote: > > On Sun, 26 Jul 2020, Pengfei Li wrote: > > > > > Since mm->locked_vm is already an atomic counter, > > > account_locked_vm() does not need to hold mmap_lock. > > > > I am

Re: [PATCH] drm/i915: Fix wrong return value

Hi Tianjia, > diff --git a/drivers/gpu/drm/i915/i915_active.c > b/drivers/gpu/drm/i915/i915_active.c > index d960d0be5bd2..cc017e3cc9c5 100644 > --- a/drivers/gpu/drm/i915/i915_active.c > +++ b/drivers/gpu/drm/i915/i915_active.c > @@ -758,7 +758,7 @@ int

Re: [Intel-gfx] [PATCH] drm/i915: Fix wrong return value

Quoting Andi Shyti (2020-08-02 12:40:44) > Hi Tianjia, > > > diff --git a/drivers/gpu/drm/i915/i915_active.c > > b/drivers/gpu/drm/i915/i915_active.c > > index d960d0be5bd2..cc017e3cc9c5 100644 > > --- a/drivers/gpu/drm/i915/i915_active.c > > +++ b/drivers/gpu/drm/i915/i915_active.c > > @@

Re: Should perf version match kernel version?

Hi! > > >We strive to have it all compatible, older perf should work on newer > > >kernel and newer perf should work on older kernel. > > > > > >How well it's all tested is another. > > > > > >Personally I often use a very old perf. > > > > Yeah, never was a requirement, if you find some problem

Re: [PATCH 0/6] Add TI PRUSS platform driver

Hi! > A typical usage scenario would be to load the application firmware into one or > more of the PRU cores, initialize one or more of the peripherals and perform > I/O > through shared RAM from either a kernel driver or directly from userspace. > > This series contains the PRUSS platform

Re: [PATCH v18 3/3] Input: new da7280 haptic driver

Hi! > > +static DEVICE_ATTR_RW(ps_seq_id); > > +static DEVICE_ATTR_RW(ps_seq_loop); > > +static DEVICE_ATTR_RW(gpi_seq_id0); > > +static DEVICE_ATTR_RW(gpi_seq_id1); > > +static DEVICE_ATTR_RW(gpi_seq_id2); > > +static DEVICE_ATTR_WO(patterns); > > Should this be a binary attribute instead of

Re: [RFC PATCH v5 00/11] Integrity Policy Enforcement LSM (IPE)

Hi! > IPE is a Linux Security Module which allows for a configurable > policy to enforce integrity requirements on the whole system. It > attempts to solve the issue of Code Integrity: that any code being > executed (or files being read), are identical to the version that > was built by a trusted

Re: [PATCH v1 0/4] [RFC] Implement Trampoline File Descriptor

Hi! > > This is quite clever, but now I???m wondering just how much kernel help > > is really needed. In your series, the trampoline is an non-executable > > page. I can think of at least two alternative approaches, and I'd > > like to know the pros and cons. > > > > 1. Entirely userspace: a

Re: [PATCH 0/6] Add TI PRUSS platform driver

On Sun 2020-08-02 13:53:30, Pavel Machek wrote: > Hi! > > > A typical usage scenario would be to load the application firmware into one > > or > > more of the PRU cores, initialize one or more of the peripherals and > > perform I/O > > through shared RAM from either a kernel driver or directly

Re: [PATCH v4 1/4] power: supply: core: add quick charge type property

On Mon 2020-07-20 13:47:14, Qiwu Huang wrote: > From: Qiwu Huang > > Reports the kind of quick charge type based on > different adapter power. > > Signed-off-by: Qiwu Huang > --- > Documentation/ABI/testing/sysfs-class-power | 21 + >

Re: [PATCH] MAINTAINERS: mark usbvision as obsolete

On Sun 2020-07-19 23:16:08, B K Karthik wrote: > mark staging/media/usbvision as obsolete so > checkpatch tells people not to send patches. Umm... that's not right. If we do not want people to fix it, it should not be in stagging -- it should be dropped.

Re: [PATCH v4 0/2] Syscall User Redirection

Hi! > This is v4 of Syscall User Redirection. The implementation itself is > not modified from v3, it only applies the latest round of reviews to the > selftests. > > __NR_syscalls is not really exported in header files other than > asm-generic for every architecture, so it felt safer to

[PATCH] mm/percpu.c: Modify size of populated bitmap of chunk for memory allocation

From: Sunghyun Jin Variable populated, which is a member of struct pcpu_chunk, is used as a unit of size of unsigned long in below code: ``` 1142 /* manage populated page bitmap */ 1143 chunk->immutable = true; 1144 bitmap_fill(chunk->populated, chunk->nr_pages); ``` ```

[PATCH] ath10k: Fix the size used in a 'dma_free_coherent()' call in an error handling path

Update the size used in 'dma_free_coherent()' in order to match the one used in the corresponding 'dma_alloc_coherent()'. Fixes: 1863008369ae ("ath10k: fix shadow register implementation for WCN3990") Signed-off-by: Christophe JAILLET --- This patch looks obvious to me, but commit 1863008369ae

Re: [PATCH v4 1/4] power: supply: core: add quick charge type property

On Sun, Aug 02, 2020 at 02:00:15PM +0200, Pavel Machek wrote: > On Mon 2020-07-20 13:47:14, Qiwu Huang wrote: > > From: Qiwu Huang > > > > Reports the kind of quick charge type based on > > different adapter power. > > > > Signed-off-by: Qiwu Huang > > --- > >

[PATCH] staging: rtl8723bs: replace rtw_netdev_priv define with inline function

The function guarantees type checking of arguments and return value. Result of rtw_netdev_priv macro can be assigned to pointer with incompatible type without warning. The function allow compiler to perform this check. Signed-off-by: Ivan Safonov ---

Re: [PATCH v2 1/2] MAINTAINERS: Remove JZ4780 DMA driver entry

On Sun, 2 Aug 2020, Paul Cercueil wrote: > > FYI, the usual approach would be marking the entry "Orphan" rather > > than > > removing it entirely, so that the mapping remains and makes it easy > > for > > someone to pick it up. > > This is OK in this case, as the driver is also listed as part

Re: [PATCH] clocksource/h8300_timer8: Fix wrong return value in h8300_8timer_init()

On 02/08/2020 13:15, Tianjia Zhang wrote: > In the case of calling of_iomap() failed, a positive value ENXIO is > returned here. I think this is a typo error. It is necessary to return > a negative error value. Yes, it is. Applied, thanks for the fix. -- Daniel --

[PATCH] mm, memory_hotplug: update pcp lists everytime onlining a memory block

When onlining a first memory block in a zone, pcp lists are not updated thus pcp struct will have the default setting of ->high = 0,->batch = 1. This means till the second memory block in a zone(if it have) is onlined the pcp lists of this zone will not contain any pages because pcp's ->count is

[PATCH] net: vmxnet3: avoid accessing the data mapped to streaming DMA

In vmxnet3_probe_device(), "adapter" is mapped to streaming DMA: adapter->adapter_pa = dma_map_single(..., adapter, ...); Then "adapter" is accessed at many places in this function. Theses accesses may cause data inconsistency between CPU cache and hardware. To fix this problem,

Re: [PATCH 06/15] powerpc: fadamp: simplify fadump_reserve_crash_area()

Mike Rapoport writes: > On Thu, Jul 30, 2020 at 10:15:13PM +1000, Michael Ellerman wrote: >> Mike Rapoport writes: >> > From: Mike Rapoport >> > >> > fadump_reserve_crash_area() reserves memory from a specified base address >> > till the end of the RAM. >> > >> > Replace iteration through the

Re: [Intel-gfx] [PATCH] drm/i915: Fix wrong return value

> > > diff --git a/drivers/gpu/drm/i915/i915_active.c > > > b/drivers/gpu/drm/i915/i915_active.c > > > index d960d0be5bd2..cc017e3cc9c5 100644 > > > --- a/drivers/gpu/drm/i915/i915_active.c > > > +++ b/drivers/gpu/drm/i915/i915_active.c > > > @@ -758,7 +758,7 @@ int

[BUG] scsi: wd719x: accessing the data mapped to streaming DMA

In wd719x_queuecommand(), "scb" is mapped to streaming DMA:   scb->phys = dma_map_single(..., scb, ...); Then "scb" is accessed at many places in this function, such as:   scb->SCB_options |= WD719X_SCB_FLAGS_AUTO_REQUEST_SENSE;   ...   scb->data_length = 0;   scb->data_p = 0; These accesses

Re: [PATCH net-next v3 2/2] net: dsa: qca8k: Add 802.1q VLAN support

On Sat, Aug 01, 2020 at 06:06:46PM +0100, Jonathan McDowell wrote: > This adds full 802.1q VLAN support to the qca8k, allowing the use of > vlan_filtering and more complicated bridging setups than allowed by > basic port VLAN support. > > Tested with a number of untagged ports with separate VLANs

Re: [PATCH net-next v3 1/2] net: dsa: qca8k: Add define for port VID

On Sat, Aug 01, 2020 at 06:05:54PM +0100, Jonathan McDowell wrote: > Rather than using a magic value of 1 when configuring the port VIDs add > a QCA8K_PORT_VID_DEF define and use that instead. Also fix up the > bitmask in the process; the top 4 bits are reserved so this wasn't a > problem, but

Re:Re: [PATCH] soc: qmi: allow user to set handle wq to hiprio

>> Currently the qmi_handle is initialized single threaded and strictly >> ordered with the active set to 1. This is pretty simple and safe but >> sometimes ineffency. So it is better to allow user to decide whether >> a high priority workqueue should be used. > >Can you please describe a

Re: [PATCH 4/4] mm/thp: narrow lru locking

在 2020/8/2 下午7:09, Matthew Wilcox 写道: > You're playing games with separating interrupt disabling from spinlocks. > Have you got any feedback from -rt people on this? Is there other suggestions to remove local_irq_disable? Just check again on kernel/mm directory on linux-next. there are still

[PATCH] p54: avoid accessing the data mapped to streaming DMA

In p54p_tx(), skb->data is mapped to streaming DMA on line 337: mapping = pci_map_single(..., skb->data, ...); Then skb->data is accessed on line 349: desc->device_addr = ((struct p54_hdr *)skb->data)->req_id; This access may cause data inconsistency between CPU cache and hardware. To fix

Re: [PATCH] selftests/powerpc: return skip code for spectre_v2

On Tue, 28 Jul 2020 12:50:39 -0300, Thadeu Lima de Souza Cascardo wrote: > When running under older versions of qemu of under newer versions with old > machine types, some security features will not be reported to the guest. > This will lead the guest OS to consider itself Vulnerable to

Re: [PATCH 0/2] powerpc: OpenCAPI Cleanup

On Wed, 15 Apr 2020 11:23:41 +1000, Alastair D'Silva wrote: > These patches address checkpatch & kernel doc warnings > in the OpenCAPI infrastructure. > > Alastair D'Silva (2): > ocxl: Remove unnecessary externs > ocxl: Address kernel doc errors & warnings > > [...] Applied to powerpc/next.

Re: [PATCH v6 00/11] ppc64: enable kdump support for kexec_file_load syscall

On Wed, 29 Jul 2020 17:08:44 +0530, Hari Bathini wrote: > Sorry! There was a gateway issue on my system while posting v5, due to > which some patches did not make it through. Resending... > > This patch series enables kdump support for kexec_file_load system > call (kexec -s -p) on PPC64. The

  1   2   3   4   5   >