[PATCH] atm: he: Fix the size used in a 'dma_free_coherent()' call

Update the size used in 'dma_free_coherent()' in order to match the one used in the corresponding 'dma_alloc_coherent()', in 'he_init_tpdrq()'. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Christophe JAILLET --- drivers/atm/he.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH v2] brcmfmac: Set timeout value when configuring power save

Nicolas Saenz Julienne wrote: > Set the timeout value as per cfg80211's set_power_mgmt() request. If the > requested value value is left undefined we set it to 2 seconds, the > maximum supported value. > > Signed-off-by: Nicolas Saenz Julienne Patch applied to wireless-drivers-next.git,

Re: [PATCH net-next] brcm80211: fix possible memleak in brcmf_proto_msgbuf_attach

Wang Yufen wrote: > When brcmf_proto_msgbuf_attach fail and msgbuf->txflow_wq != NULL, > we should destroy the workqueue. > > Fixes: 05491d2ccf20 ("brcm80211: move under broadcom vendor directory") Moving the driver to another directory cannot have caused this bug, so I'm removing the fixes

Re: [PATCH] drivers: bcma: remove set but not used variable `addrh` and `sizeh`

Zheng Yongjun wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/bcma/scan.c: In function 'bcma_erom_get_addr_desc': > drivers/bcma/scan.c:219 warning: > variable `addrh` and `sizeh` set but not used [-Wunused-but-set-variable] > > Signed-off-by: Zheng Yongjun Patch applied

Re: [PATCH net] wl1251: fix always return 0 error

Wang Hai wrote: > wl1251_event_ps_report() should not always return 0 because > wl1251_ps_set_mode() may fail. Change it to return 'ret'. > > Fixes: f7ad1eed4d4b ("wl1251: retry power save entry") > Reported-by: Hulk Robot > Signed-off-by: Wang Hai Patch applied to wireless-drivers-next.git,

Re: [PATCH v1] airo: use generic power management

Vaibhav Gupta wrote: > Drivers using legacy power management .suspen()/.resume() callbacks > have to manage PCI states and device's PM states themselves. They also > need to take care of standard configuration registers. > > Switch to generic power management framework using a single > "struct

Re: [PATCH v2 7/9] intersil: fix wiki website url

Flavio Suligoi wrote: > In some Intersil files, the wiki url is still the old > "wireless.kernel.org" instead of the new > "wireless.wiki.kernel.org" > > Signed-off-by: Flavio Suligoi Patch applied to wireless-drivers-next.git, thanks. 4dd9e7e08bc3 intersil: fix wiki website url --

[PATCH] scsi: esas2r: fix possible buffer overflow caused by bad DMA value in esas2r_process_fs_ioctl()

In esas2r_read_fs(): struct esas2r_ioctl_fs *fs = (struct esas2r_ioctl_fs *)a->fs_api_buffer; Because "a->fs_api_buffer" is mapped to coherent DMA (allocated in esas2r_write_fs()), "fs" is also mapped to DMA. Then esas2r_read_fs() calls esas2r_process_fs_ioctl() with "fs". In

Re: [PATCH net] qtnfmac: Missing platform_device_unregister() on error in qtnf_core_mac_alloc()

Wang Hai wrote: > Add the missing platform_device_unregister() before return from > qtnf_core_mac_alloc() in the error handling case. > > Fixes: 616f5701f4ab ("qtnfmac: assign each wiphy to its own virtual platform > device") > Reported-by: Hulk Robot > Signed-off-by: Wang Hai > Reviewed-by:

Re: memory leak in veth_dev_init

syzbot has found a reproducer for the following issue on: HEAD commit:ac3a0c84 Merge git://git.kernel.org/pub/scm/linux/kernel/g.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=156db21490 kernel config:

Re: [PATCH 1/2] ipw2100: Use GFP_KERNEL instead of GFP_ATOMIC in some memory allocation

Christophe JAILLET wrote: > The call chain is: >ipw2100_pci_init_one(the probe function) > --> ipw2100_queues_allocate >--> ipw2100_tx_allocate > > No lock is taken in the between. > So it is safe to use GFP_KERNEL in 'ipw2100_tx_allocate()'. > > BTW,

Re: [PATCH 2/3] pinctrl: actions: Add Actions S500 pinctrl driver

Hi, Sorry for the delay. This has fallen through the cracks... On Fri, Jun 26, 2020 at 08:11:48PM +0300, Cristian Ciocaltea wrote: > On Fri, Jun 26, 2020 at 07:59:41PM +0530, Manivannan Sadhasivam wrote: > > On Thu, Jun 25, 2020 at 11:16:19PM +0300, Cristian Ciocaltea wrote: > > > Add pinctrl

Re: [PATCH v1] hostap: use generic power management

Vaibhav Gupta wrote: > Drivers using legacy power management .suspen()/.resume() callbacks > have to manage PCI states and device's PM states themselves. They also > need to take care of standard configuration registers. > > Switch to generic power management framework using a single > "struct

RE: [PATCH] cpufreq: intel_pstate: Implement passive mode with HWP enabled

Hi Rafael, On 2020.07.19 04:43 Rafael J. Wysocki wrote: > On Fri, Jul 17, 2020 at 3:37 PM Doug Smythies wrote: > > On 2020.07.16 05:08 Rafael J. Wysocki wrote: > > > On Wed, Jul 15, 2020 at 10:39 PM Doug Smythies > > > wrote: > > >> On 2020.07.14 11:16 Rafael J. Wysocki wrote: > > >> > > > >>

Re: [PATCH for v5.9] b43legacy: Replace HTTP links with HTTPS ones

"Alexander A. Klimov" wrote: > Rationale: > Reduces attack surface on kernel devs opening the links for MITM > as HTTPS traffic is much harder to manipulate. > > Deterministic algorithm: > For each file: > If not .svg: > For each line: > If doesn't contain `\bxmlns\b`: > For

Re: [PATCH for v5.9] b43: Replace HTTP links with HTTPS ones

"Alexander A. Klimov" wrote: > Rationale: > Reduces attack surface on kernel devs opening the links for MITM > as HTTPS traffic is much harder to manipulate. > > Deterministic algorithm: > For each file: > If not .svg: > For each line: > If doesn't contain `\bxmlns\b`: > For

Re: [PATCH] ipw2x00: Replace HTTP links with HTTPS ones

"Alexander A. Klimov" wrote: > Rationale: > Reduces attack surface on kernel devs opening the links for MITM > as HTTPS traffic is much harder to manipulate. > > Deterministic algorithm: > For each file: > If not .svg: > For each line: > If doesn't contain `\bxmlns\b`: > For

Re: [PATCH v1] rt2x00: pci: use generic power management

Vaibhav Gupta wrote: > Drivers using legacy PM have to manage PCI states and device's PM states > themselves. They also need to take care of configuration registers. > > With improved and powerful support of generic PM, PCI Core takes care of > above mentioned, device-independent, jobs. > >

Re: [PATCH] mt7601u: add missing release on skb in mt7601u_mcu_msg_send

Navid Emamdoost wrote: > In the implementation of mt7601u_mcu_msg_send(), skb is supposed to be > consumed on all execution paths. Release skb before returning if > test_bit() fails. > > Signed-off-by: Navid Emamdoost > Acked-by: Jakub Kicinski Patch applied to wireless-drivers-next.git,

Re: [PATCH -next] mt7601u: Convert to DEFINE_SHOW_ATTRIBUTE

Qinglang Miao wrote: > Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code. > > Signed-off-by: Qinglang Miao > Acked-by: Jakub Kicinski Fails to apply to wireless-drivers-next: fatal: sha1 information is lacking or useless (drivers/net/wireless/mediatek/mt7601u/debugfs.c). error: could

[PATCH] atm: idt77252: Fix the size used in a 'dma_alloc_coherent()' call

This should be TSQSIZE in order to be consistent with the surrounding code and the corresponding 'dma_free_coherent()' in 'deinit_tsq()' This is harmless because RSQSIZE and TSQSIZE have the same value (i.e. 8192) Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Christophe JAILLET ---

Re: [RFC PATCH] iwlwifi: yoyo: don't print failure if debug firmware is missing

Wolfram Sang wrote: > Missing this firmware is not fatal, my wifi card still works. Even more, > I couldn't find any documentation what it is or where to get it. So, I > don't think the users should be notified if it is missing. If you browse > the net, you see the message is present is in quite

Re: [IB/srpt] c804af2c1d: last_state.test.blktests.exit_code.143

On 2020-08-01 23:09, kernel test robot wrote: > Greeting, > > FYI, we noticed the following commit (built with gcc-9): > > commit: c804af2c1d3152c0cf877eeb50d60c2d49ac0cf0 ("IB/srpt: use new shared CQ > mechanism") > https://git.kernel.org/cgit/linux/kernel/git/rdma/rdma.git for-next > > > in

Re: [PATCH] iio: trigger: sysfs: Disable irqs before calling iio_trigger_poll()

On 8/1/20 6:02 PM, Jonathan Cameron wrote: On Mon, 27 Jul 2020 16:57:13 +0200 Christian Eggers wrote: iio_trigger_poll() calls generic_handle_irq(). This function expects to be run with local IRQs disabled. Was there an error or warning that lead to this patch? Or can you point to what call

[PATCH] staging: wfx: clear alignment style issues

Clear checkpatch alignment style issues in debug.c. CHECK: Alignment should match open parenthesis Signed-off-by: Tomer Samara --- drivers/staging/wfx/debug.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/wfx/debug.c b/drivers/staging/wfx/debug.c index

Re: [PATCH] prism54: switch from 'pci_' to 'dma_' API

Christophe JAILLET wrote: > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GFP_ with a correct flag. > It has been compile tested. > > When memory is allocated in

Re: [PATCH v1] prism54: islpci_hotplug: use generic power management

Vaibhav Gupta wrote: > Drivers using legacy power management .suspen()/.resume() callbacks > have to manage PCI states and device's PM states themselves. They also > need to take care of standard configuration registers. > > Switch to generic power management framework using a single > "struct

[PATCH] Staging: rtl8192e: fix indent coding style issue in rtllib_tx.c

This is a patch to the rtllib_tx.c file that fixes fixes an improper indent found by the checkpatch.pl tool Signed-off-by: Mohammed Rushad --- drivers/staging/rtl8192e/rtllib_tx.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/rtl8192e/rtllib_tx.c

Re: WARNING: refcount bug in do_enable_set

syzbot has found a reproducer for the following issue on: HEAD commit:ac3a0c84 Merge git://git.kernel.org/pub/scm/linux/kernel/g.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1194935c90 kernel config:

Re: [PATCH for v5.9] prism54: Replace HTTP links with HTTPS ones

"Alexander A. Klimov" wrote: > Rationale: > Reduces attack surface on kernel devs opening the links for MITM > as HTTPS traffic is much harder to manipulate. > > Deterministic algorithm: > For each file: > If not .svg: > For each line: > If doesn't contain `\bxmlns\b`: > For

Re: [PATCH] p54: switch from 'pci_' to 'dma_' API

Christophe JAILLET wrote: > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GFP_ with a correct flag. > It has been compile tested. > > When memory is allocated in

Re: [PATCH] mwifiex: 11n_rxreorder: Remove unnecessary cast in kfree()

Xu Wang wrote: > Remove unnecassary casts in the argument to kfree. > > Signed-off-by: Xu Wang Patch applied to wireless-drivers-next.git, thanks. 614946480f8f mwifiex: 11n_rxreorder: Remove unnecessary cast in kfree() -- https://patchwork.kernel.org/patch/11686265/

[PATCH] Bluetooth: btmrvl: eliminate duplicates introducing btmrvl_reg_89xx

SD89xx devices use identical card register settings. Make sure a single common instance is used to describe them. Signed-off-by: Tamás Szűcs --- drivers/bluetooth/btmrvl_sdio.c | 54 +++-- 1 file changed, 4 insertions(+), 50 deletions(-) diff --git

[PATCH] crypto: ixp4xx - Fix the size used in a 'dma_free_coherent()' call

Update the size used in 'dma_free_coherent()' in order to match the one used in the corresponding 'dma_alloc_coherent()', in 'setup_crypt_desc()'. Fixes: 81bef0150074 ("crypto: ixp4xx - Hardware crypto support for IXP4xx CPUs") Signed-off-by: Christophe JAILLET ---

Re: [PATCH 0/4] Checkpatch tool errors clean up

On Sat, 1 Aug 2020, Joe Perches wrote: > On Sat, 2020-08-01 at 19:45 +0100, Jules Irenge wrote: > > Hi > > I am proposing these 4 patches. > > I am currently learning the core kernel the hard way. > > I will appreciate any feedback negative or positive. > > Thanks > > Generally, whitespace

Re: [RFC PATCH 00/17] Drop uses of pci_read_config_*() return value

On 8/1/20 5:56 AM, Borislav Petkov wrote: > On Sat, Aug 01, 2020 at 01:24:29PM +0200, Saheed O. Bolarinwa wrote: >> The return value of pci_read_config_*() may not indicate a device error. >> However, the value read by these functions is more likely to indicate >> this kind of error. This

Re: [PATCH] rtlwifi: btcoex: remove redundant initialization of variables ant_num and single_ant_path

Colin King wrote: > From: Colin Ian King > > The variables ant_num and single_ant_path are being initialized with a > value that is never read and are being updated later with a new value. > The initializations are redundant and can be removed. > > Addresses-Coverity: ("Unused value") >

[BUG] crypto: hisilicon: accessing the data mapped to streaming DMA

In qm_qp_ctx_cfg(), "sqc" and "aeqc" are mapped to streaming DMA:   eqc_dma = dma_map_single(..., eqc, ...);   ..   aeqc_dma = dma_map_single(..., aeqc, ...); Then "sqc" and "aeqc" are accessed at many places, such as:   eqc->base_l = cpu_to_le32(lower_32_bits(qm->eqe_dma));   eqc->base_h =

[BUG] crypto: qat: accessing the data mapped to streaming DMA

In qat_alg_sgl_to_bufl(), "bufl" and "buflout" are mapped to streaming DMA:   blp = dma_map_single(dev, bufl, sz, DMA_TO_DEVICE);   bloutp = dma_map_single(dev, buflout, sz_out, DMA_TO_DEVICE); Then "bufl" and "buflout" are accessed at some places, such as:   bufl->bufers[y].len = sg->length;  

Re: [PATCH 2/4] audit: uninitialize global variable audit_sig_sid

On Sat, 1 Aug 2020, Joe Perches wrote: > On Sat, 2020-08-01 at 19:46 +0100, Jules Irenge wrote: > > Checkpatch tool reports an error at variable audit_sig_sid declaration > [] > > diff --git a/kernel/audit.c b/kernel/audit.c > [] > > @@ -125,7 +125,7 @@ static u32 audit_backlog_wait_time

Re: [RFC PATCH v5 00/11] Integrity Policy Enforcement LSM (IPE)

On Sun 2020-08-02 10:03:00, Sasha Levin wrote: > On Sun, Aug 02, 2020 at 01:55:45PM +0200, Pavel Machek wrote: > >Hi! > > > >>IPE is a Linux Security Module which allows for a configurable > >>policy to enforce integrity requirements on the whole system. It > >>attempts to solve the issue of Code

Re: [PATCH v4 1/4] power: supply: core: add quick charge type property

On Sun 2020-08-02 14:37:42, Greg KH wrote: > On Sun, Aug 02, 2020 at 02:00:15PM +0200, Pavel Machek wrote: > > On Mon 2020-07-20 13:47:14, Qiwu Huang wrote: > > > From: Qiwu Huang > > > > > > Reports the kind of quick charge type based on > > > different adapter power. > > > > > >

[BUG] net: rocker: accessing the data mapped to streaming DMA

In rocker_dma_test_offset(), "buf" is mapped to streaming DMA on line 203:   dma_handle = pci_map_single(..., buf, ...); Then, "buf" is accessed on line 229:   expect[i] = ~buf[i]; This access may cause data inconsistency between CPU cache and hardware. I am not sure how to properly fix this

[PATCH] ieee802154/adf7242: check status of adf7242_read_reg

From: Tom Rix Clang static analysis reports this error adf7242.c:887:6: warning: Assigned value is garbage or undefined len = len_u8; ^ ~~ len_u8 is set in adf7242_read_reg(lp, 0, _u8); When this call fails, len_u8 is not set. So check the return code. Fixes:

[PATCH] gve: Fix the size used in a 'dma_free_coherent()' call

Update the size used in 'dma_free_coherent()' in order to match the one used in the corresponding 'dma_alloc_coherent()'. Fixes: 893ce44df5 ("gve: Add basic driver framework for Compute Engine Virtual NIC") Signed-off-by: Christophe JAILLET --- drivers/net/ethernet/google/gve/gve_adminq.c | 2

RE: [PATCH v4 2/2] cpufreq: intel_pstate: Implement passive mode with HWP enabled

On 2020.08.01 16:41 Srinivas Pandruvada wrote: > On Tue, 2020-07-28 at 17:13 +0200, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > > > Allow intel_pstate to work in the passive mode with HWP enabled and > > make it set the HWP minimum performance limit (HWP floor) to the > > P-state

Re: [RFC PATCH v5 00/11] Integrity Policy Enforcement LSM (IPE)

On Sun, Aug 02, 2020 at 01:55:45PM +0200, Pavel Machek wrote: Hi! IPE is a Linux Security Module which allows for a configurable policy to enforce integrity requirements on the whole system. It attempts to solve the issue of Code Integrity: that any code being executed (or files being read),

RE: [PATCH v4 0/2] cpufreq: intel_pstate: Implement passive mode with HWP enabled

On 2020.08.01 09:40 Srinivas Pandruvada wrote: >> On Monday, July 27, 2020 5:13:40 PM CEST Rafael J. Wysocki wrote: >>> On Thursday, July 16, 2020 7:37:04 PM CEST Rafael J. Wysocki wrote: This really is a v2 of this patch: https://patchwork.kernel.org/patch/11663271/ with

Re: [PATCH v1 0/4] [RFC] Implement Trampoline File Descriptor

* Madhavan T. Venkataraman: > Standardization > - > > Trampfd is a framework that can be used to implement multiple > things. May be, a few of those things can also be implemented in > user land itself. But I think having just one mechanism to execute > dynamic code objects is

[PATCH] kbuild: remove redundant FORCE definition in scripts/Makefile.modpost

The same code exists a few lines above. Fixes: 436b2ac603d5 ("modpost: invoke modpost only when input files are updated") Signed-off-by: Masahiro Yamada --- scripts/Makefile.modpost | 3 --- 1 file changed, 3 deletions(-) diff --git a/scripts/Makefile.modpost b/scripts/Makefile.modpost index

[PATCH 2/2] net: spider_net: Remove a useless memset

Avoid a memset after a call to 'dma_alloc_coherent()'. This is useless since commit 518a2f1925c3 ("dma-mapping: zero memory returned from dma_alloc_*") Signed-off-by: Christophe JAILLET --- NOT compile tested, because I don't have the configuration for that ---

[PATCH 1/2] net: spider_net: Fix the size used in a 'dma_free_coherent()' call

Update the size used in 'dma_free_coherent()' in order to match the one used in the corresponding 'dma_alloc_coherent()', in 'spider_net_init_chain()'. Fixes: d4ed8f8d1fb7 ("Spidernet DMA coalescing") Signed-off-by: Christophe JAILLET --- NOT compile tested, because I don't have the

[PATCH] net: sgi: ioc3-eth: Fix the size used in some 'dma_free_coherent()' calls

Update the size used in 'dma_free_coherent()' in order to match the one used in the corresponding 'dma_alloc_coherent()'. Fixes: 369a782af0f1 ("net: sgi: ioc3-eth: ensure tx ring is 16k aligned.") Signed-off-by: Christophe JAILLET --- drivers/net/ethernet/sgi/ioc3-eth.c | 4 ++-- 1 file

Re: [net-next PATCH] net: phy: mdio-mvusb: select MDIO_DEVRES in Kconfig

On Sun, Aug 02, 2020 at 09:49:53AM +0200, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski > > PHYLIB is not selected by the mvusb driver but it uses mdio devres > helpers. Explicitly select MDIO_DEVRES in this driver's Kconfig entry. > > Reported-by: kernel test robot > Fixes:

Re: [PATCH] powerpc: fix function annotations to avoid section mismatch warnings with gcc-10

On Wed, 29 Jul 2020 15:37:41 +0200, Vladis Dronov wrote: > Certain warnings are emitted for powerpc code when building with a gcc-10 > toolset: > > WARNING: modpost: vmlinux.o(.text.unlikely+0x377c): Section mismatch in > reference from the function remove_pmd_table() to the function >

Re: [PATCH v3 0/3] cpuidle-pseries: Parse extended CEDE information for idle.

On Thu, 30 Jul 2020 11:02:54 +0530, Gautham R. Shenoy wrote: > This is a v3 of the patch series to parse the extended CEDE > information in the pseries-cpuidle driver. > > The previous two versions of the patches can be found here: > > v2: >

Re: [PATCH v6 00/11] ppc64: enable kdump support for kexec_file_load syscall

On Wed, 29 Jul 2020 17:08:44 +0530, Hari Bathini wrote: > Sorry! There was a gateway issue on my system while posting v5, due to > which some patches did not make it through. Resending... > > This patch series enables kdump support for kexec_file_load system > call (kexec -s -p) on PPC64. The

Re: [PATCH] selftests/powerpc: return skip code for spectre_v2

On Tue, 28 Jul 2020 12:50:39 -0300, Thadeu Lima de Souza Cascardo wrote: > When running under older versions of qemu of under newer versions with old > machine types, some security features will not be reported to the guest. > This will lead the guest OS to consider itself Vulnerable to

Re: [PATCH 0/2] powerpc: OpenCAPI Cleanup

On Wed, 15 Apr 2020 11:23:41 +1000, Alastair D'Silva wrote: > These patches address checkpatch & kernel doc warnings > in the OpenCAPI infrastructure. > > Alastair D'Silva (2): > ocxl: Remove unnecessary externs > ocxl: Address kernel doc errors & warnings > > [...] Applied to powerpc/next.

[PATCH] p54: avoid accessing the data mapped to streaming DMA

In p54p_tx(), skb->data is mapped to streaming DMA on line 337: mapping = pci_map_single(..., skb->data, ...); Then skb->data is accessed on line 349: desc->device_addr = ((struct p54_hdr *)skb->data)->req_id; This access may cause data inconsistency between CPU cache and hardware. To fix

Re: [PATCH 4/4] mm/thp: narrow lru locking

在 2020/8/2 下午7:09, Matthew Wilcox 写道: > You're playing games with separating interrupt disabling from spinlocks. > Have you got any feedback from -rt people on this? Is there other suggestions to remove local_irq_disable? Just check again on kernel/mm directory on linux-next. there are still

Re:Re: [PATCH] soc: qmi: allow user to set handle wq to hiprio

>> Currently the qmi_handle is initialized single threaded and strictly >> ordered with the active set to 1. This is pretty simple and safe but >> sometimes ineffency. So it is better to allow user to decide whether >> a high priority workqueue should be used. > >Can you please describe a

Re: [PATCH net-next v3 1/2] net: dsa: qca8k: Add define for port VID

On Sat, Aug 01, 2020 at 06:05:54PM +0100, Jonathan McDowell wrote: > Rather than using a magic value of 1 when configuring the port VIDs add > a QCA8K_PORT_VID_DEF define and use that instead. Also fix up the > bitmask in the process; the top 4 bits are reserved so this wasn't a > problem, but

Re: [PATCH net-next v3 2/2] net: dsa: qca8k: Add 802.1q VLAN support

On Sat, Aug 01, 2020 at 06:06:46PM +0100, Jonathan McDowell wrote: > This adds full 802.1q VLAN support to the qca8k, allowing the use of > vlan_filtering and more complicated bridging setups than allowed by > basic port VLAN support. > > Tested with a number of untagged ports with separate VLANs

[BUG] scsi: wd719x: accessing the data mapped to streaming DMA

In wd719x_queuecommand(), "scb" is mapped to streaming DMA:   scb->phys = dma_map_single(..., scb, ...); Then "scb" is accessed at many places in this function, such as:   scb->SCB_options |= WD719X_SCB_FLAGS_AUTO_REQUEST_SENSE;   ...   scb->data_length = 0;   scb->data_p = 0; These accesses

Re: [Intel-gfx] [PATCH] drm/i915: Fix wrong return value

> > > diff --git a/drivers/gpu/drm/i915/i915_active.c > > > b/drivers/gpu/drm/i915/i915_active.c > > > index d960d0be5bd2..cc017e3cc9c5 100644 > > > --- a/drivers/gpu/drm/i915/i915_active.c > > > +++ b/drivers/gpu/drm/i915/i915_active.c > > > @@ -758,7 +758,7 @@ int

Re: [PATCH 06/15] powerpc: fadamp: simplify fadump_reserve_crash_area()

Mike Rapoport writes: > On Thu, Jul 30, 2020 at 10:15:13PM +1000, Michael Ellerman wrote: >> Mike Rapoport writes: >> > From: Mike Rapoport >> > >> > fadump_reserve_crash_area() reserves memory from a specified base address >> > till the end of the RAM. >> > >> > Replace iteration through the

[PATCH] net: vmxnet3: avoid accessing the data mapped to streaming DMA

In vmxnet3_probe_device(), "adapter" is mapped to streaming DMA: adapter->adapter_pa = dma_map_single(..., adapter, ...); Then "adapter" is accessed at many places in this function. Theses accesses may cause data inconsistency between CPU cache and hardware. To fix this problem,

[PATCH] mm, memory_hotplug: update pcp lists everytime onlining a memory block

When onlining a first memory block in a zone, pcp lists are not updated thus pcp struct will have the default setting of ->high = 0,->batch = 1. This means till the second memory block in a zone(if it have) is onlined the pcp lists of this zone will not contain any pages because pcp's ->count is

Re: [PATCH] clocksource/h8300_timer8: Fix wrong return value in h8300_8timer_init()

On 02/08/2020 13:15, Tianjia Zhang wrote: > In the case of calling of_iomap() failed, a positive value ENXIO is > returned here. I think this is a typo error. It is necessary to return > a negative error value. Yes, it is. Applied, thanks for the fix. -- Daniel --

Re: [PATCH v2 1/2] MAINTAINERS: Remove JZ4780 DMA driver entry

On Sun, 2 Aug 2020, Paul Cercueil wrote: > > FYI, the usual approach would be marking the entry "Orphan" rather > > than > > removing it entirely, so that the mapping remains and makes it easy > > for > > someone to pick it up. > > This is OK in this case, as the driver is also listed as part

[PATCH] staging: rtl8723bs: replace rtw_netdev_priv define with inline function

The function guarantees type checking of arguments and return value. Result of rtw_netdev_priv macro can be assigned to pointer with incompatible type without warning. The function allow compiler to perform this check. Signed-off-by: Ivan Safonov ---

Re: [PATCH v4 1/4] power: supply: core: add quick charge type property

On Sun, Aug 02, 2020 at 02:00:15PM +0200, Pavel Machek wrote: > On Mon 2020-07-20 13:47:14, Qiwu Huang wrote: > > From: Qiwu Huang > > > > Reports the kind of quick charge type based on > > different adapter power. > > > > Signed-off-by: Qiwu Huang > > --- > >

[PATCH] ath10k: Fix the size used in a 'dma_free_coherent()' call in an error handling path

Update the size used in 'dma_free_coherent()' in order to match the one used in the corresponding 'dma_alloc_coherent()'. Fixes: 1863008369ae ("ath10k: fix shadow register implementation for WCN3990") Signed-off-by: Christophe JAILLET --- This patch looks obvious to me, but commit 1863008369ae

[PATCH] mm/percpu.c: Modify size of populated bitmap of chunk for memory allocation

From: Sunghyun Jin Variable populated, which is a member of struct pcpu_chunk, is used as a unit of size of unsigned long in below code: ``` 1142 /* manage populated page bitmap */ 1143 chunk->immutable = true; 1144 bitmap_fill(chunk->populated, chunk->nr_pages); ``` ```

Re: [PATCH v4 0/2] Syscall User Redirection

Hi! > This is v4 of Syscall User Redirection. The implementation itself is > not modified from v3, it only applies the latest round of reviews to the > selftests. > > __NR_syscalls is not really exported in header files other than > asm-generic for every architecture, so it felt safer to

Re: [PATCH] MAINTAINERS: mark usbvision as obsolete

On Sun 2020-07-19 23:16:08, B K Karthik wrote: > mark staging/media/usbvision as obsolete so > checkpatch tells people not to send patches. Umm... that's not right. If we do not want people to fix it, it should not be in stagging -- it should be dropped.

Re: [PATCH v4 1/4] power: supply: core: add quick charge type property

On Mon 2020-07-20 13:47:14, Qiwu Huang wrote: > From: Qiwu Huang > > Reports the kind of quick charge type based on > different adapter power. > > Signed-off-by: Qiwu Huang > --- > Documentation/ABI/testing/sysfs-class-power | 21 + >

Re: [PATCH 0/6] Add TI PRUSS platform driver

On Sun 2020-08-02 13:53:30, Pavel Machek wrote: > Hi! > > > A typical usage scenario would be to load the application firmware into one > > or > > more of the PRU cores, initialize one or more of the peripherals and > > perform I/O > > through shared RAM from either a kernel driver or directly

Re: [PATCH v1 0/4] [RFC] Implement Trampoline File Descriptor

Hi! > > This is quite clever, but now I???m wondering just how much kernel help > > is really needed. In your series, the trampoline is an non-executable > > page. I can think of at least two alternative approaches, and I'd > > like to know the pros and cons. > > > > 1. Entirely userspace: a

Re: [RFC PATCH v5 00/11] Integrity Policy Enforcement LSM (IPE)

Hi! > IPE is a Linux Security Module which allows for a configurable > policy to enforce integrity requirements on the whole system. It > attempts to solve the issue of Code Integrity: that any code being > executed (or files being read), are identical to the version that > was built by a trusted

Re: [PATCH v18 3/3] Input: new da7280 haptic driver

Hi! > > +static DEVICE_ATTR_RW(ps_seq_id); > > +static DEVICE_ATTR_RW(ps_seq_loop); > > +static DEVICE_ATTR_RW(gpi_seq_id0); > > +static DEVICE_ATTR_RW(gpi_seq_id1); > > +static DEVICE_ATTR_RW(gpi_seq_id2); > > +static DEVICE_ATTR_WO(patterns); > > Should this be a binary attribute instead of

Re: [PATCH 0/6] Add TI PRUSS platform driver

Hi! > A typical usage scenario would be to load the application firmware into one or > more of the PRU cores, initialize one or more of the peripherals and perform > I/O > through shared RAM from either a kernel driver or directly from userspace. > > This series contains the PRUSS platform

Re: Should perf version match kernel version?

Hi! > > >We strive to have it all compatible, older perf should work on newer > > >kernel and newer perf should work on older kernel. > > > > > >How well it's all tested is another. > > > > > >Personally I often use a very old perf. > > > > Yeah, never was a requirement, if you find some problem

Re: [Intel-gfx] [PATCH] drm/i915: Fix wrong return value

Quoting Andi Shyti (2020-08-02 12:40:44) > Hi Tianjia, > > > diff --git a/drivers/gpu/drm/i915/i915_active.c > > b/drivers/gpu/drm/i915/i915_active.c > > index d960d0be5bd2..cc017e3cc9c5 100644 > > --- a/drivers/gpu/drm/i915/i915_active.c > > +++ b/drivers/gpu/drm/i915/i915_active.c > > @@

Re: [PATCH] drm/i915: Fix wrong return value

Hi Tianjia, > diff --git a/drivers/gpu/drm/i915/i915_active.c > b/drivers/gpu/drm/i915/i915_active.c > index d960d0be5bd2..cc017e3cc9c5 100644 > --- a/drivers/gpu/drm/i915/i915_active.c > +++ b/drivers/gpu/drm/i915/i915_active.c > @@ -758,7 +758,7 @@ int

Re: [PATCH 2/2] mm, util: account_locked_vm() does not hold mmap_lock

On Thu, 30 Jul 2020 16:57:05 -0400 Daniel Jordan wrote: > On Wed, Jul 29, 2020 at 12:21:11PM -0700, Hugh Dickins wrote: > > On Sun, 26 Jul 2020, Pengfei Li wrote: > > > > > Since mm->locked_vm is already an atomic counter, > > > account_locked_vm() does not need to hold mmap_lock. > > > > I am

Re: [serial] 679193b7ba: BUG:spinlock_bad_magic_on_CPU

On Sun, Aug 2, 2020 at 1:58 PM Greg Kroah-Hartman wrote: > On Sun, Aug 02, 2020 at 01:50:29PM +0300, Andy Shevchenko wrote: > > On Sun, Aug 2, 2020 at 8:54 AM kernel test robot wrote: ... > > > If you fix the issue, kindly add following tag > > > Reported-by: kernel test robot > > > > Thanks

[PATCH] net/enetc: Fix wrong return value in enetc_psfp_parse_clsflower()

In the case of invalid rule, a positive value EINVAL is returned here. I think this is a typo error. It is necessary to return an error value. Cc: Po Liu Signed-off-by: Tianjia Zhang --- drivers/net/ethernet/freescale/enetc/enetc_qos.c | 8 1 file changed, 4 insertions(+), 4

[PATCH] drm/amd/display: Fix wrong return value in dm_update_plane_state()

On an error exit path, a negative error code should be returned instead of a positive return value. Fixes: 9e869063b0021 ("drm/amd/display: Move iteration out of dm_update_planes") Cc: Leo Li Signed-off-by: Tianjia Zhang --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +-- 1 file

[PATCH] net: ethernet: aquantia: Fix wrong return value

In function hw_atl_a0_hw_multicast_list_set(), when an invalid request is encountered, a negative error code should be returned. Fixes: bab6de8fd180b ("net: ethernet: aquantia: Atlantic A0 and B0 specific functions") Cc: David VomLehn Signed-off-by: Tianjia Zhang ---

[PATCH] clocksource/h8300_timer8: Fix wrong return value in h8300_8timer_init()

In the case of calling of_iomap() failed, a positive value ENXIO is returned here. I think this is a typo error. It is necessary to return a negative error value. Fixes: 691f8f878290f ("clocksource/drivers/h8300_timer8: Convert init function to return error") Cc: Daniel Lezcano Signed-off-by:

[PATCH] crypto: mediatek - Fix wrong return value in mtk_desc_ring_alloc()

In case of memory allocation failure, a negative error code should be returned. Fixes: 785e5c616c849 ("crypto: mediatek - Add crypto driver support for some MediaTek chips") Cc: Ryder Lee Signed-off-by: Tianjia Zhang --- drivers/crypto/mediatek/mtk-platform.c | 4 ++-- 1 file changed, 2

[PATCH] drm/i915: Fix wrong return value

In function i915_active_acquire_preallocate_barrier(), not all paths have the return value set correctly, and in case of memory allocation failure, a negative error code should be returned. Cc: Chris Wilson Signed-off-by: Tianjia Zhang --- drivers/gpu/drm/i915/i915_active.c| 4 ++--

[PATCH] IB/core: Fix wrong return value in _ib_modify_qp()

On an error exit path, a negative error code should be returned instead of a positive return value. Fixes: 7a5c938b9ed09 ("IB/core: Check for rdma_protocol_ib only after validating port_num") Cc: Jason Gunthorpe Signed-off-by: Tianjia Zhang --- drivers/infiniband/core/verbs.c | 2 +- 1 file

[PATCH] phy: qcom-ufs: Fix wrong return value in ufs_qcom_phy_calibrate()

On an error exit path, a negative error code should be returned instead of a positive return value. Fixes: adaafaa393ef1 ("phy: qcom-ufs: add support for QUALCOMM Technologies UFS PHY drivers") Cc: Yaniv Gardi Signed-off-by: Tianjia Zhang --- drivers/phy/qualcomm/phy-qcom-ufs.c | 4 ++-- 1

[PATCH] scsi: qla2xxx: Remove redundant variable initialization

The initialization value of `rc` is wrong. It is unnecessary to initialize `rc` variables, so remove its initialization operation. Fixes: 84905dfe78d28 ("scsi: qla2xxx: Fix TMF and Multi-Queue config") Cc: Quinn Tran Signed-off-by: Tianjia Zhang --- drivers/scsi/qla2xxx/qla_target.c | 2 +- 1

[PATCH] liquidio: Fix wrong return value in cn23xx_get_pf_num()

On an error exit path, a negative error code should be returned instead of a positive return value. Fixes: 0c45d7fe12c7e ("liquidio: fix use of pf in pass-through mode in a virtual machine") Cc: Rick Farrington Signed-off-by: Tianjia Zhang ---

[PATCH] s390/pkey: Remove redundant variable initialization

In the first place, the initialization value of `rc` is wrong. It is unnecessary to initialize `rc` variables, so remove their initialization operation. Fixes: f2bbc96e7cfad ("s390/pkey: add CCA AES cipher key support") Cc: Harald Freudenberger Signed-off-by: Tianjia Zhang ---

[PATCH] scsi: qla2xxx: Fix wrong return value in qla_nvme_register_hba()

On an error exit path, a negative error code should be returned instead of a positive return value. Fixes: 8777e4314d397 ("scsi: qla2xxx: Migrate NVME N2N handling into state machine") Cc: Quinn Tran Signed-off-by: Tianjia Zhang --- drivers/scsi/qla2xxx/qla_nvme.c | 2 +- 1 file changed, 1

<    1   2   3   4   5   >