[PATCH v3 10/19] dlb2: add start domain ioctl

2020-09-01 Thread Gage Eads
Once a scheduling domain and its resources have been configured, the start domain ioctl is called to enable its ports to begin enqueueing to the device. Once started, the domain's resources cannot be configured again until after the domain is reset. Signed-off-by: Gage Eads Reviewed-by: Björn

[PATCH v3 04/19] dlb2: add device ioctl layer and first three ioctls

2020-09-01 Thread Gage Eads
This commit introduces the dlb2 device ioctl layer, and the first three ioctls: query device version, query available resources, and create a scheduling domain. This commit also introduces the user-space interface file dlb2_user.h. The device version query is designed to allow each DLB device

Re: [PATCH] staging: gdm724x: gdm_tty: replaced macro with an inline function

2020-09-01 Thread kernel test robot
Hi Antoni, Thank you for the patch! Yet something to improve: [auto build test ERROR on staging/staging-testing] url: https://github.com/0day-ci/linux/commits/Antoni-Przybylik/staging-gdm724x-gdm_tty-replaced-macro-with-an-inline-function/20200901-234632 base: https://git.kernel.org/pub

[PATCH v3 17/19] dlb2: add device FLR support

2020-09-01 Thread Gage Eads
A device FLR can be triggered while applications are actively using the device, which poses two problems: - If applications continue to enqueue to the hardware they will cause hardware errors, because the FLR will have reset the scheduling domains, ports, and queues. - When the applications

[PATCH v3 16/19] dlb2: add cos bandwidth get/set ioctls

2020-09-01 Thread Gage Eads
The DLB 2.0 supports four load-balanced port classes of service (CoS). Each CoS receives a guaranteed percentage of the load-balanced scheduler's bandwidth, and any unreserved bandwidth is divided among the four CoS. These two ioctls allow applications to query CoS allocations and adjust them as

[PATCH v3 03/19] dlb2: add resource and device initialization

2020-09-01 Thread Gage Eads
This commit adds the hardware resource data structures and functions for their initialization/teardown and for device power-on. In subsequent commits, dlb2_resource.c will be expanded to hold the dlb2 resource-management and configuration logic (using the data structures defined in

[PATCH v3 08/19] dlb2: add ioctl to configure ports, query poll mode

2020-09-01 Thread Gage Eads
The port is a core's interface to the DLB, and it consists of an MMIO page (the "producer port" (PP)) through which the core enqueues a queue entry and an in-memory queue (the "consumer queue" (CQ)) to which the device schedules QEs. The driver allocates DMA memory for each port's CQ, and frees

[PATCH v3 02/19] dlb2: initialize PF device

2020-09-01 Thread Gage Eads
The driver detects the device type (PF/VF) at probe time, and assigns the corresponding 'ops' callbacks from that. These callbacks include mapping and unmapping the PCI BAR space, creating/destroying the device, and adding/deleting a char device. Signed-off-by: Gage Eads Reviewed-by: Magnus

[PATCH v3 09/19] dlb2: add port mmap support

2020-09-01 Thread Gage Eads
Once a port is created, the application can mmap the corresponding DMA memory and MMIO into user-space. This allows user-space applications to do (performance-sensitive) enqueue and dequeue independent of the kernel driver. The mmap callback is only available through special port files: a

[PATCH v3 14/19] dlb2: add domain alert support

2020-09-01 Thread Gage Eads
Domain alerts are a mechanism for the driver to asynchronously notify user-space applications of device reset or hardware alarms (both to be added in later commits). This mechanism also allows the application to enqueue an alert to its domain, as a form of (limited) IPC in a multi-process

[PATCH v3 01/19] dlb2: add skeleton for DLB 2.0 driver

2020-09-01 Thread Gage Eads
This initial commit contains basic driver functionality (load, unload, probe, and remove callbacks) file_operations stubs, and device documentation as well. Signed-off-by: Gage Eads Reviewed-by: Magnus Karlsson --- Documentation/misc-devices/dlb2.rst | 310 +++

[PATCH v3 11/19] dlb2: add queue map and unmap ioctls

2020-09-01 Thread Gage Eads
Load-balanced queues can be "mapped" to any number of load-balanced ports. Once mapped, the port becomes a candidate to which the device can schedule queue entries from the queue. If a port is unmapped from a queue, it is no longer a candidate for scheduling from that queue. The process for map

[PATCH v3 18/19] dlb2: add basic PF sysfs interfaces

2020-09-01 Thread Gage Eads
These interfaces include files for reading the total and available device resources, getting and setting sequence number group allocations, and reading the device ID. Signed-off-by: Gage Eads Reviewed-by: Björn Töpel --- Documentation/ABI/testing/sysfs-driver-dlb2 | 165 +++

Re: [PATCH v9 13/32] drm: omapdrm: use common helper for extracting pages array

2020-09-01 Thread Robin Murphy
On 2020-08-26 07:32, Marek Szyprowski wrote: Use common helper for converting a sg_table object into struct page pointer array. Signed-off-by: Marek Szyprowski --- drivers/gpu/drm/omapdrm/omap_gem.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git

Re: [PATCH v9 12/32] drm: msm: fix common struct sg_table related issues

2020-09-01 Thread Robin Murphy
On 2020-08-26 07:32, Marek Szyprowski wrote: The Documentation/DMA-API-HOWTO.txt states that the dma_map_sg() function returns the number of the created entries in the DMA address space. However the subsequent calls to the dma_sync_sg_for_{device,cpu}() and dma_unmap_sg must be called with the

Re: [PATCH 2/6] mtd: rawnand: atmel: Simplify with dev_err_probe()

2020-09-01 Thread Alexandre Belloni
On 01/09/2020 16:25:31+0200, Krzysztof Kozlowski wrote: > Common pattern of handling deferred probe can be simplified with > dev_err_probe(). Less code and the error value gets printed. > > Signed-off-by: Krzysztof Kozlowski Reviewed-by: Alexandre Belloni > --- >

Re: [PATCH v5 00/21] kprobes: Unify kretprobe trampoline handlers and make kretprobe lockless

2020-09-01 Thread Peter Zijlstra
On Sat, Aug 29, 2020 at 09:59:49PM +0900, Masami Hiramatsu wrote: > Masami Hiramatsu (16): > kprobes: Add generic kretprobe trampoline handler > x86/kprobes: Use generic kretprobe trampoline handler > arm: kprobes: Use generic kretprobe trampoline handler > arm64: kprobes:

Re: [PATCH 03/11] spi: atmel: Simplify with dev_err_probe()

2020-09-01 Thread Alexandre Belloni
On 01/09/2020 17:27:05+0200, Krzysztof Kozlowski wrote: > Common pattern of handling deferred probe can be simplified with > dev_err_probe(). Less code and the error value gets printed. > > Signed-off-by: Krzysztof Kozlowski Reviewed-by: Alexandre Belloni > --- > drivers/spi/spi-atmel.c | 5

Re: [PATCH 5.4 000/214] 5.4.62-rc1 review

2020-09-01 Thread Guenter Roeck
On 9/1/20 8:08 AM, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 5.4.62 release. > There are 214 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Responses

Re: [PATCH 4.19 124/125] HID: hiddev: Fix slab-out-of-bounds write in hiddev_ioctl_usage()

2020-09-01 Thread Pavel Machek
Hi! > commit 25a097f5204675550afb879ee18238ca917cba7a upstream. > > `uref->usage_index` is not always being properly checked, causing > hiddev_ioctl_usage() to go out of bounds under some cases. Fix it. Well, the code is quite confusig, but: a) does HIDIOCGCOLLECTIONINDEX need same checking?

Re: [PATCH v4 0/5] cpufreq: intel_pstate: Address some HWP-related oddities

2020-09-01 Thread Srinivas Pandruvada
On Tue, 2020-09-01 at 19:23 +0200, Rafael J. Wysocki wrote: > Hi All, > > The last two patches in the v3 needed to be updated to take re- > enabling of HWP > after an ACPI S3 suspend/resume cycle into account > appropriately. The first > three patches are the same as before. > > The purpose of

Re: [PATCH net-next RFC v3 02/14] devlink: Add reload actions counters

2020-09-01 Thread Moshe Shemesh
On 8/31/2020 1:48 PM, Jiri Pirko wrote: Sun, Aug 30, 2020 at 05:27:22PM CEST, mo...@mellanox.com wrote: Add reload actions counters to hold the history per reload action type. For example, the number of times fw_activate has been done on this device since the driver module was added or if the

Re: remove the last set_fs() in common code, and remove it for x86 and powerpc v2

2020-09-01 Thread Christophe Leroy
Le 01/09/2020 à 19:25, Al Viro a écrit : On Tue, Sep 01, 2020 at 07:13:00PM +0200, Christophe Leroy wrote: 10.92% dd [kernel.kallsyms] [k] iov_iter_zero Interesting... Could you get an instruction-level profile inside iov_iter_zero(), along with the disassembly of that

Re: [PATCH net-next RFC v3 03/14] devlink: Add reload actions counters to dev get

2020-09-01 Thread Moshe Shemesh
On 8/31/2020 1:44 PM, Jiri Pirko wrote: Sun, Aug 30, 2020 at 05:27:23PM CEST, mo...@mellanox.com wrote: Expose devlink reload actions counters to the user through devlink dev get command. Examples: $ devlink dev show pci/:82:00.0: reload_actions_stats: driver_reinit 2

Re: [PATCH 4.4 00/62] 4.4.235-rc1 review

2020-09-01 Thread Guenter Roeck
On 9/1/20 8:09 AM, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 4.4.235 release. > There are 62 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Responses

Re: [PATCH 05/10] lkdtm: disable set_fs-based tests for !CONFIG_SET_FS

2020-09-01 Thread Kees Cook
On Sat, Aug 29, 2020 at 11:24:06AM +0200, Christoph Hellwig wrote: > On Thu, Aug 27, 2020 at 11:06:28AM -0700, Linus Torvalds wrote: > > On Thu, Aug 27, 2020 at 8:00 AM Christoph Hellwig wrote: > > > > > > Once we can't manipulate the address limit, we also can't test what > > > happens when the

[PATCH 07/27] blk-iocost: make iocg_kick_waitq() call iocg_kick_delay() after paying debt

2020-09-01 Thread Tejun Heo
iocg_kick_waitq() is the function which pays debt and iocg_kick_delay() updates the actual delay status accordingly. If iocg_kick_delay() is not called after iocg_kick_delay() updated debt, unnecessarily large delays can be applied temporarily. Let's make sure such conditions don't occur by

[PATCHSET for-5.10/block] blk-iocost: iocost: improve donation, debt and excess handling

2020-09-01 Thread Tejun Heo
Hello, This patchset improves iocost in three areas to make iocost internal operations more accurate and immediate with the goal of improving work conservation and distribution fairness, and removing dependence on vrate adjustments for masking work conservation issues. This improves overall

[PATCH 01/27] blk-iocost: ioc_pd_free() shouldn't assume irq disabled

2020-09-01 Thread Tejun Heo
ioc_pd_free() grabs irq-safe ioc->lock without ensuring that irq is disabled when it can be called with irq disabled or enabled. This has a small chance of causing A-A deadlocks and triggers lockdep splats. Use irqsave operations instead. Signed-off-by: Tejun Heo Fixes: 7caa47151ab2 ("blkcg:

[PATCH 11/27] blk-iocost: streamline vtime margin and timer slack handling

2020-09-01 Thread Tejun Heo
The margin handling was pretty inconsistent. * ioc->margin_us and ioc->inuse_margin_vtime were used as vtime margin thresholds. However, the two are in different units with the former requiring conversion to vtime on use. * iocg_kick_waitq() was using a quarter of WAITQ_TIMER_MARGIN_PCT of

[PATCH 10/27] blk-iocost: make ioc_now->now and ioc->period_at 64bit

2020-09-01 Thread Tejun Heo
They are in microseconds and wrap in around 1.2 hours with u32. While unlikely, confusions from wraparounds are still possible. We aren't saving anything meaningful by keeping these u32. Let's make them u64. Signed-off-by: Tejun Heo --- block/blk-iocost.c | 4 ++-- 1 file changed, 2

[PATCH 06/27] blk-iocost: move iocg_kick_delay() above iocg_kick_waitq()

2020-09-01 Thread Tejun Heo
We'll make iocg_kick_waitq() call iocg_kick_delay(). Reorder them in preparation. This is pure code reorganization. Signed-off-by: Tejun Heo --- block/blk-iocost.c | 120 ++--- 1 file changed, 60 insertions(+), 60 deletions(-) diff --git

Re: [PATCH v4] iommu/tegra-smmu: Add locking around mapping operations

2020-09-01 Thread Dmitry Osipenko
01.09.2020 20:13, Dmitry Osipenko пишет: ... > + /* > + * In order to prevent exhaustion of the atomic memory pool, we > + * allocate page in a sleeping context if GFP flags permit. Hence > + * spinlock needs to be unlocked and re-locked after allocation. > + */ > + if

[PATCH 02/27] blk-stat: make q->stats->lock irqsafe

2020-09-01 Thread Tejun Heo
blk-iocost calls blk_stat_enable_accounting() while holding an irqsafe lock which triggers a lockdep splat because q->stats->lock isn't irqsafe. Let's make it irqsafe. Signed-off-by: Tejun Heo Fixes: cd006509b0a9 ("blk-iocost: account for IO size when testing latencies") Cc:

[PATCH 23/27] blk-iocost: halve debts if device stays idle

2020-09-01 Thread Tejun Heo
A low weight iocg can amass a large amount of debt, for example, when anonymous memory gets reclaimed aggressively. If the system has a lot of memory paired with a slow IO device, the debt can span multiple seconds or more. If there are no other subsequent IO issuers, the in-debt iocg may end up

[PATCH 25/27] blk-iocost: restore inuse update tracepoints

2020-09-01 Thread Tejun Heo
Update and restore the inuse update tracepoints. Signed-off-by: Tejun Heo --- block/blk-iocost.c| 16 include/trace/events/iocost.h | 6 +++--- 2 files changed, 19 insertions(+), 3 deletions(-) diff --git a/block/blk-iocost.c b/block/blk-iocost.c index

[PATCH 27/27] blk-iocost: update iocost_monitor.py

2020-09-01 Thread Tejun Heo
iocost went through significant internal changes. Update iocost_monitor.py accordingly. Signed-off-by: Tejun Heo --- tools/cgroup/iocost_monitor.py | 54 -- 1 file changed, 19 insertions(+), 35 deletions(-) diff --git a/tools/cgroup/iocost_monitor.py

[PATCH 26/27] blk-iocost: add three debug stat - cost.wait, indebt and indelay

2020-09-01 Thread Tejun Heo
These are really cheap to collect and can be useful in debugging iocost behavior. Add them as debug stats for now. Signed-off-by: Tejun Heo --- block/blk-iocost.c | 77 +++--- 1 file changed, 72 insertions(+), 5 deletions(-) diff --git

[PATCH 04/27] blk-iocost: rename propagate_active_weights() to propagate_weights()

2020-09-01 Thread Tejun Heo
It already propagates two weights - active and inuse - and there will be another soon. Let's drop the confusing misnomers. Rename [__]propagate_active_weights() to [__]propagate_weights() and commit_active_weights() to commit_weights(). This is pure rename. Signed-off-by: Tejun Heo ---

[PATCH 22/27] blk-iocost: implement delay adjustment hysteresis

2020-09-01 Thread Tejun Heo
Curently, iocost syncs the delay duration to the outstanding debt amount, which seemed enough to protect the system from anon memory hogs. However, that was mostly because the delay calcuation was using hweight_inuse which quickly converges towards zero under debt for delay duration calculation,

[PATCH 19/27] blk-iocost: revamp donation amount determination

2020-09-01 Thread Tejun Heo
iocost has various safety nets to combat inuse adjustment calculation inaccuracies. With Andy's method implemented in transfer_surpluses(), inuse adjustment calculations are now accurate and we can make donation amount determinations accurate too. * Stop keeping track of past usage history and

[PATCH 13/27] blk-iocost: add absolute usage stat

2020-09-01 Thread Tejun Heo
Currently, iocost doesn't collect or expose any statistics punting off all monitoring duties to drgn based iocost_monitor.py. While it works for some scenarios, there are some usability and data availability challenges. For example, accurate per-cgroup usage information can't be tracked by vtime

[PATCH 14/27] blk-iocost: calculate iocg->usages[] from iocg->local_stat.usage_us

2020-09-01 Thread Tejun Heo
Currently, iocg->usages[] which are used to guide inuse adjustments are calculated from vtime deltas. This, however, assumes that the hierarchical inuse weight at the time of calculation held for the entire period, which often isn't true and can lead to significant errors. Now that we have

[PATCH 20/27] blk-iocost: revamp in-period donation snapbacks

2020-09-01 Thread Tejun Heo
When the margin drops below the minimum on a donating iocg, donation is immediately canceled in full. There are a couple shortcomings with the current behavior. * It's abrupt. A small temporary budget deficit can lead to a wide swing in weight allocation and a large surplus. * It's open coded

[PATCH 24/27] blk-iocost: implement vtime loss compensation

2020-09-01 Thread Tejun Heo
When an iocg accumulates too much vtime or gets deactivated, we throw away some vtime, which lowers the overall device utilization. As the exact amount which is being thrown away is known, we can compensate by accelerating the vrate accordingly so that the extra vtime generated in the current

[PATCH 18/27] blk-iocost: implement Andy's method for donation weight updates

2020-09-01 Thread Tejun Heo
iocost implements work conservation by reducing iocg->inuse and propagating the adjustment upwards proportionally. However, while I knew the target absolute hierarchical proportion - adjusted hweight_inuse, I couldn't figure out how to determine the iocg->inuse adjustment to achieve that and

[PATCH 21/27] blk-iocost: revamp debt handling

2020-09-01 Thread Tejun Heo
Debt handling had several issues. * How much inuse a debtor carries wasn't clearly defined. inuse would be driven down over time from not issuing IOs but it'd be better to clamp it to minimum immediately once in debt. * How much can be paid off was determined by hweight_inuse. As inuse was

[PATCH 16/27] blk-iocost: decouple vrate adjustment from surplus transfers

2020-09-01 Thread Tejun Heo
Budget donations are inaccurate and could take multiple periods to converge. To prevent triggering vrate adjustments while surplus transfers were catching up, vrate adjustment was suppressed if donations were increasing, which was indicated by non-zero nr_surpluses. This entangling won't be

[PATCH 15/27] blk-iocost: replace iocg->has_surplus with ->surplus_list

2020-09-01 Thread Tejun Heo
Instead of marking iocgs with surplus with a flag and filtering for them while walking all active iocgs, build a surpluses list. This doesn't make much difference now but will help implementing improved donation logic which will iterate iocgs with surplus multiple times. Signed-off-by: Tejun Heo

[PATCH 17/27] blk-iocost: restructure surplus donation logic

2020-09-01 Thread Tejun Heo
The way the surplus donation logic is structured isn't great. There are two separate paths for starting/increasing donations and decreasing them making the logic harder to follow and is prone to unnecessary behavior differences. In preparation for improved donation handling, this patch

Re: [PATCH v9 11/32] drm: mediatek: use common helper for extracting pages array

2020-09-01 Thread Robin Murphy
On 2020-08-26 07:32, Marek Szyprowski wrote: Use common helper for converting a sg_table object into struct page pointer array. Reviewed-by: Robin Murphy Side note: is mtk_drm_gem_prime_vmap() missing a call to sg_free_table(sgt) before its kfree(sgt)? Signed-off-by: Marek Szyprowski

[PATCH 12/27] blk-iocost: grab ioc->lock for debt handling

2020-09-01 Thread Tejun Heo
Currently, debt handling requires only iocg->waitq.lock. In the future, we want to adjust and propagate inuse changes depending on debt status. Let's grab ioc->lock in debt handling paths in preparation. * Because ioc->lock nests outside iocg->waitq.lock, the decision to grab ioc->lock needs to

[PATCH 05/27] blk-iocost: clamp inuse and skip noops in __propagate_weights()

2020-09-01 Thread Tejun Heo
__propagate_weights() currently expects the callers to clamp inuse within [1, active], which is needlessly fragile. The inuse adjustment logic is going to be revamped, in preparation, let's make __propagate_weights() clamp inuse on entry. Also, make it avoid weight updates altogether if neither

[PATCH 08/27] blk-iocost: s/HWEIGHT_WHOLE/WEIGHT_ONE/g

2020-09-01 Thread Tejun Heo
We're gonna use HWEIGHT_WHOLE for regular weights too. Let's rename it to WEIGHT_ONE. Pure rename. Signed-off-by: Tejun Heo --- block/blk-iocost.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/block/blk-iocost.c b/block/blk-iocost.c index

Re: [PATCH 05/10] lkdtm: disable set_fs-based tests for !CONFIG_SET_FS

2020-09-01 Thread Kees Cook
On Sat, Aug 29, 2020 at 11:24:06AM +0200, Christoph Hellwig wrote: > On Thu, Aug 27, 2020 at 11:06:28AM -0700, Linus Torvalds wrote: > > On Thu, Aug 27, 2020 at 8:00 AM Christoph Hellwig wrote: > > > > > > Once we can't manipulate the address limit, we also can't test what > > > happens when the

[PATCH 09/27] blk-iocost: use WEIGHT_ONE based fixed point number for weights

2020-09-01 Thread Tejun Heo
To improve weight donations, we want to able to scale inuse with a greater accuracy and down below 1. Let's make non-hierarchical weights to use WEIGHT_ONE based fixed point numbers too like hierarchical ones. This doesn't cause any behavior changes yet. Signed-off-by: Tejun Heo ---

[PATCH 03/27] blk-iocost: use local[64]_t for percpu stat

2020-09-01 Thread Tejun Heo
blk-iocost has been reading percpu stat counters from remote cpus which on some archs can lead to torn reads in really rare occassions. Use local[64]_t for those counters. Signed-off-by: Tejun Heo --- block/blk-iocost.c | 37 +++-- 1 file changed, 27

Re: [PATCH 1/2] EDAC/aspeed: Fix handling of platform_get_irq() error

2020-09-01 Thread Borislav Petkov
On Thu, Aug 27, 2020 at 09:07:42AM +0200, Krzysztof Kozlowski wrote: > platform_get_irq() returns -ERRNO on error. In such case comparison > to 0 would pass the check. > > Fixes: 9b7e6242ee4e ("EDAC, aspeed: Add an Aspeed AST2500 EDAC driver") > Signed-off-by: Krzysztof Kozlowski > --- >

Re: [PATCH 1/1] RAS: Add CPU Correctable Error Collector to isolate an erroneous CPU core

2020-09-01 Thread kernel test robot
, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Shiju-Jose/RAS-Add-CPU-Correctable-Error-Collector-to-isolate-an-erroneous-CPU-core/20200901-222704 base: https://git.kernel.org/pub/scm/linux/kernel/git

Re: [PATCH] module: Add more error message for failed kernel module loading

2020-09-01 Thread Lucas De Marchi
On Sat, Aug 29, 2020 at 4:15 AM Qu Wenruo wrote: > > When kernel module loading failed, user space only get one of the > following error messages: > - -ENOEXEC > This is the most confusing one. From corrupted ELF header to bad > WRITE|EXEC flags check introduced by in

Re: [PATCH 3/5] shmem: shmem_writepage() split unlikely i915 THP

2020-09-01 Thread Yang Shi
On Tue, Sep 1, 2020 at 10:39 AM Hugh Dickins wrote: > > On Tue, 1 Sep 2020, Yang Shi wrote: > > On Sun, Aug 30, 2020 at 2:04 PM Hugh Dickins wrote: > > > > > > drivers/gpu/drm/i915/gem/i915_gem_shmem.c contains a shmem_writeback() > > > which calls shmem_writepage() from a shrinker: that usually

Re: [PATCH net-next] net: sungem: Remove unneeded cast from memory allocation

2020-09-01 Thread David Miller
From: YueHaibing Date: Tue, 1 Sep 2020 22:10:28 +0800 > Remove dma_alloc_coherent return value cast. > This is detected by coccinelle. > > Signed-off-by: YueHaibing Applied.

Re: [PATCH net-next] liquidio: Remove unneeded cast from memory allocation

2020-09-01 Thread David Miller
From: YueHaibing Date: Tue, 1 Sep 2020 22:11:15 +0800 > Remove unneeded return value cast. > This is detected by coccinelle. > > Signed-off-by: YueHaibing Applied.

Re: [PATCH] pktgen: fix error message with wrong function name

2020-09-01 Thread David Miller
From: Leesoo Ahn Date: Tue, 1 Sep 2020 22:04:47 +0900 > Error on calling kthread_create_on_node prints wrong function name, > kernel_thread. > > Signed-off-by: Leesoo Ahn Applied with Fixes: tag added.

Re: [PATCH v6 2/2] iio: light: as73211: New driver

2020-09-01 Thread Jonathan Cameron
On Thu, 6 Aug 2020 18:44:51 +0100 Jonathan Cameron wrote: > On Wed, 5 Aug 2020 07:57:44 +0200 > Christian Eggers wrote: > > > Support for AMS AS73211 JENCOLOR(R) Digital XYZ Sensor. > > > > This driver has no built-in trigger. In order for making triggered > > measurements, an external

Re: [PATCH v9 3/3] mm/madvise: introduce process_madvise() syscall: an external memory hinting API

2020-09-01 Thread Florian Weimer
* Minchan Kim: > ssize_t process_madvise(int pidfd, const struct iovec *iovec, > unsigned long vlen, int advice, unsigned int flags); size_t for vlen provides a clearer hint regarding the type of special treatment needed for ILP32 here (zero extension, not changing the type

[PATCH v2] driver core: Fix device_pm_lock() locking for device links

2020-09-01 Thread Saravana Kannan
This commit fixes two issues: 1. The lockdep warning reported by Dong Aisheng [1]. It is a warning about a cycle (dpm_list_mtx --> kn->active#3 --> fw_lock) that was introduced when device-link devices were added to expose device link information in sysfs. The patch that "introduced" this

Re: [PATCH v9 10/32] drm: mediatek: use common helper for a scatterlist contiguity check

2020-09-01 Thread Robin Murphy
On 2020-08-26 07:32, Marek Szyprowski wrote: Use common helper for checking the contiguity of the imported dma-buf and do this check before allocating resources, so the error path is simpler. Reviewed-by: Robin Murphy Signed-off-by: Marek Szyprowski ---

Re: [PATCH v9 08/32] drm: i915: fix common struct sg_table related issues

2020-09-01 Thread Robin Murphy
On 2020-08-26 07:32, Marek Szyprowski wrote: The Documentation/DMA-API-HOWTO.txt states that the dma_map_sg() function returns the number of the created entries in the DMA address space. However the subsequent calls to the dma_sync_sg_for_{device,cpu}() and dma_unmap_sg must be called with the

Re: [PATCH 4.19 047/125] media: davinci: vpif_capture: fix potential double free

2020-09-01 Thread Pavel Machek
Hi! > [ Upstream commit 602649eadaa0c977e362e641f51ec306bc1d365d ] > > In case of errors vpif_probe_complete() releases memory for vpif_obj.sd > and unregisters the V4L2 device. But then this is done again by > vpif_probe() itself. The patch removes the cleaning from > vpif_probe_complete(). >

Re: [PATCH v9 05/32] drm: etnaviv: fix common struct sg_table related issues

2020-09-01 Thread Robin Murphy
On 2020-08-26 07:32, Marek Szyprowski wrote: The Documentation/DMA-API-HOWTO.txt states that the dma_map_sg() function returns the number of the created entries in the DMA address space. However the subsequent calls to the dma_sync_sg_for_{device,cpu}() and dma_unmap_sg must be called with the

Re: [PATCH v5 1/2] iio: accel: adxl372: Add support for FIFO peak mode

2020-09-01 Thread Jonathan Cameron
On Sat, 29 Aug 2020 18:43:50 +0100 Jonathan Cameron wrote: > On Mon, 10 Aug 2020 12:32:56 +0300 > wrote: > > > From: Stefan Popa > > > > By default, if all three channels (x, y, z) are enabled, sample sets of > > concurrent 3-axis data is stored in the FIFO. This patch adds the option > > to

Re: remove the last set_fs() in common code, and remove it for x86 and powerpc v2

2020-09-01 Thread Christophe Leroy
Le 01/09/2020 à 19:25, Al Viro a écrit : On Tue, Sep 01, 2020 at 07:13:00PM +0200, Christophe Leroy wrote: 10.92% dd [kernel.kallsyms] [k] iov_iter_zero Interesting... Could you get an instruction-level profile inside iov_iter_zero(), along with the disassembly of that

Re: [PATCH] mm/memory_hotplug: drain per-cpu pages again during memory offline

2020-09-01 Thread David Rientjes
On Tue, 1 Sep 2020, Pavel Tatashin wrote: > There is a race during page offline that can lead to infinite loop: > a page never ends up on a buddy list and __offline_pages() keeps > retrying infinitely or until a termination signal is received. > > Thread#1 - a new process: > > load_elf_binary >

Re: [PATCH net-next] net: sch_generic: aviod concurrent reset and enqueue op for lockless qdisc

2020-09-01 Thread David Miller
From: Yunsheng Lin Date: Tue, 1 Sep 2020 15:27:44 +0800 > On 2020/9/1 14:48, Eric Dumazet wrote: >> We request Fixes: tag for fixes in networking land. > > ok. > > Fixes: 6b3ba9146fe6 ("net: sched: allow qdiscs to handle locking") You should repost the patch with the Fixes: tag in order to

Re: Boot failure on gru-scarlet-inx with 5.9-rc2

2020-09-01 Thread Samuel Dionne-Riel
On Tue, 1 Sep 2020 17:42:49 +0100 Lorenzo Pieralisi wrote: > On Tue, Sep 01, 2020 at 04:37:42PM +0100, Marc Zyngier wrote: > > On 2020-09-01 04:45, Samuel Dionne-Riel wrote: > > > - if (pci_is_root_bus(bus->parent) && dev > 0) > > > + if (bus->primary == rockchip->root_bus_nr && dev > 0) >

Re: [PATCH v3 03/23] arc: use asm-generic/mmu_context.h for no-op implementations

2020-09-01 Thread Vineet Gupta
On 9/1/20 7:15 AM, Nicholas Piggin wrote: > Cc: Vineet Gupta > Cc: linux-snps-...@lists.infradead.org > Signed-off-by: Nicholas Piggin Acked-by: Vineet Gupta#arch/arc Thx, -Vineet > --- > > Please ack or nack if you object to this being mered via > Arnd's tree. > >

Re: [PATCH v9 04/32] drm: armada: fix common struct sg_table related issues

2020-09-01 Thread Robin Murphy
On 2020-08-26 07:32, Marek Szyprowski wrote: The Documentation/DMA-API-HOWTO.txt states that the dma_map_sg() function returns the number of the created entries in the DMA address space. However the subsequent calls to the dma_sync_sg_for_{device,cpu}() and dma_unmap_sg must be called with the

Re: linux-next: Fixes tag needs some work in the arc-current tree

2020-09-01 Thread Vineet Gupta
On 9/1/20 4:36 AM, Stephen Rothwell wrote: > Hi Mike, > > On Tue, 1 Sep 2020 12:13:08 +0300 Mike Rapoport wrote: >> On Tue, Sep 01, 2020 at 06:49:28PM +1000, Stephen Rothwell wrote: >>> In commit >>> >>> 7000c9462d1b ("arc: fix memory initialization for systems with two memory >>> banks") >>>

Re: [PATCH v11 25/25] x86/cet/shstk: Add arch_prctl functions for shadow stack

2020-09-01 Thread Yu, Yu-cheng
On 9/1/2020 11:17 AM, Florian Weimer wrote: * Yu-cheng Yu: On 9/1/2020 10:50 AM, Florian Weimer wrote: * Yu-cheng Yu: Like other arch_prctl()'s, this parameter was 'unsigned long' earlier. The idea was, since this arch_prctl is only implemented for the 64-bit kernel, we wanted it to look as

Re: [PATCH net-next] net: sch_generic: aviod concurrent reset and enqueue op for lockless qdisc

2020-09-01 Thread Cong Wang
On Mon, Aug 31, 2020 at 5:59 PM Yunsheng Lin wrote: > > Currently there is concurrent reset and enqueue operation for the > same lockless qdisc when there is no lock to synchronize the > q->enqueue() in __dev_xmit_skb() with the qdisc reset operation in > qdisc_deactivate() called by

Re: [PATCH v11 25/25] x86/cet/shstk: Add arch_prctl functions for shadow stack

2020-09-01 Thread H.J. Lu
On Tue, Sep 1, 2020 at 11:17 AM Florian Weimer wrote: > > * Yu-cheng Yu: > > > On 9/1/2020 10:50 AM, Florian Weimer wrote: > >> * Yu-cheng Yu: > >> > >>> Like other arch_prctl()'s, this parameter was 'unsigned long' > >>> earlier. The idea was, since this arch_prctl is only implemented for > >>>

Re: [PATCH v11 25/25] x86/cet/shstk: Add arch_prctl functions for shadow stack

2020-09-01 Thread Florian Weimer
* Yu-cheng Yu: > On 9/1/2020 10:50 AM, Florian Weimer wrote: >> * Yu-cheng Yu: >> >>> Like other arch_prctl()'s, this parameter was 'unsigned long' >>> earlier. The idea was, since this arch_prctl is only implemented for >>> the 64-bit kernel, we wanted it to look as 64-bit only. I will change

Re: [PATCH v2] can: m_can: Set device to software init mode before closing

2020-09-01 Thread Dan Murphy
Faiz On 8/25/20 12:54 AM, Faiz Abbas wrote: There might be some requests pending in the buffer when the interface close sequence occurs. In some devices, these pending requests might lead to the module not shutting down properly when m_can_clk_stop() is called. Therefore, move the device to

Re: [PATCH v11 25/25] x86/cet/shstk: Add arch_prctl functions for shadow stack

2020-09-01 Thread Dave Hansen
On 9/1/20 10:45 AM, Andy Lutomirski wrote: >>> For arm64 (and sparc etc.) we continue to use the regular mmap/mprotect >>> family of calls. One or two additional arch-specific mmap flags are >>> sufficient for now. >>> >>> Is x86 definitely not going to fit within those calls? >> That can work

Re: [PATCH bpf-next v1 4/8] bpf/libbpf: BTF support for typed ksyms

2020-09-01 Thread Andrii Nakryiko
On Thu, Aug 27, 2020 at 3:29 PM Hao Luo wrote: > > On Fri, Aug 21, 2020 at 3:37 PM Andrii Nakryiko > wrote: > > > > On Wed, Aug 19, 2020 at 3:42 PM Hao Luo wrote: > > > > > > If a ksym is defined with a type, libbpf will try to find the ksym's btf > > > information from kernel btf. If a valid

Re: [RFC PATCH 0/2] mm/gup: fix gup_fast with dynamic page table folding

2020-09-01 Thread Jason Gunthorpe
On Tue, Sep 01, 2020 at 07:40:20PM +0200, Gerald Schaefer wrote: > +/* > + * With dynamic page table levels on s390, the static pXd_addr_end() > functions > + * will not return corresponding dynamic boundaries. This is no problem as > long > + * as only pXd pointers are passed down during page

Re: [PATCH bpf-next v1 8/8] bpf/selftests: Test for bpf_per_cpu_ptr()

2020-09-01 Thread Andrii Nakryiko
On Thu, Aug 27, 2020 at 8:42 PM Hao Luo wrote: > > Thanks for taking a look! > > On Fri, Aug 21, 2020 at 8:30 PM Andrii Nakryiko > wrote: > > > > On Wed, Aug 19, 2020 at 3:42 PM Hao Luo wrote: > > > > > > Test bpf_per_cpu_ptr(). Test two paths in the kernel. If the base > > > pointer points to

Re: [PATCH 4/5] drm_dp_cec: add plumbing in preparation for MST support

2020-09-01 Thread Lyude Paul
Super minor nitpicks: On Tue, 2020-09-01 at 16:22 +1000, Sam McNally wrote: > From: Hans Verkuil > > Signed-off-by: Hans Verkuil > [sa...@chromium.org: > - rebased > - removed polling-related changes > - moved the calls to drm_dp_cec_(un)set_edid() into the next patch > ] > Signed-off-by:

Re: [RFC PATCH 1/7] Fix khugepaged's request size in collapse_file()

2020-09-01 Thread Song Liu
On Tue, Sep 1, 2020 at 9:28 AM David Howells wrote: > > collapse_file() in khugepaged passes PAGE_SIZE as the number of pages to be > read ahead to page_cache_sync_readahead(). It seems this was expressed as a > number of bytes rather than a number of pages. > > Fix it to use the number of pages

stm32-timers.c:undefined reference to `dma_release_channel'

2020-09-01 Thread kernel test robot
-20200901 (attached as .config) compiler: nds32le-linux-gcc (GCC) 9.3.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout

Re: Re: [PATCH v3] PCI: Add pci_iounmap

2020-09-01 Thread George Cherian
Hi Yang, > -Original Message- > From: Yang Yingliang > Sent: Tuesday, September 1, 2020 6:59 PM > To: George Cherian ; linux-kernel@vger.kernel.org; > linux-a...@vger.kernel.org; linux-...@vger.kernel.org > Cc: kbuild-...@lists.01.org; bhelg...@google.com; a...@arndb.de; >

Re: [PATCH 00/13] remoteproc: Add support for detaching from rproc

2020-09-01 Thread Mathieu Poirier
On Tue, Sep 01, 2020 at 06:55:14PM +0200, Arnaud POULIQUEN wrote: > Hi Mathieu, > > On 8/26/20 6:45 PM, Mathieu Poirier wrote: > > Following the work done here [1] this set provides support for the > > remoteproc core to release resources associated with a remote processor > > without having to

Re: [PATCH v6 00/29] Warn on orphan section placement

2020-09-01 Thread Nick Desaulniers
On Tue, Sep 1, 2020 at 8:17 AM Kees Cook wrote: > > On Tue, Sep 01, 2020 at 10:16:47AM +0200, Ingo Molnar wrote: > > > > * Ingo Molnar wrote: > > > > > > > > * Ingo Molnar wrote: > > > > > > > > > > > * Kees Cook wrote: > > > > > > > > > On Fri, Aug 21, 2020 at 12:42:41PM -0700, Kees Cook

Re: ERROR: "min_low_pfn" undefined!

2020-09-01 Thread Randy Dunlap
On 9/1/20 5:05 AM, kernel test robot wrote: > Hi Ard, > > First bad commit (maybe != root cause): > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: b51594df17d0ce80b9f9f35394a1f42d7ac94472 > commit: be1eb7f78aa8fbe34779c56c266ccd0364604e71 crypto:

Re: [PATCH 1/1] RAS: Add CPU Correctable Error Collector to isolate an erroneous CPU core

2020-09-01 Thread kernel test robot
, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/Shiju-Jose/RAS-Add-CPU-Correctable-Error-Collector-to-isolate-an-erroneous-CPU-core/20200901-222704 base: https://git.kernel.org/pub/scm/linux/kernel/git

INFO: task can't die in irqentry_exit

2020-09-01 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:b36c9697 Add linux-next specific files for 20200828 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=118ca62590 kernel config: https://syzkaller.appspot.com/x/.config?x=5e3cf99580b5542c dashboard

Re: [PATCH] Documentation: process: step 2: Link to email list fixed.

2020-09-01 Thread Randy Dunlap
On 9/1/20 2:09 AM, Javier Garcia wrote: > In the past, these email lists where located at lists.redhat.com. This > is not longer the case and they are now at redhat.com/mailman/listinfo > > Signed-off-by: Javier Garcia > --- > Documentation/process/2.Process.rst | 2 +- > 1 file changed, 1

Re: [PATCH v3 23/23] xtensa: use asm-generic/mmu_context.h for no-op implementations

2020-09-01 Thread Max Filippov
On Tue, Sep 1, 2020 at 7:17 AM Nicholas Piggin wrote: > > Cc: Chris Zankel > Cc: Max Filippov > Cc: linux-xte...@linux-xtensa.org > Signed-off-by: Nicholas Piggin > --- > > Please ack or nack if you object to this being mered via > Arnd's tree. > > arch/xtensa/include/asm/mmu_context.h | 11

Re: [PATCH v11 25/25] x86/cet/shstk: Add arch_prctl functions for shadow stack

2020-09-01 Thread Yu, Yu-cheng
On 9/1/2020 10:50 AM, Florian Weimer wrote: * Yu-cheng Yu: Like other arch_prctl()'s, this parameter was 'unsigned long' earlier. The idea was, since this arch_prctl is only implemented for the 64-bit kernel, we wanted it to look as 64-bit only. I will change it back to 'unsigned long'.

<    1   2   3   4   5   6   7   8   9   10   >