Re: [PATCH v4 3/5] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-10-29 Thread Lukasz Stelmach
It was <2020-10-29 czw 01:31>, when Andrew Lunn wrote: > > Reverse christmass tree > >> + >> +static int ax88796c_process_isr(struct ax88796c_device *ax_local) >> +{ >> +u16 isr; >> +u8 done = 0; >> +struct net_device *ndev = ax_local->ndev; > > ... > >> +static irqreturn_t

Re: [PATCH 16/16] rcu/tree: Use delayed work instead of hrtimer to refill the cache

2020-10-29 Thread Paul E. McKenney
On Thu, Oct 29, 2020 at 09:22:41PM +0100, Uladzislau Rezki wrote: > On Thu, Oct 29, 2020 at 09:13:42PM +0100, Uladzislau Rezki wrote: > > On Thu, Oct 29, 2020 at 12:47:24PM -0700, Paul E. McKenney wrote: > > > On Thu, Oct 29, 2020 at 05:50:19PM +0100, Uladzislau Rezki (Sony) wrote: > > > > A

Re: [PATCH v2] mm: memcg/slab: Fix return child memcg objcg for root memcg

2020-10-29 Thread Shakeel Butt
On Thu, Oct 29, 2020 at 10:10 AM Roman Gushchin wrote: > > On Thu, Oct 29, 2020 at 08:48:45AM -0700, Shakeel Butt wrote: > > On Tue, Oct 27, 2020 at 8:50 PM Muchun Song > > wrote: > > > > > > Consider the following memcg hierarchy. > > > > > > root > > >/

Re: [PATCH 1/3] Input: goodix - add option to disable firmware loading

2020-10-29 Thread Dmitry Torokhov
Hi Andrej, On Thu, Oct 29, 2020 at 06:03:11PM +0100, Andrej Valek wrote: > Firmware file loadind for GT911 controller takes too much time (~60s). > There is no check that configuration is the same which is already present. > This happens always during boot, which makes touchscreen unusable. > >

[PATCH v2] arm64: NUMA: Kconfig: Increase NODES_SHIFT to 4

2020-10-29 Thread Vanshidhar Konda
The current arm64 default config limits max NUMA nodes available on system to 4 (NODES_SHIFT = 2). Today's arm64 systems can reach or exceed 16 NUMA nodes. To accomodate current hardware and to fit NODES_SHIFT within page flags on arm64, increase NODES_SHIFT to 4. Discussion on v1 of the patch:

Re: [PATCH v2 1/2] bpf: don't rely on GCC __attribute__((optimize)) to disable GCSE

2020-10-29 Thread Segher Boessenkool
On Wed, Oct 28, 2020 at 10:57:45PM -0400, Arvind Sankar wrote: > On Wed, Oct 28, 2020 at 04:20:01PM -0700, Alexei Starovoitov wrote: > > All compilers have bugs. Kernel has bugs. What can go wrong? Heh. > +linux-toolchains. GCC updated the documentation in 7.x to discourage > people from using

Re: [PATCH] Add devices for HID_QUIRK_INCREMENT_USAGE_ON_DUPLICATE

2020-10-29 Thread Dmitry Torokhov
Hi Chris, On Thu, Oct 29, 2020 at 12:47:14PM -0700, Chris Ye wrote: > Kernel 5.4 introduces HID_QUIRK_INCREMENT_USAGE_ON_DUPLICATE, devices > need to be set explicitly with this flag. > > Signed-off-by: Chris Ye The format of the patches looks good now, but you want to make sure you send your

Re: [PATCH v2] venus: venc: Fix setting of profile and level

2020-10-29 Thread Steev Klimaszewski
On 10/27/20 4:19 AM, Stanimir Varbanov wrote: > The profile and level in op_set_ctrl was recently changed but during > v4l2_ctrl_handler_setup profile and level control values are mangled. > > Fixes: 435c53c3698f ("media: venus: venc: Use helper to set profile and > level") > Signed-off-by:

Re: [PATCH] [v2] x86: apic: avoid -Wshadow warning in header

2020-10-29 Thread Thomas Gleixner
On Thu, Oct 29 2020 at 17:59, Paolo Bonzini wrote: > On 29/10/20 17:56, Arvind Sankar wrote: >>> For those two just add: >>> struct apic *apic = x86_system_apic; >>> before all the assignments. >>> Less churn and much better code. >>> >> Why would it be better code? >> > > I think he means

Re: For review: seccomp_user_notif(2) manual page [v2]

2020-10-29 Thread Michael Kerrisk (man-pages)
Hello Sargun,, On 10/29/20 9:53 AM, Sargun Dhillon wrote: > On Mon, Oct 26, 2020 at 10:55:04AM +0100, Michael Kerrisk (man-pages) wrote: [...] >>ioctl(2) operations >>The following ioctl(2) operations are provided to support seccomp >>user-space notification. For each of

Re: [selftest/bpf] 472547778d: WARNING:at_kernel/bpf/verifier.c:#resolve_pseudo_ldimm64

2020-10-29 Thread Andrii Nakryiko
Hao, This seems to be coming from resolve_pseudo_ldimm64(), could you please take a look? Thanks! -- Andrii On Thu, Oct 29, 2020 at 5:58 AM kernel test robot wrote: > > Greeting, > > FYI, we noticed the following commit (built with gcc-9): > > commit: 472547778de24e2764ab325268dd5b77e6923939

Re: [v4,1/3] drm/msm: Add support for GPU cooling

2020-10-29 Thread mka
On Thu, Oct 29, 2020 at 01:37:19PM +0530, Akhil P Oommen wrote: > Register GPU as a devfreq cooling device so that it can be passively > cooled by the thermal framework. > > Signed-off-by: Akhil P Oommen > Reviewed-by: Matthias Kaehlcke Wait, I did not post a 'Reviewed-by' tag for this patch!

Re: [selftest/bpf] 472547778d: WARNING:at_kernel/bpf/verifier.c:#resolve_pseudo_ldimm64

2020-10-29 Thread Hao Luo
Sure, let me take a look at it. On Thu, Oct 29, 2020 at 1:43 PM Andrii Nakryiko wrote: > > Hao, > > This seems to be coming from resolve_pseudo_ldimm64(), could you > please take a look? Thanks! > > -- Andrii > > On Thu, Oct 29, 2020 at 5:58 AM kernel test robot wrote: > > > > Greeting, > > > >

Re: SIGHUP on connect

2020-10-29 Thread Bernd Petrovitsch
Hi all! On 29/10/2020 14:10, Michael J. Baars wrote: [...] > According to manual page socket(7), SO_REUSEADDR allows for local addresses > to be reused for binding. I've tested this socket option with the WAN > address, it > appears the problem is solved for both local and non-local

Re: [RFC PATCH 0/3] Fix errors on DT overlay removal with devlinks

2020-10-29 Thread Frank Rowand
On 10/28/20 11:25 AM, Michael Auchter wrote: > Hey Saravana, > > Thanks for taking the time to look into this! > > On Mon, Oct 26, 2020 at 12:10:33PM -0700, Saravana Kannan wrote: >> On Wed, Oct 21, 2020 at 2:02 PM Frank Rowand wrote: >>> >>> Hi Saravana, >>> >>> Michael found an issue related

Re: [PATCH 06/16] mm/pagemap: Cleanup PREEMPT_COUNT leftovers

2020-10-29 Thread Uladzislau Rezki
On Thu, Oct 29, 2020 at 05:50:09PM +0100, Uladzislau Rezki (Sony) wrote: > From: Thomas Gleixner > > CONFIG_PREEMPT_COUNT is now unconditionally enabled and will be > removed. Cleanup the leftovers before doing so. > > Signed-off-by: Thomas Gleixner > Cc: Andrew Morton > Cc:

Re: [PATCH] libbpf hashmap: Fix undefined behavior in hash_bits

2020-10-29 Thread Ian Rogers
On Thu, Oct 29, 2020 at 1:16 PM Andrii Nakryiko wrote: > > On Thu, Oct 29, 2020 at 9:11 AM Ian Rogers wrote: > > > > If bits is 0, the case when the map is empty, then the >> is the size of > > the register which is undefined behavior - on x86 it is the same as a > > shift by 0. Fix by handling

linux-next: Fixes tag needs some work in the hid tree

2020-10-29 Thread Stephen Rothwell
Hi all, In commit 4b393f0f76c8 ("AMD_SFH: Fix for incorrect Sensor index") Fixes tag Fixes: 4f567b9f8141 ("SFH: PCIe driver to add support of AMD sensor fusion hub 4f567b9f8141") has these problem(s): - Subject does not match target commit subject Just use git log -1

Re: [PATCH 16/16] rcu/tree: Use delayed work instead of hrtimer to refill the cache

2020-10-29 Thread Uladzislau Rezki
On Thu, Oct 29, 2020 at 01:33:55PM -0700, Paul E. McKenney wrote: > On Thu, Oct 29, 2020 at 09:22:41PM +0100, Uladzislau Rezki wrote: > > On Thu, Oct 29, 2020 at 09:13:42PM +0100, Uladzislau Rezki wrote: > > > On Thu, Oct 29, 2020 at 12:47:24PM -0700, Paul E. McKenney wrote: > > > > On Thu, Oct

Re: [PATCH 3/3] blk-mq: Use llist_head for blk_cpu_done

2020-10-29 Thread Sebastian Andrzej Siewior
On 2020-10-29 13:03:26 [-0700], Sagi Grimberg wrote: > > > > > Well, usb-storage obviously seems to do it, and the block layer > > > > does not prohibit it. > > > > > > Also loop, nvme-tcp and then I stopped looking. > > > Any objections about adding local_bh_disable() around it? > > > > To me

[tip: x86/build] x86/build: Fix vmlinux size check on 64-bit

2020-10-29 Thread tip-bot2 for Arvind Sankar
The following commit has been merged into the x86/build branch of tip: Commit-ID: ea3186b9572a1b0299448697cfc44920061872cf Gitweb: https://git.kernel.org/tip/ea3186b9572a1b0299448697cfc44920061872cf Author:Arvind Sankar AuthorDate:Thu, 29 Oct 2020 12:19:03 -04:00

Re: arm64: dropping prevent_bootmem_remove_notifier

2020-10-29 Thread Sudarshan Rajagopalan
Hi Anshuman, David, Thanks for all the detailed explanations for the reasoning to have bootmem protected from being removed. Also, I do agree drivers being able to mark memory sections isn't the right thing to do. We went ahead with the approach of using "mem=" as you suggested to limit

Re: [PATCH v4 3/5] net: ax88796c: ASIX AX88796C SPI Ethernet Adapter Driver

2020-10-29 Thread Andrew Lunn
> >> +static irqreturn_t ax88796c_interrupt(int irq, void *dev_instance) > >> +{ > >> + struct net_device *ndev = dev_instance; > >> + struct ax88796c_device *ax_local = to_ax88796c_device(ndev); Do the assignment later. Andrew

[GIT PULL, staging, net-next] wimax: move to staging

2020-10-29 Thread Arnd Bergmann
The following changes since commit 3650b228f83adda7e5ee532e2b90429c03f7b9ec: Linux 5.10-rc1 (2020-10-25 15:14:11 -0700) are available in the Git repository at: git://git.kernel.org:/pub/scm/linux/kernel/git/arnd/playground.git tags/wimax-staging for you to fetch changes up to

Re: [PATCH 3/3] blk-mq: Use llist_head for blk_cpu_done

2020-10-29 Thread Sagi Grimberg
Well, usb-storage obviously seems to do it, and the block layer does not prohibit it. Also loop, nvme-tcp and then I stopped looking. Any objections about adding local_bh_disable() around it? To me it seems like the whole IPI plus potentially softirq dance is a little pointless when

Re: [PATCH] powerpc/32s: Setup the early hash table at all time.

2020-10-29 Thread Andreas Schwab
On Okt 01 2020, Christophe Leroy wrote: > At the time being, an early hash table is set up when > CONFIG_KASAN is selected. > > There is nothing wrong with setting such an early hash table > all the time, even if it is not used. This is a statically > allocated 256 kB table which lies in the init

Re: [PATCH v2] KVM: arm64: Failback on unsupported huge page sizes

2020-10-29 Thread Marc Zyngier
On Mon, 26 Oct 2020 10:06:26 +1100, Gavin Shan wrote: > The huge page could be mapped through multiple contiguous PMDs or PTEs. > The corresponding huge page sizes aren't supported by the page table > walker currently. > > This fails the unsupported huge page sizes to the near one. Otherwise, >

Re: [PATCH] KVM: arm64: Fix masks in stage2_pte_cacheable()

2020-10-29 Thread Marc Zyngier
On Thu, 29 Oct 2020 14:47:16 +, Will Deacon wrote: > stage2_pte_cacheable() tries to figure out whether the mapping installed > in its 'pte' parameter is cacheable or not. Unfortunately, it fails > miserably because it extracts the memory attributes from the entry using > FIELD_GET(), which

Re: [PATCH v2 0/1] KVM: arm64: fix the mmio faulting

2020-10-29 Thread Marc Zyngier
On Mon, 26 Oct 2020 16:54:06 +0530, Santosh Shukla wrote: > Description of the Reproducer scenario as asked in the thread [1]. > > Tried to create the reproducer scenario with vfio-pci driver using > nvidia GPU in PT mode, As because vfio-pci driver now supports > vma faulting

Re: [PATCH] KVM: arm64: Allocate stage-2 pgd pages with GFP_KERNEL_ACCOUNT

2020-10-29 Thread Marc Zyngier
On Mon, 26 Oct 2020 14:44:23 +, Will Deacon wrote: > For consistency with the rest of the stage-2 page-table page allocations > (performing using a kvm_mmu_memory_cache), ensure that __GFP_ACCOUNT is > included in the GFP flags for the PGD pages. Applied to next, thanks! [1/1] KVM: arm64:

linux-next: failure while fetching the pinctrl-samsung-fixes tree

2020-10-29 Thread Stephen Rothwell
Hi all, Fetching the pinctrl-samsung-fixes tree produces this error: fatal: couldn't find remote ref refs/heads/pinctrl-fixes -- Cheers, Stephen Rothwell pgpSkguuqDDli.pgp Description: OpenPGP digital signature

Re: [GIT PULL] Networking

2020-10-29 Thread patchwork-bot+netdevbpf
Hello: This pull request was applied to netdev/net.git (refs/heads/master): On Thu, 29 Oct 2020 12:43:35 -0700 you wrote: > The following changes since commit 3cb12d27ff655e57e8efe3486dca2a22f4e30578: > > Merge tag 'net-5.10-rc1' of > git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net

Re: Re: [RFC PATCH 0/3] Fix errors on DT overlay removal with devlinks

2020-10-29 Thread Michael Auchter
On Thu, Oct 29, 2020 at 03:54:21PM -0500, Frank Rowand wrote: > On 10/28/20 11:25 AM, Michael Auchter wrote: > > Hey Saravana, > > > > Thanks for taking the time to look into this! > > > > On Mon, Oct 26, 2020 at 12:10:33PM -0700, Saravana Kannan wrote: > >> On Wed, Oct 21, 2020 at 2:02 PM Frank

Re: [PATCH] mm/compaction: count pages and stop correctly during page isolation.

2020-10-29 Thread Yang Shi
On Thu, Oct 29, 2020 at 1:04 PM Zi Yan wrote: > > From: Zi Yan > > In isolate_migratepages_block, when cc->alloc_contig is true, we are > able to isolate compound pages, nr_migratepages and nr_isolated did not > count compound pages correctly, causing us to isolate more pages than we > thought.

Re: [PATCH 06/16] mm/pagemap: Cleanup PREEMPT_COUNT leftovers

2020-10-29 Thread Paul E. McKenney
On Thu, Oct 29, 2020 at 09:57:17PM +0100, Uladzislau Rezki wrote: > On Thu, Oct 29, 2020 at 05:50:09PM +0100, Uladzislau Rezki (Sony) wrote: > > From: Thomas Gleixner > > > > CONFIG_PREEMPT_COUNT is now unconditionally enabled and will be > > removed. Cleanup the leftovers before doing so. > >

Re: [PATCH v2] mm: memcg/slab: Fix return child memcg objcg for root memcg

2020-10-29 Thread Roman Gushchin
On Thu, Oct 29, 2020 at 01:34:57PM -0700, Shakeel Butt wrote: > On Thu, Oct 29, 2020 at 10:10 AM Roman Gushchin wrote: > > > > On Thu, Oct 29, 2020 at 08:48:45AM -0700, Shakeel Butt wrote: > > > On Tue, Oct 27, 2020 at 8:50 PM Muchun Song > > > wrote: > > > > > > > > Consider the following

mm/memblock: export memblock_{start/end}_of_DRAM

2020-10-29 Thread Sudarshan Rajagopalan
Hello all, We have a usecase where a module driver adds certain memory blocks using add_memory_driver_managed(), so that it can perform memory hotplug operations on these blocks. In general, these memory blocks aren’t something that gets physically added later, but is part of actual RAM that

Re: [RFC PATCH v3 9/9] ipu3-cio2: Add functionality allowing software_node connections to sensors on platforms designed for Windows

2020-10-29 Thread Laurent Pinchart
On Thu, Oct 29, 2020 at 10:26:56PM +0200, Andy Shevchenko wrote: > On Thu, Oct 29, 2020 at 10:21 PM Laurent Pinchart wrote: > > On Mon, Oct 26, 2020 at 06:10:50PM +0200, Andy Shevchenko wrote: > > > On Sat, Oct 24, 2020 at 12:37:02PM +0300, Laurent Pinchart wrote: > > > > On Sat, Oct 24, 2020 at

[PATCH v5] driver/perf: Add PMU driver for the ARM DMC-620 memory controller

2020-10-29 Thread Tuan Phan
DMC-620 PMU supports total 10 counters which each is independently programmable to different events and can be started and stopped individually. Currently, it only supports ACPI. Other platforms feel free to test and add support for device tree. Usage example: #perf stat -e

Re: [PATCH v4 0/5] Bluetooth: Add new MGMT interface for advertising add

2020-10-29 Thread Daniel Winkler
Hello Maintainers, Just a friendly reminder to review this kernel patch series. I may have accidentally named this series the same as the userspace series, so I apologize if it has caused the set to be hidden in anybody's inbox. I'll be sure not to do this in the future. Thanks in advance for

Re: [PATCH net-next 1/2] net: phy: realtek: Add phy ids for RTL8226-CG/RTL8226B-CG

2020-10-29 Thread Jakub Kicinski
On Thu, 29 Oct 2020 20:07:57 +0800 Willy Liu wrote: > Realtek single-port 2.5Gbps Ethernet PHY ids as below: > RTL8226-CG: 0x001cc800(ES)/0x001cc838(MP) > RTL8226B-CG/RTL8221B-CG: 0x001cc840(ES)/0x001cc848(MP) > ES: engineer sample > MP: mass production > > Since above PHYs are already in mass

Re: [PATCH v4] cpupower: Provide online and offline CPU information

2020-10-29 Thread Shuah Khan
On 10/23/20 9:25 AM, Brahadambal Srinivasan wrote: When a user tries to modify cpuidle or cpufreq properties on offline CPUs, the tool returns success (exit status 0) but also does not provide any warning message regarding offline cpus that may have been specified but left unchanged. In case of

Re: [PATCH] [v2] x86: apic: avoid -Wshadow warning in header

2020-10-29 Thread Arvind Sankar
On Thu, Oct 29, 2020 at 09:41:13PM +0100, Thomas Gleixner wrote: > On Thu, Oct 29 2020 at 17:59, Paolo Bonzini wrote: > > On 29/10/20 17:56, Arvind Sankar wrote: > >>> For those two just add: > >>> struct apic *apic = x86_system_apic; > >>> before all the assignments. > >>> Less churn and much

Re: [PATCH net-next 03/11] rsxx: remove extraneous 'const' qualifier

2020-10-29 Thread Joe Perches
On Thu, 2020-10-29 at 12:34 -0700, Nick Desaulniers wrote: > On Mon, Oct 26, 2020 at 2:31 PM Arnd Bergmann wrote: > > > > From: Arnd Bergmann > > > > The returned string from rsxx_card_state_to_str is 'const', > > but the other qualifier doesn't change anything here except > > causing a

Re: [PATCH] smp: Add bootcpus parameter to boot subset of CPUs

2020-10-29 Thread Elliot Berman
On 10/28/2020 8:15 AM, Sudeep Holla wrote: Hi Thomas and Peter, Based on my understanding with maxcpus option provides, maximum no of CPUs are brough up during the device boot up. There is a different case, in which we want to restrict which CPUs to be brough up. On a system with 8 cpus, if we

Re: [PATCH] mm/compaction: count pages and stop correctly during page isolation.

2020-10-29 Thread Zi Yan
On 29 Oct 2020, at 17:14, Yang Shi wrote: > On Thu, Oct 29, 2020 at 1:04 PM Zi Yan wrote: >> >> From: Zi Yan >> >> In isolate_migratepages_block, when cc->alloc_contig is true, we are >> able to isolate compound pages, nr_migratepages and nr_isolated did not >> count compound pages correctly,

Re: [PATCH 1/4] tools/power/cpupower: Read energy_perf_bias from sysfs

2020-10-29 Thread Shuah Khan
On 10/16/20 2:37 AM, Borislav Petkov wrote: On Thu, Oct 15, 2020 at 11:49:32AM -0600, Shuah Khan wrote: Is there a reason to move "int fd"? Sorry for a late response. Okay. Looked odd since it didn't need changing. Habit from tip - we sort function-local variables in a reverse fir tree

[PATCH v10 1/4] bus: mhi: core: Add helper API to return number of free TREs

2020-10-29 Thread Hemant Kumar
Introduce mhi_get_free_desc_count() API to return number of TREs available to queue buffer. MHI clients can use this API to know before hand if ring is full without calling queue API. Signed-off-by: Hemant Kumar Reviewed-by: Jeffrey Hugo Reviewed-by: Manivannan Sadhasivam ---

[PATCH v10 3/4] docs: Add documentation for userspace client interface

2020-10-29 Thread Hemant Kumar
MHI userspace client driver is creating device file node for user application to perform file operations. File operations are handled by MHI core driver. Currently Loopback MHI channel is supported by this driver. Signed-off-by: Hemant Kumar --- Documentation/mhi/index.rst | 1 +

[PATCH v10 2/4] bus: mhi: core: Move MHI_MAX_MTU to external header file

2020-10-29 Thread Hemant Kumar
Currently this macro is defined in internal MHI header as a TRE length mask. Moving it to external header allows MHI client drivers to set this upper bound for the transmit buffer size. Signed-off-by: Hemant Kumar Reviewed-by: Jeffrey Hugo Reviewed-by: Manivannan Sadhasivam ---

[PATCH v10 4/4] bus: mhi: Add userspace client interface driver

2020-10-29 Thread Hemant Kumar
This MHI client driver allows userspace clients to transfer raw data between MHI device and host using standard file operations. Driver instantiates UCI device object which is associated to device file node. UCI device object instantiates UCI channel object when device file node is opened. UCI

[PATCH v10 0/4] userspace MHI client interface driver

2020-10-29 Thread Hemant Kumar
This patch series adds support for UCI driver. UCI driver enables userspace clients to communicate to external MHI devices like modem and WLAN. UCI driver probe creates standard character device file nodes for userspace clients to perform open, read, write, poll and release file operations. These

Re: [RFC PATCH] irqchip/sifive-plic: Fix getting wrong chip_data when interrupt is hierarchy

2020-10-29 Thread Atish Patra
On Wed, Oct 28, 2020 at 7:37 PM Greentime Hu wrote: > > This oops is caused by a wrong chip_data and it is because plic_irq_unmask > uses irq_get_chip_data(irq_data->irq) to get the chip_data. However it may > get another irq_data with the same irq_data->irq if it is hierarchy. > > In this case,

Re: [PATCH v4 0/5] Bluetooth: Add new MGMT interface for advertising add

2020-10-29 Thread Luiz Augusto von Dentz
Hi Daniel, On Thu, Oct 29, 2020 at 2:35 PM Daniel Winkler wrote: > > Hello Maintainers, > > Just a friendly reminder to review this kernel patch series. I may > have accidentally named this series the same as the userspace series, > so I apologize if it has caused the set to be hidden in

Re: [PATCH v10 3/4] docs: Add documentation for userspace client interface

2020-10-29 Thread Randy Dunlap
Hi, On 10/29/20 2:40 PM, Hemant Kumar wrote: > MHI userspace client driver is creating device file node > for user application to perform file operations. File > operations are handled by MHI core driver. Currently > Loopback MHI channel is supported by this driver. > > Signed-off-by: Hemant

Re: [PATCH v3 2/2] vhost-vdpa: fix page pinning leakage in error path

2020-10-29 Thread Michael S. Tsirkin
On Thu, Oct 15, 2020 at 01:17:14PM -0700, si-wei liu wrote: > > On 10/15/2020 6:11 AM, Michael S. Tsirkin wrote: > > On Thu, Oct 15, 2020 at 02:15:32PM +0800, Jason Wang wrote: > > > On 2020/10/14 上午7:42, si-wei liu wrote: > > > > > > > > > > So what I suggest is to fix the pinning leakage first

Re: [PATCH -next] drm/amd/display: remove useless if/else

2020-10-29 Thread Alex Deucher
Applied. Thanks! Alex On Wed, Oct 28, 2020 at 2:56 PM Zou Wei wrote: > > Fix the following coccinelle report: > > ./drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c:1367:3-5: > WARNING: possible condition with no effect (if == else) > > Both branches are the same, so remove the if/else

Re: [PATCH 1/4] tools/power/cpupower: Read energy_perf_bias from sysfs

2020-10-29 Thread Borislav Petkov
On Thu, Oct 29, 2020 at 03:38:43PM -0600, Shuah Khan wrote: > All of the other ones should be changed as such. Why add more? Because a patch should do one thing and one thing only. So a separate patch which converts them all in one go should come ontop. But if you insist for the ones I'm adding

Re: [PATCH v3 5/6] pci: dwc: pci-exynos: rework the driver to support Exynos5433 variant

2020-10-29 Thread Jingoo Han
On 10/29/20, 9:41 AM, Marek Szyprowski wrote: > > From: Jaehoon Chung > > Exynos5440 SoC support has been dropped since commit 8c83315da1cf ("ARM: > dts: exynos: Remove Exynos5440"). Rework this driver to support DWC PCIe > variant found in the Exynos5433 SoCs. > > The main difference in

Re: [PATCH][next] drm/amd/pm: fix out-of-bound read on pptable->SkuReserved

2020-10-29 Thread Alex Deucher
Applied. Thanks! On Wed, Oct 28, 2020 at 8:43 AM Colin King wrote: > > From: Colin Ian King > > A recent change added two uint16_t elements to PPTable_t and reduced the > uint32_t array down to 8 elements. This results in the dev_info printing > of pptable->SkuReserved[8] accessing a value

Re: [External] Re: [PATCH v2 07/19] mm/hugetlb: Free the vmemmap pages associated with each hugetlb page

2020-10-29 Thread Mike Kravetz
On 10/28/20 11:13 PM, Muchun Song wrote: > On Thu, Oct 29, 2020 at 7:42 AM Mike Kravetz wrote: >> >> On 10/26/20 7:51 AM, Muchun Song wrote: >>> + >>> +static inline spinlock_t *vmemmap_pmd_lockptr(pmd_t *pmd) >>> +{ >>> + static DEFINE_SPINLOCK(pgtable_lock); >>> + >>> + return _lock;

Re: [PATCH V3 2/2] PCI: dwc: Add support to configure for ECRC

2020-10-29 Thread Jingoo Han
On 10/29/20, 1:40 AM, Vidya Sagar wrote: > > DesignWare core has a TLP digest (TD) override bit in one of the control > registers of ATU. This bit also needs to be programmed for proper ECRC > functionality. This is currently identified as an issue with DesignWare > IP version 4.90a. This patch

[tip:perf/core] BUILD SUCCESS 306e3e91edf1c6739a55312edd110d298ff498dd

2020-10-29 Thread kernel test robot
randconfig-a001-20201029 x86_64 randconfig-a002-20201029 x86_64 randconfig-a003-20201029 x86_64 randconfig-a006-20201029 x86_64 randconfig-a005-20201029 x86_64 randconfig-a004-20201029 i386 randconfig-a002-20201029 i386

[tip:sched/core] BUILD SUCCESS WITH WARNING d8fcb81f1acf651a0e50eacecca43d0524984f87

2020-10-29 Thread kernel test robot
'. Warning ids grouped by kconfigs: gcc_recent_errors `-- x86_64-randconfig-m001-20201029 `-- kernel-sched-cpupri.c-convert_prio()-error:uninitialized-symbol-cpupri-. elapsed time: 724m configs tested: 149 configs skipped: 2 gcc tested configs: arm defconfig

[PATCH] kunit: tool: print out stderr from make (like build warnings)

2020-10-29 Thread Daniel Latypov
Currently the tool redirects make stdout + stderr, and only shows them if the make command fails. This means build warnings aren't shown to the user. This change prints the contents of stderr even if make succeeds, under the assumption these are only build warnings or other messages the user

[PATCH] libbpf hashmap: Avoid undefined behavior in hash_bits

2020-10-29 Thread Ian Rogers
If bits is 0, the case when the map is empty, then the >> is the size of the register which is undefined behavior - on x86 it is the same as a shift by 0. Avoid calling hash_bits with bits == 0 by adding additional empty hashmap tests. Suggested-by: Andrii Nakryiko , Suggested-by: Song Liu

Re: [PATCH v2 1/2] bpf: don't rely on GCC __attribute__((optimize)) to disable GCSE

2020-10-29 Thread Ard Biesheuvel
On Thu, 29 Oct 2020 at 21:35, Segher Boessenkool wrote: > > On Wed, Oct 28, 2020 at 10:57:45PM -0400, Arvind Sankar wrote: > > On Wed, Oct 28, 2020 at 04:20:01PM -0700, Alexei Starovoitov wrote: > > > All compilers have bugs. Kernel has bugs. What can go wrong? > > Heh. > > > +linux-toolchains.

Re: [PATCH 7/7] platform/chrome: cros_ec_typec: Register partner altmodes

2020-10-29 Thread Prashant Malani
Hi Heikki, Thank you for reviewing the patch! On Wed, Oct 28, 2020 at 03:17:32PM +0200, Heikki Krogerus wrote: > Hi, > > On Wed, Oct 21, 2020 at 01:53:16PM -0700, Prashant Malani wrote: > > +static void cros_typec_unregister_altmodes(struct cros_typec_data *typec, > > int port_num) > > +{ > >

RE: [PATCH] [v2] x86: apic: avoid -Wshadow warning in header

2020-10-29 Thread David Laight
From: Arvind Sankar > Sent: 29 October 2020 21:35 > > On Thu, Oct 29, 2020 at 09:41:13PM +0100, Thomas Gleixner wrote: > > On Thu, Oct 29 2020 at 17:59, Paolo Bonzini wrote: > > > On 29/10/20 17:56, Arvind Sankar wrote: > > >>> For those two just add: > > >>> struct apic *apic =

Re: [PATCH 33/33] docs: ABI: unify /sys/class/leds//max_brightness documentation

2020-10-29 Thread Jacek Anaszewski
Hi Mauro, Patch title needs fixing: s/max_brightness/brightness/ On 10/28/20 3:23 PM, Mauro Carvalho Chehab wrote: This ABI is defined twice, one for normal leds and another one for multicolor ones. Ensure that just one definition is there at ABI. Signed-off-by: Mauro Carvalho Chehab ---

Re: [PATCH v5 5/6] dt-bindings: spi: Convert cadence-quadspi.txt to cadence-quadspi.yaml

2020-10-29 Thread Ramuthevar, Vadivel MuruganX
Hi Rob, Thank you so much for the review comments... On 29/10/2020 11:59 pm, Rob Herring wrote: On Thu, Oct 29, 2020 at 02:20:13PM +0800, Ramuthevar,Vadivel MuruganX wrote: From: Ramuthevar Vadivel Murugan Convert the cadence-quadspi.txt documentation to cadence-quadspi.yaml remove the

Re: [PATCH v2 2/2] init/Kconfig: Increase default log buffer size from 128 KB to 512 KB

2020-10-29 Thread Paul Menzel
Dear Petr, Am 11.08.20 um 12:53 schrieb Petr Mladek: On Tue 2020-08-11 11:29:24, Paul Menzel wrote: Commit f17a32e97e (let LOG_BUF_SHIFT default to 17) from 2008 was the last time, the the default log buffer size bump was increased. Machines have evolved, and on current hardware, enough

Re: [RFC PATCH v3 9/9] ipu3-cio2: Add functionality allowing software_node connections to sensors on platforms designed for Windows

2020-10-29 Thread Andy Shevchenko
On Thu, Oct 29, 2020 at 11:29:30PM +0200, Laurent Pinchart wrote: > On Thu, Oct 29, 2020 at 10:26:56PM +0200, Andy Shevchenko wrote: > > On Thu, Oct 29, 2020 at 10:21 PM Laurent Pinchart wrote: > > > On Mon, Oct 26, 2020 at 06:10:50PM +0200, Andy Shevchenko wrote: > > > > On Sat, Oct 24, 2020 at

[PATCH][next] nl80211/cfg80211: fix potential infinite loop

2020-10-29 Thread Colin King
From: Colin Ian King The for-loop iterates with a u8 loop counter and compares this with the loop upper limit of request->n_ssids which is an int type. There is a potential infinite loop if n_ssids is larger than the u8 loop counter, so fix this by making the loop counter an int.

Re: Use after free in bcm2835_spi_remove()

2020-10-29 Thread Mark Brown
On Wed, Oct 28, 2020 at 10:59:46AM +0100, Lukas Wunner wrote: > On Thu, Oct 15, 2020 at 01:53:35PM +0100, Mark Brown wrote: > > This feels a bit icky - we're masking a standard use after free bug that > > affects devm in general, not just this instance, and so while it will > > work it doesn't

Re: [PATCH] libbpf hashmap: Avoid undefined behavior in hash_bits

2020-10-29 Thread Andrii Nakryiko
On Thu, Oct 29, 2020 at 3:10 PM Ian Rogers wrote: > > If bits is 0, the case when the map is empty, then the >> is the size of > the register which is undefined behavior - on x86 it is the same as a > shift by 0. > Avoid calling hash_bits with bits == 0 by adding additional empty > hashmap tests.

Re: [PATCH v4 0/5] Bluetooth: Add new MGMT interface for advertising add

2020-10-29 Thread Daniel Winkler
Hi Luiz, Thank you for the feedback regarding mgmt-tester. I intended to use the tool, but found that it had a very high rate of test failure even before I started adding new tests. If you have a strong preference for its use, I can look into it again but it may take some time. These changes were

[ANNOUNCE] Git v2.29.2

2020-10-29 Thread Junio C Hamano
The latest maintenance release Git v2.29.2 is now available at the usual places. This is to fix the "--committer-date-is-author-date" feature of "rebase" that was completely broken in v2.29.0 release. The tarballs are found at: https://www.kernel.org/pub/software/scm/git/ The following

[PATCH v2 1/7] platform/chrome: cros_ec_typec: Relocate set_port_params_v*() functions

2020-10-29 Thread Prashant Malani
Move the cros_typec_set_port_params_v0/v1() functions closer to the place where they are called, cros_typec_port_update(). While we are performing the relocation, also move cros_typec_get_mux_info() closer to its call-site. No functional changes are introduced by this commit. Signed-off-by:

[PATCH v2 2/7] platform/chrome: cros_ec_typec: Fix remove partner logic

2020-10-29 Thread Prashant Malani
The cros_unregister_ports() function can be called in situations where the partner has not been registered yet, and so its related data structures would not have been initialized. Calling cros_typec_remove_partner() in such a situation can lead to null pointer dereferences. So, only call

[PATCH v2 3/7] platform/chrome: cros_ec_typec: Clear partner identity on device removal

2020-10-29 Thread Prashant Malani
The partner identity struct isn't reset when a partner is removed, meaning a subsequent partner can inherit an old partner's identity VDOs before discovery is complete. So, clear that struct when a partner removal is detected. Signed-off-by: Prashant Malani --- Changes in v2: - No changes.

[PATCH v2 0/7] platform/chrome: cros_ec_typec: Register partner PD information

2020-10-29 Thread Prashant Malani
This series adds support to retrieve Type C PD(Power Delivery) Discovery information from the Chrome OS EC, and register this information with the Type C connector class framework. There are also a couple of patches which fix minor bugs with the existing cros-ec-typec driver. v1:

[PATCH v2 iproute2-next] bridge: add support for L2 multicast groups

2020-10-29 Thread Vladimir Oltean
From: Vladimir Oltean Extend the 'bridge mdb' command for the following syntax: bridge mdb add dev br0 port swp0 grp 01:02:03:04:05:06 permanent Signed-off-by: Vladimir Oltean --- Changes in v2: - Removed the const void casts. - Removed MDB_FLAGS_L2 from the UAPI to be in sync with the latest

Re: [PATCH v4 7/7] dma-buf: system_heap: Add a system-uncached heap re-using the system heap

2020-10-29 Thread John Stultz
On Thu, Oct 29, 2020 at 12:10 AM Hillf Danton wrote: > On Thu, 29 Oct 2020 00:16:24 + John Stultz wrote: > > @@ -194,6 +210,9 @@ static int system_heap_mmap(struct dma_buf *dmabuf, > > struct vm_area_struct *vma) > > struct sg_page_iter piter; > > int ret; > > > > + if

[PATCH v2 7/7] platform/chrome: cros_ec_typec: Register partner altmodes

2020-10-29 Thread Prashant Malani
Use the discovery data from the Chrome EC to register parter altmodes with the Type C Connector Class framework. Also introduce a node struct to keep track of the list of registered alt modes. Cc: Heikki Krogerus Signed-off-by: Prashant Malani --- Changes in v2: - Changed list traversal during

[PATCH v2 4/7] platform/chrome: cros_ec: Import Type C host commands

2020-10-29 Thread Prashant Malani
Import the EC_CMD_TYPEC_STATUS and EC_CMD_TYPEC_DISCOVERY Chrome OS EC host commands from the EC code base [1]. These commands can be used by the application processor to query Power Delivery (PD) discovery information concerning connected Type C peripherals. Also add the EC_FEATURE_TYPEC_CMD

[PATCH v2 5/7] platform/chrome: cros_ec_typec: Introduce TYPEC_STATUS

2020-10-29 Thread Prashant Malani
Make a call to the newly introduced EC_CMD_TYPEC_STATUS command. Currently we just check to see if the SOP (port-partner) discovery was done and emit a debug level print for it. Subsequent patches will retrieve and parse the discovery data and fill out the Type C connector class data structures.

[PATCH v2 6/7] platform/chrome: cros_ec_typec: Parse partner PD ID VDOs

2020-10-29 Thread Prashant Malani
Use EC_CMD_TYPE_DISCOVERY to retrieve and store the discovery data for the port partner. With that data, update the PD Identity VDO values for the partner, which were earlier not initialized. Cc: Heikki Krogerus Signed-off-by: Prashant Malani --- Changes in v2: - No changes

Re: [PATCH 1/4] tools/power/cpupower: Read energy_perf_bias from sysfs

2020-10-29 Thread Shuah Khan
On 10/29/20 3:59 PM, Borislav Petkov wrote: On Thu, Oct 29, 2020 at 03:38:43PM -0600, Shuah Khan wrote: All of the other ones should be changed as such. Why add more? Because a patch should do one thing and one thing only. So a separate patch which converts them all in one go should come

[patch V2 07/18] csky/mm/highmem: Switch to generic kmap atomic

2020-10-29 Thread Thomas Gleixner
No reason having the same code in every architecture. Signed-off-by: Thomas Gleixner Acked-by: Guo Ren Cc: linux-c...@vger.kernel.org --- arch/csky/Kconfig |1 arch/csky/include/asm/highmem.h |4 +- arch/csky/mm/highmem.c | 75

[patch V2 15/18] io-mapping: Cleanup atomic iomap

2020-10-29 Thread Thomas Gleixner
Switch the atomic iomap implementation over to kmap_local and stick the preempt/pagefault mechanics into the generic code similar to the kmap_atomic variants. Rename the x86 map function in preparation for a non-atomic variant. Signed-off-by: Thomas Gleixner --- V2: New patch to make review

[patch V2 16/18] sched: highmem: Store local kmaps in task struct

2020-10-29 Thread Thomas Gleixner
Instead of storing the map per CPU provide and use per task storage. That prepares for local kmaps which are preemptible. The context switch code is preparatory and not yet in use because kmap_atomic() runs with preemption disabled. Will be made usable in the next step. The context switch logic

[patch V2 02/18] mm/highmem: Un-EXPORT __kmap_atomic_idx()

2020-10-29 Thread Thomas Gleixner
Nothing in modules can use that. Signed-off-by: Thomas Gleixner Reviewed-by: Christoph Hellwig Cc: Andrew Morton Cc: linux...@kvack.org --- mm/highmem.c |2 -- 1 file changed, 2 deletions(-) --- a/mm/highmem.c +++ b/mm/highmem.c @@ -108,8 +108,6 @@ static inline wait_queue_head_t

[patch V2 06/18] ARM: highmem: Switch to generic kmap atomic

2020-10-29 Thread Thomas Gleixner
No reason having the same code in every architecture. Signed-off-by: Thomas Gleixner Cc: Russell King Cc: Arnd Bergmann Cc: linux-arm-ker...@lists.infradead.org diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig index e00d94b16658..410235e350cc 100644 --- a/arch/arm/Kconfig +++

[patch V2 05/18] arc/mm/highmem: Use generic kmap atomic implementation

2020-10-29 Thread Thomas Gleixner
Adopt the map ordering to match the other architectures and the generic code. Signed-off-by: Thomas Gleixner Cc: Vineet Gupta Cc: linux-snps-...@lists.infradead.org --- arch/arc/Kconfig |1 arch/arc/include/asm/highmem.h |8 ++- arch/arc/mm/highmem.c | 44

[patch V2 18/18] io-mapping: Provide iomap_local variant

2020-10-29 Thread Thomas Gleixner
Similar to kmap local provide a iomap local variant which only disables migration, but neither disables pagefaults nor preemption. Signed-off-by: Thomas Gleixner --- V2: Split out from the large combo patch and add the !IOMAP_ATOMIC variants --- include/linux/io-mapping.h | 34

[tip:x86/entry] BUILD SUCCESS c8d5ed67936fddbe2ae845fc80397718006322d7

2020-10-29 Thread kernel test robot
powerpc allyesconfig powerpc allmodconfig powerpc allnoconfig x86_64 randconfig-a001-20201029 x86_64 randconfig-a002-20201029 x86_64 randconfig-a003-20201029 x86_64

[patch V2 11/18] powerpc/mm/highmem: Switch to generic kmap atomic

2020-10-29 Thread Thomas Gleixner
No reason having the same code in every architecture Signed-off-by: Thomas Gleixner Cc: Michael Ellerman Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: linuxppc-...@lists.ozlabs.org --- arch/powerpc/Kconfig |1 arch/powerpc/include/asm/highmem.h |6 ++-

[patch V2 01/18] sched: Make migrate_disable/enable() independent of RT

2020-10-29 Thread Thomas Gleixner
Now that the scheduler can deal with migrate disable properly, there is no real compelling reason to make it only available for RT. There are quite some code pathes which needlessly disable preemption in order to prevent migration and some constructs like kmap_atomic() enforce it implicitly.

[patch V2 04/18] x86/mm/highmem: Use generic kmap atomic implementation

2020-10-29 Thread Thomas Gleixner
Convert X86 to the generic kmap atomic implementation and make the iomap_atomic() naming convention consistent while at it. Signed-off-by: Thomas Gleixner Cc: x...@kernel.org --- arch/x86/Kconfig |3 +- arch/x86/include/asm/fixmap.h |1 arch/x86/include/asm/highmem.h |

  1   2   3   4   5   6   7   8   9   10   >