Re: [PATCH net v2 1/3] ethernet: ucc_geth: set dev->max_mtu to 1518

2020-12-20 Thread Vladimir Oltean
On Fri, Dec 18, 2020 at 11:55:36AM +0100, Rasmus Villemoes wrote: > All the buffers and registers are already set up appropriately for an > MTU slightly above 1500, so we just need to expose this to the > networking stack. AFAICT, there's no need to implement .ndo_change_mtu > when the receive

Re: [PATCH] mm/userfaultfd: fix memory corruption due to writeprotect

2020-12-20 Thread Nadav Amit
> On Dec 19, 2020, at 10:05 PM, Yu Zhao wrote: > > On Sat, Dec 19, 2020 at 01:34:29PM -0800, Nadav Amit wrote: >> [ cc’ing some more people who have experience with similar problems ] >> >>> On Dec 19, 2020, at 11:15 AM, Andrea Arcangeli wrote: >>> >>> Hello, >>> >>> On Fri, Dec 18, 2020 at

[PATCH] IB/sa: Fix memleak in ib_nl_make_request

2020-12-20 Thread Dinghao Liu
When rdma_nl_multicast() fails, skb should be freed just like when ibnl_put_msg() fails. Signed-off-by: Dinghao Liu --- drivers/infiniband/core/sa_query.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/infiniband/core/sa_query.c

[PATCH v2 0/5] Fix the incorrect memmep defer init handling and do some cleanup

2020-12-20 Thread Baoquan He
VMware reported the performance regression during memmap_init() invocation. And they bisected to commit 73a6e474cb376 ("mm: memmap_init: iterate over memblock regions rather that check each PFN") causing it.

[PATCH v2 2/5] mm: rename memmap_init() and memmap_init_zone()

2020-12-20 Thread Baoquan He
The current memmap_init_zone() only handles memory region inside one zone, actually memmap_init() does the memmap init of one zone. So rename both of them accordingly. And also rename the function parameter 'range_start_pfn' and local variable 'range_end_pfn' of memmap_init() to

[PATCH v2 3/5] mm: simplify parater of function memmap_init_zone()

2020-12-20 Thread Baoquan He
As David suggested, simply passing 'struct zone *zone' is enough. We can get all needed information from 'struct zone*' easily. Suggested-by: David Hildenbrand Signed-off-by: Baoquan He --- arch/ia64/include/asm/pgtable.h | 3 +-- arch/ia64/mm/init.c | 12 +++-

[PATCH v2 4/5] mm: simplify parameter of setup_usemap()

2020-12-20 Thread Baoquan He
Parameter 'zone' has got needed information, let's remove other unnecessary parameters. Signed-off-by: Baoquan He --- mm/page_alloc.c | 17 +++-- 1 file changed, 7 insertions(+), 10 deletions(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 7a6626351ed7..7f0a917ab858 100644

[PATCH v2 5/5] mm: remove unneeded local variable in free_area_init_core

2020-12-20 Thread Baoquan He
Local variable 'zone_start_pfn' is not needed since there's only one call site in free_area_init_core(). Let's remove it and pass zone->zone_start_pfn directly to init_currently_empty_zone(). Signed-off-by: Baoquan He --- mm/page_alloc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)

[PATCH v2 1/5] mm: memmap defer init dosn't work as expected

2020-12-20 Thread Baoquan He
VMware observed a performance regression during memmap init on their platform, and bisected to commit 73a6e474cb376 ("mm: memmap_init: iterate over memblock regions rather that check each PFN") causing it. Before the commit: [0.033176] Normal zone: 1445888 pages used for memmap [0.033176]

[PATCH] net: ethernet: mvneta: Fix error handling in mvneta_probe

2020-12-20 Thread Dinghao Liu
When mvneta_port_power_up() fails, we should execute cleanup functions after label err_netdev to avoid memleak. Fixes: 41c2b6b4f0f80 ("net: ethernet: mvneta: Add back interface mode validation") Signed-off-by: Dinghao Liu --- drivers/net/ethernet/marvell/mvneta.c | 2 +- 1 file changed, 1

[PATCH v3] pinctrl: remove empty lines in pinctrl subsystem

2020-12-20 Thread Zhaoyu Liu
Remove all empty lines at the end of functions in pinctrl subsystem, and make the code neat. Reviewed-by: Bjorn Andersson Reviewed-by: Geert Uytterhoeven Reviewed-by: Linus Walleij Reviewed-by: Andy Shevchenko Signed-off-by: Zhaoyu Liu --- Changelog: v3: - Rebuild the patch based on "devel"

Fair Pay Initiative, OS is now €-X.

2020-12-20 Thread Ywe Cærlyn
We think we can simplify the name to €-X, Euro being optimal for a digital currency. I have updated my homepage: https://ihsan-code.eu/ Serenity, Ywe Cærlyn.

Re: [PATCH] Add spi-nor driver for Realtek RTL838x/RTL839x switch SoCs

2020-12-20 Thread Chuanhong Guo
Hi! On Sun, Dec 20, 2020 at 7:01 AM Bert Vermeulen wrote: > > On 12/16/20 9:30 AM, tudor.amba...@microchip.com wrote: > > On 12/15/20 11:46 PM, Bert Vermeulen wrote: > >> This driver supports the spiflash core in all RTL838x/RTL839x SoCs, > >> and likely some older models as well (RTL8196C). >

[PATCH] m68k: Enable seccomp architecture tracking

2020-12-20 Thread Geert Uytterhoeven
To enable seccomp constant action bitmaps, we need to have a static mapping to the audit architecture and system call table size. Signed-off-by: Geert Uytterhoeven --- Needed for CONFIG_SECCOMP_CACHE_DEBUG. Note that upstream doesn't have m68k seccomp support yet. arch/m68k/include/asm/Kbuild

Re: [RFC PATCH 0/13] sparc32: sunset sun4m and sun4d

2020-12-20 Thread Julian Calaby
Hi Romain, Sam, On Sun, Dec 20, 2020 at 6:46 PM Romain Dolbeau wrote: > > Le sam. 19 déc. 2020 à 22:41, Sam Ravnborg a écrit : > > Another said that it would be a shame to sunset sun4m and sun4d because > > there are so many machines around, and netbsd is also active on the > > sparc32 area. >

[GIT PULL] KVM changes for Linux 5.11

2020-12-20 Thread Paolo Bonzini
Linus, The following changes since commit 701f49065e68741a26752e6ae235c02bcafa2424: arm64: mark __system_matches_cap as __maybe_unused (2020-12-03 16:54:57 +) are available in the Git repository at: https://git.kernel.org/pub/scm/virt/kvm/kvm.git tags/for-linus for you to fetch

Re: [RFC PATCH 0/13] sparc32: sunset sun4m and sun4d

2020-12-20 Thread Romain Dolbeau
Le dim. 20 déc. 2020 à 09:54, Julian Calaby a écrit : > If I want to run them, assuming the hardware still works, I need to > netboot them as I cannot find working, compatible HDDs for them as > everything has switched to SATA or SAS. SCSI2SD

[PATCH v2 1/5] venus: vdec: Fix non reliable setting of LAST flag

2020-12-20 Thread Stanimir Varbanov
In real use of dynamic-resolution-change it is observed that the LAST buffer flag (which marks the last decoded buffer with the resolution before the resolution-change event) is not reliably set. Fix this by set the LAST buffer flag on next queued capture buffer after the resolution-change event.

[PATCH v2 0/5] Venus dynamic resolution change fixes

2020-12-20 Thread Stanimir Varbanov
Hi, Changes since v1: * In 1/5 - clear next_buf_last flag before session_continue in vdec_start_capture - on event, flush output buffers unconditiannly * Added two more patches from Alex (4/5) and Fritz (5/5) v1 can be found at: https://www.spinics.net/lists/linux-media/msg177801.html

[PATCH v2 4/5] media: venus: preserve DRC state across seeks

2020-12-20 Thread Stanimir Varbanov
From: Alexandre Courbot DRC events can happen virtually at anytime, including when we are starting a seek. Should this happen, we must make sure to return to the DRC state, otherwise the firmware will expect buffers of the new resolution whereas userspace will still work with the old one.

[PATCH v2 5/5] venus: vdec: Handle DRC after drain

2020-12-20 Thread Stanimir Varbanov
From: Fritz Koenig If the DRC is near the end of the stream the client may send a V4L2_DEC_CMD_STOP before the DRC occurs. V4L2_DEC_CMD_STOP puts the driver into the VENUS_DEC_STATE_DRAIN state. DRC must be aware so that after the DRC event the state can be restored correctly. Signed-off-by:

[PATCH v2 3/5] venus: helpers: Lock outside of buffer queue helper

2020-12-20 Thread Stanimir Varbanov
After adding more logic in vdec buf_queue vb2 op it is not practical to have two lock/unlock for one decoder buf_queue. So move the instance lock in encoder and decoder vb2 buf_queue operations. Signed-off-by: Stanimir Varbanov --- drivers/media/platform/qcom/venus/helpers.c | 11 +++

[PATCH v2 2/5] venus: vdec: Make decoder return LAST flag for sufficient event

2020-12-20 Thread Stanimir Varbanov
This makes the decoder to behaives equally for sufficient and insufficient events. After this change the LAST buffer flag will be set when the new resolution (in dynamic-resolution-change state) is smaller then the old bitstream resolution. Signed-off-by: Stanimir Varbanov ---

Re: INFO: rcu detected stall in tipc_release

2020-12-20 Thread syzbot
syzbot suspects this issue was fixed by commit: commit cc00bcaa589914096edef7fb87ca5cee4a166b5c Author: Subash Abhinov Kasiviswanathan Date: Wed Nov 25 18:27:22 2020 + netfilter: x_tables: Switch synchronization to RCU bisection log:

[PATCH v5 4/6] staging: mt7621-dts: make use of new 'mt7621-clk'

2020-12-20 Thread Sergio Paracuellos
Clocks for SoC mt7621 have been properly integrated so there is no need to declare fixed clocks at all in the device tree. Remove all of them, add new device tree nodes for mt7621-clk and update the rest of the nodes to use them. Signed-off-by: Sergio Paracuellos ---

[PATCH v5 0/6] MIPS: ralink: add CPU clock detection and clock driver for MT7621

2020-12-20 Thread Sergio Paracuellos
This patchset ports CPU clock detection for MT7621 from OpenWrt and adds a complete clock plan for the mt7621 SOC. The documentation for this SOC only talks about two registers regarding to the clocks: * SYSC_REG_CPLL_CLKCFG0 - provides some information about boostrapped refclock. PLL and

[PATCH v5 3/6] clk: ralink: add clock driver for mt7621 SoC

2020-12-20 Thread Sergio Paracuellos
The documentation for this SOC only talks about two registers regarding to the clocks: * SYSC_REG_CPLL_CLKCFG0 - provides some information about boostrapped refclock. PLL and dividers used for CPU and some sort of BUS. * SYSC_REG_CPLL_CLKCFG1 - a banch of gates to enable/disable clocks for all or

[PATCH v5 2/6] dt: bindings: add mt7621-clk device tree binding documentation

2020-12-20 Thread Sergio Paracuellos
Adds device tree binding documentation for clocks in the MT7621 SOC. Signed-off-by: Sergio Paracuellos --- .../bindings/clock/mediatek,mt7621-clk.yaml | 52 +++ 1 file changed, 52 insertions(+) create mode 100644

[PATCH v5 6/6] MAINTAINERS: add MT7621 CLOCK maintainer

2020-12-20 Thread Sergio Paracuellos
Adding myself as maintainer for mt7621 clock driver. Signed-off-by: Sergio Paracuellos --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index f5eafee83bc6..f0c51d9760ec 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -11247,6 +11247,12 @@ L:

[PATCH v5 5/6] staging: mt7621-dts: use valid vendor 'mediatek' instead of invalid 'mtk'

2020-12-20 Thread Sergio Paracuellos
Vendor listed for mediatek in kernel vendor file 'vendor-prefixes.yaml' contains 'mediatek' as a valid vendor string. Some nodes in the device tree are using an invalid vendor string vfor 'mtk' instead. Fix all of them in dts file. Update also ralink mt7621 related code to properly match new

[PATCH v5 1/6] dt-bindings: clock: add dt binding header for mt7621 clocks

2020-12-20 Thread Sergio Paracuellos
Adds dt binding header for 'mediatek,mt7621-clk' clocks. Acked-by: Rob Herring Signed-off-by: Sergio Paracuellos --- include/dt-bindings/clock/mt7621-clk.h | 41 ++ 1 file changed, 41 insertions(+) create mode 100644 include/dt-bindings/clock/mt7621-clk.h diff --git

Re: [PATCH v1 0/4] s390/kvm: fix MVPG when in VSIE

2020-12-20 Thread David Hildenbrand
On 18.12.20 15:18, Claudio Imbrenda wrote: > The current handling of the MVPG instruction when executed in a nested > guest is wrong, and can lead to the nested guest hanging. Hi, thanks for spotting and debugging! Is this related to nested guests hanging while migrating (mentioned by Janosch at

Re: [PATCH v1 1/4] s390/kvm: VSIE: stop leaking host addresses

2020-12-20 Thread David Hildenbrand
On 18.12.20 15:18, Claudio Imbrenda wrote: > The addresses in the SIE control block of the host should not be > forwarded to the guest. They are only meaningful to the host, and > moreover it would be a clear security issue. It's really almost impossible for someone without access to

Re: [RFC PATCH] badblocks: Improvement badblocks_set() for handling multiple ranges

2020-12-20 Thread Coly Li
On 12/20/20 4:02 AM, antlists wrote: > On 03/12/2020 17:15, Coly Li wrote: >> This patch is an initial effort to improve badblocks_set() for setting >> bad blocks range when it covers multiple already set bad ranges in the >> bad blocks table, and to do it as fast as possible. > > Is this your

Re: [RFC PATCH] badblocks: Improvement badblocks_set() for handling multiple ranges

2020-12-20 Thread Coly Li
On 12/18/20 11:25 AM, Dan Williams wrote: > [ add Neil, original gooodguy who wrote badblocks ] > > > On Thu, Dec 3, 2020 at 9:16 AM Coly Li wrote: >> >> Recently I received a bug report that current badblocks code does not >> properly handle multiple ranges. For example, >>

[PATCH] MAINTAINERS: mark dca driver orphan

2020-12-20 Thread Lukas Bulwahn
The dca driver did not have any maintainer section since its inclusion. As discussed with Dan Williams, there is no maintainer for this driver since the initial developers moved away. Introduce a new DIRECT CACHE ACCESS (DCA) DRIVER section and mark the driver orphan. Signed-off-by: Lukas

Re: [RFC PATCH 0/13] sparc32: sunset sun4m and sun4d

2020-12-20 Thread Julian Calaby
Hi Romain, On Sun, Dec 20, 2020 at 8:26 PM Romain Dolbeau wrote: > > Le dim. 20 déc. 2020 à 09:54, Julian Calaby a écrit > : > > If I want to run them, assuming the hardware still works, I need to > > netboot them as I cannot find working, compatible HDDs for them as > > everything has

Re: [PATCH] mm/userfaultfd: fix memory corruption due to writeprotect

2020-12-20 Thread Yu Zhao
On Sun, Dec 20, 2020 at 12:06:38AM -0800, Nadav Amit wrote: > > On Dec 19, 2020, at 10:05 PM, Yu Zhao wrote: > > > > On Sat, Dec 19, 2020 at 01:34:29PM -0800, Nadav Amit wrote: > >> [ cc’ing some more people who have experience with similar problems ] > >> > >>> On Dec 19, 2020, at 11:15 AM,

[PATCH] epoll: fix compat syscall wire up of epoll_pwait2

2020-12-20 Thread Heiko Carstens
Commit b0a0c2615f6f ("epoll: wire up syscall epoll_pwait2") wired up the 64 bit syscall instead of the compat variant in a couple of places. Cc: Willem de Bruijn Cc: Al Viro Cc: Arnd Bergmann Cc: Matthew Wilcox (Oracle) Cc: Catalin Marinas Cc: Will Deacon Cc: Thomas Bogendoerfer Cc: Vasily

Re: [PATCH v1 4/4] s390/kvm: VSIE: correctly handle MVPG when in VSIE

2020-12-20 Thread David Hildenbrand
On 18.12.20 15:18, Claudio Imbrenda wrote: > Correctly handle the MVPG instruction when issued by a VSIE guest. > I remember that MVPG SIE documentation was completely crazy and full of corner cases. :) Looking at arch/s390/kvm/intercept.c:handle_mvpg_pei(), I can spot that 1. "This

Re: 5.10.1: UBSAN: shift-out-of-bounds in ./include/linux/log2.h:57:1

2020-12-20 Thread Toralf Förster
On 12/20/20 2:09 AM, Randy Dunlap wrote: On 12/18/20 2:20 AM, Toralf Förster wrote: On 12/18/20 7:54 AM, Randy Dunlap wrote: Hi, [adding linux-mm] On 12/16/20 1:54 AM, Toralf Förster wrote: Hi, I got this recently at this hardened Gentoo Linux server: Linux mr-fox 5.10.1 #1 SMP Tue Dec 15

RE: [EXT] Re: [PATCH net v3] net: mvpp2: Fix GoP port 3 Networking Complex Control configurations

2020-12-20 Thread Stefan Chulski
> External Email > > -- > On Thu, 17 Dec 2020 14:37:28 +0200 stef...@marvell.com wrote: > > From: Stefan Chulski > > > > During GoP port 2 Networking Complex Control mode of operation > > configurations, also GoP port 3 mode of

[PATCH net v4] net: mvpp2: Fix GoP port 3 Networking Complex Control configurations

2020-12-20 Thread stefanc
From: Stefan Chulski During GoP port 2 Networking Complex Control mode of operation configurations, also GoP port 3 mode of operation was wrongly set. Patch removes these configurations. Fixes: f84bf386f395 ("net: mvpp2: initialize the GoP") Acked-by: Marcin Wojtas Signed-off-by: Stefan

[PATCH 1/1] v4l: ioctl: Fix memory leak in video_usercopy

2020-12-20 Thread Sakari Ailus
When an IOCTL with argument size larger than 128 that also used array arguments were handled, two memory allocations were made but alas, only the latter one of them was released. This happened because there was only a single local variable to hold such a temporary allocation. Fix this by adding

Re: [PATCH 1/1] v4l: ioctl: Fix memory leak in video_usercopy

2020-12-20 Thread Hans Verkuil
On 20/12/2020 12:06, Sakari Ailus wrote: > When an IOCTL with argument size larger than 128 that also used array > arguments were handled, two memory allocations were made but alas, only > the latter one of them was released. This happened because there was only > a single local variable to hold

RE: [EXT] Re: [PATCH net-next] net: mvpp2: prs: improve ipv4 parse flow

2020-12-20 Thread Stefan Chulski
> > -- > On Thu, 17 Dec 2020 18:07:58 +0200 stef...@marvell.com wrote: > > From: Stefan Chulski > > > > Patch didn't fix any issue, just improve parse flow and align ipv4 > > parse flow with ipv6 parse flow. > > > > Currently

Re: [PATCH] m68k: Enable seccomp architecture tracking

2020-12-20 Thread John Paul Adrian Glaubitz
Hi Geert! On 12/20/20 9:51 AM, Geert Uytterhoeven wrote: > To enable seccomp constant action bitmaps, we need to have a static > mapping to the audit architecture and system call table size. > > Signed-off-by: Geert Uytterhoeven > --- > Needed for CONFIG_SECCOMP_CACHE_DEBUG. > Note that

Re: [PATCH] ovl: fix dentry leak in ovl_get_redirect

2020-12-20 Thread Joseph Qi
On 12/19/20 12:17 AM, Liangyan wrote: > We need to lock d_parent->d_lock before dget_dlock, or this may > have d_lockref updated parallelly like calltrace below which will > cause dentry->d_lockref leak and risk a crash. > > npm-20576 [028] 5705749.040094: > [28]

Re: [PATCH] inotify, memcg: account inotify instances to kmemcg

2020-12-20 Thread Amir Goldstein
On Sun, Dec 20, 2020 at 6:24 AM Shakeel Butt wrote: > > On Sat, Dec 19, 2020 at 8:25 AM Amir Goldstein wrote: > > > > On Sat, Dec 19, 2020 at 4:31 PM Shakeel Butt wrote: > > > > > > On Sat, Dec 19, 2020 at 1:48 AM Amir Goldstein wrote: > > > > > > > > On Sat, Dec 19, 2020 at 12:11 AM Shakeel

Re: [PATCH v2] inotify, memcg: account inotify instances to kmemcg

2020-12-20 Thread Amir Goldstein
On Sun, Dec 20, 2020 at 6:46 AM Shakeel Butt wrote: > > Currently the fs sysctl inotify/max_user_instances is used to limit the > number of inotify instances on the system. For systems running multiple > workloads, the per-user namespace sysctl max_inotify_instances can be > used to further

Re: [PATCH 1/1] v4l: ioctl: Fix memory leak in video_usercopy

2020-12-20 Thread Arnd Bergmann
On Sun, Dec 20, 2020 at 12:06 PM Sakari Ailus wrote: > > When an IOCTL with argument size larger than 128 that also used array > arguments were handled, two memory allocations were made but alas, only > the latter one of them was released. This happened because there was only > a single local

Re: [PATCH] epoll: fix compat syscall wire up of epoll_pwait2

2020-12-20 Thread Arnd Bergmann
On Sun, Dec 20, 2020 at 11:00 AM Heiko Carstens wrote: > > Commit b0a0c2615f6f ("epoll: wire up syscall epoll_pwait2") wired up > the 64 bit syscall instead of the compat variant in a couple of places. > > Cc: Willem de Bruijn > Cc: Al Viro > Cc: Arnd Bergmann > Cc: Matthew Wilcox (Oracle) >

Re: [PATCH 1/1] v4l: ioctl: Fix memory leak in video_usercopy

2020-12-20 Thread Sakari Ailus
On Sun, Dec 20, 2020 at 12:36:23PM +0100, Arnd Bergmann wrote: > On Sun, Dec 20, 2020 at 12:06 PM Sakari Ailus > wrote: > > > > When an IOCTL with argument size larger than 128 that also used array > > arguments were handled, two memory allocations were made but alas, only > > the latter one of

Re: [PATCH AUTOSEL 5.4 08/10] selftests/bpf: Fix array access with signed variable test

2020-12-20 Thread Jean-Philippe Brucker
Hi, On Sat, Dec 19, 2020 at 10:34:55PM -0500, Sasha Levin wrote: > From: Jean-Philippe Brucker > > [ Upstream commit 77ce220c0549dcc3db8226c61c60e83fc59dfafc ] > > The test fails because of a recent fix to the verifier, even though this That fix is commit b02709587ea3 ("bpf: Fix propagation

[PATCH v2] ovl: fix dentry leak in ovl_get_redirect

2020-12-20 Thread Liangyan
We need to lock d_parent->d_lock before dget_dlock, or this may have d_lockref updated parallelly like calltrace below which will cause dentry->d_lockref leak and risk a crash. npm-20576 [028] 5705749.040094: [28] ovl_set_redirect+0x11c/0x310 //tmp = dget_dlock(d->d_parent); [28]?

Re: [-next] mt76: mt7915: fix MESH ifdef block

2020-12-20 Thread Kalle Valo
Randy Dunlap wrote: > Fix a build error when CONFIG_MAC80211_MESH is not enabled: > > ../drivers/net/wireless/mediatek/mt76/mt7915/init.c:47:2: error: expected > expression before '}' token > }, { > ^ > > Fixes: af901eb4ab80 ("mt76: mt7915: get rid of dbdc debugfs knob") > Signed-off-by:

[PATCH] net/ncsi: Use real net-device for response handler

2020-12-20 Thread John Wang
When aggregating ncsi interfaces and dedicated interfaces to bond interfaces, the ncsi response handler will use the wrong net device to find ncsi_dev, so that the ncsi interface will not work properly. Here, we use the net device registered to packet_type to fix it. Fixes: 138635cc27c9

Re: [RFC] exit: do exit_task_work() before shooting off mm

2020-12-20 Thread Pavel Begunkov
On 08/12/2020 01:37, Al Viro wrote: > On Thu, Dec 03, 2020 at 02:30:46AM +, Pavel Begunkov wrote: >> Handle task works and lock it earlier before it starts killing off >> task's resources like mm. io_uring makes use of it a lot and it'd >> nicer to have all added task_work finding tasks in a

KASAN: global-out-of-bounds Read in smc_nl_get_sys_info

2020-12-20 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:3db1a3fa Merge tag 'staging-5.11-rc1' of git://git.kernel... git tree: net console output: https://syzkaller.appspot.com/x/log.txt?x=121dc93750 kernel config: https://syzkaller.appspot.com/x/.config?x=2764fc28a92339f9

Re: general protection fault in j1939_netdev_notify (2)

2020-12-20 Thread Oliver Hartkopp
Hello Oleksij, I assume there is some ndev->ml_priv value set - but not from a CAN netdevice. What was the reason to fiddle with the 'priv' stuff in j1939_netdev_notify() before checking if it was a CAN device? Would this patch fix the issue then? diff --git a/net/can/j1939/main.c

Re: general protection fault in rose_send_frame

2020-12-20 Thread syzbot
syzbot suspects this issue was fixed by commit: commit 3b3fd068c56e3fbea30090859216a368398e39bf Author: Anmol Karn Date: Thu Nov 19 19:10:43 2020 + rose: Fix Null pointer dereference in rose_send_frame() bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=139e2b9b50

Re: [PATCH] hwrng: ingenic - Fix a resource leak in an error handling path

2020-12-20 Thread Zhou Yanjie
Hi Christophe, On 2020/12/19 下午3:52, Christophe JAILLET wrote: In case of error, we should call 'clk_disable_unprepare()' to undo a previous 'clk_prepare_enable()' call, as already done in the remove function. Fixes: 406346d22278 ("hwrng: ingenic - Add hardware TRNG for Ingenic X1830")

Re: [PATCH 5.10 00/16] 5.10.2-rc1 review

2020-12-20 Thread Jon Hunter
On 19/12/2020 12:57, Greg Kroah-Hartman wrote: > This is the start of the stable review cycle for the 5.10.2 release. > There are 16 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > > Responses

Re: [RFC] exit: do exit_task_work() before shooting off mm

2020-12-20 Thread Oleg Nesterov
On 12/20, Pavel Begunkov wrote: > > On 08/12/2020 01:37, Al Viro wrote: > > On Thu, Dec 03, 2020 at 02:30:46AM +, Pavel Begunkov wrote: > >> Handle task works and lock it earlier before it starts killing off > >> task's resources like mm. io_uring makes use of it a lot and it'd > >> nicer to

Re: [PATCH 1/1] v4l: ioctl: Fix memory leak in video_usercopy

2020-12-20 Thread Laurent Pinchart
Hi Sakari, Thank you for the patch. On Sun, Dec 20, 2020 at 01:06:51PM +0200, Sakari Ailus wrote: > When an IOCTL with argument size larger than 128 that also used array > arguments were handled, two memory allocations were made but alas, only > the latter one of them was released. Alas, this

Re: [PATCH] signal: Don't init struct kernel_siginfo fields to zero again

2020-12-20 Thread Oleg Nesterov
On 12/20, Leesoo Ahn wrote: > > clear_siginfo() is responsible for clearing struct kernel_siginfo object. > It's obvious that manually initializing those fields is needless as > a commit[1] explains why the function introduced and its guarantee that > all bits in the struct are cleared after it. >

RE: [RFC PATCH 0/13] sparc32: sunset sun4m and sun4d

2020-12-20 Thread David Laight
From: Julian Calaby > Sent: 20 December 2020 08:55 > > On Sun, Dec 20, 2020 at 6:46 PM Romain Dolbeau wrote: > > > > Le sam. 19 déc. 2020 à 22:41, Sam Ravnborg a écrit : > > > Another said that it would be a shame to sunset sun4m and sun4d because > > > there are so many machines around, and

Re: [PATCH] m68k: Enable seccomp architecture tracking

2020-12-20 Thread Geert Uytterhoeven
Hi Adrian, On Sun, Dec 20, 2020 at 12:24 PM John Paul Adrian Glaubitz wrote: > On 12/20/20 9:51 AM, Geert Uytterhoeven wrote: > > To enable seccomp constant action bitmaps, we need to have a static > > mapping to the audit architecture and system call table size. > > > > Signed-off-by: Geert

Re: general protection fault in j1939_netdev_notify (2)

2020-12-20 Thread Oleksij Rempel
Hello Oliver, On Sun, Dec 20, 2020 at 02:18:27PM +0100, Oliver Hartkopp wrote: > Hello Oleksij, > > I assume there is some ndev->ml_priv value set - but not from a CAN > netdevice. it is kind of CAN device :) > What was the reason to fiddle with the 'priv' stuff in j1939_netdev_notify() >

Re: [RFC] exit: do exit_task_work() before shooting off mm

2020-12-20 Thread Pavel Begunkov
On 20/12/2020 13:58, Oleg Nesterov wrote: > On 12/20, Pavel Begunkov wrote: >> >> On 08/12/2020 01:37, Al Viro wrote: >>> On Thu, Dec 03, 2020 at 02:30:46AM +, Pavel Begunkov wrote: Handle task works and lock it earlier before it starts killing off task's resources like mm. io_uring

RE: [PATCH 0/2] drop unused POWER_AVS option for ARM/ARM64 config

2020-12-20 Thread ZHIZHIKIN Andrey
Hello Arnd, A while ago, I've submitted this series to clean-up the unused POWER_AVS config option, and It looks like it did not land in anyone's tree until now. Similar patch to clean-up the same option in omap2plus_defconfig has been already picked up by Tony Lindgren and is already present

[PATCH v2 1/5] csky: Remove custom asm/atomic.h implementation

2020-12-20 Thread guoren
From: Guo Ren Use generic atomic implementation based on cmpxchg. So remove csky asm/atomic.h. Signed-off-by: Guo Ren Cc: Peter Zijlstra Cc: Arnd Bergmann Cc: Paul E. McKenney --- arch/csky/include/asm/atomic.h | 212 - 1 file changed, 212

Re: [PATCH] staging: qlge: Removed duplicate word in comment.

2020-12-20 Thread Kari Argillander
On Fri, Dec 18, 2020 at 05:48:29PM -0800, Daniel West wrote: > This patch fixes the checkpatch warning: > > WARNING: Possible repeated word: 'and' > > Signed-off-by: Daniel West > --- > drivers/staging/qlge/qlge_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH] fs: io_uring.c: Add skip option for __io_sqe_files_update

2020-12-20 Thread Pavel Begunkov
On 20/12/2020 06:50, noah wrote:> From: noah > > This patch makes it so that specify a file descriptor value of -2 will > skip updating the corresponding fixed file index. > > This will allow for users to reduce the number of syscalls necessary > to update a sparse file range when using the

Re: [PATCH] signal: Don't init struct kernel_siginfo fields to zero again

2020-12-20 Thread Christian Brauner
On Sun, Dec 20, 2020 at 04:45:54PM +0900, Leesoo Ahn wrote: > clear_siginfo() is responsible for clearing struct kernel_siginfo object. > It's obvious that manually initializing those fields is needless as > a commit[1] explains why the function introduced and its guarantee that > all bits in the

[PATCH] block: aoe: Use seq_putc() if possible

2020-12-20 Thread Amey Narkhede
This is a single character that is printed out. Use seq_putc() for it to simplify the code. Signed-off-by: Amey Narkhede --- drivers/block/aoe/aoeblk.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/block/aoe/aoeblk.c b/drivers/block/aoe/aoeblk.c index

Re: [PATCH 8455/8455] staging: rtl8188eu: core: fixed a comment format issue.

2020-12-20 Thread Kari Argillander
On Sat, Dec 19, 2020 at 02:43:12PM -0800, Daniel West wrote: > Fixed a checkpatch warning: > > WARNING: Block comments use * on subsequent lines > #4595: FILE: drivers/staging/rtl8188eu/core/rtw_mlme_ext.c:4595: > +/ > +

Re: [PATCH] Add spi-nor driver for Realtek RTL838x/RTL839x switch SoCs

2020-12-20 Thread Bert Vermeulen
On 12/20/20 9:51 AM, Chuanhong Guo wrote: Hi! On Sun, Dec 20, 2020 at 7:01 AM Bert Vermeulen wrote: On 12/16/20 9:30 AM, tudor.amba...@microchip.com wrote: > On 12/15/20 11:46 PM, Bert Vermeulen wrote: >> This driver supports the spiflash core in all RTL838x/RTL839x SoCs, >> and likely some

[PATCH v2 1/5] csky: Remove custom asm/atomic.h implementation

2020-12-20 Thread guoren
From: Guo Ren Use generic atomic implementation based on cmpxchg. So remove csky asm/atomic.h. Signed-off-by: Guo Ren Cc: Peter Zijlstra Cc: Arnd Bergmann Cc: Paul E. McKenney --- arch/csky/include/asm/atomic.h | 212 - 1 file changed, 212

[PATCH v2 2/5] csky: Fixup barrier design

2020-12-20 Thread guoren
From: Guo Ren Remove shareable bit for ordering barrier, just keep ordering in current hart is enough for SMP. Using three continuous sync.is as PTW barrier to prevent speculative PTW in 860 microarchitecture. Signed-off-by: Guo Ren --- arch/csky/include/asm/barrier.h | 82

[PATCH v2 4/5] csky: Fixup asm/cmpxchg.h with correct ordering barrier

2020-12-20 Thread guoren
From: Guo Ren Optimize the performance of cmpxchg by using more fine-grained acquire/release barriers. Signed-off-by: Guo Ren Cc: Peter Zijlstra Cc: Arnd Bergmann Cc: Paul E. McKenney --- arch/csky/include/asm/cmpxchg.h | 27 +-- 1 file changed, 17 insertions(+), 10

[PATCH v2 5/5] csky: Cleanup asm/spinlock.h

2020-12-20 Thread guoren
From: Guo Ren There are two implementation of spinlock in arch/csky: - simple one (NR_CPU = 1,2) - tick's one (NR_CPU = 3,4) Remove the simple one. There is already smp_mb in spinlock, so remove the definition of smp_mb__after_spinlock. Link:

[PATCH v2 3/5] csky: Fixup futex SMP implementation

2020-12-20 Thread guoren
From: Guo Ren Arnd said: I would guess that for csky, this is a mistake, as the architecture is fairly new and should be able to implement it. Guo reply: The c610, c807, c810 don't support SMP, so futex_cmpxchg_enabled = 1 with asm-generic's implementation. For c860, there is no

Re: [PATCH] signal: Don't init struct kernel_siginfo fields to zero again

2020-12-20 Thread Rae Kim
It looks like compiler optimization is smart enough to know that assigning zero is unnecessary after clear_siginfo() which is memset() under the hood. At least in my x86_64 machine, w/ or w/o this patch, there is no difference in final compiled machine code. (I've compared "objdump -d" results

Re: [PATCH 1/2] futex: mark futex_detect_cmpxchg() as 'noinline'

2020-12-20 Thread Guo Ren
Hi Arnd, On Tue, Dec 15, 2020 at 7:26 PM Arnd Bergmann wrote: > > On Tue, Dec 15, 2020 at 7:09 AM Guo Ren wrote: > > On Mon, Dec 14, 2020 at 9:15 PM Arnd Bergmann wrote: > > > I had a look at what other architectures always implement > > > futex_atomic_cmpxchg_inatomic() or can use the

Re: [PATCH] staging: rtl8192e: fix bool comparison in expressions

2020-12-20 Thread Kari Argillander
On Thu, Dec 17, 2020 at 05:12:04PM +0530, Aditya Srivastava wrote: > There are certain conditional expressions in rtl8192e, where a boolean > variable is compared with true/false, in forms such as (foo == true) or > (false != bar), which does not comply with checkpatch.pl (CHECK: >

Re: [PATCH] signal: Don't init struct kernel_siginfo fields to zero again

2020-12-20 Thread Christian Brauner
On Mon, Dec 21, 2020 at 12:43:05AM +0900, Rae Kim wrote: > > It looks like compiler optimization is smart enough to know that > assigning zero is unnecessary after clear_siginfo() which is memset() > under the hood. At least in my x86_64 machine, w/ or w/o this patch, > there is no difference in

Re: [PATCH v4 1/9] media: uvcvideo: Move guid to entity

2020-12-20 Thread Laurent Pinchart
Hi Ricardo, Thank you for the patch. On Tue, Dec 15, 2020 at 04:44:31PM +0100, Ricardo Ribalda wrote: > Instead of having multiple copies of the entity guid on the code, move > it to the entity structure. > > Reviewed-by: Laurent Pinchart > Signed-off-by: Ricardo Ribalda > --- >

Re: [PATCH v4 3/9] media: uvcvideo: Allow entities with no pads

2020-12-20 Thread Laurent Pinchart
Hi Ricardo, Thank you for the patch. On Tue, Dec 15, 2020 at 04:44:33PM +0100, Ricardo Ribalda wrote: > Avoid an underflow while calculating the number of inputs for entities > with zero pads. > > Signed-off-by: Ricardo Ribalda > --- > drivers/media/usb/uvc/uvc_driver.c | 8 ++-- > 1 file

Re: [PATCH v4 4/9] media: uvcvideo: Entity defined get_info and get_cur

2020-12-20 Thread Laurent Pinchart
Hi Ricardo, Thank you for the patch. Maybe s/Entity defined/Allow entity-defined/ in the subject line ? On Tue, Dec 15, 2020 at 04:44:34PM +0100, Ricardo Ribalda wrote: > Allows controls to get their properties and current value > from an entity-defined function instead of via a query to the

Re: [PATCH] clk: mvebu: a3700: fix the XTAL MODE pin to MPP1_9

2020-12-20 Thread Pali Rohár
On Saturday 19 December 2020 15:51:30 Stephen Boyd wrote: > Quoting Pali Rohár (2020-11-06 02:00:39) > > From: Terry Zhou > > > > There is an error in the current code that the XTAL MODE > > pin was set to NB MPP1_31 which should be NB MPP1_9. > > The latch register of NB MPP1_9 has different

Re: [PATCH] cpufreq: intel_pstate: Use most recent guaranteed performance values

2020-12-20 Thread Rafael J. Wysocki
On Sat, Dec 19, 2020 at 6:21 AM srinivas pandruvada wrote: > > On Thu, 2020-12-17 at 20:17 +0100, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > > > When turbo has been disabled by the BIOS, but HWP_CAP.GUARANTEED is > > changed later, user space may want to take advantage of this > >

[PATCH] block: aoe: replace use of __constant_htons to htons

2020-12-20 Thread Amey Narkhede
The macro htons expands to __swab16 which has special case for constants in little endian case. In big endian case both __constant_htons and htons macros expand to the same code. So, replace __constant_htons with htons to get rid of the definition of __constant_htons completely. Signed-off-by:

Re: [PATCH v4 5/9] media: uvcvideo: Implement UVC_EXT_GPIO_UNIT

2020-12-20 Thread Laurent Pinchart
Hi Ricardo, Thank you for the patch. On Tue, Dec 15, 2020 at 04:44:35PM +0100, Ricardo Ribalda wrote: > Some devices can implement a physical switch to disable the input of the > camera on demand. Think of it like an elegant privacy sticker. > > The system can read the status of the privacy

Re: [PATCH v4 2/9] media: uvcvideo: Allow external entities

2020-12-20 Thread Laurent Pinchart
Hi Ricardo, Thank you for the patch. On Tue, Dec 15, 2020 at 04:44:32PM +0100, Ricardo Ribalda wrote: > Increase the size of the id, to avoid collisions with external entities. Could you expand the commit message a bit to explain what external entities are ? > Signed-off-by: Ricardo Ribalda >

UBSAN: object-size-mismatch in wg_xmit

2020-12-20 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:5e60366d Merge tag 'fallthrough-fixes-clang-5.11-rc1' of g.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=12b12c1350 kernel config: https://syzkaller.appspot.com/x/.config?x=267a60b188ded8ed

Re: [PATCH v4 6/9] media: uvcvideo: Add Privacy control based on EXT_GPIO

2020-12-20 Thread Laurent Pinchart
Hi Ricardo, Thank you for the patch. On Tue, Dec 15, 2020 at 04:44:36PM +0100, Ricardo Ribalda wrote: > Add a new control and mapping for Privacy controls connected to > UVC_GUID_EXT_GPIO_CONTROLLERs. > > Signed-off-by: Ricardo Ribalda Reviewed-by: Laurent Pinchart > --- >

[PATCH 4/4] arm64: dtb: qcom: qrb5165-rb5: add power domain to pcie0 phy

2020-12-20 Thread Dmitry Baryshkov
If QCA6391 chip (connected to PCIe0) is not powered at the PCIe probe time, PCIe0 bus probe will timeout and the device will not be detected. To ease device power up support, use qca639x as pcie0 phy power-domain. This allows us to make sure that QCA6391 chip is powered on before PCIe0 probe

[PATCH 0/4] Add support for Qualcomm QCA639x chips family

2020-12-20 Thread Dmitry Baryshkov
Qualcomm QCA639x is a family of WiFi + Bluetooth chips, with BT part being controlled through the UART and WiFi being present on PCIe bus. Both blocks share common power sources wich should be turned on before either of devices can be probed. Declare common 'qca639x' driver providing a power

[PATCH 3/4] arm64: dts: qcom: Add Bluetooth support on RB5

2020-12-20 Thread Dmitry Baryshkov
From: Manivannan Sadhasivam Add Bluetooth support on RB5 using the onboard QCA6391 WLAN+BT chipset. Signed-off-by: Manivannan Sadhasivam [DB: added qca639x power domain] Signed-off-by: Dmitry Baryshkov --- arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 97 1 file

  1   2   3   4   >