[PATCH v4 29/37] regulator: scmi: port driver to the new scmi_voltage_proto_ops interface

2021-01-06 Thread Cristian Marussi
Port driver to the new SCMI Voltage interface based on protocol handles and common devm_get_ops(). Signed-off-by: Cristian Marussi --- drivers/regulator/scmi-regulator.c | 39 -- 1 file changed, 21 insertions(+), 18 deletions(-) diff --git

[PATCH v2 4/5] ibmvfc: complete commands outside the host/queue lock

2021-01-06 Thread Tyrel Datwyler
Drain the command queue and place all commands on a completion list. Perform command completion on that list outside the host/queue locks. Further, move purged command compeletions outside the host_lock as well. Signed-off-by: Tyrel Datwyler Reviewed-by: Brian King ---

[PATCH v2 5/5] ibmvfc: relax locking around ibmvfc_queuecommand

2021-01-06 Thread Tyrel Datwyler
The drivers queuecommand routine is still wrapped to hold the host lock for the duration of the call. This will become problematic when moving to multiple queues due to the lock contention preventing asynchronous submissions to mulitple queues. There is no real legatimate reason to hold the host

[PATCH v2 0/5] ibmvfc: MQ preparatory locking work

2021-01-06 Thread Tyrel Datwyler
The ibmvfc driver in its current form relies heavily on the host_lock. This patchset introduces a genric queue with its own queue lock and sent/free event list locks. This generic queue allows the driver to decouple the primary queue and future subordinate queues from the host lock reducing lock

Re: [PATCH] mm/mmap: replace if (cond) BUG() with BUG_ON()

2021-01-06 Thread Hugh Dickins
On Wed, 6 Jan 2021, Andrea Arcangeli wrote: > > I'd be surprised if the kernel can boot with BUG_ON() defined as "do > {}while(0)" so I guess it doesn't make any difference. I had been afraid of that too, when CONFIG_BUG is not set: but I think it's actually "if (cond) do {} while (0)".

[PATCH v4 31/37] firmware: arm_scmi: make references to handle const

2021-01-06 Thread Cristian Marussi
Now that all the protocol private variable data have been moved out of struct scmi_handle, mark all of its references as const. Signed-off-by: Cristian Marussi --- drivers/firmware/arm_scmi/common.h | 4 ++-- drivers/firmware/arm_scmi/driver.c | 12 ++-- include/linux/scmi_protocol.h

[PATCH v4 34/37] firmware: arm_scmi: cleanup events registration transient code

2021-01-06 Thread Cristian Marussi
Remove all the events registration code used to ease the transition to the new interface based on protocol handles.. Signed-off-by: Cristian Marussi --- drivers/firmware/arm_scmi/base.c| 4 ++-- drivers/firmware/arm_scmi/notify.h | 6 +++--- drivers/firmware/arm_scmi/perf.c| 9

[PATCH v4 26/37] firmware: arm_scmi: remove legacy scmi_sensor_ops protocol interface

2021-01-06 Thread Cristian Marussi
Now that all the SCMI driver users have been migrated to the new interface remove the legacy interface and all the transient code. Signed-off-by: Cristian Marussi --- drivers/firmware/arm_scmi/sensors.c | 82 - include/linux/scmi_protocol.h | 19 --- 2

[PATCH v4 18/37] firmware: arm_scmi: port Clock protocol to new protocols interface

2021-01-06 Thread Cristian Marussi
Convert internals of protocol implementation to use protocol handles and expose a new protocol operations interface for SCMI driver using the new get/put common operations, while keeping the old handle->clk_ops still around to ease transition. Remove handle->clock_priv now unused. Signed-off-by:

[PATCH v4 14/37] firmware: arm_scmi: remove legacy scmi_perf_ops protocol interface

2021-01-06 Thread Cristian Marussi
Now that all the SCMI driver users have been migrated to the new interface remove the legacy interface and all the transient code. Signed-off-by: Cristian Marussi --- drivers/firmware/arm_scmi/perf.c | 120 --- include/linux/scmi_protocol.h| 27 --- 2 files

[PATCH v4 17/37] firmware: arm_scmi: remove legacy scmi_power_ops protocol interface

2021-01-06 Thread Cristian Marussi
Now that all the SCMI driver users have been migrated to the new interface remove the legacy interface and all the transient code. Signed-off-by: Cristian Marussi --- drivers/firmware/arm_scmi/power.c | 47 --- include/linux/scmi_protocol.h | 11 2 files

[PATCH v4 32/37] firmware: arm_scmi: cleanup legacy protocol init code

2021-01-06 Thread Cristian Marussi
Now that all protocols and drivers have been ported to the new interface based on protocol handles and get/put operations, remove all the legacy transient initialization code. Signed-off-by: Cristian Marussi --- drivers/firmware/arm_scmi/bus.c| 26 +-

[PATCH v4 28/37] firmware: arm_scmi: port Voltage protocol to new protocols interface

2021-01-06 Thread Cristian Marussi
Convert internals of protocol implementation to use protocol handles and expose a new protocol operations interface for SCMI driver using the new get/put common operations, while keeping the old handle->voltage_ops still around to ease transition. Remove handle->voltage_priv now unused.

[PATCH v4 25/37] hwmon: (scmi) port driver to the new scmi_sensor_proto_ops interface

2021-01-06 Thread Cristian Marussi
Port driver to the new SCMI Sensor interface based on protocol handles and common devm_get_ops(). Signed-off-by: Cristian Marussi --- drivers/hwmon/scmi-hwmon.c | 24 +++- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/drivers/hwmon/scmi-hwmon.c

[PATCH v4 33/37] firmware: arm_scmi: cleanup unused core xfer wrappers

2021-01-06 Thread Cristian Marussi
Remove unused core scmi_xfer wrappers now that we have migrated all protocols to the new interface based on protocol handles. Signed-off-by: Cristian Marussi --- drivers/firmware/arm_scmi/common.h | 15 - drivers/firmware/arm_scmi/driver.c | 91 -- 2 files

[PATCH v4 20/37] firmware: arm_scmi: remove legacy scmi_clk_ops protocol interface

2021-01-06 Thread Cristian Marussi
Now that all the SCMI driver users have been migrated to the new interface remove the legacy interface and all the transient code. Signed-off-by: Cristian Marussi --- drivers/firmware/arm_scmi/clock.c | 67 --- include/linux/scmi_protocol.h | 15 --- 2 files

[PATCH v4 23/37] firmware: arm_scmi: remove legacy scmi_reset_ops protocol interface

2021-01-06 Thread Cristian Marussi
Now that all the SCMI driver users have been migrated to the new interface remove the legacy interface and all the transient code. Signed-off-by: Cristian Marussi --- drivers/firmware/arm_scmi/reset.c | 68 --- include/linux/scmi_protocol.h | 11 - 2 files

[PATCH v4 16/37] firmware: arm_scmi: port GenPD driver to the new scmi_power_proto_ops interface

2021-01-06 Thread Cristian Marussi
Port driver to the new SCMI Power interface based on protocol handles and common devm_get_ops(). Signed-off-by: Cristian Marussi --- drivers/firmware/arm_scmi/scmi_pm_domain.c | 26 +- 1 file changed, 16 insertions(+), 10 deletions(-) diff --git

[PATCH v4 19/37] clk: scmi: port driver to the new scmi_clk_proto_ops interface

2021-01-06 Thread Cristian Marussi
Port driver to the new SCMI Clock interface based on protocol handles and common devm_get_ops(). Signed-off-by: Cristian Marussi --- drivers/clk/clk-scmi.c | 27 +-- 1 file changed, 17 insertions(+), 10 deletions(-) diff --git a/drivers/clk/clk-scmi.c

[PATCH v4 12/37] firmware: arm_scmi: port Perf protocol to new protocols interface

2021-01-06 Thread Cristian Marussi
Convert internals of protocol implementation to use protocol handles and expose a new protocol operations interface for SCMI driver using the new get/put common operations, while keeping the old handle->perf_ops still around to ease transition. Remove handle->perf_priv now unused. Signed-off-by:

[PATCH v4 11/37] firmware: arm_scmi: port Base protocol to new interface

2021-01-06 Thread Cristian Marussi
Port Base protocol to new protocol handles based interface. Signed-off-by: Cristian Marussi --- drivers/firmware/arm_scmi/base.c | 117 +++-- drivers/firmware/arm_scmi/common.h | 3 +- drivers/firmware/arm_scmi/driver.c | 14 +++- 3 files changed, 71 insertions(+),

[PATCH v4 13/37] cpufreq: scmi: port driver to the new scmi_perf_proto_ops interface

2021-01-06 Thread Cristian Marussi
Port driver to the new SCMI Perf interface based on protocol handles and common devm_get_ops(). Signed-off-by: Cristian Marussi --- drivers/cpufreq/scmi-cpufreq.c | 37 ++ 1 file changed, 20 insertions(+), 17 deletions(-) diff --git

[PATCH v4 09/37] firmware: arm_scmi: add new protocol handle core xfer ops

2021-01-06 Thread Cristian Marussi
Add new core SCMI xfer operations based on protocol handles to enable protocols to builds and send their own protocol specific messages. Keep old original scmi_xfer_ operations interface as wrappers around the new interface in order to let coexist old and new interfaces to ease protocol by

[PATCH v4 15/37] firmware: arm_scmi: port Power protocol to new protocols interface

2021-01-06 Thread Cristian Marussi
Convert internals of protocol implementation to use protocol handles and expose a new protocol operations interface for SCMI driver using the new get/put common operations, while keeping the old handle->power_ops still around to ease transition. Remove handle->power_priv now unused.

[PATCH v4 08/37] firmware: arm_scmi: convert events registration to protocol handles

2021-01-06 Thread Cristian Marussi
Convert refactored events registration routines to use protocol handles. In order to maintain bisectability and to allow protocols and drivers to be later ported to the new protocol handle interface one by one, introduce here also some transient code and typing that will be removed later in order

[PATCH v4 10/37] firmware: arm_scmi: add helper to access revision area memory

2021-01-06 Thread Cristian Marussi
Add an helper to grab, from a protocol handle, the handle common memory area allocated to store SCMI version data which is exposed on sysfs. Such helper will be needed by SCMI Base protocol initialization once it will be moved to new protocol handles scheme. Signed-off-by: Cristian Marussi ---

[PATCH v4 06/37] firmware: arm_scmi: introduce new devres notification ops

2021-01-06 Thread Cristian Marussi
Expose to the SCMI drivers a new alternative devres managed notifications API based on protocol handles. All drivers still keep using the old API, no functional change. Signed-off-by: Cristian Marussi --- drivers/firmware/arm_scmi/notify.c | 123 +

[PATCH v4 02/37] firmware: arm_scmi: introduce protocol handle definitions

2021-01-06 Thread Cristian Marussi
Add basic protocol handles definitions and private data helpers support. A protocol handle identifies a protocol instance initialized against a specific handle; it embeds all the references to the core SCMI xfer methods that will be needed by a protocol implementation to build and send its own

[PATCH v4 04/37] [RFC] firmware: arm_scmi: introduce bare get/put protocols ops

2021-01-06 Thread Cristian Marussi
Expose to the SCMI drivers a non managed version of a common protocols API based on generic get/put methods and protocol handles. All drivers still keep using the old API, no functional change. Signed-off-by: Cristian Marussi --- These non devres methods are probably not needed, given the devm_

[PATCH v4 03/37] firmware: arm_scmi: introduce devres get/put protocols operations

2021-01-06 Thread Cristian Marussi
Expose to the SCMI drivers a new devres managed common protocols API based on generic get/put methods and protocol handles. All drivers still keep using the old API, no functional change. Signed-off-by: Cristian Marussi --- drivers/firmware/arm_scmi/driver.c | 92 ++

Re: [PATCH v3 2/2] power: supply: mt6360_charger: add MT6360 charger support

2021-01-06 Thread Sebastian Reichel
Hi Gene, I have a bunch of comments, please take a look at my inline comments. On Thu, Dec 24, 2020 at 03:48:04PM +0800, Gene Chen wrote: > From: Gene Chen > > Add basic support for the battery charger for MT6360 PMIC > > Signed-off-by: Gene Chen > --- > drivers/power/supply/Kconfig

[PATCH v4 01/37] firmware: arm_scmi: review protocol registration interface

2021-01-06 Thread Cristian Marussi
Extend common protocol registration routines and provide some new generic protocols get/put helpers that can track protocols usage and automatically perform the proper initialization and de-initialization on demand when required. Convert all standard protocols to use this new registration scheme

[PATCH v4 0/37] SCMI vendor protocols and modularization

2021-01-06 Thread Cristian Marussi
Hi all, The current SCMI implementation does not provide an interface to easily develop and include a custom vendor protocol implementation as prescribed by the SCMI standard, also because, there is not currently any custom protocol in the upstream to justify the development of a custom interface

Re: [PATCH mips-next 0/4] MIPS: vmlinux.lds.S sections fix & cleanup

2021-01-06 Thread Alexander Lobakin
From: Nathan Chancellor Date: Mon, 4 Jan 2021 17:09:36 -0700 > On Mon, Jan 04, 2021 at 12:18:10PM +, Alexander Lobakin wrote: >> This series hunts the problems discovered after manual enabling of >> ARCH_WANT_LD_ORPHAN_WARN, notably the missing PAGE_ALIGNED_DATA() >> section affecting VDSO

Re: arch/arm64/kernel/topology.c:367:22: sparse: sparse: dereference of noderef expression

2021-01-06 Thread Ionela Voinescu
On Wednesday 06 Jan 2021 at 17:47:58 (+), Al Viro wrote: > On Wed, Jan 06, 2021 at 03:07:24PM +, Ionela Voinescu wrote: > > > > > > 367 switch ((u64)reg->address) { > > > > > > That's not a dereference but I guess sparse complains of dropping the > > > __iomem. We could change

Re: [PATCH] mm/mmap: replace if (cond) BUG() with BUG_ON()

2021-01-06 Thread Andrea Arcangeli
Hello, On Wed, Jan 06, 2021 at 11:46:20AM -0800, Andrew Morton wrote: > On Tue, 5 Jan 2021 20:28:27 -0800 (PST) Hugh Dickins wrote: > > > Alex, please consider why the authors of these lines (whom you > > did not Cc) chose to write them without BUG_ON(): it has always > > been preferred

Re: [PATCH] mm/mmap: replace if (cond) BUG() with BUG_ON()

2021-01-06 Thread Hugh Dickins
On Wed, 6 Jan 2021, Andrew Morton wrote: > On Tue, 5 Jan 2021 20:28:27 -0800 (PST) Hugh Dickins wrote: > > > Alex, please consider why the authors of these lines (whom you > > did not Cc) chose to write them without BUG_ON(): it has always > > been preferred practice to use BUG_ON() on

Re: [PATCH v2 2/4] pinctrl: sunxi: h6-r: Add s_rsb pin functions

2021-01-06 Thread Linus Walleij
On Sun, Jan 3, 2021 at 11:00 AM Samuel Holland wrote: > As there is an RSB controller in the H6 SoC, there should be some pin > configuration for it. While no such configuration is documented, the > "s_i2c" pins are suspiciously on the "alternate" function 3, with no > primary function 2 given.

RE: [RFC PATCH v3 2/2] scheduler: add scheduler level for clusters

2021-01-06 Thread Song Bao Hua (Barry Song)
> -Original Message- > From: Vincent Guittot [mailto:vincent.guit...@linaro.org] > Sent: Thursday, January 7, 2021 5:29 AM > To: Song Bao Hua (Barry Song) > Cc: Valentin Schneider ; Catalin Marinas > ; Will Deacon ; Rafael J. Wysocki > ; Cc: Len Brown ; > gre...@linuxfoundation.org;

[PATCH v2 mips-next 4/4] MIPS: select ARCH_WANT_LD_ORPHAN_WARN

2021-01-06 Thread Alexander Lobakin
Now, after that all the sections are explicitly described and declared in vmlinux.lds.S, we can enable ld orphan warnings to prevent from missing any new sections in future. Signed-off-by: Alexander Lobakin --- arch/mips/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v2 mips-next 3/4] MIPS: vmlinux.lds.S: catch bad .got, .plt and .rel.dyn at link time

2021-01-06 Thread Alexander Lobakin
Catch any symbols placed in .got, .got.plt, .plt, .rel.dyn or .rela.dyn and check for these sections to be zero-sized at link time. At least two of them were noticed in real builds: mips-alpine-linux-musl-ld: warning: orphan section `.rel.dyn' from `init/main.o' being placed in section

[PATCH v2 mips-next 2/4] MIPS: vmlinux.lds.S: add ".gnu.attributes" to DISCARDS

2021-01-06 Thread Alexander Lobakin
Discard GNU attributes at link time as kernel doesn't use it at all. Solves a dozen of the following ld warnings (one per every file): mips-alpine-linux-musl-ld: warning: orphan section `.gnu.attributes' from `arch/mips/kernel/head.o' being placed in section `.gnu.attributes'

[PATCH v2 mips-next 1/4] MIPS: vmlinux.lds.S: add missing PAGE_ALIGNED_DATA() section

2021-01-06 Thread Alexander Lobakin
MIPS uses its own declaration of rwdata, and thus it should be kept in sync with the asm-generic one. Currently PAGE_ALIGNED_DATA() is missing from the linker script, which emits the following ld warnings: mips-alpine-linux-musl-ld: warning: orphan section `.data..page_aligned' from

[PATCH v2 mips-next 0/4] MIPS: vmlinux.lds.S sections fix & cleanup

2021-01-06 Thread Alexander Lobakin
This series hunts the problems discovered after manual enabling of ARCH_WANT_LD_ORPHAN_WARN, notably the missing PAGE_ALIGNED_DATA() section affecting VDSO placement (marked for stable). Compile and runtime tested on MIPS32R2 CPS board with no issues. Since v1 [0]: - catch .got entries too as

drivers/soc/litex/litex_soc_ctrl.c:143:34: warning: unused variable 'litex_soc_ctrl_of_match'

2021-01-06 Thread kernel test robot
Hi Pawel, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: e71ba9452f0b5b2e8dc8aa5445198cd9214a6a62 commit: 22447a99c97e353bde8f90c2353873f27681d57c drivers/soc/litex: add LiteX SoC Controller driver date: 8 weeks

Re: [PATCH] mm: memcg/slab: optimize objcg stock draining

2021-01-06 Thread Roman Gushchin
On Wed, Jan 06, 2021 at 11:50:44AM -0800, Andrew Morton wrote: > On Tue, 5 Jan 2021 20:22:39 -0800 Roman Gushchin wrote: > > > Imran Khan reported a regression in hackbench results caused by the > > commit f2fe7b09a52b ("mm: memcg/slab: charge individual slab objects > > instead of pages"). > >

Re: [PATCH] mm: Teach pfn_to_online_page() about ZONE_DEVICE section collisions

2021-01-06 Thread Dan Williams
On Wed, Jan 6, 2021 at 3:23 AM David Hildenbrand wrote: > > On 06.01.21 11:42, Michal Hocko wrote: > > On Wed 06-01-21 10:56:19, David Hildenbrand wrote: > > [...] > >> Note that this is not sufficient in the general case. I already > >> mentioned that we effectively override an already

Re: [PATCH v2 2/6] mm: hugetlbfs: fix cannot migrate the fallocated HugeTLB page

2021-01-06 Thread Michal Hocko
On Wed 06-01-21 11:30:25, Mike Kravetz wrote: > On 1/6/21 8:35 AM, Michal Hocko wrote: > > On Wed 06-01-21 16:47:35, Muchun Song wrote: > >> Because we only can isolate a active page via isolate_huge_page() > >> and hugetlbfs_fallocate() forget to mark it as active, we cannot > >> isolate and

[PATCH v10 1/2] dt-bindings: power: Add the bq256xx dt bindings

2021-01-06 Thread Ricardo Rivera-Matos
Add the bindings for the bq256xx series of battery charging ICs. Datasheets: - https://www.ti.com/lit/ds/symlink/bq25600.pdf - https://www.ti.com/lit/ds/symlink/bq25601.pdf - https://www.ti.com/lit/ds/symlink/bq25600d.pdf - https://www.ti.com/lit/ds/symlink/bq25601d.pdf -

[PATCH v10 2/2] power: supply: bq256xx: Introduce the BQ256XX charger driver

2021-01-06 Thread Ricardo Rivera-Matos
The BQ256XX family of devices are highly integrated buck chargers for single cell batteries. Signed-off-by: Ricardo Rivera-Matos --- v9 - resolves two warnings issued by kernel test robot v10 - passes psy_cfg by reference drivers/power/supply/Kconfig | 11 +

[PATCH v10 0/2] Introduce the BQ256XX family of chargers

2021-01-06 Thread Ricardo Rivera-Matos
Hello, This patchset introduces the bq256xx family of charging ICs. The bq256xx ICs are highly integrated, buck, switching chargers intended for use in smartphones, tablets, and portable electronics. Ricardo Rivera-Matos (2): dt-bindings: power: Add the bq256xx dt bindings power: supply:

Re: [PATCH v2 5/6] PCI: brcmstb: Add panic/die handler to RC driver

2021-01-06 Thread Jim Quinlan
On Wed, Jan 6, 2021 at 2:42 PM Jim Quinlan wrote: > > -- Forwarded message - > From: Bjorn Helgaas > Date: Wed, Jan 6, 2021 at 2:19 PM > Subject: Re: [PATCH v2 5/6] PCI: brcmstb: Add panic/die handler to RC driver > To: Jim Quinlan > Cc: , Nicolas Saenz Julienne > , , > ,

Re: [PATCH RFC clocksource 2/5] clocksource: Retry clock read if long delays detected

2021-01-06 Thread Paul E. McKenney
On Wed, Jan 06, 2021 at 11:28:00AM -0500, Rik van Riel wrote: > On Tue, 2021-01-05 at 16:41 -0800, paul...@kernel.org wrote: > > > > @@ -203,7 +204,6 @@ static void > > clocksource_watchdog_inject_delay(void) > > injectfail = inject_delay_run; > > if (!(++injectfail /

Re: [PATCH] mm: memcg/slab: optimize objcg stock draining

2021-01-06 Thread Andrew Morton
On Tue, 5 Jan 2021 20:22:39 -0800 Roman Gushchin wrote: > Imran Khan reported a regression in hackbench results caused by the > commit f2fe7b09a52b ("mm: memcg/slab: charge individual slab objects > instead of pages"). How large was the regression? > --- a/mm/memcontrol.c > +++

Re: [PATCH 5.10 00/40] 5.10.3-rc1 review

2021-01-06 Thread Greg Kroah-Hartman
On Thu, Jan 07, 2021 at 01:08:01AM +0530, Jeffrin Jose T wrote: > On Mon, 2021-01-04 at 07:21 +0100, Greg Kroah-Hartman wrote: > > On Sun, Jan 03, 2021 at 06:37:51PM +0530, Jeffrin Jose T wrote: > > > On Mon, 2020-12-28 at 12:41 -0800, Guenter Roeck wrote: > > > > On 12/28/20 1:50 AM, Pavel Machek

Re: [PATCH] mm/mmap: replace if (cond) BUG() with BUG_ON()

2021-01-06 Thread Andrew Morton
On Tue, 5 Jan 2021 20:28:27 -0800 (PST) Hugh Dickins wrote: > Alex, please consider why the authors of these lines (whom you > did not Cc) chose to write them without BUG_ON(): it has always > been preferred practice to use BUG_ON() on predicates, but not on > functionally effective statements

Re: [PATCH] rxrpc: fix handling of an unsupported token type in rxrpc_read()

2021-01-06 Thread David Howells
Tom Rix wrote: > These two loops iterate over the same data, i believe returning here is all > that is needed. But if the first loop is made to support a new type, but the second loop is missed, it will then likely oops. Besides, the compiler should optimise both paths together. David

Re: [PATCH 5.10 00/40] 5.10.3-rc1 review

2021-01-06 Thread Jeffrin Jose T
On Mon, 2021-01-04 at 07:21 +0100, Greg Kroah-Hartman wrote: > On Sun, Jan 03, 2021 at 06:37:51PM +0530, Jeffrin Jose T wrote: > > On Mon, 2020-12-28 at 12:41 -0800, Guenter Roeck wrote: > > > On 12/28/20 1:50 AM, Pavel Machek wrote: > > > > Hi! > > > > > > > > > > > > > >

Re: [PATCH] media: atomisp: ov2722: replace hardcoded function name

2021-01-06 Thread Dan Carpenter
On Wed, Jan 06, 2021 at 10:25:26AM -0800, Joe Perches wrote: > On Wed, 2021-01-06 at 18:52 +0100, Greg Kroah-Hartman wrote: > > On Wed, Jan 06, 2021 at 07:43:42PM +0200, Filip Kolev wrote: > > > On 06-Jan-21 09:51, Greg Kroah-Hartman wrote: > > > > On Tue, Jan 05, 2021 at 10:29:18PM +0200, Filip

[PATCH 2/2] scsi: ufs: handle LINERESET with correct tm_cmd

2021-01-06 Thread Jaegeuk Kim
From: Jaegeuk Kim This fixes a warning caused by wrong reserve tag usage in __ufshcd_issue_tm_cmd. WARNING: CPU: 7 PID: 7 at block/blk-core.c:630 blk_get_request+0x68/0x70 WARNING: CPU: 4 PID: 157 at block/blk-mq-tag.c:82 blk_mq_get_tag+0x438/0x46c And, in ufshcd_err_handler(), we can avoid to

[PATCH 1/2] scsi: ufs: fix livelock of ufshcd_clear_ua_wluns

2021-01-06 Thread Jaegeuk Kim
When gate_work/ungate_work gets an error during hibern8_enter or exit, ufshcd_err_handler() ufshcd_scsi_block_requests() ufshcd_reset_and_restore() ufshcd_clear_ua_wluns() -> stuck ufshcd_scsi_unblock_requests() In order to avoid it, ufshcd_clear_ua_wluns() can be called per

[PATCH 1/2] drm/sun4i: tcon: fix inverted DCLK polarity

2021-01-06 Thread Giulio Benetti
During commit "88bc4178568b8e0331143cc0616640ab72f0cba1" DRM_BUS_FLAG_* macros have been changed to avoid ambiguity but just because of this ambiguity previous DRM_BUS_FLAG_PIXDATA_(POS/NEG)EDGE were used meaning _SAMPLE_ not _DRIVE_. This lead to DLCK inversion, so let's swap DCLK phase to fix

[PATCH 0/2] drm/sun4i: fix DCLK and improve its handling

2021-01-06 Thread Giulio Benetti
First patch is a tested by me fix, while the second need testing to understand if it works correctly with any sunxi SoC with DE peripheral. Already tested SoCs are: - A20 - A33 Need testing: - A10 - A10s - A13 Giulio Benetti (2): drm/sun4i: tcon: fix inverted DCLK polarity drm/sun4i: tcon:

[PATCH 2/2] drm/sun4i: tcon: improve DCLK polarity handling

2021-01-06 Thread Giulio Benetti
It turned out(Maxime suggestion) that bit 26 of SUN4I_TCON0_IO_POL_REG is dedicated to invert DCLK polarity and this makes thing really easier than before. So let's handle DCLK polarity by adding SUN4I_TCON0_IO_POL_DCLK_POSITIVE as bit 26 and activating according to bus_flags the same way is done

Re: [PATCH] mm/memcontrol: fix warning in mem_cgroup_page_lruvec()

2021-01-06 Thread Andrew Morton
On Wed, 6 Jan 2021 14:49:35 +0800 Baoquan He wrote: > > Fixes: 9a1ac2288cf1 ("mm/memcontrol:rewrite mem_cgroup_page_lruvec()") > > ... > > Thanks for fixing this. We also encountered this issue in kdump kernel > with the mainline 5.10 kernel since 'cgroup_disable=memory' is added. Wait.

Re: [PATCH] rxrpc: fix handling of an unsupported token type in rxrpc_read()

2021-01-06 Thread Tom Rix
On 1/6/21 9:40 AM, David Howells wrote: > David Howells wrote: > >> How about this? >> ... >> Fix the second loop so that it doesn't encode the size and type of an >> unsupported token, but rather just ignore it as does the first loop. > Actually, a better way is probably just to error

[PATCH 1/2] scsi: ufs: fix livelock of ufshcd_clear_ua_wluns

2021-01-06 Thread Jaegeuk Kim
When gate_work/ungate_work gets an error during hibern8_enter or exit, ufshcd_err_handler() ufshcd_scsi_block_requests() ufshcd_reset_and_restore() ufshcd_clear_ua_wluns() -> stuck ufshcd_scsi_unblock_requests() In order to avoid it, ufshcd_clear_ua_wluns() can be called per

Re: [PATCH 0/5] virtio/vsock: introduce SOCK_SEQPACKET support.

2021-01-06 Thread Arseny Krasnov
> Hi Arseny, thanks for your work on this! > I did a small review in a hope it helps. > Also it may be cool to have the driver feature > for that (so that the host can see if its supported). > But I guess this was already said by Michael. :) Hello, thank You for your review, i'll prepare v2 as

Re: [PATCH] mm/memcontrol: fix warning in mem_cgroup_page_lruvec()

2021-01-06 Thread Andrew Morton
On Wed, 6 Jan 2021 14:49:35 +0800 Baoquan He wrote: > > --- 5.11-rc2/include/linux/memcontrol.h 2020-12-27 20:39:36.751923135 > > -0800 > > +++ linux/include/linux/memcontrol.h2021-01-03 19:38:24.822978559 > > -0800 > > @@ -665,7 +665,7 @@ static inline struct lruvec *mem_cgroup_ >

Re: [PATCH v2 2/6] mm: hugetlbfs: fix cannot migrate the fallocated HugeTLB page

2021-01-06 Thread Mike Kravetz
On 1/6/21 8:35 AM, Michal Hocko wrote: > On Wed 06-01-21 16:47:35, Muchun Song wrote: >> Because we only can isolate a active page via isolate_huge_page() >> and hugetlbfs_fallocate() forget to mark it as active, we cannot >> isolate and migrate those pages. > > I've little bit hard time to

Re: [PATCH] media: zr364xx: fix memory leaks in probe()

2021-01-06 Thread Dan Carpenter
On Wed, Jan 06, 2021 at 11:45:50AM -0500, Alan Stern wrote: > On Wed, Jan 06, 2021 at 01:10:05PM +0300, Dan Carpenter wrote: > > Syzbot discovered that the probe error handling doesn't clean up the > > resources allocated in zr364xx_board_init(). There are several > > related bugs in this code so

Re: [PATCH 4/5] af_vsock: add socket ops for SOCK_SEQPACKET.

2021-01-06 Thread Arseny Krasnov
> Is ENODEV the right error here? > Just a quick look at a man page, and > I am under impression something like > EPROTONOSUPPORT or ESOCKNOSUPPORT > may suit? I used ENODEV because this code is returned some lines below when !new_transport(e.g. valid transport not found). But i think you codes

Re: [PATCH net-next] net: broadcom: Drop OF dependency from BGMAC_PLATFORM

2021-01-06 Thread Randy Dunlap
On 1/6/21 11:15 AM, Florian Fainelli wrote: > All of the OF code that is used has stubbed and will compile and link > just fine, keeping COMPILE_TEST is enough. Yes, that matches my understanding. I wish we had a list of which API families have full stub support... Acked-by: Randy Dunlap

Re: [PATCH 1/5] vsock/virtio: support for SOCK_SEQPACKET socket.

2021-01-06 Thread Arseny Krasnov
> IMHO you can avoid this special-casing > by introducing yet another outer loop just > for draining the extra data from buffer. > Admittedly that may also require an extra > transport op. I'm not sure that extra tranport op is needed, may be i'll try to put drain code inside copy loop, because

Re: [PATCH] module: harden ELF info handling

2021-01-06 Thread Frank van der Linden
On Tue, Jan 05, 2021 at 02:39:28PM +0100, Jessica Yu wrote: > Hi Frank, > > Sorry for the delay. I've just gotten back from vacation :-) No problem - I figured you were :-) Comments inline - > > +++ Frank van der Linden [21/12/20 23:49 +]: > > 5fdc7db644 ("module: setup load info before

Re: [GIT PULL] Btrfs fixes for 5.11-rc3

2021-01-06 Thread pr-tracker-bot
The pull request you sent on Wed, 6 Jan 2021 12:48:12 +0100: > git://git.kernel.org/pub/scm/linux/kernel/git/kdave/linux.git for-5.11-rc2-tag has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/71c061d2443814de15e177489d5cc00a4a253ef3 Thank you! -- Deet-doot-dot, I am

Re: (hid-logitech) Support for non-DJ receivers

2021-01-06 Thread Filipe Laíns
On Wed, 2021-01-06 at 20:16 +0100, Hans de Goede wrote: > Hi Filipe, > > hid-logitech-dj already supports exposing devices behind a non-DJ / non- > unifying > receiver as separate HID child-devices of the receiver as we doe for DJ > devices. > > ATM hid-logitech-dj does not yet support the c541

Re: [RFC 0/3] mm, slab, slub: remove cpu and memory hotplug locks

2021-01-06 Thread Christoph Lameter
On Wed, 6 Jan 2021, Vlastimil Babka wrote: > rather accept some wasted memory in scenarios that should be rare anyway (full > memory hot remove), as we do the same in other contexts already. It's all RFC > for now, as I might have missed some reason why it's not safe. Looks good to me. My only

Re: [PATCH v2 0/6] brcmstb: add EP regulators and panic handler

2021-01-06 Thread Bjorn Helgaas
On Mon, Nov 30, 2020 at 04:11:37PM -0500, Jim Quinlan wrote: > v2 -- Use regulator bulk API rather than multiple calls (MarkB). > > v1 -- Bindings are added for fixed regulators that may power the EP device. >-- The brcmstb RC driver is modified to control these regulators > during

Re: [PATCH v2 5/6] PCI: brcmstb: Add panic/die handler to RC driver

2021-01-06 Thread Bjorn Helgaas
On Mon, Nov 30, 2020 at 04:11:42PM -0500, Jim Quinlan wrote: > Whereas most PCIe HW returns 0x on illegal accesses and the like, > by default Broadcom's STB PCIe controller effects an abort. This simple > handler determines if the PCIe controller was the cause of the abort and if > so,

Re: (hid-logitech) Support for non-DJ receivers

2021-01-06 Thread Hans de Goede
Hi Filipe, On 1/6/21 8:07 PM, Filipe Laíns wrote: > Hey, > > Some of the new Logitech receivers do not have the DJ interface, this creates > an > issue userspace applications like libratbag, as seen in [1], because we can't > identify the device based on the hidraw PID. > > There are two

Re: [PATCH] HID: logitech-hidpp: add support for Unified Battery (1004) feature

2021-01-06 Thread Bastien Nocera
On Wed, 2021-01-06 at 18:48 +, Filipe Laíns wrote: > On Wed, 2021-01-06 at 10:34 +0100, Bastien Nocera wrote: > > On Mon, 2021-01-04 at 18:29 +, la...@archlinux.org wrote: > > > From: Filipe Laíns > > > > > > This new feature present in new devices replaces the old Battery > > > Level >

Re: [PATCH RFC x86/mce] Make mce_timed_out() identify holdout CPUs

2021-01-06 Thread Paul E. McKenney
On Wed, Jan 06, 2021 at 06:39:30PM +, Luck, Tony wrote: > > The "Timeout: Not all CPUs entered broadcast exception handler" message > > will appear from time to time given enough systems, but this message does > > not identify which CPUs failed to enter the broadcast exception handler. > >

[PATCH net-next] net: broadcom: Drop OF dependency from BGMAC_PLATFORM

2021-01-06 Thread Florian Fainelli
All of the OF code that is used has stubbed and will compile and link just fine, keeping COMPILE_TEST is enough. Signed-off-by: Florian Fainelli --- drivers/net/ethernet/broadcom/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/Kconfig

Re: [PATCH RFC x86/mce] Make mce_timed_out() identify holdout CPUs

2021-01-06 Thread Paul E. McKenney
On Wed, Jan 06, 2021 at 07:32:44PM +0100, Borislav Petkov wrote: > On Wed, Jan 06, 2021 at 09:41:02AM -0800, Paul E. McKenney wrote: > > The "Timeout: Not all CPUs entered broadcast exception handler" message > > will appear from time to time given enough systems, but this message does > > not

Re: [PATCH 05/10] dma: tx49 removal

2021-01-06 Thread Joe Perches
On Tue, 2021-01-05 at 15:02 +0100, Thomas Bogendoerfer wrote: > Signed-off-by: Thomas Bogendoerfer [] > diff --git a/drivers/dma/txx9dmac.h b/drivers/dma/txx9dmac.h [] > @@ -26,11 +26,6 @@ >   * DMA channel. >   */ >   > > -#ifdef CONFIG_MACH_TX49XX > -static inline bool

(hid-logitech) Support for non-DJ receivers

2021-01-06 Thread Filipe Laíns
Hey, Some of the new Logitech receivers do not have the DJ interface, this creates an issue userspace applications like libratbag, as seen in [1], because we can't identify the device based on the hidraw PID. There are two solutions for this: 1) Implement device discovery via the internal

Re: [PATCH -next] pci: hotplug: Use DEFINE_SPINLOCK() for spinlock

2021-01-06 Thread Bjorn Helgaas
On Mon, Dec 28, 2020 at 09:50:38PM +0800, Zheng Yongjun wrote: > spinlock can be initialized automatically with DEFINE_SPINLOCK() > rather than explicitly calling spin_lock_init(). See this again: https://lore.kernel.org/r/20171026223701.ga25...@bhelgaas-glaptop.roam.corp.google.com >

Re: [PATCH V3] drm/vkms: Decouple config data for configfs

2021-01-06 Thread Melissa Wen
On 01/05, Sumera Priyadarsini wrote: > Currently, data for the device instance is held by vkms_device. > Add a separate type, vkms_config to contain configuration details > for the device and various modes to be later used by configfs. > This config data stays constant once the device is created.

Re: [PATCH -next] pci/controller/dwc: convert comma to semicolon

2021-01-06 Thread Bjorn Helgaas
On Wed, Dec 16, 2020 at 09:19:44PM +0800, Zheng Yongjun wrote: > Replace a comma between expression statements by a semicolon. Looks like a good fix, but read this about the changelog title: https://lore.kernel.org/r/20171026223701.ga25...@bhelgaas-glaptop.roam.corp.google.com > Signed-off-by:

Re: [PATCH v2 1/2] KVM: x86/mmu: Ensure TDP MMU roots are freed after yield

2021-01-06 Thread Ben Gardon
On Wed, Jan 6, 2021 at 10:59 AM Ben Gardon wrote: > > Many TDP MMU functions which need to perform some action on all TDP MMU > roots hold a reference on that root so that they can safely drop the MMU > lock in order to yield to other threads. However, when releasing the > reference on the root,

Re: [PATCH 4/6] hugetlb: avoid allocation failed when page reporting is on going

2021-01-06 Thread Alexander Duyck
On Tue, Jan 5, 2021 at 7:50 PM Liang Li wrote: > > Page reporting isolates free pages temporarily when reporting > free pages information. It will reduce the actual free pages > and may cause application failed for no enough available memory. > This patch try to solve this issue, when there is no

[PATCH v2 1/2] KVM: x86/mmu: Ensure TDP MMU roots are freed after yield

2021-01-06 Thread Ben Gardon
Many TDP MMU functions which need to perform some action on all TDP MMU roots hold a reference on that root so that they can safely drop the MMU lock in order to yield to other threads. However, when releasing the reference on the root, there is a bug: the root will not be freed even if its

[PATCH v2 2/2] KVM: x86/mmu: Clarify TDP MMU page list invariants

2021-01-06 Thread Ben Gardon
The tdp_mmu_roots and tdp_mmu_pages in struct kvm_arch should only contain pages with tdp_mmu_page set to true. tdp_mmu_pages should not contain any pages with a non-zero root_count and tdp_mmu_roots should only contain pages with a positive root_count, unless a thread holds the MMU lock and is in

Re: [RFC PATCH v3 5/6] dt-bindings: of: Add restricted DMA pool

2021-01-06 Thread Konrad Rzeszutek Wilk
On Wed, Jan 06, 2021 at 11:41:23AM +0800, Claire Chang wrote: > Introduce the new compatible string, restricted-dma-pool, for restricted > DMA. One can specify the address and length of the restricted DMA memory > region by restricted-dma-pool in the device tree. > > Signed-off-by: Claire Chang

Re: [RFC PATCH v3 2/6] swiotlb: Add restricted DMA pool

2021-01-06 Thread Konrad Rzeszutek Wilk
Hello! In this file: > diff --git a/kernel/dma/swiotlb.c b/kernel/dma/swiotlb.c > index e4368159f88a..7fb2ac087d23 100644 > --- a/kernel/dma/swiotlb.c > +++ b/kernel/dma/swiotlb.c .. > +static const struct reserved_mem_ops rmem_swiotlb_ops = { > + .device_init= rmem_swiotlb_device_init,

Re: [PATCH] of: property: Add device link support for interrupts

2021-01-06 Thread Saravana Kannan
On Sat, Jan 2, 2021 at 3:37 AM Marc Zyngier wrote: > > On Thu, 31 Dec 2020 21:12:40 +, > Rob Herring wrote: > > > > On Mon, Dec 21, 2020 at 09:30:45AM +, Marc Zyngier wrote: > > > On 2020-12-18 21:07, Saravana Kannan wrote: > > > > Add support for creating device links out of interrupts

Re: [PATCH 00/10] Remove support for TX49xx

2021-01-06 Thread Thomas Bogendoerfer
On Wed, Jan 06, 2021 at 09:37:11AM +0100, Geert Uytterhoeven wrote: > Hi Thomas, > > CC Nemoto-san (de-facto TX49XX maintainer) > > On Tue, Jan 5, 2021 at 3:03 PM Thomas Bogendoerfer > wrote: > > I couldn't find any buyable product other than reference boards using > > TX49xx CPUs. And since

Re: [RFC PATCH v3 0/6] Restricted DMA

2021-01-06 Thread Florian Fainelli
Hi, First of all let me say that I am glad that someone is working on a upstream solution for this issue, would appreciate if you could CC and Jim Quinlan on subsequent submissions. On 1/5/21 7:41 PM, Claire Chang wrote: > This series implements mitigations for lack of DMA access control on >

Re: [PATCH] HID: logitech-hidpp: add support for Unified Battery (1004) feature

2021-01-06 Thread Filipe Laíns
On Wed, 2021-01-06 at 10:34 +0100, Bastien Nocera wrote: > On Mon, 2021-01-04 at 18:29 +, la...@archlinux.org wrote: > > From: Filipe Laíns > > > > This new feature present in new devices replaces the old Battery > > Level > > Status (0x1000) feature. It keeps essentially the same

<    1   2   3   4   5   6   7   8   9   10   >