[PATCH] [v2] evm: Fix memleak in init_desc

2021-01-10 Thread Dinghao Liu
When kmalloc() fails, tmp_tfm allocated by crypto_alloc_shash() has not been freed, which leads to memleak. Fixes: d46eb3699502b ("evm: crypto hash replaced by shash") Signed-off-by: Dinghao Liu --- Changelog: v2: - Remove checks against tmp_tfm before freeing. ---

Re: [PATCH v4] driver core: Fix device link device name collision

2021-01-10 Thread Greg Kroah-Hartman
On Sat, Jan 09, 2021 at 02:45:06PM -0800, Saravana Kannan wrote: > The device link device's name was of the form: > -- > > This can cause name collision as reported here [1] as device names are > not globally unique. Since device names have to be unique within the > bus/class, add the bus/class

Re: [PATCH] dts64: mt7622: fix slow sd card access

2021-01-10 Thread Frank Wunderlich
I guess issue is caused by incompatible setting in uboot,but have not found which exactly so i handled it like emmc. If patch is ready to be applied please add Cc: sta...@vger.kernel.org because all kernel versions are affected (tested at least in 5.4 and 5.9). If i need to create a v2,i

Re: [PATCH] selftests: netfilter: Pass family parameter "-f" to conntrack tool

2021-01-10 Thread Pablo Neira Ayuso
On Tue, Jan 05, 2021 at 11:31:20PM +0800, Chen Yi wrote: > Fix nft_conntrack_helper.sh false fail report: > > 1) Conntrack tool need "-f ipv6" parameter to show out ipv6 traffic items. > > 2) Sleep 1 second after background nc send packet, to make sure check > is after this statement executed. >

Re: [PATCH v4 1/2] misc: pvpanic: introduce device capability

2021-01-10 Thread Greg KH
On Sun, Jan 10, 2021 at 01:37:18PM +0800, zhenwei pi wrote: > According to pvpanic spec: > https://git.qemu.org/?p=qemu.git;a=blob_plain;f=docs/specs/pvpanic.txt > > The guest should determine pvpanic capability by RDPT, so initialize > capability during device probing. There is no need to

Re: [PATCH] netfilter: Fix memleak in nf_nat_init

2021-01-10 Thread Pablo Neira Ayuso
On Sat, Jan 09, 2021 at 08:01:21PM +0800, Dinghao Liu wrote: > When register_pernet_subsys() fails, nf_nat_bysource > should be freed just like when nf_ct_extend_register() > fails. Applied, thanks.

Re: [PATCH v4 2/2] misc: pvpanic: introduce events device attribue

2021-01-10 Thread Greg KH
On Sun, Jan 10, 2021 at 01:37:19PM +0800, zhenwei pi wrote: > Suggested by Paolo & Greg, add 'events' device attribute that can be > used to limit which capabilities the driver uses. > > Finally, the pvpanic guest driver works by the limitation of both > device capability and user setting. > >

Re: Old platforms: bring out your dead

2021-01-10 Thread Arnd Bergmann
On Sun, Jan 10, 2021 at 12:12 AM Andrew Lunn wrote: > > > Then there are ARM platforms that are old but have still seen some work > > in the past years. If I hear nothing, these will all stay, but if > > maintainers > > may want to drop them anyway, I can help with that: > > Hi Arnd > > I notice

Re: upstream build error (11)

2021-01-10 Thread Dmitry Vyukov
On Sat, Jan 9, 2021 at 11:34 PM Andrew Morton wrote: > > On Sat, 9 Jan 2021 21:41:23 +0100 Dmitry Vyukov wrote: > > > On Wed, Oct 28, 2020 at 9:31 AM syzbot > > wrote: > > > > > > Hello, > > > > > > syzbot found the following issue on: > > > > > > HEAD commit:4d09c1d9 Merge tag

[PATCH] scsi: ufs: A tad optimization in query upiu trace

2021-01-10 Thread Avri Altman
Remove a redundant if clause in ufshcd_add_query_upiu_trace. Signed-off-by: Avri Altman --- drivers/scsi/ufs/ufshcd.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c index 53fd59ce50b2..678a520b303e

Re: memory leak in mcba_usb_probe

2021-01-10 Thread Bui Quang Minh
#syz test: https://github.com/minhbq-99/linux.git 080e743dff190ee8ebec63a13ac33fe8b7e4fc9e

[PATCH] can: mcba_usb: Fix memory leak when cancelling urb

2021-01-10 Thread Bui Quang Minh
In mcba_usb_read_bulk_callback(), when we don't resubmit the urb, we need to deallocate the transfer buffer that is allocated in mcba_usb_start(). Reported-by: syzbot+57281c762a3922e14...@syzkaller.appspotmail.com Signed-off-by: Bui Quang Minh --- drivers/net/can/usb/mcba_usb.c | 2 ++ 1 file

Re: memory leak in mcba_usb_probe

2021-01-10 Thread syzbot
Hello, syzbot has tested the proposed patch but the reproducer is still triggering an issue: memory leak in rxrpc_lookup_local BUG: memory leak unreferenced object 0x888118b2f300 (size 256): comm "syz-executor.5", pid 8860, jiffies 4294944050 (age 373.640s) hex dump (first 32 bytes):

[PATCH] writeback: Remove useless comment for __wakeup_flusher_threads_bdi()

2021-01-10 Thread winndows
From: Liao Pingfang Remove useless comment for __wakeup_flusher_threads_bdi(), as argument 'nr_pages' was removed. Fixes: e8e8a0c6c9bf ("writeback: move nr_pages == 0 logic to one location") Signed-off-by: Liao Pingfang --- fs/fs-writeback.c | 4 1 file changed, 4 deletions(-) diff

Re: [PATCH] random: avoid arch_get_random_seed_long() when collecting IRQ randomness

2021-01-10 Thread Ard Biesheuvel
On Mon, 4 Jan 2021 at 20:09, Ard Biesheuvel wrote: > > On Tue, 17 Nov 2020 at 14:33, Ard Biesheuvel wrote: > > > > On Wed, 11 Nov 2020 at 09:19, Ard Biesheuvel wrote: > > > > > > (+ Eric) > > > > > > On Thu, 5 Nov 2020 at 16:29, Ard Biesheuvel wrote: > > > > > > > > When reseeding the CRNG

KMSAN: kernel-infoleak in move_addr_to_user (4)

2021-01-10 Thread syzbot
Hello, syzbot found the following issue on: HEAD commit:73d62e81 kmsan: random: prevent boot-time reports in _mix_.. git tree: https://github.com/google/kmsan.git master console output: https://syzkaller.appspot.com/x/log.txt?x=15c8b8c750 kernel config:

Re: depmod fixes for linux-stable releases

2021-01-10 Thread Sasha Levin
On Sat, Jan 09, 2021 at 05:23:22PM -0800, Linus Torvalds wrote: Ack, I think 436e980e2ed5 ("kbuild: don't hardcode depmod path") is stable material even if it doesn't fix a bug. Not only does the fix for that commit not make sense without the commit in the first place, but any environment that

Re: [PATCH v2] dt-bindings: timer: nuvoton: Clarify that interrupt of timer 0 should be specified

2021-01-10 Thread Avi Fishman
On Fri, Jan 8, 2021 at 6:30 PM Jonathan Neuschäfer wrote: > > The NPCM750 Timer/Watchdog Controller has multiple interrupt lines, > connected to multiple timers. The driver uses timer 0 for timer > interrupts, so the interrupt line corresponding to timer 0 should be > specified in DT. > > I

Re: [PATCH] irqchip: mips-cpu: set IPI domain parent chip

2021-01-10 Thread Marc Zyngier
On Thu, 7 Jan 2021 22:36:03 +0100, Mathias Kresin wrote: > Since commit 55567976629e ("genirq/irqdomain: Allow partial trimming of > irq_data hierarchy") the irq_data chain is valided. > > The irq_domain_trim_hierarchy() function doesn't consider the irq + ipi > domain hierarchy as valid, since

Re: [PATCH] irqchip: Simplify the TI_PRUSS_INTC Kconfig

2021-01-10 Thread Marc Zyngier
On Fri, 8 Jan 2021 10:29:01 -0600, Suman Anna wrote: > The TI PRUSS INTC irqchip driver handles the local interrupt controller > which is a child device of it's parent PRUSS/ICSSG device. The driver > was upstreamed in parallel with the PRUSS platform driver, and was > configurable independently

[irqchip: irq/irqchip-next] irqchip/mips-cpu: Set IPI domain parent chip

2021-01-10 Thread irqchip-bot for Mathias Kresin
The following commit has been merged into the irq/irqchip-next branch of irqchip: Commit-ID: 599b3063adf4bf041a87a69244ee36aded0d878f Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/599b3063adf4bf041a87a69244ee36aded0d878f Author:Mathias Kresin

[irqchip: irq/irqchip-next] irqchip/pruss: Simplify the TI_PRUSS_INTC Kconfig

2021-01-10 Thread irqchip-bot for Suman Anna
The following commit has been merged into the irq/irqchip-next branch of irqchip: Commit-ID: b8e594fa20d2e33d40c7a8c7c106549a35c38972 Gitweb: https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms/b8e594fa20d2e33d40c7a8c7c106549a35c38972 Author:Suman Anna

[GIT PULL] x86/urgent for v5.11-rc3

2021-01-10 Thread Borislav Petkov
Hi Linus, as expected, fixes started trickling in after the holidays so please pull the accumulated pile of x86 urgent fixes for 5.11. Thx. --- The following changes since commit 5c8fe583cce542aa0b84adc939ce85293de36e5e: Linux 5.11-rc1 (2020-12-27 15:30:22 -0800) are available in the Git

[PATCH 0/1] Add software TX timestamps to the CAN devices

2021-01-10 Thread Vincent Mailhol
With the ongoing work to add BQL to Socket CAN, I figured out that it would be nice to have an easy way to mesure the latency. And one easy way to do so it to check the round trip time of the packet by doing the difference between the software rx timestamp and the software tx timestamp. rx

[PATCH 1/1] can: dev: add software tx timestamps

2021-01-10 Thread Vincent Mailhol
Call skb_tx_timestamp() within can_put_echo_skb() so that a software tx timestamp gets attached on the skb. There two main reasons to include this call in can_put_echo_skb(): * It easily allow to enable the tx timestamp on all devices with just one small change. * According to

Re: Old platforms: bring out your dead

2021-01-10 Thread Russell King - ARM Linux admin
On Sun, Jan 10, 2021 at 07:21:13AM +0100, Willy Tarreau wrote: > On Sat, Jan 09, 2021 at 10:52:53PM +0100, Arnd Bergmann wrote: > (... i486 ...) > > As with the other older platforms, the main question to ask is: > > Are there users that are better off running a future LTS kernel on this > >

Re: [RFC PATCH 1/8] rcu: Remove superfluous rdp fetch

2021-01-10 Thread Frederic Weisbecker
On Sat, Jan 09, 2021 at 10:03:33AM +0100, Greg KH wrote: > On Sat, Jan 09, 2021 at 03:05:29AM +0100, Frederic Weisbecker wrote: > > Signed-off-by: Frederic Weisbecker > > Cc: Paul E. McKenney > > Cc: Rafael J. Wysocki > > Cc: Peter Zijlstra > > Cc: Thomas Gleixner > > Cc: Ingo Molnar > > ---

[GIT PULL] irqchip fixes for 5.11, take #1

2021-01-10 Thread Marc Zyngier
Hi Thomas, Happy New Year! This is the first set of fixes from the irqchip (and related) department for 5.11. On the menu this time, three notable fixes: a MIPS CPU hierarchy violation, a fix for the on-stack init of msi_alloc_info (or lack thereof), and a fix for the RPi2/3 IPI irqchip that

[PATCH] fs: Remove the comment for argument "cred" of vfs_open()

2021-01-10 Thread winndows
From: Liao Pingfang Remove the comment for argument "cred" of vfs_open(), as it was removed. Fixes: ae2bb293a3e8 ("get rid of cred argument of vfs_open() and do_dentry_open()") Signed-off-by: Liao Pingfang --- fs/open.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/open.c b/fs/open.c

Re: [PATCH v5 09/15] lib/test_printf.c: Use helper function to unwind array of software_nodes

2021-01-10 Thread Laurent Pinchart
Hi Andy, On Sat, Jan 09, 2021 at 11:07:33AM +0200, Andy Shevchenko wrote: > On Saturday, January 9, 2021, Laurent Pinchart wrote: > > > Hi Peter, Steven and Sergey, > > > > Could you please let us know if you're fine with this patch getting > > merged in v5.12 through the linux-media tree ? The

Re: [PATCH 1/1] can: dev: add software tx timestamps

2021-01-10 Thread Jeroen Hofstee
Hello Vincent, On 1/10/21 11:35 AM, Vincent Mailhol wrote: Call skb_tx_timestamp() within can_put_echo_skb() so that a software tx timestamp gets attached on the skb. [..] diff --git a/drivers/net/can/dev.c b/drivers/net/can/dev.c index 3486704c8a95..3904e0874543 100644 ---

Re: [PATCH 5.10 00/20] 5.10.6-rc1 review

2021-01-10 Thread Greg Kroah-Hartman
On Thu, Jan 07, 2021 at 06:10:15PM -0700, Shuah Khan wrote: > On 1/7/21 7:33 AM, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 5.10.6 release. > > There are 20 patches in this series, all will be posted as a response > > to this one. If anyone has any issues

Re: [PATCH 5.10 00/20] 5.10.6-rc1 review

2021-01-10 Thread Greg Kroah-Hartman
On Fri, Jan 08, 2021 at 09:41:19AM -0800, Guenter Roeck wrote: > On Thu, Jan 07, 2021 at 03:33:55PM +0100, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 5.10.6 release. > > There are 20 patches in this series, all will be posted as a response > > to this one.

Re: [PATCH 5.10 00/20] 5.10.6-rc1 review

2021-01-10 Thread Greg Kroah-Hartman
On Fri, Jan 08, 2021 at 07:32:54AM +0530, Naresh Kamboju wrote: > On Thu, 7 Jan 2021 at 20:03, Greg Kroah-Hartman > wrote: > > > > This is the start of the stable review cycle for the 5.10.6 release. > > There are 20 patches in this series, all will be posted as a response > > to this one. If

Re: [patch V3 13/37] mips/mm/highmem: Switch to generic kmap atomic

2021-01-10 Thread Paul Cercueil
Hi Thomas, Le sam. 9 janv. 2021 à 1:33, Thomas Bogendoerfer a écrit : On Sat, Jan 09, 2021 at 12:58:05AM +0100, Thomas Bogendoerfer wrote: On Fri, Jan 08, 2021 at 08:20:43PM +, Paul Cercueil wrote: > Hi Thomas, > > 5.11 does not boot anymore on Ingenic SoCs, I bisected it to this

[PATCH] arm64: dts: imx8mm-beacon: add more pinctrl states for usdhc1

2021-01-10 Thread Adam Ford
The WiFi chip is capable of communication at SDR104 speeds. Enable 100Mhz and 200MHz pinmux to support this. Signed-off-by: Adam Ford diff --git a/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi b/arch/arm64/boot/dts/freescale/imx8mm-beacon-som.dtsi index d897913537ca..988f8ab679ad 100644

[PATCH v5 mips-next 0/9] MIPS: vmlinux.lds.S sections fixes & cleanup

2021-01-10 Thread Alexander Lobakin
This series hunts the problems discovered after manual enabling of ARCH_WANT_LD_ORPHAN_WARN. Notably: - adds the missing PAGE_ALIGNED_DATA() section affecting VDSO placement (marked for stable); - stops blind catching of orphan text sections with .text.* directive; - properly stops

[PATCH] arm64: dts: imx8mn-beacon-som: Configure RTC aliases

2021-01-10 Thread Adam Ford
On the i.MX8MN Beacon SOM, there is an RTC chip which is fed power from the baseboard during power off. The SNVS RTC integrated into the SoC is not fed power. Depending on the order the modules are loaded, this can be a problem if the external RTC isn't rtc0. Make the alias for rtc0 point to

[PATCH v5 1/2] misc: pvpanic: introduce device capability

2021-01-10 Thread zhenwei pi
According to pvpanic spec: https://git.qemu.org/?p=qemu.git;a=blob_plain;f=docs/specs/pvpanic.txt The guest should determine pvpanic capability by RDPT, so initialize capability during device probing. There is no need to register panic notifier callback function if no events supported. Before

[PATCH v5 2/2] misc: pvpanic: introduce events device attribue

2021-01-10 Thread zhenwei pi
Suggested by Paolo & Greg, add 'events' device attribute that can be used to limit which capabilities the driver uses. Finally, the pvpanic guest driver works by the limitation of both device capability and user setting. Signed-off-by: zhenwei pi ---

[PATCH v5 0/2] misc: pvpanic: introduce capability & event attribute

2021-01-10 Thread zhenwei pi
v4 -> v5: Use sysfs_emit to export attribute value. Only allow subset of capability to set on events. Add more detailed infomation in document. v3 -> v4: Use event sysfs attribute instead of module parameter. Use driver dev_groups instead of creating files by sysfs_* API. v2 -> v3: Seperate the

[PATCH v5 mips-next 4/9] MIPS: properly stop .eh_frame generation

2021-01-10 Thread Alexander Lobakin
Commit 866b6a89c6d1 ("MIPS: Add DWARF unwinding to assembly") added -fno-asynchronous-unwind-tables to KBUILD_CFLAGS to prevent compiler from emitting .eh_frame symbols. However, as MIPS heavily uses CFI, that's not enough. Use the approach taken for x86 (as it also uses CFI) and explicitly put

[PATCH v5 mips-next 3/9] MIPS: vmlinux.lds.S: add ".gnu.attributes" to DISCARDS

2021-01-10 Thread Alexander Lobakin
Discard GNU attributes (MIPS FP type, GNU Hash etc.) at link time as kernel doesn't use it at all. Solves a dozen of the following ld warnings (one per every file): mips-alpine-linux-musl-ld: warning: orphan section `.gnu.attributes' from `arch/mips/kernel/head.o' being placed in section

[PATCH v5 mips-next 1/9] MIPS: vmlinux.lds.S: add missing PAGE_ALIGNED_DATA() section

2021-01-10 Thread Alexander Lobakin
MIPS uses its own declaration of rwdata, and thus it should be kept in sync with the asm-generic one. Currently PAGE_ALIGNED_DATA() is missing from the linker script, which emits the following ld warnings: mips-alpine-linux-musl-ld: warning: orphan section `.data..page_aligned' from

[PATCH v5 mips-next 9/9] MIPS: select ARCH_WANT_LD_ORPHAN_WARN

2021-01-10 Thread Alexander Lobakin
Now, after that all the sections are explicitly described and declared in vmlinux.lds.S, we can enable ld orphan warnings to prevent from missing any new sections in future. Signed-off-by: Alexander Lobakin Reviewed-by: Kees Cook Reviewed-by: Nathan Chancellor --- arch/mips/Kconfig | 1 + 1

[PATCH v5 mips-next 2/9] MIPS: CPS: don't create redundant .text.cps-vec section

2021-01-10 Thread Alexander Lobakin
A number of symbols from arch/mips/kernel/cps-vec.S is explicitly placed into '.text.cps-vec' section. There are no direct references to this section, so there's no need to form it. '.balign 0x1000' directive will work anyway. Moreover, this section was being placed in vmlinux differently

[PATCH v5 mips-next 6/9] MIPS: vmlinux.lds.S: explicitly declare .got table

2021-01-10 Thread Alexander Lobakin
LLVM stack generates GOT table when building the kernel: ld.lld: warning: :(.got) is being placed in '.got' According to the debug assertions, it's not zero-sized and thus can't be handled the way it's done for x86. Also use the ARM64 path here and place it at the end of .text section.

[PATCH v5 mips-next 5/9] MIPS: vmlinux.lds.S: explicitly catch .rel.dyn symbols

2021-01-10 Thread Alexander Lobakin
According to linker warnings, both GCC and LLVM generate '.rel.dyn' symbols: mips-alpine-linux-musl-ld: warning: orphan section `.rel.dyn' from `init/main.o' being placed in section `.rel.dyn' Link-time assertion shows that this section is sometimes empty, sometimes not, depending on machine

[PATCH v5 mips-next 8/9] vmlinux.lds.h: catch UBSAN's "unnamed data" into data

2021-01-10 Thread Alexander Lobakin
When building kernel with both LD_DEAD_CODE_DATA_ELIMINATION and UBSAN, LLVM stack generates lots of "unnamed data" sections: ld.lld: warning: net/built-in.a(netfilter/utils.o): (.data.$__unnamed_2) is being placed in '.data.$__unnamed_2' ld.lld: warning: net/built-in.a(netfilter/utils.o):

[PATCH v5 mips-next 7/9] vmlinux.lds.h: catch compound literals into data and BSS

2021-01-10 Thread Alexander Lobakin
When building kernel with LD_DEAD_CODE_DATA_ELIMINATION, LLVM stack generates separate sections for compound literals, just like in case with enabled LTO [0]: ld.lld: warning: drivers/built-in.a(mtd/nand/spi/gigadevice.o): (.data..compoundliteral.14) is being placed in '.data..compoundliteral.14'

Re: [patch V3 13/37] mips/mm/highmem: Switch to generic kmap atomic

2021-01-10 Thread H. Nikolaus Schaller
> Am 10.01.2021 um 12:35 schrieb Paul Cercueil : > > Hi Thomas, > > Le sam. 9 janv. 2021 à 1:33, Thomas Bogendoerfer > a écrit : >> On Sat, Jan 09, 2021 at 12:58:05AM +0100, Thomas Bogendoerfer wrote: >>> On Fri, Jan 08, 2021 at 08:20:43PM +, Paul Cercueil wrote: >>> > Hi Thomas, >>> >

Re: [PATCH] arm64: dts: ls1028a: fix the offset of the reset register

2021-01-10 Thread Shawn Guo
On Tue, Dec 15, 2020 at 10:26:22PM +0100, Michael Walle wrote: > The offset of the reset request register is 0, the absolute address is > 0x1e6. Boards without PSCI support will fail to perform a reset: > > [ 26.734700] reboot: Restarting system > [ 27.743259] Unable to restart system > [

Re: Re: [PATCH] arm/kasan:fix the arry size of kasan_early_shadow_pte

2021-01-10 Thread Linus Walleij
On Sun, Jan 10, 2021 at 11:21 AM hailong wrote: > >> +#ifndef PTE_HWTABLE_PTRS > >> +#define PTE_HWTABLE_PTRS 0 > >> +#endif > > > >Can this even happen? We have either pgtable-2level.h or > >pgtable-3level.h, both of which define PTE_HWTABLE_PTRS. > > > > I guess not for arm. But I'm not sure

[PATCH v1 (RFC)] docs: discourage users from using bugzilla.kernel.org

2021-01-10 Thread Thorsten Leemhuis
The bugtracker on kernel.org is not working very well and might be a disservice to the community, as discussed on the maintainers summit 2017 and explained below in detail. For most of the kernel it was never the preferred place to report issues anyway, as the MAINTAINERS file and the recently

Re: [stable 4.9.y 0/4] scripts/gdb Fixes for stable 4.9

2021-01-10 Thread Sasha Levin
On Thu, Jan 07, 2021 at 02:52:25PM -0800, Florian Fainelli wrote: Hi Greg, Sasha, This series contains some scripts/gdb/ fixes that are already present in newer stable kernels. Queued up, thanks! -- Thanks, Sasha

[PATCH 2/5] rtlwifi: rtl8192c-common: fix bool comparison in expressions

2021-01-10 Thread Aditya Srivastava
There are certain conditional expressions in rtl8192c-common, where a boolean variable is compared with true/false, in forms such as (foo == true) or (false != bar), which does not comply with checkpatch.pl (CHECK: BOOL_COMPARISON), according to which boolean variables should be themselves used in

[PATCH 4/5] rtlwifi: rtl8192se: fix bool comparison in expressions

2021-01-10 Thread Aditya Srivastava
There are certain conditional expressions in rtl8192se, where a boolean variable is compared with true/false, in forms such as (foo == true) or (false != bar), which does not comply with checkpatch.pl (CHECK: BOOL_COMPARISON), according to which boolean variables should be themselves used in the

[PATCH 0/5] rtlwifi: fix bool comparison in expressions

2021-01-10 Thread Aditya Srivastava
This patch series fixes the bool comparison in conditional expressions for all the drivers in rtlwifi. There are certain conditional expressions in rtlwifi drivers, where a boolean variable is compared with true/false, in forms such as (foo == true) or (false != bar), which does not comply with

Re: [PATCH v2 0/3] Mainline Webasto ccbv2 board

2021-01-10 Thread Shawn Guo
On Wed, Dec 16, 2020 at 05:24:29PM +0100, Rouven Czerwinski wrote: > Add Webasto ccbv2 device tree. > > v2: > - add correct mailing lists to cc > - add commit message for vendor-prefix and dt-bindings > > Rouven Czerwinski (3): > dt-bindings: vendor-prefixes: add Webasto SE I did not receive

[PATCH 1/5] rtlwifi: rtl_pci: fix bool comparison in expressions

2021-01-10 Thread Aditya Srivastava
There are certain conditional expressions in rtl_pci, where a boolean variable is compared with true/false, in forms such as (foo == true) or (false != bar), which does not comply with checkpatch.pl (CHECK: BOOL_COMPARISON), according to which boolean variables should be themselves used in the

[PATCH 3/5] rtlwifi: rtl8188ee: fix bool comparison in expressions

2021-01-10 Thread Aditya Srivastava
There are certain conditional expressions in rtl8188ee, where a boolean variable is compared with true/false, in forms such as (foo == true) or (false != bar), which does not comply with checkpatch.pl (CHECK: BOOL_COMPARISON), according to which boolean variables should be themselves used in the

[PATCH 5/5] rtlwifi: rtl8821ae: fix bool comparison in expressions

2021-01-10 Thread Aditya Srivastava
There are certain conditional expressions in rtl8821ae, where a boolean variable is compared with true/false, in forms such as (foo == true) or (false != bar), which does not comply with checkpatch.pl (CHECK: BOOL_COMPARISON), according to which boolean variables should be themselves used in the

Re: [PATCH v2 2/4] arm64: dts: imx8mq-librem5-devkit: Tweak pmic regulators

2021-01-10 Thread Shawn Guo
On Thu, Dec 17, 2020 at 04:13:13PM +0100, Guido Günther wrote: > BUCK3 needs a regulator-enable-ramp-delay since otherwise the board > freezes on etnaviv probe. With this pgc_gpu suspends and resumes as > expected. This must have been always broken since gpcv2 support was > enabled. > > We also

Re: [PATCH v2 4/4] arm64: dts: imx8mq-librem5-devkit: Drop custom clock settings

2021-01-10 Thread Shawn Guo
On Thu, Dec 17, 2020 at 04:13:15PM +0100, Guido Günther wrote: > Otherwise the boot hangs early on and the resulting clock tree without > this already closely matches the selected rates (722534400 and > 786432000). > > audio_pll2 000 722534397 0

Re: [PATCH v2 3/4] arm64: dts: imx8mq-librem5-devkit: Disable snvs_rtc

2021-01-10 Thread Shawn Guo
On Thu, Dec 17, 2020 at 04:13:14PM +0100, Guido Günther wrote: > The board has it's own RTC chip which is backed by the (optional) > battery and hence preserves data/time on poweroff when that is inserted. > > Signed-off-by: Guido Günther Applied, thanks.

Re: [PATCH v2 0/4] Config and device tree updates for the Librem 5 devkit

2021-01-10 Thread Shawn Guo
On Thu, Dec 17, 2020 at 04:13:11PM +0100, Guido Günther wrote: > This enables more components to get a working display, panel, audio and > sensors. It also updates some device tree bits to make mainline boot. > > I've skipped wifi (which needs some more driver work) and devfreq (since > Martin >

Re: [PATCH 1/1] can: dev: add software tx timestamps

2021-01-10 Thread Vincent MAILHOL
Hello Jeroen, On Sun. 10 Jan 2021 at 20:29, Jeroen Hofstee wrote: > > Hello Vincent, > > On 1/10/21 11:35 AM, Vincent Mailhol wrote: > > Call skb_tx_timestamp() within can_put_echo_skb() so that a software > > tx timestamp gets attached on the skb. > > > [..] > > > > diff --git

Re: [PATCH 1/2] ARM: dts: imx6q-logicpd: Drop unused clock-names reference

2021-01-10 Thread Shawn Guo
On Thu, Dec 17, 2020 at 11:25:28AM -0600, Adam Ford wrote: > The wlf,wm8962 driver does not use the clock-names property. > Drop it. > > Signed-off-by: Adam Ford Applied both, thanks.

[PATCH v3 0/6] Fix some bugs about HugeTLB code

2021-01-10 Thread Muchun Song
This patch series aims to fix some bugs and add some improvements. Changelog since v2 -> v3: - Update commit log. - Using head[3].private to indicate the page is freed in patch #3. Changelog since v1 -> v2: - Export set_page_huge_active() in patch #2 to fix. - Using head[3].mapping to

[PATCH v3 1/6] mm: migrate: do not migrate HugeTLB page whose refcount is one

2021-01-10 Thread Muchun Song
If the refcount is one when it is migrated, it means that the page was freed from under us. So we are done and do not need to migrate. This optimization is consistent with the regular pages, just like unmap_and_move() does. Signed-off-by: Muchun Song Reviewed-by: Mike Kravetz Acked-by: Yang

[PATCH v3 2/6] mm: hugetlbfs: fix cannot migrate the fallocated HugeTLB page

2021-01-10 Thread Muchun Song
If a new hugetlb page is allocated during fallocate it will not be marked as active (set_page_huge_active) which will result in a later isolate_huge_page failure when the page migration code would like to move that page. Such a failure would be unexpected and wrong. Only export

[PATCH v3 5/6] mm: hugetlb: fix a race between isolating and freeing page

2021-01-10 Thread Muchun Song
There is a race between isolate_huge_page() and __free_huge_page(). CPU0: CPU1: if (PageHuge(page)) put_page(page) __free_huge_page(page)

[PATCH v3 6/6] mm: hugetlb: remove VM_BUG_ON_PAGE from page_huge_active

2021-01-10 Thread Muchun Song
The page_huge_active() can be called from scan_movable_pages() which do not hold a reference count to the HugeTLB page. So when we call page_huge_active() from scan_movable_pages(), the HugeTLB page can be freed parallel. Then we will trigger a BUG_ON which is in the page_huge_active() when

[PATCH v2 0/1] Add software TX timestamps to the CAN devices

2021-01-10 Thread Vincent Mailhol
With the ongoing work to add BQL to Socket CAN, I figured out that it would be nice to have an easy way to mesure the latency. And one easy way to do so it to check the round trip time of the packet by doing the difference between the software rx timestamp and the software tx timestamp. rx

[PATCH v3 3/6] mm: hugetlb: fix a race between freeing and dissolving the page

2021-01-10 Thread Muchun Song
There is a race condition between __free_huge_page() and dissolve_free_huge_page(). CPU0: CPU1: // page_count(page) == 1 put_page(page) __free_huge_page(page) dissolve_free_huge_page(page) spin_lock(_lock)

[PATCH v3 4/6] mm: hugetlb: add return -EAGAIN for dissolve_free_huge_page

2021-01-10 Thread Muchun Song
There is a race between dissolve_free_huge_page() and put_page(), and the race window is quite small. Theoretically, we should return -EBUSY when we encounter this race. In fact, we have a chance to successfully dissolve the page if we do a retry. Because the race window is quite small. If we

[PATCH v2 1/1] can: dev: add software tx timestamps

2021-01-10 Thread Vincent Mailhol
Call skb_tx_timestamp() within can_put_echo_skb() so that a software tx timestamp gets attached on the skb. There two main reasons to include this call in can_put_echo_skb(): * It easily allow to enable the tx timestamp on all devices with just one small change. * According to

Re: [PATCH] arm64: dts: imx8mq: Add clock parents for mipi dphy

2021-01-10 Thread Shawn Guo
On Fri, Dec 18, 2020 at 06:50:05PM +0100, Guido Günther wrote: > This makes sure the clock tree setup for the dphy is not dependent on > other components. > > Without this change bringing up the display can fail like > > kernel: phy phy-30a00300.dphy.2: Invalid CM/CN/CO values: 165/217/1 >

[PATCH v3 0/1] Add software TX timestamps to the CAN devices

2021-01-10 Thread Vincent Mailhol
With the ongoing work to add BQL to Socket CAN, I figured out that it would be nice to have an easy way to mesure the latency. And one easy way to do so it to check the round trip time of the packet by doing the difference between the software rx timestamp and the software tx timestamp. rx

[PATCH v3 1/1] can: dev: add software tx timestamps

2021-01-10 Thread Vincent Mailhol
Call skb_tx_timestamp() within can_put_echo_skb() so that a software tx timestamp gets attached on the skb. There two main reasons to include this call in can_put_echo_skb(): * It easily allow to enable the tx timestamp on all devices with just one small change. * According to

[GIT PULL] Please pull powerpc/linux.git powerpc-5.11-3 tag

2021-01-10 Thread Michael Ellerman
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 Hi Linus, Please pull a couple of powerpc fixes for 5.11: The following changes since commit e71ba9452f0b5b2e8dc8aa5445198cd9214a6a62: Linux 5.11-rc2 (2021-01-03 15:55:30 -0800) are available in the git repository at:

Re: [PATCH] scsi: ufs: A tad optimization in query upiu trace

2021-01-10 Thread Bean Huo
On Sun, 2021-01-10 at 10:46 +0200, Avri Altman wrote: > Remove a redundant if clause in ufshcd_add_query_upiu_trace. > > Signed-off-by: Avri Altman Looks good to me, thanks. Reviewed-by: Bean Huo

[PATCH V4 0/3] Decouple config data for configfs

2021-01-10 Thread Sumera Priyadarsini
This patchset aims to lay down some prep work before configfs can be implemented for the vkms driver. The first patch in the series adds a new type vkms_config to track device configuration. The second and third patch add module testing support for writeback operations. The first patch is

[PATCH V4 1/3] drm/vkms: Add vkms_config type

2021-01-10 Thread Sumera Priyadarsini
Currently, data for the device instance is held by vkms_device. Add a separate type, vkms_config to contain configuration details for the device and various modes to be later used by configfs. This config data stays constant once the device is created. Accordingly, add vkms_create and

[PATCH V4 2/3] drm/vkms: Add support for writeback module

2021-01-10 Thread Sumera Priyadarsini
Add enable_writeback feature to vkms_config as a module. Signed-off-by: Sumera Priyadarsini --- drivers/gpu/drm/vkms/vkms_drv.c| 5 + drivers/gpu/drm/vkms/vkms_drv.h| 1 + drivers/gpu/drm/vkms/vkms_output.c | 9 ++--- 3 files changed, 12 insertions(+), 3 deletions(-) diff --git

[PATCH V4 3/3] drm/vkms: Add information about module options

2021-01-10 Thread Sumera Priyadarsini
Update vkms documentation to contain usage of `modinfo` command and steps to load vkms with module options enabled. Signed-off-by: Sumera Priyadarsini --- Documentation/gpu/vkms.rst | 10 ++ 1 file changed, 10 insertions(+) diff --git a/Documentation/gpu/vkms.rst

[GIT PULL] Char/Misc driver fixes for 5.11-rc3

2021-01-10 Thread Greg KH
The following changes since commit 5c8fe583cce542aa0b84adc939ce85293de36e5e: Linux 5.11-rc1 (2020-12-27 15:30:22 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git tags/char-misc-5.11-rc3 for you to fetch changes up to

[GIT PULL] Staging driver fixes for 5.11-rc3

2021-01-10 Thread Greg KH
The following changes since commit 5c8fe583cce542aa0b84adc939ce85293de36e5e: Linux 5.11-rc1 (2020-12-27 15:30:22 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git tags/staging-5.11-rc3 for you to fetch changes up to

[GIT PULL] USB driver fixes for 5.11-rc3

2021-01-10 Thread Greg KH
The following changes since commit 5c8fe583cce542aa0b84adc939ce85293de36e5e: Linux 5.11-rc1 (2020-12-27 15:30:22 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git tags/usb-5.11-rc3 for you to fetch changes up to

[PATCH mips-fixes] MIPS: relocatable: fix possible boot hangup with KASLR enabled

2021-01-10 Thread Alexander Lobakin
LLVM-built Linux triggered a boot hangup with KASLR enabled. arch/mips/kernel/relocate.c:get_random_boot() uses linux_banner, which is a string constant, as a random seed, but accesses it as an array of unsigned long (in rotate_xor()). When the address of linux_banner is not aligned to

Re: [PATCH 1/2] pinctrl: Add driver for Awinic AW9523/B I2C GPIO Expander

2021-01-10 Thread AngeloGioacchino Del Regno
Il 10/01/21 01:24, Linus Walleij ha scritto: On Sun, Jan 10, 2021 at 12:11 AM AngeloGioacchino Del Regno wrote: Il 09/01/21 23:11, Linus Walleij ha scritto: The major review comment is that it'd be nice if you look into using regmaps register cache instead of rolling your own, and also

[PATCH net-next] net: mvpp2: prs: improve ipv4 parse flow

2021-01-10 Thread stefanc
From: Stefan Chulski Patch didn't fix any issue, just improve parse flow and align ipv4 parse flow with ipv6 parse flow. Currently ipv4 kenguru parser first check IP protocol(TCP/UDP) and then destination IP address. Patch introduce reverse ipv4 parse, first destination IP address parsed and

Re: [PATCH 3/3] arm64: dts: rockchip: rk3328: Add Radxa ROCK Pi E

2021-01-10 Thread Johan Jonker
Hi Chen-Yu, Some comments, have a look if it is useful... On 1/10/21 4:58 AM, Chen-Yu Tsai wrote: > From: Chen-Yu Tsai > > Radxa ROCK Pi E is a router oriented SBC based on Rockchip's RK3328 SoC. > As the official wiki page puts it, "E for Ethernets". > > It features the RK3328 SoC, gigabit

Re: [PATCH 1/2] pinctrl: Add driver for Awinic AW9523/B I2C GPIO Expander

2021-01-10 Thread AngeloGioacchino Del Regno
Il 10/01/21 15:32, AngeloGioacchino Del Regno ha scritto: Il 10/01/21 01:24, Linus Walleij ha scritto: On Sun, Jan 10, 2021 at 12:11 AM AngeloGioacchino Del Regno wrote: Il 09/01/21 23:11, Linus Walleij ha scritto: The major review comment is that it'd be nice if you look into using

[PATCH] drivers: base: change 'driver_create_groups' to 'driver_add_groups' in printk

2021-01-10 Thread Joe Pater
driver_create_groups doesn't seem to have ever existed. Change its mention in a printk to 'driver_add_groups'. Signed-off-by: Joe Pater <02joepate...@gmail.com> --- drivers/base/bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/base/bus.c b/drivers/base/bus.c

Re: [PATCH v8 04/20] dlb: add device ioctl layer and first three ioctls

2021-01-10 Thread Greg KH
On Sat, Jan 09, 2021 at 01:49:42PM -0800, Dan Williams wrote: > On Sat, Jan 9, 2021 at 12:34 AM Greg KH wrote: > > > > On Sat, Jan 09, 2021 at 07:49:24AM +, Chen, Mike Ximing wrote: > > > > > +static int dlb_ioctl_arg_size[NUM_DLB_CMD] = { > > > > > + sizeof(struct

Re: [PATCH v5 00/15] Add functionality to ipu3-cio2 driver allowing software_node connections to sensors on platforms designed for Windows

2021-01-10 Thread Greg Kroah-Hartman
On Sat, Jan 09, 2021 at 04:08:04AM +0200, Laurent Pinchart wrote: > Hi Greg, > > On Thu, Jan 07, 2021 at 01:28:23PM +, Daniel Scally wrote: > > > > Hello all > > > > v4: > >

Re: [PATCH v5 08/15] software_node: Add support for fwnode_graph*() family of functions

2021-01-10 Thread Greg KH
On Thu, Jan 07, 2021 at 01:28:31PM +, Daniel Scally wrote: > From: Heikki Krogerus > > This implements the remaining .graph_*() callbacks in the fwnode > operations structure for the software nodes. That makes the > fwnode_graph_*() functions available in the drivers also when software >

Re: [PATCH v2 0/4] Config and device tree updates for the Librem 5 devkit

2021-01-10 Thread Guido Günther
Hi Shawn, On Sun, Jan 10, 2021 at 08:26:18PM +0800, Shawn Guo wrote: > On Thu, Dec 17, 2020 at 04:13:11PM +0100, Guido Günther wrote: > > This enables more components to get a working display, panel, audio and > > sensors. It also updates some device tree bits to make mainline boot. > > > > I've

Re: [PATCH v5 06/15] software_node: unregister software_nodes in reverse order

2021-01-10 Thread Greg KH
On Thu, Jan 07, 2021 at 01:28:29PM +, Daniel Scally wrote: > To maintain consistency with software_node_unregister_nodes(), reverse > the order in which the software_node_unregister_node_group() function > unregisters nodes. > > Reported-by: kernel test robot > Reported-by: Dan Carpenter >

  1   2   3   4   5   6   >