Re: [PATCH] scsi_logging: print cdb into new line after opcode

2021-01-22 Thread Ewan D. Milne
On Fri, 2021-01-22 at 09:39 +0100, Martin Kepplinger wrote: > The current log message results in a line like the following where > the first byte is duplicated, giving a wrong impression: > > sd 0:0:0:0: [sda] tag#0 CDB: opcode=0x28 28 00 00 00 60 40 00 00 01 > 00 > > Print the cdb into a new

[PATCH v3 1/5] hugetlb: use page.private for hugetlb specific page flags

2021-01-22 Thread Mike Kravetz
As hugetlbfs evolved, state information about hugetlb pages was added. One 'convenient' way of doing this was to use available fields in tail pages. Over time, it has become difficult to know the meaning or contents of fields simply by looking at a small bit of code. Sometimes, the naming is

[PATCH v3 5/5] hugetlb: convert PageHugeFreed to HPageFreed flag

2021-01-22 Thread Mike Kravetz
Use new hugetlb specific HPageFreed flag to replace the PageHugeFreed interfaces. Signed-off-by: Mike Kravetz Reviewed-by: Oscar Salvador Reviewed-by: Muchun Song --- include/linux/hugetlb.h | 3 +++ mm/hugetlb.c| 23 --- 2 files changed, 7 insertions(+), 19

Re: [PATCH RESEND v8 2/4] input: elants: support old touch report format

2021-01-22 Thread Michał Mirosław
On Fri, Jan 22, 2021 at 11:10:52PM +0300, Dmitry Osipenko wrote: > 08.01.2021 01:06, Dmitry Osipenko пишет: > > 11.12.2020 21:48, Dmitry Torokhov пишет: > >> On Fri, Dec 11, 2020 at 06:04:01PM +0100, Michał Mirosław wrote: > >>> On Fri, Dec 11, 2020 at 07:39:33PM +0300, Dmitry Osipenko wrote: >

Re: [PATCH v2] lan743x: add virtual PHY for PHY-less devices

2021-01-22 Thread Sergej Bauer
On Saturday, January 23, 2021 1:08:03 AM MSK Andrew Lunn wrote: > On Sat, Jan 23, 2021 at 12:42:41AM +0300, Sergej Bauer wrote: > > From: sba...@blackbox.su > > > > v1->v2: > > switch to using of fixed_phy as was suggested by Andrew and Florian > > also features-related parts are removed

Re: [PATCH v2] lan743x: add virtual PHY for PHY-less devices

2021-01-22 Thread Andrew Lunn
> > > @@ -1000,8 +1005,10 @@ static void lan743x_phy_close(struct > > > lan743x_adapter *adapter)> > > > struct net_device *netdev = adapter->netdev; > > > > > > phy_stop(netdev->phydev); > > > > > > - phy_disconnect(netdev->phydev); > > > - netdev->phydev = NULL; > > > + if

Re: rcu-torture: Internal error: Oops: 96000006

2021-01-22 Thread Paul E. McKenney
On Fri, Jan 22, 2021 at 09:16:38PM +0530, Naresh Kamboju wrote: > On Fri, 22 Jan 2021 at 21:07, Paul E. McKenney wrote: > > > > On Fri, Jan 22, 2021 at 03:21:07PM +0530, Naresh Kamboju wrote: > > > On Fri, 22 Jan 2021 at 03:13, Paul E. McKenney wrote: > > > > > > > > On Thu, Jan 21, 2021 at

[PATCH v2] mm/vmalloc: Separate put pages and flush VM flags

2021-01-22 Thread Rick Edgecombe
When VM_MAP_PUT_PAGES was added, it was defined with the same value as VM_FLUSH_RESET_PERMS. This doesn't seem like it will cause any big functional problems other than some excess flushing for VM_MAP_PUT_PAGES allocations. Redefine VM_MAP_PUT_PAGES to have its own value. Also, rearrange things

Re: [PATCH v2] KVM/SVM: add support for SEV attestation command

2021-01-22 Thread Brijesh Singh
Hi Paolo, Do you have any feedback on this ? It will be great if we can queue this for 5.11. -Brijesh On 1/4/21 9:17 AM, Brijesh Singh wrote: > The SEV FW version >= 0.23 added a new command that can be used to query > the attestation report containing the SHA-256 digest of the guest memory >

Re: [PATCH v2] lan743x: add virtual PHY for PHY-less devices

2021-01-22 Thread Sergej Bauer
On Saturday, January 23, 2021 2:23:25 AM MSK Andrew Lunn wrote: > > > > @@ -1000,8 +1005,10 @@ static void lan743x_phy_close(struct > > > > lan743x_adapter *adapter)> > > > > > > > > struct net_device *netdev = adapter->netdev; > > > > > > > > phy_stop(netdev->phydev); >

Re: [PATCH v9 02/18] arm64: hibernate: move page handling function to new trans_pgd.c

2021-01-22 Thread Pavel Tatashin
On Wed, Apr 29, 2020 at 1:00 PM James Morse wrote: > > Hi Pavel, > > On 26/03/2020 03:24, Pavel Tatashin wrote: > > Now, that we abstracted the required functions move them to a new home. > > Later, we will generalize these function in order to be useful outside > > of hibernation. > >

Re: [PATCH next v2 04/17] dt-bindings: phy: mediatek: dsi-phy: add optional clock-names

2021-01-22 Thread Chun-Kuang Hu
Hi, Chunfeng: Chunfeng Yun 於 2021年1月22日 週五 下午8:04寫道: > > Add an optional "clock-names" property, it's not used to get the clock, > but some DTS files (e.g. mt8183) provide it. I think the logic is that we define property in binding document first, and then write it in device tree. If a property

Re: [PATCH v9 04/18] arm64: trans_pgd: pass allocator trans_pgd_create_copy

2021-01-22 Thread Pavel Tatashin
On Wed, Apr 29, 2020 at 1:01 PM James Morse wrote: > > Hi Pavel, > > On 26/03/2020 03:24, Pavel Tatashin wrote: > > Make trans_pgd_create_copy and its subroutines to use allocator that is > > passed as an argument > > Reviewed-by: James Morse Thank you, Pasha

[GIT PULL] KUnit update for Linux 5.11-rc5

2021-01-22 Thread Shuah Khan
Hi Linus, Please pull the following KUnit fixes update for Linux 5.11-rc5. This KUnit update for Linux 5.11-rc5 consists of 5 fixes to kunit tool and documentation from Daniel Latypov and David Gow. diff is attached. thanks, -- Shuah

Re: [Nouveau] nouveau regression post v5.8, still present in v5.10

2021-01-22 Thread Jamie Heilman
Jamie Heilman wrote: > Karol Herbst wrote: > > fyi, there is a patch which solves a maybe related issue on your GPU, > > mind giving it a try before we dig further? > > https://gitlab.freedesktop.org/drm/nouveau/-/issues/14#note_767791 > > So, I tried that. Turns out, I can still trigger a

Re: [RFC][PATCH 2/3] dma-buf: system_heap: Add pagepool support to system heap

2021-01-22 Thread John Stultz
On Mon, Dec 21, 2020 at 2:09 PM Daniel Vetter wrote: > > On Fri, Dec 18, 2020 at 05:16:56PM -0800, John Stultz wrote: > > On Fri, Dec 18, 2020 at 6:36 AM Daniel Vetter wrote: > > > On Thu, Dec 17, 2020 at 11:06:11PM +, John Stultz wrote: > > > > Reuse/abuse the pagepool code from the network

Re: [PATCH net 1/1] net: fec: Fix temporary RMII clock reset on link up

2021-01-22 Thread Jakub Kicinski
On Fri, 22 Jan 2021 16:13:47 +0100 Laurent Badel wrote: > fec_restart() does a hard reset of the MAC module when the link status > changes to up. This temporarily resets the R_CNTRL register which controls > the MII mode of the ENET_OUT clock. In the case of RMII, the clock > frequency

Re: [PATCH v3 net-next 0/4] net: ipa: remove a build dependency

2021-01-22 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Wed, 20 Jan 2021 15:26:02 -0600 you wrote: > (David/Jakub, please take these all through net-next if they are > acceptable to you, once Rob has acked the binding. Rob, please ack > if the binding looks OK to you.) >

[PATCH] spmi: spmi-pmic-arb: Fix hw_irq overflow

2021-01-22 Thread Subbaraman Narayanamurthy
Currently, when handling the SPMI summary interrupt, the hw_irq number is calculated based on SID, Peripheral ID, IRQ index and APID. This is then passed to irq_find_mapping() to see if a mapping exists for this hw_irq and if available, invoke the interrupt handler. Since the IRQ index uses an

Re: [PATCH 3/4] ubifs: Update directory size when creating whiteouts

2021-01-22 Thread Zhihao Cheng
在 2021/1/23 5:22, Richard Weinberger 写道: Although whiteouts are unlinked files they will get re-linked later, I just want to make sure, is this where the count is increased? do_rename -> inc_nlink(whiteout) therefore the size of the parent directory needs to be updated too. Cc:

[PATCH] nfc: fix typo

2021-01-22 Thread samirweng1979
From: wengjianfeng change 'regster' to 'register' Signed-off-by: wengjianfeng --- drivers/nfc/trf7970a.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/nfc/trf7970a.c b/drivers/nfc/trf7970a.c index c70f62fe..3397802 100644 --- a/drivers/nfc/trf7970a.c +++

[PATCH v3 1/2] power: supply: PCHG: Peripheral device charger

2021-01-22 Thread Daisuke Nojiri
This patch adds a driver for PCHG (Peripheral CHarGer). PCHG is a framework managing power supplies for peripheral devices. This driver creates a sysfs node for each peripheral charge port: /sys/class/power_supply/PCHGn where is the index of a charge port. For example, when a stylus

Re: [Nouveau] nouveau regression post v5.8, still present in v5.10

2021-01-22 Thread Jamie Heilman
Karol Herbst wrote: > fyi, there is a patch which solves a maybe related issue on your GPU, > mind giving it a try before we dig further? > https://gitlab.freedesktop.org/drm/nouveau/-/issues/14#note_767791 So, I tried that. Turns out, I can still trigger a problem. Is it the same problem?

[PATCH v2 00/10] mm: lru related cleanups

2021-01-22 Thread Yu Zhao
The cleanups are intended to reduce the verbosity in lru list operations and make them less error-prone. A typical example would be how the patches change __activate_page(): static void __activate_page(struct page *page, struct lruvec *lruvec) { if (!PageActive(page) &&

[PATCH v2 01/10] mm: use add_page_to_lru_list()

2021-01-22 Thread Yu Zhao
There is add_page_to_lru_list(), and move_pages_to_lru() should reuse it, not duplicate it. Link: https://lore.kernel.org/linux-mm/20201207220949.830352-2-yuz...@google.com/ Signed-off-by: Yu Zhao Reviewed-by: Alex Shi --- mm/vmscan.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-)

[PATCH v2 04/10] mm: don't pass "enum lru_list" to trace_mm_lru_insertion()

2021-01-22 Thread Yu Zhao
The parameter is redundant in the sense that it can be extracted from the "struct page" parameter by page_lru() correctly. Link: https://lore.kernel.org/linux-mm/20201207220949.830352-5-yuz...@google.com/ Signed-off-by: Yu Zhao Reviewed-by: Alex Shi --- include/trace/events/pagemap.h | 11

Re: [PATCH] bpf: Drop disabled LSM hooks from the sleepable set

2021-01-22 Thread KP Singh
On Fri, Jan 22, 2021 at 1:32 PM Mikko Ylinen wrote: > > Networking LSM hooks are conditionally enabled and when building the new > sleepable BPF LSM hooks with the networking LSM hooks disabled, the > following build error occurs: > > BTFIDS vmlinux > FAILED unresolved symbol

[PATCH 4.14 22/50] NFS4: Fix use-after-free in trace_event_raw_event_nfs4_set_lock

2021-01-22 Thread Greg Kroah-Hartman
From: Dave Wysochanski commit 3d1a90ab0ed93362ec8ac85cf291243c87260c21 upstream. It is only safe to call the tracepoint before rpc_put_task() because 'data' is freed inside nfs4_lock_release (rpc_release). Fixes: 48c9579a1afe ("Adding stateid information to tracepoints") Signed-off-by: Dave

[PATCH 4.14 02/50] MIPS: boot: Fix unaligned access with CONFIG_MIPS_RAW_APPENDED_DTB

2021-01-22 Thread Greg Kroah-Hartman
From: Paul Cercueil commit 4d4f9c1a17a3480f8fe523673f7232b254d724b7 upstream. The compressed payload is not necesarily 4-byte aligned, at least when compiling with Clang. In that case, the 4-byte value appended to the compressed payload that corresponds to the uncompressed kernel image size

[PATCH 4.14 14/50] ethernet: ucc_geth: fix definition and size of ucc_geth_tx_global_pram

2021-01-22 Thread Greg Kroah-Hartman
From: Rasmus Villemoes [ Upstream commit 887078de2a23689e29d6fa1b75d7cbc544c280be ] Table 8-53 in the QUICC Engine Reference manual shows definitions of fields up to a size of 192 bytes, not just 128. But in table 8-111, one does find the text Base Address of the Global Transmitter Parameter

Re: [RESEND][PATCH 2/3] dma-buf: heaps: Add a WARN_ON should the vmap_cnt go negative

2021-01-22 Thread John Stultz
On Fri, Jan 22, 2021 at 2:21 PM Suren Baghdasaryan wrote: > On Thu, Jan 21, 2021 at 11:56 PM Sumit Semwal wrote: > > On Wed, 20 Jan 2021 at 02:15, John Stultz wrote: > > > > > > We shouldn't vunmap more then we vmap, but if we do, make > > > sure we complain loudly. > > > > I was checking the

[PATCH 4.14 20/50] dump_common_audit_data(): fix racy accesses to ->d_name

2021-01-22 Thread Greg Kroah-Hartman
From: Al Viro commit d36a1dd9f77ae1e72da48f4123ed35627848507d upstream. We are not guaranteed the locking environment that would prevent dentry getting renamed right under us. And it's possible for old long name to be freed after rename, leading to UAF here. Cc: sta...@kernel.org # v2.6.2+

[PATCH 4.14 17/50] net: ethernet: fs_enet: Add missing MODULE_LICENSE

2021-01-22 Thread Greg Kroah-Hartman
From: Michael Ellerman [ Upstream commit 445c6198fe7be03b7d38e66fe8d4b3187bc251d4 ] Since commit 1d6cd3929360 ("modpost: turn missing MODULE_LICENSE() into error") the ppc32_allmodconfig build fails with: ERROR: modpost: missing MODULE_LICENSE() in

Re: [PATCH 3/3] lib: support N as end of range in bitmap_parselist()

2021-01-22 Thread Yury Norov
On Thu, Jan 21, 2021 at 8:44 PM Paul Gortmaker wrote: > > [Re: [PATCH 3/3] lib: support N as end of range in bitmap_parselist()] On > 21/01/2021 (Thu 16:29) Yury Norov wrote: > > > On Thu, Jan 21, 2021 at 2:34 PM Paul Gortmaker > > wrote: > > > > > > While this is done for all bitmaps, the

Re: [PATCH bpf-next v4] samples/bpf: Update build procedure for manually compiling LLVM and Clang

2021-01-22 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to bpf/bpf-next.git (refs/heads/master): On Fri, 22 Jan 2021 09:39:44 +0800 you wrote: > The current LLVM and Clang build procedure in samples/bpf/README.rst is > out of date. See below that the links are not accessible any more. > > $ git clone

Re: [PATCH kspp-next] kbuild: prevent CC_FLAGS_LTO self-bloating on recursive rebuilds

2021-01-22 Thread Kees Cook
On Thu, Jan 21, 2021 at 06:45:55PM +, Alexander Lobakin wrote: > CC_FLAGS_LTO gets initialized only via +=, never with := or =. > When building with CONFIG_TRIM_UNUSED_KSYMS, Kbuild may perform > several kernel rebuilds to satisfy symbol dependencies. In this > case, value of CC_FLAGS_LTO is

[PATCH v2] IMA: Measure kernel version in early boot

2021-01-22 Thread Raphael Gianotti
The integrity of a kernel can be verified by the boot loader on cold boot, and during kexec, by the current running kernel, before it is loaded. However, it is still possible that the new kernel being loaded is older than the current kernel, and/or has known vulnerabilities. Therefore, it is

Re: [PATCH v2] MAINTAINERS: Add FPGA SUBDEVICES

2021-01-22 Thread Moritz Fischer
On Fri, Jan 22, 2021 at 11:29:28AM -0800, t...@redhat.com wrote: > From: Tom Rix > > Every FPGA has several subdevices in other subsystems. > The new FPGA subdevices section is necessary to ensure changes to > the subdevices files get reviewed within the context of the FPGA > subsystem. > >

[PATCH 0/2] KVM: x86: Minor steal time cleanups

2021-01-22 Thread Sean Christopherson
Cleanups and a minor optimization to kvm_steal_time_set_preempted() that were made possible by the switch to using a cache gfn->pfn translation. Sean Christopherson (2): KVM: x86: Remove obsolete disabling of page faults in kvm_arch_vcpu_put() KVM: x86: Take KVM's SRCU lock only if steal

[PATCH 2/2] KVM: x86: Take KVM's SRCU lock only if steal time update is needed

2021-01-22 Thread Sean Christopherson
Enter a SRCU critical section for a memslots lookup during steal time update if and only if a steal time update is actually needed. Taking the lock can be avoided if steal time is disabled by the guest, or if KVM knows it has already flagged the vCPU as being preempted. Reword the comment to be

[PATCH 1/2] KVM: x86: Remove obsolete disabling of page faults in kvm_arch_vcpu_put()

2021-01-22 Thread Sean Christopherson
Remove the disabling of page faults across kvm_steal_time_set_preempted() as KVM now accesses the steal time struct (shared with the guest) via a cached mapping (see commit b043138246a4, "x86/KVM: Make sure KVM_VCPU_FLUSH_TLB flag is not missed".) The cache lookup is flagged as atomic, thus it

Re: [RFC PATCH v3 15/16] cxl/mem: Add limited Get Log command (0401h)

2021-01-22 Thread Ben Widawsky
On 21-01-14 18:08:26, Jonathan Cameron wrote: > On Mon, 11 Jan 2021 14:51:20 -0800 > Ben Widawsky wrote: > > > The Get Log command returns the actual log entries that are advertised > > via the Get Supported Logs command (0400h). CXL device logs are selected > > by UUID which is part of the CXL

[PATCH 0/3] KVM: x86: Revert dirty tracking for GPRs

2021-01-22 Thread Sean Christopherson
This is effectively belated feedback on the SEV-ES series. My primary interest is to revert the GPR dirty/available tracking, as it's pure overhead for non-SEV-ES VMs, and even for SEV-ES I suspect the dirty tracking is at best lost in the noise, and possibly even a net negative. My original

Re: [PATCH 4.19 00/22] 4.19.170-rc1 review

2021-01-22 Thread Shuah Khan
On 1/22/21 7:12 AM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.19.170 release. There are 22 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be

Re: [PATCH 4.4 00/31] 4.4.253-rc1 review

2021-01-22 Thread Shuah Khan
On 1/22/21 7:08 AM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.4.253 release. There are 31 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made

Re: [PATCH v9 08/18] arm64: kexec: move relocation function setup

2021-01-22 Thread Pavel Tatashin
On Wed, Apr 29, 2020 at 1:01 PM James Morse wrote: > > Hi Pavel, > > On 26/03/2020 03:24, Pavel Tatashin wrote: > > Currently, kernel relocation function is configured in machine_kexec() > > at the time of kexec reboot by using control_code_page. > > > > This operation, however, is more logical

Re: [PATCH net] tcp: make TCP_USER_TIMEOUT accurate for zero window probes

2021-01-22 Thread Jakub Kicinski
On Fri, 22 Jan 2021 11:13:06 -0800 Enke Chen wrote: > From: Enke Chen > > The TCP_USER_TIMEOUT is checked by the 0-window probe timer. As the > timer has backoff with a max interval of about two minutes, the > actual timeout for TCP_USER_TIMEOUT can be off by up to two minutes. > > In this

Re: [PATCH] regulator: core: avoid regulator_resolve_supply() race condition

2021-01-22 Thread David Collins
Hello Mark, On 1/21/21 12:30 PM, Marek Szyprowski wrote: Hi Mark, On 21.01.2021 16:44, Mark Brown wrote: On Thu, Jan 21, 2021 at 10:41:59AM +0100, Marek Szyprowski wrote: On 18.01.2021 21:49, Mark Brown wrote: Does this help (completely untested): Sadly nope. I get same warning: Try this

Re: [PATCH v2 00/20] objtool: vmlinux.o and CLANG LTO support

2021-01-22 Thread Josh Poimboeuf
On Fri, Jan 22, 2021 at 05:32:43PM -0800, Nick Desaulniers wrote: > > In this specific case, find_func_by_offset returns NULL for > > .text..L.cfi.jumptable.43 at addend 0x8, because Clang doesn't emit > > jump table symbols for static functions: > > > >

Re: [PATCH] net: Simplify the calculation of variables

2021-01-22 Thread Jakub Kicinski
On Fri, 22 Jan 2021 16:57:47 +0800 Jiapeng Zhong wrote: > Fix the following coccicheck warnings: > > ./net/ipv4/esp4_offload.c:288:32-34: WARNING !A || A && B is > equivalent to !A || B. > > Reported-by: Abaci Robot > Signed-off-by: Jiapeng Zhong > --- > net/ipv4/esp4_offload.c | 2 +- > 1

Re: [PATCH v2 net-next] vmxnet3: Remove buf_info from device

2021-01-22 Thread Jakub Kicinski
On Fri, 22 Jan 2021 00:30:51 -0800 Ronak Doshi wrote: > + tq->buf_info = kcalloc_node(tq->tx_ring.size, sizeof(tq->buf_info[0]), > + GFP_KERNEL | __GFP_ZERO, > + dev_to_node(>pdev->dev)); no need to pass __GFP_ZERO to kcalloc

Re: [PATCH] scsi: megaraid: fix ifnullfree.cocci warnings

2021-01-22 Thread Martin K. Petersen
Julia, > NULL check before vfree is not needed. > > Generated by: scripts/coccinelle/free/ifnullfree.cocci Applied to 5.12/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering

[PATCH] RISC-V: probes: Treat the instruction stream as host-endian

2021-01-22 Thread Palmer Dabbelt
From: Palmer Dabbelt Neither of these are actually correct: the instruction stream is defined (for versions of the ISA manual newer than 2.2) as a stream of 16-bit little-endian parcels, which is different than just being little-endian. In theory we should represent this as a type, but we don't

[PATCH v2 1/3] dma-buf: heaps: Add deferred-free-helper library code

2021-01-22 Thread John Stultz
This patch provides infrastructure for deferring buffer frees. This is a feature ION provided which when used with some form of a page pool, provides a nice performance boost in an allocation microbenchmark. The reason it helps is it allows the page-zeroing to be done out of the normal

[PATCH v2 2/3] dma-buf: system_heap: Add pagepool support to system heap

2021-01-22 Thread John Stultz
Reuse/abuse the pagepool code from the network code to speed up allocation performance. This is similar to the ION pagepool usage, but tries to utilize generic code instead of a custom implementation. Cc: Daniel Vetter Cc: Sumit Semwal Cc: Liam Mark Cc: Chris Goldsworthy Cc: Laura Abbott

[PATCH v2 3/3] dma-buf: system_heap: Add deferred freeing to the system heap

2021-01-22 Thread John Stultz
Utilize the deferred free helper library in the system heap. This provides a nice performance bump and puts the system heap performance on par with ION. Cc: Daniel Vetter Cc: Sumit Semwal Cc: Liam Mark Cc: Chris Goldsworthy Cc: Laura Abbott Cc: Brian Starkey Cc: Hridya Valsaraju Cc: Suren

Re: [PATCH v2] lan743x: add virtual PHY for PHY-less devices

2021-01-22 Thread Sergej Bauer
resending answer to all: On Saturday, January 23, 2021 4:32:38 AM MSK Andrew Lunn wrote: > > it migth be helpful for developers work on userspace networking tools with > > PHY-less lan743x > > (the interface even could not be brought up) > > > of course, there nothing much to do without TP port

Re: [PATCH] scsi: pm80xx: switch from 'pci_' to 'dma_' API

2021-01-22 Thread Martin K. Petersen
On Sun, 17 Jan 2021 14:24:45 +0100, Christophe JAILLET wrote: > The wrappers in include/linux/pci-dma-compat.h should go away. > > The patch has been generated with the coccinelle script below and has been > hand modified to replace GFP_ with a correct flag. > It has been compile tested. > >

Re: [PATCH] scsi: ufs: delete redundant if statement in ufshcd_intr()

2021-01-22 Thread Martin K. Petersen
On Mon, 18 Jan 2021 21:12:33 +0100, Bean Huo wrote: > Once going into while-do loop, intr_status is already true, > this if-statement is redundant, remove it. Applied to 5.12/scsi-queue, thanks! [1/1] scsi: ufs: delete redundant if statement in ufshcd_intr()

Re: [PATCH v7 0/6] Several changes for UFS WriteBooster

2021-01-22 Thread Martin K. Petersen
On Tue, 19 Jan 2021 17:38:41 +0100, Bean Huo wrote: > Changelog: > > v6--v7: > 1. Change wb_on sysfs documentation and add information that WriteBooster > is already enabled after power-on/reset(Incorporate Adrian Hunter's > suggestion) > > v5--v6: > 1. Remove original patch 7/7: > "scsi:

Re: [PATCH v3 0/3] scsi: ufs: Cleanup and refactor clock scaling

2021-01-22 Thread Martin K. Petersen
On Wed, 20 Jan 2021 23:01:39 +0800, Stanley Chu wrote: > This series cleans up and refactors clk-scaling feature, and shall not change > any functionality. > > This series is based on Can's series "Three changes related with UFS clock > scaling" in 5.12/scsi-queue branch in Martin's tree. > >

Re: [PATCH][next] scsi: pm80xx: clean up indentation of a code block

2021-01-22 Thread Martin K. Petersen
On Fri, 15 Jan 2021 09:58:24 +, Colin King wrote: > A block of code is indented one level too deeply, clean this > up. Applied to 5.12/scsi-queue, thanks! [1/1] scsi: pm80xx: clean up indentation of a code block https://git.kernel.org/mkp/scsi/c/7b382122d276 -- Martin K. Petersen

Re: [net-next PATCH 3/7] octeontx2-pf: ethtool fec mode support

2021-01-22 Thread Jakub Kicinski
On Thu, 21 Jan 2021 13:23:25 +0530 Hariprasad Kelam wrote: > From: Christina Jacob > > Add ethtool support to configure fec modes baser/rs and > support to fecth FEC stats from CGX as well PHY. > > Configure fec mode > - ethtool --set-fec eth0 encoding rs/baser/off/auto > Query fec mode >

Re: [PATCH v2 5/6] hwmon: (lm70) Avoid undefined reference to match table

2021-01-22 Thread Guenter Roeck
On 1/22/21 7:44 PM, Stephen Boyd wrote: > We're going to remove of_match_ptr() from the definition of > of_match_device() when CONFIG_OF=n. This way we can always be certain > that of_match_device() acts the same when CONFIG_OF is set and when it > isn't. Add of_match_ptr() here so that this

[PATCH] mm/workingset.c: avoid unnecessary max_nodes estimation in count_shadow_nodes()

2021-01-22 Thread Miaohe Lin
If list_lru_shrink_count is 0, we always return SHRINK_EMPTY regardless of the value of max_nodes. So we can return early if nodes == 0 to save some cpu cycles of approximating a reasonable limit for the nodes. Signed-off-by: Miaohe Lin --- mm/workingset.c | 5 ++--- 1 file changed, 2

[PATCH v2 06/10] mm: add __clear_page_lru_flags() to replace page_off_lru()

2021-01-22 Thread Yu Zhao
Similar to page_off_lru(), the new function does non-atomic clearing of PageLRU() in addition to PageActive() and PageUnevictable(), on a page that has no references left. If PageActive() and PageUnevictable() are both set, refuse to clear either and leave them to bad_page(). This is a behavior

Re: [PATCH] Revert "mm: memcontrol: avoid workload stalls when lowering memory.high"

2021-01-22 Thread Roman Gushchin
On Fri, Jan 22, 2021 at 01:43:41PM -0500, Johannes Weiner wrote: > This reverts commit 536d3bf261a2fc3b05b3e91e7eef7383443015cf, as it > can cause writers to memory.high to get stuck in the kernel forever, > performing page reclaim and consuming excessive amounts of CPU cycles. > > Before the

Re: [PATCH] arm64: PCI: Enable SMC conduit

2021-01-22 Thread Will Deacon
Hi Lorenzo, On Fri, Jan 08, 2021 at 10:32:16AM +, Lorenzo Pieralisi wrote: > On Thu, Jan 07, 2021 at 04:05:48PM -0500, Jon Masters wrote: > > On 1/7/21 1:14 PM, Will Deacon wrote: > > > > > On Mon, Jan 04, 2021 at 10:57:35PM -0600, Jeremy Linton wrote: > > > > Given that most arm64

Re: [PATCH 0/8] cpupower: Updates and cleanup to support AMD Family 0x19

2021-01-22 Thread Robert Richter
On 22.01.21 11:38:28, Nathan Fontenot wrote: > Updates to the cpupower command to add support for AMD family 0x19 > and cleanup the code to remove many of the family checks to hopefully > make any future family updates easier. > > The first couple of patches are simple updates to rename the

Re: [PATCH v1] memory: tegra: Check whether reset is already asserted

2021-01-22 Thread Krzysztof Kozlowski
On Sat, Jan 23, 2021 at 12:58:12AM +0300, Dmitry Osipenko wrote: > 23.01.2021 00:40, Krzysztof Kozlowski пишет: > > On Wed, Jan 20, 2021 at 02:52:10AM +0300, Dmitry Osipenko wrote: > >> Check whether memory client reset is already asserted in order to prevent > >> DMA-flush error on trying to

[PATCH 2/3] KVM: x86: Revert "KVM: x86: Mark GPRs dirty when written"

2021-01-22 Thread Sean Christopherson
Revert the dirty/available tracking of GPRs now that KVM copies the GPRs to the GHCB on any post-VMGEXIT VMRUN, even if a GPR is not dirty. Per commit de3cd117ed2f ("KVM: x86: Omit caching logic for always-available GPRs"), tracking for GPRs noticeably impacts KVM's code footprint. This reverts

Re: [PATCH v2] lan743x: add virtual PHY for PHY-less devices

2021-01-22 Thread Florian Fainelli
On 1/22/2021 3:58 PM, Sergej Bauer wrote: > On Saturday, January 23, 2021 2:23:25 AM MSK Andrew Lunn wrote: > @@ -1000,8 +1005,10 @@ static void lan743x_phy_close(struct > lan743x_adapter *adapter)> > > struct net_device *netdev = adapter->netdev; > >

[PATCH v13 3/5] PCI/ACPI: Tidy _OSC control bit checking

2021-01-22 Thread Kuppuswamy Sathyanarayanan
Add OSC_OWNER() helper to prettify checking the _OSC control bits to learn whether the platform has granted us control of PCI features. No functional change intended. [bhelgaas: split to separate patch, commit log] Signed-off-by: Kuppuswamy Sathyanarayanan Signed-off-by: Bjorn Helgaas ---

[PATCH v13 0/5] Simplify PCIe native ownership

2021-01-22 Thread Kuppuswamy Sathyanarayanan
Currently, PCIe capabilities ownership status is detected by verifying the status of pcie_ports_native, and _OSC negotiated results (cached in struct pci_host_bridge->native_* members). But this logic can be simplified, and we can use only struct pci_host_bridge ->native_* members to detect it.

Re: [PATCH v9 10/18] arm64: kexec: cpu_soft_restart change argument types

2021-01-22 Thread Pavel Tatashin
On Wed, Apr 29, 2020 at 1:01 PM James Morse wrote: > > Hi Pavel, > > On 26/03/2020 03:24, Pavel Tatashin wrote: > > Change argument types from unsigned long to a more descriptive > > phys_addr_t. > > For 'entry', which is a physical addresses, sure... > > > diff --git

[PATCH v13 1/5] PCI/DPC: Ignore devices with no AER Capability

2021-01-22 Thread Kuppuswamy Sathyanarayanan
From: Bjorn Helgaas Downstream Ports may support DPC regardless of whether they support AER (see PCIe r5.0, sec 6.2.10.2). Previously, if the user booted with "pcie_ports=dpc-native", it was possible for dpc_probe() to succeed even if the device had no AER Capability, but

Re: [PATCH v2] lan743x: add virtual PHY for PHY-less devices

2021-01-22 Thread Florian Fainelli
On 1/22/2021 5:01 PM, Sergej Bauer wrote: > On Saturday, January 23, 2021 3:01:47 AM MSK Florian Fainelli wrote: >> On 1/22/2021 3:58 PM, Sergej Bauer wrote: >>> On Saturday, January 23, 2021 2:23:25 AM MSK Andrew Lunn wrote: >>> @@ -1000,8 +1005,10 @@ static void lan743x_phy_close(struct

Re: [PATCH] scsi: qla2xxx: Assign boolean values to a bool variable

2021-01-22 Thread Martin K. Petersen
Jiapeng, > ./drivers/scsi/qla2xxx/qla_isr.c:780:2-18: WARNING: Assignment > of 0/1 to bool variable. Applied to 5.12/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering

[PATCH] spi: spi-au1550: pr_err instead of printk

2021-01-22 Thread corentin noel
Signed-off-by: corentin noel --- drivers/spi/spi-au1550.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/spi/spi-au1550.c b/drivers/spi/spi-au1550.c index dfb7196f4caf..8f92bbdf391b 100644 --- a/drivers/spi/spi-au1550.c +++ b/drivers/spi/spi-au1550.c @@ -972,8

Re: [External] Re: [PATCH v13 03/12] mm: hugetlb: free the vmemmap pages associated with each HugeTLB page

2021-01-22 Thread Muchun Song
On Sat, Jan 23, 2021 at 9:00 AM Mike Kravetz wrote: > > X-Gm-Spam: 0 > X-Gm-Phishy: 0 > > On 1/17/21 7:10 AM, Muchun Song wrote: > > Every HugeTLB has more than one struct page structure. We __know__ that > > we only use the first 4(HUGETLB_CGROUP_MIN_ORDER) struct page structures > > to store

Re: [PATCH v2 1/1] riscv/kasan: add KASAN_VMALLOC support

2021-01-22 Thread Palmer Dabbelt
On Fri, 15 Jan 2021 21:58:35 PST (-0800), nyl...@andestech.com wrote: It references to x86/s390 architecture. So, it doesn't map the early shadow page to cover VMALLOC space. Prepopulate top level page table for the range that would otherwise be empty. lower levels are filled dynamically upon

Re: [PATCH 4.9 00/33] 4.9.253-rc2 review

2021-01-22 Thread Naresh Kamboju
On Fri, 22 Jan 2021 at 21:40, Greg Kroah-Hartman wrote: > > This is the start of the stable review cycle for the 4.9.253 release. > There are 33 patches in this series, all will be posted as a response > to this one. If anyone has any issues with these being applied, please > let me know. > >

[PATCH] Input: ti_am335x_tsc - fix spelling mistake

2021-01-22 Thread liumingyu
From: liumingyu fix typo "postion" -> "position" Signed-off-by: liumingyu --- drivers/input/touchscreen/ti_am335x_tsc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/touchscreen/ti_am335x_tsc.c b/drivers/input/touchscreen/ti_am335x_tsc.c index

[PATCH v2 02/10] mm: shuffle lru list addition and deletion functions

2021-01-22 Thread Yu Zhao
These functions will call page_lru() in the following patches. Move them below page_lru() to avoid the forward declaration. Link: https://lore.kernel.org/linux-mm/20201207220949.830352-3-yuz...@google.com/ Signed-off-by: Yu Zhao --- include/linux/mm_inline.h | 42

Re: [PATCH 3/3] tracing: Remove NULL check from current in tracing_generic_entry_update().

2021-01-22 Thread Steven Rostedt
On Wed, 13 Jan 2021 00:00:57 +0100 Sebastian Andrzej Siewior wrote: > I can't imagine when or why `current' would return a NULL pointer. This > check was added in commit > 72829bc3d63cd ("ftrace: move enums to ftrace.h and make helper function > global") > > but it doesn't give me hint

Re: [PATCH v2] lan743x: add virtual PHY for PHY-less devices

2021-01-22 Thread Sergej Bauer
On Saturday, January 23, 2021 12:52:48 AM MSK Florian Fainelli wrote: > On 1/22/2021 1:42 PM, Sergej Bauer wrote: > > From: sba...@blackbox.su > > > > v1->v2: > > switch to using of fixed_phy as was suggested by Andrew and Florian > > also features-related parts are removed > > > >

Re: [PATCH 1/3] tracing: Merge irqflags + preempt counter.

2021-01-22 Thread Steven Rostedt
On Wed, 13 Jan 2021 00:00:55 +0100 Sebastian Andrzej Siewior wrote: > The state of the interrupts (irqflags) and the preemption counter are > both passed down to tracing_generic_entry_update(). Only one bit of > irqflags is actually required: The on/off state. The complete 32bit > of the

Re: [PATCH v2] ACPI/IORT: Do not blindly trust DMA masks from firmware

2021-01-22 Thread Moritz Fischer
On Fri, Jan 22, 2021 at 07:17:59PM +, Robin Murphy wrote: > On 2021-01-22 17:50, Moritz Fischer wrote: > > Hi Robin, > > > > On Fri, Jan 22, 2021 at 02:42:05PM +, Robin Murphy wrote: > > > On 2021-01-22 01:24, Moritz Fischer wrote: > > > > Address issue observed on real world system with

[PATCH v5] proc: Allow pid_revalidate() during LOOKUP_RCU

2021-01-22 Thread Stephen Brennan
The pid_revalidate() function drops from RCU into REF lookup mode. When many threads are resolving paths within /proc in parallel, this can result in heavy spinlock contention on d_lockref as each thread tries to grab a reference to the /proc dentry (and drop it shortly thereafter). Investigation

Re: [PATCH] printk: fix buffer overflow potential for print_text()

2021-01-22 Thread John Ogness
%r1,1,12,0x7900981e >0x79009748: cgij%r8,0,8,0x79009852 >0x7900974e: la %r2,4(%r8) > > crash> sym 0x79009700 > 79009700 (t) iomap_finish_ioend+192 > /usr/src/debug/kernel-5.10.fc33/linux-5.11.0-20210122.rc4.git0.9f29bd8b2e71.300.fc33.s390x/./include/linux/pagemap.

Re: [PATCH v6 00/12] SVM cleanup and INVPCID feature support

2021-01-22 Thread Babu Moger
On 1/21/21 5:51 PM, Babu Moger wrote: > > > On 1/20/21 9:10 PM, Babu Moger wrote: >> >> >> On 1/20/21 3:45 PM, Babu Moger wrote: >>> >>> >>> On 1/20/21 3:14 PM, Jim Mattson wrote: On Tue, Jan 19, 2021 at 3:45 PM Babu Moger wrote: > > > > On 1/19/21 5:01 PM, Jim Mattson

Re: [PATCH net 2/4] net: mvpp2: Remove unneeded Kconfig dependency.

2021-01-22 Thread Jakub Kicinski
On Thu, 21 Jan 2021 07:08:02 -0800 Richard Cochran wrote: > On Thu, Jan 21, 2021 at 10:27:54AM +, Russell King - ARM Linux admin > wrote: > > On Wed, Jan 20, 2021 at 08:06:01PM -0800, Richard Cochran wrote: > > > The mvpp2 is an Ethernet driver, and it implements MAC style time > > >

Re: [PATCH 06/20] clk: sifive: fu540-prci: Declare static const variable 'prci_clk_fu540' where it's used

2021-01-22 Thread Palmer Dabbelt
On Wed, 20 Jan 2021 01:30:26 PST (-0800), lee.jo...@linaro.org wrote: Fixes the following W=1 kernel build warning(s): drivers/clk/sifive/fu540-prci.h:16:35: warning: ‘prci_clk_fu540’ defined but not used [-Wunused-const-variable=] drivers/clk/sifive/fu540-prci.h:16:35: warning:

[PATCH] usbnet: fix the indentation of one code snippet

2021-01-22 Thread Dongliang Mu
Every line of code should start with tab (8 characters) Signed-off-by: Dongliang Mu --- drivers/net/usb/usbnet.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c index 1447da1d5729..305c5f7b9a9b 100644 ---

[PATCH v2 08/10] mm: fold page_lru_base_type() into its sole caller

2021-01-22 Thread Yu Zhao
We've removed all other references to this function. Link: https://lore.kernel.org/linux-mm/20201207220949.830352-9-yuz...@google.com/ Signed-off-by: Yu Zhao Reviewed-by: Alex Shi --- include/linux/mm_inline.h | 27 ++- 1 file changed, 6 insertions(+), 21 deletions(-)

[PATCH v2 07/10] mm: VM_BUG_ON lru page flags

2021-01-22 Thread Yu Zhao
Move scattered VM_BUG_ONs to two essential places that cover all lru list additions and deletions. Link: https://lore.kernel.org/linux-mm/20201207220949.830352-8-yuz...@google.com/ Signed-off-by: Yu Zhao --- include/linux/mm_inline.h | 4 mm/swap.c | 2 -- mm/vmscan.c

[PATCH v2 10/10] mm: make lruvec_lru_size() static

2021-01-22 Thread Yu Zhao
All other references to the function were removed after commit b910718a948a ("mm: vmscan: detect file thrashing at the reclaim root"). Link: https://lore.kernel.org/linux-mm/20201207220949.830352-11-yuz...@google.com/ Signed-off-by: Yu Zhao Reviewed-by: Alex Shi --- include/linux/mmzone.h | 2

[PATCH v3 2/2] mfd: cros_ec: Add peripheral device charger

2021-01-22 Thread Daisuke Nojiri
This patch adds a cell entry for PCHG (Peripheral CHarGer). PCHG is a framework managing power supplies for peripheral devices. Signed-off-by: Daisuke Nojiri Acked-for-MFD-by: Lee Jones --- v1->v2 * None v2->v3 * None --- drivers/mfd/cros_ec_dev.c | 1 + 1 file changed, 1 insertion(+) diff

[PATCH v2 09/10] mm: fold __update_lru_size() into its sole caller

2021-01-22 Thread Yu Zhao
All other references to the function were removed after commit a892cb6b977f ("mm/vmscan.c: use update_lru_size() in update_lru_sizes()"). Link: https://lore.kernel.org/linux-mm/20201207220949.830352-10-yuz...@google.com/ Signed-off-by: Yu Zhao Reviewed-by: Alex Shi ---

[PATCH v2 05/10] mm: don't pass "enum lru_list" to del_page_from_lru_list()

2021-01-22 Thread Yu Zhao
The parameter is redundant in the sense that it can be potentially extracted from the "struct page" parameter by page_lru(). We need to make sure that existing PageActive() or PageUnevictable() remains until the function returns. A few places don't conform, and simple reordering fixes them. This

  1   2   3   4   5   6   7   8   9   10   >