[PATCH v2 3/7] pps: clients: gpio: Remove redundant condition in ->remove()

2021-03-18 Thread Andy Shevchenko
The timer along with GPIO API are NULL-aware, there is no need to test against existing GPIO echo line. Signed-off-by: Andy Shevchenko Acked-by: Rodolfo Giometti --- drivers/pps/clients/pps-gpio.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git

[PATCH v2 7/7] pps: clients: gpio: Rearrange optional stuff in pps_gpio_setup()

2021-03-18 Thread Andy Shevchenko
Rearrange optional stuff in pps_gpio_setup() so it will go after mandatory one and with reduced indentation. This will increase readability of the sources. Signed-off-by: Andy Shevchenko Acked-by: Rodolfo Giometti --- drivers/pps/clients/pps-gpio.c | 33 ++--- 1

[PATCH v2 1/7] pps: clients: gpio: Bail out on error when requesting GPIO echo line

2021-03-18 Thread Andy Shevchenko
When requesting optional GPIO echo line, bail out on error, so user will know that something wrong with the existing property. Signed-off-by: Andy Shevchenko Acked-by: Rodolfo Giometti --- drivers/pps/clients/pps-gpio.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff

[PATCH v2 4/7] pps: clients: gpio: Get rid of legacy platform data

2021-03-18 Thread Andy Shevchenko
Platform data is a legacy interface to supply device properties to the driver. In this case we even don't have in-kernel users for it. Just remove it for good. Signed-off-by: Andy Shevchenko Acked-by: Rodolfo Giometti --- drivers/pps/clients/pps-gpio.c | 17 +++--

[PATCH v2 2/7] pps: clients: gpio: Use dev_err_probe() to avoid log noise

2021-03-18 Thread Andy Shevchenko
When GPIO APIs return -EPROBE_DEFER there is no need to print the message, especially taking into consideration that it may repeat several times. Use dev_err_probe() to avoid log noise in such cases. Signed-off-by: Andy Shevchenko Acked-by: Rodolfo Giometti --- drivers/pps/clients/pps-gpio.c |

[PATCH v2 6/7] pps: clients: gpio: Use struct device pointer directly

2021-03-18 Thread Andy Shevchenko
In most parts of the code the platform device is not used. Use struct device pointer directly to reduce code size and increase readability. Signed-off-by: Andy Shevchenko Acked-by: Rodolfo Giometti --- drivers/pps/clients/pps-gpio.c | 42 +++--- 1 file changed, 19

[PATCH v2 5/7] pps: clients: gpio: Make use of device properties

2021-03-18 Thread Andy Shevchenko
Device property API allows to gather device resources from different sources, such as ACPI. Convert the drivers to unleash the power of device property API. Signed-off-by: Andy Shevchenko Acked-by: Rodolfo Giometti --- drivers/pps/clients/pps-gpio.c | 17 +++-- 1 file changed, 7

Re: [PATCH] fs: Improve eventpoll logging to stop indicting timerfd

2021-03-18 Thread Thomas Gleixner
Manish, On Mon, Mar 01 2021 at 19:49, Manish Varma wrote: > All together, that will give us names like the following: > > 1) timerfd file descriptor: [timerfd14:system_server] > 2) eventpoll top-level per-process wakesource: epoll:system_server > 3) eventpoll-on-timerfd per-descriptor

Re: [PATCH 4/5] ARM: dts: stm32: enable the analog filter for all I2C nodes in stm32mp151

2021-03-18 Thread Alexandre TORGUE
Hi Wolfram On 3/18/21 11:55 AM, Wolfram Sang wrote: On Fri, Feb 05, 2021 at 09:51:43AM +0100, Alain Volmat wrote: Enable the analog filter for all I2C nodes of the stm32mp151. Signed-off-by: Alain Volmat I usually don't take DTS patches, but they can go in now via arm-soc as I applied the

Re: [PATCH 2/2] arm64: stacktrace: Add skip when task == current

2021-03-18 Thread chenjun (AM)
在 2021/3/18 11:31, chenjun (AM) 写道: > 在 2021/3/18 3:34, Mark Rutland 写道: >> On Wed, Mar 17, 2021 at 06:36:36PM +, Catalin Marinas wrote: >>> On Wed, Mar 17, 2021 at 02:20:50PM +, Chen Jun wrote: On ARM64, cat /sys/kernel/debug/page_owner, all pages return the same stack:

Re: [PATCH 4/7] regulator: mediatek: Add regulators_node to description

2021-03-18 Thread Mark Brown
On Fri, Mar 12, 2021 at 03:55:42PM +0100, matthias@kernel.org wrote: > From: Matthias Brugger > > Define the regulator node under which the regulators are described. Acked-by: Mark Brown signature.asc Description: PGP signature

[PATCH] driver/media/i2c:fix unneeded semicolon

2021-03-18 Thread ChunyouTang
From: tangchunyou delete unneeded semicolon Signed-off-by: tangchunyou --- drivers/media/i2c/ov02a10.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/i2c/ov02a10.c b/drivers/media/i2c/ov02a10.c index 60b4bc6..c47b1d4 100644 --- a/drivers/media/i2c/ov02a10.c

[PATCH] nfc/fdp: Simplify the return expression of fdp_nci_open()

2021-03-18 Thread zuoqilin1
From: zuoqilin Simplify the return expression. Signed-off-by: zuoqilin --- drivers/nfc/fdp/fdp.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/nfc/fdp/fdp.c b/drivers/nfc/fdp/fdp.c index 4dc7bd7..824f2da 100644 --- a/drivers/nfc/fdp/fdp.c +++

Re: [PATCH v1 2/2] ASoC: amd: fix multiple definition error

2021-03-18 Thread Mukunda,Vijendar
On 18/03/21 6:32 pm, Mark Brown wrote: On Thu, Mar 18, 2021 at 02:03:47AM +0530, Vijendar Mukunda wrote: make W=1 ARCH=x86_64 error: acp3x-rt5682-max9836.c:(.text+0x840): multiple definition of `soc_is_rltk_max'; sound/soc/amd/acp-da7219-max98357a.o:acp-da7219-max98357a.c:

[PATCH -next] phy: sparx5_serdes: Fix return value check in sparx5_serdes_probe()

2021-03-18 Thread 'w00385741
From: Wei Yongjun In case of error, the function devm_ioremap() returns NULL pointer not ERR_PTR(). The IS_ERR() test in the return value check should be replaced with NULL test. Fixes: 2ff8a1eeb5aa ("phy: Add Sparx5 ethernet serdes PHY driver") Reported-by: Hulk Robot Signed-off-by: Wei

[PATCH] fs/dcache: fix typos and sentence disorder

2021-03-18 Thread Xiaofeng Cao
change 'sould' to 'should' change 'colocated' to 'collocated' change 'talke' to 'take' reorganize sentence Signed-off-by: Xiaofeng Cao --- fs/dcache.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/fs/dcache.c b/fs/dcache.c index 7d24ff7eb206..99a58676f478 100644

Re: [syzbot] WARNING in __percpu_ref_exit (2)

2021-03-18 Thread Pavel Begunkov
On 18/03/2021 08:33, Hillf Danton wrote: > On Mon, 15 Mar 2021 12:18:20 + Pavel Begunkov wrote: >> On 15/03/2021 11:58, syzbot wrote: >>> Hello, >>> >>> syzbot found the following issue on: >>> >>> HEAD commit:75013c6c Merge tag 'perf_urgent_for_v5.12-rc3' of git://gi.. >>> git tree:

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

2021-03-18 Thread Amey Narkhede
On 21/03/17 09:13PM, Pali Rohár wrote: > On Wednesday 17 March 2021 14:00:20 Alex Williamson wrote: > > On Wed, 17 Mar 2021 20:40:24 +0100 > > Pali Rohár wrote: > > > > > On Wednesday 17 March 2021 13:32:45 Alex Williamson wrote: > > > > On Wed, 17 Mar 2021 20:24:24 +0100 > > > > Pali Rohár

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

2021-03-18 Thread Leon Romanovsky
On Thu, Mar 18, 2021 at 07:52:52PM +0530, Amey Narkhede wrote: > On 21/03/18 11:09AM, Leon Romanovsky wrote: > > On Wed, Mar 17, 2021 at 11:31:40AM -0600, Alex Williamson wrote: > > > On Wed, 17 Mar 2021 15:58:40 +0200 > > > Leon Romanovsky wrote: > > > > > > > On Wed, Mar 17, 2021 at 06:47:18PM

Re: [PATCH v5 3/3] arm64: dts: ti: k3-j7200: Add support for higher speed modes and update delay select values for MMCSD subsystems

2021-03-18 Thread Kishon Vijay Abraham I
Hi, On 10/03/21 9:49 pm, Aswath Govindraju wrote: > The following speed modes are now supported in J7200 SoC, > - HS200 and HS400 modes at 1.8 V card voltage, in MMCSD0 subsystem [1]. > - UHS-I speed modes in MMCSD1 subsystem [1]. > > Add support for UHS-I modes by adding voltage regulator

Re: [PATCH v4 4/5] mm: memcontrol: use obj_cgroup APIs to charge kmem pages

2021-03-18 Thread Johannes Weiner
On Thu, Mar 18, 2021 at 07:06:57PM +0800, Muchun Song wrote: > Since Roman series "The new cgroup slab memory controller" applied. All > slab objects are charged via the new APIs of obj_cgroup. The new APIs > introduce a struct obj_cgroup to charge slab objects. It prevents > long-living objects

Re: [PATCH 1/1] ACPI: fix acpi table use after free

2021-03-18 Thread Rafael J. Wysocki
On Thu, Mar 18, 2021 at 11:50 AM Rafael J. Wysocki wrote: > > On Thu, Mar 18, 2021 at 8:25 AM Mike Rapoport wrote: > > > > On Wed, Mar 17, 2021 at 09:14:37PM +0100, Rafael J. Wysocki wrote: > > > On Monday, March 15, 2021 5:19:29 PM CET Rafael J. Wysocki wrote: > > > > On Sun, Mar 14, 2021 at

Re: [PATCH v1] memory: tegra20: Add debug statistics

2021-03-18 Thread Krzysztof Kozlowski
On 18/03/2021 12:55, Dmitry Osipenko wrote: > Add debug statistics collection support. The statistics is available > via debugfs in '/sys/kernel/debug/mc/stats', it shows percent of memory > controller utilization for each memory client. This information is > intended to help with debugging of

Re: [syzbot] BUG: unable to handle kernel access to user memory in sock_ioctl

2021-03-18 Thread Ben Dooks
On 18/03/2021 15:18, Dmitry Vyukov wrote: On Mon, Mar 15, 2021 at 3:41 PM Ben Dooks wrote: On 15/03/2021 11:52, Dmitry Vyukov wrote: On Mon, Mar 15, 2021 at 12:30 PM Ben Dooks wrote: On 14/03/2021 11:03, Dmitry Vyukov wrote: On Sun, Mar 14, 2021 at 11:01 AM Dmitry Vyukov wrote: On Wed,

Re: [PATCH] fs/exec: fix typos and sentence disorder

2021-03-18 Thread Christian Brauner
On Thu, Mar 18, 2021 at 11:31:45PM +0800, Xiaofeng Cao wrote: > change 'backwords' to 'backwards' > change 'and argument' to 'an argument' > change 'visibile' to 'visible' > change 'wont't' to 'won't' > reorganize sentence > > Signed-off-by: Xiaofeng Cao > --- Reviewed-by: Christian Brauner

Re: [PATCH v2 1/2] kvm/kvm_util: add _vm_ioctl

2021-03-18 Thread Paolo Bonzini
On 18/03/21 16:16, Emanuele Giuseppe Esposito wrote: As in kvm_ioctl and _kvm_ioctl, add the respective _vm_ioctl for vm_ioctl. _vm_ioctl invokes an ioctl using the vm fd, leaving the caller to test the result. Slightly better subject: "selftests/kvm: add _vm_ioctl". Queued both, but next

Re: [PATCH v3 1/2] crypto: qat - dont release uninitialized resources

2021-03-18 Thread Giovanni Cabiddu
On Thu, Mar 18, 2021 at 03:53:03PM +, Giovanni Cabiddu wrote: > On Fri, Mar 12, 2021 at 11:22:02AM -0500, Tong Zhang wrote: > > adf_vf_isr_resource_alloc() is not unwinding correctly when error > > happens and it trys to release uninitialized resources. Typo: perhaps

Re: [PATCH v4 1/3] bus: mhi: core: Introduce internal register poll helper function

2021-03-18 Thread Jeffrey Hugo
On 3/17/2021 3:26 PM, Bhaumik Bhatt wrote: On 2021-03-11 11:59 AM, Jeffrey Hugo wrote: On 3/11/2021 1:00 AM, Loic Poulain wrote: Hi Bhaumik, On Thu, 11 Mar 2021 at 00:31, Bhaumik Bhatt wrote: Introduce helper function to allow MHI core driver to poll for a value in a register field. This

Re: [PATCH net-next v2 2/4] net: ipa: use upper_32_bits()

2021-03-18 Thread Alex Elder
On 3/18/21 11:03 AM, Florian Fainelli wrote: On 3/18/2021 6:51 AM, Alex Elder wrote: Use upper_32_bits() to extract the high-order 32 bits of a DMA address. This avoids doing a 32-position shift on a DMA address if it happens not to be 64 bits wide. Suggested-by: Florian Fainelli

Re: [PATCH v1 2/2] ASoC: amd: fix multiple definition error

2021-03-18 Thread Mark Brown
On Thu, Mar 18, 2021 at 02:03:47AM +0530, Vijendar Mukunda wrote: > make W=1 ARCH=x86_64 error: > acp3x-rt5682-max9836.c:(.text+0x840): multiple definition of > `soc_is_rltk_max'; > sound/soc/amd/acp-da7219-max98357a.o:acp-da7219-max98357a.c: > (.text+0xd00):first defined here In general you

Re: [PATCH v2 1/3] perf test: Remove unused argument

2021-03-18 Thread Jiri Olsa
On Tue, Mar 16, 2021 at 05:55:03PM -0700, Ian Rogers wrote: > Remove unused argument from daemon_exit. > > Signed-off-by: Ian Rogers for the patchset Acked-by: Jiri Olsa thanks, jirka > --- > tools/perf/tests/shell/daemon.sh | 15 +++ > 1 file changed, 7 insertions(+), 8

Re: [PATCH 08/10] of: of_net: Provide function name and param description

2021-03-18 Thread Andrew Lunn
On Thu, Mar 18, 2021 at 10:40:34AM +, Lee Jones wrote: > Fixes the following W=1 kernel build warning(s): > > drivers/of/of_net.c:104: warning: Function parameter or member 'np' not > described in 'of_get_mac_address' > drivers/of/of_net.c:104: warning: expecting prototype for mac().

[PATCH] cifsd: fix a precedence bug in parse_dacl()

2021-03-18 Thread Dan Carpenter
The shift has higher precedence than mask so this doesn't work as intended. Fixes: ef24dca82789 ("cifsd: add support for ACLs") Signed-off-by: Dan Carpenter --- fs/cifsd/smbacl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/cifsd/smbacl.c b/fs/cifsd/smbacl.c index

RE: [PATCH RESEND] gcc-plugins: avoid errors with -std=gnu++11 on old gcc

2021-03-18 Thread David Laight
From: Valdis Kletnieks > Sent: 18 March 2021 11:56 > > On Thu, 18 Mar 2021 11:41:29 -, David Laight said: > > > That gcc bug just implies you need a space after "xxx". > > That is easily fixable in the sources. > > It's not quite that simple. > >In file included from >

[PATCH v2 2/2] i2c: stm32f7: add SMBus-Alert support

2021-03-18 Thread Alain Volmat
Add support for the SMBus-Alert protocol to the STM32F7 that has dedicated control and status logic. If SMBus-Alert is used, the SMBALERT# pin must be configured as alternate function for I2C Alert. Signed-off-by: Alain Volmat --- v2: - rely on st,smbus-alert binding instead of smbus ---

[PATCH v2 1/2] dt-bindings: i2c: stm32f7: add st,smbus-alert binding for SMBus Alert

2021-03-18 Thread Alain Volmat
Based on the SMBus specification, SMBus Alert active state is low. As often on SoC, the SMBus Alert pin is not only dedicated to this feature and can also be used for another purpose (by configuring it as alternate function for other functions via pinctrl). "smbus" dt-binding has been introduced

[PATCH v2 0/2] i2c: stm32f7: add SMBus-Alert support

2021-03-18 Thread Alain Volmat
This serie adds support for SMBus Alert on the STM32F7. A new binding st,smbus-alert is added in order to differenciate with the existing smbus binding. SMBA alert control and status logic must be enabled along with SMBALERT# pin configured via pinctrl in the device tree. This is the rational for

[PATCH 2/3] virtiofs: split requests that exceed virtqueue size

2021-03-18 Thread Connor Kuehl
If an incoming FUSE request can't fit on the virtqueue, the request is placed onto a workqueue so a worker can try to resubmit it later where there will (hopefully) be space for it next time. This is fine for requests that aren't larger than a virtqueue's maximum capacity. However, if a request's

[PATCH 0/3] virtiofs: split requests that exceed virtqueue size

2021-03-18 Thread Connor Kuehl
I also have a patch in this series that fixes a typo I saw while I was in there. For testing, I have been using a toy program that performs a readv or a writev with a large number of iovecs that exceeds the number of descriptors available to the virtqueue and observing the number of scattergather

[PATCH 3/3] fuse: fix typo for fuse_conn.max_pages comment

2021-03-18 Thread Connor Kuehl
'Maxmum' -> 'Maximum' Signed-off-by: Connor Kuehl --- fs/fuse/fuse_i.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/fuse/fuse_i.h b/fs/fuse/fuse_i.h index f0e4ee906464..8bdee79ba593 100644 --- a/fs/fuse/fuse_i.h +++ b/fs/fuse/fuse_i.h @@ -552,7 +552,7 @@ struct

[PATCH 1/3] virtio_ring: always warn when descriptor chain exceeds queue size

2021-03-18 Thread Connor Kuehl
>From section 2.6.5.3.1 (Driver Requirements: Indirect Descriptors) of the virtio spec: "A driver MUST NOT create a descriptor chain longer than the Queue Size of the device." This text suggests that the warning should trigger even if indirect descriptors are in use. Reported-by: Stefan

Re: [PATCH v3] ASoC: Intel: Skylake: skl-topology: fix -frame-larger-than

2021-03-18 Thread Mark Brown
On Sun, Mar 14, 2021 at 06:39:08PM -0700, Nick Desaulniers wrote: > Fixes: > sound/soc/intel/skylake/skl-topology.c:3613:13: warning: stack frame > size of 1304 bytes in function 'skl_tplg_complete' > [-Wframe-larger-than=] Changelogs like this look like Fixes: tags and confuse tools which

Re: [PATCH v2 3/4] fs: unicode: Use strscpy() instead of strncpy()

2021-03-18 Thread Shreeya Patel
On 18/03/21 7:03 pm, Shreeya Patel wrote: Following warning was reported by Kernel Test Robot. In function 'utf8_parse_version', inlined from 'utf8_load' at fs/unicode/utf8mod.c:195:7: fs/unicode/utf8mod.c:175:2: warning: 'strncpy' specified bound 12 equals destination size

Re: [PATCH][next] soc: xilinx: vcu: remove deadcode on null divider check

2021-03-18 Thread Michael Tretter
On Thu, 18 Mar 2021 12:48:06 +, Colin Ian King wrote: > On 11/02/2021 19:05, Stephen Boyd wrote: > > Quoting Michael Tretter (2021-02-10 23:39:06) > >> On Wed, 10 Feb 2021 19:28:18 -0800, Stephen Boyd wrote: > >>> Quoting Colin King (2021-02-10 10:49:38) > From: Colin Ian King > >

Re: seccomp: Delay filter activation

2021-03-18 Thread Christian Brauner
Sorry, I just found that mail. On Mon, Mar 01, 2021 at 03:44:06PM -0800, Kees Cook wrote: > On Mon, Mar 01, 2021 at 02:21:56PM +0100, Christian Brauner wrote: > > On Mon, Mar 01, 2021 at 12:09:09PM +0100, Christian Brauner wrote: > > > On Sat, Feb 20, 2021 at 01:31:57AM -0800, Sargun Dhillon

Re: [PATCH v1] usb: typec: tcpm: PD3.0 sinks can send Discover Identity even in device mode

2021-03-18 Thread Guenter Roeck
On 3/17/21 11:56 PM, Badhri Jagan Sridharan wrote: >>From 6.4.4.2 Structured VDM: > • Either Port May be an Initiator of Structured VDMs except for the Enter > Mode and Exit Mode Commands which Shall only be initiated by the DFP." > > The above implies that when PD3.0 link is established PD3.0

Re: [PATCH 1/2] media: v4l2-core: ignore native time32 ioctls on 64-bit

2021-03-18 Thread Laurent Pinchart
Hi Arnd, Thank you for the patch. On Thu, Mar 18, 2021 at 02:43:18PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > Syzbot found that passing ioctl command 0xc0505609 into a 64-bit > kernel from a 32-bit process causes uninitialized kernel memory to > get passed to drivers instead of

[PATCH 1/2] USB: core: drop outdated interface-binding comment

2021-03-18 Thread Johan Hovold
It's been almost twenty years since USB drivers returned a data pointer from their probe routines in order to bind to an interface. Time to update the documentation for usb_driver_claim_interface(). Signed-off-by: Johan Hovold --- drivers/usb/core/driver.c | 4 1 file changed, 4

Re: [syzbot] BUG: unable to handle kernel access to user memory in sock_ioctl

2021-03-18 Thread Dmitry Vyukov
On Thu, Mar 18, 2021 at 4:35 PM Ben Dooks wrote: > > On 18/03/2021 15:18, Dmitry Vyukov wrote: > > On Mon, Mar 15, 2021 at 3:41 PM Ben Dooks wrote: > >> > >> On 15/03/2021 11:52, Dmitry Vyukov wrote: > >>> On Mon, Mar 15, 2021 at 12:30 PM Ben Dooks > >>> wrote: > > On 14/03/2021

[PATCH 2/2] USB: core: rename usb_driver_claim_interface() data parameter

2021-03-18 Thread Johan Hovold
It's been almost twenty years since the interface "private data" pointer was removed in favour of using the driver-data pointer of struct device. Let's rename the driver-data parameter of usb_driver_claim_interface() so that it better reflects how it's used. Signed-off-by: Johan Hovold ---

Re: [PATCH v10 0/3] Charge loop device i/o to issuing cgroup

2021-03-18 Thread Shakeel Butt
On Wed, Mar 17, 2021 at 3:30 PM Jens Axboe wrote: > > On 3/16/21 9:36 AM, Dan Schatzberg wrote: > > No major changes, just rebasing and resubmitting > > Applied for 5.13, thanks. > I have requested a couple of changes in the patch series. Can this applied series still be changed or new patches

Re: [PATCH net V2 1/1] net: phy: fix invalid phy id when probe using C22

2021-03-18 Thread Florian Fainelli
On 3/18/2021 6:25 AM, Heiner Kallweit wrote: > On 18.03.2021 10:09, Wong Vee Khee wrote: >> When using Clause-22 to probe for PHY devices such as the Marvell >> 88E2110, PHY ID with value 0 is read from the MII PHYID registers >> which caused the PHY framework failed to attach the Marvell PHY

[PATCH net-next] net: cdc_ncm: drop redundant driver-data assignment

2021-03-18 Thread Johan Hovold
The driver data for the data interface has already been set by usb_driver_claim_interface() so drop the subsequent redundant assignment. Note that this also avoids setting the driver data three times in case of a combined interface. Signed-off-by: Johan Hovold --- drivers/net/usb/cdc_ncm.c | 1

Re: [PATCH] mm/page_alloc: try oom if reclaim is unable to make forward progress

2021-03-18 Thread Michal Hocko
On Mon 15-03-21 16:58:37, Aaron Tomlin wrote: > In the situation where direct reclaim is required to make progress for > compaction but no_progress_loops is already over the limit of > MAX_RECLAIM_RETRIES consider invoking the oom killer. What is the problem you are trying to fix? > >

RE: [PATCH v2] scsi: ufs: Tidy up WB configuration code

2021-03-18 Thread Avri Altman
> > -int ufshcd_wb_ctrl(struct ufs_hba *hba, bool enable) > +static int __ufshcd_wb_toggle(struct ufs_hba *hba, bool set, enum flag_idn > idn) > { > - int ret; > u8 index; > enum query_opcode opcode; What I meant is: enum query_opcode opcode = set ?

Re: A potential data race in drivers/iio/adc/berlin2-adc.ko

2021-03-18 Thread Lars-Peter Clausen
On 3/18/21 9:27 AM, Lars-Peter Clausen wrote: On 3/18/21 9:07 AM, Pavel Andrianov wrote: Hi, berlin2_adc_probe [1] registers two interrupt handlers: berlin2_adc_irq [2] and berlin2_adc_tsen_irq [3]. The interrupt handlers operate with the same data, for example, modify priv->data with

Re: [PATCH] objtool,static_call: Don't emit static_call_site for .exit.text

2021-03-18 Thread Peter Zijlstra
On Thu, Mar 18, 2021 at 09:30:18AM +0100, Peter Zijlstra wrote: > On Thu, Mar 18, 2021 at 08:59:45AM +0100, Peter Zijlstra wrote: > > On Wed, Mar 17, 2021 at 07:02:12PM -0500, Josh Poimboeuf wrote: > > > On Wed, Mar 17, 2021 at 01:45:57PM +0100, Peter Zijlstra wrote: > > > > arguably it simply

Re: EDAC list as Trojan Horse distribution ??

2021-03-18 Thread Enrico Weigelt, metux IT consult
On 16.03.21 20:51, Luck, Tony wrote: Nothing new - just the next spammer attempt. But this was a new class of Spam. So far i got only mass mailing... This was personalized based on my previous e-Mail (did not include this part in my mail) Somewhat new - combining trawling of public mailing

Re: [PATCH v6 16/17] media: uvcvideo: Return -EACCES to inactive controls

2021-03-18 Thread Hans Verkuil
On 18/03/2021 08:39, Hans Verkuil wrote: > Hi Ricardo, > > On 17/03/2021 17:45, Ricardo Ribalda wrote: >> If a control is inactive return -EACCES to let the userspace know that >> the value will not be applied automatically when the control is active >> again. Note that this needs to be

Re: [PATCH v2 1/2] dt-bindings: interconnect: Add Qualcomm SM8350 DT bindings

2021-03-18 Thread Vinod Koul
Hello Georgi, On 18-03-21, 09:08, Georgi Djakov wrote: > Hi Vinod, > > +#define MASTER_GEM_NOC_CNOC1 > > Maybe start from zero? Yeah not sure how that got missed > > +#define MASTER_CAMNOC_HF 0 > > +#define MASTER_CAMNOC_ICP 2 > > Why jump from 0 to 2?

Re: [Linux-stm32] [PATCH v9 22/33] counter: Internalize sysfs interface code

2021-03-18 Thread Fabrice Gasnier
On 3/14/21 10:08 AM, William Breathitt Gray wrote: > On Sun, Mar 14, 2021 at 04:56:44PM +0900, William Breathitt Gray wrote: >> On Fri, Mar 12, 2021 at 04:02:42PM +0100, Fabrice Gasnier wrote: >>> On 3/9/21 2:19 PM, William Breathitt Gray wrote: +static ssize_t enums_available_show(const u32

Re: [PATCH v5 4/5] mm: Make alloc_contig_range handle in-use hugetlb pages

2021-03-18 Thread Michal Hocko
On Thu 18-03-21 09:54:01, Oscar Salvador wrote: [...] > @@ -2287,10 +2288,12 @@ static int alloc_and_dissolve_huge_page(struct hstate > *h, struct page *old_page) > goto unlock; > } else if (page_count(old_page)) { > /* > - * Someone has grabbed the

Re: [PATCH 07/11] PM / devfreq: check get_dev_status before start monitor

2021-03-18 Thread Chanwoo Choi
On 3/18/21 6:54 PM, Chanwoo Choi wrote: > On 3/18/21 5:03 PM, Dong Aisheng wrote: >> Hi Chanwoo, >> >> On Sat, Mar 13, 2021 at 2:45 PM Dong Aisheng wrote: >>> >>> On Sat, Mar 13, 2021 at 12:09 AM Chanwoo Choi wrote: On 21. 3. 12. 오후 7:57, Dong Aisheng wrote: > On Thu, Mar 11, 2021

Re: [PATCH v5 2/5] mm,compaction: Let isolate_migratepages_{range,block} return error codes

2021-03-18 Thread Vlastimil Babka
On 3/17/21 3:59 PM, Michal Hocko wrote: > On Wed 17-03-21 15:38:35, Oscar Salvador wrote: >> On Wed, Mar 17, 2021 at 03:12:29PM +0100, Michal Hocko wrote: >> > > Since isolate_migratepages_block will stop returning the next pfn to be >> > > scanned, we reuse the cc->migrate_pfn field to keep track

Re: [syzbot] BUG: unable to handle kernel access to user memory in schedule_tail

2021-03-18 Thread Dmitry Vyukov
On Thu, Mar 18, 2021 at 10:41 AM Ben Dooks wrote: > > On 12/03/2021 17:38, Dmitry Vyukov wrote: > > On Fri, Mar 12, 2021 at 6:34 PM Dmitry Vyukov wrote: > >> > >> On Fri, Mar 12, 2021 at 5:36 PM Ben Dooks > >> wrote: > >>> > >>> On 12/03/2021 16:34, Ben Dooks wrote: > On 12/03/2021 16:30,

Re: [PATCH v2 2/4] leds: simatic-ipc-leds: add new driver for Siemens Industial PCs

2021-03-18 Thread Enrico Weigelt, metux IT consult
On 15.03.21 11:48, Andy Shevchenko wrote: Hi, I have a question, why we can't provide a GPIO driver which is already in the kernel and, with use of the patch series I sent, to convert this all magic to GPIO LEDs as it's done for all normal cases? Do we alread have a generic led driver that

Re: [PATCH v4 1/6] soc/tegra: Add devm_tegra_core_dev_init_opp_table()

2021-03-18 Thread Dmitry Osipenko
14.03.2021 19:48, Dmitry Osipenko пишет: > Add common helper which initializes OPP table for Tegra SoC core devices. > > Tested-by: Peter Geis # Ouya T30 > Tested-by: Paul Fertser # PAZ00 T20 > Tested-by: Nicolas Chauvet # PAZ00 T20 and TK1 T124 > Tested-by: Matt Merhar # Ouya T30 >

[PATCH] HID: ft260: fix an error message in ft260_i2c_write_read()

2021-03-18 Thread Dan Carpenter
The "len" variable is uninitialize. Fixes: 6a82582d9fa4 ("HID: ft260: add usb hid to i2c host bridge driver") Signed-off-by: Dan Carpenter --- drivers/hid/hid-ft260.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/hid/hid-ft260.c b/drivers/hid/hid-ft260.c index

[PATCH] drm: Few typo fixes

2021-03-18 Thread Bhaskar Chowdhury
s/instatiated/instantiated/ s/unreference/unreferenced/ Signed-off-by: Bhaskar Chowdhury --- drivers/gpu/drm/drm_property.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_property.c b/drivers/gpu/drm/drm_property.c index 6ee04803c362..27c824a6eb60

[PATCH V2 0/2] Separate out earlycon

2021-03-18 Thread Roja Rani Yarubandi
Dropped below patch as it is not required: [3/3] Serial: Separate out earlycon support Roja Rani Yarubandi (2): soc: qcom-geni-se: Cleanup the code to remove proxy votes arm64: dts: qcom: sc7180: Remove QUP-CORE ICC path arch/arm64/boot/dts/qcom/sc7180.dtsi | 4 --

[PATCH V2 1/2] soc: qcom-geni-se: Cleanup the code to remove proxy votes

2021-03-18 Thread Roja Rani Yarubandi
ICC core and platforms drivers supports sync_state feature, which ensures that the default ICC BW votes from the bootloader is not removed until all it's consumers are probes. The proxy votes were needed in case other QUP child drivers I2C, SPI probes before UART, they can turn off the QUP-CORE

[PATCH V2 2/2] arm64: dts: qcom: sc7180: Remove QUP-CORE ICC path

2021-03-18 Thread Roja Rani Yarubandi
We had introduced the QUP-CORE ICC path to put proxy votes from QUP wrapper on behalf of earlycon, if other users of QUP-CORE turn off this clock before the real console is probed, unclocked access to HW was seen from earlycon. With ICC sync state support proxy votes are no longer need as ICC

[PATCH] security/smack: fix misspellings using codespell tool

2021-03-18 Thread menglong8 . dong
From: Xiong Zhenwu A typo is found out by codespell tool in 116th line of smackfs.c: $ codespell ./security/smack ./smackfs.c:116: lables ==> labels Fix a typo found by codespell. Signed-off-by: Xiong Zhenwu --- security/smack/smackfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH v5 2/5] mm,compaction: Let isolate_migratepages_{range,block} return error codes

2021-03-18 Thread Vlastimil Babka
On 3/18/21 11:22 AM, Michal Hocko wrote: > On Thu 18-03-21 10:50:38, Vlastimil Babka wrote: >> On 3/17/21 3:59 PM, Michal Hocko wrote: >> > On Wed 17-03-21 15:38:35, Oscar Salvador wrote: >> >> On Wed, Mar 17, 2021 at 03:12:29PM +0100, Michal Hocko wrote: >> >> > > Since isolate_migratepages_block

Re: [PATCH v4 resend 00/13] MFD/extcon/ASoC: Rework arizona codec jack-detect support

2021-03-18 Thread Hans de Goede
Hi Lee, On 3/7/21 4:17 PM, Hans de Goede wrote: > Hi All, > > Here is v4 of my series to rework the arizona codec jack-detect support > to use the snd_soc_jack helpers instead of direct extcon reporting. > > As discussed before here is a resend rebased on 5.12-rc2, making sure that > all

Re: [PATCH v4 1/5] mm,memory_hotplug: Allocate memmap from the added memory range

2021-03-18 Thread David Hildenbrand
On 18.03.21 11:38, Oscar Salvador wrote: On Thu, Mar 18, 2021 at 09:27:48AM +0100, Oscar Salvador wrote: If we check for IS_ALIGNED(nr_vmemmap_pages, PMD_SIZE), please add a proper TODO comment that this is most probably the wrong place to take care of this. Sure, I will stuff the check in

Re: [PATCH -next] x86: Fix unused variable 'hi'

2021-03-18 Thread Ingo Molnar
* Xu Yihang wrote: > Fixes the following W=1 kernel build warning(s): > arch/x86/hyperv/hv_apic.c:58:15: warning: variable ‘hi’ set but not used > [-Wunused-but-set-variable] > > Reported-by: Hulk Robot > Signed-off-by: Xu Yihang > --- > arch/x86/hyperv/hv_apic.c | 3 ++- > 1 file

Re: [PATCH v5 2/5] mm,compaction: Let isolate_migratepages_{range,block} return error codes

2021-03-18 Thread Michal Hocko
On Thu 18-03-21 12:10:14, Vlastimil Babka wrote: > On 3/18/21 11:22 AM, Michal Hocko wrote: [...] > > E.g. something like the following > > diff --git a/mm/internal.h b/mm/internal.h > > index 1432feec62df..6c5a9066adf0 100644 > > --- a/mm/internal.h > > +++ b/mm/internal.h > > @@ -225,7 +225,13

Re: [PATCH RESEND] gcc-plugins: avoid errors with -std=gnu++11 on old gcc

2021-03-18 Thread Valdis Klētnieks
On Thu, 18 Mar 2021 18:07:28 +0900, Masahiro Yamada said: > We can require GCC 6+ for building GCC plugins. > + depends on CC_IS_GCC && GCC_VERSION >= 6 I'd be OK with that personally, but the question is whether any gcc 4.9 or 5.x users are using plugins. That's a bit above my pay

[PATCH] security: fix misspellings using codespell tool

2021-03-18 Thread menglong8 . dong
From: Xiong Zhenwu A typo is found out by codespell tool: $ codespell ./security ./security/commoncap.c:1135: capabilties ==> capabilities Fix a typo found by codespell. Signed-off-by: Xiong Zhenwu --- security/commoncap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH 4.19 000/120] 4.19.181-rc1 review

2021-03-18 Thread Samuel Zou
On 2021/3/15 21:55, gre...@linuxfoundation.org wrote: From: Greg Kroah-Hartman This is the start of the stable review cycle for the 4.19.181 release. There are 120 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied,

Re: [PATCH 4.14 00/95] 4.14.226-rc1 review

2021-03-18 Thread Samuel Zou
On 2021/3/15 21:56, gre...@linuxfoundation.org wrote: From: Greg Kroah-Hartman This is the start of the stable review cycle for the 4.14.226 release. There are 95 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please

[PATCH 07/10] crypto: caam: caampkc: Provide the name of the function and provide missing descriptions

2021-03-18 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/crypto/caam/caampkc.c:199: warning: expecting prototype for from a given scatterlist(). Prototype was for caam_rsa_count_leading_zeros() instead drivers/crypto/caam/caamalg_qi2.c:87: warning: Function parameter or member

[PATCH 08/10] crypto: vmx: Source headers are not good kernel-doc candidates

2021-03-18 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/crypto/vmx/vmx.c:23: warning: expecting prototype for Routines supporting VMX instructions on the Power 8(). Prototype was for p8_init() instead Cc: "Breno Leitão" Cc: Nayna Jain Cc: Paulo Flabiano Smorigo Cc: Michael Ellerman Cc:

[PATCH 01/10] crypto: hisilicon: sec_drv: Supply missing description for 'sec_queue_empty()'s 'queue' param

2021-03-18 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/crypto/hisilicon/sec/sec_drv.c:843: warning: Function parameter or member 'queue' not described in 'sec_queue_empty' Cc: Herbert Xu Cc: "David S. Miller" Cc: Zaibo Xu Cc: Jonathan Cameron Cc: linux-cry...@vger.kernel.org

[PATCH 09/10] crypto: nx: nx-aes-cbc: Repair some kernel-doc problems

2021-03-18 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/crypto/nx/nx-aes-cbc.c:24: warning: Function parameter or member 'tfm' not described in 'cbc_aes_nx_set_key' drivers/crypto/nx/nx-aes-cbc.c:24: warning: Function parameter or member 'in_key' not described in 'cbc_aes_nx_set_key'

[PATCH 10/10] crypto: cavium: nitrox_isr: Demote non-compliant kernel-doc headers

2021-03-18 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/crypto/cavium/nitrox/nitrox_isr.c:17: warning: expecting prototype for One vector for each type of ring(). Prototype was for NR_RING_VECTORS() instead drivers/crypto/cavium/nitrox/nitrox_isr.c:224: warning: Function parameter or member

Re: [PATCH] ARM: decompressor: remove unused global variable output_data

2021-03-18 Thread Rasmus Villemoes
On 08/03/2021 15.29, Rasmus Villemoes wrote: > output_data seems to have been write-only since the flush_window() > callback was removed in commit e7db7b4270ed ("arm: add support for > LZO-compressed kernels"). Ping.

[PATCH 03/10] crypto: chelsio: chcr_core: Fix some kernel-doc issues

2021-03-18 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/crypto/chelsio/chcr_core.c:2: warning: wrong kernel-doc identifier on line: drivers/crypto/chelsio/chcr_algo.c:806: warning: Function parameter or member 'wrparam' not described in 'create_cipher_wr'

Re: [PATCH V3 5/5] arm64: dts: renesas: beacon kits: Setup AVB refclk

2021-03-18 Thread Adam Ford
On Thu, Mar 4, 2021 at 2:04 AM Geert Uytterhoeven wrote: > > On Wed, Feb 24, 2021 at 12:52 PM Adam Ford wrote: > > The AVB refererence clock assumes an external clock that runs > > reference > > > automatically. Because the Versaclock is wired to provide the > > AVB refclock, the device tree

[PATCH 02/10] crypto: bcm: Fix a whole host of kernel-doc misdemeanours

2021-03-18 Thread Lee Jones
Fixes the following W=1 kernel build warning(s): drivers/crypto/bcm/util.c:136: warning: Function parameter or member 'from_nents' not described in 'spu_msg_sg_add' drivers/crypto/bcm/util.c:136: warning: Function parameter or member 'length' not described in 'spu_msg_sg_add'

[PATCH v6 2/3] dt-bindings: mtd: Add a property to declare secure regions in NAND chips

2021-03-18 Thread Manivannan Sadhasivam
On a typical end product, a vendor may choose to secure some regions in the NAND memory which are supposed to stay intact between FW upgrades. The access to those regions will be blocked by a secure element like Trustzone. So the normal world software like Linux kernel should not touch these

[PATCH v6 0/3] Add support for secure regions in NAND

2021-03-18 Thread Manivannan Sadhasivam
On a typical end product, a vendor may choose to secure some regions in the NAND memory which are supposed to stay intact between FW upgrades. The access to those regions will be blocked by a secure element like Trustzone. So the normal world software like Linux kernel should not touch these

Re: [PATCH 1/2] devtmpfs: fix placement of complete() call

2021-03-18 Thread Rasmus Villemoes
On 12/03/2021 11.30, Rasmus Villemoes wrote: > Calling complete() from within the __init function is wrong - > theoretically, the init process could proceed all the way to freeing > the init mem before the devtmpfsd thread gets to execute the return > instruction in devtmpfs_setup(). Greg, ping?

[PATCH v6 3/3] mtd: rawnand: Add support for secure regions in NAND memory

2021-03-18 Thread Manivannan Sadhasivam
On a typical end product, a vendor may choose to secure some regions in the NAND memory which are supposed to stay intact between FW upgrades. The access to those regions will be blocked by a secure element like Trustzone. So the normal world software like Linux kernel should not touch these

[PATCH v6 1/3] dt-bindings: mtd: Convert Qcom NANDc binding to YAML

2021-03-18 Thread Manivannan Sadhasivam
Convert Qcom NANDc devicetree binding to YAML. Signed-off-by: Manivannan Sadhasivam Reviewed-by: Rob Herring --- .../devicetree/bindings/mtd/qcom,nandc.yaml | 196 ++ .../devicetree/bindings/mtd/qcom_nandc.txt| 142 - 2 files changed, 196 insertions(+), 142

[PATCH v3 00/10] Rid W=1 warnings in Crypto

2021-03-18 Thread Lee Jones
This is set 1 of 2 sets required to fully clean Crypto. v2: No functional changes since v1. v3: Description change and additional struct header fix Lee Jones (10): crypto: hisilicon: sec_drv: Supply missing description for 'sec_queue_empty()'s 'queue' param crypto: bcm: Fix a whole host

Re: [PATCH v4 1/4] sched/fair: Introduce primitives for CFS bandwidth burst

2021-03-18 Thread Phil Auld
On Thu, Mar 18, 2021 at 09:26:58AM +0800 changhuaixin wrote: > > > > On Mar 17, 2021, at 4:06 PM, Peter Zijlstra wrote: > > > > On Wed, Mar 17, 2021 at 03:16:18PM +0800, changhuaixin wrote: > > > >>> Why do you allow such a large burst? I would expect something like: > >>> > >>> if (burst

Re: [PATCH v4 1/2] ASoC: amd: Add support for RT5682 codec in machine driver

2021-03-18 Thread Mark Brown
On Thu, Mar 18, 2021 at 02:03:46AM +0530, Vijendar Mukunda wrote: > +++ b/sound/soc/amd/acp-da7219-max98357a.c > @@ -1,27 +1,8 @@ > -/* > - * Machine driver for AMD ACP Audio engine using DA7219 & MAX98357 codec > - * > - * Copyright 2017 Advanced Micro Devices, Inc. The conversion to SPDX really

Re: [PATCH 5/9] objtool: Rework rebuild_reloc logic

2021-03-18 Thread Peter Zijlstra
On Wed, Mar 17, 2021 at 07:49:17PM -0500, Josh Poimboeuf wrote: > On Wed, Mar 17, 2021 at 09:12:15AM +0100, Peter Zijlstra wrote: > > On Tue, Mar 16, 2021 at 10:34:17PM -0500, Josh Poimboeuf wrote: > > > On Fri, Mar 12, 2021 at 06:16:18PM +0100, Peter Zijlstra wrote: > > > > ---

  1   2   3   4   5   6   7   8   9   10   >