[GIT PULL] iomap: fixes for 5.12-rc4

2021-03-18 Thread Darrick J. Wong
Hi Linus, Please pull this single fix to the iomap code for 5.12-rc4, which fixes some drama when someone gives us a {de,ma}liciously fragmented swap file. The branch merges cleanly with upstream as of a few minutes ago and has been soaking in for-next for a week without complaints. Please let

Re: [V2,1/1] platform/x86: add support for Advantech software defined button

2021-03-18 Thread Hans de Goede
Hi, On 3/12/21 9:11 AM, YingChieh Ho wrote: > From: "Andrea.Ho" > > Advantech sw_button is a ACPI event trigger button. > > With this driver, we can report KEY_EVENT on the > Advantech Tabletop Network Appliances products and it has been > tested in FWA1112VC. > > Add the software define

Re: [PATCH RESEND V12 2/8] fuse: 32-bit user space ioctl compat for fuse device

2021-03-18 Thread Alessio Balsini
On Tue, Mar 16, 2021 at 07:53:06PM +0100, Arnd Bergmann wrote: > On Mon, Jan 25, 2021 at 4:48 PM Alessio Balsini wrote: > > > > With a 64-bit kernel build the FUSE device cannot handle ioctl requests > > coming from 32-bit user space. > > This is due to the ioctl command translation that

Re: [PATCH 3/3] static_call: Fix static_call_update() sanity check

2021-03-18 Thread Josh Poimboeuf
On Thu, Mar 18, 2021 at 12:31:59PM +0100, Peter Zijlstra wrote: > if (!kernel_text_address((unsigned long)site_addr)) { > - WARN_ONCE(1, "can't patch static call site at > %pS", > + /* > + *

Re: [PATCH v23 21/28] mm: Re-introduce vm_flags to do_mmap()

2021-03-18 Thread Borislav Petkov
On Thu, Mar 18, 2021 at 08:59:28AM -0700, Yu, Yu-cheng wrote: > Right, do_mmap_pgoff() was removed by commit 45e55300f114. This patch does > not add back the wrapper. Instead, add vm_flags to do_mmap(). Please advice > if I misunderstand the question. I'm just wondering why you even need to

Re: [PATCH] scsi: libsas: Reset num_scatter if libata mark qc as NODATA

2021-03-18 Thread John Garry
On 18/03/2021 00:24, Jolly Shah wrote: Hi John, Thanks for the review. On Wed, Mar 17, 2021 at 4:44 AM John Garry wrote: On 16/03/2021 19:39, Jolly Shah wrote: When the cache_type for the scsi device is changed, the scsi layer issues a MODE_SELECT command. The caching mode details are

Re: [PATCH v1] memory: tegra20: Add debug statistics

2021-03-18 Thread Dmitry Osipenko
18.03.2021 18:23, Krzysztof Kozlowski пишет: ... >> +mc->debugfs.root = debugfs_create_dir("mc", NULL); >> +if (!mc->debugfs.root) >> +dev_err(>dev, "failed to create debugfs directory\n"); > > It's error pointer, not null, but anyway there is no need for handling > debugfs

[PATCH] cifsd: fix a IS_ERR() vs NULL bug

2021-03-18 Thread Dan Carpenter
The smb_direct_alloc_sendmsg() function never returns NULL, it only returns error pointers so the check needs to be updated. Fixes: cabcebc31de4 ("cifsd: introduce SMB3 kernel server") Signed-off-by: Dan Carpenter --- fs/cifsd/transport_rdma.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH net-next v2 4/4] net: ipa: relax 64-bit build requirement

2021-03-18 Thread Alex Elder
We currently assume the IPA driver is built only for a 64 bit kernel. When this constraint was put in place it eliminated some do_div() calls, replacing them with the "/" and "%" operators. We now only use these operations on u32 and size_t objects. In a 32-bit kernel build, size_t will be 32

[PATCH net-next v2 0/4] net: ipa: support 32-bit targets

2021-03-18 Thread Alex Elder
There is currently a configuration dependency that restricts IPA to be supported only on 64-bit machines. There are only a few things that really require that, and those are fixed in this series. The last patch in the series removes the CONFIG_64BIT build dependency for IPA. Version 2 of this

[PATCH net-next v2 1/4] net: ipa: fix assumptions about DMA address size

2021-03-18 Thread Alex Elder
Some build time checks in ipa_table_validate_build() assume that a DMA address is 64 bits wide. That is more restrictive than it has to be. A route or filter table is 64 bits wide no matter what the size of a DMA address is on the AP. The code actually uses a pointer to __le64 to access table

[PATCH net-next v2 3/4] net: ipa: fix table alignment requirement

2021-03-18 Thread Alex Elder
We currently have a build-time check to ensure that the minimum DMA allocation alignment satisfies the constraint that IPA filter and route tables must point to rules that are 128-byte aligned. But what's really important is that the actual allocated DMA memory has that alignment, even if the

[PATCH net-next v2 2/4] net: ipa: use upper_32_bits()

2021-03-18 Thread Alex Elder
Use upper_32_bits() to extract the high-order 32 bits of a DMA address. This avoids doing a 32-position shift on a DMA address if it happens not to be 64 bits wide. Suggested-by: Florian Fainelli Signed-off-by: Alex Elder --- v2: - Switched to use the existing function, as suggested by

Re: [PATCH 1/2] spi: spi-zynq-qspi: Fix kernel-doc warning

2021-03-18 Thread Mark Brown
On Thu, Mar 18, 2021 at 04:24:45AM -0600, Amit Kumar Mahapatra wrote: > Fix kernel-doc warning. > > Signed-off-by: Amit Kumar Mahapatra > --- Applying: spi: spi-zynq-qspi: Fix kernel-doc warning Using index info to reconstruct a base tree... error: patch failed: drivers/spi/spi-zynq-qspi.c:367

Re: Question about sg_count_fuse_req() in linux/fs/fuse/virtio_fs.c

2021-03-18 Thread Connor Kuehl
On 3/18/21 8:56 AM, Vivek Goyal wrote: I think all the in args are being mapped into a single scatter gather element and that's why it does not matter whether in_numargs is 3, 2 or 1. They will be mapped in a single element. sg_init_fuse_args() { len = fuse_len_args(numargs - argpages,

[PATCH v4] hwmon: corsair-psu: add support for critical values

2021-03-18 Thread Wilken Gottwalt
Adds support for reading the critical values of the temperature sensors and the rail sensors (voltage and current) once and caches them. Updates the naming of the constants following a more clear scheme. Also updates the documentation and fixes some typos. Updates is_visible and ops_read functions

Re: [PATCH v6 3/3] mtd: rawnand: Add support for secure regions in NAND memory

2021-03-18 Thread kernel test robot
Hi Manivannan, I love your patch! Perhaps something to improve: [auto build test WARNING on mtd/mtd/next] [also build test WARNING on mtd/mtd/fixes mtd/nand/next v5.12-rc3 next-20210318] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest

[RESEND PATCH] Kconfig: Move CONFIG_DEBUG_KMEMLEAK_TEST to samples/Kconfig

2021-03-18 Thread chenjun (AM)
From: Chen Jun commit 1abbef4f51724fb11f09adf0e75275f7cb422a8a ("mm,kmemleak-test.c: move kmemleak-test.c to samples dir") make CONFIG_DEBUG_KMEMLEAK_TEST depend on CONFIG_SAMPLES implicitly. And the dependency cannot be guaranteed by Kconfig. move the definition of CONFIG_DEBUG_KMEMLEAK_TEST

Re: [PATCH tip/core/rcu 1/3] rcu: Provide polling interfaces for Tree RCU grace periods

2021-03-18 Thread Frederic Weisbecker
On Tue, Mar 16, 2021 at 09:51:01AM -0700, Paul E. McKenney wrote: > On Tue, Mar 16, 2021 at 04:17:50PM +0100, Frederic Weisbecker wrote: > > On Wed, Mar 03, 2021 at 04:26:30PM -0800, paul...@kernel.org wrote: > > > +/** > > > + * poll_state_synchronize_rcu - Conditionally wait for an RCU grace >

[PATCH 1/2] dt-bindings: remoteproc: stm32-rproc: add new mailbox channel for detach

2021-03-18 Thread Arnaud Pouliquen
Add the "detach" mailbox item, that allows to define a mailbox to send a IPCC signal to the remote processor on remoteproc detach action. Signed-off-by: Arnaud Pouliquen --- .../bindings/remoteproc/st,stm32-rproc.yaml | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(-)

Re: [syzbot] KASAN: slab-out-of-bounds Read in riscv_intc_irq

2021-03-18 Thread Dmitry Vyukov
On Thu, Mar 18, 2021 at 3:50 PM Kefeng Wang wrote: > >> On 2021/3/14 18:47, Dmitry Vyukov wrote: > >>> On Sun, Mar 14, 2021 at 11:14 AM syzbot > >>> wrote: > Hello, > > syzbot found the following issue on: > > HEAD commit:0d7588ab riscv: process: Fix no prototype for

Re: [PATCH] fs/dcache: fix typos and sentence disorder

2021-03-18 Thread Matthew Wilcox
On Thu, Mar 18, 2021 at 10:31:53PM +0800, Xiaofeng Cao wrote: > change 'sould' to 'should' > change 'colocated' to 'collocated' uh. collocated is incorrect. colocated is correct. https://www.merriam-webster.com/dictionary/colocate https://www.merriam-webster.com/dictionary/collocate The other

[PATCH 0/2] remoteproc: stm32: add support of detaching a remote processor

2021-03-18 Thread Arnaud Pouliquen
This patchset is the stm32mp1 platform implementation of the detach operation added in series [1]. On detach, the stm32 rproc driver sends a mailbox signal to the remote processor to inform it that it will be detached. Applied and tested on Bjorn's "for_next" branch (2b81aa17008e) [1]

[PATCH 2/2] remoteproc: stm32: add capability to detach

2021-03-18 Thread Arnaud Pouliquen
From: Arnaud Pouliquen A mechanism similar to the shutdown mailbox signal is implemented to detach a remote processor. Upon detachment, a signal is sent to the remote firmware, allowing it to perform specific actions such as stopping RPMsg communication. The Cortex-M hold boot is also disabled

Re: [PATCH v4 1/4] sched/fair: Introduce primitives for CFS bandwidth burst

2021-03-18 Thread Peter Zijlstra
On Thu, Mar 18, 2021 at 08:59:44AM -0400, Phil Auld wrote: > I admit to not having followed all the history of this patch set. That > said, when I see the above I just think your quota is too low for your > workload. This. > The burst (mis?)feature seems to be a way to bypass the quota. And it

Re: [PATCH v4 3/5] mm: memcontrol: change ug->dummy_page only if memcg changed

2021-03-18 Thread Johannes Weiner
On Thu, Mar 18, 2021 at 07:06:56PM +0800, Muchun Song wrote: > Just like assignment to ug->memcg, we only need to update ug->dummy_page > if memcg changed. So move it to there. This is a very small optimization. > > Signed-off-by: Muchun Song Acked-by: Johannes Weiner

[PATCH 12/15] staging: rtl8723bs: remove unnecessary logging in os_dep/ioctl_cfg80211.c

2021-03-18 Thread Fabio Aiuto
fix the following checkpatch.pl issues: WARNING: Unnecessary ftrace-like logging - prefer using ftrace 239: FILE: drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c:239: + /* DBG_8192C("%s\n", __func__); */ -- WARNING: Unnecessary ftrace-like logging - prefer using ftrace 569: FILE:

[PATCH 14/15] staging: rtl8723bs: remove unnecessary logging in os_dep/os_intfs.c

2021-03-18 Thread Fabio Aiuto
fix the following checkpatch.pl issues: WARNING: Unnecessary ftrace-like logging - prefer using ftrace 977: FILE: drivers/staging/rtl8723bs/os_dep/os_intfs.c:977: + DBG_871X("===> %s.\n", __func__); -- WARNING: Unnecessary ftrace-like logging - prefer using ftrace 1030: FILE:

Re: [RFC PATCH 4/7] iommu/amd: Initial support for AMD IOMMU v2 page table

2021-03-18 Thread Joerg Roedel
Hi Suravee, On Fri, Mar 12, 2021 at 03:04:08AM -0600, Suravee Suthikulpanit wrote: > @@ -503,6 +504,7 @@ struct amd_io_pgtable { > int mode; > u64 *root; > atomic64_t pt_root;/* pgtable root and pgtable mode */ > +

[PATCH 13/15] staging: rtl8723bs: remove unnecessary logging in os_dep/ioctl_linux.c

2021-03-18 Thread Fabio Aiuto
fix the following checkpatch.pl issues: WARNING: Unnecessary ftrace-like logging - prefer using ftrace 1207: FILE: drivers/staging/rtl8723bs/os_dep/ioctl_linux.c:1207: + DBG_871X("%s\n", __func__); -- WARNING: Unnecessary ftrace-like logging - prefer using ftrace 1507: FILE:

[PATCH 15/15] staging: rtl8723bs: remove unnecessary logging in os_dep/wifi_regd.c

2021-03-18 Thread Fabio Aiuto
fix the following checkpatch.pl issues: WARNING: Unnecessary ftrace-like logging - prefer using ftrace 153: FILE: drivers/staging/rtl8723bs/os_dep/wifi_regd.c:153: + DBG_8192C("%s\n", __func__); Signed-off-by: Fabio Aiuto --- drivers/staging/rtl8723bs/os_dep/wifi_regd.c | 2 -- 1 file

Re: [RFC PATCH 6/7] iommu/amd: Introduce amd_iommu_pgtable command-line option

2021-03-18 Thread Joerg Roedel
On Fri, Mar 12, 2021 at 03:04:10AM -0600, Suravee Suthikulpanit wrote: > To allow specification whether to use v1 or v2 IOMMU pagetable for > DMA remapping when calling kernel DMA-API. > > Signed-off-by: Suravee Suthikulpanit > --- > Documentation/admin-guide/kernel-parameters.txt | 6 ++ >

Re: [PATCH 1/1] ACPI: fix acpi table use after free

2021-03-18 Thread Rafael J. Wysocki
On Wed, Mar 17, 2021 at 11:28 PM George Kennedy wrote: > > > > On 3/17/2021 4:14 PM, Rafael J. Wysocki wrote: > > On Monday, March 15, 2021 5:19:29 PM CET Rafael J. Wysocki wrote: > >> On Sun, Mar 14, 2021 at 8:00 PM Mike Rapoport wrote: > >>> On Thu, Mar 11, 2021 at 04:36:31PM +0100, Rafael J.

Re: [PATCH 2/2] iommu/iova: Improve restart logic

2021-03-18 Thread John Garry
Well yeah, in your particular case you're allocating from a heavily over-contended address space, so much of the time it is genuinely full. Plus you're primarily churning one or two sizes of IOVA, so there's a high chance that you will either allocate immediately from the cached node (after

Re: [PATCH] selftests/bpf: fix warning comparing pointer to 0

2021-03-18 Thread Daniel Borkmann
On 3/18/21 2:55 AM, Jiapeng Chong wrote: Fix the following coccicheck warning: ./tools/testing/selftests/bpf/progs/fentry_test.c:76:15-16: WARNING comparing pointer to 0. Reported-by: Abaci Robot Signed-off-by: Jiapeng Chong --- tools/testing/selftests/bpf/progs/fentry_test.c | 4 ++-- 1

Re: [PATCH v3 1/2] crypto: qat - dont release uninitialized resources

2021-03-18 Thread Tong Zhang
Thanks! I have fixed typos and resent them as v4. - Tong

Re: [PATCH v2 1/2] kvm/kvm_util: add _vm_ioctl

2021-03-18 Thread Andrew Jones
On Thu, Mar 18, 2021 at 04:16:23PM +0100, Emanuele Giuseppe Esposito wrote: > As in kvm_ioctl and _kvm_ioctl, add > the respective _vm_ioctl for vm_ioctl. > > _vm_ioctl invokes an ioctl using the vm fd, > leaving the caller to test the result. > > Signed-off-by: Emanuele Giuseppe Esposito > ---

Re: [PATCH v4 1/3] mm/slub: Introduce two counters for partial objects

2021-03-18 Thread Xunlei Pang
On 3/18/21 8:18 PM, Vlastimil Babka wrote: > On 3/17/21 8:54 AM, Xunlei Pang wrote: >> The node list_lock in count_partial() spends long time iterating >> in case of large amount of partial page lists, which can cause >> thunder herd effect to the list_lock contention. >> >> We have HSF

[RFC PATCH v3 1/8] RISC-V: Enable CPU_IDLE drivers

2021-03-18 Thread Anup Patel
We force select CPU_PM and provide asm/cpuidle.h so that we can use CPU IDLE drivers for Linux RISC-V kernel. Signed-off-by: Anup Patel --- arch/riscv/Kconfig| 7 +++ arch/riscv/configs/defconfig | 7 +++ arch/riscv/configs/rv32_defconfig | 4 ++--

Re: [PATCH] i2c: stm32f7: avoid ifdef CONFIG_PM_SLEEP for pm callbacks

2021-03-18 Thread Pierre Yves MORDRET
Hi All, Reviewed-by: Pierre-Yves MORDRET Regards On 3/12/21 12:53 PM, Alain Volmat wrote: > Avoid CONFIG_PM preprocessor check for pm suspend/resume > callbacks and identify the functions with __maybe_unused. > > Signed-off-by: Alain Volmat > --- > drivers/i2c/busses/i2c-stm32f7.c | 10

[RFC PATCH v3 2/8] RISC-V: Rename relocate() and make it global

2021-03-18 Thread Anup Patel
The low-level relocate() function enables mmu and relocates execution to link-time addresses. We rename relocate() function to relocate_enable_mmu() function which is more informative. Also, the relocate_enable_mmu() function will be used in the resume path when a CPU wakes-up from a

[RFC PATCH v3 3/8] RISC-V: Add arch functions for non-retentive suspend entry/exit

2021-03-18 Thread Anup Patel
The hart registers and CSRs are not preserved in non-retentative suspend state so we provide arch specific helper functions which will save/restore hart context upon entry/exit to non-retentive suspend state. These helper functions can be used by cpuidle drivers for non-retentive suspend

[RFC PATCH v3 0/8] RISC-V CPU Idle Support

2021-03-18 Thread Anup Patel
This series adds RISC-V CPU Idle support using SBI HSM suspend function. The RISC-V SBI CPU idle driver added by this series is highly inspired from the ARM PSCI CPU idle driver. At high-level, this series includes the following changes: 1) Preparatory arch/riscv patches (Patches 1 to 3) 2)

Re: [PATCH v2 1/3] perf test: Remove unused argument

2021-03-18 Thread Arnaldo Carvalho de Melo
Em Thu, Mar 18, 2021 at 02:01:49PM +0100, Jiri Olsa escreveu: > On Tue, Mar 16, 2021 at 05:55:03PM -0700, Ian Rogers wrote: > > Remove unused argument from daemon_exit. > > > > Signed-off-by: Ian Rogers > > for the patchset > > Acked-by: Jiri Olsa Thanks, added to the csets I had applied

Re: [PATCH] virt_wifi: Return micros for BSS TSF values

2021-03-18 Thread kernel test robot
patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch] url: https://github.com/0day-ci/linux/commits/A-Cody-Schuffelen/virt_wifi-Return-micros-for-BSS-TSF-values/20210318-100417 base: https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless

Re: [RESEND 00/53] Rid GPU from W=1 warnings

2021-03-18 Thread Daniel Vetter
On Wed, Mar 17, 2021 at 9:32 PM Daniel Vetter wrote: > > On Wed, Mar 17, 2021 at 9:17 AM Lee Jones wrote: > > > > On Thu, 11 Mar 2021, Lee Jones wrote: > > > > > On Thu, 11 Mar 2021, Daniel Vetter wrote: > > > > > > > On Mon, Mar 08, 2021 at 09:19:32AM +, Lee Jones wrote: > > > > > On Fri,

Re: [PATCH] ALSA: usb-audio: Fix unintentional sign extension issue

2021-03-18 Thread Takashi Iwai
On Thu, 18 Mar 2021 14:20:08 +0100, Colin King wrote: > > From: Colin Ian King > > The shifting of the u8 integer device by 24 bits to the left will > be promoted to a 32 bit signed int and then sign-extended to a > 64 bit unsigned long. In the event that the top bit of device is > set then all

Re: [PATCH net V2 1/1] net: phy: fix invalid phy id when probe using C22

2021-03-18 Thread Heiner Kallweit
On 18.03.2021 10:09, Wong Vee Khee wrote: > When using Clause-22 to probe for PHY devices such as the Marvell > 88E2110, PHY ID with value 0 is read from the MII PHYID registers > which caused the PHY framework failed to attach the Marvell PHY > driver. > > Fixed this by adding a check of PHY ID

Re: [PATCH 0/6] usbip fixes to crashes found by syzbot

2021-03-18 Thread Tetsuo Handa
On 2021/03/18 22:13, Shuah Khan wrote: > Please don't review code that isn't sent upstream. This repo you are > looking at is a private branch created just to verify fixes on syzbot. But nobody was able to review this series when sent to ML (except you simply ignored my questions), and this

Re: [PATCH 4/4] PCI/sysfs: Allow userspace to query and set device reset mechanism

2021-03-18 Thread Amey Narkhede
On 21/03/18 11:09AM, Leon Romanovsky wrote: > On Wed, Mar 17, 2021 at 11:31:40AM -0600, Alex Williamson wrote: > > On Wed, 17 Mar 2021 15:58:40 +0200 > > Leon Romanovsky wrote: > > > > > On Wed, Mar 17, 2021 at 06:47:18PM +0530, Amey Narkhede wrote: > > > > On 21/03/17 01:47PM, Leon Romanovsky

[PATCH net-next] net: phy: at803x: remove at803x_aneg_done()

2021-03-18 Thread Michael Walle
at803x_aneg_done() is pretty much dead code since the patch series "net: phy: improve and simplify phylib state machine" [1]. Remove it. [1] https://lore.kernel.org/netdev/922c223b-7bc0-e0ec-345d-2034b796a...@gmail.com/ Suggested-by: Vladimir Oltean Signed-off-by: Michael Walle ---

Re: [PATCH v8] i2c: virtio: add a virtio i2c frontend driver

2021-03-18 Thread Arnd Bergmann
On Thu, Mar 18, 2021 at 3:42 PM Enrico Weigelt, metux IT consult wrote: > > On 16.03.21 08:44, Viresh Kumar wrote: > > > FWIW, this limits this driver to support a single device ever. We > > can't bind multiple devices to this driver now. Yeah, perhaps we will > > never be required to do so, but

Re: [PATCH v2 2/2] mm/memcg: set memcg when split page

2021-03-18 Thread Johannes Weiner
On Thu, Mar 18, 2021 at 03:05:00PM +0100, Michal Hocko wrote: > On Thu 11-03-21 12:37:20, Hugh Dickins wrote: > > On Thu, 11 Mar 2021, Michal Hocko wrote: > > > On Thu 11-03-21 10:21:39, Johannes Weiner wrote: > > > > On Thu, Mar 11, 2021 at 09:37:02AM +0100, Michal Hocko wrote: > > > > >

Re: [PATCH v3 0/6] Some cleanups for huge_memory

2021-03-18 Thread Peter Xu
On Thu, Mar 18, 2021 at 08:27:16AM -0400, Miaohe Lin wrote: > Hi all, > This series contains cleanups to rework some function logics to make it > more readable, use helper function and so on. More details can be found > in the respective changelogs. Thanks! > > v2->v3: > use ALIGN/ALIGN_DOWN too

Re: [RESEND PATCH v2] perf stat: improve readability of shadow stats

2021-03-18 Thread Changbin Du
On Tue, Mar 16, 2021 at 02:53:41PM +0100, Jiri Olsa wrote: > On Mon, Mar 15, 2021 at 10:30:47PM +0800, Changbin Du wrote: > > SNIP > > > diff --git a/tools/perf/util/stat-shadow.c b/tools/perf/util/stat-shadow.c > > index 6ccf21a72f06..3f800e71126f 100644 > > --- a/tools/perf/util/stat-shadow.c

Re: [PATCH 2/3] virtiofs: split requests that exceed virtqueue size

2021-03-18 Thread Miklos Szeredi
On Thu, Mar 18, 2021 at 08:52:22AM -0500, Connor Kuehl wrote: > If an incoming FUSE request can't fit on the virtqueue, the request is > placed onto a workqueue so a worker can try to resubmit it later where > there will (hopefully) be space for it next time. > > This is fine for requests that

Re: [syzbot] BUG: unable to handle kernel access to user memory in sock_ioctl

2021-03-18 Thread Dmitry Vyukov
On Mon, Mar 15, 2021 at 3:41 PM Ben Dooks wrote: > > On 15/03/2021 11:52, Dmitry Vyukov wrote: > > On Mon, Mar 15, 2021 at 12:30 PM Ben Dooks > > wrote: > >> > >> On 14/03/2021 11:03, Dmitry Vyukov wrote: > >>> On Sun, Mar 14, 2021 at 11:01 AM Dmitry Vyukov wrote: > > On Wed, Mar 10, 2021

Re: [PATCH] selftests/kvm: add get_msr_index_features

2021-03-18 Thread Paolo Bonzini
On 18/03/21 15:56, Emanuele Giuseppe Esposito wrote: Test the KVM_GET_MSR_FEATURE_INDEX_LIST and KVM_GET_MSR_INDEX_LIST ioctls. Signed-off-by: Emanuele Giuseppe Esposito Looks good, thanks. I queued it with a little extra code to verify KVM_GET_MSR_INDEX_LIST in the case that does not

Re: [PATCH v2 1/1] PCI: pciehp: Skip DLLSC handling if DPC is triggered

2021-03-18 Thread Sinan Kaya
On 3/17/2021 4:02 PM, Kuppuswamy, Sathyanarayanan wrote: > My point is, there is no race in OS handlers (pciehp_ist() vs > pcie_do_recovery()) >  However, Sinan wrote in >> 2018 that one of the issues with hotplug versus DPC is that pciehp >> may turn off slot power and thereby foil DPC recovery. 

Re: [RFC PATCH 7/7] iommu/amd: Add support for using AMD IOMMU v2 page table for DMA-API

2021-03-18 Thread Joerg Roedel
On Fri, Mar 12, 2021 at 03:04:11AM -0600, Suravee Suthikulpanit wrote: > Introduce init function for setting up DMA domain for DMA-API with > the IOMMU v2 page table. > > Signed-off-by: Suravee Suthikulpanit > --- > drivers/iommu/amd/iommu.c | 21 + > 1 file changed, 21

Re: [PATCH v3 1/2] crypto: qat - dont release uninitialized resources

2021-03-18 Thread Giovanni Cabiddu
On Fri, Mar 12, 2021 at 11:22:02AM -0500, Tong Zhang wrote: > adf_vf_isr_resource_alloc() is not unwinding correctly when error > happens and it trys to release uninitialized resources. > To fix this, only release initialized resources. > > [1.792845] Trying to free already-free IRQ 11 > [

[PATCH] audit: log nftables configuration change events once per table

2021-03-18 Thread Richard Guy Briggs
Reduce logging of nftables events to a level similar to iptables. Restore the table field to list the table, adding the generation. Indicate the op as the most significant operation in the event. A couple of sample events: type=PROCTITLE msg=audit(2021-03-18 09:30:49.801:143) :

[PATCH][next] mm/vmalloc: fix read of uninitialized pointer area

2021-03-18 Thread Colin King
From: Colin Ian King There is a corner case where the sanity check of variable size fails and branches to label fail and shift can be less than PAGE_SHIFT causing area to never be assigned. This was picked up by static analysis as follows: 1. var_decl: Declaring variable area without

Re: [PATCH v10 0/3] Charge loop device i/o to issuing cgroup

2021-03-18 Thread Jens Axboe
On 3/18/21 9:53 AM, Shakeel Butt wrote: > On Wed, Mar 17, 2021 at 3:30 PM Jens Axboe wrote: >> >> On 3/16/21 9:36 AM, Dan Schatzberg wrote: >>> No major changes, just rebasing and resubmitting >> >> Applied for 5.13, thanks. >> > > I have requested a couple of changes in the patch series. Can

Re: [PATCH v23 21/28] mm: Re-introduce vm_flags to do_mmap()

2021-03-18 Thread Yu, Yu-cheng
On 3/18/2021 4:42 AM, Borislav Petkov wrote: On Tue, Mar 16, 2021 at 08:10:47AM -0700, Yu-cheng Yu wrote: There was no more caller passing vm_flags to do_mmap(), and vm_flags was removed from the function's input by: commit 45e55300f114 ("mm: remove unnecessary wrapper function

Re: [RFC PATCH 5/7] iommu/amd: Add support for Guest IO protection

2021-03-18 Thread Joerg Roedel
On Fri, Mar 12, 2021 at 03:04:09AM -0600, Suravee Suthikulpanit wrote: > @@ -519,6 +521,7 @@ struct protection_domain { > spinlock_t lock;/* mostly used to lock the page table*/ > u16 id; /* the domain id written to the device table */ > int glx;

Re: [PATCH][RESEND] Revert "PM: ACPI: reboot: Use S5 for reboot"

2021-03-18 Thread Rafael J. Wysocki
On 3/18/2021 6:42 AM, Kai-Heng Feng wrote: On Thu, Mar 18, 2021 at 1:25 AM Josef Bacik wrote: [snipped] "shutdown now" works fine with and without your patch. Thanks, Rafael, Please revert the patch while we are working on it. Done, thanks! Josef, Can you please test the following

[PATCH][next] octeontx2-af: Remove redundant initialization of pointer pfvf

2021-03-18 Thread Colin King
From: Colin Ian King The pointer pfvf is being initialized with a value that is never read and it is being updated later with a new value. The initialization is redundant and can be removed. Addresses-Coverity: ("Unused value") Fixes: 56bcef528bd8 ("octeontx2-af: Use npc_install_flow API for

Hello linux-kernel@vger.kernel.org

2021-03-18 Thread Dr Chris Hobson
Greetings: linux-kernel@vger.kernel.org I have a business transaction that I will like to discuss with you. Please reply me immediately via my Email: chrishobson...@gmail.com Best regards, Dr Chris Hobson Credit Suisse Bank London.

Re: [PATCH v3 0/3] Binder: Enable App Freezing Capability

2021-03-18 Thread Todd Kjos
On Wed, Mar 17, 2021 at 1:17 PM Jann Horn wrote: > > On Wed, Mar 17, 2021 at 7:00 PM Christian Brauner > wrote: > > On Mon, Mar 15, 2021 at 06:16:27PM -0700, Li Li wrote: > > > To improve the user experience when switching between recently used > > > applications, the background applications

Re: [PATCH v2 2/2] selftests/kvm: add set_boot_cpu_id test

2021-03-18 Thread Andrew Jones
On Thu, Mar 18, 2021 at 04:16:24PM +0100, Emanuele Giuseppe Esposito wrote: > Test for the KVM_SET_BOOT_CPU_ID ioctl. > Check that it correctly allows to change the BSP vcpu. > > v1 -> v2: > - remove unnecessary printf > - move stage for loop inside run_vcpu > - test EBUSY when calling

Re: [PATCH v2 4/6] phy: qcom-qmp: add support for sm8250-usb3-dp phy

2021-03-18 Thread kernel test robot
Hi Dmitry, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on robh/for-next] [also build test WARNING on linus/master v5.12-rc3] [cannot apply to phy/next next-20210318] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting

Re: [PATCH 0/6] usbip fixes to crashes found by syzbot

2021-03-18 Thread Shuah Khan
On 3/17/21 9:06 AM, Shuah Khan wrote: On 3/17/21 12:21 AM, Tetsuo Handa wrote: Shuah, this driver is getting more and more cryptic and buggy. Please explain the strategy for serialization before you write patches. - Fix attach_store() to check usbip_event_happened() before    waking up

[PATCH] cifsd: Fix a use after free on error path

2021-03-18 Thread Dan Carpenter
The ksmbd_free_work_struct() frees "work" so we need to swap the order of these two function calls to avoid a use after free. Fixes: cabcebc31de4 ("cifsd: introduce SMB3 kernel server") Signed-off-by: Dan Carpenter --- fs/cifsd/oplock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH 2/2] iommu/iova: Improve restart logic

2021-03-18 Thread Robin Murphy
On 2021-03-18 11:38, John Garry wrote: On 10/03/2021 17:47, John Garry wrote: On 09/03/2021 15:55, John Garry wrote: On 05/03/2021 16:35, Robin Murphy wrote: Hi Robin, When restarting after searching below the cached node fails, resetting the start point to the anchor node is often overly

[PATCH] ALSA: usb-audio: Fix unintentional sign extension issue

2021-03-18 Thread Colin King
From: Colin Ian King The shifting of the u8 integer device by 24 bits to the left will be promoted to a 32 bit signed int and then sign-extended to a 64 bit unsigned long. In the event that the top bit of device is set then all then all the upper 32 bits of the unsigned long will end up as also

[no subject]

2021-03-18 Thread kayla manthey
Ik wil alsjeblieft weten of je mijn vorige berichten hebt ontvangen.

Re: [PATCH v2 2/2] mm/memcg: set memcg when split page

2021-03-18 Thread Michal Hocko
On Thu 11-03-21 12:37:20, Hugh Dickins wrote: > On Thu, 11 Mar 2021, Michal Hocko wrote: > > On Thu 11-03-21 10:21:39, Johannes Weiner wrote: > > > On Thu, Mar 11, 2021 at 09:37:02AM +0100, Michal Hocko wrote: > > > > Johannes, Hugh, > > > > > > > > what do you think about this approach? If we

Re: [PATCH v3 3/6] mm/huge_memory.c: rework the function do_huge_pmd_numa_page() slightly

2021-03-18 Thread Zi Yan
On 18 Mar 2021, at 8:27, Miaohe Lin wrote: > The current code that checks if migrating misplaced transhuge page is > needed is pretty hard to follow. Rework it and add a comment to make > its logic more clear and improve readability. > > Signed-off-by: Miaohe Lin > --- > mm/huge_memory.c | 11

Re: [PATCH v7 2/2] hwspinlock: add sun6i hardware spinlock support

2021-03-18 Thread Wilken Gottwalt
On Mon, 15 Mar 2021 17:12:20 +0100 Maxime Ripard wrote: > On Sun, Mar 14, 2021 at 10:31:13AM +0100, Wilken Gottwalt wrote: > > Adds the sun6i_hwspinlock driver for the hardware spinlock unit found in > > most of the sun6i compatible SoCs. > > > > This unit provides at least 32 spinlocks in

Re: [PATCH 7/7] arm64: dts: mt8173: Drop compatible for mt6397

2021-03-18 Thread Enric Balletbo Serra
Hi Matthias, Thank you for your patch. Missatge de l'adreça del dia dv., 12 de març 2021 a les 15:57: > > From: Matthias Brugger > > The regulator framework does not need compatible, it's actually > superfluous. Drop it from the DT. > > Signed-off-by: Matthias Brugger > > Series-to:

Re: [PATCH] Documentation: arm64/acpi : clarify arm64 support of IBFT

2021-03-18 Thread Ard Biesheuvel
On Thu, 18 Mar 2021 at 12:29, Lorenzo Pieralisi wrote: > > [+ Al, Ard] > > On Thu, Mar 18, 2021 at 10:44:33AM +, Will Deacon wrote: > > [+Lorenzo] > > > > On Tue, Mar 16, 2021 at 12:50:41PM -0600, Tom Saeger wrote: > > > In commit 94bccc340710 ("iscsi_ibft: make ISCSI_IBFT dependson ACPI > >

Re: [Linux-stm32] [PATCH v9 22/33] counter: Internalize sysfs interface code

2021-03-18 Thread William Breathitt Gray
On Thu, Mar 18, 2021 at 11:10:29AM +0100, Fabrice Gasnier wrote: > On 3/18/21 10:21 AM, Fabrice Gasnier wrote: > > On 3/14/21 10:08 AM, William Breathitt Gray wrote: > >> On Sun, Mar 14, 2021 at 04:56:44PM +0900, William Breathitt Gray wrote: > >>> On Fri, Mar 12, 2021 at 04:02:42PM +0100, Fabrice

Re: [syzbot] BUG: unable to handle kernel access to user memory in schedule_tail

2021-03-18 Thread Dmitry Vyukov
On Mon, Mar 15, 2021 at 5:55 PM Ben Dooks wrote: > > On Fri, Mar 12, 2021 at 9:12 PM Ben Dooks wrote: > > >>> Still no luck for the moment, can't reproduce it locally, my test is > >>> maybe not that good (I created threads all day long in order to trigger > >>> the put_user of schedule_tail). >

[tip: x86/cleanups] x86: Fix various typos in comments

2021-03-18 Thread tip-bot2 for Ingo Molnar
The following commit has been merged into the x86/cleanups branch of tip: Commit-ID: d9f6e12fb0b7fcded0bac34b8293ec46f80dfc33 Gitweb: https://git.kernel.org/tip/d9f6e12fb0b7fcded0bac34b8293ec46f80dfc33 Author:Ingo Molnar AuthorDate:Thu, 18 Mar 2021 15:28:01 +01:00

Re: [PATCH v7 2/3] block: add bdev_interposer

2021-03-18 Thread Sergei Shtepa
The 03/17/2021 22:13, Mike Snitzer wrote: > On Wed, Mar 17 2021 at 2:14pm -0400, > Sergei Shtepa wrote: > > > The 03/17/2021 18:04, Mike Snitzer wrote: > > > On Wed, Mar 17 2021 at 8:22am -0400, > > > Sergei Shtepa wrote: > > > > > > > The 03/17/2021 06:03, Ming Lei wrote: > > > > > On Tue,

[PATCH] selftests/kvm: add get_msr_index_features

2021-03-18 Thread Emanuele Giuseppe Esposito
Test the KVM_GET_MSR_FEATURE_INDEX_LIST and KVM_GET_MSR_INDEX_LIST ioctls. Signed-off-by: Emanuele Giuseppe Esposito --- tools/testing/selftests/kvm/.gitignore| 1 + tools/testing/selftests/kvm/Makefile | 1 + .../kvm/x86_64/get_msr_index_features.c | 124

Re: [PATCH] memcg: set page->private before calling swap_readpage

2021-03-18 Thread Johannes Weiner
On Wed, Mar 17, 2021 at 06:59:59PM -0700, Shakeel Butt wrote: > The function swap_readpage() (and other functions it call) extracts swap > entry from page->private. However for SWP_SYNCHRONOUS_IO, the kernel > skips the swapcache and thus we need to manually set the page->private > with the swap

Re: [PATCH] memcg: set page->private before calling swap_readpage

2021-03-18 Thread Johannes Weiner
On Thu, Mar 18, 2021 at 03:01:25PM +0100, Michal Hocko wrote: > On Wed 17-03-21 18:59:59, Shakeel Butt wrote: > > The function swap_readpage() (and other functions it call) extracts swap > > entry from page->private. However for SWP_SYNCHRONOUS_IO, the kernel > > skips the swapcache and thus we

Re: [PATCH v2 2/2] mm/memcg: set memcg when split page

2021-03-18 Thread Matthew Wilcox
On Thu, Mar 18, 2021 at 03:05:00PM +0100, Michal Hocko wrote: > On Thu 11-03-21 12:37:20, Hugh Dickins wrote: > > On Thu, 11 Mar 2021, Michal Hocko wrote: > > > On Thu 11-03-21 10:21:39, Johannes Weiner wrote: > > > > On Thu, Mar 11, 2021 at 09:37:02AM +0100, Michal Hocko wrote: > > > > >

[PATCH][next] loop: Fix missing max_active argument in alloc_workqueue call

2021-03-18 Thread Colin King
From: Colin Ian King The 3rd argument to alloc_workqueue should be the max_active count, however currently it is the lo->lo_number that is intended for the loop%d number. Fix this by adding in the missing max_active count. Addresses-Coverity: ("Missing argument to printf") Fixes: 08ad7f822739

[PATCH v2 2/2] selftests/kvm: add set_boot_cpu_id test

2021-03-18 Thread Emanuele Giuseppe Esposito
Test for the KVM_SET_BOOT_CPU_ID ioctl. Check that it correctly allows to change the BSP vcpu. v1 -> v2: - remove unnecessary printf - move stage for loop inside run_vcpu - test EBUSY when calling KVM_SET_BOOT_CPU_ID after vcpu creation and execution - introduce _vm_ioctl Signed-off-by:

[PATCH v2 1/2] kvm/kvm_util: add _vm_ioctl

2021-03-18 Thread Emanuele Giuseppe Esposito
As in kvm_ioctl and _kvm_ioctl, add the respective _vm_ioctl for vm_ioctl. _vm_ioctl invokes an ioctl using the vm fd, leaving the caller to test the result. Signed-off-by: Emanuele Giuseppe Esposito --- tools/testing/selftests/kvm/include/kvm_util.h | 1 +

Re: [PATCH 1/2] media: v4l2-core: ignore native time32 ioctls on 64-bit

2021-03-18 Thread Arnd Bergmann
On Thu, Mar 18, 2021 at 4:00 PM Laurent Pinchart wrote: > On Thu, Mar 18, 2021 at 02:43:18PM +0100, Arnd Bergmann wrote: > > v4l2_event vs. v4l2_event32 vs. v4l2_event_time32 vs. > v4l2_event32_time32 is a bit confusing. Do I understand correctly that > the code below runs for the non-compat

[PATCH] fs/exec: fix typos and sentence disorder

2021-03-18 Thread Xiaofeng Cao
change 'backwords' to 'backwards' change 'and argument' to 'an argument' change 'visibile' to 'visible' change 'wont't' to 'won't' reorganize sentence Signed-off-by: Xiaofeng Cao --- fs/exec.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/fs/exec.c

[PATCH net] net: cdc-phonet: fix data-interface release on probe failure

2021-03-18 Thread Johan Hovold
Set the disconnected flag before releasing the data interface in case netdev registration fails to avoid having the disconnect callback try to deregister the never registered netdev (and trigger a WARN_ON()). Fixes: 87cf65601e17 ("USB host CDC Phonet network interface driver") Signed-off-by:

Re: [PATCH 08/10] MIPS: disable CONFIG_IDE in malta*_defconfig

2021-03-18 Thread Thomas Bogendoerfer
On Thu, Mar 18, 2021 at 05:57:04AM +0100, Christoph Hellwig wrote: > arch/mips/configs/malta_kvm_guest_defconfig | 3 --- that file is gone in mips-next. I could take all MIPS patches into mips-next, if you want... Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not

Re: [PATCH v3 2/2] crypto: qat: ADF_STATUS_PF_RUNNING should be set after adf_dev_init

2021-03-18 Thread Giovanni Cabiddu
On Fri, Mar 12, 2021 at 11:22:03AM -0500, Tong Zhang wrote: > ADF_STATUS_PF_RUNNING is (only) used and checked by adf_vf2pf_shutdown() > before calling adf_iov_putmsg()->mutex_lock(vf2pf_lock), however the > vf2pf_lock is initialized in adf_dev_init(), which can fail and when it > fail, the

Re: [PATCH 2/3] KVM: x86: guest debug: don't inject interrupts while single stepping

2021-03-18 Thread Jan Kiszka
[only saw this now, or delivery to me was delayed - anyway] On 16.03.21 19:02, Maxim Levitsky wrote: > On Tue, 2021-03-16 at 18:01 +0100, Jan Kiszka wrote: >> On 16.03.21 17:50, Sean Christopherson wrote: >>> On Tue, Mar 16, 2021, Maxim Levitsky wrote: On Tue, 2021-03-16 at 16:31 +0100, Jan

Re: [PATCH net-next v2 2/4] net: ipa: use upper_32_bits()

2021-03-18 Thread Florian Fainelli
On 3/18/2021 6:51 AM, Alex Elder wrote: > Use upper_32_bits() to extract the high-order 32 bits of a DMA > address. This avoids doing a 32-position shift on a DMA address > if it happens not to be 64 bits wide. > > Suggested-by: Florian Fainelli > Signed-off-by: Alex Elder > --- > v2: -

<    1   2   3   4   5   6   7   8   9   10   >