Re: [PATCH] net/core/flow.c: compare data with memcmp

2006-12-31 Thread Daniel Marjamäki
Hello! So you mean that in this particular case it's faster with a handcoded comparison than memcmp? Because both key1 and key2 are located at word-aligned addresses? That's fascinating. Best regards, Daniel 2006/12/31, David Miller <[EMAIL PROTECTED]>: From: "Daniel_Marjamäki" <[EMAIL

Re: Happy New Year (and v2.6.20-rc3 released)

2006-12-31 Thread Cyrill V. Gorcnov
On Monday 01 January 2007 04:19, you wrote: | | In order to not get in trouble with MADR ("Mothers Against Drunk | Releases") I decided to cut the 2.6.20-rc3 release early rather than wait | for midnight, because it's bound to be new years _somewhere_ out there. So | here's to a happy

Re: [patch] remove MAX_ARG_PAGES

2006-12-31 Thread Ollie Wild
On 12/29/06, Ingo Molnar <[EMAIL PROTECTED]> wrote: what is keeping this fix from going upstream? There are still a couple outstanding issues which need to be resolved before this is ready for inclusion in the mainline kernel. The main one is support for CONFIG_STACK_GROWSUP, which I think

Re: [PATCH] [DISCUSS] Make the variable NULL after freeing it.

2006-12-31 Thread Amit Choudhary
--- Ingo Oeser <[EMAIL PROTECTED]> wrote: > On Sunday, 31. December 2006 14:38, Bernd Petrovitsch wrote: > > That depends on the decision/definition if (so called) "double free" is > > an error or not (and "free(NULL)" must work in POSIX-compliant > > environments). > > A double free of

Re: [PATCH] Documentation: Explain a second alternative for multi-line macros.

2006-12-31 Thread Randy Dunlap
Segher Boessenkool wrote: #define setcc(cc) ({ \ partial_status &= ~(SW_C0|SW_C1|SW_C2|SW_C3); \ partial_status |= (cc) & (SW_C0|SW_C1|SW_C2|SW_C3); }) This _does_ return a value though, bad example. Where does it return a value? partial_status |= as I expected (or suspected). I

Re: [PATCH] Make JFFS depend on CONFIG_BROKEN

2006-12-31 Thread Josh Boyer
On 12/30/06, Adrian Bunk <[EMAIL PROTECTED]> wrote: On Mon, Dec 18, 2006 at 07:25:56AM -0600, Josh Boyer wrote: > + NOTE: This filesystem is deprecated and is scheduled for removal in > + 2.6.21. See Documentation/feature-removal-schedule.txt >... $ grep -i jffs

Re: [PATCH] Documentation: Explain a second alternative for multi-line macros.

2006-12-31 Thread Segher Boessenkool
#define setcc(cc) ({ \ partial_status &= ~(SW_C0|SW_C1|SW_C2|SW_C3); \ partial_status |= (cc) & (SW_C0|SW_C1|SW_C2|SW_C3); }) This _does_ return a value though, bad example. Where does it return a value? partial_status |= I don't see any uses of it Ah, that's a separate thing

Re: [PATCH] Open Firmware device tree virtual filesystem

2006-12-31 Thread Segher Boessenkool
Some comments, mostly coding style: - 0xb0 - 0x13f Free. Add more parameters here if you really need them. + 0xb0 16 bytes Open Firmware information (magic, version, callback, idt) Is there an OF ISA binding for x86 somewhere? And don't point me to the source code, I'd like to

Re: [PATCH] Open Firmware device tree virtual filesystem

2006-12-31 Thread Segher Boessenkool
I would not exactly call what we have for powerpc "exporting the OFW device tree". I don't quite know what it is, but it isn't as simple as exporting the OFW device tree. I don't think we really wanted to get into any of that here. The Linux PowerPC port uses an OF-like device tree on *every*

Re: [PATCH] Open Firmware device tree virtual filesystem

2006-12-31 Thread David Kahn
Folks, If we reused the current code in fs/proc/proc_devtree.c and re-wrote the underlying of_* routines for i386 only, (in the hope of removing the complexity not needed for this implementation) would that be an acceptable implementation? In other words, the of_* routines continue to define

Re: [PATCH] Open Firmware device tree virtual filesystem

2006-12-31 Thread Segher Boessenkool
+A regular file in ofwfs contains the exact byte sequence that +comprises the OFW property value. Properties are not reformatted +into text form, so numeric property values appear as binary +integers. While this is inconvenient for viewing, it is generally +easier for programs that read

Re: [PATCH] Documentation: Explain a second alternative for multi-line macros.

2006-12-31 Thread Randy Dunlap
Segher Boessenkool wrote: In this case, the second form should be used when the macro needs to return a value (and you can't use an inline function for whatever reason), whereas the first form should be used at all other times. that's a fair point, although it's certainly not the coding style

Re: [PATCH] Open Firmware device tree virtual filesystem

2006-12-31 Thread Segher Boessenkool
All we've done is created a trivial implementation for exporting the device tree to userland that isn't burdened by the powerpc and sparc legacy code that's in there now. So now we'll have _3_ different implementations of exporting the OFW device tree via procfs. Your's, the proc_devtree of

Re: [PATCH] include/linux/slab.h: new KFREE() macro.

2006-12-31 Thread Segher Boessenkool
+#define KFREE(x) \ + do {\ + kfree(x); \ + x = NULL; \ + } while(0) This doesn't work correctly if "x" has side effects -- double evaluation. Use a temporary variable instead, or better, an inline function.

BUG: scheduling while atomic on 2.6.20-rc2-git1 on x86-64

2006-12-31 Thread Aaron Sethman
Got the following trace on 2.6.20-rc2-git2 on x86-64. Let me know if there is additional details that is needed. -Aaron BUG: scheduling while atomic: hald-addon-stor/0x2000/2902 Call Trace: [] __sched_text_start+0x5d/0x834 [] __wake_up+0x43/0x70 [] scsi_done+0x0/0x20 []

Re: Finding hardlinks

2006-12-31 Thread Nikita Danilov
Mikulas Patocka writes: > > > On Fri, 29 Dec 2006, Trond Myklebust wrote: > > > On Thu, 2006-12-28 at 19:14 +0100, Mikulas Patocka wrote: > >> Why don't you rip off the support for colliding inode number from the > >> kernel at all (i.e. remove iget5_locked)? > >> > >> It's reasonable

Re: [BUG 2.6.20-rc2-mm1] init segfaults when CONFIG_PROFILE_LIKELY=y

2006-12-31 Thread Fengguang Wu
On Sun, Dec 31, 2006 at 11:45:09AM -0800, Daniel Walker wrote: > On Sun, 2006-12-31 at 23:04 +0800, Fengguang Wu wrote: > > Hi, > > > > The following messages keeps popping up when CONFIG_PROFILE_LIKELY=y: > > > > init[1]: segfault at 8118c110 rip 8118c110 rsp > >

Re: Happy New Year (and v2.6.20-rc3 released)

2006-12-31 Thread Alexey Dobriyan
On Sun, Dec 31, 2006 at 05:19:44PM -0800, Linus Torvalds wrote: > Alexey Dobriyan (2): > V4L/DVB (5012): Usbvision fix: It was using "&&" instead "&" > fuse: fix typo Second is from Thomas Hisch <[EMAIL PROTECTED]>, actually. - To unsubscribe from this list: send the line

Re: [PATCH] Documentation: Explain a second alternative for multi-line macros.

2006-12-31 Thread Segher Boessenkool
In this case, the second form should be used when the macro needs to return a value (and you can't use an inline function for whatever reason), whereas the first form should be used at all other times. that's a fair point, although it's certainly not the coding style that's in play now. for

Re: Raid 0 Swap?

2006-12-31 Thread Bill Davidsen
Jan Engelhardt wrote: On Dec 28 2006 00:06, Mike Huber wrote: I would like to point out one key argument against raid0 swap partitions, which is that, should a drive failure occur, the least used programs in memory are most drastically affected. Unfortunately, in the case of a drastic drive

chaostables 0.2

2006-12-31 Thread Jan Engelhardt
Hi list(s), chaostables is a small package containing some nice netfilter magic: a module xt_portscan which matches the nmap scan types (including -sS) and more, and a xt_CHAOS module which slows down network scanners by triggering their codepaths for handling slow-working/'broken' operating

Re: replace "memset(...,0,PAGE_SIZE)" calls with "clear_page()"?

2006-12-31 Thread Folkert van Heusden
> > regarding alignment that don't allow clear_page() to be used > > copy_page() in the memcpy() case), but it's going to need a lot of Maybe these optimalisations should be in the coding style docs? Folkert van Heusden -- Ever wonder what is out there? Any alien races? Then please support

Re: Linux disk performance.

2006-12-31 Thread Bill Davidsen
Phillip Susi wrote: Bill Davidsen wrote: Quite honestly, the main place I have found O_DIRECT useful is in keeping programs doing large i/o quantities from blowing the buffers and making the other applications run like crap. If you application is running alone, unless you are very short of

Re: Happy New Year (and v2.6.20-rc3 released)

2006-12-31 Thread Gene Heskett
On Sunday 31 December 2006 20:19, Linus Torvalds wrote: >In order to not get in trouble with MADR ("Mothers Against Drunk >Releases") I decided to cut the 2.6.20-rc3 release early rather than > wait for midnight, because it's bound to be new years _somewhere_ out > there. So here's to a happy 2007

Re: [PATCH 2.6.20-rc2] Add a quirk to allow at least some ENE PCI SD card readers to work again

2006-12-31 Thread Pierre Ossman
Darren Salt wrote: > > (BTW, is there a version of Thunderbird which preserves Mail-Followup-To in > followups? I ask because I see that that header got lost...) > No idea, I'm just a user. ;) Its handling of Mail-Followup-To is generally rather annoying. It doesn't strip out my own email

Happy New Year (and v2.6.20-rc3 released)

2006-12-31 Thread Linus Torvalds
In order to not get in trouble with MADR ("Mothers Against Drunk Releases") I decided to cut the 2.6.20-rc3 release early rather than wait for midnight, because it's bound to be new years _somewhere_ out there. So here's to a happy 2007 for everybody. The big thing at least for me personally

Re: [PATCH] [DISCUSS] Make the variable NULL after freeing it.

2006-12-31 Thread YOSHIFUJI Hideaki / 吉藤英明
In article <[EMAIL PROTECTED]> (at Mon, 1 Jan 2007 01:43:00 +0100), Ingo Oeser <[EMAIL PROTECTED]> says: > On Sunday, 31. December 2006 14:38, Bernd Petrovitsch wrote: > > That depends on the decision/definition if (so called) "double free" is > > an error or not (and "free(NULL)" must work in

Re: [PATCH] [DISCUSS] Make the variable NULL after freeing it.

2006-12-31 Thread Ingo Oeser
On Sunday, 31. December 2006 14:38, Bernd Petrovitsch wrote: > That depends on the decision/definition if (so called) "double free" is > an error or not (and "free(NULL)" must work in POSIX-compliant > environments). A double free of non-NULL is certainly an error. So the idea of setting it to

[PATCH] include/linux/slab.h: new KFREE() macro.

2006-12-31 Thread Amit Choudhary
Description: new KFREE() macro to set the variable NULL after freeing it. Signed-off-by: Amit Choudhary <[EMAIL PROTECTED]> diff --git a/include/linux/slab.h b/include/linux/slab.h index 1ef822e..28da74c 100644 --- a/include/linux/slab.h +++ b/include/linux/slab.h @@ -75,6 +75,12 @@ void

Re: [PATCH 4/8] KVM: Implement a few system configuration msrs

2006-12-31 Thread Ingo Oeser
Hi, On Thursday, 28. December 2006 11:11, Avi Kivity wrote: > Index: linux-2.6/drivers/kvm/svm.c > === > --- linux-2.6.orig/drivers/kvm/svm.c > +++ linux-2.6/drivers/kvm/svm.c > @@ -1068,6 +1068,9 @@ static int

Re: [BUG 2.6.20-rc2-mm1] init segfaults when CONFIG_PROFILE_LIKELY=y

2006-12-31 Thread Randy Dunlap
On Sun, 31 Dec 2006 13:11:26 -0800 Daniel Walker wrote: > On Sun, 2006-12-31 at 12:43 -0800, Randy Dunlap wrote: > > On Sun, 31 Dec 2006 11:45:09 -0800 Daniel Walker wrote: > > > > > On Sun, 2006-12-31 at 23:04 +0800, Fengguang Wu wrote: > > > > Hi, > > > > > > > > The following messages keeps

Fwd: [patch 2.6.19-rc1] rtc-at91rm9200 build fix

2006-12-31 Thread David Brownell
Patch still needs merging ... BTW, glad to see googlegroups finally returns rtc-linux when I search for it ... :) -- Forwarded Message -- Subject: [patch 2.6.19-rc1] rtc-at91rm9200 build fix Date: Saturday 16 December 2006 3:38 pm From: David Brownell <[EMAIL PROTECTED]> To:

Re: Oops in 2.6.19.1

2006-12-31 Thread Alistair John Strachan
On Sunday 31 December 2006 21:43, Chuck Ebbert wrote: > In-Reply-To: <[EMAIL PROTECTED]> > > On Sat, 30 Dec 2006 18:29:15 +, Alistair John Strachan wrote: > > > Can you post disassembly of pipe_poll() for both the one that crashes > > > and the one that doesn't? Use 'objdump -D -r fs/pipe.o'

[PATCH 2.6.20-rc2] drivers/char/agp/sgi-agp.c: check kmalloc() return value.

2006-12-31 Thread Amit Choudhary
Description: Check the return value of kmalloc() in function agp_sgi_init(), in file drivers/char/agp/sgi-agp.c. Signed-off-by: Amit Choudhary <[EMAIL PROTECTED]> diff --git a/drivers/char/agp/sgi-agp.c b/drivers/char/agp/sgi-agp.c index d73be4c..5897e6c 100644 --- a/drivers/char/agp/sgi-agp.c

Re: Linux 2.6.16.37

2006-12-31 Thread Chuck Ebbert
In-Reply-To: <[EMAIL PROTECTED]> On Thu, 28 Dec 2006 14:53:08 +0100, Adrian Bunk wrote: > Changes since 2.6.16.36: > ... If you're not going to merge the critical x86 fixes I sent, I won't bother sending anything more. -- MBTI: IXTP - To unsubscribe from this list: send the line "unsubscribe

Re: Oops in 2.6.19.1

2006-12-31 Thread Chuck Ebbert
In-Reply-To: <[EMAIL PROTECTED]> On Sat, 30 Dec 2006 18:29:15 +, Alistair John Strachan wrote: > > Can you post disassembly of pipe_poll() for both the one that crashes > > and the one that doesn't? Use 'objdump -D -r fs/pipe.o' so we get the > > relocation info and post just the one

Re: ata1: spurious interrupt (irq_stat 0x8 active_tag -84148995 sactive 0x0) r0xj0

2006-12-31 Thread Andrew Lyon
On 12/28/06, Tejun Heo <[EMAIL PROTECTED]> wrote: Andrew Lyon wrote: > Hi, > > My system is gigabyte ds3 motherboard with onboard SATA JMicron > 20360/20363 AHCI Controller (rev 02), drive connected is WDC > WD740ADFD-00 20.0, I am running 2.6.18.6 32 bit, under heavy i/o I get > the following

Re: [PATCH] Open Firmware device tree virtual filesystem

2006-12-31 Thread Jan Engelhardt
On Dec 31 2006 12:45, David Miller wrote: >From: Jan Engelhardt <[EMAIL PROTECTED]> > >> BUT, the eeprom utility may be used to modify values, and if used, I >> would like to see ofwfs show the updated value. openpromfs does it >> today: >> >> 15:09 ares:/proc/openprom/options # cat oem-banner?

RE: [nfsv4] RE: Finding hardlinks

2006-12-31 Thread Halevy, Benny
Trond Myklebust wrote: > > On Thu, 2006-12-28 at 15:07 -0500, Halevy, Benny wrote: > > Mikulas Patocka wrote: > > > >BTW. how does (or how should?) NFS client deal with cache coherency if > > >filehandles for the same file differ? > > > > > > > Trond can probably answer this better than me...

RE: Finding hardlinks

2006-12-31 Thread Halevy, Benny
Trond Myklebust wrote: > > On Thu, 2006-12-28 at 17:12 +0200, Benny Halevy wrote: > > > As an example, some file systems encode hint information into the filehandle > > and the hints may change over time, another example is encoding parent > > information into the filehandle and then handles

Re: fuse, get_user_pages, flush_anon_page, aliasing caches and all that again

2006-12-31 Thread David Miller
From: Linus Torvalds <[EMAIL PROTECTED]> Date: Sun, 31 Dec 2006 12:58:45 -0800 (PST) > So there really is two different cases here: > > - flush the cache as seen by A PARTICULAR virtual mapping. > >This is ptrace, but it's other things like "unmap page from this VM" >too. > > -

Re: [BUG 2.6.20-rc2-mm1] init segfaults when CONFIG_PROFILE_LIKELY=y

2006-12-31 Thread Daniel Walker
On Sun, 2006-12-31 at 12:43 -0800, Randy Dunlap wrote: > On Sun, 31 Dec 2006 11:45:09 -0800 Daniel Walker wrote: > > > On Sun, 2006-12-31 at 23:04 +0800, Fengguang Wu wrote: > > > Hi, > > > > > > The following messages keeps popping up when CONFIG_PROFILE_LIKELY=y: > > > > > > init[1]: segfault

[PATCH] Simplify some code to use the container_of() macro.

2006-12-31 Thread Robert P. J. Day
Simplify a number of code snippets in source and header files to use the kernel.h "container_of()" macro. Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- and while we're at it, everybody can stop re-inventing the container_of() macro. :-) drivers/net/ppp_generic.c|2

Re: fuse, get_user_pages, flush_anon_page, aliasing caches and all that again

2006-12-31 Thread Linus Torvalds
On Sun, 31 Dec 2006, David Miller wrote: > > Even in the ptrace() case, you do want to flush all the other VMA's > that might be out there with an aliased cached copy in the cpu cache. I don't think that's necessarily true. If the same page is cached differently (and virtually) in multiple

Re: [BUG 2.6.20-rc2-mm1] init segfaults when CONFIG_PROFILE_LIKELY=y

2006-12-31 Thread Randy Dunlap
On Sun, 31 Dec 2006 11:45:09 -0800 Daniel Walker wrote: > On Sun, 2006-12-31 at 23:04 +0800, Fengguang Wu wrote: > > Hi, > > > > The following messages keeps popping up when CONFIG_PROFILE_LIKELY=y: > > > > init[1]: segfault at 8118c110 rip 8118c110 rsp > > 7fff9a9d14d8

Re: [PATCH] Open Firmware device tree virtual filesystem

2006-12-31 Thread David Miller
From: Christoph Hellwig <[EMAIL PROTECTED]> Date: Sun, 31 Dec 2006 15:41:03 + > On Sun, Dec 31, 2006 at 02:49:17AM -0800, David Miller wrote: > > Am I the only person who sees something very wrong with this? > > No, I completely agree with you on this. > > If firmworks really wants to have

Re: [PATCH] Open Firmware device tree virtual filesystem

2006-12-31 Thread David Miller
From: Jan Engelhardt <[EMAIL PROTECTED]> Date: Sun, 31 Dec 2006 15:12:26 +0100 (MET) > BUT, the eeprom utility may be used to modify values, and if used, I > would like to see ofwfs show the updated value. openpromfs does it > today: > > 15:09 ares:/proc/openprom/options # cat oem-banner? >

Re: compile failure on 2.6.19

2006-12-31 Thread Robin Cook
That fixed the problem. Thanks On Sun, 2006-12-31 at 10:27 -0800, David Brown wrote: > On 12/31/06, Robin Cook <[EMAIL PROTECTED]> wrote: > > I am getting this error when I try to compile 2.6.19 and 2.6.19.1. > > > > I ran make mrproper and make menuconfig then ran make and got the below > >

Re: fuse, get_user_pages, flush_anon_page, aliasing caches and all that again

2006-12-31 Thread David Miller
From: Miklos Szeredi <[EMAIL PROTECTED]> Date: Sun, 31 Dec 2006 13:24:53 +0100 > > I'm willing to do that - and I guess this means we can probably do this > > instead of walking the list of VMAs for the shared mapping, thereby > > hitting both anonymous and shared mappings with the same code? >

Re: [PATCH] net/core/flow.c: compare data with memcmp

2006-12-31 Thread David Miller
From: "Daniel_Marjamäki" <[EMAIL PROTECTED]> Date: Sun, 31 Dec 2006 17:37:05 +0100 > From: Daniel Marjamäki > This has been tested by me. > Signed-off-by: Daniel Marjamäki <[EMAIL PROTECTED]> Please do not do this. memcmp() cannot assume the alignment of the source and destination buffers and

Re: compile failure on 2.6.19

2006-12-31 Thread Ken Moffat
On Sun, Dec 31, 2006 at 10:27:26AM -0800, David Brown wrote: > On 12/31/06, Robin Cook <[EMAIL PROTECTED]> wrote: > >I am getting this error when I try to compile 2.6.19 and 2.6.19.1. > > > >I ran make mrproper and make menuconfig then ran make and got the below > >error. > > > > HOSTLD

Re: [PATCH] Documentation: Explain a second alternative for multi-line macros.

2006-12-31 Thread Robert P. J. Day
On Sun, 31 Dec 2006, Muli Ben-Yehuda wrote: > On Sun, Dec 31, 2006 at 02:49:48PM -0500, Robert P. J. Day wrote: > > > there would appear to be *lots* of cases where the ({ }) notation > > is used when nothing is being returned. i'm not sure you can be > > that adamant about that distinction at

Re: [PATCH] Documentation: Explain a second alternative for multi-line macros.

2006-12-31 Thread Randy Dunlap
On Sun, 31 Dec 2006 22:09:03 +0200 Muli Ben-Yehuda wrote: > On Sun, Dec 31, 2006 at 02:49:48PM -0500, Robert P. J. Day wrote: > > > there would appear to be *lots* of cases where the ({ }) notation is > > used when nothing is being returned. i'm not sure you can be that > > adamant about that

Re: [PATCH] Documentation: Explain a second alternative for multi-line macros.

2006-12-31 Thread Muli Ben-Yehuda
On Sun, Dec 31, 2006 at 02:49:48PM -0500, Robert P. J. Day wrote: > there would appear to be *lots* of cases where the ({ }) notation is > used when nothing is being returned. i'm not sure you can be that > adamant about that distinction at this point. IMHO, the main point of CodingStyle is to

Re: [PATCH] Documentation: Explain a second alternative for multi-line macros.

2006-12-31 Thread Robert P. J. Day
On Sun, 31 Dec 2006, Muli Ben-Yehuda wrote: > On Sun, Dec 31, 2006 at 02:32:25PM -0500, Robert P. J. Day wrote: > > > Generally, inline functions are preferable to macros resembling > > functions. > > This should be stressed, IMHO. We have too many macros which have no > reason to live. > > >

Re: [KJ] [PATCH] net/core/flow.c: compare data with memcmp

2006-12-31 Thread Nishanth Aravamudan
On 31.12.2006 [17:37:05 +0100], Daniel Marjam?ki wrote: > From: Daniel Marjamäki > This has been tested by me. > Signed-off-by: Daniel Marjamäki <[EMAIL PROTECTED]> > --- linux-2.6.20-rc2/net/core/flow.c 2006-12-27 09:59:56.0 +0100 > +++ linux/net/core/flow.c 2006-12-31

Re: [BUG 2.6.20-rc2-mm1] init segfaults when CONFIG_PROFILE_LIKELY=y

2006-12-31 Thread Daniel Walker
On Sun, 2006-12-31 at 23:04 +0800, Fengguang Wu wrote: > Hi, > > The following messages keeps popping up when CONFIG_PROFILE_LIKELY=y: > > init[1]: segfault at 8118c110 rip 8118c110 rsp > 7fff9a9d14d8 error 15 > init[1]: segfault at 8118c110 rip 8118c110 rsp

Re: [PATCH] Documentation: Explain a second alternative for multi-line macros.

2006-12-31 Thread Muli Ben-Yehuda
On Sun, Dec 31, 2006 at 02:32:25PM -0500, Robert P. J. Day wrote: > Generally, inline functions are preferable to macros resembling > functions. This should be stressed, IMHO. We have too many macros which have no reason to live. > -Macros with multiple statements should be enclosed in a do -

Re: [patch 2.6.20-rc1 0/6] arch-neutral GPIO calls

2006-12-31 Thread Kevin O'Connor
> Based on earlier discussion, I'm sending a refresh of the generic GPIO > patch, with several (ARM based) implementations in separate patches: Hi Dave, I'm very interested in seeing an abstraction for gpios. Over the last several months, I've been working on getting Linux running on my phone -

[PATCH] Documentation: Explain a second alternative for multi-line macros.

2006-12-31 Thread Robert P. J. Day
Add an explanation for defining multi-line macros using the ({ }) notation to CodingStyle. Signed-off-by: Robert P. J. Day <[EMAIL PROTECTED]> --- diff --git a/Documentation/CodingStyle b/Documentation/CodingStyle index 9069189..1d0ddb8 100644 --- a/Documentation/CodingStyle +++

Re: replace "memset(...,0,PAGE_SIZE)" calls with "clear_page()"?

2006-12-31 Thread Robert P. J. Day
On Mon, 1 Jan 2007, Paul Mundt wrote: > On Sat, Dec 30, 2006 at 06:04:14PM -0500, Robert P. J. Day wrote: > > fair enough. *technically*, not every call of the form > > "memset(ptr,0,PAGE_SIZE)" necessarily represents an address that's on > > a page boundary. but, *realistically*, i'm guessing

Re: [PATCH] Open Firmware device tree virtual filesystem

2006-12-31 Thread Mitch Bradley
I made all the changes Pekka suggested, except: + security = strncmp(propname, "security-", 9) == 0; + len = 0; Redundant assignment, no? + if (!security) + (void)callofw("getproplen", 2, 1, node, propname, ); That

Re: replace "memset(...,0,PAGE_SIZE)" calls with "clear_page()"?

2006-12-31 Thread Paul Mundt
On Sat, Dec 30, 2006 at 06:04:14PM -0500, Robert P. J. Day wrote: > fair enough. *technically*, not every call of the form > "memset(ptr,0,PAGE_SIZE)" necessarily represents an address that's on > a page boundary. but, *realistically*, i'm guessing most of them do. > just grabbing a random

Re: [PATCH 2.6.20-rc2] Add a quirk to allow ENE PCI SD card readers to work again

2006-12-31 Thread Darren Salt
I demand that I definitely did write... > Add a quirk to allow ENE PCI SD card readers to work again > Support for these devices was broken for 2.6.18-rc1 and later by commit > 146ad66eac836c0b976c98f428d73e1f6a75270d, which added voltage level > support. > This restores the previous behaviour

Re: compile failure on 2.6.19

2006-12-31 Thread David Brown
On 12/31/06, Robin Cook <[EMAIL PROTECTED]> wrote: I am getting this error when I try to compile 2.6.19 and 2.6.19.1. I ran make mrproper and make menuconfig then ran make and got the below error. HOSTLD scripts/kconfig/conf scripts/kconfig/conf -s arch/i386/Kconfig CHK

Re: [PATCH 1/1] Char: tty_wakeup cleanup

2006-12-31 Thread Tilman Schmidt
On Sat, 16 Dec 2006 23:17:00 +0100 (CET), Jiri Slaby wrote: > tty_wakeup cleanup > > - remove wake_up_interruptible(>write_wait) surrounding > tty_wakup(tty); > - substitute tty->ldisc.write_wakeup(tty) + wake_up() by tty_wakeup(tty); > > Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]>

Re: [KVM][PATCH] smp_processor_id() and sleeping functions used in invalid context

2006-12-31 Thread Luca
On 12/31/06, Avi Kivity <[EMAIL PROTECTED]> wrote: Luca Tettamanti wrote: > Hello, > I'm testing KVM on a Core2 CPU. I'm running kernel 2.6.20-git (pulled > few hours ago), configured with SMP and PREEMPT. > > I'm hitting 2 different warnings: > BUG: using smp_processor_id() in preemptible

compile failure on 2.6.19

2006-12-31 Thread Robin Cook
I am getting this error when I try to compile 2.6.19 and 2.6.19.1. I ran make mrproper and make menuconfig then ran make and got the below error. HOSTLD scripts/kconfig/conf scripts/kconfig/conf -s arch/i386/Kconfig CHK include/linux/version.h UPD include/linux/version.h /bin/sh:

Re: [KVM][PATCH] smp_processor_id() and sleeping functions used in invalid context

2006-12-31 Thread Avi Kivity
Luca Tettamanti wrote: Hello, I'm testing KVM on a Core2 CPU. I'm running kernel 2.6.20-git (pulled few hours ago), configured with SMP and PREEMPT. I'm hitting 2 different warnings: BUG: using smp_processor_id() in preemptible [0001] code: kvm/7726 caller is vmx_create_vcpu+0x9/0x2f

Re: replace "memset(...,0,PAGE_SIZE)" calls with "clear_page()"?

2006-12-31 Thread Arjan van de Ven
> arjan, you and i actually agree on this. i fully accept that the idea > of a "clear_page()" call might or should have extra semantics, > compared to the more simple and direct "memset(...,0,PAGE_SIZE)" call > (such as alignment requirements, for example). my observation is > simply that this

Re: [RFC] MTD driver for MMC cards

2006-12-31 Thread Matthieu CASTET
On Sun, 31 Dec 2006 13:32:18 +0100, Pierre Ossman wrote: > Arnd Bergmann wrote: > I'm a complete MTD noob, but what uses does the MTD layer have besides > JFFS2. If it's none, than this advantage isn't that big of a deal. > AFAIK MTD is for device where erase is need to managed in "software"

Re: fuse, get_user_pages, flush_anon_page, aliasing caches and all that again

2006-12-31 Thread Russell King
On Sun, Dec 31, 2006 at 01:24:53PM +0100, Miklos Szeredi wrote: > > I'm willing to do that - and I guess this means we can probably do this > > instead of walking the list of VMAs for the shared mapping, thereby > > hitting both anonymous and shared mappings with the same code? > > But for the

Using _syscall3 to manipulate files in a driver

2006-12-31 Thread Jon Smirl
I have the source code for a vendor written driver that is targeted at 2.6.9. It includes this and then proceeds to manipulate files from the driver. asmlinkage _syscall3(int,write,int,fd,const char *,buf,off_t,count) asmlinkage _syscall3(int,read,int,fd,char *,buf,off_t,count) asmlinkage

[PATCH 2.6.20-rc2] Add a quirk to allow ENE PCI SD card readers to work again

2006-12-31 Thread Darren Salt
Add a quirk to allow ENE PCI SD card readers to work again Support for these devices was broken for 2.6.18-rc1 and later by commit 146ad66eac836c0b976c98f428d73e1f6a75270d, which added voltage level support. This restores the previous behaviour for these devices by ensuring that when the voltage

Re: [PATCH 2.6.20-rc2] Add a quirk to allow at least some ENE PCI SD card readers to work again

2006-12-31 Thread Darren Salt
I demand that Pierre Ossman may or may not have written... > Darren Salt wrote: >> Add a quirk to allow at least some ENE PCI SD card readers to work again >> Support for these devices was broken for 2.6.18-rc1 and later by commit >> 146ad66eac836c0b976c98f428d73e1f6a75270d, which added voltage

[KVM][PATCH] smp_processor_id() and sleeping functions used in invalid context

2006-12-31 Thread Luca Tettamanti
Hello, I'm testing KVM on a Core2 CPU. I'm running kernel 2.6.20-git (pulled few hours ago), configured with SMP and PREEMPT. I'm hitting 2 different warnings: BUG: using smp_processor_id() in preemptible [0001] code: kvm/7726 caller is vmx_create_vcpu+0x9/0x2f [kvm_intel] []

Re: Open letter to Linux kernel developers (was Re: Binary Drivers)

2006-12-31 Thread Alan
> Why don't you release source? To protect the intellectual property. > Well, duh! That's why everyone holds back source. So allow me to > translate.. That IP story is for the most part not even credible. If they were worried about "software IP" they would release hardware docs and let us get

Re: Oops in 2.6.19.1

2006-12-31 Thread Alistair John Strachan
On Sunday 31 December 2006 16:27, Adrian Bunk wrote: > On Sat, Dec 30, 2006 at 04:59:35PM +, Alistair John Strachan wrote: > > On Thursday 28 December 2006 04:14, Alistair John Strachan wrote: > > > On Thursday 28 December 2006 04:02, Alistair John Strachan wrote: > > > > On Thursday 28

Re: Oops in 2.6.19.1

2006-12-31 Thread Alistair John Strachan
On Sunday 31 December 2006 16:28, Adrian Bunk wrote: > On Sat, Dec 30, 2006 at 06:29:15PM +, Alistair John Strachan wrote: > > On Saturday 30 December 2006 17:21, Chuck Ebbert wrote: > > > In-Reply-To: <[EMAIL PROTECTED]> > > > > > > On Sat, 30 Dec 2006 16:59:35 +, Alistair John Strachan

Re: replace "memset(...,0,PAGE_SIZE)" calls with "clear_page()"?

2006-12-31 Thread Robert P. J. Day
On Sun, 31 Dec 2006, Arjan van de Ven wrote: > On Sun, 2006-12-31 at 14:39 +0100, Folkert van Heusden wrote: > > > > i don't see how that can be true, given that most of the definitions > > > > of the clear_page() macro are simply invocations of memset(). see for > > > > yourself: > > > *MOST*.

[PATCH] net/core/flow.c: compare data with memcmp

2006-12-31 Thread Daniel Marjamäki
From: Daniel Marjamäki This has been tested by me. Signed-off-by: Daniel Marjamäki <[EMAIL PROTECTED]> --- linux-2.6.20-rc2/net/core/flow.c2006-12-27 09:59:56.0 +0100 +++ linux/net/core/flow.c 2006-12-31 18:26:06.0 +0100 @@ -144,29 +144,16 @@ typedef u32 flow_compare_t;

Re: [PATCH] Add Ultrabay support for the T60p Thinkpad

2006-12-31 Thread Henrique de Moraes Holschuh
Whoopie from ThinkWiki just sent me an email, calling my attention to the fact that the patch you submitted is in fact different from the one I merged... something I should have triple-verified. It appears the t60p has the bay in a different ACPI node than some other *60 ThinkPads. Either that,

Re: Oops in 2.6.19.1

2006-12-31 Thread Adrian Bunk
On Sat, Dec 30, 2006 at 06:29:15PM +, Alistair John Strachan wrote: > On Saturday 30 December 2006 17:21, Chuck Ebbert wrote: > > In-Reply-To: <[EMAIL PROTECTED]> > > > > On Sat, 30 Dec 2006 16:59:35 +, Alistair John Strachan wrote: > > > I've eliminated 2.6.19.1 as the culprit, and also

Re: Oops in 2.6.19.1

2006-12-31 Thread Adrian Bunk
On Sat, Dec 30, 2006 at 04:59:35PM +, Alistair John Strachan wrote: > On Thursday 28 December 2006 04:14, Alistair John Strachan wrote: > > On Thursday 28 December 2006 04:02, Alistair John Strachan wrote: > > > On Thursday 28 December 2006 02:41, Zhang, Yanmin wrote: > > > [snip] > > > > > >

Re: Suspend problems on 2.6.20-rc2-git1

2006-12-31 Thread Rafael J. Wysocki
On Sunday, 31 December 2006 14:27, Rafael J. Wysocki wrote: > On Sunday, 31 December 2006 09:15, Robert Hancock wrote: > > Having some suspend problems on 2.6.20-rc2-git1 with Fedora Core 6. > > First of all the normal user interface for hibernate isn't working > > properly while it did in

Re: [PATCH] Open Firmware device tree virtual filesystem

2006-12-31 Thread Christoph Hellwig
On Sun, Dec 31, 2006 at 02:49:17AM -0800, David Miller wrote: > From: David Kahn <[EMAIL PROTECTED]> > Date: Sun, 31 Dec 2006 02:11:53 -0800 > > > All we've done is created a trivial implementation for exporting > > the device tree to userland that isn't burdened by the powerpc > > and sparc

Re: kref refcnt and false positives

2006-12-31 Thread David Woodhouse
On Thu, 2006-12-21 at 09:01 +, Linux Kernel Mailing List wrote: > Gitweb: > http://git.kernel.org/git/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=f334b60b43a0927f4ab1187cbdb4582f5227c3b1 > Commit: f334b60b43a0927f4ab1187cbdb4582f5227c3b1 > Parent:

[BUG 2.6.20-rc2-mm1] init segfaults when CONFIG_PROFILE_LIKELY=y

2006-12-31 Thread Fengguang Wu
Hi, The following messages keeps popping up when CONFIG_PROFILE_LIKELY=y: init[1]: segfault at 8118c110 rip 8118c110 rsp 7fff9a9d14d8 error 15 init[1]: segfault at 8118c110 rip 8118c110 rsp 7fff9a9d14d8 error 15 init[1]: segfault at 8118c110 rip

Re: Finding hardlinks

2006-12-31 Thread Mikulas Patocka
On Wed, 20 Dec 2006, Al Viro wrote: On Wed, Dec 20, 2006 at 05:50:11PM +0100, Miklos Szeredi wrote: I don't see any problems with changing struct kstat. There would be reservations against changing inode.i_ino though. So filesystems that have 64bit inodes will need a specialized getattr()

Re: [OOPS] bcm43xx oops on 2.6.20-rc1 on x86_64

2006-12-31 Thread Larry Finger
Adrian Bunk wrote: > > To avoid any misunderstandings: > > This wasn't in any way meant against you personally. > > And in this case you were right, it was the same bug. > > My answer was based on experiences like one during 2.6.19-rc where we > had 4 bug reports for a regression with a patch

Re: [PATCH] Open Firmware device tree virtual filesystem

2006-12-31 Thread Jan Engelhardt
On Dec 30 2006 15:38, Mitch Bradley wrote: > > Request for comments. > > It is similar in some respect to fs/proc/proc_devtree.c , but does > not use procfs, nor does it require an intermediate layer of code > to create a flattened representation of the device tree. NB: openpromfs does not use

Re: VM: Fix nasty and subtle race in shared mmap'ed page writeback

2006-12-31 Thread Andrea Gelmini
On Sun, Dec 31, 2006 at 02:55:58PM +1100, Nick Piggin wrote: > This bug was only introduced in 2.6.19, due to a change that caused pte no, Linus said that with 2.6.19 it's easier to trigger this bug... > So if your corruption is years old, then it must be something else. > Maybe it is hidden by a

[ANNOUNCE] kvm-9 release

2006-12-31 Thread Avi Kivity
Changes from kvm-8: - API documentation (James Jacobsson) - More stabilization fixes (Yoshimi Ichiyanagi, Ingo Molnar, Nguyen Anh Quynh) - Interactivity improvements (Dor Laor) http://kvm.sourceforge.net -- error compiling committee.c: too many arguments to function - To unsubscribe from

Re: Oops in 2.6.19.1

2006-12-31 Thread Alistair John Strachan
On Saturday 30 December 2006 16:59, Alistair John Strachan wrote: > I have compiled GCC 3.4.6 and compiled 2.6.19 with an identical config > using this compiler (but the same binutils), and will report back if it > crashes. My bet is that it won't, however. Still fine after >24 hours. Linux

Re: replace "memset(...,0,PAGE_SIZE)" calls with "clear_page()"?

2006-12-31 Thread Arjan van de Ven
On Sun, 2006-12-31 at 14:39 +0100, Folkert van Heusden wrote: > > > i don't see how that can be true, given that most of the definitions > > > of the clear_page() macro are simply invocations of memset(). see for > > > yourself: > > *MOST*. Not all. > > For example an SSE version will at least

Re: [OOPS] bcm43xx oops on 2.6.20-rc1 on x86_64

2006-12-31 Thread Adrian Bunk
On Sat, Dec 30, 2006 at 04:45:21PM -0600, Larry Finger wrote: > Adrian Bunk wrote: > > On Sat, Dec 30, 2006 at 03:23:42PM -0600, Larry Finger wrote: > >> Adrian Bunk wrote: > >>> On Sun, Dec 17, 2006 at 03:15:28PM -0500, Aaron Sethman wrote: > Just was loading the bcm43xx module and got the

Re: [PATCH] [DISCUSS] Make the variable NULL after freeing it.

2006-12-31 Thread Bernd Petrovitsch
On Thu, 2006-12-28 at 09:54 +0100, Jan Engelhardt wrote: > On Dec 27 2006 17:10, Pavel Machek wrote: > > >> Was just wondering if the _var_ in kfree(_var_) could be set to > >> NULL after its freed. It may solve the problem of accessing some > >> freed memory as the kernel will crash since _var_

Re: replace "memset(...,0,PAGE_SIZE)" calls with "clear_page()"?

2006-12-31 Thread Folkert van Heusden
> > i don't see how that can be true, given that most of the definitions > > of the clear_page() macro are simply invocations of memset(). see for > > yourself: > *MOST*. Not all. > For example an SSE version will at least assume 16 byte alignment, etc > etc. What about an if (adress & 15) {

Re: Suspend problems on 2.6.20-rc2-git1

2006-12-31 Thread Rafael J. Wysocki
On Sunday, 31 December 2006 09:15, Robert Hancock wrote: > Having some suspend problems on 2.6.20-rc2-git1 with Fedora Core 6. > First of all the normal user interface for hibernate isn't working > properly while it did in 2.6.19. When you select "Hibernate" it seems to > stop X and go into

Re: [PATCH] Open Firmware device tree virtual filesystem

2006-12-31 Thread Pekka Enberg
On 12/31/06, Mitch Bradley <[EMAIL PROTECTED]> wrote: diff --git a/arch/i386/kernel/ofw_fs.c b/arch/i386/kernel/ofw_fs.c new file mode 100644 index 000..30ca359 --- /dev/null +++ b/arch/i386/kernel/ofw_fs.c @@ -0,0 +1,261 @@ +/* 1275 in little-endian ASCII (for IEEE 1275 - the Open Firmware

  1   2   3   >