[RFC 4/8]KVM: move gfn_to_page out of kmap/unmap pars

2007-07-22 Thread Shaohua Li
gfn_to_page might sleep with swap support. Move it out of the kmap calls. Signed-off-by: Shaohua Li <[EMAIL PROTECTED]> --- drivers/kvm/kvm.h |2 - drivers/kvm/kvm_main.c|9 ++--- drivers/kvm/mmu.c |2 - drivers/kvm/paging_tmpl.h | 80 +++-

[RFC 5/8]KVM: rmap readonly pages

2007-07-22 Thread Shaohua Li
Make shadow page table rmap readonly pages. Signed-off-by: Shaohua Li <[EMAIL PROTECTED]> --- drivers/kvm/mmu.c | 66 ++ drivers/kvm/paging_tmpl.h |2 - 2 files changed, 39 insertions(+), 29 deletions(-) Index: linux/drivers/kvm/mmu.c ===

[RFC 2/8]KVM: export several symbols kvm swap out needed

2007-07-22 Thread Shaohua Li
export symbols kvm swapout required Signed-off-by: Shaohua Li <[EMAIL PROTECTED]> Index: linux/mm/swap_state.c === --- linux.orig/mm/swap_state.c 2007-07-23 13:06:20.0 +0800 +++ linux/mm/swap_state.c 2007-07-23 13:29:1

Re: usb_serial_suspend(): buggy(?) code

2007-07-22 Thread Oliver Neukum
Am Montag 23 Juli 2007 schrieb Adrian Bunk: > Commit ec22559e0b7a05283a3413bda5d177e42c950e23 added the following > function to drivers/usb/serial/usb-serial.c: > [..] > > The Coverity checker spotted the inconsequent NULL checking for "serial". > > Looking at the code it also doesn't seem to h

[RFC 3/8]KVM: convert vm lock to a mutex

2007-07-22 Thread Shaohua Li
convert kvm lock to a mutex. TBD: after this change, a lot of logic in kvm can be simplified, eg, we don't need release lock and then do operation blocking. Signed-off-by: Shaohua Li <[EMAIL PROTECTED]> --- drivers/kvm/kvm.h |2 - drivers/kvm/kvm_main.c | 58 --

[PATCH] usb/atm: fix Kconfig garbage

2007-07-22 Thread Borislav Petkov
Hi there, I don't know whether this is the proper Kconfig-way to fix this but it works ok here. When entered, the menu point "USB DSL modem support" in menuconfig, path [Device Drivers->USB Support] shows no entries but "^@" instead. The following fixes it. Signed-off-by: Borislav Petkov

[RFC 0/8]KVM: swap out guest pages

2007-07-22 Thread Shaohua Li
This patch series make kvm guest pages be able to be swapped out and dynamically allocated. Without it, all guest memory is allocated at guest start time. patches are against latest git, and you need first patch Avi's kvm-sch integration patch (http://sourceforge.net/mailarchive/forum.php?thread_n

[RFC 1/8]KVM: fix bugs in kvm sched integration patch

2007-07-22 Thread Shaohua Li
fix some bugs in kvm-sch patch. 1. vmcs_readl/vmcs_writel are called with preempt enabled 2. preempt_count check doesn't make sense with preempt disabled 3. vmx_cpu_run doesn't handle error correctly and kvm_mmu_reload might sleep with mutex changes, so I move it above. Signed-off-by: Shaohua Li <

Re: [2.6.23 patch] xenbus_xs.c: fix a use-after-free

2007-07-22 Thread Jeremy Fitzhardinge
Adrian Bunk wrote: > This patch fixes an obvious use-after-free spotted by the Coverity checker. > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> > OK, thanks. J - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More m

Re: cmpxchg is not available to generic code

2007-07-22 Thread Nick Piggin
Dave Airlie wrote: On 7/19/07, Andrew Morton <[EMAIL PROTECTED]> wrote: On Thu, 19 Jul 2007 18:15:03 +1000 "Dave Airlie" <[EMAIL PROTECTED]> wrote: > Maybe we could add CONFIG_HAVE_CMPXCHG and let DRM depend on it.. That would certainly be better than adding a sprinkle of architectures in DR

Re: drivers/net/xen-netfront.c: bogus code

2007-07-22 Thread Jeremy Fitzhardinge
Adrian Bunk wrote: > The Coverity checker spotted the following bogus code > in drivers/net/xen-netfront.c: > > <-- snip --> > > ... > static void xennet_alloc_rx_buffers(struct net_device *dev) > { > ... > for (nr_flips = i = 0; ; i++) { > skb = __skb_dequeue(&np->rx_batc

Re: [BUG] firewire: mass-storage i/o-problems

2007-07-22 Thread Manuel Lauss
Hello, On Mon, Jul 23, 2007 at 01:34:11AM +0200, Stefan Richter wrote: > > Software: > > Kernel Vanilla 2.6.22, gcc 4.1.2. > > > > On another PC same problem, but replugging one or two times get the thing > > working. > > Which controller does this other PC have? I too experience these bu

Re: [PATCH] Move --build-id option

2007-07-22 Thread Sam Ravnborg
On Sun, Jul 22, 2007 at 11:14:46PM -0700, Roland McGrath wrote: > > My original makefile patch to use ld --build-id wound up using it in too > many places. We want it only for the .ko and vmlinux links (and vmlinux > temporary links that determine the vmlinux layout). > > Signed-off-by: Roland M

Re: Problems with timerfd()

2007-07-22 Thread Andrew Morton
On Sun, 22 Jul 2007 23:38:26 -0700 Andrew Morton <[EMAIL PROTECTED]> wrote: > > Davide has already submitted a patch to you to make read() from a timerfd > > file descriptor return an 8 byte integer, and I understand it to have been > > accepted into -mm. > > argh. Nobody told me it was an ABI c

Re: [GIT PULL] Trivial sh64 updates for 2.6.23-rc1

2007-07-22 Thread Jan Dittmer
Paul Mundt wrote: On Sun, Jul 22, 2007 at 06:39:08PM +0200, Jan Dittmer wrote: Paul Mundt wrote: It's known that empty objects require explicit tuning for the ABI, however, this has never been anything that was fatal. If you flip something on within each of those subsystems, does the error go a

Re: Problems with timerfd()

2007-07-22 Thread Andrew Morton
On Mon, 23 Jul 2007 08:32:29 +0200 Michael Kerrisk <[EMAIL PROTECTED]> wrote: > Andrew, > > The timerfd() syscall went into 2.6.22. While writing the man page for > this syscall I've found some notable limitations of the interface, and I am > wondering whether you and Linus would consider having

Re: [PATCH][22/37] Clean up duplicate includes in include/linux/memory_hotplug.h

2007-07-22 Thread Yasunori Goto
Oops. This should be Thanks! Acked-by: Yasunori Goto <[EMAIL PROTECTED]> > Hi, > > This patch cleans up duplicate includes in > include/linux/memory_hotplug.h > > > Signed-off-by: Jesper Juhl <[EMAIL PROTECTED]> > --- > > diff --git a/include/linux/memory_hotplug.h b/include/linu

Re: "build-id" changes break sparc64

2007-07-22 Thread Sam Ravnborg
On Mon, Jul 23, 2007 at 04:13:21PM +1000, Paul Mackerras wrote: > Roland McGrath writes: > > > It turns out the problem here is that some .o files wind up with their own > > .note.gnu.build-id sections. I got the makefile magic wrong, thinking that > > LDFLAGS_MODULE was a variable specifically f

Problems with timerfd()

2007-07-22 Thread Michael Kerrisk
Andrew, The timerfd() syscall went into 2.6.22. While writing the man page for this syscall I've found some notable limitations of the interface, and I am wondering whether you and Linus would consider having this interface fixed for 2.6.23. On the one hand, these fixes would be an ABI change, w

fallocate() man page

2007-07-22 Thread Michael Kerrisk
Amit, I've taken the page that you sent and made various minor formatting and wording fixes. I've also added various FIXMEs to the page. Some of these ("FIXME .") are things that I need to check up later. Some others are questions for which I need input from you, David, or someone else with the

Re: "build-id" changes break sparc64

2007-07-22 Thread Sam Ravnborg
On Sun, Jul 22, 2007 at 11:01:55PM -0700, Roland McGrath wrote: > It turns out the problem here is that some .o files wind up with their own > .note.gnu.build-id sections. I got the makefile magic wrong, thinking that > LDFLAGS_MODULE was a variable specifically for .ko links. Reading Documentati

Re: [PATCH] Fix fbcon - 'map_override' defined but not used warning

2007-07-22 Thread Antonino A. Daplas
On Sun, 2007-07-22 at 18:23 +0200, Gabriel C wrote: > Hi, > > I got this warning on current git: > > ... > > drivers/video/console/fbcon.c:130: warning: 'map_override' defined but not > used > > ... > > Signed-off-by: Gabriel Craciunescu <[EMAIL PROTECTED]> > > --- > > diff --git a/drivers/

keyboard not found in 2.6.22.1

2007-07-22 Thread Alan Curry
When I boot 2.6.22.1 on my PegasosPPC, the PS/2 keyboard is not detected. It works in 2.6.21.5. Both kernels have: CONFIG_KEYBOARD_ATKBD=y CONFIG_SERIO_I8042=y The 2.6.21.5 kernel logs this stuff during boot: serio: i8042 KBD port at 0x60,0x64 irq 1 serio: i8042 AUX port at 0x60,0x64 irq 12

[PATCH] Move --build-id option

2007-07-22 Thread Roland McGrath
My original makefile patch to use ld --build-id wound up using it in too many places. We want it only for the .ko and vmlinux links (and vmlinux temporary links that determine the vmlinux layout). Signed-off-by: Roland McGrath <[EMAIL PROTECTED]> --- Makefile |8 +++- sc

Re: "build-id" changes break sparc64

2007-07-22 Thread Paul Mackerras
Roland McGrath writes: > It turns out the problem here is that some .o files wind up with their own > .note.gnu.build-id sections. I got the makefile magic wrong, thinking that > LDFLAGS_MODULE was a variable specifically for .ko links. It's also used > in cmd_link_multi-m. Alan Modra (binutils

Re: Oops with touch and unknown uid [was Re: 2.6.22-rc6-mm1]

2007-07-22 Thread Andrew Morton
On Sun, 22 Jul 2007 23:48:14 +0200 "J.A. Magallón" <[EMAIL PROTECTED]> wrote: > On Thu, 28 Jun 2007 03:43:21 -0700, Andrew Morton <[EMAIL PROTECTED]> wrote: > > > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.22-rc6/2.6.22-rc6-mm1/ > > > > I have noticed a funny problem

Re: Linus 2.6.23-rc1

2007-07-22 Thread Jakub Jelinek
On Mon, Jul 23, 2007 at 01:31:00AM +0200, Andi Kleen wrote: > On Monday 23 July 2007 01:23:38 Andre Noll wrote: > > On 00:22, Andi Kleen wrote: > > > > /usr/bin/ld: section .text [ff700500 -> ff7007e3] > > > > overlaps section .gnu.version_d [ff7004d8 -> ff70050f] >

Re: vdso.so mislinked by buggy linker was Re: Linus 2.6.23-rc1

2007-07-22 Thread Jakub Jelinek
On Mon, Jul 23, 2007 at 01:56:20AM +0200, Andi Kleen wrote: > On Monday 23 July 2007 01:38:40 Andre Noll wrote: > [readded linux-kernel, Linus] > > > [Nr] Name Type Address Offset > >Size EntSize Flags Link Info Align > > [ 0]

Re: "build-id" changes break sparc64

2007-07-22 Thread Roland McGrath
It turns out the problem here is that some .o files wind up with their own .note.gnu.build-id sections. I got the makefile magic wrong, thinking that LDFLAGS_MODULE was a variable specifically for .ko links. It's also used in cmd_link_multi-m. So the problem David and Adrian saw is not actually

Fix compiling UML

2007-07-22 Thread Ulrich Drepper
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 The following patch is needed to get 2.6.23-rc1 to compile for UML on x86-64. Signed-off-by: Ulrich Drepper <[EMAIL PROTECTED]> diff --git a/arch/um/os-Linux/aio.c b/arch/um/os-Linux/aio.c index b126df4..9c70cb0 100644 - --- a/arch/um/os-Linux/aio.c

Re: 2.6.20->2.6.21 - networking dies after random time

2007-07-22 Thread Marcin Ślusarz
Ok, I've bisected this problem and found that this patch broke my NIC: 76d2160147f43f982dfe881404cfde9fd0a9da21 is first bad commit commit 76d2160147f43f982dfe881404cfde9fd0a9da21 Author: Ingo Molnar <[EMAIL PROTECTED]> Date: Fri Feb 16 01:28:24 2007 -0800 [PATCH] genirq: do not mask interr

Re: [linux-pm] Re: Hibernation considerations

2007-07-22 Thread david
On Mon, 23 Jul 2007, Nigel Cunningham wrote: Hi Alan. On Monday 23 July 2007 01:26:23 Alan Stern wrote: On Sun, 22 Jul 2007, Nigel Cunningham wrote: Hi. On Sunday 22 July 2007 02:13:56 Jeremy Maitin-Shepard wrote: It seems that you could still potentially get a failure to freeze if one FUS

Re: [linux-pm] Power Management framework proposal

2007-07-22 Thread david
On Sun, 22 Jul 2007, Arjan van de Ven wrote: On Sun, 2007-07-22 at 21:04 -0700, [EMAIL PROTECTED] wrote: this strategy should work well on the normal unpredictable workload that most people deal with, but there are some cases where the workload becomes pretty predictable (media players for exa

Re: [PATCH 3/3] readahead: scale max readahead size depending on memory size

2007-07-22 Thread Jens Axboe
On Sun, Jul 22 2007, Rik van Riel wrote: > Jens Axboe wrote: > >> I just wish you had a rationale behind them, I don't think it's that >> great of a series. I agree with the low point of 128k. Then it'd be sane >> to try and determine what the upper limit of ra window size goodness is, >> which is

Re: [PATCH] Optimize struct task_delay_info

2007-07-22 Thread Balbir Singh
Zhang, Yanmin wrote: > struct task_delay_info is used by per process block I/O delay statistics > feature which is useful in kernel. This struct is not optimized. > > My patch against kernel 2.6.22 shrinks it a half. > > 1) Delete blkio_start and blkio_end. As the collection happens in > io_sched

Re: [PATCH] Move KVM, paravirt, lguest, VMI and Xen under arch-level Virtualization option

2007-07-22 Thread Rusty Russell
On Sat, 2007-07-21 at 17:49 +0200, Jan Engelhardt wrote: > On Jul 20 2007 14:22, Rusty Russell wrote: > >Subject: [PATCH] Move KVM, paravirt, lguest, > >VMI and Xen under arch-level Virtualization option > > > >Any objections? > > Well btw, would it make sense to also rearrange the directory s

Re: Determine version of kernel that produced vmcore

2007-07-22 Thread Vivek Goyal
On Thu, Jul 19, 2007 at 12:39:15PM -0400, Don Zickus wrote: [..] > > I am not a big fan of this approach as it forces distros to require > kexec-tools when building a kernel. Even Joe Hacker who wants a custom > kernel (and not interested in kexec) would have to not only download the > kernel.src

Re: [linux-pm] Power Management framework proposal

2007-07-22 Thread Arjan van de Ven
On Sun, 2007-07-22 at 21:04 -0700, [EMAIL PROTECTED] wrote: > >> the fact that you want to run at the max frequancy for a given voltage is > > > > no I want to run at the max frequency PERIOD. On just about any PC, it's > > more power efficient to go full speed when executing code, and then idle >

Re: Power Management framework proposal

2007-07-22 Thread david
On Sun, 22 Jul 2007, Arjan van de Ven wrote: Date: Sun, 22 Jul 2007 21:00:39 -0700 From: Arjan van de Ven <[EMAIL PROTECTED]> To: [EMAIL PROTECTED] Cc: LKML , linux-pm <[EMAIL PROTECTED]> Subject: Re: Power Management framework proposal example 1: a laptop screen mode capacity power desc

Re: Linus 2.6.23-rc1

2007-07-22 Thread Greg KH
On Mon, Jul 23, 2007 at 10:23:17AM +0900, Paul Mundt wrote: > On Sun, Jul 22, 2007 at 02:04:24PM -0700, Linus Torvalds wrote: > > Lots of architecture updates (for just about all of them - x86[-64], arm, > > alpha, mips, ia64, powerpc, s390, sh, sparc, um..), lots of driver updates > > (again, al

Re: [linux-pm] Power Management framework proposal

2007-07-22 Thread david
On Sun, 22 Jul 2007, Arjan van de Ven wrote: I disagree with you here. for each frequency setting you can say how much power the cpu/system is expected to use (especially as a percentage of the full power mode). creating this value requires you to take two things into account, the voltage you ar

Re: Power Management framework proposal

2007-07-22 Thread Arjan van de Ven
> example 1: a laptop screen > > mode capacity power description > 000off > 1 100 100full brightness > 2 70 60half power to the backlight > 3 50 35quarter power to the backlight > 4 30 25eighth power to the backligh

Re: [linux-pm] Power Management framework proposal

2007-07-22 Thread Arjan van de Ven
> I disagree with you here. for each frequency setting you can say how much > power the cpu/system is expected to use (especially as a percentage of the > full power mode). creating this value requires you to take two things into > account, the voltage you are running things at (by far the bigg

Re: Power Management framework proposal

2007-07-22 Thread david
On Sun, 22 Jul 2007, Arjan van de Ven wrote: On Sun, 2007-07-22 at 11:56 -0700, [EMAIL PROTECTED] wrote: I have a concern with this approach though. It seems to assume that there is one global thing somewhere that sets the system state; in my experience that is the wrong approach; in fact ther

Re: [git patches] two warning fixes

2007-07-22 Thread Kyle Moffett
On Jul 19, 2007, at 14:04:29, Linus Torvalds wrote: On Thu, 19 Jul 2007, Krzysztof Halasa wrote: Jeff Garzik <[EMAIL PROTECTED]> writes: My overall goal is killing useless warnings that continually obscure real ones. Precisely, the goal should be to make must_check (and similar things) war

Re: [PATCH -rt] drop spurious rcu unlock

2007-07-22 Thread Paul E. McKenney
On Sun, Jul 22, 2007 at 10:22:37AM -0700, Daniel Walker wrote: > > Strange rcu_read_unlock() which causes a imbalance, and boot hang.. I > didn't notice a reason for it, and removing it allows my system to make > progress. > > This should go into the preempt-realtime-sched.patch Strange. I have

Re: [linux-pm] Re: Hibernation considerations

2007-07-22 Thread Nigel Cunningham
Hi. On Monday 23 July 2007 10:04:43 Paul Mackerras wrote: > Nigel Cunningham writes: > > > I guess I want to persist because all of these issues aren't utterly > > unsolvable. It's just that we don't have the infrastructure yet to > > figure out the solutions to these issues trivially. Take, for

Re: sound is interrupting with new kernels

2007-07-22 Thread [EMAIL PROTECTED]
Hi! Please run this script while using mplayer or audacious http://people.redhat.com/mingo/cfs-scheduler/tools/cfs-debug-info.sh No need. I'm testing now pure 2.6.22: my uname is 'Linux niam 2.6.22 #2 Sun Jul 22 13:52:03 EEST 2007 i686 Intel(R) Celeron(R) M processor 1.50GHz GenuineIntel GNU/L

Re: Linus 2.6.23-rc1

2007-07-22 Thread Gabriel C
allyesconfig has a lot 'Section mismatch' warnings ... LD vmlinux.o MODPOST vmlinux.o WARNING: vmlinux.o(.text+0x183): Section mismatch: reference to .init.text.1:start_kernel (between 'is386' and 'check_x87') WARNING: vmlinux.o(.data+0x4b38): Section mismatch: reference to .init.te

Re: [linux-pm] Power Management framework proposal

2007-07-22 Thread david
On Sun, 22 Jul 2007, Arjan van de Ven wrote: son anyway) I don't think you have got it right: the only info being passed is the standard cpufreq list of frequencies; everything else is part of the cpufreq driver. to make the decisions the software makeing the decision needs to know how much

Re: Linus 2.6.23-rc1

2007-07-22 Thread Gabriel C
Gabriel C wrote: [ fixed CC , sorry to that ] > Linus Torvalds wrote: >> Ok, right on time, two weeks afetr 2.6.22, there's a 2.6.23-rc1 out there. > > > ... > > drivers/char/hpet.c:76: warning: integer constant is too large for 'long' type > > ... > > Introduced by 0aa366f351d044703e25c8425e

Re: "build-id" changes break sparc64

2007-07-22 Thread David Miller
From: Roland McGrath <[EMAIL PROTECTED]> Date: Sun, 22 Jul 2007 01:59:40 -0700 (PDT) > Maybe: > > --- a/arch/sparc64/kernel/vmlinux.lds.S > +++ b/arch/sparc64/kernel/vmlinux.lds.S > @@ -19,6 +19,7 @@ SECTIONS > SCHED_TEXT > LOCK_TEXT > KPROBES_TEXT > +NOTES > *(.gnu.warnin

[PATCH] fault_inject: silence a warning

2007-07-22 Thread Stephen Rothwell
lib/fault-inject.c:168: warning: 'debugfs_create_ul_MAX_STACK_TRACE_DEPTH' defined but not used Signed-off-by: Stephen Rothwell <[EMAIL PROTECTED]> --- lib/fault-inject.c |4 1 files changed, 4 insertions(+), 0 deletions(-) -- Cheers, Stephen Rothwell[EMAIL PROTECT

usb_serial_suspend(): buggy(?) code

2007-07-22 Thread Adrian Bunk
Commit ec22559e0b7a05283a3413bda5d177e42c950e23 added the following function to drivers/usb/serial/usb-serial.c: <-- snip --> ... int usb_serial_suspend(struct usb_interface *intf, pm_message_t message) { struct usb_serial *serial = usb_get_intfdata(intf); struct usb_serial_por

Re: Linus 2.6.23-rc1

2007-07-22 Thread Adrian Bunk
On Sun, Jul 22, 2007 at 05:31:03PM -0700, Roland McGrath wrote: > > That's the Debian unstable package of binutils containing what was on > > 20070718 in the upstream binutils CVS (the version number comes from > > the upstream CVS). > > At what time on July 18? Before or after the commits I ma

Re: Linus 2.6.23-rc1

2007-07-22 Thread Paul Mundt
On Mon, Jul 23, 2007 at 03:27:21AM +0200, Gabriel C wrote: > Paul Mundt wrote: > > On Sun, Jul 22, 2007 at 02:04:24PM -0700, Linus Torvalds wrote: > >> Lots of architecture updates (for just about all of them - x86[-64], arm, > >> alpha, mips, ia64, powerpc, s390, sh, sparc, um..), lots of driver

Re: [DRIVER SUBMISSION] DRBD wants to go mainline

2007-07-22 Thread Kyle Moffett
Ok, I didn't have a chance to get through anywhere near all of it, but here's my comments so far. I didn't really go through things in any particular order but most of these comments are about your drbd_int.h header file. Hopefully a lot of the comments will be useful to fix similar/identical pro

Re: Linus 2.6.23-rc1

2007-07-22 Thread Gabriel C
Paul Mundt wrote: > On Sun, Jul 22, 2007 at 02:04:24PM -0700, Linus Torvalds wrote: >> Lots of architecture updates (for just about all of them - x86[-64], arm, >> alpha, mips, ia64, powerpc, s390, sh, sparc, um..), lots of driver updates >> (again, all over - usb, net, dvb, ide, sata, scsi, isdn

net/bluetooth/rfcomm/tty.c: use-after-free

2007-07-22 Thread Adrian Bunk
Commit 8de0a15483b357d0f0b821330ec84d1660cadc4e added the following use-after-free in net/bluetooth/rfcomm/tty.c: <-- snip --> ... static int rfcomm_dev_add(struct rfcomm_dev_req *req, struct rfcomm_dlc *dlc) { ... if (IS_ERR(dev->tty_dev)) { list_del(&dev->list);

Re: [patch] use __asm__ and __volatile__ in asm-x86_64/msr.h

2007-07-22 Thread H. Peter Anvin
Mike Frysinger wrote: > On Wednesday 20 June 2007, H. Peter Anvin wrote: >> Andi Kleen wrote: asm-i386/msr.h should not be exported to userspace at all, it contains nothing but kernel-internal helpers. >>> Actually rdtsc and rdtscll and potentially rdpmc which is in there can be >>> very

Re: Linus 2.6.23-rc1

2007-07-22 Thread Paul Mundt
On Sun, Jul 22, 2007 at 02:04:24PM -0700, Linus Torvalds wrote: > Lots of architecture updates (for just about all of them - x86[-64], arm, > alpha, mips, ia64, powerpc, s390, sh, sparc, um..), lots of driver updates > (again, all over - usb, net, dvb, ide, sata, scsi, isdn, infiniband, > firewi

Re: Linus 2.6.23-rc1

2007-07-22 Thread Gabriel C
Linus Torvalds wrote: > Ok, right on time, two weeks afetr 2.6.22, there's a 2.6.23-rc1 out there. > allmodconfig is broken ... drivers/misc/asus-laptop.c: In function 'asus_led_exit': drivers/misc/asus-laptop.c:1076: error: 'struct led_classdev' has no member named 'class_dev' drivers/misc/as

net/9p/mux.c: use-after-free

2007-07-22 Thread Adrian Bunk
The Coverity checker spotted the following use-after-free in net/9p/mux.c: <-- snip --> ... struct p9_conn *p9_conn_create(struct p9_transport *trans, int msize, unsigned char *extended) { ... if (!m->tagpool) { kfree(m);

Re: drivers/dma/ioatdma.c - address of '__this_module' will always evaluate as 'true' , warning

2007-07-22 Thread Gabriel C
Gabriel C wrote: > Hi, > > I got this warning on current git using gcc 4.2.1 : > > ... > > drivers/dma/ioatdma.c: In function 'ioat_init_module': > drivers/dma/ioatdma.c:816: warning: the address of '__this_module' will > always evaluate as 'true' > > ... > > > Regards, > > Gabriel C > [

Re: rtc-ds1307.c: array overrun

2007-07-22 Thread David Brownell
On Sunday 22 July 2007, Adrian Bunk wrote: > The Coverity checker spotted the following array overrun > in drivers/rtc/rtc-ds1307.c: Typo -- thanks, fix is attached. CUT HERE Fix a typo turned up by a Coverity check: referring to the wrong register, which could cause problems res

[2.6.23 patch] xenbus_xs.c: fix a use-after-free

2007-07-22 Thread Adrian Bunk
This patch fixes an obvious use-after-free spotted by the Coverity checker. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- --- linux-2.6.22-rc6-mm1/drivers/xen/xenbus/xenbus_xs.c.old 2007-07-23 03:04:20.0 +0200 +++ linux-2.6.22-rc6-mm1/drivers/xen/xenbus/xenbus_xs.c 2007-07-23 0

Re: [PATCH] Optimize struct task_delay_info

2007-07-22 Thread Zhang, Yanmin
On Wed, 2007-07-18 at 12:30 +0800, Zhang, Yanmin wrote: > On Wed, 2007-07-11 at 17:16 +0530, Balbir Singh wrote: > > Zhang, Yanmin wrote: > > > struct task_delay_info is used by per process block I/O delay statistics > > > feature which is useful in kernel. This struct is not optimized. > > > > >

xenbus_xs.c: use-after-free

2007-07-22 Thread Adrian Bunk
The Coverity checker spotted the following use-after-free in drivers/xen/xenbus/xenbus_xs.c: <-- snip --> ... static int process_msg(void) { ... if (IS_ERR(msg->u.watch.vec)) { kfree(msg); err = PTR_ERR(msg->u.watch.vec); ... <--

drivers/hwmon/lm93.c: array overruns

2007-07-22 Thread Adrian Bunk
The Coverity checker spotted the following array overruns in drivers/hwmon/lm93.c: <-- snip --> ... struct lm93_data { ... struct { u8 min; u8 max; } temp_lim[3]; ... }; ... static void lm93_update_client_common(struct lm93_data *data,

rtc-ds1307.c: array overrun

2007-07-22 Thread Adrian Bunk
The Coverity checker spotted the following array overrun in drivers/rtc/rtc-ds1307.c: <-- snip --> ... #define DS1337_REG_CONTROL 0x0e ... struct ds1307 { u8 reg_addr; u8 regs[8]; ... }; ... static int __devinit ds1307_probe(struct

Re: Problematic __attribute__((section(" "))) and gcc alignment

2007-07-22 Thread Denis Vlasenko
On Thursday 21 June 2007 21:32, Mathieu Desnoyers wrote: > Let's take arch/i386/boot/video.h as an example: > > it defines > > struct card_info { > const char *card_name; > int (*set_mode)(struct mode_info *mode); > int (*probe)(void); > struct mode_info *modes; >

sound/core/init.c - address of 'snd_shutdown_f_ops' will always evaluate as 'true' , warning

2007-07-22 Thread Gabriel C
Hi, I got this warning on current git using gcc 4.2.1: ... sound/core/init.c: In function 'snd_card_disconnect': sound/core/init.c:307: warning: the address of 'snd_shutdown_f_ops' will always evaluate as 'true' ... Regards, Gabriel C - To unsubscribe from this list: send the line "unsubscr

Re: 2.6.22-git17 boot failure

2007-07-22 Thread Tilman Schmidt
on Mon, 23 Jul 2007 01:47:30 +0200, /me wrote: > On my test machine with a Pentium D 940 processor, Intel DQ965GF > mainboard and SATA disks, kernel 2.6.22-git17 (32 bit build) fails > to come up because it cannot find the disk drives. Same issue > with a clone of the 'linus' git tree. Anything kno

Re: [patch] use __asm__ and __volatile__ in asm-x86_64/msr.h

2007-07-22 Thread Mike Frysinger
On Wednesday 20 June 2007, H. Peter Anvin wrote: > Andi Kleen wrote: > >> asm-i386/msr.h should not be exported to userspace at all, it contains > >> nothing but kernel-internal helpers. > > > > Actually rdtsc and rdtscll and potentially rdpmc which is in there can be > > very useful in user space

Re: voyager_{thread,cat}.c compile warnings

2007-07-22 Thread Cédric Augonnet
2007/7/22, James Bottomley <[EMAIL PROTECTED]>: On Sun, 2007-07-22 at 18:49 -0400, Cédric Augonnet wrote: > iff -urN a/arch/i386/mach-voyager/voyager_cat.c > b/arch/i386/mach-voyager/voyager_cat.c > --- /home/gonnet/tmp/linux-2.6.22/arch/i386/mach-voyager/voyager_cat.c 2007-07-20 11:50:17.0

Re: 2.6.22-git17 boot failure

2007-07-22 Thread Gabriel C
Tilman Schmidt wrote: > On my test machine with a Pentium D 940 processor, Intel DQ965GF > mainboard and SATA disks, kernel 2.6.22-git17 (32 bit build) fails > to come up because it cannot find the disk drives. Same issue > with a clone of the 'linus' git tree. Anything known? > Could you post th

2.6.23 regression: lpfc_sli.c: off-by-10

2007-07-22 Thread Adrian Bunk
The Coverity checker spotted the following off-by-10 in drivers/scsi/lpfc/lpfc_sli.c: <-- snip --> ... static int lpfc_sli_process_unsol_iocb(struct lpfc_hba *phba, struct lpfc_sli_ring *pring, struct lpfc_iocbq *saveq) { ... saveq->context3

Re: Linus 2.6.23-rc1

2007-07-22 Thread Roland McGrath
> That's the Debian unstable package of binutils containing what was on > 20070718 in the upstream binutils CVS (the version number comes from > the upstream CVS). At what time on July 18? Before or after the commits I made that day? You see, I can't tell from the information at hand. - To unsu

Re: [PATCH 3/3] x86_64: offset apicid_to_node before use it before init_cpu_to_node

2007-07-22 Thread Andi Kleen
> you will need to force every BIOS to have correct SRAT table. They are normally correct. I'm not aware of wrong SRAT tables in production systems. -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info a

RE: 2.6.22-git17 boot failure

2007-07-22 Thread Sid Boyce
Tilman Schmidt: wrote > On my test machine with a Pentium D 940 processor, Intel DQ965GF > mainboard and SATA disks, kernel 2.6.22-git17 (32 bit build) fails > to come up because it cannot find the disk drives. Same issue > with a clone of the 'linus' git tree. Anything known? I don't know if this

Re: Git tree for old kernels from before the current tree

2007-07-22 Thread Jon Smirl
On 7/22/07, Michael Tharp <[EMAIL PROTECTED]> wrote: H. Peter Anvin wrote: > Wouldn't be hard to make a git tree with all the patches all the way > back to 0.01 even... It'd be delightful from a completeness standpoint (and I do love completeness), but considering it already takes a good 20 minu

Re: sound is interrupting with new kernels

2007-07-22 Thread Michal Piotrowski
Hi, On 22/07/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: Hi to all! I have a problem with recent 2.6.22 kernel with cfs-19 patch. While I'm watching the video using mplayer or listening to the music using audacious the sound is interrupting rather often. During I'm watching the video I don

Re: early_printk accessing __log_buf

2007-07-22 Thread Paul Mundt
On Sun, Jul 22, 2007 at 07:50:47PM -0400, Mike Frysinger wrote: > On 7/18/07, Robin Getz <[EMAIL PROTECTED]> wrote: > >On Wed 18 Jul 2007 20:26, Andrew Morton pondered: > >> Robin Getz wrote: > >> > [need to access _log_buf from external for early debugging code] > >> > > >> > Something simple like

Re: Linus 2.6.23-rc1

2007-07-22 Thread Adrian Bunk
On Sun, Jul 22, 2007 at 04:51:30PM -0700, Roland McGrath wrote: > > I'm fairly sure this is already known about on SPARC64 (see David Miller's > > email ""build-id" changes break sparc64"), but I just thought I'd let > > people > > know the warnings are also visible on x86_64: > > > > "ld: warn

Re: Lots of scheduling bugs (?) with -rc1

2007-07-22 Thread Paul Mundt
On Sun, Jul 22, 2007 at 10:49:26PM +0100, Adrian McMenamin wrote: > [ 16.818606] Call trace: > [ 16.822686] [<8c00f782>] __cond_resched+0x1a/0x40 > [ 16.827589] [<8c15adf4>] cond_resched+0x30/0x48 > [ 16.832256] [<8c15b6ba>] mutex_lock+0xa/0x50 > [ 16.836656] [<8c00c4d8>] clear_user_page+

Re: [linux-pm] Re: Hibernation considerations

2007-07-22 Thread Paul Mackerras
Nigel Cunningham writes: > I guess I want to persist because all of these issues aren't utterly > unsolvable. It's just that we don't have the infrastructure yet to > figure out the solutions to these issues trivially. Take, for example, Ever heard of the halting problem? :) It's not just a matt

Re: Git tree for old kernels from before the current tree

2007-07-22 Thread Jon Smirl
On 7/22/07, Paul Mundt <[EMAIL PROTECTED]> wrote: Anyone still sending 2.4 patches with the intent of them being moved forward and applied to a current kernel needs to be killfiled. These patches are coming from companies that aren't interested in participating in the GPL process but are being

Re: Git tree for old kernels from before the current tree

2007-07-22 Thread Michael Tharp
H. Peter Anvin wrote: > Wouldn't be hard to make a git tree with all the patches all the way > back to 0.01 even... It'd be delightful from a completeness standpoint (and I do love completeness), but considering it already takes a good 20 minutes to clone the 2.6 tree over a respectable cable conn

vdso.so mislinked by buggy linker was Re: Linus 2.6.23-rc1

2007-07-22 Thread Andi Kleen
On Monday 23 July 2007 01:38:40 Andre Noll wrote: [readded linux-kernel, Linus] > [Nr] Name Type Address Offset >Size EntSize Flags Link Info Align > [ 0] NULL >

Re: [PATCH 3/3] readahead: scale max readahead size depending on memory size

2007-07-22 Thread Rik van Riel
Jens Axboe wrote: I just wish you had a rationale behind them, I don't think it's that great of a series. I agree with the low point of 128k. Then it'd be sane to try and determine what the upper limit of ra window size goodness is, which is probably impossible since it depends on the hardware a

Re: Linus 2.6.23-rc1

2007-07-22 Thread Roland McGrath
> I'm fairly sure this is already known about on SPARC64 (see David Miller's > email ""build-id" changes break sparc64"), but I just thought I'd let people > know the warnings are also visible on x86_64: > > "ld: warning: Cannot create .note.gnu.build-id section, --build-id ignored." I don't ha

Re: early_printk accessing __log_buf

2007-07-22 Thread Mike Frysinger
On 7/18/07, Robin Getz <[EMAIL PROTECTED]> wrote: On Wed 18 Jul 2007 20:26, Andrew Morton pondered: > Robin Getz wrote: > > [need to access _log_buf from external for early debugging code] > > > > Something simple like - early_copy_log_buff(void *dest, size_t n) > > > > copies n bytes from log_bu

Re: [patch 3/9] cpu: deliver CPU_UP_CANCELED only to NOTIFY_OKed callbacks with CPU_UP_PREPARE

2007-07-22 Thread Rusty Russell
On Mon, 2007-07-23 at 00:33 +0900, Akinobu Mita wrote: > plain text document attachment (cpuhotplug-nr-calls.patch) > From: Akinobu Mita <[EMAIL PROTECTED]> > > The functions in a CPU notifier chain is called with CPU_UP_PREPARE event > before making the CPU online. If one of the callback returns

Re: voyager_{thread,cat}.c compile warnings

2007-07-22 Thread James Bottomley
On Sun, 2007-07-22 at 18:49 -0400, Cédric Augonnet wrote: > iff -urN a/arch/i386/mach-voyager/voyager_cat.c > b/arch/i386/mach-voyager/voyager_cat.c > --- /home/gonnet/tmp/linux-2.6.22/arch/i386/mach-voyager/voyager_cat.c > 2007-07-20 11:50:17.0 -0400 > +++ linux-2.6.22/arch/i386/mach-voy

2.6.22-git17 boot failure

2007-07-22 Thread Tilman Schmidt
On my test machine with a Pentium D 940 processor, Intel DQ965GF mainboard and SATA disks, kernel 2.6.22-git17 (32 bit build) fails to come up because it cannot find the disk drives. Same issue with a clone of the 'linus' git tree. Anything known? -- Tilman Schmidt E-Mail

[ANNOUNCE][GIT PATCH 00/02 ] Kconfig.cpu cosmetics (resend)

2007-07-22 Thread Oliver Pinter
In this little patch is cosmetic in i386 and x86_64 Kconfig files. In first patch add the "Pentium D" for help, in second patch change the order, that logically simplifier when the cpu-s sorted by time-line. 01_add_pentium_d_for_kconfig_cpu.patch 02_change_cpu_order_in_Kconfig_cpu.patch arch/i38

[ANNOUNCE][GIT PATCH 01/02 ] Kconfig.cpu cosmetics (resend)

2007-07-22 Thread Oliver Pinter
01_add_pentium_d_for_kconfig_cpu.patch: arch/i386/Kconfig.cpu |6 +++--- arch/x86_64/Kconfig |6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) -- Thanks, Oliver commit 56c7bb5042008698752b7eb6abb8a28256867941 Author: Oliver Pinter <[EMAIL PROTECTED]> Date: Mon Jul 23 00:47:4

[ANNOUNCE][GIT PATCH 02/02 ] Kconfig.cpu cosmetics (resend)

2007-07-22 Thread Oliver Pinter
02_change_cpu_order_in_Kconfig_cpu.patch: arch/i386/Kconfig.cpu | 14 +++--- 1 files changed, 7 insertions(+), 7 deletions(-) -- Thanks, Oliver commit cefc467f037e374beecb825226294be014120509 Author: Oliver Pinter <[EMAIL PROTECTED]> Date: Mon Jul 23 01:06:06 2007 +0200 change CP

Re: Oops with touch and unknown uid [was Re: 2.6.22-rc6-mm1]

2007-07-22 Thread Randy Dunlap
On Sun, 22 Jul 2007 23:48:14 +0200 J.A. Magallón wrote: > On Thu, 28 Jun 2007 03:43:21 -0700, Andrew Morton <[EMAIL PROTECTED]> wrote: > > > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.22-rc6/2.6.22-rc6-mm1/ > > so is this 2.6.22-rc6-mm1 or is it as Oops says: 2.6.21

Re: [BUG] firewire: mass-storage i/o-problems

2007-07-22 Thread Stefan Richter
(quoting in full for linux1394-devel, Cc added) Andreas Messer wrote at LKML: > Hello, > > I tried the new firewire stack with a external harddisc and a external dvd > writer and get massive i/o problems. Here is the kernel output for the > harddisc. Please cc me for further questions. I hope i

  1   2   3   4   >