Re: [PATCH] virtio config_ops refactoring

2007-11-09 Thread Rusty Russell
On Saturday 10 November 2007 10:45:38 Anthony Liguori wrote: > The problem is the ABI. We can either require that PCI configuration > values are accessed with natural instructions, or it makes very little > sense to use the PCI configuration space for virtio configuration > information. To me it

Re: [PATCH 0/11 v3] enable "make ARCH=x86"

2007-11-09 Thread Sam Ravnborg
On Fri, Nov 09, 2007 at 10:23:23PM -0500, Jeff Garzik wrote: > Sam Ravnborg wrote: > >This is the patch that get rid of ARCH=i386 and ARCH=x86_64 > >and introduce ARCH=x86. > >It touches several files but the changes are all one or two-liners. > > > > x86: drop backward compatibility symlinks

Re: Module init call vs symbols exporting race?

2007-11-09 Thread Rusty Russell
On Friday 09 November 2007 23:16:47 Jan Glauber wrote: > On Fri, 2007-11-09 at 06:44 -0500, Jon Masters wrote: > > On Thu, 2007-11-08 at 13:10 +1100, Rusty Russell wrote: > > > On Wednesday 07 November 2007 21:01:30 Jan Glauber wrote: > > > > Hi Rusty, > > > > > > > > I've seen a symbol-resolving

Re: [PATCH] x86 - 32-bit ptrace emulation mishandles 6th arg

2007-11-09 Thread Andi Kleen
Roland McGrath <[EMAIL PROTECTED]> writes: > Sure has my ACK. > I never really understood why my old patch was not taken 2.5 years ago. If I remember correctly the old patch back then broke some programs, so it was reverted. It's certainly ugly that it leaks r9 internals to ptrace. Also it

Re: [PATCH 2/2] Version 11 (2.6.24-rc2) Smack: Simplified Mandatory Access Control Kernel

2007-11-09 Thread Eric Paris
[snip from fs/super.c:vfs_kern_mount() just for reference] if (data) { secdata = alloc_secdata(); if (!secdata) goto out_mnt; error = security_sb_copy_data(type, data, secdata); if (error)

Re: 2.6.24-rc2: Network commit causes SLUB performance regression with tbench

2007-11-09 Thread Nick Piggin
On Saturday 10 November 2007 12:29, Nick Piggin wrote: > cc'ed linux-netdev Err, make that 'netdev' :P > On Saturday 10 November 2007 10:46, Christoph Lameter wrote: > > commit deea84b0ae3d26b41502ae0a39fe7fe134e703d0 seems to cause a drop > > in SLUB tbench performance: > > > > 8p x86_64

Re: [patch 1/2] mm: page trylock rename

2007-11-09 Thread Nick Piggin
Here's a little something to make up for the occasional extra cacheline write in add_to_page_cache. Saves an atomic operation and 2 memory barriers for every add_to_page_cache(). I suspect lockdepifying the page lock will also barf without this, too... --- Setting and clearing the page locked

Re: [PATCH] Don't fail ata device revalidation for bad _GTF methods

2007-11-09 Thread Jeff Garzik
Matthew Garrett wrote: Experience suggests that the _GTF method may be bad. We currently fail device revalidation in that case, which seems excessive. Signed-off-by: Matthew Garrett <[EMAIL PROTECTED]> applied - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the

[patch 2/2] fs: buffer trylock rename

2007-11-09 Thread Nick Piggin
fs: rename buffer trylock Converting the buffer lock to new bitops also requires name change, so convert the raw test_and_set bitop to a trylock. Signed-off-by: Nick Piggin <[EMAIL PROTECTED]> --- fs/buffer.c |4 ++-- fs/jbd/commit.c |2 +- fs/jbd2/commit.c

[patch 1/2] mm: page trylock rename

2007-11-09 Thread Nick Piggin
Hi, OK minus the memory barrier changes for now. Can we possibly please get these into 2.6.24? -- mm: rename page trylock Converting page lock to new locking bitops requires a change of page flag operation naming, so we might as well convert it to something nicer (!TestSetPageLocked =>

Re: [PATCH] sata_nv,ahci: add the ahci legacy mode support to sata_nv

2007-11-09 Thread Jeff Garzik
Jeff Garzik wrote: The proposed sata_nv patch does the opposite -- guarantees we must support the continually problematic legacy IDE interface ad infinitum. Such patches are OK for the test lab, but in this specific case users /suffer/ when not running AHCI mode. Just to reinforce...

Re: [PATCH 1/2] NetLabel: Introduce a new kernel configuration API for NetLabel - Version 11 (2.6.24-rc2) Smack: Simplified Mandatory Access Control Kernel

2007-11-09 Thread James Morris
On Fri, 9 Nov 2007, Andrew Morton wrote: > On Thu, 08 Nov 2007 20:48:35 -0800 > Casey Schaufler <[EMAIL PROTECTED]> wrote: > > > From: Paul Moore <[EMAIL PROTECTED]> > > > > Add a new set of configuration functions to the NetLabel/LSM API so that > > LSMs can perform their own configuration of

cd/dvd inaccessible in 2.6.24-rc2

2007-11-09 Thread Will Trives
Hello, Motherboard: Gigabyte GA-P35-DS4 (rev. 1.1) Chipset: Intel P35 + ICH9R PATA port runs off JMicron controller CD/DVD Device: BENQ DW1640 16X I cannot access my dvd burner under 2.6.24-rc2, I have no problems under 2.6.23. Basically the drive is detected OK, everything looks ok but as

Re: [PATCH 0/11 v3] enable "make ARCH=x86"

2007-11-09 Thread Jeff Garzik
Brian Gerst wrote: Jeff Garzik wrote: Sam Ravnborg wrote: This is the patch that get rid of ARCH=i386 and ARCH=x86_64 and introduce ARCH=x86. It touches several files but the changes are all one or two-liners. x86: drop backward compatibility symlinks to i386/boot and x86_64/boot

Re: 2.6.24-rc2: Network commit causes SLUB performance regression with tbench

2007-11-09 Thread Nick Piggin
cc'ed linux-netdev On Saturday 10 November 2007 10:46, Christoph Lameter wrote: > commit deea84b0ae3d26b41502ae0a39fe7fe134e703d0 seems to cause a drop > in SLUB tbench performance: > > 8p x86_64 system: > > 2.6.24-rc2: > 1260.80 MB/sec > > After reverting the patch: > 2350.04 MB/sec

Re: [PATCH 6/6] MN10300: Add MTD flash support for the ASB2303 board [try #5]

2007-11-09 Thread David Woodhouse
Dunno why it's called "try #5" when I haven't directly received it even once yet. On Fri, 2007-11-09 at 15:35 +, David Howells wrote: > Add MTD flash support for the ASB2303 board. We're trying to avoid taking new simple map drivers -- you should be able to use a platform device instead. >

Re: [PATCH 0/11 v3] enable "make ARCH=x86"

2007-11-09 Thread Brian Gerst
Jeff Garzik wrote: > Sam Ravnborg wrote: >> This is the patch that get rid of ARCH=i386 and ARCH=x86_64 >> and introduce ARCH=x86. >> It touches several files but the changes are all one or two-liners. >> >> x86: drop backward compatibility symlinks to i386/boot and >> x86_64/boot >>

Re: [PATCH] sata_nv,ahci: add the ahci legacy mode support to sata_nv

2007-11-09 Thread Jeff Garzik
peer chen wrote: Yes, link - http://lkml.org/lkml/2007/10/8/93 add the AHCI legacy support to sata_nv when IDE/RAID mode been set in SBIOS and Device IDs are not in ahci.c at this moment. To do so, when a new chipset come out and DIDs haven't been submited to LKML,user still can use ahci driver

Re: [PATCH] Add quirk to set AHCI mode on ICH boards

2007-11-09 Thread Jeff Garzik
Theodore Tso wrote: On Fri, Nov 09, 2007 at 10:05:05PM -0500, Jeff Garzik wrote: By forcing AHCI, your PATA devices will be inaccessible, in a common configuration. It also means shuffling users from one driver to another, which induces breakage. I was speaking wishfully. Real life

Re: [PATCH, RFC] improved hacks to allow -rt to run kernbench on POWER

2007-11-09 Thread Nick Piggin
On Saturday 10 November 2007 07:52, Benjamin Herrenschmidt wrote: > > diff -urpNa -X dontdiff linux-2.6.23.1-rt4/arch/powerpc/kernel/process.c > > linux-2.6.23.1-rt4-fix/arch/powerpc/kernel/process.c --- > > linux-2.6.23.1-rt4/arch/powerpc/kernel/process.c2007-10-12 > > 09:43:44.0

Re: [PATCH] Add quirk to set AHCI mode on ICH boards

2007-11-09 Thread Theodore Tso
On Fri, Nov 09, 2007 at 10:05:05PM -0500, Jeff Garzik wrote: > By forcing AHCI, your PATA devices will be inaccessible, in a common > configuration. It also means shuffling users from one driver to another, > which induces breakage. > > I was speaking wishfully. Real life intrudes, alas. Not

Re: [PATCH 5/6] MN10300: Add the MN10300/AM33 architecture to the kernel [try #5]

2007-11-09 Thread Andrew Morton
On Fri, 09 Nov 2007 15:34:58 + David Howells <[EMAIL PROTECTED]> wrote: > Add architecture support for the MN10300/AM33 CPUs produced by MEI to the > kernel. hm, kprobes and gdb support. ho hum, I've seen worse-looking code ;). There's quite a bit of the usual stuff in there: use of

[GIT pull] x86 updates

2007-11-09 Thread Thomas Gleixner
Linus, please pull x86 updates from: ssh://master.kernel.org/pub/scm/linux/kernel/git/x86/linux-2.6-x86.git master Thanks, tglx Chuck Ebbert (1): x86 - 32-bit ptrace emulation mishandles 6th arg Randy Dunlap (1): voyager: use struct instead of PARAM Roland McGrath

Re: [PATCH 2/5] Watchdog: bfin_wdt, remove SPIN_LOCK_UNLOCKED

2007-11-09 Thread Mike Frysinger
On Nov 9, 2007 6:32 PM, Jiri Slaby <[EMAIL PROTECTED]> wrote: > bfin_wdt, remove SPIN_LOCK_UNLOCKED > > SPIN_LOCK_UNLOCKED is deprecated, use DEFINE_SPINLOCK instead thanks Signed-off-by: Mike Frysinger <[EMAIL PROTECTED]> -mike - To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH 0/11 v3] enable "make ARCH=x86"

2007-11-09 Thread Adrian Bunk
On Fri, Nov 09, 2007 at 10:23:23PM -0500, Jeff Garzik wrote: > Sam Ravnborg wrote: >> This is the patch that get rid of ARCH=i386 and ARCH=x86_64 >> and introduce ARCH=x86. >> It touches several files but the changes are all one or two-liners. >> >> x86: drop backward compatibility symlinks

Re: [PATCH 0/11 v3] enable "make ARCH=x86"

2007-11-09 Thread Randy Dunlap
On Fri, 09 Nov 2007 22:23:23 -0500 Jeff Garzik wrote: > Sam Ravnborg wrote: > > This is the patch that get rid of ARCH=i386 and ARCH=x86_64 > > and introduce ARCH=x86. > > It touches several files but the changes are all one or two-liners. > > > > x86: drop backward compatibility symlinks

Re: Laptop's HDD

2007-11-09 Thread Jeff Garzik
Maciej W. Rozycki wrote: On Sun, 4 Nov 2007, Alberto Gonzalez wrote: The problem comes from a very high rate of load/unload cycles of the heads that reaches the 300.000-600.000 limit in 2-3 years (with smartmontools it can checked it with "smartctl -A /dev/sda") . There are reports of HDD

Re: [PATCH 0/11 v3] enable "make ARCH=x86"

2007-11-09 Thread Jeff Garzik
Sam Ravnborg wrote: This is the patch that get rid of ARCH=i386 and ARCH=x86_64 and introduce ARCH=x86. It touches several files but the changes are all one or two-liners. x86: drop backward compatibility symlinks to i386/boot and x86_64/boot kbuild: sanity check the specified arch

Re: [PATCH] Add quirk to set AHCI mode on ICH boards

2007-11-09 Thread Jeff Garzik
Matthias Schniedermeyer wrote: And on the topic of "broken" BIOSes. I have a little empathy for the MB manufactures as non-RAID AHCI royaly screws Windos, so not supporting it reduces their support costs enough to overlook screwing the non-windos faction. non-RAID AHCI works just fine on

Re: [PATCH] Add quirk to set AHCI mode on ICH boards

2007-11-09 Thread Jeff Garzik
Alan Cox wrote: On Thu, 8 Nov 2007 22:46:22 -0500 Jeff Garzik <[EMAIL PROTECTED]> wrote: On Thu, Nov 08, 2007 at 10:29:37PM -0500, Mark Lord wrote: And I might even privately patch my own kernels to map the ACHI BAR in the cases where the BIOS didn't... The inability to do this in the

Re: [PATCH 1/2] create file_drop_write_access() helper

2007-11-09 Thread Erez Zadok
In message <[EMAIL PROTECTED]>, Dave Hansen writes: > > These should fix the bug that Erez Zadok <[EMAIL PROTECTED]> > reported: > > Stopping RPC idmapd: > > kernel: __fput() of writeable file with no mnt_want_write() > kernel: WARNING: at fs/file_table.c:262 __fput() > kernel: []

WARNING: at lib/kref.c:33 kref_get() (-mm 2007-11-06-02-32++)

2007-11-09 Thread Erez Zadok
Setup: FC6 system with MM snapshot broken-out-2007-11-06-02-32 and these two patches added: r-o-bind-mounts-track-number-of-mount-writer-fix-buggy-loop.patch r-o-bind-mounts-track-number-of-mount-writer-fix-buggy-loop-checkpatch-fixes.patch Booting the machine, waiting a few minutes (not logging

Re: [PATCH 5/24] smp x86 consolidation

2007-11-09 Thread Jeremy Fitzhardinge
Glauber de Oliveira Costa wrote: > > arch/x86/kernel/built-in.o: In function `native_smp_send_reschedule': > > /home/jeremy/hg/xen/paravirt/linux/arch/x86/kernel/smpcommon.c:262: > undefined reference to `genapic' > > arch/x86/kernel/built-in.o: In function `native_smp_call_function_mask': > >

Re:

2007-11-09 Thread Eric Dumazet
Luck, Tony a écrit : Just pulled latest git tree from Linus and a few ia64 configurations (anything with CONFIG_NUMA=y) won't build. The offending commit appears to be: 230140cffa7feae90ad50bf259db1fa07674f3a7 Here's the error messages from the compiler: CC [M]

Re: [PATCH 5/24] smp x86 consolidation

2007-11-09 Thread Glauber de Oliveira Costa
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jeremy Fitzhardinge escreveu: > Glauber de Oliveira Costa wrote: >> This patch consolidates part of the pieces of smp for both architectures. >> (i386 and x86_64). It makes part the calls go through smp_ops, and shares >> code for those functions in

Re: [PATCH 1/24] mm/sparse-vmemmap.c: make sure init_mm is included

2007-11-09 Thread Glauber de Oliveira Costa
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Jeremy Fitzhardinge escreveu: > Glauber de Oliveira Costa wrote: >> mm/sparse-vmemmap.c uses init_mm in some places. However, it is not >> present in any of the headers currently included in the file. >> >> init_mm is defined as extern in sched.h, so

[no subject]

2007-11-09 Thread Luck, Tony
Just pulled latest git tree from Linus and a few ia64 configurations (anything with CONFIG_NUMA=y) won't build. The offending commit appears to be: 230140cffa7feae90ad50bf259db1fa07674f3a7 Here's the error messages from the compiler: CC [M] drivers/infiniband/core/cma.o In file included

Re: [PATCH] make ds1wm driver to check ds1wm_platform_data pointer against NULL

2007-11-09 Thread Andrew Morton
On Fri, 9 Nov 2007 14:07:31 +0800 "eric miao" <[EMAIL PROTECTED]> wrote: > Do a sanity check for the "struct ds1wm_platform_data" pointer passed in > by the platform_device, and so to enforce each platform to provide a > valid structure. > > Signed-off-by: eric miao <[EMAIL PROTECTED]> > --- >

Re: 2.6.24-rc1 and 2.6.24.rc2 hangs while running udev on my laptop

2007-11-09 Thread Venki Pallipadi
On Fri, Nov 09, 2007 at 10:10:43AM -0800, Pallipadi, Venkatesh wrote: > > > >-Original Message- > >From: Andrew Morton [mailto:[EMAIL PROTECTED] > >Sent: Friday, November 09, 2007 2:03 AM > >To: SANGOI DINO LEONARDO > >Cc: linux-kernel@vger.kernel.org; Rafael J. Wysocki; Brown, >

Re: [PATCH 1/2] NetLabel: Introduce a new kernel configuration API for NetLabel - Version 11 (2.6.24-rc2) Smack: Simplified Mandatory Access Control Kernel

2007-11-09 Thread Andrew Morton
On Thu, 08 Nov 2007 20:48:35 -0800 Casey Schaufler <[EMAIL PROTECTED]> wrote: > From: Paul Moore <[EMAIL PROTECTED]> > > Add a new set of configuration functions to the NetLabel/LSM API so that > LSMs can perform their own configuration of the NetLabel subsystem without > relying on assistance

Re: [PATCH] uvesafb: Fix warnings about unused variables on non-x86

2007-11-09 Thread Andrew Morton
On Fri, 9 Nov 2007 00:08:19 +0100 Frank Lichtenheld <[EMAIL PROTECTED]> wrote: > Variables that are only used in #ifdef CONFIG_X86 should also > only be declared there. > > Signed-off-by: Frank Lichtenheld <[EMAIL PROTECTED]> > --- > drivers/video/uvesafb.c |6 -- > 1 files changed, 4

Re: [PATCH 5/24] smp x86 consolidation

2007-11-09 Thread Jeremy Fitzhardinge
Glauber de Oliveira Costa wrote: > This patch consolidates part of the pieces of smp for both architectures. > (i386 and x86_64). It makes part the calls go through smp_ops, and shares > code for those functions in smpcommon.c > > There's more room for code sharing here, but it is left as an

problem with x86-prepare-kprobes-code-for-unification.patch

2007-11-09 Thread Jeremy Fitzhardinge
Hi, This code in kprobes_64.c from x86-prepare-kprobes-code-for-unification.patch is problematic: +static __always_inline int is_IF_modifier(kprobe_opcode_t *insn) +{ + switch (*insn) { + case 0xfa: /* cli */ + case 0xfb: /* sti */ + case 0xcf:

Re: [PATCH] ehea: Add kdump support

2007-11-09 Thread Michael Neuling
> To support ehea driver reloading in a kdump kernel the driver has to > perform firmware handle deregistrations when the original kernel > crashes. As there's currently no notifier chain for machine crashes > this patch enables kdump support in the ehea driver by bending the >

Re: High priority tasks break SMP balancer?

2007-11-09 Thread Micah Dowty
On Sat, Nov 10, 2007 at 12:56:07AM +0100, Cyrus Massoumi wrote: > I tried your program on my machine (C2D, 2.6.17, O(1) scheduler). > > Both CPUs are 100% busy all the time. Each busy-looping thread is running > on its own CPU. I've been watching top output for 10 minutes, the spreading > is

Re: [PATCH] Add quirk to set AHCI mode on ICH boards

2007-11-09 Thread Matthias Schniedermeyer
On 09.11.2007 12:04, Alan Cox wrote: > On Thu, 8 Nov 2007 22:46:22 -0500 > Jeff Garzik <[EMAIL PROTECTED]> wrote: > > > On Thu, Nov 08, 2007 at 10:29:37PM -0500, Mark Lord wrote: > > > And I might even privately patch my own kernels to map the ACHI BAR > > > in the cases where the BIOS didn't...

Re: High priority tasks break SMP balancer?

2007-11-09 Thread Cyrus Massoumi
Hi Micah On my machine (2-way Opteron with a vanilla 2.6.23.1 kernel) this test program will reliably put the scheduler into a state where one CPU has both of the busy-looping processes in its runqueue, and the other CPU is usually idle. The usually-idle CPU will have a very high cpu_load, as

[RFC 13/13] Char: nozomi, cleanup read and write

2007-11-09 Thread Jiri Slaby
nozomi, cleanup read and write - remove macros testing for endianness, le*_to_cpu and complements will do it - pointers cleanup (no need to have different pointers for be and le) - put unlikely into reading/writing while loop, because it will proceed through this case only on last two bytes -

[RFC 11/13] Char: nozomi, remove unused includes

2007-11-09 Thread Jiri Slaby
nozomi, remove unused includes Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]> --- commit 1ab5d64fc4a2dd7a50b8971c67b9793511b4c47a tree d169718adab1aaf82ee655dc2048535eae3742a7 parent 2bd359aea85cf712d4d161a83e940fe5e1202ee8 author Jiri Slaby <[EMAIL PROTECTED]> Mon, 05 Nov 2007 15:25:18 +0100

[RFC 12/13] Char: nozomi, remove void acc char2 char3 more mp mp.c mp.yy m1 nozomi2 proto rej slock1 casts

2007-11-09 Thread Jiri Slaby
nozomi, remove void * casts Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]> --- commit 92ca82bcbd5dde95096dac24d0f6a9beab68e003 tree 748ac937f772410b364245897492b693491743f6 parent 1ab5d64fc4a2dd7a50b8971c67b9793511b4c47a author Jiri Slaby <[EMAIL PROTECTED]> Mon, 05 Nov 2007 15:28:46 +0100

[RFC 9/13] Char: nozomi, lock cleanup

2007-11-09 Thread Jiri Slaby
nozomi, lock cleanup - semaphore is deprecated, use mutex instead - don't return -ERESTARTSYS when signal might not be pending since it's not permitted (unknown retval mioght reach userspace) - don't lock interruptible in close or the card might not be stopped on last close Signed-off-by:

[RFC! 10/13] Char: nozomi, fix tty_flip_buffer_push

2007-11-09 Thread Jiri Slaby
Especially on this I would like to see feedback. Unlock and lock the spinlock just around the tty_flip_buffer_push would be much more easier, but won't it break anything? -- nozomi, fix tty_flip_buffer_push tty_flip_buffer_push call may deadlock when invoking it while holding spinlock used in

[RFC 7/13] Char: nozomi, remove struct irq

2007-11-09 Thread Jiri Slaby
nozomi, remove struct irq struct irq (named as my_irq) is used only in ISR and its called functions. We might silently use u16 variable on stack and remove all references to this structure. This is the first step of struct nozomi_devices removal. Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]>

[RFC 8/13] Char: nozomi, tty cleanup

2007-11-09 Thread Jiri Slaby
nozomi, tty cleanup - init and deinit tty driver at module load/unload. When the OS (user) loads the driver the hardware usually is ready to driver. - merge (unify) MAX_PORT, NTTY_TTY_MINORS into NOZOMI_MAX_PORTS - remove struct nozomi_devices, it was used only as list entries Signed-off-by:

2.6.24-rc2: Network commit causes SLUB performance regression with tbench

2007-11-09 Thread Christoph Lameter
commit deea84b0ae3d26b41502ae0a39fe7fe134e703d0 seems to cause a drop in SLUB tbench performance: 8p x86_64 system: 2.6.24-rc2: 1260.80 MB/sec After reverting the patch: 2350.04 MB/sec SLAB performance (which is at 2435.58 MB/sec, ~3% better than SLUB) is not affected by the

[RFC 6/13] Char: nozomi, reorder and cleanup probe, remove

2007-11-09 Thread Jiri Slaby
nozomi, reorder and cleanup probe, remove - remap space after requesting region, to not map something we cannot use anyway - init spin lock before request_irq, because due to shared irq debug, isr might be called immediately, where the lock is being held - remove INIT_LIST_HEAD before

[RFC 4/13] Char: nozomi, tty index cleanup

2007-11-09 Thread Jiri Slaby
nozomi, tty index cleanup - don't store unneeded copy of tty->index into port structure, tty->index is available everywhere - mod tty->index by MAX_PORT where expected (otherwise array index out of bounds) Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]> --- commit

[RFC 5/13] Char: nozomi, ioctls cleanup

2007-11-09 Thread Jiri Slaby
nozomi, ioctls cleanup - init tty_wait - don't forget to wake up tiocmiwait waiters - convert the whole tiocmiwait into wait_event_interruptible - don't check for cmd == TIOCGICOUNT in ntty_ioctl_tiocgicount, as it's expected to be it when we call the function, also pass internal structures

Re: SIS190.c

2007-11-09 Thread Francois Romieu
j gleacher <[EMAIL PROTECTED]> : [sorry for the delay, I was busy] > I'm not sure how to properly send you this information about subject, > but with a new Acer Desktop I needed to add 0x0968 to the below to > get the eth0 recognized. Ok. Can you check the patch below against 2.6.24-rc2 ? diff

Re: [PATCH 6/6] Char: riscom8, remove wakeup anf hangup bottomhalves

2007-11-09 Thread Alan Cox
On Fri, 9 Nov 2007 23:45:46 GMT Jiri Slaby <[EMAIL PROTECTED]> wrote: > riscom8, remove wakeup anf hangup bottomhalves > > Both of them may be called directly from the code, don't add special code > and variables and schedule a work for them. > > Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]>

[RFC 3/13] Char: nozomi, fix fail paths

2007-11-09 Thread Jiri Slaby
nozomi, fix fail paths Free resources on fail path in probe function properly (free_irq, remove_sysfs_files, kfifo_free, kfree(dc->send_buf) and atomic_dec). Also use kfifo_free instead of kfree on release function, because it leaked fifo->buffer. Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]>

Re: [PATCH] virtio config_ops refactoring

2007-11-09 Thread Anthony Liguori
Rusty Russell wrote: On Friday 09 November 2007 09:33:04 Anthony Liguori wrote: switch (addr) { case VIRTIO_BLK_CONFIG_MAX_SEG: return vdev->max_seg & 0xFF; case VIRTIO_BLK_CONFIG_MAX_SEG + 1: return (vdev->max_seg >> 8) & 0xFF; case VIRTIO_BLK_CONFIG_MAX_SEG + 2: return

[RFC 2/13] Char: nozomi, expand some functions

2007-11-09 Thread Jiri Slaby
nozomi, expand some functions nozomi_setup_interrupt and tty_do_close are used only in one place and has no pros of being in separate functions. move tty_do_close contents into ntty_close (it contained only tty_do_close call before) and nozomi_setup_interrupt (only request_irq) into

[RFC 1/13] Char: nozomi, remove unneded stuff

2007-11-09 Thread Jiri Slaby
Frank, could you comment (and test) following changes to the nozomi driver? I did them before you post the updated version and rediffed them a while ago, I hope I haven't done any mistake while doing it. Thanks. -- nozomi, remove unneded stuff - tty_termios* are set to tty struct, but

[PATCH 6/6] Char: riscom8, remove wakeup anf hangup bottomhalves

2007-11-09 Thread Jiri Slaby
riscom8, remove wakeup anf hangup bottomhalves Both of them may be called directly from the code, don't add special code and variables and schedule a work for them. Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]> Cc: Alan Cox <[EMAIL PROTECTED]> --- commit 9d50b0aba24ca0b601820663939987990db134c6

[PATCH 5/6] Char: serial167, remove bottomhalf

2007-11-09 Thread Jiri Slaby
serial167, remove bottomhalf - Cy_EVENT_OPEN_WAKEUP is simple wake_up - Cy_EVENT_HANGUP is wake_up + tty_hangup, which schedules its own work - Cy_EVENT_WRITE_WAKEUP is tty_wakeup which may be called directly too Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]> Cc: Alan Cox <[EMAIL PROTECTED]> ---

Re: [PATCH 3/7] Char: rocket, remove useless macros

2007-11-09 Thread Alan Cox
On Fri, 9 Nov 2007 18:36:08 -0500 Jiri Slaby <[EMAIL PROTECTED]> wrote: > rocket, remove useless macros > > Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]> Acked-by: Alan Cox <[EMAIL PROTECTED]> I'd just done some of that in my tree too. I have some other changes but they don't overlap (termios

[PATCH 4/6] Char: stallion, remove bottomhalf

2007-11-09 Thread Jiri Slaby
stallion, remove bottomhalf - tty_hangup schedules a bottomhalf itself, tty_wakeup doesn't need it - call the CD code (part of work handler previously) directly from the code (it wakes somebody up or calls tty_hangup at worse) Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]> Cc: Alan Cox <[EMAIL

Re: [PATCH 2/7] Char: rocket, printk cleanup

2007-11-09 Thread Alan Cox
> - printk(KERN_INFO "rp_do_receive(%d)...", ToRecv); > + printk(KERN_INFO "rp_do_receive(%d)...\n", ToRecv); The missing \n was intentional looking at the old code, and meant you got a lot of trace per line for debugging. The KERN_ additions are the breakage here. We might as well just

[PATCH 3/6] Char: specialix, remove bottomhalves

2007-11-09 Thread Jiri Slaby
specialix, remove bottomhalves - tqueue is used only for tty_wakeup, call it directly from the code - tqueue_hangup for tty_hangup, it schedules its own work, use it directly too Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]> Cc: Alan Cox <[EMAIL PROTECTED]> --- commit

[PATCH 2/6] Char: istallion, remove hangup bottomhalf

2007-11-09 Thread Jiri Slaby
istallion, remove hangup bottomhalf tty_hangup schedules a work for hangup itself, no need to do it in the driver. Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]> Cc: Alan Cox <[EMAIL PROTECTED]> --- commit d55ce2f15b7233e7a4e5e1880a656c4160b69866 tree bc00e50e40466542762f07c7a87811bad90f2e6d

[PATCH 1/6] Char: esp, remove hangup and wakeup bottomhalves

2007-11-09 Thread Jiri Slaby
esp, remove hangup and wakeup bottomhalves There is no need to schedule a bottomhalf for either of them. One is fast and the another schedules a bottomhalf itself. Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]> Cc: Alan Cox <[EMAIL PROTECTED]> --- commit ee7ef7fcd70a75d11d05429e5ac7ac31aca381b1

[PATCH 7/7] Char: riscom8, change rc_init_drivers prototype

2007-11-09 Thread Jiri Slaby
riscom8, change rc_init_drivers prototype Let compiler decide if the rc_init_drivers function will be inlined and mark it as __init, because it's called only from __init function. Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]> --- commit da1c9104ea38d0ca6e5ce0ee9be8cb6adff0ee71 tree

[PATCH 6/7] Char: stallion, fix compiler warnings

2007-11-09 Thread Jiri Slaby
stallion, fix compiler warnings Don't emit warnings on 64 bit platforms from min(). sizeof() on those is not uint, neither 2 pointers difference, cast it to uint by min_t in both cases. Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]> --- commit 7a411a4d1729e34bd7dc6697a8eedec7dd989c32 tree

[PATCH 5/7] Char: mxser_new, ioaddresses are ulong

2007-11-09 Thread Jiri Slaby
mxser_new, ioaddresses are ulong To not pass ulong address as int parameter, switch it to ulong. Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]> --- commit f412e3e0d4d012b7b57e381ae85ddfb1b5fc99bf tree 3c00698655cc3b6fd7a99139607578a34358093d parent d927dc37e63aa8347e596052615b85ff4936b3e2 author

[PATCH 3/7] Char: rocket, remove useless macros

2007-11-09 Thread Jiri Slaby
rocket, remove useless macros Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]> --- commit 585adae2019a87909ec738cbd414a330afbe04a8 tree cb170c8236ae0e49b81b50c305fa221aeb4315c2 parent c0e0b8a247ca469f85e51867fb11b5dbc19dace7 author Jiri Slaby <[EMAIL PROTECTED]> Sat, 20 Oct 2007 22:18:40 +0200

[PATCH 4/7] Char: char/serial, remove SERIAL_TYPE_NORMAL redefines

2007-11-09 Thread Jiri Slaby
char/serial, remove SERIAL_TYPE_NORMAL redefines Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]> Cc: Alan Cox <[EMAIL PROTECTED]> --- commit d927dc37e63aa8347e596052615b85ff4936b3e2 tree 0c62b277b0a1b414cd1ac911de0f65b0ebcfd216 parent 585adae2019a87909ec738cbd414a330afbe04a8 author Jiri Slaby

[PATCH 2/7] Char: rocket, printk cleanup

2007-11-09 Thread Jiri Slaby
rocket, printk cleanup - add KERN_ level to each print - change some levels appropriately - add \n at the ends where missing - change two complex printks into dev_info, where the original info is printed automatically Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]> --- commit

[PATCH 5/5] Net: sunrpc, remove SPIN_LOCK_UNLOCKED

2007-11-09 Thread Jiri Slaby
sunrpc, remove SPIN_LOCK_UNLOCKED SPIN_LOCK_UNLOCKED is deprecated, use DEFINE_SPINLOCK instead Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]> --- commit d5e782e62a4fe2663a012571c345d9887b02 tree b993038b020d8c619f6ffdad412fbb992c073513 parent 828042d12cc0aa515e049889aa76d4066df100c0 author

[PATCH 4/5] FS: sysfs, remove SPIN_LOCK_UNLOCKED

2007-11-09 Thread Jiri Slaby
sysfs, remove SPIN_LOCK_UNLOCKED SPIN_LOCK_UNLOCKED is deprecated, use DEFINE_SPINLOCK instead Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]> Cc: Greg Kroah-Hartman <[EMAIL PROTECTED]> --- commit 828042d12cc0aa515e049889aa76d4066df100c0 tree 85652493f11a06d0a1cda316d0f88a2ee7117d50 parent

[PATCH 1/7] Char: rocket, switch long delay to sleep

2007-11-09 Thread Jiri Slaby
rocket, switch long delay to sleep Don't busy wait for whole 1s when registering some rocket modems. Sleep instead since we are not in atomic. Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]> --- commit a9b06d9c7a580246dc328e96f31039d932bca47c tree eb2e25299ebce29c89efa19c3014d41f742454c0 parent

[PATCH 2/5] Watchdog: bfin_wdt, remove SPIN_LOCK_UNLOCKED

2007-11-09 Thread Jiri Slaby
bfin_wdt, remove SPIN_LOCK_UNLOCKED SPIN_LOCK_UNLOCKED is deprecated, use DEFINE_SPINLOCK instead Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]> Cc: Wim Van Sebroeck <[EMAIL PROTECTED]> --- commit 5290a0e1fffeb61f0062ebca98e45a6a5ba75711 tree 4d377ca30153b48b32b4d2c079ab884983c0091d parent

[PATCH 3/5] Sbus: cpwatchdog, remove SPIN_LOCK_UNLOCKED

2007-11-09 Thread Jiri Slaby
cpwatchdog, remove SPIN_LOCK_UNLOCKED SPIN_LOCK_UNLOCKED is deprecated, use __SPIN_LOCK_UNLOCKED with an unique name instead Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]> Cc: Wim Van Sebroeck <[EMAIL PROTECTED]> --- commit 4e91ba06c53856bfaab065aaf9fd8f5b0dd59f6f tree

[PATCH 1/5] Net: ibm_newemac, remove SPIN_LOCK_UNLOCKED

2007-11-09 Thread Jiri Slaby
ibm_newemac, remove SPIN_LOCK_UNLOCKED SPIN_LOCK_UNLOCKED is deprecated, use DEFINE_SPINLOCK instead Signed-off-by: Jiri Slaby <[EMAIL PROTECTED]> Cc: Jeff Garzik <[EMAIL PROTECTED]> --- commit aefcf0f6b6ab925184e7cebff8b609e4da1f5c0d tree 9e1e6240f26c759826959e8812885726c520019d parent

Re: [PATCH] CRISv10 improve and bugfix fasttimer

2007-11-09 Thread Andrew Morton
On Thu, 8 Nov 2007 09:54:30 +0100 Jesper Nilsson <[EMAIL PROTECTED]> wrote: > Improve and bugfix CRIS v10 fast timers. I'm trying to work out what's going on with all this cris activity. Is the current code really that busted, or are you adding new chip support, or are you resyncing mainline

[PATCH 10/11] x86: drop backward compatibility symlinks to i386/boot and x86_64/boot

2007-11-09 Thread Sam Ravnborg
This is the final step of full transition to the unified x86 architecture from the build system point of view. Signed-off-by: Sam Ravnborg <[EMAIL PROTECTED]> --- arch/x86/Makefile_32 |2 -- arch/x86/Makefile_64 |2 -- 2 files changed, 0 insertions(+), 4 deletions(-) diff --git

[PATCH 06/11] x86: copy x86_64 specific Kconfig symbols to Kconfig.i386

2007-11-09 Thread Sam Ravnborg
No functional changes. A prepatory step towards full unification. Signed-off-by: Sam Ravnborg <[EMAIL PROTECTED]> --- arch/x86/Kconfig |6 +- arch/x86/Kconfig.i386 | 215 - 2 files changed, 198 insertions(+), 23 deletions(-) diff --git

[PATCH 09/11] x86: enable "make ARCH=x86"

2007-11-09 Thread Sam Ravnborg
After unification of the Kconfig files it required only trivial changes to enable "make ARCH=x86". This patch unteach kconfig about SRCARCH and let kbuild compute x86 for `uname -m` equals x86_64 and the i.86 variants. The selection of 32 versus 64 bit is now done as a configuration step like we

[PATCH 07/11] x86: move all simple arch settings to Kconfig

2007-11-09 Thread Sam Ravnborg
Most of the arch settings were equal so combine them in the first part of Kconfig. Signed-off-by: Sam Ravnborg <[EMAIL PROTECTED]> --- arch/x86/Kconfig| 136 +++ arch/x86/Kconfig.i386 | 119 -

[PATCH 04/11] x86: add X86_32 dependency to i386 specific symbols in Kconfig.i386

2007-11-09 Thread Sam Ravnborg
To ease unification of Kconfig.i386 and Kconfig.x86_64 add X86_32 dependencies to all i386 specific symbols. This patch introduce no functional changes but is one step towards unification. This smaller step is used to ease review of the patch set. Signed-off-by: Sam Ravnborg <[EMAIL PROTECTED]>

[PATCH 03/11] x86: arch/x86/Kconfig.cpu unification

2007-11-09 Thread Sam Ravnborg
Move all CPU definitions to Kconfig.cpu Always define X86_MINIMUM_CPU_FAMILY and do the obvious code cleanup in boot/cpucheck.c Comments from: Adrian Bunk <[EMAIL PROTECTED]> incorporated. Signed-off-by: Sam Ravnborg <[EMAIL PROTECTED]> Cc: Adrian Bunk <[EMAIL PROTECTED]> Cc: Brian Gerst <[EMAIL

[PATCH 11/11] kbuild: sanity check the specified arch

2007-11-09 Thread Sam Ravnborg
If the ARCH used does not exist print out the following: Makefile:203: *** "ERROR: ARCH (i386) does not exist (for i386 and x86_64 use ARCH=x86)". Stop. This check is highly relevant now i386 and x86_64 are gone. Signed-off-by: Sam Ravnborg <[EMAIL PROTECTED]> Cc: Christoph Hellwig <[EMAIL

[PATCH 02/11] x86: start unification of arch/x86/Kconfig.*

2007-11-09 Thread Sam Ravnborg
This step introduces the file arch/x86/Kconfig which contains all the menu's from "Power Management" and below. The main part of the new Kconfig file is shared and the remaining i386/x86_64 specific symbols are covered by dependencies. A x86_64 allmodconfig build did not show any differences.

[PATCH 05/11] x86: add X86_64 dependency to x86_64 specific symbols in Kconfig.x86_64

2007-11-09 Thread Sam Ravnborg
To ease unification of Kconfig.i386 and Kconfig.x86_64 add X86_64 dependencies to all x86_64 specific symbols. This patch introduce no functional changes but is one step towards unification. This smaller step is used to ease review of the patch set. Signed-off-by: Sam Ravnborg <[EMAIL

[PATCH 01/11] x86: unification of cfufreq/Kconfig

2007-11-09 Thread Sam Ravnborg
Merge the two Kconfig files to a single file. Checked using make allmodconfig for x86_64. No changes in build. Signed-off-by: Sam Ravnborg <[EMAIL PROTECTED]> Cc: Adrian Bunk <[EMAIL PROTECTED]> Cc: Dave Jones <[EMAIL PROTECTED]> --- arch/x86/Kconfig.i386 |2 +-

[PATCH 0/11 v3] enable "make ARCH=x86"

2007-11-09 Thread Sam Ravnborg
With this patchset the former ARCH=i386 / ARCH=x86_64 are replaced by ARCH=x86. The rationale behind the patchset are that with a unified x86 architecture this should be reflected in the build commands. With this patch set the 32/64 bit selection is done at configuration time like we know it from

Re: [PATCH 1/24] mm/sparse-vmemmap.c: make sure init_mm is included

2007-11-09 Thread Jeremy Fitzhardinge
Glauber de Oliveira Costa wrote: > mm/sparse-vmemmap.c uses init_mm in some places. However, it is not > present in any of the headers currently included in the file. > > init_mm is defined as extern in sched.h, so we add it to the headers list > > Up to now, this problem was masked by the fact

Re: oops in oprofile/dump_trace/X86 with 2.6.24-rcX

2007-11-09 Thread Robert Fitzsimons
> this only happens 32bit. Somehow I broke this when I introduced > stack_pointer(). Here is a patch that fixes the problem. > > Subject: oprofile: Fix oops on x86 32-bit I've tested this and it fixes the oops. Thank you. Robert - To unsubscribe from this list: send the line "unsubscribe

Re: kernel BUG message while using jffs2

2007-11-09 Thread David Woodhouse
On Fri, 2007-11-09 at 17:08 +0200, Alexandru Damian wrote: > Hello, > > Sorry for posting here, it seems the best spot; if I need to redirect > this to mtd-utils team, please tell me. > > I'm playing around with some jffs2 files. While trying to mount (via > block2mtd, loop) a jffs2 system, a

Re: [PATCH 2/6] MTD: Add support for the SST 39VF1601 flash chip [try #5]

2007-11-09 Thread David Woodhouse
On Fri, 2007-11-09 at 15:34 +, David Howells wrote: > Add support for the SST 39VF1601 flash chip. > > Signed-off-by: David Howells <[EMAIL PROTECTED]> Applied. -- dwmw2 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL

  1   2   3   4   5   6   >