Re: [PATCH] scripts/checkpatch.pl: add a check for the patch level (patch -p)

2007-12-22 Thread Borislav Petkov
On Fri, Dec 21, 2007 at 06:12:02PM +, Andy Whitcroft wrote: > On Tue, Dec 18, 2007 at 06:46:41AM +0100, Borislav Petkov wrote: > > On Mon, Dec 17, 2007 at 08:11:05AM +0100, Borislav Petkov wrote: > > > > A slightly microoptimized version 1.1: > > > > --- > > From: Borislav Petkov <[EMAIL PROT

Re: [PATCH 4/4] usb: libusual: locking cleanup

2007-12-22 Thread Pete Zaitcev
On Sat, 22 Dec 2007 09:01:50 -0800, Daniel Walker <[EMAIL PROTECTED]> wrote: > Then in usu_probe_thread() your basically stopping it at the start of > the function with a down(), and the up() is just ancillary .. So you > could easily move the up() further down in the function and still have > the

Re: Testing RAM from userspace / question about memmap= arguments

2007-12-22 Thread David Newall
Pavel Machek wrote: On Sun 2007-12-23 07:06:58, David Newall wrote: It's kind of hard to run anything over SSH if it has to be run before userspace is up. But the kernel can collect results from a modified memtest, after it chains back. memtest can be ran from userspace, that's the p

2.6.24-rc6-mm1

2007-12-22 Thread Andrew Morton
ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.24-rc6/2.6.24-rc6-mm1/ - This kernel doesn't work on i386! It oopses late in boot due to an unrevertable change (e3c1b141) in git-x86 which I stared at for a while then I ran out of time and gave up. I would have just aband

[PATCH 1/2] UIO: Add a MAINTAINERS entry for Userspace I/O

2007-12-22 Thread Greg Kroah-Hartman
From: Hans-Jürgen Koch <[EMAIL PROTECTED]> This patch adds an entry for the Userspace I/O framework to MAINTAINERS. Signed-off-by: Hans J. Koch <[EMAIL PROTECTED]> Signed-off-by: Greg Kroah-Hartman <[EMAIL PROTECTED]> --- MAINTAINERS |8 1 files changed, 8 insertions(+), 0 deletions

[PATCH 2/2] Modules: fix memory leak of module names

2007-12-22 Thread Greg Kroah-Hartman
Due to the change in kobject name handling, the module kobject needs to have a null release function to ensure that the name it previously set will be properly cleaned up. All of this wierdness goes away in 2.6.25 with the rework of the kobject name and cleanup logic, but this is required for 2.6.

[GIT PATCH] driver core fix for 2.6.24-rc6

2007-12-22 Thread Greg KH
Here is one bugfix for a memory leak for every module that is unloaded from the system due to the change in the kobject name code against your 2.6.24-rc6 tree. And an entry for MAINTAINERS for the UIO subsystem so the proper people get the blame :) Please pull from: master.kernel.org:/pub

[GIT PATCH] USB fixes for 2.6.24-rc5

2007-12-22 Thread Greg KH
Here are some USB fixes and new device ids against your 2.6.24-rc6 git tree. Please pull from: master.kernel.org:/pub/scm/linux/kernel/git/gregkh/usb-2.6.git/ The full patches will be sent to the linux-usb mailing list (note the address change), if anyone wants to see them. thanks, greg

Re: NFS EINVAL on open(... | O_TRUNC) on 2.6.23.9

2007-12-22 Thread Scott
On Dec 22, 2007, at 5:52 AM, Gianluca Alberici wrote: I've run into this problem 2.6.23.9. The open syscall will return "Invalid argument" when O_TRUNC is set on existing files. The same file can be opened for append or removed. The evidence is for example: mars:~# mount localhost:/opt/nfs/ /

Re: [git patches] net driver fixes

2007-12-22 Thread Al Viro
On Sun, Dec 23, 2007 at 01:42:14AM -0500, Jeff Garzik wrote: > I applied it to #upstream (2.6.25) since forcedeth is not on any > big-endian platforms AFAIK. All right, then... I hadn't been sure if it's onboard-only, that's all. > I have an epic100 card too if you need it (though it sounds li

Re: [PATCH 00/63] ide-cd: redux

2007-12-22 Thread Borislav Petkov
On Fri, Dec 21, 2007 at 08:57:49PM +0100, Bartlomiej Zolnierkiewicz wrote: > On Thursday 20 December 2007, Borislav Petkov wrote: > > On Thu, Dec 20, 2007 at 01:48:49AM +0100, Bartlomiej Zolnierkiewicz wrote: > > Hi Bart, > > Hi all, > > > > > PS ide-cd Maintainer position is still open... > > i'd

Re: [git patches] net driver fixes

2007-12-22 Thread Jeff Garzik
Al Viro wrote: On Sun, Dec 23, 2007 at 12:33:14AM -0500, Jeff Garzik wrote: A couple [minorly] notable wireless bug fixes, and plenty of viro fixes for obscure issues :) Heh... FWIW, forcedeth patch (sent your way about two weeks ago) also belongs in the same set. If you need a resend - tell

Re: [git patches] net driver fixes

2007-12-22 Thread Al Viro
On Sun, Dec 23, 2007 at 12:33:14AM -0500, Jeff Garzik wrote: > > A couple [minorly] notable wireless bug fixes, and plenty of viro fixes > for obscure issues :) Heh... FWIW, forcedeth patch (sent your way about two weeks ago) also belongs in the same set. If you need a resend - tell... There's

Re: kobject ->k_name memory leak

2007-12-22 Thread Greg KH
On Sat, Dec 22, 2007 at 03:07:21PM +0300, Alexey Dobriyan wrote: > On Thu, Dec 20, 2007 at 02:04:56PM -0800, Greg KH wrote: > > On Sat, Dec 15, 2007 at 04:19:16PM +0100, Kay Sievers wrote: > > > On Sat, 2007-12-15 at 16:34 +0300, Alexey Dobriyan wrote: > > > > On Fri, Dec 14, 2007 at 01:48:23PM -08

Re: [RFC] USB Kconfig: Declutter USB Kconfig Menu

2007-12-22 Thread David Brownell
On Saturday 22 December 2007, Al Boldi wrote: > Provided there is agreement, and we go with < >, it would mean a slight > change to Host side USB, like this (note new USB Core Config sub-menu): > >       --- Support for Host-side USB >       [ ]   USB Core Config  ---> Maybe. Let's see what you

Re: [patch] Make MMCONFIG space (extended PCI config space) a driver opt-in issue

2007-12-22 Thread H. Peter Anvin
Jeff Garzik wrote: 2) It is legal for PCI-Express to put capabilities anywhere in PCI config space, including extended config space. (I hope our PCI cap walking code checks for overruns...) Uh, not really. The classical capability format only has 8-bit addresses, and the spec requires t

[PATCH] Avoid overflows in kernel/time.c (version 6)

2007-12-22 Thread H. Peter Anvin
When the conversion factor between jiffies and milli- or microseconds is not a single multiply or divide, as for the case of HZ == 300, we currently do a multiply followed by a divide. The intervening result, however, is subject to overflows, especially since the fraction is not simplified (for HZ

Re: [PATCH] (UPDATED) ecryptfs: check for existing key_tfm at mount time

2007-12-22 Thread Eric Sandeen
Andrew Morton wrote: > On Sat, 22 Dec 2007 11:42:37 -0600 Eric Sandeen <[EMAIL PROTECTED]> wrote: > >> Andrew Morton wrote: >> >>> It would all look a lot more solid if this locking was retained and both >>> ecryptfs_tfm_exists() and ecryptfs_add_new_key_tfm() were designed to be >>> called under

Re: [patch] Make MMCONFIG space (extended PCI config space) a driver opt-in issue

2007-12-22 Thread Jeff Garzik
Loic Prylli wrote: Supporting extended-conf-space is independant of the issue of using mmconf for legacy conf-space. True. There is no real reason to use the same method to access both. I have seen several arguments used that were implying that, and they all seem really bogus to me. Not only

Re: [patch] Make MMCONFIG space (extended PCI config space) a driver opt-in issue

2007-12-22 Thread Loic Prylli
On 12/22/2007 11:52 PM, Jeff Garzik wrote: > > Absolutely. > > But regardless of problems, enabling should be done globally, not per > device... The "enabling globally" requirement, i.e. not per-device, neither depending on reg >= 256 seems a very debatable assumption (IMHO a big mistake) th

Re: [patch] Make MMCONFIG space (extended PCI config space) a driver opt-in issue

2007-12-22 Thread Jeff Garzik
Linus Torvalds wrote: On Sun, 23 Dec 2007, Jeff Garzik wrote: And yes, if you want the capability following to notice automatically when capabilities really do go into the 0x100+ range, that's fine. I suspect Yes, we /must/ do this checking, if we don't already. Hell no. If the user asked fo

Re: [patch] Make MMCONFIG space (extended PCI config space) a driver opt-in issue

2007-12-22 Thread Linus Torvalds
On Sun, 23 Dec 2007, Jeff Garzik wrote: > > Then let's do it right: disable mmconfig by default on x86, and enable it > when passed "pci=mmconfig". I'm certainly ok with that, but then you say: > > And yes, if you want the capability following to notice automatically when > > capabilities rea

Re: Major regression on hackbench with SLUB (more numbers)

2007-12-22 Thread Willy Tarreau
On Sat, Dec 22, 2007 at 07:59:47PM -0500, Steven Rostedt wrote: [...] > But I still scratch my head when ever I need to touch sysfs. Same here. In fact, I've always considered that procfs was for humans while sysfs was for tools. sysfs reminds me too much the unexploitable /devices in Solaris. Wit

Re: [patch] Make MMCONFIG space (extended PCI config space) a driver opt-in issue

2007-12-22 Thread Loic Prylli
On 12/22/2007 11:13 PM, Jeff Garzik wrote: > > The facts as they exist today: > > 1) Existing 256-byte config space devices have been known put > capabilities in the high end (>= 0xc8) of config space. > > 2) It is legal for PCI-Express to put capabilities anywhere in PCI > config space, including

Re: [patch] Make MMCONFIG space (extended PCI config space) a driver opt-in issue

2007-12-22 Thread Jeff Garzik
Linus Torvalds wrote: On Sat, 22 Dec 2007, Jeff Garzik wrote: But regardless of problems, enabling should be done globally, not per device... I'm ok with trying the "globally" idea, but it has to be "globally but only if absolutely required". And quite frankly, how do you tell whether it's

Re: [patch] Make MMCONFIG space (extended PCI config space) a driver opt-in issue

2007-12-22 Thread Jeff Garzik
Linus Torvalds wrote: I want to limit that downside. Right now, the easiest way to limit it seems to be to say that those (very very few) drivers that actually care could enable it. That way, we automatically limit it to only those machines that have hardware that cares. Then let's do it righ

Re: [patch] Make MMCONFIG space (extended PCI config space) a driver opt-in issue

2007-12-22 Thread Linus Torvalds
On Sat, 22 Dec 2007, Jeff Garzik wrote: > > But regardless of problems, enabling should be done globally, not per > device... I'm ok with trying the "globally" idea, but it has to be "globally but only if absolutely required". And quite frankly, how do you tell whether it's absolutely require

Re: [patch] Make MMCONFIG space (extended PCI config space) a driver opt-in issue

2007-12-22 Thread Jeff Garzik
Linus Torvalds wrote: On Sat, 22 Dec 2007, Jeff Garzik wrote: My core assertion: the present situation -- turning off MMCONFIG aggressively -- is greatly preferable to adding pci_enable_mmconfig_accesses(pdev). Well, you do realize that right now we have to have _users_ just doing "pci=nom

Re: [patch] Make MMCONFIG space (extended PCI config space) a driver opt-in issue

2007-12-22 Thread Linus Torvalds
On Sat, 22 Dec 2007, Jeff Garzik wrote: > > Jeff Garzik wrote: > > Maybe that day will never come, but it is nonetheless quite possible without > > today's PCI Express spec for this to happen. > > er, s/without/within/ You're talking specs. I'm talking machines. I agree with you 100% that as p

Re: [patch] Make MMCONFIG space (extended PCI config space) a driver opt-in issue

2007-12-22 Thread Linus Torvalds
On Sat, 22 Dec 2007, Jeff Garzik wrote: > > It should be self-evident that mmconfig doesn't work on old hardware, is not > needed on old hardware, should not be turned on for old hardware, and in > general should never disturb old hardware. .. but it does. How do you figure out when to turn it

Re: [patch] Make MMCONFIG space (extended PCI config space) a driver opt-in issue

2007-12-22 Thread Linus Torvalds
On Sat, 22 Dec 2007, Jeff Garzik wrote: > My core assertion: the present situation -- turning off MMCONFIG aggressively > -- is greatly preferable to adding pci_enable_mmconfig_accesses(pdev). Well, you do realize that right now we have to have _users_ just doing "pci=nommconf" on the kernel

Re: [patch] Make MMCONFIG space (extended PCI config space) a driver opt-in issue

2007-12-22 Thread Jeff Garzik
Jeff Garzik wrote: Maybe that day will never come, but it is nonetheless quite possible without today's PCI Express spec for this to happen. er, s/without/within/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More major

Re: [patch] Make MMCONFIG space (extended PCI config space) a driver opt-in issue

2007-12-22 Thread Jeff Garzik
Linus Torvalds wrote: On Sat, 22 Dec 2007, Jeff Garzik wrote: Regardless of whether a driver is loaded or not, you may NEED to see extended capabilities. The system may NEED to see those capabilities just to parse them for sane operation. And that's just not true. I don't know why you even c

Re: [patch] Make MMCONFIG space (extended PCI config space) a driver opt-in issue

2007-12-22 Thread Jeff Garzik
Linus Torvalds wrote: The problem is that it isn't enough that it works on common machines with good hardware. The problem is that we end up chasing insane bugs, wasting peoples valuable time and effort, on those *few* - out of *millions* - of machines that then surprisingly don't work. And "

Re: [patch] Make MMCONFIG space (extended PCI config space) a driver opt-in issue

2007-12-22 Thread Linus Torvalds
On Sat, 22 Dec 2007, Jeff Garzik wrote: > > I forcibly turn on mmconfig on all my machines, and monitor lkml, to make sure > I'm aware of the extent of the problem -- and the extent of peoples' > exaggeration of this problem. Bullshit. You have how many machines? Ten? The problem is that it is

Re: [lm-sensors] 2.6.24-rc4 hwmon it87 probe fails

2007-12-22 Thread Bjorn Helgaas
On Saturday 22 December 2007 4:21:41 am Jean Delvare wrote: > >This patch makes the it87 driver request only the two ports used for the > >Environment Controller device. > > The problem is that the IT87xxF chips do decode 4 ports (recent chips, > 0x294-0x297) or 8 ports (older chips, 0x290-0x297),

Re: [PATCH] tty: Fix logic change introduced by wait_event_interruptible_timeout()

2007-12-22 Thread Cory T. Tusar
Andrew Morton wrote: > On Thu, 20 Dec 2007 16:39:21 -0500 "Cory T. Tusar" <[EMAIL PROTECTED]> wrote: > >> tty: Fix logic change introduced by wait_event_interruptible_timeout() >> >> Commit 5a52bd4a2dcb570333ce6fe2e16cd311650dbdc8 introduced a subtle logic >> change in tty_wait_until_sent(). The

Re: [PATCH] Avoid overflows in kernel/time.c (version 5)

2007-12-22 Thread Andrew Morton
On Mon, 17 Dec 2007 13:53:23 -0800 "H. Peter Anvin" <[EMAIL PROTECTED]> wrote: > When the conversion factor between jiffies and milli- or microseconds > is not a single multiply or divide, as for the case of HZ == 300, we > currently do a multiply followed by a divide. The intervening > result, h

[PATCH 23/24] udf: convert UDF_SB_FREE_BITMAP macro to udf_sb_free_bitmap function

2007-12-22 Thread marcin . slusarz
additionally fix sparse warnings: fs/udf/super.c:1636:4: warning: symbol 'i' shadows an earlier one fs/udf/super.c:1469:6: originally declared here fs/udf/super.c:1638:4: warning: symbol 'i' shadows an earlier one fs/udf/super.c:1469:6: originally declared here fs/udf/super.c:1712:4: warning: symbo

[PATCH 24/24] udf: fix sparse warnings (shadowing & mismatch between declaration and definition)

2007-12-22 Thread marcin . slusarz
fix warnings: fs/udf/super.c:1370:24: warning: symbol 'bh' shadows an earlier one fs/udf/super.c:1288:21: originally declared here fs/udf/super.c:450:6: warning: symbol 'udf_write_super' was not declared. Should it be static? Signed-off-by: Marcin Slusarz <[EMAIL PROTECTED]> CC: Ben Fennema <[EMA

[PATCH 21/24] udf: remove some UDF_SB_* macros

2007-12-22 Thread marcin . slusarz
remove macros: - UDF_SB_PARTTYPE - UDF_SB_PARTROOT - UDF_SB_PARTLEN - UDF_SB_PARTVSN - UDF_SB_PARTNUM - UDF_SB_TYPESPAR - UDF_SB_TYPEVIRT - UDF_SB_PARTFUNC - UDF_SB_PARTFLAGS and replace all uses Signed-off-by: Marcin Slusarz <[EMAIL PROTECTED]> CC: Ben Fennema <[EMAIL PROTECTED]> CC: Jan Kara <[E

[PATCH 22/24] udf: convert UDF_SB_ALLOC_BITMAP macro to udf_sb_alloc_bitmap function

2007-12-22 Thread marcin . slusarz
Signed-off-by: Marcin Slusarz <[EMAIL PROTECTED]> CC: Ben Fennema <[EMAIL PROTECTED]> CC: Jan Kara <[EMAIL PROTECTED]> --- fs/udf/super.c |4 ++-- fs/udf/udf_sb.h | 37 - 2 files changed, 22 insertions(+), 19 deletions(-) diff --git a/fs/udf/super.c b/fs

[PATCH 19/24] udf: check if udf_load_logicalvol failed

2007-12-22 Thread marcin . slusarz
udf_load_logicalvol may fail eg in out of memory conditions - check it and propagate error further Signed-off-by: Marcin Slusarz <[EMAIL PROTECTED]> CC: Ben Fennema <[EMAIL PROTECTED]> CC: Jan Kara <[EMAIL PROTECTED]> --- fs/udf/super.c |7 ++- 1 files changed, 6 insertions(+), 1 deletion

[PATCH 20/24] udf: convert UDF_UPDATE_UDFREV macro to udf_update_revision function

2007-12-22 Thread marcin . slusarz
Signed-off-by: Marcin Slusarz <[EMAIL PROTECTED]> CC: Ben Fennema <[EMAIL PROTECTED]> CC: Jan Kara <[EMAIL PROTECTED]> --- fs/udf/ialloc.c |2 +- fs/udf/udf_sb.h |8 ++-- 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/fs/udf/ialloc.c b/fs/udf/ialloc.c index 269f588..4d1

[PATCH 17/24] udf: convert UDF_SB_VAT macro to udf_sb_vat_inode function

2007-12-22 Thread marcin . slusarz
- change UDF_SB_VAT macro to udf_sb_vat_inode inline function - rename s_vat field to s_vat_inode Signed-off-by: Marcin Slusarz <[EMAIL PROTECTED]> CC: Ben Fennema <[EMAIL PROTECTED]> CC: Jan Kara <[EMAIL PROTECTED]> --- fs/udf/partition.c|6 +++--- fs/udf/super.c| 24 ++

[PATCH 18/24] udf: convert UDF_SB_ALLOC_PARTMAPS macro to udf_sb_alloc_partition_maps function

2007-12-22 Thread marcin . slusarz
- change UDF_SB_ALLOC_PARTMAPS macro to udf_sb_alloc_partition_maps inline function - convert kmalloc + memset to kzalloc - check if kzalloc failed (partially) Signed-off-by: Marcin Slusarz <[EMAIL PROTECTED]> CC: Ben Fennema <[EMAIL PROTECTED]> CC: Jan Kara <[EMAIL PROTECTED]> --- fs/udf/super.

[PATCH 14/24] udf: convert UDF_SB_RECORDTIME macro to udf_sb_record_time function

2007-12-22 Thread marcin . slusarz
- change UDF_SB_RECORDTIME macro to udf_sb_record_time inline function - rename s_recordtime field to s_record_time Signed-off-by: Marcin Slusarz <[EMAIL PROTECTED]> CC: Ben Fennema <[EMAIL PROTECTED]> CC: Jan Kara <[EMAIL PROTECTED]> --- fs/udf/inode.c| 14 +++--- fs/udf/su

[PATCH 15/24] udf: convert UDF_SB_SERIALNUM macro to udf_sb_serial_number function

2007-12-22 Thread marcin . slusarz
- change UDF_SB_SERIALNUM macro to udf_sb_serial_number inline function - rename s_serialnum field to s_serial_number Signed-off-by: Marcin Slusarz <[EMAIL PROTECTED]> CC: Ben Fennema <[EMAIL PROTECTED]> CC: Jan Kara <[EMAIL PROTECTED]> --- fs/udf/inode.c|2 +- fs/udf/misc.c

[PATCH 16/24] udf: convert UDF_SB_UDFREV macro to udf_sb_revision function

2007-12-22 Thread marcin . slusarz
Signed-off-by: Marcin Slusarz <[EMAIL PROTECTED]> CC: Ben Fennema <[EMAIL PROTECTED]> CC: Jan Kara <[EMAIL PROTECTED]> --- fs/udf/balloc.c |2 +- fs/udf/inode.c| 14 +++--- fs/udf/misc.c |2 +- fs/udf/namei.c|2 +- fs/udf/super.c| 10 +- fs/udf/tru

[PATCH 12/24] udf: convert UDF_SB_LVIDIU macro to udf_sb_lvidiu function

2007-12-22 Thread marcin . slusarz
Signed-off-by: Marcin Slusarz <[EMAIL PROTECTED]> CC: Ben Fennema <[EMAIL PROTECTED]> CC: Jan Kara <[EMAIL PROTECTED]> --- fs/udf/ialloc.c | 16 fs/udf/super.c | 34 +- fs/udf/udf_sb.h | 10 -- 3 files changed, 33 insertions(+), 27 de

[PATCH 13/24] udf: remove unused macros

2007-12-22 Thread marcin . slusarz
Signed-off-by: Marcin Slusarz <[EMAIL PROTECTED]> CC: Ben Fennema <[EMAIL PROTECTED]> CC: Jan Kara <[EMAIL PROTECTED]> --- fs/udf/udf_sb.h |4 1 files changed, 0 insertions(+), 4 deletions(-) diff --git a/fs/udf/udf_sb.h b/fs/udf/udf_sb.h index a9ff8fb..8683b71 100644 --- a/fs/udf/udf_sb

[PATCH 10/24] udf: convert UDF_SB_LVIDBH macro to udf_sb_lvid_bh function

2007-12-22 Thread marcin . slusarz
- change UDF_SB_LVIDBH macro to udf_sb_lvid_bh inline function - rename s_lvidbh field to s_lvid_bh Signed-off-by: Marcin Slusarz <[EMAIL PROTECTED]> CC: Ben Fennema <[EMAIL PROTECTED]> CC: Jan Kara <[EMAIL PROTECTED]> --- fs/udf/balloc.c | 26 +- fs/udf/ialloc

[PATCH 11/24] udf: convert UDF_SB_LVID macro to udf_sb_lvid function

2007-12-22 Thread marcin . slusarz
Signed-off-by: Marcin Slusarz <[EMAIL PROTECTED]> CC: Ben Fennema <[EMAIL PROTECTED]> CC: Jan Kara <[EMAIL PROTECTED]> --- fs/udf/balloc.c | 24 fs/udf/ialloc.c |2 +- fs/udf/namei.c |4 ++-- fs/udf/super.c | 40 fs/ud

[PATCH 09/24] udf: convert UDF_SB_LASTBLOCK macro to udf_sb_last_block function

2007-12-22 Thread marcin . slusarz
- change UDF_SB_LASTBLOCK macro to udf_sb_last_block inline function - rename s_lastblock field to s_last_block Signed-off-by: Marcin Slusarz <[EMAIL PROTECTED]> CC: Ben Fennema <[EMAIL PROTECTED]> CC: Jan Kara <[EMAIL PROTECTED]> --- fs/udf/super.c| 20 ++-- fs/udf/

[PATCH 07/24] udf: convert UDF_SB_SESSION macro to udf_sb_session function

2007-12-22 Thread marcin . slusarz
Signed-off-by: Marcin Slusarz <[EMAIL PROTECTED]> CC: Ben Fennema <[EMAIL PROTECTED]> CC: Jan Kara <[EMAIL PROTECTED]> --- fs/udf/misc.c |8 fs/udf/super.c | 28 ++-- fs/udf/udf_sb.h |6 +- 3 files changed, 23 insertions(+), 19 deletions(-) diff -

[PATCH 08/24] udf: convert UDF_SB_ANCHOR macro to udf_sb_anchor function

2007-12-22 Thread marcin . slusarz
Signed-off-by: Marcin Slusarz <[EMAIL PROTECTED]> CC: Ben Fennema <[EMAIL PROTECTED]> CC: Jan Kara <[EMAIL PROTECTED]> --- fs/udf/super.c | 44 ++-- fs/udf/udf_sb.h |6 +- 2 files changed, 27 insertions(+), 23 deletions(-) diff --git a/fs/udf/sup

[PATCH 04/24] udf: convert UDF_SB_VOLIDENT macro to udf_sb_volume_ident function

2007-12-22 Thread marcin . slusarz
- change UDF_SB_VOLIDENT macro to udf_sb_volume_ident inline function - rename s_volident field to s_volume_ident Signed-off-by: Marcin Slusarz <[EMAIL PROTECTED]> CC: Ben Fennema <[EMAIL PROTECTED]> CC: Jan Kara <[EMAIL PROTECTED]> --- fs/udf/file.c |2 +- fs/udf/super.c

[PATCH 05/24] udf: convert UDF_SB_NUMPARTS macro to udf_sb_num_parts function

2007-12-22 Thread marcin . slusarz
Signed-off-by: Marcin Slusarz <[EMAIL PROTECTED]> CC: Ben Fennema <[EMAIL PROTECTED]> CC: Jan Kara <[EMAIL PROTECTED]> --- fs/udf/partition.c |6 +++--- fs/udf/super.c | 20 ++-- fs/udf/udf_sb.h| 10 +++--- 3 files changed, 20 insertions(+), 16 deletions(-) dif

[PATCH 06/24] udf: convert UDF_SB_PARTITION macro to udf_sb_partition function

2007-12-22 Thread marcin . slusarz
Signed-off-by: Marcin Slusarz <[EMAIL PROTECTED]> CC: Ben Fennema <[EMAIL PROTECTED]> CC: Jan Kara <[EMAIL PROTECTED]> --- fs/udf/balloc.c | 10 fs/udf/super.c | 68 +++--- fs/udf/udf_sb.h |6 - 3 files changed, 44 insertions(+)

[PATCH 03/24] udf: convert some macros to inline functions

2007-12-22 Thread marcin . slusarz
macro UDF_SB_PARTMAPS -> function udf_sb_partmaps macro UDF_SB_FREE -> function udf_sb_free Signed-off-by: Marcin Slusarz <[EMAIL PROTECTED]> CC: Ben Fennema <[EMAIL PROTECTED]> CC: Jan Kara <[EMAIL PROTECTED]> --- fs/udf/balloc.c | 24 ++-- fs/udf/super.c | 52 ++

[PATCH 01/24] udf: fix coding style of super.c

2007-12-22 Thread marcin . slusarz
fix coding style errors found by checkpatch: - assignments in if conditions - braces {} around single statement blocks - no spaces after commas - printks without KERN_* - lines longer than 80 characters before: total: 50 errors, 207 warnings, 1835 lines checked after: total: 0 errors, 164 warnings

[PATCH 02/24] udf: rename UDF_SB to udf_sb

2007-12-22 Thread marcin . slusarz
rename UDF_SB function to udf_sb Signed-off-by: Marcin Slusarz <[EMAIL PROTECTED]> CC: Ben Fennema <[EMAIL PROTECTED]> CC: Jan Kara <[EMAIL PROTECTED]> --- fs/udf/balloc.c | 12 ++-- fs/udf/ialloc.c |4 ++-- fs/udf/inode.c |6 +++--- fs/udf/super.c | 32 -

[PATCH 00/24] udf: convert super_block macros to functions

2007-12-22 Thread marcin . slusarz
Hi This patchset converts macros related to super_block handling into functions. Besides that it fixes some sparse warnings (23rd and 24th), improves coding style (1st) and fixes error handling (19th). Note that udf files has really long lines and these patches won't validate by checkpatch. I'm go

Re: [patch] Make MMCONFIG space (extended PCI config space) a driver opt-in issue

2007-12-22 Thread Jeff Garzik
Arjan van de Ven wrote: On Sat, 22 Dec 2007 09:20:06 -0500 Jeff Garzik <[EMAIL PROTECTED]> wrote: Arjan van de Ven wrote: Hi, Linus really wants the extended (4Kb) PCI configuration space (using MCFG acpi table etc) to be opt-in, since there's many issues with it and most drivers don't even u

Re: [patch] Make MMCONFIG space (extended PCI config space) a driver opt-in issue

2007-12-22 Thread Jeff Garzik
Arjan van de Ven wrote: On Sat, 22 Dec 2007 20:30:58 +0100 Martin Mares <[EMAIL PROTECTED]> wrote: Hello! Just make it so. The name is fine, the concept is unavoidable. The people who complain are whiners that haven't ever had to deal with the fact that there are broken machines around. I c

Re: [patch] Make MMCONFIG space (extended PCI config space) a driver opt-in issue

2007-12-22 Thread Jeff Garzik
Linus Torvalds wrote: On Sat, 22 Dec 2007, Arjan van de Ven wrote: On Sat, 22 Dec 2007 09:20:06 -0500 Jeff Garzik <[EMAIL PROTECTED]> wrote: Yuck. And, Linus is just being silly. Wait a year then turn on MMCONFIG :) It took PCI MSI a while to mature, but is finally getting there. That _

Re: [Cbe-oss-dev] [announce] PS3 Linux Distributor's Starter Kit (v1.5.1) released

2007-12-22 Thread David Woodhouse
On Fri, 2007-12-21 at 13:39 -0800, Geoff Levand wrote: > An updated kboot image is here: > > http://www.kernel.org/pub/linux/kernel/people/geoff/cell/kboot-20071220.bld NFS booting seems to fail. After saying 'Mounting ...' for 30 seconds or so, it then says 'rpcbind: server 0.0.0.0 not respondin

Re: Major regression on hackbench with SLUB (more numbers)

2007-12-22 Thread Steven Rostedt
[/me sneaks away from the family] On Sat, 22 Dec 2007, Willy Tarreau wrote: > On Sat, Dec 22, 2007 at 01:00:09PM -0800, Linus Torvalds wrote: > > On Sat, 22 Dec 2007, Theodore Tso wrote: > > > But sometimes when trying to eyeball what is going on, it's a lot > > > nicer just to use "cat /proc/sl

Re: [patch] Make MMCONFIG space (extended PCI config space) a driver opt-in issue

2007-12-22 Thread Jeff Garzik
Greg KH wrote: But it is that device, and the driver that controls this device that cares about the extended config space. So it's fair to push this onto the driver if needed, instead of forcing the pci core to just blindly guess for all devices, and getting it wrong... Nothing is being force

Re: [PATCH] (UPDATED) ecryptfs: check for existing key_tfm at mount time

2007-12-22 Thread Andrew Morton
On Sat, 22 Dec 2007 11:42:37 -0600 Eric Sandeen <[EMAIL PROTECTED]> wrote: > Andrew Morton wrote: > > > It would all look a lot more solid if this locking was retained and both > > ecryptfs_tfm_exists() and ecryptfs_add_new_key_tfm() were designed to be > > called under key_tfm_list_mutex. > > H

Re: [patch 00/20] VM pageout scalability improvements

2007-12-22 Thread Rik van Riel
On Sun, 23 Dec 2007 01:57:32 +0530 Balbir Singh <[EMAIL PROTECTED]> wrote: > Rik van Riel wrote: > > On large memory systems, the VM can spend way too much time scanning > > through pages that it cannot (or should not) evict from memory. Not > > only does it use up CPU time, but it also provokes lo

Re: ACPI or radeon: spontaneous reboot regression

2007-12-22 Thread Rafael J. Wysocki
On Sunday, 23 of December 2007, Matt Mackall wrote: > With 2.6.24-rc2, plugging and unplugging power results in a sudden > reboot. After the reboot, the machine boots normally until it switches > to graphics mode, at which point the screen is scrambled. It may hang or > repeatedly reboot at this po

Re: Linux 2.6.24-rc6

2007-12-22 Thread S.Çağlar Onur
Hi; 21 Ara 2007 Cum tarihinde, Linus Torvalds şunları yazmıştı: > Here's to a merry christmas, doing the whole druidic festival around the > tree thing, With -rc6, dmesg shows following Unknown symbols; [...] [ 26.883635] Bluetooth: Core ver 2.11 [ 26.913123] hci_usb: Unknown symbol hci_sus

ACPI or radeon: spontaneous reboot regression

2007-12-22 Thread Matt Mackall
With 2.6.24-rc2, plugging and unplugging power results in a sudden reboot. After the reboot, the machine boots normally until it switches to graphics mode, at which point the screen is scrambled. It may hang or repeatedly reboot at this point. Easily repeatable after just a few plug cycles. Switch

Re: Major regression on hackbench with SLUB (more numbers)

2007-12-22 Thread Jason L Tibbitts III
> "IM" == Ingo Molnar <[EMAIL PROTECTED]> writes: IM> Distros will likely pick SLUB if there's no performance worries IM> and if it's the default. Fedora rawhide already uses SLUB. Actually, it seems to me that not only does Fedora rawhide use SLUB, but Fedora 8 and 7 use it as well. They do

Re: Major regression on hackbench with SLUB (more numbers)

2007-12-22 Thread Al Viro
On Sat, Dec 22, 2007 at 09:50:09PM +, Al Viro wrote: > On Sat, Dec 22, 2007 at 01:00:09PM -0800, Linus Torvalds wrote: > > > > Another problem with using /sys/slab is that it is downright *ugly*. > > > Why is it for example, that /sys/slab/dentry is a symlink to > > > ../slab/:a-160? > >

Re: slabtop replacement was Re: Major regression on hackbench with SLUB (more numbers)

2007-12-22 Thread Karol Swietlicki
On 22/12/2007, Andi Kleen <[EMAIL PROTECTED]> wrote: > A manpage for slabinfo would be useful though. Anybody > volunteering to write one? > > -Andi That would be me. I'm a newbie and never wrote a man page before, so it will take a few days, but I'm bored and out of ideas for any new code for the

Re: Mysterious lockdep warning from the SCSI workqueue code

2007-12-22 Thread Peter Zijlstra
On Sat, 2007-12-22 at 23:56 +0100, Rafael J. Wysocki wrote: > On Saturday, 22 of December 2007, James Bottomley wrote: > > I've no idea why this is occurring: > > > > WARNING: at kernel/lockdep.c:700 look_up_lock_class() > > Pid: 2068, comm: scsi_wq_3 Not tainted 2.6.24-rc6 #38 > > [] show_trace

Re: rt2x00 is sapmming my logs

2007-12-22 Thread Rafael J. Wysocki
On Saturday, 22 of December 2007, drago01 wrote: > On Dec 23, 2007 12:04 AM, Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: > >[..] > > > The connection seems top work anyways so i do not think this is critical. > > > Thanks in advance for your time. > > > > I have created a bugzilla entry for this

Re: rt2x00 is sapmming my logs

2007-12-22 Thread Alejandro Riveira Fernández
El Sun, 23 Dec 2007 00:04:42 +0100 "Rafael J. Wysocki" <[EMAIL PROTECTED]> escribió: > On Saturday, 22 of December 2007, Alejandro Riveira Fernández wrote: > > > I have created a bugzilla entry for this problem at: > http://bugzilla.kernel.org/show_bug.cgi?id=9622 > and added it to the list of re

Re: rt2x00 is sapmming my logs

2007-12-22 Thread drago01
On Dec 23, 2007 12:04 AM, Rafael J. Wysocki <[EMAIL PROTECTED]> wrote: >[..] > > The connection seems top work anyways so i do not think this is critical. > > Thanks in advance for your time. > > I have created a bugzilla entry for this problem at: > http://bugzilla.kernel.org/show_bug.cgi?id=962

Re: rt2x00 is sapmming my logs

2007-12-22 Thread Rafael J. Wysocki
On Saturday, 22 of December 2007, Alejandro Riveira Fernández wrote: > > I have a rt2500pci card on an 64 bit system (Ubuntu) AMD X2 processor and i'm > trying latest vanilla kernels i've used a 2.6.24-rc5 kernel without mayor > issues > (except that i have to issue a sudo iwconfig wlan0 rate 54

[PATCH] fat: Editions to support fat_fallocate()

2007-12-22 Thread Steven Cavanagh
From: Steven Cavanagh <[EMAIL PROTECTED]> Added support for fallocate for a msdos fat driver. This allows preallocation of clusters to an inode before writes to reduce file fragmentation Signed-off-by: Steven.Cavanagh <[EMAIL PROTECTED]> --- fs/fat/file.c | 45

Re: [PATCH 2/3] (Resend part #1) Add the RapidIO support to powerpc architecture with memory mapping support.

2007-12-22 Thread Stephen Rothwell
Hi, This is a very large patch. It may be easier to review if it could be split on some logical way, that is at all possible (I don't know either way). This is just a quick note about some more trivial things. On Fri, 21 Dec 2007 17:58:43 +0800 Zhang Wei <[EMAIL PROTECTED]> wrote: > > +struct r

Re: Mysterious lockdep warning from the SCSI workqueue code

2007-12-22 Thread Rafael J. Wysocki
On Saturday, 22 of December 2007, James Bottomley wrote: > I've no idea why this is occurring: > > WARNING: at kernel/lockdep.c:700 look_up_lock_class() > Pid: 2068, comm: scsi_wq_3 Not tainted 2.6.24-rc6 #38 > [] show_trace_log_lvl+0x1a/0x30 > [] show_trace+0x12/0x20 > [] dump_stack+0x6c/0x80

Re: Problems on booting

2007-12-22 Thread Rafael J. Wysocki
On Saturday, 22 of December 2007, werner wrote: > There seems to have two regressions between the kernels from yesterday and > before-yesterday > On the kernel -git7 what didnt happened on -git6 > > 1) My hard disk is /dev/hda, but when I have an usb key sticked in /dev/sba, I guess you mean /de

Re: [RFT] Port 0x80 I/O speed

2007-12-22 Thread Bauke Jan Douma
Rene Herman wrote on 12-12-07 00:31: Good day. Would some people on x86 (both 32 and 64) be kind enough to compile and run the attached program? This is about testing how long I/O port access to port 0x80 takes. It measures in CPU cycles so CPU speed is crucial in reporting. Compiled as you

Re: [2.6.24-rc6] pdflush still stuck in D state regression

2007-12-22 Thread Rafael J. Wysocki
On Saturday, 22 of December 2007, Tvrtko A. Ursulin wrote: > > Hi, Hi, > As it was in this bug report: http://bugzilla.kernel.org/show_bug.cgi?id=9441 I have reopened http://bugzilla.kernel.org/show_bug.cgi?id=9291 . Please update add the new information in there. > I am still not sure it is

Re: [PATCH] fat: Editions to support fat_fallocate()

2007-12-22 Thread Grant Likely
Thanks Steve, comments below. On 12/22/07, Steven Cavanagh <[EMAIL PROTECTED]> wrote: > From: Steven Cavanagh <[EMAIL PROTECTED]> > > Added support for fallocate for a msdos fat driver. This allows > preallocation of clusters to an inode before writes to reduce > file fragmentation Not technicall

Re: Major regression on hackbench with SLUB (more numbers)

2007-12-22 Thread Willy Tarreau
On Sat, Dec 22, 2007 at 01:00:09PM -0800, Linus Torvalds wrote: > > > On Sat, 22 Dec 2007, Theodore Tso wrote: > > > > I have a general problem with things in /sys/slab, and that's just > > because they are *ugly*. So yes, you can write ugly shell scripts > > like this to get out information: >

Re: Major regression on hackbench with SLUB (more numbers)

2007-12-22 Thread Al Viro
On Sat, Dec 22, 2007 at 01:00:09PM -0800, Linus Torvalds wrote: > > Another problem with using /sys/slab is that it is downright *ugly*. > > Why is it for example, that /sys/slab/dentry is a symlink to > > ../slab/:a-160? > > That's the only really ugly thing there. Otherwise, it's pretty nic

Re: [patch] Make MMCONFIG space (extended PCI config space) a driver opt-in issue

2007-12-22 Thread Matthew Wilcox
On Sat, Dec 22, 2007 at 08:02:49AM -0800, Arjan van de Ven wrote: > even then.. it's technically not correct; you're not supposed to mix access > types for the same device.. > Just doing opt-in also allows us to do quirks (forbid access) as well. I think what this specification means is that you

Re: Major regression on hackbench with SLUB (more numbers)

2007-12-22 Thread Linus Torvalds
On Sat, 22 Dec 2007, Theodore Tso wrote: > > I have a general problem with things in /sys/slab, and that's just > because they are *ugly*. So yes, you can write ugly shell scripts > like this to get out information: [ script deleted ] > But sometimes when trying to eyeball what is going on, i

Re: Testing RAM from userspace / question about memmap= arguments

2007-12-22 Thread Pavel Machek
On Sun 2007-12-23 07:06:58, David Newall wrote: > Pavel Machek wrote: >> memtest has following problems: >> >> 0) it is kind of hard to run memtest over ssh >> > > It's kind of hard to run anything over SSH if it has to be run before > userspace is up. But the kernel can collect results f

Re: Testing RAM from userspace / question about memmap= arguments

2007-12-22 Thread Matthew Bloch
David Newall wrote: Pavel Machek wrote: On Sat 2007-12-22 13:42:47, Richard D wrote: Cant you, modify bootmem allocator to test with memtest patterns and then use kexec (as Pavel suggested) to test the one where kernel was sitting earlier? I do not think you need to modify anything i

Re: [patch] Make MMCONFIG space (extended PCI config space) a driver opt-in issue

2007-12-22 Thread Benjamin Herrenschmidt
On Sat, 2007-12-22 at 04:31 -0800, Arjan van de Ven wrote: > Hi, > > Linus really wants the extended (4Kb) PCI configuration space (using MCFG > acpi table etc) to be opt-in, since there's many issues with it and most > drivers don't even use/need it. The idea behind opt-in is that if you don't

Re: PATCH] adding wistron_btns support for X86_64 systems.

2007-12-22 Thread Carlos Corbacho
(CC'ing linux-input, as that is the relevant subsystem list for wistron-btns). Rémi Hérilier wrote: > To use my previous patch (wistron_btns support for fujitsu-siemens amilo > pro edition v3505) with my laptop, I need to make the wistron module > compile for x86_64. It is based on Linux 2.4.24-rc

Re: Testing RAM from userspace / question about memmap= arguments

2007-12-22 Thread David Newall
Pavel Machek wrote: memtest has following problems: 0) it is kind of hard to run memtest over ssh It's kind of hard to run anything over SSH if it has to be run before userspace is up. But the kernel can collect results from a modified memtest, after it chains back. 1)

Re: [patch] Make MMCONFIG space (extended PCI config space) a driver opt-in issue

2007-12-22 Thread Martin Mares
Hello! > it's not "just a couple of chipsets", it's actually > * a whole lot of bioses > * at least one whole CPU generation > * .. > * .. > > Do you really want to code all of that into your userspace access code as > well? No, I certainly don't. But I expect this to be handled reasonably in t

Re: [patch] opt the sky2 driver into using extended config space

2007-12-22 Thread Stephen Hemminger
On Sat, 22 Dec 2007 04:35:59 -0800 Arjan van de Ven <[EMAIL PROTECTED]> wrote: > From: Arjan van de Ven <[EMAIL PROTECTED]> > Subject: opt the sky2 driver into using extended config space > > So far, the sky2 driver is the only one I've identified (with a quick grep) > that actually would be usin

  1   2   >