fib6_del_route has redundant code

2007-12-26 Thread Gui Jianfeng
Hi all, I think the following code in fib6_del_route in the latest kernel is useless. 1125 if (fn->leaf == NULL && fn->fn_flags_TL_ROOT) 1126 fn->leaf = _null_entry; ip6_null_entry will never be unlinked from fn->leaf now, that is, fn->leaf == NULL will never meet. In

Re: [PATCH 1/4] fs/autofs: Use time_before, time_before_eq, etc.

2007-12-26 Thread Julia Lawall
On Wed, 26 Dec 2007, H. Peter Anvin wrote: > Ray Lee wrote: > > On Dec 26, 2007 7:21 AM, Julia Lawall <[EMAIL PROTECTED]> wrote: > > > - if (jiffies - ent->last_usage < timeout) > > > + if (time_before(jiffies, ent->last_usage + timeout)) > > > > I don't think this is

Re: [PATCH 06/55] KVM: Per-architecture hypercall definitions

2007-12-26 Thread Avi Kivity
[copying Anthony, the original author] Pavel Machek wrote: Hi! Currently kvm provides hypercalls only for x86* architectures. To provide hypercall infrastructure for other kvm architectures I split kvm_para.h into a generic header file and architecture specific definitions. diff

Re: [PATCH 00/55] KVM patch queue review for 2.6.25 merge window (part II)

2007-12-26 Thread Avi Kivity
Sam Ravnborg wrote: On Wed, Dec 26, 2007 at 01:05:05PM +0200, Avi Kivity wrote: The second 2.6.25 kvm patch series, for your review. Three more to go. Hi Avi. A diffstat in your introduction mail would be nice so one does not have to check 50+ patches to see if it touches any file I

[PATCH linux-acpi] Fix /proc/acpi/alarm set error

2007-12-26 Thread Yi Yang
/proc/acpi/alarm can't be set correctly, here is a sample: [EMAIL PROTECTED] /]# echo "2006 09" > /proc/acpi/alarm [EMAIL PROTECTED] /]# cat /proc/acpi/alarm 2007-12-09 09:09:09 [EMAIL PROTECTED] /]# echo "2006 04" > /proc/acpi/alarm [EMAIL PROTECTED] /]# cat /proc/acpi/alarm 2007-12-04 04:04:04

2.6.24-rc6-mm1 - drivers/char/tpm/tpm_bios.c oddness?

2007-12-26 Thread Valdis . Kletnieks
On Sat, 22 Dec 2007 23:30:56 PST, Andrew Morton said: > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.24-rc6/2.6.24-rc6-mm1/ Looks like an uninitialized variable dereference for SEPARATOR events: # mount -t securityfs none /sys/kernel/security/ # ls /sys/kernel/security/ tpm0

Re: Major regression on hackbench with SLUB (more numbers)

2007-12-26 Thread Christoph Lameter
On Wed, 26 Dec 2007, Al Viro wrote: > Erm... Let me spell it out: current lifetime rules are completely broken. > As it is, create/destroy/create cache sequence will do kobject_put() on > kfree'd object. Even without people playing with holding sysfs files > open or doing IO on those. Urgh.

Re: SCSI errors on powerpc with 2.6.24-rc6-mm1

2007-12-26 Thread Balbir Singh
FUJITA Tomonori wrote: > On Thu, 27 Dec 2007 10:08:25 +0530 > Balbir Singh <[EMAIL PROTECTED]> wrote: > >> FUJITA Tomonori wrote: >>> On Mon, 24 Dec 2007 10:18:50 +0530 >>> Balbir Singh <[EMAIL PROTECTED]> wrote: >>> >> [snip] >> >>> I might break the IOMMU code. Can you reproduce it easily? If

[BUG][PATCH] bluetooth: put_device before device_del fix

2007-12-26 Thread Dave Young
Because of workqueue delay, the put_device could be called before device_del, so move it to del_conn. Signed-off-by: Dave Young <[EMAIL PROTECTED]> --- net/bluetooth/hci_conn.c | 10 +- net/bluetooth/hci_sysfs.c |1 + 2 files changed, 2 insertions(+), 9 deletions(-) diff -upr

Re: 2.6.24-rc6-mm1: __raw_spin_is_contended undefined

2007-12-26 Thread Nick Piggin
On Wed, Dec 26, 2007 at 09:21:58PM -0500, Joseph Fannin wrote: > On Sat, Dec 22, 2007 at 11:30:56PM -0800, Andrew Morton wrote: > > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.24-rc6/2.6.24-rc6-mm1/ > > > > This doesn't build on powerpc with my .config: > > In file

Re: [BUG][PATCH -mm] bluetooth : rfcomm add get/put device in del_conn

2007-12-26 Thread Dave Young
On Dec 26, 2007 11:13 AM, Dave Young <[EMAIL PROTECTED]> wrote: > > On Tue, Dec 25, 2007 at 06:07:24PM +0800, Dave Young wrote: > > On Dec 25, 2007 6:03 PM, Dave Young <[EMAIL PROTECTED]> wrote: > > > Due to 2.6.24-rc6-mm1 kernel changes (maybe kobject or driver core), If I > > > exec: > > > > >

Re: SCSI errors on powerpc with 2.6.24-rc6-mm1

2007-12-26 Thread FUJITA Tomonori
On Thu, 27 Dec 2007 10:08:25 +0530 Balbir Singh <[EMAIL PROTECTED]> wrote: > FUJITA Tomonori wrote: > > On Mon, 24 Dec 2007 10:18:50 +0530 > > Balbir Singh <[EMAIL PROTECTED]> wrote: > > > [snip] > > > > > I might break the IOMMU code. Can you reproduce it easily? If so, > > reverting my IOMMU

Re: SCSI errors on powerpc with 2.6.24-rc6-mm1

2007-12-26 Thread Balbir Singh
FUJITA Tomonori wrote: > On Mon, 24 Dec 2007 10:18:50 +0530 > Balbir Singh <[EMAIL PROTECTED]> wrote: > [snip] > > I might break the IOMMU code. Can you reproduce it easily? If so, > reverting my IOMMU patches (I've attached a patch to revert them) fix > the problem? [snip] Yes, this patch

Re: [PATCH 7/7] sg_ring: convert core ATA code to sg_ring.

2007-12-26 Thread Tejun Heo
Hello, Rusty. Rusty Russell wrote: > On Wednesday 26 December 2007 19:36:36 Tejun Heo wrote: >> It would be better to build upon sg chaining as we already have it. I >> think it can be made much easier with a bit more safe guards, >> generalization and some helpers. > > I did this work to

Re: [PATCH] net/ipv4/netfilter/ip_tables.c: remove some inlines

2007-12-26 Thread Denys Vlasenko
On Monday 17 December 2007 14:47, Patrick McHardy wrote: > Please CC netfilter-devel on netfilter patches. > > Denys Vlasenko wrote: > > Hi Patrick, Harald, > > > > I was working on unrelated problem and noticed that ip_tables.c > > seem to abuse inline. I prepared a patch which removes inlines >

[PATCH] Exporting capability code/name pairs

2007-12-26 Thread KaiGai Kohei
This patch enables to export the code/name pairs of capabilities under /capability of securityfs. In the current libcap, it obtains the list of capabilities from header file on the build environment statically. However, it is not enough portable between different versions of kernels, because an

Re: RFC: permit link(2) to work across --bind mounts ?

2007-12-26 Thread Rogelio M. Serrano Jr.
Mark Lord wrote: > Why does link(2) not support hard-linking across bind mount points > of the same underlying filesystem ? do we need link(2) at all? bind mounts are supposed to be (hard/soft) link minus the headaches. -- Democracy is about two wolves and a sheep deciding what to eat for

Re: More verizon problems

2007-12-26 Thread Bill Davidsen
Gene Heskett wrote: Resend, with more odd data from fetchmail.log appended. Just for a heads up, for about the last 8 hours, verizon, my ISP, has been inserting themselves into the path between my gmail account and my local fetchmail of this email subcription at pop.gmail.com. Worse yet

Re: SCSI errors on powerpc with 2.6.24-rc6-mm1

2007-12-26 Thread FUJITA Tomonori
On Mon, 24 Dec 2007 10:18:50 +0530 Balbir Singh <[EMAIL PROTECTED]> wrote: > Hi, > > I've just seen this on my dmesg, this is new, never seen this before on > this box and it happens only with this version of the kernel. > > In this configuration, the page size is set to 64K and I've enabled

Re: 2.6.24-rc6-mm1: some section mismatches on sparc64

2007-12-26 Thread David Miller
From: Mariusz Kozlowski <[EMAIL PROTECTED]> Date: Wed, 26 Dec 2007 13:29:07 +0100 > WARNING: vmlinux.o(.text+0x46b04): Section mismatch: reference to > .init.text:sun4v_ktsb_register (between 'smp_callin' and > 'smp_fill_in_sib_core_maps') Well known and I see them every build and so does

Re: 2.6.24-rc6-mm1: __raw_spin_is_contended undefined

2007-12-26 Thread Joseph Fannin
On Sat, Dec 22, 2007 at 11:30:56PM -0800, Andrew Morton wrote: > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.24-rc6/2.6.24-rc6-mm1/ > This doesn't build on powerpc with my .config: In file included from arch/powerpc/kernel/asm-offsets.c:17: include/linux/sched.h: In

Re: list corruption on ib_srp load in v2.6.24-rc5

2007-12-26 Thread FUJITA Tomonori
On Wed, 26 Dec 2007 12:14:11 -0500 David Dillow <[EMAIL PROTECTED]> wrote: > > On Sun, 2007-12-23 at 01:41 +0900, FUJITA Tomonori wrote: > > transport_container_unregister(>rport_attr_cont) should not fail here. > > > > It fails because there is still a srp rport. > > > > I think that as Pete

Re: 2 ports could not bond to a aggregator in 802.3ad mode issue

2007-12-26 Thread Lewis Li
Yes, you are right. The incorrect behavior is due to we don't setup the lacpdu of switch correctly. The bonding driver is correct. Thanks for your comment! I do not believe so. IEEE 802.3 section 43.3.9 states, in part, "Links that are not successful candidates for aggregation (e.g., links

Re: read-ahead in NFS server

2007-12-26 Thread Jeff Garzik
saeed bishara wrote: Hi, my NFS server seems not to utilize the read-ahead feature, my exported dir is located on ext3 fs over sata disk. the sata controller can issue commands up to 1MB, also I modified the read ahead under the sys to 1MB. but when the client do reads in 32KB chunks (rsize), I

Re: [PATCH 0/3 -mm] kexec jump -v8

2007-12-26 Thread Huang, Ying
On Wed, 2007-12-26 at 20:57 -0500, Vivek Goyal wrote: [...] > > 9. Now, you are in the original kernel again. You can read/write the > >memory image of kexeced kernel via /proc/kimgcore. > > > > Why do we need two interfaces, /proc/vmcore and /proc/kimgcore? Can't > we have just one say

Re: [PATCH 0/5] sg_ring for scsi

2007-12-26 Thread FUJITA Tomonori
On Wed, 26 Dec 2007 11:27:40 +1100 Rusty Russell <[EMAIL PROTECTED]> wrote: > On Friday 21 December 2007 15:37:46 FUJITA Tomonori wrote: > > Some scsi drivers like ips access to sglist in a tricky way. > > Indeed. I fail to see how this code works, in fact: > > drivers/scsi/ips.c:ips_queue()

Re: [PATCH 0/3 -mm] kexec jump -v8

2007-12-26 Thread Vivek Goyal
On Fri, Dec 21, 2007 at 03:33:19PM +0800, Huang, Ying wrote: [..] > The following user-space tools can be used with kexec jump. > > 1. kexec-tools needs to be patched to support kexec jump. The patches >and the precompiled kexec can be download from the following URL: >source: >

Re: [PATCH 1/3] arch/x86: Use offsetof

2007-12-26 Thread H. Peter Anvin
Jan Engelhardt wrote: On Dec 26 2007 17:01, H. Peter Anvin wrote: @@ -215,7 +215,9 @@ asmlinkage int sys_vm86old(struct pt_reg ret = -EFAULT; if (tmp) goto out; - memset(, 0, (int) - (int)); + memset(, 0, + offsetof(struct kernel_vm86_struct, regs32)

Re: [PATCH 1/3] arch/x86: Use offsetof

2007-12-26 Thread Jan Engelhardt
On Dec 26 2007 17:01, H. Peter Anvin wrote: >> > @@ -215,7 +215,9 @@ asmlinkage int sys_vm86old(struct pt_reg >> > ret = -EFAULT; >> > if (tmp) >> >goto out; >> > - memset(, 0, (int) - (int)); >> > + memset(, 0, >> > + offsetof(struct kernel_vm86_struct, regs32) - >> > +

Device node - How does kernel know about it

2007-12-26 Thread Siva Prasad
Hi, How do the device nodes work as an interface between user and kernel programs, and how to go debugging it? This is as part of my debugging effort on an embedded board. * It all started with the problem of "not printing" any thing that comes from ramdisk (echo and printf statements), while

[PATCH] SH/Dreamcast - add support for GD-Rom device

2007-12-26 Thread Adrian McMenamin
This patch adds support for the CD-Rom drive on the SEGA Dreamcast. The SEGA Dreamcast has a built in CD-Rom drive, electrically similar to an ATA-3 drive, but implementing a proprietary packet interface - the so-called Sega Packet Interface (SPI)- and also supporting a proprietary format of disk

REISER4: Attention Edward Shishkin - reiser4progs-1.0.6

2007-12-26 Thread joejamesjoyce
REISER4: Attention Edward Shishkin (reiser4progs-1.0.6) - - Hi Edward, it has been pointed out that you CHANGED reiser4progs-1.0.6 in your version http://chichkin_i.zelnet.ru/namesys/reiser4progs-1.0.6.tar.gz from the

Re: [PATCH 1/3] arch/x86: Use offsetof

2007-12-26 Thread H. Peter Anvin
Al Viro wrote: On Wed, Dec 26, 2007 at 05:01:38PM -0800, H. Peter Anvin wrote: The right way to do it is: memset(, 0, sizeof info.vm86plus); If it's just one field _and_ we don't have padding we want to zero out - certainly... It is - [comments removed for clarity]: struct

REISER4: Attention Edward Shishkin (reiser4progs-1.0.6)

2007-12-26 Thread joejamesjoyce
REISER4: Attention Edward Shishkin (reiser4progs-1.0.6) - - Hi Edward, it has been pointed out that you CHANGED reiser4progs-1.0.6 in your version http://chichkin_i.zelnet.ru/namesys/reiser4progs-1.0.6.tar.gz from the

Re: [PATCH 1/3] arch/x86: Use offsetof

2007-12-26 Thread Al Viro
On Wed, Dec 26, 2007 at 05:01:38PM -0800, H. Peter Anvin wrote: > The right way to do it is: > > memset(, 0, sizeof info.vm86plus); If it's just one field _and_ we don't have padding we want to zero out - certainly... -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH 1/3] arch/x86: Use offsetof

2007-12-26 Thread H. Peter Anvin
Pavel Machek wrote: diff -u -p a/arch/x86/kernel/vm86_32.c b/arch/x86/kernel/vm86_32.c --- a/arch/x86/kernel/vm86_32.c 2007-10-22 11:25:00.0 +0200 +++ b/arch/x86/kernel/vm86_32.c 2007-12-26 16:27:15.0 +0100 @@ -215,7 +215,9 @@ asmlinkage int sys_vm86old(struct pt_reg ret

Re: [PATCH 7/7] sg_ring: convert core ATA code to sg_ring.

2007-12-26 Thread Rusty Russell
On Wednesday 26 December 2007 19:36:36 Tejun Heo wrote: > It would be better to build upon sg chaining as we already have it. I > think it can be made much easier with a bit more safe guards, > generalization and some helpers. Hi Tejun, I did this work to replace sg chaining. The current

Re: [PATCH 02/16] adapt lguest launcher to per-cpuness

2007-12-26 Thread Rusty Russell
On Thursday 27 December 2007 01:24:10 Steven Rostedt wrote: > On Wed, 26 Dec 2007, Rusty Russell wrote: > > On Friday 21 December 2007 00:33:42 Glauber de Oliveira Costa wrote: > > > + if (!vcpu_id) { > > > + /* > > > + * Service input, then unset the BREAK

Re: Trying to convert old modules to newer kernels

2007-12-26 Thread Bill Davidsen
Lennart Sorensen wrote: On Thu, Dec 20, 2007 at 04:27:37PM -0500, linux-os (Dick Johnson) wrote: I need to get rid of -mregparm=3 on gcc's command line. It is completely incompatible with the standard calling conventions used in all our assembly-language files in our drivers. We make very

Re: Trying to convert old modules to newer kernels

2007-12-26 Thread Bill Davidsen
James Courtier-Dutton wrote: J.A. Magallón wrote: I need to get rid of -mregparm=3 on gcc's command line. It is completely incompatible with the standard calling conventions used in all our assembly-language files in our drivers. We make very high-speed number-crunching drivers that munge

Re: 2.6.24-rc6-mm1 - e1000 breakage

2007-12-26 Thread James Morris
On Wed, 26 Dec 2007, Andrew Morton wrote: > > (under current -mm, the e1000 driver doesn't find my ethernet card & the > > tcl tests won't run without an external interface). > > You might need to enable CONFIG_E1000E. Indeed, it works for me. - James -- James Morris <[EMAIL PROTECTED]>

Re: [RFC] sleepy linux

2007-12-26 Thread Oliver Neukum
Am Mittwoch, 26. Dezember 2007 21:32:58 schrieb Pavel Machek: > On Wed 2007-12-26 21:23:37, Oliver Neukum wrote: > > Am Mittwoch, 26. Dezember 2007 21:17:22 schrieb Pavel Machek: > > > Is there an easy way to tell if all the devices are runtime suspended? > > > > Do you really want to know

atimes not updated over NFS

2007-12-26 Thread Andre Majorel
After upgrading an NFS server from kernel 2.6.12 to 2.6.23, the atime of files is not updated any more when clients read them : client$ ll -u --time-style +%Y-%m-%d_%H:%M:%S /nfsmnt/zz -rw-r--r-- 1 xxx xxx 0 2007-12-21_14:58:11 /nfsmnt/zz client$ md5sum /nfsmnt/zz

Re: Correct use of __init and __devinit

2007-12-26 Thread Haavard Skinnemoen
On Mon, 24 Dec 2007 14:01:43 +0100 Sam Ravnborg <[EMAIL PROTECTED]> wrote: > So of the principle of least suprise it is best to use __devinit > for the probe function as most other drivers do. And if > the driver model happens to call your probe function after > init time then we will not oops.

Re: 2 ports could not bond to a aggregator in 802.3ad mode issue

2007-12-26 Thread Jay Vosburgh
>After the setting, I cat the proc entry and got the following information [...] >802.3ad info >LACP rate: slow >Active Aggregator Info: >Aggregator ID: 1 >Number of ports: 2 >Actor Key: 17 >Partner Key: 1 >Partner Mac Address: 00:00:00:00:00:00 [...] >The

Re: 2.6.24-rc6-mm1 - git-lblnet.patch and networking horkage

2007-12-26 Thread Andrew Morton
On Thu, 27 Dec 2007 01:16:25 +1100 (EST) James Morris <[EMAIL PROTECTED]> wrote: > On Wed, 26 Dec 2007, James Morris wrote: > > > What does the following say ? > > > > # sestatus && rpm -q selinux-policy > > Don't worry about that -- I reproduced it with Paul Moore's git tree: >

Re: [PATCH] w1-gpio: Add GPIO w1 bus master driver

2007-12-26 Thread Haavard Skinnemoen
On Fri, 21 Dec 2007 09:34:01 +0200 Ville Syrjala <[EMAIL PROTECTED]> wrote: > +static struct platform_device foo_w1_device = { > + .name = "w1-gpio", > + .id = -1, Assigning -1 to a u32 member isn't a very nice example. What does it mean anyway? >

Re: Major regression on hackbench with SLUB (more numbers)

2007-12-26 Thread Al Viro
On Wed, Dec 26, 2007 at 01:31:35PM -0800, Christoph Lameter wrote: > On Mon, 24 Dec 2007, Theodore Tso wrote: > > > So two questions: why isn't -f the default? And is /sys/slab > > Because it gives misleading output. It displays the name of the first > of multiple slabs that share the same

Re: [PATCH] ide-cd: move the remaining cdrom.c ioctl handling code to ide-cd_ioctl.c

2007-12-26 Thread Borislav Petkov
On Wed, Dec 26, 2007 at 09:50:14PM +0100, Borislav Petkov wrote: Actually you should drop the previous one for it wasn't incomplete. Here's, hopefully, a better one :). -- From: Borislav Petkov <[EMAIL PROTECTED]> There should be no functional changes from this. Signed-off-by: Borislav Petkov

Re: 2.6.24-rc6-mm1 - git-lblnet.patch and networking horkage

2007-12-26 Thread James Morris
On Thu, 26 Dec 2007, Paul Moore wrote: > As James said I'm away right now and computer access is limited. > However, I'm stuck in the airport right now and spent some time looking > at the code ... Based on what has been found so far I wonder if the > problem isn't a race but a problem of

Re: Major regression on hackbench with SLUB (more numbers)

2007-12-26 Thread Christoph Lameter
On Mon, 24 Dec 2007, Theodore Tso wrote: > So two questions: why isn't -f the default? And is /sys/slab Because it gives misleading output. It displays the name of the first of multiple slabs that share the same storage structures. -- To unsubscribe from this list: send the line "unsubscribe

Re: [PATCH] slub: /proc/slabinfo ABI compatibility

2007-12-26 Thread Christoph Lameter
On Mon, 24 Dec 2007, Pekka Enberg wrote: > On Dec 24, 2007 9:12 PM, Christoph Lameter <[EMAIL PROTECTED]> wrote: > > Hmmm... What is the combination of config variables that causes this? I > > moved the count_partial function in mm in order to make the merge of slab > > defrag easier. > > I

Re: [Suspend-devel] Fwd: Kernel Oops with 2.6.23

2007-12-26 Thread Pavel Machek
On Mon 2007-12-17 21:45:54, Ritesh Raj Sarraf wrote: > On Tuesday 04 December 2007, Pavel Machek wrote: > > On Mon 2007-12-03 06:01:26, Ritesh Raj Sarraf wrote: > > > On Sunday 02 December 2007, Pavel Machek wrote: > > > > killall -9 pulseaudio. If pulseaudio is not dead within 60 seconds, > > > >

Re: 2.6.22-stable causes oomkiller to be invoked

2007-12-26 Thread Christoph Lameter
On Fri, 21 Dec 2007, Dhaval Giani wrote: > No, it does not stop the oom I am seeing here. Duh. Disregard that patch. It looks like check_pgt_cache() is not called. This could happen if tlb_flush_mmu is never called during the fork/terminate sequences in your script. pgd_free is called *after*

Re: Regarding request for IBM camera patch to be applied to the main tree

2007-12-26 Thread David Hilvert
On Fri, 21 Dec 2007 14:32:09 -0800 Greg KH <[EMAIL PROTECTED]> wrote: > On Fri, Dec 21, 2007 at 03:21:30PM -0600, David Hilvert wrote: > > > > http://www.linux-usb.org/ibmcam/ > > > > > > http://auricle.dyndns.org/xvp610/ > > > > [Remainder of private e-mail context snipped; message has been

Re: [RFC] sleepy linux

2007-12-26 Thread H. Peter Anvin
Pavel Machek wrote: On Wed 2007-12-26 12:43:56, H. Peter Anvin wrote: Oliver Neukum wrote: Am Mittwoch, 26. Dezember 2007 19:56:59 schrieb H. Peter Anvin: 3) Network card that is either down or can wake up system on any packet (and not loose too many packets) This is the big crux I see.

[PATCH] ide-cd: move the remaining cdrom.c ioctl handling code to ide-cd_ioctl.c

2007-12-26 Thread Borislav Petkov
Hi Bart, the following moves the remaining cdrom.c ioctl-related pieces to their proper location. It applies on top of your 63 redux patches and shouldn't be changing anything in the current functionality of the driver. -- From: Borislav Petkov <[EMAIL PROTECTED]> There should be no functional

Re: [RFC] sleepy linux

2007-12-26 Thread Pavel Machek
On Wed 2007-12-26 12:43:56, H. Peter Anvin wrote: > Oliver Neukum wrote: >> Am Mittwoch, 26. Dezember 2007 19:56:59 schrieb H. Peter Anvin: 3) Network card that is either down or can wake up system on any packet (and not loose too many packets) >>> This is the big crux I see.

Re: [PATCH] x86_64: fix problems due to use of "outb" to port 80 on some AMD64x2 laptops, etc.

2007-12-26 Thread Pavel Machek
On Sun 2007-12-16 15:34:58, H. Peter Anvin wrote: > Pavel Machek wrote: >> Hi! >>> The process of safely making delicate changes here is beyond my >>> responsibility as just a user - believe me, I'm not suggesting that a >>> risky fix be put in .24. I can patch my own kernels, and I can even

Re: [PATCH 00/55] KVM patch queue review for 2.6.25 merge window (part II)

2007-12-26 Thread Sam Ravnborg
On Wed, Dec 26, 2007 at 01:05:05PM +0200, Avi Kivity wrote: > The second 2.6.25 kvm patch series, for your review. Three more to go. Hi Avi. A diffstat in your introduction mail would be nice so one does not have to check 50+ patches to see if it touches any file I can give feedback on.

Re: [PATCH 1/4] fs/autofs: Use time_before, time_before_eq, etc.

2007-12-26 Thread H. Peter Anvin
Ray Lee wrote: On Dec 26, 2007 7:21 AM, Julia Lawall <[EMAIL PROTECTED]> wrote: - if (jiffies - ent->last_usage < timeout) + if (time_before(jiffies, ent->last_usage + timeout)) I don't think this is a safe change? subtraction is always safe (if you think about it

Re: [RFC] sleepy linux

2007-12-26 Thread H. Peter Anvin
Oliver Neukum wrote: Am Mittwoch, 26. Dezember 2007 19:56:59 schrieb H. Peter Anvin: 3) Network card that is either down or can wake up system on any packet (and not loose too many packets) This is the big crux I see. You're going to constantly wake up the machine due to broadcast

Re: tlb_finish_mmu() bogisity

2007-12-26 Thread Christoph Lameter
Argh. This is indeed bogus. The one reporting the problem states that the patch did not address the issue. The report was regarding pgd freeing which is handled slightly differently from pte frees. [PATCH] Revert quicklist need->flush fix Did not fix the reported issue. Apart from other

Re: Testing RAM from userspace / question about memmap= arguments

2007-12-26 Thread Maxim Levitsky
В сообщении от Wednesday 26 December 2007 12:17:56 Arjan van de Ven написал(а): > On Wed, 26 Dec 2007 00:09:57 +0100 > Pavel Machek <[EMAIL PROTECTED]> wrote: > > > On Sat 2007-12-22 12:09:59, Arjan van de Ven wrote: > > > On Tue, 18 Dec 2007 17:06:24 + > > > > memtest86+ does various magic

[PATCH] aoe: document the behavior of /dev/etherd/err

2007-12-26 Thread Ed L. Cashin
Signed-off-by: Ed L. Cashin <[EMAIL PROTECTED]> --- drivers/block/aoe/aoechr.c |4 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/drivers/block/aoe/aoechr.c b/drivers/block/aoe/aoechr.c index 2620073..871f284 100644 --- a/drivers/block/aoe/aoechr.c +++

Re: [RFC] sleepy linux

2007-12-26 Thread Pavel Machek
On Wed 2007-12-26 21:23:37, Oliver Neukum wrote: > Am Mittwoch, 26. Dezember 2007 21:17:22 schrieb Pavel Machek: > > On Wed 2007-12-26 18:28:04, Oliver Neukum wrote: > > > Am Mittwoch, 26. Dezember 2007 00:07:31 schrieb Pavel Machek: > > > > Heute 00:07:31 > > > >   > > > > This is RFC. It does

[PATCH] aoe: initialize locking structures before registering char devices

2007-12-26 Thread Ed L. Cashin
This patch was made against 2.6.24-rc6-mm1. In March 2007, Alexey Dobriyan suggested this change, which eliminates a race after register_chardev has been called but the locking primitives protecting the error messages ring buffer have not yet been initialized. The initialization could happen at

Re: [linux-pm] [RFC] sleepy linux

2007-12-26 Thread Igor Stoppa
Hi, On Wed, 2007-12-26 at 00:07 +0100, ext Pavel Machek wrote: > This is RFC. It does not even work for me... it sleeps but it will not > wake up, because SATA wakeup code is missing. Code attached for illustration. > > I wonder if this is the right approach? What is right interface to the >

Re: [RFC] sleepy linux

2007-12-26 Thread Oliver Neukum
Am Mittwoch, 26. Dezember 2007 21:17:22 schrieb Pavel Machek: > On Wed 2007-12-26 18:28:04, Oliver Neukum wrote: > > Am Mittwoch, 26. Dezember 2007 00:07:31 schrieb Pavel Machek: > > > Heute 00:07:31 > > >   > > > This is RFC. It does not even work for me... it sleeps but it will not > > > wake

Re: [RFC] sleepy linux

2007-12-26 Thread Pavel Machek
On Wed 2007-12-26 18:28:04, Oliver Neukum wrote: > Am Mittwoch, 26. Dezember 2007 00:07:31 schrieb Pavel Machek: > > Heute 00:07:31 > >   > > This is RFC. It does not even work for me... it sleeps but it will not > > wake up, because SATA wakeup code is missing. Code attached for > >

Re: [RFC] sleepy linux

2007-12-26 Thread Oliver Neukum
Am Mittwoch, 26. Dezember 2007 19:56:59 schrieb H. Peter Anvin: > > 3) Network card that is either down > >    or can wake up system on any packet (and not loose too many packets) > > > > This is the big crux I see.  You're going to constantly wake up the > machine due to broadcast packets, and

Re: [PATCH 1/4] fs/autofs: Use time_before, time_before_eq, etc.

2007-12-26 Thread Ray Lee
On Dec 26, 2007 7:21 AM, Julia Lawall <[EMAIL PROTECTED]> wrote: > - if (jiffies - ent->last_usage < timeout) > + if (time_before(jiffies, ent->last_usage + timeout)) I don't think this is a safe change? subtraction is always safe (if you think about it as 'distance'),

Re: [PATCHv2] powerpc: DBox2 Board Support

2007-12-26 Thread Arnd Bergmann
On Wednesday 26 December 2007, Jochen Friedrich wrote: > >> + memory { > >> + device_type = "memory"; > >> + reg = <0 200>; > >> + }; > > > > I thought there are both models with 32MB and 16MB available. > > If that's true, shouldn't this be filled out by the boot loader?

Re: [PATCH 1/3] arch/x86: Use offsetof

2007-12-26 Thread Pavel Machek
Hi! > From: Julia Lawall <[EMAIL PROTECTED]> > > In the patch cc154ac64aa8d3396b187f64cef01ce67f433324, Al Viro observed > that the proper way to compute the distance between two structure fields is > to use offsetof() or a cast to a pointer to character. The same change can > be applied to a

Re: [PATCH 1/4] fs/autofs: Use time_before, time_before_eq, etc.

2007-12-26 Thread Julia Lawall
On Wed, 26 Dec 2007, H. Peter Anvin wrote: > Julia Lawall wrote: > > From: Julia Lawall <[EMAIL PROTECTED]> > > > > The functions time_before, time_before_eq, time_after, and time_after_eq > > are more robust for comparing jiffies against other values. > > > > More robust, how? You already

Re: [PATCH 06/55] KVM: Per-architecture hypercall definitions

2007-12-26 Thread Pavel Machek
Hi! > Currently kvm provides hypercalls only for x86* architectures. To > provide hypercall infrastructure for other kvm architectures I split > kvm_para.h into a generic header file and architecture specific > definitions. > > Signed-off-by: Christian Borntraeger <[EMAIL PROTECTED]> >

Re: [PATCH 09/13] remove race between use and initialization of locks

2007-12-26 Thread Ed L. Cashin
On Fri, Dec 21, 2007 at 10:00:40PM -0800, Andrew Morton wrote: > On Thu, 20 Dec 2007 17:15:57 -0500 "Ed L. Cashin" <[EMAIL PROTECTED]> wrote: ... > > +static __DECLARE_SEMAPHORE_GENERIC(emsgs_sema, 0); ... > > - sema_init(_sema, 0); > > - spin_lock_init(_lock); > > aoe_class =

Re: [RFC] sleepy linux

2007-12-26 Thread H. Peter Anvin
Pavel Machek wrote: Yep... for the first version, I'll be very happy if it autosleeps when I'm traveling by bus or something. Working with ethernet plugged in is quite a distant goal. (But I guess some cleverness could be done on the router or something. Automagically converting "interesting"

Re: [RFC] sleepy linux

2007-12-26 Thread Pavel Machek
On Wed 2007-12-26 18:28:04, Oliver Neukum wrote: > Am Mittwoch, 26. Dezember 2007 00:07:31 schrieb Pavel Machek: > > Heute 00:07:31 > >   > > This is RFC. It does not even work for me... it sleeps but it will not > > wake up, because SATA wakeup code is missing. Code attached for > >

Re: [RFC] sleepy linux

2007-12-26 Thread Pavel Machek
On Wed 2007-12-26 10:56:59, H. Peter Anvin wrote: > Pavel Machek wrote: >> This is RFC. It does not even work for me... it sleeps but it will not >> wake up, because SATA wakeup code is missing. Code attached for >> illustration. >> I wonder if this is the right approach? What is right interface

Re: [RFC] sleepy linux

2007-12-26 Thread H. Peter Anvin
Pavel Machek wrote: This is RFC. It does not even work for me... it sleeps but it will not wake up, because SATA wakeup code is missing. Code attached for illustration. I wonder if this is the right approach? What is right interface to the drivers? 3) Network card that is either down or can

Order of Loading mmc driver modules.

2007-12-26 Thread raki john
Hi All, I am working with pxamci driver(2.6.22.1). I have made , core and host as separate modules. what is the correct order of loading the modules i am doing in this order first core (mmc_core.ko), then card(mmc_block.ko) after that host driver ( pxamci.ko). Is this correct. I do not know

Re: /dev/urandom uses uninit bytes, leaks user data

2007-12-26 Thread Phillip Susi
Andrew Lutomirski wrote: No, it's there, and if there's little enough entropy around it can be recovered by brute force. A little entropy is enough to prevent a brute force attack. You would have to have ZERO entropy after a cold boot so the attacker would know exactly the contents of the

Re: Why does reading from /dev/urandom deplete entropy so much?

2007-12-26 Thread Phillip Susi
Marc Haber wrote: On Tue, Dec 11, 2007 at 10:42:49AM -0500, Bill Davidsen wrote: The original point was that urandom draws entropy from random, and that it is an an inobvious and unintentional drain on the entropy pool. At least that's how I read it. And you are reading it correct. At least

Re: [x86] is checkpatch.pl broken

2007-12-26 Thread Cyrill Gorcunov
[H. Peter Anvin - Wed, Dec 26, 2007 at 09:44:18AM -0800] > Cyrill Gorcunov wrote: >> >>> >> It's a quite true, sorry for this and thanks for the note. And Peter, >> the line I marked >> is not to be splitted even having additional spaces over math operators. >> Look >> >> orig: >> mbr_base =

Re: VGA Drivers

2007-12-26 Thread Kok, Auke
pradeep pradeep wrote: > Hi, > I want to support a new PCI based VGA card in > linux. I want to know what is the VGA driver stack in > the Linux. Can any one help me where to start. Assuming you're not talking about a VGA grabber card here... Graphics/ X drivers are mostly in userspace

Re: Suspend code ordering (again)

2007-12-26 Thread H. Peter Anvin
Alexey Starikovskiy wrote: I don't know. Windows was compliant only with 1.x spec until Vista. With Vista claims are 3.x compliance. In other words, the 1.x spec is the only thing that matters, at least in the short term (*noone* is giving up XP compatibility at this point.)

Re: [PATCH 1/4] fs/autofs: Use time_before, time_before_eq, etc.

2007-12-26 Thread H. Peter Anvin
Julia Lawall wrote: From: Julia Lawall <[EMAIL PROTECTED]> The functions time_before, time_before_eq, time_after, and time_after_eq are more robust for comparing jiffies against other values. More robust, how? You already almost introduced a bug here... -hpa -- To unsubscribe from

Re: [x86] is checkpatch.pl broken

2007-12-26 Thread H. Peter Anvin
Cyrill Gorcunov wrote: It's a quite true, sorry for this and thanks for the note. And Peter, the line I marked is not to be splitted even having additional spaces over math operators. Look orig: mbr_base = (buf_base+sector_size-1) & ~(sector_size-1); new (could be): mbr_base = (buf_base +

Re: [RFC] sleepy linux

2007-12-26 Thread Oliver Neukum
Am Mittwoch, 26. Dezember 2007 00:07:31 schrieb Pavel Machek: > Heute 00:07:31 >   > This is RFC. It does not even work for me... it sleeps but it will not > wake up, because SATA wakeup code is missing. Code attached for illustration. > > I wonder if this is the right approach? What is right

Re: list corruption on ib_srp load in v2.6.24-rc5

2007-12-26 Thread David Dillow
On Sun, 2007-12-23 at 01:41 +0900, FUJITA Tomonori wrote: > transport_container_unregister(>rport_attr_cont) should not fail here. > > It fails because there is still a srp rport. > > I think that as Pete pointed out, srp_remove_one needs to call > srp_remove_host. > > Can you try this? That

Re: [PATCH 7/7] sg_ring: convert core ATA code to sg_ring.

2007-12-26 Thread James Bottomley
On Wed, 2007-12-26 at 17:36 +0900, Tejun Heo wrote: > (PS, I haven't followed the sg chaining discussion. Why is sg chaining > an optional feature? Performance overhead on low end machines?) The idea of SG chaining is to allow drivers that wish to take advantage of it to increase their

Re: Testing RAM from userspace / question about memmap= arguments

2007-12-26 Thread Arjan van de Ven
On Wed, 26 Dec 2007 00:09:57 +0100 Pavel Machek <[EMAIL PROTECTED]> wrote: > On Sat 2007-12-22 12:09:59, Arjan van de Ven wrote: > > On Tue, 18 Dec 2007 17:06:24 + > > memtest86+ does various magic to basically bypass the caches (by > > disabling them ;-)... Doing that in a live kernel

Re: 2.6.24-rc6-mm1 - git-lblnet.patch and networking horkage

2007-12-26 Thread Valdis . Kletnieks
On Wed, 26 Dec 2007 19:52:56 +1100, James Morris said: > On Wed, 26 Dec 2007, [EMAIL PROTECTED] wrote: > > > On Wed, 26 Dec 2007 18:34:26 +1100, James Morris said: > > > > > Can you post your .config ? > > > > The gzip'ed config as of when I quit bisecting is attached. It's probably > > not

Re: TOMOYO Linux Security Goal

2007-12-26 Thread Serge E. Hallyn
Quoting Tetsuo Handa ([EMAIL PROTECTED]): > This document is intended to specify the security goal that TOMOYO Linux is > trying to achieve, so that users can evaluate whether TOMOYO Linux will meet > their needs, and kernel developers can evaluate whether TOMOYO Linux deserved > to be in-tree. >

[PATCH 3/3] drivers/scsi: Use offsetof

2007-12-26 Thread Julia Lawall
From: Julia Lawall <[EMAIL PROTECTED]> In the patch cc154ac64aa8d3396b187f64cef01ce67f433324, Al Viro observed that the proper way to compute the distance between two structure fields is to use offsetof() or a cast to a pointer to character. The same change can be applied to a few more files.

[PATCH 2/3] drivers/s390: Use offsetof

2007-12-26 Thread Julia Lawall
From: Julia Lawall <[EMAIL PROTECTED]> In the patch cc154ac64aa8d3396b187f64cef01ce67f433324, Al Viro observed that the proper way to compute the distance between two structure fields is to use offsetof() or a cast to a pointer to character. The same change can be applied to a few more files.

[PATCH 1/3] arch/x86: Use offsetof

2007-12-26 Thread Julia Lawall
From: Julia Lawall <[EMAIL PROTECTED]> In the patch cc154ac64aa8d3396b187f64cef01ce67f433324, Al Viro observed that the proper way to compute the distance between two structure fields is to use offsetof() or a cast to a pointer to character. The same change can be applied to a few more files.

Re: 2.6.24-rc6-mm1 - git-lblnet.patch and networking horkage

2007-12-26 Thread Paul Moore
As James said I'm away right now and computer access is limited. However, I'm stuck in the airport right now and spent some time looking at the code ... Based on what has been found so far I wonder if the problem isn't a race but a problem of skb->iif never being initialized correctly? To my

Re: [PATCH 00/63] ide-cd: redux

2007-12-26 Thread Borislav Petkov
On Tue, Dec 25, 2007 at 02:05:14PM -0800, Andrew Morton wrote: > On Thu, 20 Dec 2007 01:48:49 +0100 Bartlomiej Zolnierkiewicz <[EMAIL > PROTECTED]> wrote: > > > This patch series is a major rework of the ide-cd driver. > > woo-hoo. > > > PS ide-cd Maintainer position is still open... > >

  1   2   3   4   >