Re: Scheduler(?) regression from 2.6.22 to 2.6.24 for short-lived threads

2008-02-09 Thread Willy Tarreau
On Sun, Feb 10, 2008 at 01:00:56AM -0600, Olof Johansson wrote: > On Sun, Feb 10, 2008 at 07:15:58AM +0100, Willy Tarreau wrote: > > On Sat, Feb 09, 2008 at 11:29:41PM -0600, Olof Johansson wrote: > > > 40M: > > > 2.6.22time 94315 ms > > > 2.6.23time 107930 ms > > > 2.6.24

Re: [3/6] kgdb: core

2008-02-09 Thread Christoph Hellwig
On Sun, Feb 10, 2008 at 08:43:52AM +0100, Ingo Molnar wrote: > > * Christoph Hellwig <[EMAIL PROTECTED]> wrote: > > > This still doesn't address a lot of the review comments from Jason's > > last posting. > > sorry, which mails are those? It's all in the thread starting with '[PATCH 0/8] kgdb

panic about sysfs with adm1026

2008-02-09 Thread Yinghai Lu
Calling initcall 0x80c4b575: sm_adm1026_init+0x0/0xe() i2c-adapter i2c-1: : Unrecognized stepping 0x45. Defaulting to ADM1026. general protection fault: [1] SMP CPU 0 Modules linked in: Pid: 1, comm: swapper Not tainted 2.6.24-smp-09379-g0cf975e-dirty #34 RIP: 0010:[] []

Re: [3/6] kgdb: core

2008-02-09 Thread Ingo Molnar
* Christoph Hellwig <[EMAIL PROTECTED]> wrote: > This still doesn't address a lot of the review comments from Jason's > last posting. sorry, which mails are those? Ingo -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL

Re: [PATCH 2.6.24-mm1] Mempolicy: silently restrict nodemask to allowed nodes V3

2008-02-09 Thread Linus Torvalds
On Sat, 9 Feb 2008, Greg KH wrote: > > Once the patch goes into Linus's tree, feel free to send it to the > [EMAIL PROTECTED] address so that we can include it in the 2.6.24.x > tree. I've been ignoring the patches because they say "PATCH 2.6.24-mm1", and so I simply don't know whether it's

Re: [5/6] x86: kgdb support

2008-02-09 Thread Ingo Molnar
* Sam Ravnborg <[EMAIL PROTECTED]> wrote: > > config X86_64 > > def_bool 64BIT > > + select KGDB_ARCH_HAS_SHADOW_INFO > > > > ### Arch settings > > config X86 > > @@ -139,6 +140,9 @@ config AUDIT_ARCH > > config ARCH_SUPPORTS_AOUT > > def_bool y > > > > +config

Re: [0/6] kgdb light

2008-02-09 Thread David Miller
From: Ingo Molnar <[EMAIL PROTECTED]> Date: Sun, 10 Feb 2008 08:13:04 +0100 > this is the "kgdb light" tree that has been also posted at: > >http://lkml.org/lkml/2008/2/9/236 > > it is available at: > >git://git.kernel.org/pub/scm/linux/kernel/git/mingo/linux-2.6-kgdb.git > > See the

Re: [1/6] pids: add pid_max prototype

2008-02-09 Thread Christoph Hellwig
On Sun, Feb 10, 2008 at 08:13:21AM +0100, Ingo Molnar wrote: > From: Ingo Molnar <[EMAIL PROTECTED]> > > add pid_max prototype - used by sysctl and will be used by kgdb as well. Looks good, and this should go in ASAP independent of kgdb. And while you're at it, I think all of the below want to

Re: [3/6] kgdb: core

2008-02-09 Thread Christoph Hellwig
This still doesn't address a lot of the review comments from Jason's last posting. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at

Re: [5/6] x86: kgdb support

2008-02-09 Thread Sam Ravnborg
On Sun, Feb 10, 2008 at 08:13:45AM +0100, Ingo Molnar wrote: > From: Ingo Molnar <[EMAIL PROTECTED]> > > simplified and streamlined kgdb support on x86, both 32-bit and 64-bit, > based on patch from: > > Subject: kgdb: core-lite > From: Jason Wessel <[EMAIL PROTECTED]> > > [ and countless

Re: [3/6] kgdb: core

2008-02-09 Thread Sam Ravnborg
On Sun, Feb 10, 2008 at 08:13:31AM +0100, Ingo Molnar wrote: > From: Jason Wessel <[EMAIL PROTECTED]> > > kgdb core code. Handles the protocol and the arch details. > > [ [EMAIL PROTECTED]: heavily modified, simplified and cleaned up. ] Hi Ingo. I see that only a very few of my comments posted

[18/19] ftrace: add ftrace_enabled sysctl to disable mcount function

2008-02-09 Thread Ingo Molnar
From: Steven Rostedt <[EMAIL PROTECTED]> This patch adds back the sysctl ftrace_enabled. This time it is defaulted to on, if DYNAMIC_FTRACE is configured. When ftrace_enabled is disabled, the ftrace function is set to the stub return. If DYNAMIC_FTRACE is also configured, on ftrace_enabled = 0,

[19/19] ftrace

2008-02-09 Thread Ingo Molnar
[ uhm, i cannot count apparently :-) There's no 19th patch. ] -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at

[17/19] ftrace: dynamic enabling/disabling of function calls

2008-02-09 Thread Ingo Molnar
From: Steven Rostedt <[EMAIL PROTECTED]> This patch adds a feature to dynamically replace the ftrace code with the jmps to allow a kernel with ftrace configured to run as fast as it can without it configured. The way this works, is on bootup, a ftrace function is registered to record the

[16/19] ftrace: trace preempt off critical timings

2008-02-09 Thread Ingo Molnar
From: Steven Rostedt <[EMAIL PROTECTED]> Add preempt off timings. A lot of kernel core code is taken from the RT patch latency trace that was written by Ingo Molnar. This adds "preemptoff" and "preemptirqsoff" to /debugfs/tracing/available_tracers Now instead of just tracing irqs off,

[15/19] ftrace: trace irq disabled critical timings

2008-02-09 Thread Ingo Molnar
From: Steven Rostedt <[EMAIL PROTECTED]> This patch adds latency tracing for critical timings (how long interrupts are disabled for). "irqsoff" is added to /debugfs/tracing/available_tracers Note: tracing_max_latency also holds the max latency for irqsoff (in usecs). (default to large

[14/19] ftrace: tracer for scheduler wakeup latency

2008-02-09 Thread Ingo Molnar
From: Steven Rostedt <[EMAIL PROTECTED]> This patch adds the tracer that tracks the wakeup latency of the highest priority waking task. "wakeup" is added to /debugfs/tracing/available_tracers Also added to /debugfs/tracing tracing_max_latency holds the current max latency for the

[12/19] ftrace: function tracer

2008-02-09 Thread Ingo Molnar
From: Steven Rostedt <[EMAIL PROTECTED]> This is a simple trace that uses the ftrace infrastructure. It is designed to be fast and small, and easy to use. It is useful to record things that happen over a very short period of time, and not to analyze the system in general. Updates:

[13/19] ftrace: add tracing of context switches

2008-02-09 Thread Ingo Molnar
From: Steven Rostedt <[EMAIL PROTECTED]> This patch adds context switch tracing, of the format of: _--=> CPU# / _-=> irqs-off | / _=> need-resched || / _---=> hardirq/softirq ||| / _--=> preempt-depth

[11/19] ftrace: latency tracer infrastructure

2008-02-09 Thread Ingo Molnar
From: Steven Rostedt <[EMAIL PROTECTED]> This patch adds the latency tracer infrastructure. This patch does not add anything that will select and turn it on, but will be used by later patches. If it were to be compiled, it would add the following files to the debugfs: The root tracing

[10/19] ftrace: add basic support for gcc profiler instrumentation

2008-02-09 Thread Ingo Molnar
From: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> If CONFIG_FTRACE is selected and /proc/sys/kernel/ftrace_enabled is set to a non-zero value the ftrace routine will be called everytime we enter a kernel function that is not marked with the "notrace" attribute. The ftrace routine will then call

[09/19] ftrace: add notrace annotations for NMI routines

2008-02-09 Thread Ingo Molnar
From: Steven Rostedt <[EMAIL PROTECTED]> This annotates NMI functions with notrace. Some tracers may be able to live with this, but some cannot. The safest is to turn it off, it's not particularly interesting anyway. Signed-off-by: Steven Rostedt <[EMAIL PROTECTED]> Signed-off-by: Ingo Molnar

[07/19] x86: add notrace annotations to vsyscall.

2008-02-09 Thread Ingo Molnar
From: Steven Rostedt <[EMAIL PROTECTED]> Add the notrace annotations to the vsyscall functions - there we are not in kernel context yet, so the tracer function cannot (and must not) be called. Signed-off-by: Steven Rostedt <[EMAIL PROTECTED]> Signed-off-by: Ingo Molnar <[EMAIL PROTECTED]> ---

[08/19] ftrace: annotate core code that should not be traced

2008-02-09 Thread Ingo Molnar
From: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> Mark with "notrace" functions in core code that should not be traced. The "notrace" attribute will prevent gcc from adding a call to ftrace on the annotated funtions. Signed-off-by: Arnaldo Carvalho de Melo <[EMAIL PROTECTED]> Signed-off-by:

Re: [PATCH] Change pci_raw_ops to pci_raw_read/write

2008-02-09 Thread Greg KH
On Sat, Feb 09, 2008 at 10:25:23PM -0800, Yinghai Lu wrote: > On Feb 9, 2008 4:41 AM, Matthew Wilcox <[EMAIL PROTECTED]> wrote: > > On Thu, Feb 07, 2008 at 10:54:05AM -0500, Tony Camuso wrote: > > > Matthew, > > > > > > Perhaps I missed it, but did you address Yinghai's concerns? > > > > No, I was

[06/19] tracing: add notrace to linkage.h

2008-02-09 Thread Ingo Molnar
From: Ingo Molnar <[EMAIL PROTECTED]> notrace signals that a function should not be traced. Most of the time this is used by tracers to annotate code that cannot be traced - it's in a volatile state (such as in user vdso context or NMI context) or it's in the tracer internals. Signed-off-by:

[05/19] ftrace: make the task state char-string visible to all

2008-02-09 Thread Ingo Molnar
From: Steven Rostedt <[EMAIL PROTECTED]> The tracer wants to be able to convert the state number into a user visible character. This patch pulls that conversion string out the scheduler into the header. This way if it were to ever change, other parts of the kernel will know. Signed-off-by:

[04/19] ftrace: add preempt_enable/disable notrace macros

2008-02-09 Thread Ingo Molnar
From: Steven Rostedt <[EMAIL PROTECTED]> The tracer may need to call preempt_enable and disable functions for time keeping and such. The trace gets ugly when we see these functions show up for all traces. To make the output cleaner this patch adds preempt_enable_notrace and

[03/19] printk: dont wake up klogd with the rq locked

2008-02-09 Thread Ingo Molnar
From: Steven Rostedt <[EMAIL PROTECTED]> It is not wise to place a printk where the runqueue lock is held. I just spent two hours debugging why some of my code was locking up, to find that the lockup was caused by some debugging printk's that I had in the scheduler. The printk's were only in

Re: acpi dsts loading and populate_rootfs

2008-02-09 Thread Christoph Hellwig
On Sun, Feb 10, 2008 at 08:12:26AM +0100, Christoph Hellwig wrote: > Folks, moving this call around hidden behing in completely unreviewed > acpi junk is not acceptable. > > Either populate_rootfs _is_ safe to be called earlier and then we should > do it always or it's not. Either way such a

[01/19] rcu: add support for dynamic ticks and preempt rcu

2008-02-09 Thread Ingo Molnar
From: Steven Rostedt <[EMAIL PROTECTED]> The PREEMPT-RCU can get stuck if a CPU goes idle and NO_HZ is set. The idle CPU will not progress the RCU through its grace period and a synchronize_rcu my get stuck. Without this patch I have a box that will not boot when PREEMPT_RCU and NO_HZ are set.

[02/19] sched: add latency tracer callbacks to the scheduler

2008-02-09 Thread Ingo Molnar
From: Ingo Molnar <[EMAIL PROTECTED]> add 3 lightweight callbacks to the tracer backend. zero impact if tracing is turned off. Signed-off-by: Ingo Molnar <[EMAIL PROTECTED]> --- include/linux/sched.h | 26 ++ kernel/sched.c|3 +++ 2 files changed, 29

[00/19] latency tracer

2008-02-09 Thread Ingo Molnar
this is the latency tracer that has been also posted at: http://lkml.org/lkml/2008/2/8/435 http://lkml.org/lkml/2008/2/9/127 the tree can be pulled from: git://git.kernel.org/pub/scm/linux/kernel/git/mingo/linux-2.6-sched.git about 9 iterations of this have been posted to lkml in

KVM is not seen under X86 config with latest git (32 bit compile)

2008-02-09 Thread Balbir Singh
The KVM configuration is no longer visible in the latest git tree. It looks like it is selected by HAVE_SETUP_PER_CPU_AREA. I've moved HAVE_KVM to under CONFIG_X86. Hopefully, this is the right fix. Comments? Signed-off-by: Balbir Singh <[EMAIL PROTECTED]> --- arch/x86/Kconfig |4 ++-- 1

[5/6] x86: kgdb support

2008-02-09 Thread Ingo Molnar
From: Ingo Molnar <[EMAIL PROTECTED]> simplified and streamlined kgdb support on x86, both 32-bit and 64-bit, based on patch from: Subject: kgdb: core-lite From: Jason Wessel <[EMAIL PROTECTED]> [ and countless other authors - see the patch for details. ] Signed-off-by: Ingo Molnar <[EMAIL

[6/6] kgdb: document parameters

2008-02-09 Thread Ingo Molnar
From: Jason Wessel <[EMAIL PROTECTED]> document the kgdboc module/boot parameter. Signed-off-by: Ingo Molnar <[EMAIL PROTECTED]> --- Documentation/kernel-parameters.txt |5 + 1 file changed, 5 insertions(+) Index: linux-kgdb.q/Documentation/kernel-parameters.txt

[4/6] consoles: polling support, kgdboc

2008-02-09 Thread Ingo Molnar
From: Jan Kiszka <[EMAIL PROTECTED]> polled console handling support, to access a console in an irq-less way while in debug or irq context. absolutely zero impact as long as CONFIG_CONSOLE_POLL is disabled. (which is the default) kgdb over consoles support from: Jason Wessel <[EMAIL

[1/6] pids: add pid_max prototype

2008-02-09 Thread Ingo Molnar
From: Ingo Molnar <[EMAIL PROTECTED]> add pid_max prototype - used by sysctl and will be used by kgdb as well. Signed-off-by: Ingo Molnar <[EMAIL PROTECTED]> Signed-off-by: Thomas Gleixner <[EMAIL PROTECTED]> --- include/linux/pid.h |2 ++ kernel/sysctl.c |2 +- 2 files changed, 3

[2/6] uaccess: add probe_kernel_write()

2008-02-09 Thread Ingo Molnar
From: Ingo Molnar <[EMAIL PROTECTED]> add probe_kernel_write() - copy & paste of the existing probe_kernel_access(), extended to writes. Signed-off-by: Ingo Molnar <[EMAIL PROTECTED]> Reviewed-by: Thomas Gleixner <[EMAIL PROTECTED]> --- include/linux/uaccess.h | 22 ++ 1

[0/6] kgdb light

2008-02-09 Thread Ingo Molnar
this is the "kgdb light" tree that has been also posted at: http://lkml.org/lkml/2008/2/9/236 it is available at: git://git.kernel.org/pub/scm/linux/kernel/git/mingo/linux-2.6-kgdb.git See the shortlog below. various iterations of this have also been included in x86.git for the past 3

acpi dsts loading and populate_rootfs

2008-02-09 Thread Christoph Hellwig
Folks, moving this call around hidden behing in completely unreviewed acpi junk is not acceptable. Either populate_rootfs _is_ safe to be called earlier and then we should do it always or it's not. Either way such a change should be posted separately and reviewd on lkml. Len, can you please

Re: Scheduler(?) regression from 2.6.22 to 2.6.24 for short-lived threads

2008-02-09 Thread Olof Johansson
On Sun, Feb 10, 2008 at 07:15:58AM +0100, Willy Tarreau wrote: > On Sat, Feb 09, 2008 at 11:29:41PM -0600, Olof Johansson wrote: > > 40M: > > 2.6.22 time 94315 ms > > 2.6.23 time 107930 ms > > 2.6.24 time 113291 ms > > 2.6.24-git19time 110360 ms > >

Re: One minute delay when booting 2.6.24.1

2008-02-09 Thread Tvrtko A. Ursulin
On Saturday 09 February 2008 22:01:44 Jan Engelhardt wrote: > On Feb 9 2008 13:29, Tvrtko A. Ursulin wrote: > >Hi all, > > > >As the subject says I get ~1 minute delay when booting 2.6.24.1 > >pretty reliably. It is possible it is not new to 2.6.24.1 but I > >can't tell due recent hardware

Re: kernel 2.6.24.1 still vulnerable to the vmsplice local root exploit

2008-02-09 Thread Niki Denev
On Feb 10, 2008 8:32 AM, Willy Tarreau <[EMAIL PROTECTED]> wrote: > On Sun, Feb 10, 2008 at 08:04:35AM +0200, Niki Denev wrote: > > Hi, > > > > As the subject says the 2.6.24.1 is still vulnerable to the vmsplice > > local root exploit. > > Yes indeed, that's quite bad. 2.6.24-git is still

[GIT PULL] ext4 update

2008-02-09 Thread Theodore Ts'o
Hi Linus, Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4.git for_linus These are mostly bug fixes that we've found since the last pull request. The one non-bugfix change is that I've added a sanity check to assure that production ext3 filesystems don't get

Re: kernel 2.6.24.1 still vulnerable to the vmsplice local root exploit

2008-02-09 Thread Willy Tarreau
On Sun, Feb 10, 2008 at 08:04:35AM +0200, Niki Denev wrote: > Hi, > > As the subject says the 2.6.24.1 is still vulnerable to the vmsplice > local root exploit. Yes indeed, that's quite bad. 2.6.24-git is still vulnerable too, and also contains the fix :-( CC'd Jens as he worked on the fix.

Re: [PATCH] Change pci_raw_ops to pci_raw_read/write

2008-02-09 Thread Yinghai Lu
On Feb 9, 2008 4:41 AM, Matthew Wilcox <[EMAIL PROTECTED]> wrote: > On Thu, Feb 07, 2008 at 10:54:05AM -0500, Tony Camuso wrote: > > Matthew, > > > > Perhaps I missed it, but did you address Yinghai's concerns? > > No, I was on holiday. > > > Yinghai Lu wrote: > > >On Jan 28, 2008 7:03 PM, Matthew

Re: [PATCH] USB: mark USB drivers as being GPL only

2008-02-09 Thread Daniel Hazelton
On Sunday 10 February 2008 00:43:49 Marcel Holtmann wrote: > Hi Daniel, > > > > > > It makes no difference if you > > > > > distribute the GPL library with it or not. > > > > > > > > If you do not distribute the GPL library, the library is simply being > > > > used in the intended, ordinary way.

/bin/sh: -c: line 0: syntax error near unexpected token `;'

2008-02-09 Thread Mr. James W. Laferriere
ODE 132632; echo '#define KERNEL_VERSION(a,b,c) (((a) << 16) + ((b) << 8) + (c))';) < /usr/src/linux-2.6.25-git-20080209/Makefile > include/linux/version.h.tmp; if [ -r include/linux/version.h ] && cmp -s include/linux/version.h include/linux/version.h.tmp; then rm -f incl

Re: Scheduler(?) regression from 2.6.22 to 2.6.24 for short-lived threads

2008-02-09 Thread Willy Tarreau
On Sat, Feb 09, 2008 at 11:29:41PM -0600, Olof Johansson wrote: > On Sat, Feb 09, 2008 at 05:19:57PM +0100, Willy Tarreau wrote: > > On Sat, Feb 09, 2008 at 02:37:39PM +0100, Mike Galbraith wrote: > > > > > > On Sat, 2008-02-09 at 12:40 +0100, Willy Tarreau wrote: > > > > On Sat, Feb 09, 2008 at

kernel 2.6.24.1 still vulnerable to the vmsplice local root exploit

2008-02-09 Thread Niki Denev
Hi, As the subject says the 2.6.24.1 is still vulnerable to the vmsplice local root exploit. [EMAIL PROTECTED] tmp]$ uname -a Linux tester 2.6.24.1 #1 Sun Feb 10 00:06:49 EST 2008 i686 unknown [EMAIL PROTECTED] tmp]$ ./vms --- Linux vmsplice Local Root Exploit

Re: [PATCH 2.6.24-mm1] Mempolicy: silently restrict nodemask to allowed nodes V3

2008-02-09 Thread Greg KH
On Sun, Feb 10, 2008 at 02:29:24PM +0900, KOSAKI Motohiro wrote: > CC'd Greg KH <[EMAIL PROTECTED]> > > I tested this patch on fujitsu memoryless node. > (2.6.24 + silently-restrict-nodemask-to-allowed-nodes-V3 insted 2.6.24-mm1) > it seems works good. > > Tested-by: KOSAKI Motohiro <[EMAIL

Re: [PATCH] USB: mark USB drivers as being GPL only

2008-02-09 Thread Marcel Holtmann
Hi Daniel, > > > > It makes no difference if you > > > > distribute the GPL library with it or not. > > > > > > If you do not distribute the GPL library, the library is simply being > > > used in the intended, ordinary way. You do not need to agree to, nor can > > > you violate, the GPL simply by

Re: [PATCH 2.6.24-mm1] Mempolicy: silently restrict nodemask to allowed nodes V3

2008-02-09 Thread KOSAKI Motohiro
CC'd Greg KH <[EMAIL PROTECTED]> I tested this patch on fujitsu memoryless node. (2.6.24 + silently-restrict-nodemask-to-allowed-nodes-V3 insted 2.6.24-mm1) it seems works good. Tested-by: KOSAKI Motohiro <[EMAIL PROTECTED]> Greg, I hope this patch merge to 2.6.24.x stable tree because this

Re: [git pull] kgdb light

2008-02-09 Thread Christoph Hellwig
On Sat, Feb 09, 2008 at 09:42:59PM +0100, Ingo Molnar wrote: > Linus, > > while this is probably one of the last days of the merge window, please > still consider pulling the "kgdb light" git tree from: > >git://git.kernel.org/pub/scm/linux/kernel/git/mingo/linux-2.6-kgdb.git Without

Re: Scheduler(?) regression from 2.6.22 to 2.6.24 for short-lived threads

2008-02-09 Thread Olof Johansson
On Sat, Feb 09, 2008 at 05:19:57PM +0100, Willy Tarreau wrote: > On Sat, Feb 09, 2008 at 02:37:39PM +0100, Mike Galbraith wrote: > > > > On Sat, 2008-02-09 at 12:40 +0100, Willy Tarreau wrote: > > > On Sat, Feb 09, 2008 at 11:58:25AM +0100, Mike Galbraith wrote: > > > > > > > > On Sat,

Re: [PATCH] [resend] 3c509: convert to isa_driver and pnp_driver v4

2008-02-09 Thread Christoph Hellwig
On Sun, Feb 10, 2008 at 01:10:07AM +0100, Ondrej Zary wrote: > > > +typedef enum { EL3_ISA, EL3_PNP, EL3_MCA, EL3_EISA } el3_cardtype; > > > + > > > > No typedef please (see checkpatch) > > Is there any standard way to solve this without a typedef? I added > el3_dev_fill() function which fills

Re: [PATCH] USB: mark USB drivers as being GPL only

2008-02-09 Thread Daniel Hazelton
On Saturday 09 February 2008 23:50:17 Marcel Holtmann wrote: > > > It makes no difference if you > > > distribute the GPL library with it or not. > > > > If you do not distribute the GPL library, the library is simply being > > used in the intended, ordinary way. You do not need to agree to, nor

Re: [RFC] ipvs: Cleanup sync daemon code

2008-02-09 Thread Christoph Hellwig
On Sun, Feb 10, 2008 at 12:38:11AM +0100, Sven Wegener wrote: > struct ip_vs_sync_thread_data { > - struct completion *startup; > + struct completion *startup; /* set to NULL once completed */ This is not needed anmore. kthread_run guarantees that the newly creates thread is run before

RE: [PATCH] USB: mark USB drivers as being GPL only

2008-02-09 Thread Marcel Holtmann
Hi David, > > Lets phrase this in better words as Valdis pointed out: You can't > > distribute an application (binary or source form) under anything else > > than GPL if it uses a GPL library. > > This simply cannot be correct. The only way it could be true is if the work > was a derivative work

Re: [git pull] CPU isolation extensions (updated)

2008-02-09 Thread Max Krasnyansky
Paul Jackson wrote: > Max wrote: >> Linus, please pull CPU isolation extensions from > > Did I miss something in this discussion? I thought > Ingo was quite clear, and Linus pretty clear too, > that this patch should bake in *-mm or some such > place for a bit first. > Andrew said: > The

[PATCH] Silent compiler warning introduced by commit 801c135ce73d5df1caf3eca35b66a10824ae0707 (UBI: Unsorted Block Images)

2008-02-09 Thread S.Çağlar Onur
Hi; Following patch silents drivers/mtd/ubi/vmt.c: In function `ubi_create_volume': drivers/mtd/ubi/vmt.c:379: warning: statement with no effect compiler warning introduced by commit 801c135ce73d5df1caf3eca35b66a10824ae0707 (UBI: Unsorted Block Images) Signed-off-by: S.Çağlar Onur <[EMAIL

[PATCH] drivers/media/video/em28xx/: Fix undefined symbol error with CONFIG_SND=N

2008-02-09 Thread S.Çağlar Onur
Hi; Following patch fixes following undefined symbol errors with CONFIG_SND=N ERROR: "snd_pcm_period_elapsed" [drivers/media/video/em28xx/em28xx-alsa.ko] undefined! ERROR: "snd_pcm_hw_constraint_integer" [drivers/media/video/em28xx/em28xx-alsa.ko] undefined! ERROR: "snd_pcm_set_ops"

Re: [git pull] CPU isolation extensions (updated)

2008-02-09 Thread Paul Jackson
Max wrote: > Linus, please pull CPU isolation extensions from Did I miss something in this discussion? I thought Ingo was quite clear, and Linus pretty clear too, that this patch should bake in *-mm or some such place for a bit first. -- I won't rest till it's the best ...

[PATCH] Update kernel/.gitignore with new generated files

2008-02-09 Thread S.Çağlar Onur
Hi; Following patch updates kernel/.gitignore with new auto-generated files Signed-off-by: S.Çağlar Onur <[EMAIL PROTECTED]> kernel/.gitignore |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/kernel/.gitignore b/kernel/.gitignore index f2ab700..ab4f109 100644 ---

[PATCH] Update arch/x86/boot/.gitignore with new generated files

2008-02-09 Thread S.Çağlar Onur
Hi; Following patch update arch/x86/boot/.gitignore with new auto-generated files Signed-off-by: S.Çağlar Onur <[EMAIL PROTECTED]> arch/x86/boot/.gitignore |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/arch/x86/boot/.gitignore b/arch/x86/boot/.gitignore index

[git pull] CPU isolation extensions (updated)

2008-02-09 Thread Max Krasnyansky
Linus, please pull CPU isolation extensions from git://git.kernel.org/pub/scm/linux/kernel/git/maxk/cpuisol-2.6.git for-linus Diffstat: Documentation/ABI/testing/sysfs-devices-system-cpu | 41 +++ Documentation/cpu-isolation.txt| 113 +

[PATCH] Silent compiler warning introduced by commit 75b6102257874a4ea796af686de2f72cfa0452f9 (rtc: add support for Epson RTC-9701JE V4)

2008-02-09 Thread S.Çağlar Onur
Hi; Following patch silents drivers/rtc/rtc-r9701.c: In function `r9701_get_datetime': drivers/rtc/rtc-r9701.c:74: warning: unused variable `time' compiler warning introduced by commit 75b6102257874a4ea796af686de2f72cfa0452f9 (rtc: add support for Epson RTC-9701JE V4) Signed-off-by: S.Çağlar

[PATCH] Silent compiler warning introduced by 11b0cc3a4af65413ca3bb5698769e091486e0b22 (x25_asy: Fix ref count rule violation)

2008-02-09 Thread S.Çağlar Onur
Hi; Following patch silents drivers/net/wan/x25_asy.c: In function `x25_asy_open_tty': drivers/net/wan/x25_asy.c:557: warning: unused variable `ld' compiler warning introduced by commit 11b0cc3a4af65413ca3bb5698769e091486e0b22 (x25_asy: Fix ref count rule violation) Signed-off-by: S.Çağlar

[PATCH] Silent compiler warning introduced by acea6852f32b8805e166d885ed7e9f0c7cd10d41 ([BLUETOOTH]: Move children of connection device to NULL before connection down.)

2008-02-09 Thread S.Çağlar Onur
Hi; Following patch silents net/bluetooth/hci_sysfs.c: In function `del_conn': net/bluetooth/hci_sysfs.c:339: warning: suggest parentheses around assignment used as truth value compiler warning introduced by commit acea6852f32b8805e166d885ed7e9f0c7cd10d41 ([BLUETOOTH]: Move children of

Re: Kernel Panic in MPT SAS on 2.6.24 (and 2.6.23.14, 2.6.23.9)

2008-02-09 Thread Maximilian Wilhelm
Am Friday, den 8 February hub Maximilian Wilhelm folgendes in die Tasten: > Just noticed that Eric's address was wrong, so resend with corrected Cc. > Eric, my intial report was http://lkml.org/lkml/2008/2/6/300 > > > Am Thursday, den 7 February hub Krzysztof Oledzki folgendes in die Tasten:

RE: [PATCH] USB: mark USB drivers as being GPL only

2008-02-09 Thread David Schwartz
Marcel Holtmann wrote: > Lets phrase this in better words as Valdis pointed out: You can't > distribute an application (binary or source form) under anything else > than GPL if it uses a GPL library. This simply cannot be correct. The only way it could be true is if the work was a derivative

Re: DMAR EHCI failures

2008-02-09 Thread David Brownell
On Monday 04 February 2008, Jiri Slaby wrote: > Hi, > > I have this in dmesg: > DMAR:[DMA Write] Request device [00:02.0] fault addr ee1512000 > DMAR:[fault reason 05] PTE Write access is not set > PCI-DMA: Intel(R) Virtualization Technology for Directed I/O > DMAR:[DMA Read] Request device

Re: [sample] mem_notify v6: usage example

2008-02-09 Thread Pavel Machek
On Sat 2008-02-09 11:07:09, Jon Masters wrote: > This really needs to be triggered via a generic kernel > event in the final version - I picture glibc having a > reservation API and having generic support for freeing > such reservations. Not sure what you are talking about. This seems very

Re: [PATCH] Define a NO_GPIO macro to compare against and to use as an invalid GPIO

2008-02-09 Thread David Brownell
On Saturday 09 February 2008, Guennadi Liakhovetski wrote: > On Fri, 8 Feb 2008, David Brownell wrote: > > > Actually I thought that what you needed was an is_valid_gpio(); > > your motivation was that you needed a predicate. > > > > The problem I have with a #define for a single such invalid

Re: [git pull] x86 updates

2008-02-09 Thread Randy Dunlap
On Sun, 10 Feb 2008 00:24:50 +0100 (CET) Thomas Gleixner wrote: > Linus, > > please pull the pending x86 updates from: > > ssh://master.kernel.org/pub/scm/linux/kernel/git/x86/linux-2.6-x86.git > master Hi Thomas, can we please get diffstats with git pull requests? (in the future) > The

Re: how to tell i386 from x86-64 kernel

2008-02-09 Thread Pavel Machek
On Sat 2008-02-09 14:34:30, Arjan van de Ven wrote: > On Sat, 9 Feb 2008 21:13:43 +0100 (CET) > Jan Engelhardt <[EMAIL PROTECTED]> wrote: > > > > > On Feb 1 2008 12:53, Alejandro Riveira Fernández wrote: > > >> > > >> # uname -m > > >> I won't tell you. > > >> # linux32 uname -m > > >> i686 > >

Re: [RFC] ipvs: Cleanup sync daemon code

2008-02-09 Thread Simon Horman
On Sun, Feb 10, 2008 at 12:38:11AM +0100, Sven Wegener wrote: > Hi all, > > I'd like to get your feedback on this: > > - Use kthread_run instead of doing a double-fork via kernel_thread() > > - Return proper error codes to user-space on failures > > Currently ipvsadm --start-daemon with an invalid

Re: 2.6.24-git20 -- BUG: sleeping function called from invalid context at include/asm/uaccess_32.h:449

2008-02-09 Thread Arjan van de Ven
On Sat, 9 Feb 2008 16:26:43 -0800 Andrew Morton <[EMAIL PROTECTED]> wrote: > Ugh, how did I let that one through? > > Guys, how often mut it be said? PLEASE always test all code with all > kernel deubg options enabled. maybe we should make a CONFIG_KERNEL_DEVELOPER option that SELECTs the

Re: 2.6.24-git20 -- BUG: sleeping function called from invalid context at include/asm/uaccess_32.h:449

2008-02-09 Thread Andrew Morton
On Sat, 9 Feb 2008 14:03:28 -0500 "Miles Lane" <[EMAIL PROTECTED]> wrote: > Command run: > find /proc | xargs tail > > [ 2710.028219] BUG: sleeping function called from invalid context at > include/asm/uaccess_32.h:449 > [ 2710.028229] in_atomic():1, irqs_disabled():0 > [ 2710.028232] 1

Re: [RFC] Sectionized printk data

2008-02-09 Thread Arnaldo Carvalho de Melo
Em Sun, Feb 10, 2008 at 01:18:18AM +0100, Jan Engelhardt escreveu: > > On Feb 9 2008 21:54, Arnaldo Carvalho de Melo wrote: > >> To drop strings that are only shown once anyway, such as: > >> > >> static int __init ebtables_init(void) > >> { > >> int ret; > >> > >>

Re: mm/slub.c warnings

2008-02-09 Thread Christoph Lameter
On Sat, 9 Feb 2008, Vegard Nossum wrote: > Hi, > > I get these warnings when compiling mm/slub.c in linux-2.6.git: > > mm/slub.c: In function 'slab_alloc': > mm/slub.c:1637: warning: assignment makes pointer from integer without a cast > mm/slub.c:1637: warning: assignment makes pointer from

Re: [RFC] Sectionized printk data

2008-02-09 Thread Jan Engelhardt
On Feb 9 2008 21:54, Arnaldo Carvalho de Melo wrote: >> To drop strings that are only shown once anyway, such as: >> >> static int __init ebtables_init(void) >> { >> int ret; >> >> mutex_lock(_mutex); >> list_add(_standard_target.list, _targets); >>

Re: [PATCH] Define a NO_GPIO macro to compare against and to use as an invalid GPIO

2008-02-09 Thread Guennadi Liakhovetski
On Fri, 8 Feb 2008, David Brownell wrote: > On Thursday 31 January 2008, Guennadi Liakhovetski wrote: > > As discussed on i2c mailing list with David Brownell, and number > > outside of the 0...MAX_INT range is invalid as a GPIO number. > > Define a macro, similar to NO_IRQ, to be used as a

Re: [PATCH] [resend] 3c509: convert to isa_driver and pnp_driver v4

2008-02-09 Thread Ondrej Zary
On Saturday 09 February 2008 22:48:05 Stephen Hemminger wrote: > On Sat, 9 Feb 2008 22:33:07 +0100 > > Ondrej Zary <[EMAIL PROTECTED]> wrote: > > Hello, > > this patch converts 3c509 driver to isa_driver and pnp_driver. The result > > is that autoloading using udev and hibernation works with ISA

Re: Query about set_pages_* API

2008-02-09 Thread Arjan van de Ven
On Sat, 09 Feb 2008 15:40:12 -0700 Larry Finger <[EMAIL PROTECTED]> wrote: > Is the set_pages_* API that replaces change_page_attr described > somewhere? I have been unable to find it with Google. > > I'm trying to modify the VirtualBox kernel module to work with > 2.6.24-git (and 2.6.25) on

Re: Query about set_pages_* API

2008-02-09 Thread Arjan van de Ven
On Sat, 09 Feb 2008 15:40:12 -0700 Larry Finger <[EMAIL PROTECTED]> wrote: > I'm trying to modify the VirtualBox kernel module to work with > 2.6.24-git (and 2.6.25) on x86_64 architecture. The current code has > a value of the third argument of the call (prot) with 3 variants. All > variations

Re: [RFC] Sectionized printk data

2008-02-09 Thread Arnaldo Carvalho de Melo
Em Sat, Feb 09, 2008 at 11:08:45PM +0100, Jan Engelhardt escreveu: > > On Feb 4 2008 19:07, Sam Ravnborg wrote: > >> The attached patch allows something along the lines: > >> > >> int __init some_function(void) > >> { > >> [...] > >> pr_init(KERN_WARNING "failure %s in %s\n",

Re: Fwd: Re: e1000 1sec latency problem

2008-02-09 Thread Kok, Auke
Ray Lee wrote: > On Feb 9, 2008 1:51 PM, Kok, Auke <[EMAIL PROTECTED]> wrote: >> Martin Rogge wrote: >>> On Saturday 09 February 2008 11:07:26 Martin Rogge wrote: Hi, I am not so familiar with the various mailing lists and missed out on [EMAIL PROTECTED] the first time. Please

[RFC] ipvs: Cleanup sync daemon code

2008-02-09 Thread Sven Wegener
Hi all, I'd like to get your feedback on this: - Use kthread_run instead of doing a double-fork via kernel_thread() - Return proper error codes to user-space on failures Currently ipvsadm --start-daemon with an invalid --mcast-interface will silently suceed. With these changes we get an

[git pull] x86 updates

2008-02-09 Thread Thomas Gleixner
Linus, please pull the pending x86 updates from: ssh://master.kernel.org/pub/scm/linux/kernel/git/x86/linux-2.6-x86.git master The update contains: - a couple of bugfixes - CPA and DEBUG_PAGEALLOC improvements - x86 power management consolidation - GEODE updates - 32bit

Re: HPET timer broken using 2.6.23.13 / nanosleep() hangs

2008-02-09 Thread Andrew Paprocki
Thomas, I haven't found a good way to capture the SysRq output for this. I found that when it locks up at boot time, even SysRq is unresponsive. I don't have another way of getting console on the machine right now to get the output off of it. I have since upgraded to 2.6.24 and the problem still

[PATCH] scsi: ses fix mem leaking when fail to add intf

2008-02-09 Thread Yinghai Lu
[PATCH] scsi: ses fix mem leaking when fail to add intf fix leaking with scomp leaking when failing. also remove one extra space. Signed-off-by: Yinghai Lu <[EMAIL PROTECTED]> Index: linux-2.6/drivers/scsi/ses.c === ---

Query about set_pages_* API

2008-02-09 Thread Larry Finger
Is the set_pages_* API that replaces change_page_attr described somewhere? I have been unable to find it with Google. I'm trying to modify the VirtualBox kernel module to work with 2.6.24-git (and 2.6.25) on x86_64 architecture. The current code has a value of the third argument of the call

Re: how to tell i386 from x86-64 kernel

2008-02-09 Thread Arjan van de Ven
On Sat, 9 Feb 2008 21:13:43 +0100 (CET) Jan Engelhardt <[EMAIL PROTECTED]> wrote: > > On Feb 1 2008 12:53, Alejandro Riveira Fernández wrote: > >> > >> # uname -m > >> I won't tell you. > >> # linux32 uname -m > >> i686 > > > > Ubuntu 7.10 64 bit userland 2.6.24 > > > >$ uname -m > >x86_64 > >$

Re: [PATCH] time: Fix constant size in kernel/timeconst.h

2008-02-09 Thread Johann Felix Soden
H. Peter Anvin wrote: > Johann Felix Soden wrote: > > kernel/timeconst.pl generates only long sized constants in timeconst.pl > > which gives this warning: > > > > kernel/time.c: In function 'msecs_to_jiffies': > > kernel/time.c:472: warning: integer constant is too large for 'long' type > > > >

Re: [PATCH] scsi: ses fix for len and mem leaking when fail to add intf

2008-02-09 Thread Yinghai Lu
On Feb 9, 2008 7:00 AM, James Bottomley <[EMAIL PROTECTED]> wrote: > > On Sat, 2008-02-09 at 04:13 -0800, Yinghai Lu wrote: > > [PATCH] scsi: ses fix for len and mem leaking when fail to add intf > > > > change to u32 before left shifting char > > This one is a bit unnecessary; C promotion rules

Re: [patch 0/4] make pr_debug() dynamic

2008-02-09 Thread Jan Engelhardt
On Feb 8 2008 10:52, Jason Baron wrote: >On Thu, Feb 07, 2008 at 02:42:14PM -0800, Joe Perches wrote: >> On Thu, 2008-02-07 at 16:03 -0500, Jason Baron wrote: >> > make the pr_debug() function dependent upon the new immediate >> > infrastruture. >> >> What's wrong with klogd -c 8 or equivalent?

Re: wrong cylinders of kingston usb pendrive [intel 82801DB]

2008-02-09 Thread Alan Stern
On Mon, 4 Feb 2008, Patrick Ringl wrote: > Hello, > > I am suffering from the following (usb-related?) problem: > > I have several different mashines - all x86 architecture - just lets > call them mashineA, mashineB and mashineC. > Anyway, mashineA has a severe problem with a >

Re: [RFC] Sectionized printk data

2008-02-09 Thread Jan Engelhardt
On Feb 4 2008 19:07, Sam Ravnborg wrote: >> The attached patch allows something along the lines: >> >> int __init some_function(void) >> { >> [...] >> pr_init(KERN_WARNING "failure %s in %s\n", ...); >> [...] >> } >> >> Another idea I had was to make printk a macro that

  1   2   3   4   5   6   7   >