>>> +void __init enable_pressure_cgroup(void)
>>> +{
>>> + WARN_ON(cgroup_add_cftypes(_cgroup_subsys,
>>> + vmpressure_cgroup_files));
>>> +}
>>
>> There is no functionality discovery going on here, and this is
>> conditional on nothing. Isn't it better then to just
Hi Damien,
Thanks for the test and the feedback.
Could you send me the sched_domain configuration of your machine with
the kernel that boots on your machine ?
It's available in /proc/sys/kernel/sched_domain/cpu*/
This should not have any impact on your machine but it looks like it have one.
Hi Stephane,
On Tue, 12 Feb 2013 15:09:27 +0100, Stephane Eranian wrote:
> Refactor aggregation code by introducing
> a single aggr_mode variable and an enum
> for aggregation.
>
> Also refactor cpumap code having to do
> with cpu to socket mappings. All in preparation
> for extended modes, such
On Wed, 13 Feb 2013, Marek Szyprowski wrote:
> Hello,
>
> On 2/12/2013 11:10 PM, Guennadi Liakhovetski wrote:
> > Hi Marek
> >
> > On Tue, 12 Feb 2013, Marek Szyprowski wrote:
> >
> > > Some regulators don't report any voltage values, so checking supported
> > > voltage range results in
[CC initramfs-tools]
On Wed, Feb 13, 2013 at 08:16:28AM +0100, Andreas Mohr wrote:
> Hi,
>
> On Wed, Feb 13, 2013 at 07:44:36AM +0100, Andreas Mohr wrote:
> > So, what to do? I'm now going to do some experimentation with git revert
> > on some revision, and I'm trying to establish the USB port
Hi Kukjin,
Today's linux-next merge of the samsung tree got conflicts in quite a few
files between commits from the arm-soc tree and commits from the samsung
tree.
I took Olof's advice and just dropped the samsung tree for today.
--
Cheers,
Stephen Rothwell
13.02.2013 11:37, Ian Kent wrote:
[]
So, you would like me to forward this to Linus?
I'd be inclined to wait until the window for 3.9 opens since Linus
probably has more than enough to do finalizing 3.8 right now.
I guess this change is anything but urgent ;)
Thanks,
/mjt
--
To unsubscribe
On Wed, 2013-02-13 at 11:23 +0400, Michael Tokarev wrote:
> 13.02.2013 11:20, Ian Kent wrote:
> > On Tue, 2013-02-12 at 10:12 -0700, Tim Gardner wrote:
> >> smatch analysis:
> >>
> >> fs/autofs4/waitq.c:46 autofs4_catatonic_mode() info: redundant null
> >> check on wq->name.name calling kfree()
On Sun, Feb 10 2013, Anton Vorontsov wrote:
> With this patch userland applications that want to maintain the
> interactivity/memory allocation cost can use the new pressure level
> notifications. The levels are defined like this:
>
> The "low" level means that the system is reclaiming memory for
Hello,
On 2/12/2013 11:10 PM, Guennadi Liakhovetski wrote:
Hi Marek
On Tue, 12 Feb 2013, Marek Szyprowski wrote:
> Some regulators don't report any voltage values, so checking supported
> voltage range results in disabling all SDHCI_CAN_VDD_* flags and
> registration failure. This patch
On Wed, Feb 13, 2013 at 04:30:54AM +0100, Peter Huewe wrote:
> In vmk80xx_do_insn_bits the local variable reg, which is used as an
> index to the tx_buf array, can be used uninitialized if
> - data[0] == 0
> and
> - devpriv->model != VMK8061_MODEL
> -> we get into the else branch without having
On Tue, 2013-02-12 at 15:50 -0800, Andrew Morton wrote:
> On Fri, 08 Feb 2013 10:08:49 +
> Matt Fleming wrote:
>
> > On Fri, 2013-02-08 at 18:05 +0800, Jeremy Kerr wrote:
> > > However, the tests expose a bug at the moment, so run_tests will fail.
> > > Matt will have that fixed soon though
From: Manjunath Goudar
Separate the vt8500 host controller driver from ehci-hcd host code
into its own driver module.
Signed-off-by: Manjunath Goudar
Cc: Greg KH
Cc: Alan Stern
Cc: Tony Prisk
Cc: Alexey Charkov
Cc: linux-...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
Hi Glauber,
On Mon, Feb 11, 2013 at 02:17:06PM +0400, Glauber Costa wrote:
[...]
> > +static struct vmpressure *vmpressure_parent(struct vmpressure *vmpr)
> > +{
> > + struct cgroup *cg = vmpr_to_css(vmpr)->cgroup->parent;
> > +
> > + if (!cg)
> > + return NULL;
> > + return
13.02.2013 11:20, Ian Kent wrote:
On Tue, 2013-02-12 at 10:12 -0700, Tim Gardner wrote:
smatch analysis:
fs/autofs4/waitq.c:46 autofs4_catatonic_mode() info: redundant null
check on wq->name.name calling kfree()
I'm not sure about this change.
autofs4_catatonic_mode() could be called when
On Tue, 2013-02-12 at 10:12 -0700, Tim Gardner wrote:
> smatch analysis:
>
> fs/autofs4/waitq.c:46 autofs4_catatonic_mode() info: redundant null
> check on wq->name.name calling kfree()
I'm not sure about this change.
autofs4_catatonic_mode() could be called when there are remaining
entries in
Hi Greg,
Thanks for taking a look!
On Tue, Feb 12, 2013 at 10:42:51PM -0800, Greg Thelen wrote:
[...]
> > +static unsigned long vmpressure_calc_level(unsigned int win,
> > + unsigned int s, unsigned int r)
>
> Should seems like the return type of this
Hi all,
Today's linux-next merge of the arm-soc tree got a conflict in
drivers/irqchip/Makefile between commit 270de53f851b ("metag: Internal
and external irqchips") from the metag tree and commit a900e5d99718
("ARM: exynos: move exynos4210-combiner to drivers/irqchip") from the
arm-soc tree.
I
Is the below patch picked up?
On Sun, Feb 3, 2013 at 9:31 PM, anish kumar wrote:
> From: anish kumar
>
> This watchdog_disabled flag is bit of cryptic.Howerver it's usefullnes is
> multifold.
> Uses are:
> 1. Check if smpboot_register_percpu_thread function passed.
> 2. Makes sure that user
Hi,
On Wed, Feb 13, 2013 at 07:44:36AM +0100, Andreas Mohr wrote:
> So, what to do? I'm now going to do some experimentation with git revert
> on some revision, and I'm trying to establish the USB port dependency
> (BIOS-owned handoff root hub invisible!?, as discussed in initial mail).
After
From: Manjunath Goudar
Separate the mv(marvell) host controller driver from ehci-hcd host code
into its own driver module.
Signed-off-by: Manjunath Goudar
Cc: Greg KH
Cc: Alan Stern
Cc: Jason Cooper
Cc: Andrew Lunn
Cc: linux-...@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
---
On Tue, Feb 12, 2013 at 08:24:33AM +0100, Andreas Larsson wrote:
> This driver supports GRGPIO gpio cores available in the GRLIB VHDL IP
> core library from Aeroflex Gaisler.
>
> This also adds support to gpio-generic for using custom accessor
> functions. The grgpio driver uses this to use
uency properties from serial nodes", the
UART clocks get turned off and the console breaks.
I tested this in next-20130212 where "clock-frequency" is there in
tegra30.dtsi file.
If you remove this from dts file at all then it will not work as there
is no execution path to call th
At Tue, 12 Feb 2013 12:34:20 -0800,
Greg Kroah-Hartman wrote:
>
> This is the start of the stable review cycle for the 3.7.8 release.
> There are 61 patches in this series, all will be posted as a response
> to this one. If anyone has any issues with these being applied, please
> let me know.
>
From: Alexandre Courbot
Some functions dereferenced their GPIO descriptor argument without
checking its validity first, potentially leading to an oops when given
an invalid argument.
This patch also makes gpio_get_value() more resilient when given an
invalid GPIO, returning 0 instead of
From: Alexandre Courbot
Constify descriptor parameter of gpiod_* functions for those that
should obviously not modify it. This includes value or direction get,
cansleep, and IRQ number query.
Signed-off-by: Alexandre Courbot
---
drivers/gpio/gpiolib.c | 29 -
1
This short series is a fixup to patch 6/9 of my previous series ("gpiolib: use
descriptors internally"), which mainly addresses issues raised by Linus W. in
this patch and a few other minor ones caught while proof-reading gpiolib.
First patch is the most significant. It mostly avoids oopses
Delivered-To: gnu...@gmail.com
Received: by 10.64.96.232 with SMTP id dv8csp15271ieb;
Sun, 10 Feb 2013 05:48:07 -0800 (PST)
X-Received: by 10.68.0.39 with SMTP id 7mr11102539pbb.124.1360504086445;
Sun, 10 Feb 2013 05:48:06 -0800 (PST)
Return-Path:
Received: from
From: Alexandre Courbot
This comment applies to gpio_to_chip(), not gpiod_to_chip().
Signed-off-by: Alexandre Courbot
---
drivers/gpio/gpiolib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index ad6df6b..d8aa1a0 100644
From: Alexandre Courbot
Their value being obtained by gpio_chip_hwgpio(), this better reflects
their use.
Signed-off-by: Alexandre Courbot
---
drivers/gpio/gpiolib.c | 70 +-
1 file changed, 35 insertions(+), 35 deletions(-)
diff --git
Le 12/02/2013 19:54, Lars-Peter Clausen a écrit :
On 02/12/2013 06:10 PM, Christophe Leroy wrote:
This patch adds support for Analog Devices AD7923 ADC in the IIO Subsystem.
Signed-off-by: Patrick Vasseur
Signed-off-by: Christophe Leroy
Looks good to me except for one small, but important
This patch adds support for Analog Devices AD7923 ADC in the IIO Subsystem.
Signed-off-by: Patrick Vasseur
Signed-off-by: Christophe Leroy
diff -urN linux-next-e347c98/drivers/iio/adc/Kconfig
linux-next-e347c98.new/drivers/iio/adc/Kconfig
--- linux-next-e347c98/drivers/iio/adc/Kconfig
Hi guys (*wink*),
On Tue, Feb 12, 2013 at 08:16:17AM -0800, Greg KH wrote:
> On Tue, Feb 12, 2013 at 05:07:27PM +0100, Andreas Mohr wrote:
> > On Sun, Feb 10, 2013 at 03:05:54PM +0100, Andreas Mohr wrote:
> > > Regression sorta confirmed now. -rc3 with a fully suitable .config does
> > > not boot
On Tue, 2013-02-12 at 22:33 -0800, H. Peter Anvin wrote:
> That is just batshit crazy. If you have CAP_SYS_RAWIO you can do iopl()
> which means you can reprogram your northbridge, at which point you most
> definitely *can* modify the running kernel.
Well right, that's the point of this
Hi Al,
linux-next contains ksignal conversion for some of the architectures. Are you
planning to complete that in 3.9 merge window. The reason I ask is so that the
newer architectures (arc/metag - for a likely 3.9 merge) can queue the
corresponding changes via respective trees.
Thx,
-Vineet
--
On Tue, Feb 12, 2013 at 01:20:36PM -0800, Joe Perches wrote:
> His email bounces and he hasn't done work on
> these sections in a couple of years.
>
I've added him to the CC list.
Can we just update MAINTAINERS with the correct email address? It's
been useful to CC him on stuff.
regards,
dan
On 02/12/2013 10:27 PM, Matthew Garrett wrote:
On Tue, 2013-02-12 at 22:12 -0800, H. Peter Anvin wrote:
Sounds like you are thinking of CAP_SYS_ADMIN, but I don't really see a
huge difference between MSRs and I/O control registers... just different
address spaces.
Not having CAP_SYS_RAWIO
Vivek Gautam wrote:
>
> Based on 'usb-next'
>
> Changes from v4:
> - Modifying function names and driver names to follow a common
>naming convention.
> "usb2phy" for samsung-usb2phy driver
> "usb3phy" for samsung-usb3phy driver
> - Changing file names "samsung-usb2.c" to
On Tue, 2013-02-12 at 22:12 -0800, H. Peter Anvin wrote:
> Sounds like you are thinking of CAP_SYS_ADMIN, but I don't really see a
> huge difference between MSRs and I/O control registers... just different
> address spaces.
Not having CAP_SYS_RAWIO blocks various SCSI commands, for instance.
Hi,
I tested this on top of 3.8-rc7 and this made the machine (x86_64, Core
i7 920) unable to boot (very early as nothing at all is displayed on
screen). Nothing in the kernel log (after booting with a working
kernel).
Double-checked by just backing out only this patch and this made the
machine
On 02/01/2013 01:27 AM, Minchan Kim wrote:
> On Tue, Jan 29, 2013 at 03:40:26PM -0600, Seth Jennings wrote:
>> This patchset adds support for flush pages out of the compressed
>> pool to the swap device
>>
Thanks for the review Minchan! Sorry for the delayed response. I'm
prepping v5 for
Hi Kirill,
On Tue, 12 Feb 2013 01:40:04 +0400, Kirill Tkhai wrote:
> Simple return
>
> Signed-off-by: Kirill V Tkhai
> CC: Steven Rostedt
> CC: Ingo Molnar
> CC: Peter Zijlstra
> CC: linux-rt-users
> ---
> kernel/sched/stop_task.c |4 ++--
> 1 file changed, 2 insertions(+), 2
On 02/12/2013 09:39 PM, Matthew Garrett wrote:
On Tue, 2013-02-12 at 16:48 -0800, H. Peter Anvin wrote:
OK... what none of this gets into:
Why should CAP_RAWIO be allowed on a secure boot system, when there are
2^n known ways of compromise a system with CAP_RAWIO?
CAP_SYS_RAWIO seems to
Stephen Warren wrote @ Tue, 12 Feb 2013 17:35:56 +0100:
> However I'd like to avoid changing the body of those two functions at
> all if possible, since I hope the PCIe driver rework will be merged in
> 3.10, and that will allow the Harmony and TrimSlice init functions to be
> removed entirely.
On Tue, 2013-02-12 at 16:48 -0800, H. Peter Anvin wrote:
> OK... what none of this gets into:
>
> Why should CAP_RAWIO be allowed on a secure boot system, when there are
> 2^n known ways of compromise a system with CAP_RAWIO?
CAP_SYS_RAWIO seems to have ended up being a catchall of "Maybe
On Tue, 12 Feb 2013, Dave Jones wrote:
> On Tue, Feb 12, 2013 at 04:56:55PM -0800, Hugh Dickins wrote:
>
> > > so I can hit this pretty quickly with this..
> > >
> > > while [ 1 ];
> > > do
> > > rtcwake -s 5 -m no ; pm-suspend
> > > done
> > >
> > > Which should make it bisectable at
KyongHo Cho wrote:
>
> On Fri, Feb 1, 2013 at 10:51 PM, Joerg Roedel wrote:
> > Cho,
> >
> > On Wed, Jan 02, 2013 at 02:53:49PM +0900, KyongHo Cho wrote:
> >> On Tuesday, January 1, 2013, Sylwester Nawrocki
>
> >
> >> > Cc: devicetree-disc...@lists.ozlabs.org
> >
> > Since patch 7 of this set
Hi,
On Wednesday 13 February 2013 08:12 AM, Simon Glass wrote:
We now have a binding which adds two parameters to the matrix keypad DT
node. This is separate from the GPIO-driven matrix keypad binding, and
unfortunately incompatible, since that uses row-gpios/col-gpios for the
row and column
Got this lockdep warning straightaway during boot:
[7.435890] =
[7.435891] [ INFO: possible recursive locking detected ]
[7.435893] 3.8.0-next-20130204+pcipatch-xeon+lockdep #20130204+pcipatch Not
tainted
[7.435893]
13.02.2013 01:18, Peter Staubach пишет:
The "+" thing seems a little odd. Why not use "||" instead? The sum of the
two returns isn't really the important thing, is it? It is that either call to svc_close_list()
returns non-zero.
Thanx...
Yep, thanks for the notice.
On Tue, 2013-02-12 at 23:45 -0500, Peter Hurley wrote:
> Got this message log (excerpted below) while building a kernel on
> next-20130204.
>
> The build was taking place on an ext4 fs which is device-mapped on
> stripped fakeraid.
Happened directly on boot on a lockdep next-20130204 kernel. Log
This is a couple of patches, one to fix a broken build with HPUX
compatibility and the other to solve a coherency problem we've been
seeing in our TLB where setting a page read only occasionally fails to
trigger a COW because of a stale writeable TLB entry.
The patches are here:
Hi Dave,
Today's linux-next merge of the drm tree got a conflict in
drivers/gpu/drm/radeon/evergreen_cs.c between commit de0babd60d8d
("drm/radeon: enforce use of radeon_get_ib_value when reading user cmd")
from Linus' tree and commit 0fcb6155cb5c ("radeon/kms: cleanup async dma
packet checking")
On Tue, Feb 12, 2013 at 7:58 PM, KY Srinivasan wrote:
>
>
>> -Original Message-
>> From: H. Peter Anvin [mailto:h...@zytor.com]
>> Sent: Tuesday, February 12, 2013 10:55 PM
>> To: KY Srinivasan
>> Cc: Yinghai Lu; mi...@kernel.org; linux-kernel@vger.kernel.org;
>> t...@linutronix.de;
[+cc linux-pci, Rafael, Alan]
[https://bugzilla.kernel.org/show_bug.cgi?id=53551]
On Tue, Feb 12, 2013 at 1:13 PM, Artem S. Tashkinov wrote:
> Feb 13, 2013 01:32:53 AM, Linus Torvalds wrote:
> On Tue, Feb 12, 2013 at 10:29 AM, Artem S. Tashkinov wrote:
>>> Feb 12, 2013 11:30:20 PM, Linus
On Tue, 2013-02-12 at 18:42 -0800, Yinghai Lu wrote:
> On Tue, Feb 12, 2013 at 6:20 PM, Peter Hurley
> wrote:
> >
> > Reported-and-tested-by: Peter Hurley
>
> Thanks.
>
> > PS - I just happened to see this version on the list. Would you please
> > cc me on any future versions?
>
> oh, my
On Tue, Feb 12, 2013 at 04:56:55PM -0800, Hugh Dickins wrote:
> > so I can hit this pretty quickly with this..
> >
> > while [ 1 ];
> > do
> > rtcwake -s 5 -m no ; pm-suspend
> > done
> >
> > Which should make it bisectable at least..
>
> Thanks, I'll give that a try this evening.
> -Original Message-
> From: H. Peter Anvin [mailto:h...@zytor.com]
> Sent: Tuesday, February 12, 2013 10:55 PM
> To: KY Srinivasan
> Cc: Yinghai Lu; mi...@kernel.org; linux-kernel@vger.kernel.org;
> t...@linutronix.de; h...@linux.intel.com; linux-tip-comm...@vger.kernel.org
> Subject:
On 02/12/2013 07:49 PM, KY Srinivasan wrote:
The issue was that you could turn on CONFIG_HYPERV without enabling
CONFIG_X86_LOCAL_APIC. Peter fixed it.
He is asking why you are using IS_ENABLED() instead of #ifdef. The
difference is that IS_ENABLED() works even for modules.
My mistake!
> -Original Message-
> From: H. Peter Anvin [mailto:h...@zytor.com]
> Sent: Tuesday, February 12, 2013 10:46 PM
> To: KY Srinivasan
> Cc: Yinghai Lu; mi...@kernel.org; linux-kernel@vger.kernel.org;
> t...@linutronix.de; h...@linux.intel.com; linux-tip-comm...@vger.kernel.org
> Subject:
On 02/12/2013 07:32 PM, KY Srinivasan wrote:
+#if IS_ENABLED(CONFIG_HYPERV)
+apicinterrupt HYPERVISOR_CALLBACK_VECTOR \
+ hyperv_callback_vector hyperv_vector_handler
+#endif /* CONFIG_HYPERV */
+
so #ifdef CONFIG_HYPERV does not work here?
The issue was that you could turn on
On Tue, 2013-02-12 at 12:35 -0800, Greg Kroah-Hartman wrote:
> 3.7-stable review patch. If anyone has any objections, please let me know.
FWIW, I never saw this on 3.7 but it happened 1st time on 3.8-rcX
I haven't tested this fix either.
Regards,
Peter Hurley
--
To unsubscribe from this list:
On Tue, 2013-02-12 at 18:42 -0800, Simon Glass wrote:
> This is the base EC implementation, which provides a high level
> interface to the EC for use by the rest of the kernel. The actual
> communcations is dealt with by a separate protocol driver which
> registers itself with this interface.
> -Original Message-
> From: yhlu.ker...@gmail.com [mailto:yhlu.ker...@gmail.com] On Behalf Of
> Yinghai Lu
> Sent: Tuesday, February 12, 2013 9:56 PM
> To: mi...@kernel.org; h...@zytor.com; linux-kernel@vger.kernel.org; KY
> Srinivasan; t...@linutronix.de; h...@linux.intel.com
> Cc:
Hi Rafael,
I have another comment at container.c.
2013/02/13 12:08, Yasuaki Ishimatsu wrote:
Hi Rafael,
The patch seems good.
There is a comment below.
2013/02/13 9:19, Rafael J. Wysocki wrote:
From: Rafael J. Wysocki
This changeset is aimed at fixing a few different but related
problems
In vmk80xx_do_insn_bits the local variable reg, which is used as an
index to the tx_buf array, can be used uninitialized if
- data[0] == 0
and
- devpriv->model != VMK8061_MODEL
-> we get into the else branch without having reg initialized.
Since the driver usually differentiates between
Hi Gerd,
> > +/* Option name for socket's service label. Use as the option name in
> > + * setsockopt(3) or getsockopt(3) to set or get the service label for a
> > socket.
> > + * The service label is a C-style NUL-terminated string. Only available
> > for
> > + * hypervisor endpoints.
> > + */
> stream_has_data: Returns amount of data available (in bytes) in the
> socket's receive buffer, or -1 if empty.
>
> stream_has_space: Returns amount of space available (in bytes) in the
> socket's send buffer, or -1 if full.
Actually, I think it's for empty/full, and -1 for an error (say, the
Hi Rafael,
The patch seems good.
There is a comment below.
2013/02/13 9:19, Rafael J. Wysocki wrote:
From: Rafael J. Wysocki
This changeset is aimed at fixing a few different but related
problems in the ACPI hotplug infrastructure.
First of all, since notify handlers may be run in parallel
Sparse complains that some functions can be declared as static:
123:6: warning: symbol 'PlatformIOWrite1Byte' was not declared. Should it be
static?
129:6: warning: symbol 'PlatformIOWrite2Byte' was not declared. Should it be
static?
135:6: warning: symbol 'PlatformIOWrite4Byte' was not
WriteBBPortUchar reimplements ReadBBPortUchar in its body, so we can
remove the duplicated code by calling ReadBBPortUchar directly.
Unfortunately we have to move ReadBBPortUchar around; while at it we can
also get rid of the temporary variable for the return value.
Also we can remove the local
Am Mittwoch, 13. Februar 2013, 03:54:26 schrieb Peter Huewe:
> Local variable AcmCtrl is never read/used after assignment so we can remove
> all assignments to it and the related code around the assignments.
>
> Signed-off-by: Peter Huewe
Sorry wrong distribution list.
Seems my script went a
These two functions PlatformIORead2Byte and PlatformIORead4Byte are
unused and thus can be removed.
Signed-off-by: Peter Huewe
---
drivers/staging/rtl8187se/r8185b_init.c | 20
1 files changed, 0 insertions(+), 20 deletions(-)
diff --git
In SetAntennaConfig87SE both branches of if (bAntDiversity) do exactly
the same, except that there is an offset of 0x80 for the register values
if bAntDiversity is true.
-> Consolidate both branches and assign the offset if necessary.
Signed-off-by: Peter Huewe
---
The simple PlatformIORead1Byte function doesn't need to store its return
value in a temporary variable; rather simply return the value directly.
By moving the function to the top we can also get rid of the forward
declaration.
The wrapper functions could be easily replaced by direct calls to
On Tue, Feb 12, 2013 at 4:58 PM, tip-bot for K. Y. Srinivasan
wrote:
> Commit-ID: bc2b0331e077f576369a2b6c75d15ed4de4ef91f
> Gitweb: http://git.kernel.org/tip/bc2b0331e077f576369a2b6c75d15ed4de4ef91f
> Author: K. Y. Srinivasan
> AuthorDate: Sun, 3 Feb 2013 17:22:39 -0800
> Committer:
The local variable u4bAcParam is never read/used after assignment,
thus we can remove the declaration, assignment and any related code.
-> the local variables u1bAIFS, eACI and pAcParam can also be removed.
Signed-off-by: Peter Huewe
---
drivers/staging/rtl8187se/r8185b_init.c | 39
The local variables priv and ieee are not used and thus can be removed.
The local variable u1bAIFS is not used/read after assignment and thus
can be removed.
Signed-off-by: Peter Huewe
---
drivers/staging/rtl8187se/r8185b_init.c |5 -
1 files changed, 0 insertions(+), 5 deletions(-)
The local variable AcParam is only assigned to but not read/used
afterwards, thus it and all related code can be removed.
The bFollowLegacySetting variable and check can also be removed as it is
always true.
Signed-off-by: Peter Huewe
---
drivers/staging/rtl8187se/r8185b_init.c | 35
Local variable AcmCtrl is never read/used after assignment so we can remove
all assignments to it and the related code around the assignments.
Signed-off-by: Peter Huewe
---
drivers/staging/rtl8187se/r8185b_init.c | 49 +--
1 files changed, 1 insertions(+), 48
The local variable AcParam is only assigned to but not read/used
afterwards, thus it and all related code can be removed.
The bFollowLegacySetting variable and check can also be removed as it is
always true.
Signed-off-by: Peter Huewe
---
drivers/staging/rtl8187se/r8185b_init.c | 35
The local variables priv and ieee are not used and thus can be removed.
The local variable u1bAIFS is not used/read after assignment and thus
can be removed.
Signed-off-by: Peter Huewe
---
drivers/staging/rtl8187se/r8185b_init.c |5 -
1 files changed, 0 insertions(+), 5 deletions(-)
The local variable u4bAcParam is never read/used after assignment,
thus we can remove the declaration, assignment and any related code.
-> the local variables u1bAIFS, eACI and pAcParam can also be removed.
Signed-off-by: Peter Huewe
---
drivers/staging/rtl8187se/r8185b_init.c | 39
The simple PlatformIORead1Byte function doesn't need to store its return
value in a temporary variable; rather simply return the value directly.
By moving the function to the top we can also get rid of the forward
declaration.
The wrapper functions could be easily replaced by direct calls to
Sparse complains that some functions can be declared as static:
123:6: warning: symbol 'PlatformIOWrite1Byte' was not declared. Should it be
static?
129:6: warning: symbol 'PlatformIOWrite2Byte' was not declared. Should it be
static?
135:6: warning: symbol 'PlatformIOWrite4Byte' was not
This uses an I2C bus to talk to the ChromeOS EC. The protocol
is defined by the EC and is fairly simple, with a length byte,
checksum, command byte and version byte (to permit easy creation
of new commands).
Signed-off-by: Simon Glass
Signed-off-by: Che-Liang Chiou
---
Changes in v2:
- Remove
WriteBBPortUchar reimplements ReadBBPortUchar in its body, so we can
remove the duplicated code by calling ReadBBPortUchar directly.
Unfortunately we have to move ReadBBPortUchar around; while at it we can
also get rid of the temporary variable for the return value.
Also we can remove the local
These two functions PlatformIORead2Byte and PlatformIORead4Byte are
unused and thus can be removed.
Signed-off-by: Peter Huewe
---
drivers/staging/rtl8187se/r8185b_init.c | 20
1 files changed, 0 insertions(+), 20 deletions(-)
diff --git
Local variable AcmCtrl is never read/used after assignment so we can remove
all assignments to it and the related code around the assignments.
Signed-off-by: Peter Huewe
---
drivers/staging/rtl8187se/r8185b_init.c | 49 +--
1 files changed, 1 insertions(+), 48
In SetAntennaConfig87SE both branches of if (bAntDiversity) do exactly
the same, except that there is an offset of 0x80 for the register values
if bAntDiversity is true.
-> Consolidate both branches and assign the offset if necessary.
Signed-off-by: Peter Huewe
---
On 13 February 2013 02:37, Guenter Roeck wrote:
> On Wed, Jan 23, 2013 at 04:58:06AM -, Naveen Krishna Chatradhi wrote:
>> This patch add an ADC IP found on EXYNOS5 series socs from Samsung.
>> Also adds the Documentation for device tree bindings.
>>
>> Signed-off-by: Naveen Krishna Chatradhi
This file is included verbatim from the ChromeOS EC respository.
Ideally we would prefer to avoid changing it, to make it easier
to track this rapidly-changing file.
Signed-off-by: Simon Glass
Signed-off-by: Che-Liang Chiou
Signed-off-by: Vincent Palatin
---
Changes in v2: None
We now have a binding which adds two parameters to the matrix keypad DT
node. This is separate from the GPIO-driven matrix keypad binding, and
unfortunately incompatible, since that uses row-gpios/col-gpios for the
row and column counts.
So the easiest option here is to provide a function for
The ChromeOS Embedded Controller (EC) is an Open Source EC implementation
used on ARM and Intel Chromebooks. Current implementations use a Cortex-M3
connected on a bus (such as I2C, SPI, LPC) to the AP. A separate interrupt
line is used to indicate when the EC needs service.
Functions performed
This uses a SPI bus to talk to the ChromeOS EC. The protocol
is defined by the EC and is fairly simple, with a length byte,
checksum, command byte and version byte (to permit easy creation
of new commands).
Signed-off-by: Simon Glass
---
Changes in v2:
- Remove use of __devinit/__devexit
Use the key-matrix layer to interpret key scan information from the EC
and inject input based on the FDT-supplied key map. This driver registers
itself with the ChromeOS EC driver to perform communications.
Additional FDT bindings are provided to specify rows/columns and the
auto-repeat
This is the base EC implementation, which provides a high level
interface to the EC for use by the rest of the kernel. The actual
communcations is dealt with by a separate protocol driver which
registers itself with this interface.
Interrupts are passed on through a notifier. The driver supports
On Tue, Feb 12, 2013 at 6:20 PM, Peter Hurley wrote:
> On Tue, 2013-02-12 at 11:11 -0800, Yinghai Lu wrote:
>> Peter Hurley found "irq 18 nobody cared" with pci-next, and dmesg has
>>
>> [8.983246] pci :00:1e.0: can't derive routing for PCI INT A
>> [8.983600] snd_ctxfi :09:02.0:
On Mon, Feb 11, 2013 at 10:10 PM, H. Peter Anvin wrote:
> On 02/11/2013 01:34 AM, Ingo Molnar wrote:
>>
>> * Yinghai Lu wrote:
>>
>>> Hi,
>>>
>>> Current x86 code does not support iapic hotplug yet.
>>
>> Please give a better high-level description: outline how an
>> IO-APIC will be hotplugged
On Tue, 2013-02-12 at 11:11 -0800, Yinghai Lu wrote:
> Peter Hurley found "irq 18 nobody cared" with pci-next, and dmesg has
>
> [8.983246] pci :00:1e.0: can't derive routing for PCI INT A
> [8.983600] snd_ctxfi :09:02.0: PCI INT A: no GSI - using ISA IRQ 5
>
> bisect to
> |
1 - 100 of 1429 matches
Mail list logo
