Re: [git pull] uaccess-related bits of vfs.git

2017-05-12 Thread Al Viro
On Fri, May 12, 2017 at 06:00:44PM -0700, Linus Torvalds wrote: > So I should have asked earlier, but I was feeling rather busy during > the early merge window.. > So I'm actually more interested to hear if you have any pending work > on cleaning up the __get/put_user() mess we have. Is that on yo

Re: [PATCH 26/36] libata.rst: add c function and struct cross-references

2017-05-12 Thread kbuild test robot
Hi Mauro, [auto build test WARNING on linus/master] [also build test WARNING on next-20170512] [cannot apply to v4.11] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Mauro-Carvalho-Chehab/docs

Re: [patch v4 resend 2/2] kcmp: Add KCMP_EPOLL_TFD mode to compare epoll target files

2017-05-12 Thread Cyrill Gorcunov
On Fri, May 12, 2017 at 06:45:09PM -0700, Andrei Vagin wrote: > On Sat, May 13, 2017 at 01:53:40AM +0300, Cyrill Gorcunov wrote: > > On Sat, May 13, 2017 at 12:41:30AM +0200, Jann Horn wrote: > > > [resending as plaintext] > > > > > > I realize that the existing kcmp code has the same issue, but:

Re: [PATCH] ovl: Select EXPORTFS for exportfs_{en,de}code_fh

2017-05-12 Thread Amir Goldstein
On Sat, May 13, 2017 at 5:17 AM, Florian Fainelli wrote: > fs/overlayfs/namei.c now calls exportfs_decode_fh() and > fs/overlayfs/copy_up.c calls exportfs_encode_fh() but misses an EXPORTFS > select which results in the following build error: > Arnd has already sent that patch 2 days ago, but Tha

[PATCH] usb: class: usblp: Fixed assignments inside if conditions

2017-05-12 Thread Alberto Ladron
Fixed coding style issues. Signed-off-by: Alberto Ladron --- drivers/usb/class/usblp.c | 32 +--- 1 file changed, 21 insertions(+), 11 deletions(-) diff --git a/drivers/usb/class/usblp.c b/drivers/usb/class/usblp.c index fb87c17..b1879ff 100644 --- a/drivers/usb/clas

[PATCH v5 3/3] Documentation/kernel-parameters.txt: Update 'memmap=' option description

2017-05-12 Thread Baoquan He
In commit: 9710f581bb4c ("x86, mm: Let "memmap=" take more entries one time") ... 'memmap=' was changed to adopt multiple, comma delimited values in a single entry, so update the related description. In the special case of only specifying size value without an offset, like memmap=nn[KMG], memm

[PATCH v5 2/3] KASLR: Handle memory limit specified by memmap and mem option

2017-05-12 Thread Baoquan He
Option mem= will limit the max address a system can use and any memory region above the limit will be removed. Furthermore, memmap=nn[KMG] which has no offset specified has the same behaviour as mem=. KASLR needs to consider this when choosing the random position for decompressing the kernel. Do

[PATCH v5 1/3] KASLR: Parse all memmap entries in command line

2017-05-12 Thread Baoquan He
In commit: f28442497b5c ("x86/boot: Fix KASLR and memmap= collision") ... the memmap= option is parsed so that KASLR can avoid those reserved regions. It uses cmdline_find_option() to get the value if memmap= is specified, however the problem is that cmdline_find_option() can only find the last

[PATCH v5 0/3] Handle memmap and mem kernel options in boot stage kaslr

2017-05-12 Thread Baoquan He
People reported kernel panic occurs during system boots up with mem boot option. After checking code, several problems are found about memmap= and mem= in boot stage kaslr. *) In commit f28442497b5c ("x86/boot: Fix KASLR and memmap= collision"), only one memmap entry is considered and only th

Re: [PATCH v2] Add "shutdown" to "struct class".

2017-05-12 Thread Greg Kroah-Hartman
On Fri, May 12, 2017 at 04:38:31PM -0700, Josh Zimmerman wrote: > The TPM class has some common shutdown code that must be executed for > all drivers. This adds some needed functionality for that. > > (In addition, update a comment to reflect an out-of-date path.) Change that in a different patch

Re: depmod gets stuck in symlink cycle in arch/arm/boot/dts/include

2017-05-12 Thread Yauheni Kaliuta
Hi, Omar! > On Fri, 12 May 2017 15:23:07 -0700, Omar Sandoval wrote: > Hi, > Linux kernel commit 4027494ae6e3 ("ARM: dts: add arm/arm64 include > symlinks") introduced a couple of symlink cycles: > $ ls -al arch/arm{,64}/boot/dts/include > arch/arm64/boot/dts/include: > total 12 > dr

[PATCH] lightnvm: pblk: fix bad free seq. on error path

2017-05-12 Thread Javier González
Braces around the error patch for metadata pre-allocation are wrongly placed. This causes a memory leak in case of a memory allocation failure. Fix it Signed-off-by: Javier González --- drivers/lightnvm/pblk-init.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletio

Re: Is there an recommended way to refer to bitkeepr commits?

2017-05-12 Thread Eric W. Biederman
Rob Landley writes: > On 05/12/2017 09:45 AM, Eric W. Biederman wrote: >> Thomas Gleixner writes: >> >>> On Fri, 12 May 2017, Michael Ellerman wrote: Fixes: BKrev: 3e8e57a1JvR25MkFRNzoz85l2Gzccg ("[PATCH] linux-2.5.66-signal-cleanup.patch") In your tree that is c3c1070516

[PATCH v3] x86/efi: Correct ident mapping of efi old_map when kalsr enabled

2017-05-12 Thread Baoquan He
For EFI with 'efi=old_map' kernel option specified, Kernel will panic when kaslr is enabled. The back trace is: BUG: unable to handle kernel paging request at 7febd57e IP: 0x7febd57e PGD 1025a067 PUD 0 Oops: 0010 [#1] SMP [ ... ] Call Trace: ? efi_call+0x58/0x90 ? printk+0x58/0x6f efi

[PATCH] devicetree: Move include prefixes from arch to separate directory

2017-05-12 Thread Olof Johansson
We use a directory under arch/$ARCH/boot/dts as an include path that has links outside of the subtree to find dt-bindings from under include/dt-bindings. That's been working well, but new DT architectures haven't been adding them by default. Recently there's been a desire to share some of the DT m

Re: [v6 1/3] ACPI/IORT: Fixup SMMUv3 resource size for Cavium ThunderX2 SMMUv3 model

2017-05-12 Thread Geetha Akula
On Sat, May 13, 2017 at 6:03 AM, kbuild test robot wrote: > Hi Linu, > > [auto build test ERROR on arm64/for-next/core] > [also build test ERROR on v4.11 next-20170512] > [if your patch is applied to the wrong git tree, please drop us a note to > help improve the system] &g

[PATCH] usb: gadget: f_fs: use memdup_user

2017-05-12 Thread Geliang Tang
Use memdup_user() helper instead of open-coding to simplify the code. Signed-off-by: Geliang Tang --- drivers/usb/gadget/function/f_fs.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/usb/gadget/function/f_fs.c b/drivers/usb/gadget/function/f_fs.c index

[PATCH] KEYS: use memdup_user

2017-05-12 Thread Geliang Tang
Use memdup_user() helper instead of open-coding to simplify the code. Signed-off-by: Geliang Tang --- security/keys/keyctl.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/security/keys/keyctl.c b/security/keys/keyctl.c index dd0da25..ce1574a 100644 --- a/securit

[PATCH] USB: iowarrior: use memdup_user

2017-05-12 Thread Geliang Tang
Use memdup_user() helper instead of open-coding to simplify the code. Signed-off-by: Geliang Tang --- drivers/usb/misc/iowarrior.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/usb/misc/iowarrior.c b/drivers/usb/misc/iowarrior.c index 7756953..816afad 10

[PATCH] mmc: block: use memdup_user

2017-05-12 Thread Geliang Tang
Use memdup_user() helper instead of open-coding to simplify the code. Signed-off-by: Geliang Tang --- drivers/mmc/core/block.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/mmc/core/block.c b/drivers/mmc/core/block.c index 8273b07..47ccb2a 100644 ---

Re: [PATCH 4.9 000/103] 4.9.28-stable review

2017-05-12 Thread Guenter Roeck
On 05/11/2017 07:11 AM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.9.28 release. There are 103 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be m

HPET enabled in BIOS, not presented as available_clocksource -- config, kernel code, &/or BIOS?

2017-05-12 Thread PGNet Dev
I run kernel 4.11.0-4 on a Supermicro X10SAT motherboard. HPET's enabled in BIOS, and apparently firmware table data is available. But, hpet is not an available_clocksource. Where's this need to be addressed/fixed? In my config, in kernel code, &/or in BIOS? info: @ the mobo, dmidec

[PATCH] ovl: Select EXPORTFS for exportfs_{en,de}code_fh

2017-05-12 Thread Florian Fainelli
fs/overlayfs/namei.c now calls exportfs_decode_fh() and fs/overlayfs/copy_up.c calls exportfs_encode_fh() but misses an EXPORTFS select which results in the following build error: fs/built-in.o: In function `ovl_get_origin': /home/florian/dev/linux/fs/overlayfs/namei.c:141: undefined reference to

Re: [patch v4 resend 2/2] kcmp: Add KCMP_EPOLL_TFD mode to compare epoll target files

2017-05-12 Thread Andrei Vagin
On Sat, May 13, 2017 at 01:53:40AM +0300, Cyrill Gorcunov wrote: > On Sat, May 13, 2017 at 12:41:30AM +0200, Jann Horn wrote: > > [resending as plaintext] > > > > I realize that the existing kcmp code has the same issue, but: > > > > Why are you not taking a reference to filp or filp_tgt? This ca

[PATCH v2] staging: rtl8188eu: fix indentation error

2017-05-12 Thread Remco Verhoef
Fixes a 'code indent should use tabs where possible' checkpatch code style error by changing whitespace into tabs. Signed-off-by: Remco Verhoef --- Changes in v2: - More expressive commit message and subject drivers/staging/rtl8188eu/hal/rtl8188e_rxdesc.c | 2 +- 1 file changed, 1 insertion(+

Re: [PATCH V2] SMB2: Fix share type handling

2017-05-12 Thread Steve French
Merged into cifs-2.6.git for-next On Fri, May 12, 2017 at 10:59 AM, Christophe JAILLET wrote: > In fs/cifs/smb2pdu.h, we have: > #define SMB2_SHARE_TYPE_DISK0x01 > #define SMB2_SHARE_TYPE_PIPE0x02 > #define SMB2_SHARE_TYPE_PRINT 0x03 > > Knowing that, with the current code, the SMB2_SHA

Re: [PATCH] fs: cifs: transport: Use time_after for time comparison

2017-05-12 Thread Steve French
merged into cifs-2.6.git for-next On Thu, May 11, 2017 at 6:53 PM, Karim Eshapa wrote: > Use time_after kernel macro for time comparison > that has safety check. > > Signed-off-by: Karim Eshapa > --- > fs/cifs/transport.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/

Re: [v6 2/3] iommu/arm-smmu-v3: Add workaround for Cavium ThunderX2 erratum #74

2017-05-12 Thread kbuild test robot
Hi Linu, [auto build test ERROR on arm64/for-next/core] [also build test ERROR on v4.11 next-20170512] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Geetha-sowjanya/Cavium-ThunderX2-SMMUv3

[PATCH] sched: remove sched_find_first_bit()

2017-05-12 Thread Yury Norov
sched_find_first_bit() is in fact the unrolled version of find_first_bit(), which is theoretically faster in some cases. But in the kernel it is called only in couple places in kernel/sched/rt.c, and both of them are not looking like hot paths that will doubtly achieve measurable benefit from usin

Re: [git pull] uaccess-related bits of vfs.git

2017-05-12 Thread Linus Torvalds
So I should have asked earlier, but I was feeling rather busy during the early merge window.. On Sun, Apr 30, 2017 at 8:45 PM, Al Viro wrote: > uaccess unification pile. It's _not_ the end of uaccess work, but > the next batch of that will go into the next cycle. This one mostly takes >

Re: [PATCH] cifs: cifsacl: Use a temporary ops variable to reduce code length

2017-05-12 Thread Steve French
merged into cifs-2.6.git for-next On Tue, May 9, 2017 at 11:26 PM, Shirish Pargaonkar wrote: > Looks correct. > > Acked-by: Shirish Pargaonkar > > On Sun, May 7, 2017 at 3:31 AM, Joe Perches via samba-technical > wrote: >> Create an ops variable to store tcon->ses->server->ops and cache >> indi

Re: [PATCH] arm64: dts: rockchip: Drop explicit "include/" prefix from #include

2017-05-12 Thread Brian Norris
On Sat, May 13, 2017 at 12:53:57AM +0100, Ian Campbell wrote: > It not necessary and counter to how all the other files are done. > > It also happens to break the build in the split device tree repo > https://git.kernel.org/pub/scm/linux/kernel/git/devicetree/devicetree-rebasing.git/ > > Signed-o

Re: [PATCH v3 1/9] arm: dts: mt7623: add mt7623-mt6323.dtsi file

2017-05-12 Thread Fengguang Wu
On Fri, May 12, 2017 at 05:46:06PM +0200, Matthias Brugger wrote: On 12/05/17 12:46, kbuild test robot wrote: Hi John, [auto build test ERROR on robh/for-next] [also build test ERROR on v4.11 next-20170512] [if your patch is applied to the wrong git tree, please drop us a note to help

Re: [PATCH] mdio: mux: fix device_node_continue.cocci warnings

2017-05-12 Thread Julia Lawall
On Fri, 12 May 2017, Florian Fainelli wrote: > On 05/12/2017 09:22 AM, David Miller wrote: > > From: Julia Lawall > > Date: Fri, 12 May 2017 22:54:23 +0800 (SGT) > > > >> Device node iterators put the previous value of the index variable, so an > >> explicit put causes a double put. > > ... >

Re: [v6 1/3] ACPI/IORT: Fixup SMMUv3 resource size for Cavium ThunderX2 SMMUv3 model

2017-05-12 Thread kbuild test robot
Hi Linu, [auto build test ERROR on arm64/for-next/core] [also build test ERROR on v4.11 next-20170512] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Geetha-sowjanya/Cavium-ThunderX2-SMMUv3

[PATCH] arm64: dts: rockchip: Drop explicit "include/" prefix from #include

2017-05-12 Thread Ian Campbell
It not necessary and counter to how all the other files are done. It also happens to break the build in the split device tree repo https://git.kernel.org/pub/scm/linux/kernel/git/devicetree/devicetree-rebasing.git/ Signed-off-by: Ian Campbell Cc: Brian Norris Cc: Heiko Stuebner Cc: Rob Herring

Re: [PATCH] pinctrl: use non-devm kmalloc versions for free functions

2017-05-12 Thread André Przywara
On 12/05/17 18:14, Tony Lindgren wrote: > * Tony Lindgren [170512 08:39]: >> * Linus Walleij [170512 02:28]: >>> On Thu, May 11, 2017 at 4:20 PM, Andre Przywara >>> wrote: Linus, can you shed some light if this array creation serves some purpose? >>> >>> Tony [author of this function] can

Re: [RFC][PATCH 2/5] cpu-hotplug: Allow get_online_cpus() to nest

2017-05-12 Thread Steven Rostedt
On Sat, 13 May 2017 00:15:03 +0200 (CEST) Thomas Gleixner wrote: > On Fri, 12 May 2017, Steven Rostedt wrote: > > void get_online_cpus(void) > > { > > +#ifdef CONFIG_LOCKDEP > > + if (current->goc_depth++) > > + return; > > This must be unconditional and not depend on lockdep. Th

Re: [PATCH 4/5] dt-bindings: phy: Modify Broadcom NS USB 3.0 PHY binding to use MDIO

2017-05-12 Thread Rob Herring
On Thu, May 11, 2017 at 03:29:24PM +0200, Rafał Miłecki wrote: > From: Rafał Miłecki > > Thanks to work done by Broadcom explaining their USB 3.0 PHY details we > know it's attached to the MDIO bus. Use this knowledge to update the > binding: make it a subnode to the MDIO bus and rework way of sp

Re: [PATCH v3 1/3] dt-bindings: Document STM32 I2S bindings

2017-05-12 Thread Rob Herring
On Thu, May 11, 2017 at 11:45:02AM +0200, olivier moysan wrote: > Add documentation of device tree bindings for STM32 SPI/I2S. > > Signed-off-by: olivier moysan > --- > .../devicetree/bindings/sound/st,stm32-i2s.txt | 68 > ++ > 1 file changed, 68 insertions(+) > create

[v1 1/1] usb:host:xhci support option to disable xHCI 1.0 USB2 HW LPM

2017-05-12 Thread Thang Q. Nguyen
XHCI specification 1.1 does not require xHCI 1.0 compliant controllers to always enable hardware USB2 LPM. However, the current xHCI driver always enable it by setting HLE=1 when seeing HLC=1. This makes certain xHCI controllers that have broken USB2 HW LPM fail to work as there is no way to disabl

Re: [RESEND PATCH v4 4/5] dt-bindings: usb: DT bindings documentation for Broadcom IPROC USB Device controller.

2017-05-12 Thread Rob Herring
On Wed, May 10, 2017 at 06:48:08PM +0530, Raviteja Garimella wrote: > The device node is used for UDCs integrated into Broadcom's > iProc family of SoCs'. The UDC is based on Synopsys Designware > Cores AHB Subsystem USB Device Controller IP. > > Signed-off-by: Raviteja Garimella > --- > Documen

Re: [PATCH v5 14/17] dt-bindings: slave-device: add current-speed property

2017-05-12 Thread Rob Herring
On Wed, May 10, 2017 at 10:53:25AM +0200, Stefan Wahren wrote: > This adds a new DT property to define the current baud rate of the > slave device. > > Signed-off-by: Stefan Wahren > --- > Documentation/devicetree/bindings/serial/slave-device.txt | 9 + > 1 file changed, 9 insertions(+)

Re: [PATCH v6 3/4] dt-bindings: mailbox: Introduce Qualcomm APCS global binding

2017-05-12 Thread Rob Herring
On Tue, May 09, 2017 at 12:47:02PM -0700, Bjorn Andersson wrote: > Introduce a binding for the Qualcomm APCS global block, exposing a > mailbox for invoking interrupts on remote processors in the system. > > Signed-off-by: Bjorn Andersson > --- > > Changes since v5: > - None > > .../bindings/m

Re: [RFC/PATCH 1/2] dt-binding: mfd: Add Maxim/Dallas DS1374 MFD device binding

2017-05-12 Thread Rob Herring
On Tue, May 09, 2017 at 11:20:20AM -0700, Moritz Fischer wrote: > This adds a binding for the Maxim/Dallas DS1374 MFD. > > Signed-off-by: Moritz Fischer > --- > > Hi all, > > I'm not entirely sure aobut the binding, does anyone > have a better suggestion for the remap-wdt-reset property? > > T

Re: [PATCH] dt-bindings: Document optional "reserved-names" property

2017-05-12 Thread Rob Herring
On Tue, May 09, 2017 at 10:18:47AM -0700, Florian Fainelli wrote: > Define an optional string property: "reserved-names" which can be used > by the client program to tag/identify reserved memory regions. > > Signed-off-by: Florian Fainelli > --- > Documentation/devicetree/bindings/reserved-memor

Re: [PATCH] nvme: Change our APST table to be no more aggressive than Intel RSTe

2017-05-12 Thread Andy Lutomirski
On Fri, May 12, 2017 at 7:34 AM, wrote: >>Yes, mostly. I've written the patch, but I was planning to target it >>at 4.12 or 4.13 but not -stable. It's mostly just a cleanup and has >>no real power saving benefit since the RSTe timeouts are so absurdly >>conservative that I doubt PS4 will happen

[PATCH v2] Add "shutdown" to "struct class".

2017-05-12 Thread Josh Zimmerman
The TPM class has some common shutdown code that must be executed for all drivers. This adds some needed functionality for that. (In addition, update a comment to reflect an out-of-date path.) Signed-off-by: Josh Zimmerman --- drivers/base/core.c| 5 + include/linux/device.h | 4 +++- 2

[PATCH] Add "shutdown" to "struct class".

2017-05-12 Thread Josh Zimmerman
The TPM class has some common shutdown code that must be executed for all drivers. This adds some needed functionality for that. (In addition, update a comment to reflect an out-of-date path.) --- drivers/base/core.c| 5 + include/linux/device.h | 4 +++- 2 files changed, 8 insertions(+),

[PATCH] kmod: don't load module unless req process has CAP_SYS_MODULE

2017-05-12 Thread Mahesh Bandewar
From: Mahesh Bandewar A process inside random user-ns should not load a module, which is currently possible. As demonstrated in following scenario - Create namespaces; especially a user-ns and become root inside. $ unshare -rfUp -- unshare -unm -- bash Try to load the bridge module. It sh

Re: [kernel-hardening] Re: [PATCH v9 1/4] syscalls: Verify address limit before returning to user-mode

2017-05-12 Thread Andy Lutomirski
On Fri, May 12, 2017 at 12:15 AM, Al Viro wrote: > Folks, seriously, have you even looked through that zoo? I have, and it's > really, really not fun. Sure, we can say "fuck 'em, no need to allow > splice() on random crap". Would be perfectly reasonable, expect that > it's not the only place d

Re: [PATCH v9 1/4] syscalls: Verify address limit before returning to user-mode

2017-05-12 Thread Andy Lutomirski
On Mon, May 8, 2017 at 1:48 PM, Al Viro wrote: > On Mon, May 08, 2017 at 04:06:35PM +0200, Jann Horn wrote: > >> I think Kees might be talking about >> https://bugs.chromium.org/p/project-zero/issues/detail?id=822, fixed in >> commit e6978e4bf181fb3b5f8cb6f71b4fe30fbf1b655c. The issue was that >>

Re: [kernel-hardening] Re: [PATCH v9 1/4] syscalls: Verify address limit before returning to user-mode

2017-05-12 Thread Al Viro
On Fri, May 12, 2017 at 05:47:55PM -0400, Rik van Riel wrote: > > Seriously, look at these beasts.  Overwriting ->addr_limit is nowhere > > near > > the top threat.  If attacker can overwrite thread_info, you have > > lost. > > That is why THREAD_INFO_IN_TASK exists. It moves > the struct thread_

Re: [PATCH v3 1/2] selinux: add brief info to policydb

2017-05-12 Thread William Roberts
On Fri, May 12, 2017 at 3:22 PM, Paul Moore wrote: > > On Thu, May 11, 2017 at 4:45 PM, Casey Schaufler > wrote: > > On 5/11/2017 1:22 PM, Stephen Smalley wrote: > >> On Thu, 2017-05-11 at 08:56 -0700, Casey Schaufler wrote: > >>> On 5/11/2017 5:59 AM, Sebastien Buisson wrote: > Add policyb

mmotm 2017-05-12-15-53 uploaded

2017-05-12 Thread akpm
The mm-of-the-moment snapshot 2017-05-12-15-53 has been uploaded to http://www.ozlabs.org/~akpm/mmotm/ mmotm-readme.txt says README for mm-of-the-moment: http://www.ozlabs.org/~akpm/mmotm/ This is a snapshot of my -mm patch queue. Uploaded at random hopefully more than once a week. You wi

Re: depmod gets stuck in symlink cycle in arch/arm/boot/dts/include

2017-05-12 Thread Olof Johansson
Yeah, the location of the include directory needs to move. I'll post a patch shortly. Russell reported it earlier but the week got busy and I lost track of it. The easiest solution here is to move the dts/include directory to somewhere else. -Olof On Fri, May 12, 2017 at 3:23 PM, Omar Sandoval

Re: [patch v4 resend 2/2] kcmp: Add KCMP_EPOLL_TFD mode to compare epoll target files

2017-05-12 Thread Cyrill Gorcunov
On Sat, May 13, 2017 at 12:41:30AM +0200, Jann Horn wrote: > [resending as plaintext] > > I realize that the existing kcmp code has the same issue, but: > > Why are you not taking a reference to filp or filp_tgt? This can end up > performing a comparison between a pointer to a freed struct file a

Re: [PATCH] mdio: mux: fix device_node_continue.cocci warnings

2017-05-12 Thread Florian Fainelli
On 05/12/2017 09:22 AM, David Miller wrote: > From: Julia Lawall > Date: Fri, 12 May 2017 22:54:23 +0800 (SGT) > >> Device node iterators put the previous value of the index variable, so an >> explicit put causes a double put. > ... >> @@ -169,7 +169,6 @@ int mdio_mux_init(struct device *dev, >>

Re: [PATCH v4 3/5] soc: qcom: Introduce APCS IPC driver

2017-05-12 Thread Bjorn Andersson
On Wed 10 May 19:07 PDT 2017, Jassi Brar wrote: > On Thu, May 11, 2017 at 12:30 AM, Bjorn Andersson > wrote: > > On Tue 09 May 19:33 PDT 2017, Jassi Brar wrote: [..] > > So please let me know what you think about [1], if you don't like it > > I'll fix the things pointed to by Stephen and we'll ha

Re: [patch v4 resend 2/2] kcmp: Add KCMP_EPOLL_TFD mode to compare epoll target files

2017-05-12 Thread Jann Horn
[resending as plaintext] On Mon, Apr 24, 2017 at 5:39 PM, Cyrill Gorcunov wrote: > With current epoll architecture target files are addressed > with file_struct and file descriptor number, where the last > is not unique. Moreover files can be transferred from another > process via unix socket, ad

depmod gets stuck in symlink cycle in arch/arm/boot/dts/include

2017-05-12 Thread Omar Sandoval
Hi, Linux kernel commit 4027494ae6e3 ("ARM: dts: add arm/arm64 include symlinks") introduced a couple of symlink cycles: $ ls -al arch/arm{,64}/boot/dts/include arch/arm64/boot/dts/include: total 12 drwxr-xr-x 1 osandov users 38 May 11 14:01 . drwxr-xr-x 1 osandov users 320 Jan 25 20:44 .. lrwxr

Re: [PATCH v3 1/2] selinux: add brief info to policydb

2017-05-12 Thread Paul Moore
On Thu, May 11, 2017 at 4:45 PM, Casey Schaufler wrote: > On 5/11/2017 1:22 PM, Stephen Smalley wrote: >> On Thu, 2017-05-11 at 08:56 -0700, Casey Schaufler wrote: >>> On 5/11/2017 5:59 AM, Sebastien Buisson wrote: Add policybrief field to struct policydb. It holds a brief info of the po

Re: [PATCH 04/36] mutex, futex: adjust kernel-doc markups to generate ReST

2017-05-12 Thread Darren Hart
On Sat, May 13, 2017 at 12:11:09AM +0200, Peter Zijlstra wrote: > On Fri, May 12, 2017 at 06:51:50PM -0300, Mauro Carvalho Chehab wrote: > > > * Return: > > > * * 0 - ready to wait > > > * * 1 - acquired the lock > > > * * <0 - error > > > > > > I'm fine with either though, just curious i

Re: [PATCH v3 04/29] x86: assembly, use ENDPROC for functions

2017-05-12 Thread Josh Poimboeuf
On Fri, May 12, 2017 at 09:53:48AM +0200, Jiri Slaby wrote: > On 04/26/2017, 03:42 AM, Josh Poimboeuf wrote: > >> @@ -323,7 +323,7 @@ ENTRY(resume_userspace) > >>movl%esp, %eax > >>callprepare_exit_to_usermode > >>jmp restore_all > >> -END(ret_from_exception) > >> +ENDPROC(r

Re: [RFC][PATCH 2/5] cpu-hotplug: Allow get_online_cpus() to nest

2017-05-12 Thread Thomas Gleixner
On Fri, 12 May 2017, Steven Rostedt wrote: > void get_online_cpus(void) > { > +#ifdef CONFIG_LOCKDEP > + if (current->goc_depth++) > + return; This must be unconditional and not depend on lockdep. The percpu rwsem is going to deadlock silently otherwise when a writer is waiting .

Re: [patch v4 resend 2/2] kcmp: Add KCMP_EPOLL_TFD mode to compare epoll target files

2017-05-12 Thread Cyrill Gorcunov
On Fri, May 12, 2017 at 03:00:18PM -0700, Andrew Morton wrote: > On Mon, 24 Apr 2017 18:39:28 +0300 Cyrill Gorcunov wrote: > > That's quite a bit more code. Is there a neat way of making it depend > on a new CONFIG_foo, then select CONFIG_foo if > CONFIG_CHECKPOINT_RESTORE? Sure, will do on top

Re: [PATCH 04/36] mutex, futex: adjust kernel-doc markups to generate ReST

2017-05-12 Thread Peter Zijlstra
On Fri, May 12, 2017 at 06:51:50PM -0300, Mauro Carvalho Chehab wrote: > > * Return: > > * * 0 - ready to wait > > * * 1 - acquired the lock > > * * <0 - error > > > > I'm fine with either though, just curious if this would be an improvement, > > or if > > we have an established policy (

Re: [PATCH 04/36] mutex, futex: adjust kernel-doc markups to generate ReST

2017-05-12 Thread Darren Hart
On Fri, May 12, 2017 at 06:51:50PM -0300, Mauro Carvalho Chehab wrote: > Em Fri, 12 May 2017 09:41:22 -0700 > Darren Hart escreveu: > > > On Fri, May 12, 2017 at 10:59:47AM -0300, Mauro Carvalho Chehab wrote: > > > There are a few issues on some kernel-doc markups that was > > > causing troubles

Re: [patch v4 resend 2/2] kcmp: Add KCMP_EPOLL_TFD mode to compare epoll target files

2017-05-12 Thread Andrew Morton
On Mon, 24 Apr 2017 18:39:28 +0300 Cyrill Gorcunov wrote: > With current epoll architecture target files are addressed > with file_struct and file descriptor number, where the last > is not unique. Moreover files can be transferred from another > process via unix socket, added into queue and clos

[PATCH] efi-pstore: Fix read iter after pstore API refactor

2017-05-12 Thread Kees Cook
During the internal pstore API refactoring, the EFI vars read entry was accidentally made to update a stack variable instead of the pstore private data pointer. This corrects the problem (and removes the now needless argument). Signed-off-by: Kees Cook --- drivers/firmware/efi/efi-pstore.c | 26

Re: [PATCH 2/2] Revert "ACPI / button: Change default behavior to lid_init_state=open"

2017-05-12 Thread Rafael J. Wysocki
On Friday, May 12, 2017 02:36:20 AM Zheng, Lv wrote: > Hi, > > > From: Benjamin Tissoires [mailto:benjamin.tissoi...@redhat.com] > > Subject: Re: [PATCH 2/2] Revert "ACPI / button: Change default behavior to > > lid_init_state=open" > > > > On May 11 2017 or thereabouts, Zheng, Lv wrote: > > >

Re: [PATCH 04/36] mutex, futex: adjust kernel-doc markups to generate ReST

2017-05-12 Thread Mauro Carvalho Chehab
Em Fri, 12 May 2017 09:41:22 -0700 Darren Hart escreveu: > On Fri, May 12, 2017 at 10:59:47AM -0300, Mauro Carvalho Chehab wrote: > > There are a few issues on some kernel-doc markups that was > > causing troubles with kernel-doc output on ReST format. > > Fix them. > > > > No functional changes

Re: [kernel-hardening] Re: [PATCH v9 1/4] syscalls: Verify address limit before returning to user-mode

2017-05-12 Thread Kees Cook
On Fri, May 12, 2017 at 2:41 PM, Al Viro wrote: > On Fri, May 12, 2017 at 02:17:19PM -0700, Kees Cook wrote: > >> Two things are at risk from stack exhaustion: thread_info (mainly >> addr_limit) when on the stack (fixed by THREAD_INFO_IN_TASK), and > > Really? Let's take a look at arm, for exampl

Re: [Resend][PATCH] cpufreq: intel_pstate: Document the current behavior and user interface

2017-05-12 Thread Rafael J. Wysocki
On Friday, May 12, 2017 03:20:48 PM Jonathan Corbet wrote: > On Fri, 12 May 2017 22:47:25 +0200 > "Rafael J. Wysocki" wrote: > > > > Hi Jon, > > > > > > All of the dependencies for this patch have been merged, so I can route it > > > through the PM tree. > > > > > > Please let me know if you pr

Re: [kernel-hardening] Re: [PATCH v9 1/4] syscalls: Verify address limit before returning to user-mode

2017-05-12 Thread Rik van Riel
On Fri, 2017-05-12 at 22:41 +0100, Al Viro wrote: > On Fri, May 12, 2017 at 02:17:19PM -0700, Kees Cook wrote: > > > Two things are at risk from stack exhaustion: thread_info (mainly > > addr_limit) when on the stack (fixed by THREAD_INFO_IN_TASK), and > > Really?  Let's take a look at arm, for e

Re: [PATCH v4 2/4] ACPICA: Tables: Add mechanism to allow to balance late stage acpi_get_table() independently

2017-05-12 Thread Rafael J. Wysocki
On Friday, May 12, 2017 11:03:52 PM Rafael J. Wysocki wrote: > On Tuesday, May 09, 2017 01:57:41 PM Lv Zheng wrote: > > For all frequent late stage acpi_get_table() clone invocations, we should > > only change them altogether, otherwise, excessive acpi_put_table() could > > unexpectedly unmap the t

Re: [PATCH] net: ipv6: Truncate single route when it doesn't fit into dump buffer.

2017-05-12 Thread Jan Moskyto Matejka
On Fri, May 12, 2017 at 11:34:04PM +0200, Jan Moskyto Matejka wrote: > On Fri, May 12, 2017 at 11:24:47AM -0400, David Miller wrote: > > From: Jan Moskyto Matejka > > Date: Fri, 12 May 2017 13:15:10 +0200 > > > > > -int rt6_dump_route(struct rt6_info *rt, void *p_arg); > > > +int rt6_dump_route(s

[PATCH] drivers: char: mem: Check for address space wraparound with mmap()

2017-05-12 Thread Julius Werner
/dev/mem currently allows mmap() mappings that wrap around the end of the physical address space, which should probably be illegal. It circumvents the existing STRICT_DEVMEM permission check because the loop immediately terminates (as the start address is already higher than the end address). On th

Re: [kernel-hardening] Re: [PATCH v9 1/4] syscalls: Verify address limit before returning to user-mode

2017-05-12 Thread Al Viro
On Fri, May 12, 2017 at 02:17:19PM -0700, Kees Cook wrote: > Two things are at risk from stack exhaustion: thread_info (mainly > addr_limit) when on the stack (fixed by THREAD_INFO_IN_TASK), and Really? Let's take a look at arm, for example: struct thread_info { unsigned long

Re: [PATCH] net: ipv6: Truncate single route when it doesn't fit into dump buffer.

2017-05-12 Thread Jan Moskyto Matejka
On Fri, May 12, 2017 at 10:26:08AM -0700, David Ahern wrote: > On 5/12/17 8:24 AM, David Miller wrote: > > From: Jan Moskyto Matejka > > Date: Fri, 12 May 2017 13:15:10 +0200 > > > >> -int rt6_dump_route(struct rt6_info *rt, void *p_arg); > >> +int rt6_dump_route(struct rt6_info *rt, void *p_arg,

Re: [PATCH] net: ipv6: Truncate single route when it doesn't fit into dump buffer.

2017-05-12 Thread Jan Moskyto Matejka
On Fri, May 12, 2017 at 11:24:47AM -0400, David Miller wrote: > From: Jan Moskyto Matejka > Date: Fri, 12 May 2017 13:15:10 +0200 > > > -int rt6_dump_route(struct rt6_info *rt, void *p_arg); > > +int rt6_dump_route(struct rt6_info *rt, void *p_arg, int truncate); > > Please use "bool" and "true"

[PATCH] serial: altera_jtaguart: adding iounmap()

2017-05-12 Thread Alexey Khoroshilov
The driver does ioremap(port->mapbase, ALTERA_JTAGUART_SIZE), but there is no any iounmap(). Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/tty/serial/altera_jtaguart.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/tty/

[GIT PULL] libnvdimm fixes for 4.12-rc1

2017-05-12 Thread Williams, Dan J
Hi Linus, please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm libnvdimm-fixes ...to receive some incremental fixes and a small feature addition relative to the libnvdimm 4.12 pull request. * Geert noticed that tinyconfig was bloated by BLOCK selecting DAX. The size re

Re: [PATCH V2] mm/madvise: Enable (soft|hard) offline of HugeTLB pages at PGD level

2017-05-12 Thread Andrew Morton
On Wed, 26 Apr 2017 09:27:31 +0530 Anshuman Khandual wrote: > Though migrating gigantic HugeTLB pages does not sound much like real > world use case, they can be affected by memory errors. Hence migration > at the PGD level HugeTLB pages should be supported just to enable soft > and hard offline

Re: [RFC][PATCH 0/5] perf/tracing/cpuhotplug: Fix locking order

2017-05-12 Thread Steven Rostedt
On Fri, 12 May 2017 21:49:56 +0200 Peter Zijlstra wrote: > On Fri, May 12, 2017 at 01:15:44PM -0400, Steven Rostedt wrote: > > 2) Allow for get_online_cpus() to nest > > So Thomas and me have been avoiding doing this. > > In general we avoid nested locking in the kernel. Nested locking makes

Re: [PATCH v2] perf/core: Avoid removing shared pmu_context on unregister

2017-05-12 Thread David Carrillo-Cisneros
>> >> Shouldn't be cleaner to keep the check in find_pmu_context, just as it >> was before commit 1fd7e4169954 ("perf/core: Remove >> perf_cpu_context::unique_pmu")? >> >> (Code below untested) >> >> diff --git a/kernel/events/core.c b/kernel/events/core.c >> index 6e75a5c9412d..50d90cbf8418 100644

Re: [kernel-hardening] Re: [PATCH v9 1/4] syscalls: Verify address limit before returning to user-mode

2017-05-12 Thread Daniel Micay
> overflow into adjacent allocations (fixed by VMAP_STACK). 99% fixed, but it's possible to skip over the guard page without -fstack-check enabled (plus some edge cases need to be fixed in GCC), unless VLAs were forbidden in addition to the existing large frame size warning. I'm not sure about in

Re: [PATCH 2/5] extcon: Add FUSB302 USB TYPE-C controller support

2017-05-12 Thread Hans de Goede
Hi, On 24-04-17 15:12, Guenter Roeck wrote: On 04/24/2017 04:02 AM, Heikki Krogerus wrote: +Guenter On Fri, Apr 21, 2017 at 09:51:50PM +0300, Andy Shevchenko wrote: +Cc: Heikki. He might comment on this. Thanks Andy. On Fri, Apr 21, 2017 at 4:01 PM, Hans de Goede wrote: Add support for

Re: [Resend][PATCH] cpufreq: intel_pstate: Document the current behavior and user interface

2017-05-12 Thread Jonathan Corbet
On Fri, 12 May 2017 22:47:25 +0200 "Rafael J. Wysocki" wrote: > > Hi Jon, > > > > All of the dependencies for this patch have been merged, so I can route it > > through the PM tree. > > > > Please let me know if you prefer to take it into the documentation tree > > instead. > > I'm taking t

[PATCH] staging: iio: meter: Replace symbolic permissions with octal permissions

2017-05-12 Thread Harinath Nampally
This patch fixes below kind of warnings: WARNING: Symbolic permissions 'S_IXXX | S_IXXX' are not preferred. Issue found and fixed by checkpatch.pl Signed-off-by: Harinath Nampally --- drivers/staging/iio/meter/ade7758_core.c | 50 1 file changed, 25 insertions(+

[RFC][PATCH 0/2] Few DTS changes needed for Nexus7 support

2017-05-12 Thread John Stultz
Wanted to send out a few dts patches needed to get the usb and wifi mostly working on the 2013 Nexus7(flo). Still need one code change, to boot, and a few more hacks to get the touch input and wifi totally working. If anyone is interested, my mainline tracking WIP tree is here: https://git.linaro

[PATCH 1/2] ARM: dts: qcom-apq8064: Collapse usb support into one node

2017-05-12 Thread John Stultz
From: Stephen Boyd We currently have three device nodes for the same USB hardware block, as evident by the reuse of the same reg address multiple times. Now that the chipidea driver fully supports OTG with the MSM wrapper we can collapse the three nodes into one USB device node, reflecting the tr

[PATCH 2/2] ARM: dts: nexus7: Add regulator tweaks and wcnss entry to support wifi

2017-05-12 Thread John Stultz
Tweak and add some regulator entries that are needed to support wifi. The values here were taken from: arch/arm/mach-msm/asustek/flo/board-flo-regulator.c in the AOSP msm 3.4 flo branch. This also adds a wcnss entry so it gets enabled on the board. Cc: Bjorn Andersson Cc: Srinivas Kandagatla C

Re: [kernel-hardening] Re: [PATCH v9 1/4] syscalls: Verify address limit before returning to user-mode

2017-05-12 Thread Kees Cook
On Fri, May 12, 2017 at 2:06 PM, Al Viro wrote: > On Fri, May 12, 2017 at 09:21:06PM +0100, Russell King - ARM Linux wrote: >> On Fri, May 12, 2017 at 12:30:02PM -0700, Kees Cook wrote: >> > I'm clearly not explaining things well enough. I shouldn't say >> > "corruption", I should say "malicious m

Re: [kernel-hardening] Re: [PATCH v9 1/4] syscalls: Verify address limit before returning to user-mode

2017-05-12 Thread Daniel Micay
On Fri, 2017-05-12 at 22:06 +0100, Al Viro wrote: > On Fri, May 12, 2017 at 09:21:06PM +0100, Russell King - ARM Linux > wrote: > > On Fri, May 12, 2017 at 12:30:02PM -0700, Kees Cook wrote: > > > I'm clearly not explaining things well enough. I shouldn't say > > > "corruption", I should say "malic

Re: [PATCH v4 2/4] ACPICA: Tables: Add mechanism to allow to balance late stage acpi_get_table() independently

2017-05-12 Thread Rafael J. Wysocki
On Tuesday, May 09, 2017 01:57:41 PM Lv Zheng wrote: > For all frequent late stage acpi_get_table() clone invocations, we should > only change them altogether, otherwise, excessive acpi_put_table() could > unexpectedly unmap the table used by the other users. Thus the current plan > is to change al

Re: [RFC PATCH] PCI: disable MSI/MSI-X before resetting

2017-05-12 Thread Brian Norris
On Fri, May 12, 2017 at 10:07:29AM -0700, Alexander Duyck wrote: > On Thu, May 11, 2017 at 2:54 PM, Brian Norris > wrote: > > Despite the claims in the associated comment block, it seems that > > clearing the command register is not enough to guarantee that no > > MSI interrupts get triggered dur

[PATCH] arm: ftrace: Adds support for CONFIG_DYNAMIC_FTRACE_WITH_REGS

2017-05-12 Thread Abel Vesa
The DYNAMIC_FTRACE_WITH_REGS configuration makes it possible for a ftrace operation to specify if registers need to saved/restored by the ftrace handler. This is needed by kgraft and possibly other ftrace-based tools, and the ARM architecture is currently lacking this feature. It would also be the

Re: [kernel-hardening] Re: [PATCH v9 1/4] syscalls: Verify address limit before returning to user-mode

2017-05-12 Thread Al Viro
On Fri, May 12, 2017 at 09:21:06PM +0100, Russell King - ARM Linux wrote: > On Fri, May 12, 2017 at 12:30:02PM -0700, Kees Cook wrote: > > I'm clearly not explaining things well enough. I shouldn't say > > "corruption", I should say "malicious manipulation". The methodology > > of attacks against t

Re: [PATCH] arm: ftrace: Adds support for CONFIG_DYNAMIC_FTRACE_WITH_REGS

2017-05-12 Thread Abel Vesa
On Fri, May 12, 2017 at 09:38:37PM +0100, abelv...@gmail.com wrote: > From: Abel Vesa To be ignored, wrong git config. Will send another one without the From line. > > The DYNAMIC_FTRACE_WITH_REGS configuration makes it possible for a ftrace > operation to specify if registers need to saved/resto

  1   2   3   4   5   6   7   >