Re: [PATCH v5 08/14] platform/x86: dell-smbios: Add a sysfs interface for SMBIOS tokens

2017-10-06 Thread Greg KH
On Fri, Oct 06, 2017 at 11:59:52PM -0500, Mario Limonciello wrote: > Currently userspace tools can access system tokens via the dcdbas > kernel module and a SMI call that will cause the platform to execute > SMM code. > > With a goal in mind of deprecating the dcdbas kernel module a different > me

5f82e71a00 ("Merge branch 'locking-core-for-linus' of .."): watchdog: BUG: soft lockup - CPU#0 stuck for 21s! [swapper:1]

2017-10-06 Thread kernel test robot
Greetings, 0day kernel testing robot got the below dmesg and the first bad commit is https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master commit 5f82e71a001d14824a7728ad9e49f6aea420f161 Merge: 6c51e67b64d16 edc2988c548db Author: Linus Torvalds AuthorDate: Mon Sep 4 11:5

Re: [Patch v6 2/7] slimbus: Add messaging APIs to slimbus framework

2017-10-06 Thread Jonathan Neuschäfer
Hi, On Fri, Oct 06, 2017 at 05:51:31PM +0200, srinivas.kandaga...@linaro.org wrote: > From: Sagar Dharia > > Slimbus devices use value-element, and information elements to > control device parameters (e.g. value element is used to represent > gain for codec, information element is used to repres

Re: [for-next][PATCH 15/16] ftrace: Add freeing algorithm to free ftrace_mod_maps

2017-10-06 Thread Joel Fernandes (Google)
Hi Steve, On Fri, Oct 6, 2017 at 11:07 AM, Steven Rostedt wrote: > From: "Steven Rostedt (VMware)" > > The ftrace_mod_map is a descriptor to save module init function names in > case they were traced, and the trace output needs to reference the function > name from the function address. But afte

Re: [RFC PATCH -tip 0/5] kprobes: Abolish jprobe APIs

2017-10-06 Thread Stafford Horne
Hello, Nice read, see some comments below On Fri, Oct 06, 2017 at 11:34:30AM -0400, Steven Rostedt wrote: > On Fri, 6 Oct 2017 13:49:59 +0900 > Masami Hiramatsu wrote: > > > Steve, could you write a documentation how to use ftrace callback? > > I think I should update the Documentation/kprobes.

Re: [PATCH] mwifiex: Use put_unaligned_le32

2017-10-06 Thread kbuild test robot
Hi Himanshu, [auto build test ERROR on wireless-drivers-next/master] [also build test ERROR on v4.14-rc3 next-20170929] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Himanshu-Jha/mwifiex-Use-pu

Re: [PATCH] MAINTAINERS: Update the UV architecture to current addresses

2017-10-06 Thread Joe Perches
On Fri, 2017-10-06 at 15:36 -0500, Nathan Zimmer wrote: > After the buyout/merger our @sgi.com address are slowing being less useful. > So make sure we are can be contacted properly. This seems more like a new entry so the commit message seems wrong. > Signed-off-by: Nathan Zimmer > Signed-off-b

[PATCH] irqchip/gicv3-its: Add missing changes to support 52bit physical address

2017-10-06 Thread Shanker Donthineni
The current ITS driver works fine as long as normal memory and GICR regions are located within the lower 48bit (>=0 && <2^48) physical address space. Some of the registers GICR_PEND/PROP, GICR_VPEND/VPROP and GITS_CBASER are handled properly but not all when configuring the hardware with 52bit phys

Re: [Patch v6 6/7] regmap: add SLIMBUS support

2017-10-06 Thread Jonathan Neuschäfer
Hi, On Fri, Oct 06, 2017 at 05:51:35PM +0200, srinivas.kandaga...@linaro.org wrote: > From: Srinivas Kandagatla > > This patch adds support to read/write slimbus value elements. > Currently it only supports byte read/write. Adding this support in > regmap would give codec drivers more flexibilit

[PATCH v5 02/14] platform/x86: dell-wmi: increase severity of some failures

2017-10-06 Thread Mario Limonciello
There is a lot of error checking in place for the format of the WMI descriptor buffer, but some of the potentially raised issues should be considered critical failures. If the buffer size or header don't match, this is a good indication that the buffer format changed in a way that the rest of the

[PATCH v5 01/14] platform/x86: wmi: Add new method wmidev_evaluate_method

2017-10-06 Thread Mario Limonciello
Drivers properly using the wmibus can pass their wmi_device pointer rather than the GUID back to the WMI bus to evaluate the proper methods. Any "new" drivers added that use the WMI bus should use this rather than the old wmi_evaluate_method that would take the GUID. Signed-off-by: Mario Limoncie

[PATCH v5 03/14] platform/x86: dell-wmi: clean up wmi descriptor check

2017-10-06 Thread Mario Limonciello
Some cases the wrong type was used for errors and checks can be done more cleanly. Signed-off-by: Mario Limonciello Reviewed-by: Edward O'Callaghan Suggested-by: Andy Shevchenko --- drivers/platform/x86/dell-wmi.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/d

[PATCH v5 07/14] platform/x86: dell-smbios: only run if proper oem string is detected

2017-10-06 Thread Mario Limonciello
The proper way to indicate that a system is a 'supported' Dell System is by the presence of this string in OEM strings. Allowing the driver to load on non-Dell systems will have undefined results. Signed-off-by: Mario Limonciello --- drivers/platform/x86/dell-smbios.c | 7 +++ 1 file change

[PATCH v5 08/14] platform/x86: dell-smbios: Add a sysfs interface for SMBIOS tokens

2017-10-06 Thread Mario Limonciello
Currently userspace tools can access system tokens via the dcdbas kernel module and a SMI call that will cause the platform to execute SMM code. With a goal in mind of deprecating the dcdbas kernel module a different method for accessing these tokens from userspace needs to be created. This is in

[PATCH v5 04/14] platform/x86: dell-wmi: allow 32k return size in the descriptor

2017-10-06 Thread Mario Limonciello
Some platforms this year will be adopting 32k WMI buffer, so don't complain when encountering those. Signed-off-by: Mario Limonciello --- drivers/platform/x86/dell-wmi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86

[PATCH v5 09/14] platform/x86: dell-smbios: Introduce dispatcher for SMM calls

2017-10-06 Thread Mario Limonciello
This splits up the dell-smbios driver into two drivers: * dell-smbios * dell-smbios-smm dell-smbios can operate with multiple different dispatcher drivers to perform SMBIOS operations. Also modify the interface that dell-laptop and dell-wmi use align to this model more closely. Rather than a sin

[PATCH v5 05/14] platform/x86: dell-wmi-descriptor: split WMI descriptor into it's own driver

2017-10-06 Thread Mario Limonciello
All communication on individual GUIDs should occur in separate drivers. Allowing a driver to communicate with the bus to another GUID is just a hack that discourages drivers to adopt the bus model. The information found from the WMI descriptor driver is now exported for use by other drivers. Sign

[PATCH v5 00/14] Introduce support for Dell SMBIOS over WMI

2017-10-06 Thread Mario Limonciello
The existing way that the dell-smbios helper module and associated other drivers (dell-laptop, dell-wmi) communicate with the platform really isn't secure. It requires creating a buffer in physical DMA32 memory space and passing that to the platform via SMM. Since the platform got a physical memo

[PATCH v5 11/14] platform/x86: dell-smbios-wmi: Add new WMI dispatcher driver

2017-10-06 Thread Mario Limonciello
The dell-smbios stack only currently uses an SMI interface which grants direct access to physical memory to the firmware SMM methods via a pointer. This dispatcher driver adds a WMI-ACPI interface that is detected by WMI probe and preferred over the SMI interface in dell-smbios. Changing this to

[PATCH v5 10/14] platform/x86: dell-smbios: add filtering capability for requests

2017-10-06 Thread Mario Limonciello
There are some categories of tokens and SMBIOS calls that it makes sense to protect userspace from accessing. These are calls that may write to one time use fields or activate hardware debugging capabilities. They are not intended for general purpose use. This same functionality may be be later

[PATCH v5 13/14] platform/x86: wmi: create character devices when requested by drivers

2017-10-06 Thread Mario Limonciello
For WMI operations that are only Set or Query read or write sysfs attributes created by WMI vendor drivers make sense. For other WMI operations that are run on Method, there needs to be a way to guarantee to userspace that the results from the method call belong to the data request to the method c

[PATCH v5 14/14] platform/x86: dell-smbios-wmi: introduce userspace interface

2017-10-06 Thread Mario Limonciello
It's important for the driver to provide a R/W ioctl to ensure that two competing userspace processes don't race to provide or read each others data. This userspace character device will be used to perform SMBIOS calls from any applications. It provides an ioctl that will allow passing the WMI ca

[PATCH v5 06/14] platform/x86: wmi: Don't allow drivers to get each other's GUIDs

2017-10-06 Thread Mario Limonciello
The only driver using this was dell-wmi, and it really was a hack. The driver was getting a data attribute from another driver and this type of action should not be encouraged. Rather drivers that need to interact with one another should pass data back and forth via exported functions. Signed-off

[PATCH v5 12/14] platform/x86: dell-smbios-smm: test for WSMT

2017-10-06 Thread Mario Limonciello
WSMT is as an attestation to the OS that the platform won't modify memory outside of pre-defined areas. If a platform has WSMT enabled in BIOS setup, SMM calls through dcdbas will fail. The only way to access platform data in these instances is through the WMI SMBIOS calling interface. Signed-of

Re: [ANNOUNCE] v4.11.12-rt13

2017-10-06 Thread Mike Galbraith
On Fri, 2017-10-06 at 19:38 +0200, Mike Galbraith wrote: > On Fri, 2017-10-06 at 15:33 +0200, Mike Galbraith wrote: > > > > I'll run full ltp again, make sure there are no new failure deltas. > > Haven't done that yet, but I have checked all of the reported failures. > > time-hrtimer:-Use-softir

[rcu:rcu/next 48/97] drivers/firmware/tegra/ivc.c:154:39: error: lvalue required as left operand of assignment

2017-10-06 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git rcu/next head: bd76953f4e7b0b1f66b3fe631106fcc4c85a380c commit: 669f98e232aa6f77bd602e2826dd55c3694109e5 [48/97] drivers/firmware/tegra: Convert ACCESS_ONCE() to READ_ONCE() config: arm64-defconfig (attached as .confi

Re: [PATCH] crypto: bcm: use of_device_get_match_data

2017-10-06 Thread Herbert Xu
On Wed, Sep 20, 2017 at 08:47:26PM +0200, Corentin Labbe wrote: > The usage of of_device_get_match_data reduce the code size a bit. > Furthermore, it prevents an improbable dereference when > of_match_device() return NULL. > > Signed-off-by: Corentin Labbe Patch applied. Thanks. -- Email: Herb

Re: [PATCH] crypto: stm32: use of_device_get_match_data

2017-10-06 Thread Herbert Xu
On Wed, Sep 20, 2017 at 08:31:40PM +0200, Corentin Labbe wrote: > The usage of of_device_get_match_data reduce the code size a bit. > Furthermore, it prevents an improbable dereference when > of_match_device() return NULL. > > Signed-off-by: Corentin Labbe Patch applied. Thanks. -- Email: Herb

Re: [PATCH] crypto: omap: use of_device_get_match_data

2017-10-06 Thread Herbert Xu
On Wed, Sep 20, 2017 at 08:42:48PM +0200, Corentin Labbe wrote: > The usage of of_device_get_match_data reduce the code size a bit. > Furthermore, it prevents an improbable dereference when > of_match_device() return NULL. > > Signed-off-by: Corentin Labbe Patch applied. Thanks. -- Email: Herb

Re: [PATCH] crypto: algboss: remove redundant setting of len to zero

2017-10-06 Thread Herbert Xu
On Thu, Sep 14, 2017 at 07:02:19PM +0100, Colin King wrote: > From: Colin Ian King > > The variable len is set to zero, never read and then later updated > to p - name, so clearly the zero'ing of len is redundant and > can be removed. > > Detected by clang scan-build: > " warning: Value stored t

Re: [PATCH 02/10] drivers:crypto: return -ENOMEM on allocation failure.

2017-10-06 Thread Herbert Xu
Allen Pais wrote: > Signed-off-by: Allen Pais Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Re: [PATCH 1/2] crypto: stm32 - Fix uninitialized data usage

2017-10-06 Thread Herbert Xu
On Tue, Sep 12, 2017 at 11:35:38AM +0200, Arnd Bergmann wrote: > The error handling in stm32_hash_irq_thread passes > uninitialized data into stm32_hash_finish_req, as gcc > points out: > > drivers/crypto/stm32/stm32-hash.c: In function 'stm32_hash_irq_thread': > drivers/crypto/stm32/stm32-hash.c:

Re: [PATCH 2/2] crypto: stm32 - Try to fix hash padding

2017-10-06 Thread Herbert Xu
On Tue, Sep 12, 2017 at 11:35:39AM +0200, Arnd Bergmann wrote: > gcc warns that the length for the extra unaligned data in the hash > function may be used unaligned. In theory this could happen if > we pass a zero-length sg_list, or if sg_is_last() was never true: > > In file included from drivers

Re: [PATCH] crc32-pclmul: remove useless relative addressing

2017-10-06 Thread Herbert Xu
On Wed, Sep 06, 2017 at 10:41:21PM -0400, Mikulas Patocka wrote: > In 32-bit mode, the x86 architecture can hold full 32-bit pointers. > Therefore, the code that copies the current address to the %ecx register > and uses %ecx-relative addressing is useless, we could just use absolute > addressing.

Re: [PATCH] crypto: xts - Fix an error handling path in 'create()'

2017-10-06 Thread Herbert Xu
On Tue, Sep 26, 2017 at 08:17:44AM +0200, Christophe JAILLET wrote: > All error handling paths 'goto err_drop_spawn' except this one. > In order to avoid some resources leak, we should do it as well here. > > Fixes: f1c131b45410 ("crypto: xts - Convert to skcipher") > Signed-off-by: Christophe JAI

Re: [Patch v6 1/7] slimbus: Device management on SLIMbus

2017-10-06 Thread Jonathan Neuschäfer
Hi, I have some more or less trivial comments below. On Fri, Oct 06, 2017 at 05:51:30PM +0200, srinivas.kandaga...@linaro.org wrote: > From: Sagar Dharia > > SLIMbus (Serial Low Power Interchip Media Bus) is a specification > developed by MIPI (Mobile Industry Processor Interface) alliance. > SL

Re: [PATCH 1/2] Revert "vmalloc: back off when the current task is killed"

2017-10-06 Thread Tetsuo Handa
Johannes Weiner wrote: > On Sat, Oct 07, 2017 at 11:21:26AM +0900, Tetsuo Handa wrote: > > On 2017/10/05 19:36, Tetsuo Handa wrote: > > > I don't want this patch backported. If you want to backport, > > > "s/fatal_signal_pending/tsk_is_oom_victim/" is the safer way. > > > > If you backport this pa

Re: [PATCH] sched/rt.c: pick and check task if double_lock_balance() unlock the rq

2017-10-06 Thread zhouchengming
Hi Steven, Peter, On 2017/9/26 11:18, Steven Rostedt wrote: On Tue, 26 Sep 2017 09:23:20 +0800 zhouchengming wrote: On 2017/9/26 3:40, Steven Rostedt wrote: On Mon, 11 Sep 2017 14:51:49 +0800 Zhou Chengming wrote: push_rt_task() pick the first pushable task and find an eligible lowest_rq

Re: [RFC PATCH] crypto: make the seed() function optional

2017-10-06 Thread Herbert Xu
Mathieu Malaterre wrote: > This makes it simplier for driver author to not provide the seed() function > in case of a pseudo RNG where the seed operation is a no-op. > > Document that the seed() function pointer is optional in header. > > Signed-off-by: Mathieu Malaterre > --- > The PRNG as fou

Re: [PATCH] mwifiex: Use put_unaligned_le32

2017-10-06 Thread kbuild test robot
Hi Himanshu, [auto build test ERROR on wireless-drivers-next/master] [also build test ERROR on v4.14-rc3 next-20170929] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Himanshu-Jha/mwifiex-Use-pu

Re: [PATCH tip/core/rcu 1/9] rcu: Provide GP ordering in face of migrations and delays

2017-10-06 Thread Paul E. McKenney
On Fri, Oct 06, 2017 at 10:15:37PM +0200, Peter Zijlstra wrote: > On Fri, Oct 06, 2017 at 12:18:22PM -0700, Paul E. McKenney wrote: > > > /me goes and install this herd thing again.. I'm sure I had it running > > > _somewhere_.. A well. > > > > > > C C-PaulEMcKenney-W+RWC4+2017-10-05 > > > > >

follow this information

2017-10-06 Thread ''vinec''
hello,note that i am having problem with other e-mail. i therefore, recommend you to register free via below link to increase your finance, free money no charges click or copy link - http://woredrzydo.win/8071093818423/ please get back to me after registration.

Re: [BUG] GPF on reboot of box

2017-10-06 Thread Steven Rostedt
This bug still crashes my box on rc3 -- Steve On October 6, 2017 10:21:26 PM EDT, Nadav Amit wrote: >Steven Rostedt wrote: > >> Starting with v4.14-rc1 my box crashes during a reboot. All I get is >> the following: >> >> [ 250.615793] sd 0:0:0:0: [sda] Synchronizing SCSI cache >> [ 250.6356

Re: [PATCH 4.9 086/104] arm64: kasan: avoid bad virt_to_pfn()

2017-10-06 Thread Levin, Alexander (Sasha Levin)
On Fri, Oct 06, 2017 at 07:13:22PM +0100, Mark Rutland wrote: >Hi Greg, > >On Fri, Oct 06, 2017 at 10:52:04AM +0200, Greg Kroah-Hartman wrote: >> 4.9-stable review patch. If anyone has any objections, please let me know. > >I'm a little confused as to why this is being backported, given it >wasn't

Re: [PATCH v8 01/20] crypto: change transient busy return code to -EAGAIN

2017-10-06 Thread Herbert Xu
On Tue, Sep 05, 2017 at 03:38:40PM +0300, Gilad Ben-Yossef wrote: > > diff --git a/crypto/algif_hash.c b/crypto/algif_hash.c > index 5e92bd2..3b3c154 100644 > --- a/crypto/algif_hash.c > +++ b/crypto/algif_hash.c > @@ -39,6 +39,20 @@ struct algif_hash_tfm { > bool has_key; > }; > > +/* Pre

[PATCH v2 2/4] kmemcheck: stop using GFP_NOTRACK and SLAB_NOTRACK

2017-10-06 Thread Levin, Alexander (Sasha Levin)
Convert all allocations that used a NOTRACK flag to stop using it. Signed-off-by: Sasha Levin --- arch/arm/include/asm/pgalloc.h | 2 +- arch/arm64/include/asm/pgalloc.h | 2 +- arch/powerpc/include/asm/pgalloc.h | 2 +- arch/sh/kernel/dwarf.c | 4 ++-- arch/sh/kern

[PATCH v2 1/4] kmemcheck: remove annotations

2017-10-06 Thread Levin, Alexander (Sasha Levin)
Remove kmemcheck annotations, and calls to kmemcheck from the kernel. Signed-off-by: Sasha Levin --- arch/arm/include/asm/dma-iommu.h| 1 - arch/openrisc/include/asm/dma-mapping.h | 1 - arch/x86/Makefile | 5 - arch/x86/include/asm/dma-mapping.h | 1 -

[PATCH v2 3/4] kmemcheck: rip it out

2017-10-06 Thread Levin, Alexander (Sasha Levin)
Fix up makefiles, remove references, and git rm kmemcheck. Signed-off-by: Sasha Levin --- Documentation/admin-guide/kernel-parameters.txt | 7 - Documentation/dev-tools/index.rst | 1 - Documentation/dev-tools/kmemcheck.rst | 733 MAINTAINERS

[PATCH v2 4/4] kmemcheck: remove whats left of NOTRACK flags

2017-10-06 Thread Levin, Alexander (Sasha Levin)
Now that kmemcheck is gone, we don't need the NOTRACK flags. Signed-off-by: Sasha Levin --- arch/x86/include/asm/pgtable.h | 5 - arch/x86/include/asm/pgtable_types.h | 13 - include/linux/gfp.h | 9 - include/linux/slab.h | 6 ---

[PATCH v2 0/4] kmemcheck: kill kmemcheck

2017-10-06 Thread Levin, Alexander (Sasha Levin)
2 Years ago I proposed to kill kmemcheck: > As discussed on LSF/MM, kill kmemcheck. > > KASan is a replacement that is able to work without the limitation of > kmemcheck (single CPU, slow). KASan is already upstream. > > We are also not aware of any users of kmemcheck (or users who don't consider

Re: [PATCH] Userfaultfd: Add description for UFFD_FEATURE_SIGBUS

2017-10-06 Thread Prakash Sangappa
cc: Andrea Arcangeli On 10/6/17 7:52 PM, Prakash Sangappa wrote: Userfaultfd feature UFFD_FEATURE_SIGBUS was merged recently and should be available in Linux 4.14 release. This patch is for the manpage changes documenting this API. Documents the following commit: commit 2d6d6f5a09a96cc1fec7ed

[PATCH] Userfaultfd: Add description for UFFD_FEATURE_SIGBUS

2017-10-06 Thread Prakash Sangappa
Userfaultfd feature UFFD_FEATURE_SIGBUS was merged recently and should be available in Linux 4.14 release. This patch is for the manpage changes documenting this API. Documents the following commit: commit 2d6d6f5a09a96cc1fec7ed992b825e05f64cb50e Author: Prakash Sangappa Date: Wed Sep 6 16:23:39

Re: [PATCH 1/2] Revert "vmalloc: back off when the current task is killed"

2017-10-06 Thread Johannes Weiner
On Sat, Oct 07, 2017 at 11:21:26AM +0900, Tetsuo Handa wrote: > On 2017/10/05 19:36, Tetsuo Handa wrote: > > I don't want this patch backported. If you want to backport, > > "s/fatal_signal_pending/tsk_is_oom_victim/" is the safer way. > > If you backport this patch, you will see "complete depleti

[RFC v4 5/8] platform/x86: intel_punit_ipc: Fix resource ioremap warning

2017-10-06 Thread sathyanarayanan . kuppuswamy
From: Kuppuswamy Sathyanarayanan For PUNIT device, ISPDRIVER_IPC and GTDDRIVER_IPC resources are not mandatory. So when PMC IPC driver creates a PUNIT device, if these resources are not available then it creates dummy resource entries for these missing resources. But during PUNIT device probe , d

[RFC v4 7/8] platform/x86: intel_pmc_ipc: Use generic Intel IPC device calls

2017-10-06 Thread sathyanarayanan . kuppuswamy
From: Kuppuswamy Sathyanarayanan Removed redundant IPC helper functions and refactored the driver to use generic IPC device driver APIs. Also, cleaned up the driver to minimize the usage of global variable ipcdev by propogating the struct intel_pmc_ipc_dev pointer or by getting it from device pri

[RFC v4 6/8] platform/x86: intel_punit_ipc: Use generic intel ipc device calls

2017-10-06 Thread sathyanarayanan . kuppuswamy
From: Kuppuswamy Sathyanarayanan Removed redundant IPC helper functions and refactored the driver to use APIs provided by generic IPC driver. This patch also cleans-up PUNIT IPC user drivers(intel_telemetry_pltdrv.c) to use APIs provided by generic IPC driver. Signed-off-by: Kuppuswamy Sathyanar

[RFC v4 4/8] platform: x86: Add generic Intel IPC driver

2017-10-06 Thread sathyanarayanan . kuppuswamy
From: Kuppuswamy Sathyanarayanan Currently intel_scu_ipc.c, intel_pmc_ipc.c and intel_punit_ipc.c redundantly implements the same IPC features and has lot of code duplication between them. This driver addresses this issue by grouping the common IPC functionalities under the same driver. Signed-o

[RFC v4 1/8] platform/x86: intel_pmc_ipc: Use MFD framework to create dependent devices

2017-10-06 Thread sathyanarayanan . kuppuswamy
From: Kuppuswamy Sathyanarayanan Currently, we have lot of repetitive code in dependent device resource allocation and device creation handling code. This logic can be improved if we use MFD framework for dependent device creation. This patch adds this support. Signed-off-by: Kuppuswamy Sathyana

[RFC v4 0/8] PMC/PUNIT IPC driver cleanup

2017-10-06 Thread sathyanarayanan . kuppuswamy
From: Kuppuswamy Sathyanarayanan Hi All, Currently intel_pmc_ipc.c, intel_punit_ipc.c, intel_scu_ipc.c drivers implements the same IPC features. This code duplication could be avoided if we implement the IPC driver as a generic library and let custom device drivers use API provided by generic

[RFC v4 8/8] platform/x86: intel_scu_ipc: Use generic Intel IPC device calls

2017-10-06 Thread sathyanarayanan . kuppuswamy
From: Kuppuswamy Sathyanarayanan Removed redundant IPC helper functions and refactored the driver to use generic IPC device driver APIs. This patch also cleans-up SCU IPC user drivers(rtc-mrst.c, intel-mid_wdt.c, intel-mid_wdt.c, intel-mid.c) to use APIs provided by generic IPC driver. Signed-o

[RFC v4 3/8] platform/x86: intel_pmc_ipc: Use regmap calls for GCR updates

2017-10-06 Thread sathyanarayanan . kuppuswamy
From: Kuppuswamy Sathyanarayanan This patch adds support for regmap based implementation for GCR read/write/update APIs. Signed-off-by: Kuppuswamy Sathyanarayanan --- drivers/platform/x86/Kconfig | 1 + drivers/platform/x86/intel_pmc_ipc.c | 120 +--

[RFC v4 2/8] platform/x86: intel_pmc_ipc: Use spin_lock to protect GCR updates

2017-10-06 Thread sathyanarayanan . kuppuswamy
From: Kuppuswamy Sathyanarayanan Currently, update_no_reboot_bit() function implemented in this driver uses mutex_lock() to protect its register updates. But this function is called with in atomic context in iTCO_wdt_start() and iTCO_wdt_stop() functions in iTCO_wdt.c driver, which in turn causes

Re: [PATCH] bcache: Remove nested function from sysfs

2017-10-06 Thread Coly Li
On 2017/10/7 上午5:35, Matthias Kaehlcke wrote: > From: Behan Webster > > Replace the use of nested functions where a normal function will > suffice. > > Nested functions are not liked by upstream kernel developers in > general. Their use breaks the use of clang as a compiler, and > doesn't make t

[PATCH v2 02/18] powerpc/vas: Validate window credits

2017-10-06 Thread Sukadev Bhattiprolu
NX-842, the only user of VAS, sets the window credits to default values but VAS should check the credits against the possible max values. The VAS_WCREDS_MIN is not needed and can be dropped. Signed-off-by: Sukadev Bhattiprolu --- arch/powerpc/platforms/powernv/vas-window.c | 6 ++ arch/powe

[PATCH v2 01/18] powerpc/vas: init missing fields from [rt]xattr

2017-10-06 Thread Sukadev Bhattiprolu
Initialize a few missing window context fields from the window attributes specified by the caller. These fields are currently set to their default values by the caller (NX-842), but would be good to apply them anyway. Signed-off-by: Sukadev Bhattiprolu --- arch/powerpc/platforms/powernv/vas-wind

Re: [BUG] fs/aio: A possible sleep-in-atomic bug in aio_migratepage

2017-10-06 Thread Al Viro
On Sat, Oct 07, 2017 at 09:36:48AM +0800, Jia-Ju Bai wrote: > According to fs/aio.c, cond_resched is called under a spinlock, > and the function call path is: > aio_migratepage (acquire the spinlock) > migrate_page_copy > copy_huge_page > __copy_gigantic_page > cond_resched >

[PATCH v2 05/18] powerpc/vas: Use helper to unpin/close window

2017-10-06 Thread Sukadev Bhattiprolu
Use a helper to have the hardware unpin and mark a window closed. Signed-off-by: Sukadev Bhattiprolu --- arch/powerpc/platforms/powernv/vas-window.c | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/arch/powerpc/platforms/powernv/vas-window.c b/arch/pow

[PATCH v2 06/18] powerpc/vas: Reduce polling interval for busy state

2017-10-06 Thread Sukadev Bhattiprolu
A VAS window is normally in "busy" state for only a short duration. Reduce the time we wait for the window to go to "not-busy" state to speed-up vas_win_close() a bit. Signed-off-by: Sukadev Bhattiprolu --- arch/powerpc/platforms/powernv/vas-window.c | 10 ++ 1 file changed, 6 insertions

[PATCH v2 07/18] powerpc/vas: Save configured window credits

2017-10-06 Thread Sukadev Bhattiprolu
Save the configured max window credits for a window in the vas_window structure. We will need this when polling for return of window credits. Signed-off-by: Sukadev Bhattiprolu --- arch/powerpc/platforms/powernv/vas-window.c | 6 -- arch/powerpc/platforms/powernv/vas.h| 1 + 2 files

[PATCH v2 09/18] powerpc/vas: Create cpu to vas id mapping

2017-10-06 Thread Sukadev Bhattiprolu
Create a cpu to vasid mapping so callers can specify -1 instead of trying to find a VAS id. Changelog[v2] [Michael Ellerman] Use per-cpu variables to simplify code. Signed-off-by: Sukadev Bhattiprolu --- arch/powerpc/platforms/powernv/vas.c | 14 +- 1 file changed, 13 insert

[PATCH v2 11/18] powerpc/vas: Export HVWC to debugfs

2017-10-06 Thread Sukadev Bhattiprolu
Export the VAS Window context information to debugfs. We need to hold a mutex when closing the window to prevent a race with the debugfs read(). Rather than introduce a per-instance mutex, we use the global vas_mutex for now, since it is not heavily contended. The window->cop field is only releva

[PATCH v2 08/18] powerpc/vas: poll for return of window credits

2017-10-06 Thread Sukadev Bhattiprolu
Normally, the NX driver waits for the CRBs to be processed before closing the window. But it is better to ensure that the credits are returned before the window gets reassigned later. Signed-off-by: Sukadev Bhattiprolu --- arch/powerpc/platforms/powernv/vas-window.c | 45

[PATCH v2 12/18] powerpc: have copy depend on CONFIG_BOOK3S_64

2017-10-06 Thread Sukadev Bhattiprolu
Have the COPY/PASTE instructions depend on CONFIG_BOOK3S_64 rather than CONFIG_PPC_STD_MMU_64. Signed-off-by: Sukadev Bhattiprolu --- arch/powerpc/kernel/process.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/powerpc/kernel/process.c b/arch/powerpc/kernel/process

[PATCH v2 10/18] powerpc/vas, nx-842: Define and use chip_to_vas_id()

2017-10-06 Thread Sukadev Bhattiprolu
Define a helper, chip_to_vas_id() to map a given chip id to corresponding vas id. Normally, callers of vas_rx_win_open() and vas_tx_win_open() want the VAS window to be on the same chip where the calling thread is executing. These callers can pass in -1 for the VAS id. This interface will be usef

[PATCH v2 13/18] powerpc: Add support for setting SPRN_TIDR

2017-10-06 Thread Sukadev Bhattiprolu
We need the SPRN_TIDR to be set for use with fast thread-wakeup (core- to-core wakeup) and also with CAPI. Each thread in a process needs to have a unique id within the process. But as explained below, for now, we assign globally unique thread ids to all threads in the system. Signed-off-by: Suka

[PATCH v2 17/18] powerpc/vas: Define vas_win_id()

2017-10-06 Thread Sukadev Bhattiprolu
Define an interface to return a system-wide unique id for a given VAS window. The vas_win_id() will be used in a follow-on patch to generate an unique handle for a user space receive window. Applications can use this handle to pair send and receive windows for fast thread-wakeup. The hardware ref

[PATCH v2 18/18] powerpc/vas: Add support for user receive window

2017-10-06 Thread Sukadev Bhattiprolu
Add support for user space receive window (for the Fast thread-wakeup coprocessor type) Signed-off-by: Sukadev Bhattiprolu --- arch/powerpc/platforms/powernv/vas-window.c | 59 + 1 file changed, 52 insertions(+), 7 deletions(-) diff --git a/arch/powerpc/platforms/pow

[PATCH v2 14/18] powerpc: Define set_thread_used_vas()

2017-10-06 Thread Sukadev Bhattiprolu
A CP_ABORT instruction is required in processes that have mapped a VAS "paste address" with the intention of using COPY/PASTE instructions. But since CP_ABORT is expensive, we want to restrict it to only processes that use/intend to use COPY/PASTE. Define an interface, set_thread_used_vas(), that

[PATCH v2 16/18] powerpc/vas: Define vas_win_paste_addr()

2017-10-06 Thread Sukadev Bhattiprolu
Define an interface that the NX drivers can use to find the physical paste address of a send window. This interface is expected to be used with the mmap() operation of the NX driver's device. i.e the user space process can use driver's mmap() operation to map the send window's paste address into th

[PATCH v2 00/18] powerpc/vas: Add support for FTW

2017-10-06 Thread Sukadev Bhattiprolu
The first 10 patches in this set were posted earlier[1] and don't have any significant changes since then. This set sanitizes cpu/chip id to VAS id mapping, improves vas_win_close() performance and adds a check for return of credits and cleans up some code. Patch 11 adds debugfs support for the VA

Re: [PATCH] ext2/super: Fix a possible sleep-in-atomic bug in parse_options

2017-10-06 Thread Al Viro
On Sat, Oct 07, 2017 at 03:02:17AM +0100, Al Viro wrote: > > I do wonder if we shouldn't just use something like > > > > "skip leading zeroes, copy to size-limited stack location instead" > > > > because the input length really *is* limited once you skip leading > > zeroes (and whatever base mar

[PATCH v2 15/18] powerpc: Emulate paste instruction

2017-10-06 Thread Sukadev Bhattiprolu
From: Michael Neuling On POWER9 DD2.1 and below there are issues when the paste instruction generates an error. If an error occurs when thread reconfiguration happens (ie another thread in the core goes into/out of powersave) the core may hang. To avoid this a special sequence is required which

[PATCH v2 04/18] powerpc/vas: Drop poll_window_cast_out().

2017-10-06 Thread Sukadev Bhattiprolu
Polling for window cast out is listed in the spec, but turns out that it is not strictly necessary and slows down window close. Making it a stub for now. Signed-off-by: Sukadev Bhattiprolu --- arch/powerpc/platforms/powernv/vas-window.c | 34 ++--- 1 file changed, 17 inse

[PATCH v2 03/18] powerpc/vas: Cleanup some debug code

2017-10-06 Thread Sukadev Bhattiprolu
Clean up vas.h and the debug code around ifdef vas_debug. Signed-off-by: Sukadev Bhattiprolu --- arch/powerpc/platforms/powernv/vas-window.c | 8 +++-- arch/powerpc/platforms/powernv/vas.h| 56 +++-- 2 files changed, 18 insertions(+), 46 deletions(-) diff --git

Re: [BUG] fs/dlm: A possible sleep-in-atomic bug in dlm_master_lookup

2017-10-06 Thread Al Viro
On Sat, Oct 07, 2017 at 09:59:41AM +0800, Jia-Ju Bai wrote: > According to fs/dlm/lock.c, the kernel may sleep under a spinlock, > and the function call path is: > dlm_master_lookup (acquire the spinlock) > dlm_send_rcom_lookup_dump > create_rcom > dlm_lowcomms_get_buffer > node

Re: [PATCH v3 03/22] dt-bindings: arm: scmi: add ARM MHU specific mailbox client bindings

2017-10-06 Thread Jassi Brar
On Fri, Oct 6, 2017 at 9:24 PM, Rob Herring wrote: > On Fri, Oct 6, 2017 at 6:01 AM, Jassi Brar wrote: >> On Fri, Oct 6, 2017 at 4:50 AM, Rob Herring wrote: >>> On Thu, Sep 28, 2017 at 02:11:27PM +0100, Sudeep Holla wrote: >>> +- mbox-data : For each phandle listed in mboxes property, an u

Re: [PATCH 1/2] Revert "vmalloc: back off when the current task is killed"

2017-10-06 Thread Tetsuo Handa
On 2017/10/05 19:36, Tetsuo Handa wrote: > I don't want this patch backported. If you want to backport, > "s/fatal_signal_pending/tsk_is_oom_victim/" is the safer way. If you backport this patch, you will see "complete depletion of memory reserves" and "extra OOM kills due to depletion of memory r

Re: [BUG] GPF on reboot of box

2017-10-06 Thread Nadav Amit
Steven Rostedt wrote: > Starting with v4.14-rc1 my box crashes during a reboot. All I get is > the following: > > [ 250.615793] sd 0:0:0:0: [sda] Synchronizing SCSI cache > [ 250.635639] reboot: Restarting system > [ 250.639671] reboot: machine restart > [ 250.643842] general protection faul

Re: [PATCH 0/6] Shrinking DT memory usage

2017-10-06 Thread Frank Rowand
On 10/05/17 12:44, Rob Herring wrote: > On kernels with a minimal config and a RAM target in the 100s of KB, DT > is quite a hog of runtime memory usage. How much is dependent on how many > nodes and properties in the DT which have a corresponding struct device_node > and struct property in the ke

[rcu:rcu/next 93/97] include/linux/pm_runtime.h:108:34: error: lvalue required as left operand of assignment

2017-10-06 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git rcu/next head: f561b44bd4bd0518dc12c5d112bf3c9fb8ec56e7 commit: bb506b193f6f9bea58316cedceec18e680f93161 [93/97] include/linux: Convert ACCESS_ONCE() to READ_ONCE() config: i386-randconfig-x001-201740 (attached as .co

Re: [PATCH 3/4] sched: WARN when migrating to an offline CPU

2017-10-06 Thread Levin, Alexander (Sasha Levin)
On Fri, Sep 29, 2017 at 01:11:26PM +0200, Peter Zijlstra wrote: >I can't seem to trigger :-( > >Can you please run with the below patch and: > > # echo 1 > /proc/sys/kernel/traceoff_on_warning The call stack trace looks like so: [ 2073.492089] Unregister pv shared memory for cpu 2 [ 2073.495414]

Re: [PATCH] ext2/super: Fix a possible sleep-in-atomic bug in parse_options

2017-10-06 Thread Al Viro
On Fri, Oct 06, 2017 at 06:37:11PM -0700, Linus Torvalds wrote: > On Fri, Oct 6, 2017 at 6:20 PM, Jia-Ju Bai wrote: > > > > To fix it, GFP_KERNEL is replaced with GFP_ATOMIC. > > This bug is found by my static analysis tool and my code review. > > I'm not saying your patch is wrong, but it's a sh

Re: [PATCH net-next 2/2] bnxt_en: tc: only the function prototypes need to be wrapped in #ifdef

2017-10-06 Thread David Miller
From: Michael Chan Date: Fri, 6 Oct 2017 18:27:31 -0700 > On Fri, Oct 6, 2017 at 12:48 PM, Jonathan Toppins wrote: >> There is no reason to wrap the data structures inside the ifdef. > > What's so bad about wrapping unused data structures inside #ifdef? > These structures are only used if CONFI

Re: [PATCH net-next 1/2] bnxt_en: don't consider building bnxt_tc.o if option not enabled

2017-10-06 Thread David Miller
From: Michael Chan Date: Fri, 6 Oct 2017 18:01:57 -0700 > On Fri, Oct 6, 2017 at 12:48 PM, Jonathan Toppins wrote: >> Instead of zeroing out bnxt_tc.c with a #ifdef foo, instead don't compile >> the file when the option is not enabled. Now make and the preprocessor do >> not have to waste time c

[BUG] fs/dlm: A possible sleep-in-atomic bug in dlm_master_lookup

2017-10-06 Thread Jia-Ju Bai
According to fs/dlm/lock.c, the kernel may sleep under a spinlock, and the function call path is: dlm_master_lookup (acquire the spinlock) dlm_send_rcom_lookup_dump create_rcom dlm_lowcomms_get_buffer nodeid2con mutex_lock --> may sleep This bug is found by my static

Re: [PATCH] ext2/super: Fix a possible sleep-in-atomic bug in parse_options

2017-10-06 Thread Jia-Ju Bai
Thanks for your reply. I agree that extra allocation in match_number() and match_u64int() may be unnecessary. Thanks, Jia-Ju Bai On 2017/10/7 9:37, Linus Torvalds wrote: On Fri, Oct 6, 2017 at 6:20 PM, Jia-Ju Bai wrote: To fix it, GFP_KERNEL is replaced with GFP_ATOMIC. This bug is found b

[BUG] GPF on reboot of box

2017-10-06 Thread Steven Rostedt
Starting with v4.14-rc1 my box crashes during a reboot. All I get is the following: [ 250.615793] sd 0:0:0:0: [sda] Synchronizing SCSI cache [ 250.635639] reboot: Restarting system [ 250.639671] reboot: machine restart [ 250.643842] general protection fault: [#1] PREEMPT SMP KASAN Then n

Re: [PATCH] ext2/super: Fix a possible sleep-in-atomic bug in parse_options

2017-10-06 Thread Linus Torvalds
On Fri, Oct 6, 2017 at 6:20 PM, Jia-Ju Bai wrote: > > To fix it, GFP_KERNEL is replaced with GFP_ATOMIC. > This bug is found by my static analysis tool and my code review. I'm not saying your patch is wrong, but it's a shame that we do that extra allocation in match_number() and match_u64int(), a

[BUG] fs/aio: A possible sleep-in-atomic bug in aio_migratepage

2017-10-06 Thread Jia-Ju Bai
According to fs/aio.c, cond_resched is called under a spinlock, and the function call path is: aio_migratepage (acquire the spinlock) migrate_page_copy copy_huge_page __copy_gigantic_page cond_resched might_sleep This bug is found by my static analysis tool and my co

Re: [PATCH net-next 2/2] bnxt_en: tc: only the function prototypes need to be wrapped in #ifdef

2017-10-06 Thread Michael Chan
On Fri, Oct 6, 2017 at 12:48 PM, Jonathan Toppins wrote: > There is no reason to wrap the data structures inside the ifdef. What's so bad about wrapping unused data structures inside #ifdef? These structures are only used if CONFIG_BNXT_FLOWER_OFFLOAD is defined.

  1   2   3   4   5   6   7   8   9   10   >