Re: [PATCH 4/4] arm64: dts: qcom: msm8916: add bindings for i2c1, i2c3, i2c5

On Thu 09 Nov 09:14 PST 2017, Damien Riegel wrote: > Hi Bjorn, > > > On Thu, Nov 09, 2017 at 09:00:16AM -0800, Bjorn Andersson wrote: > > On Wed 01 Nov 10:53 PDT 2017, Damien Riegel wrote: > > > > I think it's better to use the word "nodes" (add nodes...) > > Will reword that. > > > > > >

Re: [PATCH 4/4] arm64: dts: qcom: msm8916: add bindings for i2c1, i2c3, i2c5

On Thu 09 Nov 09:14 PST 2017, Damien Riegel wrote: > Hi Bjorn, > > > On Thu, Nov 09, 2017 at 09:00:16AM -0800, Bjorn Andersson wrote: > > On Wed 01 Nov 10:53 PDT 2017, Damien Riegel wrote: > > > > I think it's better to use the word "nodes" (add nodes...) > > Will reword that. > > > > > >

Re: staging: pi433: Possible bug in rf69.c

Hi Dan, I checked it on my local SVN. You are right. I submitted the code with '&'. Accodring to a check-in message on my SVN, there was a bugreport end of July and most probably a patch - either from me, you, Joseph Wright, Colin King or Julia Lawall, changing '&' to '|'. I guess the patch for

Re: staging: pi433: Possible bug in rf69.c

Hi Dan, I checked it on my local SVN. You are right. I submitted the code with '&'. Accodring to a check-in message on my SVN, there was a bugreport end of July and most probably a patch - either from me, you, Joseph Wright, Colin King or Julia Lawall, changing '&' to '|'. I guess the patch for

Re: [Cocci] [PATCH v2] coccinelle: fix parallel build with CHECK=scripts/coccicheck

On Fri, 10 Nov 2017, Julia Lawall wrote: > > > On Thu, 9 Nov 2017, Masahiro Yamada wrote: > > > The command "make -j8 C=1 CHECK=scripts/coccicheck" produces lots of > > "coccicheck failed" error messages. > > The question is where parallelism should be specified. Currently, make > coccicheck

Re: [Cocci] [PATCH v2] coccinelle: fix parallel build with CHECK=scripts/coccicheck

On Fri, 10 Nov 2017, Julia Lawall wrote: > > > On Thu, 9 Nov 2017, Masahiro Yamada wrote: > > > The command "make -j8 C=1 CHECK=scripts/coccicheck" produces lots of > > "coccicheck failed" error messages. > > The question is where parallelism should be specified. Currently, make > coccicheck

Re: [PATCH 1/1] ALSA: usb: initial USB Audio Device Class 3.0 support

On Sat, 11 Nov 2017 03:56:17 +0100, Ruslan Bilovol wrote: > > On Thu, Nov 9, 2017 at 10:33 AM, Greg Kroah-Hartman > wrote: > > On Thu, Nov 09, 2017 at 09:16:52AM +0100, Takashi Iwai wrote: > >> On Thu, 09 Nov 2017 09:04:58 +0100, > >> Greg Kroah-Hartman wrote: > >> >

Re: [PATCH 1/1] ALSA: usb: initial USB Audio Device Class 3.0 support

On Sat, 11 Nov 2017 03:56:17 +0100, Ruslan Bilovol wrote: > > On Thu, Nov 9, 2017 at 10:33 AM, Greg Kroah-Hartman > wrote: > > On Thu, Nov 09, 2017 at 09:16:52AM +0100, Takashi Iwai wrote: > >> On Thu, 09 Nov 2017 09:04:58 +0100, > >> Greg Kroah-Hartman wrote: > >> > > >> > On Wed, Nov 08, 2017

Re: [PATCH net-next 0/6] net: dsa: simplify switchdev prepare phase

From: Vivien Didelot Date: Wed, 8 Nov 2017 12:19:11 -0500 > This patch series brings no functional changes. > > It removes the unused switchdev_trans arguments from the dsa_switch_ops > for both MDB and VLAN operations, and provides function to prepare and

Re: [PATCH net-next 0/6] net: dsa: simplify switchdev prepare phase

From: Vivien Didelot Date: Wed, 8 Nov 2017 12:19:11 -0500 > This patch series brings no functional changes. > > It removes the unused switchdev_trans arguments from the dsa_switch_ops > for both MDB and VLAN operations, and provides function to prepare and > add these objects for a given

Re: [PATCH net] net: dsa: return after vlan prepare phase

From: Vivien Didelot Date: Wed, 8 Nov 2017 10:50:10 -0500 > The current code does not return after successfully preparing the VLAN > addition on every ports member of a it. Fix this. > > Fixes: 1ca4aa9cd4cc ("net: dsa: check VLAN capability of every

Re: [PATCH net] net: dsa: return after vlan prepare phase

From: Vivien Didelot Date: Wed, 8 Nov 2017 10:50:10 -0500 > The current code does not return after successfully preparing the VLAN > addition on every ports member of a it. Fix this. > > Fixes: 1ca4aa9cd4cc ("net: dsa: check VLAN capability of every switch") > Signed-off-by: Vivien Didelot

Re: [PATCH net] net: dsa: return after mdb prepare phase

From: Vivien Didelot Date: Wed, 8 Nov 2017 10:49:56 -0500 > The current code does not return after successfully preparing the MDB > addition on every ports member of a multicast group. Fix this. > > Fixes: a1a6b7ea7f2d ("net: dsa: add cross-chip multicast

Re: [PATCH net] net: dsa: return after mdb prepare phase

From: Vivien Didelot Date: Wed, 8 Nov 2017 10:49:56 -0500 > The current code does not return after successfully preparing the MDB > addition on every ports member of a multicast group. Fix this. > > Fixes: a1a6b7ea7f2d ("net: dsa: add cross-chip multicast support") > Reported-by: Egil

[PATCH net v3 04/12] net/sonic: Clean up and modernize log messages

Add missing printk severity levels by adopting pr_foo() calls for the platform_driver and dev_foo() calls for the nubus_driver. Avoid KERN_CONT usage as per advice from checkpatch. Avoid #ifdef around printk calls. Cc: Thomas Bogendoerfer Cc: Chris Zankel

[PATCH net v3 04/12] net/sonic: Clean up and modernize log messages

Add missing printk severity levels by adopting pr_foo() calls for the platform_driver and dev_foo() calls for the nubus_driver. Avoid KERN_CONT usage as per advice from checkpatch. Avoid #ifdef around printk calls. Cc: Thomas Bogendoerfer Cc: Chris Zankel Tested-by: Stan Johnson Signed-off-by:

[PATCH net v3 02/12] net/mac89x0: Convert to platform_driver

Apparently these Dayna cards don't have a pseudoslot declaration ROM which means they can't be probed like NuBus cards. Cc: Geert Uytterhoeven Signed-off-by: Finn Thain --- arch/m68k/mac/config.c| 4 +++ drivers/net/Space.c

[PATCH net v3 02/12] net/mac89x0: Convert to platform_driver

Apparently these Dayna cards don't have a pseudoslot declaration ROM which means they can't be probed like NuBus cards. Cc: Geert Uytterhoeven Signed-off-by: Finn Thain --- arch/m68k/mac/config.c| 4 +++ drivers/net/Space.c | 3 --

[PATCH net v3 03/12] net/mac8390: Convert to nubus_driver

Tested-by: Stan Johnson Signed-off-by: Finn Thain --- drivers/net/Space.c | 3 -- drivers/net/ethernet/8390/mac8390.c | 105 ++-- include/net/Space.h | 1 - 3 files changed, 53

[PATCH net v3 03/12] net/mac8390: Convert to nubus_driver

Tested-by: Stan Johnson Signed-off-by: Finn Thain --- drivers/net/Space.c | 3 -- drivers/net/ethernet/8390/mac8390.c | 105 ++-- include/net/Space.h | 1 - 3 files changed, 53 insertions(+), 56 deletions(-) diff --git

[PATCH net v3 06/12] net/mac89x0: Remove dead or unreachable code

Signed-off-by: Finn Thain --- drivers/net/ethernet/cirrus/mac89x0.c | 31 --- 1 file changed, 31 deletions(-) diff --git a/drivers/net/ethernet/cirrus/mac89x0.c b/drivers/net/ethernet/cirrus/mac89x0.c index 8a23d2fc0e28..c1a3d1aed037

[PATCH net v3 08/12] net/mac89x0: Replace custom debug logging with netif_* calls

Signed-off-by: Finn Thain --- drivers/net/ethernet/cirrus/mac89x0.c | 52 --- 1 file changed, 18 insertions(+), 34 deletions(-) diff --git a/drivers/net/ethernet/cirrus/mac89x0.c b/drivers/net/ethernet/cirrus/mac89x0.c index

[PATCH net v3 06/12] net/mac89x0: Remove dead or unreachable code

Signed-off-by: Finn Thain --- drivers/net/ethernet/cirrus/mac89x0.c | 31 --- 1 file changed, 31 deletions(-) diff --git a/drivers/net/ethernet/cirrus/mac89x0.c b/drivers/net/ethernet/cirrus/mac89x0.c index 8a23d2fc0e28..c1a3d1aed037 100644 ---

[PATCH net v3 08/12] net/mac89x0: Replace custom debug logging with netif_* calls

Signed-off-by: Finn Thain --- drivers/net/ethernet/cirrus/mac89x0.c | 52 --- 1 file changed, 18 insertions(+), 34 deletions(-) diff --git a/drivers/net/ethernet/cirrus/mac89x0.c b/drivers/net/ethernet/cirrus/mac89x0.c index 4575370d57db..9348c095c898 100644 ---

[PATCH net v3 05/12] net/sonic: Replace custom debug logging with netif_* calls

Eliminate duplicated debug code by moving it into the core driver. Don't log the only valid silicon revision number (it's in the source). Cc: Thomas Bogendoerfer Cc: Chris Zankel Tested-by: Stan Johnson Signed-off-by: Finn Thain

[PATCH net v3 05/12] net/sonic: Replace custom debug logging with netif_* calls

Eliminate duplicated debug code by moving it into the core driver. Don't log the only valid silicon revision number (it's in the source). Cc: Thomas Bogendoerfer Cc: Chris Zankel Tested-by: Stan Johnson Signed-off-by: Finn Thain --- Only the sonic.[ch] and macsonic.c changes have been tested.

[PATCH net v3 12/12] net/smc9194: Remove bogus CONFIG_MAC reference

AFAIK the only version of smc9194.c with Mac support is the one in the linux-mac68k CVS repo, which never made it to the mainline. Despite that, as of v2.3.45, arch/m68k/config.in listed CONFIG_SMC9194 under CONFIG_MAC. This mistake got carried over into Kconfig in v2.5.55. (See pre-git era

[PATCH net v3 12/12] net/smc9194: Remove bogus CONFIG_MAC reference

AFAIK the only version of smc9194.c with Mac support is the one in the linux-mac68k CVS repo, which never made it to the mainline. Despite that, as of v2.3.45, arch/m68k/config.in listed CONFIG_SMC9194 under CONFIG_MAC. This mistake got carried over into Kconfig in v2.5.55. (See pre-git era

[PATCH net v3 07/12] net/mac89x0: Fix and modernize log messages

Fix log message fragments which no longer produce the desired output (since the behaviour of printk() was changed). Add missing printk severity levels. Drop deprecated "out of memory" message as per checkpatch advice. Signed-off-by: Finn Thain ---

[PATCH net v3 07/12] net/mac89x0: Fix and modernize log messages

Fix log message fragments which no longer produce the desired output (since the behaviour of printk() was changed). Add missing printk severity levels. Drop deprecated "out of memory" message as per checkpatch advice. Signed-off-by: Finn Thain --- drivers/net/ethernet/cirrus/mac89x0.c | 19

[PATCH net v3 11/12] net/macmace: Fix and clean up log messages

Don't log unexpanded "eth%d". Log the chip revision in the probe message (consistent with mace.c). Drop redundant debug messages for FIFO events recorded in the interface statistics (also consistent with mace.c). Tested-by: Stan Johnson Signed-off-by: Finn Thain

[PATCH net v3 11/12] net/macmace: Fix and clean up log messages

Don't log unexpanded "eth%d". Log the chip revision in the probe message (consistent with mace.c). Drop redundant debug messages for FIFO events recorded in the interface statistics (also consistent with mace.c). Tested-by: Stan Johnson Signed-off-by: Finn Thain ---

[PATCH net v3 01/12] net/macsonic: Convert to nubus_driver

Tested-by: Stan Johnson Signed-off-by: Finn Thain --- drivers/net/ethernet/natsemi/macsonic.c | 170 ++-- 1 file changed, 118 insertions(+), 52 deletions(-) diff --git a/drivers/net/ethernet/natsemi/macsonic.c

[PATCH net v3 00/12] Fixes, cleanup and modernization for some legacy ethernet NIC drivers

This patch series adds support for the Linux Driver Model for Mac NIC drivers, fixes some logging bugs, removes dead code, and adopts netif_* calls to reduce code duplication. All up, about 100 lines of code are eliminated. This patch series has been tested on a variety of Macs, with coverage

[PATCH net v3 01/12] net/macsonic: Convert to nubus_driver

Tested-by: Stan Johnson Signed-off-by: Finn Thain --- drivers/net/ethernet/natsemi/macsonic.c | 170 ++-- 1 file changed, 118 insertions(+), 52 deletions(-) diff --git a/drivers/net/ethernet/natsemi/macsonic.c b/drivers/net/ethernet/natsemi/macsonic.c index

[PATCH net v3 00/12] Fixes, cleanup and modernization for some legacy ethernet NIC drivers

This patch series adds support for the Linux Driver Model for Mac NIC drivers, fixes some logging bugs, removes dead code, and adopts netif_* calls to reduce code duplication. All up, about 100 lines of code are eliminated. This patch series has been tested on a variety of Macs, with coverage

[PATCH net v3 10/12] net/mac8390: Fix log messages

Use dev_foo() and log the slot number instead of the unexpanded "eth%d". Disambiguate the two identical "Card type %s is unsupported" messages. Tested-by: Stan Johnson Signed-off-by: Finn Thain --- drivers/net/ethernet/8390/mac8390.c | 36

[PATCH net v3 09/12] net/8390: Fix redundant code

The patch which introduced the 8390 core module parameter 'msg_enable' failed to do anything useful with it: it merely causes an ancient version string to be logged. Remove the other code that logs the same string. Use the msg_enable module parameter as the default value for ei_local->msg_enable.

[PATCH net v3 10/12] net/mac8390: Fix log messages

Use dev_foo() and log the slot number instead of the unexpanded "eth%d". Disambiguate the two identical "Card type %s is unsupported" messages. Tested-by: Stan Johnson Signed-off-by: Finn Thain --- drivers/net/ethernet/8390/mac8390.c | 36 +--- 1 file changed,

[PATCH net v3 09/12] net/8390: Fix redundant code

The patch which introduced the 8390 core module parameter 'msg_enable' failed to do anything useful with it: it merely causes an ancient version string to be logged. Remove the other code that logs the same string. Use the msg_enable module parameter as the default value for ei_local->msg_enable.

Re: [PATCH net-next 0/2] net: hns3: Bug fixes & Code improvements in HNS3 driver

From: Lipeng Date: Wed, 8 Nov 2017 15:52:21 +0800 > This patch-set introduces some bug fixes and code improvements. > As [patch 1/2] depends on the patch {5392902 net: hns3: Consistently using > GENMASK in hns3 driver}, which exists in net-next, not exists in net, so > push

Re: [PATCH net-next 0/2] net: hns3: Bug fixes & Code improvements in HNS3 driver

From: Lipeng Date: Wed, 8 Nov 2017 15:52:21 +0800 > This patch-set introduces some bug fixes and code improvements. > As [patch 1/2] depends on the patch {5392902 net: hns3: Consistently using > GENMASK in hns3 driver}, which exists in net-next, not exists in net, so > push this serise to

[PATCH] drm: fix amdkfd use-after-free GP fault

From: Randy Dunlap Fix GP fault caused by dev_info() reference to a struct device* after the device has been freed (use after free). kfd_chardev_exit() frees the device so 'kfd_device' should not be used after calling kfd_chardev_exit(). To reproduce, just load the module

[PATCH] drm: fix amdkfd use-after-free GP fault

From: Randy Dunlap Fix GP fault caused by dev_info() reference to a struct device* after the device has been freed (use after free). kfd_chardev_exit() frees the device so 'kfd_device' should not be used after calling kfd_chardev_exit(). To reproduce, just load the module and then unload it.

[PATCH 07/14] nubus: Remove redundant code

Eliminate unused values from struct nubus_dev to save wasted memory (a Radius PrecisionColor 24X card has about 95 functional resources and up to six such cards may be fitted). Also remove redundant static variable initialization, an unreachable !MACH_IS_MAC conditional, the unused

[PATCH 07/14] nubus: Remove redundant code

Eliminate unused values from struct nubus_dev to save wasted memory (a Radius PrecisionColor 24X card has about 95 functional resources and up to six such cards may be fitted). Also remove redundant static variable initialization, an unreachable !MACH_IS_MAC conditional, the unused

[PATCH 05/14] nubus: Validate slot resource IDs

While we are here, include the slot number in the related error messages. Tested-by: Stan Johnson Signed-off-by: Finn Thain --- drivers/nubus/nubus.c | 25 +++-- 1 file changed, 19 insertions(+), 6 deletions(-) diff --git

[PATCH 06/14] nubus: Call proc_mkdir() not more than once per slot

This patch fixes the following WARNING. proc_dir_entry 'nubus/a' already registered Modules linked in: CPU: 0 PID: 1 Comm: swapper Tainted: GW 4.13.0-00036-gd57552077387 #1 Stack from 01c1bd9c: 01c1bd9c 003c2c8b 01c1bdc0 0001b0fe 00322f4a 01c43a20 01c43b0c

[PATCH 05/14] nubus: Validate slot resource IDs

While we are here, include the slot number in the related error messages. Tested-by: Stan Johnson Signed-off-by: Finn Thain --- drivers/nubus/nubus.c | 25 +++-- 1 file changed, 19 insertions(+), 6 deletions(-) diff --git a/drivers/nubus/nubus.c b/drivers/nubus/nubus.c

[PATCH 06/14] nubus: Call proc_mkdir() not more than once per slot

This patch fixes the following WARNING. proc_dir_entry 'nubus/a' already registered Modules linked in: CPU: 0 PID: 1 Comm: swapper Tainted: GW 4.13.0-00036-gd57552077387 #1 Stack from 01c1bd9c: 01c1bd9c 003c2c8b 01c1bdc0 0001b0fe 00322f4a 01c43a20 01c43b0c

[PATCH 10/14] nubus: Depopulate /proc/bus/nubus/s/

The /proc/bus/nubus/s/ directory tree for any slot s is missing a lot of information. The struct file_operations methods have long been left unimplemented (hence the familiar compile-time warning, "Need to set some I/O handlers here"). Slot resources have a complex structure which varies

[PATCH 10/14] nubus: Depopulate /proc/bus/nubus/s/

The /proc/bus/nubus/s/ directory tree for any slot s is missing a lot of information. The struct file_operations methods have long been left unimplemented (hence the familiar compile-time warning, "Need to set some I/O handlers here"). Slot resources have a complex structure which varies

[PATCH 08/14] nubus: Clean up whitespace

Tested-by: Stan Johnson Signed-off-by: Finn Thain --- include/linux/nubus.h | 54 +-- 1 file changed, 27 insertions(+), 27 deletions(-) diff --git a/include/linux/nubus.h b/include/linux/nubus.h

[PATCH 08/14] nubus: Clean up whitespace

Tested-by: Stan Johnson Signed-off-by: Finn Thain --- include/linux/nubus.h | 54 +-- 1 file changed, 27 insertions(+), 27 deletions(-) diff --git a/include/linux/nubus.h b/include/linux/nubus.h index d832d849d55c..cddfed466bee 100644 ---

[PATCH 11/14] nubus: Repopulate /proc/bus/nubus/s/

Create the /proc/bus/nubus/s/ inodes while scanning slot s. During descent through slot resource subdirectories, call the new nubus_proc_add_foo() functions to create the procfs inodes. Also add a new function, nubus_seq_write_rsrc_mem(), to write the contents of a particular slot resource to a

[PATCH 11/14] nubus: Repopulate /proc/bus/nubus/s/

Create the /proc/bus/nubus/s/ inodes while scanning slot s. During descent through slot resource subdirectories, call the new nubus_proc_add_foo() functions to create the procfs inodes. Also add a new function, nubus_seq_write_rsrc_mem(), to write the contents of a particular slot resource to a

[PATCH 09/14] nubus: Don't needlessly unpack vidname and driver resources

Scrap the specialized code to unpack video mode name resources and driver resources. It isn't useful. Instead, add a re-usable function to handle lists of block resources of any kind, and descend into the mode table resource directory. Rename nubus_show_foo() as nubus_get_foo(), consistent with

[PATCH 09/14] nubus: Don't needlessly unpack vidname and driver resources

Scrap the specialized code to unpack video mode name resources and driver resources. It isn't useful. Instead, add a re-usable function to handle lists of block resources of any kind, and descend into the mode table resource directory. Rename nubus_show_foo() as nubus_get_foo(), consistent with

[PATCH 00/14] Modernization and fixes for NuBus subsystem

This series begins with cleanups and fixes for the NuBus subsystem and finishes with a patch to add support for the Linux Driver Model. The next series, which requires this one, will modernize NuBus drivers. Finn Thain (14): nubus: Avoid array underflow and overflow nubus: Fix up header

[PATCH 14/14] nubus: Add support for the driver model

Cc: Greg Kroah-Hartman Tested-by: Stan Johnson Signed-off-by: Finn Thain --- drivers/nubus/Makefile | 2 +- drivers/nubus/bus.c| 87 ++ drivers/nubus/nubus.c | 3 ++

[PATCH 00/14] Modernization and fixes for NuBus subsystem

This series begins with cleanups and fixes for the NuBus subsystem and finishes with a patch to add support for the Linux Driver Model. The next series, which requires this one, will modernize NuBus drivers. Finn Thain (14): nubus: Avoid array underflow and overflow nubus: Fix up header

[PATCH 14/14] nubus: Add support for the driver model

Cc: Greg Kroah-Hartman Tested-by: Stan Johnson Signed-off-by: Finn Thain --- drivers/nubus/Makefile | 2 +- drivers/nubus/bus.c| 87 ++ drivers/nubus/nubus.c | 3 ++ include/linux/nubus.h | 39 ++ 4 files changed, 130

[PATCH 13/14] nubus: Add expansion_type values for various Mac models

Add an expansion slot attribute to allow drivers to properly handle cards like Comm Slot cards and PDS cards without declaration ROMs. Tested-by: Stan Johnson Signed-off-by: Finn Thain --- arch/m68k/include/asm/macintosh.h | 9 ++-

[PATCH 13/14] nubus: Add expansion_type values for various Mac models

Add an expansion slot attribute to allow drivers to properly handle cards like Comm Slot cards and PDS cards without declaration ROMs. Tested-by: Stan Johnson Signed-off-by: Finn Thain --- arch/m68k/include/asm/macintosh.h | 9 ++- arch/m68k/mac/config.c | 110

[PATCH 12/14] nubus: Rename struct nubus_dev

It is misleading to use "dev" to mean a functional resource. And in adopting the Linux Driver Model, struct nubus_board will embed a struct device. Drivers will then bind with boards, not with functional resources. Rename struct nubus_dev as struct nubus_functional_resource. This is the vendor's

[PATCH 12/14] nubus: Rename struct nubus_dev

It is misleading to use "dev" to mean a functional resource. And in adopting the Linux Driver Model, struct nubus_board will embed a struct device. Drivers will then bind with boards, not with functional resources. Rename struct nubus_dev as struct nubus_functional_resource. This is the vendor's

[PATCH 03/14] nubus: Use static functions where possible

This fixes a couple of warnings from 'make W=1': drivers/nubus/nubus.c:790: warning: no previous prototype for 'nubus_probe_slot' drivers/nubus/nubus.c:824: warning: no previous prototype for 'nubus_scan_bus' Tested-by: Stan Johnson Signed-off-by: Finn Thain

[PATCH 03/14] nubus: Use static functions where possible

This fixes a couple of warnings from 'make W=1': drivers/nubus/nubus.c:790: warning: no previous prototype for 'nubus_probe_slot' drivers/nubus/nubus.c:824: warning: no previous prototype for 'nubus_scan_bus' Tested-by: Stan Johnson Signed-off-by: Finn Thain --- drivers/nubus/nubus.c | 4 ++--

[PATCH 02/14] nubus: Fix up header split

Due to the '#ifdef __KERNEL__' being located in the wrong place, some definitions from the kernel API were placed in the UAPI header during the scripted header split. Fix this. Also, remove the duplicate comment which is only relevant to the UAPI header. Fixes: 607ca46e97a1 ("UAPI: (Scripted)

[PATCH 02/14] nubus: Fix up header split

Due to the '#ifdef __KERNEL__' being located in the wrong place, some definitions from the kernel API were placed in the UAPI header during the scripted header split. Fix this. Also, remove the duplicate comment which is only relevant to the UAPI header. Fixes: 607ca46e97a1 ("UAPI: (Scripted)

[PATCH 01/14] nubus: Avoid array underflow and overflow

Check array indices. Avoid sprintf. Use buffers of sufficient size. Use appropriate types for the parameters to nubus_get_rsrc_{mem,str}() functions. Tested-by: Stan Johnson Signed-off-by: Finn Thain --- drivers/nubus/nubus.c | 29

[PATCH 04/14] nubus: Fix log spam

Testing shows that a single Radius PrecisionColor 24X display board, which has 95 functional resources, produces over a thousand lines of log messages. Suppress these messages with pr_debug(). Remove some redundant messages relating to nubus_get_subdir() calls. Fix the format block debug messages

[PATCH 01/14] nubus: Avoid array underflow and overflow

Check array indices. Avoid sprintf. Use buffers of sufficient size. Use appropriate types for the parameters to nubus_get_rsrc_{mem,str}() functions. Tested-by: Stan Johnson Signed-off-by: Finn Thain --- drivers/nubus/nubus.c | 29 + drivers/nubus/proc.c | 12

[PATCH 04/14] nubus: Fix log spam

Testing shows that a single Radius PrecisionColor 24X display board, which has 95 functional resources, produces over a thousand lines of log messages. Suppress these messages with pr_debug(). Remove some redundant messages relating to nubus_get_subdir() calls. Fix the format block debug messages

Re: [PATCH net-next 1/2] net/ncsi: Improve general state logging

From: Samuel Mendoza-Jonas Date: Wed, 8 Nov 2017 16:30:44 +1100 > The NCSI driver is mostly silent which becomes a headache when trying to > determine what has occurred on the NCSI connection. This adds additional > logging in a few key areas such as state transitions and

Re: [PATCH net-next 2/2] net/ncsi: Don't return error on normal response

From: Samuel Mendoza-Jonas Date: Wed, 8 Nov 2017 16:30:45 +1100 > Several response handlers return EBUSY if the data corresponding to the > command/response pair is already set. There is no reason to return an > error here; the channel is advertising something as enabled

Re: [PATCH net-next 1/2] net/ncsi: Improve general state logging

From: Samuel Mendoza-Jonas Date: Wed, 8 Nov 2017 16:30:44 +1100 > The NCSI driver is mostly silent which becomes a headache when trying to > determine what has occurred on the NCSI connection. This adds additional > logging in a few key areas such as state transitions and calling out > certain

Re: [PATCH net-next 2/2] net/ncsi: Don't return error on normal response

From: Samuel Mendoza-Jonas Date: Wed, 8 Nov 2017 16:30:45 +1100 > Several response handlers return EBUSY if the data corresponding to the > command/response pair is already set. There is no reason to return an > error here; the channel is advertising something as enabled because we > told it to

[PATCH] drivers: base: omit redundant interations

When error happens, these interators return the error, no interation should be continued, so make the change for getting out of while immediately. Signed-off-by: Gimcuan Hui --- drivers/base/bus.c| 2 +- drivers/base/core.c | 2 +- drivers/base/driver.c | 2 +- 3 files

[PATCH] drivers: base: omit redundant interations

When error happens, these interators return the error, no interation should be continued, so make the change for getting out of while immediately. Signed-off-by: Gimcuan Hui --- drivers/base/bus.c| 2 +- drivers/base/core.c | 2 +- drivers/base/driver.c | 2 +- 3 files changed, 3

[PATCH 1/2] Input: ili210x - use managed allocated resources

Use managed allocated resources to simplify error handling during probing. Adjust goto labels and remove function accordingly. Signed-off-by: Andi Shyti --- drivers/input/touchscreen/ili210x.c | 36 +++- 1 file changed, 11 insertions(+), 25

[PATCH 1/2] Input: ili210x - use managed allocated resources

Use managed allocated resources to simplify error handling during probing. Adjust goto labels and remove function accordingly. Signed-off-by: Andi Shyti --- drivers/input/touchscreen/ili210x.c | 36 +++- 1 file changed, 11 insertions(+), 25 deletions(-) diff

Re: [kernel-hardening] Re: vDSO maximum stack usage, stack probes, and -fstack-check

On 2017-11-11 07:04, Andy Lutomirski wrote: >> On Nov 10, 2017, at 8:36 AM, Hector Martin 'marcan' wrote: >> >>> On 2017-11-11 01:02, Hector Martin 'marcan' wrote: >>> Not entirely sure what's going on here. >> >> Actually, if you think about it, it doesn't matter that it skips

Re: [kernel-hardening] Re: vDSO maximum stack usage, stack probes, and -fstack-check

On 2017-11-11 07:04, Andy Lutomirski wrote: >> On Nov 10, 2017, at 8:36 AM, Hector Martin 'marcan' wrote: >> >>> On 2017-11-11 01:02, Hector Martin 'marcan' wrote: >>> Not entirely sure what's going on here. >> >> Actually, if you think about it, it doesn't matter that it skips the >> first page,

[PATCH 2/2] Input: ili210x - use separate error handling for different allocators

Split the error between devm_kzalloc and devm_input_allocate_device, there is no need to call the second allocator if the first has failed. Besides this doesn't provide practical advantages. Signed-off-by: Andi Shyti --- drivers/input/touchscreen/ili210x.c | 5 - 1 file

[PATCH 2/2] Input: ili210x - use separate error handling for different allocators

Split the error between devm_kzalloc and devm_input_allocate_device, there is no need to call the second allocator if the first has failed. Besides this doesn't provide practical advantages. Signed-off-by: Andi Shyti --- drivers/input/touchscreen/ili210x.c | 5 - 1 file changed, 4

[PATCH 0/2] managed resources for ili210x

Hi Dmitry, this is another patch of my series for switching the touchscreen drivers to to the managed resource allocators. The second patch is very trivial and perhaps bothering only me, feel free to ignore. Thanks, Andi Andi Shyti (2): Input: ili210x - use managed allocated resources

[PATCH 0/2] managed resources for ili210x

Hi Dmitry, this is another patch of my series for switching the touchscreen drivers to to the managed resource allocators. The second patch is very trivial and perhaps bothering only me, feel free to ignore. Thanks, Andi Andi Shyti (2): Input: ili210x - use managed allocated resources

Re: [PATCHv4 5/6] symbol lookup: introduce dereference_symbol_descriptor()

On (11/10/17 10:09), Luck, Tony wrote: > On Fri, Nov 10, 2017 at 08:48:29AM +0900, Sergey Senozhatsky wrote: > > -Examples:: > > - > > - printk("Going to call: %pF\n", gettimeofday); > > - printk("Going to call: %pF\n", p->func); > > - printk("%s: called from %pS\n", __func__, (void

Re: [PATCHv4 5/6] symbol lookup: introduce dereference_symbol_descriptor()

On (11/10/17 10:09), Luck, Tony wrote: > On Fri, Nov 10, 2017 at 08:48:29AM +0900, Sergey Senozhatsky wrote: > > -Examples:: > > - > > - printk("Going to call: %pF\n", gettimeofday); > > - printk("Going to call: %pF\n", p->func); > > - printk("%s: called from %pS\n", __func__, (void

WireGuard Upstreaming Roadmap (November 2017)

Hi folks, This relates to WireGuard [0]. Following a very nice conference with the Linux kernel networking subsystem community [1,2], I thought it might be a good idea to spell out the roadmap for the coming months and the trajectory into upstream, based on my discussions with several developers

WireGuard Upstreaming Roadmap (November 2017)

Hi folks, This relates to WireGuard [0]. Following a very nice conference with the Linux kernel networking subsystem community [1,2], I thought it might be a good idea to spell out the roadmap for the coming months and the trajectory into upstream, based on my discussions with several developers

Re: [PATCH v6 0/2] add support for the Samsung S6SY761 touchscreen

> On Wed, Nov 08, 2017 at 05:21:03PM +0900, Andi Shyti wrote: > > Hi, > > > > This patchset adds support for the Samsung s6sy761 touchscreen. > > > > Thanks, > > Andi > > Applied, thank you. Thanks for your review :) Andi

Re: [PATCH v6 0/2] add support for the Samsung S6SY761 touchscreen

> On Wed, Nov 08, 2017 at 05:21:03PM +0900, Andi Shyti wrote: > > Hi, > > > > This patchset adds support for the Samsung s6sy761 touchscreen. > > > > Thanks, > > Andi > > Applied, thank you. Thanks for your review :) Andi

Re: [PATCHv4 0/6] printk/ia64/ppc64/parisc64: let's deprecate %pF/%pf printk specifiers

On (11/10/17 10:11), Luck, Tony wrote: > On Fri, Nov 10, 2017 at 08:48:24AM +0900, Sergey Senozhatsky wrote: > > All Ack-s/Tested-by-s were dropped, since the patch set has been > > reworked. I'm kindly asking arch-s maintainers and developers to test it > > once again. Sorry for any

Re: [PATCHv4 0/6] printk/ia64/ppc64/parisc64: let's deprecate %pF/%pf printk specifiers

On (11/10/17 10:11), Luck, Tony wrote: > On Fri, Nov 10, 2017 at 08:48:24AM +0900, Sergey Senozhatsky wrote: > > All Ack-s/Tested-by-s were dropped, since the patch set has been > > reworked. I'm kindly asking arch-s maintainers and developers to test it > > once again. Sorry for any

Re: [RFC 5/7] x86/asm: Rearrange struct cpu_tss to enlarge SYSENTER_stack and fix alignment

On Fri, Nov 10, 2017 at 8:05 PM, Andy Lutomirski wrote: > The Intel SDM says (Volume 3, 7.2.1): > >Avoid placing a page boundary in the part of the TSS that the >processor reads during a task switch (the first 104 bytes). The >processor may not correctly perform

Re: [RFC 5/7] x86/asm: Rearrange struct cpu_tss to enlarge SYSENTER_stack and fix alignment

On Fri, Nov 10, 2017 at 8:05 PM, Andy Lutomirski wrote: > The Intel SDM says (Volume 3, 7.2.1): > >Avoid placing a page boundary in the part of the TSS that the >processor reads during a task switch (the first 104 bytes). The >processor may not correctly perform address translations

[RFC 1/7] x86/asm/64: Allocate and enable the SYSENTER stack

This will simplify some future code changes that will want some temporary stack space in more places. It also lets us get rid of a SWAPGS_UNSAFE_STACK user. This does not depend on CONFIG_IA32_EMULATION because we'll want the stack space even without IA32 emulation. Signed-off-by: Andy

[RFC 1/7] x86/asm/64: Allocate and enable the SYSENTER stack

This will simplify some future code changes that will want some temporary stack space in more places. It also lets us get rid of a SWAPGS_UNSAFE_STACK user. This does not depend on CONFIG_IA32_EMULATION because we'll want the stack space even without IA32 emulation. Signed-off-by: Andy

  1   2   3   4   5   6   7   8   9   10   >