Re: [PATCH 4.14 000/164] 4.14.6-stable review

On Wed, Dec 13, 2017 at 07:48:43AM +0100, Marek Szyprowski wrote: > Hi Shuah and Greg, > > On 2017-12-12 15:47, Shuah Khan wrote: > > On 12/12/2017 05:43 AM, Greg Kroah-Hartman wrote: > > > This is the start of the stable review cycle for the 4.14.6 release. > > > There are 164 patches in this

Re: [PATCH 4.14 000/164] 4.14.6-stable review

On Wed, Dec 13, 2017 at 07:48:43AM +0100, Marek Szyprowski wrote: > Hi Shuah and Greg, > > On 2017-12-12 15:47, Shuah Khan wrote: > > On 12/12/2017 05:43 AM, Greg Kroah-Hartman wrote: > > > This is the start of the stable review cycle for the 4.14.6 release. > > > There are 164 patches in this

Re: [rtc-linux] Re: [PATCH v4 0/2] Add support for cros-ec-rtc driver.

On Tue, 12 Dec 2017, Alexandre Belloni wrote: > On 12/12/2017 at 17:05:37 +0100, Alexandre Belloni wrote: > > On 12/12/2017 at 16:41:39 +0100, Enric Balletbo Serra wrote: > > > + Alessandro Zummo > > > + Alexandre Belloni > > > > > > 2017-11-10 22:55 GMT+01:00 Enric Balletbo i Serra > > >

Re: [rtc-linux] Re: [PATCH v4 0/2] Add support for cros-ec-rtc driver.

On Tue, 12 Dec 2017, Alexandre Belloni wrote: > On 12/12/2017 at 17:05:37 +0100, Alexandre Belloni wrote: > > On 12/12/2017 at 16:41:39 +0100, Enric Balletbo Serra wrote: > > > + Alessandro Zummo > > > + Alexandre Belloni > > > > > > 2017-11-10 22:55 GMT+01:00 Enric Balletbo i Serra > > > :

Re: [PATCH] cgroup/cpuset: fix circular locking dependency

On 12/11/2017 08:50 PM, Tejun Heo wrote: > Hello, Peter. > > On Tue, Dec 05, 2017 at 12:01:17AM +0100, Peter Zijlstra wrote: >>> AFAICS, this should remove the circular dependency you originally >>> reported. I'll revert the two cpuset commits for now. >> >> So I liked his patches in that we

Re: [PATCH] cgroup/cpuset: fix circular locking dependency

On 12/11/2017 08:50 PM, Tejun Heo wrote: > Hello, Peter. > > On Tue, Dec 05, 2017 at 12:01:17AM +0100, Peter Zijlstra wrote: >>> AFAICS, this should remove the circular dependency you originally >>> reported. I'll revert the two cpuset commits for now. >> >> So I liked his patches in that we

[PATCH 1/1] arm: sunxi: Add alternative pins for spi0

Allwinner A10/A13/A20 SoCs have pinmux for spi0 on port C. The patch adds these pins in the respective dts includes. Signed-off-by: Stefan Mavrodiev --- arch/arm/boot/dts/sun4i-a10.dtsi | 10 ++ arch/arm/boot/dts/sun5i.dtsi | 10 ++

[PATCH 1/1] arm: sunxi: Add alternative pins for spi0

Allwinner A10/A13/A20 SoCs have pinmux for spi0 on port C. The patch adds these pins in the respective dts includes. Signed-off-by: Stefan Mavrodiev --- arch/arm/boot/dts/sun4i-a10.dtsi | 10 ++ arch/arm/boot/dts/sun5i.dtsi | 10 ++ arch/arm/boot/dts/sun7i-a20.dtsi | 10

Re: [BUG] skge: a possible sleep-in-atomic bug in skge_remove

On 2017/12/13 13:18, Stephen Hemminger wrote: On Tue, 12 Dec 2017 20:57:01 -0500 (EST) David Miller wrote: From: Stephen Hemminger Date: Tue, 12 Dec 2017 10:22:40 -0800 On Tue, 12 Dec 2017 08:34:45 -0500 (EST) David Miller

Re: [BUG] skge: a possible sleep-in-atomic bug in skge_remove

On 2017/12/13 13:18, Stephen Hemminger wrote: On Tue, 12 Dec 2017 20:57:01 -0500 (EST) David Miller wrote: From: Stephen Hemminger Date: Tue, 12 Dec 2017 10:22:40 -0800 On Tue, 12 Dec 2017 08:34:45 -0500 (EST) David Miller wrote: From: Jia-Ju Bai Date: Tue, 12 Dec 2017 16:38:12

Re: [PATCH v2 04/13] dt-bindings: pinctrl: Add bindings for Microsemi Ocelot

On Fri, Dec 8, 2017 at 4:46 PM, Alexandre Belloni wrote: > Add the documentation for the Microsemi Ocelot pinmuxing and gpio > controller. > > Cc: Linus Walleij > Cc: linux-g...@vger.kernel.org > Signed-off-by: Alexandre Belloni

Re: [PATCH v2 04/13] dt-bindings: pinctrl: Add bindings for Microsemi Ocelot

On Fri, Dec 8, 2017 at 4:46 PM, Alexandre Belloni wrote: > Add the documentation for the Microsemi Ocelot pinmuxing and gpio > controller. > > Cc: Linus Walleij > Cc: linux-g...@vger.kernel.org > Signed-off-by: Alexandre Belloni > Acked-by: Rob Herring Patch applied. Yours, Linus Walleij

Re: [BUG] scsi/qla2xxx: a possible sleep-in-atomic bug in qlt_get_tag

On 2017/12/13 12:42, James Bottomley wrote: On Wed, 2017-12-13 at 11:18 +0800, Jia-Ju Bai wrote: The driver may sleep under a spinlock. The function call paths are: qlt_handle_abts_recv_work (acquire the spinlock) qlt_response_pkt_all_vps qlt_response_pkt

Re: [BUG] scsi/qla2xxx: a possible sleep-in-atomic bug in qlt_get_tag

On 2017/12/13 12:42, James Bottomley wrote: On Wed, 2017-12-13 at 11:18 +0800, Jia-Ju Bai wrote: The driver may sleep under a spinlock. The function call paths are: qlt_handle_abts_recv_work (acquire the spinlock) qlt_response_pkt_all_vps qlt_response_pkt

Re: general protection fault in page_mapping

On 12/12/2017 06:03 PM, syzbot wrote: > Hello, > > syzkaller hit the following crash on > 82bcf1def3b5f1251177ad47c44f7e17af039b4b > git://git.cmpxchg.org/linux-mmots.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console output is attached. > C reproducer is

Re: general protection fault in page_mapping

On 12/12/2017 06:03 PM, syzbot wrote: > Hello, > > syzkaller hit the following crash on > 82bcf1def3b5f1251177ad47c44f7e17af039b4b > git://git.cmpxchg.org/linux-mmots.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console output is attached. > C reproducer is

Re: [PATCH v5 8/9] pinctrl: axp209: add support for AXP813 GPIOs

On Fri, Dec 8, 2017 at 2:41 PM, Quentin Schulz wrote: >> - pctl->desc = _data; >> + pctl->desc = (struct axp20x_pctrl_desc *)of_device_get_match_data(dev); >> pctl->regmap = axp20x->regmap; >> pctl->dev = >dev; >> > > I am using pctl->desc

Re: [PATCH v5 8/9] pinctrl: axp209: add support for AXP813 GPIOs

On Fri, Dec 8, 2017 at 2:41 PM, Quentin Schulz wrote: >> - pctl->desc = _data; >> + pctl->desc = (struct axp20x_pctrl_desc *)of_device_get_match_data(dev); >> pctl->regmap = axp20x->regmap; >> pctl->dev = >dev; >> > > I am using pctl->desc before retrieving it, thus

Re: [PATCH v5 0/4] ARM: ep93xx: ts72xx: Add support for BK3 board

On Tue, Dec 12, 2017 at 12:36 AM, Lukasz Majewski wrote: > This patch series adds support for Liebherr's BK3 board, being > a derivative of TS72XX design. All looks good. Acked-by: Linus Walleij Out of curiosity: Liebherr is obviously doing heavy-duty

Re: [PATCH v5 0/4] ARM: ep93xx: ts72xx: Add support for BK3 board

On Tue, Dec 12, 2017 at 12:36 AM, Lukasz Majewski wrote: > This patch series adds support for Liebherr's BK3 board, being > a derivative of TS72XX design. All looks good. Acked-by: Linus Walleij Out of curiosity: Liebherr is obviously doing heavy-duty industrial control systems. Likewise

Re: [PATCH] spi: s3c64xx: add SPDX identifier

On Wed, Dec 13, 2017 at 2:48 AM, Andi Shyti wrote: > Hi Krzysztof, > >> > Here, this should be as a top line: >> > >> > // SPDX-License-Identifier: GPL-2.0+ >> > >> > >> > So I agree with the SPDX id but also pointing to the use of the C++ // >> > comment style as

Re: [PATCH] spi: s3c64xx: add SPDX identifier

On Wed, Dec 13, 2017 at 2:48 AM, Andi Shyti wrote: > Hi Krzysztof, > >> > Here, this should be as a top line: >> > >> > // SPDX-License-Identifier: GPL-2.0+ >> > >> > >> > So I agree with the SPDX id but also pointing to the use of the C++ // >> > comment style as requested by Linus [1] >> >>

[PATCH V8 3/7] device property: Introduce a common API to fetch device match data

There is an OF/ACPI function to obtain the driver data. We want to hide OF/ACPI details from the device drivers and abstract following the device family of functions. Signed-off-by: Sinan Kaya Reviewed-by: Rob Herring Acked-by: Sakari Ailus

[PATCH V8 3/7] device property: Introduce a common API to fetch device match data

There is an OF/ACPI function to obtain the driver data. We want to hide OF/ACPI details from the device drivers and abstract following the device family of functions. Signed-off-by: Sinan Kaya Reviewed-by: Rob Herring Acked-by: Sakari Ailus --- drivers/base/property.c | 7 +++

[PATCH V8 1/7] Documentation: DT: qcom_hidma: Bump HW revision for the bugfixed HW

A new version of the HIDMA IP has been released with bug fixes. Bumping the hardware version to differentiate from others. Signed-off-by: Sinan Kaya Reviewed-by: Rob Herring --- Documentation/devicetree/bindings/dma/qcom_hidma_mgmt.txt | 4 ++-- 1 file

Re: [PATCH V2 2/3] perf/x86/intel/bm.c: Add Intel Branch Monitoring support

On Tue, Dec 12, 2017 at 03:08:00PM -0800, Megha Dey wrote: > > > > There's work on the way to allow multiple HW PMUs. You'll either have to > > wait for that or help in making that happen. What you do not do is > > silently hack around it. > > Could I get a pointer to the code implementing this?

[PATCH V8 1/7] Documentation: DT: qcom_hidma: Bump HW revision for the bugfixed HW

A new version of the HIDMA IP has been released with bug fixes. Bumping the hardware version to differentiate from others. Signed-off-by: Sinan Kaya Reviewed-by: Rob Herring --- Documentation/devicetree/bindings/dma/qcom_hidma_mgmt.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [PATCH V2 2/3] perf/x86/intel/bm.c: Add Intel Branch Monitoring support

On Tue, Dec 12, 2017 at 03:08:00PM -0800, Megha Dey wrote: > > > > There's work on the way to allow multiple HW PMUs. You'll either have to > > wait for that or help in making that happen. What you do not do is > > silently hack around it. > > Could I get a pointer to the code implementing this?

[PATCH V8 5/7] ACPI: properties: Implement get_match_data() callback

Now that we have a get_match_data() callback as part of the firmware node, implement the ACPI specific piece for it. Signed-off-by: Sinan Kaya Acked-by: Sakari Ailus --- drivers/acpi/property.c | 8 1 file changed, 8 insertions(+)

[PATCH V8 6/7] dmaengine: qcom_hidma: Add support for the new revision

Add support for probing the newer HW and also organize MSI capable hardware into an array for maintenance reasons. Signed-off-by: Sinan Kaya --- drivers/dma/qcom/hidma.c | 34 +- 1 file changed, 13 insertions(+), 21 deletions(-) diff --git

[PATCH V8 5/7] ACPI: properties: Implement get_match_data() callback

Now that we have a get_match_data() callback as part of the firmware node, implement the ACPI specific piece for it. Signed-off-by: Sinan Kaya Acked-by: Sakari Ailus --- drivers/acpi/property.c | 8 1 file changed, 8 insertions(+) diff --git a/drivers/acpi/property.c

[PATCH V8 6/7] dmaengine: qcom_hidma: Add support for the new revision

Add support for probing the newer HW and also organize MSI capable hardware into an array for maintenance reasons. Signed-off-by: Sinan Kaya --- drivers/dma/qcom/hidma.c | 34 +- 1 file changed, 13 insertions(+), 21 deletions(-) diff --git

[PATCH V8 7/7] dmaengine: qcom_hidma: Add identity register support

The location for destination event channel register has been relocated from offset 0x28 to 0x40. Update the code accordingly. Signed-off-by: Sinan Kaya --- drivers/dma/qcom/hidma.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git

[PATCH V8 7/7] dmaengine: qcom_hidma: Add identity register support

The location for destination event channel register has been relocated from offset 0x28 to 0x40. Update the code accordingly. Signed-off-by: Sinan Kaya --- drivers/dma/qcom/hidma.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/dma/qcom/hidma.c

[PATCH V8 4/7] OF: properties: Implement get_match_data() callback

Now that we have a get_match_data() callback as part of the firmware node, implement the OF specific piece for it. Signed-off-by: Sinan Kaya Reviewed-by: Rob Herring Acked-by: Sakari Ailus --- drivers/of/property.c | 8

[PATCH V8 4/7] OF: properties: Implement get_match_data() callback

Now that we have a get_match_data() callback as part of the firmware node, implement the OF specific piece for it. Signed-off-by: Sinan Kaya Reviewed-by: Rob Herring Acked-by: Sakari Ailus --- drivers/of/property.c | 8 1 file changed, 8 insertions(+) diff --git

[PATCH V8 2/7] ACPI / bus: Introduce acpi_get_match_data() function

OF has of_device_get_match_data() function to extract driver specific data structure. Add a similar function for ACPI. Signed-off-by: Sinan Kaya Acked-by: Rafael J. Wysocki --- drivers/acpi/bus.c | 18 ++ include/linux/acpi.h

[PATCH V8 2/7] ACPI / bus: Introduce acpi_get_match_data() function

OF has of_device_get_match_data() function to extract driver specific data structure. Add a similar function for ACPI. Signed-off-by: Sinan Kaya Acked-by: Rafael J. Wysocki --- drivers/acpi/bus.c | 18 ++ include/linux/acpi.h | 6 ++ 2 files changed, 24 insertions(+)

Re: [PATCH -mm] mm, swap: Fix race between swapoff and some swap operations

Hi Huang, Sorry for the late response. I'm in middle of long vacation. On Fri, Dec 08, 2017 at 08:32:16PM +0800, Huang, Ying wrote: > Minchan Kim writes: > > > On Fri, Dec 08, 2017 at 04:41:38PM +0800, Huang, Ying wrote: > >> Minchan Kim writes: > >>

Re: [PATCH -mm] mm, swap: Fix race between swapoff and some swap operations

Hi Huang, Sorry for the late response. I'm in middle of long vacation. On Fri, Dec 08, 2017 at 08:32:16PM +0800, Huang, Ying wrote: > Minchan Kim writes: > > > On Fri, Dec 08, 2017 at 04:41:38PM +0800, Huang, Ying wrote: > >> Minchan Kim writes: > >> > >> > On Fri, Dec 08, 2017 at

Re: [PATCH] iommu/vt-d: Fix shift overflow in qi_flush_dev_iotlb

On Tue, Dec 12, 2017 at 03:43:08PM -0700, Alex Williamson wrote: [...] > diff --git a/drivers/iommu/dmar.c b/drivers/iommu/dmar.c > index 9a7ffd13c7f0..87888b102057 100644 > --- a/drivers/iommu/dmar.c > +++ b/drivers/iommu/dmar.c > @@ -1345,7 +1345,9 @@ void qi_flush_dev_iotlb(struct intel_iommu

Re: [PATCH] iommu/vt-d: Fix shift overflow in qi_flush_dev_iotlb

On Tue, Dec 12, 2017 at 03:43:08PM -0700, Alex Williamson wrote: [...] > diff --git a/drivers/iommu/dmar.c b/drivers/iommu/dmar.c > index 9a7ffd13c7f0..87888b102057 100644 > --- a/drivers/iommu/dmar.c > +++ b/drivers/iommu/dmar.c > @@ -1345,7 +1345,9 @@ void qi_flush_dev_iotlb(struct intel_iommu

Re: About the try to remove cross-release feature entirely by Ingo

On Wed, Dec 13, 2017 at 3:24 PM, Byungchul Park wrote: > Lockdep works, based on the following: > >(1) Classifying locks properly >(2) Checking relationship between the classes > > If (1) is not good or (2) is not good, then we > might get false positives. >

Re: About the try to remove cross-release feature entirely by Ingo

On Wed, Dec 13, 2017 at 3:24 PM, Byungchul Park wrote: > Lockdep works, based on the following: > >(1) Classifying locks properly >(2) Checking relationship between the classes > > If (1) is not good or (2) is not good, then we > might get false positives. > > For (1), we don't have to

[PATCH v3] perf evsel: Enable ignore_missing_thread for pid option

While monitoring a multithread process with pid option, perf sometimes may return sys_perf_event_open failure with 3(No such process) if any of the process's threads die before we open the event. However, we want perf continue monitoring the remaining threads and do not exit with error. Here, the

[PATCH v3] perf evsel: Enable ignore_missing_thread for pid option

While monitoring a multithread process with pid option, perf sometimes may return sys_perf_event_open failure with 3(No such process) if any of the process's threads die before we open the event. However, we want perf continue monitoring the remaining threads and do not exit with error. Here, the

Re: [PATCH] vfio: Simplify capability helper

On 2017.12.13 12:13:34 +1100, Alexey Kardashevskiy wrote: > On 13/12/17 06:59, Alex Williamson wrote: > > The vfio_info_add_capability() helper requires the caller to pass a > > capability ID, which it then uses to fill in header fields, assuming > > hard coded versions. This makes for an awkward

Re: [PATCH] vfio: Simplify capability helper

On 2017.12.13 12:13:34 +1100, Alexey Kardashevskiy wrote: > On 13/12/17 06:59, Alex Williamson wrote: > > The vfio_info_add_capability() helper requires the caller to pass a > > capability ID, which it then uses to fill in header fields, assuming > > hard coded versions. This makes for an awkward

[PATCH] KVM: arm/arm64: don't set vtimer->cnt_ctl in kvm_arch_timer_handler

In our Armv8a server (qualcomm Amberwing, non VHE), after applying Christoffer's timer optimizing patchset(Optimize arch timer register handling), the guest is hang during kernel booting. The error root cause might be as follows: 1. in kvm_arch_timer_handler, it reset vtimer->cnt_ctl with current

[PATCH] KVM: arm/arm64: don't set vtimer->cnt_ctl in kvm_arch_timer_handler

In our Armv8a server (qualcomm Amberwing, non VHE), after applying Christoffer's timer optimizing patchset(Optimize arch timer register handling), the guest is hang during kernel booting. The error root cause might be as follows: 1. in kvm_arch_timer_handler, it reset vtimer->cnt_ctl with current

[v3 PATCH 0/3] powernv-cpufreq: Multiple pstate related fixes.

From: "Gautham R. Shenoy" This is a third version of the patch to fix pstate related issues in the powernv-cpufreq driver. The previous versions can be found here: [v2]: https://lkml.org/lkml/2017/12/7/1562 [v1]: https://lkml.org/lkml/2017/11/29/1338 On POWERNV

[v3 PATCH 0/3] powernv-cpufreq: Multiple pstate related fixes.

From: "Gautham R. Shenoy" This is a third version of the patch to fix pstate related issues in the powernv-cpufreq driver. The previous versions can be found here: [v2]: https://lkml.org/lkml/2017/12/7/1562 [v1]: https://lkml.org/lkml/2017/11/29/1338 On POWERNV platform, Pstates are

[v3 PATCH 2/3] powernv-cpufreq: Fix pstate_to_idx() to handle non-continguous pstates

From: "Gautham R. Shenoy" The code in powernv-cpufreq, makes the following two assumptions which are not guaranteed by the device-tree bindings: 1) Pstate ids are continguous: This is used in pstate_to_idx() to obtain the reverse map from a pstate to it's

[v3 PATCH 1/3] powernv-cpufreq: Add helper to extract pstate from PMSR

From: "Gautham R. Shenoy" On POWERNV platform, the fields for pstates in the Power Management Status Register (PMSR) and the Power Management Control Register (PMCR) are 8-bits wide. On POWER8 the pstates are negatively numbered while on POWER9 they are positively

[v3 PATCH 2/3] powernv-cpufreq: Fix pstate_to_idx() to handle non-continguous pstates

From: "Gautham R. Shenoy" The code in powernv-cpufreq, makes the following two assumptions which are not guaranteed by the device-tree bindings: 1) Pstate ids are continguous: This is used in pstate_to_idx() to obtain the reverse map from a pstate to it's corresponding entry

[v3 PATCH 1/3] powernv-cpufreq: Add helper to extract pstate from PMSR

From: "Gautham R. Shenoy" On POWERNV platform, the fields for pstates in the Power Management Status Register (PMSR) and the Power Management Control Register (PMCR) are 8-bits wide. On POWER8 the pstates are negatively numbered while on POWER9 they are positively numbered. The device-tree

[v3 PATCH 3/3] powernv-cpufreq: Treat pstates as opaque 8-bit values

From: "Gautham R. Shenoy" On POWER8 and POWER9, the PMSR and the PMCR registers define pstates to be 8-bit wide values. The device-tree exports pstates as 32-bit wide values of which the lower byte is the actual pstate. The current implementation in the kernel treats

[v3 PATCH 3/3] powernv-cpufreq: Treat pstates as opaque 8-bit values

From: "Gautham R. Shenoy" On POWER8 and POWER9, the PMSR and the PMCR registers define pstates to be 8-bit wide values. The device-tree exports pstates as 32-bit wide values of which the lower byte is the actual pstate. The current implementation in the kernel treats pstates as integer type,

Re: [RFC PATCH 5/9] ethtool: implement GET_DRVINFO message

Wed, Dec 13, 2017 at 12:54:39AM CET, mkube...@suse.cz wrote: >On Mon, Dec 11, 2017 at 05:16:01PM +0100, Jiri Pirko wrote: >> Mon, Dec 11, 2017 at 02:54:01PM CET, mkube...@suse.cz wrote: >> >+ >> >+ETHA_DRVINFO_DRIVER(string)driver name >> >+ETHA_DRVINFO_VERSION

Re: [RFC PATCH 5/9] ethtool: implement GET_DRVINFO message

Wed, Dec 13, 2017 at 12:54:39AM CET, mkube...@suse.cz wrote: >On Mon, Dec 11, 2017 at 05:16:01PM +0100, Jiri Pirko wrote: >> Mon, Dec 11, 2017 at 02:54:01PM CET, mkube...@suse.cz wrote: >> >+ >> >+ETHA_DRVINFO_DRIVER(string)driver name >> >+ETHA_DRVINFO_VERSION

Re: [PATCH] vfio: Simplify capability helper

On Tue, Dec 12, 2017 at 12:59:39PM -0700, Alex Williamson wrote: > The vfio_info_add_capability() helper requires the caller to pass a > capability ID, which it then uses to fill in header fields, assuming > hard coded versions. This makes for an awkward and rigid interface. > The only thing we

Re: [PATCH] vfio: Simplify capability helper

On Tue, Dec 12, 2017 at 12:59:39PM -0700, Alex Williamson wrote: > The vfio_info_add_capability() helper requires the caller to pass a > capability ID, which it then uses to fill in header fields, assuming > hard coded versions. This makes for an awkward and rigid interface. > The only thing we

Re: [PATCH 4.14 000/164] 4.14.6-stable review

Hi Shuah and Greg, On 2017-12-12 15:47, Shuah Khan wrote: On 12/12/2017 05:43 AM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.14.6 release. There are 164 patches in this series, all will be posted as a response to this one. If anyone has any issues with

Re: [PATCH 4.14 000/164] 4.14.6-stable review

Hi Shuah and Greg, On 2017-12-12 15:47, Shuah Khan wrote: On 12/12/2017 05:43 AM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.14.6 release. There are 164 patches in this series, all will be posted as a response to this one. If anyone has any issues with

[PATCH v2 01/11] ASoC: fsl_ssi: Rename fsl_ssi_private to fsl_ssi

Shorten the private data structure to save some wrapped lines. Signed-off-by: Nicolin Chen --- sound/soc/fsl/fsl_ssi.c | 456 +++- 1 file changed, 220 insertions(+), 236 deletions(-) diff --git a/sound/soc/fsl/fsl_ssi.c

[PATCH v2 01/11] ASoC: fsl_ssi: Rename fsl_ssi_private to fsl_ssi

Shorten the private data structure to save some wrapped lines. Signed-off-by: Nicolin Chen --- sound/soc/fsl/fsl_ssi.c | 456 +++- 1 file changed, 220 insertions(+), 236 deletions(-) diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c

[PATCH v2 06/11] ASoC: fsl_ssi: Refine printk outputs

This patches unifies the error message in the "failed to " format. It also reduces the length of one line and adds spaces to an operator. Signed-off-by: Nicolin Chen --- sound/soc/fsl/fsl_ssi.c | 16 1 file changed, 8 insertions(+), 8 deletions(-)

[PATCH v2 06/11] ASoC: fsl_ssi: Refine printk outputs

This patches unifies the error message in the "failed to " format. It also reduces the length of one line and adds spaces to an operator. Signed-off-by: Nicolin Chen --- sound/soc/fsl/fsl_ssi.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git

[PATCH v2 07/11] ASoC: fsl_ssi: Rename cpu_dai parameter to dai

Shortens the variable name to save space, useful for dev_err outputs. Signed-off-by: Nicolin Chen --- sound/soc/fsl/fsl_ssi.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/sound/soc/fsl/fsl_ssi.c

[PATCH v2 05/11] ASoC: fsl_ssi: Refine indentations and wrappings

This patch just simply unifies the coding style. Signed-off-by: Nicolin Chen --- Changelog v1->v2 * Added two missing indentation changes * Removed two extra blank lines. sound/soc/fsl/fsl_ssi.c | 239 +---

[PATCH v2 07/11] ASoC: fsl_ssi: Rename cpu_dai parameter to dai

Shortens the variable name to save space, useful for dev_err outputs. Signed-off-by: Nicolin Chen --- sound/soc/fsl/fsl_ssi.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c index

[PATCH v2 05/11] ASoC: fsl_ssi: Refine indentations and wrappings

This patch just simply unifies the coding style. Signed-off-by: Nicolin Chen --- Changelog v1->v2 * Added two missing indentation changes * Removed two extra blank lines. sound/soc/fsl/fsl_ssi.c | 239 +--- sound/soc/fsl/fsl_ssi.h | 2 +-

[PATCH v2 02/11] ASoC: fsl_ssi: Cache pdev->dev pointer

There should be no trouble to understand dev = pdev->dev. This can save some space to have more print info or save some wrapped lines. Signed-off-by: Nicolin Chen --- sound/soc/fsl/fsl_ssi.c | 64 - 1 file changed, 31

[PATCH v2 02/11] ASoC: fsl_ssi: Cache pdev->dev pointer

There should be no trouble to understand dev = pdev->dev. This can save some space to have more print info or save some wrapped lines. Signed-off-by: Nicolin Chen --- sound/soc/fsl/fsl_ssi.c | 64 - 1 file changed, 31 insertions(+), 33

[PATCH v2 09/11] ASoC: fsl_ssi: Replace fsl_ssi_rxtx_reg_val with fsl_ssi_regvals

The name fsl_ssi_rxtx_reg_val is too long to read comfortably. So this patch shortens it by using an array (fsl_ssi_regvals, renamed from fsl_ssi_reg_val). To do that, it also introduces two macros (TX and RX) to replace the wrapper structure. This will also help further cleanups. Meanwhile, it

[PATCH v2 09/11] ASoC: fsl_ssi: Replace fsl_ssi_rxtx_reg_val with fsl_ssi_regvals

The name fsl_ssi_rxtx_reg_val is too long to read comfortably. So this patch shortens it by using an array (fsl_ssi_regvals, renamed from fsl_ssi_reg_val). To do that, it also introduces two macros (TX and RX) to replace the wrapper structure. This will also help further cleanups. Meanwhile, it

[PATCH v2 11/11] ASoC: fsl_ssi: Define ternary macros to simplify code

Some regmap code looks redudant. So simplify it. Signed-off-by: Nicolin Chen --- sound/soc/fsl/fsl_ssi.c | 27 +++ sound/soc/fsl/fsl_ssi.h | 4 2 files changed, 15 insertions(+), 16 deletions(-) diff --git a/sound/soc/fsl/fsl_ssi.c

[PATCH v2 11/11] ASoC: fsl_ssi: Define ternary macros to simplify code

Some regmap code looks redudant. So simplify it. Signed-off-by: Nicolin Chen --- sound/soc/fsl/fsl_ssi.c | 27 +++ sound/soc/fsl/fsl_ssi.h | 4 2 files changed, 15 insertions(+), 16 deletions(-) diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c index

[PATCH v2 08/11] ASoC: fsl_ssi: Rename scr_val to scr

Simplify the variable name. This reduces one over-80-character line. Signed-off-by: Nicolin Chen --- sound/soc/fsl/fsl_ssi.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c index

[PATCH v2 08/11] ASoC: fsl_ssi: Rename scr_val to scr

Simplify the variable name. This reduces one over-80-character line. Signed-off-by: Nicolin Chen --- sound/soc/fsl/fsl_ssi.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/sound/soc/fsl/fsl_ssi.c b/sound/soc/fsl/fsl_ssi.c index 69fa86d..7fcc6bd 100644 ---

[PATCH v2 03/11] ASoC: fsl_ssi: Refine all comments

This patch refines the comments by: 1) Removing all out-of-date comments 2) Removing all not-so-useful comments 3) Unifying the styles of all comments 4) Simplifying over-descriptive comments 5) Adding comments to improve code readablity 6) Moving all register related comments to fsl_ssi.h 7)

[PATCH v2 03/11] ASoC: fsl_ssi: Refine all comments

This patch refines the comments by: 1) Removing all out-of-date comments 2) Removing all not-so-useful comments 3) Unifying the styles of all comments 4) Simplifying over-descriptive comments 5) Adding comments to improve code readablity 6) Moving all register related comments to fsl_ssi.h 7)

[PATCH v2 10/11] ASoC: fsl_ssi: Rename i2smode to i2s_net

Since this i2smode also includes the setting of Network mode, it should have it in the name. This patch also adds its MASK define. Signed-off-by: Nicolin Chen --- sound/soc/fsl/fsl_ssi.c | 24 sound/soc/fsl/fsl_ssi.h | 1 + 2 files changed, 13

[PATCH v2 04/11] ASoC: fsl_ssi: Rename registers and fields macros

This patch renames CCSR_SSI_xxx to REG_SSI_xxx and SSI_xxx_yyy style. It also slightly reduces the length of them to save some space. Signed-off-by: Nicolin Chen --- sound/soc/fsl/fsl_ssi.c | 374 +-- sound/soc/fsl/fsl_ssi.h

[PATCH v2 10/11] ASoC: fsl_ssi: Rename i2smode to i2s_net

Since this i2smode also includes the setting of Network mode, it should have it in the name. This patch also adds its MASK define. Signed-off-by: Nicolin Chen --- sound/soc/fsl/fsl_ssi.c | 24 sound/soc/fsl/fsl_ssi.h | 1 + 2 files changed, 13 insertions(+), 12

[PATCH v2 04/11] ASoC: fsl_ssi: Rename registers and fields macros

This patch renames CCSR_SSI_xxx to REG_SSI_xxx and SSI_xxx_yyy style. It also slightly reduces the length of them to save some space. Signed-off-by: Nicolin Chen --- sound/soc/fsl/fsl_ssi.c | 374 +-- sound/soc/fsl/fsl_ssi.h | 376

[PATCH v2 00/11] ASoC: fsl_ssi: Clean up - coding style level

==Changelog== v1->v2 * Dropped one patch to remove "struct device" * Revised PATCH-03 "Refine all comments" * Revised PATCH-05 "Refine indentations and wrappings" * Rebased all other patches * Added PATCH-10 "Rename i2smode to i2s_net" * Added PATCH-11 "Define ternary macros to simplify

[PATCH v2 00/11] ASoC: fsl_ssi: Clean up - coding style level

==Changelog== v1->v2 * Dropped one patch to remove "struct device" * Revised PATCH-03 "Refine all comments" * Revised PATCH-05 "Refine indentations and wrappings" * Rebased all other patches * Added PATCH-10 "Rename i2smode to i2s_net" * Added PATCH-11 "Define ternary macros to simplify

[PATCH 4/5] phy: renesas: rcar-gen3-usb2: add rcar_gen3_role_swap_ops

This patch add rcar_gen3_role_swap_ops to support other feature (e.g. gpio handling) easily. Signed-off-by: Yoshihiro Shimoda --- drivers/phy/renesas/phy-rcar-gen3-usb2.c | 51 +++- 1 file changed, 43 insertions(+), 8 deletions(-)

[PATCH 4/5] phy: renesas: rcar-gen3-usb2: add rcar_gen3_role_swap_ops

This patch add rcar_gen3_role_swap_ops to support other feature (e.g. gpio handling) easily. Signed-off-by: Yoshihiro Shimoda --- drivers/phy/renesas/phy-rcar-gen3-usb2.c | 51 +++- 1 file changed, 43 insertions(+), 8 deletions(-) diff --git

[PATCH 0/5] phy: renesas: rcar-gen3-usb2: add gpio handling for R-Car D3

This patch set is based on the latest linux-phy / next branch (commit id = 4fbd8d194f06c8a3fd2af1ce560ddb31f7ec8323). This new feature will be used by the renesas_usbhs driver on R-Car D3. Yoshihiro Shimoda (5): phy: renesas: rcar-gen3-usb2: call INIT_WORK() anyway phy: renesas:

[PATCH 0/5] phy: renesas: rcar-gen3-usb2: add gpio handling for R-Car D3

This patch set is based on the latest linux-phy / next branch (commit id = 4fbd8d194f06c8a3fd2af1ce560ddb31f7ec8323). This new feature will be used by the renesas_usbhs driver on R-Car D3. Yoshihiro Shimoda (5): phy: renesas: rcar-gen3-usb2: call INIT_WORK() anyway phy: renesas:

[PATCH 2/5] phy: renesas: rcar-gen3-usb2: unify OBINTEN handling

This patch unifies the OBINTEN handling to clean-up the code. Signed-off-by: Yoshihiro Shimoda --- drivers/phy/renesas/phy-rcar-gen3-usb2.c | 23 +++ 1 file changed, 15 insertions(+), 8 deletions(-) diff --git

[PATCH 2/5] phy: renesas: rcar-gen3-usb2: unify OBINTEN handling

This patch unifies the OBINTEN handling to clean-up the code. Signed-off-by: Yoshihiro Shimoda --- drivers/phy/renesas/phy-rcar-gen3-usb2.c | 23 +++ 1 file changed, 15 insertions(+), 8 deletions(-) diff --git a/drivers/phy/renesas/phy-rcar-gen3-usb2.c

[PATCH 5/5] phy: renesas: rcar-gen3-usb2: add gpio handling

Some R-Car SoCs (e.g. R-Car D3) doesn't have dedicated pins of VBUS and ID. So, they may be connected to gpio pins. To handle the gpio pins, this patch adds the handling of VBUS and ID pins instead of dedicated pins. Signed-off-by: Yoshihiro Shimoda ---

[PATCH 5/5] phy: renesas: rcar-gen3-usb2: add gpio handling

Some R-Car SoCs (e.g. R-Car D3) doesn't have dedicated pins of VBUS and ID. So, they may be connected to gpio pins. To handle the gpio pins, this patch adds the handling of VBUS and ID pins instead of dedicated pins. Signed-off-by: Yoshihiro Shimoda ---

[PATCH 1/5] phy: renesas: rcar-gen3-usb2: call INIT_WORK() anyway

In the future, the work struct will be used by non-irq related code. So, this patch moves the INIT_WORK() timing. Signed-off-by: Yoshihiro Shimoda --- drivers/phy/renesas/phy-rcar-gen3-usb2.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH 3/5] phy: renesas: rcar-gen3-usb2: use prefix "has_otg_pins_" for dedicated pins handling

To support gpio handling in the future, this patch clean-ups the code to use prefix "has_otg_pins_" functions. Signed-off-by: Yoshihiro Shimoda --- drivers/phy/renesas/phy-rcar-gen3-usb2.c | 130 --- 1 file changed, 85 insertions(+),

[PATCH 1/5] phy: renesas: rcar-gen3-usb2: call INIT_WORK() anyway

In the future, the work struct will be used by non-irq related code. So, this patch moves the INIT_WORK() timing. Signed-off-by: Yoshihiro Shimoda --- drivers/phy/renesas/phy-rcar-gen3-usb2.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[PATCH 3/5] phy: renesas: rcar-gen3-usb2: use prefix "has_otg_pins_" for dedicated pins handling

To support gpio handling in the future, this patch clean-ups the code to use prefix "has_otg_pins_" functions. Signed-off-by: Yoshihiro Shimoda --- drivers/phy/renesas/phy-rcar-gen3-usb2.c | 130 --- 1 file changed, 85 insertions(+), 45 deletions(-) diff --git

  1   2   3   4   5   6   7   8   9   10   >