Re: KASAN: slab-out-of-bounds Read in map_lookup_elem

2018-01-13 Thread Dmitry Vyukov
On Sun, Jan 14, 2018 at 1:13 AM, Daniel Borkmann wrote: > On 01/13/2018 02:58 AM, syzbot wrote: >> Hello, >> >> syzkaller hit the following crash on 19d28fbd306e7ae7c1acf05c3e6968b56f0d196b >> git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/master >> compiler: gcc (GCC) 7.1.1 2017

Re: [PATCH v1 3/4] ARM: dts: add pwm pins for r40.

2018-01-13 Thread Hao Zhang
2018-01-11 20:47 GMT+08:00 Maxime Ripard : > Hi, > > On Thu, Jan 11, 2018 at 07:33:23PM +0800, hao_zhang wrote: >> This patch add pwm pins for r40. >> >> Signed-off-by: hao_zhang > > You should order your patches differently. We try to be as bisectable > as possible, and if we just apply this patc

Re: [PATCH v1 4/4] ARM: dts: add pwm node for r40.

2018-01-13 Thread Hao Zhang
2018-01-11 20:47 GMT+08:00 Maxime Ripard : > Hi, > > On Thu, Jan 11, 2018 at 07:34:12PM +0800, hao_zhang wrote: >> This patch add pwm node for r40. >> >> Signed-off-by: hao_zhang >> --- >> arch/arm/boot/dts/sun8i-r40.dtsi | 13 + >> 1 file changed, 13 insertions(+) >> >> diff --git a/

warning: '______f' is static but declared in inline function in

2018-01-13 Thread Randy Dunlap
Hi, I regularly get 50 MB - 60 MB files during kernel randconfig builds. These large files mostly contain (many repeats of; e.g., 124,594): In file included from ../include/linux/string.h:6:0, from ../include/linux/uuid.h:20, from ../include/linux/mod_devicetable

Re: [PATCH 3/3] tracing: don't set parser->cont if it has reached the end of input buffer

2018-01-13 Thread Du, Changbin
On Fri, Jan 12, 2018 at 10:31:08AM -0500, Steven Rostedt wrote: [...] > > Thanks, so now I unstand why below corner case. The userspace try to set the > > filter with a unrecognized symbole name (e.g "abcdefg"). > > open("/sys/kernel/debug/tracing/set_ftrace_filter", O_WRONLY|O_TRUNC) = 3 > > write

Re: [PATCH v3 1/3] PCI/AER: factor out error reporting from AER

2018-01-13 Thread poza
On 2018-01-13 06:27, Bjorn Helgaas wrote: On Mon, Jan 08, 2018 at 01:25:03PM +0530, Oza Pawandeep wrote: This patch factors out error reporting callbacks, which are currently tightly coupled with AER. DPC should be able to call these callbacks when DPC trigger event occurs. Signed-off-by: Oza

Re: Commit fc72ae40e303 broke x86-64 build environment.

2018-01-13 Thread vcaputo
On Sat, Jan 13, 2018 at 11:13:13PM -0600, Rob Landley wrote: > You've made the ORC unwinder part of allnoconfig, which means trying to > build "make ARCH=x86_64 allnoconfig" requires installing a new package > (libelf-dev) or else the build breaks. > > What's worse, if I go into menuconfig and swi

Hello,

2018-01-13 Thread mallory genest
-- Weekend Greetings , I was wondering if you got my previous Email to you regarding my proposal ? best regards

Commit fc72ae40e303 broke x86-64 build environment.

2018-01-13 Thread Rob Landley
You've made the ORC unwinder part of allnoconfig, which means trying to build "make ARCH=x86_64 allnoconfig" requires installing a new package (libelf-dev) or else the build breaks. What's worse, if I go into menuconfig and switch it back to frame pointer, the build STILL breaks: $ make -j 8 Make

Re: [PATCH] net/mlx4_en: ensure rx_desc updating reaches HW before prod db updating

2018-01-13 Thread jianchao.wang
Dear all Thanks for the kindly response and reviewing. That's really appreciated. On 01/13/2018 12:46 AM, Eric Dumazet wrote: >> Does this need to be dma_wmb(), and should it be in >> mlx4_en_update_rx_prod_db ? >> > +1 on dma_wmb() > > On what architecture bug was observed ? This issue was obse

Re: [PATCHv2 5/7] printk: allow kmsg to be encrypted using public key encryption

2018-01-13 Thread Sergey Senozhatsky
Ccing Kees, Peter, Andrew, Steven On (01/13/18 23:34), Dan Aloni wrote: > This commit enables the kernel to encrypt the free-form text that > is generated by printk() before it is brought up to `dmesg` in > userspace. > > The encryption is made using one of the trusted public keys which > are kep

Re: [PATCH 04/11] signal/parisc: Document a conflict with SI_USER with SIGFPE

2018-01-13 Thread Eric W. Biederman
ebied...@xmission.com (Eric W. Biederman) writes: > Helge Deller writes: > >> * Eric W. Biederman : >>> Setting si_code to 0 results in a userspace seeing an si_code of 0. >>> This is the same si_code as SI_USER. Posix and common sense requires >>> that SI_USER not be a signal specific si_code.

Year 2018 to Year 3018: Top 15 Blacklisted Photographers in Singapore Unveiled

2018-01-13 Thread Turritopsis Dohrnii Teo En Ming
1. Mr. Turritopsis Dohrnii Teo En Ming is a TARGETED INDIVIDUAL (TI) since 2007, or perhaps even earlier. That is more than 10 years already. A TARGETED INDIVIDUAL (TI) is a person who is PERSECUTED, TARGETED, BLACKLISTED and MARKED by the [SINGAPORE] GOVERNMENT. Teo En Ming, who is a Targeted Indi

Re: [PATCH bpf-next v5 5/5] error-injection: Support fault injection framework

2018-01-13 Thread Masami Hiramatsu
On Sat, 13 Jan 2018 22:28:29 +0900 Akinobu Mita wrote: > 2018-01-13 2:56 GMT+09:00 Masami Hiramatsu : > > Support in-kernel fault-injection framework via debugfs. > > This allows you to inject a conditional error to specified > > function using debugfs interfaces. > > > > Here is the result of te

Year 2025: Top 15 Blacklisted Photographers in Singapore Unveiled

2018-01-13 Thread Turritopsis Dohrnii Teo En Ming
1. Mr. Turritopsis Dohrnii Teo En Ming is a TARGETED INDIVIDUAL (TI) since 2007, or perhaps even earlier. That is more than 10 years already. A TARGETED INDIVIDUAL (TI) is a person who is PERSECUTED, TARGETED, BLACKLISTED and MARKED by the [SINGAPORE] GOVERNMENT. Teo En Ming, who is a Targeted Indi

Re: [PATCH 1/2] microblaze: fix endian handling

2018-01-13 Thread kbuild test robot
Hi Arnd, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.15-rc7 next-20180112] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/A

Re: [PATCH] kernel:bpf Remove structure passing and assignment to save stack and no coping structures

2018-01-13 Thread Alexei Starovoitov
On Sun, Jan 14, 2018 at 12:03:42AM +0200, Karim Eshapa wrote: > Use pointers to structure as arguments to function instead of coping > structures and less stack size. Also transfer TNUM(_v, _m) to > tnum.h file to be used in differnet files for creating anonymous structures > statically. > > Signe

Re: BUG: unable to handle kernel paging request in check_memory_region

2018-01-13 Thread Daniel Borkmann
On 01/13/2018 08:29 AM, Dmitry Vyukov wrote: > On Fri, Jan 12, 2018 at 11:58 PM, syzbot > wrote: >> Hello, >> >> syzkaller hit the following crash on >> c92a9a461dff6140c539c61e457aa97df29517d6 >> git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/master >> compiler: gcc (GCC) 7.1.1

Re: general protection fault in __bpf_map_put

2018-01-13 Thread Daniel Borkmann
On 01/13/2018 08:16 AM, Dmitry Vyukov wrote: > On Wed, Jan 10, 2018 at 1:58 PM, syzbot > wrote: >> Hello, >> >> syzkaller hit the following crash on >> b4464bcab38d3f7fe995a7cb960eeac6889bec08 >> git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/master >> compiler: gcc (GCC) 7.1.1

Re: divide error in ___bpf_prog_run

2018-01-13 Thread Daniel Borkmann
On 01/13/2018 02:58 AM, syzbot wrote: > Hello, > > syzkaller hit the following crash on 19d28fbd306e7ae7c1acf05c3e6968b56f0d196b > git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console output is attached. >

Re: KASAN: slab-out-of-bounds Read in map_lookup_elem

2018-01-13 Thread Daniel Borkmann
On 01/13/2018 02:58 AM, syzbot wrote: > Hello, > > syzkaller hit the following crash on 19d28fbd306e7ae7c1acf05c3e6968b56f0d196b > git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git/master > compiler: gcc (GCC) 7.1.1 20170620 > .config is attached > Raw console output is attached. >

[PATCH] input: Add driver for USB ELAN Touchpad

2018-01-13 Thread Alexandrov Stansilav
This is driver for usb touchpad found on HP Pavilion x2 10-p0xx laptop. On this device keyboard and touchpad connected as a single usb device with two interfaces: keyboard, which exposes ordinary keys and second interface is touchpad which also contains FlightMode button and audio mute led (which p

[PATCH v2] x86/retpoline: Add LFENCE to the retpoline/RSB filling RSB macros

2018-01-13 Thread Tom Lendacky
The PAUSE instruction is currently used in the retpoline and RSB filling macros as a speculation trap. The use of PAUSE was originally suggested because it showed a very, very small difference in the amount of cycles/time used to execute the retpoline as compared to LFENCE. On AMD, the PAUSE inst

[PATCH] x86/pti: Fix !PCID and sanitize defines

2018-01-13 Thread Thomas Gleixner
The switch to the user space page tables in the low level ASM code sets unconditionally bit 12 and bit 11 of CR3. Bit 12 is switching the base address of the page directory to the user part, bit 11 is switching the PCID to the PCID associated with the user page tables. This fails on a machine whic

[PATCH v5 05/14] nubus: Validate slot resource IDs

2018-01-13 Thread Finn Thain
While we are here, include the slot number in the related error messages. Tested-by: Stan Johnson Signed-off-by: Finn Thain --- drivers/nubus/nubus.c | 26 -- 1 file changed, 20 insertions(+), 6 deletions(-) diff --git a/drivers/nubus/nubus.c b/drivers/nubus/nubus.c ind

[PATCH v5 04/14] nubus: Fix log spam

2018-01-13 Thread Finn Thain
Testing shows that a single Radius PrecisionColor 24X display board, which has 95 functional resources, produces over a thousand lines of log messages. Suppress these messages with pr_debug(). Remove some redundant messages relating to nubus_get_subdir() calls. Fix the format block debug messages a

[PATCH v5 09/14] nubus: Generalize block resource handling

2018-01-13 Thread Finn Thain
Scrap the specialized code to unpack video mode name resources and driver resources. It isn't useful. Instead, add a re-usable function to handle lists of block resources of any kind, and descend into the video mode table resource directory. Rename callers as nubus_get_foo(), consistent with their

[PATCH v5 06/14] nubus: Call proc_mkdir() not more than once per slot directory

2018-01-13 Thread Finn Thain
This patch fixes the following WARNING. proc_dir_entry 'nubus/a' already registered Modules linked in: CPU: 0 PID: 1 Comm: swapper Tainted: GW 4.13.0-00036-gd57552077387 #1 Stack from 01c1bd9c: 01c1bd9c 003c2c8b 01c1bdc0 0001b0fe 00322f4a 01c43a20 01c43b0c 0

[PATCH v5 08/14] nubus: Clean up whitespace

2018-01-13 Thread Finn Thain
Tested-by: Stan Johnson Signed-off-by: Finn Thain --- include/linux/nubus.h | 58 +-- 1 file changed, 29 insertions(+), 29 deletions(-) diff --git a/include/linux/nubus.h b/include/linux/nubus.h index 3c7b236074b3..2d6f04055ebe 100644 --- a/includ

[PATCH v5 07/14] nubus: Remove redundant code

2018-01-13 Thread Finn Thain
Eliminate unused values from struct nubus_dev to save wasted memory (a Radius PrecisionColor 24X card has about 95 functional resources and up to six such cards may be fitted). Also remove redundant static variable initialization, an unreachable !MACH_IS_MAC conditional, the unused nubus_find_devic

[PATCH v5 10/14] nubus: Rework /proc/bus/nubus/s/ implementation

2018-01-13 Thread Finn Thain
The /proc/bus/nubus/s/ directory tree for any slot s is missing a lot of information. The struct file_operations methods have long been left unimplemented (hence the familiar compile-time warning, "Need to set some I/O handlers here"). Slot resources have a complex structure which varies depending

[PATCH v5 11/14] nubus: Rename struct nubus_dev

2018-01-13 Thread Finn Thain
It is misleading to call a functional resource a "device". In adopting the Linux Driver Model, the struct device will be embedded in struct nubus_board. That will compound the terminlogy problem because drivers will bind with boards, not with functional resources. Avoid this by renaming struct nubu

[PATCH v5 12/14] nubus: Adopt standard linked list implementation

2018-01-13 Thread Finn Thain
This increases code re-use and improves readability. Cc: "David S. Miller" Cc: Bartlomiej Zolnierkiewicz Acked-by: Bartlomiej Zolnierkiewicz Tested-by: Stan Johnson Signed-off-by: Finn Thain --- drivers/net/ethernet/8390/mac8390.c | 7 +++-- drivers/net/ethernet/cirrus/mac89x0.c | 6

[PATCH v5 14/14] nubus: Add support for the driver model

2018-01-13 Thread Finn Thain
This patch brings basic support for the Linux Driver Model to the NuBus subsystem. For flexibility, the matching of boards with drivers is left up to the drivers. This is also the approach taken by NetBSD. A board may have many functions, and drivers may have to consider many functional resources

[PATCH v5 13/14] nubus: Add expansion_type values for various Mac models

2018-01-13 Thread Finn Thain
Add an expansion slot attribute to allow drivers to properly handle cards like Comm Slot cards and PDS cards without declaration ROMs. This clarifies the logic for the Centris 610 model which has no Comm Slot but has an optional on-board SONIC device. Cc: "David S. Miller" Tested-by: Stan Johnson

[PATCH v5 02/14] nubus: Fix up header split

2018-01-13 Thread Finn Thain
Due to the '#ifdef __KERNEL__' being located in the wrong place, some definitions from the kernel API were placed in the UAPI header during the scripted header split. Fix this. Also, remove the duplicate comment which is only relevant to the UAPI header. Fixes: 607ca46e97a1 ("UAPI: (Scripted) Disi

[PATCH v5 01/14] nubus: Avoid array underflow and overflow

2018-01-13 Thread Finn Thain
Check array indices. Avoid sprintf. Use buffers of sufficient size. Use appropriate types for array length parameters. Tested-by: Stan Johnson Signed-off-by: Finn Thain --- drivers/nubus/nubus.c | 29 + drivers/nubus/proc.c | 12 ++-- include/linux/nubus.h |

[PATCH v5 03/14] nubus: Use static functions where possible

2018-01-13 Thread Finn Thain
This fixes a couple of warnings from 'make W=1': drivers/nubus/nubus.c:790: warning: no previous prototype for 'nubus_probe_slot' drivers/nubus/nubus.c:824: warning: no previous prototype for 'nubus_scan_bus' Tested-by: Stan Johnson Signed-off-by: Finn Thain --- drivers/nubus/nubus.c | 4 ++--

[PATCH v5 00/14] Modernization and fixes for NuBus subsystem

2018-01-13 Thread Finn Thain
This series begins with cleanups and fixes for the NuBus subsystem and finishes with a patch to add support for the Linux Driver Model. A separate series (which requires this one) modernizes NuBus drivers. Changes since v1: - Added the missing NULL check in nubus_device_remove(). - Squashed the tw

[PATCH] kernel:bpf Remove structure passing and assignment to save stack and no coping structures

2018-01-13 Thread Karim Eshapa
Use pointers to structure as arguments to function instead of coping structures and less stack size. Also transfer TNUM(_v, _m) to tnum.h file to be used in differnet files for creating anonymous structures statically. Signed-off-by: Karim Eshapa Thanks, Karim --- include/linux/tnum.h | 4 +++

[PATCHv2 6/7] tools: add dmesg decryption program

2018-01-13 Thread Dan Aloni
Example execution: dmesg | dmesg-decipher Signed-off-by: Dan Aloni --- tools/Makefile | 9 +- tools/kmsg/.gitignore | 1 + tools/kmsg/Makefile | 14 ++ tools/kmsg/dmesg-decipher.c | 354 4 files changed, 377 inser

[PATCHv2 0/7] RFC: Public key encryption of dmesg by the kernel

2018-01-13 Thread Dan Aloni
Changes from v1 [1]: - Made suggested fixes following a review from Randy Dunlap - Modified the ASCII encoding of cipher text to base64 instead of hex, with newlines replaced by '~' ; updated dmesg-decipher for it too - Moved base64 code from fs/ceph to lib, and improved it a bit - Improved

[PATCHv2 3/7] base64-armor: add bounds checking

2018-01-13 Thread Dan Aloni
Future use of the API can benefit from bounds checking. Signed-off-by: Dan Aloni --- include/linux/base64-armor.h | 17 +++-- lib/base64-armor.c | 20 ++-- net/ceph/crypto.c| 2 +- 3 files changed, 30 insertions(+), 9 deletions(-) diff --git a/

[PATCHv2 2/7] Move net/ceph/armor to lib/ and add docs

2018-01-13 Thread Dan Aloni
Plus, add functions that assist in managing buffer bounds. Signed-off-by: Dan Aloni --- include/linux/base64-armor.h | 65 ++ lib/Kconfig| 7 lib/Makefile | 1 + net/ceph/armor.c => lib/base64-

[PATCHv2 1/7] crypto: fix memory leak in rsa-kcs1pad encryption

2018-01-13 Thread Dan Aloni
The encryption mode of pkcs1pad never uses out_sg and out_buf, so there's no need to allocate the buffer, which presently is not even being freed. CC: Herbert Xu Signed-off-by: Dan Aloni --- crypto/rsa-pkcs1pad.c | 9 - 1 file changed, 9 deletions(-) diff --git a/crypto/rsa-pkcs1pad.c

Re: [PATCH v1] x86/retpoline: Use lfence in the retpoline/RSB filling RSB macros

2018-01-13 Thread Thomas Gleixner
On Sat, 13 Jan 2018, Tom Lendacky wrote: > On 1/13/2018 8:07 AM, Van De Ven, Arjan wrote: > >>> The RSB filling macro is applicable to AMD, and, if software is unable to > >>> verify that lfence is serializing on AMD (possible when running under a > >>> hypervisor), the generic retpoline support w

[PATCHv2 4/7] certs: allow in-kernel access of trusted keys

2018-01-13 Thread Dan Aloni
CC: David Howells Signed-off-by: Dan Aloni --- certs/system_keyring.c| 56 ++- include/keys/system_keyring.h | 3 +++ 2 files changed, 58 insertions(+), 1 deletion(-) diff --git a/certs/system_keyring.c b/certs/system_keyring.c index 6251d1b27f0c

[PATCHv2 5/7] printk: allow kmsg to be encrypted using public key encryption

2018-01-13 Thread Dan Aloni
This commit enables the kernel to encrypt the free-form text that is generated by printk() before it is brought up to `dmesg` in userspace. The encryption is made using one of the trusted public keys which are kept built-in inside the kernel. These keys are presently also used for verifying kernel

[PATCHv2 7/7] docs: add dmesg encryption doc

2018-01-13 Thread Dan Aloni
Reviewed-by: Randy Dunlap Signed-off-by: Dan Aloni --- Documentation/admin-guide/dmesg-encryption.rst | 118 + Documentation/admin-guide/index.rst| 1 + 2 files changed, 119 insertions(+) create mode 100644 Documentation/admin-guide/dmesg-encryption.rst di

Re: [PATCH] [net-next] net: netsec: use dma_addr_t for storing dma address

2018-01-13 Thread Ard Biesheuvel
On 13 January 2018 at 21:13, Arnd Bergmann wrote: > On targets that have different sizes for phys_addr_t and dma_addr_t, > we get a type mismatch error: > > drivers/net/ethernet/socionext/netsec.c: In function 'netsec_alloc_dring': > drivers/net/ethernet/socionext/netsec.c:970:9: error: passing ar

[PATCH] [net-next] net: netsec: use dma_addr_t for storing dma address

2018-01-13 Thread Arnd Bergmann
On targets that have different sizes for phys_addr_t and dma_addr_t, we get a type mismatch error: drivers/net/ethernet/socionext/netsec.c: In function 'netsec_alloc_dring': drivers/net/ethernet/socionext/netsec.c:970:9: error: passing argument 3 of 'dma_zalloc_coherent' from incompatible pointer

Re: [PATCH v1] x86/retpoline: Use lfence in the retpoline/RSB filling RSB macros

2018-01-13 Thread Tom Lendacky
On 1/13/2018 8:07 AM, Van De Ven, Arjan wrote: >>> The RSB filling macro is applicable to AMD, and, if software is unable to >>> verify that lfence is serializing on AMD (possible when running under a >>> hypervisor), the generic retpoline support will be used and, so, is also >>> applicable to AMD

Re: pci/setup-bus: Delete an error message for a failed memory allocation in add_to_list()

2018-01-13 Thread SF Markus Elfring
> Your commit message says "omit an extra message", which suggests that > there are currently two messages about the memory allocation failure, > and that your patch removes one of them. Yes. - There is a general transformation pattern applied. > If that's the case, it would be nice to know wher

Re: [PATCH 04/11] signal/parisc: Document a conflict with SI_USER with SIGFPE

2018-01-13 Thread Eric W. Biederman
Helge Deller writes: > * Eric W. Biederman : >> Setting si_code to 0 results in a userspace seeing an si_code of 0. >> This is the same si_code as SI_USER. Posix and common sense requires >> that SI_USER not be a signal specific si_code. As such this use of 0 >> for the si_code is a pretty horr

Re: [PATCH v2 16/22] mmc: tmio: fix never-detected card insertion bug

2018-01-13 Thread Wolfram Sang
> I am talking about the card detection > by the IP-builtin circuit. Yes, I know. As I wrote in one of the previous patches when reviewing it, I disabled GPIO CD and used the internal mechanism (for tests where it is relevant). Like here, too. > - GPIO is not set up -> mmc_g

Re: Yet another KPTI regression with 4.14.x series in a VM

2018-01-13 Thread Andy Lutomirski
On Sat, Jan 13, 2018 at 12:45 PM, Thomas Gleixner wrote: > On Sat, 13 Jan 2018, Andy Lutomirski wrote: >> Trying to inventory this stuff scattered all over the place: >> >> #define PTI_PGTABLE_SWITCH_BITPAGE_SHIFT >> #define PTI_SWITCH_PGTABLES_MASK(1<> # define X86_CR3_PTI_SWITCH_BIT1

Re: Yet another KPTI regression with 4.14.x series in a VM

2018-01-13 Thread Thomas Gleixner
On Sat, 13 Jan 2018, Andy Lutomirski wrote: > Trying to inventory this stuff scattered all over the place: > > #define PTI_PGTABLE_SWITCH_BITPAGE_SHIFT > #define PTI_SWITCH_PGTABLES_MASK(1< # define X86_CR3_PTI_SWITCH_BIT11 > #define PTI_SWITCH_MASK > (PTI_SWITCH_PGTABLES_MASK|(1< > B

[GIT PULL] Staging driver fixe for 4.15-rc8

2018-01-13 Thread Greg KH
The following changes since commit 30a7acd573899fd8b8ac39236eff6468b195ac7d: Linux 4.15-rc6 (2017-12-31 14:47:43 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git/ tags/staging-4.15-rc8 for you to fetch changes up to 443064cb0b1

[GIT PULL] USB driver fixes for 4.15-rc8

2018-01-13 Thread Greg KH
The following changes since commit 30a7acd573899fd8b8ac39236eff6468b195ac7d: Linux 4.15-rc6 (2017-12-31 14:47:43 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git/ tags/usb-4.15-rc8 for you to fetch changes up to 1a2e91e795def04e15f

[GIT PULL] Char/Misc driver fixes for 4.15-rc8

2018-01-13 Thread Greg KH
The following changes since commit 30a7acd573899fd8b8ac39236eff6468b195ac7d: Linux 4.15-rc6 (2017-12-31 14:47:43 -0800) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/char-misc.git/ tags/char-misc-4.15-rc8 for you to fetch changes up to aa1f10e

Re: [PATCH v5] leaking_addresses: add generic 32-bit support

2018-01-13 Thread Tobin C. Harding
On Sat, Jan 13, 2018 at 10:55:26AM +, Kaiwan N Billimoria wrote: > Hi Tobin, > > Thanks very much for your detailed review. > Just wanted to say that am up to my neck in work (an exceptionally busy > time), hence will take a while to work on this - around another 3 weeks > perhaps. > I'd like

[PATCH v2] Coccinelle: kzalloc-simple: Rename kzalloc-simple to zalloc-simple

2018-01-13 Thread Himanshu Jha
Rename kzalloc-simple to zalloc-simple since now the rule is not specific to kzalloc function only, but also to many other zero memory allocating functions specified in the rule. Suggested-by: SF Markus Elfring Signed-off-by: Himanshu Jha --- v2: -generated the patch using -M flag f

Re: [PATCH v3 8/9] x86: use __uaccess_begin_nospec and ASM_IFENCE in get_user paths

2018-01-13 Thread Eric W. Biederman
Linus Torvalds writes: > On Sat, Jan 13, 2018 at 11:05 AM, Linus Torvalds > wrote: >> >> I _know_ that lfence is expensive as hell on P4, for example. >> >> Yes, yes, "sbb" is often more expensive than most ALU instructions, >> and Agner Fog says it has a 10-cycle latency on Prescott (which is >

Re: pci/setup-bus: Delete an error message for a failed memory allocation in add_to_list()

2018-01-13 Thread Bjorn Helgaas
On Sat, Jan 13, 2018 at 07:15:04AM +0100, SF Markus Elfring wrote: > >> Omit an extra message for a memory allocation failure in this function. > > > > If this is an "extra" message, I assume there's some other message? > > Can you mention where that is in the changelog? > > * Would you like to g

[PATCH v3] input: pxrc: new driver for PhoenixRC Flight Controller Adapter

2018-01-13 Thread Marcus Folkesson
This driver let you plug in your RC controller to the adapter and use it as input device in various RC simulators. Signed-off-by: Marcus Folkesson --- v3: - Use RUDDER and MISC instead of TILT_X and TILT_Y - Drop kref and anchor - Rework URB handling - Add PM suppo

Re: Yet another KPTI regression with 4.14.x series in a VM

2018-01-13 Thread Andy Lutomirski
On Fri, Jan 12, 2018 at 10:33 PM, Willy Tarreau wrote: > On Fri, Jan 12, 2018 at 10:08:20PM -0800, Andy Lutomirski wrote: >> In fact, it looks like this code is totally bogus and has never been >> correct at all. Even in: >> >> commit 4b1d5ae3b103eda43f9d0f85c355bb6995b03a30 >> Author: Peter Zijl

Re: [Cocci] [PATCH] Coccinelle: kzalloc-simple: Rename kzalloc-simple to zalloc-simple

2018-01-13 Thread Himanshu Jha
On Sat, Jan 13, 2018 at 05:13:36PM -0200, Fabio Estevam wrote: > On Sat, Jan 13, 2018 at 3:53 PM, Himanshu Jha > wrote: > > > Yes, I used 'git mv'. > > > > It doesn't matter when applying through 'git am', both will result the > > same AFAIK and only difference is that the patch files generated b

[PATCH] sunrpc: Use seq_putc() in unix_gid_show()

2018-01-13 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 13 Jan 2018 20:33:05 +0100 A single character (line break) should be put into a sequence. Thus use the corresponding function "seq_putc". This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- net/sunrpc/svcauth_unix.c | 2 +

Re: [PATCH v3 8/9] x86: use __uaccess_begin_nospec and ASM_IFENCE in get_user paths

2018-01-13 Thread Linus Torvalds
On Sat, Jan 13, 2018 at 11:05 AM, Linus Torvalds wrote: > > I _know_ that lfence is expensive as hell on P4, for example. > > Yes, yes, "sbb" is often more expensive than most ALU instructions, > and Agner Fog says it has a 10-cycle latency on Prescott (which is > outrageous, but being one or two

[PATCH v2] iio: adc: driver for ti adc081s/adc101s/adc121s

2018-01-13 Thread Milan Stevanovic
From fab687d20ba46d78439b6cdaf0d40b78ae68222c Mon Sep 17 00:00:00 2001 From: Milan Stevanovic Date: Sun, 7 Jan 2018 21:44:33 +0100 Subject: [PATCH v2] iio: adc: driver for ti adc081s/adc101s/adc121s Add Linux device driver for TI single-channel CMOS 8/10/12-bit analog-to-digital converte

[PATCH] Remove structure passing and assignment to save stack and no coping structures.

2018-01-13 Thread Karim Eshapa
Signed-off-by: Karim Eshapa Thanks, Karim --- include/linux/tnum.h | 2 +- kernel/bpf/tnum.c | 13 +++-- kernel/bpf/verifier.c | 12 3 files changed, 16 insertions(+), 11 deletions(-) diff --git a/include/linux/tnum.h b/include/linux/tnum.h index 0d2d3da..ddb1250 1006

[PATCH] l2tp: Use seq_putc() in l2tp_dfs_seq_session_show()

2018-01-13 Thread SF Markus Elfring
From: Markus Elfring Date: Sat, 13 Jan 2018 20:11:01 +0100 Two single characters (line breaks) should be put into a sequence. Thus use the corresponding function "seq_putc". This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring --- net/l2tp/l2tp_debugfs.c | 4

Re: [PATCH] net/mlx4_en: ensure rx_desc updating reaches HW before prod db updating

2018-01-13 Thread Jason Gunthorpe
On Fri, Jan 12, 2018 at 01:01:56PM -0800, Saeed Mahameed wrote: > Simply putting a memory barrier on the top or the bottom of a functions, > means nothing unless you are looking at the whole picture, of all the > callers of that function to understand why is it there. When I review code I want t

Re: [Cocci] [PATCH] Coccinelle: kzalloc-simple: Rename kzalloc-simple to zalloc-simple

2018-01-13 Thread Fabio Estevam
On Sat, Jan 13, 2018 at 3:53 PM, Himanshu Jha wrote: > Yes, I used 'git mv'. > > It doesn't matter when applying through 'git am', both will result the > same AFAIK and only difference is that the patch files generated by 'git > format-patch' are different. But that is not important I think. You

[PATCH] x86_64: trim clear_page.S includes

2018-01-13 Thread Alexey Dobriyan
After alternatives were shifted to the call site, only 2 headers are necessary. Signed-off-by: Alexey Dobriyan --- arch/x86/lib/clear_page_64.S |2 -- 1 file changed, 2 deletions(-) --- a/arch/x86/lib/clear_page_64.S +++ b/arch/x86/lib/clear_page_64.S @@ -1,6 +1,4 @@ #include -#include

Re: [PATCH v3 8/9] x86: use __uaccess_begin_nospec and ASM_IFENCE in get_user paths

2018-01-13 Thread Linus Torvalds
On Sat, Jan 13, 2018 at 10:18 AM, Dan Williams wrote: > diff --git a/arch/x86/lib/getuser.S b/arch/x86/lib/getuser.S > index c97d935a29e8..85f400b8ee7c 100644 > --- a/arch/x86/lib/getuser.S > +++ b/arch/x86/lib/getuser.S > @@ -41,6 +41,7 @@ ENTRY(__get_user_1) > cmp TASK_addr_limit(%_ASM_D

Re: [PATCH v2 00/19] prevent bounds-check bypass via speculative execution

2018-01-13 Thread Linus Torvalds
On Fri, Jan 12, 2018 at 4:15 PM, Tony Luck wrote: > > Here there isn't any reason for speculation. The core has the > value of 'x' in a register and the upper bound encoded into the > "cmp" instruction. Both are right there, no waiting, no speculation. So this is an argument I haven't seen befor

Re: stable/linux-3.16.y build: 178 builds: 1 failed, 177 passed, 2 errors, 57 warnings (v3.16.52)

2018-01-13 Thread Manfred Spraul
Hi Arnd, On 01/03/2018 12:15 AM, Arnd Bergmann wrote: 2 ipc/sem.c:377:6: warning: '___p1' may be used uninitialized in this function [-Wmaybe-uninitialized] This code was last touched in 3.16 by the backport of commit 5864a2fd3088 ("ipc/sem.c: fix complex_count vs. simple op race") The warn

[PATCH] x86_64: clobber flags in clear_page()

2018-01-13 Thread Alexey Dobriyan
All clear_page() implementations use XOR which resets flags. Judging by allyesconfig disassembly no code is affected. Signed-off-by: Alexey Dobriyan --- arch/x86/include/asm/page_64.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/arch/x86/include/asm/page_64.h +++ b/arch/x86/

Re: [PATCH 1/3] ARM: dts: rockchip: drop veyron's nonstandard 'backlight-boot-off'

2018-01-13 Thread Heiko Stuebner
Am Freitag, 5. Januar 2018, 16:47:55 CET schrieb Brian Norris: > This was used out-of-tree as a hack for resolving issues where some > systems expect the backlight to turn on automatically at boot, while > others expect to manage the backlight status via a DRM/panel driver. > Those issues have sinc

[PATCH] Remove structure passing and assignment to save stack and no coping structures.

2018-01-13 Thread Karim Eshapa
Signed-off-by: Karim Eshapa Thanks, Karim --- include/linux/tnum.h | 2 +- kernel/bpf/tnum.c | 13 +++-- kernel/bpf/verifier.c | 12 3 files changed, 16 insertions(+), 11 deletions(-) diff --git a/include/linux/tnum.h b/include/linux/tnum.h index 0d2d3da..ddb1250 1006

Re: [PATCH v5] perf tools: Add ARM Statistical Profiling Extensions (SPE) support

2018-01-13 Thread Arnaldo Carvalho de Melo
Em Fri, Jan 12, 2018 at 07:27:37PM -0600, Kim Phillips escreveu: > 'perf record' and 'perf report --dump-raw-trace' supported in this > release. > > Example usage: > > # perf record -e arm_spe/ts_enable=1,pa_enable=1/ dd if=/dev/zero > of=/dev/null count=1 > # perf report --dump-raw-trace

[PATCH v3 8/9] x86: use __uaccess_begin_nospec and ASM_IFENCE in get_user paths

2018-01-13 Thread Dan Williams
Quoting Linus: I do think that it would be a good idea to very expressly document the fact that it's not that the user access itself is unsafe. I do agree that things like "get_user()" want to be protected, but not because of any direct bugs or problems with get_user() and friends,

[PATCH v3 6/9] asm/nospec: mask speculative execution flows

2018-01-13 Thread Dan Williams
'__array_ptr' is proposed as a generic mechanism to mitigate against Spectre-variant-1 attacks, i.e. an attack that bypasses memory bounds checks via speculative execution). The '__array_ptr' implementation appears safe for current generation cpus across multiple architectures. In comparison, 'ife

[PATCH v3 7/9] x86: introduce __uaccess_begin_nospec and ASM_IFENCE

2018-01-13 Thread Dan Williams
For 'get_user' paths, do not allow the kernel to speculate on the value of a user controlled pointer. In addition to the 'stac' instruction for Supervisor Mode Access Protection, an 'ifence' causes the 'access_ok' result to resolve in the pipeline before the cpu might take any speculative action on

[PATCH v3 5/9] x86: implement ifence_array_ptr() and array_ptr_mask()

2018-01-13 Thread Dan Williams
'ifence_array_ptr' is provided as an alternative to the default '__array_ptr' implementation that uses a mask to sanitize user controllable pointers. Later patches will allow it to be selected via the kernel command line. The '__array_ptr' implementation otherwise appears safe for current generatio

[PATCH v3 9/9] vfs, fdtable: prevent bounds-check bypass via speculative execution

2018-01-13 Thread Dan Williams
Expectedly, static analysis reports that 'fd' is a user controlled value that is used as a data dependency to read from the 'fdt->fd' array. In order to avoid potential leaks of kernel memory values, block speculative execution of the instruction stream that could issue reads based on an invalid '

Re: [PATCH] kdump: Write a correct address of mem_section into vmcoreinfo

2018-01-13 Thread Kirill A. Shutemov
On Sat, Jan 13, 2018 at 11:48:38AM +0100, Ingo Molnar wrote: > > * Kirill A. Shutemov wrote: > > > Depending on configuration mem_section can now be an array or a pointer > > to an array allocated dynamically. In most cases, we can continue to refer > > to it as 'mem_section' regardless of what

[PATCH v3 0/9] core, x86: prevent bounds-check bypass via speculative execution

2018-01-13 Thread Dan Williams
Changes since v2 [1]: * style fix in Documentation/speculation.txt (Geert) * add Russell and Catalin to the cc on the ARM patches (Russell) * clarify changelog for "x86: introduce __uaccess_begin_nospec and ASM_IFENCE" (Eric, Linus, Josh) * fix the dynamic 'mask' / 'ifence' toggle vs CONFIG_JU

[PATCH v3 2/9] arm64: implement ifence_array_ptr()

2018-01-13 Thread Dan Williams
From: Mark Rutland This patch implements ifence_array_ptr() for arm64, using an LDR+CSEL+CSDB sequence to inhibit speculative use of the returned value. Signed-off-by: Mark Rutland Signed-off-by: Will Deacon Cc: Catalin Marinas Cc: Peter Zijlstra Signed-off-by: Dan Williams --- arch/arm64/

[PATCH v3 4/9] x86: implement ifence()

2018-01-13 Thread Dan Williams
The new barrier, 'ifence', ensures that speculative execution never crosses the fence. Previously the kernel only needed this fence in 'rdtsc_ordered', but now it is also proposed as a mitigation against Spectre variant1 attacks. When used it needs to be placed in the success path after a bounds c

[PATCH v3 3/9] arm: implement ifence_array_ptr()

2018-01-13 Thread Dan Williams
From: Mark Rutland This patch implements ifence_array_ptr() for arm, using an LDR+MOVCS+CSDB sequence to inhibit speculative use of the returned value. Cc: Russell King Signed-off-by: Mark Rutland Signed-off-by: Dan Williams --- arch/arm/include/asm/barrier.h | 24

[PATCH v3 1/9] Documentation: document array_ptr

2018-01-13 Thread Dan Williams
From: Mark Rutland Document the rationale and usage of the new array_ptr() helper. Signed-off-by: Mark Rutland Signed-off-by: Will Deacon Cc: Dan Williams Cc: Jonathan Corbet Cc: Peter Zijlstra Signed-off-by: Dan Williams --- Documentation/speculation.txt | 143 ++

Re: [PATCH] retpoline/module: Taint kernel for missing retpoline in module

2018-01-13 Thread Andi Kleen
> > Also what's the point of putting this information into every symbol? > > It makes it easy to check :) Easier than nm? Per symbol still doesn't make any sense to me. > > > Once per module is good enough. > > > > We already have similar checks for staging etc. > > Sure, but this is more of

Re: [PATCH 4.9] x86/pti/efi: broken conversion from efi to kernel page table

2018-01-13 Thread Greg KH
On Sat, Jan 13, 2018 at 12:40:10PM -0500, Pavel Tatashin wrote: > Hi Greg, > > Yeah, the one in pgtable.c needs to be removed, I wonder how it > compiled... I will submit a new patch for 4.9 sometime later. It builds, just gives a warning, easy to miss if you aren't looking for it :)

Re: [PATCH 4/8] irqchip/gic-v3: add ability to save/restore GIC/ITS state

2018-01-13 Thread Marc Zyngier
[I remember asking you to copy Sudeep Hola on this. Please do so the next time around] On Fri, 12 Jan 2018 21:24:18 +, Derek Basehore wrote: > > Some platforms power off GIC logic in S3, so we need to save/restore S3 is a not a GIC concept, and is only vaguely mentioned in terms of the rk339

Re: [PATCHSET v5] blk-mq: reimplement timeout handling

2018-01-13 Thread Ming Lei
On Sat, Jan 13, 2018 at 10:45:14PM +0800, Ming Lei wrote: > On Fri, Jan 12, 2018 at 04:55:34PM -0500, Laurence Oberman wrote: > > On Fri, 2018-01-12 at 20:57 +, Bart Van Assche wrote: > > > On Tue, 2018-01-09 at 08:29 -0800, Tejun Heo wrote: > > > > Currently, blk-mq timeout path synchronizes a

Re: [Cocci] [PATCH] Coccinelle: kzalloc-simple: Rename kzalloc-simple to zalloc-simple

2018-01-13 Thread Himanshu Jha
On Sat, Jan 13, 2018 at 03:02:10PM -0200, Fabio Estevam wrote: > On Sat, Jan 13, 2018 at 1:57 PM, Himanshu Jha > wrote: > > Rename kzalloc-simple to zalloc-simple since now the rule is not > > specific to kzalloc function only, but also to many other zero memory > > allocating functions specified

Re: [PATCH 4.9] x86/pti/efi: broken conversion from efi to kernel page table

2018-01-13 Thread Pavel Tatashin
Hi Greg, Yeah, the one in pgtable.c needs to be removed, I wonder how it compiled... I will submit a new patch for 4.9 sometime later. Thank you, Pavel On Sat, Jan 13, 2018 at 12:12 PM, Greg KH wrote: > On Thu, Jan 11, 2018 at 04:58:20PM -0500, Pavel Tatashin wrote: >> The page table order must

Re

2018-01-13 Thread Alex
-- Hello, I have a project i want to bring to you.. please respond for details Alex

  1   2   >