[PATCH 03/18] staging: gasket: typo and whitespace cleanups

2018-07-13 Thread Todd Poynor
From: Todd Poynor Trivial typo and whitespace fixes. Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/apex_driver.c | 2 +- drivers/staging/gasket/gasket_core.h | 2 +- drivers/staging/gasket/gasket_page_table.c | 2 +- 3 files changed, 3

[PATCH 00/18] staging: gasket: sundry fixes and fixups

2018-07-13 Thread Todd Poynor
From: Todd Poynor Various fixes mainly from the chromium review of the gasket and apex drivers. More to come. Various (18): staging: gasket: remove X86 Kconfig restriction MAINTAINERS: Add maintainer for drivers/staging/gasket staging: gasket: typo and whitespace cleanups staging:

[PATCH 01/18] staging: gasket: remove X86 Kconfig restriction

2018-07-13 Thread Todd Poynor
From: Todd Poynor The gasket and apex drivers are to be used on other architectures besides X86. Signed-off-by: Todd Poynor --- drivers/staging/gasket/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gasket/Kconfig b/drivers/staging/gasket/Kconfig

[PATCH 06/18] staging: gasket: fix deadlock in pci driver unregister path

2018-07-13 Thread Todd Poynor
From: Todd Poynor g_mutex held across pci_unregister_driver() call, also held in gasket_pci_remove(), which deadlocks. Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 7 ++- 1 file changed, 2 insertions(+), 5

[PATCH 04/18] staging: gasket: device registration error and unregister fixups

2018-07-13 Thread Todd Poynor
From: Todd Poynor Remove device registration on class creation fail. Hold mutex around device removal updates for proper ordering of updates. Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 8 +++- 1 file changed, 7 insertions(+), 1

[PATCH 02/18] MAINTAINERS: Add maintainer for drivers/staging/gasket

2018-07-13 Thread Todd Poynor
From: Todd Poynor Todd Poynor will be a maintainer of the Gasket and Apex drivers. Signed-off-by: Todd Poynor --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 562ee1e1cfd6..8f44e7bed49e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -5968,6

[PATCH 13/18] staging: gasket: gasket_enable_dev fixups

2018-07-13 Thread Todd Poynor
From: Todd Poynor Remove unnecessary variable. Bail out if no physical device. Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 19 ++- 1 file changed, 6 insertions(+), 13 deletions(-) diff --git a/drivers/staging/gasket/gasket_core.c

[PATCH 18/18] staging: gasket: various cleanups

2018-07-13 Thread Todd Poynor
From: Todd Poynor Cleanups to error codes, code style, error conditions, etc. Reported-by: Guenter Roeck Signed-off-by: Simon Que Signed-off-by: Todd Poynor --- drivers/staging/gasket/apex.h | 7 ++- drivers/staging/gasket/apex_driver.c | 50 -

[PATCH 11/18] staging: gasket: always allow root open for write

2018-07-13 Thread Todd Poynor
From: Todd Poynor Always allow root to open device for writing. Drop special-casing of ioctl permissions for root vs. owner. Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/apex_driver.c | 9 +++--

[PATCH 07/18] staging: gasket: convert gasket_mmap_has_permissions to bool return

2018-07-13 Thread Todd Poynor
From: Todd Poynor gasket_mmap_has_permissions() should return a boolean value. Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/gasket/gasket_core.c

[PATCH 09/18] staging: gasket: bail out of reset sequence on device callback error

2018-07-13 Thread Todd Poynor
From: Todd Poynor If device reset callback returns an error, error out at the gasket level. Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[PATCH 15/18] staging: gasket: remove unnecessary code in coherent allocator

2018-07-13 Thread Todd Poynor
From: Todd Poynor Remove extraneous statement in gasket_config_coherent_allocator() Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_ioctl.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git

[PATCH 12/18] staging: gasket: annotate ioctl arg with __user

2018-07-13 Thread Todd Poynor
From: Todd Poynor For sparse checking. Reported-by: Dmitry Torokhov Signed-off-by: Zhongze Hu Signed-off-by: Todd Poynor --- drivers/staging/gasket/apex_driver.c | 12 ++--- drivers/staging/gasket/gasket_core.c | 6 ++- drivers/staging/gasket/gasket_core.h | 4 +-

[PATCH 16/18] staging: gasket: gasket core error handling fixups

2018-07-13 Thread Todd Poynor
From: Todd Poynor Minor fixups to error codes and error handling in gasket core. No device reset callback registered is not an error condition. Signed-off-by: Simon Que Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_core.c | 13 + 1 file changed, 5 insertions(+), 8

[PATCH 17/18] staging: gasket: don't release coherent mappings

2018-07-13 Thread Todd Poynor
From: Todd Poynor coherent address mappings aren't backed by a struct page, don't need to be released, and don't count as an active page in the page table bookkeeping. Signed-off-by: Simon Que Signed-off-by: Todd Poynor --- drivers/staging/gasket/gasket_page_table.c | 2 +- 1 file changed, 1

Re: [PATCH 10/39] x86/entry/32: Handle Entry from Kernel-Mode on Entry-Stack

2018-07-13 Thread Joerg Roedel
On Fri, Jul 13, 2018 at 04:31:02PM -0700, Andy Lutomirski wrote: > What you're really doing is keeping it available for an extra flag. > Please update the comment as such. But see below. Thanks, will do. > > +.macro PARANOID_EXIT_TO_KERNEL_MODE > > + > > + /* > > +* Test if we

Re: [PATCH 39/39] x86/entry/32: Add debug code to check entry/exit cr3

2018-07-13 Thread Joerg Roedel
On Fri, Jul 13, 2018 at 10:28:50AM -0700, Andy Lutomirski wrote: > On Wed, Jul 11, 2018 at 4:29 AM, Joerg Roedel wrote: > > From: Joerg Roedel > > > > Add a config option that enabled code to check that we enter > > and leave the kernel with the correct cr3. This is needed > > because we have no

Re: [PATCH 38/39] x86/mm/pti: Add Warning when booting on a PCID capable CPU

2018-07-13 Thread Joerg Roedel
On Fri, Jul 13, 2018 at 11:59:44AM -0700, Andy Lutomirski wrote: > On Wed, Jul 11, 2018 at 4:29 AM, Joerg Roedel wrote: > > From: Joerg Roedel > > > > Warn the user in case the performance can be significantly > > improved by switching to a 64-bit kernel. > > ... > > > +#ifdef CONFIG_X86_32 >

Re: [PATCH 30/39] x86/mm/pti: Clone entry-text again in pti_finalize()

2018-07-13 Thread Joerg Roedel
On Fri, Jul 13, 2018 at 04:21:45PM -0700, Andy Lutomirski wrote: > On Wed, Jul 11, 2018 at 4:29 AM, Joerg Roedel wrote: > > From: Joerg Roedel > > > > The mapping for entry-text might have changed in the kernel > > after it was cloned to the user page-table. Clone again > > to update the user

Re: [PATCH] kconfig: remove EXPERT from CHECKPOINT_RESTORE

2018-07-13 Thread Kees Cook
On Fri, Jul 13, 2018 at 1:55 PM, Andrew Morton wrote: > On Thu, 12 Jul 2018 11:33:33 -0500 ebied...@xmission.com (Eric W. Biederman) > wrote: >> What is the value of disabling this functionality ever? >> >> Is there any reason why we don't just delete CONFIG_CHECKPOINT_RESTORE >> entirely? > >

Re: [PATCH] mmc: mxcmmc: Fix missing parentheses and brace

2018-07-13 Thread Randy Dunlap
On 07/12/2018 12:59 PM, Kees Cook wrote: > Looks like the adjusted syntax wasn't fully build tested. This fixes > failures with powerpc builds: > > drivers/mmc/host/mxcmmc.c: In function ‘mxcmci_swap_buffers’: > drivers/mmc/host/mxcmmc.c:296:51: error: expected ‘)’ before ‘;’ token >void *buf

Re: [PATCH 1/6] swap: Add comments to lock_cluster_or_swap_info()

2018-07-13 Thread Huang, Ying
Dave Hansen writes: >> +/* >> + * At most times, fine grained cluster lock is sufficient to protect > > Can we call out those times, please? To protect si->swap_map[], if HDD, si->lock is used, otherwise cluster lock is used. "at most times" is ambiguous here, I will fix it. >> + * the

Re: [PATCH v2 4/4] clk: qcom: Add graphics clock controller driver for SDM845

2018-07-13 Thread kbuild test robot
Hi Amit, Thank you for the patch! Yet something to improve: [auto build test ERROR on agross/for-next] [also build test ERROR on v4.18-rc4 next-20180713] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

Re: [PATCH v2] tools/memory-model: Add extra ordering for locks and remove it for ordinary release/acquire

2018-07-13 Thread Linus Torvalds
On Fri, Jul 13, 2018 at 6:51 PM Alan Stern wrote: > > The point being that the scenarios under discussion in this thread all > fall most definitely into the "Non-standard usage; you'd better know > exactly what you're doing" category. Well, yes and no. The thing is, people expected unlock+lock

Re: mmotm 2018-07-13-16-51 uploaded (PSI)

2018-07-13 Thread Stephen Rothwell
Hi all, On Fri, 13 Jul 2018 18:41:40 -0700 Randy Dunlap wrote: > > On 07/13/2018 04:51 PM, a...@linux-foundation.org wrote: > > The mm-of-the-moment snapshot 2018-07-13-16-51 has been uploaded to > > > >http://www.ozlabs.org/~akpm/mmotm/ > > > > mmotm-readme.txt says > > > > README for

Re: [PATCH v4 1/2] leds: core: Introduce generic pattern interface

2018-07-13 Thread Baolin Wang
Hi Jacek, On 14 July 2018 at 04:07, Jacek Anaszewski wrote: > Hi Baolin, > > Thank you for the update. > > > On 07/13/2018 08:21 AM, Baolin Wang wrote: >> >> From: Bjorn Andersson >> >> Some LED controllers have support for autonomously controlling >> brightness over time, according to some

RE: [RFC] x86, tsc: Add kcmdline args for skipping tsc calibration sequences

2018-07-13 Thread Brown, Len
We disabled CPUID-based TSC calibration on SKX in December for several reasons. If you still have it enabled, you need this patch: commit b511203093489eb1829cb4de86e8214752205ac6 x86/tsc: Fix erroneous TSC rate on Skylake Xeon If you are referring to another platform that has CPUID-TSC

Re: Kernel 4.17.4 lockup

2018-07-13 Thread Andy Lutomirski
I'm not at all convinced that this is the problem, but the series here will give a better diagnostic if the issue really is an IRQ stack overflow: https://git.kernel.org/pub/scm/linux/kernel/git/luto/linux.git/log/?h=x86/guard_pages (link currently broken. should work soon.)

[PATCH V2] ARM: dts: imx6sl-evk: add missing GPIO iomux setting

2018-07-13 Thread Anson Huang
On i.MX6SL EVK board, the MX6SL_PAD_KEY_ROW5 pin is used as lcd 3v3 regulator control pin, need to make sure MX6SL_PAD_KEY_ROW5 is muxed as GPIO function for controlling lcd 3v3 regulator. Signed-off-by: Anson Huang --- change since V1: using a separate pin group for lcd regulator

RE: [PATCH] gpio: mxc: add power management support

2018-07-13 Thread Anson Huang
Hi, Fabio Anson Huang Best Regards! > -Original Message- > From: Fabio Estevam [mailto:feste...@gmail.com] > Sent: Saturday, July 14, 2018 2:34 AM > To: Anson Huang > Cc: Linus Walleij ; open list:GPIO SUBSYSTEM > ; linux-kernel ; > dl-linux-imx > Subject: Re: [PATCH] gpio: mxc: add

Re: [PATCH v2] tools/memory-model: Add extra ordering for locks and remove it for ordinary release/acquire

2018-07-13 Thread Alan Stern
On Fri, 13 Jul 2018, Andrea Parri wrote: > On Fri, Jul 13, 2018 at 10:16:48AM -0700, Linus Torvalds wrote: > > On Fri, Jul 13, 2018 at 2:34 AM Will Deacon wrote: > > > > > > And, since we're stating preferences, I'll reiterate my preference > > > towards: > > > > > > * RCsc unlock/lock

[PATCH v9 1/2] regulator: dt-bindings: add QCOM RPMh regulator bindings

2018-07-13 Thread David Collins
Introduce bindings for RPMh regulator devices found on some Qualcomm Technlogies, Inc. SoCs. These devices allow a given processor within the SoC to make PMIC regulator requests which are aggregated within the RPMh hardware block along with requests from other processors in the SoC to determine

[PATCH v9 2/2] regulator: add QCOM RPMh regulator driver

2018-07-13 Thread David Collins
Add the QCOM RPMh regulator driver to manage PMIC regulators which are controlled via RPMh on some Qualcomm Technologies, Inc. SoCs. RPMh is a hardware block which contains several accelerators which are used to manage various hardware resources that are shared between the processors of the SoC.

[PATCH v9 0/2] regulator: add QCOM RPMh regulator driver

2018-07-13 Thread David Collins
This patch series adds a driver and device tree binding documentation for PMIC regulator control via Resource Power Manager-hardened (RPMh) on some Qualcomm Technologies, Inc. SoCs such as SDM845. RPMh is a hardware block which contains several accelerators which are used to manage various

Re: mmotm 2018-07-13-16-51 uploaded (PSI)

2018-07-13 Thread Randy Dunlap
On 07/13/2018 04:51 PM, a...@linux-foundation.org wrote: > The mm-of-the-moment snapshot 2018-07-13-16-51 has been uploaded to > >http://www.ozlabs.org/~akpm/mmotm/ > > mmotm-readme.txt says > > README for mm-of-the-moment: > > http://www.ozlabs.org/~akpm/mmotm/ > > This is a snapshot of

Re: [PATCH v2 4/4] clk: qcom: Add graphics clock controller driver for SDM845

2018-07-13 Thread kbuild test robot
Hi Amit, Thank you for the patch! Yet something to improve: [auto build test ERROR on agross/for-next] [also build test ERROR on v4.18-rc4 next-20180713] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux

Re: [patch 0/7] x86/kvmclock: Remove memblock dependency and further cleanups

2018-07-13 Thread Pavel Tatashin
On 07/13/2018 06:51 PM, Thomas Gleixner wrote: > On Wed, 11 Jul 2018, Pavel Tatashin wrote: > >>> So this still will have some overhead when kvmclock is not in use, but >>> bringing it down to zero would be a massive trainwreck and even more >>> indirections. >> >> Hi Thomas, >> >> In my

Re: [PATCH] get_maintainer.pl: Add optional .get_maintainer.MAINTAINERS override

2018-07-13 Thread Joe Perches
On Fri, 2018-07-13 at 14:51 -0400, Don Zickus wrote: > On Fri, Jul 06, 2018 at 03:14:28PM -0700, Joe Perches wrote: > > On Fri, 2018-07-06 at 15:09 -0700, Joe Perches wrote: > > > On Fri, 2018-07-06 at 17:58 -0400, Don Zickus wrote: > > > > We have an internal use case of multiple MAINTAINER

Re: [PATCH] checkpatch: Require commit text and warn on long commit text lines

2018-07-13 Thread Joe Perches
On Fri, 2018-07-13 at 16:28 -0700, pher...@codeaurora.org wrote: > On 2018-07-13 14:46, Joe Perches wrote: > > On Fri, 2018-07-13 at 14:40 -0700, Prakruthi Deepak Heragu wrote: > > > Commit text is almost always necessary to explain why a change is > > > needed. > > > > This bit seems sensible,

mmotm 2018-07-13-16-51 uploaded

2018-07-13 Thread akpm
The mm-of-the-moment snapshot 2018-07-13-16-51 has been uploaded to http://www.ozlabs.org/~akpm/mmotm/ mmotm-readme.txt says README for mm-of-the-moment: http://www.ozlabs.org/~akpm/mmotm/ This is a snapshot of my -mm patch queue. Uploaded at random hopefully more than once a week. You

[PATCH] IB/mlx5: avoid binding a new mpi unit to the same devices repeatedly

2018-07-13 Thread Qing Huang
When a CX5 device is configured in dual-port RoCE mode, after creating many VFs against port 1, creating the same number of VFs against port 2 will flood kernel/syslog with something like "mlx5_*:mlx5_ib_bind_slave_port:4266:(pid 5269): port 2 already affiliated." So basically, when traversing

Re: [RFC PATCH 10/10] psi: aggregate ongoing stall events when somebody reads pressure

2018-07-13 Thread Suren Baghdasaryan
On Fri, Jul 13, 2018 at 3:49 PM, Johannes Weiner wrote: > On Fri, Jul 13, 2018 at 03:13:07PM -0700, Suren Baghdasaryan wrote: >> On Thu, Jul 12, 2018 at 10:29 AM, Johannes Weiner wrote: >> > might want to know about and react to stall states before they have >> > even concluded (e.g. a prolonged

Re: [PATCH 10/39] x86/entry/32: Handle Entry from Kernel-Mode on Entry-Stack

2018-07-13 Thread Andy Lutomirski
On Wed, Jul 11, 2018 at 4:29 AM, Joerg Roedel wrote: > From: Joerg Roedel > > It can happen that we enter the kernel from kernel-mode and > on the entry-stack. The most common way this happens is when > we get an exception while loading the user-space segment > registers on the

Re: [PATCH] checkpatch: Require commit text and warn on long commit text lines

2018-07-13 Thread pheragu
On 2018-07-13 14:46, Joe Perches wrote: On Fri, 2018-07-13 at 14:40 -0700, Prakruthi Deepak Heragu wrote: Commit text is almost always necessary to explain why a change is needed. This bit seems sensible, but perhaps it should just count the number of lines after the end of email headers and

Re: [PATCH 28/39] x86/mm/pti: Keep permissions when cloning kernel text in pti_clone_kernel_text()

2018-07-13 Thread Andy Lutomirski
On Wed, Jul 11, 2018 at 4:29 AM, Joerg Roedel wrote: > From: Joerg Roedel > > Mapping the kernel text area to user-space makes only sense > if it has the same permissions as in the kernel page-table. > If permissions are different this will cause a TLB reload > when using the kernel page-table,

Re: [PATCH 30/39] x86/mm/pti: Clone entry-text again in pti_finalize()

2018-07-13 Thread Andy Lutomirski
On Wed, Jul 11, 2018 at 4:29 AM, Joerg Roedel wrote: > From: Joerg Roedel > > The mapping for entry-text might have changed in the kernel > after it was cloned to the user page-table. Clone again > to update the user page-table to bring the mapping in sync > with the kernel again. Can't we just

Re: [PATCH 35/39] x86/ldt: Split out sanity check in map_ldt_struct()

2018-07-13 Thread Andy Lutomirski
On Wed, Jul 11, 2018 at 4:29 AM, Joerg Roedel wrote: > From: Joerg Roedel > > This splits out the mapping sanity check and the actual > mapping of the LDT to user-space from the map_ldt_struct() > function in a way so that it is re-usable for PAE paging. > Reviewed-by: Andy Lutomirski

Re: [PATCH 03/39] x86/entry/32: Load task stack from x86_tss.sp1 in SYSENTER handler

2018-07-13 Thread Andy Lutomirski
On Fri, Jul 13, 2018 at 10:19 AM, Andy Lutomirski wrote: > On Fri, Jul 13, 2018 at 2:48 AM, Joerg Roedel wrote: >> On Thu, Jul 12, 2018 at 01:49:13PM -0700, Andy Lutomirski wrote: >>> > On Jul 11, 2018, at 4:29 AM, Joerg Roedel wrote: >>> >/* Offset from the sysenter stack to tss.sp0 */ >>>

[patch v3 -mm 5/6] mm, memcg: separate oom_group from selection criteria

2018-07-13 Thread David Rientjes
With the current implementation of the cgroup-aware oom killer, memory.oom_group defines two behaviors: - consider the footprint of the "group" consisting of the mem cgroup itself and all descendants for comparison with other cgroups, and - when selected as the victim mem cgroup, kill all

[patch v3 -mm 3/6] mm, memcg: add hierarchical usage oom policy

2018-07-13 Thread David Rientjes
One of the three significant concerns brought up about the cgroup aware oom killer is that its decisionmaking is completely evaded by creating subcontainers and attaching processes such that the ancestor's usage does not exceed another cgroup on the system. Consider the example from the previous

[patch v3 -mm 0/6] rewrite cgroup aware oom killer for general use

2018-07-13 Thread David Rientjes
and extends it to be generally useful outside of very specialized usecases. It eliminates the mount option for the cgroup aware oom killer entirely since it is now enabled through the root mem cgroup's oom policy. --- v3: - Rebased to next-20180713 v2: - Rebased to next-20180322 - Fixed

[patch v3 -mm 2/6] mm, memcg: replace cgroup aware oom killer mount option with tunable

2018-07-13 Thread David Rientjes
Now that each mem cgroup on the system has a memory.oom_policy tunable to specify oom kill selection behavior, remove the needless "groupoom" mount option that requires (1) the entire system to be forced, perhaps unnecessarily, perhaps unexpectedly, into a single oom policy that differs from the

[patch v3 -mm 6/6] mm, memcg: disregard mempolicies for cgroup-aware oom killer

2018-07-13 Thread David Rientjes
The cgroup-aware oom killer currently considers the set of allowed nodes for the allocation that triggers the oom killer and discounts usage from disallowed nodes when comparing cgroups. If a cgroup has both the cpuset and memory controllers enabled, it may be possible to restrict allocations to

[patch v3 -mm 1/6] mm, memcg: introduce per-memcg oom policy tunable

2018-07-13 Thread David Rientjes
The cgroup aware oom killer is needlessly enforced for the entire system by a mount option. It's unnecessary to force the system into a single oom policy: either cgroup aware, or the traditional process aware. This patch introduces a memory.oom_policy tunable for all mem cgroups. It is currently

[patch v3 -mm 4/6] mm, memcg: evaluate root and leaf memcgs fairly on oom

2018-07-13 Thread David Rientjes
There are several downsides to the current implementation that compares the root mem cgroup with leaf mem cgroups for the cgroup-aware oom killer. For example, /proc/pid/oom_score_adj is accounted for processes attached to the root mem cgroup but not leaves. This leads to wild inconsistencies

Re: [patch 0/7] x86/kvmclock: Remove memblock dependency and further cleanups

2018-07-13 Thread Thomas Gleixner
On Wed, 11 Jul 2018, Pavel Tatashin wrote: > > So this still will have some overhead when kvmclock is not in use, but > > bringing it down to zero would be a massive trainwreck and even more > > indirections. > > Hi Thomas, > > In my opinion, having kvmclock page in __initdata for boot cpu,

x86/events/intel/ds: Fix bts_interrupt_threshold alignment

2018-07-13 Thread Hugh Dickins
Markus reported that BTS is sporadically missing the tail of the trace in the perf_event data buffer: [decode error (1): instruction overflow] shown in GDB; and bisected it to the conversion of debug_store to PTI. A little "optimization" crept into alloc_bts_buffer(), which mistakenly placed

Re: [RFC PATCH 10/10] psi: aggregate ongoing stall events when somebody reads pressure

2018-07-13 Thread Johannes Weiner
On Fri, Jul 13, 2018 at 03:13:07PM -0700, Suren Baghdasaryan wrote: > On Thu, Jul 12, 2018 at 10:29 AM, Johannes Weiner wrote: > > might want to know about and react to stall states before they have > > even concluded (e.g. a prolonged reclaim cycle). > > > > This patches the procfs/cgroupfs

Re: [PATCH 1/3] clocksource: drivers: set clockevent device cpumask to cpu_possible_mask

2018-07-13 Thread Thomas Gleixner
On Wed, 11 Jul 2018, Daniel Lezcano wrote: > On 11/07/2018 15:42, Sudeep Holla wrote: > > Hi Daniel, > > > > On 11/07/18 12:36, Daniel Lezcano wrote: > >> On 11/07/2018 13:24, Sudeep Holla wrote: > >>> Currently, quite a few clockevent devices have cpumask set to > >>> cpu_all_mask which should

Re: [PATCH] i2c: i2c-qcom-geni: Fix suspend clock handling

2018-07-13 Thread Evan Green
On Fri, Jul 13, 2018 at 3:21 PM Karthik Ramasubramanian wrote: > > > > On 7/9/2018 5:49 PM, Evan Green wrote: > > pm_runtime_suspended can return 0 even if the last runtime power > > management function called in the device was a suspend call. This > > trips up the i2c-qcom-geni's suspend_noirq

Re: [PATCH v13 2/2] Add oom victim's memcg to the oom context information

2018-07-13 Thread David Rientjes
On Fri, 13 Jul 2018, ufo19890...@gmail.com wrote: > diff --git a/mm/oom_kill.c b/mm/oom_kill.c > index 531b2c86d4db..7fbd389ea779 100644 > --- a/mm/oom_kill.c > +++ b/mm/oom_kill.c > @@ -434,10 +434,11 @@ static void dump_header(struct oom_control *oc, struct > task_struct *p) >

Re: [PATCH] i2c: i2c-qcom-geni: Fix suspend clock handling

2018-07-13 Thread Karthik Ramasubramanian
On 7/9/2018 5:49 PM, Evan Green wrote: > pm_runtime_suspended can return 0 even if the last runtime power > management function called in the device was a suspend call. This > trips up the i2c-qcom-geni's suspend_noirq accounting, which was > trying to use the function to determine if it should

Re: [PATCH v4] cpufreq / CPPC: Add cpuinfo_cur_freq support for CPPC

2018-07-13 Thread Prakash, Prashanth
Hi George, This version looks good. Thanks! On 7/12/2018 12:07 AM, George Cherian wrote: > Per Section 8.4.7.1.3 of ACPI 6.2, The platform provides performance > feedback via set of performance counters. To determine the actual > performance level delivered over time, OSPM may read a set of >

Re: [RFC PATCH 10/10] psi: aggregate ongoing stall events when somebody reads pressure

2018-07-13 Thread Johannes Weiner
On Thu, Jul 12, 2018 at 04:45:37PM -0700, Andrew Morton wrote: > On Thu, 12 Jul 2018 13:29:42 -0400 Johannes Weiner wrote: > > > Right now, psi reports pressure and stall times of already concluded > > stall events. For most use cases this is current enough, but certain > > highly

Re: [RFC PATCH 10/10] psi: aggregate ongoing stall events when somebody reads pressure

2018-07-13 Thread Suren Baghdasaryan
On Thu, Jul 12, 2018 at 10:29 AM, Johannes Weiner wrote: > Right now, psi reports pressure and stall times of already concluded > stall events. For most use cases this is current enough, but certain > highly latency-sensitive applications, like the Android OOM killer, to be more precise, it's

Re: [PATCH 0/10] psi: pressure stall information for CPU, memory, and IO v2

2018-07-13 Thread Johannes Weiner
On Thu, Jul 12, 2018 at 04:44:22PM -0700, Andrew Morton wrote: > On Thu, 12 Jul 2018 13:29:32 -0400 Johannes Weiner wrote: > > > > > ... > > > > The io file is similar to memory. Because the block layer doesn't have > > a concept of hardware contention right now (how much longer is my IO > >

Re: [PATCH RT v2] arm64: fpsimd: use a local_lock() in addition to local_bh_disable()

2018-07-13 Thread Mike Galbraith
On Fri, 2018-07-13 at 19:49 +0200, Sebastian Andrzej Siewior wrote: > In v4.16-RT I noticed a number of warnings from task_fpsimd_load(). The > code disables BH and expects that it is not preemptible. On -RT the > task remains preemptible but remains the same CPU. This may corrupt the > content of

Re: unexpected kernel reboot (3)

2018-07-13 Thread Andrew Morton
On Fri, 13 Jul 2018 14:39:02 -0700 syzbot wrote: > Hello, > > syzbot found the following crash on: hm, I don't think I've seen an "unexpected reboot" report before. Can you expand on specifically what happened here? Did the machine simply magically reboot itself? Or did an external monitor

[PATCH v10 1/3] lockdep: use this_cpu_ptr instead of get_cpu_var stats

2018-07-13 Thread Joel Fernandes
From: "Joel Fernandes (Google)" get_cpu_var disables preemption which has the potential to call into the preemption disable trace points causing some complications. There's also no need to disable preemption in uses of get_lock_stats anyway since preempt is already disabled. So lets simplify the

[PATCH v10 0/3] tracing: Centralize preemptirq tracepoints and unify their usage

2018-07-13 Thread Joel Fernandes
From: "Joel Fernandes (Google)" This series contains the last 2 patches of the previous series, with minor changes suggested by Peter and Steven, and an additional patch for get_lock_stats cleanup suggested by Peter. The preempt/irq tracepoints exist but not everything in the kernel is using it

[PATCH v10 3/3] tracing: Centralize preemptirq tracepoints and unify their usage

2018-07-13 Thread Joel Fernandes
From: "Joel Fernandes (Google)" This patch detaches the preemptirq tracepoints from the tracers and keeps it separate. Advantages: * Lockdep and irqsoff event can now run in parallel since they no longer have their own calls. * This unifies the usecase of adding hooks to an irqsoff and irqson

[PATCH v10 2/3] tracepoint: Make rcuidle tracepoint callers use SRCU

2018-07-13 Thread Joel Fernandes
From: "Joel Fernandes (Google)" In recent tests with IRQ on/off tracepoints, a large performance overhead ~10% is noticed when running hackbench. This is root caused to calls to rcu_irq_enter_irqson and rcu_irq_exit_irqson from the tracepoint code. Following a long discussion on the list [1]

Re: [PATCH v4] regulator: fixed: Convert to use GPIO descriptor only

2018-07-13 Thread Janusz Krzysztofik
Hi Linus, On Friday, July 13, 2018 9:35:06 AM CEST Linus Walleij wrote: > On Tue, Jul 10, 2018 at 7:56 PM Janusz Krzysztofik wrote: > > > - .gpio = AMS_DELTA_GPIO_PIN_MODEM_NRESET, > > > > This is OK but not enough for clean build of board-ams-delta.c when merged > > into

Re: [PATCH] checkpatch: Require commit text and warn on long commit text lines

2018-07-13 Thread Joe Perches
On Fri, 2018-07-13 at 14:40 -0700, Prakruthi Deepak Heragu wrote: > Commit text is almost always necessary to explain why a change is needed. This bit seems sensible, but perhaps it should just count the number of lines after the end of email headers and before any Signed-off-by:/Signature line

[PATCH] checkpatch: Require commit text and warn on long commit text lines

2018-07-13 Thread Prakruthi Deepak Heragu
Commit text is almost always necessary to explain why a change is needed. Also, warn on commit text lines longer than 75 characters. The commit text are indented and may wrap on a terminal if they are longer than 75 characters. Signed-off-by: David Keitel Signed-off-by: Prakruthi Deepak Heragu

unexpected kernel reboot (3)

2018-07-13 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:1e4b044d2251 Linux 4.18-rc4 git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=17c6a6d040 kernel config: https://syzkaller.appspot.com/x/.config?x=25856fac4e580aa7 dashboard link:

Re: [patch -mm] mm, oom: remove oom_lock from exit_mmap

2018-07-13 Thread Tetsuo Handa
On 2018/07/13 23:26, Michal Hocko wrote: > On Thu 12-07-18 14:34:00, David Rientjes wrote: > [...] >> diff --git a/mm/oom_kill.c b/mm/oom_kill.c >> index 0fe4087d5151..e6328cef090f 100644 >> --- a/mm/oom_kill.c >> +++ b/mm/oom_kill.c >> @@ -488,9 +488,11 @@ void __oom_reap_task_mm(struct mm_struct

Re: [GIT PULL] arm64 fixes for 4.18-rc5

2018-07-13 Thread Harald Arnesen
Linus Torvalds [2018-07-13 20:51]: > On Fri, Jul 13, 2018 at 6:13 AM Will Deacon wrote: >> >> Catalin's out enjoying the sunshine, so I'm sending the fixes for a couple >> of weeks (although there hopefully won't be any more!). > > Never fear, I'm sure there won't be more than a couple of weeks

Re: [PATCH v3] iio: chemical: Add support for Bosch BME680 sensor

2018-07-13 Thread David Frey
Hi Himanshu Jha, First a bit of background. I'm working on a device which will contain a bme680 sensor. A colleague of mine started work on a Linux kernel driver for the chip a little while ago. The (WIP) driver can be found here:

[PATCH] io_submit.2: Add IOCB_FLAG_IOPRIO

2018-07-13 Thread adam . manzanares
From: Adam Manzanares The newly added IOCB_FLAG_IOPRIO aio_flag introduces new behaviors and return values. The details of this new feature are posted here: https://lkml.org/lkml/2018/5/22/809 Signed-off-by: Adam Manzanares --- man2/io_submit.2 | 34 +++--- 1 file

Re: [PATCH] kconfig: remove EXPERT from CHECKPOINT_RESTORE

2018-07-13 Thread Andrew Morton
On Thu, 12 Jul 2018 11:33:33 -0500 ebied...@xmission.com (Eric W. Biederman) wrote: > > Adrian Reber writes: > > > The CHECKPOINT_RESTORE configuration option was introduced in 2012 and > > combined with EXPERT. CHECKPOINT_RESTORE is already enabled in many > > distribution kernels and also

Re: [PATCH v1 2/2] mm: soft-offline: close the race against page allocation

2018-07-13 Thread Andrew Morton
On Fri, 13 Jul 2018 12:26:06 +0900 Naoya Horiguchi wrote: > A process can be killed with SIGBUS(BUS_MCEERR_AR) when it tries to > allocate a page that was just freed on the way of soft-offline. > This is undesirable because soft-offline (which is about corrected error) > is less aggressive than

Re: [PATCH] i2c: aspeed: Adjust spinlock scope in the irq handler

2018-07-13 Thread Jae Hyun Yoo
On 7/13/2018 1:33 PM, Wolfram Sang wrote: BTW, to whom should I ask applying this patch? Should I send v2 after adding your reviewed-by tag? Not needed, thanks. I use 'patchwork' and this tool collects all the tags for me. If I see a patch reviewed by a driver maintainer, I'll pick it up in

Re: [PATCH v1 1/2] mm: fix race on soft-offlining free huge pages

2018-07-13 Thread Andrew Morton
On Fri, 13 Jul 2018 12:26:05 +0900 Naoya Horiguchi wrote: > There's a race condition between soft offline and hugetlb_fault which > causes unexpected process killing and/or hugetlb allocation failure. > > The process killing is caused by the following flow: > > CPU 0 CPU 1

[PULL REQUEST] i2c for 4.18

2018-07-13 Thread Wolfram Sang
Linus, I2C has for you: - one I2C core bugfix regarding bus recovery - one driver bugfix for the tegra driver - one typo correction Please pull. Thanks, Wolfram The following changes since commit 021c91791a5e7e85c567452f1be3e4c2c6cb6063: Linux 4.18-rc3 (2018-07-01 16:04:53 -0700) are

Re: [PATCH] i2c: aspeed: Adjust spinlock scope in the irq handler

2018-07-13 Thread Wolfram Sang
> BTW, to whom should I ask applying this patch? Should I send v2 after > adding your reviewed-by tag? Not needed, thanks. I use 'patchwork' and this tool collects all the tags for me. If I see a patch reviewed by a driver maintainer, I'll pick it up in the next queue. signature.asc

Re: [PATCH 6/6] swap, put_swap_page: Share more between huge/normal code path

2018-07-13 Thread Daniel Jordan
On Fri, Jul 13, 2018 at 07:36:36AM +0800, Huang, Ying wrote: > From: Huang Ying > > In this patch, locking related code is shared between huge/normal code > path in put_swap_page() to reduce code duplication. And `free_entries > == 0` case is merged into more general `free_entries != >

Re: [PATCH 3/6] swap: Unify normal/huge code path in swap_page_trans_huge_swapped()

2018-07-13 Thread Daniel Jordan
On Fri, Jul 13, 2018 at 07:36:33AM +0800, Huang, Ying wrote: > diff --git a/mm/swapfile.c b/mm/swapfile.c > index 75c84aa763a3..160f78072667 100644 > --- a/mm/swapfile.c > +++ b/mm/swapfile.c > @@ -270,7 +270,10 @@ static inline void cluster_set_null(struct > swap_cluster_info *info) > >

[PATCH 01/10] staging:rtl8192u: remove typedef of enumeration TR_SELECT - Style

2018-07-13 Thread John Whitmore
To clear a checkpatch issue removed the typedef of the enumeration TR_SELECT this should not impact runtime code as it's only a coding style change. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/ieee80211.h | 4 ++--

[PATCH 03/10] staging:rtl8192u: Rename List > list - Coding style

2018-07-13 Thread John Whitmore
In struct TS_COMMON_INFO rename the member List to list. This clears the checkpatch issue concerning CamelCase naming of variables. Signed-off-by: John Whitmore --- .../staging/rtl8192u/ieee80211/rtl819x_TS.h | 2 +- .../rtl8192u/ieee80211/rtl819x_TSProc.c | 64 +-- 2

[PATCH 04/10] staging:rtl8192u: rename SetupTimer > setup_timer - Style

2018-07-13 Thread John Whitmore
Rename the struct TS_COMMON_INFO member SetupTimer to setup_timer. This clears the checkpatch issue with CamelCase variable names. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h | 2 +- drivers/staging/rtl8192u/ieee80211/rtl819x_TSProc.c | 8 2

[PATCH 09/10] staging:trl8192u: Rename TClasProc > t_clas_proc - Style

2018-07-13 Thread John Whitmore
Rename the struct TS_COMMON_INFO member variable TClasProc to t_clas_proc. This change clears the checkpatch issue with CamelCase variable names. There should be no impact on runtime execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h | 2 +-

[PATCH 10/10] staging:rtl8192u: Rename TClasNum > t_clas_num - Style

2018-07-13 Thread John Whitmore
Rename the struct TS_COMMON_INFO member variable TClasNum to t_clas_num. This change clears the checkpatch issue with CamelCase naming. There should be no impact on runtime execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h | 2 +-

[PATCH 07/10] staging:rtl8192u: Rename TSpec > t_spec - Style

2018-07-13 Thread John Whitmore
Rename the TS_COMMON_INFO structure's member TSpec to t_spec. This change clears the checkpatch issue with CamelCase naming of variables. There should be no impact on runtime execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c | 2 +-

[PATCH 08/10] staging:rtl8192u: Rename TClass > t_class - Style

2018-07-13 Thread John Whitmore
Rename the struct TS_COMMON_INFO member variable from TClass to t_class. This change clears the checkpatch issue with CamelCase Variable names. There should be no impact on runtime execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h | 2 +-

[PATCH 02/10] staging:rtl8192u: remove typedef of struct TS_COMMON_INFO - Style

2018-07-13 Thread John Whitmore
To clear a checkpatch issue removed the typedef of the structure TS_COMMON_INFO. This change removes the previous declaration, which defined two types, both TS_COMMON_INFO and a pointer type PTS_COMMON_INFO: typedef struct _TS_COMMON_INFO { ... } TS_COMMON_INFO, *PTS_COMMON_INFO; The

Re: KASAN: null-ptr-deref Read in smc_ioctl

2018-07-13 Thread Byoungyoung Lee
Attached C repro code as well as its kernel config. It takes about 10-30 seconds to reproduce. C repro: https://kiwi.cs.purdue.edu/static/race-fuzzer/null-ptr-deref-smc_ioctl.c kernel config (v4.18-rc3): https://kiwi.cs.purdue.edu/static/race-fuzzer/null-ptr-deref-smc_ioctl.c [ 172.890255]

[PATCH 06/10] staging:rtl8192u: Rename Addr > addr - Style

2018-07-13 Thread John Whitmore
Rename the TX_COMMON_INFO structure's member Addr to addr. This change clears the checkpatch issue with CamelCase naming. This is a coding style change only and should not impact runtime execution. Signed-off-by: John Whitmore --- .../staging/rtl8192u/ieee80211/rtl819x_BAProc.c| 10

[PATCH 05/10] staging:rtl8192u: Rename InactTimer > inact_timer - Style

2018-07-13 Thread John Whitmore
Rename the struct TS_COMMON_INFO member InactTimer to inact_timer. This change clears the checkpatch issue with CamelCase naming. The change should not have any impact on runtime execution. Signed-off-by: John Whitmore --- drivers/staging/rtl8192u/ieee80211/rtl819x_TS.h | 2 +-

staging:rtl8192u: [0/10] Coding style changes.

2018-07-13 Thread John Whitmore
All coding style changes, but the second [2/10] is a bit more hairy then most. The original code combined two typedef declarations into one with both the structure and a pointer to the structure defined. I've totally removed the pointer to the structure type since it uses Hungarian notation, which

  1   2   3   4   5   >