Hello Lee & All others,
I'm physically back from my vacations so I can once again reach the
keyboard. So it's time to try address these issues =)
On Thu, Jul 12, 2018 at 02:00:13PM +0100, Lee Jones wrote:
> On Thu, 05 Jul 2018, Matti Vaittinen wrote:
>
> > + ret = regmap_read(bd71837->regmap,
On Mon, 30 Jul 2018 at 03:39, Linus Torvalds
wrote:
>
> So unless something odd happens, this should be the last rc for 4.18.
>
> Nothing particularly odd happened this last week - we got the usual
> random set of various minor fixes all over. About two thirds of it is
> drivers - networking, stag
On 29.7.2018 03:38, Masahiro Yamada wrote:
> machine_early_init is defined in arch/microblaze/kernel/setup.c
> I do not see mach-* directory for MicroBlaze.
>
> Signed-off-by: Masahiro Yamada
> ---
>
> arch/microblaze/kernel/head.S | 5 -
> 1 file changed, 5 deletions(-)
>
> diff --git a/a
Dear Sir/ Madam,
It's really nice to come across your e-mail contact from International Business
Directory, then i decided to contact you hoping that meeting you here will be a
good step for a beautiful future business relationship and Partnership under
your management.
I am Dr. Abdullah Al-Th
Hi Stephen,
On 2018/7/30 14:16, Stephen Rothwell wrote:
> Hi Greg,
>
> After merging the staging tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> drivers/staging/erofs/super.c: In function 'erofs_read_super':
> drivers/staging/erofs/super.c:343:17: error: 'MS_RDONLY'
The fix in commit 0cbb4b4f4c44 ("userfaultfd: clear the
vma->vm_userfaultfd_ctx if UFFD_EVENT_FORK fails") cleared the
vma->vm_userfaultfd_ctx but kept userfaultfd flags in vma->vm_flags that
were copied from the parent process VMA.
As the result, there is an inconsistency between the values of
vm
Thanks a lot, Steven.
---
Best wishes
Yi Wang
Original Mail
Sender: StevenRostedt
To: Wang Yi10129963;
CC: t...@linutronix.de mi...@redhat.com
h...@zytor.com x...@kernel.org
douly.f...@cn.fujitsu.com
jgr...@suse.com
ville.syrj...@linux.intel.com
len.br...@intel.com
linux
Add ACPI support to all IPROC SDHCI varients
Signed-off-by: Srinath Mannam
Reviewed-by: Ray Jui
Reviewed-by: Scott Branden
Reviewed-by: Vladimir Olovyannikov
---
drivers/mmc/host/Kconfig | 1 +
drivers/mmc/host/sdhci-iproc.c | 63 +-
2 files chan
This patch series adds
- Feature to get generic device properties in the
place of DT properties.
- ACPI support to IPROC SDHCI varients
This patch series is based off v4.18-rc3
Changes from v2:
- Added patch "Convert DT properties to generic device properties"
given by Adrian Hunter
From: Adrian Hunter
Convert DT properties to generic device properties
so that drivers can get properties from DT or ACPI.
Signed-off-by: Adrian Hunter
Tested-by: Srinath Mannam
---
drivers/mmc/host/sdhci-pltfm.c | 68 +-
drivers/mmc/host/sdhci-pltfm.h
Hi Greg,
After merging the staging tree, today's linux-next build (x86_64
allmodconfig) failed like this:
drivers/staging/erofs/super.c: In function 'erofs_read_super':
drivers/staging/erofs/super.c:343:17: error: 'MS_RDONLY' undeclared (first use
in this function); did you mean 'IS_RDONLY'?
s
Any updates on this?
On Wed, Jul 04, 2018 at 04:18:12PM +0300, Mike Rapoport wrote:
> These patches switch nios2 boot time memory allocators from bootmem to
> memblock + no_bootmem.
>
> As nios2 uses fdt, the conversion is pretty much about actually using the
> existing fdt infrastructure for the
.hansson-mmc/next]
>>> [also build test ERROR on v4.18-rc6 next-20180727]
>>> [if your patch is applied to the wrong git tree, please drop us a note to
>>> help improve the system]
>>>
>>> url:
>>> https://github.com/0day-ci/linux/commits
:
>>
>> [auto build test ERROR on ulf.hansson-mmc/next]
>> [also build test ERROR on v4.18-rc6 next-20180727]
>> [if your patch is applied to the wrong git tree, please drop us a note to
>> help improve the system]
>>
>> url:
>> https://github.
On 07/28/2018 12:58 AM, Minchan Kim wrote:
I made a mistake on previous patch.
Could you test this patches?
Thanks! Looking good so far! No errors whatsoever with the new patch. I
will let my test workload running for while to be sure, but I think we
are good.
--
Kind regards,
Tino Lehnig
tree, please drop us a note to
> help improve the system]
>
> url:
> https://github.com/0day-ci/linux/commits/Srinath-Mannam/mmc-host-iproc-Add-ACPI-support-to-IPROC-SDHCI/20180729-003026
> base: git://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc.git next
> config: i
Hi,
On Fri, Jul 27, 2018 at 10:07 PM, Stephen Boyd wrote:
> Quoting Amit Daniel Kachhap (2018-07-27 07:01:52)
>> This fix rounds the clock rate properly by using quotient and not
>> remainder in the calculation. This issue was found while testing HDMI
>> in the Juno platform.
>>
>> Signed-off-by:
Hello Trent and Andy,
> From: Trent Piepho [mailto:tpie...@impinj.com]
> Sent: Friday, July 27, 2018 2:02 AM
> To: andy.shevche...@gmail.com; Hayashibara, Keiji/林原 啓二
>
> Subject: Re: [PATCH v2 2/2] spi: add SPI controller driver for UniPhier SoC
>
> On Thu, 2018-07-26 at 11:46 +0300, Andy Shev
Hi Cong,
On 7/28/18 8:24 AM, Cong Wang wrote:
> Each time we sync cfs_rq->runtime_expires with cfs_b->runtime_expires,
> we should sync its ->expires_seq too. However it is missing
> for distribute_cfs_runtime(), especially the slack timer call path.
I don't think it's a problem, as expires_seq w
Hi.
Many thanks for the response! Some replies inline.
On Sun, 2018-07-22 at 22:42 +0300, Andy Shevchenko wrote:
> On Sun, Jul 22, 2018 at 1:36 AM, Lubomir Rintel
> wrote:
> > This driver switches the P10T tablet to "Android" mode, where the
> > Home
> > button sends a single sancode instead of
Dear Friend,
Good day, this is Mr. Henri Zongo, I'm happy to inform you about my success in
getting the fund $29.6Million transferred under the co-operation of a new
partner from Dubai, Presently I'm in Dubai for investment projects with my own
share of the total sum. Meanwhile,I didn't forget
On Mon, Jul 30, 2018 at 1:04 AM, Al Viro wrote:
> From: Miklos Szeredi
>
> iput() ends up calling ->evict() on new inode, which is not yet initialized
> by owning fs. So use destroy_inode() instead.
>
> Add to sb->s_inodes list only if inode is not in I_CREATING state (meaning
> that it wasn't a
On 24-07-18, 01:46, Robin Gong wrote:
> Add macro SDMA_BD_MAX_CNT to replace '0x'.
Applied, thanks
--
~Vinod
On 24-07-18, 01:46, Robin Gong wrote:
> Add MEMCPY capability for imx-sdma driver.
Applied, thanks
--
~Vinod
On Sat, Jul 28, 2018 at 8:34 PM, Jens Axboe wrote:
> On 7/28/18 3:50 AM, Souptick Joarder wrote:
>> out_unlock:
>> unlock_page(page);
>> + ret = block_page_mkwrite_return(err);
>> return ret;
>
> return block_page_mkwrite_return(err);
>
> --
> Jens Axboe
>
OK, I will post
On 27-07-18, 13:17, Srinivas Kandagatla wrote:
> Thankyou for reviewing v1 patchset, here is v2 addressing comments from v1.
>
> Qualcomm WCD9335 Codec is a standalone Hi-Fi audio codec IC.
> It is integrated in multiple Qualcomm SoCs like: MSM8996, MSM8976,
> and MSM8956 chipsets.
>
> WCD9335 ha
On 27-07-18, 13:17, Srinivas Kandagatla wrote:
> +obj-$(CONFIG_MFD_WCD9335)+= wcd9335.o
> +wcd9335-objs := wcd9335-core.o
> +
no slimbus objs?
> +static int wcd9335_bring_up(struct wcd9335 *wcd)
> +{
> + struct regmap *rm = wcd->regmap;
> + int val, byte0;
> + int
Hello Linus,
I have sent modified patch for this bag as v2.
Please refer to the following.
[PATCH v2]
https://patchwork.kernel.org/patch/10533929/
[Changes since v1]
diff --git a/drivers/pinctrl/uniphier/pinctrl-uniphier-sld8.c
b/drivers/pinctrl/uniphier/pinctrl-uniphier-sld8.c
-index 0f921a6..
Hi
My name is Wang Shengkun, i am a software programmer and i work with a lottery
company over here in the United States. I can give you the winning numbers in
our admin to play and win the lottery and we will share the proceeds 50% each.
If you are interested , kindly write me back at : 21489
On Mon, 30 Jul 2018 03:11:59 +
Matthew Leon wrote:
> >> Hey Jisheng,
>
> >Hi,
>
> >>
>
> >In LKML, we'd better not top post.
>
> Noted. My apologies.
>
> >> Shouldn't we be splitting until all DMA blocks are less than 128M
> boundary?
> >> I am a noob, but I think we should be
>> Hey Jisheng,
>Hi,
>>
>In LKML, we'd better not top post.
Noted. My apologies.
>> Shouldn't we be splitting until all DMA blocks are less than 128M
boundary?
>> I am a noob, but I think we should be prepared for boundaries that when
>> split in two, will still be greater than 128M. Feel fre
On Mon, 30 Jul 2018 02:56:20 + Matthew Leon wrote:
> Hey Jisheng,
Hi,
>
In LKML, we'd better not top post.
> Shouldn't we be splitting until all DMA blocks are less than 128M boundary?
> I am a noob, but I think we should be prepared for boundaries that when
> split in two, will still be
Hey Jisheng,
Shouldn't we be splitting until all DMA blocks are less than 128M boundary?
I am a noob, but I think we should be prepared for boundaries that when
split in two, will still be greater than 128M. Feel free to disagree but
please explain why I may be wrong. Thank-you.
Sincerely,
Matthe
When using DMA, if the DMA addr spans 128MB boundary, we have to split
the DMA transfer into two so that each one doesn't exceed the boundary.
Signed-off-by: Jisheng Zhang
---
drivers/mmc/host/sdhci-of-dwcmshc.c | 43 +
1 file changed, 43 insertions(+)
diff --git a/d
Hi Saravanan,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on pinctrl/devel]
[also build test ERROR on next-20180727]
[cannot apply to v4.18-rc7]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://gith
Add this hook so that it can be overridden with driver specific
implementations. We also rename the original sdhci_adma_write_desc()
to _sdhci_adma_write_desc() and export it, so that it could be reused
by driver's specific implementations.
Signed-off-by: Jisheng Zhang
---
drivers/mmc/host/sdhci
This patch adds adma_table_num member to struct sdhci_host to give more
flexibility to drivers to control the ADMA table number.
Default value of adma_table_num is set to (SDHCI_MAX_SEGS * 2 + 1).
Signed-off-by: Jisheng Zhang
---
drivers/mmc/host/sdhci.c | 17 +
drivers/mmc/host
When using DMA, if the DMA addr spans 128MB boundary, we have to split
the DMA transfer into two so that each one doesn't exceed the boundary.
patch1 adds adma_table_num to struct sdhci_host so that driver can
control the ADMA table number.
patch2 introduces adma_write_desc() hook to struct sdhci_
From: Levin Du
ROC-RK3399-PC is a power efficient 4GB LPDDR4 single board
computer with USB 3.0 and Gigabit Ethernet in a form factor
compatible with the Raspberry Pi. It is based on the Rockchip
RK3399 SoC, powered by the Type-C port.
The devicetree currently supports peripherals of:
- Etherne
Hi Rafael,
After merging the pm tree, today's linux-next build (x86_64 allmodconfig)
produced this warning:
drivers/media/i2c/mt9v111.c: In function 'mt9v111_set_format':
drivers/media/i2c/mt9v111.c:887:15: warning: 'idx' may be used uninitialized in
this function [-Wmaybe-uninitialized]
unsig
Hello Andy,
> -Original Message-
> From: linux-kernel-ow...@vger.kernel.org
> [mailto:linux-kernel-ow...@vger.kernel.org] On Behalf Of Andy
> Shevchenko
> Sent: Thursday, July 26, 2018 10:44 PM
> To: Hayashibara, Keiji/林原 啓二
> Cc: Mark Brown ; Rob Herring ; Mark
> Rutland ;
> Yamada, Ma
On Tue, 2018-07-24 at 17:34 +0300, Anton Vasilyev wrote:
> ish_dev_init() allocates 512*176 bytes memory for tx_buf and stores
> it at
> &dev->wr_free_list_head.link list on ish_probe().
> But there is no deallocation of this memory in ish_remove() and in
> ish_probe() error path.
> So current inte
Hello Radu,
> From: Radu Pirea [mailto:radu.pi...@microchip.com]
> Sent: Thursday, July 26, 2018 7:58 PM
> To: Hayashibara, Keiji/林原 啓二 ; 'Andy
> Shevchenko'
>
> Subject: Re: [PATCH v2 2/2] spi: add SPI controller driver for UniPhier SoC
>
>
>
> On 07/26/2018 12:38 PM, Keiji Hayashibara wrote
Hi Alexei,
FYI, the error/warning still remains.
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
master
head: acb1872577b346bd15ab3a3f8dff780d6cca4b70
commit: 819dd92b9c0bc7bce9097d8c1f14240f471bb386 bpfilter: switch to CC from
HOSTCC
date: 8 weeks ago
config: alp
Hi Linus,
On 30 July 2018 at 00:59, Linus Walleij wrote:
> On Thu, Jul 26, 2018 at 2:01 AM Tomer Maimon wrote:
>
> > I initialize bgpio as follow:
> >
> > ret = bgpio_init(&pctrl->gpio_bank[id].gc,
> > pctrl->dev, 4,
> >
syzbot has found a reproducer for the following crash on:
HEAD commit:d1e0b8e0cb7a Add linux-next specific files for 20180725
git tree: linux-next
console output: https://syzkaller.appspot.com/x/log.txt?x=10eff97840
kernel config: https://syzkaller.appspot.com/x/.config?x=eef3552c8
Thank you, i found a few case on this module i will try to fix them
and send a new patch series.
On Sun, 29 Jul 2018 at 20:33, Joe Perches wrote:
>
> On Sun, 2018-07-29 at 17:43 +0300, Georgios Tsotsos wrote:
> > Fixing coding style for a few lines that were reported to check from
> > checkpatch.p
Replaced -1 with defined error code EINVAL
Signed-off-by: Georgios Tsotsos
---
v2: Apply coding style to function cvmx_usb_poll_channel
v3: Break down function cvmx_usb_poll_channel
v4: Return defined error code and applying coding style for function calls
v5: Fixing wrong patch applied before wi
Replacing CVMX_WAIT_FOR_FIELD32 macro with equivalent function, and used
simpler approach for new function's parameters.
Signed-off-by: Georgios Tsotsos
---
v3: Changed CVMX_WAIT_FOR_FIELD32 macro to function according as refereed in
commit message and suggested by Greg Kroah-Hartman
v4: Added pa
So unless something odd happens, this should be the last rc for 4.18.
Nothing particularly odd happened this last week - we got the usual
random set of various minor fixes all over. About two thirds of it is
drivers - networking, staging and usb stands out, but there's a little
bit of stuff all ov
From: Al Viro
we don't want open-by-handle to pick an in-core inode that
has failed setup halfway through.
Signed-off-by: Al Viro
---
fs/udf/namei.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/fs/udf/namei.c b/fs/udf/namei.c
index c586026508db..061d049c2620
From: Al Viro
Signed-off-by: Al Viro
---
fs/ext2/ialloc.c | 3 +--
fs/ext2/namei.c | 9 +++--
2 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/fs/ext2/ialloc.c b/fs/ext2/ialloc.c
index 6484199b35d1..5c3d7b7e4975 100644
--- a/fs/ext2/ialloc.c
+++ b/fs/ext2/ialloc.c
@@ -611,8 +
From: Al Viro
Since NFS allows open-by-fhandle, we have to cope with the possibility
of mkdir vs. open-by-guessed-handle races. A local filesystem could
decide what the inumber of the new object will be and insert a locked
inode with that inumber into icache _before_ the on-disk data structures
From: Al Viro
Make sure that no partially set up inodes can be returned by
open-by-handle.
Signed-off-by: Al Viro
---
fs/btrfs/inode.c | 106 ---
1 file changed, 39 insertions(+), 67 deletions(-)
diff --git a/fs/btrfs/inode.c b/fs/btrfs/inod
From: Al Viro
Cc: Chris Mason
Signed-off-by: Al Viro
---
fs/btrfs/transaction.c | 2 +-
fs/btrfs/tree-log.c| 5 ++---
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/fs/btrfs/transaction.c b/fs/btrfs/transaction.c
index ff5f6c719976..feb0348dbcbf 100644
--- a/fs/btrfs/transa
From: Miklos Szeredi
iput() ends up calling ->evict() on new inode, which is not yet initialized
by owning fs. So use destroy_inode() instead.
Add to sb->s_inodes list only if inode is not in I_CREATING state (meaning
that it wasn't allocated with new_inode(), which already does the
insertion).
From: Al Viro
don't open-code iget_failed(), don't bother with btrfs_free_path(NULL),
move handling of positive return values of btrfs_lookup_inode() from
btrfs_read_locked_inode() to btrfs_iget() and kill now obviously pointless
ASSERT() in there.
Signed-off-by: Al Viro
---
fs/btrfs/inode.c |
From: Al Viro
We don't want open-by-handle picking half-set-up in-core
struct inode from e.g. mkdir() having failed halfway through.
In other words, we don't want such inodes returned by iget_locked()
on their way to extinction. However, we can't just have them
unhashed - otherwise open-
From: Al Viro
just get rid of pointless checks
Cc: Chris Mason
Signed-off-by: Al Viro
---
fs/btrfs/free-space-cache.c | 4
fs/btrfs/relocation.c | 7 ++-
fs/btrfs/tree-log.c | 6 +-
3 files changed, 3 insertions(+), 14 deletions(-)
diff --git a/fs/btrfs/free-space-
From: Al Viro
We never look them up in there; inode_fake_hash() will make them appear
hashed for mark_inode_dirty() purposes. And don't leave them around
until memory pressure kicks them out - we never look them up again.
Signed-off-by: Al Viro
---
fs/adfs/inode.c | 2 +-
fs/adfs/super.c | 1
From: Al Viro
The only user is fuse_create_new_entry(), and there it's used to
mitigate the same mkdir/open-by-handle race as in nfs_mkdir().
The same solution applies - unhash the mkdir argument, then
call d_splice_alias() and if that returns a reference to preexisting
alias, dput() and report s
From: Al Viro
open-coded in a quite a few places...
Signed-off-by: Al Viro
---
fs/hfs/inode.c | 2 +-
fs/jfs/jfs_imap.c | 8 +---
fs/jfs/super.c | 2 +-
fs/xfs/xfs_iops.c | 2 +-
include/linux/fs.h | 11 +++
5 files changed, 15 insertions(+), 10 deletions(-)
diff --g
From: Al Viro
we don't need to check is_bad_inode() after the call of
btrfs_read_locked_inode() - it's exactly the same as checking
return value for being non-zero.
Signed-off-by: Al Viro
---
fs/btrfs/inode.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/btrfs/inod
From: Al Viro
We hit that when inumber allocation has failed. In that case
the in-core inode is not hashed and since its ->i_nlink is 1
the only place where jfs checks is_bad_inode() won't be reached.
Signed-off-by: Al Viro
---
fs/jfs/jfs_inode.c | 2 --
1 file changed, 2 deletions(-)
diff -
From: Al Viro
we don't want open-by-handle to pick an in-core inode that
has failed setup halfway through.
Signed-off-by: Al Viro
---
fs/ufs/ialloc.c | 3 +--
fs/ufs/namei.c | 9 +++--
2 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/fs/ufs/ialloc.c b/fs/ufs/ialloc.c
index e
From: Al Viro
we don't want open-by-handle to pick an in-core inode that
has failed setup halfway through.
Signed-off-by: Al Viro
---
fs/jfs/jfs_inode.c | 8
fs/jfs/namei.c | 12
2 files changed, 8 insertions(+), 12 deletions(-)
diff --git a/fs/jfs/jfs_inode.c b/fs/
Assorted icache-related fixes for the next window; some of that is -stable
fodder.
1) NFS and FUSE mkdir/open_by_handle() race fix. NFS side posted and
discussed earlier, NFS folks hadn't objected... Basically, the strategy
used by local filesystems to deal with that kind of races does not (and
Hi Saravanan,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on pinctrl/devel]
[also build test WARNING on next-20180727]
[cannot apply to v4.18-rc6]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
http
Fixes: e96a1c4b279a ("pinctrl: actions: Add Actions Semi S700 pinctrl driver")
Signed-off-by: kbuild test robot
---
pinctrl-s700.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/pinctrl/actions/pinctrl-s700.c
b/drivers/pinctrl/actions/pinctrl-s700.c
index
On Thu, Jul 26, 2018 at 2:01 AM Tomer Maimon wrote:
> I initialize bgpio as follow:
>
> ret = bgpio_init(&pctrl->gpio_bank[id].gc,
> pctrl->dev, 4,
> pctrl->gpio_bank[id].base +
>
On Thu, Jul 26, 2018 at 5:42 PM Stefan Agner wrote:
> Since commit e45d1c80c0ee ("gpio: put GPIO IRQs into their own lock
> class") and commit a0a8bcf4670c ("gpiolib: irqchip: use different
> lockdep class for each gpio irqchip") GPIO lib takes care of lockdep
> classes. In fact, gpiochip_irq_map
On Thu, Jul 26, 2018 at 5:40 PM Stefan Agner wrote:
> Tegra 2 uses a different GPIO controller which uses "tegra20-gpio" as
> compatible string.
>
> Make the compatible string the GPIO node is using a SoC specific
> property. This prevents the kernel from registering the GPIO range
> twice in cas
On Tue, Jul 24, 2018 at 2:09 PM zhong jiang wrote:
> Fix the following sparse error:
>
> drivers/gpio/gpio-ath79.c:54:16: error: return expression in void function
>
> Signed-off-by: zhong jiang
Patch applied with Alban's ACK.
Yours,
Linus Walleij
Hello,
This is Ms Julian Smith and i am from Invictus Group Co.,LTD in United Kingdom.
We are glad to know about your company from the web and we are interested in
your products.
Could you kindly send us your Latest catalog and price list for our trial order.
Best Regards,
Julian Smith
Purchasin
Hi Saravanan,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on pinctrl/devel]
[also build test ERROR on next-20180727]
[cannot apply to v4.18-rc6]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://gith
On Wed, Jul 25, 2018 at 2:27 PM Quentin Schulz
wrote:
> The GPIO controller also serves as an interrupt controller for events
> on the GPIO it handles.
>
> An interrupt occurs whenever a GPIO line has changed.
>
> Signed-off-by: Quentin Schulz
Reviewed-by: Linus Walleij
Yours,
Linus Walleij
On Sun, Jul 29, 2018 at 10:05:11PM +0100, John Whitmore wrote:
> Second attempt correcting my initial attempt where I left '_t'
> and '_e' trailing the structures defined. These have now been
> corrected.
>
> John Whitmore (15):
> staging:rtl8192u: Remove typedef of struct cmpk_txfb_t - Style
>
Hi,
Indeed there was a mix-up with patches i will send correction asap.
On Sun, 29 Jul 2018 at 23:21, Aaro Koskinen wrote:
>
> Hi,
>
> On Sun, Jul 29, 2018 at 05:33:38PM +0300, Georgios Tsotsos wrote:
> > diff --git a/drivers/staging/octeon-usb/octeon-hcd.c
> > b/drivers/staging/octeon-usb/octeo
On Tue, Jul 24, 2018 at 1:57 PM Arnd Bergmann wrote:
> Some randconfig builds fail in the mtk-eint driver:
>
> drivers/pinctrl/mediatek/mtk-eint.c: In function 'mtk_eint_irq_handler':
> drivers/pinctrl/mediatek/mtk-eint.c:324:2: error: implicit declaration of
> function 'chained_irq_enter'; did
On Sun, 29 Jul 2018 22:36:49 +0200
Linus Walleij wrote:
> On Thu, Jul 19, 2018 at 8:44 AM Boris Brezillon
> wrote:
>
> > I guess you'd prefer to have the pin values in a bitmap instead of an
> > array of integers. That's probably something you can discuss with
> > Linus, see if he would accept
On Sun, Jul 29, 2018 at 10:05:15PM +0100, John Whitmore wrote:
> Rename the union ACI_AIFSN to aci_aifsn and remove the typedef directive.
>
> The removal of the typedef clears the checkpatch issue with defining
> new types. The renaming is to adhere to the coding style where types
> are name in l
On Sun, Jul 29, 2018 at 10:05:17PM +0100, John Whitmore wrote:
> Rename the member variables of union aci_aifsn, which should be named
> in lowercase. The only member variable, of this union, which is
> actually used is 'acm'.
>
> This are coding style changes which should have no impact on runtim
On Mon, Jul 23, 2018 at 6:54 PM Anton Vasilyev wrote:
> If ioh_gpio_probe() fails on devm_irq_alloc_descs() then chip may point
> to any element of chip_save array, so reverse iteration from pointer chip
> may become chip_save[-1] and gpiochip_remove() will operate with wrong
> memory.
>
> The pa
Correct the spelling of a number of comments, which cause a checkpatch
issue. This is purely a coding style change which should have no impact
on runtime code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/r819xU_cmdpkt.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletio
Remove the typedef from cmpk_set_cfg_t, leaving the structure as
struct cmd_pkt_set_configuration. This change clears the checkpatch
issue with defining new types. The change is purely a coding
style change which should have no impact on runtime code execution.
Signed-off-by: John Whitmore
---
d
The enumerated type dm_dig_connect_e is only used to group constant
values, as the actual type is never used as the type for the variables
which use the defined constants (cur_connect_state and pre_connect_state).
These two member variables have had there defined types changed to
properly reflect
The enumerated type dm_dig_dbg_e is never used in code so has simply
been removed from the source code.
this is a coding style change which should have no impact on runtime
code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/r8192U_dm.h | 6 --
1 file changed, 6 deleti
The enumerated type dm_dig_cs_ratio_e is never actually used as a type,
but only as a collection of related constants. This is because the
variables, which use the defined constant values, are defined as being
of type u8 rather then tne enumerated type. This omission negates the
possibility of taki
Remove the unused macro definition CMPK_RX_DBG_MSG_SIZE. This is a
coding style change which should have no impact on runtime code
execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/r819xU_cmdpkt.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/r819
The enumerated type dm_dig_alg_e is only used by one variable in the
code, 'dig_algorithm', a member variable of the structure dig. That
member variable was defined to be of type 'u8' thus negating any
advantage of the use of an enumerated type, (compiler type-checking).
The type of the variable '
Remove the typedef of the structure cmpk_txfb_t. This clears the
checkpatch issue with defining new types.
Additionally the type is renamed from cmpk_txfb_t to cmd_pkt_tx_feedback
removing the '_t' as the typedef has been removed.
These changes are purely coding style in nature and should have no
Remove the typedef of struct cmpk_intr_sta_t, the name of the structure
has been left as cmd_pkt_interrupt_status. This clears the checkpatch
issue with creating new types in code. The change is purely a coding
style change and should have no impact on runtime code execution.
Signed-off-by: John W
The enumerated type dm_ratr_sta_e was defined in the file
drivers/staging/rtl8192u/r8192U_dm.h but never actually used in that
file. The only variable which uses this enumerated type is 'ratr_state',
a member variable of the _rate_adaptive structure defined in the file
drivers/staging/rtl8192u/r819
Refactor the use of the enumerated type dm_dig_sta_e, which is not
actually used for type checking by the compiler.
The typedef of dm_dig_sta_e is removed to clear the checkpatch issue
with defining new types, and the enumerated type is left with the name
enum dynamic_init_gain_state
The enumerat
The enumerated type dm_dig_pd_th_e is never actually used as
the type for the two variables which use the constants, which the
enumeration defines. This omission removes the possibility of taking
advantage of compiler type checking.
To correct this the two member variables, (curpd_thstate & prepd_
Remove the enumerated type dm_dig_op_e. The type is only used as a
parameter to the function dm_change_dynamic_initgain_thresh(), but
that function is never referenced in the code at all.
I would consider this to be a coding style change as the function is
never referenced and as a result the enum
The enumerated type DM_CCK_Rx_Path_Method is used as a container for
constant definitions, rather then an enumerated type enabling compiler
type checking. To correct this, the variable which uses the constants,
defined by the enumeration, has had its type changed from a u8 to the
enumeration.
Addi
Remove the unused macro CMPK_TX_SET_CONFIG_SIZE. This is a coding style
change which should not impact runtime code execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/r819xU_cmdpkt.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/r819xU_cmdpkt.h
b/
Second attempt correcting my initial attempt where I left '_t'
and '_e' trailing the structures defined. These have now been
corrected.
John Whitmore (15):
staging:rtl8192u: Remove typedef of struct cmpk_txfb_t - Style
staging:rtl8192u: Remove unused CMPK_TX_SET_CONFIG_SIZE - Style
staging:r
Remove the unused macro definition CMPK_RX_DBG_MSG_SIZE. This is a
coding style change which should have no impact on runtime code
execution.
Signed-off-by: John Whitmore
---
drivers/staging/rtl8192u/r819xU_cmdpkt.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/rtl8192u/r819
1 - 100 of 256 matches
Mail list logo
