Re: [PATCH] mm: Use special value SHRINKER_REGISTERING instead list_empty() check

2018-08-04 Thread Kirill Tkhai
On 05.08.2018 03:03, Matthew Wilcox wrote: > On Sat, Aug 04, 2018 at 09:42:05PM +0300, Kirill Tkhai wrote: >> This is exactly the thing the patch makes. Instead of inserting a shrinker >> pointer >> to idr, it inserts a fake value SHRINKER_REGISTERING there. The patch makes >> impossible >> to

Re: [rt-patch 4/3] arm,KVM: Move phys_timer handling to hard irq context

2018-08-04 Thread Mike Galbraith
On Sat, 2018-08-04 at 14:25 +0200, Mike Galbraith wrote: > > Besides, there are more interesting fish in the arm64 sea than kvm. > > virgin 4.16.18-rt12-rt > > [ 537.236131] ITS queue timeout (65440 65504 4640) > [ 537.236150] ITS cmd its_build_inv_cmd failed FWIW, I had thought that

[PATCH v4 1/2] leds: core: Introduce LED pattern trigger

2018-08-04 Thread Baolin Wang
Some LED controllers have support for autonomously controlling brightness over time, according to some preprogrammed pattern or function. This patch adds pattern trigger that LED device can configure the pattern and trigger it. Signed-off-by: Raphael Teysseyre Signed-off-by: Baolin Wang ---

Re: [LKP] [mm, oom] c1e4c54f9c: BUG:KASAN:null-ptr-deref_in_d

2018-08-04 Thread 禹舟键
Hi Michal and David, AFAICS, the null pointer is the task_struct of p in the dump_header. Why don't we just add a if before printing the victim task's informaiton. diff --git a/mm/oom_kill.c b/mm/oom_kill.c --- a/mm/oom_kill.c +++ b/mm/oom_kill.c @@ -438,14 +438,6 @@ static void

Re: [PATCH v8 2/6] arm64: dts: actions: Add pinctrl definition for S900 I2C controller

2018-08-04 Thread Manivannan Sadhasivam
On Sat, Aug 04, 2018 at 11:04:40PM +0200, Wolfram Sang wrote: > On Wed, Aug 01, 2018 at 11:32:28PM +0530, Manivannan Sadhasivam wrote: > > Add pinctrl definition for Actions Semiconductor S900 I2C controller. > > Pinctrl definitions are only available for I2C0, I2C1, and I2C2. > > > >

Re: [PATCH v3 1/2] leds: core: Introduce LED pattern trigger

2018-08-04 Thread Baolin Wang
Hi Jacek, On 5 August 2018 at 05:41, Jacek Anaszewski wrote: > Hi Baolin, > > Thank you for the new version of the patch set. Thanks for your quick response. > > On 08/04/2018 06:51 PM, Baolin Wang wrote: >> Some LED controllers have support for autonomously controlling >> brightness over

Re: [PATCH] arm64: clean the additional checks before calling ghes_notify_sea()

2018-08-04 Thread gengdongjiu
2018-07-27 18:06 GMT+08:00 Will Deacon : > On Thu, Jul 26, 2018 at 05:01:47PM -0400, Dongjiu Geng wrote: >> In order to remove the additional check before calling the >> ghes_notify_sea(), make stub definition when !CONFIG_ACPI_APEI_SEA. >> >> Signed-off-by: Dongjiu Geng >> --- > > Acked-by: Will

[PATCH] PM / hibernate: Mark expected switch fall-through

2018-08-04 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Addresses-Coverity-ID: 114713 ("Missing break in switch") Signed-off-by: Gustavo A. R. Silva --- kernel/power/hibernate.c | 1 + 1 file changed, 1 insertion(+) diff --git

Re: [PATCH] power: supply: max77693_charger: fix unintentional fall-through

2018-08-04 Thread Gustavo A. R. Silva
Hi Sebastian, On 07/22/2018 05:17 PM, Sebastian Reichel wrote: > Hi, > > On Wed, Jul 18, 2018 at 08:14:50AM +0200, Krzysztof Kozlowski wrote: >> On 17 July 2018 at 23:47, Gustavo A. R. Silva wrote: >>> It seems that a *break* is missing in order to avoid a fall-through. >>> Otherwise, the

Re: [PATCH v2 1/2] Support the nonstring variable attribute (gcc >= 8)

2018-08-04 Thread Joe Perches
On Wed, 2018-08-01 at 19:54 +0200, Miguel Ojeda wrote: > From the GCC manual: > > The nonstring variable attribute specifies that an object or member > declaration with type array of char or pointer to char is intended to > store character arrays that do not necessarily contain a terminating NUL

Re: [PATCH 4/4] watchdog: hpwdt: Update version number.

2018-08-04 Thread Guenter Roeck
On 08/02/2018 02:15 PM, Jerry Hoemann wrote: Bump version number to reflect recent bug fixes. Signed-off-by: Jerry Hoemann As usual, my recommendation is to drop version numbers. The version number is reflected by the Linux kernel version and SHA. Yet, I understand that people feel quite

Re: [PATCH 3/4] watchdog: hpwdt: Display module parameters.

2018-08-04 Thread Guenter Roeck
On 08/02/2018 02:15 PM, Jerry Hoemann wrote: Print module parameters when the driver is loaded. Signed-off-by: Jerry Hoemann --- drivers/watchdog/hpwdt.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/watchdog/hpwdt.c b/drivers/watchdog/hpwdt.c index

Re: [PATCH 2/4] watchdog: hpwdt: Claim NMI from iLO

2018-08-04 Thread Guenter Roeck
On 08/02/2018 02:15 PM, Jerry Hoemann wrote: The hwpdt driver is overloaded for handling both the iLO watchdog and the explicit "Generate NMI to System" virutal button. Claim the iLO NMI virtual button even if we are not claiming the iLO watchdog pretimeout. Signed-off-by: Jerry Hoemann

Re: [PATCH 1/4] watchdog: hpwdt: Initialize pretimeout from module parameter.

2018-08-04 Thread Guenter Roeck
On 08/02/2018 02:15 PM, Jerry Hoemann wrote: When the pretimeout is specified as a module parameter, the value should be reflected in hpwdt_dev.pretimeout. The default (on) case is correct. But, when disabling pretimeout, the value should be set to zero in hpwdt_dev. Signed-off-by: Jerry

Re: [PATCH 00/46] Use dmaenginem_async_device_register to simplify code

2018-08-04 Thread Huang Shijie
On Fri, Aug 03, 2018 at 11:20:49AM +0300, Peter Ujfalusi wrote: > Hi, > > On 2018-08-03 10:19, Huang Shijie wrote: > > All the patches are using dmaenginem_async_device_register to simplify code > > except the last one: > > dmaengine: add COMPILE_TEST for the drivers > > > > I use the last one

[PATCH] soc: mediatek: pwrap: use true and false for boolean values

2018-08-04 Thread Gustavo A. R. Silva
Return statements in functions returning bool should use true or false instead of an integer value. This issue was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- drivers/soc/mediatek/mtk-pmic-wrap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] s390/qeth: use true and false for boolean values

2018-08-04 Thread Gustavo A. R. Silva
Return statements in functions returning bool should use true or false instead of an integer value. This issue was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- drivers/s390/net/qeth_l3_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH 0/3] Kbuild: fix and clean-up arch/um/Makefile

2018-08-04 Thread Randy Dunlap
On 08/03/2018 09:47 PM, Masahiro Yamada wrote: > 1/3 fixes the build failure reported by Randy. > (I may have seen a similar report before, but I cannot recall it.) > > 2/3 and 3/3 clean-up the Makefile a bit more. > > I'd like to apply this series to kbuild tree. > Ack from UML folks are

Re: [RFC PATCH v1] memory: tegra: Block DMA for clients HW on a faulty memory access

2018-08-04 Thread Dmitry Osipenko
On Sunday, 5 August 2018 03:11:57 MSK Mikko Perttunen wrote: > One potential issue is with host1x clients where userspace processes can > submit jobs with invalid memory accesses (addresses not mapped to > IOMMU). If when such a failure happens, we disable the DMA for the whole > host1x client,

[PATCH] genwqe: card_base: Use true and false for boolean values

2018-08-04 Thread Gustavo A. R. Silva
Return statements in functions returning bool should use true or false instead of an integer value. This code was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- drivers/misc/genwqe/card_base.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH] Input: raydium_i2c_ts - use true and false for boolean values

2018-08-04 Thread Gustavo A. R. Silva
Return statements in functions returning bool should use true or false instead of an integer value. This code was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- drivers/input/touchscreen/raydium_i2c_ts.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)

[PATCH] clk: qcom: clk-branch: Use true and false for boolean values

2018-08-04 Thread Gustavo A. R. Silva
Return statements in functions returning bool should use true or false instead of an integer value. This code was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- drivers/clk/qcom/clk-branch.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [RFC 0/4] Virtio uses DMA API for all devices

2018-08-04 Thread Michael S. Tsirkin
On Fri, Aug 03, 2018 at 08:16:21PM -0500, Benjamin Herrenschmidt wrote: > On Fri, 2018-08-03 at 22:07 +0300, Michael S. Tsirkin wrote: > > On Fri, Aug 03, 2018 at 10:58:36AM -0500, Benjamin Herrenschmidt wrote: > > > On Fri, 2018-08-03 at 00:05 -0700, Christoph Hellwig wrote: > > > > > 2- Make

[PATCH] platform/x86: acer-wmi: use true and false for boolean values

2018-08-04 Thread Gustavo A. R. Silva
Return statements in functions returning bool should use true or false instead of an integer value. This code was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- drivers/platform/x86/acer-wmi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [RFC PATCH v1] memory: tegra: Block DMA for clients HW on a faulty memory access

2018-08-04 Thread Mikko Perttunen
One potential issue is with host1x clients where userspace processes can submit jobs with invalid memory accesses (addresses not mapped to IOMMU). If when such a failure happens, we disable the DMA for the whole host1x client, unrelated userspace processes may see failures even though there is

Re: [PATCH] mm: Use special value SHRINKER_REGISTERING instead list_empty() check

2018-08-04 Thread Matthew Wilcox
On Sat, Aug 04, 2018 at 09:42:05PM +0300, Kirill Tkhai wrote: > This is exactly the thing the patch makes. Instead of inserting a shrinker > pointer > to idr, it inserts a fake value SHRINKER_REGISTERING there. The patch makes > impossible > to dereference a shrinker unless it's completely

Re: Re: [PATCH] [PATCH] mm: disable preemption before swapcache_free

2018-08-04 Thread Hugh Dickins
On Fri, 27 Jul 2018, zhaowu...@wingtech.com wrote: > >On Thu, 26 Jul 2018 15:03:23 +0800 "zhaowu...@wingtech.com" > > wrote: > > > >> >On Thu 26-07-18 10:21:40, zhaowu...@wingtech.com wrote: > >> >[...] > >> >> Our project really needs a fix to this issue > >> > > >> >Could you be more specific

Re: [PATCH 1/7] mm: allocate mm_cpumask dynamically based on nr_cpu_ids

2018-08-04 Thread Guenter Roeck
On Mon, Jul 16, 2018 at 03:03:31PM -0400, Rik van Riel wrote: > The mm_struct always contains a cpumask bitmap, regardless of > CONFIG_CPUMASK_OFFSTACK. That means the first step can be to > simplify things, and simply have one bitmask at the end of the > mm_struct for the mm_cpumask. > > This

[PATCH] mm/kasan/kasan_init: use true and false for boolean values

2018-08-04 Thread Gustavo A. R. Silva
Return statements in functions returning bool should use true or false instead of an integer value. This code was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- mm/kasan/kasan_init.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH 12/12] ASoC: wm8903: use true and false for boolean values

2018-08-04 Thread Gustavo A. R. Silva
Return statements in functions returning bool should use true or false instead of an integer value. This code was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- sound/soc/codecs/wm8903.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 10/12] ASoC: wm5100-tables: use true and false for boolean values

2018-08-04 Thread Gustavo A. R. Silva
Return statements in functions returning bool should use true or false instead of an integer value. This code was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- sound/soc/codecs/wm5100-tables.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-)

[PATCH 11/12] ASoC: da9055: use true and false for boolean values

2018-08-04 Thread Gustavo A. R. Silva
Return statements in functions returning bool should use true or false instead of an integer value. This code was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- sound/soc/codecs/da9055.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 09/12] ASoC: da7213: use true and false for boolean values

2018-08-04 Thread Gustavo A. R. Silva
Return statements in functions returning bool should use true or false instead of an integer value. This code was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- sound/soc/codecs/da7213.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 08/12] ASoC: twl6040: use true and false for boolean values

2018-08-04 Thread Gustavo A. R. Silva
Return statements in functions returning bool should use true or false instead of an integer value. This code was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- sound/soc/codecs/twl6040.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 07/12] ASoC: da7219: use true and false for boolean values

2018-08-04 Thread Gustavo A. R. Silva
Return statements in functions returning bool should use true or false instead of an integer value. This code was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- sound/soc/codecs/da7219.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 06/12] ASoC: wm8996: use true and false for boolean values

2018-08-04 Thread Gustavo A. R. Silva
Return statements in functions returning bool should use true or false instead of an integer value. This code was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- sound/soc/codecs/wm8996.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH 05/12] ASoC: cs4270: use true and false for boolean values

2018-08-04 Thread Gustavo A. R. Silva
Return statements in functions returning bool should use true or false instead of an integer value. This code was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- sound/soc/codecs/cs4270.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 04/12] ASoC: wm8990: use true and false for boolean values

2018-08-04 Thread Gustavo A. R. Silva
Return statements in functions returning bool should use true or false instead of an integer value. This code was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- sound/soc/codecs/wm8990.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 03/12] ASoC: tda7419: use true and false for boolean values

2018-08-04 Thread Gustavo A. R. Silva
Return statements in functions returning bool should use true or false instead of an integer value. This code was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- sound/soc/codecs/tda7419.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 02/12] ASoC: rt5631: use true and false for boolean values

2018-08-04 Thread Gustavo A. R. Silva
Return statements in functions returning bool should use true or false instead of an integer value. This code was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- sound/soc/codecs/rt5631.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[PATCH 01/12] ASoC: max9850: use true and false for boolean values

2018-08-04 Thread Gustavo A. R. Silva
Return statements in functions returning bool should use true or false instead of an integer value. This code was detected with the help of Coccinelle. Signed-off-by: Gustavo A. R. Silva --- sound/soc/codecs/max9850.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 00/12] ASoC: codecs: use true and false for boolean values

2018-08-04 Thread Gustavo A. R. Silva
Hi all, This patchset aims to replace the use of integer values with a proper true or false in return statements for functions returning bool. Thanks Gustavo A. R. Silva (12): ASoC: max9850: use true and false for boolean values ASoC: rt5631: use true and false for boolean values ASoC:

Re: [PATCH v3 1/2] leds: core: Introduce LED pattern trigger

2018-08-04 Thread Jacek Anaszewski
Hi Baolin, Thank you for the new version of the patch set. On 08/04/2018 06:51 PM, Baolin Wang wrote: > Some LED controllers have support for autonomously controlling > brightness over time, according to some preprogrammed pattern or > function. > > This patch adds pattern trigger that LED

Re: [PATCH 5/7] x86/mm/init: remove freed kernel image areas from alias mapping

2018-08-04 Thread Andy Lutomirski
On Thu, Aug 2, 2018 at 3:58 PM, Dave Hansen wrote: > > From: Dave Hansen > > The kernel image is mapped into two places in the virtual address > space (addresses without KASLR, of course): > > 1. The kernel direct map (0x8800) > 2. The "high kernel map"

Re: [PATCH v2, simpler] ia64: fix ptrace(PTRACE_GETREGS) (unbreaks strace, gdb)

2018-08-04 Thread Sergei Trofimovich
On Fri, 9 Mar 2018 23:15:55 + Sergei Trofimovich wrote: I tried to explain in more detail breakage mechanics of unwinder and gcc code generation quirks at: https://trofi.github.io/posts/210-ptrace-and-accidental-boot-fix-on-ia64.html Hopefully it gives better intuition of code change

Re: [PATCH] ext4/mballoc: Remove unneeded variable "err"

2018-08-04 Thread Theodore Y. Ts'o
On Sat, Aug 04, 2018 at 07:04:56PM +0800, zhong jiang wrote: > The err is not used after initalization. So just remove the variable. > > Signed-off-by: zhong jiang I'll apply this patch, but how did you generate the diff? The function name here is all wrong: > diff --git a/fs/ext4/mballoc.c

Re: [PATCH i2c-next v2] i2c: aspeed: Add an explicit type casting for *get_clk_reg_val

2018-08-04 Thread Wolfram Sang
On Tue, Jul 24, 2018 at 01:36:15PM -0700, Jae Hyun Yoo wrote: > This commit fixes this sparse warning: > drivers/i2c/busses/i2c-aspeed.c:875:38: warning: incorrect type in assignment > (different modifiers) > drivers/i2c/busses/i2c-aspeed.c:875:38:expected unsigned int ( > *get_clk_reg_val

Re: [PATCH v8 6/6] MAINTAINERS: Add entry for Actions Semiconductor Owl I2C driver

2018-08-04 Thread Wolfram Sang
On Wed, Aug 01, 2018 at 11:32:32PM +0530, Manivannan Sadhasivam wrote: > Add entry for Actions Semiconductor Owl I2C driver under ARM/ACTIONS So, it goes upstream via arm-soc? > > Signed-off-by: Manivannan Sadhasivam Acked-by: Wolfram Sang signature.asc Description: PGP signature

Re: [PATCH v8 2/6] arm64: dts: actions: Add pinctrl definition for S900 I2C controller

2018-08-04 Thread Wolfram Sang
On Wed, Aug 01, 2018 at 11:32:28PM +0530, Manivannan Sadhasivam wrote: > Add pinctrl definition for Actions Semiconductor S900 I2C controller. > Pinctrl definitions are only available for I2C0, I2C1, and I2C2. > > Signed-off-by: Manivannan Sadhasivam Note that I don't take DTS patches, so

Re: [PATCH v2 14/18] serial: intel: Add CCF support

2018-08-04 Thread Arnd Bergmann
On Sat, Aug 4, 2018 at 2:43 PM, Greg Kroah-Hartman wrote: > On Sat, Aug 04, 2018 at 12:54:22PM +0200, Hauke Mehrtens wrote: >> On 08/03/2018 12:30 PM, Greg Kroah-Hartman wrote: >> > On Fri, Aug 03, 2018 at 03:33:38PM +0800, Wu, Songjun wrote: >> This patch makes it possible to use it with the

Re: [PATCH v8 5/6] i2c: Add Actions Semiconductor Owl family S900 I2C driver

2018-08-04 Thread Wolfram Sang
On Wed, Aug 01, 2018 at 11:32:31PM +0530, Manivannan Sadhasivam wrote: > Add Actions Semiconductor Owl family S900 I2C driver. > > Signed-off-by: Manivannan Sadhasivam > Acked-by: Peter Rosin Applied to for-next, thanks! signature.asc Description: PGP signature

Re: [PATCH v8 1/6] dt-bindings: i2c: Add binding for Actions Semiconductor Owl I2C controller

2018-08-04 Thread Wolfram Sang
On Wed, Aug 01, 2018 at 11:32:27PM +0530, Manivannan Sadhasivam wrote: > Add devicetree binding for Actions Semiconductor Owl I2C controller > > Signed-off-by: Manivannan Sadhasivam > Reviewed-by: Rob Herring Applied to for-next, thanks! signature.asc Description: PGP signature

Re: [PATCH v3 1/3] iio: adc: add support for mcp3911

2018-08-04 Thread Andy Shevchenko
On Sat, Aug 4, 2018 at 9:55 AM, Marcus Folkesson wrote: > On Fri, Aug 03, 2018 at 11:09:22PM +0100, Jonathan Cameron wrote: >> On Thu, 2 Aug 2018 22:52:00 +0300 >> Andy Shevchenko wrote: >> >> > On Thu, Aug 2, 2018 at 10:15 PM, Marcus Folkesson >> > wrote: >> > > MCP3911 is a dual channel

Re: [PATCH] eeprom: at24: Fix unexpected timeout under high load

2018-08-04 Thread Andy Shevchenko
On Sat, Aug 4, 2018 at 8:43 PM, Mark Jonas wrote: > -#define at24_loop_until_timeout(tout, op_time) \ > - for (tout = jiffies + msecs_to_jiffies(at24_write_timeout), \ > -op_time = 0; \ > -

[PATCH] ALSA: echoaudio: Mark expected switch fall-throughs

2018-08-04 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Addresses-Coverity-ID: 115156 ("Missing break in switch") Signed-off-by: Gustavo A. R. Silva --- sound/pci/echoaudio/echoaudio.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[PATCH] ALSA: emu10k1: Mark expected switch fall-throughs

2018-08-04 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Notice that in this particular case, I replaced the code comment with a proper "fall through" annotation, which is what GCC is expecting to find. Signed-off-by: Gustavo A. R. Silva ---

[PATCH] ALSA: mixart: Mark expected switch fall-through

2018-08-04 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Signed-off-by: Gustavo A. R. Silva --- sound/pci/mixart/mixart.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/pci/mixart/mixart.c b/sound/pci/mixart/mixart.c index

Re: [PATCH 3/4] ARM64: dts: meson-gx: add dmcbus and canvas nodes.

2018-08-04 Thread Maxime Jourdan
>> + sysctrl_DMC: system-controller@0 { >> + compatible = "amlogic,meson-gx-dmc-sysctrl", >> "syscon", "simple-mfd"; > > we'd like to drop 'meson-' prefix, so better using "amlogic,gx-dmc-sysctrl", > please take a look at the discussion here [1]

Re: [PATCH] mm: Use special value SHRINKER_REGISTERING instead list_empty() check

2018-08-04 Thread Kirill Tkhai
On 04.08.2018 01:51, Andrew Morton wrote: > On Fri, 03 Aug 2018 18:36:14 +0300 Kirill Tkhai wrote: > >> The patch introduces a special value SHRINKER_REGISTERING to use instead >> of list_empty() to detect a semi-registered shrinker. >> >> This should be clearer for a reader since "list is

Re: [PATCH 3/7] x86/mm/init: pass unconverted symbol addresses to free_init_pages()

2018-08-04 Thread Hugh Dickins
On Sat, 4 Aug 2018, Linus Torvalds wrote: > On Fri, Aug 3, 2018 at 5:19 PM Hugh Dickins wrote: > > > > I thought that virt_to_page() only works on virtual addresses > > in the direct map > > You're right that virt_to_page() does not work on any _actual_ virtual > mappings (ie no user pages, and

Re: [PATCH] gpio: Add driver for PC Engines APU2/APU3 GPIOs

2018-08-04 Thread Christian Lamparter
On Thursday, August 2, 2018 11:30:00 PM CEST Linus Walleij wrote: > On Wed, Aug 1, 2018 at 1:12 PM Florian Eckert wrote: > > > Add a new device driver "gpio-apu" which will now handle the GPIOs on > > APU2 and APU3 devices from PC Engines. > > > > - APU2/APU3 -> front button reset support > > -

[PATCH] eeprom: at24: Fix unexpected timeout under high load

2018-08-04 Thread Mark Jonas
From: Wang Xin Within at24_loop_until_timeout the timestamp used for timeout checking is recorded after the I2C transfer and sleep_range(). Under high CPU load either the execution time for I2C transfer or sleep_range() could actually be larger than the timeout value. Worst case the I2C transfer

Re: [PATCH] Revert "cpufreq: intel_pstate: Fix ->set_policy() interface for no_turbo"

2018-08-04 Thread Gabriele Mazzotta
On 04/08/2018 17:29, Gabriele Mazzotta wrote: > This change does not take into account that some BIOSes change > MSR_IA32_MISC_ENABLE_TURBO_DISABLE depending on the power source. > If the turbo is disabled when the system boots, policy.max_freq > is set to pstate.max_pstate. However, if the BIOS

Re: [PATCH 3/7] x86/mm/init: pass unconverted symbol addresses to free_init_pages()

2018-08-04 Thread Linus Torvalds
On Fri, Aug 3, 2018 at 5:19 PM Hugh Dickins wrote: > > I thought that virt_to_page() only works on virtual addresses > in the direct map You're right that virt_to_page() does not work on any _actual_ virtual mappings (ie no user pages, and no vmalloc() pages etc). It does not follow page tables

Re: [PATCH v2 1/2] leds: core: Introduce LED pattern trigger

2018-08-04 Thread Baolin Wang
Hi Jacek, On 3 August 2018 at 19:59, Jacek Anaszewski wrote: > Hi Baolin, > > On 08/03/2018 10:05 AM, Baolin Wang wrote: >> Hi Jacek, >> >> On 3 August 2018 at 05:21, Jacek Anaszewski >> wrote: >>> Hi Baolin, >>> >>> Thank you for addressing review remarks. >>> >>> I've played a bit with the

[PATCH v3 1/2] leds: core: Introduce LED pattern trigger

2018-08-04 Thread Baolin Wang
Some LED controllers have support for autonomously controlling brightness over time, according to some preprogrammed pattern or function. This patch adds pattern trigger that LED device can configure the pattern and trigger it. Signed-off-by: Raphael Teysseyre Signed-off-by: Baolin Wang ---

[PATCH v3 2/2] leds: sc27xx: Add pattern_set/clear interfaces for LED controller

2018-08-04 Thread Baolin Wang
This patch implements the 'pattern_set'and 'pattern_clear' interfaces to support SC27XX LED breathing mode. Signed-off-by: Baolin Wang --- Changes from v2: - None. Changes from v1: - Remove pattern_get interface. --- drivers/leds/leds-sc27xx-bltc.c | 94

[PATCH] ALSA: hda/realtek - Add mute LED quirk for HP Spectre x360

2018-08-04 Thread Alexandru Gagniuc
This device has the same issues as the HP x360 wrt the MUTE LED and the front speakers not working. This patch fixes the MUTE LED issue, but doesn't touch the HDA verbs. The fix for the x360 does not work on the Spectre. Signed-off-by: Alexandru Gagniuc --- sound/pci/hda/patch_realtek.c | 1 +

Re: [PATCH] um: NULL check before kfree is not needed

2018-08-04 Thread Anton Ivanov
On 03/08/18 07:39, YueHaibing wrote: kfree(NULL) is safe,so this removes NULL check before freeing the mem Signed-off-by: YueHaibing --- arch/um/drivers/vector_kern.c | 15 +-- arch/um/drivers/vector_user.c | 6 ++ arch/um/kernel/irq.c | 3 +-- 3 files changed,

Re: [PATCH 3/6] irqchip: RISC-V Local Interrupt Controller Driver

2018-08-04 Thread Thomas Gleixner
On Fri, 3 Aug 2018, Palmer Dabbelt wrote: > On Wed, 01 Aug 2018 11:55:06 PDT (-0700), t...@linutronix.de wrote: > > Is there some high level documentation about the design (or the lack of) or > > can someone give a concise explanation how this stuff is supposed to work? > As part of our original

Re: [PATCH v4 0/4] EDAC: Enhancements to Synopsys EDAC driver

2018-08-04 Thread Borislav Petkov
On Sat, Aug 04, 2018 at 02:55:31PM +0530, Manish Narani wrote: > This patch series enhances the current EDAC driver to support different This one, your 2/4 and 4/4 still says "this patch". Hurried too much? How about slowing down and looking at them with a critical eye? Also, how about waiting

Re: kbuild: ARCH=um archheaders failed

2018-08-04 Thread Randy Dunlap
On 08/03/2018 07:23 PM, Masahiro Yamada wrote: > 2018-08-04 0:41 GMT+09:00 Randy Dunlap : >> On 08/02/2018 05:13 PM, Randy Dunlap wrote: >>> Hi Yamada-san, >>> >>> I see this every few weeks. It's not reproducible (it depends >>> on the moon, Mars, etc.). >>> >>> I'm using O=builddir. The build

[PATCH] Revert "cpufreq: intel_pstate: Fix ->set_policy() interface for no_turbo"

2018-08-04 Thread Gabriele Mazzotta
This change does not take into account that some BIOSes change MSR_IA32_MISC_ENABLE_TURBO_DISABLE depending on the power source. If the turbo is disabled when the system boots, policy.max_freq is set to pstate.max_pstate. However, if the BIOS later enables the turbo, the CPU will never be able to

[GIT PULL] usercopy fix for v4.18-rc8

2018-08-04 Thread Kees Cook
Hi, Please pull this usercopy fix for v4.18-rc8. Bart Massey discovered that the usercopy whitelist for JFS was incomplete: the inline inode data may intentionally "overflow" into the neighboring "extended area", so the size of the whitelist needed to be raised to include the neighboring field.

Re: [PATCH 4.17 00/31] 4.17.13-stable review

2018-08-04 Thread Guenter Roeck
On 08/04/2018 02:00 AM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.17.13 release. There are 31 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be

Re: [PATCH 4.14 00/23] 4.14.61-stable review

2018-08-04 Thread Guenter Roeck
On 08/04/2018 02:00 AM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.14.61 release. There are 23 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be

Re: [PATCH 4.9 00/32] 4.9.118-stable review

2018-08-04 Thread Guenter Roeck
On 08/04/2018 02:00 AM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.9.118 release. There are 32 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be

Re: [PATCH 4.4 000/124] 4.4.146-stable review

2018-08-04 Thread Guenter Roeck
On 08/04/2018 01:59 AM, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.4.146 release. There are 124 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be

[PATCH 2/4] staging: rtl8188eu: remove unnecessary parentheses

2018-08-04 Thread Michael Straube
Remove unnecessary parentheses from if conditions. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_iol.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8188eu/core/rtw_iol.c b/drivers/staging/rtl8188eu/core/rtw_iol.c index

[PATCH 1/4] staging: rtl8188eu: rename rtw_IOL_applied

2018-08-04 Thread Michael Straube
Rename rtw_IOL_applied to be all lowercase. rtw_IOL_applied -> rtw_iol_applied Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/core/rtw_efuse.c| 2 +- drivers/staging/rtl8188eu/core/rtw_iol.c | 2 +- drivers/staging/rtl8188eu/hal/rtl8188e_hal_init.c | 4 ++--

[PATCH 3/4] staging: rtl8188eu: remove redundant include

2018-08-04 Thread Michael Straube
The header osdep_service.h is included from drv_types.h, so remove the redundant include. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/include/rtw_iol.h | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/rtl8188eu/include/rtw_iol.h

[PATCH 4/4] staging: rtl8188eu: remove unnecessary includes

2018-08-04 Thread Michael Straube
In the header rtw_iol.h there is only one function declared. Remove the include of rtw_iol.h from files that do not use this function. Signed-off-by: Michael Straube --- drivers/staging/rtl8188eu/hal/mac_cfg.c| 1 - drivers/staging/rtl8188eu/hal/phy.c| 1 -

Re: [PATCH v1 1/2] pinctrl: tegra: Move drivers registration to arch_init level

2018-08-04 Thread Dmitry Osipenko
On Friday, 3 August 2018 20:24:56 MSK Linus Walleij wrote: > On Thu, Aug 2, 2018 at 1:31 PM Stefan Agner wrote: > > A while back at least using those init lists were not well received even > > for GPIO/pinctrl drivers: > > > >

Re: [PATCH v3 2/2] slab: __GFP_ZERO is incompatible with a constructor

2018-08-04 Thread Guenter Roeck
On 08/04/2018 02:28 AM, Geert Uytterhoeven wrote: On Sat, Aug 4, 2018 at 12:34 AM Matthew Wilcox wrote: On Fri, Aug 03, 2018 at 02:22:57PM -0700, Guenter Roeck wrote: On Thu, Apr 12, 2018 at 12:13:22PM -0700, Matthew Wilcox wrote: From: Matthew Wilcox __GFP_ZERO requests that the object be

Re: WARNING in try_charge

2018-08-04 Thread Tetsuo Handa
syzbot is hitting WARN(1) because of mem_cgroup_out_of_memory() == false. At first I suspected that syzbot is hitting static bool oom_kill_memcg_victim(struct oom_control *oc) { if (oc->chosen_memcg == NULL || oc->chosen_memcg == INFLIGHT_VICTIM) return

WARNING in try_charge

2018-08-04 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:d1e0b8e0cb7a Add linux-next specific files for 20180725 git tree: linux-next console output: https://syzkaller.appspot.com/x/log.txt?x=15a1c77040 kernel config: https://syzkaller.appspot.com/x/.config?x=eef3552c897e4d33

Re: framebuffer corruption due to overlapping stp instructions on arm64

2018-08-04 Thread Mikulas Patocka
On Fri, 3 Aug 2018, Matt Sealey wrote: > On 3 August 2018 at 13:25, Mikulas Patocka wrote: > > > > > > On Fri, 3 Aug 2018, Ard Biesheuvel wrote: > > > >> Are we still talking about overlapping unaligned accesses here? Or do > >> you see other failures as well? > > > > Yes - it is caused by

Re: [PATCH v4 4/4] arm64: dts: rockchip: add sdmmc UHS support for roc-rk3328-cc

2018-08-04 Thread Heiko Stuebner
Hi Levin, Am Dienstag, 31. Juli 2018, 07:59:22 CEST schrieb d...@t-chip.com.cn: > From: Levin Du > > In roc-rk3328-cc board, the signal voltage of sdmmc is supplied by the > vcc_sdio regulator, which is a mux between 1.8V and 3.3V, controlled by > a special output only gpio pin labeled

Re: [PATCH v4 2/4] arm64: dts: rockchip: add GRF GPIO controller to rk3328

2018-08-04 Thread Heiko Stuebner
Hi Levin, Am Dienstag, 31. Juli 2018, 07:59:20 CEST schrieb d...@t-chip.com.cn: > From: Levin Du > > Adding a GRF GPIO controller labled "grf_gpio" to rk3328, currently > providing access to the GPIO_MUTE pin, which is manupulated by the > GRF_SOC_CON10 register. > > The GPIO_MUTE pin is

[PATCH 04/20] perf annotate: Rename struct annotation_line::samples* to data*

2018-08-04 Thread Jiri Olsa
The name 'samples*' is little confusing because we have nested 'struct sym_hist_entry' under annotation_line struct, which holds 'nr_samples' as well. Also the holding struct name is 'annotation_data' so the 'data' name fits better. Link:

[PATCH 13/20] perf annotate: Pass struct annotation_options to symbol__calc_lines

2018-08-04 Thread Jiri Olsa
Passing struct annotation_options to symbol__calc_lines, to carry on and pass the percent_type value. Link: http://lkml.kernel.org/n/tip-hsutsg6zepd5o9dxdz0di...@git.kernel.org Signed-off-by: Jiri Olsa --- tools/perf/util/annotate.c | 23 +-- 1 file changed, 13

[PATCH 08/20] perf annotate: Switch struct annotation_data::percent to array

2018-08-04 Thread Jiri Olsa
So we can hold multiple percent values for annotation line. The first member of this array is current local hits percent value (PERCENT_HITS_LOCAL index), so no functional change is expected. Adding annotation_data__percent function to return requested percent value from struct annotation_data.

[PATCH 10/20] perf annotate: Add PERCENT_PERIOD_LOCAL percent value

2018-08-04 Thread Jiri Olsa
Adding and computing local period percent value for annotation line. Storing it in struct annotation_data percent array under new PERCENT_PERIOD_LOCAL index. At the moment it's not displayed, it's coming in following patches. Link:

[PATCH 19/20] perf annotate: Add --percent-type option

2018-08-04 Thread Jiri Olsa
Adding --percent-type option to set annotation percent type from following choices: global-period, local-period, global-hits, local-hits Examples: $ perf annotate --percent-type period-local --stdio | head -1 Percent | Source code ... es, percent: local period) $ perf

[PATCH 20/20] perf report: Add --percent-type option

2018-08-04 Thread Jiri Olsa
Set annotation percent type from following choices: global-period, local-period, global-hits, local-hits With following report option setup the percent type will be passed to annotation browser: $ perf report --percent-type period-local The local/global keywords set if the percentage is

[PATCH 17/20] perf annotate: Make local period the default percent type

2018-08-04 Thread Jiri Olsa
Currently we display the percentages in annotation output based on number of samples hits. Switching it to period based percentage by default, because it corresponds more to the time spent on the line. Link: http://lkml.kernel.org/n/tip-so91zbhsjblu1g3867lfv...@git.kernel.org Signed-off-by: Jiri

[PATCH 15/20] perf annotate: Pass browser percent_type in annotate_browser__calc_percent

2018-08-04 Thread Jiri Olsa
Passing browser percent_type in annotate_browser__calc_percent. Link: http://lkml.kernel.org/n/tip-7hqr2hyuv4yaqqtzxithr...@git.kernel.org Signed-off-by: Jiri Olsa --- tools/perf/ui/browsers/annotate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 14/20] perf annotate: Pass struct annotation_options to map_symbol__annotation_dump

2018-08-04 Thread Jiri Olsa
Passing struct annotation_options to map_symbol__annotation_dump, to carry on and pass the percent_type value. Link: http://lkml.kernel.org/n/tip-5toohgdkgpk3vn6zebusr...@git.kernel.org Signed-off-by: Jiri Olsa --- tools/perf/ui/browsers/annotate.c | 4 +-- tools/perf/util/annotate.c|

[PATCH 16/20] perf annotate: Add support to togle percent type

2018-08-04 Thread Jiri Olsa
Adding new key bindings to togle percent type/base in annotation UI browser: 'p' to switch between local and global percent type 'b' to switch between hits and perdio percent base Adding following help messages to the UI browser '?' window: ... p Toggle percent type

[PATCH 18/20] perf annotate: Display percent type in stdio output

2018-08-04 Thread Jiri Olsa
In following patches we will allow to switch percent type even for stdio annotation outputs. Adding the percent type value into the annotation outputs title. $ perf annotate --stdio Percent | Sou ... instructions:u } (2805 samples, percent: local period)

  1   2   3   4   >