INFO: rcu detected stall in kvm_vcpu_ioctl

2018-09-10 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:3d0e7a9e00fd Merge tag 'md/4.19-rc2' of git://git.kernel.o.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1666429e40 kernel config: https://syzkaller.appspot.com/x/.config?x=8f59875069d721b6

Re: [PATCHv3 2/6] tty/ldsem: Update waiter->task before waking up reader

2018-09-10 Thread Sergey Senozhatsky
On (09/11/18 14:04), Sergey Senozhatsky wrote: > > for (;;) { > > set_current_state(TASK_UNINTERRUPTIBLE); > > I think that set_current_state() also executes memory barrier. Just > because it accesses task state. > > > - if (!waiter.task) > > + if

[RFC PATCH 2/9] mm: introduce smp_list_del for concurrent list entry removals

2018-09-10 Thread Aaron Lu
From: Daniel Jordan Now that the LRU lock is a RW lock, lay the groundwork for fine-grained synchronization so that multiple threads holding the lock as reader can safely remove pages from an LRU at the same time. Add a thread-safe variant of list_del called smp_list_del that allows multiple

[RFC PATCH 8/9] mm: use smp_list_splice() on free path

2018-09-10 Thread Aaron Lu
With free path running concurrently, the cache bouncing on free list head is severe since multiple threads can be freeing pages and each free will need to add the page to free list head. To improve performance on free path for order-0 pages, we can choose to not add the merged pages to Buddy

[RFC PATCH 1/9] mm: do not add anon pages to LRU

2018-09-10 Thread Aaron Lu
For the sake of testing purpose, do not add anon pages to LRU to avoid LRU lock so we can test zone lock exclusively. Signed-off-by: Aaron Lu --- mm/memory.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/memory.c b/mm/memory.c index c467102a5cbc..080641255b8b 100644 ---

[RFC PATCH 9/9] mm: page_alloc: merge before sending pages to global pool

2018-09-10 Thread Aaron Lu
Now that we have mergable pages in Buddy unmerged, this is a step to reduce such things from happening to some extent. Suppose two buddy pages are on the list to be freed in free_pcppages_bulk(), the first page goes to merge but its buddy is not in Buddy yet so we hold it locally as an order0

[RFC PATCH 5/9] mm/page_alloc: use helper functions to add/remove a page to/from buddy

2018-09-10 Thread Aaron Lu
There are multiple places that add/remove a page into/from buddy, introduce helper functions for them. This also makes it easier to add code when a page is added/removed to/from buddy. No functionality change. Acked-by: Vlastimil Babka Signed-off-by: Aaron Lu --- mm/page_alloc.c | 65

[RFC PATCH 0/9] Improve zone lock scalability using Daniel Jordan's list work

2018-09-10 Thread Aaron Lu
Daniel Jordan and others proposed an innovative technique to make multiple threads concurrently use list_del() at any position of the list and list_add() at head position of the list without taking a lock in this year's MM summit[0]. People think this technique may be useful to improve zone lock

[RFC PATCH 3/9] mm: introduce smp_list_splice to prepare for concurrent LRU adds

2018-09-10 Thread Aaron Lu
From: Daniel Jordan Now that we splice a local list onto the LRU, prepare for multiple tasks doing this concurrently by adding a variant of the kernel's list splicing API, list_splice, that's designed to work with multiple tasks. Although there is naturally less parallelism to be gained from

[RFC PATCH 4/9] mm: convert zone lock from spinlock to rwlock

2018-09-10 Thread Aaron Lu
This patch converts zone lock from spinlock to rwlock and always take the lock in write mode so there is no functionality change. This is a preparation for free path to take the lock in read mode to make free path work concurrently. compact_trylock and compact_unlock_should_abort are taken from

[RFC PATCH 6/9] use atomic for free_area[order].nr_free

2018-09-10 Thread Aaron Lu
Since we will make free path run concurrently, free_area[].nr_free has to be atomic. Signed-off-by: Aaron Lu --- include/linux/mmzone.h | 2 +- mm/page_alloc.c| 12 ++-- mm/vmstat.c| 4 ++-- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git

[RFC PATCH 7/9] mm: use read_lock for free path

2018-09-10 Thread Aaron Lu
Daniel Jordan's patch has made it possible for multiple threads to operate on a global list with smp_list_del() at any position and smp_list_add/splice() at head position concurrently without taking any lock. This patch makes use of this technique on free list. To make this happen,

Re: [RFC PATCH v2 2/2] fscrypt: enable RCU-walk path for .d_revalidate

2018-09-10 Thread Gao Xiang
Hi Eric, On 2018/9/11 7:20, Eric Biggers wrote: > Hi Gao, > > On Mon, Sep 10, 2018 at 09:08:57PM +0800, Gao Xiang wrote: >> This patch attempts to enable RCU-walk for fscrypt. >> It looks harmless at glance and could have better >> performance than do ref-walk only. >> >> Signed-off-by: Gao

RE: [LINUX PATCH v11 1/3] dt-bindings: memory: Add pl353 smc controller devicetree binding information

2018-09-10 Thread Naga Sureshkumar Relli
Hi, [LINUX PATCH v11 1/3] dt-bindings: memory: Add pl353 smc controller devicetree binding information [LINUX PATCH v11 2/3] memory: pl353: Add driver for arm pl353 static memory controller Can somebody apply the above patches? The above patches are already reviewed. Thanks, Naga Sureshkumar

[PATCH] scsi: qla2xxx: reduce time granularity of qla2x00_eh_wait_on_command

2018-09-10 Thread Jianchao Wang
If the cmd has not be returned after aborted by qla2x00_eh_abort, we have to wait for it. However, the time is 1000ms at least currently. If there are a lot cmds need to be aborted, the delay could be long enough to lead to panic due to such as hung task, ocfs2 heartbeat, etc, just before scsi

RE: [LINUX PATCH v10 2/2] mtd: rawnand: arasan: Add support for Arasan NAND Flash Controller

2018-09-10 Thread Naga Sureshkumar Relli
Hi Boris, > -Original Message- > From: Boris Brezillon [mailto:boris.brezil...@bootlin.com] > Sent: Monday, August 20, 2018 10:10 PM > To: Naga Sureshkumar Relli > Cc: miquel.ray...@bootlin.com; rich...@nod.at; dw...@infradead.org; > computersforpe...@gmail.com; marek.va...@gmail.com;

[LKP] [kernfs, sysfs, cgroup, intel_rdt] a8c7fe83d1: BUG:kernel_hang_in_test_stage

2018-09-10 Thread kernel test robot
FYI, we noticed the following commit (built with gcc-6): commit: a8c7fe83d17109b77c7b27a23140e76d3753fa6a ("kernfs, sysfs, cgroup, intel_rdt: Support fs_context") https://git.kernel.org/cgit/linux/kernel/git/dhowells/linux-fs.git btrfs-mount-api in testcase: trinity with following parameters:

Re: [PATCHv3 2/6] tty/ldsem: Update waiter->task before waking up reader

2018-09-10 Thread Sergey Senozhatsky
On (09/11/18 02:48), Dmitry Safonov wrote: > There is a couple of reports about lockup in ldsem_down_read() without > anyone holding write end of ldisc semaphore: > lkml.kernel.org/r/<20171121132855.ajdv4k6swzhvk...@wfg-t540p.sh.intel.com> > lkml.kernel.org/r/<20180907045041.GF1110@shao2-debian> >

linux-next: Tree for Sep 11

2018-09-10 Thread Stephen Rothwell
Hi all, Changes since 20180910: Dropped trees: xarray, ida (temporarily) The vfs tree lost a build failure, but I still disabled building some samples. The tty tree gained a build failure so I used the version from next-20180910. Non-merge commits (relative to Linus' tree): 2768 3055 files

Re: [PATCH v9 3/6] kernel/reboot.c: export pm_power_off_prepare

2018-09-10 Thread Oleksij Rempel
Hi Shawn, On 11.09.2018 03:53, Shawn Guo wrote: > On Mon, Sep 10, 2018 at 04:19:26PM +0100, Mark Brown wrote: >> On Sun, Sep 09, 2018 at 10:00:23AM +0800, Shawn Guo wrote: >>> On Thu, Sep 06, 2018 at 11:15:17AM +0100, Mark Brown wrote: >> I was expecting to get a pull request with the

Re: get_arg_page() && ptr_size accounting

2018-09-10 Thread Kees Cook
On Mon, Sep 10, 2018 at 10:43 AM, Oleg Nesterov wrote: > On 09/10, Oleg Nesterov wrote: >> >> On 09/10, Kees Cook wrote: >> > >> > On Mon, Sep 10, 2018 at 9:41 AM, Kees Cook wrote: >> > > On Mon, Sep 10, 2018 at 5:29 AM, Oleg Nesterov wrote: >> > >> Hi Kees, >> > >> >> > >> I was thinking about

Re: get_arg_page() && ptr_size accounting

2018-09-10 Thread Kees Cook
On Mon, Sep 10, 2018 at 10:21 AM, Oleg Nesterov wrote: > On 09/10, Kees Cook wrote: >> >> On Mon, Sep 10, 2018 at 9:41 AM, Kees Cook wrote: >> > On Mon, Sep 10, 2018 at 5:29 AM, Oleg Nesterov wrote: >> >> Hi Kees, >> >> >> >> I was thinking about backporting the commit 98da7d08850fb8bde >> >>

Re: get_arg_page() && ptr_size accounting

2018-09-10 Thread Kees Cook
On Mon, Sep 10, 2018 at 10:18 AM, Oleg Nesterov wrote: > On 09/10, Kees Cook wrote: >> >> > So get_arg_page() does >> > >> > /* >> > * Since the stack will hold pointers to the strings, we >> > * must account for them as well. >> >

Re: [PATCH v2 3/5] irqchip: RISC-V Local Interrupt Controller Driver

2018-09-10 Thread Anup Patel
On Tue, Sep 11, 2018 at 3:49 AM, Christoph Hellwig wrote: > On Mon, Sep 10, 2018 at 09:37:59PM +0200, Thomas Gleixner wrote: >> Processor local interrupts really should be architected and there are >> really not that many of them. > > And that is what they are. > >> But well, RISC-V decided

[PATCH v4] dt-binding: remoteproc: Add QTI ADSP PIL bindings

2018-09-10 Thread Rohit kumar
Add devicetree bindings documentation file for Qualcomm Technolgies Inc ADSP Peripheral Image Loader. Signed-off-by: Rohit kumar --- Changes since v3: Addressed comments given by Rob .../bindings/remoteproc/qcom,adsp-pil.txt | 126 + 1 file changed, 126

linux-next: build warning after merge of the tip tree

2018-09-10 Thread Stephen Rothwell
Hi all, After merging the tip tree, today's linux-next build (x86_64 allnoconfig) produced this warning: arch/x86/kernel/cpu/common.c: In function 'syscall_init': arch/x86/kernel/cpu/common.c:1534:6: warning: unused variable 'cpu' [-Wunused-variable] int cpu = smp_processor_id(); ^~~

Re: [PATCH v3 2/2] remoteproc: qcom: Introduce Non-PAS ADSP PIL driver

2018-09-10 Thread Rohit Kumar
Thanks Bjorn for reviewing. On 9/11/2018 12:01 AM, Bjorn Andersson wrote: On Mon 03 Sep 04:52 PDT 2018, Rohit kumar wrote: This adds Non PAS ADSP PIL driver for Qualcomm Technologies Inc SoCs. Added initial support for SDM845 with ADSP bootup and shutdown operation handled from Application

Re: [PATCH v3 1/2] dt-binding: remoteproc: Add QTI ADSP PIL bindings

2018-09-10 Thread Rohit Kumar
Thanks Rob for reviewing. On 9/11/2018 1:31 AM, Rob Herring wrote: On Mon, Sep 03, 2018 at 05:22:39PM +0530, Rohit kumar wrote: Add devicetree bindings documentation file for Qualcomm Technolgies Inc ADSP Peripheral Image Loader. Signed-off-by: Rohit kumar ---

Re: [RFC PATCH 1/5] RISC-V: Make IPI triggering flexible

2018-09-10 Thread Anup Patel
On Mon, Sep 10, 2018 at 7:04 PM, Christoph Hellwig wrote: > On Thu, Sep 06, 2018 at 04:15:14PM +0530, Anup Patel wrote: >> This patch is doing two things: >> 1. Allow IRQCHIP driver to provide IPI trigger mechanism > > And the big questions is why do we want that? The last thing we > want is for

Compiler flags for libapi and libtraceevent

2018-09-10 Thread Ben Hutchings
I noticed that tools/lib/api/Makefile has these conditional assignments, similar to tools/perf/Makefile.config: ifeq ($(DEBUG),0) ifeq ($(CC_NO_CLANG), 0) CFLAGS += -O3 else CFLAGS += -O6 endif endif ifeq ($(DEBUG),0) CFLAGS += -D_FORTIFY_SOURCE endif But it doesn't set DEBUG to 0 by

linux-next: build failure after merge of the tty tree

2018-09-10 Thread Stephen Rothwell
d [-Wunused-variable] static const struct of_device_id at91_usart_mode_of_match[] = { ^~~~ Caused by commit 7d3aa342cef7 ("mfd: at91-usart: Add MFD driver for USART") Forgot to include ? I used the version of the tty tre

[PATCH v12 1/2] leds: core: Introduce LED pattern trigger

2018-09-10 Thread Baolin Wang
This patch adds one new led trigger that LED device can configure the software or hardware pattern and trigger it. Consumers can write 'pattern' file to enable the software pattern which alters the brightness for the specified duration with one software timer. Moreover consumers can write

[PATCH v12 2/2] leds: sc27xx: Add pattern_set/clear interfaces for LED controller

2018-09-10 Thread Baolin Wang
This patch implements the 'pattern_set'and 'pattern_clear' interfaces to support SC27XX LED breathing mode. Signed-off-by: Baolin Wang Acked-by: Pavel Machek --- Changes from v11: - None. Changes from v10: - Add duration alignment function suggested by Jacek. - Add acked tag from Pavel.

linux-next: build warning after merge of the usb tree

2018-09-10 Thread Stephen Rothwell
Hi Greg, After merging the usb tree, today's linux-next build (arm multi_v7_defconfig) produced this warning: drivers/usb/core/hcd.c: In function '__usb_hcd_giveback_urb': drivers/usb/core/hcd.c:1741:16: warning: unused variable 'flags' [-Wunused-variable] unsigned long flags;

Re: [PATCH] iio: proximity: Add driver support for ST's VL53L0X ToF ranging sensor.

2018-09-10 Thread Song Qiang
On Mon, Sep 10, 2018 at 11:27:47PM +0530, Himanshu Jha wrote: > On Mon, Sep 10, 2018 at 10:42:59PM +0800, Song Qiang wrote: > > This driver was originally written by ST in 2016 as a misc input device, > > and hasn't been maintained for a long time. I grabbed some code from > > it's API and

[PATCH v2 4/4] arm64: dts: rockchip: Enable SD card detection for Rock960 boards

2018-09-10 Thread Manivannan Sadhasivam
For proper working of SD cards, let's add the Card Detect GPIO property to the common devicetree for Rock960 family boards. Signed-off-by: Manivannan Sadhasivam --- arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v2 2/4] dt-bindings: arm: rockchip: Add binding for Rock960 board

2018-09-10 Thread Manivannan Sadhasivam
Add devicetree binding for Rock960 board from Vamrs Limited. Signed-off-by: Manivannan Sadhasivam --- Documentation/devicetree/bindings/arm/rockchip.txt | 4 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/arm/rockchip.txt

[PATCH v2 3/4] arm64: boot: dts: rockchip: Add support for Rock960 board

2018-09-10 Thread Manivannan Sadhasivam
Add devicetree support for Rock960 board, one of the Consumer Edition boards of the 96Boards family. This board support utilizes the common Rock960 family board support that includes Ficus 96Board. Signed-off-by: Manivannan Sadhasivam --- arch/arm64/boot/dts/rockchip/Makefile | 1 +

[PATCH v2 1/4] arm64: dts: rockchip: Split out common nodes for Rock960 based boards

2018-09-10 Thread Manivannan Sadhasivam
Since the same family members of Rock960 boards (Rock960 and Ficus) share the same configuration, split out the common nodes into a common dtsi file for reducing code duplication. The board specific nodes for Ficus boards are then placed in corresponding board DTS file. Signed-off-by: Manivannan

Re: [PATCH 4.19 regression fix] printk: For early boot messages check loglevel when flushing the buffer

2018-09-10 Thread Sergey Senozhatsky
On (09/10/18 16:57), Petr Mladek wrote: > > Good catch. > > > --- > > > > diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c > > index c036f128cdc3..ede29a7ba6db 100644 > > --- a/kernel/printk/printk.c > > +++ b/kernel/printk/printk.c > > @@ -2545,6 +2545,7 @@ void

[PATCH v2 0/4] Add 96Boards Rock960 CE board support

2018-09-10 Thread Manivannan Sadhasivam
This patchset adds 96Boards Rock960 CE board support. Rock960 CE (Consumer Edition) board is one of the member of 96Boards Consumer Edition and AI platform and is manufactured by Vamrs Limited. Most of the board configuration is shared with the Ficus board manufactured by vamrs, which is an

Re: [PATCH v3 1/2] i2c: mediatek: Register i2c adapter driver earlier

2018-09-10 Thread Jun Gao
On Thu, 2018-09-06 at 20:31 +0200, Wolfram Sang wrote: > On Thu, Sep 06, 2018 at 09:15:28PM +0800, Jun Gao wrote: > > From: Jun Gao > > > > In order not to block the initializations of some i2c devices. > > Register i2c adapter driver at appropriate time. > > > > Signed-off-by: Jun Gao > >

[PATCH] kernel: prevent submission of creds with higher privileges inside container

2018-09-10 Thread My Name
From: Xin Lin <18650033...@163.com> Adversaries often attack the Linux kernel via using commit_creds(prepare_kernel_cred(0)) to submit ROOT credential for the purpose of privilege escalation. For processes inside the Linux container, the above approach also works, because the container and the

Re: [PATCH] iio: proximity: Add driver support for ST's VL53L0X ToF ranging sensor.

2018-09-10 Thread Song Qiang
On Mon, Sep 10, 2018 at 06:12:43PM +0300, Andy Shevchenko wrote: > On Mon, Sep 10, 2018 at 10:42:59PM +0800, Song Qiang wrote: > > This driver was originally written by ST in 2016 as a misc input device, > > and hasn't been maintained for a long time. I grabbed some code from > > it's API and

Re: [PATCH] ip6_gre: simplify gre header parsing in ip6gre_err

2018-09-10 Thread Haishuang Yan
> On 2018年9月10日, at 下午11:36, Jiri Benc wrote: > > On Mon, 10 Sep 2018 16:25:09 +0800, Haishuang Yan wrote: >> +if (gre_parse_header(skb, , _err, htons(ETH_P_IPV6), >> + offset) < 0) { >> +if (!csum_err) /* ignore csum errors. */ >> +

Re: [PATCH] arm64: add NUMA emulation support

2018-09-10 Thread Shuah Khan
Hi Michal, On 09/10/2018 07:48 AM, Michal Hocko wrote: > On Fri 07-09-18 16:30:59, Shuah Khan wrote: >> On 09/07/2018 02:34 AM, Michal Hocko wrote: >>> On Thu 06-09-18 15:53:34, Shuah Khan wrote: [] >> >> In addition to isolation, being able to reserve a block instead is one of the >> issues

Re: [PATCH v9 3/6] kernel/reboot.c: export pm_power_off_prepare

2018-09-10 Thread Shawn Guo
On Mon, Sep 10, 2018 at 04:19:26PM +0100, Mark Brown wrote: > On Sun, Sep 09, 2018 at 10:00:23AM +0800, Shawn Guo wrote: > > On Thu, Sep 06, 2018 at 11:15:17AM +0100, Mark Brown wrote: > > > > I was expecting to get a pull request with the precursor patches in it - > > > the regulator driver

[PATCHv3 5/6] tty: Simplify tty->count math in tty_reopen()

2018-09-10 Thread Dmitry Safonov
As notted by Jiri, tty_ldisc_reinit() shouldn't rely on tty counter. Simplify math by increasing the counter after reinit success. Cc: Greg Kroah-Hartman Cc: Jiri Slaby Link: lkml.kernel.org/r/<20180829022353.23568-2-d...@arista.com> Suggested-by: Jiri Slaby Reviewed-by: Jiri Slaby

[PATCHv3 4/6] tty/lockdep: Add ldisc_sem asserts

2018-09-10 Thread Dmitry Safonov
Make sure under CONFIG_LOCKDEP that each change to line discipline is done with held write semaphor. Otherwise potential reader will have a good time dereferencing incomplete/uninitialized ldisc. Exception here is tty_ldisc_open(), as it's called without ldisc_sem locked by tty_init_dev() for the

[PATCHv3 1/6] tty: Drop tty->count on tty_reopen() failure

2018-09-10 Thread Dmitry Safonov
In case of tty_ldisc_reinit() failure, tty->count should be decremented back, otherwise we will never release_tty(). Tetsuo reported that it fixes noisy warnings on tty release like: pts pts4033: tty_release: tty->count(10529) != (#fd's(7) + #kopen's(0)) Fixes: commit 892d1fa7eaae ("tty:

[PATCHv3 6/6] tty/ldsem: Decrement wait_readers on timeouted down_read()

2018-09-10 Thread Dmitry Safonov
It seems like when ldsem_down_read() fails with timeout, it misses update for sem->wait_readers. By that reason, when writer finally releases write end of the semaphore __ldsem_wake_readers() does adjust sem->count with wrong value: sem->wait_readers * (LDSEM_ACTIVE_BIAS - LDSEM_WAIT_BIAS) I.e,

[PATCHv3 2/6] tty/ldsem: Update waiter->task before waking up reader

2018-09-10 Thread Dmitry Safonov
There is a couple of reports about lockup in ldsem_down_read() without anyone holding write end of ldisc semaphore: lkml.kernel.org/r/<20171121132855.ajdv4k6swzhvk...@wfg-t540p.sh.intel.com> lkml.kernel.org/r/<20180907045041.GF1110@shao2-debian> They all looked like a missed wake up. I wasn't

[PATCHv3 3/6] tty: Hold tty_ldisc_lock() during tty_reopen()

2018-09-10 Thread Dmitry Safonov
tty_ldisc_reinit() doesn't race with neither tty_ldisc_hangup() nor set_ldisc() nor tty_ldisc_release() as they use tty lock. But it races with anyone who expects line discipline to be the same after hoding read semaphore in tty_ldisc_ref(). We've seen the following crash on v4.9.108 stable:

[PATCHv3 0/6] tty: Hold write ldisc sem in tty_reopen()

2018-09-10 Thread Dmitry Safonov
Hi all, Three fixes that worth to have in the @stable, as we've hit them on v4.9 stable. And for linux-next - adding lockdep asserts for line discipline changing code, verifying that write ldisc sem will be held forthwith. The last patch is optional and probably, timeout can be dropped for

[PATCH] rtmutex: Fix the preprocessor logic with normal #ifdef #else #endif

2018-09-10 Thread Steven Rostedt
From: Steven Rostedt (VMware) Merging v4.14.68 into v4.14-rt I tripped over a conflict in the rtmutex.c code. There I found that we had: #ifdef CONFIG_DEBUG_LOCK_ALLOC [..] #endif #ifndef CONFIG_DEBUG_LOCK_ALLOC [..] #endif Really this should be: #ifdef CONFIG_DEBUG_LOCK_ALLOC [..]

Re: [PATCH] bcache: remove unnecessary null poiner check in cache_set_free

2018-09-10 Thread zhong jiang
On 2018/9/11 8:59, Junhui Tang wrote: > This patch is NOT OK to me,maybe many cache in a cache_set, and some > cache are not registered yet, so ca is possible NULL. Yep, It's my fault. please ingnore the patch. Thanks, zhong jiang > zhong jiang 于2018年9月8日周六 下午7:52写道: >> The iterator in

Re: [PATCH v3 06/12] RISC-V: Rename riscv_of_processor_hart to riscv_of_processor_hartid

2018-09-10 Thread Atish Patra
On 9/10/18 4:26 AM, Christoph Hellwig wrote: On Thu, Sep 06, 2018 at 01:05:29AM -0700, Atish Patra wrote: From: Palmer Dabbelt It's a bit confusing exactly what this function does: it actually returns the hartid of an OF processor node, failing with -1 on invalid nodes. I've changed the name

Re: [PATCH v3 11/12] RISC-V: Use Linux logical cpu number instead of hartid

2018-09-10 Thread Atish Patra
On 9/10/18 4:29 AM, Christoph Hellwig wrote: On Thu, Sep 06, 2018 at 01:05:34AM -0700, Atish Patra wrote: Setup the cpu_logical_map during boot. Moreover, every SBI call and PLIC context are based on the physical hartid. Use the logical cpu to hartid mapping to pass correct hartid to respective

Re: [PATCH v3 02/12] RISC-V: Filter ISA and MMU values in cpuinfo

2018-09-10 Thread Atish Patra
On 9/10/18 4:24 AM, Christoph Hellwig wrote: On Thu, Sep 06, 2018 at 01:05:25AM -0700, Atish Patra wrote: +#elif defined(CONFIG_64BIT) + if ((strcmp(mmu_type, "riscv,sv39") != 0) + && (strcmp(mmu_type, "riscv,sv48") != 0)) + return; This should be: if

Re: [PATCH v8 1/2] leds: core: Introduce LED pattern trigger

2018-09-10 Thread Baolin Wang
On 11 September 2018 at 05:20, Pavel Machek wrote: > Hi! > >> >> I'm still convinced that this will confuse our users and to me it would >> >> be more logical if this denotes the number of times the pattern should >> >> be repeated, with e.g. negative numbers denoting infinite. >> > >> > Sounds

Re: [PATCH] iio: remove unnecessary condition judgment in am2315_trigger_handler

2018-09-10 Thread zhong jiang
On 2018/9/10 21:49, zhong jiang wrote: > On 2018/9/8 22:17, Jonathan Cameron wrote: >> On Sat, 8 Sep 2018 17:59:13 +0530 >> Himanshu Jha wrote: >> >>> On Sat, Sep 08, 2018 at 06:57:36PM +0800, zhong jiang wrote: The iterator in for_each_set_bit is never null, therefore, remove the

Re: [PATCH v6 0/3] x86/boot/KASLR: Parse ACPI table and limit kaslr in immovable memory.

2018-09-10 Thread Chao Fan
sorry, the cover letter forwand to rafael. Thanks, Chao Fan On Mon, Sep 10, 2018 at 08:40:12PM +0800, Chao Fan wrote: >***Background: >People reported that kaslr may randomly chooses some positions >which are located in movable memory regions. This will break memory >hotplug feature and make the

Re: [PATCH 1/2] sound: q6core: Use kmemdup to replace kzalloc + memcpy

2018-09-10 Thread zhong jiang
On 2018/9/10 22:19, Mark Brown wrote: > On Sat, Sep 08, 2018 at 04:36:19PM +0800, zhong jiang wrote: >> kmemdup has implemented the function that kzalloc() + memcpy() will >> do. and we prefer to use the kmemdup rather than the open coded >> implementation. > Please submit patches using subject

[RFC PATCH v2 8/8] mm: enable concurrent LRU adds

2018-09-10 Thread Daniel Jordan
Switch over to holding lru_lock as reader when splicing pages onto the front of an LRU. The main benefit of doing this is to allow LRU adds and removes to happen concurrently. Before this patch, an add blocks all removing threads. Suggested-by: Yosef Lev Signed-off-by: Daniel Jordan ---

[RFC PATCH v2 4/8] mm: introduce smp_list_del for concurrent list entry removals

2018-09-10 Thread Daniel Jordan
Now that the LRU lock is a RW lock, lay the groundwork for fine-grained synchronization so that multiple threads holding the lock as reader can safely remove pages from an LRU at the same time. Add a thread-safe variant of list_del called smp_list_del that allows multiple threads to delete nodes

[RFC PATCH v2 6/8] mm: splice local lists onto the front of the LRU

2018-09-10 Thread Daniel Jordan
The add-to-front LRU path currently adds one page at a time to the front of an LRU. This is slow when using the concurrent algorithm described in the next patch because the LRU head node will be locked for every page that's added. Instead, prepare local lists of pages, grouped by LRU, to be

Re: [PATCH] bcache: remove unnecessary null poiner check in cache_set_free

2018-09-10 Thread Junhui Tang
This patch is NOT OK to me,maybe many cache in a cache_set, and some cache are not registered yet, so ca is possible NULL. zhong jiang 于2018年9月8日周六 下午7:52写道: > > The iterator in for_each_cache is never null, therefore, remove > the redundant null pointer check. > > Signed-off-by: zhong jiang >

[RFC PATCH v2 7/8] mm: introduce smp_list_splice to prepare for concurrent LRU adds

2018-09-10 Thread Daniel Jordan
Now that we splice a local list onto the LRU, prepare for multiple tasks doing this concurrently by adding a variant of the kernel's list splicing API, list_splice, that's designed to work with multiple tasks. Although there is naturally less parallelism to be gained from locking the LRU head

[RFC PATCH v2 5/8] mm: enable concurrent LRU removals

2018-09-10 Thread Daniel Jordan
The previous patch used the concurrent algorithm serially to see that it was stable for one task. Now in release_pages, take lru_lock as reader instead of writer to allow concurrent removals from one or more LRUs. Suggested-by: Yosef Lev Signed-off-by: Daniel Jordan --- mm/swap.c | 28

Re: [PATCH v4 1/2] rtmutex: allow specifying a subclass for nested locking

2018-09-10 Thread Peter Rosin
On 2018-09-11 01:27, Steven Rostedt wrote: > > Why this: > > #ifdef CONFIG_DEBUG_LOCK_ALLOC > [..] > #endif > > #ifndef CONFIG_DEBUG_LOCK_ALLOC > [..] > #endif > > ??? > > This should use #else. Yes. Water under the bridge... Cheers, Peter

[LKP] [vfs] fd0002870b: BUG:KASAN:null-ptr-deref_in_n

2018-09-10 Thread kernel test robot
FYI, we noticed the following commit (built with gcc-6): commit: fd0002870b453c58d0d8c195954f5049bc6675fb ("vfs: Implement a filesystem superblock creation/configuration context") https://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git master in testcase: boot on test machine:

[RFC PATCH v2 3/8] mm: convert lru_lock from a spinlock_t to a rwlock_t

2018-09-10 Thread Daniel Jordan
lru_lock is currently a spinlock, which allows only one task at a time to add or remove pages from any of a node's LRU lists, even if the pages are in different parts of the same LRU or on different LRUs altogether. This bottleneck shows up in memory-intensive database workloads such as decision

[RFC PATCH v2 0/8] lru_lock scalability and SMP list functions

2018-09-10 Thread Daniel Jordan
Hi, This is a work-in-progress of what I presented at LSF/MM this year[0] to greatly reduce contention on lru_lock, allowing it to scale on large systems. This is completely different from the lru_lock series posted last January[1]. I'm hoping for feedback on the overall design and general

[RFC PATCH v2 1/8] mm, memcontrol.c: make memcg lru stats thread-safe without lru_lock

2018-09-10 Thread Daniel Jordan
lru_lock needs to be held to update memcg LRU statistics. This requirement arises fairly naturally based on when the stats are updated because callers are holding lru_lock already. In preparation for allowing concurrent adds and removes from the LRU, however, make concurrent updates to these

[RFC PATCH v2 2/8] mm: make zone_reclaim_stat updates thread-safe

2018-09-10 Thread Daniel Jordan
lru_lock needs to be held to update the zone_reclaim_stat statistics. Similar to the previous patch, this requirement again arises fairly naturally because callers are holding lru_lock already. In preparation for allowing concurrent adds and removes from the LRU, however, make concurrent updates

Re: [PATCH RFC] mm: don't raise MEMCG_OOM event due to failed high-order allocation

2018-09-10 Thread David Rientjes
On Mon, 10 Sep 2018, Roman Gushchin wrote: > The memcg OOM killer is never invoked due to a failed high-order > allocation, however the MEMCG_OOM event can be easily raised. > > Under some memory pressure it can happen easily because of a > concurrent allocation. Let's look at try_charge(). Even

Re: Plumbers 2018 - Performance and Scalability Microconference

2018-09-10 Thread Daniel Jordan
On 9/8/18 12:13 AM, John Hubbard wrote: I'm interested in the first 3 of those 4 topics, so if it doesn't conflict with HMM topics or fix-gup-with-dma topics, I'd like to attend. Great, we'll add your name to the list. GPUs generally need to access large chunks of memory, and that includes

Re: Plumbers 2018 - Performance and Scalability Microconference

2018-09-10 Thread Daniel Jordan
On 9/10/18 1:34 PM, John Hubbard wrote: On 9/10/18 10:20 AM, Davidlohr Bueso wrote: On Mon, 10 Sep 2018, Waiman Long wrote: On 09/08/2018 12:13 AM, John Hubbard wrote: [...] It's also interesting that there are two main huge page systems (THP and Hugetlbfs), and I sometimes wonder the

Re: [PATCH 2/2] fs: list init in the critical section

2018-09-10 Thread Dave Chinner
On Mon, Sep 10, 2018 at 05:09:52AM -0700, swkhack wrote: > the i_state init in the critical section,so as the list init should in it. Why? What bug does this fix? -Dave. -- Dave Chinner da...@fromorbit.com

[WTF?] extremely old dead code

2018-09-10 Thread Al Viro
Folks, please tell me that I'm misreading the history here... 0.97: kernel/chr_dev/tty_ioctl.c:tty_ioctl(): + case FIONBIO: + if (arg) + file->f_flags |= O_NONBLOCK; + else +

Re: [PATCH v2] sched/fair: Remove setting task's se->runnable_weight during PELT update

2018-09-10 Thread Dietmar Eggemann
Hi, On 08/03/2018 07:05 AM, Dietmar Eggemann wrote: A CFS (SCHED_OTHER, SCHED_BATCH or SCHED_IDLE policy) task's se->runnable_weight must always be in sync with its se->load.weight. se->runnable_weight is set to se->load.weight when the task is forked (init_entity_runnable_average()) or

[PATCH v5 0/4] Add EDAC driver for QCOM SoCs

2018-09-10 Thread Venkata Narendra Kumar Gutta
This series implements EDAC driver for QCOM SoCs. As of now, this driver supports EDAC for Last Level Cache Controller (LLCC). LLCC EDAC driver is to detect and report single and double bit errors on Last Level Cache Controller (LLCC) cache. Interrupts are triggered when the errors happen in the

[PATCH v5 3/4] drivers: edac: Add EDAC driver support for QCOM SoCs

2018-09-10 Thread Venkata Narendra Kumar Gutta
From: Channagoud Kadabi Add error reporting driver for Single Bit Errors (SBEs) and Double Bit Errors (DBEs). As of now, this driver supports error reporting for Last Level Cache Controller (LLCC) of Tag RAM and Data RAM. Interrupts are triggered when the errors happen in the cache, the driver

[PATCH v5 4/4] dt-bindings: msm: Update documentation of qcom,llcc

2018-09-10 Thread Venkata Narendra Kumar Gutta
Add reg-names and interrupts for LLCC documentation and the usage examples. llcc broadcast base is added in addition to llcc base, which is used for llcc broadcast writes. Signed-off-by: Venkata Narendra Kumar Gutta Reviewed-by: Rob Herring --- .../devicetree/bindings/arm/msm/qcom,llcc.txt

[PATCH net-next] net: dsa: b53: Only call b53_port_event() for SGMII ports

2018-09-10 Thread Florian Fainelli
Built-in PHY ports are still being polled, avoid generating spurious and duplicate events which the PHY library resolves through polling anyways. Fixes: 0e01491de646 ("net: dsa: b53: Add SerDes support") Signed-off-by: Florian Fainelli --- drivers/net/dsa/b53/b53_srab.c | 3 ++- 1 file changed,

[PATCH v5 2/4] drivers: soc: Add support to register LLCC EDAC driver

2018-09-10 Thread Venkata Narendra Kumar Gutta
Cache error reporting controller detects and reports single and double bit errors on Last Level Cache Controller (LLCC) cache. Add required support to register LLCC EDAC driver as platform driver, from LLCC driver. Signed-off-by: Venkata Narendra Kumar Gutta Reviewed-by: Evan Green ---

[PATCH v5 1/4] drivers: soc: Add broadcast base for Last Level Cache Controller (LLCC)

2018-09-10 Thread Venkata Narendra Kumar Gutta
Currently, broadcast base is set to end of the LLCC banks, which may not be correct always. As the number of banks may vary for each chipset and the broadcast base could be at a different address as well. This info depends on the chipset, so get the broadcast base info from the device tree (DT).

Re: [PATCH v4 1/2] rtmutex: allow specifying a subclass for nested locking

2018-09-10 Thread Steven Rostedt
I just noticed this patch because it conflicted with the PREEMPT_RT v4.14 patch. On Fri, Jul 20, 2018 at 10:39:13AM +0200, Peter Rosin wrote: > Needed for annotating rt_mutex locks. > > Tested-by: John Sperbeck > Signed-off-by: Peter Rosin > --- > include/linux/rtmutex.h | 7 +++ >

Re: [PATCH 2/2] rtc: abx80x: add basic watchdog support

2018-09-10 Thread Guenter Roeck
On Mon, Sep 10, 2018 at 03:36:54PM -0600, Jeremy Gebben wrote: > The abx804 and abx805 chips have support for a simple watchdog > function that can trigger an external reset. > > Signed-off-by: Jeremy Gebben I am missing the "select WATCHDOG_CORE" that would normally go with watchdog drivers.

Re: [RFC PATCH v2 2/2] fscrypt: enable RCU-walk path for .d_revalidate

2018-09-10 Thread Eric Biggers
Hi Gao, On Mon, Sep 10, 2018 at 09:08:57PM +0800, Gao Xiang wrote: > This patch attempts to enable RCU-walk for fscrypt. > It looks harmless at glance and could have better > performance than do ref-walk only. > > Signed-off-by: Gao Xiang > --- > change log v2: > -

Re: sysfs: Do not return POSIX ACL xattrs via listxattr()

2018-09-10 Thread Marc Aurèle La France
On Mon, 10 Sep 2018, Andreas Grünbacher wrote: Am Mo., 10. Sep. 2018 schrieb Marc Aurèle La France: Commit 786534b92f3ce68f4afc8a761c80b76887797b0a "tmpfs: listxattr should include POSIX ACL xattrs", which first appeared in 4.5 kernels, introduced a regression whereby listxattr() syscalls on

[GIT PULL] Please pull RDMA subsystem changes

2018-09-10 Thread Jason Gunthorpe
Hi Linus, This fixes one major regression with NFS and mlx4 due to the max_sg rework in this merge window, tidies a few minor error_path regressions, and various small fixes. The HFI1 driver is broken this cycle due to a regression caused by a PCI change, it is looking like Bjorn will merge a

[PATCH] misc: kgdbts: Fix restrict error

2018-09-10 Thread Laura Abbott
kgdbts current fails when compiled with restrict: drivers/misc/kgdbts.c: In function ‘configure_kgdbts’: drivers/misc/kgdbts.c:1070:2: error: ‘strcpy’ source argument is the same as destination [-Werror=restrict] strcpy(config, opt); ^~~ As the error says, config is being

Re: [PATCH v4 3/4] drivers: edac: Add EDAC driver support for QCOM SoCs

2018-09-10 Thread vnkgutta
On 2018-09-06 22:02, Sai Prakash Ranjan wrote: On 9/7/2018 4:01 AM, vnkgu...@codeaurora.org wrote: On 2018-09-06 05:38, Sai Prakash Ranjan wrote: On 9/5/2018 4:52 AM, Venkata Narendra Kumar Gutta wrote: +static const struct of_device_id qcom_llcc_edac_match_table[] = { +    { .compatible =

Re: [PATCH v2 3/5] irqchip: RISC-V Local Interrupt Controller Driver

2018-09-10 Thread Christoph Hellwig
On Mon, Sep 10, 2018 at 09:37:59PM +0200, Thomas Gleixner wrote: > Processor local interrupts really should be architected and there are > really not that many of them. And that is what they are. > But well, RISC-V decided obvsiouly not to learn from mistakes made by > others. I don't think

Re: [PATCH v2 3/5] irqchip: RISC-V Local Interrupt Controller Driver

2018-09-10 Thread Christoph Hellwig
On Mon, Sep 10, 2018 at 10:41:22PM +0530, Anup Patel wrote: > RISC-V priv spec 1.10 defines the 9 bits in MIE and MIP registers and > other bits are reserved. > > The unused bits in MIP are WIRI (reserved write ignored and read ignored) > and unused bits in MIE are WPRI (reserved write preserve

RE: [PATCH 6/7] remoteproc: Add Xilinx ZynqMP R5 remoteproc

2018-09-10 Thread Jiaying Liang
> -Original Message- > From: Loic PALLARDY [mailto:loic.palla...@st.com] > Sent: Monday, September 10, 2018 1:25 PM > To: Jiaying Liang ; o...@wizery.com; > bjorn.anders...@linaro.org; Michal Simek ; > robh...@kernel.org; mark.rutl...@arm.com; Rajan Vaja > ; Jolly Shah > Cc:

Re: [PATCH resend] uapi/linux/keyctl.h: don't use C++ reserved keyword as a struct member name

2018-09-10 Thread Andrew Morton
On Mon, 10 Sep 2018 00:00:18 +0200 Eugene Syromiatnikov wrote: > On Tue, Aug 28, 2018 at 04:34:04PM -0700, Randy Dunlap wrote: > > From: Randy Dunlap > > > > Since this header is in "include/uapi/linux/", apparently people > > want to use it in userspace programs -- even in C++ ones. > >

Re: [PATCH 2/5] gpio: davinci: Use dev name for label and automatic base selection

2018-09-10 Thread Grygorii Strashko
On 09/09/2018 09:47 PM, Keerthy wrote: > > > On Sunday 09 September 2018 01:11 AM, Grygorii Strashko wrote: >> >> >> On 09/06/2018 09:16 AM, Keerthy wrote: >>> >>> >>> On Wednesday 05 September 2018 04:07 PM, Linus Walleij wrote: On Mon, Sep 3, 2018 at 7:40 AM Keerthy wrote: > On

Re: Regression in next with apps hanging with vm_fault_t

2018-09-10 Thread Stephen Rothwell
Hi all, On Tue, 11 Sep 2018 00:17:45 +0530 Souptick Joarder wrote: > > On Mon, Sep 10, 2018 at 11:51 PM Tony Lindgren wrote: > > > > I'm seeing a regression with Linux next with commit 7b6ec2ae877a > > ("fs: convert return type int to vm_fault_t") where apps can just > > hang. > > > > The

  1   2   3   4   5   6   7   8   9   >