Re: The linux devs can rescind their license grant.

2018-10-26 Thread visionsofalice
Al: the FSF was so insistent on the adoption of the GPL version 3 because the GPL version 2 is not operative against the grantor. This deficiency was, in their eyes, so fatal to the purposes that they envisioned that they, as you have pointed out, elected to employ enhanced means of converting pr

RE: [RFC/RFT][PATCH v2] cpuidle: New timer events oriented governor for tickless systems

2018-10-26 Thread Doug Smythies
This is just for anybody else trying to compile: On 2018.10.26 02:12 Rafael J. Wysocki wrote: > The venerable menu governor does some thigns that are quite Typo: thigns -> things ...[snip]... > The patch should apply on top of 4.19, although I'm running it on > top of my linux-next branch. No

[PATCH 3/8] clk: palmas: constify clk_ops structure

2018-10-26 Thread Julia Lawall
The clk_ops structure is only stored in the ops field of clk_init_data structures. This field is const, so the clk_ops structure can be const as well. Identified and transformed using Coccinelle. Signed-off-by: Julia Lawall --- drivers/clk/clk-palmas.c |2 +- 1 file changed, 1 insertion(+

[PATCH 6/8] clk: s2mps11: constify clk_ops structure

2018-10-26 Thread Julia Lawall
The clk_ops structure is only stored in the ops fields of clk_init_data structures. This field is const, so the clk_ops structure can be const as well. Identified and transformed using Coccinelle. Signed-off-by: Julia Lawall --- drivers/clk/clk-s2mps11.c |2 +- 1 file changed, 1 insertion

[PATCH 2/8] ARM: vexpress/spc: constify clk_ops structure

2018-10-26 Thread Julia Lawall
The clk_ops structure is only stored in the ops field of a clk_init_data structure. This field is const, so the clk_ops structure can be const as well. Identified and transformed using Coccinelle. Signed-off-by: Julia Lawall --- arch/arm/mach-vexpress/spc.c |2 +- 1 file changed, 1 insert

[PATCH 1/8] clk: max77686: constify clk_ops structure

2018-10-26 Thread Julia Lawall
The clk_ops structure is only stored in the ops field of a clk_init_data structure. This field is const, so the clk_ops structure can be const as well. Identified and transformed using Coccinelle. Signed-off-by: Julia Lawall --- drivers/clk/clk-max77686.c |2 +- 1 file changed, 1 insertio

[PATCH 7/8] drm/imx: imx-tve: constify clk_ops structure

2018-10-26 Thread Julia Lawall
The clk_ops structure is only stored in the ops field of a clk_init_data structure. This field is const, so the clk_ops structure can be const as well. Identified and transformed using Coccinelle. Signed-off-by: Julia Lawall --- drivers/gpu/drm/imx/imx-tve.c |2 +- 1 file changed, 1 inser

[PATCH 4/8] clk: pistachio: constify clk_ops structures

2018-10-26 Thread Julia Lawall
These clk_ops structures are only stored in the ops field of a clk_init_data structure. This field is const, so the clk_ops structures can be const as well. Identified and transformed using Coccinelle. Signed-off-by: Julia Lawall --- drivers/clk/pistachio/clk-pll.c |8 1 file cha

[PATCH 5/8] clk: pxa: constify clk_ops structures

2018-10-26 Thread Julia Lawall
These clk_ops structures are only passed to a call to clk_register_composite where the corresponding parameters are const, so the clk_ops structure can be const as well. Identified and transformed using Coccinelle. Signed-off-by: Julia Lawall --- drivers/clk/pxa/clk-pxa.c |4 ++-- 1 file c

[PATCH 0/8] constify clk_ops structure

2018-10-26 Thread Julia Lawall
Declare as const clk_ops structures that are only stored in const fields or passed to functions with const parameters. Identified and transformed using Coccinelle. Signed-off-by: Julia Lawall --- arch/arm/mach-vexpress/spc.c |2 +- drivers/clk/clk-max77686.c |

Re: possible deadlock in aio_poll

2018-10-26 Thread syzbot
syzbot has found a reproducer for the following crash on: HEAD commit:18d0eae30e6a Merge tag 'char-misc-4.20-rc1' of git://git.k.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=14728be540 kernel config: https://syzkaller.appspot.com/x/.config?x=342f43

Re: The linux devs can rescind their license grant. - Additional restrictive terms

2018-10-26 Thread visionsofalice
Version 2 of the GPL forbids the incorporation of additional restrictive terms, relating to the distribution, modification, etc of the article licensed under the terms. Those that violate this section are declared, by operation of the terms, to have their grant automatically revoked. An addition

[GIT PULL] C-SKY(csky) Port for Linux 4.20

2018-10-26 Thread Guo Ren
The following changes since commit 84df9525b0c27f3ebc2ebb1864fa62a97fdedb7d: Linux 4.19 (2018-10-22 07:37:37 +0100) are available in the git repository at: https://github.com/c-sky/csky-linux.git tags/csky-for-linus-4.20 for you to fetch changes up to 2347e7e1aea410865e3c3f92014b07ff7d4c5b0

Re: Linux kernel crash

2018-10-26 Thread Stephen Smith
On Wednesday, October 24, 2018 10:20:05 PM MST Stephen Smith wrote: > > Whenever I run "shutdown -h now" or "reboot" I receive an immediate kernel > crash with a dump that has: > > "Code: Bad RIP value" I Canonical response noted the following from the dump: [ 42.640541] resource sanity check:

Re: 4.18: early boot crash in thermal_cooling_device_destroy_sysfs

2018-10-26 Thread Randy Dunlap
On 10/26/18 2:14 AM, Rafael J. Wysocki wrote: > On Monday, October 22, 2018 8:37:25 PM CEST Randy Dunlap wrote: >> >> On 8/16/18 2:33 PM, Randy Dunlap wrote: >>> Hi, >>> >>> Sorry for the photo. That's all I have available so far. >>> >>> https://www.infradead.org/~rdunlap/doc/IMG_20180816_1332547

[PATCH] sched/rt: Fix a comment in pick_next_task_rt()

2018-10-26 Thread Muchun Song
Commit f4ebcbc0d7e0 ("sched/rt: Substract number of tasks of throttled queues from rq->nr_running") added a new member rt_rq->rt_queued, which is used to indicate the status of rq->rt enqueue or dequeue. So, the check rt_nr_running was removed and we now check rt_queued. Fix the comment in pick_ne

[PATCH -next] sgi-xp: drop pointless static qualifier in xpc_setup_msg_structures_uv

2018-10-26 Thread YueHaibing
There is no need to have the 'enum xp_retval ret' variable static since new value always be assigned before use it. Signed-off-by: YueHaibing --- drivers/misc/sgi-xp/xpc_uv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/sgi-xp/xpc_uv.c b/drivers/misc/sgi-xp/xp

[PATCH] ASoC: stm32: sai: fix invalid use of sizeof in stm32_sai_add_mclk_provider()

2018-10-26 Thread Wei Yongjun
sizeof() when applied to a pointer typed expression gives the size of the pointer, not that of the pointed data. Fixes: 8307b2afd386 ("ASoC: stm32: sai: set sai as mclk clock provider") Signed-off-by: Wei Yongjun --- sound/soc/stm/stm32_sai_sub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletio

[PATCH v2 6/6] staging:iio:ad2s90: Check channel type at read_raw

2018-10-26 Thread Matheus Tavares
This patch adds a channel type check at the beginning of the ad2s90_read_raw function. Since ad2s90 has only one channel, it just checks if the given channel is the expected one and if not, return -EINVAL. Signed-off-by: Matheus Tavares --- drivers/staging/iio/resolver/ad2s90.c | 3 +++ 1 file c

[PATCH v2 2/6] staging:iio:ad2s90: Make probe handle spi_setup failure

2018-10-26 Thread Matheus Tavares
Previously, ad2s90_probe ignored the return code from spi_setup, not handling its possible failure. This patch makes ad2s90_probe check if the code is an error code and, if so, do the following: - Call dev_err with an appropriate error message. - Return the spi_setup's error code, aborting the exe

[PATCH v2 1/6] staging:iio:ad2s90: Make read_raw return spi_read's error code

2018-10-26 Thread Matheus Tavares
Previously, when spi_read returned an error code inside ad2s90_read_raw, the code was ignored and IIO_VAL_INT was returned. This patch makes the function return the error code returned by spi_read when it fails. Signed-off-by: Matheus Tavares --- drivers/staging/iio/resolver/ad2s90.c | 9 ++-

[PATCH v2 0/6] staging:iio:ad2s90: Add scale info and improve error handling

2018-10-26 Thread Matheus Tavares
This patch set adds scale info to ad2s90's single channel, improve error handling in it's functions and fix a possible race condition issue. The goal with this patch set is to address the points discussed in the mailing list in an effort to move ad2s90.c out of staging. Changes in v2: - Added my

[PATCH v2 5/6] staging:iio:ad2s90: Add IIO_CHAN_INFO_SCALE to channel spec and read_raw

2018-10-26 Thread Matheus Tavares
This patch adds the IIO_CHAN_INFO_SCALE mask to ad2s90_chan and implements the relative read behavior at ad2s90_read_raw. Signed-off-by: Victor Colombo Signed-off-by: Matheus Tavares --- drivers/staging/iio/resolver/ad2s90.c | 32 ++- 1 file changed, 22 insertions(+), 10

[PATCH v2 3/6] staging:iio:ad2s90: Remove always overwritten assignment

2018-10-26 Thread Matheus Tavares
This patch removes an initial assignment to the variable ret at probe, that was always overwritten. Signed-off-by: Matheus Tavares --- drivers/staging/iio/resolver/ad2s90.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/iio/resolver/ad2s90.c b/drivers/stagin

[PATCH v2 4/6] staging:iio:ad2s90: Move device registration to the end of probe

2018-10-26 Thread Matheus Tavares
Previously, devm_iio_device_register was being called before the spi_setup call and the spi_device's max_speed_hz and mode assignments. This could lead to a race condition since the driver was still being set up after it was already made ready to use. To fix it, this patch moves the device registra

Re: [PATCH v2 1/3] namei: implement O_BENEATH-style AT_* flags

2018-10-26 Thread Ed Maste
On Tue, 9 Oct 2018 at 02:53, Aleksa Sarai wrote: > > +#ifndef O_BENEATH > +#define O_BENEATH 0004000 /* *Not* the same as capsicum's > O_BENEATH! */ > +#endif I had originally followed up privately to Aleksa about this comment (to suggest that it's outdated and should be removed), but t

Re: [Ksummit-discuss] Call to Action Re: [PATCH 0/7] Code of Conduct: Fix some wording, and add an interpretation document

2018-10-26 Thread Josh Triplett
On Fri, Oct 26, 2018 at 08:14:51AM +1100, NeilBrown wrote: > On Wed, Oct 24 2018, Josh Triplett wrote: > > > On Tue, Oct 23, 2018 at 07:26:06AM +1100, NeilBrown wrote: > >> On Sun, Oct 21 2018, Josh Triplett wrote: > >> > >> > On Mon, Oct 22, 2018 at 08:20:11AM +1100, NeilBrown wrote: > >> >> I c

Re: [RFC PATCH 2/2] memcg: do not report racy no-eligible OOM tasks

2018-10-26 Thread Tetsuo Handa
On 2018/10/27 4:25, Michal Hocko wrote: >> out_of_memory() bails on task_will_free_mem(current), which >> specifically *excludes* already reaped tasks. Why are we then adding a >> separate check before that to bail on already reaped victims? > > 696453e66630a has introduced the bail out. > >> Do

Re: [GIT] Sparc

2018-10-26 Thread Linus Torvalds
On Fri, Oct 26, 2018 at 4:08 PM David Miller wrote: > > Some more sparc fixups, mostly aimed at getting the allmodconfig build > up and clean again. Pulled, Linus

Re: [RFC 00/60] Coscheduling for Linux

2018-10-26 Thread Jan H . Schönherr
On 27/10/2018 01.05, Subhra Mazumdar wrote: > > >> D) What can I *not* do with this? >> - >> >> Besides the missing load-balancing within coscheduled task-groups, this >> implementation has the following properties, which might be considered >> short-comings. >> >>

[git pull] Input updates for v4.20-rc0

2018-10-26 Thread Dmitry Torokhov
Hi Linus, Please pull from: git://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git for-linus to receive updates for the input subsystem. Just random driver fixups, nothing exiting. Changelog: - Brian Masney (1): Input: pwm-vibrator - correct pwms in DT binding examp

[RFC 00/60] Coscheduling for Linux

2018-10-26 Thread Jan H . Schönherr
On 19/10/2018 02.26, Subhra Mazumdar wrote: > Hi Jan, Hi. Sorry for the delay. > On 9/7/18 2:39 PM, Jan H. Schönherr wrote: >> The collective context switch from one coscheduled set of tasks to another >> -- while fast -- is not atomic. If a use-case needs the absolute guarantee >> that all tasks

[RFC PATCH 5/7] kernel/kthread.c: do runtime check of format string in kthread_create_on_cpu()

2018-10-26 Thread Rasmus Villemoes
One is supposed to pass in a format string containing (at most) one %u instance. Use fmtcheck() to enforce that at runtime, WARNing and falling back to a harmless "kthread/%u" in case verification fails. Signed-off-by: Rasmus Villemoes --- kernel/kthread.c | 4 ++-- 1 file changed, 2 insertions(

[RFC PATCH 2/7] lib/vsprintf.c: add fmtcheck utility

2018-10-26 Thread Rasmus Villemoes
We have a few places in the kernel where a *printf function is used with a non-constant format string, making the ordinary static type checking done by gcc et al. impossible. With extra instrumentation, some things can still be caught at build time, but that still leaves a number of places unchecke

[RFC PATCH 1/7] compiler_attributes.h: add __attribute__((format_arg)) shorthand

2018-10-26 Thread Rasmus Villemoes
The __format_arg attribute tells gcc that it can use a specific argument to the annotated function as the format string for the purpose of type-checking a surrounding __printf function call. For example, assuming one has a fmtcheck function declared as const char *fmtcheck(const char *, const ch

[RFC PATCH 6/7] nfs: use fmtcheck() in root_nfs_data

2018-10-26 Thread Rasmus Villemoes
tmp is initially the string "/tftpboot/%s", but it may be changed from the calls to root_nfs_parse_options. While an nfsroot= command line option can probably be trusted (or the user gets to keep both pieces), it's also possible for contents to come via a BOOTP option. Do a sanity check of fmt to

[RFC PATCH 4/7] lib/test_printf.c: add a few fmtcheck() test cases

2018-10-26 Thread Rasmus Villemoes
It should be trivial to add more test cases, once we figure out the exact rules for being compatible or not. Perhaps we'll have to extend the struct test with a flags element if we add flags that affect the return value. Signed-off-by: Rasmus Villemoes --- lib/test_printf.c | 43

[RFC PATCH 3/7] kernel.h: implement fmtmatch() wrapper around fmtcheck()

2018-10-26 Thread Rasmus Villemoes
Some users may prefer to check a "user-supplied" string upfront and return EINVAL rather than using the the template as a fallback for printf'ing later. fmtmatch() is simply a shorthand for fmtcheck(a, b, c | FMTCHECK_SILENT) == a. Signed-off-by: Rasmus Villemoes --- include/linux/kernel.h |

Re: [PATCH 11/11] perf tools: Stop fallbacking to kallsyms for vdso symbols lookup

2018-10-26 Thread Vinicius Costa Gomes
Hi, Adrian Hunter writes: > On 18/10/18 1:55 AM, Arnaldo Carvalho de Melo wrote: >> From: Arnaldo Carvalho de Melo >> >> David reports that: >> >> >> Perf has this hack where it uses the kernel symbol map as a backup when >> a symbol can't be found in the user's symbol table(s). > > I don't

[GIT] Sparc

2018-10-26 Thread David Miller
Some more sparc fixups, mostly aimed at getting the allmodconfig build up and clean again. Please pull, thanks a lot! The following changes since commit caf539cd1087f7c36b9c4df271575e9aee49fde5: sparc: Fix VDSO build with older binutils. (2018-10-25 10:36:19 -0700) are available in the Git

[PATCH] platform/x86: ideapad: Add Y530-15ICH to no_hw_rfkill

2018-10-26 Thread Misha Komarovskiy
Lenovo Legion Y530-15ICH is another model without hardware radio switch. Add it to no_hw_rfkill to enable wireless. Signed-off-by: Misha Komarovskiy --- drivers/platform/x86/ideapad-laptop.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/platform/x86/ideapad-laptop.c b/drive

Re: [RFC 00/60] Coscheduling for Linux

2018-10-26 Thread Subhra Mazumdar
D) What can I *not* do with this? - Besides the missing load-balancing within coscheduled task-groups, this implementation has the following properties, which might be considered short-comings. This particular implementation focuses on SCHED_OTHER tasks manage

Re: [PATCH 1/2] x86/pkeys: copy pkey state at fork()

2018-10-26 Thread Daniel Micay
On Fri, 26 Oct 2018 at 18:12, Andy Lutomirski wrote: > > > > > On Oct 26, 2018, at 2:39 PM, Daniel Micay wrote: > > > > I ended up working around this with a pthread_atfork handler disabling > > my usage of the feature in the child process for the time being. I > > don't have an easy way to detec

[PATCH] MIPS: OCTEON: fix out of bounds array access on CN68XX

2018-10-26 Thread Aaro Koskinen
The maximum number of interfaces is returned by cvmx_helper_get_number_of_interfaces(), and the value is used to access interface_port_count[]. When CN68XX support was added, we forgot to increase the array size. Fix that. Fixes: 2c8c3f0201333 ("MIPS: Octeon: Support additional interfaces on CN68X

Re: [PATCH net-next] net/ncsi: Add NCSI Mellanox OEM command

2018-10-26 Thread Vijay Khemka
Thanks David On 10/26/18, 10:36 AM, "David Miller" wrote: From: Vijay Khemka Date: Fri, 26 Oct 2018 17:19:49 + > Do you have any timeline when it is going to open next or how do I > know. I always announce net-next openning and closing here on the list.

[PATCH v4 0/2] arm64: Get rid of __early_init_dt_declare_initrd()

2018-10-26 Thread Florian Fainelli
Hi all, I numbered this v4 because this is still revolving around the same initial desire to cut the build time of an ARM64 kernel when toggling CONFIG_BLK_DEV_INITRD. This 4th version is basically the 3rd possible way to just get rid of __early_init_dt_declare_initrd() for ARM64. I previously me

[PATCH v4 2/2] of/fdt: Remove definition check for __early_init_dt_declare_initrd()

2018-10-26 Thread Florian Fainelli
With the one and only architecture (ARM64) no longer defining a custom __early_init_dt_declare_initrd() function, just get rid of the check for that function being already defined. Signed-off-by: Florian Fainelli --- drivers/of/fdt.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/o

[PATCH v4 1/2] arm64: Get rid of __early_init_dt_declare_initrd()

2018-10-26 Thread Florian Fainelli
ARM64 is the only architecture that re-defines __early_init_dt_declare_initrd() in order for that function to populate initrd_start/initrd_end with physical addresses instead of virtual addresses. Instead of having an override, just get rid of that implementation and perform the virtual to physical

Re: Call to Action Re: [PATCH 0/7] Code of Conduct: Fix some wording, and add an interpretation document

2018-10-26 Thread NeilBrown
On Fri, Oct 26 2018, Rainer Fiebig wrote: > NeilBrown schrieb: >> On Thu, Oct 25 2018, Rainer Fiebig wrote: >> >>> Am Montag, 22. Oktober 2018, 08:20:11 schrieb NeilBrown: On Sat, Oct 20 2018, Greg Kroah-Hartman wrote: > Hi all, > > As everyone knows by now, we added a new Code o

Re: [PATCH v4] kernel/signal: Signal-based pre-coredump notification

2018-10-26 Thread Enke Chen
Hi, Olge: This is really a good idea given that "parent" is declared as RCU-protected. Just a bit odd, though, that the "parent" has not been accessed this way in the code base. So just to confirm: the revised code would look like the following: static void do_notify_parent_predump(void) {

[PATCH] x86: traps.c: use format string with panic() call

2018-10-26 Thread Rasmus Villemoes
Building with -Wformat-nonliteral gives arch/x86/kernel/traps.c:334:2: warning: format not a string literal and no format arguments [-Wformat-nonliteral] panic(message); handle_stack_overflow can only be called from two places (kernel/traps.c and via inline asm in mm/fault.c), in both cases wi

Re: [PATCH 1/2] x86/pkeys: copy pkey state at fork()

2018-10-26 Thread Andy Lutomirski
> On Oct 26, 2018, at 2:39 PM, Daniel Micay wrote: > > I ended up working around this with a pthread_atfork handler disabling > my usage of the feature in the child process for the time being. I > don't have an easy way to detect if the bug is present within a > library so Can you not just ma

Re: [PATCH 1/3] tracing: merge seq_print_sym_short() and seq_print_sym_offset()

2018-10-26 Thread Steven Rostedt
Hi Ramus, Thanks for sending these patches. I have some small nits though. First, please send a cover letter whenever sending more than one patch. It just groups them better in my inbox. The second is embedded below. On Fri, 26 Oct 2018 23:13:44 +0200 Rasmus Villemoes wrote: > These two fun

Re: [PATCH 1/2] x86/pkeys: copy pkey state at fork()

2018-10-26 Thread Daniel Micay
I ended up working around this with a pthread_atfork handler disabling my usage of the feature in the child process for the time being. I don't have an easy way to detect if the bug is present within a library so I'm going to need a kernel version check with a table of kernel releases fixing the pr

[PATCH] fs: proc: move linux_proc_banner to where it is used

2018-10-26 Thread Rasmus Villemoes
With -Wformat-literal, gcc complains fs/proc/version.c:11:16: warning: format not a string literal, argument types not checked [-Wformat-nonliteral] seq_printf(m, linux_proc_banner, linux_proc_banner is only used in this one place, so move the definition here, to allow the compiler to complain

Re: Git pull ack emails..

2018-10-26 Thread Mark Brown
On Fri, Oct 26, 2018 at 12:36:14PM -0500, Rob Herring wrote: > On Thu, Oct 25, 2018 at 9:14 AM Linus Torvalds > wrote: > > Are there other situations where you might want to track something > > _outside_ of a pull request? Maybe. I can't really think of a lot of > > them, though. Patches etc don'

[PATCH 3/3] tracing: simplify printf'ing in seq_print_sym

2018-10-26 Thread Rasmus Villemoes
trace_seq_printf(..., "%s", ...) can be done with trace_seq_puts() instead, avoiding printf overhead. In the second instance, the string we're copying was just created from an snprintf() to a stack buffer, so we might as well do that printf directly. This naturally leads to moving the declaration o

[PATCH 1/3] tracing: merge seq_print_sym_short() and seq_print_sym_offset()

2018-10-26 Thread Rasmus Villemoes
These two functions are nearly identical, so we can avoid some code duplication by moving the conditional into a common implementation. Signed-off-by: Rasmus Villemoes --- kernel/trace/trace_output.c | 34 +++--- 1 file changed, 7 insertions(+), 27 deletions(-) diff

[PATCH 2/3] tracing: avoid -Wformat-nonliteral warning

2018-10-26 Thread Rasmus Villemoes
Building with -Wformat-nonliteral, gcc complains kernel/trace/trace_output.c: In function ‘seq_print_sym’: kernel/trace/trace_output.c:356:3: warning: format not a string literal, argument types not checked [-Wformat-nonliteral] trace_seq_printf(s, fmt, name); But seq_print_sym only has a sin

Re: [PATCH v2 4/4] dts/arm64/layerscape: Clean PCIe controller compatible strings

2018-10-26 Thread Li Yang
On Thu, Oct 25, 2018 at 4:53 AM Z.q. Hou wrote: The correct prefix for arm64 dts patches should be: "arm64: dts: layerscape: ...", and it should be better to mention the string removed in the title too. > > From: Hou Zhiqiang > > Removed the wrong compatible string "snps,dw-pcie", in case > mat

[PATCH] mfd: ti_am335x_tscadc: release device nodes in ti_tscadc_probe()

2018-10-26 Thread Alexey Khoroshilov
ti_tscadc_probe() increments refcnt of tsc and adc device nodes and leaves it undecremented. Found by Linux Driver Verification project (linuxtesting.org). Signed-off-by: Alexey Khoroshilov --- drivers/mfd/ti_am335x_tscadc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/mfd/ti_

Re: [PATCH v2 3/4] dts/arm/ls1021a: Clean PCIe controller compatible strings

2018-10-26 Thread Li Yang
On Thu, Oct 25, 2018 at 4:52 AM Z.q. Hou wrote: The correct prefix for arm dts patches should be: "ARM: dts: ls1021a: ...", and it should be better to mention the string removed in the title too. > > From: Hou Zhiqiang > > Removed the wrong compatible string "snps,dw-pcie", in case > match inco

[GIT PULL] RTC for 4.20

2018-10-26 Thread Alexandre Belloni
Hi Linus, Here is the pull-request for the RTC subsystem for 4.20. This cycle, there were mostly non urgent fixes in drivers. I also finally unexported the non managed registration. The following changes since commit 5b394b2ddf0347bef56e50c69a58773c94343ff3: Linux 4.19-rc1 (2018-08-26 14:11:5

Re: [Outreachy kernel] [RESEND PATCH 2/2] staging: vboxvideo: Use unsigned int instead bool

2018-10-26 Thread Julia Lawall
[Adding Joe Perches] On Fri, 26 Oct 2018, Sasha Levin wrote: > On Fri, Oct 26, 2018 at 04:04:45PM -0300, Shayenne da Luz Moura wrote: > > This change was suggested by checkpath.pl. Use unsigned int with bitfield > > allocate only one bit to the boolean variable. > > > > CHECK: Avoid using bool st

[REGRESSION] OCTEON MMC driver failure with v4.19

2018-10-26 Thread Aaro Koskinen
Hi, OCTEON (MIPS64) MMC driver probe fails with v4.19, because with commit 6c2fb2ea76361da9b420a8e23a2a19e7842cbdda Author: Robin Murphy Date: Mon Jul 23 23:16:09 2018 +0100 of/device: Set bus DMA mask as appropriate we now get a default 32-bit bus DMA mask, and the device itself has 64-

Re: A concern about overflow ring buffer mode

2018-10-26 Thread Arnaldo Carvalho de Melo
Em Fri, Oct 26, 2018 at 04:11:51PM -0400, Liang, Kan escreveu: > > > On 10/26/2018 3:24 PM, Arnaldo Carvalho de Melo wrote: > > Em Fri, Oct 26, 2018 at 03:16:29PM -0400, Liang, Kan escreveu: > > > > > > > > > On 10/26/2018 3:12 PM, Arnaldo Carvalho de Melo wrote: > > > > Em Fri, Oct 26, 2018 at

Re: [Outreachy kernel] [RESEND PATCH 2/2] staging: vboxvideo: Use unsigned int instead bool

2018-10-26 Thread Sasha Levin
On Fri, Oct 26, 2018 at 04:04:45PM -0300, Shayenne da Luz Moura wrote: This change was suggested by checkpath.pl. Use unsigned int with bitfield allocate only one bit to the boolean variable. CHECK: Avoid using bool structure members because of possible alignment issues Signed-off-by: Shayenne

Re: [RFC 1/6] pstore: map pstore types to names

2018-10-26 Thread Kees Cook
On Fri, Oct 26, 2018 at 9:35 PM, Joel Fernandes wrote: > But I have the index variable, so it would be cleaner to just return that? I > believe I can just drop the cast and do that. Yeah, that should be fine. -- Kees Cook

Re: [PATCH v3] libata: Apply NOLPM quirk for SAMSUNG MZ7TD256HAFV-000L9

2018-10-26 Thread Diego Viola
On Fri, Oct 26, 2018 at 11:21 AM Jens Axboe wrote: > > On 10/26/18 7:45 AM, Diego Viola wrote: > > med_power_with_dipm causes my T450 to freeze with a SAMSUNG > > MZ7TD256HAFV-000L9 SSD (firmware DXT02L5Q). > > > > Switching the LPM to max_performance fixes this issue. > > Applied, thanks. > > --

Re: [RFC 1/6] pstore: map pstore types to names

2018-10-26 Thread Joel Fernandes
On Fri, Oct 26, 2018 at 08:04:24PM +0100, Kees Cook wrote: > On Fri, Oct 26, 2018 at 7:00 PM, Joel Fernandes (Google) > wrote: > > In later patches we will need to map types to names, so create a table > > for that which can also be used and reused in different parts of old and > > new code. Also

Re: [PATCH v4 4/8] regulator: stpmic1: add stpmic1 regulator driver

2018-10-26 Thread Mark Brown
On Thu, Oct 25, 2018 at 01:23:08PM +, Pascal PAILLET-LME wrote: > I have reworked the code so that we don't touch any more to the init_data. > the new loop to register the regulators is below: > > for (i = 0; i < ARRAY_SIZE(stpmic1_regulator_cfgs); i++) { > ret = stpmic1_regulat

Re: [PATCH v2 2/5] mfd: lochnagar: Add support for the Cirrus Logic Lochnagar

2018-10-26 Thread Mark Brown
On Fri, Oct 26, 2018 at 09:00:51AM +0100, Lee Jones wrote: > On Thu, 25 Oct 2018, Richard Fitzgerald wrote: > > Largely the point. How long do you think it would take to populate the > > cache if you had to read thousands of registers over I2C? Boot time matters. > > Deferring it until it's touche

Re: [GIT PULL] Please pull NFS client changes for Linux 4.20.

2018-10-26 Thread Linus Torvalds
On Fri, Oct 26, 2018 at 1:21 PM Trond Myklebust wrote: > > We agreed about a year or so ago to take turns maintaining the linux- > next branches. Heh. That was a simpler pattern than I thought. It was just hidden by the fact that there are sometimes more than one pull request during the merge win

Re: [RFC 5/6] pstore: donot treat empty buffers as valid

2018-10-26 Thread Joel Fernandes
On Fri, Oct 26, 2018 at 08:39:13PM +0100, Kees Cook wrote: > On Fri, Oct 26, 2018 at 7:00 PM, Joel Fernandes (Google) > wrote: > > pstore currently calls persistent_ram_save_old even if a buffer is > > empty. While this appears to work, it is simply not the right thing to > > do and could lead to

Re: [GIT PULL] Please pull NFS client changes for Linux 4.20.

2018-10-26 Thread Trond Myklebust
On Fri, 2018-10-26 at 13:10 -0700, Linus Torvalds wrote: > On Fri, Oct 26, 2018 at 8:45 AM Trond Myklebust < > tron...@hammerspace.com> wrote: > > > > NFS client updates for Linux 4.20 > > Pulled. Thank you! > Btw, just out of curiosity - is there some pattern to when I get the > pull requests

bluetooth serdev driver for wi2wi w2cbw003?

2018-10-26 Thread H. Nikolaus Schaller
Hi, what is the best strategy to support the above mentioned bluetooth (+ wlan combo) chip by a serdev driver? We have the chip up and running for long time with using hciattach on the serial port (and no vendor specific functions like firmware download). And our own out-of-tree driver to control

Re: [PATCH v2 09/10] irqchip: ti-sci-inta: Add support for Interrupt Aggregator driver

2018-10-26 Thread Lokesh Vutla
Hi Marc, [..snip..] [...] +/** + * ti_sci_inta_register_event() - Register a event to an interrupt aggregator + * @dev: Device pointer to source generating the event + * @src_id:TISCI device ID of the event source + * @src_index: Event source index within the device. + * @virq:

Re: A concern about overflow ring buffer mode

2018-10-26 Thread Liang, Kan
On 10/26/2018 3:24 PM, Arnaldo Carvalho de Melo wrote: Em Fri, Oct 26, 2018 at 03:16:29PM -0400, Liang, Kan escreveu: On 10/26/2018 3:12 PM, Arnaldo Carvalho de Melo wrote: Em Fri, Oct 26, 2018 at 03:07:40PM -0400, Liang, Kan escreveu: On 10/26/2018 3:02 PM, Arnaldo Carvalho de Melo wrote

Re: [GIT PULL] Please pull NFS client changes for Linux 4.20.

2018-10-26 Thread Linus Torvalds
On Fri, Oct 26, 2018 at 8:45 AM Trond Myklebust wrote: > > NFS client updates for Linux 4.20 Pulled. Btw, just out of curiosity - is there some pattern to when I get the pull requests from you vs Anna? Or is it just "whoever happens to have the baton"? Not that it matters, but I was wondering if

Re: [RFC 6/6] Revert "pstore/ram_core: Do not reset restored zone's position and size"

2018-10-26 Thread Joel Fernandes
On Fri, Oct 26, 2018 at 08:42:12PM +0100, Kees Cook wrote: > On Fri, Oct 26, 2018 at 7:22 PM, Joel Fernandes > wrote: > > On Fri, Oct 26, 2018 at 07:16:28PM +0100, Kees Cook wrote: > >> On Fri, Oct 26, 2018 at 7:00 PM, Joel Fernandes (Google) > >> wrote: > >> > This reverts commit 25b63da6470821

Re: [PATCH 1/2] x86/pkeys: copy pkey state at fork()

2018-10-26 Thread Dave Hansen
On 10/26/18 12:51 PM, Dave Hansen wrote: ... > The result is that, after a fork(), the child's pkey state ends up > looking like it does after an execve(), which is totally wrong. pkeys > that are already allocated can be allocated again, for instance. One thing I omitted. This was very nicely d

[PATCH 1/2] x86/pkeys: copy pkey state at fork()

2018-10-26 Thread Dave Hansen
From: Dave Hansen Our creation of new mm's is a bit convoluted. At fork(), the code does: 1. memcpy() the parent mm to initialize child 2. mm_init() to initalize some select stuff stuff 3. dup_mmap() to create true copies that memcpy() did not do right. For

[PATCH 2/2] x86/selftests/pkeys: fork() to check for state being preserved

2018-10-26 Thread Dave Hansen
From: Dave Hansen There was a bug where the per-mm pkey state was not being preserved across fork() in the child. fork() is performed in the pkey selftests, but all of our pkey activity is performed in the parent. The child does not perform any actions sensitive to pkey state. To make the tes

Re: More checks for patterns? was: Fix pattern handling optimalization

2018-10-26 Thread Jacek Anaszewski
On 10/25/2018 11:24 PM, Pavel Machek wrote: > > We don't want brightness < 0, but this may not be best way to do > this. We also don't want brightness > max_brightness, but I'm not sure > this check is effective. > > We probably also don't want pattern where all the delta_t s are zero. > > I cam

Re: [RFC 6/6] Revert "pstore/ram_core: Do not reset restored zone's position and size"

2018-10-26 Thread Kees Cook
On Fri, Oct 26, 2018 at 7:22 PM, Joel Fernandes wrote: > On Fri, Oct 26, 2018 at 07:16:28PM +0100, Kees Cook wrote: >> On Fri, Oct 26, 2018 at 7:00 PM, Joel Fernandes (Google) >> wrote: >> > This reverts commit 25b63da64708212985c06c7f8b089d356efdd9cf. >> > >> > Due to the commit which is being r

Re: [RFC 3/6] pstore: remove max argument from ramoops_get_next_prz

2018-10-26 Thread Joel Fernandes
On Fri, Oct 26, 2018 at 08:27:49PM +0100, Kees Cook wrote: > On Fri, Oct 26, 2018 at 8:22 PM, Joel Fernandes > wrote: > > On Fri, Oct 26, 2018 at 11:00:39AM -0700, Joel Fernandes (Google) wrote: > >> From the code flow, the 'max' checks are already being done on the prz > >> passed to ramoops_get

Re: [RFC 5/6] pstore: donot treat empty buffers as valid

2018-10-26 Thread Kees Cook
On Fri, Oct 26, 2018 at 7:00 PM, Joel Fernandes (Google) wrote: > pstore currently calls persistent_ram_save_old even if a buffer is > empty. While this appears to work, it is simply not the right thing to > do and could lead to bugs so lets avoid that. It also prevent misleading > prints in the l

Re: [RFC 4/6] pstore: further reduce ramoops_get_next_prz arguments by passing record

2018-10-26 Thread Joel Fernandes
On Fri, Oct 26, 2018 at 08:32:16PM +0100, Kees Cook wrote: > On Fri, Oct 26, 2018 at 7:00 PM, Joel Fernandes (Google) > wrote: > > Both the id and type fields of a pstore_record are set by > > ramoops_get_next_prz. So we can just pass a pointer to the pstore_record > > instead of passing individua

[PATCH] scheduler: wait: Added missing include freezer.h

2018-10-26 Thread Carmeli Tamir
The function 'wait_event_freezable' calls '__wait_event_freezable' that uses 'try_to_freeze', which is defined in freezer.h. This causes a compilation error for callers of 'wait_event_freezables', forcing them to include also freezer.h. Signed-off-by: Carmeli Tamir --- include/linux/wait.h | 1 +

[GIT PULL] LED fix for 4.20-rc1

2018-10-26 Thread Jacek Anaszewski
Hi Linus, Please pull one LED fix for 4.20-rc1. The patch fixes regression introduced by the commit 45d4c6de4e49 ("leds: gpio: Try to lookup gpiod from device"). The following changes since commit 8dbac65f5c181e4723586ab738b703bb23bc3f2a: leds: sc27xx: Add pattern_set/clear interfaces for LED

Re: [RFC PATCH 2/2] memcg: do not report racy no-eligible OOM tasks

2018-10-26 Thread Michal Hocko
On Fri 26-10-18 21:25:51, Michal Hocko wrote: > On Fri 26-10-18 10:25:31, Johannes Weiner wrote: [...] > > There is of course the scenario brought forward in this thread, where > > multiple threads of a process race and the second one enters oom even > > though it doesn't need to anymore. What the

Re: [RFC 4/6] pstore: further reduce ramoops_get_next_prz arguments by passing record

2018-10-26 Thread Kees Cook
On Fri, Oct 26, 2018 at 7:00 PM, Joel Fernandes (Google) wrote: > Both the id and type fields of a pstore_record are set by > ramoops_get_next_prz. So we can just pass a pointer to the pstore_record > instead of passing individual elements. This results in cleaner more > readable code and fewer li

Re: [RFC 3/6] pstore: remove max argument from ramoops_get_next_prz

2018-10-26 Thread Kees Cook
On Fri, Oct 26, 2018 at 8:22 PM, Joel Fernandes wrote: > On Fri, Oct 26, 2018 at 11:00:39AM -0700, Joel Fernandes (Google) wrote: >> From the code flow, the 'max' checks are already being done on the prz >> passed to ramoops_get_next_prz. Lets remove it to simplify this function >> and reduce its

Re: [RFC PATCH 2/2] memcg: do not report racy no-eligible OOM tasks

2018-10-26 Thread Michal Hocko
On Fri 26-10-18 10:25:31, Johannes Weiner wrote: > On Mon, Oct 22, 2018 at 09:13:23AM +0200, Michal Hocko wrote: > > From: Michal Hocko > > > > Tetsuo has reported [1] that a single process group memcg might easily > > swamp the log with no-eligible oom victim reports due to race between > > the

Re: A concern about overflow ring buffer mode

2018-10-26 Thread Arnaldo Carvalho de Melo
Em Fri, Oct 26, 2018 at 03:16:29PM -0400, Liang, Kan escreveu: > > > On 10/26/2018 3:12 PM, Arnaldo Carvalho de Melo wrote: > > Em Fri, Oct 26, 2018 at 03:07:40PM -0400, Liang, Kan escreveu: > > > On 10/26/2018 3:02 PM, Arnaldo Carvalho de Melo wrote: > > > > So, I'm adding the following to my tr

Re: [RFC 3/6] pstore: remove max argument from ramoops_get_next_prz

2018-10-26 Thread Kees Cook
On Fri, Oct 26, 2018 at 7:00 PM, Joel Fernandes (Google) wrote: > From the code flow, the 'max' checks are already being done on the prz > passed to ramoops_get_next_prz. Lets remove it to simplify this function > and reduce its arguments. > > Signed-off-by: Joel Fernandes (Google) > --- > fs/ps

[PATCH 2/6] drm/qxl: Add line after variable declarations

2018-10-26 Thread Shayenne da Luz Moura
Add whiteline after variable declarations to remove the checkpath.pl warning: WARNING: Missing a blank line after declarations Signed-off-by: Shayenne da Luz Moura --- drivers/gpu/drm/qxl/qxl_cmd.c | 4 drivers/gpu/drm/qxl/qxl_display.c | 2 ++ drivers/gpu/drm/qxl/qxl_draw.c| 2 ++

Re: [RFC 3/6] pstore: remove max argument from ramoops_get_next_prz

2018-10-26 Thread Joel Fernandes
On Fri, Oct 26, 2018 at 11:00:39AM -0700, Joel Fernandes (Google) wrote: > From the code flow, the 'max' checks are already being done on the prz > passed to ramoops_get_next_prz. Lets remove it to simplify this function > and reduce its arguments. > > Signed-off-by: Joel Fernandes (Google) > ---

Re: A concern about overflow ring buffer mode

2018-10-26 Thread Liang, Kan
On 10/26/2018 3:12 PM, Arnaldo Carvalho de Melo wrote: Em Fri, Oct 26, 2018 at 03:07:40PM -0400, Liang, Kan escreveu: On 10/26/2018 3:02 PM, Arnaldo Carvalho de Melo wrote: So, I'm adding the following to my tree to help in diagnosing problems with this overwrite mode: Actually, you can

Re: [GIT PULL] Devicetree updates for 4.20

2018-10-26 Thread Linus Torvalds
On Fri, Oct 26, 2018 at 9:07 AM Rob Herring wrote: > > Please pull DT updates for 4.20. Pulled, Linus

  1   2   3   4   5   >