Re: [PATCH] pinctrl: sprd: Use define directive for sprd_pinconf_params values

2018-10-31 Thread Baolin Wang
On 1 November 2018 at 08:44, Nathan Chancellor wrote: > Clang warns when one enumerated type is implicitly converted to another: > > drivers/pinctrl/sprd/pinctrl-sprd.c:845:19: warning: implicit conversion > from enumeration type 'enum sprd_pinconf_params' to different > enumeration type 'enum

Re: INFO: rcu detected stall in do_idle

2018-10-31 Thread Juri Lelli
On 31/10/18 18:58, Daniel Bristot de Oliveira wrote: > On 10/31/18 5:40 PM, Juri Lelli wrote: > > On 31/10/18 17:18, Daniel Bristot de Oliveira wrote: > >> On 10/30/18 12:08 PM, luca abeni wrote: > >>> Hi Peter, > >>> > >>> On Tue, 30 Oct 2018 11:45:54 +0100 > >>> Peter Zijlstra wrote: > >>>

[GIT PULL] Addition of the I3C subsystem in 4.20 (5.0)?

2018-10-31 Thread Boris Brezillon
Hello Greg, Linus, Greg, I didn't get your feedback on v10 of the i3c patchset [1] where I was asking if you'd agree to have this framework merged in 4.20 (I know you were busy with the 4.19 release and after that the Kernel Summit, so that's not a surprise), so I'm sending this PR. It's really

[GIT PULL] fixup dtb Kbuild for C-SKY(csky) Port

2018-10-31 Thread Guo Ren
Please pull this to fixup dtb Kbuild rules for csky subsystem. The following changes since commit ac435075892e3e651c667b4a9f2267cf3ef1d5a2: Merge tag 'csky-for-linus-4.20' of https://github.com/c-sky/csky-linux (2018-10-29 08:25:00 -0700) are available in the git repository at:

[PATCH v2 2/2] RISC-V: defconfig: Enable printk timestamps

2018-10-31 Thread Anup Patel
The printk timestamps are very useful information to visually see where kernel is spending time during boot. It also helps us see the timing of hotplug events at runtime. This patch enables printk timestamps in RISC-V defconfig so that we have it enabled by default (similar to other architectures

[PATCH v2 1/2] RISC-V: refresh defconfig

2018-10-31 Thread Anup Patel
This patch updates defconfig using savedefconfig on Linux-4.19. Signed-off-by: Anup Patel --- arch/riscv/configs/defconfig | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/arch/riscv/configs/defconfig b/arch/riscv/configs/defconfig index

Re: [PATCH v1 2/2] clk: qcom : dispcc: Add support for display port clocks

2018-10-31 Thread Taniya Das
+ Chandan from Display Port team, On 10/30/2018 10:03 PM, Stephen Boyd wrote: Quoting Taniya Das (2018-10-29 23:01:44) On 10/30/2018 12:13 AM, Stephen Boyd wrote: Quoting Taniya Das (2018-10-28 03:34:55) On 2018-10-19 16:04, Taniya Das wrote: On 10/10/2018 2:04 AM, Stephen Boyd wrote:

Re: [RFC] doc: rcu: remove note on smp_mb during synchronize_rcu

2018-10-31 Thread Joel Fernandes
On Wed, Oct 31, 2018 at 11:17:48AM -0700, Paul E. McKenney wrote: > On Tue, Oct 30, 2018 at 06:11:19PM -0700, Joel Fernandes wrote: > > Hi Paul, > > > > On Tue, Oct 30, 2018 at 04:43:36PM -0700, Paul E. McKenney wrote: > > > On Tue, Oct 30, 2018 at 03:26:49PM -0700, Joel Fernandes wrote: > > > >

Re: [RFC PATCH] Implement /proc/pid/kill

2018-10-31 Thread Andy Lutomirski
On Wed, Oct 31, 2018 at 9:23 AM Jann Horn wrote: > > +linux-api, Andy Lutomirski, Eric Biederman > > On Wed, Oct 31, 2018 at 3:12 AM Daniel Colascione wrote: > > Add a simple proc-based kill interface. To use /proc/pid/kill, just > > write the signal number in base-10 ASCII to the kill file of

Re: [PATCH] ata: add Buddha PATA controller driver

2018-10-31 Thread Michael Schmitz
Hi Adrian, my fix is evidently incomplete - I just crashed elgar trying to remove the pata_buddha module, sorry. Must've done something silly. So no, can't post a patch to add module_exit just yet. Cheers, Michael Am 31.10.2018 um 23:06 schrieb John Paul Adrian Glaubitz: Hi! On

Re: [PATCH] RISC-V: defconfig: Enable printk timestamps

2018-10-31 Thread Anup Patel
On Thu, Nov 1, 2018 at 4:20 AM Olof Johansson wrote: > > On Wed, Oct 31, 2018 at 1:42 PM Palmer Dabbelt wrote: > > > > On Wed, 31 Oct 2018 12:20:40 PDT (-0700), Olof Johansson wrote: > > > On Tue, Oct 30, 2018 at 5:37 AM Anup Patel wrote: > > >> > > >> The printk timestamps are very useful

Re: [LKP] b179f0826c BUG: kernel hang in boot stage

2018-10-31 Thread Stephen Rothwell
Hi all, On Thu, 1 Nov 2018 09:13:07 +0800 kernel test robot wrote: > > Greetings, > > 0day kernel testing robot got the below dmesg and the first bad commit is > > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master > > commit b179f0826c6a13563c5ce0554c6da6748a1fa699 >

Re: [PATCH v6 0/1] ns: introduce binfmt_misc namespace

2018-10-31 Thread Jann Horn
On Thu, Nov 1, 2018 at 3:59 AM James Bottomley wrote: > > On Tue, 2018-10-16 at 11:52 +0200, Laurent Vivier wrote: > > Hi, > > > > Any comment on this last version? > > > > Any chance to be merged? > > I've got a use case for this: I went to one of the Graphene talks in > Edinburgh and it struck

linux-next: Tree for Nov 1

2018-10-31 Thread Stephen Rothwell
Hi all, Please do not add any v4.21/v5.1 code to your linux-next included trees until after the merge window closes. Changes since 20181031: My fixes tree contains this: "drivers: net: include linux/ip.h for iphdr" Non-merge commits (relative to Linus' tree): 790 953 files chan

Re: linux-next: Tree for Oct 31 (vboxguest)

2018-10-31 Thread Masahiro Yamada
Hi Arnd, On Thu, Nov 1, 2018 at 6:42 AM Arnd Bergmann wrote: > > On 10/31/18, Randy Dunlap wrote: > > On 10/30/18 8:59 PM, Stephen Rothwell wrote: > >> Hi all, > >> > >> Please do not add any v4.21/v5.1 code to your linux-next included trees > >> until after the merge window closes. > >> > >>

Re: [PATCH v3 4/5] modpost: Changes parameter name to avoid shadowing.

2018-10-31 Thread Leonardo Bras
Em qua, 2018-10-31 às 20:24 -0300, Leonardo Bras escreveu: > Em seg, 2018-10-29 às 01:42 +0900, Masahiro Yamada escreveu: > > On Wed, Oct 24, 2018 at 1:05 PM Leonardo Bras > > wrote: > > > Changes the parameter name to avoid shadowing a variable. > > > > > > Signed-off-by: Leonardo Bras > > >

[PATCH 1/1] modpost: Refactor and removes global variable *modules

2018-10-31 Thread Leonardo Bras
Refactors the code to accept the modules list as a parameter in the functions that need it, and moves the variable from the global scope to the main function scope. This also fixes the parameter shadowing of add_depends. Signed-off-by: Leonardo Bras --- scripts/mod/modpost.c | 39

Re: [PATCH 16/17] prmem: pratomic-long

2018-10-31 Thread Kees Cook
On Wed, Oct 31, 2018 at 2:10 AM, Peter Zijlstra wrote: > On Tue, Oct 30, 2018 at 04:28:16PM +, Will Deacon wrote: >> On Tue, Oct 30, 2018 at 04:58:41PM +0100, Peter Zijlstra wrote: >> > Like mentioned elsewhere; if you do write_enable() + write_disable() >> > thingies, it all becomes: >> > >>

Re: [PATCH v1 2/2] x86/hyperv: make HvNotifyLongSpinWait hypercall

2018-10-31 Thread Yi Sun
On 18-10-31 18:15:39, Peter Zijlstra wrote: > On Wed, Oct 31, 2018 at 11:07:22AM -0400, Waiman Long wrote: > > On 10/31/2018 10:10 AM, Peter Zijlstra wrote: > > > On Wed, Oct 31, 2018 at 09:54:17AM +0800, Yi Sun wrote: > > >> On 18-10-23 17:33:28, Yi Sun wrote: > > >>> On 18-10-23 10:51:27, Peter

Re: [Ocfs2-devel] [PATCH V2] ocfs2: fix dead lock caused by ocfs2_defrag_extent

2018-10-31 Thread Changwei Ge
Hi Larry, I still have a few tiny comments for your patch, please refer to them. On 2018/11/1 5:28, Andrew Morton wrote: > > Folks, could we please review this patch for upstream inclusion? > > Thanks. > > > From: Larry Chen > Subject: ocfs2: fix deadlock caused by ocfs2_defrag_extent > >

[PATCH 1/3] modpost: Refactor and removes global variable *modules

2018-10-31 Thread Leonardo Bras
Refactors the code to accept the modules list as a parameter in the functions that need it, and moves the variable from the global scope to the main function scope. This also fixes the parameter shadowing of add_depends. Signed-off-by: Leonardo Bras --- scripts/mod/modpost.c | 39

[Patch v2] genirq/matrix: Choose CPU for assigning interrupts based on allocated IRQs

2018-10-31 Thread Long Li
From: Long Li On a large system with multiple devices of the same class (e.g. NVMe disks, using managed IRQs), the kernel tends to concentrate their IRQs on several CPUs. The issue is that when NVMe calls irq_matrix_alloc_managed(), the assigned CPU tends to be the first several CPUs in the

[GIT PULL] platform-drivers-x86 for 4.20-1

2018-10-31 Thread Darren Hart
Hi Linus, This tag has a few merge conflicts with some x86/cpu id changes. Stephen Rothwell's merge in next/master is correct, and I have provided an example here as well: git://git.infradead.org/linux-platform-drivers-x86.git pdx86-v4.20-1-merge Thanks, Darren Hart VMware Open Source

Re: [PATCH v6 0/1] ns: introduce binfmt_misc namespace

2018-10-31 Thread James Bottomley
On Tue, 2018-10-16 at 11:52 +0200, Laurent Vivier wrote: > Hi, > > Any comment on this last version? > > Any chance to be merged? I've got a use case for this: I went to one of the Graphene talks in Edinburgh and it struck me that we seem to keep reinventing the type of sandboxing that

[PATCH] objtool: Support GCC 9 cold subfunction naming scheme

2018-10-31 Thread Josh Poimboeuf
Starting with GCC 8, a lot of unlikely code was moved out of line to "cold" subfunctions in .text.unlikely. For example, the unlikely bits of: irq_do_set_affinity() are moved out to the following subfunction: irq_do_set_affinity.cold.49() Starting with GCC 9, the numbered suffix has been

Re: linux-next: build warning in Linus' tree tree

2018-10-31 Thread Mauro Carvalho Chehab
Em Thu, 1 Nov 2018 08:28:20 +1100 Stephen Rothwell escreveu: > Hi all, > > Building Linus' tree, today's linux-next build (x86_64 allmodconfig) > produced this warning: > > ./usr/include/linux/v4l2-controls.h:1105: found __[us]{8,16,32,64} type > without #include > > Introduced by commit >

[PATCH -next] firewire: net: remove set but not used variable 'guid'

2018-10-31 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/firewire/net.c:488:9: warning: variable ‘guid’ set but not used [-Wunused-but-set-variable] It not used anymore after commit 6752c8db8e0c ("firewire net, ipv4 arp: Extend hardware address and remove driver-level packet inspection.")

[PATCH -next] edac: i82975x: remove set but not used variable 'dtype'

2018-10-31 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/edac/i82975x_edac.c:378:16: warning: variable ‘dtype’ set but not used [-Wunused-but-set-variable] It never used since introduction in commit 084a4fccef39 ("edac: move dimm properties to struct dimm_info") Signed-off-by: YueHaibing ---

make[3]: *** No rule to make target 'arch/mips/boot/dts/brcm/bcm93384wvg.dtb', needed by '__build'.

2018-10-31 Thread kbuild test robot
Hi Rob, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 5b7449810ae6d652629c550d3974c8453836d229 commit: 37c8a5fafa3bb7dcdd51774be353be6cb2912b86 kbuild: consolidate Devicetree dtb build rules date: 4 weeks ago

Re: [patch 8/9] posix-clocks: Remove license boiler plate

2018-10-31 Thread Richard Cochran
On Wed, Oct 31, 2018 at 07:21:15PM +0100, Thomas Gleixner wrote: > The SPDX identifier defines the license of the file already. No need for > the boilerplate. > > Signed-off-by: Thomas Gleixner > Cc: Richard Cochran > --- > > @Richard: This file is (C) OMICRON, but I don't have a contact >

Re: [PATCH 3/3] kprobes/x86: Simplify indirect-jump check in retpoline

2018-10-31 Thread Zhenzhong Duan
On 2018/10/31 22:00, Peter Zijlstra wrote: On Wed, Oct 31, 2018 at 02:53:20PM +0100, Peter Zijlstra wrote: On Wed, Oct 31, 2018 at 02:01:20PM +0800, Zhenzhong Duan wrote: On 2018/10/30 16:36, Peter Zijlstra wrote: On Mon, Oct 29, 2018 at 11:55:06PM -0700, Zhenzhong Duan wrote: Since

[PATCH v1 2/3] clk: tegra: ignore unused vfir clock shared with uartb

2018-10-31 Thread Marcel Ziswiler
From: Marcel Ziswiler As UARTB and VFIR share their clock enable bit it is rather unwise for the kernel to turn off the VFIR one should that be unused (and potentially vice versa but so far there anyway is no VFIR driver). Without this patch trying to use UARTB with the regular 8250 driver will

[PATCH v1 3/3] serial: tegra: fix some spelling mistakes

2018-10-31 Thread Marcel Ziswiler
From: Marcel Ziswiler Fix a few spelling mistakes I stumbled upon while debugging a customers UART issues. Signed-off-by: Marcel Ziswiler --- drivers/tty/serial/serial-tegra.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/tty/serial/serial-tegra.c

[PATCH v1 1/3] clk: tegra: get rid of duplicate defines

2018-10-31 Thread Marcel Ziswiler
From: Marcel Ziswiler Get rid of 3 duplicate defines. Signed-off-by: Marcel Ziswiler --- drivers/clk/tegra/clk-tegra-periph.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/clk/tegra/clk-tegra-periph.c b/drivers/clk/tegra/clk-tegra-periph.c index 38c4eb28c8bf..cc5275ec2c01

[PATCH v1 0/3] clk/serial tegra: uart related fixes

2018-10-31 Thread Marcel Ziswiler
This series features some UART related clock issue fix and clean-up. Marcel Ziswiler (3): clk: tegra: get rid of duplicate defines clk: tegra: ignore unused vfir clock shared with uartb serial: tegra: fix some spelling mistakes drivers/clk/tegra/clk-tegra-periph.c | 5 +

Re: [PATCHv3] panic: avoid deadlocks in re-entrant console drivers

2018-10-31 Thread Sergey Senozhatsky
On (10/31/18 13:27), Petr Mladek wrote: > > > > Signed-off-by: Sergey Senozhatsky > > The patch makes sense to me. The locks should stay busted also for > console_flush_on_panic(). > > With the added #include : > > Reviewed-by: Petr Mladek Thanks! Since there are no objections - how shall

[GIT] Sparc

2018-10-31 Thread David Miller
Two small fixes, please pull. Thanks! The following changes since commit 4b42745211af552f170f38a1b97f4a112b5da6b2: Merge tag 'armsoc-soc' of git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc (2018-10-29 15:37:33 -0700) are available in the Git repository at:

Re: [PATCH 0/3] RISC-V: A few build/warning fixes and cleanup

2018-10-31 Thread Fengguang Wu
CC Philip, current kbuild test robot maintainer. On Wed, Oct 31, 2018 at 12:12:21PM -0600, Logan Gunthorpe wrote: On 2018-10-31 11:52 a.m., Olof Johansson wrote: I've migrated machines to a new system and that CI is up and running. Right now the emails don't go anywhere but me, but let me

Re: [Patch v4 3/3] CIFS: Add direct I/O functions to file_operations

2018-10-31 Thread Steve French
made minor cleanup to patch 1 and 2, added Ronnie's reviewed to patch 3, and tentatively merged to cifs-2.6.git for-next On Wed, Oct 31, 2018 at 5:16 PM Long Li wrote: > > From: Long Li > > With direct read/write functions implemented, add them to file_operations. > > Dircet I/O is used under

Re: [PATCH AUTOSEL 3.18 22/22] mfd: menelaus: Fix possible race condition and leak

2018-10-31 Thread Sasha Levin
On Thu, Nov 01, 2018 at 01:27:08AM +0100, Alexandre Belloni wrote: Hello, On 31/10/2018 19:12:06-0400, Sasha Levin wrote: - m->rtc = rtc_device_register(DRIVER_NAME, - >client->dev, - _rtc_ops, THIS_MODULE); - if (IS_ERR(m->rtc)) { +

Randomize address space after each fork

2018-10-31 Thread cerberus cerberus
Randomize address space after each fork ~~ I might be entirely wrong with what I write and the solution proposed thereafter, yet I want to raise awareness that with current linux kernels it is possible to leak (at least) heap addresses in an attempt to

arch/x86/include/asm/rmwcc.h:23:17: error: jump into statement expression

2018-10-31 Thread kbuild test robot
Hi Peter, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 5b7449810ae6d652629c550d3974c8453836d229 commit: 7aa54be2976550f17c11a1c3e3630002dea39303 locking/qspinlock, x86: Provide liveness guarantee date: 2 weeks

Re: sound/pci/hda/patch_ca0132.c:7650:20: error: implicit declaration of function 'pci_iomap'; did you mean 'pcim_iomap'?

2018-10-31 Thread Randy Dunlap
On 10/31/18 5:48 PM, kbuild test robot wrote: > Hi Rakesh, > > FYI, the error/warning still remains. > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > master > head: 5b7449810ae6d652629c550d3974c8453836d229 > commit: 6bae5ea9498926440ffc883f3dbceb0adc65e492

net/sunrpc/auth_gss/gss_krb5_seal.c:144:14: error: implicit declaration of function 'cmpxchg64'; did you mean 'cmpxchg'?

2018-10-31 Thread kbuild test robot
Hi Arnd, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 5b7449810ae6d652629c550d3974c8453836d229 commit: 21924765862a0871908a35cb0e53e2e1c169b888 SUNRPC: use cmpxchg64() in gss_seq_send64_fetch_and_inc() date: 4

[PATCH] pinctrl: zynq: Use define directive for PIN_CONFIG_IO_STANDARD

2018-10-31 Thread Nathan Chancellor
Clang warns when one enumerated type is implicitly converted to another: drivers/pinctrl/pinctrl-zynq.c:985:18: warning: implicit conversion from enumeration type 'enum zynq_pin_config_param' to different enumeration type 'enum pin_config_param' [-Wenum-conversion] {"io-standard",

Re: [RFC 0/2] RISC-V: A proposal to add vendor-specific code

2018-10-31 Thread Alan Kao
On Wed, Oct 31, 2018 at 07:17:45AM -0700, Christoph Hellwig wrote: > On Wed, Oct 31, 2018 at 04:46:10PM +0530, Anup Patel wrote: > > I agree that we need a place for vendor-specific ISA extensions and > > having vendor-specific directories is also good. > > The only sensible answer is that we

[PATCH] rtc: omap: Use define directive for PIN_CONFIG_ACTIVE_HIGH

2018-10-31 Thread Nathan Chancellor
Clang warns when one enumerated type is implicitly converted to another: drivers/rtc/rtc-omap.c:574:21: warning: implicit conversion from enumeration type 'enum rtc_pin_config_param' to different enumeration type 'enum pin_config_param' [-Wenum-conversion] {"ti,active-high",

[PATCH] pinctrl: lpc18xx: Use define directive for PIN_CONFIG_GPIO_PIN_INT

2018-10-31 Thread Nathan Chancellor
Clang warns when one enumerated type is implicitly converted to another: drivers/pinctrl/pinctrl-lpc18xx.c:643:29: warning: implicit conversion from enumeration type 'enum lpc18xx_pin_config_param' to different enumeration type 'enum pin_config_param' [-Wenum-conversion]

[PATCH] pinctrl: max77620: Use define directive for max77620_pinconf_param values

2018-10-31 Thread Nathan Chancellor
Clang warns when one enumerated type is implicitly converted to another: drivers/pinctrl/pinctrl-max77620.c:56:12: warning: implicit conversion from enumeration type 'enum max77620_pinconf_param' to different enumeration type 'enum pin_config_param' [-Wenum-conversion] .param =

Re: [PATCH v3 1/8] selftests/resctrl: Add README for resctrl tests

2018-10-31 Thread Randy Dunlap
On 10/31/18 2:02 PM, Fenghua Yu wrote: > resctrl tests will be implemented. README is added for the tool first. > > Signed-off-by: Fenghua Yu Hi, > --- > tools/testing/selftests/resctrl/README | 53 > ++ > 1 file changed, 53 insertions(+) > create mode 100644

sound/pci/hda/patch_ca0132.c:7650:20: error: implicit declaration of function 'pci_iomap'; did you mean 'pcim_iomap'?

2018-10-31 Thread kbuild test robot
Hi Rakesh, FYI, the error/warning still remains. tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 5b7449810ae6d652629c550d3974c8453836d229 commit: 6bae5ea9498926440ffc883f3dbceb0adc65e492 ASoC: hdac_hda: add asoc extension for legacy HDA codec drivers

[PATCH] pinctrl: bcm2835: Use define directive for BCM2835_PINCONF_PARAM_PULL

2018-10-31 Thread Nathan Chancellor
Clang warns when one enumerated type is implicitly converted to another: drivers/pinctrl/bcm/pinctrl-bcm2835.c:707:40: warning: implicit conversion from enumeration type 'enum bcm2835_pinconf_param' to different enumeration type 'enum pin_config_param' [-Wenum-conversion] configs[0] =

[PATCH] pinctrl: sprd: Use define directive for sprd_pinconf_params values

2018-10-31 Thread Nathan Chancellor
Clang warns when one enumerated type is implicitly converted to another: drivers/pinctrl/sprd/pinctrl-sprd.c:845:19: warning: implicit conversion from enumeration type 'enum sprd_pinconf_params' to different enumeration type 'enum pin_config_param' [-Wenum-conversion] {"sprd,control",

Re: [PATCH v2 11/11] ext4: access to uninitialized bh fields in ext4_xattr_set_handle()

2018-10-31 Thread Andreas Dilger
On Oct 30, 2018, at 9:39 PM, Vasily Averin wrote: > > On 10/31/2018 04:30 AM, Andreas Dilger wrote: >> Could you please explain your statement below that on-stack >> initialization does not zero unspecified fields? According >> to documents I found, for example: >> >>

[PATCH 1/1] irq/matrix: Fix memory overallocation

2018-10-31 Thread Michael Kelley
IRQ_MATRIX_SIZE is the number of longs needed for a bitmap, multiplied by the size of a long, yielding a byte count. But it is used as the size of an array of longs, which is way more memory than is needed. Change IRQ_MATRIX_SIZE so it is just the number of longs needed and the arrays come out

Re: [PATCH AUTOSEL 3.18 22/22] mfd: menelaus: Fix possible race condition and leak

2018-10-31 Thread Alexandre Belloni
Hello, On 31/10/2018 19:12:06-0400, Sasha Levin wrote: > - m->rtc = rtc_device_register(DRIVER_NAME, > - >client->dev, > - _rtc_ops, THIS_MODULE); > - if (IS_ERR(m->rtc)) { > + err = rtc_register_device(m->rtc); This appeared in v4.13, this

[PATCHv6 1/7] tty/ldsem: Wake up readers after timed out down_write()

2018-10-31 Thread Dmitry Safonov
ldsem_down_read() will sleep if there is pending writer in the queue. If the writer times out, readers in the queue should be woken up, otherwise they may miss a chance to acquire the semaphore until the last active reader will do ldsem_up_read(). There was a couple of reports where there was one

[PATCHv6 5/7] tty/ldsem: Convert to regular lockdep annotations

2018-10-31 Thread Dmitry Safonov
From: Peter Zijlstra For some reason ldsem has its own lockdep wrappers, make them go away. Cc: Greg Kroah-Hartman Cc: Jiri Slaby Signed-off-by: Peter Zijlstra (Intel) Signed-off-by: Dmitry Safonov --- drivers/tty/tty_ldsem.c | 51 +++-- 1 file changed,

[PATCHv6 4/7] tty: Simplify tty->count math in tty_reopen()

2018-10-31 Thread Dmitry Safonov
As notted by Jiri, tty_ldisc_reinit() shouldn't rely on tty counter. Simplify math by increasing the counter after reinit success. Cc: Greg Kroah-Hartman Cc: Jiri Slaby Link: lkml.kernel.org/r/<20180829022353.23568-2-d...@arista.com> Suggested-by: Jiri Slaby Reviewed-by: Jiri Slaby Tested-by:

[PATCHv6 6/7] tty/ldsem: Add lockdep asserts for ldisc_sem

2018-10-31 Thread Dmitry Safonov
Make sure under CONFIG_LOCKDEP that each change to line discipline is done with held write semaphor. Otherwise potential reader will have a good time dereferencing incomplete/uninitialized ldisc. An exception here is tty_ldisc_open(), as it's called without ldisc_sem locked by tty_init_dev() =>

[PATCHv6 7/7] tty/ldsem: Decrement wait_readers on timeouted down_read()

2018-10-31 Thread Dmitry Safonov
It seems like when ldsem_down_read() fails with timeout, it misses update for sem->wait_readers. By that reason, when writer finally releases write end of the semaphore __ldsem_wake_readers() does adjust sem->count with wrong value: sem->wait_readers * (LDSEM_ACTIVE_BIAS - LDSEM_WAIT_BIAS) I.e,

[PATCHv6 3/7] tty: Don't block on IO when ldisc change is pending

2018-10-31 Thread Dmitry Safonov
There might be situations where tty_ldisc_lock() has blocked, but there is already IO on tty and it prevents line discipline changes. It might theoretically turn into dead-lock. Basically, provide more priority to pending tty_ldisc_lock() than to servicing reads/writes over tty. User-visible

[PATCHv6 2/7] tty: Hold tty_ldisc_lock() during tty_reopen()

2018-10-31 Thread Dmitry Safonov
tty_ldisc_reinit() doesn't race with neither tty_ldisc_hangup() nor set_ldisc() nor tty_ldisc_release() as they use tty lock. But it races with anyone who expects line discipline to be the same after hoding read semaphore in tty_ldisc_ref(). We've seen the following crash on v4.9.108 stable:

[PATCHv6 0/7] tty: Hold write ldisc sem in tty_reopen()

2018-10-31 Thread Dmitry Safonov
Hi all, Here are fixes that worth to have in the @stable, as they were hit by different people, including Arista on v4.9 stable. And for linux-next - adding lockdep asserts for line discipline changing code, verifying that write ldisc sem will be held forthwith. Mikulas, can you add your

[PATCH 2/3] asus-nb-wmi: Map 0x35 to KEY_SCREENLOCK

2018-10-31 Thread João Paulo Rechi Vita
When the OS registers to handle events from the display off hotkey the EC will send a notification with 0x35 for every key press, independent of the backlight state. The behavior of this key on Windows, with the ATKACPI driver from Asus installed, is turning off the backlight of all connected

[PATCH 3/3] asus-nb-wmi: Drop mapping of 0x33 and 0x34 scan codes

2018-10-31 Thread João Paulo Rechi Vita
According to Asus firmware engineers, the meaning of these codes is only to notify the OS that the screen brightness has been turned on/off by the EC. This does not match the meaning of KEY_DISPLAYTOGGLE / KEY_DISPLAY_OFF, where userspace is expected to change the display brightness.

[PATCH 0/3] Fix display off hotkey on Asus machines

2018-10-31 Thread João Paulo Rechi Vita
Asus laptops have a hotkey function on the F7 key to turn the display backlight OFF, labeled with a screen with a X inside, as shown on https://dlcdnimgs.asus.com/websites/global/products/Xep1ZcSY8dyWXK11/images/keyboard.png This hotkey worked on very few Asus models, where the EC acts on the

[PATCH 1/3] asus-wmi: Tell the EC the OS will handle the display off hotkey

2018-10-31 Thread João Paulo Rechi Vita
In the past, Asus firmwares would change the panel backlight directly through the EC when the display off hotkey (Fn+F7) was pressed, and only notify the OS of such change, with 0x33 when the LCD was ON and 0x34 when the LCD was OFF. These are currently mapped to KEY_DISPLAYTOGGLE and

Re: [PATCH RFC 1/1] drivers: pinctrl: qcom: add wakeup capability to GPIO

2018-10-31 Thread Stephen Boyd
Quoting Lina Iyer (2018-10-31 09:46:50) > On Wed, Oct 31 2018 at 01:05 -0600, Stephen Boyd wrote: > >Hi Lina, > > > >Quoting Lina Iyer (2018-10-10 17:29:58) > >> QCOM SoC's that have Power Domain Controller (PDC) chip in the always-on > >> domain can wakeup the SoC, when interrupts and GPIOs are

[PATCH v2 3/7] power: supply: bq24190_charger: add of_match for usb-otg-vbus regulator

2018-10-31 Thread Brian Masney
From: Jonathan Marek This patch adds an of_match for the usb-otg-vbus regulator to bq24190_charger. Signed-off-by: Jonathan Marek Signed-off-by: Brian Masney --- drivers/power/supply/bq24190_charger.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/power/supply/bq24190_charger.c

[PATCH v2 1/7] dt-bindings: power: supply: bq24190_charger: add bq24192 and usb-otg-vbus

2018-10-31 Thread Brian Masney
Add support for the ti,bq24192 variant and a child node for the usb-otg-vbus regulator. Signed-off-by: Brian Masney --- .../devicetree/bindings/power/supply/bq24190.txt | 9 + 1 file changed, 9 insertions(+) diff --git

[PATCH v2 6/7] ARM: dts: qcom: msm8974: add gpio-ranges

2018-10-31 Thread Brian Masney
This adds the gpio-ranges property to pm8941_gpios so that the GPIO pins are initialized by the GPIO framework and not pinctrl. This fixes a circular dependency so GPIO hogging can be used on this board. Signed-off-by: Brian Masney --- arch/arm/boot/dts/qcom-pm8941.dtsi | 1 + 1 file changed, 1

[PATCH v2 4/7] power: supply: bq24190_charger: add extcon support for USB OTG

2018-10-31 Thread Brian Masney
Add extcon support so that we can notify USB drivers of cable state changes. Based on work from Jonathan Marek. USB OTG was tested on a LG Nexus 5 (hammerhead) phone. Signed-off-by: Brian Masney --- drivers/power/supply/bq24190_charger.c | 37 +- 1 file changed, 36

[PATCH v2 7/7] ARM: dts: qcom: msm8974-hammerhead: add USB OTG support

2018-10-31 Thread Brian Masney
Add the device tree bindings for USB OTG support. Driver was tested using on a LG Nexus 5 (hammerhead) phone. This patch is based on work from Jonathan Marek and from the other msm8974 devices. Signed-off-by: Brian Masney --- .../qcom-msm8974-lge-nexus5-hammerhead.dts| 60

[PATCH v2 2/7] power: supply: bq24190_charger: add support for bq24192 variant

2018-10-31 Thread Brian Masney
From: Jonathan Marek This patch adds support for the bq24192 variant to bq24190_charger. Signed-off-by: Jonathan Marek [masn...@onstation.org: Changed if statement to a switch based on feedback from Sebastian Reichel.] Signed-off-by: Brian Masney --- drivers/power/supply/bq24190_charger.c |

[PATCH v2 5/7] pinctrl: qcom: spmi-gpio: fix gpio-hog related boot issues

2018-10-31 Thread Brian Masney
When attempting to setup up a gpio hog, device probing would repeatedly fail with -EPROBE_DEFERED errors. It was caused by a circular dependency between the gpio and pinctrl frameworks. If the gpio-ranges property is present in device tree, then the gpio framework will handle the gpio pin

[PATCH v2 0/7] ARM: qcom: msm8974-hammerhead: add USB OTG support

2018-10-31 Thread Brian Masney
This patch set adds USB OTG support for the LG Nexus 5 (hammerhead) phone. Changes in v2: - Reworked patches to use gpio hogging as suggested in the bq24190 device tree documentation. - bq24190_charger: changed to use a switch instead of an if as requested by Sebastian Reichel. -

Re: [PATCH] pinctrl: generic: Avoid several implicit enum conversions

2018-10-31 Thread Nathan Chancellor
On Wed, Oct 31, 2018 at 02:33:24PM +0100, Linus Walleij wrote: > On Thu, Oct 25, 2018 at 11:04 PM Nathan Chancellor > wrote: > > > In my opinion, there are enough of these warnings to warrant changing > > the type of param globally (arm64 allyesconfig): > > Yeah as it is from the compiler, sure

Re: remove exofs and the T10 OSD code V2

2018-10-31 Thread Boaz Harrosh
On 31/10/18 23:10, Douglas Gilbert wrote: > On 2018-10-31 4:57 p.m., Boaz Harrosh wrote: >> On 30/10/18 09:45, Christoph Hellwig wrote: >>> On Mon, Oct 29, 2018 at 02:42:12PM -0600, Jens Axboe wrote: LGTM, for both: >>> >>> I also have this one on top as requested by Martin. The core block

Re: Regression found (Stop-marking-clocks-as-CLK_IS_CRITICAL)

2018-10-31 Thread Dean Wallace
On 31-10-18, Pierre-Louis Bossart wrote: > > > Just thought it worth mentioning, this new patch that fixes sound > > again, seems to have ressurected an old issue with PLL unlock. I'm > > seeing journal entries after fresh boot .. > > > > ``` > > picard kernel: max98090 i2c-193C9890:00: PLL

Re: [PATCH v2] arm64: dts: sdm845: Add PSCI cpuidle low power states

2018-10-31 Thread Doug Anderson
Hi, On Tue, Oct 30, 2018 at 10:23 AM Raju P.L.S.S.S.N wrote: > > Add device bindings for cpuidle states for cpu devices. > > Cc: > Signed-off-by: Raju P.L.S.S.S.N > --- > Changes in v2 > - Address comments from Doug > --- > --- > arch/arm64/boot/dts/qcom/sdm845.dtsi | 62 >

[PATCH AUTOSEL 4.19 003/146] net: loopback: clear skb->tstamp before netif_rx()

2018-10-31 Thread Sasha Levin
From: Eric Dumazet [ Upstream commit 4c16128b6271e70c8743178e90cccee147858503 ] At least UDP / TCP stacks can now cook skbs with a tstamp using MONOTONIC base (or arbitrary values with SCM_TXTIME) Since loopback driver does not call (directly or indirectly) skb_scrub_packet(), we need to clear

[PATCH AUTOSEL 4.19 006/146] ataflop: fix error handling during setup

2018-10-31 Thread Sasha Levin
From: Omar Sandoval [ Upstream commit 71327f547ee3a46ec5c39fdbbd268401b2578d0e ] Move queue allocation next to disk allocation to fix a couple of issues: - If add_disk() hasn't been called, we should clear disk->queue before calling put_disk(). - If we fail to allocate a request queue, we

[PATCH AUTOSEL 4.19 004/146] locking/lockdep: Fix debug_locks off performance problem

2018-10-31 Thread Sasha Levin
From: Waiman Long [ Upstream commit 9506a7425b094d2f1d9c877ed5a78f416669269b ] It was found that when debug_locks was turned off because of a problem found by the lockdep code, the system performance could drop quite significantly when the lock_stat code was also configured into the kernel. For

[PATCH AUTOSEL 4.19 007/146] swim: fix cleanup on setup error

2018-10-31 Thread Sasha Levin
From: Omar Sandoval [ Upstream commit 1448a2a5360ae06f25e2edc61ae070dff5c0beb4 ] If we fail to allocate the request queue for a disk, we still need to free that disk, not just the previous ones. Additionally, we need to cleanup the previous request queues. Signed-off-by: Omar Sandoval

[PATCH AUTOSEL 4.19 010/146] nfp: devlink port split support for 1x100G CXP NIC

2018-10-31 Thread Sasha Levin
From: Ryan C Goodfellow [ Upstream commit 5948185b97fa1f83d7855e638a72982a1073ebf5 ] This commit makes it possible to use devlink to split the 100G CXP Netronome into two 40G interfaces. Currently when you ask for 2 interfaces, the math in src/nfp_devlink.c:nfp_devlink_port_split calculates

[PATCH AUTOSEL 4.19 009/146] hv_netvsc: fix vf serial matching with pci slot info

2018-10-31 Thread Sasha Levin
From: Haiyang Zhang [ Upstream commit 005479556197f80139771960dda0dfdcd2d2aad5 ] The VF device's serial number is saved as a string in PCI slot's kobj name, not the slot->number. This patch corrects the netvsc driver, so the VF device can be successfully paired with synthetic NIC. Fixes:

[PATCH AUTOSEL 4.19 014/146] lightnvm: pblk: fix race on sysfs line state

2018-10-31 Thread Sasha Levin
From: Javier González [ Upstream commit 44cdbdc657b23f75736eca3e88b781f009104363 ] pblk exposes a sysfs interface that represents its internal state. Part of this state is the map bitmap for the current open line, which should be protected by the line lock to avoid a race when freeing the line

[PATCH AUTOSEL 4.19 011/146] tun: Consistently configure generic netdev params via rtnetlink

2018-10-31 Thread Sasha Levin
From: Serhey Popovych [ Upstream commit df52eab23d703142c766ac00bdb8db19d71238d0 ] Configuring generic network device parameters on tun will fail in presence of IFLA_INFO_KIND attribute in IFLA_LINKINFO nested attribute since tun_validate() always return failure. This can be visualized with

[PATCH AUTOSEL 4.19 013/146] hwmon: (pwm-fan) Set fan speed to 0 on suspend

2018-10-31 Thread Sasha Levin
From: Thierry Reding [ Upstream commit 95dcd64bc5a27080beaa344edfe5bdcca3d2e7dc ] Technically this is not required because disabling the PWM should be enough. However, when support for atomic operations was implemented in the PWM subsystem, only actual changes to the PWM channel are applied

[PATCH AUTOSEL 4.19 016/146] lightnvm: pblk: fix race condition on metadata I/O

2018-10-31 Thread Sasha Levin
From: Javier González [ Upstream commit d8adaa3b86324c6186d0adf74bc256bdacfffdb6 ] In pblk, when a new line is allocated, metadata for the previously written line is scheduled. This is done through a fixed memory region that is shared through time and contexts across different lines and

[PATCH AUTOSEL 4.19 020/146] perf tools: Free 'printk' string in parse_ftrace_printk()

2018-10-31 Thread Sasha Levin
From: Sanskriti Sharma [ Upstream commit 9c8a182e5a73e01afd11742a2ab887bf338fdafd ] parse_ftrace_printk() tokenizes and parses a line, calling strdup() each iteration. Add code to free this temporary format string duplicate. Fixes the following coverity complaints: Error: RESOURCE_LEAK

Re: [GIT PULL] UML changes for 4.20-rc1

2018-10-31 Thread Linus Torvalds
On Wed, Oct 31, 2018 at 4:01 PM Richard Weinberger wrote: > > Okay, so my rebase was in vain, I thought you don't like pull requests > with such an old base. Some *really* old bases can cause problems, but generally that's if it's more than a year old (or if there's been some major upheaval that

[PATCH AUTOSEL 4.19 029/146] iwlwifi: mvm: check for n_profiles validity in EWRD ACPI

2018-10-31 Thread Sasha Levin
From: Luca Coelho [ Upstream commit 2e1976bb75263fbad918e82184b16a23bd721546 ] When reading the profiles from the EWRD table in ACPI, we loop over the data and set it into our internal table. We use the number of profiles specified in ACPI without checking its validity, so if the ACPI table is

[PATCH AUTOSEL 4.19 019/146] perf tools: Cleanup trace-event-info 'tdata' leak

2018-10-31 Thread Sasha Levin
From: Sanskriti Sharma [ Upstream commit faedbf3fd19f2511a39397f76359e4cc6ee93072 ] Free tracing_data structure in tracing_data_get() error paths. Fixes the following coverity complaint: Error: RESOURCE_LEAK (CWE-772): leaked_storage: Variable "tdata" going out of scope leaks the storage

[PATCH AUTOSEL 4.19 028/146] iwlwifi: mvm: clear HW_RESTART_REQUESTED when stopping the interface

2018-10-31 Thread Sasha Levin
From: Emmanuel Grumbach [ Upstream commit 155f7e0441cd121b1e673d465a35e99f4b9b2f0b ] Fix a bug that happens in the following scenario: 1) suspend without WoWLAN 2) mac80211 calls drv_stop because of the suspend 3) __iwl_mvm_mac_stop deallocates the aux station 4) during drv_stop the firmware

[PATCH AUTOSEL 4.19 025/146] sdhci: acpi: add free_slot callback

2018-10-31 Thread Sasha Levin
From: Wang Dongsheng [ Upstream commit c7eabbee3de99347105faa7fd925a500ccf43baf ] The device specific resource can be free in free_slot after removing host controller. Signed-off-by: Wang Dongsheng Acked-by: Adrian Hunter Signed-off-by: Ulf Hansson Signed-off-by: Sasha Levin ---

[PATCH AUTOSEL 4.19 017/146] spi: spi-ep93xx: Use dma_data_direction for ep93xx_spi_dma_{finish,prepare}

2018-10-31 Thread Sasha Levin
From: Nathan Chancellor [ Upstream commit a1108c7b2efb892350ba6a0e932dfd45622f4e2b ] Clang warns when one enumerated type is implicitly converted to another. drivers/spi/spi-ep93xx.c:342:62: warning: implicit conversion from enumeration type 'enum dma_transfer_direction' to different

[PATCH AUTOSEL 4.19 021/146] perf strbuf: Match va_{add,copy} with va_end

2018-10-31 Thread Sasha Levin
From: Sanskriti Sharma [ Upstream commit ce49d8436cffa9b7a6a5f110879d53e89dbc6746 ] Ensure that all code paths in strbuf_addv() call va_end() on the ap_saved copy that was made. Fixes the following coverity complaint: Error: VARARGS (CWE-237): [#def683] tools/perf/util/strbuf.c:106:

[PATCH AUTOSEL 4.19 022/146] cpupower: Fix coredump on VMWare

2018-10-31 Thread Sasha Levin
From: Prarit Bhargava [ Upstream commit f69ffc5d3db8f1f03fd6d1df5930f9a1fbd787b6 ] cpupower crashes on VMWare guests. The guests have the AMD PStateDef MSR (0xC0010064 + state number) set to zero. As a result fid and did are zero and the crash occurs because of a divide by zero (cof =

  1   2   3   4   5   6   7   8   9   10   >