Re: [PATCH rdma-rc 1/3] RDMA/hns: Fix the Oops during rmmod or insmod ko when reset occurs

2019-01-11 Thread Wei Hu (Xavier)
On 2019/1/12 5:34, Jason Gunthorpe wrote: > On Thu, Jan 10, 2019 at 09:57:41PM +0800, Wei Hu (Xavier) wrote: >> +/* Check the status of the current software reset process, if in >> + * software reset process, wait until software reset process finished, >> + * in order to ensure that

[PATCH v2] x86/boot/e820: Use kmemdup instead of duplicating its function

2019-01-11 Thread Yi Wang
From: "Huang Zijiang" changes since v1: redo the patch based on suggestions from Boris. v1 link:https://lkml.org/lkml/2019/1/8/30 kmemdup is the same function as kmalloc() + memcpy(). Signed-off-by: Huang Zijiang --- arch/x86/kernel/e820.c | 9 +++-- 1 file changed, 3

[PATCH] fgraph: record function return value

2019-01-11 Thread Changbin Du
This patch adds a new trace option 'funcgraph-retval' and is disabled by default. When this option is enabled, fgraph tracer will show the return value of each function. This is useful to find/analyze a original error source in a call graph. One limitation is that kernel doesn't know the

Re: 5.0-rc1 KVM inspired "BUG: Bad page state in process" spew

2019-01-11 Thread Mike Galbraith
On Wed, 2019-01-09 at 11:26 -0800, Sean Christopherson wrote: > > I'll try to bisect. Good luck with that. I gave it a go, but that apparently invalidated the warrantee of my vm image :) -Mike

Re: linux-next: build failure after merge of the pwm tree

2019-01-11 Thread Stephen Rothwell
Hi all, On Sat, 12 Jan 2019 17:01:17 +1100 Stephen Rothwell wrote: > > [Reported by "kernelci.org bot" ] [Also reported by Mark Brown ] > > After merging the pwm tree, today's linux-next build (arm64-allmodconfig) > failed like this: > > In file included from drivers/pwm/pwm-imx27.c:15: >

Re: [alsa-devel] [PATCH] ASoC: soc-core: Fix null pointer dereference in soc_find_component

2019-01-11 Thread Rohit kumar
On 1/12/2019 3:19 AM, Pierre-Louis Bossart wrote: Thanks for the overnight fix. This update fixes the issue on my Skylake XPS13 test device (blind testing since I don't understand what the code does). Tested-by: Pierre-Louis Bossart I need to take this back, this set of changes

[PATCH] MAINTAINERS: drop PREEMPTIBLE KERNEL section entry

2019-01-11 Thread Lukas Bulwahn
The PREEMPTIBLE KERNEL section entry seems quite outdated: Robert Love is not actively maintaining the file anymore, nor a recorded contributor to the files in the PREEMPTIBLE KERNEL section for the last few years. The mailing list kpreempt-t...@lists.sourceforge.net does not exist anymore; the

linux-next: build failure after merge of the pwm tree

2019-01-11 Thread Stephen Rothwell
Hi all, [Reported by "kernelci.org bot" ] After merging the pwm tree, today's linux-next build (arm64-allmodconfig) failed like this: In file included from drivers/pwm/pwm-imx27.c:15: drivers/pwm/pwm-imx27.c:292:25: error: 'imx_pwm_dt_ids' undeclared here (not in a function); did you mean

[PATCH] fs: drop unused fput_atomic definition

2019-01-11 Thread Lukas Bulwahn
commit d7065da03822 ("get rid of the magic around f_count in aio") added fput_atomic to include/linux/fs.h, motivated by its use in __aio_put_req() in fs/aio.c. Later, commit 3ffa3c0e3f6e ("aio: now fput() is OK from interrupt context; get rid of manual delayed __fput()") removed the only use of

[PATCH] fcoe: make use of fip_mode enum complete

2019-01-11 Thread Lukas Bulwahn
commit 1917d42d14b7 ("fcoe: use enum for fip_mode") introduces a separate enum for the fip_mode that shall be used during initialisation handling until it is passed to fcoe_ctrl_link_up to set the initial fip_state. That change was incomplete and gcc quietly converted in various places between the

[PATCH v2] target: fix a missing check of match_int

2019-01-11 Thread Kangjie Lu
When match_int fails, "arg" is left uninitialized and may contain random value, thus should not be used. The fix checks if match_int fails, and if so, returns its error code. Signed-off-by: Kangjie Lu --- drivers/target/target_core_rd.c | 15 +-- 1 file changed, 13 insertions(+), 2

Re: [PATCH 2/6] crypto: kdf - SP800-108 Key Derivation Function

2019-01-11 Thread Eric Biggers
On Fri, Jan 11, 2019 at 08:10:02PM +0100, Stephan Müller wrote: > The SP800-108 compliant Key Derivation Function is implemented as a > random number generator considering that it behaves like a deterministic > RNG. > > All three KDF types specified in SP800-108 are implemented. > > The code

Re: [PATCH 3/6] crypto: kdf - add known answer tests

2019-01-11 Thread Eric Biggers
On Fri, Jan 11, 2019 at 08:10:22PM +0100, Stephan Müller wrote: > Add known answer tests to the testmgr for the KDF (SP800-108) cipher. > > Signed-off-by: Stephan Mueller > --- > crypto/testmgr.c | 226 +++ > crypto/testmgr.h | 110

Re: [PATCH 5/6] crypto: hkdf - add known answer tests

2019-01-11 Thread Eric Biggers
On Fri, Jan 11, 2019 at 08:10:56PM +0100, Stephan Müller wrote: > Add known answer tests to the testmgr for the HKDF (RFC5869) cipher. > > The known answer tests are derived from RFC 5869 appendix A. > > Note, the HKDF is considered to be a FIPS 140-2 allowed (not approved) > cipher as of now.

Re: [PATCH 4/6] crypto: hkdf - RFC5869 Key Derivation Function

2019-01-11 Thread Eric Biggers
Hi Stephan, On Fri, Jan 11, 2019 at 08:10:39PM +0100, Stephan Müller wrote: > The RFC5869 compliant Key Derivation Function is implemented as a > random number generator considering that it behaves like a deterministic > RNG. > Thanks for the proof of concept! I guess it ended up okay. But

Re: [PATCH lora-next 4/4] dt-bindings: lora: sx130x: add clock bindings

2019-01-11 Thread Andreas Färber
Am 08.01.19 um 09:41 schrieb Ben Whitten: > The sx130x family consumes two clocks, a 32MHz clock provided by a > connected IQ transceiver, and a 133MHz high speed clock. > > In the example we connect the concentrator to output 0 of a fixed clock > providing the 133MHz high speed clock, and we

[PATCH] regulator: pwm: No need to make a copy of regulator_ops per instance

2019-01-11 Thread Axel Lin
Having instance specific copy of desc is enough to support multiple instance of pwm regulator. The regulator_ops is never changed so no need to copy it per instance, make pwm_regulator_voltage_table_ops and pwm_regulator_voltage_continuous_ops const to ensure they won't be changed. The

Re: [PATCH 2/2] sh: generate uapi header and syscall table header files

2019-01-11 Thread Rob Landley
On 1/10/19 5:54 PM, Guenter Roeck wrote: > On Wed, Jan 02, 2019 at 09:07:25PM +0530, Firoz Khan wrote: >> Unified system call table generation script must be run to >> generate unistd_32.h and syscall_table.h files. This patch >> will have changes which will invokes the script. >> >> This patch

Re: [PATCH lora-next 3/4] dt-bindings: lora: sx125x: add clock bindings

2019-01-11 Thread Andreas Färber
Am 08.01.19 um 09:41 schrieb Ben Whitten: > The sx125x consumes a 32MHz clock and if it is coupled with a sx130x > concentrator may also provide a gated version of this 32MHz for the > concentrator. "SX125x", "SX130x", "32 MHz" > > In the example we connect to output 0 of "txco" clock source.

Re: [PATCH 0/5] Improve the latency tracers

2019-01-11 Thread Changbin Du
Hi Steven, Have you checked this serias yet? :) On Tue, Jan 01, 2019 at 11:46:09PM +0800, Changbin Du wrote: > Happy new year! > > This series make some improments for the kernel latency tracers, especilly > for the wakeup tracers. The latency tracers will show us more useful > information. With

stack-protector: fix CC_HAS_STACKPROTECTOR_NONE depend on -fno-stack-protector

2019-01-11 Thread 隆春
commit(2a61f4747eeaa85ce26ca9fbd81421b15facd018)rename CC_STACKPROTECTOR_NONE config. but unfortunately if the compiler support option -fno-stack-protector, CC_HAS_STACKPROTECTOR_NONE will not be disabled. CC_HAS_STACKPROTECTOR_NONE and CC_STACKPROTECTOR_STRONG will be enabled at once, as the

Re: [PATCH lora-next 2/4] dt-bindings: lora: sx125x: add basic documentation

2019-01-11 Thread Andreas Färber
Am 08.01.19 um 09:41 schrieb Ben Whitten: > The sx125x family are IQ radio transceivers from Semtech configured over > SPI, they are typically connected to an sx130x series concentrator however > may be connected to a host directly. "SX125x" and "SX130x" > > Required properties include the

Re: [PATCH V7 2/2] drm/panel: Add Sitronix ST7701 panel driver

2019-01-11 Thread Jagan Teki
On Sat, Jan 12, 2019 at 2:49 AM Sam Ravnborg wrote: > > Hi Jagan. > > Gave this another more detailed read - triggered some additional comments. > Depite the comments it looks good, and this is all more or > less cosmetic improvements. Thanks for the review. > > Sam > > > +struct

Re: [PATCH] scsi: ufs: Remove select of phy-qcom-ufs from ufs-qcom

2019-01-11 Thread Martin K. Petersen
Evan, > CONFIG_SCSI_UFS_QCOM selects CONFIG_PHY_QCOM_UFS, assuming that > this was the only possible PHY driver Qualcomm's UFS controller > would use. But in SDM845, the UFS driver is bundled into phy-qcom-qmp, > and phy-qcom-ufs is unused. > > Remove the select, since for SDM845 it adds

Re: [PATCH lora-next 1/4] dt-bindings: lora: sx130x: add basic documentation

2019-01-11 Thread Andreas Färber
Hi Ben, Am 08.01.19 um 09:41 schrieb Ben Whitten: > Add basic documentation in YAML format for the sx130x series concentrators > from Semtech. > Required is; the location on the SPI bus, the reset gpio and the node for > downstream IQ radios, typically sx125x. > > Signed-off-by: Ben Whitten >

Re: [PATCH] scsi: qla1280: set 64bit coherent mask

2019-01-11 Thread Martin K. Petersen
Thomas, > Reason is that SGI IP27 always generates 64bit DMA addresses and has > no fallback mode for 32bit DMA addresses implemented. QLA1280 > supports 64bit addressing for all DMA accesses so setting coherent mask > to 64bit fixes the issue. Applied to 5.0/scsi-fixes, thanks! -- Martin K.

Re: [PATCH 1/1] doc: scsi: remove reference to tmscsim.txt file

2019-01-11 Thread Martin K. Petersen
Otto, > The tmscsim.txt doc file was removed in c121107d0f84. Applied to 5.1/scsi-queue, thanks. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2019-01-11 Thread Jerome Glisse
On Fri, Jan 11, 2019 at 07:06:08PM -0800, John Hubbard wrote: > On 1/11/19 6:46 PM, Jerome Glisse wrote: > > On Fri, Jan 11, 2019 at 06:38:44PM -0800, John Hubbard wrote: > >> On 1/11/19 6:02 PM, Jerome Glisse wrote: > >>> On Fri, Jan 11, 2019 at 05:04:05PM -0800, John Hubbard wrote: > On

Re: [PATCH 0/3] libsas: SATA PHY connection rate matching during disovery

2019-01-11 Thread Martin K. Petersen
John, > This patchset looks to resolve an issue we see whereby a SATA end device > negotiated linkrate may exceed the min linkrate to the initiator, and > not be able to establish a connection. Looks good to me. Applied to 5.1/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux

RE: [PATCH v2] soc: imx: Break dependency on SOC_IMX8MQ for GPCv2

2019-01-11 Thread Aisheng Dong
> From: Shawn Guo [mailto:shawn...@kernel.org] > Sent: Saturday, January 12, 2019 11:09 AM > On Sun, Dec 23, 2018 at 01:20:34PM +, Abel Vesa wrote: > > Since this is going to be used on more SoCs than just i.MX8MQ, make > > the dependency here more generic. > > > > Signed-off-by: Abel Vesa >

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2019-01-11 Thread Jerome Glisse
On Fri, Jan 11, 2019 at 06:38:44PM -0800, John Hubbard wrote: > On 1/11/19 6:02 PM, Jerome Glisse wrote: > > On Fri, Jan 11, 2019 at 05:04:05PM -0800, John Hubbard wrote: > >> On 1/11/19 8:51 AM, Jerome Glisse wrote: > >>> On Thu, Jan 10, 2019 at 06:59:31PM -0800, John Hubbard wrote: > On

Re: [PATCH v2] soc: imx: Break dependency on SOC_IMX8MQ for GPCv2

2019-01-11 Thread Shawn Guo
On Sun, Dec 23, 2018 at 01:20:34PM +, Abel Vesa wrote: > Since this is going to be used on more SoCs than just i.MX8MQ, > make the dependency here more generic. > > Signed-off-by: Abel Vesa > Reviewed-by: Dong Aisheng > --- > Changes since v1: > * removed the SOC_IMX7D since it's included

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2019-01-11 Thread John Hubbard
On 1/11/19 6:46 PM, Jerome Glisse wrote: > On Fri, Jan 11, 2019 at 06:38:44PM -0800, John Hubbard wrote: >> On 1/11/19 6:02 PM, Jerome Glisse wrote: >>> On Fri, Jan 11, 2019 at 05:04:05PM -0800, John Hubbard wrote: On 1/11/19 8:51 AM, Jerome Glisse wrote: > On Thu, Jan 10, 2019 at

Re: [PATCH] mISDN: hfcsusb: Use struct_size() in kzalloc()

2019-01-11 Thread David Miller
From: "Gustavo A. R. Silva" Date: Tue, 8 Jan 2019 15:27:05 -0600 > One of the more common cases of allocation size calculations is finding the > size of a structure that has a zero-sized array at the end, along with memory > for some number of elements for that array. For example: > > struct

Re: [PATCH v2] rbtree: fix the red root

2019-01-11 Thread Michel Lespinasse
On Fri, Jan 11, 2019 at 3:47 PM David Lechner wrote: > > On 1/11/19 2:58 PM, Qian Cai wrote: > > A GPF was reported, > > > > kasan: CONFIG_KASAN_INLINE enabled > > kasan: GPF could be caused by NULL-ptr deref or user memory access > > general protection fault: [#1] SMP KASAN > >

Re: [PATCH 05/41] scsi: aic7xxx: aic79xx: mark expected switch fall-through

2019-01-11 Thread Martin K. Petersen
Hannes, >> Friendly ping (second one): >> >> Who can ack/review/take this patch, please? Applied to 5.1/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 10/41] scsi: bfa: bfa_fcs_lport: Mark expected switch fall-throughs

2019-01-11 Thread Martin K. Petersen
Gustavo, > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. Applied this and two other bfa patches to 5.1/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 1/3] arm64: dts: add dpaa2-console node for DPAA2 platforms

2019-01-11 Thread Shawn Guo
On Fri, Dec 21, 2018 at 03:31:09PM +, Ioana Ciornei wrote: > Add the dpaa2-console device tree node for the following > DPAA2 based platforms: LS1088A, LS2080A and LS2088A. > > Signed-off-by: Ioana Ciornei DTS patch generally goes to the last in a series. Shawn

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2019-01-11 Thread Jerome Glisse
On Fri, Jan 11, 2019 at 06:38:44PM -0800, John Hubbard wrote: > On 1/11/19 6:02 PM, Jerome Glisse wrote: > > On Fri, Jan 11, 2019 at 05:04:05PM -0800, John Hubbard wrote: > >> On 1/11/19 8:51 AM, Jerome Glisse wrote: > >>> On Thu, Jan 10, 2019 at 06:59:31PM -0800, John Hubbard wrote: > On

Re: [PATCH 14/41] scsi: esas2r: esas2r_init: mark expected switch fall-throughs

2019-01-11 Thread Martin K. Petersen
Gustavo, > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. Applied to 5.1/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 1/2] arm64: dts: lx2160a: Add fsl-mc node

2019-01-11 Thread Shawn Guo
On Thu, Dec 20, 2018 at 05:02:03PM +, Ioana Ciocoi Radulescu wrote: > Add the fsl-mc node in the LX2160A device tree. > > Signed-off-by: Ioana Radulescu Applied both, thanks.

Re: [PATCH] scsi: hisi_sas: Set protection parameters prior to adding SCSI host

2019-01-11 Thread Martin K. Petersen
John, > Currently we set the protection parameters after calling scsi_add_host() > for v3 hw. > > They should be set beforehand, so make this change. Applied to 5.0/scsi-fixes. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2019-01-11 Thread John Hubbard
On 1/11/19 6:02 PM, Jerome Glisse wrote: > On Fri, Jan 11, 2019 at 05:04:05PM -0800, John Hubbard wrote: >> On 1/11/19 8:51 AM, Jerome Glisse wrote: >>> On Thu, Jan 10, 2019 at 06:59:31PM -0800, John Hubbard wrote: On 1/3/19 6:44 AM, Jerome Glisse wrote: > On Thu, Jan 03, 2019 at

Re: [PATCH] scsi: isci: initialize shost fully before calling scsi_add_host()

2019-01-11 Thread Martin K. Petersen
John, > So how about just drop these APIs and let the user set the shost > protection parameters directly, like other shost parameters, The protection interfaces here obviously predate the block layer allocation changes that made this particular issue pop up. > which should make it a bit

[PATCH v2 9/9] kprobes: Prohibit probing on lockdep functions

2019-01-11 Thread Masami Hiramatsu
Some lockdep functions can be involved in breakpoint handling and probing on those functions can cause a breakpoint recursion. Prohibit probing on those functions by blacklist. Signed-off-by: Masami Hiramatsu --- kernel/locking/lockdep.c |7 ++- 1 file changed, 6 insertions(+), 1

[PATCH v2 8/9] kprobes: Prohibit probing on RCU debug routine

2019-01-11 Thread Masami Hiramatsu
Since kprobe itself depends on RCU, probing on RCU debug routine can cause recursive breakpoint problem. Prohibit probing on RCU debug routines. int3 ->do_int3() ->ist_enter() ->RCU_LOCKDEP_WARN() ->debug_lockdep_rcu_enabled() -> int3 Signed-off-by: Masami Hiramatsu ---

[PATCH v2 6/9] kprobes: Prohibit probing on hardirq tracers

2019-01-11 Thread Masami Hiramatsu
Since kprobes breakpoint handling involves hardirq tracer, probing these functions cause breakpoint recursion problem. Prohibit probing on those functions. Signed-off-by: Masami Hiramatsu Acked-by: Steven Rostedt (VMware) --- kernel/trace/trace_irqsoff.c|9 +++--

[PATCH v2 7/9] kprobes: Prohibit probing on preempt_check debug functions

2019-01-11 Thread Masami Hiramatsu
Since kprobes depends on preempt disable/enable, probing on the preempt debug routine can cause recursive breakpoint problem. Signed-off-by: Masami Hiramatsu --- lib/smp_processor_id.c |7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/lib/smp_processor_id.c

[PATCH v2 4/9] x86/kprobes: Prohibit probing on IRQ handlers directly

2019-01-11 Thread Masami Hiramatsu
Prohibit probing on IRQ handlers in irqentry_text because if it interrupts user mode, at that point we haven't changed to kernel space yet and which eventually leads a double fault. E.g. # echo p apic_timer_interrupt > kprobe_events # echo 1 > events/kprobes/enable PANIC: double fault,

[PATCH v2 5/9] kprobes: Search non-suffixed symbol in blacklist

2019-01-11 Thread Masami Hiramatsu
Newer gcc can generate some different instances of a function with suffixed symbols if the function is optimized and only has a part of that. (e.g. .constprop, .part etc.) In this case, it is not enough to check the entry of kprobe blacklist because it only records non-suffixed symbol address.

[PATCH v2 3/9] x86/kprobes: Prohibit probing on functions before kprobe_int3_handler()

2019-01-11 Thread Masami Hiramatsu
Prohibit probing on the functions called before kprobe_int3_handler() in do_int3(). More specifically, ftrace_int3_handler(), poke_int3_handler(), and ist_enter(). And since rcu_nmi_enter() is called by ist_enter(), it also should be marked as NOKPROBE_SYMBOL. Since those are handled before

[PATCH v2 2/9] x86/kprobes: Move trampoline code into RODATA

2019-01-11 Thread Masami Hiramatsu
Move optprobe trampoline code into RODATA since it is not executed, but copied and modified to be used on a trampoline buffer. Signed-off-by: Masami Hiramatsu --- arch/x86/kernel/kprobes/opt.c |9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git

[PATCH v2 1/9] x86/kprobes: Prohibit probing on optprobe template code

2019-01-11 Thread Masami Hiramatsu
Prohibit probing on optprobe template code, since it is not a code but a template instruction sequence. If we modify this template, copied template must be broken. Signed-off-by: Masami Hiramatsu Fixes: 9326638cbee2 ("kprobes, x86: Use NOKPROBE_SYMBOL() instead of __kprobes annotation") Cc:

[PATCH v2 0/9] kprobes: Fix and improve blacklist symbols

2019-01-11 Thread Masami Hiramatsu
Hi, Here is the v2 series of kprobes blacklist bugfix and improvements mainly on x86 (since I started testing on qemu-x86). >From v1, I just removed stable-ml from Cc (but tagged [1/9]) and added Steve's Ack. This has been started from discussion about KPROBE_ENENTS_ON_NOTRACE configuration. I

Re: [PATCH net v4 0/4] net: bpfilter: fix two bugs in bpfilter

2019-01-11 Thread David Miller
From: Taehee Yoo Date: Wed, 9 Jan 2019 02:23:42 +0900 > This patches fix two bugs in the bpfilter_umh which are related in > iptables command. ... Series applied, thank you.

Re: [PATCH v4] RISC-V: defconfig: Enable Generic PCIE by default

2019-01-11 Thread Paul Walmsley
On Sat, 12 Jan 2019, Alistair Francis wrote: > Enable generic PCIe by default in the RISC-V defconfig, this allows us > to use QEMU's PCIe support out of the box. > > Signed-off-by: Alistair Francis Reviewed-by: Paul Walmsley - Paul

Re: [PATCH 36/41] scsi: qla4xxx: ql4_os: mark expected switch fall-through

2019-01-11 Thread Martin K. Petersen
Nilesh, >>In preparation to enabling -Wimplicit-fallthrough, mark switch cases >>where we are expecting to fall through. >> >>Notice that, in this particular case, I replaced "allow fall-through" >>with a "fall through" annotation, which is what GCC is expecting to >>find. Applied to

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2019-01-11 Thread Jerome Glisse
On Fri, Jan 11, 2019 at 05:04:05PM -0800, John Hubbard wrote: > On 1/11/19 8:51 AM, Jerome Glisse wrote: > > On Thu, Jan 10, 2019 at 06:59:31PM -0800, John Hubbard wrote: > >> On 1/3/19 6:44 AM, Jerome Glisse wrote: > >>> On Thu, Jan 03, 2019 at 10:26:54AM +0100, Jan Kara wrote: > On Wed

Good News for 2019 and Beyond: National Neuroscience Institute Singapore MRI Brain Scan Stroke Protocol Radiology Report of 29 Dec 2018

2019-01-11 Thread Turritopsis Dohrnii Teo En Ming
Subject: Good News for 2019 and Beyond: National Neuroscience Institute Singapore MRI Brain Scan Stroke Protocol Radiology Report of 29 Dec 2018

Re: [PATCH] isdn: i4l: isdn_tty: Fix some concurrency double-free bugs

2019-01-11 Thread David Miller
From: Jia-Ju Bai Date: Tue, 8 Jan 2019 21:04:48 +0800 > The functions isdn_tty_tiocmset() and isdn_tty_set_termios() may be > concurrently executed. ... > These possible bugs are found by a static tool written by myself and > my manual code review. > > To fix these possible bugs, the mutex

Re: [PATCH 1/3] media: dt: bindings: sunxi-ir: Add A64 compatible

2019-01-11 Thread Chen-Yu Tsai
On Sat, Jan 12, 2019 at 1:30 AM Jernej Skrabec wrote: > > A64 IR is compatible with A13, so add A64 compatible with A13 as a > fallback. We ask people to add the SoC-specific compatible as a contigency, in case things turn out to be not so "compatible". To be consistent with all the other SoCs

Re: UBSAN: Undefined behaviour in drivers/pps/pps.c

2019-01-11 Thread Dmitry Torokhov
On Wed, Jan 09, 2019 at 10:20:50AM +0100, Rodolfo Giometti wrote: > On 08/01/2019 21:24, Kyungtae Kim wrote: > > We report a bug in linux-4.20: "UBSAN: Undefined behaviour in > > drivers/pps/pps.c" > > > > kernel config: https://kt0755.github.io/etc/config_v4.20_stable > > repro:

Re: [PATCH] net: nvidia: forcedeth: Fix two possible concurrency use-after-free bugs

2019-01-11 Thread David Miller
From: Jia-Ju Bai Date: Tue, 8 Jan 2019 20:45:18 +0800 > In drivers/net/ethernet/nvidia/forcedeth.c, the functions > nv_start_xmit() and nv_start_xmit_optimized() can be concurrently > executed with nv_poll_controller(). > > nv_start_xmit > line 2321: prev_tx_ctx->skb = skb; > >

[PATCH v7 8/8] gpio: pcie-idio-24: Utilize for_each_set_clump8 macro

2019-01-11 Thread William Breathitt Gray
Replace verbose implementation in get_multiple/set_multiple callbacks with for_each_set_clump8 macro to simplify code and improve clarity. Signed-off-by: William Breathitt Gray --- drivers/gpio/gpio-pcie-idio-24.c | 109 --- 1 file changed, 40 insertions(+), 69

[PATCH v7 7/8] gpio: pci-idio-16: Utilize for_each_set_clump8 macro

2019-01-11 Thread William Breathitt Gray
Replace verbose implementation in get_multiple/set_multiple callbacks with for_each_set_clump8 macro to simplify code and improve clarity. Signed-off-by: William Breathitt Gray --- drivers/gpio/gpio-pci-idio-16.c | 73 - 1 file changed, 26 insertions(+), 47

Re: [PATCH] vhost/vsock: fix vhost vsock cid hashing inconsistent

2019-01-11 Thread David Miller
From: Zha Bin Date: Tue, 8 Jan 2019 16:07:03 +0800 > The vsock core only supports 32bit CID, but the Virtio-vsock spec define > CID (dst_cid and src_cid) as u64 and the upper 32bits is reserved as > zero. This inconsistency causes one bug in vhost vsock driver. The > scenarios is: > > 0. A

[PATCH v7 5/8] gpio: gpio-mm: Utilize for_each_set_clump8 macro

2019-01-11 Thread William Breathitt Gray
Replace verbose implementation in get_multiple/set_multiple callbacks with for_each_set_clump8 macro to simplify code and improve clarity. Signed-off-by: William Breathitt Gray --- drivers/gpio/gpio-gpio-mm.c | 71 +++-- 1 file changed, 20 insertions(+), 51

[PATCH v7 4/8] gpio: 104-idi-48: Utilize for_each_set_clump8 macro

2019-01-11 Thread William Breathitt Gray
Replace verbose implementation in get_multiple/set_multiple callbacks with for_each_set_clump8 macro to simplify code and improve clarity. Signed-off-by: William Breathitt Gray --- drivers/gpio/gpio-104-idi-48.c | 36 +++--- 1 file changed, 7 insertions(+), 29

[PATCH v7 6/8] gpio: ws16c48: Utilize for_each_set_clump8 macro

2019-01-11 Thread William Breathitt Gray
Replace verbose implementation in get_multiple/set_multiple callbacks with for_each_set_clump8 macro to simplify code and improve clarity. Signed-off-by: William Breathitt Gray --- drivers/gpio/gpio-ws16c48.c | 71 ++--- 1 file changed, 19 insertions(+), 52

[PATCH v7 3/8] gpio: 104-dio-48e: Utilize for_each_set_clump8 macro

2019-01-11 Thread William Breathitt Gray
Replace verbose implementation in get_multiple/set_multiple callbacks with for_each_set_clump8 macro to simplify code and improve clarity. Signed-off-by: William Breathitt Gray --- drivers/gpio/gpio-104-dio-48e.c | 71 ++--- 1 file changed, 20 insertions(+), 51

Re: [PATCH] Input: tca6416-keypad: use struct_size() in kzalloc()

2019-01-11 Thread Dmitry Torokhov
On Tue, Jan 08, 2019 at 09:28:16AM -0600, Gustavo A. R. Silva wrote: > One of the more common cases of allocation size calculations is finding the > size of a structure that has a zero-sized array at the end, along with memory > for some number of elements for that array. For example: > > struct

[PATCH v7 2/8] lib/test_bitmap.c: Add for_each_set_clump8 test cases

2019-01-11 Thread William Breathitt Gray
The introduction of the for_each_set_clump8 macro warrants test cases to verify the implementation. This patch adds test case checks for whether an out-of-bounds clump index is returned, a zero clump is returned, or the returned clump value differs from the expected clump value. Cc: Andy

[PATCH v7 1/8] bitops: Introduce the for_each_set_clump8 macro

2019-01-11 Thread William Breathitt Gray
This macro iterates for each 8-bit group of bits (clump) with set bits, within a bitmap memory region. For each iteration, "start" is set to the bit offset of the found clump, while the respective clump value is stored to the location pointed by "clump". Additionally, the bitmap_get_value8 and

[PATCH v7 0/8] Introduce the for_each_set_clump8 macro

2019-01-11 Thread William Breathitt Gray
Changes in v7: - Pass bitmap_set_value8 'value' parameter by value - Remove bitmap_set_value8 final mask operation; users beware: values greater than 8 bits may clobber bitmap While adding GPIO get_multiple/set_multiple callback support for various drivers, I noticed a pattern of looping

Re: WARNING in apparmor_cred_free

2019-01-11 Thread Casey Schaufler
>>>>> >>>>> syzbot found the following crash on: >>>>> >>>>> HEAD commit:    b808822a75a3 Add linux-next specific files for 20190111 >>>>> git tree:   linux-next >>>>> console output: https://syzkaller.appsp

Re: [PATCH 1/2] arm64: dts: layerscape: Add incr-burst-type-adjustment property to USB3 node

2019-01-11 Thread Shawn Guo
On Wed, Dec 19, 2018 at 05:41:08PM +0800, Ran Wang wrote: > Add this property to all layerscape platforms to improve USB read write > performance. > > Signed-off-by: Ran Wang Applied both, thanks.

Re: [PATCH] Input: synaptics - add PNP IDs for Dell XPS models to forcepad

2019-01-11 Thread Dmitry Torokhov
Hi Kim, On Fri, Jan 11, 2019 at 02:54:30PM -0600, Kim Phillips wrote: > This patch is the result of seeing this message: > > psmouse serio1: synaptics: Your touchpad (PNP: DLL087c PNP0f13) says it can > support a different bus. If i2c-hid and hid-rmi are not used, you might want > to try

Re: [PATCH v3 2/6] spmi: pmic-arb: convert to v2 irq interfaces to support hierarchical IRQ chips

2019-01-11 Thread Brian Masney
On Fri, Jan 11, 2019 at 03:39:27PM -0800, Stephen Boyd wrote: > Ok sounds good. Can you also fix all the spmi-gpio specifying dts files? > There are more than just two PMIC dts files that need changes (per my > grep results sent to the list earlier). Yes, I'll take care of all of them in the next

Re: linux-next: build failure after merge of the imx-mxs tree

2019-01-11 Thread Shawn Guo
On Fri, Jan 11, 2019 at 12:15:59AM +0100, Lukasz Majewski wrote: > Hi Stephen, > > > Hi all, > > > > On Fri, 11 Jan 2019 09:30:03 +1100 Stephen Rothwell > > wrote: > > > > > > After merging the imx-mxs tree, today's linux-next build (arm > > > multi_v7_defconfig) failed like this: > > > >

Re: ppc64le reliable stack unwinder and scheduled tasks

2019-01-11 Thread Balbir Singh
On Thu, Jan 10, 2019 at 04:14:00PM -0500, Joe Lawrence wrote: > Hi all, > > tl;dr: On ppc64le, what is top-most stack frame for scheduled tasks >about? > > I am looking at a bug in which ~10% of livepatch tests on RHEL-7 and > RHEL-8 distro kernels, the ppc64le reliable stack unwinder

Re: [PATCH 1/2] mm: introduce put_user_page*(), placeholder versions

2019-01-11 Thread John Hubbard
On 1/11/19 8:51 AM, Jerome Glisse wrote: > On Thu, Jan 10, 2019 at 06:59:31PM -0800, John Hubbard wrote: >> On 1/3/19 6:44 AM, Jerome Glisse wrote: >>> On Thu, Jan 03, 2019 at 10:26:54AM +0100, Jan Kara wrote: On Wed 02-01-19 20:55:33, Jerome Glisse wrote: > On Wed, Dec 19, 2018 at

ARM: config issue with ftrace function graph tracer

2019-01-11 Thread Jeremy Fertic
I'm having a problem with the ftrace function graph tracer on a 32 bit arm board (orangepi pc). A bisect points to the following commit: f9b58e8c7d03 ("ARM: 8800/1: use choice for kernel unwinders") Before this commit, if I use sunxi_defconfig and then menuconfig to enable FTRACE and

Re: [PATCH v1] clk: qcom: clk-rpmh: Add IPA clock support

2019-01-11 Thread David Dai
On 1/9/2019 11:28 AM, Stephen Boyd wrote: Quoting David Dai (2018-12-13 18:35:04) The current clk-rpmh driver only supports on and off RPMh clock resources, let's extend the current driver by add support for clocks that are managed by a different type of RPMh resource known as Bus Clock

Bug (since v4.20): integer underflow in known_siginfo_layout() when sig=0

2019-01-11 Thread Eric Biggers
Hi Eric, The following commit, which went into v4.20, introduced undefined behavior when sys_rt_sigqueueinfo() is called with sig=0: commit 4ce5f9c9e7546915c559ffae594e6d73f918db00 Author: Eric W. Biederman Date: Tue Sep 25 12:59:31 2018 +0200 signal: Use a smaller struct siginfo in the

[PATCH v4] RISC-V: defconfig: Enable Generic PCIE by default

2019-01-11 Thread Alistair Francis
Enable generic PCIe by default in the RISC-V defconfig, this allows us to use QEMU's PCIe support out of the box. Signed-off-by: Alistair Francis --- arch/riscv/configs/defconfig | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/arch/riscv/configs/defconfig

Re: [PATCH v2] rbtree: fix the red root

2019-01-11 Thread Esme
I've been out today but return home tomorrow and can test any suggested fixes, or with different kernel settings. Just let me know. Esme Sent with ProtonMail Secure Email. ‐‐‐ Original Message ‐‐‐ On Friday, January 11, 2019 7:18 PM, Qian Cai wrote: > On 1/11/19 6:16 PM, Matthew

Re: [Potential Spoof] Re: [Potential Spoof] Re: [PATCH v2 4/4] ARM: dts: aspeed: Add lpc ctrl for Facebook

2019-01-11 Thread Vijay Khemka
Joel, Please merge these patches as it is required by facebook platform. Regards -Vijay On 1/7/19, 11:25 AM, "Linux-aspeed on behalf of Vijay Khemka" wrote: Please merge these patches in upstream kernel. Regards -Vijay On 12/20/18, 10:06 AM, "Linux-aspeed on behalf

Re: [PATCH v2] rbtree: fix the red root

2019-01-11 Thread Qian Cai
On 1/11/19 6:16 PM, Matthew Wilcox wrote: > On Fri, Jan 11, 2019 at 03:58:43PM -0500, Qian Cai wrote: >> diff --git a/lib/rbtree_test.c b/lib/rbtree_test.c >> index b7055b2a07d3..afad0213a117 100644 >> --- a/lib/rbtree_test.c >> +++ b/lib/rbtree_test.c >> @@ -345,6 +345,17 @@ static int __init

Re: [PATCH] staging: vchiq: Fix local event signalling

2019-01-11 Thread Stefan Wahren
> Phil Elwell hat am 11. Januar 2019 um 12:34 > geschrieben: > > > Prior to the recent event reworking (see Fixes), thread synchronisation > was implemented using completions, the worker thread being woken with > a call to complete(). The replacement uses waitqueues, which are more > like

Re: [PATCH v3] RISC-V: defconfig: Enable Generic PCIE by default

2019-01-11 Thread Alistair Francis
On Sat, 2019-01-12 at 00:03 +, Alistair Francis wrote: > Enable generic PCIe by default in the RISC-V defconfig, this allows > us > to use QEMU's PCIe support out of the box. > > Signed-off-by: Alistair Francis > --- > arch/riscv/configs/defconfig | 5 +++-- > 1 file changed, 3

[PATCH] acpi/nfit: Fix command-supported detection

2019-01-11 Thread Dan Williams
The _DSM function number validation only happens to succeed when the generic Linux command number translation corresponds with a DSM-family-specific function number. This breaks NVDIMM-N implementations that correctly implement _LSR, _LSW, and _LSI, but do not happen to publish support for DSM

[PATCH 3/3] autofs: add ignore mount option

2019-01-11 Thread Ian Kent
Add an autofs file system mount option that can be used to provide a generic indicator to applications that the mount entry should be ignored when displaying mount information. Signed-off-by: Ian Kent --- fs/autofs/autofs_i.h |1 + fs/autofs/inode.c|9 -

[PATCH 2/3] autofs - fix error return in autofs_fill_super()

2019-01-11 Thread Ian Kent
In autofs_fill_super() on error of get inode/make root dentry the return should be ENOMEM as this is the only failure case of the called functions. Signed-off-by: Ian Kent --- fs/autofs/inode.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/fs/autofs/inode.c

4.19.{12,[13],14}: RIP: 0010:nf_conncount_cache_free+0x26/0x2f [nf_conncount]

2019-01-11 Thread Steffen Nurpmeso
Hello. this is my first post to a Linux list, and i am not subscribed. [Used it from 01-11-1999 to about 2001, then happily went to FreeBSD. ^_^ But Linux again since 2015, on bare metal since last October/November. Many thanks -- working Unix/POSIX on a Laptop. Fantastic

[PATCH 1/3] autofs: drop dentry reference only when it is never used

2019-01-11 Thread Ian Kent
From: Pan Bian The function autofs_expire_run calls dput(dentry) to drop the reference count of dentry. However, dentry is read via autofs_dentry_ino(dentry) after that. This may result in a use-free-bug. The patch drops the reference count of dentry only when it is never used. Signed-off-by:

[PATCH] binderfs: handle !CONFIG_IPC_NS builds

2019-01-11 Thread Christian Brauner
kbuild reported a build faile in [1]. This is triggered when CONFIG_IPC_NS is not set. So let's make the use of init_ipc_ns conditional on CONFIG_IPC_NS being set. [1]: https://lists.01.org/pipermail/kbuild-all/2019-January/056903.html Signed-off-by: Christian Brauner ---

[PATCH v3] RISC-V: defconfig: Enable Generic PCIE by default

2019-01-11 Thread Alistair Francis
Enable generic PCIe by default in the RISC-V defconfig, this allows us to use QEMU's PCIe support out of the box. Signed-off-by: Alistair Francis --- arch/riscv/configs/defconfig | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/riscv/configs/defconfig

Re: [PATCH] drm/msm: Fix A6XX support for opp-level

2019-01-11 Thread Jordan Crouse
On Fri, Jan 11, 2019 at 02:27:21PM -0800, Douglas Anderson wrote: > The bindings for Qualcomm opp levels changed after being Acked but > before landing. Thus the code in the GPU that was relying on the old > bindings is now broken. > > While we could just change the string 'qcom,level' to the

Re: [PATCH INTERNAL V3 0/3] Add support for PWM Configure and stablize for PWM kona

2019-01-11 Thread Ray Jui
On 1/11/2019 3:58 PM, Ray Jui wrote: > Please remove 'INTERNAL' in all of your patches and cover letter. > Never mind, saw your next patchset with this issue fixed > On 1/10/2019 9:08 PM, Sheetal Tigadoli wrote: >> Hi, >> This patchset contain support to make PWM changes configure

Re: [PATCH INTERNAL V3 0/3] Add support for PWM Configure and stablize for PWM kona

2019-01-11 Thread Ray Jui
Please remove 'INTERNAL' in all of your patches and cover letter. On 1/10/2019 9:08 PM, Sheetal Tigadoli wrote: > Hi, > This patchset contain support to make PWM changes configure > and stablize > Following are brief changes done > a. Add support for version2 compatible

  1   2   3   4   5   6   7   8   9   10   >