Re: possible deadlock in console_unlock

2019-02-15 Thread Sergey Senozhatsky
On (02/16/19 16:21), Sergey Senozhatsky wrote: > On (02/16/19 14:36), Yao HongBo wrote: > > hi, sergey: > > > > As shown in that link, https://lkml.org/lkml/2018/6/6/397 > > > > On the linux kernel 5.0-rc6, Syzkaller also hit 'possible deadlock in > > console_unlock' > > bug for several times

Re: [PATCH] ata: fix a race condition when internal cmd time out

2019-02-15 Thread Sergei Shtylyov
Hello! On 16.02.2019 6:42, Jason Yan wrote: For internal cmds, we will unmap DMA memory associated with the cmd before we abort the cmd. If DMA transfering data before the aborting, Transferring. bus error will occured. Occur. ata_exec_internal_sg ->ata_port_freeze if timeout

linux-next: Fixes tag needs some work in the kvm tree

2019-02-15 Thread Stephen Rothwell
Hi all, In commit aa8359972cfc ("KVM: x86/mmu: Differentiate between nr zapped and list unstable") Fixes tag Fixes: 54a4f0239f2e ("KVM: MMU: make kvm_mmu_zap_page() return has these problem(s): - Subject has leading but no trailing quotes Please do not split Fixes tags over more

Re: possible deadlock in console_unlock

2019-02-15 Thread Sergey Senozhatsky
On (02/16/19 14:36), Yao HongBo wrote: > hi, sergey: > > As shown in that link, https://lkml.org/lkml/2018/6/6/397 > > On the linux kernel 5.0-rc6, Syzkaller also hit 'possible deadlock in > console_unlock' > bug for several times in my environment. > > This solution fixes things for me. Do

[PATCH -next] drm/bridge: cdns: Remove set but not used variable 'bpp'

2019-02-15 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/gpu/drm/bridge/cdns-dsi.c: In function 'cdns_dsi_bridge_enable': drivers/gpu/drm/bridge/cdns-dsi.c:986:6: warning: variable 'bpp' set but not used [-Wunused-but-set-variable] It never used since introduction. Signed-off-by: YueHaibing ---

WARNING in __vunmap

2019-02-15 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:a048a07d7f45 powerpc/64s: Add support for a store forwardi.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1418d5a780 kernel config: https://syzkaller.appspot.com/x/.config?x=982e2df1b9e60b02

INFO: task hung in __flush_work

2019-02-15 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:90cadbbf341d Merge git://git.kernel.org/pub/scm/linux/kern.. git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=10a565c740 kernel config: https://syzkaller.appspot.com/x/.config?x=9d41c8529d7e7362

general protection fault in rt_cache_valid

2019-02-15 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:b71acb0e3721 Merge branch 'linus' of git://git.kernel.org/.. git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=1582bc30c0 kernel config: https://syzkaller.appspot.com/x/.config?x=b03c5892bb940c76

general protection fault in __vunmap

2019-02-15 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:cb5b020a8d38 Revert "exec: load_script: don't blindly trun.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=13c2886cc0 kernel config: https://syzkaller.appspot.com/x/.config?x=ee434566c893c7b1

general protection fault in reuseport_add_sock

2019-02-15 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:f9bcc9f3ee4f net: ethernet: freescale: set FEC ethtool reg.. git tree: net console output: https://syzkaller.appspot.com/x/log.txt?x=158a10f340 kernel config: https://syzkaller.appspot.com/x/.config?x=8f00801d7b7c4fe6

possible deadlock in console_unlock

2019-02-15 Thread Yao HongBo
hi, sergey: As shown in that link, https://lkml.org/lkml/2018/6/6/397 On the linux kernel 5.0-rc6, Syzkaller also hit 'possible deadlock in console_unlock' bug for several times in my environment. This solution fixes things for me. Do you have a plan to submit patches to solve this problem.

Re: WARNING: refcount bug in kvm_vm_ioctl

2019-02-15 Thread Dmitry Vyukov
On Fri, Feb 15, 2019 at 6:22 PM Jann Horn wrote: > > On Fri, Feb 15, 2019 at 6:13 PM Dmitry Vyukov wrote: > > On Fri, Feb 15, 2019 at 6:10 PM Jann Horn wrote: > > > On Fri, Feb 15, 2019 at 5:45 PM Dmitry Vyukov wrote: > > > > On Fri, Feb 15, 2019 at 5:03 PM Jann Horn wrote: > > > > > On Fri,

Re: next/master boot bisection: next-20190215 on beaglebone-black

2019-02-15 Thread Stephen Rothwell
rnelci.org bot" > > > wrote: > > > > > > Details:https://kernelci.org/boot/id/5c666ea959b514b017fe6017 > > > > Plain log: > > > > https://storage.kernelci.org//next/master/next-20190215/arm/multi_v7_defconfig+CONFIG_SMP=n/gcc-7/lab-collabora/

Re: [PATCH] gpu: drm: radeon: Set DPM_FLAG_NEVER_SKIP when enabling PM-runtime

2019-02-15 Thread Lukas Wunner
On Fri, Feb 15, 2019 at 11:01:04AM -0500, Alex Deucher wrote: > On Fri, Feb 15, 2019 at 10:39 AM Rafael J. Wysocki wrote: > > On HP ProBook 4540s, if PM-runtime is enabled in the radeon driver > > and the direct-complete optimization is used for the radeon device > > during system-wide suspend,

[PATCH -next] platform/chrome: Make function wilco_ec_transfer() static

2019-02-15 Thread Wei Yongjun
Fixes the following sparse warning: drivers/platform/chrome/wilco_ec/mailbox.c:126:5: warning: symbol 'wilco_ec_transfer' was not declared. Should it be static? Fixes: 436dad4fda10 ("platform/chrome: Add new driver for Wilco EC") Signed-off-by: Wei Yongjun ---

Re: [Lsf-pc] [LSF/MM TOPIC] The end of the DAX experiment

2019-02-15 Thread Dave Chinner
On Thu, Feb 14, 2019 at 12:20:11PM -0800, Dan Williams wrote: > On Thu, Feb 14, 2019 at 12:09 PM Matthew Wilcox wrote: > > > > On Thu, Feb 14, 2019 at 11:31:24AM -0800, Dan Williams wrote: > > > On Thu, Feb 14, 2019 at 11:10 AM Jerome Glisse wrote: > > > > I am just again working on my struct

Re: [PATCH net-next v3 0/9] net: Get rid of switchdev_port_attr_get()

2019-02-15 Thread Florian Fainelli
On 2/15/2019 8:55 PM, Florian Fainelli wrote: > Hi all, > > This patch series splits the removal of the switchdev_ops that was > proposed a few times before and first tackles the easy part which is the > removal of the single call to switchdev_port_attr_get() within the > bridge code. > > As

[PATCH net-next v3 4/9] mlxsw: spectrum_switchdev: Handle SWITCHDEV_PORT_ATTR_GET/SET

2019-02-15 Thread Florian Fainelli
Following patches will change the way we communicate getting or setting a port's attribute and use a blocking notifier to perform those tasks. Prepare mlxsw to support receiving notifier events targeting SWITCHDEV_PORT_ATTR_GET/SET and simply translate that into the existing

[PATCH net-next v3 2/9] switchdev: Add SWITCHDEV_PORT_ATTR_SET, SWITCHDEV_PORT_ATTR_GET

2019-02-15 Thread Florian Fainelli
In preparation for allowing switchdev enabled drivers to veto specific attribute settings from within the context of the caller, introduce a new switchdev notifier type for port attributes. Suggested-by: Ido Schimmel Signed-off-by: Florian Fainelli --- include/net/switchdev.h | 10 ++

[PATCH net-next v3 9/9] net: Remove switchdev_ops

2019-02-15 Thread Florian Fainelli
Now that we have converted all possible callers to using a switchdev notifier for attributes we do not have a need for implementing switchdev_ops anymore, and this can be removed from all drivers the net_device structure. Signed-off-by: Florian Fainelli ---

[PATCH net-next v3 7/9] net: dsa: Handle SWITCHDEV_PORT_ATTR_GET/SET

2019-02-15 Thread Florian Fainelli
Following patches will change the way we communicate getting or setting a port's attribute and use a blocking notifier to perform those tasks. Prepare DSA to support receiving notifier events targeting SWITCHDEV_PORT_ATTR_GET/SET and simply translate that into the existing

[PATCH net-next v3 8/9] net: switchdev: Replace port attr get/set SDO with a notification

2019-02-15 Thread Florian Fainelli
Drop switchdev_ops.switchdev_port_attr_get and _set. Drop the uses of this field from all clients, which were migrated to use switchdev notification in the previous patches. Add a new function switchdev_port_attr_notify() that sends the switchdev notifications SWITCHDEV_PORT_ATTR_GET and _SET.

[PATCH net-next v3 5/9] net: mscc: ocelot: Handle SWITCHDEV_PORT_ATTR_GET/SET

2019-02-15 Thread Florian Fainelli
Following patches will change the way we communicate getting or setting a port's attribute and use a blocking notifier to perform those tasks. Prepare ocelot to support receiving notifier events targeting SWITCHDEV_PORT_ATTR_GET/SET and simply translate that into the existing

[PATCH net-next v3 6/9] staging: fsl-dpaa2: ethsw: Handle SWITCHDEV_PORT_ATTR_GET/SET

2019-02-15 Thread Florian Fainelli
Following patches will change the way we communicate getting or setting a port's attribute and use a blocking notifier to perform those tasks. Prepare ethsw to support receiving notifier events targeting SWITCHDEV_PORT_ATTR_GET/SET and simply translate that into the existing

[PATCH net-next v3 3/9] rocker: Handle SWITCHDEV_PORT_ATTR_GET/SET

2019-02-15 Thread Florian Fainelli
Following patches will change the way we communicate getting or setting a port's attribute and use a blocking notifier to perform those tasks. Prepare rocker to support receiving notifier events targeting SWITCHDEV_PORT_ATTR_GET/SET and simply translate that into the existing

Re: [f2fs-dev] [PATCH] f2fs: don't clear CP_QUOTA_NEED_FSCK_FLAG

2019-02-15 Thread Jaegeuk Kim
On 02/13, Chao Yu wrote: > On 2019/2/12 10:33, Jaegeuk Kim wrote: > > If we met this once, let fsck.f2fs clear this only. > > Note that, this addresses all the subtle fault injection test. > > > > Signed-off-by: Jaegeuk Kim > > --- > > fs/f2fs/checkpoint.c | 2 -- > > 1 file changed, 2

[PATCH net-next v3 1/9] Documentation: networking: switchdev: Update port parent ID section

2019-02-15 Thread Florian Fainelli
Update the section about switchdev drivers having to implement a switchdev_port_attr_get() function to return SWITCHDEV_ATTR_ID_PORT_PARENT_ID since that is no longer valid after commit bccb30254a4a ("net: Get rid of SWITCHDEV_ATTR_ID_PORT_PARENT_ID"). Fixes: bccb30254a4a ("net: Get rid of

[PATCH net-next v3 0/9] net: Get rid of switchdev_port_attr_get()

2019-02-15 Thread Florian Fainelli
Hi all, This patch series splits the removal of the switchdev_ops that was proposed a few times before and first tackles the easy part which is the removal of the single call to switchdev_port_attr_get() within the bridge code. As suggestd by Ido, this patch series adds a

Re: [PATCH net-next v2 0/9] net: Get rid of switchdev_port_attr_get()

2019-02-15 Thread David Miller
From: Florian Fainelli Date: Fri, 15 Feb 2019 16:37:38 -0800 > David, please ignore this version, I will repost one that actually > builds, need to keep mangling with my kernel configuration and keep > those drivers enabled... Ok.

[PATCH] arm64/mm: skip hwasan callbacks for pgtable walker

2019-02-15 Thread Qian Cai
Page table walkers trigger soft lockups below with KASAN_SW_TAGS outline mode on a large ThunderX2 system, because there is too much overhead to call check_memory_region() for every memory access where it needs to dereference every byte of the corresponding KASAN shadow address for the correct

Re: [PATCH net-next] selftests: forwarding: Add some missing configuration symbols

2019-02-15 Thread David Miller
From: Florian Fainelli Date: Fri, 15 Feb 2019 10:14:52 -0800 > For the forwarding selftests to work, we need network namespaces when > using veth/vrf otherwise ping/ping6 commands like these: > > ip vrf exec vveth0 /bin/ping 192.0.2.2 -c 10 -i 0.1 -w 5 > > will fail because network namespaces

Re: [PATCH] x86: uaccess: fix regression in unsafe_get_user

2019-02-15 Thread Jann Horn
+Andy Lutomirski On Sat, Feb 16, 2019 at 12:59 AM wrote: > > From: Arthur Gautier > > When extracting an initramfs, a filename may be near an allocation boundary. > Should that happen, strncopy_from_user will invoke unsafe_get_user which > may cross the allocation boundary. Should that happen,

Re: [PATCH] net: phy: xgmiitorgmii: Support generic PHY status read

2019-02-15 Thread David Miller
From: Paul Kocialkowski Date: Fri, 15 Feb 2019 17:17:08 +0100 > Some PHY drivers like the generic one do not provide a read_status > callback on their own but rely on genphy_read_status being called > directly. > > With the current code, this results in a NULL function pointer call. > Call

Re: [PATCH][next] mlxsw: core: fix spelling mistake "temprature" -> "temperature"

2019-02-15 Thread David Miller
From: Colin King Date: Fri, 15 Feb 2019 15:11:53 + > From: Colin Ian King > > There is a spelling mistake in several dev_err messages, fix these. > > Signed-off-by: Colin Ian King Applied, thanks Colin.

Re: [PATCH v2 0/6] Add clock support for Actions Semi S500 SoC

2019-02-15 Thread Manivannan Sadhasivam
Hi Stephen, On Fri, Feb 01, 2019 at 09:23:43AM +0530, Manivannan Sadhasivam wrote: > Hi Stephen, > > On Tue, Jan 15, 2019 at 09:03:34AM +0530, Manivannan Sadhasivam wrote: > > Hello, > > > > This patchset adds common clock support for Actions Semi S500 SoC of > > the Owl family SoCs. This

Re: [PATCH v2 1/3] dt-bindings: ufs: Add HI3670 UFS controller binding

2019-02-15 Thread Manivannan Sadhasivam
On Fri, Jan 11, 2019 at 03:35:02PM -0600, Rob Herring wrote: > On Sat, 5 Jan 2019 12:58:57 +0530, Manivannan Sadhasivam wrote: > > Add devicetree binding for HI3670 UFS controller. HI3760 SoC is very > > similar to HI3660 SoC with almost same IPs. Only major difference in terms > > of UFS is the

Re: [PATCH] sched/x86: Save [ER]FLAGS on context switch

2019-02-15 Thread hpa
On February 14, 2019 2:14:29 AM PST, Peter Zijlstra wrote: >On Wed, Feb 13, 2019 at 02:49:47PM -0800, Andy Lutomirski wrote: > >> Do we need to backport this thing? > >Possibly, just to be safe. > >> The problem can’t be too widespread or we would have heard of it >before. > >Yes, so far we've

[PATCH] ata: fix a race condition when internal cmd time out

2019-02-15 Thread Jason Yan
For internal cmds, we will unmap DMA memory associated with the cmd before we abort the cmd. If DMA transfering data before the aborting, bus error will occured. ata_exec_internal_sg ->ata_port_freeze if timeout ->ata_qc_complete ->ata_sg_clean

Re: [PATCH v5 00/10] Add support for TISCI irqchip drivers

2019-02-15 Thread Lokesh Vutla
Hi Marc, On 2/12/2019 1:12 PM, Lokesh Vutla wrote: > TI AM65x SoC based on K3 architecture introduced support for Events > which are message based interrupts with minimal latency. These events > are not compatible with regular interrupts and are valid only through > an event transport lane. An

Re: [PATCH][V2] scsi: qla2xxx: remove redundant null check on pointer sess

2019-02-15 Thread Martin K. Petersen
Colin, > The null check on pointer sess and the subsequent call is redundant as > sess is null on all the the paths that lead to the out_term2 label. > Hence the null check and the call can be removed. Also remove the > redundant setting of sess to NULL as this is not required now. Applied to

Re: [PATCH v5 05/10] dt-bindings: irqchip: Introduce TISCI Interrupt router bindings

2019-02-15 Thread Lokesh Vutla
Hi Rob, On 2/12/2019 1:12 PM, Lokesh Vutla wrote: > Add the DT binding documentation for Interrupt router driver. > > Signed-off-by: Lokesh Vutla > --- > Changes since v4: > - None > > .../interrupt-controller/ti,sci-intr.txt | 85 +++ > MAINTAINERS

Re: [PATCH v5 05/10] dt-bindings: irqchip: Introduce TISCI Interrupt router bindings

2019-02-15 Thread Lokesh Vutla
Hi Tony, On 2/15/2019 9:46 PM, Tony Lindgren wrote: > Hi, > > * Lokesh Vutla [190214 18:03]: >> On 2/14/2019 11:16 PM, Tony Lindgren wrote: >>> But I'd rather have a proper hardware based phandle + index >>> type mapping in the dts if possible though. >> >> The idea about sysfw here is that

Re: [PATCH] scsi: libsas: Fix rphy phy_identifier for PHYs with end devices attached

2019-02-15 Thread Martin K. Petersen
John, > The sysfs phy_identifier attribute for a sas_end_device comes > from the rphy phy_identifier value. Applied to 5.0/scsi-fixes, thank you! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v2 3/4] Makefile: lld: tell clang to use lld

2019-02-15 Thread Masahiro Yamada
On Thu, Feb 14, 2019 at 8:08 AM Nick Desaulniers wrote: > > On Wed, Feb 13, 2019 at 6:59 AM Masahiro Yamada > wrote: > > > > On Tue, Feb 12, 2019 at 5:42 AM wrote: > > > > > > This is needed because clang doesn't select which linker to use based on > > > $LD but rather -fuse-ld=lld. This is

Re: [PATCH v2 2/4] Makefile: clang: choose GCC_TOOLCHAIN_DIR not on LD

2019-02-15 Thread Masahiro Yamada
On Tue, Feb 12, 2019 at 5:42 AM wrote: > > This causes an issue when trying to build with `make LD=ld.lld` if > ld.lld and the rest of your cross tools aren't in the same directory > (ex. /usr/local/bin) (as is the case for Android's build system), as the > GCC_TOOLCHAIN_DIR then gets set based

[PATCH v2 net-next] mdio_bus: Fix PTR_ERR() usage after initialization to constant

2019-02-15 Thread YueHaibing
Fix coccinelle warning: ./drivers/net/phy/mdio_bus.c:51:5-12: ERROR: PTR_ERR applied after initialization to constant on line 44 ./drivers/net/phy/mdio_bus.c:52:5-12: ERROR: PTR_ERR applied after initialization to constant on line 44 fix this by using IS_ERR before PTR_ERR Fixes: bafbdd527d56

Re: [PATCH v2 3/3] scsi: ufs: Add HI3670 SoC UFS driver support

2019-02-15 Thread Martin K. Petersen
Manivannan, > Ping on this patch! Applied to 5.1/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v2 4/4] Makefile: lld: set -O2 linker flag when linking with LLD

2019-02-15 Thread Masahiro Yamada
On Tue, Feb 12, 2019 at 5:42 AM wrote: > > For arm64: > 0.34% size improvement with lld -O2 over lld for vmlinux. > 3.3% size improvement with lld -O2 over lld for Image.lz4-dtb. > > Link: https://github.com/ClangBuiltLinux/linux/issues/343 > Suggested-by: Rui Ueyama > Suggested-by: Nathan

[PATCH] parisc: Fix ptrace syscall number modification

2019-02-15 Thread Dmitry V. Levin
Commit 910cd32e552e ("parisc: Fix and enable seccomp filter support") introduced a regression in ptrace-based syscall tampering: when tracer changes syscall number to -1, the kernel fails to initialize %r28 with -ENOSYS and subsequently fails to return the error code of the failed syscall to

Re: [PATCH net-next] mdio_bus: Fix PTR_ERR() usage after initialization to constant

2019-02-15 Thread YueHaibing
On 2019/2/1 12:24, Al Viro wrote: > On Tue, Jan 29, 2019 at 11:30:27AM +0800, YueHaibing wrote: gpiod = fwnode_get_named_gpiod(>dev.of_node->fwnode, "reset-gpios", 0, GPIOD_OUT_LOW, "PHY

[PATCH net-next] ptr_ring: remove duplicated include from ptr_ring.h

2019-02-15 Thread YueHaibing
Remove duplicated include. Signed-off-by: YueHaibing --- include/linux/ptr_ring.h | 1 - 1 file changed, 1 deletion(-) diff --git a/include/linux/ptr_ring.h b/include/linux/ptr_ring.h index 186cd8e..8da46ac 100644 --- a/include/linux/ptr_ring.h +++ b/include/linux/ptr_ring.h @@ -26,7 +26,6 @@

Re: [PATCH v2] of: unittest: unflatten device tree on UML when testing

2019-02-15 Thread Frank Rowand
On 2/15/19 6:18 PM, Frank Rowand wrote: > On 2/15/19 4:46 PM, Brendan Higgins wrote: >> UML supports enabling OF, and is useful for running the device tree >> tests, so add support for unflattening device tree blobs so we can >> actually use it. >> >> Signed-off-by: Brendan Higgins >> --- >>

Re: [PATCH] powerpc: use $(origin ARCH) to select KBUILD_DEFCONFIG

2019-02-15 Thread Masahiro Yamada
On Sat, Feb 16, 2019 at 1:11 AM Mathieu Malaterre wrote: > > On Fri, Feb 15, 2019 at 10:41 AM Masahiro Yamada > wrote: > > > > I often test all Kconfig commands for all architectures. To ease my > > workflow, I want 'make defconfig' at least working without any cross > > compiler. > > > >

Re: [PATCH 1/2 v2] kprobe: Do not use uaccess functions to access kernel memory that can fault

2019-02-15 Thread Steven Rostedt
On Fri, 15 Feb 2019 18:14:21 -0800 Andy Lutomirski wrote: > > In the uprobes case, we have: > > > > static nokprobe_inline int > > probe_mem_read(void *dest, void *src, size_t size) > > { > >void __user *vaddr = (void __force __user *)src; > > > >return copy_from_user(dest, vaddr,

Re: [PATCH v2] of: unittest: unflatten device tree on UML when testing

2019-02-15 Thread Frank Rowand
On 2/15/19 4:46 PM, Brendan Higgins wrote: > UML supports enabling OF, and is useful for running the device tree > tests, so add support for unflattening device tree blobs so we can > actually use it. > > Signed-off-by: Brendan Higgins > --- > drivers/of/unittest.c | 3 +++ > 1 file changed, 3

Re: [PATCH 1/2 v2] kprobe: Do not use uaccess functions to access kernel memory that can fault

2019-02-15 Thread Andy Lutomirski
> On Feb 15, 2019, at 6:08 PM, Steven Rostedt wrote: > > On Fri, 15 Feb 2019 17:32:55 -0800 > Andy Lutomirski wrote: > >>> I added you just because I wanted help getting the change log correct, >>> as that's what Linus was complaining about. I kept using "kernel >>> address" when the sample

find_get_entries_tag regression bisected

2019-02-15 Thread Dan Williams
Hi Willy, Piotr reports the following crash can be triggered on latest mainline: EXT4-fs (pmem5): recovery complete EXT4-fs (pmem5): mounted filesystem with ordered data mode. Opts: dax [ cut here ] kernel BUG at mm/pgtable-generic.c:127! invalid opcode: [#1]

Re: [PATCH 1/2 v2] kprobe: Do not use uaccess functions to access kernel memory that can fault

2019-02-15 Thread Steven Rostedt
On Fri, 15 Feb 2019 17:32:55 -0800 Andy Lutomirski wrote: > > I added you just because I wanted help getting the change log correct, > > as that's what Linus was complaining about. I kept using "kernel > > address" when the sample bug used for the patch was really a > > non-canonical address (as

Re: [PATCH] efi/libstub: refactor cmd_stubcopy

2019-02-15 Thread Masahiro Yamada
On Sat, Feb 16, 2019 at 12:38 AM Ard Biesheuvel wrote: > > On Fri, 15 Feb 2019 at 06:49, Masahiro Yamada > wrote: > > > > On Tue, Feb 12, 2019 at 4:26 PM Ard Biesheuvel > > wrote: > > > > > > On Tue, 12 Feb 2019 at 04:45, Masahiro Yamada > > > wrote: > > > > > > > > It took me a while to

Re: [PATCH] Fix resume for ELAN2097 touchscreen.

2019-02-15 Thread Jim Broadus
Happy new year. I think you might be right. I found some discussions about Dell disabling S3 support in a recent bios due to a C-state bug. I'll try to investigate a bit more this weekend. Jim On Fri, Feb 15, 2019 at 1:25 AM Kai-Heng Feng wrote: > > Hi Jiri and James, > > > On Feb 15, 2019, at

Re: [PATCH 1/2 v2] kprobe: Do not use uaccess functions to access kernel memory that can fault

2019-02-15 Thread Andy Lutomirski
> On Feb 15, 2019, at 4:19 PM, Steven Rostedt wrote: > > On Fri, 15 Feb 2019 15:49:35 -0800 > Andy Lutomirski wrote: > >> I’m missing most of the context here, but even probe_kernel_...() is >> unwise for a totally untrustworthy address. It could be MMIO, for >> example. > > True, but

[PATCH -next] ASoC: wm8741: Make function 'wm8741_mute' static

2019-02-15 Thread Wei Yongjun
Fixes the following sparse warning: sound/soc/codecs/wm8741.c:371:5: warning: symbol 'wm8741_mute' was not declared. Should it be static? Fixes: 36b1599340b5 ("ASoC: wm8741: Add digital mute callback") Signed-off-by: Wei Yongjun --- sound/soc/codecs/wm8741.c | 2 +- 1 file changed, 1

[PATCH -next] misc: fastrpc: Fix return value check in fastrpc_map_create()

2019-02-15 Thread Wei Yongjun
In case of error, the function dma_buf_get() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Signed-off-by: Wei Yongjun --- drivers/misc/fastrpc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH] ARM: dts: rockchip: add chosen node on veyron chromebooks

2019-02-15 Thread Alexandru M Stan
On Fri, Feb 15, 2019 at 3:09 PM Heiko Stübner wrote: > > Hi Enric, > > Am Freitag, 15. Februar 2019, 12:51:50 CET schrieb Enric Balletbo i Serra: > > In order to use earlycon, the stdout-path property needs to be set > > in the chosen node. > > > > Signed-off-by: Enric Balletbo i Serra > >

[PATCH -next] ASoC: samsung: i2s: Fix return value check in i2s_create_secondary_device()

2019-02-15 Thread Wei Yongjun
In case of error, the function platform_device_register_simple() returns ERR_PTR() and never returns NULL. The NULL test in the return value check should be replaced with IS_ERR(). Fixes: 7196c64c7d0c ("ASoC: samsung: i2s: Restore support for the secondary PCM") Signed-off-by: Wei Yongjun ---

[PATCH] doc: cgroup: correct the wrong information about measure of memory pressure

2019-02-15 Thread Yang Shi
Since PSI has implemented some kind of measure of memory pressure, the statement about lack of such measure is not true anymore. Cc: Tejun Heo Cc: Johannes Weiner Cc: Jonathan Corbet Signed-off-by: Yang Shi --- Documentation/admin-guide/cgroup-v2.rst | 3 +-- 1 file changed, 1 insertion(+),

Re: [PATCH -next] drm: Remove set but not used variable 'gem'

2019-02-15 Thread Eric Anholt
YueHaibing writes: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/gpu/drm/vc4/vc4_txp.c: In function 'vc4_txp_connector_atomic_check': > drivers/gpu/drm/vc4/vc4_txp.c:252:29: warning: > variable 'gem' set but not used [-Wunused-but-set-variable] > struct drm_gem_cma_object *gem;

[PATCH v2] of: unittest: unflatten device tree on UML when testing

2019-02-15 Thread Brendan Higgins
UML supports enabling OF, and is useful for running the device tree tests, so add support for unflattening device tree blobs so we can actually use it. Signed-off-by: Brendan Higgins --- drivers/of/unittest.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/of/unittest.c

Re: [PATCH 2/2] Input: add Apple SPI keyboard and trackpad driver.

2019-02-15 Thread Andy Shevchenko
On Sun, Feb 10, 2019 at 03:18:34AM -0800, Life is hard, and then you die wrote: > On Wed, Feb 06, 2019 at 10:22:56PM +0200, Andy Shevchenko wrote: > > On Mon, Feb 04, 2019 at 12:19:47AM -0800, Ronald Tschalär wrote: > > > +#define debug_print(mask, fmt, ...) \ > > > + do { \ > > > + if

RE: [PATCH V4 2/2] clk: imx: scu: add cpu frequency scaling support

2019-02-15 Thread Anson Huang
Hi, Stephen Best Regards! Anson Huang > -Original Message- > From: Stephen Boyd [mailto:sb...@kernel.org] > Sent: 2019年2月16日 7:58 > To: devicet...@vger.kernel.org; feste...@gmail.com; > ker...@pengutronix.de; linux-arm-ker...@lists.infradead.org; linux- > c...@vger.kernel.org;

Re: [PATCH V6 2/2] clk: imx: scu: add cpu frequency scaling support

2019-02-15 Thread Stephen Boyd
Quoting Anson Huang (2019-02-14 01:55:57) > On NXP's i.MX SoCs with system controller inside, CPU frequency > scaling can ONLY be done by system controller firmware, and it > can ONLY be requested from secure mode, so Linux kernel has to > call ARM SMC to trap to ARM-Trusted-Firmware to request

Re: [PATCH net-next 1/3] net: stmmac: Fix NAPI poll in TX path when in multi-queue

2019-02-15 Thread Florian Fainelli
On 2/15/19 5:42 AM, Jose Abreu wrote: > Commit 8fce33317023 introduced the concept of NAPI per-channel and > independent cleaning of TX path. > > This is currently breaking performance in some cases. The scenario > happens when all packets are being received in Queue 0 but the TX is > performed

Re: [PATCH net-next v2 0/9] net: Get rid of switchdev_port_attr_get()

2019-02-15 Thread Florian Fainelli
On 2/15/19 2:53 PM, Florian Fainelli wrote: > Hi all, > > This patch series splits the removal of the switchdev_ops that was > proposed a few times before and first tackles the easy part which is the > removal of the single call to switchdev_port_attr_get() within the > bridge code. > > As

Re: [PATCH] clk: samsung: s3c2443: Mark expected switch fall-through

2019-02-15 Thread Stephen Boyd
Quoting Kees Cook (2019-02-12 10:57:05) > On Mon, Feb 11, 2019 at 11:41 PM Krzysztof Kozlowski wrote: > > > > It is just the GCC which has to be fixed not the code. You want to > > adjust the code for specific version of GCC and what if GCC changes > > its warning? For example GCC might require

Re: [RFC v4 15/17] of: unittest: migrate tests to run on KUnit

2019-02-15 Thread Frank Rowand
On 2/14/19 1:37 PM, Brendan Higgins wrote: > Migrate tests without any cleanup, or modifying test logic in anyway to > run under KUnit using the KUnit expectation and assertion API. > > Signed-off-by: Brendan Higgins > --- > drivers/of/Kconfig|1 + > drivers/of/unittest.c | 1310

Re: [PATCH 6/8] ARM: at91: pm: add ULP1 support for SAM9X60

2019-02-15 Thread Stephen Boyd
Quoting claudiu.bez...@microchip.com (2019-02-14 07:54:57) > From: Claudiu Beznea > > Add ULP1 support for SAM9X60. In pm_suspend.S enable RC oscillator in > PMC if it is not enabled. At resume the state before suspend is > restored. > > Signed-off-by: Claudiu Beznea > --- >

Re: [PATCH v2 05/11] mfd: pm8xxx: disassociate old virq if hwirq mapping already exists

2019-02-15 Thread Brian Masney
On Fri, Feb 15, 2019 at 01:28:02PM -0800, Stephen Boyd wrote: > Quoting Brian Masney (2019-02-15 05:47:33) > > On Thu, Feb 14, 2019 at 09:51:26PM -0800, Stephen Boyd wrote: > > > > diff --git a/drivers/mfd/qcom-pm8xxx.c b/drivers/mfd/qcom-pm8xxx.c > > > > index 8eb2528793f9..2f99a98ccee5 100644 >

Re: [PATCH net-next v5] ipmr: ip6mr: Create new sockopt to clear mfc cache or vifs

2019-02-15 Thread Nikolay Aleksandrov
On 14/02/2019 04:44, Callum Sinclair wrote: > Currently the only way to clear the forwarding cache was to delete the > entries one by one using the MRT_DEL_MFC socket option or to destroy and > recreate the socket. > > Create a new socket option which with the use of optional flags can > clear

Re: [PATCH] sched/x86: Save [ER]FLAGS on context switch

2019-02-15 Thread Linus Torvalds
On Fri, Feb 15, 2019 at 3:34 PM Peter Zijlstra wrote: > > Now, EFLAGS bit 1 is supposedly always 1, but it really doesn't seem to > matter for POPF. Correct, it's "read as 1", you can try to write it and it doesn't matter. > I went through the other flags, and aside from VIP/VIF (I've no clue),

[PATCH] platform/x86: intel_pmc_core: Avoid a u32 overflow

2019-02-15 Thread Rajat Jain
The register (SLP_S0_RES) at offset slp_s0_offset is a 32 bit register. The pmc_core_adjust_slp_s0_step() could overflow the u32 value while returning it after adjusting the step. Thus change to u64, this is already accounted for in debugfs attribute (that wants to output a 64 bit value).

Re: [PATCH 1/2 v2] kprobe: Do not use uaccess functions to access kernel memory that can fault

2019-02-15 Thread Steven Rostedt
On Fri, 15 Feb 2019 15:49:35 -0800 Andy Lutomirski wrote: > I’m missing most of the context here, but even probe_kernel_...() is > unwise for a totally untrustworthy address. It could be MMIO, for > example. True, but kprobes are used like modules, and only allowed by root. They are used to

[PATCH] i2c: Allow recovery of the initial IRQ by a i2c client device.

2019-02-15 Thread Jim Broadus
A previous change allowed i2c client devices to discover new IRQs upon reprobe. By clearing the IRQ in i2c_device_remove. However, if an IRQ was assigned in i2c_new_device, that information is lost. For example, the touchscreen and trackpad devices on a Dell Inspiron laptop are I2C devices whose

Re: Crash in list_add_leaf_cfs_rq due to bad tmp_alone_branch

2019-02-15 Thread Gabriel Hartmann
Hi Vincent, On Fri, Jan 25, 2019 at 6:31 AM Vincent Guittot wrote: > > Hi Sargun, > > On Mon, 21 Jan 2019 at 15:46, Vincent Guittot > wrote: > > > > Hi Sargun, > > > > Le Friday 18 Jan 2019 à 15:06:28 (+0100), Vincent Guittot a écrit : > > > On Fri, 18 Jan 2019 at 11:16, Vincent Guittot > > >

[PATCH] x86: uaccess: fix regression in unsafe_get_user

2019-02-15 Thread baloo
From: Arthur Gautier When extracting an initramfs, a filename may be near an allocation boundary. Should that happen, strncopy_from_user will invoke unsafe_get_user which may cross the allocation boundary. Should that happen, unsafe_get_user will trigger a page fault, and strncopy_from_user

Re: [PATCH V4 2/2] clk: imx: scu: add cpu frequency scaling support

2019-02-15 Thread Stephen Boyd
Quoting Anson Huang (2019-02-13 17:54:08) > On NXP's i.MX SoCs with system controller inside, CPU frequency > scaling can ONLY be done by system controller firmware, and it > can ONLY be requested from secure mode, so Linux kernel has to > call ARM SMC to trap to ARM-Trusted-Firmware to request

Re: [PATCH v2 1/2] ARC: U-boot: check arguments paranoidly

2019-02-15 Thread Vineet Gupta
[...] > -char __initdata *uboot_arg; > +unsigned int __initdata uboot_arg; Why ? In both places it is actually used, it is intended as a pointer. The cast for range check is needed but lets cast there. See below for real reason. > -static inline int is_kernel(unsigned long addr) > +static

Re: [PATCH 1/2 v2] kprobe: Do not use uaccess functions to access kernel memory that can fault

2019-02-15 Thread Andy Lutomirski
> On Feb 15, 2019, at 2:15 PM, Steven Rostedt wrote: > > On Fri, 15 Feb 2019 09:55:32 -0800 > Linus Torvalds wrote: > >>> On Fri, Feb 15, 2019 at 9:49 AM Steven Rostedt wrote: >>> >>> From: Changbin Du >>> >>> The userspace can ask kprobe to intercept strings at any memory address, >>>

Re: [LSF/MM TOPIC] Discuss least bad options for resolving longterm-GUP usage by RDMA

2019-02-15 Thread Ira Weiny
On Fri, Feb 15, 2019 at 03:00:31PM -0700, Jason Gunthorpe wrote: > On Fri, Feb 15, 2019 at 06:31:36PM +, Christopher Lameter wrote: > > On Fri, 15 Feb 2019, Matthew Wilcox wrote: > > > > > > Since RDMA is something similar: Can we say that a file that is used for > > > > RDMA should not use

Re: [PATCH v3 8/9] s390: ap: Cleanup on removing the AP device

2019-02-15 Thread Tony Krowiak
On 2/14/19 8:51 AM, Pierre Morel wrote: When the device is remove, we must make sure to clear the interruption and reset the AP device. We also need to clear the CRYCB of the guest. Signed-off-by: Pierre Morel --- drivers/s390/crypto/vfio_ap_drv.c | 92

Re: [PATCH] sched/x86: Save [ER]FLAGS on context switch

2019-02-15 Thread Peter Zijlstra
On Fri, Feb 15, 2019 at 06:40:34PM +0100, Peter Zijlstra wrote: > On Fri, Feb 15, 2019 at 09:18:00AM -0800, Linus Torvalds wrote: > > On Thu, Feb 14, 2019 at 11:34 AM Peter Zijlstra > > wrote: > > > > > > Something like the below, right? > > > > > > + frame->flags = 0; > > > +

Re: [PATCH v3 8/9] s390: ap: Cleanup on removing the AP device

2019-02-15 Thread Tony Krowiak
On 2/14/19 8:51 AM, Pierre Morel wrote: When the device is remove, we must make sure to clear the interruption and reset the AP device. We also need to clear the CRYCB of the guest. Signed-off-by: Pierre Morel --- drivers/s390/crypto/vfio_ap_drv.c | 92

Re: [PATCH v2 1/2] leds: Add Intel Cherry Trail Whiskey Cove PMIC LEDs

2019-02-15 Thread Pavel Machek
On Fri 2019-02-15 22:41:31, Jacek Anaszewski wrote: > Hi Pavel, > > On 2/14/19 1:28 PM, Pavel Machek wrote: > >Hi! > > > >Jacek, could we get you to comment here? I'd prefer "hardware" trigger... > > What prevents use from using pattern trigger with its hw_pattern file? > > Do you remember

Re: [PATCH v2] tty: serial: meson_uart: Add support for kernel debugger

2019-02-15 Thread Kevin Hilman
Julien Masson writes: > The kgdb invokes the poll_put_char and poll_get_char when communicating > with the host. This patch implement the serial polling hooks for the > meson_uart to be used for KGDB debugging over serial line. > > Signed-off-by: Julien Masson Looks good, and very useful

Re: [PATCH v2 1/2] leds: Add Intel Cherry Trail Whiskey Cove PMIC LEDs

2019-02-15 Thread Hans de Goede
Hi, On 2/15/19 11:31 PM, Jacek Anaszewski wrote: On 2/15/19 11:26 PM, Hans de Goede wrote: I think that should work fine, which means that we can use the timer and pattern trigger support for the blinking and breathing modes. That still leaves the switching between user and hw-control

Re: [PATCH 1/2] misc: fastrpc: select CONFIG_DMA_SHARED_BUFFER

2019-02-15 Thread Randy Dunlap
On 2/15/19 2:40 AM, Srinivas Kandagatla wrote: > Fastrpc is a dma buf exporter as well, so select the corresponding > DMA_SHARED_BUFFER config to fix below compilation errors on platforms > without this config. > > ld: drivers/misc/fastrpc.o: in function 'fastrpc_free_map': >

Re: [PATCH v3 7/9] s390: ap: implement PAPQ AQIC interception in kernel

2019-02-15 Thread Tony Krowiak
On 2/14/19 8:51 AM, Pierre Morel wrote: We register the AP PQAP instruction hook during the open of the mediated device. And unregister it on release. In the AP PQAP instruction hook, if we receive a demand to enable IRQs, - we retrieve the vfio_ap_queue based on the APQN we receive in REG1,

Re: [PATCH] ARM: dts: rockchip: add chosen node on veyron chromebooks

2019-02-15 Thread Heiko Stübner
Hi Enric, Am Freitag, 15. Februar 2019, 12:51:50 CET schrieb Enric Balletbo i Serra: > In order to use earlycon, the stdout-path property needs to be set > in the chosen node. > > Signed-off-by: Enric Balletbo i Serra What's the reason for adding this only for the Chromebook variants? Uart2 is

Re: [PATCH v1 1/1] of: unittest: unflatten device tree on UML when testing

2019-02-15 Thread Frank Rowand
On 2/15/19 1:49 AM, Brendan Higgins wrote: > On Thu, Feb 14, 2019 at 6:48 PM Frank Rowand wrote: >> >> On 2/14/19 5:26 PM, Brendan Higgins wrote: >>> On Thu, Feb 14, 2019 at 4:10 PM Frank Rowand wrote: On 2/12/19 10:53 AM, Brendan Higgins wrote: > UML supports enabling OF, and is

Re: [PATCH 2/2] arm64: dts: Add SEI Robotics SEI510 Board

2019-02-15 Thread Kevin Hilman
Neil Armstrong writes: > The SEI Robotics SEI510 Board is based on the Amlogic G12A S905X2 > and has the following features : > - Amlogic G12A S905X2 SoC > - 10/100 Ethernet > - USB2 + USB3 ports > - Micro SDCard Port > - Audio + CVBS AV Jack port > - HDMI 2.1 + CEC Port > - ADC Touch Button > -

Re: [patch V5 4/8] nvme-pci: Simplify interrupt allocation

2019-02-15 Thread Thomas Gleixner
On Fri, 15 Feb 2019, Thomas Gleixner wrote: > On Fri, 15 Feb 2019, Ming Lei wrote: > > > + * If only one interrupt is available, combine write and read > > > + * queues. If 'write_queues' is set, ensure it leaves room for at > > > + * least one read queue. > > > + */ > > > + if (nrirqs == 1)

  1   2   3   4   5   6   7   8   9   10   >