Re: [PATCHv2] x86/boot/KASLR: skip the specified crashkernel reserved region

2019-03-24 Thread Pingfan Liu
On Fri, Mar 22, 2019 at 4:34 PM Baoquan He wrote: > > On 03/22/19 at 03:52pm, Baoquan He wrote: > > On 03/22/19 at 03:43pm, Pingfan Liu wrote: > > > > > +/* parse crashkernel=x@y option */ > > > > > +static void mem_avoid_crashkernel_simple(char *option) > > > > > > > > Chao ever mentioned this,

Re: [PATCH] dma:xgene-dma:move spin_lock_bh to spin_lock in tasklet

2019-03-24 Thread Vinod Koul
On 20-03-19, 00:45, Jeff Xie wrote: > It is unnecessary to call spin_lock_bh in a tasklet. 1. Please use the right subsystem name, dmaengine: xxx (you cna find that by git log on that subsystem) 2. Space after each :, like dmaengine: xgene-dma: move... 3. Please explain a bit more about the

[PATCH V2 4/8] mtip32xx: use blk_mq_queue_tag_inflight_iter

2019-03-24 Thread Jianchao Wang
blk_mq_tagset_busy_iter is not safe that it could get stale request in tags->rqs[]. Use blk_mq_queue_tag_inflight_iter here. Signed-off-by: Jianchao Wang --- drivers/block/mtip32xx/mtip32xx.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH V2 0/8]: blk-mq: use static_rqs to iterate busy tags

2019-03-24 Thread Jianchao Wang
Hi Jens As we know, there is a risk of accesing stale requests when iterate in-flight requests with tags->rqs[] and this has been talked in following thread, [1] https://marc.info/?l=linux-scsi=154511693912752=2 [2] https://marc.info/?l=linux-block=154526189023236=2 A typical sence could be

[PATCH V2 7/8] nvme: use blk_mq_queue_tag_inflight_iter

2019-03-24 Thread Jianchao Wang
blk_mq_tagset_inflight_iter is not safe that it could get stale request in tags->rqs[]. Use blk_mq_queue_tag_inflight_iter here. A new helper interface nvme_iterate_inflight_rqs is introduced to iterate all of the ns under a ctrl. Signed-off-by: Jianchao Wang --- drivers/nvme/host/core.c | 12

[PATCH V2 2/8] blk-mq: use static_rqs instead of rqs to iterate tags

2019-03-24 Thread Jianchao Wang
tags->rqs[] will not been cleaned when free driver tag to avoid an extra store on a shared area in the per io path. But there is a window between get driver tag and write tags->rqs[], so we may see stale rq in tags->rqs[] which may have been freed, as following case, blk_mq_get_request

[PATCH V2 5/8] nbd: use blk_mq_queue_tag_inflight_iter

2019-03-24 Thread Jianchao Wang
blk_mq_tagset_busy_iter is not safe that it could get stale request in tags->rqs[]. Use blk_mq_queue_tag_inflight_iter here. Signed-off-by: Jianchao Wang --- drivers/block/nbd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index

[PATCH V2 6/8] skd: use blk_mq_queue_tag_inflight_iter

2019-03-24 Thread Jianchao Wang
blk_mq_tagset_busy_iter is not safe that it could get stale request in tags->rqs[]. Use blk_mq_queue_tag_inflight_iter here. Signed-off-by: Jianchao Wang --- drivers/block/skd_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/block/skd_main.c

[PATCH V2 8/8] blk-mq: remove blk_mq_tagset_busy_iter

2019-03-24 Thread Jianchao Wang
As nobody uses blk_mq_tagset_busy_iter, remove it. Signed-off-by: Jianchao Wang --- block/blk-mq-tag.c | 95 -- include/linux/blk-mq.h | 2 -- 2 files changed, 97 deletions(-) diff --git a/block/blk-mq-tag.c b/block/blk-mq-tag.c index

[PATCH V2 1/8] blk-mq: get rid of the synchronize_rcu in __blk_mq_update_nr_hw_queues

2019-03-24 Thread Jianchao Wang
In commit 530ca2c (blk-mq: Allow blocking queue tag iter callbacks), we try to get a non-zero q_usage_counter to avoid access hctxs that being modified. So the synchronize_rcu is useless and should be removed. Reviewed-by: Ming Lei Signed-off-by: Jianchao Wang --- block/blk-mq-tag.c | 4 +---

[PATCH V2 3/8] blk-mq: use blk_mq_queue_tag_inflight_iter in debugfs

2019-03-24 Thread Jianchao Wang
blk_mq_tagset_busy_iter is not safe that it could get stale request in tags->rqs[]. Use blk_mq_queue_tag_inflight_iter here. Signed-off-by: Jianchao Wang --- block/blk-mq-debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/blk-mq-debugfs.c

Re: [PATCH v2] RISC-V: Always compile mm/init.c with cmodel=medany

2019-03-24 Thread Alan Kao
Hi Anup, Sorry for being late to the party. I think one more thing should move together with setup_vm(): On Mon, Mar 25, 2019 at 03:37:38AM +, Anup Patel wrote: > The Linux RISC-V 32bit kernel is broken after we moved setup_vm() from > kernel/setup.c to mm/init.c because Linux RISC-V 32bit

Re: Virtio-scsi multiqueue irq affinity

2019-03-24 Thread Peter Xu
On Sat, Mar 23, 2019 at 06:15:59PM +0100, Thomas Gleixner wrote: > Peter, Hi, Thomas, > > On Mon, 18 Mar 2019, Peter Xu wrote: > > I noticed that starting from commit 0d9f0a52c8b9 ("virtio_scsi: use > > virtio IRQ affinity", 2017-02-27) the virtio scsi driver is using a > > new way (via

[PATCH] ARM: dts: imx6qdl: Specify IMX6QDL_CLK_IPG as "ipg" clock for SDMA

2019-03-24 Thread Andrey Smirnov
Since 25aaa75df1e6 SDMA driver uses clock rates of "ipg" and "ahb" clock to determine if it needs to configure the IP block as operating at 1:1 or 1:2 clock ratio (ACR bit in SDMAARM_CONFIG). Specifying both clocks as IMX6QDL_CLK_SDMA results in driver incorrectly thinking that ratio is 1:1 which

Re: [PATCH v2] dmaengine: pl330: introduce debugfs interface

2019-03-24 Thread Vinod Koul
On 17-03-19, 19:03, Katsuhiro Suzuki wrote: > This patch adds debugfs interface to show the relationship between > DMA threads (hardware resource for transferring data) and DMA > channel ID of DMA slave. > > Typically, PL330 has many slaves than number of DMA threads. > So sometimes PL330 cannot

Re: KASAN: use-after-free Read in path_lookupat

2019-03-24 Thread Al Viro
On Sun, Mar 24, 2019 at 06:23:24PM -0700, Linus Torvalds wrote: > Al, comments? At the very least, if we don't make > simple_symlink_inode_operations() do that, we should have a *big* > comment that if it's not part of the inode data, it needs to be > RCU-delayed.

Re: [PATCH 2/3] dmaengine: omap-dma: make omap_dma_filter_fn private

2019-03-24 Thread Vinod Koul
On 08-03-19, 16:32, Peter Ujfalusi wrote: > > > On 07/03/2019 17.16, Arnd Bergmann wrote: > > With the audio driver no longer referring to this function, it > > can be made private to the dmaengine driver itself, and the > > header file removed. Applied, thanks -- ~Vinod

Re: [PATCH 3/3] dmaengine: edma: make edma_filter_fn private

2019-03-24 Thread Vinod Koul
On 07-03-19, 16:16, Arnd Bergmann wrote: > With the audio driver no longer referring to this function, it > can be made private to the dmaengine driver itself, and the > header file removed. Applied, thanks -- ~Vinod

RE: [PATCH v3 2/5] dt-bindings: devfreq: rk3399_dmc: Add rockchip,pmu phandle.

2019-03-24 Thread MyungJoo Ham
>From: Enric Balletbo i Serra > >The Rockchip DMC (Dynamic Memory Interface) needs to access to the PMU >general register files to know the DRAM type, so add a phandle to the >syscon that manages these registers. > >Signed-off-by: Enric Balletbo i Serra >Reviewed-by: Chanwoo Choi >Acked-by: Rob

Re: [PATCH v3 1/2] dmaengine: tegra210-adma: use devm_clk_*() helpers

2019-03-24 Thread Vinod Koul
On 13-03-19, 17:02, Sameer Pujar wrote: > adma driver is using pm_clk_*() interface for managing clock resources. > With this it is observed that clocks remain ON always. This happens on > Tegra devices which use BPMP co-processor to manage clock resources, > where clocks are enabled during

RE: [PATCH v3 1/5] devfreq: rockchip-dfi: Move GRF definitions to a common place.

2019-03-24 Thread MyungJoo Ham
>From: Enric Balletbo i Serra > >Some rk3399 GRF (Generic Register Files) definitions can be used for >different drivers. Move these definitions to a common include so we >don't need to duplicate these definitions. > >Signed-off-by: Enric Balletbo i Serra >Acked-by: Chanwoo Choi >Signed-off-by:

RE: Re: [PATCH] PM / devfreq: exynos-bus: Suspend all devices on system shutdown

2019-03-24 Thread MyungJoo Ham
>Hi Chanwoo, > >On 2019-03-21 10:19, Chanwoo Choi wrote: >> On 19. 3. 21. 오후 6:01, Marek Szyprowski wrote: >>> Force all Exynos buses to safe operation points before doing the system >>> reboot operation. There are board on which some aggressive power saving >>> operation points are behind the

Re: [PATCH v2 4/9] dt-bindings: power: Add rpm power domain bindings for qcs404

2019-03-24 Thread Rajendra Nayak
On 3/24/2019 11:20 PM, Sibi Sankar wrote: From: Bjorn Andersson Add RPM Power domain bindings for the qcs404 family of SoC [sibis: Add supported rpmpd states for qcs404] Signed-off-by: Sibi Sankar SoB ordering seems wrong. Signed-off-by: Bjorn Andersson ---

Re: [PATCH v2 2/5] RISC-V: Make setup_vm() independent of GCC code model

2019-03-24 Thread Anup Patel
On Sat, Mar 23, 2019 at 9:15 PM Mike Rapoport wrote: > > On Thu, Mar 21, 2019 at 09:47:47AM +, Anup Patel wrote: > > The setup_vm() must access kernel symbols in a position independent way > > because it will be called from head.S with MMU off. > > > > If we compile kernel with cmodel=medany

Re: [PATCH v2 4/5] RISC-V: Remove redundant trampoline page table

2019-03-24 Thread Anup Patel
On Fri, Mar 22, 2019 at 7:03 PM Christoph Hellwig wrote: > > > > > - /* Compute satp for kernel page tables, but don't load it yet */ > > + /* Compute satp for kernel page directory, but don't load it yet */ > > > > /* > > - * Load trampoline page directory, which will cause us

[PATCH 2/2] dmaengine: milbeaut: Add Milbeaut AXI DMA controller

2019-03-24 Thread Kazuhiro Kasai
Add Milbeaut AXI DMA controller. This DMA controller has only capable of memory to memory transfer. Signed-off-by: Kazuhiro Kasai --- drivers/dma/Kconfig | 8 + drivers/dma/Makefile | 1 + drivers/dma/xdmac-milbeaut.c | 353 +++ 3

[PATCH 1/2] dt-bindings: dmaengine: Add Milbeaut AXI DMA controller bindings

2019-03-24 Thread Kazuhiro Kasai
Add Milbeaut AXI DMA controller bindings. This DMA controller has only capable of memory to memory transfer. Signed-off-by: Kazuhiro Kasai --- .../devicetree/bindings/dma/xdmac-milbeaut.txt | 24 ++ 1 file changed, 24 insertions(+) create mode 100644

[PATCH 0/2] Add support for AXI DMA controller on Milbeaut series

2019-03-24 Thread Kazuhiro Kasai
The following series adds AXI DMA controller support on Milbeaut series. This controller has only capable of memory to memory transfer. Kazuhiro Kasai (2): dt-bindings: dmaengine: Add Milbeaut AXI DMA controller bindings dmaengine: milbeaut: Add Milbeaut AXI DMA controller

Re: [PATCH v2 3/9] soc: qcom: rpmpd: Modify corner defining macros

2019-03-24 Thread Rajendra Nayak
On 3/24/2019 11:20 PM, Sibi Sankar wrote: From: Bjorn Andersson QCS404 uses individual resource type magic for each power-domain, so adjust the macros slightly to make them reusable for this. [sibi: Extend rpmpd corner pair to a generic rpmpd pair] This needs to be right above your SoB I

Re: [PATCH] nds32: remove unused generic-y += cmpxchg-local.h

2019-03-24 Thread Greentime Hu
Hi Yamada, Masahiro Yamada 於 2019年3月22日 週五 下午11:22寫道: > > NDS32 is the only architecture that creates , > which is not included anyone. > > Signed-off-by: Masahiro Yamada > --- > > arch/nds32/include/asm/Kbuild | 1 - > 1 file changed, 1 deletion(-) > > diff --git

Re: [PATCH v2 2/9] soc: qcom: rpmpd: Add support to set rpmpd state to max

2019-03-24 Thread Rajendra Nayak
On 3/24/2019 11:20 PM, Sibi Sankar wrote: Add support to set rpmpd state to max across SoCs. Changelog could be better, 'rpmpd max state varies across SoCs and SoC families, add support in the driver to make it SoC/SoC family specific' Signed-off-by: Sibi Sankar ---

Re: [PATCH v2 1/9] soc: qcom: rpmpd: fixup rpmpd set performance state

2019-03-24 Thread Rajendra Nayak
On 3/24/2019 11:19 PM, Sibi Sankar wrote: Fixup rpmpd state to max if the required state is greater than all the supported states. This should also say why, 'so the clients which just want to vote on whatever is the max state supported can do so by passing an INT_MAX'? Fixes: 075d3db8d10d

RE: [RFC PATCH 2/3] arch/x86/acrn: Use HYPERVISOR_CALLBACK_VECTOR for Acrn upcall vector

2019-03-24 Thread Zhao, Yakui
>-Original Message- >From: Thomas Gleixner [mailto:t...@linutronix.de] >Sent: Friday, March 22, 2019 11:45 PM >To: Zhao, Yakui >Cc: linux-kernel@vger.kernel.org; x...@kernel.org; Chen, Jason CJ > >Subject: Re: [RFC PATCH 2/3] arch/x86/acrn: Use >HYPERVISOR_CALLBACK_VECTOR for Acrn

[patch v14 4/4] irqchip/qeic: remove PPCisms for QEIC

2019-03-24 Thread Qiang Zhao
QEIC was supported on PowerPC, and dependent on PPC, Now it is supported on other platforms, so remove PPCisms. Signed-off-by: Zhao Qiang --- arch/powerpc/platforms/83xx/km83xx.c |1 - arch/powerpc/platforms/83xx/misc.c|1 - arch/powerpc/platforms/83xx/mpc832x_mds.c

[patch v14 1/4] irqchip/qeic: move qeic driver from drivers/soc/fsl/qe

2019-03-24 Thread Qiang Zhao
move the driver from drivers/soc/fsl/qe to drivers/irqchip, merge qe_ic.h and qe_ic.c into irq-qeic.c. Signed-off-by: Zhao Qiang --- MAINTAINERS|6 + drivers/irqchip/Makefile |1 + drivers/{soc/fsl/qe/qe_ic.c =>

[patch v14 2/4] irqchip/qeic: merge qeic init code from platforms to a common function

2019-03-24 Thread Qiang Zhao
The codes of qe_ic init from a variety of platforms are redundant, merge them to a common function and put it to irqchip/irq-qeic.c For non-p1021_mds mpc85xx_mds boards, use "qe_ic_init(np, 0, qe_ic_cascade_low_mpic, qe_ic_cascade_high_mpic);" instead of "qe_ic_init(np, 0,

[PATCH 0/4] This patchset is to remove PPCisms for QEIC

2019-03-24 Thread Qiang Zhao
QE is an IP block included in SoC of fsl PowerPC series and layerscape series, its interrupt contoller was put under drivers/soc/fsl/qe, now move to driver/irqchip. And QEIC is supported more than just powerpc boards, so remove PPCisms. changelog: Changes for v2: - modify

[patch v14 3/4] irqchip/qeic: merge qeic_of_init into qe_ic_init

2019-03-24 Thread Qiang Zhao
qeic_of_init just get device_node of qeic from dtb and call qe_ic_init, pass the device_node to qe_ic_init. So merge qeic_of_init into qe_ic_init to get the qeic node in qe_ic_init. Signed-off-by: Zhao Qiang --- drivers/irqchip/irq-qeic.c | 110

Re: [PATCH v4 4/6] x86/mm/KASLR: Fix the wrong calculation of memory region initial size

2019-03-24 Thread Baoquan He
On 03/24/19 at 09:58pm, Thomas Gleixner wrote: > On Thu, 14 Mar 2019, Baoquan He wrote: > > In memory region KASLR, __PHYSICAL_MASK_SHIFT is taken to calculate > > the initial size of the direct mapping region. This is correct in > > the old code where __PHYSICAL_MASK_SHIFT was equal to

[PATCH v2] RISC-V: Always compile mm/init.c with cmodel=medany

2019-03-24 Thread Anup Patel
The Linux RISC-V 32bit kernel is broken after we moved setup_vm() from kernel/setup.c to mm/init.c because Linux RISC-V 32bit kernel by default uses cmodel=medlow which results in a non-position-independent setup_vm(). This patch fixes Linux RISC-V 32bit kernel booting by: 1. Forcing

RE: [RFC PATCH 1/3] arch/x86: add ACRN hypervisor guest

2019-03-24 Thread Zhao, Yakui
Hi, Tglx Thanks for your nice review. >-Original Message- >From: Thomas Gleixner [mailto:t...@linutronix.de] >Sent: Friday, March 22, 2019 11:20 PM >To: Zhao, Yakui >Cc: linux-kernel@vger.kernel.org; x...@kernel.org; Chen, Jason CJ > >Subject: Re: [RFC PATCH 1/3] arch/x86: add

[PATCH 06/17] fpga: dfl: pci: enable SRIOV support.

2019-03-24 Thread Wu Hao
This patch enables the standard sriov support. It allows user to enable SRIOV (and VFs), then user could pass through accelerators (VFs) into virtual machine or use VFs directly in host. Signed-off-by: Zhang Yi Z Signed-off-by: Xu Yilun Signed-off-by: Wu Hao --- drivers/fpga/dfl-pci.c | 40

[PATCH 03/17] fpga: dfl: fme: support 512bit data width PR

2019-03-24 Thread Wu Hao
In early partial reconfiguration private feature, it only supports 32bit data width when writing data to hardware for PR. 512bit data width PR support is an important optimization for some specific solutions (e.g. XEON with FPGA integrated), it allows driver to use AVX512 instruction to improve

[PATCH 05/17] fpga: dfl: fme: add DFL_FPGA_FME_PORT_RELEASE/ASSIGN ioctl support.

2019-03-24 Thread Wu Hao
In order to support virtualization usage via PCIe SRIOV, this patch adds two ioctls under FPGA Management Engine (FME) to release and assign back the port device. In order to safely turn Port from PF into VF and enable PCIe SRIOV, it requires user to invoke this PORT_RELEASE ioctl to release port

[PATCH 07/17] fpga: dfl: afu: add AFU state related sysfs interfaces

2019-03-24 Thread Wu Hao
This patch introduces more sysfs interfaces for Accelerated Function Unit (AFU). These interfaces allow users to read current AFU Power State (APx), read / clear AFU Power (APx) events which are sticky to identify transient APx state, and manage AFU's LTR (latency tolerance reporting).

[PATCH 13/17] fpga: dfl: fme: add capability sysfs interfaces

2019-03-24 Thread Wu Hao
This patch adds 3 read-only sysfs interfaces for FPGA Management Engine (FME) block for capabilities including cache_size, fabric_version and socket_id. Signed-off-by: Luwei Kang Signed-off-by: Xu Yilun Signed-off-by: Wu Hao --- Documentation/ABI/testing/sysfs-platform-dfl-fme | 23

[PATCH 12/17] fpga: dfl: afu: add STP (SignalTap) support

2019-03-24 Thread Wu Hao
STP (SignalTap) is one of the private features under the port for debugging. This patch adds private feature driver support for it to allow userspace applications to mmap related mmio region and provide STP service. Signed-off-by: Xu Yilun Signed-off-by: Wu Hao --- drivers/fpga/dfl-afu-main.c

[PATCH 16/17] fpga: dfl: fme: add global error reporting support

2019-03-24 Thread Wu Hao
This patch adds support for global error reporting for FPGA Management Engine (FME), it introduces sysfs interfaces to report different error detected by the hardware, and allow user to clear errors or inject error for testing purpose. Signed-off-by: Luwei Kang Signed-off-by: Ananda Ravuri

[PATCH 11/17] fpga: dfl: afu: add error reporting support.

2019-03-24 Thread Wu Hao
Error reporting is one important private feature, it reports error detected on port and accelerated function unit (AFU). It introduces several sysfs interfaces to allow userspace to check and clear errors detected by hardware. Signed-off-by: Xu Yilun Signed-off-by: Wu Hao ---

[PATCH 15/17] fpga: dfl: fme: add power management support

2019-03-24 Thread Wu Hao
This patch adds support for power management private feature under FPGA Management Engine (FME), sysfs interfaces are introduced for different power management functions, users could use these sysfs interface to get current number of consumed power, throttling thresholds, threshold status and

[PATCH 10/17] fpga: dfl: afu: export __port_enable/disable function.

2019-03-24 Thread Wu Hao
As these two functions are used by other private features. e.g. in error reporting private feature, it requires to check port status and reset port for error clearing. Signed-off-by: Xu Yilun Signed-off-by: Wu Hao --- drivers/fpga/dfl-afu-main.c | 25 ++---

[PATCH 04/17] Documentation: fpga: dfl: add descriptions for virtualization and new interfaces.

2019-03-24 Thread Wu Hao
This patch adds virtualization support description for DFL based FPGA devices (based on PCIe SRIOV), and introductions to new interfaces added by new dfl private features. Signed-off-by: Xu Yilun Signed-off-by: Wu Hao --- Documentation/fpga/dfl.txt | 115

[PATCH 17/17] fpga: dfl: fme: add performance reporting support

2019-03-24 Thread Wu Hao
This patch adds support for performance reporting private feature for FPGA Management Engine (FME). Actually it supports 4 categories performance counters, 'clock', 'cache', 'iommu' and 'fabric', user could read the performance counter via exposed sysfs interfaces. Please refer to sysfs doc for

[PATCH 14/17] fpga: dfl: fme: add thermal management support

2019-03-24 Thread Wu Hao
This patch adds support to thermal management private feature for DFL FPGA Management Engine (FME). As thermal throttling is handled by hardware automatically per pre-defined thresholds, this private feature driver only provides read-only sysfs interfaces for user to read temperature, thresholds,

[PATCH 08/17] fpga: dfl: afu: add userclock sysfs interfaces.

2019-03-24 Thread Wu Hao
This patch introduces userclock sysfs interfaces for AFU, user could use these interfaces for clock setting to AFU. Please note that, this is only working for port header feature with revision 0, for later revisions, userclock setting is moved to a separated private feature, so one revision sysfs

[PATCH 01/17] fpga: dfl-fme-mgr: fix FME_PR_INTFC_ID register address.

2019-03-24 Thread Wu Hao
FME_PR_INTFC_ID is used as compat_id for fpga manager and region, but high 64 bits and low 64 bits of the compat_id are swapped by mistake. This patch fixes this problem by fixing register address. Signed-off-by: Wu Hao --- drivers/fpga/dfl-fme-mgr.c | 4 ++-- 1 file changed, 2 insertions(+), 2

[PATCH 00/17] add new features for FPGA DFL drivers

2019-03-24 Thread Wu Hao
This patchset adds more features support for FPGA Device Feature List (DFL) drivers, including PR enhancement, virtualization support based on PCIe SRIOV, private features to Port, private features to FME, and enhancement to DFL framework. Please refer to details in below list. Patch 1: A bug

[PATCH 09/17] fpga: dfl: add id_table for dfl private feature driver

2019-03-24 Thread Wu Hao
This patch adds id_table for each dfl private feature driver, it allows to reuse same private feature driver to match and support multiple dfl private features. Signed-off-by: Xu Yilun Signed-off-by: Wu Hao --- drivers/fpga/dfl-afu-main.c | 14 -- drivers/fpga/dfl-fme-main.c | 11

[PATCH 02/17] fpga: dfl: fme: align PR buffer size per PR datawidth

2019-03-24 Thread Wu Hao
Current driver checks if input bitstream file size is aligned or not per PR data width (default 32bits). It requires one additional step for end user when they generate the bitstream file, padding extra zeros to bitstream file to align its size per PR data width, but they don't have to as hardware

Re: [PATCH] RISC-V: Always compile mm/init.c with cmodel=medany

2019-03-24 Thread Anup Patel
On Mon, Mar 25, 2019 at 12:44 AM Gary Guo wrote: > > > > > -Original Message- > > From: linux-riscv On Behalf Of > > Anup > > Patel > > Sent: Sunday, March 24, 2019 11:08 > > To: Palmer Dabbelt ; Albert Ou > > Cc: Anup Patel ; linux-kernel@vger.kernel.org; Mike > > Rapoport ; Christoph

Re: [PATCH] RISC-V: Always compile mm/init.c with cmodel=medany

2019-03-24 Thread Anup Patel
On Sun, Mar 24, 2019 at 8:27 PM Christoph Hellwig wrote: > > On Sun, Mar 24, 2019 at 11:08:29AM +, Anup Patel wrote: > > Signed-off-by: Christoph Hellwig > > Signed-off-by: Mike Rapoport > > Huh? I don't think this is from Mike and me. > > > +unsigned long va_pa_offset; > >

Re: [PATCH] RISC-V: Always compile mm/init.c with cmodel=medany

2019-03-24 Thread Anup Patel
On Sun, Mar 24, 2019 at 10:13 PM Mike Rapoport wrote: > > On Sun, Mar 24, 2019 at 03:57:08PM +0100, Christoph Hellwig wrote: > > On Sun, Mar 24, 2019 at 11:08:29AM +, Anup Patel wrote: > > > Signed-off-by: Christoph Hellwig > > > Signed-off-by: Mike Rapoport > > > > Huh? I don't think this

[PATCH 3/3] clocksource/drivers/timer-milbeaut: Cleanup common register accesses

2019-03-24 Thread Sugaya Taichi
Aggregate common register accesses into shared functions for maintainability. Signed-off-by: Sugaya Taichi --- drivers/clocksource/timer-milbeaut.c | 62 +++- 1 file changed, 39 insertions(+), 23 deletions(-) diff --git a/drivers/clocksource/timer-milbeaut.c

[PATCH 0/3] Bugfix and cleanup the timer driver for Milbeaut M10V

2019-03-24 Thread Sugaya Taichi
This series fixes a bug and cleanup code about timer driver for Milbeaut M10V. Since it is difficult to separate, it is integrated into a series. Sugaya Taichi (3): clocksource/drivers/timer-milbeaut: Fix to enable one-shot timer clocksource/drivers/timer-milbeaut: Add shutdown function

linux-next: Tree for Mar 25

2019-03-24 Thread Stephen Rothwell
Hi all, Changes since 20190322: Non-merge commits (relative to Linus' tree): 2741 2308 files changed, 76588 insertions(+), 37798 deletions(-) I have created today's linux-next tree at

[PATCH v2 -next] ASoC: simple-card-utils: remove set but not used variable 'dai_name'

2019-03-24 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: sound/soc/generic/simple-card-utils.c: In function 'asoc_simple_parse_clk': sound/soc/generic/simple-card-utils.c:164:18: warning: parameter 'dai_name' set but not used [-Wunused-but-set-parameter] It's not used since commit 0580dde59438 ("ASoC:

[PATCH 2/3] clocksource/drivers/timer-milbeaut: Add shutdown function

2019-03-24 Thread Sugaya Taichi
Add a shutdown operation to support shutdown timer. Signed-off-by: Sugaya Taichi --- drivers/clocksource/timer-milbeaut.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/clocksource/timer-milbeaut.c b/drivers/clocksource/timer-milbeaut.c index 9fd5d08..f478061 100644

[PATCH 1/3] clocksource/drivers/timer-milbeaut: Fix to enable one-shot timer

2019-03-24 Thread Sugaya Taichi
Fix mlb_set_oneshot_state() to enable one-shot timer. The function should stop and start a timer, but "start" statement was dropped. Kick the register to start one-shot timer. Signed-off-by: Sugaya Taichi --- drivers/clocksource/timer-milbeaut.c | 2 ++ 1 file changed, 2 insertions(+) diff

Re: [PATCH -next] ASoC: simple-card-utils: remove set but not used variable ''

2019-03-24 Thread YueHaibing
On 2019/3/25 10:31, Kuninori Morimoto wrote: > > Hi > >> Fixes gcc '-Wunused-but-set-variable' warning: >> >> sound/soc/generic/simple-card-utils.c: In function 'asoc_simple_parse_clk': >> sound/soc/generic/simple-card-utils.c:164:18: warning: >> parameter 'dai_name' set but not used

Re: Linux 5.1-rc2

2019-03-24 Thread Randy Dunlap
On 3/24/19 2:26 PM, Linus Torvalds wrote: > Well, we're a week away from the merge window close, and here's rc2. > Things look fairly normal, but honestly, rc2 is usually too early to > tell. People haven't necessarily had time to notice problems yet. > Which is just another way of saying "please

Re: pick_next_task() picking the wrong task [v4.9.163]

2019-03-24 Thread Radu Rendec
On Sat, 2019-03-23 at 11:15 +0100, Peter Zijlstra wrote: > On Fri, Mar 22, 2019 at 05:57:59PM -0400, Radu Rendec wrote: > > Hi Everyone, > > > > I believe I'm seeing a weird behavior of pick_next_task() where it > > chooses a lower priority task over a higher priority one. The scheduling > >

BUG: KASAN: stack-out-of-bounds in unwind_next_frame (*Reproducible*)

2019-03-24 Thread Gen Zhang
Hi, I think I found a reproducible kernel bug in version 5.0.4. Source file: arch/x86/kernel/unwind_orc.c:505 The KASAN output is as following: [ 26.095365] BUG: KASAN: stack-out-of-bounds in unwind_next_frame+0x1403/0x19e0 [ 26.095365] Read of size 8 at addr 88805cc67d18 by task

Re: [PATCH 11/17] x86/kprobes: Make trampoline_handler global and visible

2019-03-24 Thread Masami Hiramatsu
On Sat, 23 Mar 2019 07:35:18 -0700 Andi Kleen wrote: > On Sat, Mar 23, 2019 at 06:45:21PM +0900, Masami Hiramatsu wrote: > > On Thu, 21 Mar 2019 15:00:03 -0700 > > Andi Kleen wrote: > > > > > From: Andi Kleen > > > > > > This function is referenced from assembler, so in LTO > > > it needs to

LET ME KNOW

2019-03-24 Thread Ragnhild Lilly Button
Dear Beloved One, I am Mrs Ragnhild Lilly Button, it's true we do not know one another but My spirit led me to write this email, so please don't be annoyed or embarrased. I write you with heavy heart and great joy of sorrow because I am shocked today when finally I was informed by my doctor

Re: [PATCH 1/3] staging: erofs: fix error handling when failed to read compresssed data

2019-03-24 Thread Gao Xiang
Hi, On 2019/3/25 8:38, Sasha Levin wrote: > Hi, > > [This is an automated email] > > This commit has been processed because it contains a "Fixes:" tag, > fixing commit: 3883a79abd02 staging: erofs: introduce VLE decompression > support. > > The bot has tested the following trees: v5.0.3,

Re: KASAN: use-after-free Read in path_lookupat

2019-03-24 Thread Linus Torvalds
On Sun, Mar 24, 2019 at 5:44 PM syzbot wrote: > > syzbot has bisected this bug to: > > commit a435393acafbf0ecff4deb3e3cb554b34f0d0664 That's wrong. It might change some timing or something to make the race hit, but it looks entirely unrelated to the bpf path_lookupat problem.

Re: KASAN: use-after-free Read in path_lookupat

2019-03-24 Thread Linus Torvalds
Hmm. Al, this one seems real and also seems pretty nasty from a vfs interface standpoint. On Wed, Nov 28, 2018 at 9:40 AM syzbot wrote: > > BUG: KASAN: use-after-free in lookup_last fs/namei.c:2269 [inline] > BUG: KASAN: use-after-free in path_lookupat.isra.43+0x9f8/0xc00 > fs/namei.c:2318 >

Re: [PATCH 1/6] x86, mm: remove second argument of split_mem_range()

2019-03-24 Thread Wei Yang
On Sun, Mar 24, 2019 at 03:38:24PM +0100, Thomas Gleixner wrote: >Wei, > >On Tue, 12 Feb 2019, Wei Yang wrote: > >Vs. the subject line. 'x86, mm:' is not the proper prefix. > ># git log path/to/file > >gives you usually a pretty good hint, i.e. in this case: 'x86/mm:' > >Also the sentence after

Re: [RFC PATCH] random: add get_random_max() function

2019-03-24 Thread George Spelvin
P.S. The cited paper calls your algorithm the "OpenBSD algorithm" and has a bunch of benchmarks comparing it to others in Fisher-Yates shuffles of sizes 1e3..1e9. Including all overhead (base PRNG, shuffle), it's 3x slower for 32-bit operations and 8x slower for 64-bit up to arrays of size 1e6,

Re: KASAN: use-after-free Read in path_lookupat

2019-03-24 Thread syzbot
syzbot has bisected this bug to: commit a435393acafbf0ecff4deb3e3cb554b34f0d0664 Author: Sagi Grimberg Date: Thu Jul 13 08:09:40 2017 + mlx5: move affinity hints assignments to generic code bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=12df1ba320 start commit:

Re: [RFC PATCH] random: add get_random_max() function

2019-03-24 Thread George Spelvin
On Sun, 24 Mar 2019 at 21:47:50 +0100, Jason A. Donenfeld wrote: > I generally use a slightly simpler algorithm in various different projects: > > //[0, bound) > static unsigned long random_bounded(unsigned long bound) > { >unsigned long ret; >const unsigned long max_mod_bound =

Re: [PATCH 2/2] edac: sifive: Add EDAC driver for SiFive FU540-C000 chip

2019-03-24 Thread Paul Walmsley
Hi Yash, Just a few brief comments here: On Wed, 20 Mar 2019, Yash Shah wrote: > This EDAC driver supports: > - Initial configuration reporting on bootup via debug logs > - ECC event monitoring and reporting through the EDAC framework > - ECC event injection > It's probably worth mentioning

Re: [PATCH 1/2] edac: sifive: Add DT documentation for SiFive EDAC driver and subcomponent

2019-03-24 Thread Paul Walmsley
Hi Yash, On Wed, 20 Mar 2019, Yash Shah wrote: > DT documentation for EDAC driver added. > DT documentation for subcomponent L2 cache controller also added. > > Signed-off-by: Yash Shah > --- > .../devicetree/bindings/edac/sifive-edac.txt | 40 > ++ > 1 file

Re: [PATCH 2/2] sifive: edac: Add EDAC driver for Sifive l2 Cache Controller

2019-03-24 Thread Paul Walmsley
On Tue, 12 Mar 2019, Borislav Petkov wrote: > Please no EDAC drivers for a single functional unit with RAS > capabilities. Rather, a sifive_edac or riscv_edac driver which covers > the whole platform or even architecture and contains support for all the > RAS functionality there. See altera_edac,

Re: [tip:ras/core 2/2] drivers/ras/debugfs.c:9:5: error: redefinition of 'ras_userspace_consumers'

2019-03-24 Thread Valdis Klētnieks
On Mon, 25 Mar 2019 06:41:49 +0800, kbuild test robot said: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git ras/core > head: 56baf8bd6c92819b1d89210fbfac2c6327a1271b > commit: 56baf8bd6c92819b1d89210fbfac2c6327a1271b [2/2] ras/debugfs: Fix > -Wmissing-prototypes warnings

Re: [rcu:dev.2019.03.20b 59/83] kernel/rcu/tree_plugin.h:612:8: error: 'rcu_softirq_enabled' undeclared; did you mean 'trace_softirqs_enabled'?

2019-03-24 Thread Paul E. McKenney
On Sat, Mar 23, 2019 at 10:16:23AM +0800, kbuild test robot wrote: > tree: https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git > dev.2019.03.20b > head: 6d4434b4b4df791620743178e1419de882b44c7b > commit: d0f41d341df0520e900cac03de05bbbd11abdcd9 [59/83] rcu: Enable >

Re: [RFC 2/2] rcutree: Add checks for dynticks counters in rcu_is_cpu_rrupt_from_idle

2019-03-24 Thread Paul E. McKenney
On Fri, Mar 22, 2019 at 11:02:51PM -0400, Joel Fernandes wrote: > On Fri, Mar 22, 2019 at 09:29:39PM -0400, Joel Fernandes (Google) wrote: > > In the future we would like to combine the dynticks and dynticks_nesting > > counters thus leading to simplifying the code. At the moment we cannot > > do

Re: [PATCH v3] rcu: Allow to eliminate softirq processing from rcutree

2019-03-24 Thread Paul E. McKenney
On Sat, Mar 23, 2019 at 09:10:02AM -0700, Paul E. McKenney wrote: > On Fri, Mar 22, 2019 at 05:25:19PM -0700, Paul E. McKenney wrote: > > On Fri, Mar 22, 2019 at 07:48:19PM -0400, Joel Fernandes wrote: > > > On Wed, Mar 20, 2019 at 10:13:33PM +0100, Sebastian Andrzej Siewior wrote: > > > > Running

RESPONSE

2019-03-24 Thread WESTERN UNION
Compensation Funds of 800,000 Euro Valid for claim contact Mr . Wu Guofa for claim

Re: [PATCH v3] rcu: Allow to eliminate softirq processing from rcutree

2019-03-24 Thread Paul E. McKenney
On Fri, Mar 22, 2019 at 05:25:19PM -0700, Paul E. McKenney wrote: > On Fri, Mar 22, 2019 at 07:48:19PM -0400, Joel Fernandes wrote: > > On Wed, Mar 20, 2019 at 10:13:33PM +0100, Sebastian Andrzej Siewior wrote: > > > Running RCU out of softirq is a problem for some workloads that would > > > like

[PATCH] sound: codecs: fix a missing check for regmap_update_bits

2019-03-24 Thread Kangjie Lu
regmap_update_bits could fail. The fix checks its status and if it fails, returns its error code upstream. Signed-off-by: Kangjie Lu --- sound/soc/codecs/cs35l34.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/codecs/cs35l34.c b/sound/soc/codecs/cs35l34.c index

Re: [PATCH 3.16 00/16] 3.16.64-rc1 review

2019-03-24 Thread Ben Hutchings
On Fri, 2019-03-22 at 21:43 -0700, Guenter Roeck wrote: > On 3/22/19 6:44 AM, Guenter Roeck wrote: > > On 3/21/19 10:20 PM, Ben Hutchings wrote: > > > This is the start of the stable review cycle for the 3.16.64 release. > > > There are 16 patches in this series, which will be posted as responses

Re: [PATCH] gpio: fix a potential NULL pointer dereference

2019-03-24 Thread Andrew Jeffery
On Mon, 25 Mar 2019, at 09:40, Kangjie Lu wrote: > In case devm_kzalloc, the patch returns ENOMEM to avoid potential > NULL pointer dereference. > > Signed-off-by: Kangjie Lu Reviewed-by: Andrew Jeffery > --- > drivers/gpio/gpio-aspeed.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff

[PATCH] sound: codecs: fix a potential NULL pointer dereference

2019-03-24 Thread Kangjie Lu
In case devm_kzalloc fails, the patch returns -ENOMEM to avoid potential NULL pointer dereference. Signed-off-by: Kangjie Lu --- sound/soc/codecs/rt5663.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sound/soc/codecs/rt5663.c b/sound/soc/codecs/rt5663.c index da6647015708..909ab99a1995

[PATCH] gpio: fix a potential NULL pointer dereference

2019-03-24 Thread Kangjie Lu
In case devm_kzalloc, the patch returns ENOMEM to avoid potential NULL pointer dereference. Signed-off-by: Kangjie Lu --- drivers/gpio/gpio-aspeed.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpio/gpio-aspeed.c b/drivers/gpio/gpio-aspeed.c index 854bce4fb9e7..217507002dbc

[PATCH] platform: uv: fix missing checks for kcalloc

2019-03-24 Thread Kangjie Lu
In case kcalloc fails, the patch return an error to avoid potential NULL pointer dereference. Signed-off-by: Kangjie Lu --- arch/x86/platform/uv/tlb_uv.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/arch/x86/platform/uv/tlb_uv.c b/arch/x86/platform/uv/tlb_uv.c index

[PATCH] thunderbolt: property: fix a buffer overflow and a missing check

2019-03-24 Thread Kangjie Lu
First, no memory is allocated for "property->value.text"; the following strcpy will lead to a buffer overflow. Second, no check is enforced for the return value of kzalloc, which may lead to NULL-pointer dereference. The patch fixes the two issues. Signed-off-by: Kangjie Lu ---

[PATCH] vc04_services: vchiq_arm: fix a NULL pointer dereference

2019-03-24 Thread Kangjie Lu
When kzalloc fails, "platform_state->inited = 1" is a NULL pointer dereference. The fix returns VCHIQ_ERROR in case it failed to avoid NULL pointer dereference. Signed-off-by: Kangjie Lu --- .../staging/vc04_services/interface/vchiq_arm/vchiq_2835_arm.c | 2 ++ 1 file changed, 2 insertions(+)

[tip:ras/core 2/2] drivers/ras/debugfs.c:9:5: error: redefinition of 'ras_userspace_consumers'

2019-03-24 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git ras/core head: 56baf8bd6c92819b1d89210fbfac2c6327a1271b commit: 56baf8bd6c92819b1d89210fbfac2c6327a1271b [2/2] ras/debugfs: Fix -Wmissing-prototypes warnings config: x86_64-randconfig-x003-201912 (attached as .config) compiler:

[PATCH v2] mtd: rawnand: ams-delta: Drop board specific partition info

2019-03-24 Thread Janusz Krzysztofik
After recent modifications, only a hardcoded partition info makes the driver device specific. Other than that, the driver uses GPIO exclusively and can be used on any hardware. Drop the partition info and use MTD partition parser with default list of parser names instead. For the OF parser to

  1   2   3   4   5   6   >