[RFC 7/9] platform/x86: huawei-wmi: Add fn-lock support

2019-06-29 Thread Ayman Bagabas
Huawei Matebook laptops uses Fn key and toggle to access F1-F12 keys. Along with that, there is this feature called fn-lock that inverts the behavior of this Fn key. Implement the basic functionality of this feature to be used later by sysfs interface support introduced in this series.

[RFC 8/9] platform/x86: huawei-wmi: Add sysfs interface support

2019-06-29 Thread Ayman Bagabas
Add sysfs interface to enable the use of battery charging thresholds and fn-lock support introduced in this series. Signed-off-by: Ayman Bagabas --- drivers/platform/x86/huawei-wmi.c | 82 +++ 1 file changed, 82 insertions(+) diff --git

[RFC 9/9] platform/x86: huawei-wmi: Add debugfs support

2019-06-29 Thread Ayman Bagabas
Add a debugfs interface that can be used to call the WMI management interface function. The WMI interface takes a 64 bit integer and returns 256-260 bytes buffer. This debugfs interface creates two files, one stores a 64 bit int and the other calls the WMI interface and dumps out the returned

[RFC 6/9] platform/x86: huawei-wmi: Add battery charging thresholds

2019-06-29 Thread Ayman Bagabas
Implement battery charging thresholds functionality to be used with sysfs interface support that is implemented in this series. Setting battery charging thresholds can introduce a race condition where two are trying to read/write values from/to EC memory. Even though a mutex is used, this doesn't

[RFC 5/9] platform/x86: huawei-wmi: Control micmute led through wmi interface

2019-06-29 Thread Ayman Bagabas
Now that huawei WMI management interface is implemented, micmute LED can be controlled easily through this interface. Exception is the Matebook X (2017) which continue to uses ACPI EC method to control the LED. This model can control the LED through the legacy WMI interface which is not

[RFC 0/9] platform/x86: Huawei WMI laptop extras driver

2019-06-29 Thread Ayman Bagabas
This patch series introduce changes to huawei-wmi driver that includes: * Move to platform driver * Implement WMI management interface * Add micmute LED support through WMI * Add battery charging protection support through WMI * Add fn-lock support through WMI * Implement driver quirks and

Re: WARNING in kernfs_create_dir_ns

2019-06-29 Thread syzbot
syzbot has found a reproducer for the following crash on: HEAD commit:72825454 Merge branch 'x86-urgent-for-linus' of git://git... git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=104d6755a0 kernel config:

[RFC 2/9] platform/x86: huawei-wmi: Move to platform driver

2019-06-29 Thread Ayman Bagabas
Move from WMI driver to platform driver. This move is necessary since the driver is no longer a hotkeys driver only. Platform driver makes it easier for users to access sysfs attributes under (i.e. /sys/devices/platform/huawei-wmi) compared to wmi driver. Signed-off-by: Ayman Bagabas --- Do you

[RFC 3/9] platform/x86: huawei-wmi: Implement huawei wmi management interface

2019-06-29 Thread Ayman Bagabas
Huawei Matebook laptops come with a WMI management interface that can control various aspects of the device. This interface is also found on the old Matebook X released in 2017. Implement basic functionality of this interface along with supported command IDs that are implemented in this series.

[RFC 4/9] platform/x86: huawei-wmi: Add quirks and module parameters

2019-06-29 Thread Ayman Bagabas
Introduce quirks and module parameters. 3 quirks are added: 1. Fixes reporting brightness keys twice since it's already handled by acpi-video. 2. Some models need a short delay when setting battery thresholds to prevent a race condition when two processes read/write. 3. Matebook X (2017)

[RFC 1/9] platform/x86: huawei-wmi: Rename guid and driver name

2019-06-29 Thread Ayman Bagabas
Use WMI device UID, AMW0 has a UID of HWMI. WMI0 is the device name and doesn't have a UID so keep it as it is. Change module description to reflect the upcoming changes. Signed-off-by: Ayman Bagabas --- drivers/platform/x86/huawei-wmi.c | 14 -- 1 file changed, 8 insertions(+), 6

Re: [PATCH] mm: Generalize and rename notify_page_fault() as kprobe_page_fault()

2019-06-29 Thread Anshuman Khandual
Hello Guenter, On 06/29/2019 08:20 PM, Guenter Roeck wrote: > Hi, > > On Thu, Jun 13, 2019 at 03:37:24PM +0530, Anshuman Khandual wrote: >> Architectures which support kprobes have very similar boilerplate around >> calling kprobe_fault_handler(). Use a helper function in kprobes.h to unify >>

Re: [PATCH] hwspinlock: stm32: implement the relax() ops

2019-06-29 Thread Bjorn Andersson
On Thu 07 Mar 07:42 PST 2019, Fabien Dessenne wrote: > Implement this optional ops, called by hwspinlock core while spinning on > a lock, between two successive invocations of trylock(). > > Signed-off-by: Fabien Dessenne Applied Thanks, Bjorn > --- > drivers/hwspinlock/stm32_hwspinlock.c |

Re: [PATCH v4 0/8] stm32 m4 remoteproc on STM32MP157c

2019-06-29 Thread Bjorn Andersson
On Tue 14 May 01:26 PDT 2019, Fabien Dessenne wrote: > STMicrolectronics STM32MP157 MPU are based on a Dual Arm Cortex-A7 core and a > Cortex-M4. > This patchset adds the support of the stm32_rproc driver allowing to control > the M4 remote processor. > Applied patches 1 through 3, with a few

[PATCH] media: imx7-media-csi: Remove unneeded break after return

2019-06-29 Thread Chinmaya Krishnan Mahesh
This patch fixes the checkpatch.pl warning: WARNING: break is not useful after a goto or return Signed-off-by: Chinmaya Krishnan Mahesh --- drivers/staging/media/imx/imx7-media-csi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/staging/media/imx/imx7-media-csi.c

Linux 5.2-rc7

2019-06-29 Thread Linus Torvalds
It's Sunday afternoon _somewhere_ in the world right now. In particular, in the middle of nowhere on a boat. I didn't expect to have any internet this week, and honestly, I haven't had much, and not fast. But enough to keep up with critical pull requests, and enough to push out an rc. But credit

Re: [GIT pull] smp fixes for 5.2

2019-06-29 Thread pr-tracker-bot
The pull request you sent on Sat, 29 Jun 2019 17:13:04 +0200 (CEST): > git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git smp-urgent-for-linus has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/7c15f41e8743df676f6cb0615e74e8ba30994d6a Thank you! --

Re: [GIT PULL] Please pull powerpc/linux.git powerpc-5.2-7 tag

2019-06-29 Thread pr-tracker-bot
The pull request you sent on Sat, 29 Jun 2019 22:26:26 +1000: > https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git > tags/powerpc-5.2-7 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/39132f746eceed6beecb16c7b79600fb54eb8b2b Thank you! --

Re: [RFC PATCH v2 1/2] printk-rb: add a new printk ringbuffer implementation

2019-06-29 Thread John Ogness
On 2019-06-29, Andrea Parri wrote: >> /** >> * add_descr_list() - Add a descriptor to the descriptor list. >> * >> * @e: An entry that has already reserved data. >> * >> * The provided entry contains a pointer to a descriptor that has already >> * been reserved for this entry. However, the

Re: [PATCH v3 1/4] kbuild: compile-test UAPI headers to ensure they are self-contained

2019-06-29 Thread Masahiro Yamada
On Fri, Jun 28, 2019 at 1:40 AM Masahiro Yamada wrote: > > Multiple people have suggested compile-testing UAPI headers to ensure > they can be really included from user-space. "make headers_check" is > obviously not enough to catch bugs, and we often leak references to > kernel-space definition

Re: [PATCH 10/10] staging/rtl8723bs/hal: fix comparison to true/false is error prone

2019-06-29 Thread Shobhit Kukreti
On Sat, Jun 29, 2019 at 04:07:51PM +0530, Hariprasad Kelam wrote: Hello Hari Prasad, Please add the recommended reviewers mentioned in the TODO file of rtl8723bs directory. I see the following emails in the TODO file. Greg Kroah-Hartman , Hans de Goede and Larry Finger > fix below issues

Re: [PATCH v3 1/4] kbuild: compile-test UAPI headers to ensure they are self-contained

2019-06-29 Thread Masahiro Yamada
Hi Sam, On Sat, Jun 29, 2019 at 12:44 AM Sam Ravnborg wrote: > > Hi Masahiro. > > On Fri, Jun 28, 2019 at 01:38:59AM +0900, Masahiro Yamada wrote: > > Multiple people have suggested compile-testing UAPI headers to ensure > > they can be really included from user-space. "make headers_check" is >

Re: [PATCH] Staging: most: fix coding style issues

2019-06-29 Thread Joe Perches
On Sat, 2019-06-29 at 16:44 -0700, Gabriel Beauchamp wrote: > This is a patch for the core.[ch] files that fixes up warnings > found with the checkpatch.pl tool. [] > diff --git a/drivers/staging/most/core.c b/drivers/staging/most/core.c [] > @@ -303,7 +303,8 @@ static ssize_t

Re: [PATCH V33 24/30] bpf: Restrict bpf when kernel lockdown is in confidentiality mode

2019-06-29 Thread Andy Lutomirski
On Fri, Jun 28, 2019 at 11:47 AM Matthew Garrett wrote: > > On Thu, Jun 27, 2019 at 4:27 PM Andy Lutomirski wrote: > > They're really quite similar in my mind. Certainly some things in the > > "integrity" category give absolutely trivial control over the kernel > > (e.g. modules) while others

[PATCH] Staging: most: fix coding style issues

2019-06-29 Thread Gabriel Beauchamp
This is a patch for the core.[ch] files that fixes up warnings found with the checkpatch.pl tool. Signed-off-by: Gabriel Beauchamp --- drivers/staging/most/core.c | 4 +++- drivers/staging/most/core.h | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git

Re: [RFC PATCH 3/3] Prevent user from writing to IBT bitmap.

2019-06-29 Thread Andy Lutomirski
On Fri, Jun 28, 2019 at 12:50 PM Yu-cheng Yu wrote: > > The IBT bitmap is visiable from user-mode, but not writable. > > Signed-off-by: Yu-cheng Yu > > --- > arch/x86/mm/fault.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/arch/x86/mm/fault.c b/arch/x86/mm/fault.c > index

Re: d_lookup: Unable to handle kernel paging request

2019-06-29 Thread Vicente Bergas
On Tuesday, June 25, 2019 12:48:17 PM CEST, Vicente Bergas wrote: On Tuesday, June 25, 2019 11:46:02 AM CEST, Will Deacon wrote: [+Marc] Hi again, Vicente, On Mon, Jun 24, 2019 at 12:47:41PM +0100, Will Deacon wrote: ... Hi Will, the memtest test is still pending... Hi Will, i've just ran

Re: shrink_dentry_list() logics change (was Re: [RFC PATCH v3 14/15] dcache: Implement partial shrink via Slab Movable Objects)

2019-06-29 Thread Al Viro
On Sat, Jun 29, 2019 at 11:29:45PM +0100, Al Viro wrote: > Like this (again, only build-tested): ... and with obvious braino fixed, Teach shrink_dcache_parent() to cope with mixed-filesystem shrink lists Currently, running into a shrink list that contains dentries from different filesystems can

Re: shrink_dentry_list() logics change (was Re: [RFC PATCH v3 14/15] dcache: Implement partial shrink via Slab Movable Objects)

2019-06-29 Thread Al Viro
On Sat, Jun 29, 2019 at 08:06:24PM +0100, Al Viro wrote: > I wonder if after the "no evictable candidates, but something > on other's shrink lists" we ought to do something along the > lines of > rcu_read_lock > walk it, doing > if dentry has zero refcount >

Re: [PATCH 4/6] ACPI: LPSS: Fix ->suspend_late callbacks handling

2019-06-29 Thread Rafael J. Wysocki
On Sat, Jun 29, 2019 at 1:34 PM Hans de Goede wrote: > > Hi Rafael, > > On 29-06-19 11:50, Rafael J. Wysocki wrote: > > From: Rafael J. Wysocki > > > > If the resume_from_noirq flag is set in dev_desc, the ->suspend_late > > callback provided by the device driver will be invoked at the "noirq" >

Re: [PATCH V5 08/18] clk: tegra: Add suspend resume support for DFLL

2019-06-29 Thread Dmitry Osipenko
29.06.2019 16:28, Dmitry Osipenko пишет: > 28.06.2019 5:12, Sowjanya Komatineni пишет: >> This patch creates APIs for supporting Tegra210 clock driver to >> perform DFLL suspend and resume operation. >> >> During suspend, DFLL mode is saved and on resume Tegra210 clock driver >> invokes DFLL

[PATCH] ftrace/x86: anotate text_mutex split between ftrace_arch_code_modify_post_process() and ftrace_arch_code_modify_prepare()

2019-06-29 Thread Jiri Kosina
From: Jiri Kosina ftrace_arch_code_modify_prepare() is acquiring text_mutex, while the corresponding release is happening in ftrace_arch_code_modify_post_process(). This has already been documented in the code, but let's also make the fact that this is intentional clear to the semantic analysis

Re: [PATCH] ftrace: Remove possible deadlock between register_kprobe() and ftrace_run_update_code()

2019-06-29 Thread Steven Rostedt
On Sat, 29 Jun 2019 22:56:47 +0200 (CEST) Jiri Kosina wrote: > > Care to send a patch? :-) > > From: Jiri Kosina > Subject: [PATCH] ftrace/x86: anotate text_mutex split between > ftrace_arch_code_modify_post_process() and ftrace_arch_code_modify_prepare() Care to send a proper patch ;-)

[PATCH] tools/memory-model: Update the informal documentation

2019-06-29 Thread Andrea Parri
The formal memory consistency model has added support for plain accesses (and data races). While updating the informal documentation to describe this addition to the model is highly desirable and important future work, update the informal documentation to at least acknowledge such addition.

Re: KASAN: use-after-free Write in xfrm_hash_rebuild

2019-06-29 Thread syzbot
syzbot has bisected this bug to: commit 1548bc4e0512700cf757192c106b3a20ab639223 Author: Florian Westphal Date: Fri Jan 4 13:17:02 2019 + xfrm: policy: delete inexact policies from inexact list on hash rebuild bisection log:

Re: [RFC PATCH v2 1/2] printk-rb: add a new printk ringbuffer implementation

2019-06-29 Thread Andrea Parri
> /** > * add_descr_list() - Add a descriptor to the descriptor list. > * > * @e: An entry that has already reserved data. > * > * The provided entry contains a pointer to a descriptor that has already > * been reserved for this entry. However, the reserved descriptor is not > * yet on the

Re: [PATCH] ftrace: Remove possible deadlock between register_kprobe() and ftrace_run_update_code()

2019-06-29 Thread Jiri Kosina
On Fri, 28 Jun 2019, Steven Rostedt wrote: > > > > How is that supposed to work? > > > > > > > > ftrace > > > > prepare() > > > > setrw() > > > > setro() > > > > patch <- FAIL > > > > > > /me dodges frozen shark > > > > > >

Re: [PATCH] vfs: move_mount: reject moving kernel internal mounts

2019-06-29 Thread Al Viro
On Sat, Jun 29, 2019 at 01:27:44PM -0700, Eric Biggers wrote: > @@ -2600,7 +2600,7 @@ static int do_move_mount(struct path *old_path, struct > path *new_path) > if (attached && !check_mnt(old)) > goto out; > > - if (!attached && !(ns && is_anon_ns(ns))) > + if

Re: general protection fault in do_move_mount (2)

2019-06-29 Thread Eric Biggers
On Mon, Jun 24, 2019 at 11:28:18AM +0200, 'Dmitry Vyukov' via syzkaller-bugs wrote: > On Tue, Jun 18, 2019 at 4:03 PM Al Viro wrote: > > > > On Tue, Jun 18, 2019 at 03:47:10AM -0700, syzbot wrote: > > > Hello, > > > > > > syzbot found the following crash on: > > > > > > HEAD commit:9e0babf2

Re: slub: don't panic for memcg kmem cache creation failure

2019-06-29 Thread Shakeel Butt
On Sat, Jun 29, 2019 at 7:05 AM Alexey Dobriyan wrote: > > > - if (flags & SLAB_PANIC) > > - panic("Cannot create slab %s size=%u realsize=%u order=%u > > offset=%u flags=%lx\n", > > - s->name, s->size, s->size, > > - oo_order(s->oo),

[PATCH] vfs: move_mount: reject moving kernel internal mounts

2019-06-29 Thread Eric Biggers
From: Eric Biggers sys_move_mount() crashes by dereferencing the pointer MNT_NS_INTERNAL, a.k.a. ERR_PTR(-EINVAL), if the old mount is specified by fd for a kernel object with an internal mount, such as a pipe or memfd. Fix it by checking for this case and returning -EINVAL. Reproducer:

Re: [GIT PULL] smp/urgent fixes

2019-06-29 Thread Ingo Molnar
* Ingo Molnar wrote: > Linus, > > Please pull the latest smp-urgent-for-linus git tree from: > >git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git > smp-urgent-for-linus > ># HEAD: 33d4a5a7a5b4d02915d765064b2319e90a11cbde cpu/hotplug: Fix > out-of-bounds read when setting

[GIT PULL] smp/urgent fixes

2019-06-29 Thread Ingo Molnar
Linus, Please pull the latest smp-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git smp-urgent-for-linus # HEAD: 33d4a5a7a5b4d02915d765064b2319e90a11cbde cpu/hotplug: Fix out-of-bounds read when setting fail state Two fixes: - Fix an out of

Re: net: check before dereferencing netdev_ops during busy poll

2019-06-29 Thread Matteo Croce
On Sat, Jun 29, 2019 at 9:45 AM Greg Kroah-Hartman wrote: > > On Fri, Jun 28, 2019 at 07:03:01PM -0700, Josh Elsasser wrote: > > On Jun 28, 2019, at 3:55 PM, Sasha Levin wrote: > > > > > What's the upstream commit id? > > > > The commit wasn't needed upstream, as I only sent the original patch

Re: [RFC] Deadlock via recursive wakeup via RCU with threadirqs

2019-06-29 Thread Andrea Parri
On Sat, Jun 29, 2019 at 12:15:15PM -0700, Paul E. McKenney wrote: > On Sat, Jun 29, 2019 at 08:09:10PM +0200, Andrea Parri wrote: > > On Sat, Jun 29, 2019 at 09:55:33AM -0700, Paul E. McKenney wrote: > > > On Sat, Jun 29, 2019 at 05:12:36PM +0200, Andrea Parri wrote: > > > > Hi Steve, > > > > > >

[PATCH] staging/media/davinci_vpfe: Add null check post kmalloc

2019-06-29 Thread Hariprasad Kelam
Add NULL check post memory operations Signed-off-by: Hariprasad Kelam --- drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/staging/media/davinci_vpfe/dm365_ipipe.c b/drivers/staging/media/davinci_vpfe/dm365_ipipe.c index

Re: [RFC] Deadlock via recursive wakeup via RCU with threadirqs

2019-06-29 Thread Paul E. McKenney
On Sat, Jun 29, 2019 at 08:09:10PM +0200, Andrea Parri wrote: > On Sat, Jun 29, 2019 at 09:55:33AM -0700, Paul E. McKenney wrote: > > On Sat, Jun 29, 2019 at 05:12:36PM +0200, Andrea Parri wrote: > > > Hi Steve, > > > > > > > As Paul stated, interrupts are synchronization points. Archs can only >

[PATCH] staging: netlogic: Change GFP_ATOMIC to GFP_KERNEL

2019-06-29 Thread Hariprasad Kelam
Below is data path of xlr_config_spill xlr_net_probe -->xlr_config_fifo_spill_area --->xlr_config_spill We can use GFP_KERNEL as this function is getting called from xlr_net_probe and there are no locks. Signed-off-by: Hariprasad Kelam --- drivers/staging/netlogic/xlr_net.c | 2 +- 1 file

Re: shrink_dentry_list() logics change (was Re: [RFC PATCH v3 14/15] dcache: Implement partial shrink via Slab Movable Objects)

2019-06-29 Thread Al Viro
On Sat, Jun 29, 2019 at 05:38:03AM +0100, Al Viro wrote: > PS: the problem is not gone in the next iteration of the patchset in > question. The patch I'm proposing (including dput_to_list() and _ONLY_ > compile-tested) follows. Comments? FWIW, there's another unpleasantness in the whole thing.

Re: [PATCH v2] hwspinlock: ignore disabled device

2019-06-29 Thread Bjorn Andersson
On Fri 08 Mar 08:53 PST 2019, Fabien Dessenne wrote: > Do not wait for hwspinlock device registration if it is not available > for use. > > Signed-off-by: Fabien Dessenne Applied with Suman's ack Thanks, Bjorn > --- > V2: use 'goto out' instead of 'return' > >

Re: [PATCH] remoteproc: Use struct_size() helper

2019-06-29 Thread Bjorn Andersson
On Fri 07 Jun 11:53 PDT 2019, Gustavo A. R. Silva wrote: > One of the more common cases of allocation size calculations is finding > the size of a structure that has a zero-sized array at the end, along > with memory for some number of elements for that array. For example: > > struct

Re: [PATCH] remoteproc: add vendor resources handling

2019-06-29 Thread Bjorn Andersson
On Mon 17 Jun 05:57 PDT 2019, Clement Leger wrote: > In order to allow rproc backend to handle vendor resources such as in > OpenAMP, add a handle_rsc hook. This hook allow the rproc backends to > handle vendor resources as they like. The hook will be called only for > vendor resources and should

[PATCH] staging/rtl8188eu/os_dep: Remove unneeded variable ret

2019-06-29 Thread Hariprasad Kelam
Below list of functions returns 0 in success and -EINVAL in failure. So directly return 0 on Success. Signed-off-by: Hariprasad Kelam --- drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 18 ++ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git

Re: [RFC] Deadlock via recursive wakeup via RCU with threadirqs

2019-06-29 Thread Andrea Parri
> Remark: we do have code which (while acknowledging that "interrupts are > synchronization points") doesn't quite seem to "believe it", c.f., e.g., > kernel/sched/membarrier.c:ipi_mb(). So, I guess the follow-up question > would be "Would we better be (more) paranoid? ..." should have been

Re: [PATCH 0/2] Sub ns increment fixes in Macb PTP

2019-06-29 Thread David Miller
From: Harini Katakam Date: Thu, 27 Jun 2019 11:50:58 +0530 > The subns increment register fields are not captured correctly in the > driver. Fix the same and also increase the subns incr resolution. > > Sub ns resolution was increased to 24 bits in r1p06f2 version. To my > knowledge, this PTP

Re: [RFC] Deadlock via recursive wakeup via RCU with threadirqs

2019-06-29 Thread Andrea Parri
On Sat, Jun 29, 2019 at 09:55:33AM -0700, Paul E. McKenney wrote: > On Sat, Jun 29, 2019 at 05:12:36PM +0200, Andrea Parri wrote: > > Hi Steve, > > > > > As Paul stated, interrupts are synchronization points. Archs can only > > > play games with ordering when dealing with entities outside the CPU

Re: [Linux-kernel-mentees][PATCH v2] packet: Fix undefined behavior in bit shift

2019-06-29 Thread David Miller
From: Jiunn Chang Date: Wed, 26 Jun 2019 22:25:30 -0500 > Shifting signed 32-bit value by 31 bits is undefined. Changing most > significant bit to unsigned. > > Changes included in v2: > - use subsystem specific subject lines > - CC required mailing lists > > Signed-off-by: Jiunn Chang

Re: [PATCH net-next] xdp: xdp_umem: fix umem pages mapping for 32bits systems

2019-06-29 Thread David Miller
From: Björn Töpel Date: Wed, 26 Jun 2019 22:50:23 +0200 > On Wed, 26 Jun 2019 at 17:59, Ivan Khoronzhuk > wrote: >> >> Use kmap instead of page_address as it's not always in low memory. >> > > Ah, some 32-bit love. :-) Thanks for working on this! > > For future patches, please base AF_XDP

Re: [PATCH net-next] hinic: add vlan offload support

2019-06-29 Thread David Miller
From: Xue Chaojing Date: Sat, 29 Jun 2019 02:26:27 + > This patch adds vlan offload support for the HINIC driver. > > Signed-off-by: Xue Chaojing Applied, thank you.

Re: bcachefs status update (it's done cooking; let's get this sucker merged)

2019-06-29 Thread Luke Kenneth Casson Leighton
hey linus, you made news again, all blown up and pointless again. you're doing great: you're being honest. remember the offer i made to put you in touch with my friend. anecdotal story: andrew tridgell worked on the fujitsu sparc supercomputer a couple decades ago: it had a really weird DMA ring

Re: [RFC] Deadlock via recursive wakeup via RCU with threadirqs

2019-06-29 Thread Paul E. McKenney
On Sat, Jun 29, 2019 at 05:12:36PM +0200, Andrea Parri wrote: > Hi Steve, > > > As Paul stated, interrupts are synchronization points. Archs can only > > play games with ordering when dealing with entities outside the CPU > > (devices and other CPUs). But if you have assembly that has two stores,

Re: [PATCH V5 02/18] pinctrl: tegra: Add suspend and resume support

2019-06-29 Thread Dmitry Osipenko
29.06.2019 18:58, Dmitry Osipenko пишет: > 29.06.2019 18:46, Dmitry Osipenko пишет: >> 28.06.2019 5:12, Sowjanya Komatineni пишет: >>> This patch adds support for Tegra pinctrl driver suspend and resume. >>> >>> During suspend, context of all pinctrl registers are stored and >>> on resume they are

Re: [PATCH] filesystem-dax: Disable PMD support

2019-06-29 Thread Matthew Wilcox
On Thu, Jun 27, 2019 at 07:39:37PM -0700, Dan Williams wrote: > On Thu, Jun 27, 2019 at 12:59 PM Matthew Wilcox wrote: > > > > On Thu, Jun 27, 2019 at 12:09:29PM -0700, Dan Williams wrote: > > > > This bug feels like we failed to unlock, or unlocked the wrong entry > > > > and this hunk in the

Re: [PATCH V5 02/18] pinctrl: tegra: Add suspend and resume support

2019-06-29 Thread Dmitry Osipenko
29.06.2019 18:46, Dmitry Osipenko пишет: > 28.06.2019 5:12, Sowjanya Komatineni пишет: >> This patch adds support for Tegra pinctrl driver suspend and resume. >> >> During suspend, context of all pinctrl registers are stored and >> on resume they are all restored to have all the pinmux and pad >>

Re: [PATCH v1] arm: dts: mediatek: add basic support for MT7629 SoC

2019-06-29 Thread Ryder Lee
On Fri, 2019-06-28 at 16:32 -0700, Kevin Hilman wrote: > writes: > > > From: Ryder Lee > > > > This adds basic support for MT7629 reference board. > > > > Signed-off-by: Ryder Lee > > Just noticing this is not upstream yet. > > I did a basic boot test to ramdisk on the mt7629-rfb board

BUG: using smp_processor_id() in preemptible [ADDR] code: syz-executor

2019-06-29 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:ee7dd773 sis900: remove TxIDLE git tree: net-next console output: https://syzkaller.appspot.com/x/log.txt?x=17ceb9a9a0 kernel config: https://syzkaller.appspot.com/x/.config?x=7ac9edef4d37e5fb dashboard link:

Re: [PATCH V5 02/18] pinctrl: tegra: Add suspend and resume support

2019-06-29 Thread Dmitry Osipenko
28.06.2019 5:12, Sowjanya Komatineni пишет: > This patch adds support for Tegra pinctrl driver suspend and resume. > > During suspend, context of all pinctrl registers are stored and > on resume they are all restored to have all the pinmux and pad > configuration for normal operation. > >

Re: [PATCH 02/87] ata: acard-ahci: Remove call to memset after dmam_alloc_coherent

2019-06-29 Thread Jens Axboe
On 6/27/19 11:33 AM, Fuqian Huang wrote: > In commit af7ddd8a627c > ("Merge tag 'dma-mapping-4.21' of > git://git.infradead.org/users/hch/dma-mapping"), > dmam_alloc_coherent has already zeroed the memory. > So memset is not needed. Applied this, and the rest of the ATA related patches, for 5.3.

Re: [PATCH V5 02/18] pinctrl: tegra: Add suspend and resume support

2019-06-29 Thread Dmitry Osipenko
29.06.2019 15:38, Dmitry Osipenko пишет: > 29.06.2019 2:00, Sowjanya Komatineni пишет: >> >> On 6/28/19 5:05 AM, Dmitry Osipenko wrote: >>> 28.06.2019 14:56, Dmitry Osipenko пишет: 28.06.2019 5:12, Sowjanya Komatineni пишет: > This patch adds support for Tegra pinctrl driver suspend and

Re: [PATCH V5 06/18] clk: tegra: Save and restore CPU and System clocks context

2019-06-29 Thread Dmitry Osipenko
28.06.2019 5:12, Sowjanya Komatineni пишет: > During system suspend state, core power goes off and looses all the > CAR controller register settings. > > This patch creates APIs for saving and restoring the context of Tegra > CPUG, CPULP and SCLK. > > CPU and System clock context includes > -

Re: [PATCH v8 4/5] x86/xsave: Make XSAVE check the base CPUID features before enabling

2019-06-29 Thread Vegard Nossum
On 10/5/17 11:52 PM, Andi Kleen wrote: From: Andi Kleen Before enabling XSAVE, not only check the XSAVE specific CPUID bits, but also the base CPUID features of the respective XSAVE feature. This allows to disable individual XSAVE states using the existing clearcpuid= option, which can be

Re: [PATCH 06/16] sh: use the generic get_user_pages_fast code

2019-06-29 Thread Guenter Roeck
On Tue, Jun 25, 2019 at 04:37:05PM +0200, Christoph Hellwig wrote: > The sh code is mostly equivalent to the generic one, minus various > bugfixes and two arch overrides that this patch adds to pgtable.h. > > Signed-off-by: Christoph Hellwig sh:defconfig no longer builds with this patch

Re: [PATCH V5 11/18] clk: tegra210: Add support for Tegra210 clocks

2019-06-29 Thread Dmitry Osipenko
28.06.2019 5:12, Sowjanya Komatineni пишет: > This patch adds system suspend and resume support for Tegra210 > clocks. > > All the CAR controller settings are lost on suspend when core power > goes off. > > This patch has implementation for saving and restoring all the PLLs > and clocks context

[GIT pull] smp fixes for 5.2

2019-06-29 Thread Thomas Gleixner
Linus, please pull the latest smp-urgent-for-linus git tree from: git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git smp-urgent-for-linus up to: 33d4a5a7a5b4: cpu/hotplug: Fix out-of-bounds read when setting fail state Two small changes for the cpu hotplug code: - Prevent out

Re: [RFC] Deadlock via recursive wakeup via RCU with threadirqs

2019-06-29 Thread Andrea Parri
Hi Steve, > As Paul stated, interrupts are synchronization points. Archs can only > play games with ordering when dealing with entities outside the CPU > (devices and other CPUs). But if you have assembly that has two stores, > and an interrupt comes in, the arch must guarantee that the stores

Re: [PATCH V5 11/18] clk: tegra210: Add support for Tegra210 clocks

2019-06-29 Thread Dmitry Osipenko
28.06.2019 5:12, Sowjanya Komatineni пишет: > This patch adds system suspend and resume support for Tegra210 > clocks. > > All the CAR controller settings are lost on suspend when core power > goes off. > > This patch has implementation for saving and restoring all the PLLs > and clocks context

Re: [PATCH v4] Documentation:sh:convert register-banks.txt and new-machine.txt to rst format.

2019-06-29 Thread Mauro Carvalho Chehab
Em Sat, 29 Jun 2019 20:02:45 +0530 Vandana BN escreveu: > This patch converts new-machine.txt and register-banks.txt > to ReST format, No content change. > Added interfaces.rst to contain kernel-doc markups from index.rst > Added interfaces.rst,new-machine.rst and register-banks.rst to

Re: [PATCH] i2c: remove casting dma_alloc

2019-06-29 Thread Wolfram Sang
Hi Jochen, (could you send text emails, please?) > yes, I'm still here. However, I don't have the hardware anymore to test the > patch. Thanks for answering! And besides (not) testing, are you still open to review patches to the best of your knowledge (I neither have most of the HW). Or do

Re: [PATCH] mm: Generalize and rename notify_page_fault() as kprobe_page_fault()

2019-06-29 Thread Guenter Roeck
Hi, On Thu, Jun 13, 2019 at 03:37:24PM +0530, Anshuman Khandual wrote: > Architectures which support kprobes have very similar boilerplate around > calling kprobe_fault_handler(). Use a helper function in kprobes.h to unify > them, based on the x86 code. > > This changes the behaviour for other

Re: [PATCH 04/16] MIPS: use the generic get_user_pages_fast code

2019-06-29 Thread Guenter Roeck
Hi, On Tue, Jun 25, 2019 at 04:37:03PM +0200, Christoph Hellwig wrote: > The mips code is mostly equivalent to the generic one, minus various > bugfixes and an arch override for gup_fast_permitted. > > Note that this defines ARCH_HAS_PTE_SPECIAL for mips as mips has > pte_special and

Re: [PATCH RFC v2] Convert struct pid count to refcount_t

2019-06-29 Thread Andrea Parri
On Mon, Jun 24, 2019 at 02:45:34PM -0400, Joel Fernandes (Google) wrote: > struct pid's count is an atomic_t field used as a refcount. Use > refcount_t for it which is basically atomic_t but does additional > checking to prevent use-after-free bugs. > > For memory ordering, the only change is

Re: [PATCH v2 0/8] platform/x86: Huawei WMI laptop extras driver

2019-06-29 Thread Andy Shevchenko
On Thu, Jun 13, 2019 at 6:04 AM Ayman Bagabas wrote: > > Changes from v1: > * introducing debugfs > * code reformatting > > This patch series introduce new features to the driver and also moves the > driver from wmi_driver to platform_driver. This move is necessary because the > driver is no

Re: [PATCH 2/2] input: soc_button_array for newer surface devices

2019-06-29 Thread Andy Shevchenko
On Thu, Jun 20, 2019 at 2:51 PM Maximilian Luz wrote: > > Power and volume button support for 5th and 6th genration Microsoft > Surface devices via soc_button_array. > > Note that these devices use the same MSHW0040 device as on the Surface > Pro 4, however the implementation is different (GPIOs

Re: [PATCH] platform/x86: pmc_atom: Add CB4063 Beckhoff Automation board to critclk_systems DMI table

2019-06-29 Thread Andy Shevchenko
On Tue, Jun 18, 2019 at 4:34 PM wrote: > > From: Steffen Dirkwinkel > > The CB4063 board uses pmc_plt_clk* clocks for ethernet controllers. This > adds it to the critclk_systems DMI table so the clocks are marked as > CLK_CRITICAL and not turned off. > Pushed to my review and testing queue,

Re: [PATCH 0/2] Support for buttons on newer MS Surface devices

2019-06-29 Thread Andy Shevchenko
On Thu, Jun 20, 2019 at 2:51 PM Maximilian Luz wrote: > > This series adds suport for power and volume buttons on 5th and 6th > generation Microsoft Surface devices. Specifically, it adds support for > the power-button on the Surface Laptop 1 and Laptop 2, as well as > support for power- and

答复: [PATCH v4] net: netfilter: Fix rpfilter dropping vrf packets by mistake

2019-06-29 Thread linmiaohe
On 6/29/19 20:20 PM, David Ahern wrote: > On 6/28/19 8:13 PM, linmiaohe wrote: > > You're right. Fib rules code would set FLOWI_FLAG_SKIP_NH_OIF flag. > > But I set it here for distinguish with the flags & XT_RPFILTER_LOOSE > > branch. Without this, they do the same work and maybe should be >

Re: slub: don't panic for memcg kmem cache creation failure

2019-06-29 Thread Alexey Dobriyan
> - if (flags & SLAB_PANIC) > - panic("Cannot create slab %s size=%u realsize=%u order=%u > offset=%u flags=%lx\n", > - s->name, s->size, s->size, > - oo_order(s->oo), s->offset, (unsigned long)flags); This is wrong. Without SLAB_PANIC

Re: [PATCH V5 06/18] clk: tegra: Save and restore CPU and System clocks context

2019-06-29 Thread Dmitry Osipenko
28.06.2019 5:12, Sowjanya Komatineni пишет: > During system suspend state, core power goes off and looses all the > CAR controller register settings. > > This patch creates APIs for saving and restoring the context of Tegra > CPUG, CPULP and SCLK. > > CPU and System clock context includes > -

Re: [PATCH] let proc net directory inodes reflect to active net namespace

2019-06-29 Thread Alexey Dobriyan
On Tue, Jun 25, 2019 at 10:36:06AM +, Hallsmark, Per wrote: > +struct proc_dir_entry *proc_net_mkdir(struct net *net, const char *name, > + struct proc_dir_entry *parent) > +{ > + struct proc_dir_entry *pde; > + > + pde = proc_mkdir_data(name, 0,

Re: [PATCH V5 08/18] clk: tegra: Add suspend resume support for DFLL

2019-06-29 Thread Dmitry Osipenko
28.06.2019 5:12, Sowjanya Komatineni пишет: > This patch creates APIs for supporting Tegra210 clock driver to > perform DFLL suspend and resume operation. > > During suspend, DFLL mode is saved and on resume Tegra210 clock driver > invokes DFLL resume API to re-initialize DFLL to enable target

Re: [PATCH v3] platform/x86: intel_pmc_core: transform Pkg C-state residency from TSC ticks into microseconds

2019-06-29 Thread Andy Shevchenko
On Wed, Jun 19, 2019 at 11:29 AM Harry Pan wrote: > > Refer to the Intel SDM Vol.4, the package C-state residency counters > of modern IA micro-architecture are all ticking in TSC frequency, > hence we can apply simple math to transform the ticks into microseconds. > i.e., > residency (ms) =

Re: [PATCH] platform/x86: touchscreen_dmi: Update Hi10 Air filter

2019-06-29 Thread Andy Shevchenko
On Wed, Jun 12, 2019 at 3:55 PM Hans de Goede wrote: > > Hi, > > On 12-06-19 14:40, Christian Oder wrote: > > Turns out the Hi10 Air is built by multiple companies so using Hampoo > > as a filter is not enough to cover all variants. > > > > This has been verified as working on the Hampoo and

Re: [PATCH] platform/x86: intel_pmc_core: Add ICL-NNPI support to PMC Core

2019-06-29 Thread Andy Shevchenko
On Fri, Jun 14, 2019 at 11:14 AM Rajneesh Bhardwaj wrote: > > Ice Lake Neural Network Processor for deep learning inference a.k.a. > ICL-NNPI can re-use Ice Lake Mobile regmap to enable Intel PMC Core > driver on it. > This will be postponed till next cycle since the CPU model will not appear

Re: [PATCH V5 09/18] clk: tegra: Add save and restore context support for peripheral clocks

2019-06-29 Thread Dmitry Osipenko
28.06.2019 5:12, Sowjanya Komatineni пишет: > This patch implements save and restore context for peripheral fixed > clock ops, peripheral gate clock ops, sdmmc mux clock ops, and > peripheral clock ops. > > During system suspend, core power goes off and looses the settings > of the Tegra CAR

Re: [PATCH] intel_menlow: avoid null pointer deference error

2019-06-29 Thread Andy Shevchenko
On Wed, May 29, 2019 at 4:55 AM Young Xiao <92siuy...@gmail.com> wrote: > > Fix a null pointer deference by acpi_driver_data() if device is > null (dereference before check). We should only set cdev and check > this is OK after we are sure device is not null. > Pushed to my review and testing

Re: [PATCH 3/3] platform/x86: wmi: add Xiaomi WMI key driver

2019-06-29 Thread Andy Shevchenko
On Mon, May 27, 2019 at 7:22 PM Mattias Jacobsson <2...@mok.nu> wrote: > > Some function keys on the built in keyboard on Xiaomi's notebooks does > not produce any key events when pressed in combination with the function > key. Some of these keys do report that they are being pressed via WMI >

Re: [PATCH V5 11/18] clk: tegra210: Add support for Tegra210 clocks

2019-06-29 Thread Dmitry Osipenko
28.06.2019 5:12, Sowjanya Komatineni пишет: > This patch adds system suspend and resume support for Tegra210 > clocks. > > All the CAR controller settings are lost on suspend when core power > goes off. > > This patch has implementation for saving and restoring all the PLLs > and clocks context

Re: [PATCH v4 00/13] Support of ASUS TUF Gaming series laptops

2019-06-29 Thread Andy Shevchenko
On Tue, May 14, 2019 at 9:47 PM Yurii Pavlovskyi wrote: > > Hi, > > this is the fourth version of the patch series. > Pushed to my review and testing queue, thanks! > Changelog: > v4: > * Rebase on for-next branch > * Extract local variable in patch 01 > * Rename new method to

Re: [PATCH] platform/x86: acer-wmi: Mark expected switch fall-throughs

2019-06-29 Thread Andy Shevchenko
On Thu, May 9, 2019 at 4:48 AM Gustavo A. R. Silva wrote: > Commit 5c742b45dd5fbbb6cf74d3378341704f4b23c5e8 mentions that "This was fixed > in acer_acpi some time ago, but I forgot to port the patch over to acer-wmi > when it was merged." Notice that this driver (acer-wmi) is based on the >

WARNING in kernfs_create_dir_ns

2019-06-29 Thread syzbot
Hello, syzbot found the following crash on: HEAD commit:4b972a01 Linux 5.2-rc6 git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=14910879a0 kernel config: https://syzkaller.appspot.com/x/.config?x=9a31528e58cc12e2 dashboard link:

  1   2   >