Re: [PATCH v2 2/2] mmc: Add support for the ASPEED SD controller

2019-07-25 Thread Adrian Hunter
On 26/07/19 3:52 AM, Andrew Jeffery wrote: > On Thu, 25 Jul 2019, at 22:49, Adrian Hunter wrote: >> On 12/07/19 6:32 AM, Andrew Jeffery wrote: >>> +static int aspeed_sdhci_probe(struct platform_device *pdev) >>> +{ >>> + struct sdhci_pltfm_host *pltfm_host; >>> + struct aspeed_sdhci *dev; >>>

Re: [alsa-devel] [RFC PATCH 26/40] soundwire: cadence_master: fix divider setting in clock register

2019-07-25 Thread rander.wang
在 7/26/2019 1:19 PM, Bard liao 写道: On 7/26/2019 7:40 AM, Pierre-Louis Bossart wrote: From: Rander Wang The existing code uses an OR operation which would mix the original divider setting with the new one, resulting in an invalid configuration that can make codecs hang. Add the mask

Re: [PATCH] rbtree: sync up the tools/ copy of the code with the main one

2019-07-25 Thread Michel Lespinasse
On Thu, Jul 25, 2019 at 8:19 PM Andrew Morton wrote: > On Tue, 2 Jul 2019 20:48:12 -0700 Michel Lespinasse > wrote: > > > I should probably have done this in the same commit that changed the > > main rbtree code to avoid generating code twice for the cached rbtree > > versions. > > > > Not

Re: linux-next: build warning after merge of the tip tree

2019-07-25 Thread Stephen Rothwell
Hi Josh, On Thu, 25 Jul 2019 23:49:09 -0500 Josh Poimboeuf wrote: > > This will be fixed by: > > > https://lkml.kernel.org/r/51a4155c5bc2ca847a9cbe85c1c11918bb193141.1564086017.git.jpoim...@redhat.com Thanks -- Cheers, Stephen Rothwell pgpIcuqnFnGu_.pgp Description: OpenPGP digital

[PATCH 07/17] ARM: dts: witherspoon: Cleanup gpio-keys-polled properties

2019-07-25 Thread Andrew Jeffery
dtbs_check gave the following warning: Warning (avoid_unnecessary_addr_size): /gpio-keys-polled: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property Cc: Joel Stanley Signed-off-by: Andrew Jeffery --- arch/arm/boot/dts/aspeed-bmc-opp-witherspoon.dts | 2 -- 1

[RFC PATCH 16/17] ARM: dts: aspeed-g5: Change KCS nodes to v2 binding

2019-07-25 Thread Andrew Jeffery
Fixes the following warnings: arch/arm/boot/dts/aspeed-g5.dtsi:376.19-381.8: Warning (unit_address_vs_reg): /ahb/apb/lpc@1e789000/lpc-bmc@0/kcs1@0: node has a unit name, but no reg property arch/arm/boot/dts/aspeed-g5.dtsi:382.19-387.8: Warning (unit_address_vs_reg):

[RFC PATCH 17/17] ARM: dts: aspeed-g5: Sort LPC child nodes by unit address

2019-07-25 Thread Andrew Jeffery
Lets try to maintain some sort of sanity. Signed-off-by: Andrew Jeffery --- arch/arm/boot/dts/aspeed-g5.dtsi | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/arch/arm/boot/dts/aspeed-g5.dtsi b/arch/arm/boot/dts/aspeed-g5.dtsi index 50ba58dc5093..99d2995a43db

[RFC PATCH 15/17] ipmi: kcs: aspeed: Implement v2 bindings

2019-07-25 Thread Andrew Jeffery
The v2 bindings allow us to extract the resources from the devicetree. The table in the driver is retained to derive the channel index, which removes the need for kcs_chan property from the v1 bindings. The v2 bindings allow us to reduce the number of warnings generated by the existing devicetree

[PATCH 06/17] ARM: dts: swift: Cleanup gpio-keys-polled properties

2019-07-25 Thread Andrew Jeffery
dtbs_check gave the following warning: Warning (avoid_unnecessary_addr_size): /gpio-keys-polled: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property Cc: Adriana Kobylak Signed-off-by: Andrew Jeffery --- arch/arm/boot/dts/aspeed-bmc-opp-swift.dts | 2 -- 1 file

[RFC PATCH 12/17] ARM: dts: aspeed: Add reg hints to syscon children

2019-07-25 Thread Andrew Jeffery
Fixes the following warnings: arch/arm/boot/dts/aspeed-g5.dtsi:209.28-226.6: Warning (avoid_unnecessary_addr_size): /ahb/apb/syscon@1e6e2000: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property arch/arm/boot/dts/aspeed-g4.dtsi:156.28-172.6: Warning

[PATCH 09/17] ARM: dts: ibm-power9-dual: Add a unit address for OCC nodes

2019-07-25 Thread Andrew Jeffery
These temporarily have a unit address until userspace is fixed up as noted in comments elsewhere in the dtsi. Fixes the following warning: arch/arm/boot/dts/ibm-power9-dual.dtsi:89.18-91.6: Warning (unit_address_vs_reg): /gpio-fsi/cfam@0,0/sbefifo@2400/occ: node has a reg or ranges

[PATCH 08/17] ARM: dts: aspeed: Cleanup lpc-ctrl and snoop regs

2019-07-25 Thread Andrew Jeffery
Fix the following warning: arch/arm/boot/dts/aspeed-g5.dtsi:409.27-414.8: Warning (unique_unit_address): /ahb/apb/lpc@1e789000/lpc-host@80/lpc-ctrl@0: duplicate unit-address (also used in node /ahb/apb/lpc@1e789000/lpc-host@80/lpc-snoop@0) Signed-off-by: Andrew Jeffery ---

[PATCH 04/17] ARM: dts: vesnin: Add unit address for memory node

2019-07-25 Thread Andrew Jeffery
Fixes the following warnings: arch/arm/boot/dts/aspeed-bmc-opp-vesnin.dt.yaml: /: memory: False schema does not allow {'reg': [[1073741824, 536870912]]} arch/arm/boot/dts/aspeed-bmc-opp-vesnin.dt.yaml: memory: 'device_type' is a required property Cc: Alexander Filippov Signed-off-by:

[RFC PATCH 11/17] dt-bindings: misc: Document reg for aspeed,p2a-ctrl nodes

2019-07-25 Thread Andrew Jeffery
The P2A controller node sits under a syscon device, and can assume offsets from the base of the syscon based on the compatible. However, for devicetree correctness allow a reg property to be specified, which an associated driver may choose to use to discover associated resources. Cc: Patrick

[RFC PATCH 10/17] dt-bindings: pinctrl: aspeed: Add reg property as a hint

2019-07-25 Thread Andrew Jeffery
The pinctrl node sits under a syscon device, and can assume offsets from the base of the syscon based on the compatible. However, for devicetree correctness allow a reg property to be specified, which an associated driver may choose to use to discover associated resources. Cc: Linus Walleij Cc:

[PATCH 01/17] ARM: dts: aspeed-g5: Move EDAC node to APB

2019-07-25 Thread Andrew Jeffery
Previously the register interface was not attached to any internal bus, which is not correct - it lives on the APB. Cc: Stefan M Schaeckeler Signed-off-by: Andrew Jeffery --- arch/arm/boot/dts/aspeed-g5.dtsi | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git

[PATCH 02/17] ARM: dts: aspeed-g5: Use recommended generic node name for SDMC

2019-07-25 Thread Andrew Jeffery
The EDAC is a sub-function of the SDRAM Memory Controller. Rename the node to the appropriate generic node name. Cc: Stefan M Schaeckeler Signed-off-by: Andrew Jeffery --- arch/arm/boot/dts/aspeed-g5.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 03/17] ARM: dts: aspeed-g5: Fix aspeed,external-nodes description

2019-07-25 Thread Andrew Jeffery
The existing approach lead to an error from the dtbs_check: pinctrl: aspeed,external-nodes: [[8, 9]] is too short Cc: Adriana Kobylak Cc: Brian Yang Cc: Joel Stanley Cc: John Wang Cc: Ken Chen Cc: Tao Ren Cc: Xo Wang Cc: Yuan Yao Signed-off-by: Andrew Jeffery ---

[PATCH 05/17] ARM: dts: fp5280g2: Cleanup gpio-keys-polled properties

2019-07-25 Thread Andrew Jeffery
dtbs_check gave the following warning: Warning (avoid_unnecessary_addr_size): /gpio-keys-polled: unnecessary #address-cells/#size-cells without "ranges" or child "reg" property Cc: John Wang Signed-off-by: Andrew Jeffery --- arch/arm/boot/dts/aspeed-bmc-inspur-fp5280g2.dts | 2 -- 1 file

Re: [PATCH] staging:iio:adc:ad7280a: add of_match_table entry

2019-07-25 Thread Ardelean, Alexandru
On Fri, 2019-07-26 at 01:38 +0530, Kartik Kulkarni wrote: > Add the of_device_id struct and the respective > of_match_device entry to complete device tree support. > This would be a [V2] I suppose. This change also does the rename of the driver name in a single go. Since it's a trivial change,

linux-next: Tree for Jul 26

2019-07-25 Thread Stephen Rothwell
Hi all, Changes since 20190725: New tree: edac Removed tree: edac-amd The vfs-fixes tree's BUG is gone (it was in interaction with the vfs tree). The leds tree lost its build failure. The akpm-current tree gained a build failure so I reverted 5 commits. Non-merge commits (relative to Linus

Re: [alsa-devel] [RFC PATCH 26/40] soundwire: cadence_master: fix divider setting in clock register

2019-07-25 Thread Bard liao
On 7/26/2019 7:40 AM, Pierre-Louis Bossart wrote: From: Rander Wang The existing code uses an OR operation which would mix the original divider setting with the new one, resulting in an invalid configuration that can make codecs hang. Add the mask definition and use cdns_updatel to update

Re: [PATCH v7 21/25] mips: Add clock_gettime64 entry point

2019-07-25 Thread Paul Burton
Hello, Vincenzo Frascino wrote: > With the release of Linux 5.1 has been added a new syscall, > clock_gettime64, that provided a 64 bit time value for a specified > clock_ID to make the kernel Y2038 safe on 32 bit architectures. > > Update the mips32 specific vDSO library accordingly with what

Re: [PATCH v7 20/25] mips: Add clock_getres entry point

2019-07-25 Thread Paul Burton
Hello, Vincenzo Frascino wrote: > The generic vDSO library provides an implementation of clock_getres() > that can be leveraged by each architecture. > > Add clock_getres() entry point on mips. > > Cc: Ralf Baechle > Cc: Paul Burton > Signed-off-by: Vincenzo Frascino Applied to mips-next.

Re: [PATCH v7 19/25] mips: Add support for generic vDSO

2019-07-25 Thread Paul Burton
Hello, Vincenzo Frascino wrote: > The mips vDSO library requires some adaptations to take advantage of the > newly introduced generic vDSO library. > > Introduce the following changes: > - Modification of vdso.c to be compliant with the common vdso datapage > - Use of lib/vdso for gettimeofday >

Re: [RFC] mm/pgtable/debug: Add test validating architecture page table helpers

2019-07-25 Thread Anshuman Khandual
On 07/26/2019 03:24 AM, Russell King - ARM Linux admin wrote: > On Thu, Jul 25, 2019 at 12:25:23PM +0530, Anshuman Khandual wrote: >> This adds a test module which will validate architecture page table helpers >> and accessors regarding compliance with generic MM semantics expectations. >> This

Re: linux-next: build warning after merge of the tip tree

2019-07-25 Thread Josh Poimboeuf
On Fri, Jul 26, 2019 at 01:05:49PM +1000, Stephen Rothwell wrote: > Hi all, > > After merging the tip tree, today's linux-next build (x86_64 allmodconfig) > produced this warning: > > drivers/gpu/drm/i915/gem/i915_gem_execbuffer.o: warning: objtool: > .altinstr_replacement+0x1c: redundant

Re: [RFC] mm/pgtable/debug: Add test validating architecture page table helpers

2019-07-25 Thread Anshuman Khandual
On 07/25/2019 08:09 PM, Matthew Wilcox wrote: > On Thu, Jul 25, 2019 at 12:25:23PM +0530, Anshuman Khandual wrote: >> This adds a test module which will validate architecture page table helpers >> and accessors regarding compliance with generic MM semantics expectations. >> This will help various

Re: [PATCH V6 01/21] irqchip: tegra: Do not disable COP IRQ during suspend

2019-07-25 Thread Dmitry Osipenko
В Wed, 24 Jul 2019 16:09:53 -0700 Sowjanya Komatineni пишет: > On 7/22/19 4:35 PM, Dmitry Osipenko wrote: > > 22.07.2019 21:38, Marc Zyngier пишет: > >> On Mon, 22 Jul 2019 09:21:21 -0700 > >> Sowjanya Komatineni wrote: > >> > >>> On 7/22/19 3:57 AM, Dmitry Osipenko wrote: >

[PATCH] Revert "ASoC: rockchip: i2s: Support mono capture"

2019-07-25 Thread Cheng-Yi Chiang
This reverts commit db51707b9c9aeedd310ebce60f15d5bb006567e0. Previous discussion in https://patchwork.kernel.org/patch/10147153/ explains the issue of the patch. While device is configured as 1-ch, hardware is still generating a 2-ch stream. When user space reads the data and assumes it is a

Re: [PATCH 4/5] IMA: use obj-y for non-modular objects

2019-07-25 Thread Eric Biggers
On Fri, Jul 26, 2019 at 11:10:57AM +0900, Masahiro Yamada wrote: > CONFIG_IMA is a boolean option, so none of these objects is linked > into a module. > > All the objects in this directory are compiled only when CONFIG_IMA=y > since this directory is guarded by the parent Makefile: > >

Re: [RFC] mm/pgtable/debug: Add test validating architecture page table helpers

2019-07-25 Thread Anshuman Khandual
On 07/25/2019 10:37 PM, Catalin Marinas wrote: > On Thu, Jul 25, 2019 at 12:25:23PM +0530, Anshuman Khandual wrote: >> +#if !defined(__PAGETABLE_PMD_FOLDED) && !defined(__ARCH_HAS_4LEVEL_HACK) >> +static void pud_clear_tests(void) >> +{ >> +pud_t pud; >> + >> +pud_clear(); >> +

linux-next: build failure after merge of the akpm-current tree

2019-07-25 Thread Stephen Rothwell
Hi all, After merging the akpm-current tree, today's linux-next build (arm multi_v7_defconfig) failed like this: mm/madvise.c: In function 'madvise_cold_or_pageout_pte_range': mm/madvise.c:346:7: error: implicit declaration of function 'is_huge_zero_pmd'; did you mean 'is_huge_zero_pud'?

Re: [PATCH V2 net-next 00/11] net: hns3: some code optimizations & bugfixes & features

2019-07-25 Thread tanhuazhong
Sorry, please ignore this patchset. Will resend it later:) On 2019/7/26 11:24, Huazhong Tan wrote: This patch-set includes code optimizations, bugfixes and features for the HNS3 ethernet controller driver. [patch 1/11] checks reset status before setting channel. [patch 2/11] adds a NULL

Re: [PATCH] tools/lib/traceevent, tools/perf: Move struct tep_handler definition in a local header file

2019-07-25 Thread Andres Freund
Hi, On 2018-10-05 12:22:25 -0400, Steven Rostedt wrote: > From: Tzvetomir Stoyanov > > As traceevent is going to be transferred into a proper library, > its local data should be protected from the library users. > This patch encapsulates struct tep_handler into a local header, > not visible

Re: [PATCH v2] .gitignore: Add compilation database file

2019-07-25 Thread Nick Desaulniers
On Tue, Jul 23, 2019 at 5:22 PM Toru Komatsu wrote: > > This file is used by clangd to use language server protocol. > It can be generated at each compile using scripts/gen_compile_commands.py. > Therefore it is different depending on the environment and should be > ignored. > > Signed-off-by:

[PATCH 2/3] fs: ocfs2: Fix a possible null-pointer dereference in ocfs2_write_end_nolock()

2019-07-25 Thread Jia-Ju Bai
In ocfs2_write_end_nolock(), there are an if statement on lines 1976, 2047 and 2058, to check whether handle is NULL: if (handle) When handle is NULL, it is used on line 2045: ocfs2_update_inode_fsync_trans(handle, inode, 1); oi->i_sync_tid = handle->h_transaction->t_tid;

[PATCH 1/3] fs: ocfs2: Fix possible null-pointer dereferences in ocfs2_xa_prepare_entry()

2019-07-25 Thread Jia-Ju Bai
In ocfs2_xa_prepare_entry(), there is an if statement on line 2136 to check whether loc->xl_entry is NULL: if (loc->xl_entry) When loc->xl_entry is NULL, it is used on line 2158: ocfs2_xa_add_entry(loc, name_hash); loc->xl_entry->xe_name_hash = cpu_to_le32(name_hash);

[PATCH 3/3] fs: ocfs2: Fix a possible null-pointer dereference in ocfs2_info_scan_inode_alloc()

2019-07-25 Thread Jia-Ju Bai
In ocfs2_info_scan_inode_alloc(), there is an if statement on line 283 to check whether inode_alloc is NULL: if (inode_alloc) When inode_alloc is NULL, it is used on line 287: ocfs2_inode_lock(inode_alloc, , 0); ocfs2_inode_lock_full_nested(inode, ...) struct

Re: [BUG] fs: f2fs: Possible null-pointer dereferences in update_general_status()

2019-07-25 Thread Chao Yu
Hi Jiaju, Thanks for the report, I checked the code, and found it doesn't need to check SM_I(sbi) pointer, this is because in fill_super() and put_super(), we will call f2fs_destroy_stats() in prior to f2fs_destroy_segment_manager(), so if current sbi can still be visited in global stat list,

[PATCH] [ASoC][soc-dapm] : memory leak in the func snd_soc_dapm_new_dai

2019-07-25 Thread Satendra Singh Thakur
In the func snd_soc_dapm_new_dai, if the inner func snd_soc_dapm_alloc_kcontrol fails, there will be memory leak. The label param_fail wont free memory which is allocated by the func devm_kcalloc. Hence new label is created for this purpose. Signed-off-by: Satendra Singh Thakur ---

[PATCH V2 net-next 09/11] net: hns3: add interrupt affinity support for misc interrupt

2019-07-25 Thread Huazhong Tan
From: Yunsheng Lin The misc interrupt is used to schedule the reset and mailbox subtask, and a 1 sec timer is used to schedule the service subtask, which does periodic work. This patch sets the above three subtask's affinity using the misc interrupt' affinity. Also this patch setups a affinity

[PATCH V2 net-next 03/11] net: hns3: remove upgrade reset level when reset fail

2019-07-25 Thread Huazhong Tan
Currently, hclge_reset_err_handle() will assert a global reset when the failing count is smaller than MAX_RESET_FAIL_CNT, which will affect other running functions. So this patch removes this upgrading, and uses re-scheduling reset task to do it. Signed-off-by: Huazhong Tan Reviewed-by:

[PATCH V2 net-next 00/11] net: hns3: some code optimizations & bugfixes & features

2019-07-25 Thread Huazhong Tan
This patch-set includes code optimizations, bugfixes and features for the HNS3 ethernet controller driver. [patch 1/11] checks reset status before setting channel. [patch 2/11] adds a NULL pointer checking. [patch 3/11] removes reset level upgrading when current reset fails. [patch 4/11] fixes

[PATCH V2 net-next 02/11] net: hns3: add a check for get_reset_level

2019-07-25 Thread Huazhong Tan
From: Guangbin Huang For some cases, ops->get_reset_level may not be implemented, so we should check whether it is NULL before calling get_reset_level. Signed-off-by: Guangbin Huang Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hns3_enet.c | 2 +- 1 file changed, 1

[PATCH V2 net-next 05/11] net: hns3: change GFP flag during lock period

2019-07-25 Thread Huazhong Tan
From: Yufeng Mo When allocating memory, the GFP_KERNEL cannot be used during the spin_lock period. This is because it may cause scheduling when holding spin_lock. This patch changes GFP flag to GFP_ATOMIC in this case. Fixes: dd74f815dd41 ("net: hns3: Add support for rule add/delete for flow

[PATCH V2 net-next 01/11] net: hns3: add reset checking before set channels

2019-07-25 Thread Huazhong Tan
From: Jian Shen hns3_set_channels() should check the resetting status firstly, since the device will reinitialize when resetting. If the reset has not completed, the hns3_set_channels() may access invalid memory. Signed-off-by: Jian Shen Signed-off-by: Huazhong Tan ---

[PATCH V2 net-next 04/11] net: hns3: fix mis-counting IRQ vector numbers issue

2019-07-25 Thread Huazhong Tan
From: Yonglong Liu The num_msi_left means the vector numbers of NIC, but if the PF supported RoCE, it contains the vector numbers of NIC and RoCE(Not expected). This may cause interrupts lost in some case, because of the NIC module used the vector resources which belongs to RoCE. This patch

[PATCH V2 net-next 07/11] net: hns3: adds debug messages to identify eth down cause

2019-07-25 Thread Huazhong Tan
From: Yonglong Liu Some times just see the eth interface have been down/up via dmesg, but can not know why the eth down. So adds some debug messages to identify the cause for this. Signed-off-by: Yonglong Liu Signed-off-by: Peng Li Signed-off-by: Huazhong Tan ---

[PATCH V2 net-next 10/11] net: hns3: Add support for using order 1 pages with a 4K buffer

2019-07-25 Thread Huazhong Tan
From: Yunsheng Lin Hardware supports 0.5K, 1K, 2K, 4K RX buffer size, the RX buffer can not be reused because the hns3_page_order return 0 when page size and RX buffer size are both 4096. So this patch changes the hns3_page_order to return 1 when RX buffer is greater than half of the page size

[PATCH V2 net-next 08/11] net: hns3: make hclge_service use delayed workqueue

2019-07-25 Thread Huazhong Tan
From: Yunsheng Lin Use delayed work instead of using timers to trigger the hclge_serive. Simplify the code with one less middle function and in order to support misc irq affinity. Signed-off-by: Yunsheng Lin Reviewed-by: Peng Li Signed-off-by: Huazhong Tan ---

[PATCH V2 net-next 06/11] net: hns3: modify firmware version display format

2019-07-25 Thread Huazhong Tan
From: Yufeng Mo This patch modifies firmware version display format in hclge(vf)_cmd_init() and hns3_get_drvinfo(). Also, adds some optimizations for firmware version display format. Signed-off-by: Yufeng Mo Signed-off-by: Peng Li Signed-off-by: Huazhong Tan ---

[PATCH V2 net-next 11/11] net: hns3: use dev_info() instead of pr_info()

2019-07-25 Thread Huazhong Tan
dev_info() is more appropriate for printing messages when driver initialization done, so switch to dev_info(). Signed-off-by: Huazhong Tan --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c | 4 +++- drivers/net/ethernet/hisilicon/hns3/hns3vf/hclgevf_main.c | 3 ++- 2 files changed,

Re: [PATCH] cpufreq: schedutil: Don't skip freq update when limits change

2019-07-25 Thread Viresh Kumar
On 25-07-19, 08:20, Doug Smythies wrote: > I tried the patch ("patch2"). It did not fix the issue. > > To summarize, all kernel 5.2 based, all intel_cpufreq driver and schedutil > governor: > > Test: Does a busy system respond to maximum CPU clock frequency reduction? > > stock, unaltered: No.

Re: kernel BUG at mm/swap_state.c:170!

2019-07-25 Thread Huang, Ying
Matthew Wilcox writes: > On Tue, Jul 23, 2019 at 01:08:42PM +0800, Huang, Ying wrote: >> @@ -2489,6 +2491,14 @@ static void __split_huge_page(struct page *page, >> struct list_head *list, >> /* complete memcg works before add pages to LRU */ >> mem_cgroup_split_huge_fixup(head); >>

Re: [PATCH] rbtree: sync up the tools/ copy of the code with the main one

2019-07-25 Thread Andrew Morton
On Tue, 2 Jul 2019 20:48:12 -0700 Michel Lespinasse wrote: > I should probably have done this in the same commit that changed the > main rbtree code to avoid generating code twice for the cached rbtree > versions. > > Not copying the reviewers of the previous change as tools/ is just another >

linux-next: build warning after merge of the tip tree

2019-07-25 Thread Stephen Rothwell
Hi all, After merging the tip tree, today's linux-next build (x86_64 allmodconfig) produced this warning: drivers/gpu/drm/i915/gem/i915_gem_execbuffer.o: warning: objtool: .altinstr_replacement+0x1c: redundant UACCESS disable Presuambly introduced/uncovered by commit 882a0db9d143 ("objtool:

[GIT PULL] Wimplicit-fallthrough patches for 5.3-rc2

2019-07-25 Thread Gustavo A. R. Silva
Hi Linus, Kees let me know about the problems you had with my previous pull-request. Apologies for the inconvenience. Here is a new pull-request that includes a fix for those warnings you were seeing with the dcn20_dccg driver. Just for you to know, I'm building allmodconfig. Please, let me

Re: [PATCH v7 0/5] Introduce MADV_COLD and MADV_PAGEOUT

2019-07-25 Thread Minchan Kim
Hi Andrew, It's the resend with fixing build errors kbuildbot reported. Please take it this version to get more test coverage. Thanks. On Fri, Jul 26, 2019 at 11:34:30AM +0900, Minchan Kim wrote: > This patch is part of previous series: >

Re: memory leak in dma_buf_ioctl

2019-07-25 Thread Steven Rostedt
On Thu, 25 Jul 2019 19:34:01 -0700 syzbot wrote: > syzbot has bisected this bug to: > > commit 04cf31a759ef575f750a63777cee95500e410994 > Author: Michael Ellerman > Date: Thu Mar 24 11:04:01 2016 + > > ftrace: Make ftrace_location_range() global It's sad that I have yet to find a

Re: [PATCH 1/2] string: Add stracpy and stracpy_pad mechanisms

2019-07-25 Thread Joe Perches
On Thu, 2019-07-25 at 13:03 -0700, Kees Cook wrote: > On Wed, Jul 24, 2019 at 10:08:57AM -0700, Linus Torvalds wrote: > > On Wed, Jul 24, 2019 at 6:09 AM Rasmus Villemoes > > wrote: > > > The kernel's snprintf() does not behave in a non-standard way, at least > > > not with respect to its return

Re: [PATCH 1/1] power/supply/powersupply_sysfs: Add of_node name to uevent message if available

2019-07-25 Thread Richard Tresidder
Hi David   That it would be. I wasn't aware of that call. I'll give it a crack and send in a new version of the patch. Cheers   Richard Tresidder Richard Tresidder On 25/07/2019 10:08 pm, David Lechner wrote: On 7/25/19 2:47 AM, Richard Tresidder wrote: If the of_node name of the supply is

Re: [PATCH 1/1] power/supply/sbs-battery: Fix confusing battery status when idle or empty

2019-07-25 Thread Richard Tresidder
Hi Guenter    Yep sorry there was a merge that I missed during that initial send of the patch. I sent a version 2 shortly after. Regards    Richard Tresidder On 25/07/2019 9:39 pm, Guenter Roeck wrote: On Thu, Jul 25, 2019 at 1:25 AM Richard Tresidder wrote: When a battery or batteries in

RE: Re: [PATCH v4] serial/8250: Add support for NI-Serial PXI/PXIe+485 devices

2019-07-25 Thread Je Yen Tam
> Subject: [EXTERNAL] Re: [PATCH v4] serial/8250: Add support for NI-Serial > PXI/PXIe+485 devices > > On Fri, Jul 05, 2019 at 06:15:28AM -0700, jeyentam wrote: > > Add support for NI-Serial PXIe-RS232, PXI-RS485 and PXIe-RS485 devices. > > > > Signed-off-by: Je Yen Tam > > --- > > v3 -> v4: > >

[PATCH v5] serial/8250: Add support for NI-Serial PXI/PXIe+485 devices

2019-07-25 Thread jeyentam
Add support for NI-Serial PXIe-RS232, PXI-RS485 and PXIe-RS485 devices. Signed-off-by: jeyentam --- v4 -> v5 - Remove blank lines between variable definitions. - Remove trace_printk(). v3 -> v4: - Add changes description. v2 -> v3: - Add "full" name for author - Use BIT() macro for bits

Re: [PATCH] ext4: Fix deadlock on page reclaim

2019-07-25 Thread Damien Le Moal
On 2019/07/25 20:54, Christoph Hellwig wrote: > On Thu, Jul 25, 2019 at 06:33:58PM +0900, Damien Le Moal wrote: >> +gfp_t gfp_mask; >> + >> switch (ext4_inode_journal_mode(inode)) { >> case EXT4_INODE_ORDERED_DATA_MODE: >> case EXT4_INODE_WRITEBACK_DATA_MODE: >> @@ -4019,6

Re: [PATCH v5 09/10] iommu/vt-d: Add trace events for device dma map/unmap

2019-07-25 Thread Lu Baolu
Hi, On 7/25/19 8:26 PM, Steven Rostedt wrote: On Thu, 25 Jul 2019 11:17:16 +0800 Lu Baolu wrote: This adds trace support for the Intel IOMMU driver. It also declares some events which could be used to trace the events when an IOVA is being mapped or unmapped in a domain. Cc: Ashok Raj Cc:

[PATCH v7 0/5] Introduce MADV_COLD and MADV_PAGEOUT

2019-07-25 Thread Minchan Kim
This patch is part of previous series: https://lore.kernel.org/lkml/20190531064313.193437-1-minc...@kernel.org/ Originally, it was created for external madvise hinting feature. https://lkml.org/lkml/2019/5/31/463 Michal wanted to separte the discussion from external hinting interface so this

[PATCH v7 5/5] mm: factor out common parts between MADV_COLD and MADV_PAGEOUT

2019-07-25 Thread Minchan Kim
There are many common parts between MADV_COLD and MADV_PAGEOUT. This patch factor them out to save code duplication. Suggested-by: Johannes Weiner Acked-by: Michal Hocko Signed-off-by: Minchan Kim --- mm/madvise.c | 194 --- 1 file changed, 46

[PATCH 2/2] net: ipv4: Fix a possible null-pointer dereference in fib4_rule_suppress()

2019-07-25 Thread Jia-Ju Bai
In fib4_rule_suppress(), there is an if statement on line 145 to check whether result->fi is NULL: if (result->fi) When result->fi is NULL, it is used on line 167: fib_info_put(result->fi); In fib_info_put(), the argument fi is used: if (refcount_dec_and_test(>fib_clntref)) Thus, a

[PATCH v7 2/5] mm: change PAGEREF_RECLAIM_CLEAN with PAGE_REFRECLAIM

2019-07-25 Thread Minchan Kim
The local variable references in shrink_page_list is PAGEREF_RECLAIM_CLEAN as default. It is for preventing to reclaim dirty pages when CMA try to migrate pages. Strictly speaking, we don't need it because CMA didn't allow to write out by .may_writepage = 0 in reclaim_clean_pages_from_list.

[PATCH v7 4/5] mm: introduce MADV_PAGEOUT

2019-07-25 Thread Minchan Kim
When a process expects no accesses to a certain memory range for a long time, it could hint kernel that the pages can be reclaimed instantly but data should be preserved for future use. This could reduce workingset eviction so it ends up increasing performance. This patch introduces the new

[PATCH v7 3/5] mm: account nr_isolated_xxx in [isolate|putback]_lru_page

2019-07-25 Thread Minchan Kim
The isolate counting is pecpu counter so it would be not huge gain to work them by batch. Rather than complicating to make them batch, let's make it more stright-foward via adding the counting logic into [isolate|putback]_lru_page API. * v1 * fix accounting bug - Hillf Link:

[PATCH v7 1/5] mm: introduce MADV_COLD

2019-07-25 Thread Minchan Kim
When a process expects no accesses to a certain memory range, it could give a hint to kernel that the pages can be reclaimed when memory pressure happens but data should be preserved for future use. This could reduce workingset eviction so it ends up increasing performance. This patch introduces

Re: [PATCH net-next 07/11] net: hns3: adds debug messages to identify eth down cause

2019-07-25 Thread liuyonglong
As Saeed said, we will use netif_msg_drv() which is default off, this can be easily open with ethtool. Thanks for your reply! On 2019/7/26 9:28, Jakub Kicinski wrote: > On Thu, 25 Jul 2019 21:59:08 +, Saeed Mahameed wrote: >> I couldn't find any rules regarding what to put in kernel log,

[PATCH v2] counter/ftm-quaddec: Use device-managed registration API

2019-07-25 Thread Chuhong Yuan
Make use of devm_counter_register. Then we can remove redundant unregistration API usage to make code simpler. Signed-off-by: Chuhong Yuan --- Changes in v2: - Use devm_add_action_or_reset to keep resource release order. - _remove() function is redundant now, delete it.

[PATCH 1/2] net: ipv4: Fix a possible null-pointer dereference in inet_csk_rebuild_route()

2019-07-25 Thread Jia-Ju Bai
In inet_csk_rebuild_route(), rt is assigned to NULL on line 1071. On line 1076, rt is used: return >dst; Thus, a possible null-pointer dereference may occur. To fix this bug, rt is checked before being used. This bug is found by a static analysis tool STCheck written by us. Signed-off-by:

Re: [PATCH net-next 07/11] net: hns3: adds debug messages to identify eth down cause

2019-07-25 Thread liuyonglong
We will change all of them to netif_msg_drv() which is default off Thanks for your reply! On 2019/7/26 5:59, Saeed Mahameed wrote: > On Thu, 2019-07-25 at 20:28 +0800, liuyonglong wrote: >> >> On 2019/7/25 3:12, Saeed Mahameed wrote: >>> On Wed, 2019-07-24 at 11:18 +0800, Huazhong Tan wrote:

[PATCH v15 2/2] dt-bindings: spi: Document Renesas R-Car Gen3 RPC-IF controller bindings

2019-07-25 Thread Mason Yang
Dcument the bindings used by the Renesas R-Car Gen3 RPC-IF controller. Signed-off-by: Mason Yang Reviewed-by: Rob Herring --- .../devicetree/bindings/spi/spi-renesas-rpc.txt| 46 ++ 1 file changed, 46 insertions(+) create mode 100644

[PATCH 2/5] integrity: remove pointless subdir-$(CONFIG_...)

2019-07-25 Thread Masahiro Yamada
The ima/ and evm/ sub-directories contain built-in objects, so obj-$(CONFIG_...) is the correct way to descend into them. subdir-$(CONFIG_...) is redundant. Signed-off-by: Masahiro Yamada --- security/integrity/Makefile | 2 -- 1 file changed, 2 deletions(-) diff --git

Re: [PATCH v6 14/14] arm64: dts: Add power controller device node of MT8183

2019-07-25 Thread CK Hu
Hi, Weiyi: On Tue, 2019-07-23 at 12:06 +0800, Weiyi Lu wrote: > On Tue, 2019-07-16 at 09:50 +0800, CK Hu wrote: > > Hi, Weiyi: > > > > On Mon, 2019-07-15 at 17:07 +0800, Weiyi Lu wrote: > > > On Mon, 2019-07-15 at 16:07 +0800, CK Hu wrote: > > > > Hi, Weiyi: > > > > > > > > On Mon, 2019-07-01

[PATCH v15 0/2] spi: Add Renesas R-Car Gen3 RPC-IF SPI driver

2019-07-25 Thread Mason Yang
Hi Mark, v15 patch including: 1) A typo in dt-bindings and add flash subnode description 2) v14 dt-binding file has reviewed by Rob Herring. v14 patch including: 1) Patch RPC-IF back to SPI mode only instead of MFD & SPI by MFD maintainer, Lee Jones comments. 2) Patch pm_runtime control in

Re: [PATCH 2/5] sched/fair: rename sum_nr_running to sum_h_nr_running

2019-07-25 Thread Srikar Dronamraju
* Vincent Guittot [2019-07-19 09:58:22]: > sum_nr_running will track rq->nr_running task and sum_h_nr_running > will track cfs->h_nr_running so we can use both to detect when other > scheduling class are running and preempt CFS. > > There is no functional changes. > > Signed-off-by: Vincent

[PATCH v2 1/2] mmc: sdhci: Add PLL Enable support to internal clock setup

2019-07-25 Thread Michael K. Johnson
The GL9750 and GL9755 chipsets, and possibly others, require PLL Enable setup as part of the internal clock setup as described in 3.2.1 Internal Clock Setup Sequence of SD Host Controller Simplified Specification Version 4.20. This changes the timeouts to the new specification of 150ms for each

Re: [alsa-devel] [RFC PATCH 09/40] soundwire: cadence_master: fix usage of CONFIG_UPDATE

2019-07-25 Thread Bard liao
On 7/26/2019 7:40 AM, Pierre-Louis Bossart wrote: Per the hardware documentation, all changes to MCP_CONFIG, MCP_CONTROL, MCP_CMDCTRL and MCP_PHYCTRL need to be validated with a self-clearing write to MCP_CONFIG_UPDATE. For some reason, the existing code only does this write to CONFIG_UPDATE

Re: [PATCH] kprobes: Allow kprobes coexist with livepatch

2019-07-25 Thread Joe Lawrence
On Thu, Jul 25, 2019 at 03:24:37PM +0900, Masami Hiramatsu wrote: > Allow kprobes which do not modify regs->ip, coexist with livepatch > by dropping FTRACE_OPS_FL_IPMODIFY from ftrace_ops. > > User who wants to modify regs->ip (e.g. function fault injection) > must set a dummy post_handler to its

[PATCH 5/5] EVM: use obj-y for non-modular objects

2019-07-25 Thread Masahiro Yamada
CONFIG_EVM is a boolean option, so none of these objects is linked into a module. All the objects in this directory are compiled only when CONFIG_EVM=y since this directory is guarded by the parent Makefile: obj-$(CONFIG_EVM) += evm/ So, there is no point in creating the

[PATCH v15 1/2] spi: Add Renesas R-Car Gen3 RPC-IF SPI controller driver

2019-07-25 Thread Mason Yang
Add a driver for Renesas R-Car Gen3 RPC-IF SPI controller. Signed-off-by: Mason Yang Signed-off-by: Sergei Shtylyov --- drivers/spi/Kconfig | 6 + drivers/spi/Makefile | 1 + drivers/spi/spi-renesas-rpc.c | 754 ++ 3 files changed,

[PATCH] kbuild: clean-up subdir-ym computation

2019-07-25 Thread Masahiro Yamada
The intermediate variables __subdir-{y,m} are unneeded. Signed-off-by: Masahiro Yamada --- scripts/Makefile.lib | 17 + 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib index 41c50f9461e5..444574963cb5 100644 ---

[PATCH] kbuild: remove unused single-used-m

2019-07-25 Thread Masahiro Yamada
This is unused since commit 9f69a496f100 ("kbuild: split out *.mod out of {single,multi}-used-m rules"). Signed-off-by: Masahiro Yamada --- scripts/Makefile.lib | 2 -- 1 file changed, 2 deletions(-) diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib index 5241d0751eb0..41c50f9461e5

Re: [PATCH v1 2/2] extcon: axp288: Use for_each_set_bit() in axp288_extcon_log_rsi()

2019-07-25 Thread Chanwoo Choi
On 19. 7. 26. 오전 5:34, Andy Shevchenko wrote: > This simplifies and standardizes axp288_extcon_log_rsi() > by using for_each_set_bit() library function. > > Signed-off-by: Andy Shevchenko > --- > drivers/extcon/extcon-axp288.c | 13 + > 1 file changed, 5 insertions(+), 8

[PATCH v2] ALSA: i2c: ak4xxx-adda: Fix a possible null pointer dereference in build_adc_controls()

2019-07-25 Thread Jia-Ju Bai
In build_adc_controls(), there is an if statement on line 773 to check whether ak->adc_info is NULL: if (! ak->adc_info || ! ak->adc_info[mixer_ch].switch_name) When ak->adc_info is NULL, it is used on line 792: knew.name = ak->adc_info[mixer_ch].selector_name; Thus, a possible

[PATCH v2] mm: memcontrol: fix use after free in mem_cgroup_iter()

2019-07-25 Thread Miles Chen
This patch is sent to report an use after free in mem_cgroup_iter() after merging commit: be2657752e9e "mm: memcg: fix use after free in mem_cgroup_iter()". I work with android kernel tree (4.9 & 4.14), and the commit: be2657752e9e "mm: memcg: fix use after free in mem_cgroup_iter()" has been

[PATCH 1/5] integrity: remove unneeded, broken attempt to add -fshort-wchar

2019-07-25 Thread Masahiro Yamada
I guess commit 15ea0e1e3e18 ("efi: Import certificates from UEFI Secure Boot") attempted to add -fshort-wchar for building load_uefi.o, but it has never worked as intended. load_uefi.o is created in the platform_certs/ sub-directory. If you really want to add -fshort-wchar, the correct code is:

[PATCH 4/5] IMA: use obj-y for non-modular objects

2019-07-25 Thread Masahiro Yamada
CONFIG_IMA is a boolean option, so none of these objects is linked into a module. All the objects in this directory are compiled only when CONFIG_IMA=y since this directory is guarded by the parent Makefile: obj-$(CONFIG_IMA) += ima/ So, there is no point in creating the

[PATCH 0/5] security: integrity: Makefile cleanups

2019-07-25 Thread Masahiro Yamada
Masahiro Yamada (5): integrity: remove unneeded, broken attempt to add -fshort-wchar integrity: remove pointless subdir-$(CONFIG_...) integrity: use obj-y for non-modular objects IMA: use obj-y for non-modular objects EVM: use obj-y for non-modular objects security/integrity/Makefile

[PATCH 3/5] integrity: use obj-y for non-modular objects

2019-07-25 Thread Masahiro Yamada
CONFIG_INTEGRITY is a boolean option, so none of these objects is linked into a module. All of the other CONFIG options here depend on CONFIG_INTEGRITY, so there is no point in creating the composite object, integirity.o Flatten the code into the obj-$(CONFIG_...) form. Signed-off-by: Masahiro

[PATCH v2 2/2] mmc: sdhci: sdhci-pci-core: Add Genesis Logic GL975x support

2019-07-25 Thread Michael K. Johnson
Add support for the GL9750 and GL9755 chipsets. Signed-off-by: Ben Chuang Co-developed-by: Michael K Johnson Signed-off-by: Michael K Johnson diff --git a/drivers/mmc/host/sdhci-gli.h b/drivers/mmc/host/sdhci-gli.h new file mode 100644 index ..0acd35b6d3e2 --- /dev/null +++

Re: [PATCH] ALSA: i2c: ak4xxx-adda: Fix a possible null pointer dereference in build_adc_controls()

2019-07-25 Thread Jia-Ju Bai
On 2019/7/25 23:52, Takashi Iwai wrote: On Thu, 25 Jul 2019 10:27:33 +0200, Jia-Ju Bai wrote: In build_adc_controls(), there is an if statement on line 773 to check whether ak->adc_info is NULL: if (! ak->adc_info || ! ak->adc_info[mixer_ch].switch_name) When

Re: [PATCH v4 0/5] Add required-opps support to devfreq passive gov

2019-07-25 Thread Saravana Kannan
On Wed, Jul 24, 2019 at 10:22 PM Viresh Kumar wrote: > > On 24-07-19, 20:40, Saravana Kannan wrote: > > On Wed, Jul 24, 2019 at 7:30 PM Viresh Kumar > > wrote: > > > > > > On 23-07-19, 18:42, Saravana Kannan wrote: > > > > The devfreq passive governor scales the frequency of a "child" device >

  1   2   3   4   5   6   7   8   9   10   >