Re: [PATCH V7 3/3] arm64/mm: Enable memory hot remove

2019-09-12 Thread Anshuman Khandual
On 09/13/2019 01:45 AM, Catalin Marinas wrote: > Hi Anshuman, > > Thanks for the details on the need for removing the page tables and > vmemmap backing. Some comments on the code below. > > On Tue, Sep 03, 2019 at 03:15:58PM +0530, Anshuman Khandual wrote: >> --- a/arch/arm64/mm/mmu.c >> +++

RE: [EXT] Re: [PATCH 2/3] ASoC: fsl_asrc: update supported sample format

2019-09-12 Thread S.j. Wang
Hi > > On Tue, Sep 10, 2019 at 02:07:25AM +, S.j. Wang wrote: > > > On Mon, Sep 09, 2019 at 06:33:20PM -0400, Shengjiu Wang wrote: > > > > The ASRC support 24bit/16bit/8bit input width, so S20_3LE format > > > > should not be supported, it is word width is 20bit. > > > > > > I thought 3LE

Re: [PATCH v3 5/6] x86: alternative.h: use asm_inline for all alternative variants

2019-09-12 Thread Ingo Molnar
* Rasmus Villemoes wrote: > Most, if not all, uses of the alternative* family just provide one or > two instructions in .text, but the string literal can be quite large, > causing gcc to overestimate the size of the generated code. That in > turn affects its decisions about inlining of the

Re: [PATCH v3 6/6] x86: bug.h: use asm_inline in _BUG_FLAGS definitions

2019-09-12 Thread Ingo Molnar
* Rasmus Villemoes wrote: > This helps preventing a BUG* or WARN* in some static inline from > preventing that (or one of its callers) being inlined, so should allow > gcc to make better informed inlining decisions. > > For example, with gcc 9.2, tcp_fastopen_no_cookie() vanishes from >

[PATCH] tty: 8250_of: Use software emulated RS485 direction control

2019-09-12 Thread Heiko Schocher
Use software emulated RS485 direction control to provide RS485 API Currently it is not possible to use rs485 as pointer to rs485_config struct in struct uart_port is NULL in case we configure the port through device tree. Signed-off-by: Heiko Schocher --- Patch is based on:

Re: [PATCH] leds: remove PAGE_SIZE limit of /sys/class/leds//trigger

2019-09-12 Thread Greg Kroah-Hartman
On Fri, Sep 13, 2019 at 09:34:49AM +0900, Akinobu Mita wrote: > 2019年9月13日(金) 2:15 Jacek Anaszewski : > > > > Hi Akinobu, > > > > Please bump patch version each time you send an update > > of the patch with the same subject. > > Oops, should I resend with the correct subject? Yes please.

Re: [Ksummit-discuss] [PATCH v2 3/3] libnvdimm, MAINTAINERS: Maintainer Entry Profile

2019-09-12 Thread Greg KH
On Fri, Sep 13, 2019 at 07:41:55AM +0530, Aneesh Kumar K.V wrote: > On 9/12/19 12:13 AM, Dan Carpenter wrote: > > On Wed, Sep 11, 2019 at 08:48:59AM -0700, Dan Williams wrote: > > > +Coding Style Addendum > > > +- > > > +libnvdimm expects multi-line statements to be double

Re: KASAN: slab-out-of-bounds Read in handle_vmptrld

2019-09-12 Thread Greg Kroah-Hartman
On Thu, Sep 12, 2019 at 06:49:26PM +0200, Paolo Bonzini wrote: > [tl;dr: there could be a /dev/usb bug only affecting KASAN > configurations, jump to the end to skip the analysis and get to the bug > details] > > On 12/09/19 15:54, Vitaly Kuznetsov wrote: > > Hm, the bisection seems bogus but the

Re: [RFC V1 1/7] genirq/msi: Differentiate between various MSI based interrupts

2019-09-12 Thread Greg KH
On Thu, Sep 12, 2019 at 06:32:02PM -0700, Megha Dey wrote: > +enum msi_desc_tags { > + IRQ_MSI_TAG_MSI, > + IRQ_MSI_TAG_MSIX, > + IRQ_MSI_TAG_IMS, > + IRQ_MSI_TAG_PLAT, > + IRQ_MSI_TAG_FSL, > + IRQ_MSI_TAG_SCI, > +}; What does any of these mean? Can you please provide

Re: [RFC V1 2/7] drivers/base: Introduce callbacks for IMS interrupt domain

2019-09-12 Thread Greg KH
On Thu, Sep 12, 2019 at 06:32:03PM -0700, Megha Dey wrote: > This patch serves as a preparatory patch to introduce a new IMS > (Interrupt Message Store) domain. It consists of APIs which would > be used as callbacks to the IRQ chip associated with the IMS domain. > > The APIs introduced in this

[PATCH] iwlwifi: dbg_ini: fix memory leak in alloc_sgtable

2019-09-12 Thread Navid Emamdoost
In alloc_sgtable if alloc_page fails, the alocated table should be released. Signed-off-by: Navid Emamdoost --- drivers/net/wireless/intel/iwlwifi/fw/dbg.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/intel/iwlwifi/fw/dbg.c

Re: [PATCH v8 00/17] Enable FSGSBASE instructions

2019-09-12 Thread Andy Lutomirski
On 9/12/19 1:06 PM, Chang S. Bae wrote: Updates from v7 [7]: (1) Consider FSGSBASE when determining which Spectre SWAPGS mitigations are required. (2) Fixed save_fsgs() to be aware of interrupt conditions (3) Made selftest changes based on Andy's previous fixes and cleanups (4) Included

Re: [PATCH] clk: imx: lpcg: write twice when writing lpcg regs

2019-09-12 Thread Shawn Guo
On Tue, Sep 10, 2019 at 02:47:59AM +, Anson Huang wrote: > > > > On Sat, Sep 7, 2019 at 9:47 PM Stephen Boyd wrote: > > > > > > Quoting Peng Fan (2019-08-27 01:17:50) > > > > From: Peng Fan > > > > > > > > There is hardware issue that: > > > > The output clock the LPCG cell will not turn

[PATCH net-next] net: dsa: b53: Add support for port_egress_floods callback

2019-09-12 Thread Florian Fainelli
Add support for configuring the per-port egress flooding control for both Unicast and Multicast traffic. Signed-off-by: Florian Fainelli --- Beneditk, Do you mind re-testing, or confirming that this patch that I sent much earlier does work correctly for you? Thanks!

[PATCH v2 2/2] gpiolib: introduce fwnode_gpiod_get_index()

2019-09-12 Thread Dmitry Torokhov
This introduces fwnode_gpiod_get_index() that iterates through common gpio suffixes when trying to locate a GPIO within a given firmware node. We also switch devm_fwnode_gpiod_get_index() to call fwnode_gpiod_get_index() instead of iterating through GPIO suffixes on its own. Reviewed-by: Andy

[PATCH v2 0/2] Add support for software nodes to gpiolib

2019-09-12 Thread Dmitry Torokhov
This is a part of the larger series previously posted at https://lore.kernel.org/linux-gpio/20190911075215.78047-1-dmitry.torok...@gmail.com that was rebased on top of linux-gpio devel branch. Changes in v2: - switched export to be EXPORT_SYMBOL_GPL to match the new export markings for the

[PATCH v2 1/2] gpiolib: introduce devm_fwnode_gpiod_get_index()

2019-09-12 Thread Dmitry Torokhov
devm_fwnode_get_index_gpiod_from_child() is too long, besides the fwnode in question does not have to be a child of device node. Let's rename it to devm_fwnode_gpiod_get_index() and keep the old name for compatibility for now. Also let's add a devm_fwnode_gpiod_get() wrapper as majority of the

[PATCH 03/11] KVM: x86/mmu: Use fast invalidate mechanism to zap MMIO sptes

2019-09-12 Thread Sean Christopherson
Use the fast invalidate mechasim to zap MMIO sptes on a MMIO generation wrap. The fast invalidate flow was reintroduced to fix a livelock bug in kvm_mmu_zap_all() that can occur if kvm_mmu_zap_all() is invoked when the guest has live vCPUs. I.e. using kvm_mmu_zap_all() to handle the MMIO

[PATCH 00/11] KVM: x86/mmu: Restore fast invalidate/zap flow

2019-09-12 Thread Sean Christopherson
Restore the fast invalidate flow for zapping shadow pages and use it whenever vCPUs can be active in the VM. This fixes (in theory, not yet confirmed) a regression reported by James Harvey where KVM can livelock in kvm_mmu_zap_all() when it's invoked in response to a memslot update. The fast

[PATCH 02/11] KVM: x86/mmu: Treat invalid shadow pages as obsolete

2019-09-12 Thread Sean Christopherson
Treat invalid shadow pages as obsolete to fix a bug where an obsolete and invalid page with a non-zero root count could become non-obsolete due to mmu_valid_gen wrapping. The bug is largely theoretical with the current code base, as an unsigned long will effectively never wrap on 64-bit KVM, and

[PATCH 04/11] KVM: x86/mmu: Revert "Revert "KVM: MMU: show mmu_valid_gen in shadow page related tracepoints""

2019-09-12 Thread Sean Christopherson
Now that the fast invalidate mechanism has been reintroduced, restore tracing of the generation number in shadow page tracepoints. This reverts commit b59c4830ca185ba0e9f9e046fb1cd10a4a92627a. Signed-off-by: Sean Christopherson --- arch/x86/kvm/mmutrace.h | 21 - 1 file

[PATCH 11/11] KVM: x86/mmu: Skip invalid pages during zapping iff root_count is zero

2019-09-12 Thread Sean Christopherson
Do not skip invalid shadow pages when zapping obsolete pages if the pages' root_count has reached zero, in which case the page can be immediately zapped and freed. Update the comment accordingly. Signed-off-by: Sean Christopherson --- arch/x86/kvm/mmu.c | 9 + 1 file changed, 5

[PATCH 06/11] KVM: x86/mmu: Revert "Revert "KVM: MMU: zap pages in batch""

2019-09-12 Thread Sean Christopherson
Now that the fast invalidate mechanism has been reintroduced, restore the performance tweaks for fast invalidation that existed prior to its removal. Paraphrashing the original changelog: Zap at least 10 shadow pages before releasing mmu_lock to reduce the overhead associated with

[PATCH 08/11] KVM: x86/mmu: Revert "Revert "KVM: MMU: reclaim the zapped-obsolete page first""

2019-09-12 Thread Sean Christopherson
Now that the fast invalidate mechanism has been reintroduced, restore the performance tweaks for fast invalidation that existed prior to its removal. Paraphrashing the original changelog: Introduce a per-VM list to track obsolete shadow pages, i.e. pages which have been deleted from the mmu

[PATCH 05/11] KVM: x86/mmu: Revert "Revert "KVM: MMU: add tracepoint for kvm_mmu_invalidate_all_pages""

2019-09-12 Thread Sean Christopherson
Now that the fast invalidate mechanism has been reintroduced, restore the tracepoint associated with said mechanism. Note, the name of the tracepoint deviates from the original tracepoint so as to match KVM's current nomenclature. This reverts commit 42560fb1f3c6c7f730897b7fa7a478bc37e0be50.

[PATCH 01/11] KVM: x86/mmu: Reintroduce fast invalidate/zap for flushing memslot

2019-09-12 Thread Sean Christopherson
Reintroduce the fast invalidate mechanism and use it when zapping shadow pages in response to a memslot being deleted/moved. Using the fast mechanism fixes a livelock reported by James Harvey that was introduced by commit d012a06ab1d23 ("Revert "KVM: x86/mmu: Zap only the relevant pages when

[PATCH 09/11] KVM: x86/mmu: Revert "KVM: x86/mmu: Remove is_obsolete() call"

2019-09-12 Thread Sean Christopherson
Now that the fast invalidate mechanism has been reintroduced, restore the performance tweaks for fast invalidation that existed prior to its removal. Paraphrasing the original changelog (commit 5ff0568374ed2 was itself a partial revert): Don't force reloading the remote mmu when zapping an

Re: [PATCH] memcg, kmem: do not fail __GFP_NOFAIL charges

2019-09-12 Thread Shakeel Butt
On Wed, Sep 11, 2019 at 8:16 AM Michal Hocko wrote: > > On Wed 11-09-19 07:37:40, Andrew Morton wrote: > > On Wed, 11 Sep 2019 14:00:02 +0200 Michal Hocko wrote: > > > > > On Mon 09-09-19 13:22:45, Michal Hocko wrote: > > > > On Fri 06-09-19 11:24:55, Shakeel Butt wrote: > > > [...] > > > > > I

[PATCH 07/11] KVM: x86/mmu: Revert "Revert "KVM: MMU: collapse TLB flushes when zap all pages""

2019-09-12 Thread Sean Christopherson
Now that the fast invalidate mechanism has been reintroduced, restore the performance tweaks for fast invalidation that existed prior to its removal. Paraphrashing the original changelog: Reload the mmu on all vCPUs after updating the generation number so that obsolete pages are not used by

[PATCH 10/11] KVM: x86/mmu: Explicitly track only a single invalid mmu generation

2019-09-12 Thread Sean Christopherson
Toggle mmu_valid_gen between '0' and '1' instead of blindly incrementing the generation. Because slots_lock is held for the entire duration of zapping obsolete pages, it's impossible for there to be multiple invalid generations associated with shadow pages at any given time. Toggling between the

Re: [PATCH V3 2/5] input: keyboard: imx_sc: Add i.MX system controller key support

2019-09-12 Thread Dmitry Torokhov
Hi Anson, On Tue, Sep 03, 2019 at 05:36:37PM -0400, Anson Huang wrote: > i.MX8QXP is an ARMv8 SoC which has a Cortex-M4 system controller > inside, the system controller is in charge of controlling power, > clock and scu key etc.. > > Adds i.MX system controller key driver support, Linux kernel

Re: [PATCH] HID: hidraw: replace printk() with corresponding pr_xx() variant

2019-09-12 Thread Dmitry Torokhov
Hi Rishi, On Thu, Aug 22, 2019 at 10:13:52PM +0530, Rishi Gupta wrote: > This commit replaces direct invocations of printk with > their appropriate pr_info/warn() variant. > > Signed-off-by: Rishi Gupta > --- > drivers/hid/hidraw.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-)

[PATCH] clk: Make clk_bulk_get_all() return a valid "id"

2019-09-12 Thread Bjorn Andersson
The adreno driver expects the "id" field of the returned clk_bulk_data to be filled in with strings from the clock-names property. But due to the use of kmalloc_array() in of_clk_bulk_get_all() it receives a list of bogus pointers instead. Zero-initialize the "id" field and attempt to populate

Re: [PATCH v3] input: keyboard: snvs_pwrkey: Send key events for i.MX6 S, DL and Q

2019-09-12 Thread Dmitry Torokhov
Hi Robin, On Wed, Sep 04, 2019 at 06:23:29AM +, Robin van der Gracht wrote: > The first generation i.MX6 processors does not send an interrupt when the > power key is pressed. It sends a power down request interrupt if the key is > released before a hard shutdown (5 second press). This should

[PATCH v5 1/2] drivers: hv: vmbus: Introduce latency testing

2019-09-12 Thread Branden Bonaby
Introduce user specified latency in the packet reception path By exposing the test parameters as part of the debugfs channel attributes. We will control the testing state via these attributes. Signed-off-by: Branden Bonaby --- changes in v5: - As per Stephen's suggestion, Moved

[PATCH v5 2/2] tools: hv: add vmbus testing tool

2019-09-12 Thread Branden Bonaby
This is a userspace tool to drive the testing. Currently it supports introducing user specified delay in the host to guest communication path on a per-channel basis. Signed-off-by: Branden Bonaby --- Changes in v4: - Based on Harrys comments, made the tool more user friendly and added more

[PATCH v5 0/2] hv: vmbus: add fuzz testing to hv device

2019-09-12 Thread Branden Bonaby
This patchset introduces a testing framework for Hyper-V drivers. This framework allows us to introduce delays in the packet receive path on a per-device basis. While the current code only supports introducing arbitrary delays in the host/guest communication path, we intend to expand this to

Re: [Ksummit-discuss] [PATCH v2 3/3] libnvdimm, MAINTAINERS: Maintainer Entry Profile

2019-09-12 Thread Aneesh Kumar K.V
On 9/12/19 12:13 AM, Dan Carpenter wrote: On Wed, Sep 11, 2019 at 08:48:59AM -0700, Dan Williams wrote: +Coding Style Addendum +- +libnvdimm expects multi-line statements to be double indented. I.e. + +if (x... +&& ...y) { That looks

Re: [PATCH v5 2/9] documention: leds: Add multicolor class documentation

2019-09-12 Thread Dan Murphy
Hello Pavel Thanks for looking at this again On 9/12/19 3:55 PM, Pavel Machek wrote: Hi! +Directory Layout Example + +root:/sys/class/leds/rgb:grouped_leds# ls -lR colors/ +colors/: +drwxr-xr-x2 root root 0 Jun 28 20:21 blue +drwxr-xr-x2 root

Re: [PATCH 2/3] powperc/mm: read TLB Block Invalidate Characteristics

2019-09-12 Thread Aneesh Kumar K.V
On 9/13/19 12:56 AM, Laurent Dufour wrote: Le 12/09/2019 à 16:44, Aneesh Kumar K.V a écrit : Laurent Dufour writes: + +    idx = 2; +    while (idx < len) { +    unsigned int block_size = local_buffer[idx++]; +    unsigned int npsize; + +    if (!block_size) +    break;

[PATCH v2] KVM: x86: Handle unexpected MMIO accesses using master abort semantics

2019-09-12 Thread Sean Christopherson
Use master abort semantics, i.e. reads return all ones and writes are dropped, to handle unexpected MMIO accesses when reading guest memory instead of returning X86EMUL_IO_NEEDED, which in turn gets interpreted as a guest page fault. Emulation of certain instructions, notably VMX instructions,

Re: [PATCH] KVM: x86: Handle unexpected MMIO accesses using master abort semantics

2019-09-12 Thread Sean Christopherson
On Thu, Sep 12, 2019 at 04:56:03PM -0700, Sean Christopherson wrote: > Use master abort semantics, i.e. reads return all ones and writes are > dropped, to handle unexpected MMIO accesses when reading guest memory > instead of returning X86EMUL_IO_NEEDED, which in turn gets interpreted > as a guest

Re: [PATCH 0/5] hugetlbfs: Disable PMD sharing for large systems

2019-09-12 Thread Dave Chinner
On Wed, Sep 11, 2019 at 04:05:32PM +0100, Waiman Long wrote: > A customer with large SMP systems (up to 16 sockets) with application > that uses large amount of static hugepages (~500-1500GB) are experiencing > random multisecond delays. These delays was caused by the long time it > took to scan

Re: problem starting /sbin/init (32-bit 5.3-rc8)

2019-09-12 Thread Kees Cook
On Thu, Sep 12, 2019 at 05:16:02PM -0700, Kees Cook wrote: > On Thu, Sep 12, 2019 at 02:40:19PM -0700, Randy Dunlap wrote: > > This is 32-bit kernel, just happens to be running on a 64-bit laptop. > > I added the debug printk in __phys_addr() just before "[cut here]". > > > >

[RFC V1 0/7] Add support for a new IMS interrupt mechanism

2019-09-12 Thread Megha Dey
Currently, MSI (Message signaled interrupts) and MSI-X are the de facto standard for device interrupt mechanism. MSI-X supports up to 2048 interrupts per device while MSI supports 32, which seems more than enough for current devices. However, the introduction of SIOV (Scalable IO virtualization)

[RFC V1 4/7] irq_remapping: New interfaces to support IMS irqdomain

2019-09-12 Thread Megha Dey
Introduce new interfaces for interrupt remapping drivers to support IMS irqdomains: irq_remapping_get_ims_irq_domain(): get the IMS irqdomain for an IRQ allocation. We must build one IMS irqdomain for each interrupt remapping unit. The driver calls this interface to get the IMS irqdomain

[RFC V1 3/7] x86/ims: Add support for a new IMS irq domain

2019-09-12 Thread Megha Dey
This patch adds support for the creation of a new IMS irq domain. It creates a new irq_chip associated with the IMS domain and adds the necessary domain operations to it. Cc: Jacob Pan Signed-off-by: Sanjay Kumar Signed-off-by: Megha Dey --- arch/x86/include/asm/msi.h | 4 ++

[RFC V1 5/7] x86/ims: Introduce x86_ims_ops

2019-09-12 Thread Megha Dey
This patch introduces an x86 specific indirect mechanism to setup the interrupt message storage. The IMS specific functions (setup, teardown, restore) become function pointers in an x86_ims_ops struct, that defaults to their implementations in ims.c and ims-msi.c. Cc: Jacob Pan Signed-off-by:

[RFC V1 2/7] drivers/base: Introduce callbacks for IMS interrupt domain

2019-09-12 Thread Megha Dey
This patch serves as a preparatory patch to introduce a new IMS (Interrupt Message Store) domain. It consists of APIs which would be used as callbacks to the IRQ chip associated with the IMS domain. The APIs introduced in this patch are: dev_ims_mask_irq - Generic irq chip callback to mask IMS

[RFC V1 7/7] ims: Add the set_desc callback

2019-09-12 Thread Megha Dey
Add the set_desc callback to the ims domain ops. The set_desc callback is used to find a unique hwirq number from a given domain. Each mdev can have a maximum of 2048 IMS interrupts. Cc: Jacob Pan Signed-off-by: Sanjay Kumar Signed-off-by: Megha Dey --- arch/x86/kernel/apic/ims.c | 7

[RFC V1 1/7] genirq/msi: Differentiate between various MSI based interrupts

2019-09-12 Thread Megha Dey
Since a device can support both MSI-X and IMS interrupts simultaneously, do away with is_msix and introduce a new enum msi_desc_tag to differentiate between the various types of msi_descs. Signed-off-by: Megha Dey --- arch/mips/pci/msi-xlp.c| 2 +- arch/s390/pci/pci_irq.c| 2 +-

[RFC V1 6/7] ims-msi: Add APIs to allocate/free IMS interrupts

2019-09-12 Thread Megha Dey
This patch introduces APIs to allocate and free IMS interrupts. Cc: Jacob Pan Signed-off-by: Sanjay Kumar Signed-off-by: Megha Dey --- drivers/base/ims-msi.c | 216 + include/linux/msi.h| 2 + 2 files changed, 218 insertions(+) diff --git

Re: [PATCH] leds: remove PAGE_SIZE limit of /sys/class/leds//trigger

2019-09-12 Thread Akinobu Mita
2019年9月13日(金) 2:15 Jacek Anaszewski : > > Hi Akinobu, > > Please bump patch version each time you send an update > of the patch with the same subject. Oops, should I resend with the correct subject?

Re: problem starting /sbin/init (32-bit 5.3-rc8)

2019-09-12 Thread Kees Cook
On Thu, Sep 12, 2019 at 02:40:19PM -0700, Randy Dunlap wrote: > This is 32-bit kernel, just happens to be running on a 64-bit laptop. > I added the debug printk in __phys_addr() just before "[cut here]". > > CONFIG_HARDENED_USERCOPY=y I can reproduce this under CONFIG_DEBUG_VIRTUAL=y, and it

Re: [alsa-devel] [PATCH] ASoC: fsl_sai: Implement set_bclk_ratio

2019-09-12 Thread Nicolin Chen
On Wed, Sep 11, 2019 at 04:06:41PM +0300, Daniel Baluta wrote: > On Wed, Sep 11, 2019 at 2:01 PM Mark Brown wrote: > > > > On Thu, Sep 05, 2019 at 06:29:39PM -0700, Nicolin Chen wrote: > > > On Sat, Aug 31, 2019 at 12:59:10AM +0300, Daniel Baluta wrote: > > > > > > This is to allow machine

[PATCH] KVM: x86: Handle unexpected MMIO accesses using master abort semantics

2019-09-12 Thread Sean Christopherson
Use master abort semantics, i.e. reads return all ones and writes are dropped, to handle unexpected MMIO accesses when reading guest memory instead of returning X86EMUL_IO_NEEDED, which in turn gets interpreted as a guest page fault. Emulation of certain instructions, notably VMX instructions,

Re: [PATCH] ASoC: fsl_sai: Implement set_bclk_ratio

2019-09-12 Thread Nicolin Chen
On Sat, Aug 31, 2019 at 12:59:10AM +0300, Daniel Baluta wrote: > From: Viorel Suman > > This is to allow machine drivers to set a certain bitclk rate > which might not be exactly rate * frame size. > > Cc: NXP Linux Team > Signed-off-by: Viorel Suman > Signed-off-by: Daniel Baluta Acked-by:

Re: [PATCH 3/3] ASoC: fsl_asrc: Fix error with S24_3LE format bitstream in i.MX8

2019-09-12 Thread Nicolin Chen
On Wed, Sep 11, 2019 at 12:08:07PM +0100, Mark Brown wrote: > On Mon, Sep 09, 2019 at 06:52:13PM -0700, Nicolin Chen wrote: > > > And a quick feeling is that below code is mostly identical to what > > is in the soc-generic-dmaengine-pcm.c file. So I'm wondering if we > > could abstract a helper

Re: [PATCH 2/3] ASoC: fsl_asrc: update supported sample format

2019-09-12 Thread Nicolin Chen
On Tue, Sep 10, 2019 at 02:07:25AM +, S.j. Wang wrote: > > On Mon, Sep 09, 2019 at 06:33:20PM -0400, Shengjiu Wang wrote: > > > The ASRC support 24bit/16bit/8bit input width, so S20_3LE format > > > should not be supported, it is word width is 20bit. > > > > I thought 3LE used 24-bit physical

Re: [PATCH] KVM: x86: work around leak of uninitialized stack contents

2019-09-12 Thread Sean Christopherson
On Thu, Sep 12, 2019 at 02:20:09PM -0700, Jim Mattson wrote: > On Wed, Sep 11, 2019 at 9:18 PM Fuqian Huang wrote: > > > > Emulation of VMPTRST can incorrectly inject a page fault > > when passed an operand that points to an MMIO address. > > The page fault will use uninitialized kernel stack

Re: [rfc patch script] treewide conversion of __section(foo) to section("foo");

2019-09-12 Thread Joe Perches
On Thu, 2019-09-12 at 15:45 -0700, Nick Desaulniers wrote: > If you want to email me just the patch file (so I don't have to > copy+pasta from an email), Lazy... ;) > I'd be happy to apply it and compile+boot test a few more arch's > than x86. Thanks. attached. section.pl Description: Perl

Memory corruption (redzone overwritten) names_cache?

2019-09-12 Thread Jakub Jankowski
Hi, We're getting some random memory corruption on an AWS EC2 instance with 4.19.x kernels. I've tried 4.19.19, 4.19.52, but the results below are from the most recent (4.19.72). For debugging I enabled KASAN+slub_debug, but TBH, I can't make heads or tails from these. Without slub_debug,

clang-format and 'clang-format on' and 'clang-format off'

2019-09-12 Thread Joe Perches
On Thu, 2019-09-12 at 23:58 +0200, Miguel Ojeda wrote: > On Thu, Sep 12, 2019 at 11:08 PM Joe Perches wrote: > > Marking sections _no_auto_format_ isn't really a > > good solution is it? > > I am thinking about special tables that are hand-crafted or very > complex macros. For those, yes, I

Re: [EXT] Re: [PATCH 1/3] ASoC: fsl_asrc: Use in(out)put_format instead of in(out)put_word_width

2019-09-12 Thread Nicolin Chen
On Tue, Sep 10, 2019 at 02:22:06AM +, S.j. Wang wrote: > Hi > > > > > On Mon, Sep 09, 2019 at 06:33:19PM -0400, Shengjiu Wang wrote: > > > snd_pcm_format_t is more formal than enum asrc_word_width, which > > has > > > two property, width and physical width, which is more accurate than > > >

Re: [PATCH 1/3] ASoC: fsl_asrc: Use in(out)put_format instead of in(out)put_word_width

2019-09-12 Thread Nicolin Chen
On Mon, Sep 09, 2019 at 06:33:19PM -0400, Shengjiu Wang wrote: > snd_pcm_format_t is more formal than enum asrc_word_width, which has > two property, width and physical width, which is more accurate than > enum asrc_word_width. So it is better to use in(out)put_format > instead of

[PATCH] mm: memory: fix /proc/meminfo reporting for MLOCK_ONFAULT

2019-09-12 Thread Lucian Adrian Grijincu
As pages are faulted in MLOCK_ONFAULT correctly updates /proc/self/smaps, but doesn't update /proc/meminfo's Mlocked field. - Before this /proc/meminfo fields didn't change as pages were faulted in: ``` = Start = /proc/meminfo Unevictable: 10128 kB Mlocked: 10132 kB = Creating

Re: [RFC PATCH v3 00/16] Core scheduling v3

2019-09-12 Thread Aubrey Li
On Thu, Sep 12, 2019 at 8:04 PM Aaron Lu wrote: > > On Wed, Sep 11, 2019 at 09:19:02AM -0700, Tim Chen wrote: > > On 9/11/19 7:02 AM, Aaron Lu wrote: > > I think Julien's result show that my patches did not do as well as > > your patches for fairness. Aubrey did some other testing with the same >

RE: [PATCH] scsi: storvsc: Add the support of hibernation

2019-09-12 Thread Dexuan Cui
> From: linux-scsi-ow...@vger.kernel.org > On Behalf Of kbuild test robot > Sent: Thursday, September 12, 2019 1:54 PM > To: Dexuan Cui > Cc: kbuild-...@01.org; KY Srinivasan ; Haiyang Zhang > ; Stephen Hemminger > ; sas...@kernel.org; j...@linux.ibm.com; > martin.peter...@oracle.com;

Re: [PATCH 00/13] nvdimm: Use more common kernel coding style

2019-09-12 Thread Joe Perches
On Thu, 2019-09-12 at 16:00 -0700, Nick Desaulniers wrote: > Consider the fact that not all kernel developers run checkpatch.pl. > Is that a deficiency in checkpatch.pl, or the lack of enforcement in > kernel developers' workflows? No. Mostly it's because the kernel is like a bunch of little

Re: [PATCH 00/13] nvdimm: Use more common kernel coding style

2019-09-12 Thread Nick Desaulniers
On Thu, Sep 12, 2019 at 3:38 PM Joe Perches wrote: > > On Thu, 2019-09-12 at 23:58 +0200, Miguel Ojeda wrote: > > On Thu, Sep 12, 2019 at 11:08 PM Joe Perches wrote: > > > Please name the major projects and then point to their > > > .clang-format equivalents. > > > > > > Also note the

Re: [PATCH 00/13] nvdimm: Use more common kernel coding style

2019-09-12 Thread Nick Desaulniers
On Thu, Sep 12, 2019 at 2:58 PM Miguel Ojeda wrote: > > On Thu, Sep 12, 2019 at 11:08 PM Joe Perches wrote: > > > > Please name the major projects and then point to their > > .clang-format equivalents. > > > > Also note the size/scope/complexity of the major projects. > > Mozilla, WebKit, LLVM

Re: [PATCH] watchdog: f71808e_wdt: Add F81803 support

2019-09-12 Thread Jaret Cantu
On 9/12/19 2:50 PM, Guenter Roeck wrote: On Thu, Sep 12, 2019 at 01:55:50PM -0400, Jaret Cantu wrote: This adds watchdog support for the Fintek F81803 Super I/O chip. Testing was done on the Seneca XK-QUAD. Signed-off-by: Jaret Cantu Since there is no datasheet, we can only hope that this

Re: [rfc patch script] treewide conversion of __section(foo) to section("foo");

2019-09-12 Thread Nick Desaulniers
On Sun, Sep 8, 2019 at 9:21 PM Joe Perches wrote: > So running the script: > > $ perl section.pl > > produces a commit > --- > From 04e52f34fd4ee7008ea5bf0d8896bf8d1fdf9f3f Mon Sep 17 00:00:00 2001 > Message-Id: > <04e52f34fd4ee7008ea5bf0d8896bf8d1fdf9f3f.1568001863.git@perches.com> > From:

Re: [PATCH 00/13] nvdimm: Use more common kernel coding style

2019-09-12 Thread Joe Perches
On Thu, 2019-09-12 at 23:58 +0200, Miguel Ojeda wrote: > On Thu, Sep 12, 2019 at 11:08 PM Joe Perches wrote: > > Please name the major projects and then point to their > > .clang-format equivalents. > > > > Also note the size/scope/complexity of the major projects. > > Mozilla, WebKit, LLVM and

Re: [RFC] ARM: dts: omap36xx: Enable thermal throttling

2019-09-12 Thread Daniel Lezcano
Hi Adam, On 12/09/2019 23:19, Adam Ford wrote: > On Thu, Sep 12, 2019 at 4:12 PM Daniel Lezcano > wrote: >> >> On 12/09/2019 20:30, Adam Ford wrote: >>> The thermal sensor in the omap3 family isn't accurate, but it's >>> better than nothing. The various OPP's enabled for the omap3630 >>>

Re: [PATCH v3 0/6] make use of gcc 9's "asm inline()"

2019-09-12 Thread Miguel Ojeda
On Fri, Sep 13, 2019 at 12:19 AM Rasmus Villemoes wrote: > > Patch 1 has already been picked up by Greg in staging-next, it's > included here for completeness. I don't know how to route the rest, or > if they should simply wait for 5.5 given how close we are to the merge > window for 5.4. If you

[PATCH v3 4/6] compiler-types.h: add asm_inline definition

2019-09-12 Thread Rasmus Villemoes
This adds an asm_inline macro which expands to "asm inline" [1] when the compiler supports it. This is currently gcc 9.1+, gcc 8.3 and (once released) gcc 7.5 [2]. It expands to just "asm" for other compilers. Using asm inline("foo") instead of asm("foo") overrules gcc's heuristic estimate of the

[PATCH v3 3/6] compiler_types.h: don't #define __inline

2019-09-12 Thread Rasmus Villemoes
The spellings __inline and __inline__ should be reserved for uses where one really wants to refer to the inline keyword, regardless of whether or not the spelling "inline" has been #defined to something else. Due to use of __inline__ in uapi headers, we can't easily get rid of the definition of

Re: [PATCH RT v3 4/5] rcu: Disable use_softirq on PREEMPT_RT

2019-09-12 Thread Joel Fernandes
On Thu, Sep 12, 2019 at 05:38:43PM -0400, Joel Fernandes wrote: > Hi Scott, > > Would you mind CC'ing r...@vger.kernel.org on RCU related patches? I added it > for this time. > > On Wed, Sep 11, 2019 at 05:57:28PM +0100, Scott Wood wrote: > > Besides restoring behavior that used to be default on

[PATCH v3 6/6] x86: bug.h: use asm_inline in _BUG_FLAGS definitions

2019-09-12 Thread Rasmus Villemoes
This helps preventing a BUG* or WARN* in some static inline from preventing that (or one of its callers) being inlined, so should allow gcc to make better informed inlining decisions. For example, with gcc 9.2, tcp_fastopen_no_cookie() vanishes from net/ipv4/tcp_fastopen.o. It does not itself

[PATCH v3 2/6] lib/zstd/mem.h: replace __inline by inline

2019-09-12 Thread Rasmus Villemoes
Currently, compiler_types.h #defines __inline as inline (and further #defines inline to automatically attach some attributes), so this does not change functionality. It serves as preparation for removing the #define of __inline. While at it, also remove the __attribute__((unused)) - it's already

[PATCH v3 5/6] x86: alternative.h: use asm_inline for all alternative variants

2019-09-12 Thread Rasmus Villemoes
Most, if not all, uses of the alternative* family just provide one or two instructions in .text, but the string literal can be quite large, causing gcc to overestimate the size of the generated code. That in turn affects its decisions about inlining of the function containing the alternative() asm

[PATCH v3 1/6] staging: rtl8723bs: replace __inline by inline

2019-09-12 Thread Rasmus Villemoes
Currently, __inline is #defined as inline in compiler_types.h, so this should not change functionality. It is preparation for removing said #define. While at it, change some "inline static" to the customary "static inline" order. Signed-off-by: Rasmus Villemoes ---

[PATCH v3 0/6] make use of gcc 9's "asm inline()"

2019-09-12 Thread Rasmus Villemoes
gcc 9+ (and gcc 8.3, 7.5) provides a way to override the otherwise crude heuristic that gcc uses to estimate the size of the code represented by an asm() statement. From the gcc docs If you use 'asm inline' instead of just 'asm', then for inlining purposes the size of the asm is taken as the

Re: [PATCH RT v3 5/5] rcutorture: Avoid problematic critical section nesting on RT

2019-09-12 Thread Joel Fernandes
On Wed, Sep 11, 2019 at 05:57:29PM +0100, Scott Wood wrote: > rcutorture was generating some nesting scenarios that are not > reasonable. Constrain the state selection to avoid them. > > Example #1: > > 1. preempt_disable() > 2. local_bh_disable() > 3. preempt_enable() > 4. local_bh_enable() >

Re: [PATCH 00/13] nvdimm: Use more common kernel coding style

2019-09-12 Thread Joe Perches
On Thu, 2019-09-12 at 23:58 +0200, Miguel Ojeda wrote: > On Thu, Sep 12, 2019 at 11:08 PM Joe Perches wrote: > > Please name the major projects and then point to their > > .clang-format equivalents. > > > > Also note the size/scope/complexity of the major projects. > > Mozilla, WebKit, LLVM and

Re: [PATCH] sched: fix migration to invalid cpu in __set_cpus_allowed_ptr

2019-09-12 Thread Valentin Schneider
On 12/09/2019 02:55, shikemeng wrote: > From 089dbf0216628ac6ae98742ab90725ca9c2bf201 Mon Sep 17 00:00:00 2001 > From: > Date: Tue, 10 Sep 2019 09:44:58 -0400 > Subject: [PATCH] sched: fix migration to invalid cpu in __set_cpus_allowed_ptr > > reason: migration to invalid cpu in

Re: [PATCH RT v3 1/5] rcu: Acquire RCU lock when disabling BHs

2019-09-12 Thread Joel Fernandes
On Wed, Sep 11, 2019 at 05:57:25PM +0100, Scott Wood wrote: > A plain local_bh_disable() is documented as creating an RCU critical > section, and (at least) rcutorture expects this to be the case. However, > in_softirq() doesn't block a grace period on PREEMPT_RT, since RCU checks >

Re: [PATCH v2 1/4] mm: correct mask size for slub page->objects

2019-09-12 Thread Kirill A. Shutemov
On Thu, Sep 12, 2019 at 03:11:14PM -0600, Yu Zhao wrote: > On Thu, Sep 12, 2019 at 12:40:35PM +0300, Kirill A. Shutemov wrote: > > On Wed, Sep 11, 2019 at 08:31:08PM -0600, Yu Zhao wrote: > > > Mask of slub objects per page shouldn't be larger than what > > > page->objects can hold. > > > > > >

Re: [PATCH] bpf: validate bpf_func when BPF_JIT is enabled

2019-09-12 Thread Sami Tolvanen
On Thu, Sep 12, 2019 at 3:52 AM Toke Høiland-Jørgensen wrote: > I think it would be good if you do both. I'm a bit worried that XDP > performance will end up in a "death by a thousand paper cuts" situation, > so I'd rather push back on even relatively small overheads like this; so > being able to

Re: Documentation for plain accesses and data races

2019-09-12 Thread Paul E. McKenney
On Fri, Sep 06, 2019 at 02:11:29PM -0400, Alan Stern wrote: > Folks: > > I have spent some time writing up a section for > tools/memory-model/Documentation/explanation.txt on plain accesses and > data races. The initial version is below. > > I'm afraid it's rather long and perhaps gets too

Re: [PATCH 00/13] nvdimm: Use more common kernel coding style

2019-09-12 Thread Miguel Ojeda
On Thu, Sep 12, 2019 at 11:08 PM Joe Perches wrote: > > Please name the major projects and then point to their > .clang-format equivalents. > > Also note the size/scope/complexity of the major projects. Mozilla, WebKit, LLVM and Microsoft. They have their style distributed with the official

[PATCH v2] dt-bindings: iio: accel: add binding documentation for ADIS16240

2019-09-12 Thread Rodrigo Carvalho
This patch add device tree binding documentation for ADIS16240. Signed-off-by: Rodrigo Ribeiro Carvalho --- V2: - Remove true constant for spi-cpha and spi-cpol - Add description field for spi-cpha and spi-cpol - Add maxItems field for spi-cpha and spi-cpol

problem starting /sbin/init (32-bit 5.3-rc8)

2019-09-12 Thread Randy Dunlap
This is 32-bit kernel, just happens to be running on a 64-bit laptop. I added the debug printk in __phys_addr() just before "[cut here]". CONFIG_HARDENED_USERCOPY=y The BUG is this line in arch/x86/mm/physaddr.c: VIRTUAL_BUG_ON((phys_addr >> PAGE_SHIFT) > max_low_pfn); It's line

[PATCH] irqchip/sifive-plic: add irq_mask and irq_unmask

2019-09-12 Thread Darius Rad
As per the existing comment, irq_mask and irq_unmask do not need to do anything for the PLIC. However, the functions must exist (the pointers cannot be NULL) as they are not optional, based on the documentation (Documentation/core-api/genericirq.rst) as well as existing usage (e.g.,

Re: [PATCH RT v3 4/5] rcu: Disable use_softirq on PREEMPT_RT

2019-09-12 Thread Joel Fernandes
Hi Scott, Would you mind CC'ing r...@vger.kernel.org on RCU related patches? I added it for this time. On Wed, Sep 11, 2019 at 05:57:28PM +0100, Scott Wood wrote: > Besides restoring behavior that used to be default on RT, this avoids > a deadlock on scheduler locks: > > [ 136.894657] 039:

[PATCH 2/3] fs/userfaultfd.c: reorder the if check to reduce some computation

2019-09-12 Thread Wei Yang
When there are several condition check in *if* clause, the check will stop at the first false one. Since the for loop iterates vma list, we are sure only the last vma meets the condition "end <= vm_end". Reorder the check sequence to reduce some computation. Signed-off-by: Wei Yang ---

[PATCH 3/3] fs/userfaultfd.c: wrap cheching huge page alignment into a helper

2019-09-12 Thread Wei Yang
There are three places checking whether one address is huge page aligned. This patch just makes a helper function to wrap it up. Signed-off-by: Wei Yang --- fs/userfaultfd.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/fs/userfaultfd.c

Re: [PATCH RESEND] fs/epoll: fix the edge-triggered mode for nested epoll

2019-09-12 Thread Jason Baron
On 9/11/19 4:19 AM, Heiher wrote: > Hi, > > On Fri, Sep 6, 2019 at 1:48 AM Jason Baron wrote: >> >> >> >> On 9/5/19 1:27 PM, Roman Penyaev wrote: >>> On 2019-09-05 11:56, Heiher wrote: Hi, On Thu, Sep 5, 2019 at 10:53 AM Heiher wrote: > > Hi, > > I created an

Re: [PATCH] firmware: broadcom: add OP-TEE based BNXT f/w manager

2019-09-12 Thread Ard Biesheuvel
(+ Jens) Please make sure you have the right people on cc. Instead of Ingo, Thomas or linux-mips (?), you might have cc'ed the OP-TEE maintainer yourself? On Tue, 10 Sep 2019 at 16:17, Sheetal Tigadoli wrote: > > From: Vikas Gupta > > This driver registers on TEE bus to interact with OP-TEE

  1   2   3   4   5   6   7   >