Re: [PATCH] ARM: aspeed: ast2500 is ARMv6K

2019-09-19 Thread Andrew Jeffery
On Thu, 19 Sep 2019, at 23:56, Arnd Bergmann wrote: > Linux supports both the original ARMv6 level (early ARM1136) and ARMv6K > (later ARM1136, ARM1176 and ARM11mpcore). > > ast2500 falls into the second categoy, being based on arm1176jzf-s. > This is enabled by default when using

Re: [PATCH] ARM: aspeed: ast2500 is ARMv6K

2019-09-19 Thread Joel Stanley
On Thu, 19 Sep 2019 at 14:27, Arnd Bergmann wrote: > > Linux supports both the original ARMv6 level (early ARM1136) and ARMv6K > (later ARM1136, ARM1176 and ARM11mpcore). > > ast2500 falls into the second categoy, being based on arm1176jzf-s. > This is enabled by default when using ARCH_MULTI_V6,

Re: drivers/crypto/inside-secure/safexcel.c:840:9: error: implicit declaration of function 'pci_irq_vector'; did you mean 'rcu_irq_enter'?

2019-09-19 Thread Yuehaibing
Herbert, This has been fixed in below patch, but I can't find it in linux-next. https://patchwork.kernel.org/patch/11129983/ On 2019/9/20 9:03, kbuild test robot wrote: > Hi Pascal, > > FYI, the error/warning still remains. > > tree: >

[PATCH 2/5] net: ethernet: stmmac: fix warning when w=1 option is used during build

2019-09-19 Thread Christophe Roullier
This patch fix the following warning: warning: variable ‘ret’ set but not used [-Wunused-but-set-variable] int val, ret; Signed-off-by: Christophe Roullier --- drivers/net/ethernet/stmicro/stmmac/dwmac-stm32.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH 4/5] ARM: dts: stm32: adjust slew rate for Ethernet

2019-09-19 Thread Christophe Roullier
ETH_MDIO slew-rate should be set to "0" instead of "2" Signed-off-by: Christophe Roullier --- arch/arm/boot/dts/stm32mp157-pinctrl.dtsi | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/stm32mp157-pinctrl.dtsi

[PATCH 0/5] net: ethernet: stmmac: some fixes and optimization

2019-09-19 Thread Christophe Roullier
Some improvements (manage syscfg as optional clock, update slew rate of ETH_MDIO pin, Enable gating of the MAC TX clock during TX low-power mode) Fix warning build message when W=1 Christophe Roullier (5): net: ethernet: stmmac: Add support for syscfg clock net: ethernet: stmmac: fix warning

[PATCH 3/5] ARM: dts: stm32: remove syscfg clock on stm32mp157c ethernet

2019-09-19 Thread Christophe Roullier
Syscfg is now activated automatically when syscfg registers are used Signed-off-by: Christophe Roullier --- arch/arm/boot/dts/stm32mp157c.dtsi | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/arch/arm/boot/dts/stm32mp157c.dtsi b/arch/arm/boot/dts/stm32mp157c.dtsi index

[PATCH 5/5] ARM: dts: stm32: Enable gating of the MAC TX clock during TX low-power mode on stm32mp157c

2019-09-19 Thread Christophe Roullier
When there is no activity on ethernet phy link, the ETH_GTX_CLK is cut Signed-off-by: Christophe Roullier --- arch/arm/boot/dts/stm32mp157c.dtsi | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/stm32mp157c.dtsi b/arch/arm/boot/dts/stm32mp157c.dtsi index

[PATCH 1/5] net: ethernet: stmmac: Add support for syscfg clock

2019-09-19 Thread Christophe Roullier
Add optional support for syscfg clock in dwmac-stm32.c Now Syscfg clock is activated automatically when syscfg registers are used Signed-off-by: Christophe Roullier --- .../net/ethernet/stmicro/stmmac/dwmac-stm32.c | 36 +-- 1 file changed, 25 insertions(+), 11 deletions(-)

[PATCH v2 5/5] leds: lm3692x: Use flags from LM3692X_BRT_CTRL

2019-09-19 Thread Guido Günther
Use LM3692X_RAMP_EN instead of LM3692X_PWM_HYSTER_4LSB since the later is a flag for the PWM register. The actual register value remains unchanged. Signed-off-by: Guido Günther Reviewed-by: Dan Murphy Acked-by: Pavel Machek --- drivers/leds/leds-lm3692x.c | 2 +- 1 file changed, 1

[PATCH v2 3/5] leds: lm3692x: Handle failure to probe the regulator

2019-09-19 Thread Guido Günther
Instead use devm_regulator_get_optional since the regulator is optional and check for errors. Signed-off-by: Guido Günther Acked-by: Pavel Machek --- drivers/leds/leds-lm3692x.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/leds/leds-lm3692x.c

[PATCH v2 1/5] leds: lm3692x: Print error value on dev_err

2019-09-19 Thread Guido Günther
This gives a way better idea what is going on. Signed-off-by: Guido Günther Reviewed-by: Dan Murphy Acked-by: Pavel Machek --- drivers/leds/leds-lm3692x.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/drivers/leds/leds-lm3692x.c

[PATCH v2 0/5] leds: lm3692x: Probing and flag fixes

2019-09-19 Thread Guido Günther
The driver currently returns success on init although probing fails and register setup uses flag values from other registers which is confusing when reading the driver. This series cleans this up. Changes from v1: - Add reviewed by's from Dan Murphy, thanks!

[PATCH v2 2/5] leds: lm3692x: Don't overwrite return value in error path

2019-09-19 Thread Guido Günther
The driver currently reports successful initialization on every failure as long as it's able to power off the regulator. Don't check the return value of regulator_disable to avoid that. Signed-off-by: Guido Günther --- drivers/leds/leds-lm3692x.c | 7 --- 1 file changed, 4 insertions(+), 3

[PATCH v2 4/5] leds: lm3692x: Use flags from LM3692X_BOOST_CTRL

2019-09-19 Thread Guido Günther
The current setup of LM3692X_BOOST_CTRL uses flags from LM3692X_BRT_CTRL. Use flags from LM3692X_BOOST_CTRL but leave the resulting register value unchanged. Signed-off-by: Guido Günther Reviewed-by: Dan Murphy Acked-by: Pavel Machek --- drivers/leds/leds-lm3692x.c | 6 +++--- 1 file changed,

Re: [PATCH 17/23] mtd: spi-nor: Fix clearing of QE bit on lock()/unlock()

2019-09-19 Thread Tudor.Ambarus
Hi, Vignesh, On 09/19/2019 05:33 PM, Vignesh Raghavendra wrote: > External E-Mail > > > Hi Tudor > > [...] > > On 17-Sep-19 9:25 PM, tudor.amba...@microchip.com wrote: >> +static int spi_nor_write_16bit_sr_and_check(struct spi_nor *nor, u8 >> status_new, >> +

Re: [RFC {net,iproute2}-next 0/2] Introduce an eBPF hookpoint for tx queue selection in the XPS (Transmit Packet Steering) code.

2019-09-19 Thread Matt Cover
On Thu, Sep 19, 2019 at 7:45 PM Matt Cover wrote: > > On Thu, Sep 19, 2019 at 6:42 PM Jason Wang wrote: > > > > > > On 2019/9/20 上午8:05, Matt Cover wrote: > > > On Thu, Sep 19, 2019 at 3:45 PM Matthew Cover > > > wrote: > > >> WORK IN PROGRESS: > > >>* bpf program loading works! > > >>

[PATCH] qede: qede_fp: simplify a bit 'qede_rx_build_skb()'

2019-09-19 Thread Christophe JAILLET
Use 'skb_put_data()' instead of rewritting it. This improves readability. Signed-off-by: Christophe JAILLET --- drivers/net/ethernet/qlogic/qede/qede_fp.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/net/ethernet/qlogic/qede/qede_fp.c

Re: [PATCH v3 3/3] clk: qcom: Add Global Clock controller (GCC) driver for SC7180

2019-09-19 Thread Rajendra Nayak
On 9/20/2019 9:30 AM, Taniya Das wrote: Hi Rajendra, Please pick the patch in the series : https://patchwork.kernel.org/patch/11150013/ ah, right, not sure how I missed the PATCH 1/3 in the series. Sorry about the noise. On 9/19/2019 4:38 PM, Rajendra Nayak wrote: [].. +static

Re: [PATCH 19/23] mtd: spi-nor: Rework spansion(_no)_read_cr_quad_enable()

2019-09-19 Thread Tudor.Ambarus
On 09/19/2019 08:34 PM, Vignesh Raghavendra wrote: > > > On 17-Sep-19 9:25 PM, tudor.amba...@microchip.com wrote: >> From: Tudor Ambarus >> >> Merge: >> spansion_no_read_cr_quad_enable() >> spansion_read_cr_quad_enable() >> >> in spi_nor_sr2_bit1_quad_enable(). >> >> Avoid duplication of code

arch/mips/include/asm/octeon/cvmx-ipd.h:330:27: error: storage size of 'pip_sft_rst' isn't known

2019-09-19 Thread kbuild test robot
Hi Matthew, FYI, the error/warning still remains. tree: https://kernel.googlesource.com/pub/scm/linux/kernel/git/torvalds/linux.git master head: 574cc4539762561d96b456dbc0544d8898bd4c6e commit: 171a9bae68c72f2d1260c3825203760856e6793b staging/octeon: Allow test build on !MIPS date: 7

Re: [breakage] panic() does not halt arm64 systems under certain conditions

2019-09-19 Thread Jookia
On Tue, Sep 17, 2019 at 11:45:19AM +0100, Will Deacon wrote: > Hi, > > [Expanding CC list; original message is here: > > https://lore.kernel.org/linux-arm-kernel/BX1W47JXPMR8.58IYW53H6M5N@dragonstone/] > > On Mon, Sep 16, 2019 at 09:35:36PM -0400, Xogium wrote: > > On arm64 in some situations

Re: [RFC v4 3/3] vhost: introduce mdev based hardware backend

2019-09-19 Thread Tiwei Bie
On Tue, Sep 17, 2019 at 03:26:30PM +0800, Jason Wang wrote: > On 2019/9/17 上午9:02, Tiwei Bie wrote: > > diff --git a/drivers/vhost/mdev.c b/drivers/vhost/mdev.c > > new file mode 100644 > > index ..8c6597aff45e > > --- /dev/null > > +++ b/drivers/vhost/mdev.c > > @@ -0,0 +1,462 @@ > >

Re: [PATCH] rpmsg: glink: Fix channel memory leak

2019-09-19 Thread Bjorn Andersson
On Thu 19 Sep 03:05 PDT 2019, Srinivas Kandagatla wrote: > If we stop and start the dsp while channel is open then there is a leak > in the driver as the refcount is not accounted for the open. > > This patch checks if the channel is open while running cleanup code > and does an extra kref_put

Re: [PATCH V2 2/2] mm/pgtable/debug: Add test validating architecture page table helpers

2019-09-19 Thread Anshuman Khandual
On 09/18/2019 11:52 PM, Gerald Schaefer wrote: > On Wed, 18 Sep 2019 18:26:03 +0200 > Christophe Leroy wrote: > > [..] >> My suggestion was not to completely drop the #ifdef but to do like you >> did in pgd_clear_tests() for instance, ie to add the following test on >> top of the function:

Re: [PATCH 4.4 00/56] 4.4.194-stable review

2019-09-19 Thread kernelci.org bot
stable-rc/linux-4.4.y boot: 47 boots: 1 failed, 46 passed (v4.4.193-57-g7b679e1a966b) Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-4.4.y/kernel/v4.4.193-57-g7b679e1a966b/ Full Build Summary:

Re: [PATCH v3 3/3] clk: qcom: Add Global Clock controller (GCC) driver for SC7180

2019-09-19 Thread Taniya Das
Hi Rajendra, Please pick the patch in the series : https://patchwork.kernel.org/patch/11150013/ On 9/19/2019 4:38 PM, Rajendra Nayak wrote: [].. +static struct clk_rcg_dfs_data gcc_dfs_clocks[] = { +    DEFINE_RCG_DFS(gcc_qupv3_wrap0_s0_clk_src), +   

Re: [PATCH 5.2 000/124] 5.2.17-stable review

2019-09-19 Thread kernelci.org bot
stable-rc/linux-5.2.y boot: 72 boots: 0 failed, 71 passed with 1 conflict (v5.2.16-125-g690411952b3d) Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-5.2.y/kernel/v5.2.16-125-g690411952b3d/ Full Build Summary:

Re: [PATCH] ARM: aspeed: ast2500 is ARMv6K

2019-09-19 Thread Andrew Jeffery
On Thu, 19 Sep 2019, at 23:56, Arnd Bergmann wrote: > Linux supports both the original ARMv6 level (early ARM1136) and ARMv6K > (later ARM1136, ARM1176 and ARM11mpcore). > > ast2500 falls into the second categoy, being based on arm1176jzf-s. > This is enabled by default when using

[PATCH] x86/kdump: Fix 'kmem -s' reported an invalid freepointer when SME was active

2019-09-19 Thread Lianbo Jiang
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=204793 Kdump kernel will reuse the first 640k region because of some reasons, for example: the trampline and conventional PC system BIOS region may require to allocate memory in this area. Obviously, kdump kernel will also overwrite the first

RE: [EXT] [PATCH v3] serial: imx: adapt rx buffer and dma periods

2019-09-19 Thread Andy Duan
From: Philipp Puschmann Sent: Thursday, September 19, 2019 10:51 PM > Using only 4 DMA periods for UART RX is very few if we have a high frequency > of small transfers - like in our case using Bluetooth with many small packets > via UART - causing many dma transfers but in each only filling a

Re: [PATCH 4.19 00/79] 4.19.75-stable review

2019-09-19 Thread kernelci.org bot
stable-rc/linux-4.19.y boot: 68 boots: 0 failed, 68 passed (v4.19.74-80-g42a609acc1b2) Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-4.19.y/kernel/v4.19.74-80-g42a609acc1b2/ Full Build Summary:

Re: [GIT PULL] Kbuild updates for v5.4-rc1

2019-09-19 Thread Masahiro Yamada
Hi Linus, On Wed, Sep 18, 2019 at 3:48 AM Jessica Yu wrote: > > +++ Will Deacon [17/09/19 19:16 +0100]: > >Hi Jessica, > > > >On Tue, Sep 17, 2019 at 08:01:36PM +0200, Jessica Yu wrote: > >> Yikes, I did not catch Stephen Rothwell's email about pausing the > >> linux-next releases from Sept 5

Re: [PATCH] base: soc: Export soc_device_to_device API

2019-09-19 Thread Bjorn Andersson
On Thu 19 Sep 15:45 PDT 2019, Greg KH wrote: > On Thu, Sep 19, 2019 at 03:40:17PM -0700, Bjorn Andersson wrote: > > On Thu 19 Sep 15:25 PDT 2019, Greg KH wrote: > > > > > On Thu, Sep 19, 2019 at 03:14:56PM -0700, Bjorn Andersson wrote: > > > > On Thu 19 Sep 14:58 PDT 2019, Greg KH wrote: > > > >

Re: [PATCH 1/2] soc: ti: big cleanup of Kconfig file

2019-09-19 Thread Randy Dunlap
On 9/19/19 6:14 PM, santosh.shilim...@oracle.com wrote: > On 9/19/19 3:33 PM, Randy Dunlap wrote: >> From: Randy Dunlap >> >> Cleanup drivers/soc/ti/Kconfig: >> - delete duplicate words >> - end sentences with '.' >> - fix typos/spellos >> - Subsystem is one word >> - capitalize acronyms >> -

[PATCH v3 0/2] tcpm: AMS and Collision Avoidance

2019-09-19 Thread Kyle Tso
*** BLURB HERE *** Kyle Tso (2): usb: typec: tcpm: AMS and Collision Avoidance usb: typec: tcpm: AMS for PD2.0 drivers/usb/typec/tcpm/tcpm.c | 523 ++ include/linux/usb/pd.h| 1 + include/linux/usb/tcpm.h | 4 + 3 files changed, 468

[PATCH v3 2/2] usb: typec: tcpm: AMS for PD2.0

2019-09-19 Thread Kyle Tso
AMS is defined in PD2.0 as well. Remove the filter in tcpm_ams_start and change the CC for Collision Avoidance only if the negotiated revision is higher than PD2.0. Signed-off-by: Kyle Tso --- Changelog since v2: - N/A; This is the first version. drivers/usb/typec/tcpm/tcpm.c | 129

[PATCH v3 1/2] usb: typec: tcpm: AMS and Collision Avoidance

2019-09-19 Thread Kyle Tso
This patch provides the implementation of Collision Avoidance introduced in PD3.0. The start of each Atomic Message Sequence (AMS) initiated by the port will be denied if the current AMS is not interruptible. The Source port will set the CC to SinkTxNG if it is going to initiate an AMS, and

drivers/platform/x86/asus-wmi.c:464: undefined reference to `battery_hook_unregister'

2019-09-19 Thread kbuild test robot
Hi Kristian, FYI, the error/warning still remains. tree: https://kernel.googlesource.com/pub/scm/linux/kernel/git/torvalds/linux.git master head: 574cc4539762561d96b456dbc0544d8898bd4c6e commit: 7973353e92ee1e7ca3b2eb361a4b7cb66c92abee platform/x86: asus-wmi: Refactor charge threshold to

Re: [PATCH 4.14 00/59] 4.14.146-stable review

2019-09-19 Thread kernelci.org bot
stable-rc/linux-4.14.y boot: 65 boots: 0 failed, 65 passed (v4.14.145-60-g981030d9563c) Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-4.14.y/kernel/v4.14.145-60-g981030d9563c/ Full Build Summary:

Re: [PATCH 4.9 00/74] 4.9.194-stable review

2019-09-19 Thread kernelci.org bot
stable-rc/linux-4.9.y boot: 54 boots: 0 failed, 54 passed (v4.9.193-75-gfebb363e252b) Full Boot Summary: https://kernelci.org/boot/all/job/stable-rc/branch/linux-4.9.y/kernel/v4.9.193-75-gfebb363e252b/ Full Build Summary:

Re: [PATCH -next] PCI: tegra: Add missing include file

2019-09-19 Thread Vidya Sagar
On 9/20/2019 7:18 AM, YueHaibing wrote: Fix build error without CONFIG_PINCTRL drivers/pci/controller/dwc/pcie-tegra194.c: In function tegra_pcie_config_rp: drivers/pci/controller/dwc/pcie-tegra194.c:1394:8: error: implicit declaration of function pinctrl_pm_select_default_state; did you

Re: [PATCH] sched/fair: Speed-up energy-aware wake-ups

2019-09-19 Thread Pavan Kondeti
Hi Quentin, On Thu, Sep 12, 2019 at 11:44:04AM +0200, Quentin Perret wrote: > From: Quentin Perret > > EAS computes the energy impact of migrating a waking task when deciding > on which CPU it should run. However, the current approach is known to > have a high algorithmic complexity, which can

[PATCH] rtl8xxxu: prevent leaking urb

2019-09-19 Thread Navid Emamdoost
In rtl8xxxu_submit_int_urb if usb_submit_urb fails the allocated urb should be released. Signed-off-by: Navid Emamdoost --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c

Re: [PATCH] tty:vt: Add check the return value of kzalloc to avoid oops

2019-09-19 Thread Nicolas Pitre
On Thu, 19 Sep 2019, Greg KH wrote: > On Thu, Sep 19, 2019 at 05:18:15PM +0800, Xiaoming Ni wrote: > > Using kzalloc() to allocate memory in function con_init(), but not > > checking the return value, there is a risk of null pointer references > > oops. > > > > Signed-off-by: Xiaoming Ni > >

[PATCH] staging: rtl8192u: fix multiple memory leaks on error path

2019-09-19 Thread Navid Emamdoost
In rtl8192_tx on error handling path allocated urbs and also skb should be released. Signed-off-by: Navid Emamdoost --- drivers/staging/rtl8192u/r8192U_core.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8192u/r8192U_core.c

Re: [PATCH 1/1] powerpc: kvm: Reduce calls to get current->mm by storing the value locally

2019-09-19 Thread Leonardo Bras
Hello Paul, I sent this patch, but I have a question: On Thu, 2019-09-19 at 19:27 -0300, Leonardo Bras wrote: > Reduces the number of calls to get_current() in order to get the value of > current->mm by doing it once and storing the value, since it is not > supposed to change inside the same

Re: [PATCH v2 2/2] reset: Reset controller driver for Intel LGM SoC

2019-09-19 Thread Dilip Kota
Hi Martin, On 9/20/2019 3:51 AM, Martin Blumenstingl wrote: Hi Dilip, (sorry for the late reply) On Thu, Sep 12, 2019 at 8:38 AM Dilip Kota wrote: [...] The major difference between the vrx200 and lgm is: 1.) RCU in vrx200 is having multiple register regions wheres RCU in lgm has one single

Re: [RFC {net,iproute2}-next 0/2] Introduce an eBPF hookpoint for tx queue selection in the XPS (Transmit Packet Steering) code.

2019-09-19 Thread Matt Cover
On Thu, Sep 19, 2019 at 6:42 PM Jason Wang wrote: > > > On 2019/9/20 上午8:05, Matt Cover wrote: > > On Thu, Sep 19, 2019 at 3:45 PM Matthew Cover wrote: > >> WORK IN PROGRESS: > >>* bpf program loading works! > >>* txq steering via bpf program return code works! > >>* bpf program

[PATCH] can: gs_usb: prevent memory leak

2019-09-19 Thread Navid Emamdoost
In gs_can_open if usb_submit_urb fails the allocated urb should be released. Signed-off-by: Navid Emamdoost --- drivers/net/can/usb/gs_usb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/can/usb/gs_usb.c b/drivers/net/can/usb/gs_usb.c index bd6eb9967630..2f74f6704c12 100644

RE: [EXT] [PATCH v4 0/3] Fix UART DMA freezes for i.MX SOCs

2019-09-19 Thread Andy Duan
From: Philipp Puschmann Sent: Thursday, September 19, 2019 10:30 PM > For some years and since many kernel versions there are reports that RX > UART DMA channel stops working at one point. So far the usual workaround > was to disable RX DMA. This patches fix the underlying problem. > > When a

Re: [RFC v4 0/3] vhost: introduce mdev based hardware backend

2019-09-19 Thread Jason Wang
On 2019/9/20 上午10:16, Tiwei Bie wrote: On Fri, Sep 20, 2019 at 09:30:58AM +0800, Jason Wang wrote: On 2019/9/19 下午11:45, Tiwei Bie wrote: On Thu, Sep 19, 2019 at 09:08:11PM +0800, Jason Wang wrote: On 2019/9/18 下午10:32, Michael S. Tsirkin wrote: So I have some questions: 1) Compared to

[PATCH v3] HID: hidraw: replace printk() with corresponding pr_xx() variant

2019-09-19 Thread Rishi Gupta
This commit replaces direct invocations of printk with their appropriate pr_info/warn() variant. Signed-off-by: Rishi Gupta --- Changes in v3: * Use hid_warn() subsystem specific variant instead of pr_warn() drivers/hid/hidraw.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-)

RE: [PATCH] tty:vt: Add check the return value of kzalloc to avoid oops

2019-09-19 Thread Nixiaoming
On 2019/9/19 17:30, Greg KH wrote: > On Thu, Sep 19, 2019 at 05:18:15PM +0800, Xiaoming Ni wrote: >> Using kzalloc() to allocate memory in function con_init(), but not >> checking the return value, there is a risk of null pointer references >> oops. >> >> Signed-off-by: Xiaoming Ni > > We keep

[PATCH v6 3/3] mm: fix double page fault on arm64 if PTE_AF is cleared

2019-09-19 Thread Jia He
When we tested pmdk unit test [1] vmmalloc_fork TEST1 in arm64 guest, there will be a double page fault in __copy_from_user_inatomic of cow_user_page. Below call trace is from arm64 do_page_fault for debugging purpose [ 110.016195] Call trace: [ 110.016826] do_page_fault+0x5a4/0x690 [

[PATCH v6 1/3] arm64: cpufeature: introduce helper cpu_has_hw_af()

2019-09-19 Thread Jia He
We unconditionally set the HW_AFDBM capability and only enable it on CPUs which really have the feature. But sometimes we need to know whether this cpu has the capability of HW AF. So decouple AF from DBM by new helper cpu_has_hw_af(). Reported-by: kbuild test robot Suggested-by: Suzuki Poulose

[PATCH v6 0/3] fix double page fault on arm64

2019-09-19 Thread Jia He
When we tested pmdk unit test vmmalloc_fork TEST1 in arm64 guest, there will be a double page fault in __copy_from_user_inatomic of cow_user_page. As told by Catalin: "On arm64 without hardware Access Flag, copying from user will fail because the pte is old and cannot be marked young. So we

[PATCH v6 2/3] arm64: mm: implement arch_faults_on_old_pte() on arm64

2019-09-19 Thread Jia He
On arm64 without hardware Access Flag, copying fromuser will fail because the pte is old and cannot be marked young. So we always end up with zeroed page after fork() + CoW for pfn mappings. we don't always have a hardware-managed access flag on arm64. Hence implement arch_faults_on_old_pte on

Re: [RFC v4 0/3] vhost: introduce mdev based hardware backend

2019-09-19 Thread Tiwei Bie
On Fri, Sep 20, 2019 at 09:30:58AM +0800, Jason Wang wrote: > On 2019/9/19 下午11:45, Tiwei Bie wrote: > > On Thu, Sep 19, 2019 at 09:08:11PM +0800, Jason Wang wrote: > > > On 2019/9/18 下午10:32, Michael S. Tsirkin wrote: > > > > > > > So I have some questions: > > > > > > > > > > > > > > 1)

Re: [PATCH] x86/mm: fix return value of p[um]dp_set_access_flags

2019-09-19 Thread Wei Yang
On Thu, Sep 19, 2019 at 10:25:05AM -0700, Dave Hansen wrote: >On 9/19/19 1:25 AM, Wei Yang wrote: >> Function p[um]dp_set_access_flags is used with update_mmu_cache_p[um]d >> and the return value from p[um]dp_set_access_flags indicates whether it >> is necessary to do the cache update. > >If this

[GIT PULL] Hexagon arch maintainer change

2019-09-19 Thread Richard Kuo
Hi Linus, Please pull the following changes. I am leaving QuIC, and Brian Cain will be taking over maintainership of the Hexagon port. Thanks, Richard Kuo The following changes since commit 4d856f72c10ecb060868ed10ff1b1453943fc6c8: Linux 5.3 (2019-09-15 14:19:32 -0700) are available in

Re: [PATCH v2 1/1] powerpc/pseries/hotplug-memory.c: Change rc variable to bool

2019-09-19 Thread Leonardo Bras
Hello Michael, Any feedback on this patch? Best regards, On Fri, 2019-08-02 at 15:45 +0200, David Hildenbrand wrote: > On 02.08.19 15:39, Leonardo Bras wrote: > > Changes the return variable to bool (as the return value) and > > avoids doing a ternary operation before returning. > > > >

[PATCH -next] PCI: tegra: Add missing include file

2019-09-19 Thread YueHaibing
Fix build error without CONFIG_PINCTRL drivers/pci/controller/dwc/pcie-tegra194.c: In function tegra_pcie_config_rp: drivers/pci/controller/dwc/pcie-tegra194.c:1394:8: error: implicit declaration of function pinctrl_pm_select_default_state; did you mean prandom_seed_full_state?

[PATCH] staging: rtl8192u: release memory on error path

2019-09-19 Thread Navid Emamdoost
In rtl819xU_tx_cmd if usb_submit_urb fails the allocated memories should be released. Signed-off-by: Navid Emamdoost --- drivers/staging/rtl8192u/r8192U_core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c

Re: [RFC {net,iproute2}-next 0/2] Introduce an eBPF hookpoint for tx queue selection in the XPS (Transmit Packet Steering) code.

2019-09-19 Thread Jason Wang
On 2019/9/20 上午8:05, Matt Cover wrote: On Thu, Sep 19, 2019 at 3:45 PM Matthew Cover wrote: WORK IN PROGRESS: * bpf program loading works! * txq steering via bpf program return code works! * bpf program unloading not working. * bpf program attached query not working. This patch

Re: [PATCH] net/ncsi: Disable global multicast filter

2019-09-19 Thread Jakub Kicinski
On Thu, 12 Sep 2019 12:04:50 -0700, Vijay Khemka wrote: > Disabling multicast filtering from NCSI if it is supported. As it > should not filter any multicast packets. In current code, multicast > filter is enabled and with an exception of optional field supported > by device are disabled

Re: [RFC v4 0/3] vhost: introduce mdev based hardware backend

2019-09-19 Thread Jason Wang
On 2019/9/19 下午11:45, Tiwei Bie wrote: On Thu, Sep 19, 2019 at 09:08:11PM +0800, Jason Wang wrote: On 2019/9/18 下午10:32, Michael S. Tsirkin wrote: So I have some questions: 1) Compared to method 2, what's the advantage of creating a new vhost char device? I guess it's for keep the API

RE: [PATCH V2 1/2] clk: imx8mm: Move 1443X/1416X PLL clock structure to common place

2019-09-19 Thread Anson Huang
Gentle ping... > Subject: [PATCH V2 1/2] clk: imx8mm: Move 1443X/1416X PLL clock structure > to common place > > Many i.MX8M SoCs use same 1443X/1416X PLL, such as i.MX8MM, i.MX8MN > and later i.MX8M SoCs, moving these PLL definitions to pll14xx driver can > save a lot of duplicated code on each

[GIT PULL] tracing: Updates for 5.4

2019-09-19 Thread Steven Rostedt
Linus, Tracing updates: - Addition of multiprobes to kprobe and uprobe events Allows for more than one probe attached to the same location - Addition of adding immediates to probe parameters - Clean up of the recordmcount.c code. This brings us closer to merging recordmcount into

Re: [PATCH] devfreq: Make log message more explicit when devfreq device already exists

2019-09-19 Thread Chanwoo Choi
Hi, On 19. 9. 19. 오전 9:09, Matthias Kaehlcke wrote: > Before creating a new devfreq device devfreq_add_device() checks > if there is already a devfreq dev associated with the requesting > device (parent). If that's the case the function rejects to create > another devfreq dev for that parent and

Re: [PATCH 1/2] soc: ti: big cleanup of Kconfig file

2019-09-19 Thread santosh . shilimkar
On 9/19/19 3:33 PM, Randy Dunlap wrote: From: Randy Dunlap Cleanup drivers/soc/ti/Kconfig: - delete duplicate words - end sentences with '.' - fix typos/spellos - Subsystem is one word - capitalize acronyms - reflow lines to be <= 80 columns Fixes: 41f93af900a2 ("soc: ti: add Keystone

RE: [PATCH v5 3/3] mm: fix double page fault on arm64 if PTE_AF is cleared

2019-09-19 Thread Justin He (Arm Technology China)
Hi Catalin > -Original Message- > From: Catalin Marinas > Sent: 2019年9月20日 0:42 > To: Justin He (Arm Technology China) > Cc: Will Deacon ; Mark Rutland > ; James Morse ; Marc > Zyngier ; Matthew Wilcox ; Kirill A. > Shutemov ; linux-arm- > ker...@lists.infradead.org;

RE: [PATCH v5 1/3] arm64: cpufeature: introduce helper cpu_has_hw_af()

2019-09-19 Thread Justin He (Arm Technology China)
Hi Catalin > -Original Message- > From: Catalin Marinas > Sent: 2019年9月20日 0:37 > To: Justin He (Arm Technology China) > Cc: Will Deacon ; Mark Rutland > ; James Morse ; Marc > Zyngier ; Matthew Wilcox ; Kirill A. > Shutemov ; linux-arm- > ker...@lists.infradead.org;

Re: [PATCH v2] devfreq: Add tracepoint for frequency changes

2019-09-19 Thread Chanwoo Choi
Hi, On 19. 9. 20. 오전 2:44, Matthias Kaehlcke wrote: > Add a tracepoint for frequency changes of devfreq devices and > use it. > > Signed-off-by: Matthias Kaehlcke > --- > (sending v2 without much delay wrt v1, since the change in devfreq > probably isn't controversial, and I'll be offline a

drivers/crypto/inside-secure/safexcel.c:840:9: error: implicit declaration of function 'pci_irq_vector'; did you mean 'rcu_irq_enter'?

2019-09-19 Thread kbuild test robot
Hi Pascal, FYI, the error/warning still remains. tree: https://kernel.googlesource.com/pub/scm/linux/kernel/git/torvalds/linux.git master head: 574cc4539762561d96b456dbc0544d8898bd4c6e commit: 625f269a5a7a3643771320387e474bd0a61d9654 crypto: inside-secure - add support for PCI based FPGA

Re: [RFC v4 0/3] vhost: introduce mdev based hardware backend

2019-09-19 Thread Jason Wang
On 2019/9/19 下午11:45, Tiwei Bie wrote: On Thu, Sep 19, 2019 at 09:08:11PM +0800, Jason Wang wrote: On 2019/9/18 下午10:32, Michael S. Tsirkin wrote: So I have some questions: 1) Compared to method 2, what's the advantage of creating a new vhost char device? I guess it's for keep the API

[random] ec47a799bf: WARNING:at_drivers/char/random.c:#getrandom_wait

2019-09-19 Thread kernel test robot
ndom-waits-and-introduce-getrandom2/20190919-051815 in testcase: boot on test machine: qemu-system-x86_64 -enable-kvm -cpu SandyBridge -smp 2 -m 4G caused below changes (please refer to attached dmesg/kmsg for entire log

[PATCH v3 4/6] platform/x86: huawei-wmi: Add battery charging thresholds

2019-09-19 Thread Ayman Bagabas
Control battery charge thresholds through the battery API and driver's attributes. Setting battery charging thresholds can introduce a race condition with MACH-WX9 where two or more threads are trying to read/write values from/to EC memory. Signed-off-by: Ayman Bagabas ---

[PATCH v3 6/6] platform/x86: huawei-wmi: Add debugfs support

2019-09-19 Thread Ayman Bagabas
Add a debugfs interface that can be used to call the WMI management interface function if available. Signed-off-by: Ayman Bagabas --- drivers/platform/x86/huawei-wmi.c | 91 +++ 1 file changed, 91 insertions(+) diff --git a/drivers/platform/x86/huawei-wmi.c

[PATCH v3 2/6] platform/x86: huawei-wmi: Add quirks and module parameters

2019-09-19 Thread Ayman Bagabas
Introduce quirks and module parameters. 3 quirks are added: 1. Fixes reporting brightness keys twice since it's already handled by acpi-video. 2. Some models need a short delay when setting battery thresholds to prevent a race condition when two processes read/write. (will be used later) 3.

[PATCH v3 3/6] platform/x86: huawei-wmi: Implement huawei wmi management

2019-09-19 Thread Ayman Bagabas
Huawei Matebook laptops come with a WMI management interface that can control various aspects of the device. This interface is also found on the old Matebook X released in 2017. Use that to control the mic mute LED. Signed-off-by: Ayman Bagabas --- drivers/platform/x86/huawei-wmi.c | 217

[PATCH v3 5/6] platform/x86: huawei-wmi: Add fn-lock support

2019-09-19 Thread Ayman Bagabas
Huawei Matebook laptops uses Fn key and toggle to access F1-F12 keys. Along with that, there is this feature called fn-lock that inverts the behavior of this Fn key and the F1-F12 row. Signed-off-by: Ayman Bagabas --- drivers/platform/x86/huawei-wmi.c | 85 +++ 1

[PATCH v3 1/6] platform/x86: huawei-wmi: Move to platform driver

2019-09-19 Thread Ayman Bagabas
Move from WMI driver to platform driver. This move is necessary since the driver is no longer a hotkeys driver only. Platform driver makes it easier for users to access sysfs attributes under (i.e. /sys/devices/platform/huawei-wmi) compared to wmi driver. Use WMI device UID, AMW0 has a UID of

[PATCH v3 0/6] platform/x86: Huawei WMI laptop extras driver

2019-09-19 Thread Ayman Bagabas
Changes in v3: * Kconfig changes * Fix NULL cast to int warning. * Add ACPI_BATTERY as a dependency. Changes in v2: * Use battery charge control API. This patch series introduce changes to huawei-wmi driver that includes: * Move to platform driver * Implement driver quirks and parameters *

[PATCH] NFSv4: fix memory leak if nfs4_begin_drain_session fails

2019-09-19 Thread Navid Emamdoost
In nfs4_try_migration, if nfs4_begin_drain_session fails the allocated memory should be released. Signed-off-by: Navid Emamdoost --- fs/nfs/nfs4state.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/nfs/nfs4state.c b/fs/nfs/nfs4state.c index cad4e064b328..124649f12067

Re: [PATCH] ionic: remove useless return code

2019-09-19 Thread Jakub Kicinski
On Wed, 18 Sep 2019 13:46:34 -0700, Shannon Nelson wrote: > On 9/18/19 12:57 PM, Arnd Bergmann wrote: > > The debugfs function was apparently changed from returning an error code > > to a void return, but the return code left in place, causing a warning > > from clang: > > > >

Re: [PATCH] ionic: Remove unnecessary ternary operator in ionic_debugfs_add_ident

2019-09-19 Thread Jakub Kicinski
On Tue, 17 Sep 2019 16:26:16 -0700, Nathan Chancellor wrote: > clang warns: > > ../drivers/net/ethernet/pensando/ionic/ionic_debugfs.c:60:37: warning: > expression result unused [-Wunused-value] > ionic, _fops) ? 0 : -EOPNOTSUPP; >

Re: build_path_from_dentry_optional_prefix() may schedule from invalid context

2019-09-19 Thread Pavel Shilovsky
ср, 28 авг. 2019 г. в 22:02, Sergey Senozhatsky : > > Hello, > > Looking at commit "cifs: create a helper to find a writeable handle > by path name": > > ->open_file_lock scope is atomic context, while build_path_from_dentry() > can schedule - kmalloc(GFP_KERNEL) > >

Re: [RFC {net,iproute2}-next 0/2] Introduce an eBPF hookpoint for tx queue selection in the XPS (Transmit Packet Steering) code.

2019-09-19 Thread Matt Cover
On Thu, Sep 19, 2019 at 3:45 PM Matthew Cover wrote: > > WORK IN PROGRESS: > * bpf program loading works! > * txq steering via bpf program return code works! > * bpf program unloading not working. > * bpf program attached query not working. > > This patch set provides a bpf hookpoint with

Re: [PATCH 1/2] x86,sched: Add support for frequency invariance

2019-09-19 Thread Srinivas Pandruvada
On Tue, 2019-09-17 at 16:27 +0200, Giovanni Gherdovich wrote: > Hello Srinivas, > > On Fri, 2019-09-13 at 15:52 -0700, Srinivas Pandruvada wrote: > > On Mon, 2019-09-09 at 04:42 +0200, Giovanni Gherdovich wrote: > > > > ... > > > > > + > > > +/* > > > + * APERF/MPERF frequency ratio

Re: [PATCH V3 2/4] ASoC: fsl_asrc: update supported sample format

2019-09-19 Thread Nicolin Chen
On Thu, Sep 19, 2019 at 08:11:40PM +0800, Shengjiu Wang wrote: > The ASRC support 24bit/16bit/8bit input width, which is > data width, not slot width. > > For the S20_3LE format, the data with is 20bit, slot width > is 24bit, if we set ASRMCR1n.IWD to be 24bits, the result > is the volume is

Re: [PATCH RFC v4 1/1] random: WARN on large getrandom() waits and introduce getrandom2()

2019-09-19 Thread Alexander E. Patrakov
20.09.2019 03:23, Alexander E. Patrakov пишет: 20.09.2019 02:47, Linus Torvalds пишет: On Thu, Sep 19, 2019 at 1:45 PM Alexander E. Patrakov wrote: This already resembles in-kernel haveged (except that it doesn't credit entropy), and Willy Tarreau said "collect the small entropy where it is,

Re: [PATCH] base: soc: Export soc_device_to_device API

2019-09-19 Thread mnalajal
On 2019-09-19 15:45, Greg KH wrote: On Thu, Sep 19, 2019 at 03:40:17PM -0700, Bjorn Andersson wrote: On Thu 19 Sep 15:25 PDT 2019, Greg KH wrote: > On Thu, Sep 19, 2019 at 03:14:56PM -0700, Bjorn Andersson wrote: > > On Thu 19 Sep 14:58 PDT 2019, Greg KH wrote: > > > > > On Thu, Sep 19, 2019

Re: [git pull] drm tree for 5.4-rc1

2019-09-19 Thread Linus Torvalds
On Thu, Sep 19, 2019 at 12:09 PM Dave Airlie wrote: > > There are a few merge conflicts across the board, we have a shared > rerere cache which meant I hadn't noticed them until I avoided the > cache. > https://cgit.freedesktop.org/drm/drm/log/?h=drm-5.4-merge > contains what we've done, none of

Re: [RFC] mm: Proactive compaction

2019-09-19 Thread Nitin Gupta
On Tue, 2019-08-20 at 10:46 +0200, Vlastimil Babka wrote: > > This patch is largely based on ideas from Michal Hocko posted here: > > https://lore.kernel.org/linux-mm/20161230131412.gi13...@dhcp22.suse.cz/ > > > > Testing done (on x86): > > - Set

[for-next][PATCH 8/8] selftests/ftrace: Update kprobe event error testcase

2019-09-19 Thread Steven Rostedt
From: Masami Hiramatsu Update kprobe event error testcase to test if it correctly finds the exact same probe event. Link: http://lkml.kernel.org/r/156879695513.31056.1580235733738840126.stgit@devnote2 Signed-off-by: Masami Hiramatsu Signed-off-by: Steven Rostedt (VMware) ---

[for-next][PATCH 0/8] tracing: Final updates before sending to Linus

2019-09-19 Thread Steven Rostedt
git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace.git for-next Head SHA1: b78b94b82122208902c0f83805e614e1239f9893 Andy Shevchenko (1): tracing: Be more clever when dumping hex in __print_hex() Changbin Du (1): ftrace: Simplify ftrace hash lookup code in

[for-next][PATCH 6/8] tracing/probe: Fix to allow user to enable events on unloaded modules

2019-09-19 Thread Steven Rostedt
From: Masami Hiramatsu Fix to allow user to enable probe events on unloaded modules. This operations was allowed before commit 60d53e2c3b75 ("tracing/probe: Split trace_event related data from trace_probe"), because if users need to probe module init functions, they have to enable those probe

[for-next][PATCH 5/8] selftests/ftrace: Select an existing function in kprobe_eventname test

2019-09-19 Thread Steven Rostedt
From: "Steven Rostedt (VMware)" Running the ftrace selftests on the latest kernel caused the kprobe_eventname test to fail. It was due to the test that searches for a function with at "dot" in the name and adding a probe to that. Unfortunately, for this test, it picked:

[for-next][PATCH 4/8] tracing/kprobe: Fix NULL pointer access in trace_porbe_unlink()

2019-09-19 Thread Steven Rostedt
From: Masami Hiramatsu Fix NULL pointer access in trace_probe_unlink() by initializing trace_probe.list correctly in trace_probe_init(). In the error case of trace_probe_init(), it can call trace_probe_unlink() before initializing trace_probe.list member. This causes NULL pointer dereference at

  1   2   3   4   5   6   7   8   9   10   >