Re: [v2 PATCH] mm: thp: handle page cache THP correctly in PageTransCompoundMap

2019-10-23 Thread Yang Shi
On 10/23/19 12:28 PM, Hugh Dickins wrote: On Thu, 24 Oct 2019, Yang Shi wrote: We have usecase to use tmpfs as QEMU memory backend and we would like to take the advantage of THP as well. But, our test shows the EPT is not PMD mapped even though the underlying THP are PMD mapped on host.

Re: [PATCH 3/3] x86/ftrace: Use text_poke()

2019-10-23 Thread Alexei Starovoitov
On Wed, Oct 23, 2019 at 12:23:06PM -0400, Steven Rostedt wrote: > On Tue, 22 Oct 2019 14:58:43 -0700 > Alexei Starovoitov wrote: > > > Neither of two statements are true. The per-function generated trampoline > > I'm talking about is bpf specific. For a function with two arguments it's > >

Re: [PATCH] [netfilter]: Fix skb->csum calculation when netfilter manipulation for NF_NAT_MANIP_SRC\DST is done on IPV6 packet.

2019-10-23 Thread Florian Westphal
Praveen Chaudhary wrote: > Update skb->csum, when netfilter code updates IPV6 SRC\DST address in IPV6 > HEADER due to iptable rule. > > Signed-off-by: Praveen Chaudhary > Signed-off-by: Zhenggen Xu > Signed-off-by: Andy Stracner > --- > include/net/checksum.h | 2 ++ >

Re: [PATCH v2 4/4] jump_label,module: Fix module lifetime for __jump_label_mod_text_reserved

2019-10-23 Thread Steven Rostedt
On Mon, 07 Oct 2019 10:25:45 +0200 Peter Zijlstra wrote: > Nothing ensures the module exists while we're iterating > mod->jump_entries in __jump_label_mod_text_reserved(), take a module > reference to ensure the module sticks around. > > Signed-off-by: Peter Zijlstra (Intel) Reviewed-by:

[v3 PATCH] mm: thp: handle page cache THP correctly in PageTransCompoundMap

2019-10-23 Thread Yang Shi
We have usecase to use tmpfs as QEMU memory backend and we would like to take the advantage of THP as well. But, our test shows the EPT is not PMD mapped even though the underlying THP are PMD mapped on host. The number showed by /sys/kernel/debug/kvm/largepage is much less than the number of PMD

Re: [v2 PATCH] mm: thp: handle page cache THP correctly in PageTransCompoundMap

2019-10-23 Thread Hugh Dickins
On Thu, 24 Oct 2019, Yang Shi wrote: > We have usecase to use tmpfs as QEMU memory backend and we would like to > take the advantage of THP as well. But, our test shows the EPT is not > PMD mapped even though the underlying THP are PMD mapped on host. > The number showed by

Re: [PATCH] mm: gup: fix comment of __get_user_pages()

2019-10-23 Thread John Hubbard
On 10/23/19 6:51 AM, Liu Xiang wrote: > Because nr_pages is unsigned long, it can not be negative. > > Signed-off-by: Liu Xiang > --- > mm/gup.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/mm/gup.c b/mm/gup.c > index 8f236a3..0236954 100644 > --- a/mm/gup.c

Re: [PATCH v2 2/4] module: Fix up module_notifier return values.

2019-10-23 Thread Steven Rostedt
On Mon, 07 Oct 2019 10:25:43 +0200 Peter Zijlstra wrote: > kernel/trace/trace.c |2 +- > kernel/trace/trace_events.c|2 +- > kernel/trace/trace_printk.c|4 ++-- > kernel/tracepoint.c|2 +- Acked-by: Steven Rostedt (VMware) -- Steve

[PATCH] PCI/DPC: Add pcie_ports=dpc-native parameter to bring back old behavior

2019-10-23 Thread Olof Johansson
In commit eed85ff4c0da7 ("PCI/DPC: Enable DPC only if AER is available"), the behavior was changed such that native (kernel) handling of DPC got tied to whether the kernel also handled AER. While this is what the standard recommends, there are BIOSes out there that lack the DPC handling since it

Re: [PATCH 3/7] Add a UFFD_SECURE flag to the userfaultfd API.

2019-10-23 Thread Andy Lutomirski
On Wed, Oct 23, 2019 at 12:10 PM Andrea Arcangeli wrote: > > Hello, > > On Sat, Oct 12, 2019 at 06:14:23PM -0700, Andy Lutomirski wrote: > > [adding more people because this is going to be an ABI break, sigh] > > That wouldn't break the ABI, no more than when if you boot a kernel > built with

Re: [PATCH] x86/dumpstack/64: Don't evaluate exception stacks before setup

2019-10-23 Thread Josh Poimboeuf
On Wed, Oct 23, 2019 at 08:05:49PM +0200, Thomas Gleixner wrote: > Cyrill reported the following crash: > > BUG: unable to handle page fault for address: 1ff0 > #PF: supervisor read access in kernel mode > RIP: 0010:get_stack_info+0xb3/0x148 > > It turns out that if the stack

Re: [PATCH 2/3] usb, kcov: collect coverage from hub_event

2019-10-23 Thread kbuild test robot
Hi Andrey, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [cannot apply to v5.4-rc4 next-20191023] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify

Re: [PATCH 3/7] Add a UFFD_SECURE flag to the userfaultfd API.

2019-10-23 Thread Andrea Arcangeli
Hello, On Sat, Oct 12, 2019 at 06:14:23PM -0700, Andy Lutomirski wrote: > [adding more people because this is going to be an ABI break, sigh] That wouldn't break the ABI, no more than when if you boot a kernel built with CONFIG_USERFAULTFD=n. All non-cooperative features can be removed any time

Re: [PATCH] ASoC: fsl_asrc: refine the setting of internal clock divider

2019-10-23 Thread Nicolin Chen
On Wed, Oct 23, 2019 at 06:25:20AM +, S.j. Wang wrote: > > On Thu, Oct 17, 2019 at 02:21:08PM +0800, Shengjiu Wang wrote: > > > For P2P output, the output divider should align with the output sample > > > > I think we should avoid "P2P" (or "M2M") keyword in the mainline code as > > we know

Re: [PATCH resend] Add touchscreen platform data for the Schneider SCT101CTM tablet

2019-10-23 Thread Andy Shevchenko
On Wed, Oct 23, 2019 at 9:53 PM Hans de Goede wrote: > > From: Daniel Gorbea Ainz > > Add touchscreen platform data for the Schneider SCT101CTM tablet Thanks, now patchwork sees it. > Signed-off-by: Daniel Gorbea > Reviewed-by: Hans de Goede > Signed-off-by: Hans de Goede I'm not sure you

Re: [PATCH] Input: hp_sdc_rtc - remove dead chardev code

2019-10-23 Thread Helge Deller
On 23.10.19 17:22, Alexandre Belloni wrote: On 23/10/2019 16:25:02+0200, Arnd Bergmann wrote: The driver contains half of the implementation of /dev/rtc, but this was never completed, and it is now incompatible with the drivers/rtc framework. Remove the chardev completely. If anyone wants to

Re: [PATCH 3/3] power: supply: bq2515x: Introduce the bq2515x family

2019-10-23 Thread Dan Murphy
Sebastian On 10/20/19 7:15 AM, Sebastian Reichel wrote: Hi Dan, On Mon, Sep 30, 2019 at 09:31:37AM -0500, Dan Murphy wrote: [...] + +static int bq2515x_power_supply_register(struct bq2515x_device *bq2515x) +{ + struct power_supply_config psy_cfg = { .drv_data = bq2515x, }; + int

[PATCH] Fix skb->csum calculation when netfilter manipulation for NF_NAT_MANIP_SRC\DST is done on IPV6 packet.

2019-10-23 Thread Praveen Chaudhary
-Issue [BUG in current code]:- IPV6 UDP packet is dropped by kernel in function udp6_csum_init(), when netfilter for NF_NAT_MANIP_SRC\DST is applied. Counter increased: Udp6InCsumErrors. Note: incoming UPD6 packet has correct UDP checksum.

[PATCH] [netfilter]: Fix skb->csum calculation when netfilter manipulation for NF_NAT_MANIP_SRC\DST is done on IPV6 packet.

2019-10-23 Thread Praveen Chaudhary
Update skb->csum, when netfilter code updates IPV6 SRC\DST address in IPV6 HEADER due to iptable rule. Signed-off-by: Praveen Chaudhary Signed-off-by: Zhenggen Xu Signed-off-by: Andy Stracner --- include/net/checksum.h | 2 ++ net/core/utils.c | 13 +

Re: [v2 PATCH] mm: thp: handle page cache THP correctly in PageTransCompoundMap

2019-10-23 Thread Hugh Dickins
On Wed, 23 Oct 2019, Yang Shi wrote: > On 10/23/19 10:24 AM, Matthew Wilcox wrote: > > On Thu, Oct 24, 2019 at 01:05:04AM +0800, Yang Shi wrote: > > > + return map_count >= 0 && > > > +map_count == atomic_read([1].compound_mapcount); > > > } > > I didn't like Hugh's duplicate definition

Applied "regulator: bd70528: Add MODULE_ALIAS to allow module auto loading" to the regulator tree

2019-10-23 Thread Mark Brown
The patch regulator: bd70528: Add MODULE_ALIAS to allow module auto loading has been applied to the regulator tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-5.4 All being well this means that it will be integrated into the linux-next tree (usually

Applied "ASoC: rsnd: dma: fix SSI9 4/5/6/7 busif dma address" to the asoc tree

2019-10-23 Thread Mark Brown
The patch ASoC: rsnd: dma: fix SSI9 4/5/6/7 busif dma address has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.4 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24

Applied "ASoC: mediatek: Check SND_SOC_CROS_EC_CODEC dependency" to the asoc tree

2019-10-23 Thread Mark Brown
The patch ASoC: mediatek: Check SND_SOC_CROS_EC_CODEC dependency has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.5 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24

Applied "spi: document CS setup, hold & inactive times in header" to the spi tree

2019-10-23 Thread Mark Brown
The patch spi: document CS setup, hold & inactive times in header has been applied to the spi tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-5.5 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24

Applied "ASoC: rsnd: dma: set bus width to data width for monaural data" to the asoc tree

2019-10-23 Thread Mark Brown
The patch ASoC: rsnd: dma: set bus width to data width for monaural data has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.5 All being well this means that it will be integrated into the linux-next tree (usually sometime in the

Applied "ASoC: hdmi-codec: drop mutex locking again" to the asoc tree

2019-10-23 Thread Mark Brown
The patch ASoC: hdmi-codec: drop mutex locking again has been applied to the asoc tree at https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-5.4 All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and

Re: [PATCH] irqchip: Skip contexts other supervisor in plic_init()

2019-10-23 Thread Paul Walmsley
+ hch On Wed, 23 Oct 2019, Alan Mikhak wrote: > From: Alan Mikhak > > Modify plic_init() to skip .dts interrupt contexts other > than supervisor external interrupt. Might be good to explain the motivation here. > > Signed-off-by: Alan Mikhak > --- > drivers/irqchip/irq-sifive-plic.c | 4

[PATCH resend] Add touchscreen platform data for the Schneider SCT101CTM tablet

2019-10-23 Thread Hans de Goede
From: Daniel Gorbea Ainz Add touchscreen platform data for the Schneider SCT101CTM tablet Signed-off-by: Daniel Gorbea Reviewed-by: Hans de Goede Signed-off-by: Hans de Goede --- hdegoede: Resend from my email address as vger.kernel.org does not like Daniel's emails ---

Re: [PATCH v4 15/16] module: Move where we mark modules RO,X

2019-10-23 Thread Steven Rostedt
On Tue, 22 Oct 2019 22:24:01 +0200 Peter Zijlstra wrote: > On Mon, Oct 21, 2019 at 10:21:10PM -0400, Steven Rostedt wrote: > > On Fri, 18 Oct 2019 09:35:40 +0200 > > Peter Zijlstra wrote: > > > > > Now that set_all_modules_text_*() is gone, nothing depends on the > > > relation between

Re: [PATCH v1 5/6] KEYS: measure queued keys

2019-10-23 Thread Mimi Zohar
On Wed, 2019-10-23 at 13:52 -0400, Mimi Zohar wrote: > On Wed, 2019-10-23 at 10:34 -0700, Lakshmi Ramasubramanian wrote: > > On 10/23/19 6:23 AM, Mimi Zohar wrote: > > > > > The ordering of this patch set is awkward.  It should first introduce > > > a generic method for measuring keys based on

Re: [PATCH] ceph: Fix use-after-free in __ceph_remove_cap

2019-10-23 Thread Jeff Layton
On Mon, 2019-10-21 at 15:51 +0100, Luis Henriques wrote: > Jeff Layton writes: > > > On Thu, 2019-10-17 at 15:46 +0100, Luis Henriques wrote: > > > KASAN reports a use-after-free when running xfstest generic/531, with the > > > following trace: > > > > > > [ 293.903362] kasan_report+0xe/0x20

Re: [PATCH 1/2] Revert "ASoC: hdmi-codec: re-introduce mutex locking"

2019-10-23 Thread Mark Brown
On Wed, Oct 23, 2019 at 07:26:18PM +0100, Russell King - ARM Linux admin wrote: > If you look at the git log for reverted commits, the vast majority > of them follow _this_ style. From 5.3 back to the start of current > git history, there are 3665 commits with "Revert" in their subject > line,

Re: [PATCH 1/2] rtc/ia64: remove legacy efirtc driver

2019-10-23 Thread Luck, Tony
On Wed, Oct 23, 2019 at 05:01:58PM +0200, Arnd Bergmann wrote: > There are two EFI RTC drivers, the original drivers/char/efirtc.c > driver and the more modern drivers/rtc/rtc-efi.c. > > Both implement the same interface, but the new one does so > in a more portable way. > > Move everything over

Re: [PATCH] x86/dumpstack/64: Don't evaluate exception stacks before setup

2019-10-23 Thread Cyrill Gorcunov
On Wed, Oct 23, 2019 at 11:31:40AM -0700, Matthew Wilcox wrote: > On Wed, Oct 23, 2019 at 08:05:49PM +0200, Thomas Gleixner wrote: > > Prevent this by checking the validity of the cea_exception_stack base > > address and bailing out if it is zero. > > Could also initialise cea_exception_stack to

Re: [PATCH v2 0/1] Add support for setting MMIO PREF hotplug bridge size

2019-10-23 Thread Bjorn Helgaas
On Wed, Oct 23, 2019 at 12:12:08PM +, Nicholas Johnson wrote: > ... > It turns out Outlook is causing my encoding issues with git send-email. > > If I get a new email for kernel development, what should it be? Gmail > works, but looks tackier. I wish Documentation/process/email-clients.rst

Re: [PATCH] x86/dumpstack/64: Don't evaluate exception stacks before setup

2019-10-23 Thread Matthew Wilcox
On Wed, Oct 23, 2019 at 08:05:49PM +0200, Thomas Gleixner wrote: > Prevent this by checking the validity of the cea_exception_stack base > address and bailing out if it is zero. Could also initialise cea_exception_stack to -1? That would lead to it being caught by ... > end = begin +

Re: [PATCH] ASoC: fsl_esai: Add spin lock to protect reset and stop

2019-10-23 Thread Nicolin Chen
On Wed, Oct 23, 2019 at 03:29:49PM +0800, Shengjiu Wang wrote: > xrun may happen at the end of stream, the > trigger->fsl_esai_trigger_stop maybe called in the middle of > fsl_esai_hw_reset, this may cause esai in wrong state > after stop, and there may be endless xrun interrupt. What about

Re: [ipc/sem.c] 6394de3b86: BUG:kernel_NULL_pointer_dereference,address

2019-10-23 Thread Manfred Spraul
Hello, On 10/21/19 10:35 AM, kernel test robot wrote: FYI, we noticed the following commit (built with gcc-7): commit: 6394de3b868537a90dd9128607192b0e97109f6b ("[PATCH 4/5] ipc/sem.c: Document and update memory barriers") url:

Re: [PATCH 1/2] Revert "ASoC: hdmi-codec: re-introduce mutex locking"

2019-10-23 Thread Russell King - ARM Linux admin
On Wed, Oct 23, 2019 at 05:37:16PM +0100, Mark Brown wrote: > On Wed, Oct 23, 2019 at 06:12:02PM +0200, Jerome Brunet wrote: > > This reverts commit eb1ecadb7f67dde94ef0efd3ddaed5cb6c9a65ed. > > > > This fixes the following warning reported by lockdep and a potential > > issue with hibernation >

Re: [PATCH v2 2/2] RISC-V: defconfig: Enable Goldfish RTC driver

2019-10-23 Thread Paul Walmsley
On Wed, 23 Oct 2019, Alistair Francis wrote: > On Tue, 2019-10-22 at 18:06 -0700, Paul Walmsley wrote: > > On Tue, 22 Oct 2019, Alistair Francis wrote: > > > > > I think it makese sense for this to go into Linux first. > > > > > > The QEMU patches are going to be accepted, just some nit picking

Re: [PATCH 1/2] mm, vmstat: Release zone lock more frequently when reading /proc/pagetypeinfo

2019-10-23 Thread Waiman Long
On 10/23/19 2:01 PM, Michal Hocko wrote: > On Wed 23-10-19 13:34:22, Waiman Long wrote: >> With a threshold of 10, it is still possible that the zone lock >> will be held for a very long time in the worst case scenario where all >> the counts are just below the threshold. With up to 6

RE: [PATCH v2 net-next] net: axienet: In kconfig add ARM64 as supported platform

2019-10-23 Thread Radhey Shyam Pandey
> -Original Message- > From: Jakub Kicinski > Sent: Tuesday, October 22, 2019 11:00 PM > To: Michal Simek > Cc: Radhey Shyam Pandey ; da...@davemloft.net; > net...@vger.kernel.org; Anirudha Sarangi ; John Linn > ; mchehab+sams...@kernel.org; > gre...@linuxfoundation.org;

Re: [PATCH v1 6/6] KEYS: measure keys when they are created or updated

2019-10-23 Thread Mimi Zohar
On Tue, 2019-10-22 at 17:18 -0700, Lakshmi Ramasubramanian wrote: > diff --git a/security/security.c b/security/security.c > index 250ee2d76406..707a9e7fa94d 100644 > --- a/security/security.c > +++ b/security/security.c > @@ -2303,6 +2303,16 @@ int security_key_getsecurity(struct key *key, char

Re: [PATCH v2 4/9] perf affinity: Add infrastructure to save/restore affinity

2019-10-23 Thread Alexey Budankov
On 23.10.2019 20:19, Andi Kleen wrote: > On Wed, Oct 23, 2019 at 07:16:13PM +0300, Alexey Budankov wrote: >> >> On 23.10.2019 17:52, Andi Kleen wrote: >>> On Wed, Oct 23, 2019 at 04:30:49PM +0200, Jiri Olsa wrote: On Wed, Oct 23, 2019 at 06:02:35AM -0700, Andi Kleen wrote: > On Wed, Oct

Re: [PATCH 2/2] mm, vmstat: List total free blocks for each order in /proc/pagetypeinfo

2019-10-23 Thread Waiman Long
On 10/23/19 2:02 PM, Michal Hocko wrote: > On Wed 23-10-19 13:34:23, Waiman Long wrote: > [...] >> @@ -1419,6 +1419,17 @@ static void pagetypeinfo_showfree_print(struct >> seq_file *m, >> } >> seq_putc(m, '\n'); >> } >> + >> +/* >> + * List total free blocks

[PATCH] x86/dumpstack/64: Don't evaluate exception stacks before setup

2019-10-23 Thread Thomas Gleixner
Cyrill reported the following crash: BUG: unable to handle page fault for address: 1ff0 #PF: supervisor read access in kernel mode RIP: 0010:get_stack_info+0xb3/0x148 It turns out that if the stack tracer is invoked before the exception stack mappings are initialized

Re: [Outreachy kernel] [PATCH v2 0/5] Remove typedef declarations in staging: octeon

2019-10-23 Thread Wambui Karuga
On Wed, Oct 23, 2019 at 08:43:04PM +0300, Aaro Koskinen wrote: > Hi, > > On Sat, Oct 12, 2019 at 08:35:19PM +0200, Julia Lawall wrote: > > On Sat, 12 Oct 2019, Wambui Karuga wrote: > > > This patchset removes the addition of new typedefs data types in octeon, > > > along with replacing the

[GIT PULL v3] tracing: A couple of minor fixes

2019-10-23 Thread Steven Rostedt
Linus, [ Hopefully the change log of the last commit is good enough ] Two minor fixes: - A race in perf trace initialization (missing mutexes) - Minor fix to represent gfp_t in synthetic events as properly signed Please pull the latest trace-v5.4-rc3-3 tree, which can be found at:

Re: [PATCH 2/2] mm, vmstat: List total free blocks for each order in /proc/pagetypeinfo

2019-10-23 Thread Michal Hocko
On Wed 23-10-19 13:34:23, Waiman Long wrote: [...] > @@ -1419,6 +1419,17 @@ static void pagetypeinfo_showfree_print(struct > seq_file *m, > } > seq_putc(m, '\n'); > } > + > + /* > + * List total free blocks per order > + */ > + seq_printf(m,

Re: [PATCH 1/2] mm, vmstat: Release zone lock more frequently when reading /proc/pagetypeinfo

2019-10-23 Thread Michal Hocko
On Wed 23-10-19 13:34:22, Waiman Long wrote: > With a threshold of 10, it is still possible that the zone lock > will be held for a very long time in the worst case scenario where all > the counts are just below the threshold. With up to 6 migration types > and 11 orders, it means up to 6.6

Re: [PATCH net-next 4/4] bonding: balance ICMP echoes in layer3+4 mode

2019-10-23 Thread Simon Horman
On Wed, Oct 23, 2019 at 06:58:16PM +0200, Matteo Croce wrote: > On Wed, Oct 23, 2019 at 12:01 PM Simon Horman > wrote: > > > > On Mon, Oct 21, 2019 at 10:09:48PM +0200, Matteo Croce wrote: > > > The bonding uses the L4 ports to balance flows between slaves. > > > As the ICMP protocol has no

Re: [v2 PATCH] mm: thp: handle page cache THP correctly in PageTransCompoundMap

2019-10-23 Thread Yang Shi
On 10/23/19 10:24 AM, Matthew Wilcox wrote: On Thu, Oct 24, 2019 at 01:05:04AM +0800, Yang Shi wrote: + return map_count >= 0 && + map_count == atomic_read([1].compound_mapcount); } I didn't like Hugh's duplicate definition either. May I suggest: Thanks, Willy. It is

Re: [alsa-devel] [PATCH v2 4/5] soundwire: intel/cadence: add flag for interrupt enable

2019-10-23 Thread Pierre-Louis Bossart
On 10/21/19 11:55 PM, Vinod Koul wrote: On 21-10-19, 05:26, Pierre-Louis Bossart wrote: On 10/20/19 11:14 PM, Vinod Koul wrote: On 16-09-19, 14:09, Pierre-Louis Bossart wrote: Prepare for future PM support and fix error handling by disabling interrupts as needed. Signed-off-by:

[PATCH] powerpc/fadump: Remove duplicate message.

2019-10-23 Thread Michal Suchanek
There is duplicate message about lack of support by firmware in fadump_reserve_mem and setup_fadump. Due to different capitalization it is clear that the one in setup_fadump is shown on boot. Remove the duplicate that is not shown. Signed-off-by: Michal Suchanek --- arch/powerpc/kernel/fadump.c

Re: [PATCH 2/2] mm: memcontrol: try harder to set a new memory.high

2019-10-23 Thread Johannes Weiner
On Wed, Oct 23, 2019 at 08:59:49AM +0200, Michal Hocko wrote: > On Tue 22-10-19 16:15:18, Johannes Weiner wrote: > > Setting a memory.high limit below the usage makes almost no effort to > > shrink the cgroup to the new target size. > > > > While memory.high is a "soft" limit that isn't supposed

Re: [PATCH net-next 3/4] flow_dissector: extract more ICMP information

2019-10-23 Thread Simon Horman
On Wed, Oct 23, 2019 at 12:53:37PM +0200, Matteo Croce wrote: > On Wed, Oct 23, 2019 at 12:00 PM Simon Horman > wrote: > > On Mon, Oct 21, 2019 at 10:09:47PM +0200, Matteo Croce wrote: > > > + switch (ih->type) { > > > + case ICMP_ECHO: > > > + case ICMP_ECHOREPLY: > > > + case

Re: [PATCH v3 3/6] KVM: x86/vPMU: Rename pmu_ops callbacks from msr_idx to rdpmc_idx

2019-10-23 Thread Jim Mattson
On Tue, Oct 22, 2019 at 1:12 AM Like Xu wrote: > > The leagcy pmu_ops->msr_idx_to_pmc is only called in kvm_pmu_rdpmc, so > this name is restrictedly limited to rdpmc_idx which could be indexed > exactly to a kvm_pmc. Let's restrict its semantic by renaming the > existing msr_idx_to_pmc to

Re: [alsa-devel] [PATCH 0/2] ASoC: hdmi-codec: fix locking issue

2019-10-23 Thread Jerome Brunet
On Wed 23 Oct 2019 at 18:23, Takashi Iwai wrote: > On Wed, 23 Oct 2019 18:12:01 +0200, > Jerome Brunet wrote: >> >> This patchset fixes the locking issue reported by Russell. >> >> As explained a mutex was used as flag and held while returning to >> userspace. >> >> Patch 2 is entirely

Re: [PATCH v1 5/6] KEYS: measure queued keys

2019-10-23 Thread Mimi Zohar
On Wed, 2019-10-23 at 10:34 -0700, Lakshmi Ramasubramanian wrote: > On 10/23/19 6:23 AM, Mimi Zohar wrote: > > > The ordering of this patch set is awkward.  It should first introduce > > a generic method for measuring keys based on the keyring.  Then add > > the additional support needed for the

[PATCH v2 2/3] watchdog: jz4740: Use regmap provided by TCU driver

2019-10-23 Thread Paul Cercueil
Since we broke the ABI by changing the clock, the driver was also updated to use the regmap provided by the TCU driver. Signed-off-by: Paul Cercueil Tested-by: Mathieu Malaterre Tested-by: Artur Rojek Acked-by: Guenter Roeck --- Notes: v2: Rebase on top of 5.4-rc4

[PATCH v2 3/3] watchdog: jz4740: Drop dependency on MACH_JZ47xx

2019-10-23 Thread Paul Cercueil
Depending on MACH_JZ47xx prevent us from creating a generic kernel that works on more than one MIPS board. Instead, we just depend on MIPS being set. Signed-off-by: Paul Cercueil Acked-by: Guenter Roeck --- Notes: v2: Rebase on top of 5.4-rc4 drivers/watchdog/Kconfig | 2 +- 1 file

[PATCH v2 1/3] watchdog: jz4740: Use WDT clock provided by TCU driver

2019-10-23 Thread Paul Cercueil
Instead of requesting the "ext" clock and handling the watchdog clock divider and gating in the watchdog driver, we now request and use the "wdt" clock that is supplied by the ingenic-timer "TCU" driver. The major benefit is that the watchdog's clock rate and parent can now be specified from

Re: [PATCH] perf/core: fix multiplexing event scheduling issue

2019-10-23 Thread Stephane Eranian
On Wed, Oct 23, 2019 at 4:02 AM Peter Zijlstra wrote: > > On Wed, Oct 23, 2019 at 12:30:03AM -0700, Stephane Eranian wrote: > > On Mon, Oct 21, 2019 at 3:21 AM Peter Zijlstra wrote: > > > > > > On Thu, Oct 17, 2019 at 05:27:46PM -0700, Stephane Eranian wrote: > > > > This patch complements the

Re: [Outreachy kernel] [PATCH v2 0/5] Remove typedef declarations in staging: octeon

2019-10-23 Thread Aaro Koskinen
Hi, On Sat, Oct 12, 2019 at 08:35:19PM +0200, Julia Lawall wrote: > On Sat, 12 Oct 2019, Wambui Karuga wrote: > > This patchset removes the addition of new typedefs data types in octeon, > > along with replacing the previous uses with the new declaration format. > > > > v2 of the series removes

Re: [PATCH v2 2/2] RISC-V: defconfig: Enable Goldfish RTC driver

2019-10-23 Thread Alistair Francis
On Tue, 2019-10-22 at 18:06 -0700, Paul Walmsley wrote: > On Tue, 22 Oct 2019, Alistair Francis wrote: > > > I think it makese sense for this to go into Linux first. > > > > The QEMU patches are going to be accepted, just some nit picking to > > do > > first :) > > > > After that we have to

Re: [PATCH] ARM: dts: bcm: HR2: add label to sp805 watchdog

2019-10-23 Thread Florian Fainelli
On Wed, 23 Oct 2019 11:19:56 +1300, Chris Packham wrote: > This allows boards the option of adding properties or disabling the > watchdog entirely. > > Signed-off-by: Chris Packham > --- Applied to devicetree/next, thanks! -- Florian

Re: [PATCH 3/3] x86/ftrace: Use text_poke()

2019-10-23 Thread Steven Rostedt
On Wed, 23 Oct 2019 12:23:06 -0400 Steven Rostedt wrote: > All you need to do is: > > register_ftrace_direct((unsigned long)func_you_want_to_trace, > (unsigned long)your_trampoline); > > > Alexei, > > Would this work for you? I just pushed a test branch

Re: [PATCH] mm: memcontrol: fix network errors from failing __GFP_ATOMIC charges

2019-10-23 Thread Shakeel Butt
On Wed, Oct 23, 2019 at 8:46 AM Johannes Weiner wrote: > > On Wed, Oct 23, 2019 at 08:40:12AM +0200, Michal Hocko wrote: > > On Tue 22-10-19 19:37:08, Johannes Weiner wrote: > > > While upgrading from 4.16 to 5.2, we noticed these allocation errors > > > in the log of the new kernel: > > > > > >

Re: [PATCH] staging: octeon: Fix incorrect type in assignment

2019-10-23 Thread Aaro Koskinen
Hi, On Thu, Oct 10, 2019 at 07:38:15AM +0300, Wambui Karuga wrote: > Fix the following warning generated by sparse in > drivers/staging/octeon/ethernet-tx.c: > > drivers/staging/octeon/ethernet-tx.c:563:50: warning: incorrect type in > assignment (different base types) >

[PATCH 1/2] mm, vmstat: Release zone lock more frequently when reading /proc/pagetypeinfo

2019-10-23 Thread Waiman Long
With a threshold of 10, it is still possible that the zone lock will be held for a very long time in the worst case scenario where all the counts are just below the threshold. With up to 6 migration types and 11 orders, it means up to 6.6 millions. Track the total number of list iterations

Re: [PATCH] Add prctl support for controlling PF_MEMALLOC V2

2019-10-23 Thread Michal Hocko
On Wed 23-10-19 12:27:29, Mike Christie wrote: > On 10/23/2019 02:11 AM, Michal Hocko wrote: > > On Wed 23-10-19 07:43:44, Dave Chinner wrote: > >> On Tue, Oct 22, 2019 at 06:33:10PM +0200, Michal Hocko wrote: > > > > Thanks for more clarifiation regarding PF_LESS_THROTTLE. > > > > [...] > >>>

[PATCH 2/2] mm, vmstat: List total free blocks for each order in /proc/pagetypeinfo

2019-10-23 Thread Waiman Long
Now that the free block count for each migration types in /proc/pagetypeinfo may not show the exact count if it excceeds 100,000. Users may not know how much more the counts will be. As the free_area structure has already tracked the total free block count in nr_free, we may as well print it out

Re: [PATCH v1 5/6] KEYS: measure queued keys

2019-10-23 Thread Lakshmi Ramasubramanian
On 10/23/19 6:23 AM, Mimi Zohar wrote: The ordering of this patch set is awkward.  It should first introduce a generic method for measuring keys based on the keyring.  Then add the additional support needed for the specific builtin_trusted_keys keyring usecase. Would the following ordering of

[PATCH v1 0/1] rxe driver should dynamically caclculate inline data size

2019-10-23 Thread rao Shoaib
From: Rao Shoaib Resending because of typo in the email addresses. Currently rxe driver has a hard coded value for inline data size, where as mlx5 driver calculates the size of inline data and number of SGE's to use based on the values in the qp request. Some applications depend on this

[PATCH v1 1/1] rxe: calculate inline data size based on requested values

2019-10-23 Thread rao Shoaib
From: Rao Shoaib rxe driver has a hard coded value for the size of inline data, where as mlx5 driver calculates number of SGE's and inline data size based on the values in the qp request. This patch modifies rxe driver to do the same so that applications can work seamlessly across drivers.

Re: [PATCH] staging: octeon: Remove typedef declaration

2019-10-23 Thread Aaro Koskinen
Hi, On Tue, Oct 08, 2019 at 07:09:43AM +0300, Wambui Karuga wrote: > Fixes checkpatch.pl warning: do not add new typedefs in > drivers/staging/octeon/octeon-stubs.h:41 > > Signed-off-by: Wambui Karuga > --- > drivers/staging/octeon/octeon-stubs.h | 6 +++--- > 1 file changed, 3 insertions(+),

Re: [PATCH] ARM: dts: zynq: enablement of coresight topology

2019-10-23 Thread Mathieu Poirier
Hi Michal, I was not CC'ed on the original post so I just noticed this today, hence the late reply. I don't know if you were looking for feedback or already picked up the patch but here it is anyway. On Wed, 9 Oct 2019 at 08:07, Michal Simek wrote: > > From: Zumeng Chen > > This patch is to

Re: [v2 PATCH] mm: thp: handle page cache THP correctly in PageTransCompoundMap

2019-10-23 Thread Matthew Wilcox
On Thu, Oct 24, 2019 at 01:05:04AM +0800, Yang Shi wrote: > + return map_count >= 0 && > +map_count == atomic_read([1].compound_mapcount); > } I didn't like Hugh's duplicate definition either. May I suggest: diff --git a/include/linux/mm.h b/include/linux/mm.h index

Re: [PATCH 4.4 4.9 4.14] loop: Add LOOP_SET_DIRECT_IO to compat ioctl

2019-10-23 Thread Alessio Balsini
Ops, please forgive the wrong in-reply-to messge id :) Cheers, Alessio On Wed, Oct 23, 2019 at 06:17:36PM +0100, Alessio Balsini wrote: > [ Upstream commit fdbe4eeeb1aac219b14f10c0ed31ae5d1123e9b8 ] > > Enabling Direct I/O with loop devices helps reducing memory usage by > avoiding double

Re: [PATCH 1/3] kcov: remote coverage support

2019-10-23 Thread kbuild test robot
Hi Andrey, Thank you for the patch! Yet something to improve: [auto build test ERROR on linus/master] [cannot apply to v5.4-rc4 next-20191023] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system. BTW, we also suggest to use '--base' option to specify

Re: [PATCH bpf-next v2] libbpf: Fix strncat bounds error in libbpf_prog_type_by_name

2019-10-23 Thread Alexei Starovoitov
On Wed, Oct 23, 2019 at 8:40 AM KP Singh wrote: > > From: KP Singh > > On compiling samples with this change, one gets an error: > > error: ‘strncat’ specified bound 118 equals destination size > [-Werror=stringop-truncation] > > strncat(dst, name + section_names[i].len, >

Re: [PATCH v2 4/9] perf affinity: Add infrastructure to save/restore affinity

2019-10-23 Thread Andi Kleen
On Wed, Oct 23, 2019 at 07:16:13PM +0300, Alexey Budankov wrote: > > On 23.10.2019 17:52, Andi Kleen wrote: > > On Wed, Oct 23, 2019 at 04:30:49PM +0200, Jiri Olsa wrote: > >> On Wed, Oct 23, 2019 at 06:02:35AM -0700, Andi Kleen wrote: > >>> On Wed, Oct 23, 2019 at 11:59:11AM +0200, Jiri Olsa

[PATCH 4.4 4.9 4.14] loop: Add LOOP_SET_DIRECT_IO to compat ioctl

2019-10-23 Thread Alessio Balsini
[ Upstream commit fdbe4eeeb1aac219b14f10c0ed31ae5d1123e9b8 ] Enabling Direct I/O with loop devices helps reducing memory usage by avoiding double caching. 32 bit applications running on 64 bits systems are currently not able to request direct I/O because is missing from the lo_compat_ioctl.

Re: [PATCH v4 15/16] module: Move where we mark modules RO,X

2019-10-23 Thread Josh Poimboeuf
On Wed, Oct 23, 2019 at 05:16:54PM +0200, Peter Zijlstra wrote: > @@ -157,6 +158,14 @@ static int __apply_relocate_add(Elf64_Sh > > val = sym->st_value + rel[i].r_addend; > > + /* > + * .klp.rela.* sections should only contain module > + *

Re: [PATCH 3/7] Add a UFFD_SECURE flag to the userfaultfd API.

2019-10-23 Thread Andy Lutomirski
On Wed, Oct 23, 2019 at 5:44 AM Mike Rapoport wrote: > > On Wed, Oct 23, 2019 at 10:29:20AM +0300, Cyrill Gorcunov wrote: > > On Tue, Oct 22, 2019 at 09:11:04PM -0700, Andy Lutomirski wrote: > > > Trying again. It looks like I used the wrong address for Pavel. > > > > Thanks for CC Andy! I must

Re: [RFC 1/2] vhost: IFC VF hardware operation layer

2019-10-23 Thread Simon Horman
On Wed, Oct 23, 2019 at 06:36:13PM +0800, Jason Wang wrote: > > On 2019/10/23 下午6:13, Simon Horman wrote: > > On Tue, Oct 22, 2019 at 09:32:36AM +0800, Jason Wang wrote: > > > On 2019/10/22 上午12:31, Simon Horman wrote: > > > > On Mon, Oct 21, 2019 at 05:55:33PM +0800, Zhu, Lingshan wrote: > > > >

Re: [PATCH] PCI: Warn about host bridge device when its numa node is NO_NODE

2019-10-23 Thread Bjorn Helgaas
On Wed, Oct 23, 2019 at 04:22:43PM +0800, Yunsheng Lin wrote: > On 2019/10/23 5:04, Bjorn Helgaas wrote: > > On Sat, Oct 19, 2019 at 02:45:43PM +0800, Yunsheng Lin wrote: > > I think the underlying problem you're addressing is that: > > > > - NUMA_NO_NODE == -1, > > - dev_to_node(dev) may

Re: [PATCH v2 6/6] crypto: caam - populate platform devices last

2019-10-23 Thread Horia Geanta
On 10/22/2019 6:30 PM, Andrey Smirnov wrote: > Move the call to devm_of_platform_populate() at the end of > caam_probe(), so we won't try to add any child devices until all of > the initialization is finished successfully. > > Signed-off-by: Andrey Smirnov > Cc: Chris Healy > Cc: Lucas Stach >

Re: [PATCH v2 3/6] crypto: caam - use devres to de-initialize the RNG

2019-10-23 Thread Horia Geanta
On 10/22/2019 6:30 PM, Andrey Smirnov wrote: > Use devres to de-initialize the RNG and drop explicit de-initialization > code in caam_remove(). > > Signed-off-by: Andrey Smirnov > Cc: Chris Healy > Cc: Lucas Stach > Cc: Horia Geantă > Cc: Herbert Xu > Cc: Iuliana Prodan > Cc:

[GIT PULL] VFIO fixes for v5.4-rc5

2019-10-23 Thread Alex Williamson
Hi Linus, The following changes since commit 4f5cafb5cb8471e54afdc9054d973535614f7675: Linux 5.4-rc3 (2019-10-13 16:37:36 -0700) are available in the Git repository at: git://github.com/awilliam/linux-vfio.git tags/vfio-v5.4-rc5 for you to fetch changes up to

Re: KCSAN: data-race in task_dump_owner / task_dump_owner

2019-10-23 Thread Dmitry Vyukov
On Thu, Oct 17, 2019 at 8:33 PM 'Marco Elver' via syzkaller-bugs wrote: > > On Thu, 17 Oct 2019 at 20:17, Alexey Dobriyan wrote: > > > > On Thu, Oct 17, 2019 at 02:56:47PM +0200, Marco Elver wrote: > > > Hi, > > > > > > On Thu, 17 Oct 2019 at 14:36, syzbot > > > wrote: > > > > > > > > Hello, >

[v2 PATCH] mm: thp: handle page cache THP correctly in PageTransCompoundMap

2019-10-23 Thread Yang Shi
We have usecase to use tmpfs as QEMU memory backend and we would like to take the advantage of THP as well. But, our test shows the EPT is not PMD mapped even though the underlying THP are PMD mapped on host. The number showed by /sys/kernel/debug/kvm/largepage is much less than the number of PMD

Re: [PATCH v1 3/6] KEYS: ima hook to measure builtin_trusted_keys

2019-10-23 Thread Mimi Zohar
On Wed, 2019-10-23 at 07:49 -0700, Lakshmi Ramasubramanian wrote: > On 10/23/19 6:22 AM, Mimi Zohar wrote: > > Thanks for reviewing the changes Mimi. > I'll address your comments and post an updated patch set shortly. > > >> Add a new ima hook to measure keys added to builtin_trusted_keys > >>

Re: [PATCH RFC 2/2] irqchip/gic: Allow the use of SGI interrupts

2019-10-23 Thread Florian Fainelli
Hello marc, On 10/23/19 6:22 AM, Marc Zyngier wrote: > Hi Florian, > > Needless to say, I mostly have questions... > > On 2019-10-23 01:05, Florian Fainelli wrote: >> SGI interrupts are a convenient way for trusted firmware to target a >> specific set of CPUs. Update the ARM GIC code to allow

Re: [PATCH] cpufreq: s3c64xx: Remove pointless NULL check in s3c64xx_cpufreq_driver_init

2019-10-23 Thread Nathan Chancellor
On Wed, Oct 23, 2019 at 05:59:23PM +0100, Mark Brown wrote: > On Wed, Oct 23, 2019 at 09:54:17AM -0700, Nathan Chancellor wrote: > > On Wed, Oct 23, 2019 at 05:36:56PM +0100, Mark Brown wrote: > > > On Wed, Oct 23, 2019 at 09:26:28AM -0700, Nathan Chancellor wrote: > > > > On Wed, Oct 23, 2019 at

Re: [PATCH] mm: thp: handle page cache THP correctly in PageTransCompoundMap

2019-10-23 Thread Yang Shi
On 10/22/19 6:31 PM, Hugh Dickins wrote: On Tue, 22 Oct 2019, Yang Shi wrote: On 10/22/19 3:27 PM, Hugh Dickins wrote: I completely agree that the current PageTransCompoundMap() is wrong. A fix for that is one of many patches I've not yet got to upstreaming. Comparing yours and mine, I'm

Re: [PATCH v4 15/16] module: Move where we mark modules RO,X

2019-10-23 Thread Josh Poimboeuf
On Wed, Oct 23, 2019 at 01:48:35PM +0200, Peter Zijlstra wrote: > Now sadly that commit missed all the useful information, luckily I could > find the patch in my LKML folder, more sad, that thread still didn't > contain the actual useful information, for that I was directed to > github: > >

Re: [PATCH] cpufreq: s3c64xx: Remove pointless NULL check in s3c64xx_cpufreq_driver_init

2019-10-23 Thread Mark Brown
On Wed, Oct 23, 2019 at 09:54:17AM -0700, Nathan Chancellor wrote: > On Wed, Oct 23, 2019 at 05:36:56PM +0100, Mark Brown wrote: > > On Wed, Oct 23, 2019 at 09:26:28AM -0700, Nathan Chancellor wrote: > > > On Wed, Oct 23, 2019 at 11:43:04AM +0100, Mark Brown wrote: > > > > The driver should also

Re: [PATCH 06/18] add support for Clang's Shadow Call Stack (SCS)

2019-10-23 Thread Sami Tolvanen
On Tue, Oct 22, 2019 at 9:28 AM Mark Rutland wrote: > I think it would be preferable to follow the example of CC_FLAGS_FTRACE > so that this can be filtered out, e.g. > > ifdef CONFIG_SHADOW_CALL_STACK > CFLAGS_SCS := -fsanitize=shadow-call-stack > KBUILD_CFLAGS += $(CFLAGS_SCS) > export

RE: [PATCH v3 0/7] Nvidia Arm SMMUv2 Implementation

2019-10-23 Thread Krishna Reddy
>>https://git.kernel.org/pub/scm/linux/kernel/git/will/linux.git/log/?h=for-joerg/arm-smmu/updates Thanks Will! Let me rebase my patches on top of this branch and send it out. -KR

  1   2   3   4   5   6   7   8   >