Re: [PATCH v2] netprio_cgroup: Fix unlimited memory leak of v2 cgroups

2020-05-08 Thread Jakub Kicinski
On Sat, 9 May 2020 11:32:10 +0800 Zefan Li wrote: > If systemd is configured to use hybrid mode which enables the use of > both cgroup v1 and v2, systemd will create new cgroup on both the default > root (v2) and netprio_cgroup hierarchy (v1) for a new session and attach > task to the two cgroups.

RE: [RFC] Issue in final aggregate value, in case of multiple events present in metric expression

2020-05-08 Thread Joakim Zhang
Hi Arnaldo, Kajol reflects this issue for almost two months, got no feedbacks, do you have any comments? That could be appreciated if you can look into it. Thanks a lot! Please refer to below link: https://www.spinics.net/lists/linux-perf-users/msg11011.html Best Regards, Joakim Zhang >

Re: [PATCH net-next] net: ipa: Remove ipa_endpoint_stop{,_rx_dma} again

2020-05-08 Thread Jakub Kicinski
On Fri, 8 May 2020 12:41:33 -0700 Nathan Chancellor wrote: > When building arm64 allyesconfig: > > drivers/net/ipa/ipa_endpoint.c: In function 'ipa_endpoint_stop_rx_dma': > drivers/net/ipa/ipa_endpoint.c:1274:13: error: 'IPA_ENDPOINT_STOP_RX_SIZE' > undeclared (first use in this function) >

Re: [PATCH v7 8/8] bus: mhi: core: Ensure non-zero session or sequence ID values are used

2020-05-08 Thread Manivannan Sadhasivam
On Fri, May 08, 2020 at 07:26:48PM -0700, Bhaumik Bhatt wrote: > While writing any sequence or session identifiers, it is possible that > the host could write a zero value, whereas only non-zero values should > be supported writes to those registers. Ensure that the host does not > write a

Re: [PATCH v7 6/8] bus: mhi: core: Return appropriate error codes for AMSS load failure

2020-05-08 Thread Manivannan Sadhasivam
On Fri, May 08, 2020 at 07:26:46PM -0700, Bhaumik Bhatt wrote: > When loading AMSS firmware using BHIe protocol, return -ETIMEDOUT if no > response is received within the timeout or return -EIO in case of a > protocol returned failure or an MHI error state. > > Signed-off-by: Bhaumik Bhatt >

Re: [PATCH v7 7/8] bus: mhi: core: Improve debug logs for loading firmware

2020-05-08 Thread Manivannan Sadhasivam
On Fri, May 08, 2020 at 07:26:47PM -0700, Bhaumik Bhatt wrote: > Add log messages to track boot flow errors and timeouts in SBL or AMSS > firmware loading to aid in debug. > > Signed-off-by: Bhaumik Bhatt > Reviewed-by: Jeffrey Hugo Reviewed-by: Manivannan Sadhasivam Thanks, Mani > --- >

Re: [PATCH v7 4/8] bus: mhi: core: Read transfer length from an event properly

2020-05-08 Thread Manivannan Sadhasivam
On Fri, May 08, 2020 at 07:26:44PM -0700, Bhaumik Bhatt wrote: > From: Hemant Kumar > > When MHI Driver receives an EOT event, it reads xfer_len from the > event in the last TRE. The value is under control of the MHI device > and never validated by Host MHI driver. The value should never be >

Re: [PATCH][V2] net: tg3: tidy up loop, remove need to compute off with a multiply

2020-05-08 Thread Jakub Kicinski
On Sat, 9 May 2020 00:14:47 +0100 Colin King wrote: > From: Colin Ian King > > Currently the value for 'off' is computed using a multiplication and > a couple of statements later off is being incremented by len and > this value is never read. Clean up the code by removing the > multiplication

Re: [PATCH v7 5/8] bus: mhi: core: Handle firmware load using state worker

2020-05-08 Thread Manivannan Sadhasivam
On Fri, May 08, 2020 at 07:26:45PM -0700, Bhaumik Bhatt wrote: > Upon power up, driver queues firmware worker thread if the execution > environment is PBL. Firmware worker is blocked with a timeout until > state worker gets a chance to run and unblock firmware worker. An > endpoint power up

Re: [PATCH] cnic: remove redundant assignment to variable ret

2020-05-08 Thread Jakub Kicinski
On Fri, 8 May 2020 23:40:26 +0100 Colin King wrote: > From: Colin Ian King > > The variable ret is being assigned with a value that is never read, > the assignment is redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King Applied, thank you!

Re: [PATCH] net: lio_core: remove redundant assignment to variable tx_done

2020-05-08 Thread Jakub Kicinski
On Fri, 8 May 2020 23:58:10 +0100 Colin King wrote: > From: Colin Ian King > > The variable tx_done is being assigned with a value that is never read > as the function returns a few statements later. The assignment is > redundant and can be removed. > > Addresses-Coverity: ("Unused value") >

Re: [PATCH] net/atheros: remove redundant assignment to variable size

2020-05-08 Thread Jakub Kicinski
On Fri, 8 May 2020 23:33:21 +0100 Colin King wrote: > From: Colin Ian King > > The variable size is being assigned with a value that is never read, > the assignment is redundant and cab be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King Applied, thank you!

Re: [PATCH v7 3/8] bus: mhi: core: Add range check for channel id received in event ring

2020-05-08 Thread Manivannan Sadhasivam
On Fri, May 08, 2020 at 07:26:43PM -0700, Bhaumik Bhatt wrote: > From: Hemant Kumar > > MHI data completion handler function reads channel id from event > ring element. Value is under the control of MHI devices and can be > any value between 0 and 255. In order to prevent out of bound access >

Re: [PATCH v7 2/8] bus: mhi: core: Cache intmod from mhi event to mhi channel

2020-05-08 Thread Manivannan Sadhasivam
On Fri, May 08, 2020 at 07:26:42PM -0700, Bhaumik Bhatt wrote: > From: Hemant Kumar > > Driver is using zero initialized intmod value from mhi channel when > configuring TRE for bei field. This prevents interrupt moderation to > take effect in case it is supported by an event ring. Fix this by >

Re: [PATCH v7 1/8] bus: mhi: core: Refactor mhi queue APIs

2020-05-08 Thread Manivannan Sadhasivam
On Fri, May 08, 2020 at 07:26:41PM -0700, Bhaumik Bhatt wrote: > From: Hemant Kumar > > Move all the common code to generate TRE from mhi_queue_buf, > mhi_queue_dma and mhi_queue_skb to mhi_gen_tre. This helps > to centralize the TRE generation code which makes any future > bug fixing easier to

Re: [PATCH v4 1/4] device-dax: Don't leak kernel memory to user space after unloading kmem

2020-05-08 Thread David Hildenbrand
> Am 09.05.2020 um 01:53 schrieb Andrew Morton : > > On Fri, 8 May 2020 10:42:14 +0200 David Hildenbrand > wrote: > >> Assume we have kmem configured and loaded: >> [root@localhost ~]# cat /proc/iomem >> ... >> 14000-33fff : Persistent Memory$ >>14000-1481f :

[PATCH 4/4] fs: btrfs: fix a data race in btrfs_block_rsv_release()

2020-05-08 Thread Jia-Ju Bai
The functions btrfs_block_rsv_release() and btrfs_update_delayed_refs_rsv() are concurrently executed at runtime in the following call contexts: Thread 1: btrfs_file_write_iter() btrfs_buffered_write() btrfs_delalloc_release_extents() btrfs_inode_rsv_release()

Re: [PATCH 6/6] exec: Set the point of no return sooner

2020-05-08 Thread Kees Cook
On Fri, May 08, 2020 at 01:48:13PM -0500, Eric W. Biederman wrote: > > Make the code more robust by marking the point of no return sooner. > This ensures that future code changes don't need to worry about how > they return errors if they are past this point. > > This results in no actual change

Re: [PATCH -next] net: dsa: sja1105: remove set but not used variable 'prev_time'

2020-05-08 Thread Jakub Kicinski
On Fri, 8 May 2020 20:00:55 +0800 Samuel Zou wrote: > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/net/dsa/sja1105/sja1105_vl.c:468:6: warning: variable ‘prev_time’ set > but not used [-Wunused-but-set-variable] > u32 prev_time = 0; > ^ > > Reported-by: Hulk Robot

Re: [PATCH 5/6] exec: Move handling of the point of no return to the top level

2020-05-08 Thread Kees Cook
On Fri, May 08, 2020 at 01:47:10PM -0500, Eric W. Biederman wrote: > > Move the handing of the point of no return from search_binary_handler > into __do_execve_file so that it is easier to find, and to keep > things robust in the face of change. > > Make it clear that an existing fatal signal

[PATCH 3/4] fs: btrfs: fix data races in start_transaction()

2020-05-08 Thread Jia-Ju Bai
The functions start_transaction() and btrfs_update_delayed_refs_rsv() are concurrently executed at runtime in the following call contexts: Thread 1: btrfs_sync_file() btrfs_start_transaction() start_transaction() Thread 2: finish_ordered_fn() btrfs_finish_ordered_io()

[PATCH 2/4] fs: btrfs: fix data races in extent_write_cache_pages()

2020-05-08 Thread Jia-Ju Bai
The function extent_write_cache_pages is concurrently executed with itself at runtime in the following call contexts: Thread 1: btrfs_sync_file() start_ordered_ops() btrfs_fdatawrite_range() btrfs_writepages() [via function pointer] extent_writepages()

[PATCH 1/4] fs: btrfs: fix a data race in btrfs_block_group_done()

2020-05-08 Thread Jia-Ju Bai
The functions btrfs_block_group_done() and caching_thread() are concurrently executed at runtime in the following call contexts: Thread 1: btrfs_sync_file() start_ordered_ops() btrfs_fdatawrite_range() btrfs_writepages() [via function pointer] extent_writepages()

Re: [PATCH 4/6] exec: Run sync_mm_rss before taking exec_update_mutex

2020-05-08 Thread Kees Cook
On Fri, May 08, 2020 at 01:45:56PM -0500, Eric W. Biederman wrote: > Like exec_mm_release sync_mm_rss is about flushing out the state of > the old_mm, which does not need to happen under exec_update_mutex. > > Make this explicit by moving sync_mm_rss outside of exec_update_mutex. > >

Re: [PATCH v4 12/12] mtd: Support kmsg dumper based on pstore/blk

2020-05-08 Thread WeiXiong Liao
hi Kees Cook, On 2020/5/8 PM 2:40, Kees Cook wrote: > From: WeiXiong Liao > > This introduces mtdpstore, which is similar to mtdoops but more > powerful. It uses pstore/blk, and aims to store panic and oops logs to > a flash partition, where pstore can later read back and present as files > in

Re: [PATCH 3/6] exec: Stop open coding mutex_lock_killable of cred_guard_mutex

2020-05-08 Thread Kees Cook
On Fri, May 08, 2020 at 01:45:25PM -0500, Eric W. Biederman wrote: > > Oleg modified the code that did > "mutex_lock_interruptible(>cred_guard_mutex)" to return > -ERESTARTNOINTR instead of -EINTR, so that userspace will never see a > failure to grab the mutex. > > Slightly earlier Liam R.

Re: [PATCH 2/6] exec: Fix spelling of search_binary_handler in a comment

2020-05-08 Thread Kees Cook
On Fri, May 08, 2020 at 01:44:46PM -0500, Eric W. Biederman wrote: > > Signed-off-by: "Eric W. Biederman" Reviewed-by: Kees Cook -- Kees Cook

Re: [PATCH 1/6] exec: Move the comment from above de_thread to above unshare_sighand

2020-05-08 Thread Kees Cook
On Fri, May 08, 2020 at 01:44:19PM -0500, Eric W. Biederman wrote: > > The comment describes work that now happens in unshare_sighand so > move the comment where it makes sense. > > Signed-off-by: "Eric W. Biederman" Reviewed-by: Kees Cook -- Kees Cook

Re: linux-next 20200506 - build failure with net/bpfilter/bpfilter_umh

2020-05-08 Thread Valdis Klētnieks
On Sat, 09 May 2020 12:45:22 +0900, Masahiro Yamada said: > > LD [U] net/bpfilter/bpfilter_umh > > /usr/bin/ld: cannot find -lc > > collect2: error: ld returned 1 exit status > > make[2]: *** [scripts/Makefile.userprogs:36: net/bpfilter/bpfilter_umh] > > Error 1 > > make[1]: ***

Re: [PATCH v4 06/12] pstore/blk: Add console frontend support

2020-05-08 Thread WeiXiong Liao
hi Kees Cook, On 2020/5/8 PM 2:39, Kees Cook wrote: > From: WeiXiong Liao > > Support backend for console. To enable console backend, just make > console_size be greater than 0 and a multiple of 4096. > > Signed-off-by: WeiXiong Liao > Link: >

Re: [PATCH] cnic: remove redundant assignment to variable ret

2020-05-08 Thread Michael Chan
On Fri, May 8, 2020 at 3:40 PM Colin King wrote: > > From: Colin Ian King > > The variable ret is being assigned with a value that is never read, > the assignment is redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King Reviewed-by: Michael Chan

net/mptcp/protocol.c:538:6: warning: 'dfrag_collapsed' may be used uninitialized in this function

2020-05-08 Thread kbuild test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: d5eeab8d7e269e8cfc53b915bccd7bd30485bcbf commit: 3b1d6210a9577369103330b0d802b0bf74b65e7f mptcp: implement and use MPTCP-level retransmission date: 6 weeks ago config: x86_64-randconfig-a003-20200509

Re: [PATCH] net: tg3: tidy up loop, remove need to compute off with a multiply

2020-05-08 Thread Michael Chan
On Fri, May 8, 2020 at 7:31 PM Joe Perches wrote: > > On Fri, 2020-05-08 at 18:48 -0700, Jakub Kicinski wrote: > > On Sat, 9 May 2020 00:31:03 +0100 Colin Ian King wrote: > > > > My preference would be for > > > > > > > > { > > > > int i; > > > > u32 off = 0; > > > > > > > > for (i = 0; i <

[PATCH] bpfilter: document build requirements for bpfilter_umh

2020-05-08 Thread Valdis Klētnieks
It's not intuitively obvious that bpfilter_umh is a statically linked binary. Mention the toolchain requirement in the Kconfig help, so people have an easier time figuring out what's needed. Signed-off-by: Valdis Kletnieks diff --git a/net/bpfilter/Kconfig b/net/bpfilter/Kconfig index

[PATCH 12/15] ath10k: use new module_firmware_crashed()

2020-05-08 Thread Luis Chamberlain
This makes use of the new module_firmware_crashed() to help annotate when firmware for device drivers crash. When firmware crashes devices can sometimes become unresponsive, and recovery sometimes requires a driver unload / reload and in the worst cases a reboot. Using a taint flag allows us to

Re: [PATCH v5] x86: bitops: fix build regression

2020-05-08 Thread Sedat Dilek
On Sat, May 9, 2020 at 1:47 AM Jesse Brandeburg wrote: > > On Fri, 8 May 2020 13:28:35 -0700 > Nathan Chancellor wrote: > > > On Fri, May 08, 2020 at 11:32:29AM -0700, Nick Desaulniers wrote: > > > Use the `%b` "x86 Operand Modifier" to instead force register allocation > > > to select a

Re: [PATCH v4 05/12] pstore/blk: Add support for pmsg frontend

2020-05-08 Thread WeiXiong Liao
hi Kees Cook, On 2020/5/8 PM 2:39, Kees Cook wrote: > From: WeiXiong Liao > > Add pmsg support to pstore/blk (through pstore/zone). To enable, pmsg_size > must be greater than 0 and a multiple of 4096. > > Signed-off-by: WeiXiong Liao > Link: >

[PATCH 01/15] taint: add module firmware crash taint support

2020-05-08 Thread Luis Chamberlain
Device driver firmware can crash, and sometimes, this can leave your system in a state which makes the device or subsystem completely useless. Detecting this by inspecting /proc/sys/kernel/tainted instead of scraping some magical words from the kernel log, which is driver specific, is much easier.

[PATCH 11/15] wimax/i2400m: use new module_firmware_crashed()

2020-05-08 Thread Luis Chamberlain
This makes use of the new module_firmware_crashed() to help annotate when firmware for device drivers crash. When firmware crashes devices can sometimes become unresponsive, and recovery sometimes requires a driver unload / reload and in the worst cases a reboot. Using a taint flag allows us to

[PATCH 07/15] cxgb4: use new module_firmware_crashed()

2020-05-08 Thread Luis Chamberlain
This makes use of the new module_firmware_crashed() to help annotate when firmware for device drivers crash. When firmware crashes devices can sometimes become unresponsive, and recovery sometimes requires a driver unload / reload and in the worst cases a reboot. Using a taint flag allows us to

[PATCH 10/15] soc: qcom: ipa: use new module_firmware_crashed()

2020-05-08 Thread Luis Chamberlain
This makes use of the new module_firmware_crashed() to help annotate when firmware for device drivers crash. When firmware crashes devices can sometimes become unresponsive, and recovery sometimes requires a driver unload / reload and in the worst cases a reboot. Using a taint flag allows us to

[PATCH 08/15] ehea: use new module_firmware_crashed()

2020-05-08 Thread Luis Chamberlain
This makes use of the new module_firmware_crashed() to help annotate when firmware for device drivers crash. When firmware crashes devices can sometimes become unresponsive, and recovery sometimes requires a driver unload / reload and in the worst cases a reboot. Using a taint flag allows us to

[PATCH 15/15] mwl8k: use new module_firmware_crashed()

2020-05-08 Thread Luis Chamberlain
This makes use of the new module_firmware_crashed() to help annotate when firmware for device drivers crash. When firmware crashes devices can sometimes become unresponsive, and recovery sometimes requires a driver unload / reload and in the worst cases a reboot. Using a taint flag allows us to

[PATCH 04/15] bnxt: use new module_firmware_crashed()

2020-05-08 Thread Luis Chamberlain
This makes use of the new module_firmware_crashed() to help annotate when firmware for device drivers crash. When firmware crashes devices can sometimes become unresponsive, and recovery sometimes requires a driver unload / reload and in the worst cases a reboot. Using a taint flag allows us to

[PATCH 06/15] liquidio: use new module_firmware_crashed()

2020-05-08 Thread Luis Chamberlain
This makes use of the new module_firmware_crashed() to help annotate when firmware for device drivers crash. When firmware crashes devices can sometimes become unresponsive, and recovery sometimes requires a driver unload / reload and in the worst cases a reboot. Using a taint flag allows us to

[PATCH 03/15] bnx2x: use new module_firmware_crashed()

2020-05-08 Thread Luis Chamberlain
This makes use of the new module_firmware_crashed() to help annotate when firmware for device drivers crash. When firmware crashes devices can sometimes become unresponsive, and recovery sometimes requires a driver unload / reload and in the worst cases a reboot. Using a taint flag allows us to

[PATCH 13/15] ath6kl: use new module_firmware_crashed()

2020-05-08 Thread Luis Chamberlain
This makes use of the new module_firmware_crashed() to help annotate when firmware for device drivers crash. When firmware crashes devices can sometimes become unresponsive, and recovery sometimes requires a driver unload / reload and in the worst cases a reboot. Using a taint flag allows us to

[PATCH 05/15] bna: use new module_firmware_crashed()

2020-05-08 Thread Luis Chamberlain
This makes use of the new module_firmware_crashed() to help annotate when firmware for device drivers crash. When firmware crashes devices can sometimes become unresponsive, and recovery sometimes requires a driver unload / reload and in the worst cases a reboot. Using a taint flag allows us to

[PATCH 09/15] qed: use new module_firmware_crashed()

2020-05-08 Thread Luis Chamberlain
This makes use of the new module_firmware_crashed() to help annotate when firmware for device drivers crash. When firmware crashes devices can sometimes become unresponsive, and recovery sometimes requires a driver unload / reload and in the worst cases a reboot. Using a taint flag allows us to

[PATCH 00/15] net: taint when the device driver firmware crashes

2020-05-08 Thread Luis Chamberlain
Device driver firmware can crash, and sometimes, this can leave your system in a state which makes the device or subsystem completely useless. Detecting this by inspecting /proc/sys/kernel/tainted instead of scraping some magical words from the kernel log, which is driver specific, is much easier.

[PATCH 14/15] brcm80211: use new module_firmware_crashed()

2020-05-08 Thread Luis Chamberlain
This makes use of the new module_firmware_crashed() to help annotate when firmware for device drivers crash. When firmware crashes devices can sometimes become unresponsive, and recovery sometimes requires a driver unload / reload and in the worst cases a reboot. Using a taint flag allows us to

[PATCH 02/15] ethernet/839: use new module_firmware_crashed()

2020-05-08 Thread Luis Chamberlain
This makes use of the new module_firmware_crashed() to help annotate when firmware for device drivers crash. When firmware crashes devices can sometimes become unresponsive, and recovery sometimes requires a driver unload / reload and in the worst cases a reboot. Using a taint flag allows us to

Re: [PATCH -next v2] locking/osq_lock: annotate a data race in osq_lock

2020-05-08 Thread Paul E. McKenney
On Fri, May 08, 2020 at 04:59:05PM -0400, Qian Cai wrote: > > > > On Feb 11, 2020, at 8:54 AM, Qian Cai wrote: > > > > prev->next could be accessed concurrently as noticed by KCSAN, > > > > write (marked) to 0x9d3370dbbe40 of 8 bytes by task 3294 on cpu 107: > > osq_lock+0x25f/0x350 > >

[PATCH net v2] hinic: fix a bug of ndo_stop

2020-05-08 Thread Luo bin
if some function in ndo_stop interface returns failure because of hardware fault, must go on excuting rest steps rather than return failure directly, otherwise will cause memory leak.And bump the timeout for SET_FUNC_STATE to ensure that cmd won't return failure when hw is busy. Otherwise hw may

[PATCH net-next v2] hinic: add three net_device_ops of vf

2020-05-08 Thread Luo bin
adds ndo_set_vf_rate/ndo_set_vf_spoofchk/ndo_set_vf_link_state to configure netdev of virtual function Signed-off-by: Luo bin --- .../net/ethernet/huawei/hinic/hinic_hw_cmdq.c | 29 ++ .../net/ethernet/huawei/hinic/hinic_hw_dev.c | 35 ++- .../net/ethernet/huawei/hinic/hinic_hw_dev.h | 21

RE: [PATCH] fpga: dfl: Replace zero-length array with flexible-array

2020-05-08 Thread Wu, Hao
I think Moritz had already applied it to his tree per last submission. https://lkml.org/lkml/2020/3/21/373 Thanks Hao > -Original Message- > From: matthew.gerl...@linux.intel.com > Sent: Saturday, May 9, 2020 2:21 AM > To: Gustavo A. R. Silva > Cc: Wu, Hao ; linux-f...@vger.kernel.org;

Re: [PATCH v2] net: Protect INET_ADDR_COOKIE on 32-bit architectures

2020-05-08 Thread Jakub Kicinski
On Fri, 8 May 2020 14:04:57 +0200 Stephen Kitt wrote: > Commit c7228317441f ("net: Use a more standard macro for > INET_ADDR_COOKIE") added a __deprecated marker to the cookie name on > 32-bit architectures, with the intent that the compiler would flag > uses of the name. However since commit

Re: [PATCH v2] kernel: add panic_on_taint

2020-05-08 Thread Luis Chamberlain
On Fri, May 08, 2020 at 08:47:19AM -0400, Rafael Aquini wrote: > On Thu, May 07, 2020 at 10:25:58PM +, Luis Chamberlain wrote: > > On Thu, May 07, 2020 at 06:06:06PM -0400, Rafael Aquini wrote: > > > On Thu, May 07, 2020 at 08:33:40PM +, Luis Chamberlain wrote: > > > > I *think* that a

Re: [PATCH v4 03/12] pstore/blk: Introduce backend for block devices

2020-05-08 Thread WeiXiong Liao
hi Kees Cook, On 2020/5/8 PM 2:39, Kees Cook wrote: > From: WeiXiong Liao > > pstore/blk is similar to pstore/ram, but uses a block device as the > storage rather than persistent ram. > > The pstore/blk backend solves two common use-cases that used to preclude > using pstore/ram: > - not all

Re: linux-next: new contact(s) for the ceph tree?

2020-05-08 Thread Stephen Rothwell
Hi Sage, On Sat, 9 May 2020 01:03:14 + (UTC) Sage Weil wrote: > > Jeff Layton Done. > On Sat, 9 May 2020, Stephen Rothwell wrote: > > > > I noticed commit > > > > 3a5ccecd9af7 ("MAINTAINERS: remove myself as ceph co-maintainer") > > > > appear recently. So who should I now list as

Re: linux-next 20200506 - build failure with net/bpfilter/bpfilter_umh

2020-05-08 Thread Masahiro Yamada
On Fri, May 8, 2020 at 2:22 PM Valdis Klētnieks wrote: > > My kernel build came to a screeching halt with: > > CHECK net/bpfilter/bpfilter_kern.c > CC [M] net/bpfilter/bpfilter_kern.o > CC [U] net/bpfilter/main.o > LD [U] net/bpfilter/bpfilter_umh > /usr/bin/ld: cannot find -lc >

Re: [PATCH v2 1/4] Documentation: LKMM: Move MP+onceassign+derefonce to new litmus-tests/rcu/

2020-05-08 Thread Akira Yokosawa
Hi Joel, Sorry for the late response but I've noticed some glitches. On Sun, 22 Mar 2020 21:57:32 -0400, Joel Fernandes (Google) wrote: > Move MP+onceassign+derefonce to the new Documentation/litmus-tests/rcu/ > directory. MP+onceassign+derefonce.litmus is called out in

Re: [RFC v1 0/6] block: add error handling for *add_disk*()

2020-05-08 Thread Luis Chamberlain
but that's all so far. Note that break-blktrace run_0004.sh still yields: debugfs: Directory 'loop0' with parent 'block' already present! And so I suspect something else is up, this is even after. That's using my latest: https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git/lo

Re: [RFC PATCH 00/13] Core scheduling v5

2020-05-08 Thread Ning, Hongyu
- Test environment: Intel Xeon Server platform CPU(s): 192 On-line CPU(s) list: 0-191 Thread(s) per core: 2 Core(s) per socket: 48 Socket(s): 2 NUMA node(s):4 - Kernel under test: Core scheduling v5 base

[PATCH v2] netprio_cgroup: Fix unlimited memory leak of v2 cgroups

2020-05-08 Thread Zefan Li
If systemd is configured to use hybrid mode which enables the use of both cgroup v1 and v2, systemd will create new cgroup on both the default root (v2) and netprio_cgroup hierarchy (v1) for a new session and attach task to the two cgroups. If the task does some network thing then the v2 cgroup

Re: [PATCH] usb: roles: Switch on role-switch uevent reporting

2020-05-08 Thread Wen Yang
在 2020/5/9 上午12:29, Bryan O'Donoghue 写道: Right now we don't report to user-space a role switch when doing a usb_role_switch_set_role() despite having registered the uevent callbacks. This patch switches on the notifications allowing user-space to see role-switch change notifications and

[PATCH 2/2] ASoC: max98390: Added Amplifier Driver

2020-05-08 Thread Steve Lee
Signed-off-by: Steve Lee --- sound/soc/codecs/Kconfig|5 + sound/soc/codecs/Makefile |2 + sound/soc/codecs/max98390.c | 1039 +++ sound/soc/codecs/max98390.h | 661 ++ 4 files changed, 1707 insertions(+) create mode 100644

[PATCH] netprio_cgroup: Fix unlimited memory leak of v2 cgroup

2020-05-08 Thread Zefan Li
If systemd is configured to use hybrid mode which enables the use of both cgroup v1 and v2, systemd will create new cgroup on both the default root (v2) and netprio_cgroup hierarchy (v1) for a new session and attach task to the two cgroups. If the task does some network thing then the v2 cgroup

[PATCH 1/2] dt-bindings: Added device tree binding for max98390

2020-05-08 Thread Steve Lee
Signed-off-by: Steve Lee --- .../devicetree/bindings/sound/max98390.txt| 26 +++ 1 file changed, 26 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/max98390.txt diff --git a/Documentation/devicetree/bindings/sound/max98390.txt

Re: [PATCH 0/6] nouveau/hmm: add support for mapping large pages

2020-05-08 Thread Matthew Wilcox
On Fri, May 08, 2020 at 01:17:55PM -0700, Ralph Campbell wrote: > On 5/8/20 12:59 PM, Matthew Wilcox wrote: > > On Fri, May 08, 2020 at 12:20:03PM -0700, Ralph Campbell wrote: > > > hmm_range_fault() returns an array of page frame numbers and flags for > > > how the pages are mapped in the

Re: [PATCH] drm: vmwgfx: include linux/highmem.h

2020-05-08 Thread Stephen Rothwell
Hi Arnd, On Sat, 9 May 2020 00:01:31 +0200 Arnd Bergmann wrote: > > In order to call kmap_atomic() etc, we need to include linux/highmem.h: > > drivers/gpu/drm/vmwgfx/vmwgfx_blit.c: In function 'vmw_bo_cpu_blit_line': > drivers/gpu/drm/vmwgfx/vmwgfx_blit.c:377:4: error: implicit declaration of

[GIT PULL] io_uring fixes for 5.7-rc5

2020-05-08 Thread Jens Axboe
Hi Linus, A few fixes that should go into this series: - Fix finish_wait() balancing in file cancelation (Xiaoguang) - Ensure early cleanup of resources in ring map failure (Xiaoguang) - Ensure IORING_OP_SLICE does the right file mode checks (Pavel) - Remove file opening from

[PATCH v4 1/5] block: revert back to synchronous request_queue removal

2020-05-08 Thread Luis Chamberlain
Commit dc9edc44de6c ("block: Fix a blk_exit_rl() regression") merged on v4.12 moved the work behind blk_release_queue() into a workqueue after a splat floated around which indicated some work on blk_release_queue() could sleep in blk_exit_rl(). This splat would be possible when a driver called

[PATCH v4 5/5] loop: be paranoid on exit and prevent new additions / removals

2020-05-08 Thread Luis Chamberlain
Be pedantic on removal as well and hold the mutex. This should prevent uses of addition while we exit. I cannot trigger an issue with this though, this is just a fix done through code inspection. Reviewed-by: Ming Lei Signed-off-by: Luis Chamberlain --- drivers/block/loop.c | 4 1 file

[PATCH v4 4/5] blktrace: break out of blktrace setup on concurrent calls

2020-05-08 Thread Luis Chamberlain
We use one blktrace per request_queue, that means one per the entire disk. So we cannot run one blktrace on say /dev/vda and then /dev/vda1, or just two calls on /dev/vda. We check for concurrent setup only at the very end of the blktrace setup though. If we try to run two concurrent blktraces

[PATCH v4 2/5] block: move main block debugfs initialization to its own file

2020-05-08 Thread Luis Chamberlain
make_request-based drivers and and request-based drivers share some debugfs code. By moving this into its own file it makes it easier to expand and audit this shared code. This patch contains no functional changes. Cc: Bart Van Assche Cc: Omar Sandoval Cc: Hannes Reinecke Cc: Nicolai Stange

[PATCH v4 3/5] blktrace: fix debugfs use after free

2020-05-08 Thread Luis Chamberlain
On commit 6ac93117ab00 ("blktrace: use existing disk debugfs directory") merged on v4.12 Omar fixed the original blktrace code for request-based drivers (multiqueue). This however left in place a possible crash, if you happen to abuse blktrace while racing to remove / add a device. We used to use

[PATCH v4 0/5] block: fix blktrace debugfs use after free

2020-05-08 Thread Luis Chamberlain
: https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git/log/?h=20200508-block-fixes Luis Chamberlain (5): block: revert back to synchronous request_queue removal block: move main block debugfs initialization to its own file blktrace: fix debugfs use after free blktrace

Re: [PATCH net-next v1] hinic: add three net_device_ops of vf

2020-05-08 Thread Jakub Kicinski
On Sat, 9 May 2020 10:56:55 +0800 luobin (L) wrote: > >> - if (!HINIC_IS_VF(nic_dev->hwdev->hwif)) > >> - /* Wait up to 3 sec between port enable to link state */ > >> - msleep(3000); > > Why is this no longer needed? > > ---When phsical port links up, hw will notify this

Re: [PATCH v4 02/12] pstore/zone: Introduce common layer to manage storage zones

2020-05-08 Thread WeiXiong Liao
hi Kees Cook, On 2020/5/8 PM 2:39, Kees Cook wrote: > From: WeiXiong Liao > > Implement a common set of APIs needed to support pstore storage zones, > based on how ramoops is designed. This will be used by pstore/blk with > the intention of migrating pstore/ram in the future. > >

[PATCH v9 3/8] x86/split_lock: Introduce flag X86_FEATURE_SLD_FATAL and drop sld_state

2020-05-08 Thread Xiaoyao Li
Introduce a synthetic feature flag X86_FEATURE_SLD_FATAL, which means kernel is in sld_fatal mode if set. Now sld_state is not needed any more that the state of SLD can be inferred from X86_FEATURE_SPLIT_LOCK_DETECT and X86_FEATURE_SLD_FATAL. Suggested-by: Sean Christopherson Signed-off-by:

[PATCH v9 7/8] KVM: VMX: virtualize split lock detection

2020-05-08 Thread Xiaoyao Li
TEST_CTRL MSR is per-core scope, i.e., the sibling threads in the same physical core share the same MSR. This requires additional constraint when exposing it to guest. 1) When host SLD state is sld_off (no X86_FEATURE_SPLIT_LOCK_DETECT), feature split lock detection is unsupported/disabled.

[PATCH v9 8/8] x86/split_lock: Enable split lock detection initialization when running as an guest on KVM

2020-05-08 Thread Xiaoyao Li
When running as guest, enumerating feature split lock detection through CPU model is not easy since CPU model is configurable by host VMM. If running upon KVM, it can be enumerated through KVM_FEATURE_SPLIT_LOCK_DETECT, and if KVM_HINTS_SLD_FATAL is set, it needs to be set to sld_fatal mode.

[PATCH v9 4/8] x86/split_lock: Introduce split_lock_virt_switch() and two wrappers

2020-05-08 Thread Xiaoyao Li
Introduce split_lock_virt_switch(), which is used for toggling split lock detection setting as well as updating TIF_SLD_DISABLED flag to make them consistent. Note, it can only be used in sld warn mode, i.e., X86_FEATURE_SPLIT_LOCK_DETECT && !X86_FEATURE_SLD_FATAL. The FATAL check is handled by

[PATCH v9 0/8] KVM: Add virtualization support of split lock detection

2020-05-08 Thread Xiaoyao Li
This series aims to add the virtualization of split lock detection in KVM. Due to the fact that split lock detection is tightly coupled with CPU model and CPU model is configurable by host VMM, we elect to use paravirt method to expose and enumerate it for guest. Changes in v9 - rebase to

[PATCH v9 2/8] x86/split_lock: Remove bogus case in handle_guest_split_lock()

2020-05-08 Thread Xiaoyao Li
The bogus case can never happen, i.e., when sld_state == sld_off, guest won't trigger split lock #AC and of course no handle_guest_split_lock() will be called. Beside, drop bogus case also makes future patch easier to remove sld_state if we reach the alignment that it must be sld_warn or

[PATCH v9 6/8] KVM: VMX: Enable MSR TEST_CTRL for guest

2020-05-08 Thread Xiaoyao Li
Unconditionally allow the guest to read and zero-write MSR TEST_CTRL. This matches the fact that most Intel CPUs support MSR TEST_CTRL, and it also alleviates the effort to handle wrmsr/rdmsr when split lock detection is exposed to the guest in a future patch. Signed-off-by: Xiaoyao Li ---

[PATCH v9 1/8] x86/split_lock: Rename TIF_SLD to TIF_SLD_DISABLED

2020-05-08 Thread Xiaoyao Li
TIF_SLD can only be set if a user space thread hits split lock and sld_state == sld_warn. This flag is set to indicate SLD (split lock detection) is turned off for the thread, so rename it to TIF_SLD_DISABLED, which is pretty self explaining. Suggested-by: Sean Christopherson Suggested-by:

[PATCH v9 5/8] x86/kvm: Introduce paravirt split lock detection enumeration

2020-05-08 Thread Xiaoyao Li
Introduce KVM_FEATURE_SPLIT_LOCK_DETECT, for which linux guest running on KVM can enumerate the avaliablility of feature split lock detection. Introduce KVM_HINTS_SLD_FATAL, which tells whether host is sld_fatal mode, i.e., whether split lock detection is forced on for guest vcpu. Signed-off-by:

Re: [PATCH V4] f2fs: Avoid double lock for cp_rwsem during checkpoint

2020-05-08 Thread Chao Yu
On 2020/5/9 0:10, Jaegeuk Kim wrote: > Hi Sayali, > > In order to address the perf regression, how about this? > >>From 48418af635884803ffb35972df7958a2e6649322 Mon Sep 17 00:00:00 2001 > From: Jaegeuk Kim > Date: Fri, 8 May 2020 09:08:37 -0700 > Subject: [PATCH] f2fs: avoid double lock for

[PATCH -next] mm/hmm/test: fix missing unlock on error in dmirror_migrate_finalize_and_map()

2020-05-08 Thread Wei Yongjun
Add the missing unlock before return from function dmirror_migrate_finalize_and_map() in the error handling case. Fixes: 5d5e54be8a1e ("mm/hmm/test: add selftest driver for HMM") Reported-by: Hulk Robot Signed-off-by: Wei Yongjun --- lib/test_hmm.c | 4 +++- 1 file changed, 3 insertions(+), 1

[PATCH -next] mm/hmm/test: fix error return code in hmm_dmirror_init()

2020-05-08 Thread Wei Yongjun
Fix to return negative error code -ENOMEM from the alloc_page() error handling case instead of 0, as done elsewhere in this function. Fixes: 5d5e54be8a1e ("mm/hmm/test: add selftest driver for HMM") Reported-by: Hulk Robot Signed-off-by: Wei Yongjun --- lib/test_hmm.c | 4 +++- 1 file changed,

Re: [PATCH 13/14] sched: cpufreq: Use IS_ENABLED() for schedutil

2020-05-08 Thread Pavan Kondeti
On Fri, May 08, 2020 at 02:21:29PM +0100, Quentin Perret wrote: > On Friday 08 May 2020 at 11:00:53 (+0530), Pavan Kondeti wrote: > > > -#if defined(CONFIG_ENERGY_MODEL) && > > > defined(CONFIG_CPU_FREQ_GOV_SCHEDUTIL) > > > +#if defined(CONFIG_ENERGY_MODEL) && > > >

[PATCH -next] power: reset: ltc2952: remove set but used variable

2020-05-08 Thread Hongbo Yao
Fixes gcc '-Wunused-but-set-variable' warning: drivers/power/reset/ltc2952-poweroff.c:97:16: warning: variable ‘overruns’ set but not used [-Wunused-but-set-variable] unsigned long overruns; Reported-by: Hulk Robot Signed-off-by: Hongbo Yao --- drivers/power/reset/ltc2952-poweroff.c | 3 +--

Re: [RFC PATCH v3 12/14] perf metricgroup: order event groups by size

2020-05-08 Thread Andi Kleen
> > I'm not sure if size is that great an heuristic. The dedup algorithm should > > work in any case even if you don't order by size, right? > > Consider two metrics: > - metric 1 with events {A,B} > - metric 2 with events {A,B,C,D} > If the list isn't sorted then as the matching takes the

Re: [RFC 2/4] sched/core: Set nr_lat_sensitive counter at various scheduler entry/exit points

2020-05-08 Thread Pavan Kondeti
On Fri, May 08, 2020 at 04:45:16PM +0530, Parth Shah wrote: > Hi Pavan, > > Thanks for going through this patch-set. > > On 5/8/20 2:03 PM, Pavan Kondeti wrote: > > Hi Parth, > > > > On Thu, May 07, 2020 at 07:07:21PM +0530, Parth Shah wrote: > >> Monitor tasks at: > >> 1. wake_up_new_task() -

Re: [PATCH] phy: samsung: s5pv210-usb2: Add delay after reset

2020-05-08 Thread Jonathan Bakker
Hi Kishon, Is there anything else you (or someone else) needs from me? I'd really appreciate getting USB working again on s5pv210 as without this patch it is entirely broken. Thanks, Jonathan On 2020-04-28 2:50 p.m., Jonathan Bakker wrote: > Hi Kishon, > > On 2020-04-27 5:40 a.m., Kishon

Re: [PATCH] net: tg3: tidy up loop, remove need to compute off with a multiply

2020-05-08 Thread Joe Perches
On Fri, 2020-05-08 at 18:48 -0700, Jakub Kicinski wrote: > On Sat, 9 May 2020 00:31:03 +0100 Colin Ian King wrote: > > > My preference would be for > > > > > > { > > > int i; > > > u32 off = 0; > > > > > > for (i = 0; i < TG3_SD_NUM_RECS; i++) { > > > tg3_ape_scratchpad_read(tp,

Re: cgroup pointed by sock is leaked on mode switch

2020-05-08 Thread Yang Yingliang
On 2020/5/6 15:51, Zefan Li wrote: On 2020/5/6 10:16, Zefan Li wrote: On 2020/5/6 9:50, Yang Yingliang wrotee: +cc lize...@huawei.com On 2020/5/6 0:06, Tejun Heo wrote: Hello, Yang. On Sat, May 02, 2020 at 06:27:21PM +0800, Yang Yingliang wrote: I find the number nr_dying_descendants is

[PATCH v7 3/8] bus: mhi: core: Add range check for channel id received in event ring

2020-05-08 Thread Bhaumik Bhatt
From: Hemant Kumar MHI data completion handler function reads channel id from event ring element. Value is under the control of MHI devices and can be any value between 0 and 255. In order to prevent out of bound access add a bound check against the max channel supported by controller and skip

  1   2   3   4   5   6   7   8   9   10   >