Re: [PATCH v2 2/2] Add PWM fan controller driver for LGM SoC

2020-06-24 Thread Uwe Kleine-König
On Thu, Jun 25, 2020 at 12:23:54PM +0800, Tanwar, Rahul wrote: > > Hi Philipp, > > On 18/6/2020 8:25 pm, Philipp Zabel wrote: > > Hi Rahul, > > > > On Thu, 2020-06-18 at 20:05 +0800, Rahul Tanwar wrote: > >> Intel Lightning Mountain(LGM) SoC contains a PWM fan controller. > >> This PWM

Re: [PATCH] mm/spase: never partially remove memmap for early section

2020-06-24 Thread David Hildenbrand
> Am 25.06.2020 um 01:47 schrieb Dan Williams : > > On Wed, Jun 24, 2020 at 3:44 PM Wei Yang > wrote: > [..] >>> So, you are right that there is a mismatch here, but I think the >>> comprehensive fix is to allow early sections to be partially >>> depopulated/repopulated rather than have

Re: [PATCH -v2.1] x86/msr: Filter MSR writes

2020-06-24 Thread Sean Christopherson
On Mon, Jun 15, 2020 at 08:38:37AM +0200, Borislav Petkov wrote: > Here's an improved v2 with sparse warnings fixed: > > --- > Disable writing to MSRs from userspace by default. Writes can still be > allowed by supplying the allow_writes=1 module parameter and the kernel > will be tainted so that

Re: [RFC] Reed-Solomon Code: Update no_eras to the actual number of errors

2020-06-24 Thread Joe Perches
On Wed, 2020-06-24 at 22:35 -0700, Kees Cook wrote: > On Wed, Jun 24, 2020 at 09:10:53PM -0700, Aiden Leong wrote: > > Corr and eras_pos are updated to actual correction pattern and erasure > > positions, but no_eras is not. [] > > @@ -312,14 +313,21 @@ > >

Re: [PATCH 2/2] xen/privcmd: Convert get_user_pages*() to pin_user_pages*()

2020-06-24 Thread John Hubbard
On 2020-06-24 20:02, Souptick Joarder wrote: In 2019, we introduced pin_user_pages*() and now we are converting get_user_pages*() to the new API as appropriate. [1] & [2] could be referred for more information. This is case 5 as per document [1]. [1] Documentation/core-api/pin_user_pages.rst

Re: [PATCH 3/8] arm64: dts: qcom: sdm630: Add tsens node

2020-06-24 Thread Amit Kucheria
On Wed, Jun 24, 2020 at 8:32 PM Konrad Dybcio wrote: > > Interesting, the downstream DTS only mentions the 0x010AD one.. > Are you sure you're not looking at 636/660? > I looked a bit closer. So there are two instances of the controller but the platform doesn't have as many sensors. So using

RE: [PATCH -next] scsi: ufs: allow exynos ufs driver to build as module

2020-06-24 Thread Avri Altman
> > Allow Exynos UFS driver to build as a module. > This patch fix the below build issue reported by > kernel build robot. > > drivers/scsi/ufs/ufs-exynos.o: in function `exynos_ufs_probe': > drivers/scsi/ufs/ufs-exynos.c:1231: undefined reference to > `ufshcd_pltfrm_init' >

Re: [RFC] Reed-Solomon Code: Update no_eras to the actual number of errors

2020-06-24 Thread Kees Cook
On Wed, Jun 24, 2020 at 09:10:53PM -0700, Aiden Leong wrote: > Corr and eras_pos are updated to actual correction pattern and erasure > positions, but no_eras is not. > > When this library is used to recover lost bytes, we normally memset the > lost trunk of bytes to zero as a placeholder.

[PATCH] ring-buffer: speed up buffer resets by avoiding synchronize_rcu for each CPU

2020-06-24 Thread Nicholas Piggin
On a 144 thread system, `perf ftrace` takes about 20 seconds to start up, due to calling synchronize_rcu() for each CPU. cat /proc/108560/stack 0xc0003e7eb336f470 __switch_to+0x2e0/0x480 __wait_rcu_gp+0x20c/0x220 synchronize_rcu+0x9c/0xc0 ring_buffer_reset_cpu+0x88/0x2e0

[PATCH 5.7.y] erofs: fix partially uninitialized misuse in z_erofs_onlinepage_fixup

2020-06-24 Thread Gao Xiang
From: Gao Xiang commit 3c597282887fd55181578996dca52ce697d985a5 upstream. Hongyu reported "id != index" in z_erofs_onlinepage_fixup() with specific aarch64 environment easily, which wasn't shown before. After digging into that, I found that high 32 bits of page->private was set to 0x

Re: [PATCH v4 4/7] ACPI: button: Use input_device_enabled() helper

2020-06-24 Thread Dmitry Torokhov
On Mon, Jun 08, 2020 at 01:22:08PM +0200, Andrzej Pietrasiewicz wrote: > A new helper is available, so use it. > > Signed-off-by: Andrzej Pietrasiewicz > --- > drivers/acpi/button.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/acpi/button.c

Re: [Nouveau] [RESEND PATCH 1/3] nouveau: fix migrate page regression

2020-06-24 Thread Ben Skeggs
On Thu, 25 Jun 2020 at 15:23, Ben Skeggs wrote: > > On Tue, 23 Jun 2020 at 10:51, John Hubbard wrote: > > > > On 2020-06-22 16:38, Ralph Campbell wrote: > > > The patch to add zero page migration to GPU memory inadvertantly included > > > > inadvertently > > > > > part of a future change which

stable-rc/linux-5.6.y bisection: baseline.dmesg.crit on bcm2837-rpi-3-b

2020-06-24 Thread kernelci.org bot
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * This automated bisection report was sent to you on the basis * * that you may be involved with the breaking commit it has * * found. No manual investigation has been done to verify it, * * and the root cause of the

Re: [Nouveau] [RESEND PATCH 1/3] nouveau: fix migrate page regression

2020-06-24 Thread Ben Skeggs
On Tue, 23 Jun 2020 at 10:51, John Hubbard wrote: > > On 2020-06-22 16:38, Ralph Campbell wrote: > > The patch to add zero page migration to GPU memory inadvertantly included > > inadvertently > > > part of a future change which broke normal page migration to GPU memory > > by copying too much

Re: [PATCH v4 3/7] ACPI: button: Access input device's users under appropriate mutex

2020-06-24 Thread Dmitry Torokhov
On Wed, Jun 24, 2020 at 05:00:09PM +0200, Rafael J. Wysocki wrote: > On Mon, Jun 8, 2020 at 1:22 PM Andrzej Pietrasiewicz > wrote: > > > > Inspecting input device's 'users' member should be done under device's > > mutex, so add appropriate invocations. > > > > Signed-off-by: Andrzej Pietrasiewicz

[PATCH 5.4.y] erofs: fix partially uninitialized misuse in z_erofs_onlinepage_fixup

2020-06-24 Thread Gao Xiang
From: Gao Xiang commit 3c597282887fd55181578996dca52ce697d985a5 upstream. Hongyu reported "id != index" in z_erofs_onlinepage_fixup() with specific aarch64 environment easily, which wasn't shown before. After digging into that, I found that high 32 bits of page->private was set to 0x

[PATCH 4.19.y] erofs: fix partially uninitialized misuse in z_erofs_onlinepage_fixup

2020-06-24 Thread Gao Xiang
From: Gao Xiang commit 3c597282887fd55181578996dca52ce697d985a5 upstream. Hongyu reported "id != index" in z_erofs_onlinepage_fixup() with specific aarch64 environment easily, which wasn't shown before. After digging into that, I found that high 32 bits of page->private was set to 0x

Re: [PATCH 2/2][v3] PM / s2idle: Code cleanup to make s2idle consistent with normal idle path

2020-06-24 Thread Chen Yu
Hi Rafael, On Tue, Jun 23, 2020 at 07:57:59PM +0200, Rafael J. Wysocki wrote: > From: Rafael J. Wysocki > Subject: [PATCH] cpuidle: Rearrange s2idle-specific idle state entry code > > Implement call_cpuidle_s2idle() in analogy with call_cpuidle() > for the s2idle-specific idle state entry and

Re: [PATCH v6 1/6] tty: serial: qcom_geni_serial: Use OPP API to set clk/perf state

2020-06-24 Thread Bjorn Andersson
On Mon 15 Jun 05:02 PDT 2020, Rajendra Nayak wrote: > geni serial needs to express a perforamnce state requirement on CX > powerdomain depending on the frequency of the clock rates. > Use OPP table from DT to register with OPP framework and use > dev_pm_opp_set_rate() to set the clk/perf state. >

Re: [PATCH v3 08/15] arm64: kvm: Split hyp/switch.c to VHE/nVHE

2020-06-24 Thread kernel test robot
Hi David, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on linus/master] [also build test WARNING on v5.8-rc2 next-20200624] [cannot apply to kvmarm/next arm64/for-next/core arm-perf/for-next/perf] [If your patch is applied to the wrong git tree, kindly drop us

Re: [v2,net-next 2/4] net: enetc: add support max frame size for tc flower offload

2020-06-24 Thread David Miller
From: Po Liu Date: Wed, 24 Jun 2020 17:36:29 +0800 > From: Po Liu > > Base on the tc flower offload police action add max frame size by the > parameter 'mtu'. Tc flower device driver working by the IEEE 802.1Qci > stream filter can implement the max frame size filtering. Add it to the >

Re: [v2,net-next 1/4] net: qos: add tc police offloading action with max frame size limit

2020-06-24 Thread David Miller
From: Po Liu Date: Wed, 24 Jun 2020 17:36:28 +0800 > From: Po Liu > > Current police offloading support the 'burst'' and 'rate_bytes_ps'. Some > hardware own the capability to limit the frame size. If the frame size > larger than the setting, the frame would be dropped. For the police > action

Re: [v2,net-next 4/4] net: enetc add tc flower offload flow metering policing action

2020-06-24 Thread David Miller
From: Po Liu Date: Wed, 24 Jun 2020 17:36:31 +0800 > From: Po Liu > > Flow metering entries in IEEE 802.1Qci is an optional function for a > flow filtering module. Flow metering is two rates two buckets and three > color marker to policing the frames. This patch only enable one rate one >

Re: [v2,net-next 3/4] net: qos: police action add index for tc flower offloading

2020-06-24 Thread David Miller
From: Po Liu Date: Wed, 24 Jun 2020 17:36:30 +0800 > From: Po Liu > > Hardware device may include more than one police entry. Specifying the > action's index make it possible for several tc filters to share the same > police action when installing the filters. > > Propagate this index to

Re: [PATCH V8 0/8] Add interconnect support to QSPI and QUP drivers

2020-06-24 Thread Bjorn Andersson
On Tue 23 Jun 03:38 PDT 2020, Akash Asthana wrote: > This patch series is based on tag "next-20200622" of linux-next tree. > Series applied to the qcom tree, thank you and thanks for the Acks. Regards, Bjorn > High level design: > - QUP wrapper/common driver. >Vote for QUP core on behalf

ath9k broken [was: Linux 5.7.3]

2020-06-24 Thread Jiri Slaby
On 25. 06. 20, 0:05, Gabriel C wrote: > Am Mi., 17. Juni 2020 um 18:13 Uhr schrieb Greg Kroah-Hartman > : >> >> I'm announcing the release of the 5.7.3 kernel. >> > > Hello Greg, > >> Qiujun Huang (5): >> ath9k: Fix use-after-free Read in htc_connect_service >> ath9k: Fix

[Question]many kernel error "neighbour: ndisc_cache: neighbor table overflow!"

2020-06-24 Thread Jack Wang
Hi Folks, In one of our big cluster, due to capacity increase, more servers are added to the cluster, and we saw from many pserver reporting error message below: "neighbour: ndisc_cache: neighbor table overflow!" We've tested increasing the gc_thresh values in sysctl.conf, after reboot, the

Re: [PATCH net 0/3] net: bcmgenet: use hardware padding of runt frames

2020-06-24 Thread David Miller
From: Doug Berger Date: Wed, 24 Jun 2020 18:14:52 -0700 > Now that scatter-gather and tx-checksumming are enabled by default > it revealed a packet corruption issue that can occur for very short > fragmented packets. > > When padding these frames to the minimum length it is possible for > the

Re: [PATCH] venus: move buffer calculation to driver

2020-06-24 Thread dikshita
Hi Stanimir, A gentle reminder for the review. Thanks, Dikshita On 2020-06-09 17:24, Dikshita Agarwal wrote: Right now we get buffer requirements from fw. The call to get these requirements is a blocking call and takes a lot of time. This change calculates all the buffer requirement within

Re: [PATCH] venus: move platform specific data to platform file

2020-06-24 Thread dikshita
Hi Stanimir, A gentle reminder for the review. On 2020-05-29 12:37, Dikshita Agarwal wrote: Move all data specific to platform into a separate file. Signed-off-by: Dikshita Agarwal --- drivers/media/platform/qcom/venus/Makefile | 3 +- drivers/media/platform/qcom/venus/core.c

Re: [PATCH] venus: Add platform specific capabilities

2020-06-24 Thread dikshita
Hi Stanimir, A gentle reminder for the review. Thanks, Dikshita On 2020-05-29 12:48, Dikshita Agarwal wrote: Add platform specific capabilities and use them in place of firmware capabilities. Signed-off-by: Dikshita Agarwal --- drivers/media/platform/qcom/venus/core.c | 3 +

[PATCH v2] tpm: tpm2-space: Resize session and context buffers dynamically

2020-06-24 Thread Jarkko Sakkinen
Re-allocate context and session buffers when needed. Scale them in page increments so that the reallocation is only seldomly required, and thus causes minimal stress to the system. Add a static maximum limit of four pages for buffer sizes. Cc: James Bottomley Suggested-by: Stefan Berger

Re: [PATCH] tpm: tpm2-space: Resize session and context buffers dynamically

2020-06-24 Thread Jarkko Sakkinen
On Thu, Jun 25, 2020 at 07:24:20AM +0300, Jarkko Sakkinen wrote: > Re-allocate context and session buffers when needed. Scale them in page > increments so that the reallocation is only seldomly required, and thus > causes minimal stress to the system. Add a static maximum limit of four > pages for

[PATCH] tpm: tpm2-space: Resize session and context buffers dynamically

2020-06-24 Thread Jarkko Sakkinen
Re-allocate context and session buffers when needed. Scale them in page increments so that the reallocation is only seldomly required, and thus causes minimal stress to the system. Add a static maximum limit of four pages for buffer sizes. Cc: James Bottomley Suggested-by: Stefan Berger

Re: [PATCH v2 2/2] Add PWM fan controller driver for LGM SoC

2020-06-24 Thread Tanwar, Rahul
Hi Philipp, On 18/6/2020 8:25 pm, Philipp Zabel wrote: > Hi Rahul, > > On Thu, 2020-06-18 at 20:05 +0800, Rahul Tanwar wrote: >> Intel Lightning Mountain(LGM) SoC contains a PWM fan controller. >> This PWM controller does not have any other consumer, it is a >> dedicated PWM controller for fan

[RFC] Reed-Solomon Code: Update no_eras to the actual number of errors

2020-06-24 Thread Aiden Leong
Corr and eras_pos are updated to actual correction pattern and erasure positions, but no_eras is not. When this library is used to recover lost bytes, we normally memset the lost trunk of bytes to zero as a placeholder. Unfortunately, if the lost byte is zero, b[i] is zero too. Without correct

[tip:auto-latest] BUILD SUCCESS 9f2a2b6c23758d798f548911f6119def723d1029

2020-06-24 Thread kernel test robot
defconfig powerpc allyesconfig powerpc rhel-kconfig powerpc allmodconfig powerpc allnoconfig i386 randconfig-a002-20200624 i386 randconfig-a006

Re: KASAN: null-ptr-deref Write in blk_mq_map_swqueue

2020-06-24 Thread Bart Van Assche
On 2020-06-24 20:01, syzbot wrote: > This bug is marked as fixed by commit: > blk-mq: Fix a recently introduced regression in > But I can't find it in any tested tree for more than 90 days. > Is it a correct commit? Please update it by replying: > #syz fix: exact-commit-title > Until then the bug

Re: [PATCH] kernel/trace: Add TRACING_ALLOW_PRINTK config option

2020-06-24 Thread Alexei Starovoitov
On Thu, Jun 25, 2020 at 10:00:09AM +0800, Nicolas Boichat wrote: > On Thu, Jun 25, 2020 at 1:25 AM Alexei Starovoitov > wrote: > > > > On Wed, Jun 24, 2020 at 9:07 AM Steven Rostedt wrote: > > > > > > On Wed, 24 Jun 2020 16:45:24 +0800 > > > Nicolas Boichat wrote: > > > > > > > trace_printk is

Re: linux-next: build failure after merge of the rcu tree

2020-06-24 Thread Paul E. McKenney
On Thu, Jun 25, 2020 at 12:57:53PM +1000, Stephen Rothwell wrote: > Hi all, > > After merging the rcu tree, today's linux-next build (powerpc > ppc64_defconfig) failed like this: > > kernel/rcu/tree.c: In function 'rcu_dynticks_eqs_enter': > kernel/rcu/tree.c:251:8: error: implicit declaration

Re: linux-next: manual merge of the rcu tree with the tip tree

2020-06-24 Thread Paul E. McKenney
On Thu, Jun 25, 2020 at 12:44:52PM +1000, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the rcu tree got a conflict in: > > include/linux/smp.h > > between commit: > > 380dc20ce843 ("smp, irq_work: Continue smp_call_function*() and irq_work*() > integration") > > from

linux-next: build warning after merge of the scsi tree

2020-06-24 Thread Stephen Rothwell
Hi all, After merging the scsi tree, today's linux-next build (x86_64 allmodconfig) produced this warning: WARNING: modpost: missing MODULE_LICENSE() in drivers/scsi/ufs/ufs-exynos.o Introduced by commit 55f4b1f73631 ("scsi: ufs: ufs-exynos: Add UFS host support for Exynos SoCs") (not sure

Re: [PATCH 1/2] arm64: dts: qcom: sc7180: Switch SPI to use GPIO for CS

2020-06-24 Thread Doug Anderson
Hi, On Wed, Jun 24, 2020 at 6:25 PM Stephen Boyd wrote: > > Quoting Douglas Anderson (2020-06-24 17:08:04) > > The geni SPI protocol appears to have been designed without taking > > Linux needs into account. In all the normal flows it takes care of > > setting chip select itself. However,

Re: [PATCH v1 1/3] scsi: ufs: add write booster feature support

2020-06-24 Thread Stanley Chu
Hi Steev, On Wed, 2020-06-24 at 11:15 -0500, Steev Klimaszewski wrote: > On 6/23/20 8:53 PM, Stanley Chu wrote: > > Hi Steev, > > > > Please help try below simple patch to see if above WriteBooster messages > > can be eliminated. > > > > > > --- > > drivers/scsi/ufs/ufshcd.c | 2 ++ > > 1 file

[PATCH v1] driver core: Fix suspend/resume order issue with deferred probe

2020-06-24 Thread Saravana Kannan
Under the following conditions: - driver A is built in and can probe device-A - driver B is a module and can probe device-B - device-A is supplier of device-B Without this patch: 1. device-A is added. 2. device-B is added. 3. dpm_list is now [device-A, device-B]. 4. driver-A defers probe of

Re: [PATCH v3 0/2] net: phy: call phy_disable_interrupts() in phy_init_hw()

2020-06-24 Thread Florian Fainelli
On 6/24/2020 4:34 PM, David Miller wrote: > From: Florian Fainelli > Date: Wed, 24 Jun 2020 15:10:51 -0700 > >> Did you mean that you applied v4? It does not look like you pushed your >> local changes to net-next yet, so I cannot tell for sure. > > I ended up applying v4, yes. > OK, just

[PATCH v2] scsi: ufs: Disable WriteBooster capability in non-supported UFS device

2020-06-24 Thread Stanley Chu
If UFS device is not qualified to enter the detection of WriteBooster probing by disallowed UFS version or device quirks, then WriteBooster capability in host shall be disabled to prevent any WriteBooster operations in the future. Fixes: 3d17b9b5ab11 ("scsi: ufs: Add write booster feature

Re: KASAN: null-ptr-deref Write in blk_mq_map_swqueue

2020-06-24 Thread syzbot
This bug is marked as fixed by commit: blk-mq: Fix a recently introduced regression in But I can't find it in any tested tree for more than 90 days. Is it a correct commit? Please update it by replying: #syz fix: exact-commit-title Until then the bug is still considered open and new crashes with

linux-next: build failure after merge of the rcu tree

2020-06-24 Thread Stephen Rothwell
Hi all, After merging the rcu tree, today's linux-next build (powerpc ppc64_defconfig) failed like this: kernel/rcu/tree.c: In function 'rcu_dynticks_eqs_enter': kernel/rcu/tree.c:251:8: error: implicit declaration of function 'arch_atomic_add_return'; did you mean 'atomic_add_return'?

[PATCH 1/2] xen/privcmd: Corrected error handling path and mark pages dirty

2020-06-24 Thread Souptick Joarder
Previously, if lock_pages() end up partially mapping pages, it used to return -ERRNO due to which unlock_pages() have to go through each pages[i] till *nr_pages* to validate them. This can be avoided by passing correct number of partially mapped pages & -ERRNO separately, while returning from

[PATCH 2/2] xen/privcmd: Convert get_user_pages*() to pin_user_pages*()

2020-06-24 Thread Souptick Joarder
In 2019, we introduced pin_user_pages*() and now we are converting get_user_pages*() to the new API as appropriate. [1] & [2] could be referred for more information. This is case 5 as per document [1]. [1] Documentation/core-api/pin_user_pages.rst [2] "Explicit pinning of user-space pages":

Re: [PATCH v5 1/2] acpi: Extend TPM2 ACPI table with missing log fields

2020-06-24 Thread Jarkko Sakkinen
On Thu, Jun 25, 2020 at 05:52:56AM +0300, Jarkko Sakkinen wrote: > On Thu, Jun 25, 2020 at 05:34:38AM +0300, Jarkko Sakkinen wrote: > > On Wed, Jun 24, 2020 at 08:38:25PM -0400, Stefan Berger wrote: > > > On 6/24/20 8:00 PM, Jarkko Sakkinen wrote: > > > > On Tue, Jun 23, 2020 at 08:06:35AM -0400,

Re: [PATCH v5 1/2] acpi: Extend TPM2 ACPI table with missing log fields

2020-06-24 Thread Jarkko Sakkinen
On Thu, Jun 25, 2020 at 05:34:38AM +0300, Jarkko Sakkinen wrote: > On Wed, Jun 24, 2020 at 08:38:25PM -0400, Stefan Berger wrote: > > On 6/24/20 8:00 PM, Jarkko Sakkinen wrote: > > > On Tue, Jun 23, 2020 at 08:06:35AM -0400, Stefan Berger wrote: > > > > From: Stefan Berger > > > > > > > > Recent

[PATCH] [net/ipv6] Remove redundant null check in rt_mt6

2020-06-24 Thread Gaurav Singh
rh cannot be NULL here since its already checked above assignment and is being dereferenced before. Remove the redundant null check. Signed-off-by: Gaurav Singh --- net/ipv6/netfilter/ip6t_rt.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/ipv6/netfilter/ip6t_rt.c

Re: [PATCH 05/10] mfd: sprd-sc27xx-spi: Fix symbol 'sprd_pmic_detect_charger_type' was not declared warning

2020-06-24 Thread Baolin Wang
Hi Lee, On Wed, Jun 24, 2020 at 11:07 PM Lee Jones wrote: > > Sparse reports: > > drivers/mfd/sprd-sc27xx-spi.c:59:23: warning: symbol > 'sprd_pmic_detect_charger_type' was not declared. Should it be static? > > ... due to a missing header file. > > Cc: > Cc: Orson Zhai > Cc: Baolin Wang >

[PATCH] [net/ipv6] Remove redundant null check in hbh_mt6

2020-06-24 Thread Gaurav Singh
oh cannot be NULL since its already checked above after assignment and is being dereferenced before. Remove the redundant null check. Signed-off-by: Gaurav Singh --- net/ipv6/netfilter/ip6t_hbh.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/ipv6/netfilter/ip6t_hbh.c

linux-next: manual merge of the rcu tree with the tip tree

2020-06-24 Thread Stephen Rothwell
Hi all, Today's linux-next merge of the rcu tree got a conflict in: include/linux/smp.h between commit: 380dc20ce843 ("smp, irq_work: Continue smp_call_function*() and irq_work*() integration") from the tip tree and commit: 7effc6f7b465 ("EXP kernel/smp: Provide CSD lock timeout

[PATCH] [net/ipv6] remove redundant null check in frag_mt6

2020-06-24 Thread Gaurav Singh
fh cannot be NULL since its already checked above after assignment and is being dereferenced before. Remove the redundant null check. Signed-off-by: Gaurav Singh --- net/ipv6/netfilter/ip6t_frag.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

[PATCH] [net/ipv6] Remove redundant null check in ah_mt6

2020-06-24 Thread Gaurav Singh
ah cannot be NULL since its already checked above after assignment and is being dereferenced before in pr(). Remove the redundant null check. Signed-off-by: Gaurav Singh --- net/ipv6/netfilter/ip6t_ah.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git

cocci script from 2016 - assignment in if ?

2020-06-24 Thread joe
https://lore.kernel.org/patchwork/patch/649705/ Any particular reason this wasn't applied? I ask because I added something similar recently to checkpatch.

Re: [PATCH v5 1/2] acpi: Extend TPM2 ACPI table with missing log fields

2020-06-24 Thread Jarkko Sakkinen
On Wed, Jun 24, 2020 at 08:38:25PM -0400, Stefan Berger wrote: > On 6/24/20 8:00 PM, Jarkko Sakkinen wrote: > > On Tue, Jun 23, 2020 at 08:06:35AM -0400, Stefan Berger wrote: > > > From: Stefan Berger > > > > > > Recent extensions of the TPM2 ACPI table added 3 more fields > > > including 12

Re: [PATCH 1/5] Huawei BMA: Adding Huawei BMA driver: host_edma_drv

2020-06-24 Thread kernel test robot
Hi, Thank you for the patch! Yet something to improve: [auto build test ERROR on sparc-next/master] [also build test ERROR on linux/master linus/master ipvs/master v5.8-rc2] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use as

[PATCH v2] tpm_tis: Remove the HID IFX0102

2020-06-24 Thread Jarkko Sakkinen
Acer C720 running Linux v5.3 reports this in klog: tpm_tis: 1.2 TPM (device-id 0xB, rev-id 16) tpm tpm0: tpm_try_transmit: send(): error -5 tpm tpm0: A TPM error (-5) occurred attempting to determine the timeouts tpm_tis tpm_tis: Could not get TPM timeouts and durations tpm_tis 00:08: 1.2 TPM

Re: [PATCH] tpm_tis: Remove the HID IFX0102

2020-06-24 Thread Jarkko Sakkinen
On Thu, Jun 25, 2020 at 02:00:33AM +0300, Jarkko Sakkinen wrote: > Acer C720 running Linux v5.3 reports this in klog: > > tpm_tis: 1.2 TPM (device-id 0xB, rev-id 16) > tpm tpm0: tpm_try_transmit: send(): error -5 > tpm tpm0: A TPM error (-5) occurred attempting to determine the timeouts > tpm_tis

Re: [PATCH 02/22] kbuild: add support for Clang LTO

2020-06-24 Thread Nathan Chancellor
Hi Sami, On Wed, Jun 24, 2020 at 01:31:40PM -0700, 'Sami Tolvanen' via Clang Built Linux wrote: > This change adds build system support for Clang's Link Time > Optimization (LTO). With -flto, instead of ELF object files, Clang > produces LLVM bitcode, which is compiled into native code at link >

Re: [PATCH] powerpc/boot: Use address-of operator on section symbols

2020-06-24 Thread Nathan Chancellor
Hi Geoff, On Wed, Jun 24, 2020 at 06:18:48PM -0700, Geoff Levand wrote: > Hi Nathan, > > On 6/23/20 8:59 PM, Nathan Chancellor wrote: > > These are not true arrays, they are linker defined symbols, which are > > just addresses. Using the address of operator silences the warning > > and does not

Re: [PATCH v3 1/1] eventfd: implementation of EFD_MASK flag

2020-06-24 Thread Laurent Pinchart
Hi Damian, On Tue, Jun 23, 2020 at 06:21:28PM +0900, Damian Hobson-Garcia wrote: > On 2020-06-19 7:16 p.m., Paul Elder wrote: > > Hello Damian, Martin, and all, > > > > I came across this (quite old by now) patch to extend eventfd's polling > > functionality. I was wondering what happened to it

Re: [PATCH 1/3] v4l2-subdev: Add subdev ioctl support for ENUM/GET/SET INPUT

2020-06-24 Thread Laurent Pinchart
Hi Jacopo, On Wed, Jun 24, 2020 at 09:53:07AM +0200, Jacopo Mondi wrote: > On Tue, Jun 16, 2020 at 12:00:15PM +0200, Ramzi BEN MEFTAH wrote: > > From: Steve Longerbeam > > +Niklas, +Laurent > > Niklas, Laurent, how does this play with CAP_IO_MC ? I don't think it's related to CAP_IO_MC, but

Re: [PATCH] kernel/trace: Add TRACING_ALLOW_PRINTK config option

2020-06-24 Thread Nicolas Boichat
On Thu, Jun 25, 2020 at 1:25 AM Alexei Starovoitov wrote: > > On Wed, Jun 24, 2020 at 9:07 AM Steven Rostedt wrote: > > > > On Wed, 24 Jun 2020 16:45:24 +0800 > > Nicolas Boichat wrote: > > > > > trace_printk is only meant as a debugging tool, and should never be > > > compiled into production

Re: [PATCH v3 3/4] docs: Add documentation for user space client interface

2020-06-24 Thread Hemant Kumar
Hi Mani, On 6/18/20 11:39 PM, Manivannan Sadhasivam wrote: On Thu, Jun 11, 2020 at 11:13:43AM -0700, Hemant Kumar wrote: MHI user space client driver is creating device file node for user application to perform file operations. File operations are handled by MHI core driver. Currently Loopback

Re: [PATCH net 1/3] net: bcmgenet: re-remove bcmgenet_hfb_add_filter

2020-06-24 Thread Florian Fainelli
On 6/24/2020 6:14 PM, Doug Berger wrote: > This function was originally removed by Baoyou Xie in > commit e2072600a241 ("net: bcmgenet: remove unused function in > bcmgenet.c") to prevent a build warning. > > Some of the functions removed by Baoyou Xie are now used for > WAKE_FILTER support so

Re: [PATCH net 2/3] net: bcmgenet: use __be16 for htons(ETH_P_IP)

2020-06-24 Thread Florian Fainelli
On 6/24/2020 6:14 PM, Doug Berger wrote: > The 16-bit value that holds a short in network byte order should > be declared as a restricted big endian type to allow type checks > to succeed during assignment. > > Fixes: 3e370952287c ("net: bcmgenet: add support for ethtool rxnfc flows") >

Re: [PATCH net 3/3] net: bcmgenet: use hardware padding of runt frames

2020-06-24 Thread Florian Fainelli
On 6/24/2020 6:14 PM, Doug Berger wrote: > When commit 474ea9cafc45 ("net: bcmgenet: correctly pad short > packets") added the call to skb_padto() it should have been > located before the nr_frags parameter was read since that value > could be changed when padding packets with lengths between

Re: [PATCH v4 00/11] kunit: create a centralized executor to dispatch all KUnit tests

2020-06-24 Thread David Gow
Glad this is back out there: a couple of minor nitpicks below: On Thu, Jun 25, 2020 at 4:58 AM Brendan Higgins wrote: > > ## TL;DR > > This patchset adds a centralized executor to dispatch tests rather than > relying on late_initcall to schedule each test suite separately along > with a couple

Re: [PATCH drivers/misc 0/4] lkdtm: Various clean ups

2020-06-24 Thread Randy Dunlap
On 6/24/20 3:35 PM, Randy Dunlap wrote: > On 6/24/20 3:23 PM, Randy Dunlap wrote: >> On 6/24/20 3:01 PM, Richard Weinberger wrote: >>> On Wed, Jun 24, 2020 at 11:29 PM Randy Dunlap wrote: On 6/24/20 1:36 PM, Kees Cook wrote: > On Wed, Jun 24, 2020 at 09:23:25AM +0200, Richard

Re: [PATCH] kernel/trace: Add TRACING_ALLOW_PRINTK config option

2020-06-24 Thread Nicolas Boichat
On Thu, Jun 25, 2020 at 12:04 AM Steven Rostedt wrote: > > On Wed, 24 Jun 2020 16:45:24 +0800 > Nicolas Boichat wrote: > > > trace_printk is only meant as a debugging tool, and should never be > > compiled into production code without source code changes, as > > indicated by the warning that

Re: [PATCH v33 02/21] x86/cpufeatures: x86/msr: Add Intel SGX Launch Control hardware bits

2020-06-24 Thread Jarkko Sakkinen
On Wed, Jun 24, 2020 at 07:34:40AM -0700, Sean Christopherson wrote: > On Wed, Jun 24, 2020 at 03:04:34PM +0200, Borislav Petkov wrote: > > On Thu, Jun 18, 2020 at 01:08:24AM +0300, Jarkko Sakkinen wrote: > > > From: Sean Christopherson > > > > > > Add X86_FEATURE_SGX_LC, which informs whether

Re: Null-ptr-deref due to "vfs, fsinfo: Add an RCU safe per-ns mount list"

2020-06-24 Thread Stephen Rothwell
Hi all, On Wed, 24 Jun 2020 11:57:07 -0400 Qian Cai wrote: > > On Wed, May 13, 2020 at 12:29:52AM +0100, David Howells wrote: > > Qian Cai wrote: > > > > > Reverted the linux-next commit ee8ad8190cb1 (“vfs, fsinfo: Add an RCU > > > safe per-ns mount list”) fixed the null-ptr-deref. > > >

Re: [PATCH v33 01/21] x86/cpufeatures: x86/msr: Add Intel SGX hardware bits

2020-06-24 Thread Jarkko Sakkinen
On Mon, Jun 22, 2020 at 07:37:11PM +0200, Borislav Petkov wrote: > On Thu, Jun 18, 2020 at 01:08:23AM +0300, Jarkko Sakkinen wrote: > > From: Sean Christopherson > > > > Add X86_FEATURE_SGX from CPUID.(EAX=7, ECX=1), which informs whether the > > CPU has SGX. > > > > Add X86_FEATURE_SGX1 and

Re: [PATCH 1/2] arm64: dts: qcom: sc7180: Switch SPI to use GPIO for CS

2020-06-24 Thread Stephen Boyd
Quoting Douglas Anderson (2020-06-24 17:08:04) > The geni SPI protocol appears to have been designed without taking > Linux needs into account. In all the normal flows it takes care of > setting chip select itself. However, Linux likes to manage the chip > select so it can do fancy things. > >

Re: [PATCH] powerpc/boot: Use address-of operator on section symbols

2020-06-24 Thread Geoff Levand
Hi Nathan, On 6/23/20 8:59 PM, Nathan Chancellor wrote: > These are not true arrays, they are linker defined symbols, which are > just addresses. Using the address of operator silences the warning > and does not change the resulting assembly with either clang/ld.lld > or gcc/ld (tested with diff

[PATCH net 2/3] net: bcmgenet: use __be16 for htons(ETH_P_IP)

2020-06-24 Thread Doug Berger
The 16-bit value that holds a short in network byte order should be declared as a restricted big endian type to allow type checks to succeed during assignment. Fixes: 3e370952287c ("net: bcmgenet: add support for ethtool rxnfc flows") Reported-by: kbuild test robot Signed-off-by: Doug Berger

Re: [PATCH v5 00/27] clk: bcm: rpi: Add support for BCM2711 firmware clocks

2020-06-24 Thread Stephen Boyd
Quoting Maxime Ripard (2020-06-15 01:40:40) > Hi, > > Since the whole DRM/HDMI support began to grow fairly big, I've chosen > to split away the two discussions between the firmware clocks and the > HDMI support. > I see one problem. WARNING: modpost: missing MODULE_LICENSE() in

[PATCH net 1/3] net: bcmgenet: re-remove bcmgenet_hfb_add_filter

2020-06-24 Thread Doug Berger
This function was originally removed by Baoyou Xie in commit e2072600a241 ("net: bcmgenet: remove unused function in bcmgenet.c") to prevent a build warning. Some of the functions removed by Baoyou Xie are now used for WAKE_FILTER support so his commit was reverted, but this function is still

[PATCH net 3/3] net: bcmgenet: use hardware padding of runt frames

2020-06-24 Thread Doug Berger
When commit 474ea9cafc45 ("net: bcmgenet: correctly pad short packets") added the call to skb_padto() it should have been located before the nr_frags parameter was read since that value could be changed when padding packets with lengths between 55 and 59 bytes (inclusive). The use of a stale

[PATCH net 0/3] net: bcmgenet: use hardware padding of runt frames

2020-06-24 Thread Doug Berger
Now that scatter-gather and tx-checksumming are enabled by default it revealed a packet corruption issue that can occur for very short fragmented packets. When padding these frames to the minimum length it is possible for the non-linear (fragment) data to be added to the end of the linear header

Re: [PATCH] kernel/trace: Add TRACING_ALLOW_PRINTK config option

2020-06-24 Thread Nicolas Boichat
On Wed, Jun 24, 2020 at 9:57 PM Jason Gunthorpe wrote: > > On Wed, Jun 24, 2020 at 04:45:24PM +0800, Nicolas Boichat wrote: > > trace_printk is only meant as a debugging tool, and should never be > > compiled into production code without source code changes, as > > indicated by the warning that

Re: [v3] arm64: dts: sc7180: add nodes for idp display

2020-06-24 Thread Stephen Boyd
Quoting Harigovindan P (2020-02-17 00:58:42) > diff --git a/arch/arm64/boot/dts/qcom/sc7180-idp.dts > b/arch/arm64/boot/dts/qcom/sc7180-idp.dts > index 388f50ad4fde..349db8fe78a5 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180-idp.dts > +++ b/arch/arm64/boot/dts/qcom/sc7180-idp.dts > @@ -232,6

[rcu:rcu/urgent 1/1] kernel/rcu/tree.c:253:8: error: implicit declaration of function 'arch_atomic_add_return'; did you mean

2020-06-24 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git rcu/urgent head: 239341154165cec3676955bab4cc1d61852257ed commit: 239341154165cec3676955bab4cc1d61852257ed [1/1] rcu: Fixup noinstr warnings config: m68k-randconfig-r016-20200624 (attached as .config) compiler: m68k

Re: [PATCH 3/3] x86/ptrace: Fix 32-bit PTRACE_SETREGS vs fsbase and gsbase

2020-06-24 Thread Andy Lutomirski
On Wed, Jun 24, 2020 at 3:50 PM Andy Lutomirski wrote: > > Debuggers expect that doing PTRACE_GETREGS, then poking at a tracee > and maybe letting it run for a while, then doing PTRACE_SETREGS will > put the tracee back where it was. In the specific case of a 32-bit > tracer and tracee, the

Re: [GIT PULL] erofs fixes for 5.8-rc3

2020-06-24 Thread pr-tracker-bot
The pull request you sent on Thu, 25 Jun 2020 05:08:53 +0800: > git://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs.git > tags/erofs-for-5.8-rc3-fixes has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/8be3a53e18e0e1a98f288f6c7f5e9da3adbe9c49 Thank you! --

Re: [GIT PULL] virtio: fixes, tests

2020-06-24 Thread pr-tracker-bot
The pull request you sent on Wed, 24 Jun 2020 05:08:01 -0400: > https://git.kernel.org/pub/scm/linux/kernel/git/mst/vhost.git tags/for_linus has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/fc10807db5ced090d83cec167e87c95a47452d24 Thank you! -- Deet-doot-dot, I am a

[RESEND PATCH v10] dt-bindings: ufs: Add bindings for Samsung ufs host

2020-06-24 Thread Alim Akhtar
This patch adds DT bindings for Samsung ufs hci Reviewed-by: Rob Herring Signed-off-by: Alim Akhtar --- Hi Rob This is just a rebase on your's dt/next This patch was part of [1] [1] https://lkml.org/lkml/2020/5/27/1697 .../bindings/ufs/samsung,exynos-ufs.yaml | 89 +++

Re: [PATCH v5 27/27] clk: bcm: rpi: Remove the quirks for the CPU clock

2020-06-24 Thread Stephen Boyd
Quoting Maxime Ripard (2020-06-15 01:41:07) > The CPU clock has had so far a bunch of quirks to expose the clock tree > properly, but since we reverted to exposing them through the MMIO driver, > we can remove that code from the firmware driver. > > Acked-by: Nicolas Saenz Julienne > Tested-by:

Re: [PATCH v5 25/27] clk: bcm2835: Allow custom CCF flags for the PLLs

2020-06-24 Thread Stephen Boyd
Quoting Maxime Ripard (2020-06-15 01:41:05) > While some clock types allow for each clock to specify its own custom > flags, the PLLs can't. We will need this for the PLLB, so let's add it. > > Acked-by: Nicolas Saenz Julienne > Tested-by: Nicolas Saenz Julienne > Signed-off-by: Maxime Ripard

Re: [PATCH v5 26/27] clk: bcm2835: Don't cache the PLLB rate

2020-06-24 Thread Stephen Boyd
Quoting Maxime Ripard (2020-06-15 01:41:06) > The PLLB rate will be changed through the firmware clocks drivers and will > change behind this drivers' back, so we don't want to cache the rate. > > Acked-by: Nicolas Saenz Julienne > Tested-by: Nicolas Saenz Julienne > Signed-off-by: Maxime

Re: [PATCH v5 18/27] clk: bcm: rpi: Make the PLLB registration function return a clk_hw

2020-06-24 Thread Stephen Boyd
Quoting Maxime Ripard (2020-06-15 01:40:58) > The raspberrypi_register_pllb has been returning an integer so far to > notify whether the functions has exited successfully or not. > > However, the OF provider functions in the clock framework require access to > the clk_hw structure so that we can

Re: [PATCH v5 22/27] clk: bcm: rpi: Give firmware clocks a name

2020-06-24 Thread Stephen Boyd
Quoting Maxime Ripard (2020-06-15 01:41:02) > We've registered the firmware clocks using their ID as name, but it's much > more convenient to register them using their proper name. Since the > firmware doesn't provide it, we have to duplicate it. > > Acked-by: Nicolas Saenz Julienne > Tested-by:

Re: [PATCH v5 20/27] clk: bcm: rpi: Add an enum for the firmware clocks

2020-06-24 Thread Stephen Boyd
Quoting Maxime Ripard (2020-06-15 01:41:00) > While the firmware allows us to discover the available clocks, we need to > discriminate those clocks to only register the ones meaningful to Linux. > The firmware also doesn't provide a clock name, so having a list of the ID > will help us to give

Re: [PATCH v5 23/27] Revert "clk: bcm2835: remove pllb"

2020-06-24 Thread Stephen Boyd
Quoting Maxime Ripard (2020-06-15 01:41:03) > This reverts commit 2256d89333bd17b8b56b42734a7e1046d52f7fc3. Since we > will be expanding the firmware clock driver, we'll need to remove the > quirks to deal with the PLLB. However, we still want to expose the clock > tree properly, so having that

  1   2   3   4   5   6   7   8   9   10   >