Re: [v2 1/4] coccinelle: api: extend memdup_user transformation with GFP_USER

2020-07-17 Thread Markus Elfring
> Applied. Do you care for patch review concerns according to this SmPL script adjustment? * https://lore.kernel.org/cocci/5c0dae88-e172-3ba6-f86c-d1a6238bb...@web.de/ https://lkml.org/lkml/2020/6/9/568 * https://lore.kernel.org/cocci/c3464cad-e567-9ef5-b4e3-a01e3b111...@web.de/

Re: [GIT PULL] EFI fixes for v5.8-rc

2020-07-17 Thread Ard Biesheuvel
On Thu, 9 Jul 2020 at 16:28, Ard Biesheuvel wrote: > > The following changes since commit 2a55280a3675203496d302463b941834228b9875: > > efi/libstub: arm: Print CPU boot mode and MMU state at boot (2020-06-17 > 15:29:11 +0200) > > are available in the Git repository at: > >

Re: [PATCH 1/3] media: rkvdec: Fix H264 scaling list order

2020-07-17 Thread Mauro Carvalho Chehab
Em Sat, 18 Jul 2020 07:05:54 +0200 Mauro Carvalho Chehab escreveu: > From: Jonas Karlman > > The Rockchip Video Decoder driver is expecting that the values in a > scaling list are in zig-zag order and applies the inverse scanning process > to get the values in matrix order. > > Commit

Re: [RFC][PATCH] x86: optimization to avoid CAL+RES IPIs

2020-07-17 Thread Josh Don
Hey Andy, thanks for taking a look. On Fri, Jul 17, 2020 at 8:14 PM Andy Lutomirski wrote: > > PeterZ and I fixed a whole series of bugs a few years ago, and remote > wakeups *should* already do this. Did we miss something? Did it > regress? Even the call_function_single path ought to go

Re: [PATCH RFC V2 12/17] memremap: Add zone device access protection

2020-07-17 Thread Ira Weiny
On Fri, Jul 17, 2020 at 11:17:18AM +0200, Peter Zijlstra wrote: > On Fri, Jul 17, 2020 at 12:20:51AM -0700, ira.we...@intel.com wrote: > > +void dev_access_disable(void) > > +{ > > + unsigned long flags; > > + > > + if (!static_branch_unlikely(_protection_static_key)) > > + return; >

[PATCH] mt76: mt76u: add missing release on skb in __mt76x02u_mcu_send_msg

2020-07-17 Thread Navid Emamdoost
In the implementation of __mt76x02u_mcu_send_msg() the skb is consumed all execution paths except one. Release skb before returning if test_bit() fails. Signed-off-by: Navid Emamdoost --- drivers/net/wireless/mediatek/mt76/mt76x02_usb_mcu.c | 7 +-- 1 file changed, 5 insertions(+), 2

Re: [PATCH v5 03/17] perf ftrace: add option -t/--tid to filter by thread id

2020-07-17 Thread Changbin Du
On Fri, Jul 17, 2020 at 01:01:24PM -0400, Steven Rostedt wrote: > On Fri, 17 Jul 2020 21:26:50 +0800 > Changbin Du wrote: > > > On Thu, Jul 16, 2020 at 12:36:30PM -0300, Arnaldo Carvalho de Melo wrote: > > > Em Sat, Jul 11, 2020 at 08:40:21PM +0800, Changbin Du escreveu: > > > > This allows us

Re: [PATCH 06/13] fs/kernel_read_file: Remove redundant size argument

2020-07-17 Thread Scott Branden
Hi Kees, On 2020-07-17 3:06 p.m., Kees Cook wrote: On Fri, Jul 17, 2020 at 12:04:18PM -0700, Scott Branden wrote: On 2020-07-17 10:43 a.m., Kees Cook wrote: In preparation for refactoring kernel_read_file*(), remove the redundant "size" argument which is not needed: it can be included in the

Re: [PATCH v5 0/7] x86/boot: Remove run-time relocations from compressed kernel

2020-07-17 Thread Ard Biesheuvel
On Fri, 17 Jul 2020 at 21:17, Nick Desaulniers wrote: > > On Fri, Jul 17, 2020 at 6:46 AM Arvind Sankar wrote: > > > > On Tue, Jul 14, 2020 at 08:41:26PM -0400, Arvind Sankar wrote: > > > The compressed kernel currently contains bogus run-time relocations in > > > the startup code in

[PATCH] arm64: dts: meson: update spifc node name on Khadas VIM3/VIM3L

2020-07-17 Thread Christian Hewitt
The VIM3/VIM3L Boards use w25q128 not w25q32 - this is a cosmetic change only - the device probes fine with the current device-tree. Fixes: 0e1610e726d3 ("arm64: dts: khadas-vim3: add SPIFC controller node") Signed-off-by: Christian Hewitt --- arch/arm64/boot/dts/amlogic/meson-khadas-vim3.dtsi

[PATCH] arm64: dts: meson: fix mmc0 tuning error on Khadas VIM3

2020-07-17 Thread Christian Hewitt
Similar to other G12B devices using the W400 dtsi, I see reports of mmc0 tuning errors on VIM3 after a few hours uptime: [12483.917391] mmc0: tuning execution failed: -5 [30535.551221] mmc0: tuning execution failed: -5 [35359.953671] mmc0: tuning execution failed: -5 [35561.875332] mmc0: tuning

[PATCH] nfc: s3fwrn5: add missing release on skb in s3fwrn5_recv_frame

2020-07-17 Thread Navid Emamdoost
The implementation of s3fwrn5_recv_frame() is supposed to consume skb on all execution paths. Release skb before returning -ENODEV. Signed-off-by: Navid Emamdoost --- drivers/nfc/s3fwrn5/core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/nfc/s3fwrn5/core.c

[PATCH] arm64: dts: meson: misc fixups for w400 dtsi

2020-07-17 Thread Christian Hewitt
Current devices using the W400 dtsi show mmc tuning errors: [12483.917391] mmc0: tuning execution failed: -5 [30535.551221] mmc0: tuning execution failed: -5 [35359.953671] mmc0: tuning execution failed: -5 [35561.875332] mmc0: tuning execution failed: -5 [61733.348709] mmc0: tuning execution

Re: [PATCH] tools/memory-model: document the "one-time init" pattern

2020-07-17 Thread Eric Biggers
On Sat, Jul 18, 2020 at 03:13:04AM +0100, Matthew Wilcox wrote: > On Fri, Jul 17, 2020 at 06:38:39PM -0700, Eric Biggers wrote: > > On Fri, Jul 17, 2020 at 06:47:50PM +0100, Matthew Wilcox wrote: > > > On Thu, Jul 16, 2020 at 09:44:27PM -0700, Eric Biggers wrote: > > > > +If that doesn't apply,

[tip:x86/platform] BUILD SUCCESS 3bcf25a40b018e632d70bb866d75746748953fbc

2020-07-17 Thread kernel test robot
randconfig-a001-20200717 i386 randconfig-a005-20200717 i386 randconfig-a002-20200717 i386 randconfig-a006-20200717 i386 randconfig-a003-20200717 i386 randconfig-a004-20200717 x86_64 randconfig-a012-20200716

[PATCH] mt7601u: add missing release on skb in mt7601u_mcu_msg_send

2020-07-17 Thread Navid Emamdoost
In the implementation of mt7601u_mcu_msg_send(), skb is supposed to be consumed on all execution paths. Release skb before returning if test_bit() fails. Signed-off-by: Navid Emamdoost --- drivers/net/wireless/mediatek/mt7601u/mcu.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff

[PATCH 2/2] arm64: dts: meson: add initial Beelink GS-King-X device-tree

2020-07-17 Thread Christian Hewitt
The Shenzen AZW (Beelink) GS-King-X is based on the Amlogic W400 reference board with an S922X-H chip. - 4GB LPDDR4 RAM - 64GB eMMC storage - 10/100/1000 Base-T Ethernet - AP6356S Wireless (802.11 a/b/g/n/ac, BT 4.1) - HDMI 2.1 video - S/PDIF optical output - 2x ESS9018 audio DACs - 4x Ricor

[PATCH 1/2] dt-bindings: arm: amlogic: add support for the Beelink GS-King-X

2020-07-17 Thread Christian Hewitt
The Shenzen AZW (Beelink) GS-King-X is based on the Amlogic W400 reference board with an S922X-H chip. Signed-off-by: Christian Hewitt --- Documentation/devicetree/bindings/arm/amlogic.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/arm/amlogic.yaml

[PATCH] cxgb4: add missing release on skb in uld_send()

2020-07-17 Thread Navid Emamdoost
In the implementation of uld_send(), the skb is consumed on all execution paths except one. Release skb when returning NET_XMIT_DROP. Signed-off-by: Navid Emamdoost --- drivers/net/ethernet/chelsio/cxgb4/sge.c | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH 1/3] media: rkvdec: Fix H264 scaling list order

2020-07-17 Thread Mauro Carvalho Chehab
From: Jonas Karlman The Rockchip Video Decoder driver is expecting that the values in a scaling list are in zig-zag order and applies the inverse scanning process to get the values in matrix order. Commit 0b0393d59eb4 ("media: uapi: h264: clarify expected scaling_list_4x4/8x8 order") clarified

Re: [PATCH RFC V2 12/17] memremap: Add zone device access protection

2020-07-17 Thread Ira Weiny
On Fri, Jul 17, 2020 at 11:10:53AM +0200, Peter Zijlstra wrote: > On Fri, Jul 17, 2020 at 12:20:51AM -0700, ira.we...@intel.com wrote: > > +static pgprot_t dev_protection_enable_get(struct dev_pagemap *pgmap, > > pgprot_t prot) > > +{ > > + if (pgmap->flags & PGMAP_PROT_ENABLED && dev_page_pkey

[PATCH 2/3] media: atomisp: fix the handling of clock number

2020-07-17 Thread Mauro Carvalho Chehab
Right now, the driver is not doing the right thing to detect the clock like used by the sensor, at least on devices without the gmin's EFI vars. Add some notes at the code to explain why and skip the wrong value provided by the _DSM table. Signed-off-by: Mauro Carvalho Chehab ---

[PATCH 3/3] media: atomisp: reorganize the code under gmin_subdev_add()

2020-07-17 Thread Mauro Carvalho Chehab
The gmin_subdev_add() currently doesn't use ACPI device power management. In order to prepare for adding support for it, let's shift some things, placing the PM-related stuff at the end of the probing logic. Let's also store the current gs on a temporary var, in order to simplify the source code.

[PATCH 2/2] arm64: dts: meson: add support for the WeTek Core 2

2020-07-17 Thread Christian Hewitt
The WeTek Core2 is a commercial device based on the Amlogic Q200 reference design but with the following differences: - 3GB RAM, 32GB eMMC - Blue and Red LEDs used to signal on/off status - uart_AO can be accessed after opening the case; soldering required - USB OTG is not accessible (inside the

[PATCH 1/2] dt-bindings: arm: amlogic: add support for the WeTek Core 2

2020-07-17 Thread Christian Hewitt
The WeTek Core 2 is a commercial Android device based on the Amlogic Q200 reference design using the S912-H chipset. Specs: 3GB DDR3 RAM 32GB eMMC storage 10/100 Ethernet using Realtek RTL8152 (internal USB) 802.11 a/b/g/n/ac + BT 4.1 sdio wireless module (AP6356S) 2x single colour LEDs to

Re: [PATCH] MIPS: Prevent READ_IMPLIES_EXEC propagation

2020-07-17 Thread YunQiang Su
_exec' > >>>> sufficient? > >>> We inherit the READ_IMPLIES_EXEC personality flag across fork(). > >>> If we do not explicitly clear this flag in SET_PERSONALITY2(), > >>> PROT_READ implies PROT_EXEC for mmap to make memory executable > >&g

[PATCH v4] pwm: bcm-iproc: handle clk_get_rate() return

2020-07-17 Thread Scott Branden
From: Rayagonda Kokatanur Handle clk_get_rate() returning 0 to avoid possible division by zero. Fixes: daa5abc41c80 ("pwm: Add support for Broadcom iProc PWM controller") Signed-off-by: Rayagonda Kokatanur Signed-off-by: Scott Branden Reviewed-by: Ray Jui --- Changes from v3: fixed typo in

Re: [PATCH v3 4/5] LSM: Define SELinux function to measure security state

2020-07-17 Thread kernel test robot
Hi Lakshmi, Thank you for the patch! Yet something to improve: [auto build test ERROR on integrity/next-integrity] [cannot apply to pcmoore-selinux/next security/next-testing linus/master v5.8-rc5 next-20200717] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

Re: [PATCH v3] x86/ioperm: Fix io bitmap invalidation on Xen PV

2020-07-17 Thread Jürgen Groß
On 18.07.20 01:53, Andy Lutomirski wrote: tss_invalidate_io_bitmap() wasn't wired up properly through the pvop machinery, so the TSS and Xen's io bitmap would get out of sync whenever disabling a valid io bitmap. Add a new pvop for tss_invalidate_io_bitmap() to fix it. This is XSA-329. Cc:

Re: [PATCH] m68k: Replace HTTP links with HTTPS ones

2020-07-17 Thread Finn Thain
On Fri, 17 Jul 2020, Alexander A. Klimov wrote: > Rationale: > Reduces attack surface on kernel devs opening the links for > MITM as HTTPS traffic is much harder to manipulate. > Has that actually happened? You still need to fix the chain of trust in all the relevant browsers (unless you're

drivers/edac/i10nm_base.c:149:19: sparse: sparse: cast removes address space '__iomem' of expression

2020-07-17 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 4ebf8d7649cd86c41c41bf48da4b7761da2d5009 commit: 670d0a4b10704667765f7d18f7592993d02783aa sparse: use identifiers to define address spaces date: 4 weeks ago config: x86_64-randconfig-s021-20200718

[PATCH v3 1/4] scsi: ufs: Add checks before setting clk-gating states

2020-07-17 Thread Can Guo
Clock gating features can be turned on/off selectively which means its state information is only important if it is enabled. This change makes sure that we only look at state of clk-gating if it is enabled. Signed-off-by: Can Guo --- drivers/scsi/ufs/ufshcd.c | 17 ++--- 1 file

[PATCH v3 4/4] scsi: ufs: Fix up and simplify error recovery mechanism

2020-07-17 Thread Can Guo
Current UFS error recovery mechanism has two major problems, and neither of them is rare. - Error recovery can be invoked from multiple paths, including hibern8 enter/exit, some vendor vops, ufshcd_eh_host_reset_handler(), resume and eh_work scheduled from IRQ context. Ultimately, these paths

[PATCH v3 3/4] ufs: ufs-qcom: Fix a few BUGs in func ufs_qcom_dump_dbg_regs()

2020-07-17 Thread Can Guo
Dumping testbus registers needs to sleep a bit intermittently as there are too many of them. Skip them for those contexts where sleep is not allowed. Meanwhile, if ufs_qcom_dump_dbg_regs() calls ufs_qcom_testbus_config() from ufshcd_suspend/resume and/or clk gate/ungate context,

[PATCH v3 2/4] scsi: ufs: Fix imbalanced scsi_block_reqs_cnt caused by ufshcd_hold()

2020-07-17 Thread Can Guo
The scsi_block_reqs_cnt increased in ufshcd_hold() is supposed to be decreased back in ufshcd_ungate_work() in a paired way. However, if specific ufshcd_hold/release sequences are met, it is possible that scsi_block_reqs_cnt is increased twice but only one ungate work is queued. To make sure

Re: [PATCH] MIPS: Prevent READ_IMPLIES_EXEC propagation

2020-07-17 Thread Tiezhu Yang
' sufficient? We inherit the READ_IMPLIES_EXEC personality flag across fork(). If we do not explicitly clear this flag in SET_PERSONALITY2(), PROT_READ implies PROT_EXEC for mmap to make memory executable even if used with the GCC option "-z noexecstack" when compile. With next-20200717 with

[PATCH v3] PCI: hv: Fix a timing issue which causes kdump to fail occasionally

2020-07-17 Thread Wei Hu
Kdump could fail sometime on Hyper-V guest over Accelerated Network interface. This is because the retry in hv_pci_enter_d0() relies on an asynchronous host event arriving before the guest calls hv_send_resources_allocated(). Fix the problem by moving retry to hv_pci_probe(), removing this

RE: [PATCH v2] PCI: hv: Fix a timing issue which causes kdump to fail occasionally

2020-07-17 Thread Wei Hu
> -Original Message- > From: Bjorn Helgaas > Sent: Saturday, July 18, 2020 4:11 AM > To: Wei Hu > Cc: KY Srinivasan ; Haiyang Zhang > ; Stephen Hemminger ; > wei@kernel.org; lorenzo.pieral...@arm.com; r...@kernel.org; > bhelg...@google.com; linux-hyp...@vger.kernel.org; linux- >

drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c:959:30: warning: variable 'topology' set but not used

2020-07-17 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 4ebf8d7649cd86c41c41bf48da4b7761da2d5009 commit: de3916c70a24e3e1bdbf6b0a77d75b069d8953d9 drm/msm/dpu: Track resources in global state date: 4 months ago config: arm-randconfig-r026-20200717 (attached

Re: [PATCH v5 0/6] capabilities: Introduce CAP_CHECKPOINT_RESTORE

2020-07-17 Thread Serge E. Hallyn
On Wed, Jul 15, 2020 at 04:49:48PM +0200, Adrian Reber wrote: > This is v5 of the 'Introduce CAP_CHECKPOINT_RESTORE' patchset. The > changes to v4 are: > > * split into more patches to have the introduction of >CAP_CHECKPOINT_RESTORE and the actual usage in different >patches > * reduce

Re: [PATCH] locking: fcntl.h: drop duplicated word in a comment

2020-07-17 Thread Matthew Wilcox
On Fri, Jul 17, 2020 at 07:54:13PM -0700, Randy Dunlap wrote: > +++ linux-next-20200714/include/uapi/asm-generic/fcntl.h > @@ -143,7 +143,7 @@ > * record locks, but are "owned" by the open file description, not the > * process. This means that they are inherited across fork() like BSD (flock)

Re: [PATCH v3 4/5] LSM: Define SELinux function to measure security state

2020-07-17 Thread kernel test robot
Hi Lakshmi, Thank you for the patch! Yet something to improve: [auto build test ERROR on integrity/next-integrity] [cannot apply to pcmoore-selinux/next security/next-testing linus/master v5.8-rc5 next-20200717] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

Re: [RFC][PATCH] x86: optimization to avoid CAL+RES IPIs

2020-07-17 Thread Andy Lutomirski
> On Jul 17, 2020, at 7:13 PM, Josh Don wrote: > > From: Venkatesh Pallipadi > > smp_call_function_single and smp_send_reschedule send unconditional IPI > to target CPU. However, if the target CPU is in some form of poll based > idle, we can do IPI-less wakeups. > > Doing this has certain

[PATCH net-next 4/4] net: dsa: Setup dsa_netdev_ops

2020-07-17 Thread Florian Fainelli
Now that we hav all the infrastructure in place for calling into the dsa_ptr->netdev_ops function pointers, install them when we configure the DSA CPU/management interface and tear them down. The flow is unchanged from before, but now we preserve equality of tests when network device drivers do

[PATCH net-next 0/4] net: dsa: Setup dsa_netdev_ops

2020-07-17 Thread Florian Fainelli
Hi David, Jakub, This patch series addresses the overloading of a DSA CPU/management interface's netdev_ops for the purpose of providing useful information from the switch side. Up until now we had duplicated the existing netdev_ops structure and added specific function pointers to return

[PATCH net-next 1/4] net: Wrap ndo_do_ioctl() to prepare for DSA stacked ops

2020-07-17 Thread Florian Fainelli
In preparation for adding another layer of call into a DSA stacked ops singleton, wrap the ndo_do_ioctl() call into dev_do_ioctl(). Signed-off-by: Florian Fainelli --- net/core/dev_ioctl.c | 24 +--- 1 file changed, 17 insertions(+), 7 deletions(-) diff --git

[PATCH net-next 2/4] net: dsa: Add wrappers for overloaded ndo_ops

2020-07-17 Thread Florian Fainelli
Add definitions for the dsa_netdevice_ops structure which is a subset of the net_device_ops structure for the specific operations that we care about overlaying on top of the DSA CPU port net_device and provide inline stubs that take core managing whether DSA code is reachable. Signed-off-by:

[PATCH net-next 3/4] net: Call into DSA netdevice_ops wrappers

2020-07-17 Thread Florian Fainelli
Make the core net_device code call into our ndo_do_ioctl() and ndo_get_phys_port_name() functions via the wrappers defined previously Signed-off-by: Florian Fainelli --- net/core/dev.c | 5 + net/core/dev_ioctl.c | 5 + 2 files changed, 10 insertions(+) diff --git

[PATCH v2] highmem: linux/highmem.h: fix duplicated words in a comment

2020-07-17 Thread Randy Dunlap
From: Randy Dunlap Change the doubled word "is" in a comment to "it is". Signed-off-by: Randy Dunlap Cc: Andrew Morton Cc: linux...@kvack.org --- v2: instead of dropping one "is", change to "it is" [thanks Willy] include/linux/highmem.h |2 +- 1 file changed, 1 insertion(+), 1

Re: [PATCH] LSM: drop duplicated words in header file comments

2020-07-17 Thread Serge E. Hallyn
On Fri, Jul 17, 2020 at 04:36:40PM -0700, Randy Dunlap wrote: > From: Randy Dunlap > > Drop the doubled words "the" and "and" in comments. > > Signed-off-by: Randy Dunlap > Cc: James Morris > Cc: "Serge E. Hallyn" Acked-by: Serge Hallyn > Cc: linux-security-mod...@vger.kernel.org > --- >

Re: [PATCH v2] usb: gadget: configfs: Fix use-after-free issue with udc_name

2020-07-17 Thread Macpaul Lin
On Sat, 2020-07-18 at 10:45 +0800, Macpaul Lin wrote: > From: Eddie Hung > Well, it's strange, I simply replaced the uploader's name to my colleague, git send-email pop up this line automatically. Shouldn't I do that kind of change. It did not happened before. Do I need to change it back and

Re: [PATCH] clang: linux/compiler-clang.h: drop duplicated word in a comment

2020-07-17 Thread Nathan Chancellor
On Fri, Jul 17, 2020 at 07:55:02PM -0700, Randy Dunlap wrote: > From: Randy Dunlap > > Drop the doubled word "the" in a comment. > > Signed-off-by: Randy Dunlap > Cc: clang-built-li...@googlegroups.com Reviewed-by: Nathan Chancellor > --- > include/linux/compiler-clang.h |2 +- > 1

Re: [PATCH] highmem: linux/highmem.h: drop duplicated word in a comment

2020-07-17 Thread Randy Dunlap
On 7/17/20 7:53 PM, Matthew Wilcox wrote: > On Fri, Jul 17, 2020 at 07:52:07PM -0700, Randy Dunlap wrote: >> * >> - * However when holding an atomic kmap is is not legal to sleep, so atomic >> + * However when holding an atomic kmap is not legal to sleep, so atomic > > instead, s/is/it/ >

[PATCH] linux/exportfs.h: drop duplicated word in a comment

2020-07-17 Thread Randy Dunlap
From: Randy Dunlap Drop the doubled word "a" in a comment. Signed-off-by: Randy Dunlap Cc: Alexander Viro Cc: linux-fsde...@vger.kernel.org --- include/linux/exportfs.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next-20200714.orig/include/linux/exportfs.h +++

[PATCH] clang: linux/compiler-clang.h: drop duplicated word in a comment

2020-07-17 Thread Randy Dunlap
From: Randy Dunlap Drop the doubled word "the" in a comment. Signed-off-by: Randy Dunlap Cc: clang-built-li...@googlegroups.com --- include/linux/compiler-clang.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next-20200714.orig/include/linux/compiler-clang.h +++

Re: [PATCH] capabilities: Replace HTTP links with HTTPS ones

2020-07-17 Thread Serge E. Hallyn
On Mon, Jul 13, 2020 at 12:34:28PM +0200, Alexander A. Klimov wrote: > Rationale: > Reduces attack surface on kernel devs opening the links for MITM > as HTTPS traffic is much harder to manipulate. > > Deterministic algorithm: > For each file: > If not .svg: > For each line: > If

[PATCH] linux/async_tx.h: drop duplicated word in a comment

2020-07-17 Thread Randy Dunlap
From: Randy Dunlap Drop the doubled word "the" in a comment. Signed-off-by: Randy Dunlap Cc: Dan Williams --- include/linux/async_tx.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next-20200714.orig/include/linux/async_tx.h +++

[PATCH] locking: fcntl.h: drop duplicated word in a comment

2020-07-17 Thread Randy Dunlap
From: Randy Dunlap Drop the doubled word "the" in a comment. Signed-off-by: Randy Dunlap Cc: Jeff Layton Cc: "J. Bruce Fields" Cc: linux-fsde...@vger.kernel.org --- include/uapi/asm-generic/fcntl.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ---

[PATCH] linux/mdev.h: drop duplicated word in a comment

2020-07-17 Thread Randy Dunlap
From: Randy Dunlap Drop the doubled word "a" in a comment. Signed-off-by: Randy Dunlap Cc: Kirti Wankhede Cc: k...@vger.kernel.org --- include/linux/mdev.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next-20200714.orig/include/linux/mdev.h +++

Re: [PATCH] highmem: linux/highmem.h: drop duplicated word in a comment

2020-07-17 Thread Matthew Wilcox
On Fri, Jul 17, 2020 at 07:52:07PM -0700, Randy Dunlap wrote: > * > - * However when holding an atomic kmap is is not legal to sleep, so atomic > + * However when holding an atomic kmap is not legal to sleep, so atomic instead, s/is/it/

[PATCH] highmem: linux/highmem.h: drop duplicated word in a comment

2020-07-17 Thread Randy Dunlap
From: Randy Dunlap Drop the doubled word "is" in a comment. Signed-off-by: Randy Dunlap Cc: Andrew Morton Cc: linux...@kvack.org --- include/linux/highmem.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next-20200714.orig/include/linux/highmem.h +++

Re: Re: Re: Re: [PATCH v18 06/14] mm/damon: Implement callbacks for the virtual memory address spaces

2020-07-17 Thread SeongJae Park
On Fri, 17 Jul 2020 19:23:28 -0700 Shakeel Butt wrote: > On Fri, Jul 17, 2020 at 9:24 AM SeongJae Park wrote: > > > > On Fri, 17 Jul 2020 08:17:09 -0700 Shakeel Butt wrote: > > > > > On Thu, Jul 16, 2020 at 11:54 PM SeongJae Park wrote: > > > > > > > > On Thu, 16 Jul 2020 17:46:54 -0700

[PATCH] frontswap: linux/frontswap.h: drop duplicated word in a comment

2020-07-17 Thread Randy Dunlap
From: Randy Dunlap Drop the doubled word "in" in a comment. Signed-off-by: Randy Dunlap Cc: Konrad Rzeszutek Wilk Cc: Andrew Morton Cc: linux...@kvack.org --- include/linux/frontswap.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ---

[PATCH] dmaengine: linux/dmaengine.h: drop duplicated word in a comment

2020-07-17 Thread Randy Dunlap
From: Randy Dunlap Drop the doubled word "has" in a comment. Signed-off-by: Randy Dunlap Cc: Vinod Koul Cc: dmaeng...@vger.kernel.org --- include/linux/dmaengine.h |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next-20200714.orig/include/linux/dmaengine.h +++

Re: [PATCH v18 02/14] mm: Introduce Data Access MONitor (DAMON)

2020-07-17 Thread Shakeel Butt
On Mon, Jul 13, 2020 at 1:43 AM SeongJae Park wrote: > > From: SeongJae Park > > DAMON is a data access monitoring framework subsystem for the Linux > kernel. The core mechanisms of DAMON make it > > - accurate (the monitoring output is useful enough for DRAM level >memory management; It

[PATCH v2] usb: gadget: configfs: Fix use-after-free issue with udc_name

2020-07-17 Thread Macpaul Lin
From: Eddie Hung There is a use-after-free issue, if access udc_name in function gadget_dev_desc_UDC_store after another context free udc_name in function unregister_gadget. Context 1: gadget_dev_desc_UDC_store()->unregister_gadget()-> free udc_name->set udc_name to NULL Context 2:

Re: [External] Re: [PATCH RESEND] smp: Fix a potential usage of stale nr_cpus

2020-07-17 Thread Muchun Song
On Sat, Jul 18, 2020 at 4:15 AM Thomas Gleixner wrote: > > Muchun, > > Muchun Song writes: > > > The get_option() maybe return 0, it means that the nr_cpus is > > not initialized. > > Good catch, but see below. > > > Then we will use the stale nr_cpus to initialize > > We use nothing. Please

Re: Re: Re: [PATCH v18 06/14] mm/damon: Implement callbacks for the virtual memory address spaces

2020-07-17 Thread Shakeel Butt
On Fri, Jul 17, 2020 at 9:24 AM SeongJae Park wrote: > > On Fri, 17 Jul 2020 08:17:09 -0700 Shakeel Butt wrote: > > > On Thu, Jul 16, 2020 at 11:54 PM SeongJae Park wrote: > > > > > > On Thu, 16 Jul 2020 17:46:54 -0700 Shakeel Butt > > > wrote: > > > > > > > On Mon, Jul 13, 2020 at 1:44 AM

[GIT PULL] FPGA Manager changes for 5.9-rc1

2020-07-17 Thread Moritz Fischer
The following changes since commit b3a9e3b9622ae10064826dccb4f7a52bd88c7407: Linux 5.8-rc1 (2020-06-14 12:45:04 -0700) are available in the Git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/mdf/linux-fpga.git tags/fpga-for-5.9 for you to fetch changes up to

[RFC][PATCH] x86: optimization to avoid CAL+RES IPIs

2020-07-17 Thread Josh Don
From: Venkatesh Pallipadi smp_call_function_single and smp_send_reschedule send unconditional IPI to target CPU. However, if the target CPU is in some form of poll based idle, we can do IPI-less wakeups. Doing this has certain advantages: * Lower overhead on Async "no wait" IPI send path. *

Re: [PATCH] tools/memory-model: document the "one-time init" pattern

2020-07-17 Thread Matthew Wilcox
On Fri, Jul 17, 2020 at 06:38:39PM -0700, Eric Biggers wrote: > On Fri, Jul 17, 2020 at 06:47:50PM +0100, Matthew Wilcox wrote: > > On Thu, Jul 16, 2020 at 09:44:27PM -0700, Eric Biggers wrote: > > > +If that doesn't apply, you'll have to implement one-time init yourself. > > > + > > > +The

Re: [PATCH net-next 0/2] net: atlantic: add support for FW 4.x

2020-07-17 Thread David Miller
From: Mark Starovoytov Date: Fri, 17 Jul 2020 21:01:45 +0300 > This patch set adds support for FW 4.x, which is about to get into the > production for some products. > 4.x is mostly compatible with 3.x, save for soft reset, which requires > the acquisition of 2 additional semaphores. > Other

Re: [PATCH] tools/memory-model: document the "one-time init" pattern

2020-07-17 Thread Dave Chinner
On Fri, Jul 17, 2020 at 09:25:55PM -0400, Alan Stern wrote: > On Fri, Jul 17, 2020 at 05:58:57PM -0700, Eric Biggers wrote: > > On Fri, Jul 17, 2020 at 01:53:40PM -0700, Darrick J. Wong wrote: > > > > +There are also cases in which the smp_load_acquire() can be replaced by > > > > +the more

Re: [PATCH] tools/memory-model: document the "one-time init" pattern

2020-07-17 Thread Eric Biggers
On Fri, Jul 17, 2020 at 09:25:55PM -0400, Alan Stern wrote: > On Fri, Jul 17, 2020 at 05:58:57PM -0700, Eric Biggers wrote: > > On Fri, Jul 17, 2020 at 01:53:40PM -0700, Darrick J. Wong wrote: > > > > +There are also cases in which the smp_load_acquire() can be replaced by > > > > +the more

Re: [net-next PATCH v3 2/7] net: hsr: introduce common code for skb initialization

2020-07-17 Thread David Miller
From: Murali Karicheri Date: Fri, 17 Jul 2020 11:15:06 -0400 > +static void send_hsr_supervision_frame(struct hsr_port *master, > +u8 type, u8 hsr_ver) > +{ > + struct sk_buff *skb; > + struct hsr_tag *hsr_tag; > + struct hsr_sup_tag *hsr_stag; > +

Re: [net-next PATCH v3 1/7] hsr: enhance netlink socket interface to support PRP

2020-07-17 Thread David Miller
From: Murali Karicheri Date: Fri, 17 Jul 2020 11:15:05 -0400 > @@ -32,7 +33,9 @@ static int hsr_newlink(struct net *src_net, struct > net_device *dev, > struct netlink_ext_ack *extack) > { > struct net_device *link[2]; > - unsigned char multicast_spec,

Re: [PATCH 2/2 v2] net: hsr: validate address B before copying to skb

2020-07-17 Thread David Miller
From: Murali Karicheri Date: Fri, 17 Jul 2020 10:55:10 -0400 > Validate MAC address before copying the same to outgoing frame > skb destination address. Since a node can have zero mac > address for Link B until a valid frame is received over > that link, this fix address the issue of a zero MAC

Re: [PATCH 1/2 v2] net: hsr: fix incorrect lsdu size in the tag of HSR frames for small frames

2020-07-17 Thread David Miller
From: Murali Karicheri Date: Fri, 17 Jul 2020 10:55:09 -0400 > For small Ethernet frames with size less than minimum size 66 for HSR > vs 60 for regular Ethernet frames, hsr driver currently doesn't pad the > frame to make it minimum size. This results in incorrect LSDU size being > populated in

Re: [PATCH] net: ethernet: et131x: Remove redundant register read

2020-07-17 Thread David Miller
From: Mark Einon Date: Fri, 17 Jul 2020 14:21:35 +0100 > Following the removal of an unused variable assignment (remove > unused variable 'pm_csr') the associated register read can also go, > as the read also occurs in the subsequent et1310_in_phy_coma() > call. > > Signed-off-by: Mark Einon

Re: [PATCH] net: ethernet: ti: add NETIF_F_HW_TC hw feature flag for taprio offload

2020-07-17 Thread David Miller
From: Grygorii Strashko Date: Fri, 17 Jul 2020 15:19:32 +0300 > From: Murali Karicheri > > Currently drive supports taprio offload which is a tc feature offloaded > to cpsw hardware. So driver has to set the hw feature flag, NETIF_F_HW_TC > in the net device to be compliant. This patch adds

Re: [PATCH net-next] net: ethernet: et131x: Remove unused variable 'pm_csr'

2020-07-17 Thread David Miller
From: Zhang Changzhong Date: Fri, 17 Jul 2020 18:33:30 +0800 > Gcc report warning as follows: > > drivers/net/ethernet/agere/et131x.c:953:6: warning: > variable 'pm_csr' set but not used [-Wunused-but-set-variable] > 953 | u32 pm_csr; > | ^~ >

Re: [PATCH] Fix memory overwriting issue when copy an address to user space

2020-07-17 Thread David Miller
From: lebon zhou Date: Fri, 17 Jul 2020 10:31:54 + > When application provided buffer size less than sockaddr_storage, then > kernel will overwrite some memory area which may cause memory corruption, > e.g.: in recvmsg case, let msg_name=malloc(8) and msg_namelen=8, then > usually

Re: [PATCH net-next] net: bna: Remove unused variable 't'

2020-07-17 Thread David Miller
From: Zhang Changzhong Date: Fri, 17 Jul 2020 18:23:04 +0800 > Gcc report warning as follows: > > drivers/net/ethernet/brocade/bna/bfa_ioc.c:1538:6: warning: > variable 't' set but not used [-Wunused-but-set-variable] > 1538 | u32 t; > | ^ > > After commit c107ba171f3d ("bna:

Re: [PATCH] tools/memory-model: document the "one-time init" pattern

2020-07-17 Thread Dave Chinner
On Thu, Jul 16, 2020 at 09:44:27PM -0700, Eric Biggers wrote: > From: Eric Biggers > > The "one-time init" pattern is implemented incorrectly in various places > in the kernel. And when people do try to implement it correctly, it is > unclear what to use. Try to give some proper guidance. > >

Re: [PATCH] tools/memory-model: document the "one-time init" pattern

2020-07-17 Thread Matthew Wilcox
On Fri, Jul 17, 2020 at 09:25:55PM -0400, Alan Stern wrote: > On Fri, Jul 17, 2020 at 05:58:57PM -0700, Eric Biggers wrote: > > On Fri, Jul 17, 2020 at 01:53:40PM -0700, Darrick J. Wong wrote: > > > > +There are also cases in which the smp_load_acquire() can be replaced by > > > > +the more

Re: linux-next: Tree for Jul 17 (drivers/rtc/rtc-ds1374.o)

2020-07-17 Thread Stephen Rothwell
Hi Randy, [Please trim your emails a bit more, thanks] On Fri, 17 Jul 2020 09:49:05 -0700 Randy Dunlap wrote: > on x86_64: > # CONFIG_WATCHDOG is not set > > ld: drivers/rtc/rtc-ds1374.o: in function `ds1374_probe': > rtc-ds1374.c:(.text+0x736): undefined reference to `watchdog_init_timeout' >

Re: [PATCH 1/6] syscalls: use uaccess_kernel in addr_limit_user_check

2020-07-17 Thread Guenter Roeck
cut here ] [8.545294] WARNING: CPU: 0 PID: 1 at ./include/linux/syscalls.h:267 addr_limit_check_failed+0x11/0x24 [8.545376] Invalid address limit on user-mode return [8.545487] CPU: 0 PID: 1 Comm: init Not tainted 5.8.0-rc5-next-20200717 #1 [8.545603] Hardware name: MPS2 (Device Tre

Re: [PATCH] net: cxgb3: add missed destroy_workqueue in cxgb3 probe failure

2020-07-17 Thread David Miller
From: Wang Hai Date: Fri, 17 Jul 2020 14:21:17 +0800 > The driver forgets to call destroy_workqueue when cxgb3 probe fails. > Add the missed calls to fix it. > > Fixes: 4d22de3e6cc4 ("Add support for the latest 1G/10G Chelsio adapter, T3.") > Reported-by: Hulk Robot > Signed-off-by: Wang Hai

Re: [PATCH] tools/memory-model: document the "one-time init" pattern

2020-07-17 Thread Eric Biggers
On Fri, Jul 17, 2020 at 06:47:50PM +0100, Matthew Wilcox wrote: > On Thu, Jul 16, 2020 at 09:44:27PM -0700, Eric Biggers wrote: > > +If that doesn't apply, you'll have to implement one-time init yourself. > > + > > +The simplest implementation just uses a mutex and an 'inited' flag. > > +This

Re: [PATCH] rhashtable: drop duplicated word in

2020-07-17 Thread David Miller
From: Randy Dunlap Date: Fri, 17 Jul 2020 16:37:25 -0700 > From: Randy Dunlap > > Drop the doubled word "be" in a comment. > > Signed-off-by: Randy Dunlap Applied, thank you.

Re: [PATCH net] net: macb: use phy_interface_mode_is_rgmii everywhere

2020-07-17 Thread David Miller
From: Alexandre Belloni Date: Sat, 18 Jul 2020 01:32:21 +0200 > There is one RGMII check not using the phy_interface_mode_is_rgmii() > helper. This prevents the driver from configuring the MAC properly when > using a phy-mode that is not just rgmii, e.g. rgmii-rxid. This became an > issue on

Re: [PATCH] crypto: hash.h: drop duplicated word in a comment

2020-07-17 Thread David Miller
From: Randy Dunlap Date: Fri, 17 Jul 2020 16:35:33 -0700 > From: Randy Dunlap > > Drop the doubled word "in" in a comment. > > Signed-off-by: Randy Dunlap Acked-by: David S. Miller

Re: [PATCH] crypto: skcipher.h: drop duplicated word in kernel-doc

2020-07-17 Thread David Miller
From: Randy Dunlap Date: Fri, 17 Jul 2020 16:35:49 -0700 > From: Randy Dunlap > > Drop the doubled word "request" in a kernel-doc comment. > > Signed-off-by: Randy Dunlap Acked-by: David S. Miller

Re: mmotm 2020-07-16-22-52 uploaded (mm/hugetlb.c)

2020-07-17 Thread Stephen Rothwell
Hi Randy, On Fri, 17 Jul 2020 08:35:45 -0700 Randy Dunlap wrote: > > on i386: > 6 of 10 builds failed with: > > ../mm/hugetlb.c:1302:20: error: redefinition of > ‘destroy_compound_gigantic_page’ > static inline void destroy_compound_gigantic_page(struct hstate *h, >

Re: mmotm 2020-07-16-22-52 uploaded (net: IPVS)

2020-07-17 Thread Stephen Rothwell
Hi all, On Fri, 17 Jul 2020 08:30:04 -0700 Randy Dunlap wrote: > > (also in linux-next) > > Many of these errors: > > In file included from ../net/netfilter/ipvs/ip_vs_conn.c:37:0: > ../include/net/ip_vs.h: In function ‘ip_vs_enqueue_expire_nodest_conns’: > ../include/net/ip_vs.h:1536:61:

Re: [PATCH] tools/memory-model: document the "one-time init" pattern

2020-07-17 Thread Alan Stern
On Fri, Jul 17, 2020 at 05:58:57PM -0700, Eric Biggers wrote: > On Fri, Jul 17, 2020 at 01:53:40PM -0700, Darrick J. Wong wrote: > > > +There are also cases in which the smp_load_acquire() can be replaced by > > > +the more lightweight READ_ONCE(). (smp_store_release() is still > > > +required.)

Re: [PATCH net] net: atlantic: disable PTP on AQC111, AQC112

2020-07-17 Thread David Miller
From: Mark Starovoytov Date: Fri, 17 Jul 2020 23:39:49 +0300 > From: Nikita Danilov > > This patch disables PTP on AQC111 and AQC112 due to a known HW issue, > which can cause datapath issues. > > Ideally PTP block should have been disabled via PHY provisioning, but > unfortunately many units

Re: [RFT PATCH v3 1/9] RISC-V: Move DT mapping outof fixmap

2020-07-17 Thread Atish Patra
On Thu, Jul 16, 2020 at 11:32 PM Arnd Bergmann wrote: > > On Fri, Jul 17, 2020 at 1:41 AM Atish Patra wrote: > > > > From: Anup Patel > > > > Currently, RISC-V reserves 1MB of fixmap memory for device tree. However, > > it maps only single PMD (2MB) space for fixmap which leaves only < 1MB

Re: [PATCH] tools/memory-model: document the "one-time init" pattern

2020-07-17 Thread Eric Biggers
On Fri, Jul 17, 2020 at 01:51:38PM -0400, Alan Stern wrote: > On Fri, Jul 17, 2020 at 06:47:50PM +0100, Matthew Wilcox wrote: > > On Thu, Jul 16, 2020 at 09:44:27PM -0700, Eric Biggers wrote: > ... > > > + /* on success, pairs with smp_load_acquire() above and below */ > > > + if

warning unloading wmi

2020-07-17 Thread Matteo Croce
Hi, I get this warning when unloading wmi: [ 246.219255] [ cut here ] [ 246.219257] sysfs group 'power' not found for kobject '1F13AB7F-6220-4210-8F8E-8BB5E71EE969' [ 246.219271] WARNING: CPU: 4 PID: 1744 at fs/sysfs/group.c:279 sysfs_remove_group+0x6f/0x80 [

  1   2   3   4   5   6   7   8   9   10   >