Re: [PATCH] softirq: add irq off checking for __raise_softirq_irqoff

2020-08-12 Thread Peter Zijlstra
On Thu, Aug 06, 2020 at 12:07:29PM +0800, Jiafei Pan wrote: > __raise_softirq_irqoff will update per-CPU mask of pending softirqs, > it need to be called in irq disabled context in order to keep it atomic > operation, otherwise it will be interrupted by hardware interrupt, > and per-CPU softirqs

Re: [PATCH v3 2/2] powerpc/uaccess: Add pre-update addressing to __get_user_asm() and __put_user_asm()

2020-08-12 Thread Christophe Leroy
Le 12/08/2020 à 21:37, Segher Boessenkool a écrit : On Wed, Aug 12, 2020 at 12:25:17PM +, Christophe Leroy wrote: Enable pre-update addressing mode in __get_user_asm() and __put_user_asm() Signed-off-by: Christophe Leroy --- v3: new, splited out from patch 1. It still looks fine to

Re: [PATCH v4 1/7] pinctrl: qcom: Add msmgpio irqchip flags

2020-08-12 Thread Maulik Shah
Hi, On 8/12/2020 1:02 AM, Stephen Boyd wrote: Can the subject be more specific? "pinctrl: qcom: Set IRQCHIP_SET_TYPE_MASKED flag"? Sure i can update subject in v5. Thanks, Maulik Quoting Maulik Shah (2020-08-10 04:20:54) Add irqchip specific flags for msmgpio irqchip to mask non

Re: [PATCH v2] riscv: Setup exception vector for nommu platform

2020-08-12 Thread Damien Le Moal
On 2020/08/13 12:40, Qiu Wenbo wrote: > Exception vector is missing on nommu platform and that is an issue. > This patch is tested in Sipeed Maix Bit Dev Board. > > Fixes: 79b1feba5455 ("RISC-V: Setup exception vector early") > Suggested-by: Anup Patel > Suggested-by: Atish Patra >

Re: WARN_ON_ONCE(1) in iomap_dio_actor()

2020-08-12 Thread Dave Chinner
On Mon, Aug 10, 2020 at 10:03:03PM -0400, Qian Cai wrote: > On Sun, Jul 26, 2020 at 04:24:12PM +0100, Christoph Hellwig wrote: > > On Fri, Jul 24, 2020 at 02:24:32PM -0400, Qian Cai wrote: > > > On Fri, Jun 19, 2020 at 05:17:47PM -0700, Matthew Wilcox wrote: > > > > On Fri, Jun 19, 2020 at

[PATCH] rtc: cmos: initialize rtc time when reading alarm

2020-08-12 Thread Victor Ding
cmos_read_alarm() may leave certain fields of a struct rtc_time untouched; therefore, these fields contain garbage if not properly initialized, leading to inconsistent values when converting into time64_t. This patch to set all fields of a struct rtc_time to -1 before calling cmos_read_alarm().

Re: [RFC 2/7] KVM: VMX: Expose IA32_PKRS MSR

2020-08-12 Thread Chenyi Qiang
On 8/13/2020 5:21 AM, Jim Mattson wrote: On Fri, Aug 7, 2020 at 1:46 AM Chenyi Qiang wrote: Protection Keys for Supervisor Pages (PKS) uses IA32_PKRS MSR (PKRS) at index 0x6E1 to allow software to manage supervisor protection key rights. For performance consideration, PKRS intercept will

Re: [PATCH v2] riscv: Setup exception vector for nommu platform

2020-08-12 Thread Atish Patra
On Wed, Aug 12, 2020 at 8:40 PM Qiu Wenbo wrote: > > Exception vector is missing on nommu platform and that is an issue. > This patch is tested in Sipeed Maix Bit Dev Board. > > Fixes: 79b1feba5455 ("RISC-V: Setup exception vector early") > Suggested-by: Anup Patel > Suggested-by: Atish Patra >

Re: [PATCH 3/3] usb: Add Kconfig and Makefile changes to build brcmstb-usb-pinmap

2020-08-12 Thread Greg Kroah-Hartman
On Wed, Aug 12, 2020 at 04:20:18PM -0400, Al Cooper wrote: > From: Al Cooper > > Add Kconfig and Makefile changes to build brcmstb-usb-pinmap and > update MAINTAINERS for the new driver. This can be part of the previous patch, or at least the Kconfig and Makefile changes should be there so that

Re: [PATCH 2/2] iommu/iova: Free global iova rcache on iova alloc failure

2020-08-12 Thread Vijayanand Jitta
On 8/12/2020 8:46 PM, Joerg Roedel wrote: > On Mon, Aug 03, 2020 at 03:30:48PM +0530, Vijayanand Jitta wrote: >> ping? > > Please repost when v5.9-rc1 is released and add > > Robin Murphy > > on your Cc list. > > Thanks, > > Joerg > Sure, will do. Thanks, Vijay -- QUALCOMM

Re: [PATCH net] bonding: show saner speed for broadcast mode

2020-08-12 Thread Jay Vosburgh
Jarod Wilson wrote: >Broadcast mode bonds transmit a copy of all traffic simultaneously out of >all interfaces, so the "speed" of the bond isn't really the aggregate of >all interfaces, but rather, the speed of the lowest active interface. Did you mean "slowest" here? >Also, the type

RE: [PATCH RFC v2 00/18] Add VFIO mediated device support and DEV-MSI support for the idxd driver

2020-08-12 Thread Tian, Kevin
> From: Jason Wang > Sent: Thursday, August 13, 2020 12:34 PM > > > On 2020/8/12 下午12:05, Tian, Kevin wrote: > >> The problem is that if we tie all controls via VFIO uAPI, the other > >> subsystem like vDPA is likely to duplicate them. I wonder if there is a > >> way to decouple the vSVA out of

Re: [PATCH v3 2/2] power: supply: sbs-battery: don't assume i2c errors as battery disconnect

2020-08-12 Thread Nicolas Boichat
On Thu, Aug 13, 2020 at 1:11 PM Ikjoon Jang wrote: > > Current sbs-battery considers all smbus errors as disconnection events > when battery-detect pin isn't supplied, and restored to present state back > when any successful transaction is made. > > This can lead to unlimited state changes

Re: WARNING: locking bug in l2cap_chan_del

2020-08-12 Thread syzbot
syzbot has found a reproducer for the following issue on: HEAD commit:06a7a37b ipv4: tunnel: fix compilation on ARCH=um git tree: net console output: https://syzkaller.appspot.com/x/log.txt?x=115caa1690 kernel config: https://syzkaller.appspot.com/x/.config?x=7bb894f55faf8242

Re: POC: Alternative solution: Re: [PATCH 0/4] printk: reimplement LOG_CONT handling

2020-08-12 Thread Sergey Senozhatsky
On (20/08/13 02:30), John Ogness wrote: > 2. I haven't yet figured out how to preserve calling context when a > newline appears. For example: > > pr_info("text"); > pr_cont(" 1"); > pr_cont(" 2\n"); > pr_cont("3"); > pr_cont(" 4\n"); > > For "3" the calling context (info, timestamp) is lost

Re: [PATCH 1/3] mm: don't call activate_page() on new ksm pages

2020-08-12 Thread Yang Shi
On Tue, Aug 11, 2020 at 9:04 PM Yu Zhao wrote: > > lru_cache_add_active_or_unevictable() already adds new ksm pages to > active lru. Calling activate_page() isn't really necessary in this > case. > > Signed-off-by: Yu Zhao > --- > mm/swapfile.c | 10 +- > 1 file changed, 5

drivers/char/agp/i460-agp.c:254:19: sparse: sparse: incorrect type in assignment (different address spaces)

2020-08-12 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: dc06fe51d26efc100ac74121607c01a454867c91 commit: 670d0a4b10704667765f7d18f7592993d02783aa sparse: use identifiers to define address spaces date: 8 weeks ago config: ia64-randconfig-s031-20200813 (attached

Re: [PATCH] ftrace: Fixup lockdep assert held of text_mutex

2020-08-12 Thread Palmer Dabbelt
On Thu, 06 Aug 2020 22:01:01 PDT (-0700), guo...@kernel.org wrote: On Fri, Aug 7, 2020 at 12:01 PM Steven Rostedt wrote: On Fri, 7 Aug 2020 10:59:16 +0800 Guo Ren wrote: > > > > This looks like a bug in the lockdep_assert_held() in whatever arch > > (riscv) is running. > Seems you think it's

Re: [PATCH v2 15/20] fuse, dax: Take ->i_mmap_sem lock during dax page fault

2020-08-12 Thread Dave Chinner
On Wed, Aug 12, 2020 at 05:10:12PM -0400, Vivek Goyal wrote: > On Wed, Aug 12, 2020 at 11:23:45AM +1000, Dave Chinner wrote: > > On Tue, Aug 11, 2020 at 01:55:30PM -0400, Vivek Goyal wrote: > > > On Tue, Aug 11, 2020 at 08:22:38AM +1000, Dave Chinner wrote: > > > > On Fri, Aug 07, 2020 at

Re: KMSAN: uninit-value in can_receive (2)

2020-08-12 Thread syzbot
syzbot has found a reproducer for the following issue on: HEAD commit:ce8056d1 wip: changed copy_from_user where instrumented git tree: https://github.com/google/kmsan.git master console output: https://syzkaller.appspot.com/x/log.txt?x=1041a3be90 kernel config:

[PATCH v3 1/2] power: supply: sbs-battery: combine get_presence_and_health

2020-08-12 Thread Ikjoon Jang
This patch enables calling sbs_get_battery_presence_and_health() without checking its chip type. No functional changes. Signed-off-by: Ikjoon Jang --- drivers/power/supply/sbs-battery.c | 73 +++--- 1 file changed, 36 insertions(+), 37 deletions(-) diff --git

[PATCH v3 2/2] power: supply: sbs-battery: don't assume i2c errors as battery disconnect

2020-08-12 Thread Ikjoon Jang
Current sbs-battery considers all smbus errors as disconnection events when battery-detect pin isn't supplied, and restored to present state back when any successful transaction is made. This can lead to unlimited state changes between present and !present when one unsupported command was

[PATCH v3 0/2] power: supply: sbs-battery: fix presence check

2020-08-12 Thread Ikjoon Jang
When gpio detection is not supplied, presence state transitions depend on every smbus transfer result from get_property(). This patch tries to check battery presence again with well supported command before state transition. Changes: v3: check return value of get_presence_and_health() v2: combine

Re: [PATCH] perf parse-events: Set exclude_guest for user-space counting

2020-08-12 Thread Jin, Yao
Hi Arnaldo, On 8/12/2020 8:55 PM, Arnaldo Carvalho de Melo wrote: Em Wed, Aug 12, 2020 at 09:15:04AM -0300, Arnaldo Carvalho de Melo escreveu: Em Wed, Aug 12, 2020 at 02:59:53PM +0800, Jin Yao escreveu: Currently if we run 'perf record -e cycles:u', exclude_guest is 0. But it doesn't make

Re: Recursive/circular locking in serial8250_console_write/serial8250_do_startup

2020-08-12 Thread Guenter Roeck
On Wed, Aug 12, 2020 at 08:48:13AM -0700, Guenter Roeck wrote: > Hi, > > crbug.com/1114800 reports a hard lockup due to circular locking in the > 8250 console driver. This is seen if CONFIG_PROVE_LOCKING is enabled. > > Problem is as follows: > - serial8250_do_startup() locks the serial

Re: [PATCH v17 1/3] dt-bindings: Add bindings for Mediatek matrix keypad

2020-08-12 Thread Yingjoe Chen
On Wed, 2020-08-12 at 15:13 -0700, Dmitry Torokhov wrote: > Hi, > > On Tue, Aug 11, 2020 at 09:47:23AM +0800, Yingjoe Chen wrote: > > Hi, > > > > > > On Mon, 2020-08-10 at 14:40 +0800, Fengping Yu wrote: > > > From: "fengping.yu" > > > > > > This patch add devicetree bindings for Mediatek

Re: [RFC 7/7] KVM: VMX: Enable PKS for nested VM

2020-08-12 Thread Chenyi Qiang
On 8/11/2020 8:05 AM, Jim Mattson wrote: On Fri, Aug 7, 2020 at 1:47 AM Chenyi Qiang wrote: PKS MSR passes through guest directly. Configure the MSR to match the L0/L1 settings so that nested VM runs PKS properly. Signed-off-by: Chenyi Qiang --- arch/x86/kvm/vmx/nested.c | 32

Re: [RFC PATCH 0/5] Introduce /proc/all/ to gather stats from all processes

2020-08-12 Thread David Ahern
On 8/12/20 1:51 AM, Andrei Vagin wrote: > > I rebased the task_diag patches on top of v5.8: > https://github.com/avagin/linux-task-diag/tree/v5.8-task-diag Thanks for updating the patches. > > /proc/pid files have three major limitations: > * Requires at least three syscalls per process per

[PATCH] selftests: rtnetlink: load fou module for kci_test_encap_fou()

2020-08-12 Thread Po-Hsu Lin
The kci_test_encap_fou() test from kci_test_encap() in rtnetlink.sh needs the fou module to work. Otherwise it will fail with: $ ip netns exec "$testns" ip fou add port ipproto 47 RTNETLINK answers: No such file or directory Error talking to the kernel Add the CONFIG_NET_FOU into the

drivers/char/agp/i460-agp.c:254:19: sparse: expected void gatt

2020-08-12 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: dc06fe51d26efc100ac74121607c01a454867c91 commit: df41017eafd267c08acbfff99d34e4f96bbfbc92 ia64: remove support for machvecs date: 12 months ago config: ia64-randconfig-s031-20200813 (attached as .config)

Re: [PATCH RFC v2 00/18] Add VFIO mediated device support and DEV-MSI support for the idxd driver

2020-08-12 Thread Jason Wang
On 2020/8/12 下午12:05, Tian, Kevin wrote: The problem is that if we tie all controls via VFIO uAPI, the other subsystem like vDPA is likely to duplicate them. I wonder if there is a way to decouple the vSVA out of VFIO uAPI? vSVA is a per-device (either pdev or mdev) feature thus naturally

Re: [PATCH] opp: Fix dev_pm_opp_set_rate() to not return early

2020-08-12 Thread Viresh Kumar
On 11-08-20, 14:09, Stephen Boyd wrote: > This is a goto maze! Any chance we can clean this up? I have sent a short series in reply to this series, please have a look. It should look better now. -- viresh

[PATCH V2 1/4] opp: Enable resources again if they were disabled earlier

2020-08-12 Thread Viresh Kumar
From: Rajendra Nayak dev_pm_opp_set_rate() can now be called with freq = 0 in order to either drop performance or bandwidth votes or to disable regulators on platforms which support them. In such cases, a subsequent call to dev_pm_opp_set_rate() with the same frequency ends up returning early

[PATCH 2/4] opp: Track device's resources configuration status

2020-08-12 Thread Viresh Kumar
The OPP core needs to track if the resources of devices are enabled or configured or not, as it disables the resources when target_freq is set to 0. Handle that with a separate variable to make it easy to maintain. Also note that we will unconditionally call clk_set_rate() in the case where the

[PATCH 3/4] opp: Reused enabled flag and remove regulator_enabled

2020-08-12 Thread Viresh Kumar
The common "enabled" flag can be used here instead of "regulator_enabled" now. Signed-off-by: Viresh Kumar --- drivers/opp/core.c | 13 +++-- drivers/opp/opp.h | 2 -- 2 files changed, 3 insertions(+), 12 deletions(-) diff --git a/drivers/opp/core.c b/drivers/opp/core.c index

[PATCH 4/4] opp: Split out _opp_set_rate_zero()

2020-08-12 Thread Viresh Kumar
Create separate routine _opp_set_rate_zero() to handle !target_freq case. Signed-off-by: Viresh Kumar --- drivers/opp/core.c | 52 +--- 1 file changed, 29 insertions(+), 23 deletions(-) diff --git a/drivers/opp/core.c b/drivers/opp/core.c index

Re: [RFC PATCH 00/16] Core scheduling v6

2020-08-12 Thread Li, Aubrey
On 2020/8/13 7:08, Joel Fernandes wrote: > On Wed, Aug 12, 2020 at 10:01:24AM +0800, Li, Aubrey wrote: >> Hi Joel, >> >> On 2020/8/10 0:44, Joel Fernandes wrote: >>> Hi Aubrey, >>> >>> Apologies for replying late as I was still looking into the details. >>> >>> On Wed, Aug 05, 2020 at 11:57:20AM

[rcu:dev.2020.08.11a 110/112] ERROR: modpost: "rcu_read_unlock_strict" undefined!

2020-08-12 Thread kernel test robot
Hi Paul, First bad commit (maybe != root cause): tree: https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git dev.2020.08.11a head: 9030fc13639a71b15466520f09ca07b80fc30ed1 commit: 601cd69fa4bb0127bb774cc852203fd9fdf5e269 [110/112] rcuperf: Change rcuperf to rcuscale config:

Re: KMSAN: uninit-value in joydev_connect

2020-08-12 Thread syzbot
syzbot has found a reproducer for the following issue on: HEAD commit:ce8056d1 wip: changed copy_from_user where instrumented git tree: https://github.com/google/kmsan.git master console output: https://syzkaller.appspot.com/x/log.txt?x=127b9fba90 kernel config:

Re: [PATCH v2 2/2] power: supply: sbs-battery: don't assume every i2c errors as battery disconnect

2020-08-12 Thread Nicolas Boichat
On Tue, Aug 11, 2020 at 2:59 PM Ikjoon Jang wrote: > > Current sbs-battery considers all smbus errors as diconnection events disconnection > when battery-detect pin isn't supplied, and restored to present state back > on any successful transaction were made. when any... is made > > This can

RE: [PATCH v3] exfat: remove EXFAT_SB_DIRTY flag

2020-08-12 Thread Namjae Jeon
> Thanks for thinking on this complicated issue. > > > > Most of the NAND flash devices and HDDs have wear leveling and bad sector > > replacement algorithms > applied. > > So I think that the life of the boot sector will not be exhausted first. > > I'm not too worried about the life of the

[RFC PATCH 0/3] Re: [PATCH v17 14/21] mm/compaction: do page isolation first in compaction

2020-08-12 Thread Alexander Duyck
Here are the patches I had discussed earlier to address the issues in isolate_migratepages_block. They are based on the tree at: https://github.com/alexshi/linux.git lrunext The first patch is mostly cleanup to address the RCU locking in the function. The second addresses the test_and_set_skip

[RFC PATCH 1/3] mm: Drop locked from isolate_migratepages_block

2020-08-12 Thread Alexander Duyck
From: Alexander Duyck We can drop the need for the locked variable by making use of the lruvec_holds_page_lru_lock function. By doing this we can avoid some rcu locking ugliness for the case where the lruvec is still holding the LRU lock associated with the page. Instead we can just use the

[RFC PATCH 2/3] mm: Drop use of test_and_set_skip in favor of just setting skip

2020-08-12 Thread Alexander Duyck
From: Alexander Duyck The only user of test_and_set_skip was isolate_migratepages_block and it was using it after a call that was testing and clearing the LRU flag. As such it really didn't need to be behind the LRU lock anymore as it wasn't really fulfilling its purpose. With that being the

[RFC PATCH 3/3] mm: Identify compound pages sooner in isolate_migratepages_block

2020-08-12 Thread Alexander Duyck
From: Alexander Duyck Since we are holding a reference to the page much sooner in isolate_migratepages_block we could move the PageCompound check out of the LRU locked section and instead just place it after get_page_unless_zero. By doing this we can allow any of the items that might trigger a

Re: file metadata via fs API (was: [GIT PULL] Filesystem Information)

2020-08-12 Thread Jeffrey E Altman
On 8/12/2020 2:18 PM, Linus Torvalds (torva...@linux-foundation.org) wrote: > What's wrong with fstatfs()? All the extra magic metadata seems to not > really be anything people really care about. > > What people are actually asking for seems to be some unique mount ID, > and we have 16 bytes of

Re: INFO: task hung in pipe_release (2)

2020-08-12 Thread syzbot
syzbot has bisected this issue to: commit fddb5d430ad9fa91b49b1d34d0202ffe2fa0e179 Author: Aleksa Sarai Date: Sat Jan 18 12:07:59 2020 + open: introduce openat2(2) syscall bisection log: https://syzkaller.appspot.com/x/bisect.txt?x=164e716a90 start commit: 6ba1b005 Merge tag

[PATCH net] bonding: show saner speed for broadcast mode

2020-08-12 Thread Jarod Wilson
Broadcast mode bonds transmit a copy of all traffic simultaneously out of all interfaces, so the "speed" of the bond isn't really the aggregate of all interfaces, but rather, the speed of the lowest active interface. Also, the type of the speed field is u32, not unsigned long, so adjust that

Re: [PATCH v2] nvme: Use spin_lock_irq() when taking the ctrl->lock

2020-08-12 Thread Logan Gunthorpe
On 2020-08-12 6:32 p.m., Keith Busch wrote: > There's an unrelated whitespace change in nvme_init_identify(). > Otherwise, looks fine. Oops, sorry. can this be fixed up when it's merged? Logan

Re: [PATCH v17 14/21] mm/compaction: do page isolation first in compaction

2020-08-12 Thread Alex Shi
在 2020/8/13 上午10:17, Alexander Duyck 写道: >> zone lock is probability better. you can try and test. > So I spent a good chunk of today looking the code over and what I > realized is that we probably don't even really need to have this code > protected by the zone lock since the LRU bit in the

[PATCH] mm: include CMA pages in lowmem_reserve at boot

2020-08-12 Thread Doug Berger
The lowmem_reserve arrays provide a means of applying pressure against allocations from lower zones that were targeted at higher zones. Its values are a function of the number of pages managed by higher zones and are assigned by a call to the setup_per_zone_lowmem_reserve() function. The function

Re: WARNING in compat_do_ebt_get_ctl

2020-08-12 Thread syzbot
syzbot has found a reproducer for the following issue on: HEAD commit:fb893de3 Merge tag 'tag-chrome-platform-for-v5.9' of git:/.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=1742b31c90 kernel config:

Re: file metadata via fs API

2020-08-12 Thread Ian Kent
On Wed, 2020-08-12 at 12:50 -0700, Linus Torvalds wrote: > On Wed, Aug 12, 2020 at 12:34 PM Steven Whitehouse < > swhit...@redhat.com> wrote: > > The point of this is to give us the ability to monitor mounts from > > userspace. > > We haven't had that before, I don't see why it's suddenly such a

[PATCH] drivers/input/misc: Use kobj_to_dev() instead

2020-08-12 Thread Wang Qing
Use kobj_to_dev() instead of container_of() Signed-off-by: Wang Qing --- drivers/input/misc/ims-pcu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/input/misc/ims-pcu.c b/drivers/input/misc/ims-pcu.c index d8dbfc0..0879d96 --- a/drivers/input/misc/ims-pcu.c +++

[PATCH] drm/hisilicon: Fix build error of no type of module_init

2020-08-12 Thread Tian Tao
Add missing include to fix build error: hibmc_drm_drv.c:385:1: warning: data definition has no type or storage class [enabled by default] hibmc_drm_drv.c:385:1: error: type defaults to ‘int’ in declaration of ‘module_init’ [-Werror=implicit-int] hibmc_drm_drv.c:385:1: warning: parameter names

[PATCH v2] riscv: Setup exception vector for nommu platform

2020-08-12 Thread Qiu Wenbo
Exception vector is missing on nommu platform and that is an issue. This patch is tested in Sipeed Maix Bit Dev Board. Fixes: 79b1feba5455 ("RISC-V: Setup exception vector early") Suggested-by: Anup Patel Suggested-by: Atish Patra Signed-off-by: Qiu Wenbo --- arch/riscv/kernel/head.S | 25

[PATCH] drivers/greybus: Use kobj_to_dev() instead

2020-08-12 Thread Wang Qing
Use kobj_to_dev() instead of container_of() Signed-off-by: Wang Qing --- drivers/greybus/interface.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/greybus/interface.c b/drivers/greybus/interface.c index 67dbe6f..de167f1 --- a/drivers/greybus/interface.c +++

Re: [PATCH] binfmt_flat: revert "binfmt_flat: don't offset the data start"

2020-08-12 Thread Greg Ungerer
Hi Max, On 9/8/20 4:37 am, Max Filippov wrote: binfmt_flat loader uses the gap between text and data to store data segment pointers for the libraries. Even in the absence of shared libraries it stores at least one pointer to the executable's own data segment. Text and data can go back to back

Re: KMSAN: uninit-value in ath9k_htc_rx_msg

2020-08-12 Thread syzbot
syzbot has found a reproducer for the following issue on: HEAD commit:ce8056d1 wip: changed copy_from_user where instrumented git tree: https://github.com/google/kmsan.git master console output: https://syzkaller.appspot.com/x/log.txt?x=12985a1690 kernel config:

[PATCH v6] Add MediaTek MT6779 devapc driver

2020-08-12 Thread Neal Liu
These patch series introduce a MediaTek MT6779 devapc driver. MediaTek bus fabric provides TrustZone security support and data protection to prevent slaves from being accessed by unexpected masters. The security violation is logged and sent to the processor for further analysis or

[PATCH v6 2/2] soc: mediatek: add mt6779 devapc driver

2020-08-12 Thread Neal Liu
MediaTek bus fabric provides TrustZone security support and data protection to prevent slaves from being accessed by unexpected masters. The security violation is logged and sent to the processor for further analysis or countermeasures. Any occurrence of security violation would raise an

[PATCH v6 1/2] dt-bindings: devapc: add bindings for mtk-devapc

2020-08-12 Thread Neal Liu
Add bindings for mtk-devapc. Signed-off-by: Neal Liu --- .../devicetree/bindings/soc/mediatek/devapc.yaml | 58 1 file changed, 58 insertions(+) create mode 100644 Documentation/devicetree/bindings/soc/mediatek/devapc.yaml diff --git

Re: [PATCH v2] lib/cmdline: prevent unintented access to address

2020-08-12 Thread Randy Dunlap
On 8/12/20 8:07 PM, Seungil Kang wrote: > When args = "\"\0", "i" will be 0 and args[i-1] is used. (*lib/cmdline.c +238) > Because of "i" is an unsigned int type, the function will access at > args[0x]. > It can make a crash. > > Signed-off-by: Seungil Kang > --- > > Thanks for your

Re: [PATCH tip/core/rcu 06/12] rcu: Do full report for .need_qs for strict GPs

2020-08-12 Thread Paul E. McKenney
On Thu, Aug 13, 2020 at 02:50:27AM +0200, Jann Horn wrote: > On Thu, Aug 13, 2020 at 12:57 AM wrote: > > The rcu_preempt_deferred_qs_irqrestore() function is invoked at > > the end of an RCU read-side critical section (for example, directly > > from rcu_read_unlock()) and, if .need_qs is set,

[PATCH] drivers/dax: Use kobj_to_dev() instead

2020-08-12 Thread Wang Qing
Use kobj_to_dev() instead of container_of() Signed-off-by: Wang Qing --- drivers/dax/bus.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dax/bus.c b/drivers/dax/bus.c index df238c8..24625d2 --- a/drivers/dax/bus.c +++ b/drivers/dax/bus.c @@ -331,7 +331,7 @@ static

drivers/md/dm-ebs-target.c:264:4: warning: Variable 'r' is reassigned a value before the old one has been used.

2020-08-12 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: dc06fe51d26efc100ac74121607c01a454867c91 commit: d3c7b35c20d60650bac8b55c17b194adda03a979 dm: add emulated block size target date: 3 months ago compiler: sparc-linux-gcc (GCC) 9.3.0 If you fix the issue,

drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c:5638 bnx2x_link_settings_status() warn: signedness bug returning '(-22)'

2020-08-12 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: 7c2a69f610e64c8dec6a06a66e721f4ce1dd783a commit: 2c855d73f2f6107f5b8ebc45f8b934bf7f4419e0 bnx2x: Remove read_status_t function casts date: 9 months ago config: ia64-randconfig-m031-20200811 (attached as

Re: [PATCH v8 2/4] scsi: ufs: Introduce HPB feature

2020-08-12 Thread Bart Van Assche
On 2020-08-12 20:00, Daejun Park wrote: > On 2020-08-06 02:11, Daejun Park wrote: >>> +static int ufshpb_create_sysfs(struct ufs_hba *hba, struct ufshpb_lu *hpb) >>> +{ >>> +int ret; >>> + >>> +ufshpb_stat_init(hpb); >>> + >>> +kobject_init(>kobj, _ktype); >>> +

Re: [PATCH v8 3/4] scsi: ufs: L2P map management for HPB read

2020-08-12 Thread Daejun Park
On 2020-08-06 02:15, Daejun Park wrote: > > +req->end_io_data = (void *)map_req; > > Please leave the (void *) cast out since explicit casts from a non-void > to a void pointer are not necessary in C. OK, I will fix it. > > +static inline struct > > +ufshpb_rsp_field

Re: [PATCH v8 4/4] scsi: ufs: Prepare HPB read for cached sub-region

2020-08-12 Thread Daejun Park
On 2020-08-06 02:18, Daejun Park wrote: > > +static inline u32 ufshpb_get_lpn(struct scsi_cmnd *cmnd) > > +{ > > +return blk_rq_pos(cmnd->request) >> > > +(ilog2(cmnd->device->sector_size) - 9); > > +} > > Please use sectors_to_logical() from drivers/scsi/sd.h instead of open-coding >

[PATCH] dma-debug: fix debug_dma_assert_idle(), use rcu_read_lock()

2020-08-12 Thread Hugh Dickins
Since commit 2a9127fcf229 ("mm: rewrite wait_on_page_bit_common() logic") improved unlock_page(), it has become more noticeable how cow_user_page() in a kernel with CONFIG_DMA_API_DEBUG=y can create and suffer from heavy contention on DMA debug's radix_lock in debug_dma_assert_idle(). It is only

Re: [PATCH] perf parse-events: Set exclude_guest for user-space counting

2020-08-12 Thread Jin, Yao
Hi Like, On 8/12/2020 9:02 PM, Like Xu wrote: On 2020/8/12 20:15, Arnaldo Carvalho de Melo wrote: Em Wed, Aug 12, 2020 at 02:59:53PM +0800, Jin Yao escreveu: Currently if we run 'perf record -e cycles:u', exclude_guest is 0. But it doesn't make sense that we request for user-space counting

[PATCH v2] lib/cmdline: prevent unintented access to address

2020-08-12 Thread Seungil Kang
When args = "\"\0", "i" will be 0 and args[i-1] is used. (*lib/cmdline.c +238) Because of "i" is an unsigned int type, the function will access at args[0x]. It can make a crash. Signed-off-by: Seungil Kang --- Thanks for your review, my comments below > Can you be less ambiguous with

RE: [PATCH] softirq: add irq off checking for __raise_softirq_irqoff

2020-08-12 Thread Jiafei Pan
Any comments? Thanks. @Steven Rostedt, I thinks irq off checking is necessary especially for Preempt-RT kernel, because some context may be changed from irq off to irq on when enable Preempt RT, I once met a issue that hrtimer soft irq is lost when enabled Preempt RT, finally I found

Re: [PATCH v8 2/4] scsi: ufs: Introduce HPB feature

2020-08-12 Thread Daejun Park
Hi Bart, On 2020-08-06 02:11, Daejun Park wrote: > > This is a patch for the HPB feature. > > This patch adds HPB function calls to UFS core driver. > > > > The mininum size of the memory pool used in the HPB is implemented as a > ^^^ > minimum? I will fix it. > > Kconfig

[PATCH] acpi/nfit: Use kobj_to_dev() instead

2020-08-12 Thread Wang Qing
Use kobj_to_dev() instead of container_of() Signed-off-by: Wang Qing --- drivers/acpi/nfit/core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c index fa4500f..3bb350b --- a/drivers/acpi/nfit/core.c +++

[PATCH v2] mm: LMK, adjust oom_score_adj when fork a new process

2020-08-12 Thread hui yang
From: YangHui Also it rely on inheritance,But there are some things you need't inheriting if all children oom_score_adj is -1000,the oom is meaningless Signed-off-by: YangHui --- include/uapi/linux/oom.h | 1 + kernel/fork.c| 4 ++-- 2 files changed, 3 insertions(+), 2

RE: [PATCH 1/2] exfat: add NameLength check when extracting name

2020-08-12 Thread Namjae Jeon
> Thank you for your reply. > > >> -static void exfat_get_uniname_from_ext_entry(struct super_block *sb, > >> - struct exfat_chain *p_dir, int entry, unsigned short *uniname) > >> +static int exfat_get_uniname_from_name_entries(struct > >> exfat_entry_set_cache *es, > >> +

drivers/net/ethernet/oki-semi/pch_gbe/pch_gbe_main.c:2135:41: sparse: sparse: incorrect type in argument 1 (different address spaces)

2020-08-12 Thread kernel test robot
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: dc06fe51d26efc100ac74121607c01a454867c91 commit: 670d0a4b10704667765f7d18f7592993d02783aa sparse: use identifiers to define address spaces date: 8 weeks ago config: i386-randconfig-s001-20200813 (attached

Re: [PATCH v2] nvme: Use spin_lock_irq() when taking the ctrl->lock

2020-08-12 Thread Chaitanya Kulkarni
On 8/12/20 16:25, Logan Gunthorpe wrote: > When locking the ctrl->lock spinlock IRQs need to be disabled to avoid a > dead lock. The new spin_lock() calls recently added produce the > following lockdep warning when running the blktest nvme/003: > > >

Re: [PATCH] tools build feature: Quote CC and CXX for their arguments

2020-08-12 Thread Tom Hebb
On Wed, Aug 12, 2020 at 3:15 PM Daniel Díaz wrote: > > When using a cross-compilation environment, such as OpenEmbedded, > the CC an CXX variables are set to something more than just a > command: there are arguments (such as --sysroot) that need to be > passed on to the compiler so that the right

Re: [PATCH v8 2/4] scsi: ufs: Introduce HPB feature

2020-08-12 Thread Daejun Park
Hi Bart, On 2020-08-06 02:11, Daejun Park wrote: > > +static void ufshpb_issue_hpb_reset_query(struct ufs_hba *hba) > > +{ > > +int err; > > +int retries; > > + > > +for (retries = 0; retries < HPB_RESET_REQ_RETRIES; retries++) { > > +err = ufshcd_query_flag(hba,

Re: [PATCH v8 1/4] scsi: ufs: Add UFS feature related parameter

2020-08-12 Thread Daejun Park
Hi Bart, > On 2020-08-06 02:02, Daejun Park wrote: > > @@ -537,6 +548,7 @@ struct ufs_dev_info { > > u8 *model; > > u16 wspecversion; > > u32 clk_gating_wait_us; > > +u8 b_ufs_feature_sup; > > u32 d_ext_ufs_feature_sup; > > u8 b_wb_buffer_type; > > u32

Re: [PATCH v17 14/21] mm/compaction: do page isolation first in compaction

2020-08-12 Thread Alexander Duyck
On Wed, Aug 12, 2020 at 6:47 PM Alex Shi wrote: > > > > 在 2020/8/13 上午12:51, Alexander Duyck 写道: > > On Wed, Aug 12, 2020 at 4:44 AM Alex Shi wrote: > >> > >> > >> > >> 在 2020/8/11 下午10:47, Alexander Duyck 写道: > >>> On Tue, Aug 11, 2020 at 1:23 AM Alex Shi > >>> wrote: > > > >

[GIT PULL] xfs: small fixes for 5.9-rc1

2020-08-12 Thread Darrick J. Wong
Hi Linus, Please pull these two small fixes that have come in during the past week. The branch merges cleanly with upstream as of a few minutes ago, so please let me know if anything strange happens. --D The following changes since commit 818d5a91559ffe1e1f2095dcbbdb96c13fdb94ec: fs/xfs:

[PATCH v2 0/2] Try to release mmap_lock temporarily in smaps_rollup

2020-08-12 Thread Chinwen Chang
Recently, we have observed some janky issues caused by unpleasantly long contention on mmap_lock which is held by smaps_rollup when probing large processes. To address the problem, we let smaps_rollup detect if anyone wants to acquire mmap_lock for write attempts. If yes, just release the lock

[PATCH v2 1/2] mmap locking API: add mmap_lock_is_contended()

2020-08-12 Thread Chinwen Chang
Add new API to query if someone wants to acquire mmap_lock for write attempts. Using this instead of rwsem_is_contended makes it more tolerant of future changes to the lock type. Signed-off-by: Chinwen Chang --- include/linux/mmap_lock.h | 5 + 1 file changed, 5 insertions(+) diff --git

[PATCH v2 2/2] mm: proc: smaps_rollup: do not stall write attempts on mmap_lock

2020-08-12 Thread Chinwen Chang
smaps_rollup will try to grab mmap_lock and go through the whole vma list until it finishes the iterating. When encountering large processes, the mmap_lock will be held for a longer time, which may block other write requests like mmap and munmap from progressing smoothly. There are upcoming

Re: [PATCH v2] PCI: Introduce flag for detached virtual functions

2020-08-12 Thread Oliver O'Halloran
On Thu, Aug 13, 2020 at 6:33 AM Alex Williamson wrote: > > On Wed, 12 Aug 2020 15:21:11 -0400 > Matthew Rosato wrote: > > > @@ -521,7 +522,8 @@ static int vfio_basic_config_read(struct > > vfio_pci_device *vdev, int pos, > > count = vfio_default_config_read(vdev, pos, count, perm, offset,

Re: [PATCH linux-5.2.y-rt only] hrtimer: correct the logic for grab expiry lock

2020-08-12 Thread Zhantao Tang
在 2020/8/12 下午7:45, Rasmus Villemoes 写道: On 12/08/2020 12.50, zhantao.t...@windriver.com wrote: From: Zhantao Tang In commit: 47b6de0b7f22 ("hrtimer: Add a missing bracket and hide `migration_base' on !SMP") a inline function is_migration_base() is introduced. But the logic of the

Re: [PATCH v2] PCI: Introduce flag for detached virtual functions

2020-08-12 Thread Oliver O'Halloran
On Thu, Aug 13, 2020 at 5:21 AM Matthew Rosato wrote: > > s390x has the notion of providing VFs to the kernel in a manner > where the associated PF is inaccessible other than via firmware. > These are not treated as typical VFs and access to them is emulated > by underlying firmware which can

Re: [RFC PATCH] printk: Change timestamp to triplet as mono, boot and real

2020-08-12 Thread Sergey Senozhatsky
On (20/08/11 15:02), Petr Mladek wrote: > On Tue 2020-08-11 14:05:12, Thomas Gleixner wrote: > > Petr Mladek writes: > > > At least "crash" tool would need an update anyway. AFAIK, it checks > > > the size of struct printk_log and refuses to read it when it changes. > > > > > > It means that the

Re: [PATCH v2 0/4] Perf tool: Enable Arm arch timer counter and arm-spe's timestamp

2020-08-12 Thread Leo Yan
On Wed, Aug 12, 2020 at 03:53:34PM -0300, Arnaldo Carvalho de Melo wrote: > Em Wed, Aug 12, 2020 at 10:06:53AM -0600, Mathieu Poirier escreveu: > > Hi Arnaldo, > > > > On Fri, 7 Aug 2020 at 01:16, Leo Yan wrote: > > > > > > This patch set is to enable Arm arch timer counter and Arm SPE is the >

Re: [PATCH v3 0/6] tracing: export event trace and trace_marker

2020-08-12 Thread Tingwei Zhang
On Thu, Aug 13, 2020 at 12:49:25AM +0800, Mathieu Poirier wrote: > On Tue, Aug 11, 2020 at 11:57:20AM +0800, Tingwei Zhang wrote: > > Ftrace has ability to export trace packets to other destination. > > Currently, only function trace can be exported. This series extends the > > support to event

[PATCH v3 6/6] stm class: ftrace: use different channel accroding to CPU

2020-08-12 Thread Tingwei Zhang
To avoid mixup of packets from differnt ftrace packets simultaneously, use different channel for packets from different CPU. Signed-off-by: Tingwei Zhang Reviewed-by: Steven Rostedt (VMware) --- drivers/hwtracing/stm/ftrace.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff

[PATCH v3 5/6] stm class: ftrace: enable supported trace export flag

2020-08-12 Thread Tingwei Zhang
Set flags for trace_export. Export function trace, event trace and trace marker to stm. Signed-off-by: Tingwei Zhang Reviewed-by: Steven Rostedt (VMware) --- drivers/hwtracing/stm/ftrace.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/hwtracing/stm/ftrace.c

Re: [PATCH v17 14/21] mm/compaction: do page isolation first in compaction

2020-08-12 Thread Alex Shi
在 2020/8/13 上午12:51, Alexander Duyck 写道: > On Wed, Aug 12, 2020 at 4:44 AM Alex Shi wrote: >> >> >> >> 在 2020/8/11 下午10:47, Alexander Duyck 写道: >>> On Tue, Aug 11, 2020 at 1:23 AM Alex Shi wrote: 在 2020/8/10 下午10:41, Alexander Duyck 写道: > On Mon, Aug 10, 2020 at 6:10

[PATCH v3 0/6] tracing: export event trace and trace_marker

2020-08-12 Thread Tingwei Zhang
Ftrace has ability to export trace packets to other destination. Currently, only function trace can be exported. This series extends the support to event trace and trace_maker. STM is one possible destination to export ftrace. Use separate channel for each CPU to avoid mixing up packets from

[PATCH v3 2/6] tracing: add flag to control different traces

2020-08-12 Thread Tingwei Zhang
More traces like event trace or trace marker will be supported. Add flag for difference traces, so that they can be controlled separately. Move current function trace to it's own flag instead of global ftrace enable flag. Signed-off-by: Tingwei Zhang Reviewed-by: Steven Rostedt (VMware) ---

[PATCH v3 3/6] tracing: add trace_export support for event trace

2020-08-12 Thread Tingwei Zhang
Only function traces can be exported to other destinations currently. This patch exports event trace as well. Move trace export related function to the beginning of file so other trace can call trace_process_export() to export. Signed-off-by: Tingwei Zhang Reviewed-by: Steven Rostedt (VMware)

  1   2   3   4   5   6   7   8   9   10   >