Re: [PATCH 2/2] net: socket: implement SO_DESCRIPTION

2020-08-15 Thread kernel test robot
Hi Pascal, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on tip/perf/core] [also build test WARNING on linux/master v5.8] [cannot apply to security/next-testing linus/master next-20200814] [If your patch is applied to the wrong git tree, kindly drop us a note.

[PATCH] drm/bridge/tc358775: Fix for PTR_ERR

2020-08-15 Thread Vinay Simha BN
passing zero to 'PTR_ERR' Reported-by: kernel test robot Signed-off-by: Vinay Simha BN --- drivers/gpu/drm/bridge/tc358775.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/bridge/tc358775.c b/drivers/gpu/drm/bridge/tc358775.c index 7da15cd..d951cdc 100644

Re: [PATCH v2] bpf: Convert to use the preferred fallthrough macro

2020-08-15 Thread Yonghong Song
On 8/15/20 1:47 AM, Miaohe Lin wrote: Since commit 294f69e662d1 ("compiler_attributes.h: Add 'fallthrough' pseudo keyword for switch/case use") introduce fallthrough pseudo keyword, then we should convert the uses of fallthrough comments to it. Signed-off-by: Miaohe Lin Acked-by: Yonghong

Re: [PATCH v2] lib/string.c: implement stpcpy

2020-08-15 Thread Sedat Dilek
On Sun, Aug 16, 2020 at 2:19 AM 'Fangrui Song' via Clang Built Linux wrote: > > On 2020-08-15, 'Nick Desaulniers' via Clang Built Linux wrote: > >On Sat, Aug 15, 2020 at 2:31 PM Joe Perches wrote: > >> > >> On Sat, 2020-08-15 at 14:28 -0700, Nick Desaulniers wrote: > >> > On Sat, Aug 15, 2020 at

Re: [PATCH 2/2] mm/pageblock: remove false sharing in pageblock_flags

2020-08-15 Thread Matthew Wilcox
On Sun, Aug 16, 2020 at 11:47:57AM +0800, Alex Shi wrote: > Current pageblock_flags is only 4 bits, so it has to share a char size > in cmpxchg when get set, the false sharing cause perf drop. > > If we incrase the bits up to 8, false sharing would gone in cmpxchg. and > the only cost is half

Re: [PATCH 2/2] arm64: Reserve memory for quick kexec

2020-08-15 Thread kernel test robot
Hi Sang, Thank you for the patch! Yet something to improve: [auto build test ERROR on arm64/for-next/core] [also build test ERROR on linux/master linus/master v5.8 next-20200814] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

[PATCH] mm/gup_benchmark: use pin_user_pages for FOLL_LONGTERM flag

2020-08-15 Thread Barry Song
According to Documentation/core-api/pin_user_pages.rst, FOLL_PIN is a prerequisite to FOLL_LONGTERM. Another way of saying that is, FOLL_LONGTERM is a specific case, more restrictive case of FOLL_PIN. Almost all kernel modules are using pin_user_pages() with FOLL_LONGTERM, mm/gup_benchmark.c

Re: [PATCH 1/2] mm/pageblock: mitigation cmpxchg false sharing in pageblock flags

2020-08-15 Thread Matthew Wilcox
On Sun, Aug 16, 2020 at 11:47:56AM +0800, Alex Shi wrote: > +++ b/mm/page_alloc.c > @@ -467,6 +467,8 @@ static inline int pfn_to_bitidx(struct page *page, > unsigned long pfn) > return (pfn >> pageblock_order) * NR_PAGEBLOCK_BITS; > } > > +#define BITS_PER_CHAR8

Re: [PATCH] PCI: designware-ep: Fix the Header Type check

2020-08-15 Thread kernel test robot
Hi Zhiqiang, I love your patch! Perhaps something to improve: [auto build test WARNING on pci/next] [also build test WARNING on linux/master linus/master v5.8 next-20200814] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use

[PATCH 2/2] mm/pageblock: remove false sharing in pageblock_flags

2020-08-15 Thread Alex Shi
Current pageblock_flags is only 4 bits, so it has to share a char size in cmpxchg when get set, the false sharing cause perf drop. If we incrase the bits up to 8, false sharing would gone in cmpxchg. and the only cost is half char per pageblock, which is half char per 128MB on x86, 4 chars in 1

[PATCH 1/2] mm/pageblock: mitigation cmpxchg false sharing in pageblock flags

2020-08-15 Thread Alex Shi
pageblock_flags is used as long, since every pageblock_flags is just 4 bits, 'long' size will include 8(32bit machine) or 16 pageblocks' flags, that flag setting has to sync in cmpxchg with 7 or 15 other pageblock flags. It would cause long waiting for sync. If we could change the pageblock_flags

[PATCH] staging: greybus: Add identifier name to function definition argument

2020-08-15 Thread Asif Talybov
WARNING: function definition argument 'struct gbphy_device *' should also have an identifier name + int (*probe)(struct gbphy_device *, WARNING: function definition argument 'struct gbphy_device *' should also have an identifier name + void (*remove)(struct gbphy_device *);

Re: [RFC 3/3] staging: qlge: clean up code that dump info to dmesg

2020-08-15 Thread Benjamin Poirier
On 2020-08-15 00:06 +0800, Coiby Xu wrote: > The related code are not necessary because, > - Device status and general registers can be obtained by ethtool. > - Coredump can be done via devlink health reporter. > - Structure related to the hardware (struct ql_adapter) can be obtained > by crash

Re: [RFC 1/3] Initialize devlink health dump framework for the dlge driver

2020-08-15 Thread Benjamin Poirier
On 2020-08-15 00:05 +0800, Coiby Xu wrote: > Initialize devlink health dump framework for the dlge driver so the > coredump could be done via devlink. > > Signed-off-by: Coiby Xu > --- > drivers/staging/qlge/Makefile | 2 +- > drivers/staging/qlge/qlge.h| 9 +++ >

Re: [PATCH net] drivers/net/wan/lapbether: Added needed_tailroom

2020-08-15 Thread Xie He
I took some time to look at the history of needed_tailroom. I found it was added in this commit: f5184d267c1a (net: Allow netdevices to specify needed head/tailroom) The author tried to make use of needed_tailroom at various places in the kernel by replacing the macro LL_RESERVED_SPACE with his

Re: [PATCH 1/5] net: Fix potential deadloop in skb_copy_ubufs()

2020-08-15 Thread linmiaohe
Eric Dumazet wrote: >On Fri, Aug 14, 2020 at 12:14 AM linmiaohe wrote: >> >> Willem de Bruijn wrote: >> >> Since we always call skb_orphan_frags in skb_clone, is it unnecessary to >> call skb_orphan_frags in pskb_expand_head when skb is cloned ? > >Please give us a real case. > >I fear that

Re: [PATCH] net: add missing skb_uarg refcount increment in pskb_carve_inside_header()

2020-08-15 Thread linmiaohe
Willem de Bruijn wrote: >On Fri, Aug 14, 2020 at 9:20 AM linmiaohe wrote: >> >> Willem de Bruijn wrote: >> >On Thu, Aug 13, 2020 at 2:16 PM Miaohe Lin wrote: >> >> >> >> If the skb is zcopied, we should increase the skb_uarg refcount >> >> before we involve skb_release_data(). See

Re: [PATCH] mm/gup_benchmark: use pin_user_pages for FOLL_LONGTERM flag

2020-08-15 Thread John Hubbard
On 8/15/20 5:20 AM, Barry Song wrote: According to Documentation/core-api/pin_user_pages.rst, FOLL_PIN is a prerequisite to FOLL_LONGTERM. Another way of saying that is, FOLL_LONGTERM is a specific case, more restrictive case of FOLL_PIN. Almost all kernel modules are using pin_user_pages()

Re: [PATCH] net: correct zerocopy refcnt with newly allocated UDP or RAW uarg

2020-08-15 Thread linmiaohe
Willem de Bruijn wrote: >On Fri, Aug 14, 2020 at 10:17 AM linmiaohe wrote: >> > >I don't think that can happen. > >The question is when this branch is false > >next = (u32)atomic_read(>sk_zckey); >if ((u32)(uarg->id + uarg->len) == next) { > >I cannot come up with

Re: [GIT PULL] A RISC-V Fix for 5.9

2020-08-15 Thread pr-tracker-bot
The pull request you sent on Sat, 15 Aug 2020 15:39:41 -0700 (PDT): > git://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux.git > tags/riscv-for-linus-5.9-mw1 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/d84835b118ed8c14c21fa056ca54014b2eff068b Thank you! --

Re: [GIT PULL] x86 fixes

2020-08-15 Thread pr-tracker-bot
The pull request you sent on Sat, 15 Aug 2020 13:45:52 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git > x86-urgent-2020-08-15 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/50f6c7dbd973092d8e5f3c89f29eb4bea19fdebd Thank you! -- Deet-doot-dot, I

Re: [GIT PULL] perf fixes

2020-08-15 Thread pr-tracker-bot
The pull request you sent on Sat, 15 Aug 2020 13:21:33 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git > perf-urgent-2020-08-15 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/7f5f5909bb0b26dcd309424da14bdf0c7e93 Thank you! -- Deet-doot-dot,

Re: [GIT PULL] locking fixes

2020-08-15 Thread pr-tracker-bot
The pull request you sent on Sat, 15 Aug 2020 13:13:23 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git > locking-urgent-2020-08-15 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/eb1319af4119c4936e02c879295e9fd4d50bbe3a Thank you! --

Re: [GIT PULL] SMB3 fixes

2020-08-15 Thread pr-tracker-bot
The pull request you sent on Sat, 15 Aug 2020 00:32:46 -0500: > git://git.samba.org/sfrench/cifs-2.6.git tags/5.9-rc-smb3-fixes-part2 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/f6513bd39c15af8f8a63b1fbfcb1bf4717241655 Thank you! -- Deet-doot-dot, I am a bot.

Re: [GIT PULL] arch/sh updates for 5.9

2020-08-15 Thread pr-tracker-bot
The pull request you sent on Sat, 15 Aug 2020 15:33:04 -0400: > git://git.libc.org/linux-sh tags/sh-for-5.9 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/5bbec3cfe376ed0014d9456a9be11d5ed75d587b Thank you! -- Deet-doot-dot, I am a bot.

Re: [GIT PULL] scheduler fixes

2020-08-15 Thread pr-tracker-bot
The pull request you sent on Sat, 15 Aug 2020 13:27:31 +0200: > git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git > sched-urgent-2020-08-15 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/1195d58f003bf84d37fc5c30017600e09ba567b2 Thank you! -- Deet-doot-dot,

Re: [GIT PULL] 9p update for 5.9-rc1

2020-08-15 Thread pr-tracker-bot
The pull request you sent on Sat, 15 Aug 2020 07:52:19 +0200: > https://github.com/martinetd/linux tags/9p-for-5.9-rc1 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/410520d07f5c66a6c1f3eb7ef2063d9bdd3d440b Thank you! -- Deet-doot-dot, I am a bot.

Re: Re: [GIT PULL] edac for v5.9 (part 2)

2020-08-15 Thread pr-tracker-bot
The pull request you sent on Sat, 15 Aug 2020 10:21:03 -0700: > git://git.kernel.org/pub/scm/linux/kernel/git/ras/ras.git > tags/edac_updates_for_5.9_pt2 has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/6ffdcde4ee9a20beda096dec664da89002610d7d Thank you! --

Re: [PATCH v2 2/2] scsi: ufs: no need to send one Abort Task TM in case the task in DB was cleared

2020-08-15 Thread Stanley Chu
On Tue, 2020-08-11 at 16:18 +0200, Bean Huo wrote: > From: Bean Huo > > If the bit corresponds to a task in the Doorbell register has been > cleared, no need to poll the status of the task on the device side > and to send an Abort Task TM. Instead, let it directly goto cleanup. > > Meanwhile,

Re: [PATCH] bpf: Convert to use the preferred fallthrough macro

2020-08-15 Thread linmiaohe
Yonghong Song wrote: >On 8/14/20 2:16 AM, Miaohe Lin wrote: >> Convert the uses of fallthrough comments to fallthrough macro. >> >> Signed-off-by: Miaohe Lin > >This is not a bug fix but rather an enhancement so not sure whether this >should push to bpf tree or wait until bpf-next. > >It may

Re: [PATCH] bpf: Convert to use the preferred fallthrough macro

2020-08-15 Thread linmiaohe
Andrii Nakryiko wrote: On Fri, Aug 14, 2020 at 2:58 AM Miaohe Lin wrote: >> >> Convert the uses of fallthrough comments to fallthrough macro. >> @@ -1794,7 +1794,7 @@ static bool cg_sockopt_is_valid_access(int off, int >> size, >> return prog->expected_attach_type == >>

Hello My Dearest

2020-08-15 Thread Mrs. Sophia Robin
Hello My Dearest Please I appeal to you to exercise a little patience and read through my mail carefully, I am contacting you personally for investment assistance and a long term business relationship in your Country. I am Mrs. Sophia Robin a citizen of the united state of America; I work in

[PATCH v5 08/10] crypto: hisilicon/qm - register callback function to 'pci_driver.shutdown'

2020-08-15 Thread Yang Shen
Since the drivers such as HPRE/SEC/ZIP do not implement 'pci_driver.shutdow', a RAS will be triggered at OS rebooting or shutting down as the hardware device is processing request. The log looks like this: NOTICE: [NimbusSecNodeType1]:[2372L]This is sec, Base = 0x14180 NOTICE:

[PATCH v5 07/10] crypto: hisilicon/qm - fix VF not available after PF FLR

2020-08-15 Thread Yang Shen
From: Shukun Tan When PF FLR, the hardware will actively trigger the VF FLR. Configuration space of VF needs to be saved and restored to ensure that it is available after the PF FLR. Fixes: 7ce396fa12a9("crypto: hisilicon - add FLR support") Signed-off-by: Shukun Tan Signed-off-by: Yang Shen

[PATCH v5 05/10] crypto: hisilicon/qm - fix event queue depth to 2048

2020-08-15 Thread Yang Shen
From: Shukun Tan Increasing depth of 'event queue' from 1024 to 2048, which equals to twice depth of 'completion queue'. It will fix the easily happened 'event queue overflow' as using 1024 queue depth for 'event queue'. Fixes: 263c9959c937("crypto: hisilicon - add queue management driver...")

[PATCH v5 00/10] crypto: hisilicon/qm - misc fixes

2020-08-15 Thread Yang Shen
This patchset fix some qm bugs: patch 1: store the string address before pass to 'strsep' patch 2: clear 'qp_status->used' when init the 'qp' patch 3: use 'dev_info_ratelimited' to avoid printk flooding. patch 4: fix the judgement of queue is full patch 7: save the vf configuration space to make

[PATCH v5 02/10] crypto: hisilicon/qm - clear used reference count when start qp

2020-08-15 Thread Yang Shen
From: Shukun Tan The used reference count is used for counting the number of 'sqe' which is under processing. This reference count should be cleared as starting 'qp', otherwise the 'used' will be messy when allocating this 'qp' again. Fixes: 5308f6600a39("crypto: hisilicon - QM memory

[PATCH v5 10/10] crypto: hisilicon/qm - fix the process of register algorithms to crypto

2020-08-15 Thread Yang Shen
When the devices are removed or not existing, the corresponding algorithms which are registered by 'hisi-zip' driver can't be used. Move 'hisi_zip_register_to_crypto' from 'hisi_zip_init' to 'hisi_zip_probe'. The algorithms will be registered to crypto only when there is device bind on the

[PATCH v5 01/10] crypto: hisilicon/qm - fix wrong release after using strsep

2020-08-15 Thread Yang Shen
From: Sihang Chen Save the string address before pass to strsep, release it at end. Because strsep will update the string address to point after the token. Fixes: c31dc9fe165d("crypto: hisilicon/qm - add DebugFS for xQC and...") Signed-off-by: Sihang Chen Signed-off-by: Yang Shen Reviewed-by:

[PATCH v5 04/10] crypto: hisilicon/qm - fix judgement of queue is full

2020-08-15 Thread Yang Shen
From: Hui Tang The queue depth is 1024, so the condition for judging the queue full should be 1023, otherwise the hardware cannot judge whether the queue is empty or full. Fixes: 263c9959c937("crypto: hisilicon - add queue management driver...") Signed-off-by: Hui Tang Signed-off-by: Yang Shen

[PATCH v5 06/10] crypto: hisilicon/qm - fix no stop reason when use 'hisi_qm_stop'

2020-08-15 Thread Yang Shen
Now, there are three reasons of stopping: 'NORMAL', 'SOFT_RESET' and 'FLR'. In order to keep this, explicitly pass the stop reason as an input parameter of 'hisi_qm_stop' function. Fixes: b67202e8ed30("crypto: hisilicon/qm - add state machine for QM") Signed-off-by: Shukun Tan Signed-off-by:

[PATCH v5 09/10] crypto: hisilicon/qm - fix the call trace when unbind device

2020-08-15 Thread Yang Shen
From: Weili Qian Call trace will appear in the Hisilicon crypto driver unbinding or disabling SRIOV during task running with TFMs on the corresponding function. The log looks like this: [ 293.908078] Call trace: [ 293.908080] __queue_work+0x494/0x548 [ 293.908081]

[PATCH v5 03/10] crypto: hisilicon/qm - fix print frequence in hisi_qp_send

2020-08-15 Thread Yang Shen
Requests will be sent continuously as resetting, which will cause 'printk' flooding. Using 'dev_info_ratelimited' can solve this problem well. Fixes: b67202e8ed30("crypto: hisilicon/qm - add state machine for QM") Signed-off-by: Yang Shen Reviewed-by: Zhou Wang ---

RE: POC: Alternative solution: Re: [PATCH 0/4] printk: reimplement LOG_CONT handling

2020-08-15 Thread David Laight
From: Joe Perches > Sent: 15 August 2020 00:52 ... > > This is why I think any discussion that says "people should buffer > > their lines themselves and we should get rid if pr_cont()" is > > fundamentally broken. > > > > Don't go down that hole. I won't take it. It's wrong. > > I don't think

[PATCH] ASoC: wm8962: Export DAC/ADC monomix switches

2020-08-15 Thread Sebastian Krzyszkowiak
This allows solutions like ALSA UCM to utilize hardware mono downmix for cases where mono output to a single speaker is desired only in specific situations (like on a mobile phone). Signed-off-by: Sebastian Krzyszkowiak --- sound/soc/codecs/wm8962.c | 2 ++ 1 file changed, 2 insertions(+) diff

Re: [PATCH v3 1/2] scsi: ufs: change ufshcd_comp_devman_upiu() to ufshcd_compose_devman_upiu()

2020-08-15 Thread Stanley Chu
On Fri, 2020-08-14 at 11:50 +0200, Bean Huo wrote: > From: Bean Huo > > ufshcd_comp_devman_upiu() alwasy make me confuse that it is a request > completion calling function. Change it to ufshcd_compose_devman_upiu(). > > Signed-off-by: Bean Huo > Acked-by: Avri Altman > --- Reviewed-by:

Re: [PATCH v3 2/2] scsi: ufs: remove several redundant goto statements

2020-08-15 Thread Stanley Chu
On Fri, 2020-08-14 at 11:50 +0200, Bean Huo wrote: > From: Bean Huo > > Signed-off-by: Bean Huo Reviewed-by: Stanley Chu

[PATCH] signalfd: Convert to use the preferred fallthrough macro

2020-08-15 Thread Miaohe Lin
Convert the uses of fallthrough comments to fallthrough macro. Signed-off-by: Miaohe Lin --- fs/signalfd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/signalfd.c b/fs/signalfd.c index 5b78719be445..456046e15873 100644 --- a/fs/signalfd.c +++ b/fs/signalfd.c @@ -176,7

[PATCH] genirq: Convert to use the preferred fallthrough macro

2020-08-15 Thread Miaohe Lin
Convert the uses of fallthrough comments to fallthrough macro. Signed-off-by: Miaohe Lin --- kernel/irq/manage.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c index d55ba625d426..375fcd78fdd3 100644 --- a/kernel/irq/manage.c

[PATCH] sched: Convert to use the preferred fallthrough macro

2020-08-15 Thread Miaohe Lin
Convert the uses of fallthrough comments to fallthrough macro. Signed-off-by: Miaohe Lin --- kernel/sched/topology.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c index 007b0a6b0152..1bd7e3af904f 100644 ---

Re: [PATCH] fs: NTFS read-write driver GPL implementation by Paragon Software.

2020-08-15 Thread Matthew Wilcox
On Sat, Aug 15, 2020 at 09:06:42PM +0200, David Sterba wrote: > There's maybe more I missed, but hopefully HTH. One thing you missed is adding support to fstests git://git.kernel.org/pub/scm/fs/xfs/xfstests-dev.git If it passes that torture test, I think we can have confidence that this is a

[PATCH v2] net: eliminate meaningless memcpy to data in pskb_carve_inside_nonlinear()

2020-08-15 Thread Miaohe Lin
The frags of skb_shared_info of the data is assigned in following loop. It is meaningless to do a memcpy of frags here. Signed-off-by: Miaohe Lin --- net/core/skbuff.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/net/core/skbuff.c b/net/core/skbuff.c index

[PATCH] net: handle the return value of pskb_carve_frag_list() correctly

2020-08-15 Thread Miaohe Lin
pskb_carve_frag_list() may return -ENOMEM in pskb_carve_inside_nonlinear(). we should handle this correctly or we would get wrong sk_buff. Fixes: 6fa01ccd8830 ("skbuff: Add pskb_extract() helper function") Signed-off-by: Miaohe Lin --- net/core/skbuff.c | 10 +++--- 1 file changed, 7

Re: [PATCH] Add missing bound checks for software 842 decompressor

2020-08-15 Thread Joan Bruguera
Any feedback? - Joan On 05.06.20 17:44, Joan Bruguera wrote: The software 842 decompressor receives, through the initial value of the 'olen' parameter, the capacity of the buffer pointed to by 'out'. If this capacity is insufficient to decode the compressed bitstream, -ENOSPC should be

[PATCH v2] bpf: Convert to use the preferred fallthrough macro

2020-08-15 Thread Miaohe Lin
Since commit 294f69e662d1 ("compiler_attributes.h: Add 'fallthrough' pseudo keyword for switch/case use") introduce fallthrough pseudo keyword, then we should convert the uses of fallthrough comments to it. Signed-off-by: Miaohe Lin --- kernel/bpf/cgroup.c | 1 - kernel/bpf/cpumap.c | 2 +-

Protecting uvcvideo againt USB device disconnect [Was: Re: Protecting usb_set_interface() against device removal]

2020-08-15 Thread Guenter Roeck
+ linux-uvc-de...@lists.sourceforge.net + linux-me...@vger.kernel.org + laurent.pinch...@ideasonboard.com and changed subject On Fri, Aug 14, 2020 at 10:07:39PM -0400, Alan Stern wrote: > On Fri, Aug 14, 2020 at 04:07:03PM -0700, Guenter Roeck wrote: > > Hi all, > > > > over time, there have

[PATCH] net: Fix potential wrong skb->protocol in skb_vlan_untag()

2020-08-15 Thread Miaohe Lin
We may access the two bytes after vlan_hdr in vlan_set_encap_proto(). So we should pull VLAN_HLEN + sizeof(unsigned short) in skb_vlan_untag() or we may access the wrong data. Fixes: 0d5501c1c828 ("net: Always untag vlan-tagged traffic on input.") Signed-off-by: Miaohe Lin --- net/core/skbuff.c

[PATCH] efi: discover ESRT table on Xen PV too

2020-08-15 Thread Marek Marczykowski-Górecki
In case of Xen PV dom0, Xen passes along info about system tables (see arch/x86/xen/efi.c), but not the memory map from EFI. This makes sense as it is Xen responsible for managing physical memory address space. In this case, it doesn't make sense to condition using ESRT table on availability of

Re: [PATCH v2] lib/string.c: implement stpcpy

2020-08-15 Thread Fangrui Song
On 2020-08-15, 'Nick Desaulniers' via Clang Built Linux wrote: On Sat, Aug 15, 2020 at 2:31 PM Joe Perches wrote: On Sat, 2020-08-15 at 14:28 -0700, Nick Desaulniers wrote: > On Sat, Aug 15, 2020 at 2:24 PM Joe Perches wrote: > > On Sat, 2020-08-15 at 13:47 -0700, Nick Desaulniers wrote: > >

Re: Protecting usb_set_interface() against device removal

2020-08-15 Thread Alan Stern
On Fri, Aug 14, 2020 at 04:07:03PM -0700, Guenter Roeck wrote: > Hi all, > > over time, there have been a number of reports of crashes in > usb_ifnum_to_if(), > called from usb_hcd_alloc_bandwidth, which is in turn called from > usb_set_interface(). > Examples are [1] [2] [3]. A typical

Re: [PATCH v5 5/6] can: ctucanfd: CTU CAN FD open-source IP core - platform/SoC support.

2020-08-15 Thread Randy Dunlap
On 8/15/20 12:43 PM, Pavel Pisa wrote: > diff --git a/drivers/net/can/ctucanfd/Kconfig > b/drivers/net/can/ctucanfd/Kconfig > index e1636373628a..a8c9cc38f216 100644 > --- a/drivers/net/can/ctucanfd/Kconfig > +++ b/drivers/net/can/ctucanfd/Kconfig > @@ -21,4 +21,15 @@ config CAN_CTUCANFD_PCI >

Re: [PATCH v5 3/6] can: ctucanfd: add support for CTU CAN FD open-source IP core - bus independent part.

2020-08-15 Thread Randy Dunlap
On 8/15/20 12:43 PM, Pavel Pisa wrote: > diff --git a/drivers/net/can/ctucanfd/Kconfig > b/drivers/net/can/ctucanfd/Kconfig > new file mode 100644 > index ..d8da44d7f926 > --- /dev/null > +++ b/drivers/net/can/ctucanfd/Kconfig > @@ -0,0 +1,15 @@ > +config CAN_CTUCANFD > + tristate

Re: [PATCH 1/2] PCI: rockchip: Work around missing device_type property in DT

2020-08-15 Thread Bjorn Helgaas
On Sat, Aug 15, 2020 at 01:51:11PM +0100, Marc Zyngier wrote: > Recent changes to the DT PCI bus parsing made it mandatory for > device tree nodes describing a PCI controller to have the > 'device_type = "pci"' property for the node to be matched. > > Although this follows the letter of the

[PATCH] media: mceusb: Avoid GFP_ATOMIC where it is not needed

2020-08-15 Thread Christophe JAILLET
There is no point in using GFP_ATOMIC here. It is a probe function, and GFP_KERNEL is already used the line before and the line after. Use GFP_KERNEL instead. Signed-off-by: Christophe JAILLET --- drivers/media/rc/mceusb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [PATCH AUTOSEL 5.7 52/60] dyndbg: prefer declarative init in caller, to memset in callee

2020-08-15 Thread Sasha Levin
On Tue, Aug 11, 2020 at 07:13:32AM +0200, Greg Kroah-Hartman wrote: On Mon, Aug 10, 2020 at 03:10:20PM -0400, Sasha Levin wrote: From: Jim Cromie [ Upstream commit 9c9d0acbe2793315fa6945a19685ad2a51fb281b ] ddebug_exec_query declares an auto var, and passes it to ddebug_parse_query, which

Re: [PATCH] netfilter: nf_conntrack_sip: fix parsing error

2020-08-15 Thread Florian Westphal
Tong Zhang wrote: > ct_sip_parse_numerical_param can only return 0 or 1, but the caller is > checking parsing error using < 0 Reviewed-by: Florian Westphal

Re: [PATCH] genksyms: keywords: Use __restrict not _restrict

2020-08-15 Thread Randy Dunlap
On 8/14/20 8:17 PM, Joe Perches wrote: > On Fri, 2020-08-14 at 20:05 -0700, Linus Torvalds wrote: >> On Fri, Aug 14, 2020 at 7:14 PM Nick Desaulniers >> wrote: >>> What's KAO? Urban dictionary has no entry. :^P >> >> It goes back to 2003 and the original keywords.gperf file, see >> >> >>

Re: [Freedreno] [PATCH v10 3/5] drm/msm/dp: add support for DP PLL driver

2020-08-15 Thread Rob Clark
On Sat, Aug 15, 2020 at 2:21 PM Jonathan Marek wrote: > > On 8/15/20 4:20 PM, Rob Clark wrote: > > On Fri, Aug 14, 2020 at 10:05 AM Dmitry Baryshkov > > wrote: > >> > >> > >> On 12/08/2020 07:42, Tanmay Shah wrote: > >> > From: Chandan Uddaraju > >> > > >> > Add the needed DP PLL specific

[GIT PULL] arch/sh updates for 5.9

2020-08-15 Thread Rich Felker
The following changes since commit bcf876870b95592b52519ed4aafcf9d95999bc9c: Linux 5.8 (2020-08-02 14:21:45 -0700) are available in the Git repository at: git://git.libc.org/linux-sh tags/sh-for-5.9 for you to fetch changes up to 0c64a0dce51faa9c706fdf1f957d6f19878f4b81: sh: landisk:

[PATCH v5 1/6] dt-bindings: vendor-prefix: add prefix for the Czech Technical University in Prague.

2020-08-15 Thread Pavel Pisa
The Czech Technical University in Prague (CTU) is one of the biggest and oldest (founded 1707) technical universities in Europe. The abbreviation in Czech language is ČVUT according to official name in Czech language České vysoké učení technické v Praze The English translation The Czech

[PATCH v5 2/6] dt-bindings: net: can: binding for CTU CAN FD open-source IP core.

2020-08-15 Thread Pavel Pisa
The device-tree bindings for open-source/open-hardware CAN FD IP core designed at the Czech Technical University in Prague. CTU CAN FD IP core and other CTU CAN bus related projects listing and documentation page http://canbus.pages.fel.cvut.cz/ Signed-off-by: Pavel Pisa ---

Re: [PATCH 1/2] mm: add GFP mask param to strndup_user

2020-08-15 Thread Al Viro
On Sat, Aug 15, 2020 at 11:23:43AM -0700, Pascal Bouchareine wrote: > Let caller specify allocation. > Preserve existing calls with GFP_USER. Bloody bad idea, unless you slap a BUG_ON(flags & GFP_ATOMIC) on it, to make sure nobody tries _that_. Note that copying from userland is an inherently

[PATCH v5 3/6] can: ctucanfd: add support for CTU CAN FD open-source IP core - bus independent part.

2020-08-15 Thread Pavel Pisa
From: Martin Jerabek This driver adds support for the CTU CAN FD open-source IP core. More documentation and core sources at project page (https://gitlab.fel.cvut.cz/canbus/ctucanfd_ip_core). The core integration to Xilinx Zynq system as platform driver is available

Re: [PATCH v5 1/9] RISC-V: Move DT mapping outof fixmap

2020-08-15 Thread Palmer Dabbelt
On Wed, 12 Aug 2020 16:47:50 PDT (-0700), Atish Patra wrote: From: Anup Patel Currently, RISC-V reserves 1MB of fixmap memory for device tree. However, it maps only single PMD (2MB) space for fixmap which leaves only < 1MB space left for other kernel features such as early ioremap which

Re: [PATCH v5 2/9] RISC-V: Add early ioremap support

2020-08-15 Thread Palmer Dabbelt
On Wed, 12 Aug 2020 16:47:51 PDT (-0700), Atish Patra wrote: UEFI uses early IO or memory mappings for runtime services before normal ioremap() is usable. Add the necessary fixmap bindings and pmd mappings for generic ioremap support to work. Signed-off-by: Atish Patra --- arch/riscv/Kconfig

[GIT PULL] A RISC-V Fix for 5.9

2020-08-15 Thread Palmer Dabbelt
merged tag 'riscv-for-linus-5.9-mw0' The following changes since commit dbf83817315d9ce93b3e5b1c83a167f537245bd8: Merge tag 'riscv-for-linus-5.9-mw0' of git://git.kernel.org/pub/scm/linux/kernel/git/riscv/linux (2020-08-07 10:11:12 -0700) are available in the Git repository at:

Re: [audit] c4dad0aab3: canonical_address#:#[##]

2020-08-15 Thread Paul Moore
On Fri, Aug 14, 2020 at 7:09 PM Richard Guy Briggs wrote: > On 2020-08-09 14:36, kernel test robot wrote: > > Greeting, > > > > FYI, we noticed the following commit (built with clang-12): > > > > commit: c4dad0aab3fca0c1f0baa4cc84b6ec91b7ebf426 ("audit: tidy and extend > > netfilter_cfg

[PATCH v5 4/6] can: ctucanfd: CTU CAN FD open-source IP core - PCI bus support.

2020-08-15 Thread Pavel Pisa
PCI bus adaptation for CTU CAN FD open-source IP core. The project providing FPGA design for Intel EP4CGX15 based DB4CGX15 PCIe board with PiKRON.com designed transceiver riser shield is available at https://gitlab.fel.cvut.cz/canbus/pcie-ctu_can_fd . Signed-off-by: Pavel Pisa Signed-off-by:

Re: [PATCH 3/3] drm/panel: Add panel driver for the Mantix MLAF057WE51-X DSI panel

2020-08-15 Thread Sam Ravnborg
On Sat, Aug 15, 2020 at 12:40:22PM +0200, Guido Günther wrote: > Hi Sam, > On Sat, Aug 15, 2020 at 12:02:30PM +0200, Sam Ravnborg wrote: > > Hi Guido. > > > > > +static int mantix_probe(struct mipi_dsi_device *dsi) > > > +{ > > > + struct device *dev = >dev; > > > + struct mantix *ctx; > > > +

[PATCH v8 2/2] devicetree: hwmon: shtc1: add sensirion,shtc1.yaml

2020-08-15 Thread Chris Ruehl
Add documentation for the newly added DTS support in the shtc1 driver. To align with the drivers logic to have high precision by default a boolean sensirion,low-precision is used to switch to low precision. Signed-off-by: Chris Ruehl --- .../bindings/hwmon/sensirion,shtc1.yaml | 61

[PATCH v8 1/2] hwmon: shtc1: add support for device tree bindings

2020-08-15 Thread Chris Ruehl
Add support for DTS bindings for the sensirion shtc1,shtw1 and shtc3. Signed-off-by: Chris Ruehl Reviewed-by: Guenter Roeck --- v8: no change drivers/hwmon/shtc1.c | 25 ++--- 1 file changed, 22 insertions(+), 3 deletions(-) diff --git a/drivers/hwmon/shtc1.c

[PATCH v8 0/2] shtc1: add support for device tree bindings

2020-08-15 Thread Chris Ruehl
Add support for DTS bindings to the shtc driver The patches add the compatible table and of_property_read_bool to the shtc1.c. Newly created Yaml document has been released to the Documentation/devicetree/hwmon/sensirion,shtc1.yaml Signed-off-by: Chris Ruehl --- Version 8

[PATCH v5 5/6] can: ctucanfd: CTU CAN FD open-source IP core - platform/SoC support.

2020-08-15 Thread Pavel Pisa
Platform bus adaptation for CTU CAN FD open-source IP core. The core has been tested together with OpenCores SJA1000 modified to be CAN FD frames tolerant on MicroZed Zynq based MZ_APO education kits designed by Petr Porazil from PiKRON.com company. FPGA design

Re: KASAN: out-of-bounds Read in pebs_update_state

2020-08-15 Thread syzbot
syzbot suspects this issue was fixed by commit: commit 033724d6864245a11f8e04c066002e6ad22b3fd0 Author: Tetsuo Handa Date: Wed Jul 15 01:51:02 2020 + fbdev: Detect integer underflow at "struct fbcon_ops"->clear_margins. bisection log:

Re: [PATCH 3/3] drm/panel: Add panel driver for the Mantix MLAF057WE51-X DSI panel

2020-08-15 Thread Sam Ravnborg
Hi Guido. On Fri, Aug 14, 2020 at 03:36:23PM +0200, Guido Günther wrote: > The panel uses a Focaltech FT8006p, the touch part is handled by the > already existing edt-ft5x06. > > Signed-off-by: Guido Günther Looks good. A few notes in the following, nothing major. Sam > --- >

Re: [PATCH v2] lib/string.c: implement stpcpy

2020-08-15 Thread Joe Perches
On Fri, 2020-08-14 at 19:09 -0700, Nick Desaulniers wrote: > LLVM implemented a recent "libcall optimization" that lowers calls to > `sprintf(dest, "%s", str)` where the return value is used to > `stpcpy(dest, str) - dest`. This generally avoids the machinery involved > in parsing format strings.

Re: [PATCH 0/5] drm/panel: A few cleanups and improvements

2020-08-15 Thread Sam Ravnborg
Hi Paul. On Tue, Aug 11, 2020 at 02:22:35AM +0200, Paul Cercueil wrote: > Hi list, > > Here's a list of 5 patches that bring some cleanups and improvements. > > Patches 1-2 clean up the novatek,nt39016 code to remove custom handling > of the backlight and to add the missing carriage returns on

[tip: perf/urgent] perf/x86/intel/uncore: Add BW counters for GT, IA and IO breakdown

2020-08-15 Thread tip-bot2 for Vaibhav Shankar
The following commit has been merged into the perf/urgent branch of tip: Commit-ID: 24633d901ea44fe99bc9a2d01a3881fa097b78b3 Gitweb: https://git.kernel.org/tip/24633d901ea44fe99bc9a2d01a3881fa097b78b3 Author:Vaibhav Shankar AuthorDate:Thu, 13 Aug 2020 19:22:34 -07:00

Re: [PATCH 3/3] drm/panel: Add panel driver for the Mantix MLAF057WE51-X DSI panel

2020-08-15 Thread Guido Günther
Hi Sam, On Sat, Aug 15, 2020 at 12:02:30PM +0200, Sam Ravnborg wrote: > Hi Guido. > > > +static int mantix_probe(struct mipi_dsi_device *dsi) > > +{ > > + struct device *dev = >dev; > > + struct mantix *ctx; > > + int ret; > > + > > + ctx = devm_kzalloc(dev, sizeof(*ctx), GFP_KERNEL); > >

Re: [PATCH 3/3] drm/panel: Add panel driver for the Mantix MLAF057WE51-X DSI panel

2020-08-15 Thread Sam Ravnborg
Hi Guido. > > In fact I did decided against it since i was told that missing dev_* and > > DRM_* logging shouldn't be done. So is that o.k. nowadays? > s/missing/mixing/ > > I often request that logging is consistent - so I recognize the > argument. > > For panel/* I have not made up my mind

[PATCH] staging: r8188eu: remove unnecessary type cast of rtw_netdev_priv() result

2020-08-15 Thread Ivan Safonov
The type cast padapter = (struct adapter *)rtw_netdev_priv(dev); do nothing because type of rtw_netdev_priv() result is (struct adapter *). Signed-off-by: Ivan Safonov --- drivers/staging/rtl8188eu/core/rtw_debug.c| 8 +- drivers/staging/rtl8188eu/core/rtw_pwrctrl.c | 2 +-

[PATCH RESEND] docs: update trusted-encrypted.rst

2020-08-15 Thread colyli
From: Coly Li The parameters in tmp2 commands are outdated, people are not able to create trusted key by the example commands. This patch updates the paramerters of tpm2 commands, they are verified by tpm2-tools-4.1 with Linux v5.8 kernel. Signed-off-by: Coly Li Cc: Dan Williams Cc: James

[PATCH RESEND] docs: update trusted-encrypted.rst

2020-08-15 Thread Coly Li
The parameters in tmp2 commands are outdated, people are not able to create trusted key by the example commands. This patch updates the paramerters of tpm2 commands, they are verified by tpm2-tools-4.1 with Linux v5.8 kernel. Signed-off-by: Coly Li Cc: Dan Williams Cc: James Bottomley Cc:

[PATCH 1/3] net: introduce helper sendpage_ok() in include/linux/net.h

2020-08-15 Thread Coly Li
The original problem was from nvme-over-tcp code, who mistakenly uses kernel_sendpage() to send pages allocated by __get_free_pages() without __GFP_COMP flag. Such pages don't have refcount (page_count is 0) on tail pages, sending them by kernel_sendpage() may trigger a kernel panic from a

[PATCH 2/3] nvme-tcp: check page by sendpage_ok() before calling kernel_sendpage()

2020-08-15 Thread Coly Li
Currently nvme_tcp_try_send_data() doesn't use kernel_sendpage() to send slab pages. But for pages allocated by __get_free_pages() without __GFP_COMP, which also have refcount as 0, they are still sent by kernel_sendpage() to remote end, this is problematic. The new introduced helper

[PATCH 3/3] drbd: code cleanup by using sendpage_ok() to check page for kernel_sendpage()

2020-08-15 Thread Coly Li
In _drbd_send_page() a page is checked by following code before sending it by kernel_sendpage(), (page_count(page) < 1) || PageSlab(page) If the check is true, this page won't be send by kernel_sendpage() and handled by sock_no_sendpage(). This kind of check is exactly what macro

Re: [PATCH 3/3] drm/panel: Add panel driver for the Mantix MLAF057WE51-X DSI panel

2020-08-15 Thread Guido Günther
Hi, On Sat, Aug 15, 2020 at 12:46:51PM +0200, Sam Ravnborg wrote: > On Sat, Aug 15, 2020 at 12:40:22PM +0200, Guido Günther wrote: > > Hi Sam, > > On Sat, Aug 15, 2020 at 12:02:30PM +0200, Sam Ravnborg wrote: > > > Hi Guido. > > > > > > > +static int mantix_probe(struct mipi_dsi_device *dsi) > >

Re: [PATCH v2] lib/string.c: implement stpcpy

2020-08-15 Thread Nick Desaulniers
On Sat, Aug 15, 2020 at 2:31 PM Joe Perches wrote: > > On Sat, 2020-08-15 at 14:28 -0700, Nick Desaulniers wrote: > > On Sat, Aug 15, 2020 at 2:24 PM Joe Perches wrote: > > > On Sat, 2020-08-15 at 13:47 -0700, Nick Desaulniers wrote: > > > > On Sat, Aug 15, 2020 at 9:34 AM Kees Cook wrote: > >

RE: [PATCH] lib/string.c: implement stpcpy

2020-08-15 Thread David Laight
From: Nick Desaulniers > Sent: 15 August 2020 01:24 > > LLVM implemented a recent "libcall optimization" that lowers calls to > `sprintf(dest, "%s", str)` where the return value is used to > `stpcpy(dest, str) - dest`. This generally avoids the machinery involved > in parsing format strings. > >

Re: [PATCH v2] x86/boot/compressed: Disable relocation relaxation

2020-08-15 Thread Nick Desaulniers
Hi Ingo, I saw you picked up Arvind's other series into x86/boot. Would you mind please including this, as well? Our CI is quite red for x86... EOM On Sat, Aug 15, 2020 at 8:49 AM Sedat Dilek wrote: > > On Wed, Aug 12, 2020 at 2:43 AM Arvind Sankar wrote: > > > > The x86-64 psABI [0]

  1   2   3   4   >